- User Since
- Sep 2 2015, 11:58 AM (377 w, 5 d)
Fri, Nov 18
Thanks for the fix.
Thu, Nov 17
To me, it appears there are two outstanding issues that we need to solve. One is that we use large pages by default. Without hugify/hottext it doesn't make sense unless dynamic loader supports large pages. The second issue is that we align .text regardless of how many bytes it takes, leading sometimes to ~2MB "waste". Just using 64-byte alignment and relying on the containing segment being aligned to the page size will not always work. One example of the latter is "-use-old-text". I think using the MaxAlignBytes might be better suited to address this issue. What do you think?
Tue, Nov 15
Thu, Nov 3
Oct 27 2022
Oct 26 2022
@treapster, could you post a detailed description of your plans (or an RFC) to discourse? It’s possible I’m missing details of what you are planning to do.
Oct 25 2022
@hoy, Amir will migrate the internal pseudo-probe tests. That should enable you to add/modify the test for this change.
Oct 24 2022
Oct 21 2022
Looks good. There's a couple of styling nits. You might need to run arc with --verbatim to update Title and Summary fields.
There are a couple more uses of std::*map<> left that could be converted to maps from LLVM's ADT.
Oct 20 2022
Is this change going to be tested in the parent diff or otherwise?
Oct 19 2022
Oct 18 2022
Oct 17 2022
Since the erroneous condition could be triggered by a bad input, we should replace the assertion with an error.
Oct 13 2022
Fix section read-only check. Remove mapExtraSections().
Address comments by Rafael.
Oct 12 2022
One nit and one comment. Otherwise, LGTM.
Oct 10 2022
Oct 7 2022
Add "[BOLT]" to the title. Replace "this code" in the Summary with the description of the code. Otherwise LGTM.
Part of https://reviews.llvm.org/D135494
Oct 5 2022
Fix MachO. Add a test case.
Oct 4 2022
Oct 3 2022
Sep 20 2022
Sep 19 2022
Sep 16 2022
Can you s/ProfileOutput/ProfileFormat/g and s/profile-output/profile-format/g?
Change SmallVector size for AllocatedSections.
Don't free memory allocated by EFMM.
Sep 15 2022
LGTM, but please rename the method before the commit.
Sep 8 2022
This looks good to me. Thanks! I don't think there was any strong reason to enforce the type of encoding in the first place other than simplicity of the implementation.
Looks good to me. Please fix grammar in "Summary" before committing.
Sep 7 2022
Sep 6 2022
Do you expect this test to fail as it is in the stack?
Sep 1 2022
Aug 25 2022