- User Since
- Oct 10 2017, 8:01 AM (119 w, 3 d)
Wed, Jan 22
Thanks for the fix! Looks good to me!
Tue, Jan 21
Wed, Jan 15
- Move the setting of parameters of FunctionProtoTypeLoc to TypeLocImporter
- Add tests for TypeLoc import in case of functions
Tue, Jan 14
Fri, Jan 10
Related commit that moves to alpha:
- Declare ElementCountNL in if stmt
- Use makeArrayIndex instead makeIntVal
Can we enable the check by default then? What pieces are missing? Like, the symbolic extent/offset case is not a must. I think we have everything except maybe some deeper testing. I'd rather spend some time on the above exercise, but then enable by default if it goes well.
Thu, Jan 9
- Add documentation to checkers.rst
- Pass CheckerContext as last param
- Use BugType and default member initializer
Tue, Jan 7
Dec 20 2019
- Better handling of unknown values
- Bugtype by value
- Decompose Place to base region and offset
- Add test for type hierarchy
- Remove State check
- Return directly with the size of the type in case of non-array new
- Use Optional for ElementCount
- Update warning message
Thank you guys for the assiduous review!
Dec 19 2019
Dec 18 2019
Recommited in bc5b7e21e32 . I changed llvm:is_contained to a simple for loop over the lookup result. This way the copy assignment of the iterator is avoided even if windows STL is used.
Dec 17 2019
I'm curious what you think should happen to the clang-import-test. We could either rewrite the tests as unit tests in the ASTImporterTest you guys are already using or we move the necessary parts of the ExternalASTMerger into the clang-import-test
Dec 16 2019
Simplify getRecordDeclOfFriend() further.
Dec 12 2019
Addressing Alexeis comments.
Are you going to add any tests in the following patches?
I don't have any tests for now, but in a later patch we can create them.
Just one more thing, maybe that is too overkill, but I think on a long term we could benefit from a unittest for this case. You could create a test similar to LLDBLookupTest in ASTImporterTest.cpp. In that Fixture we use Minimal import and the regular lookup (that is the exact case in LLDB).
In the test itself we could call ImportDefinition on a struct that has fields with record types. And then we could assert that all field's type's have complete types.
Thanks for the patch! It look almost good to me, but I have a comment about the error handling.
Dec 7 2019
Dec 6 2019
Put back the menu, add "open source" property.
Thanks for addressing this, I just have some minor comments.
Dec 5 2019
Addressing Artem's review comments.
Artem, thanks for the review!
IMPORT -> IMPORT_TYPE_LOC
Dec 4 2019
Dec 3 2019
LGTM, but wait for others please.
Dec 2 2019
Alexei, thanks for the assiduous review!
- Address Alexei's comments
Nov 28 2019
Nov 19 2019
Nov 14 2019
Nov 5 2019
Oct 30 2019
Oct 29 2019
Oct 9 2019
Oct 8 2019
Oct 7 2019
Oct 3 2019
Oct 2 2019
With [modern-type-lookup], we completely evade the use of ASTImporterDelegate? That would be a wonderful thing to use only the the ExternalASTMerger on a long term...
Oct 1 2019
Raphael, thanks for working on this. Overall, the changes look good to me, but please see my comment for the constructor.
Sep 24 2019
Sep 23 2019
2nd attempt to fix the windows build errors: 372646
Trying to fix in svn commit 372633.