Just added a new entry to our roadmap: https://github.com/Ericsson/clang/issues/435

CallEvent::getRuntimeDefinition is overwritten in

• AnyFunctionCall
• CXXInstanceCall
• CXXMemberCall
• CXXDestructorCall
• ObjCMethodCall

• Add comment about structural eq and BFS

Ok, thanks Aleksei for the review. I added the explanation as file comments into StructuralEquivalence.cpp.

Remove unneeded assert

RecordDecl* -> RecordDecl *

Hi Aleksei,

Address review comments

I apologize for the delay in reviewing patches.

Closed in favor of https://reviews.llvm.org/D47632

Hi Aleksei, could you pleas take an other quick look, there were only minor changes since your last comments. Thanks!

@gerazo, Do you have commit rights, or should I help with the commit?

Ping

Ping.

Address review comments

Fix indentation

• Rebase from master
• Enable some disabled tests
• Update the isUsed flag
• Add a new config Minimal to the structural eq check, so lldb tests can pass now
• Return with a bool value and use LLVM_NODISCARD in CreateDecl
• Rename CreateDecl

LGTM!

PrevDecl is set after the !SearchName branch, as it had been done before.
This way original behaviour is kept as much as possible.

Remove redundant code and use only StructurlaEquivalence

I have a strong feeling of duplication with attribute and flags merging move in D47632. Maybe it is better to be resolved in that review by using the same code for attr/flag merging for both newly-created and mapped decls?

I realized that, this patch brakes 3 lldb tests ATM:

• TestTopLevelExprs.py. If https://reviews.llvm.org/D48722 was merged then this test would not be broken.
• TestPersistentTypes.py If https://reviews.llvm.org/D48773 was merged then this test would not be broken.
• TestRecursiveTypes.py. I am still working on this. The newly introduced assert fires: Assertion (Pos == ImportedDecls.end() || Pos->second == To) && "Try to import an already imported Decl"' failed.`.

The broken lldb tests are fixed with a minor change. We no longer load the Decls from the
external source during the call of DeclContext::containsDecl. A new function
DeclContext::containsDeclAndLoad is added which does a load and calls
containsDecl.

This is not trivial to fix. Reverting until we can reproduce and fix it.
Reverted with commit: r335491

@labath
Sure, looking into it.

• Rebase from master.

• Address review comments

• Update commit comment and fix broken format in a comment.

I addressed the comments, thanks for the review!

• Clang format the test code snippet.

In D47698#1140629, @thakis wrote:

This code is live when reading pchs, correct? Does this have any measurable perf impact on deserializing pchs for, say, Cocoa.h or Windows.h?

Adding @balazske and @xazax.hun as reviewers. I think if it gets one more approve then we could merge. I'd like to speed up the things here ... we can't expect Aleksei to review all those many patches we sent lately.

• Addressing Alexei's comments.

Ping.

This patch is really useful and LGTM!
Just found some minor things.

LGTM, just found some minor things.

Are you OK with incremental review?

I just wanted to give a detailed justification about why we should import the
whole redecl chain. Consider the following code:

void f(); // prototype
void f() { f(); }

Currently, when we import the prototype we end up having two independent
functions with definitions:

TranslationUnitDecl 0x25214c8 <<invalid sloc>> <invalid sloc>
|
|-FunctionDecl 0x255e3e8 <input.cc:1:11, col:27> col:16 f 'void ()'
| `-CompoundStmt 0x255e4f0 <col:20, col:27>
|   `-CallExpr 0x255e4c8 <col:22, col:24> 'void'
|     `-ImplicitCastExpr 0x255e4b0 <col:22> 'void (*)()' <FunctionToPointerDecay>
|       `-DeclRefExpr 0x255e488 <col:22> 'void ()' lvalue Function 0x255e3e8 'f' 'void ()'
`-FunctionDecl 0x255e300 <col:1, col:27> col:6 f 'void ()'
  `-CompoundStmt 0x255e570 <col:20, col:27>
    `-CallExpr 0x255e548 <col:22, col:24> 'void'
      `-ImplicitCastExpr 0x255e530 <col:22> 'void (*)()' <FunctionToPointerDecay>
        `-DeclRefExpr 0x255e508 <col:22> 'void ()' lvalue Function 0x255e3e8 'f' 'void ()'

• Add a missing "else"

• Remove unused RunOptions typedef and isCXX function

• Remove unused function

Balazs, could you please review this patch as well? (This code is not in our fork yet.)