Page MenuHomePhabricator

martong (Gabor Marton)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2017, 8:01 AM (89 w, 7 h)

Recent Activity

Today

martong added inline comments to D62376: [ASTImporter] Mark erroneous nodes in shared st.
Tue, Jun 25, 7:21 AM · Restricted Project
martong updated the diff for D62376: [ASTImporter] Mark erroneous nodes in shared st.
  • Encapsulate by adding addDeclToLookup and removeDeclFromLookup to the shared state
Tue, Jun 25, 7:21 AM · Restricted Project
martong added a reviewer for D62376: [ASTImporter] Mark erroneous nodes in shared st: balazske.
Tue, Jun 25, 6:54 AM · Restricted Project
martong updated the diff for D62376: [ASTImporter] Mark erroneous nodes in shared st.
  • Set error for FromD if it maps to an existing Decl which has an error set
Tue, Jun 25, 6:49 AM · Restricted Project
martong updated the diff for D62376: [ASTImporter] Mark erroneous nodes in shared st.
  • Add FIXMEs
  • Set error for FromD if it maps to an existing Decl which has an error set
  • Add test
Tue, Jun 25, 6:37 AM · Restricted Project
martong added inline comments to D62375: [ASTImporter] Mark erroneous nodes in from ctx.
Tue, Jun 25, 2:34 AM · Restricted Project
martong added a comment to D62373: [ASTImporter] Store import errors for Decls.

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29310/ is green.

Tue, Jun 25, 1:51 AM · Restricted Project, Restricted Project
martong committed rG303c9861e90c: [ASTImporter] Store import errors for Decls (authored by martong).
[ASTImporter] Store import errors for Decls
Tue, Jun 25, 1:07 AM
martong committed rL364279: [ASTImporter] Store import errors for Decls.
[ASTImporter] Store import errors for Decls
Tue, Jun 25, 1:05 AM
martong closed D62373: [ASTImporter] Store import errors for Decls.
Tue, Jun 25, 1:04 AM · Restricted Project, Restricted Project
martong added a comment to D62373: [ASTImporter] Store import errors for Decls.

@shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic about the error handling only, so I'd expect to have regression only if we had testcases in lldb for erroneous cases, but apparently there are no such tests.

Tue, Jun 25, 1:04 AM · Restricted Project, Restricted Project

Yesterday

martong added inline comments to D62375: [ASTImporter] Mark erroneous nodes in from ctx.
Mon, Jun 24, 10:19 AM · Restricted Project
martong added inline comments to D62375: [ASTImporter] Mark erroneous nodes in from ctx.
Mon, Jun 24, 10:19 AM · Restricted Project
martong updated the diff for D62375: [ASTImporter] Mark erroneous nodes in from ctx.
  • Use make_scope_exit
  • Make hasCycleAtBack const
Mon, Jun 24, 10:19 AM · Restricted Project
martong updated the diff for D63603: [ASTImporter] Propagate error from ImportDeclContext.
  • Use make_scope_exit
  • Add test ErrorIsNotPropagatedFromMemberToNamespace
Mon, Jun 24, 9:59 AM · Restricted Project
martong added inline comments to D63603: [ASTImporter] Propagate error from ImportDeclContext.
Mon, Jun 24, 9:59 AM · Restricted Project
martong added inline comments to D62375: [ASTImporter] Mark erroneous nodes in from ctx.
Mon, Jun 24, 9:44 AM · Restricted Project
martong updated the diff for D62375: [ASTImporter] Mark erroneous nodes in from ctx.
  • Add back an assertion in setImportDeclError(), remove the condition in Import()
Mon, Jun 24, 9:43 AM · Restricted Project
martong updated the diff for D62375: [ASTImporter] Mark erroneous nodes in from ctx.
  • Remove the macro and use std::string.op+
  • We may set up an error twice in case of a cycle, thus remove the assert
Mon, Jun 24, 8:45 AM · Restricted Project
martong updated the diff for D63603: [ASTImporter] Propagate error from ImportDeclContext.
  • Remove the macro and use std::string.op+
Mon, Jun 24, 8:33 AM · Restricted Project
martong added inline comments to D62373: [ASTImporter] Store import errors for Decls.
Mon, Jun 24, 8:07 AM · Restricted Project, Restricted Project
martong updated the diff for D62373: [ASTImporter] Store import errors for Decls.
  • Assert that we set the error only once
  • Remove the macro and use std::string.op+
Mon, Jun 24, 8:01 AM · Restricted Project, Restricted Project
martong added inline comments to D62373: [ASTImporter] Store import errors for Decls.
Mon, Jun 24, 3:15 AM · Restricted Project, Restricted Project
martong added a comment to D62375: [ASTImporter] Mark erroneous nodes in from ctx.

I think I still owe you some explanation about this patch.
I do consider this patch as one of the most intricate patches regarding ASTImporter.
I'd like to answer the following questions in this comment:
What is an ImportPath and why do we need to track it?
What does it mean if we have a cycle in the import path?
How do we use these cycles during the error handling?

Mon, Jun 24, 2:54 AM · Restricted Project

Fri, Jun 21

martong added a reviewer for D62375: [ASTImporter] Mark erroneous nodes in from ctx: balazske.
Fri, Jun 21, 9:36 AM · Restricted Project
martong added a comment to D62376: [ASTImporter] Mark erroneous nodes in shared st.

Thanks for the review!
I have provided test cases for the 3 previous patches on which this one depends on. I will provide additional tests next week for this one, and of course will address the other comments.

Fri, Jun 21, 9:34 AM · Restricted Project
martong added a comment to D62375: [ASTImporter] Mark erroneous nodes in from ctx.

Thank you for the review, I have added a test which demonstrates the changes.
By tracking the import paths and cycles we implement a very strict error handling mechanism, but this seems to be the way to avoid reaching any faulty AST nodes for the ASTImporter clients.

Fri, Jun 21, 9:28 AM · Restricted Project
martong updated the diff for D62375: [ASTImporter] Mark erroneous nodes in from ctx.
  • Add test ErrorPropagatesThroughImportCycles
  • Change existing test to new behaviour
Fri, Jun 21, 9:24 AM · Restricted Project
martong updated the diff for D62373: [ASTImporter] Store import errors for Decls.
  • Remove unused include and using
Fri, Jun 21, 9:20 AM · Restricted Project, Restricted Project
martong updated the diff for D63603: [ASTImporter] Propagate error from ImportDeclContext.
  • Remove formatv b/c it can't handle braces in code
Fri, Jun 21, 9:17 AM · Restricted Project
martong updated the diff for D62373: [ASTImporter] Store import errors for Decls.
  • Remove formatv b/c it can't handle braces in code
Fri, Jun 21, 9:15 AM · Restricted Project, Restricted Project
martong added a reviewer for D63603: [ASTImporter] Propagate error from ImportDeclContext: balazske.
Fri, Jun 21, 1:41 AM · Restricted Project
martong added a reviewer for D62373: [ASTImporter] Store import errors for Decls: balazske.
Fri, Jun 21, 1:41 AM · Restricted Project, Restricted Project

Thu, Jun 20

martong updated the diff for D62373: [ASTImporter] Store import errors for Decls.
  • Remove unrelated change
Thu, Jun 20, 7:55 AM · Restricted Project, Restricted Project
martong added inline comments to D62373: [ASTImporter] Store import errors for Decls.
Thu, Jun 20, 7:54 AM · Restricted Project, Restricted Project
martong updated the diff for D62373: [ASTImporter] Store import errors for Decls.
  • Test error values are set for AST nodes
Thu, Jun 20, 7:44 AM · Restricted Project, Restricted Project
martong added a child revision for D63603: [ASTImporter] Propagate error from ImportDeclContext: D62375: [ASTImporter] Mark erroneous nodes in from ctx.
Thu, Jun 20, 7:41 AM · Restricted Project
martong added a child revision for D62373: [ASTImporter] Store import errors for Decls: D63603: [ASTImporter] Propagate error from ImportDeclContext.
Thu, Jun 20, 7:41 AM · Restricted Project, Restricted Project
martong added a parent revision for D63603: [ASTImporter] Propagate error from ImportDeclContext: D62373: [ASTImporter] Store import errors for Decls.
Thu, Jun 20, 7:41 AM · Restricted Project
martong added a parent revision for D62375: [ASTImporter] Mark erroneous nodes in from ctx: D63603: [ASTImporter] Propagate error from ImportDeclContext.
Thu, Jun 20, 7:41 AM · Restricted Project
martong created D63603: [ASTImporter] Propagate error from ImportDeclContext.
Thu, Jun 20, 7:41 AM · Restricted Project

Mon, Jun 17

martong added a comment to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

About the regression of TestFormatters.py: I realized that the problem is about the wrong implementation of the ExternalASTSource interface.
In the implementation of FindExternalLexicalDecls of this interface, we simply ignored those cases when the given predicate (passed as a param) is false. When that happens, that means we still have some more external decls which should be dug up by the upcoming calls of DeclContext::lookup. The fix is about to indicate this.

Mon, Jun 17, 9:10 AM · Restricted Project, Restricted Project
martong updated the diff for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
  • Fix regression of TestFormatters.py
Mon, Jun 17, 8:57 AM · Restricted Project, Restricted Project

Tue, Jun 11

martong committed rGdd2b76e13eb8: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable (authored by martong).
[ASTImporter] Fix unhandled cases in ASTImporterLookupTable
Tue, Jun 11, 6:34 AM
martong committed rL363062: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
[ASTImporter] Fix unhandled cases in ASTImporterLookupTable
Tue, Jun 11, 6:32 AM
martong closed D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
Tue, Jun 11, 6:32 AM · Restricted Project, Restricted Project
martong updated the diff for D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
  • Simplify getRecordDeclOfFriend
Tue, Jun 11, 6:25 AM · Restricted Project, Restricted Project
martong added inline comments to D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
Tue, Jun 11, 6:25 AM · Restricted Project, Restricted Project

May 24 2019

martong added a child revision for D62375: [ASTImporter] Mark erroneous nodes in from ctx: D62376: [ASTImporter] Mark erroneous nodes in shared st.
May 24 2019, 3:25 AM · Restricted Project
martong added a parent revision for D62376: [ASTImporter] Mark erroneous nodes in shared st: D62375: [ASTImporter] Mark erroneous nodes in from ctx.
May 24 2019, 3:25 AM · Restricted Project
martong created D62376: [ASTImporter] Mark erroneous nodes in shared st.
May 24 2019, 3:24 AM · Restricted Project
martong added a parent revision for D62375: [ASTImporter] Mark erroneous nodes in from ctx: D62373: [ASTImporter] Store import errors for Decls.
May 24 2019, 2:59 AM · Restricted Project
martong added a child revision for D62373: [ASTImporter] Store import errors for Decls: D62375: [ASTImporter] Mark erroneous nodes in from ctx.
May 24 2019, 2:59 AM · Restricted Project, Restricted Project
martong created D62375: [ASTImporter] Mark erroneous nodes in from ctx.
May 24 2019, 2:56 AM · Restricted Project
martong updated the summary of D62373: [ASTImporter] Store import errors for Decls.
May 24 2019, 2:49 AM · Restricted Project, Restricted Project
martong created D62373: [ASTImporter] Store import errors for Decls.
May 24 2019, 2:33 AM · Restricted Project, Restricted Project
martong accepted D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName.

Looks good, thank you!

May 24 2019, 1:32 AM · Restricted Project

May 23 2019

martong created D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr.
May 23 2019, 9:15 AM · Restricted Project

May 22 2019

martong added a comment to D59467: [clang] Adding the Likelihood Attribute from C++2a.

The ASTImporter.cpp looks good to me. (Becasue the BranchHint is a simple an enum, so we don't need to specifically import that as we would in case of e.g. an Expr.)

May 22 2019, 2:15 AM · Restricted Project
martong committed rG37e6bf106c2a: Add AST logging (authored by martong).
Add AST logging
May 22 2019, 2:09 AM
martong committed rLLDB361362: Add AST logging.
Add AST logging
May 22 2019, 2:08 AM
martong committed rL361362: Add AST logging.
Add AST logging
May 22 2019, 2:08 AM
martong closed D62061: Add AST logging.
May 22 2019, 2:08 AM · Restricted Project
martong updated the diff for D62061: Add AST logging.
  • Remove superflous '.c_str()'
May 22 2019, 2:03 AM · Restricted Project

May 21 2019

martong updated the diff for D62061: Add AST logging.
  • Change to if(Log *log = ...)
  • Use LLDB_LOG
May 21 2019, 3:03 AM · Restricted Project
martong added inline comments to D62061: Add AST logging.
May 21 2019, 3:03 AM · Restricted Project
martong updated the diff for D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
  • Remove getUnderlyingType
May 21 2019, 2:36 AM · Restricted Project, Restricted Project
martong added inline comments to D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
May 21 2019, 2:36 AM · Restricted Project, Restricted Project

May 20 2019

martong committed rG1d51e3e6ee99: [ASTImporter] Enable disabled but passing tests (authored by martong).
[ASTImporter] Enable disabled but passing tests
May 20 2019, 3:38 AM
martong committed rC361139: [ASTImporter] Enable disabled but passing tests.
[ASTImporter] Enable disabled but passing tests
May 20 2019, 3:38 AM
martong committed rL361139: [ASTImporter] Enable disabled but passing tests.
[ASTImporter] Enable disabled but passing tests
May 20 2019, 3:37 AM
martong closed D62066: [ASTImporter] Enable disabled but passing tests.
May 20 2019, 3:37 AM · Restricted Project, Restricted Project
martong created D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter.
May 20 2019, 3:21 AM · Restricted Project

May 17 2019

martong created D62066: [ASTImporter] Enable disabled but passing tests.
May 17 2019, 7:42 AM · Restricted Project, Restricted Project
martong created D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable.
May 17 2019, 7:19 AM · Restricted Project, Restricted Project
martong updated the diff for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
  • se -> so
May 17 2019, 6:31 AM · Restricted Project, Restricted Project
martong added inline comments to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
May 17 2019, 6:28 AM · Restricted Project, Restricted Project
martong updated the diff for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
  • Rebase to master
  • Rebase to D62061
May 17 2019, 6:28 AM · Restricted Project, Restricted Project
martong added a parent revision for D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src: D62061: Add AST logging.
May 17 2019, 6:11 AM · Restricted Project, Restricted Project
martong added a child revision for D62061: Add AST logging: D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.
May 17 2019, 6:11 AM · Restricted Project
martong created D62061: Add AST logging.
May 17 2019, 6:11 AM · Restricted Project

May 15 2019

martong added inline comments to D44100: [ASTImporter] Reorder fields after structure import is finished.
May 15 2019, 9:42 AM · Restricted Project
martong updated the diff for D44100: [ASTImporter] Reorder fields after structure import is finished.
  • Address Shafik's comments and update assertions
May 15 2019, 9:39 AM · Restricted Project
martong committed rG5ac6d49065df: [ASTImporter] Use llvm::Expected and Error in the importer API (authored by martong).
[ASTImporter] Use llvm::Expected and Error in the importer API
May 15 2019, 3:28 AM
martong committed rC360760: [ASTImporter] Use llvm::Expected and Error in the importer API.
[ASTImporter] Use llvm::Expected and Error in the importer API
May 15 2019, 3:28 AM
martong committed rLLDB360760: [ASTImporter] Use llvm::Expected and Error in the importer API.
[ASTImporter] Use llvm::Expected and Error in the importer API
May 15 2019, 3:28 AM
martong committed rL360760: [ASTImporter] Use llvm::Expected and Error in the importer API.
[ASTImporter] Use llvm::Expected and Error in the importer API
May 15 2019, 3:27 AM
martong closed D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
May 15 2019, 3:27 AM · Restricted Project, Restricted Project, Restricted Project
martong updated the diff for D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
  • Rebase to master
May 15 2019, 2:50 AM · Restricted Project, Restricted Project, Restricted Project
martong added a comment to rC354839: Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes.".

This is a destructive revert commit which does not simply revert the mentioned r354832 commit. Besides reverting that commit, it does remove a bunch of unrelated test files! E.g. cfe/trunk/test/ASTMerge/var/Inputs/var1.c. Could you please investigate and restore the unrelated test files?

Sorry about that! I added the files back in rC360699, but some of the tests now fail, so I XFAIL'd them and applied the fixes separately in rC360701 (and forgot one change, which became rC360705). It looks like you made the behavior change in rC357394 that would've caused these tests to start failing, so you might want to take a look. It's also worth pointing out that clang/test/ASTMerge/class-template-partial-specialization/test.cpp crashes clang right now. It may have been a regression from April, but I couldn't say for sure.

I might try to reproduce the git-llvm bug that caused the file deletion if I have time, but more likely I won't get to it, and I'll just have to be more careful when reverting things in the future.

May 15 2019, 1:05 AM

May 14 2019

martong added a comment to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.

Thank you guys for the review!

May 14 2019, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
martong added a comment to rC354832: [ASTImporter] Add support for importing ChooseExpr AST nodes..

Please ignore my previous comment, I didn't recognize that the fact of the revert was indeed commented at the patch, it is my bad.

May 14 2019, 8:06 AM
martong updated subscribers of rC354832: [ASTImporter] Add support for importing ChooseExpr AST nodes..
May 14 2019, 7:55 AM
martong added a comment to rC354839: Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes.".

This is a destructive revert commit which does not simply revert the mentioned r354832 commit. Besides reverting that commit, it does remove a bunch of unrelated test files! E.g. cfe/trunk/test/ASTMerge/var/Inputs/var1.c. Could you please investigate and restore the unrelated test files?

May 14 2019, 7:45 AM
martong added inline comments to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.
May 14 2019, 4:26 AM · Restricted Project, Restricted Project, Restricted Project

May 13 2019

martong added a comment to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.

@aprantl Ping

May 13 2019, 9:14 AM · Restricted Project, Restricted Project, Restricted Project
martong committed rG3c72fe1bad4a: [ASTImporter] Separate unittest files (authored by martong).
[ASTImporter] Separate unittest files
May 13 2019, 3:09 AM
martong committed rL360572: [ASTImporter] Separate unittest files.
[ASTImporter] Separate unittest files
May 13 2019, 3:04 AM
martong committed rC360572: [ASTImporter] Separate unittest files.
[ASTImporter] Separate unittest files
May 13 2019, 3:03 AM
martong closed D61786: [ASTImporter] Separate unittest files.
May 13 2019, 3:03 AM · Restricted Project