Page MenuHomePhabricator

martong (Gabor Marton)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2017, 8:01 AM (71 w, 1 d)

Recent Activity

Today

martong committed rG2ac9ee3e1383: Fix remaining semicolon pedantic errors for intel (authored by martong).
Fix remaining semicolon pedantic errors for intel
Wed, Feb 20, 11:08 AM
martong committed rC354503: Fix remaining semicolon pedantic errors for intel.
Fix remaining semicolon pedantic errors for intel
Wed, Feb 20, 11:07 AM
martong committed rL354503: Fix remaining semicolon pedantic errors for intel.
Fix remaining semicolon pedantic errors for intel
Wed, Feb 20, 11:07 AM
martong committed rG038100ade3b7: Fix compile error with Intel's compiler (-Werror=pedantic) (authored by martong).
Fix compile error with Intel's compiler (-Werror=pedantic)
Wed, Feb 20, 8:58 AM
martong committed rC354482: Fix compile error with Intel's compiler (-Werror=pedantic).
Fix compile error with Intel's compiler (-Werror=pedantic)
Wed, Feb 20, 8:57 AM
martong committed rL354482: Fix compile error with Intel's compiler (-Werror=pedantic).
Fix compile error with Intel's compiler (-Werror=pedantic)
Wed, Feb 20, 8:57 AM

Mon, Feb 18

martong committed rGe331e63af23c: [ASTImporter] Find previous friend function template (authored by martong).
[ASTImporter] Find previous friend function template
Mon, Feb 18, 5:10 AM
martong committed rL354267: [ASTImporter] Find previous friend function template.
[ASTImporter] Find previous friend function template
Mon, Feb 18, 5:09 AM
martong committed rC354267: [ASTImporter] Find previous friend function template.
[ASTImporter] Find previous friend function template
Mon, Feb 18, 5:09 AM
martong closed D57910: [ASTImporter] Find previous friend function template.
Mon, Feb 18, 5:09 AM · Restricted Project
martong updated the diff for D57910: [ASTImporter] Find previous friend function template.

Rebase to master

Mon, Feb 18, 3:24 AM · Restricted Project
martong updated the diff for D57910: [ASTImporter] Find previous friend function template.
  • Add FIXME
Mon, Feb 18, 3:17 AM · Restricted Project
martong committed rC354259: [ASTImporter] Unify redecl chain tests as type parameterized tests.
[ASTImporter] Unify redecl chain tests as type parameterized tests
Mon, Feb 18, 3:10 AM
martong committed rGfc03fc6e6919: [ASTImporter] Unify redecl chain tests as type parameterized tests (authored by martong).
[ASTImporter] Unify redecl chain tests as type parameterized tests
Mon, Feb 18, 3:10 AM
martong committed rL354259: [ASTImporter] Unify redecl chain tests as type parameterized tests.
[ASTImporter] Unify redecl chain tests as type parameterized tests
Mon, Feb 18, 3:09 AM
martong closed D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.
Mon, Feb 18, 3:09 AM · Restricted Project, Restricted Project
martong updated the diff for D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.

Rebase to master

Mon, Feb 18, 3:06 AM · Restricted Project, Restricted Project

Fri, Feb 15

martong added reviewers for D58292: Add support for importing ChooseExpr AST nodes.: a_sidorin, martong.
Fri, Feb 15, 11:28 AM · Restricted Project
martong committed rG302f300a7a70: [ASTImporter] Import every Decl in lambda record (authored by martong).
[ASTImporter] Import every Decl in lambda record
Fri, Feb 15, 4:05 AM
martong committed rC354120: [ASTImporter] Import every Decl in lambda record.
[ASTImporter] Import every Decl in lambda record
Fri, Feb 15, 4:05 AM
martong committed rL354120: [ASTImporter] Import every Decl in lambda record.
[ASTImporter] Import every Decl in lambda record
Fri, Feb 15, 4:04 AM
martong closed D57740: [ASTImporter] Import every Decl in lambda record.
Fri, Feb 15, 4:04 AM · Restricted Project, Restricted Project
martong added a comment to D57590: [ASTImporter] Improve import of FileID..

Ping

Fri, Feb 15, 12:56 AM · Restricted Project
martong added a comment to D57910: [ASTImporter] Find previous friend function template.

Ping

Fri, Feb 15, 12:53 AM · Restricted Project

Thu, Feb 14

martong committed rG458d1457fb51: [ASTImporter] Check visibility/linkage of functions and variables (authored by martong).
[ASTImporter] Check visibility/linkage of functions and variables
Thu, Feb 14, 5:08 AM
martong committed rC354027: [ASTImporter] Check visibility/linkage of functions and variables.
[ASTImporter] Check visibility/linkage of functions and variables
Thu, Feb 14, 5:08 AM
martong committed rL354027: [ASTImporter] Check visibility/linkage of functions and variables.
[ASTImporter] Check visibility/linkage of functions and variables
Thu, Feb 14, 5:08 AM
martong closed D57232: [ASTImporter] Check visibility/linkage of functions and variables.
Thu, Feb 14, 5:08 AM · Restricted Project, Restricted Project
martong added a comment to D57232: [ASTImporter] Check visibility/linkage of functions and variables.

@shafik Thanks for the review!

Thu, Feb 14, 5:07 AM · Restricted Project, Restricted Project
martong updated the diff for D57232: [ASTImporter] Check visibility/linkage of functions and variables.

Rebase to master(trunk)

Thu, Feb 14, 1:31 AM · Restricted Project, Restricted Project

Tue, Feb 12

martong added a comment to D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.

Thanks for the review Alexei!

Tue, Feb 12, 6:03 AM · Restricted Project, Restricted Project
martong updated the diff for D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.
  • Remove numbers when possible
  • Use disabled tests instead of commented out tests
Tue, Feb 12, 6:01 AM · Restricted Project, Restricted Project

Mon, Feb 11

martong added a comment to D57906: [CTU] Do not allow different CPP dialects in CTU.

How is #if cplusplus >= 201103L qualitatively different from #ifndef NDEBUG or #if MYLIB_ABI_VERSION==2 or #if DATE__ == "2018-04-01"?

Mon, Feb 11, 5:24 AM · Restricted Project
martong accepted D57956: [www] Add ASTImporter fuzzer project..

This project is about writing a fuzzer to proactively discover these

ASTImporter bugs and provide minimal reproducers which make understanding
and fixing the underlying bug easier.
Mon, Feb 11, 2:50 AM
martong committed rG0e04ebdcda44: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces (authored by martong).
[ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces
Mon, Feb 11, 2:30 AM
martong committed rC353684: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces.
[ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces
Mon, Feb 11, 2:29 AM
martong committed rL353684: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces.
[ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces
Mon, Feb 11, 2:29 AM
martong closed D57901: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces.
Mon, Feb 11, 2:29 AM · Restricted Project, Restricted Project
martong added a comment to D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.

Ping.
Please raise your objections if you have any until the 18th of February (that date I am going to commit if there are no objections). Also, please let me know if you find this deadline too strict.

Mon, Feb 11, 2:25 AM · Restricted Project, Restricted Project
martong added a comment to D57232: [ASTImporter] Check visibility/linkage of functions and variables.

Ping

Mon, Feb 11, 2:22 AM · Restricted Project, Restricted Project

Fri, Feb 8

martong added inline comments to D57906: [CTU] Do not allow different CPP dialects in CTU.
Fri, Feb 8, 1:33 AM · Restricted Project
martong updated the diff for D57906: [CTU] Do not allow different CPP dialects in CTU.
  • Revert comment change
  • Add lang_dialect_mismatch and stats for that
Fri, Feb 8, 1:32 AM · Restricted Project
martong committed rGa9cab318e7cd: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators (authored by martong).
[ASTImporter][ASTImporterSpecificLookup] Add test for different operators
Fri, Feb 8, 1:20 AM
martong committed rL353505: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators.
[ASTImporter][ASTImporterSpecificLookup] Add test for different operators
Fri, Feb 8, 1:20 AM
martong committed rC353505: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators.
[ASTImporter][ASTImporterSpecificLookup] Add test for different operators
Fri, Feb 8, 1:20 AM
martong closed D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators.
Fri, Feb 8, 1:20 AM · Restricted Project
martong updated the diff for D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators.
  • Add comment above ASSERT_NE
Fri, Feb 8, 1:13 AM · Restricted Project
martong committed rGfc638d64e8f0: [AST] Fix structural inequivalence of operators (authored by martong).
[AST] Fix structural inequivalence of operators
Fri, Feb 8, 12:56 AM
martong committed rL353504: [AST] Fix structural inequivalence of operators.
[AST] Fix structural inequivalence of operators
Fri, Feb 8, 12:55 AM
martong committed rC353504: [AST] Fix structural inequivalence of operators.
[AST] Fix structural inequivalence of operators
Fri, Feb 8, 12:55 AM
martong closed D57902: [AST] Fix structural inequivalence of operators.
Fri, Feb 8, 12:55 AM · Restricted Project
martong added inline comments to D57902: [AST] Fix structural inequivalence of operators.
Fri, Feb 8, 12:24 AM · Restricted Project

Thu, Feb 7

martong created D57910: [ASTImporter] Find previous friend function template.
Thu, Feb 7, 10:24 AM · Restricted Project
martong created D57906: [CTU] Do not allow different CPP dialects in CTU.
Thu, Feb 7, 9:52 AM · Restricted Project
martong created D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators.
Thu, Feb 7, 9:39 AM · Restricted Project
martong created D57902: [AST] Fix structural inequivalence of operators.
Thu, Feb 7, 9:22 AM · Restricted Project
martong created D57901: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces.
Thu, Feb 7, 9:15 AM · Restricted Project, Restricted Project
martong committed rG0b57ccb7b5fa: [ASTImporter] Refactor unittests to be able to parameterize them in a more… (authored by martong).
[ASTImporter] Refactor unittests to be able to parameterize them in a more…
Thu, Feb 7, 8:53 AM
martong committed rL353425: [ASTImporter] Refactor unittests to be able to parameterize them in a more….
[ASTImporter] Refactor unittests to be able to parameterize them in a more…
Thu, Feb 7, 8:52 AM
martong committed rC353425: [ASTImporter] Refactor unittests to be able to parameterize them in a more….
[ASTImporter] Refactor unittests to be able to parameterize them in a more…
Thu, Feb 7, 8:52 AM
martong closed D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way.
Thu, Feb 7, 8:52 AM · Restricted Project

Sat, Feb 2

martong added a comment to D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer.

I think you should change back to getInit()

I am not entirely sure about this because the initalizer may not be attached to the canonical decl. getInit() gives the initializer of one given specific Decl, however, getAnyInitializer() searches through the whole redecl chain.

Sat, Feb 2, 5:53 AM · Restricted Project

Fri, Feb 1

martong added a comment to D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer.

Previously this was not required since all VarDecls were canonical. Not sure if this change was intended. I did some digging, but am not familiar enough with the code base to figure out what changed. Does anyone have an idea about this?

Fri, Feb 1, 9:49 AM · Restricted Project
Herald added a project to D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests: Restricted Project.

Ping

Fri, Feb 1, 5:01 AM · Restricted Project, Restricted Project
martong updated the diff for D57232: [ASTImporter] Check visibility/linkage of functions and variables.
  • Move hunks into this patch from parent patch
Fri, Feb 1, 2:10 AM · Restricted Project, Restricted Project
martong added a comment to D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way.

Update: I just removed the unrelated changes.

Fri, Feb 1, 1:56 AM · Restricted Project
martong updated the diff for D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way.
  • Remove unrelated hunks
Fri, Feb 1, 1:55 AM · Restricted Project

Thu, Jan 31

martong added a comment to D56581: [ASTImporter] Set the described template if not set.

@martong have you had a chance to look at this some more? We ran into another problem that this fixes partially.

I didn't have time to deal with this yet (these days we are preparing an internal release and that took away my time).

Thu, Jan 31, 1:57 AM

Mon, Jan 28

martong added a parent revision for D57232: [ASTImporter] Check visibility/linkage of functions and variables: D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way.
Mon, Jan 28, 5:33 AM · Restricted Project, Restricted Project
martong added a child revision for D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way: D57232: [ASTImporter] Check visibility/linkage of functions and variables.
Mon, Jan 28, 5:33 AM · Restricted Project
martong updated the diff for D57232: [ASTImporter] Check visibility/linkage of functions and variables.

I have created a separate patch for the test related refactor, this patch now
depends on that patch and contains merely the visibility related change and
their tests.

Mon, Jan 28, 5:31 AM · Restricted Project, Restricted Project
martong created D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way.
Mon, Jan 28, 5:11 AM · Restricted Project
martong added inline comments to D57232: [ASTImporter] Check visibility/linkage of functions and variables.
Mon, Jan 28, 4:41 AM · Restricted Project, Restricted Project
martong updated the diff for D57232: [ASTImporter] Check visibility/linkage of functions and variables.
  • Remove dumpDeclContext() call
  • Remove superfluous else
Mon, Jan 28, 4:40 AM · Restricted Project, Restricted Project
martong committed rL352345: [AST] Add structural eq tests for template args.
[AST] Add structural eq tests for template args
Mon, Jan 28, 2:01 AM
martong committed rC352345: [AST] Add structural eq tests for template args.
[AST] Add structural eq tests for template args
Mon, Jan 28, 2:01 AM
martong closed D57235: [AST] Add structural eq tests for template args.
Mon, Jan 28, 2:01 AM

Fri, Jan 25

martong created D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests.
Fri, Jan 25, 6:03 AM · Restricted Project, Restricted Project
martong created D57235: [AST] Add structural eq tests for template args.
Fri, Jan 25, 5:36 AM
martong updated the diff for D57232: [ASTImporter] Check visibility/linkage of functions and variables.
  • Remove old style import in case of FoundArray
Fri, Jan 25, 4:58 AM · Restricted Project, Restricted Project
martong created D57232: [ASTImporter] Check visibility/linkage of functions and variables.
Fri, Jan 25, 4:50 AM · Restricted Project, Restricted Project
martong added a comment to D56581: [ASTImporter] Set the described template if not set.

@shafik Ok, I'll take a look into the regression soon. What are exactly gmodules? Is it macOS only? Do you have a description or some docs about it?

Fri, Jan 25, 2:12 AM
martong accepted D56936: Fix handling of overriden methods during ASTImport.

Shafik, thanks for addressing the comments. This looks good to me now!

Fri, Jan 25, 1:37 AM

Thu, Jan 24

martong committed rL352060: Fix failing buildbots.
Fix failing buildbots
Thu, Jan 24, 8:27 AM
martong committed rC352060: Fix failing buildbots.
Fix failing buildbots
Thu, Jan 24, 8:27 AM
martong committed rC352055: Fix failing buildbots.
Fix failing buildbots
Thu, Jan 24, 7:43 AM
martong committed rL352055: Fix failing buildbots.
Fix failing buildbots
Thu, Jan 24, 7:43 AM
martong committed rL352050: [ASTImporter] Fix inequality of functions with different attributes.
[ASTImporter] Fix inequality of functions with different attributes
Thu, Jan 24, 6:48 AM
martong committed rC352050: [ASTImporter] Fix inequality of functions with different attributes.
[ASTImporter] Fix inequality of functions with different attributes
Thu, Jan 24, 6:48 AM
martong closed D53699: [ASTImporter] Fix inequality of functions with different attributes.
Thu, Jan 24, 6:48 AM

Wed, Jan 23

martong added a comment to D56936: Fix handling of overriden methods during ASTImport.

So the problem is that there are references to ParmVarDecl from inside function body and at import of ParmVarDecl always a new one is created even if there is an already existing (in the existing function prototype)?

Yes. During the import of the body we import a DeclRefExpr which refers to a ParmVarDecl but not the existing one, thus a new is created.

Wed, Jan 23, 2:01 AM

Tue, Jan 22

martong accepted D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.

The updated version looks good to me! Thank you!

Tue, Jan 22, 8:50 AM
martong added inline comments to D56936: Fix handling of overriden methods during ASTImport.
Tue, Jan 22, 8:45 AM
martong added a comment to D56936: Fix handling of overriden methods during ASTImport.

Shafik,
I have realized what's the problem with the ctu-main test. When we import the body and set the new body to the existing FunctionDecl then the parameters are still the old parameters so the new body does not refer to the formal parameters! This way the analyzer legally thinks that the parameter is not used inside the function because there is no DeclRef to that :(
This could be solved only if we merge *every* parts precisely, including the parameters, body, noexcept specifier, etc. But this would be a huge work.

Tue, Jan 22, 8:39 AM
martong added a comment to D56936: Fix handling of overriden methods during ASTImport.

I have found some other minor things in the tests.

Tue, Jan 22, 5:47 AM

Jan 21 2019

martong added a comment to D56936: Fix handling of overriden methods during ASTImport.

@martong the only issue is that I am seeing a regression on Analysis/ctu-main.cpp when I run check-clang. I am going to look into it but if you have any insights that would be helpful.

Jan 21 2019, 8:21 AM
martong added a comment to D56936: Fix handling of overriden methods during ASTImport.

Hi Shafik, thank you for this patch! Generally it looks quite okay to me, but I have a few minor comments.

Jan 21 2019, 8:18 AM

Jan 11 2019

martong created D56581: [ASTImporter] Set the described template if not set.
Jan 11 2019, 12:02 AM

Jan 8 2019

martong added a comment to D55646: [ASTImporter] Make ODR diagnostics warning by default.

Just a quick note. We are pretty sure that StructuralEquivalency can have false positive results, i.e. it can report two decls as nonequivalent falsely. My understanding is that we should report an error only if we are absolutely certain that an error has happened, this is not the case with StructuralEquivalency. Consequently this should be a warning in Sema (modules) too.

Jan 8 2019, 7:59 AM · Restricted Project
martong accepted D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions.

Looks good to me (but xazax's comments are valid)! Thank you.

Jan 8 2019, 7:56 AM