martong (Gabor Marton)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2017, 8:01 AM (40 w, 4 d)

Recent Activity

Wed, Jul 18

martong added a comment to D30691: [analyzer] Support for naive cross translational unit analysis.

Just added a new entry to our roadmap: https://github.com/Ericsson/clang/issues/435

Wed, Jul 18, 6:54 AM
martong added a comment to D30691: [analyzer] Support for naive cross translational unit analysis.

CallEvent::getRuntimeDefinition is overwritten in

  • AnyFunctionCall
  • CXXInstanceCall
  • CXXMemberCall
  • CXXDestructorCall
  • ObjCMethodCall
Wed, Jul 18, 6:51 AM

Tue, Jul 17

martong committed rL337275: [ASTImporter] Fix poisonous structural equivalence cache.
[ASTImporter] Fix poisonous structural equivalence cache
Tue, Jul 17, 5:44 AM
martong committed rC337275: [ASTImporter] Fix poisonous structural equivalence cache.
[ASTImporter] Fix poisonous structural equivalence cache
Tue, Jul 17, 5:44 AM
martong closed D49300: [ASTImporter] Fix poisonous structural equivalence cache.
Tue, Jul 17, 5:44 AM
martong updated the diff for D49300: [ASTImporter] Fix poisonous structural equivalence cache.
  • Add comment about structural eq and BFS
Tue, Jul 17, 5:32 AM
martong added a comment to D49300: [ASTImporter] Fix poisonous structural equivalence cache.

Ok, thanks Aleksei for the review. I added the explanation as file comments into StructuralEquivalence.cpp.

Tue, Jul 17, 5:32 AM
martong committed rC337267: [ASTImporter] Fix import of unnamed structs.
[ASTImporter] Fix import of unnamed structs
Tue, Jul 17, 5:11 AM
martong committed rL337267: [ASTImporter] Fix import of unnamed structs.
[ASTImporter] Fix import of unnamed structs
Tue, Jul 17, 5:11 AM
martong closed D49296: [ASTImporter] Fix import of unnamed structs.
Tue, Jul 17, 5:11 AM
martong updated the diff for D49296: [ASTImporter] Fix import of unnamed structs.

Remove unneeded assert

Tue, Jul 17, 3:13 AM

Mon, Jul 16

martong updated the diff for D49296: [ASTImporter] Fix import of unnamed structs.

RecordDecl* -> RecordDecl *

Mon, Jul 16, 7:43 AM
martong added a comment to D49300: [ASTImporter] Fix poisonous structural equivalence cache.

Hi Aleksei,

Mon, Jul 16, 7:08 AM
martong added inline comments to D49296: [ASTImporter] Fix import of unnamed structs.
Mon, Jul 16, 6:21 AM
martong updated the diff for D49296: [ASTImporter] Fix import of unnamed structs.

Address review comments

Mon, Jul 16, 6:21 AM

Fri, Jul 13

martong created D49300: [ASTImporter] Fix poisonous structural equivalence cache.
Fri, Jul 13, 8:43 AM
martong created D49296: [ASTImporter] Fix import of unnamed structs.
Fri, Jul 13, 7:53 AM
martong added a comment to D47632: [ASTImporter] Refactor Decl creation.

I apologize for the delay in reviewing patches.

Fri, Jul 13, 5:23 AM

Thu, Jul 12

martong committed rC336898: [ASTImporter] Fix infinite recursion on function import with struct definition….
[ASTImporter] Fix infinite recursion on function import with struct definition…
Thu, Jul 12, 4:55 AM
martong committed rL336898: [ASTImporter] Fix infinite recursion on function import with struct definition….
[ASTImporter] Fix infinite recursion on function import with struct definition…
Thu, Jul 12, 4:55 AM
martong closed D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters.
Thu, Jul 12, 4:55 AM
martong abandoned D48722: [ASTImporter] Update isUsed flag at Decl import..

Closed in favor of https://reviews.llvm.org/D47632

Thu, Jul 12, 2:57 AM
martong commandeered D48722: [ASTImporter] Update isUsed flag at Decl import..
Thu, Jul 12, 2:57 AM
martong committed rC336896: [ASTImporter] Refactor Decl creation.
[ASTImporter] Refactor Decl creation
Thu, Jul 12, 2:47 AM
martong committed rL336896: [ASTImporter] Refactor Decl creation.
[ASTImporter] Refactor Decl creation
Thu, Jul 12, 2:47 AM
martong closed D47632: [ASTImporter] Refactor Decl creation.
Thu, Jul 12, 2:47 AM

Wed, Jul 11

martong added a comment to D47632: [ASTImporter] Refactor Decl creation.

Hi Aleksei, could you pleas take an other quick look, there were only minor changes since your last comments. Thanks!

Wed, Jul 11, 11:46 AM
martong added a comment to D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters.

@gerazo, Do you have commit rights, or should I help with the commit?

Wed, Jul 11, 11:42 AM

Tue, Jul 10

martong added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

Ping

Tue, Jul 10, 3:30 AM
martong added a comment to D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters.

Ping.

Tue, Jul 10, 3:27 AM
martong retitled D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters from [ASTmporter] Fix infinite recursion on function import with struct definition in parameters to [ASTImporter] Fix infinite recursion on function import with struct definition in parameters.
Tue, Jul 10, 3:26 AM
martong accepted D48628: [AST] Structural equivalence of methods.
Tue, Jul 10, 3:15 AM

Mon, Jul 9

martong added inline comments to D47632: [ASTImporter] Refactor Decl creation.
Mon, Jul 9, 5:38 AM
martong updated the diff for D47632: [ASTImporter] Refactor Decl creation.

Address review comments

Mon, Jul 9, 5:38 AM

Fri, Jul 6

martong updated the diff for D47632: [ASTImporter] Refactor Decl creation.

Fix indentation

Fri, Jul 6, 8:58 AM
martong updated the diff for D47632: [ASTImporter] Refactor Decl creation.
  • Rebase from master
  • Enable some disabled tests
  • Update the isUsed flag
  • Add a new config Minimal to the structural eq check, so lldb tests can pass now
  • Return with a bool value and use LLVM_NODISCARD in CreateDecl
  • Rename CreateDecl
Fri, Jul 6, 8:50 AM
martong accepted D48941: [ASTImporter] import FunctionDecl end locations.

LGTM!

Fri, Jul 6, 12:58 AM

Thu, Jul 5

martong committed rL336332: [ASTImporter] Fix import of objects with anonymous types.
[ASTImporter] Fix import of objects with anonymous types
Thu, Jul 5, 2:56 AM
martong committed rC336332: [ASTImporter] Fix import of objects with anonymous types.
[ASTImporter] Fix import of objects with anonymous types
Thu, Jul 5, 2:56 AM
martong closed D48773: [ASTImporter] Fix import of objects with anonymous types.
Thu, Jul 5, 2:56 AM
martong updated the diff for D48773: [ASTImporter] Fix import of objects with anonymous types.

PrevDecl is set after the !SearchName branch, as it had been done before.
This way original behaviour is kept as much as possible.

Thu, Jul 5, 1:36 AM

Wed, Jul 4

martong added inline comments to D48941: [ASTImporter] import FunctionDecl end locations.
Wed, Jul 4, 8:58 AM
martong added inline comments to D48773: [ASTImporter] Fix import of objects with anonymous types.
Wed, Jul 4, 2:25 AM

Tue, Jul 3

martong added inline comments to D48773: [ASTImporter] Fix import of objects with anonymous types.
Tue, Jul 3, 7:55 AM
martong updated the diff for D48773: [ASTImporter] Fix import of objects with anonymous types.

Remove redundant code and use only StructurlaEquivalence

Tue, Jul 3, 7:55 AM
martong added a comment to D48722: [ASTImporter] Update isUsed flag at Decl import..

I have a strong feeling of duplication with attribute and flags merging move in D47632. Maybe it is better to be resolved in that review by using the same code for attr/flag merging for both newly-created and mapped decls?

Tue, Jul 3, 2:56 AM

Fri, Jun 29

martong added a comment to D47632: [ASTImporter] Refactor Decl creation.

I realized that, this patch brakes 3 lldb tests ATM:

  • TestTopLevelExprs.py. If https://reviews.llvm.org/D48722 was merged then this test would not be broken.
  • TestPersistentTypes.py If https://reviews.llvm.org/D48773 was merged then this test would not be broken.
  • TestRecursiveTypes.py. I am still working on this. The newly introduced assert fires: Assertion (Pos == ImportedDecls.end() || Pos->second == To) && "Try to import an already imported Decl"' failed.`.
Fri, Jun 29, 8:51 AM
martong created D48773: [ASTImporter] Fix import of objects with anonymous types.
Fri, Jun 29, 8:30 AM
martong committed rC335968: [ASTImporter] Added import of CXXStdInitializerListExpr.
[ASTImporter] Added import of CXXStdInitializerListExpr
Fri, Jun 29, 5:22 AM
martong committed rL335968: [ASTImporter] Added import of CXXStdInitializerListExpr.
[ASTImporter] Added import of CXXStdInitializerListExpr
Fri, Jun 29, 5:22 AM
martong closed D48631: [ASTImporter] Added import of CXXStdInitializerListExpr.
Fri, Jun 29, 5:22 AM
martong committed rC335959: [ASTImporter] Eliminated some unittest warnings..
[ASTImporter] Eliminated some unittest warnings.
Fri, Jun 29, 3:30 AM
martong committed rL335959: [ASTImporter] Eliminated some unittest warnings..
[ASTImporter] Eliminated some unittest warnings.
Fri, Jun 29, 3:30 AM
martong closed D47459: [ASTImporter] Eliminated some unittest warnings..
Fri, Jun 29, 3:30 AM

Wed, Jun 27

martong added a comment to D47532: [ASTImporter] Import the whole redecl chain of functions.

The broken lldb tests are fixed with a minor change. We no longer load the Decls from the
external source during the call of DeclContext::containsDecl. A new function
DeclContext::containsDeclAndLoad is added which does a load and calls
containsDecl.

Wed, Jun 27, 6:37 AM
martong committed rC335731: Re-apply: [ASTImporter] Import the whole redecl chain of functions.
Re-apply: [ASTImporter] Import the whole redecl chain of functions
Wed, Jun 27, 6:37 AM
martong committed rL335731: Re-apply: [ASTImporter] Import the whole redecl chain of functions.
Re-apply: [ASTImporter] Import the whole redecl chain of functions
Wed, Jun 27, 6:37 AM

Tue, Jun 26

martong added inline comments to D47632: [ASTImporter] Refactor Decl creation.
Tue, Jun 26, 9:31 AM
martong committed rL335600: [ASTImporter] Use InjectedClassNameType at import of templated record..
[ASTImporter] Use InjectedClassNameType at import of templated record.
Tue, Jun 26, 6:49 AM
martong committed rC335600: [ASTImporter] Use InjectedClassNameType at import of templated record..
[ASTImporter] Use InjectedClassNameType at import of templated record.
Tue, Jun 26, 6:49 AM
martong closed D47450: [ASTImporter] Use InjectedClassNameType at import of templated record..
Tue, Jun 26, 6:49 AM

Mon, Jun 25

martong added a comment to D47532: [ASTImporter] Import the whole redecl chain of functions.

This is not trivial to fix. Reverting until we can reproduce and fix it.
Reverted with commit: r335491

Mon, Jun 25, 9:32 AM
martong committed rC335491: Revert "[ASTImporter] Import the whole redecl chain of functions".
Revert "[ASTImporter] Import the whole redecl chain of functions"
Mon, Jun 25, 9:30 AM
martong committed rL335491: Revert "[ASTImporter] Import the whole redecl chain of functions".
Revert "[ASTImporter] Import the whole redecl chain of functions"
Mon, Jun 25, 9:30 AM
martong added a comment to D47532: [ASTImporter] Import the whole redecl chain of functions.

@labath
Sure, looking into it.

Mon, Jun 25, 8:59 AM
martong updated the diff for D47632: [ASTImporter] Refactor Decl creation.
  • Rebase from master.
Mon, Jun 25, 8:57 AM
martong committed rL335480: [ASTImporter] Import the whole redecl chain of functions.
[ASTImporter] Import the whole redecl chain of functions
Mon, Jun 25, 7:47 AM
martong committed rC335480: [ASTImporter] Import the whole redecl chain of functions.
[ASTImporter] Import the whole redecl chain of functions
Mon, Jun 25, 7:46 AM
martong closed D47532: [ASTImporter] Import the whole redecl chain of functions.
Mon, Jun 25, 7:46 AM
martong added inline comments to D47532: [ASTImporter] Import the whole redecl chain of functions.
Mon, Jun 25, 7:39 AM
martong updated the diff for D47532: [ASTImporter] Import the whole redecl chain of functions.
  • Address review comments
Mon, Jun 25, 7:39 AM
martong committed rL335464: [ASTImporter] Add ms compatibility to tests which use the TestBase.
[ASTImporter] Add ms compatibility to tests which use the TestBase
Mon, Jun 25, 6:09 AM
martong committed rC335464: [ASTImporter] Add ms compatibility to tests which use the TestBase.
[ASTImporter] Add ms compatibility to tests which use the TestBase
Mon, Jun 25, 6:09 AM
martong closed D47367: [ASTImporter] Add ms compatibility to tests.
Mon, Jun 25, 6:09 AM
martong updated the diff for D47367: [ASTImporter] Add ms compatibility to tests.
  • Update commit comment and fix broken format in a comment.
Mon, Jun 25, 6:03 AM
martong committed rC335455: [ASTImporter] Add new tests about templated-described swing.
[ASTImporter] Add new tests about templated-described swing
Mon, Jun 25, 4:43 AM
martong committed rL335455: [ASTImporter] Add new tests about templated-described swing.
[ASTImporter] Add new tests about templated-described swing
Mon, Jun 25, 4:43 AM
martong closed D47534: [ASTImporter] Add new tests about templated-described swing.
Mon, Jun 25, 4:43 AM
martong added a comment to D47534: [ASTImporter] Add new tests about templated-described swing.

I addressed the comments, thanks for the review!

Mon, Jun 25, 4:42 AM
martong updated the diff for D47534: [ASTImporter] Add new tests about templated-described swing.
  • Clang format the test code snippet.
Mon, Jun 25, 4:41 AM

Fri, Jun 22

martong added a comment to D47698: [ASTImporter] import macro source locations.

This code is live when reading pchs, correct? Does this have any measurable perf impact on deserializing pchs for, say, Cocoa.h or Windows.h?

Fri, Jun 22, 7:56 AM
martong added reviewers for D47698: [ASTImporter] import macro source locations: balazske, xazax.hun.

Adding @balazske and @xazax.hun as reviewers. I think if it gets one more approve then we could merge. I'd like to speed up the things here ... we can't expect Aleksei to review all those many patches we sent lately.

Fri, Jun 22, 2:16 AM

Jun 21 2018

martong added a reviewer for D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters: xazax.hun.
Jun 21 2018, 5:43 AM
martong added inline comments to D47532: [ASTImporter] Import the whole redecl chain of functions.
Jun 21 2018, 5:34 AM
martong updated the diff for D47532: [ASTImporter] Import the whole redecl chain of functions.
  • Addressing Alexei's comments.
Jun 21 2018, 5:34 AM

Jun 19 2018

martong requested review of D47367: [ASTImporter] Add ms compatibility to tests.

Ping.

Jun 19 2018, 8:23 AM
martong accepted D47698: [ASTImporter] import macro source locations.

This patch is really useful and LGTM!
Just found some minor things.

Jun 19 2018, 8:04 AM
martong accepted D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters.

LGTM, just found some minor things.

Jun 19 2018, 3:16 AM

Jun 5 2018

martong added a comment to D47532: [ASTImporter] Import the whole redecl chain of functions.

Are you OK with incremental review?

Jun 5 2018, 9:22 AM

Jun 1 2018

martong created D47632: [ASTImporter] Refactor Decl creation.
Jun 1 2018, 6:27 AM

May 31 2018

martong added inline comments to D47532: [ASTImporter] Import the whole redecl chain of functions.
May 31 2018, 6:43 AM
martong added a comment to D47532: [ASTImporter] Import the whole redecl chain of functions.

I just wanted to give a detailed justification about why we should import the
whole redecl chain. Consider the following code:

void f(); // prototype
void f() { f(); }

Currently, when we import the prototype we end up having two independent
functions with definitions:

TranslationUnitDecl 0x25214c8 <<invalid sloc>> <invalid sloc>
|
|-FunctionDecl 0x255e3e8 <input.cc:1:11, col:27> col:16 f 'void ()'
| `-CompoundStmt 0x255e4f0 <col:20, col:27>
|   `-CallExpr 0x255e4c8 <col:22, col:24> 'void'
|     `-ImplicitCastExpr 0x255e4b0 <col:22> 'void (*)()' <FunctionToPointerDecay>
|       `-DeclRefExpr 0x255e488 <col:22> 'void ()' lvalue Function 0x255e3e8 'f' 'void ()'
`-FunctionDecl 0x255e300 <col:1, col:27> col:6 f 'void ()'
  `-CompoundStmt 0x255e570 <col:20, col:27>
    `-CallExpr 0x255e548 <col:22, col:24> 'void'
      `-ImplicitCastExpr 0x255e530 <col:22> 'void (*)()' <FunctionToPointerDecay>
        `-DeclRefExpr 0x255e508 <col:22> 'void ()' lvalue Function 0x255e3e8 'f' 'void ()'
May 31 2018, 2:35 AM

May 30 2018

martong added inline comments to D47450: [ASTImporter] Use InjectedClassNameType at import of templated record..
May 30 2018, 7:45 AM
martong created D47534: [ASTImporter] Add new tests about templated-described swing.
May 30 2018, 7:04 AM
martong updated the diff for D47532: [ASTImporter] Import the whole redecl chain of functions.
  • Add a missing "else"
May 30 2018, 6:20 AM
martong created D47532: [ASTImporter] Import the whole redecl chain of functions.
May 30 2018, 6:13 AM
martong updated the diff for D47367: [ASTImporter] Add ms compatibility to tests.
  • Remove unused RunOptions typedef and isCXX function
May 30 2018, 5:31 AM
martong updated the diff for D47367: [ASTImporter] Add ms compatibility to tests.
  • Remove unused function
May 30 2018, 5:28 AM
martong updated the summary of D47367: [ASTImporter] Add ms compatibility to tests.
May 30 2018, 5:19 AM
martong added a reviewer for D47367: [ASTImporter] Add ms compatibility to tests: balazske.

Balazs, could you please review this patch as well? (This code is not in our fork yet.)

May 30 2018, 5:18 AM