Page MenuHomePhabricator

martong (Gabor Marton)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2017, 8:01 AM (79 w, 3 d)

Recent Activity

Tue, Apr 16

martong added a reviewer for D43357: [Concepts] Function trailing requires clauses: balazske.
Tue, Apr 16, 1:41 AM · Restricted Project
martong requested changes to D43357: [Concepts] Function trailing requires clauses.
Tue, Apr 16, 1:37 AM · Restricted Project
martong requested changes to D41910: [Concepts] Constrained partial specializations and function overloads..
Tue, Apr 16, 1:36 AM · Restricted Project
martong added a reviewer for D44352: [Concepts] Constrained template parameters: balazske.
Tue, Apr 16, 1:30 AM · Restricted Project
martong requested changes to D44352: [Concepts] Constrained template parameters.
Tue, Apr 16, 1:23 AM · Restricted Project

Wed, Apr 10

martong updated the summary of D59692: [ASTImporter] Fix name conflict handling.
Wed, Apr 10, 8:38 AM · Restricted Project
martong added a comment to D59692: [ASTImporter] Fix name conflict handling.

Ping @a_sidorin @shafik

Wed, Apr 10, 8:38 AM · Restricted Project
martong updated the diff for D59692: [ASTImporter] Fix name conflict handling.
  • Put back the call to GetOriginalDecl
Wed, Apr 10, 8:38 AM · Restricted Project

Wed, Apr 3

martong added a comment to D55049: Changed every use of ASTImporter::Import to Import_New.

Ping @shafik @a_sidorin

Wed, Apr 3, 2:44 AM · Restricted Project
martong added a comment to D59826: [expression] Explicitly build the lookup table of any TagDecl's context.

Any way to dump the AST in a test to verify we don't create multiple?

Wed, Apr 3, 1:48 AM · Restricted Project

Tue, Apr 2

martong added a comment to D59826: [expression] Explicitly build the lookup table of any TagDecl's context.

Ping

Tue, Apr 2, 2:16 AM · Restricted Project
martong added inline comments to D59692: [ASTImporter] Fix name conflict handling.
Tue, Apr 2, 2:11 AM · Restricted Project

Mon, Apr 1

martong committed rGdae5ff2b7b8e: Attempt to fix failing buildbot (ppc64le) (authored by martong).
Attempt to fix failing buildbot (ppc64le)
Mon, Apr 1, 8:47 AM
martong committed rL357405: Attempt to fix failing buildbot (ppc64le).
Attempt to fix failing buildbot (ppc64le)
Mon, Apr 1, 8:47 AM
martong committed rC357405: Attempt to fix failing buildbot (ppc64le).
Attempt to fix failing buildbot (ppc64le)
Mon, Apr 1, 8:47 AM
martong committed rG410f32ce7c69: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation (authored by martong).
[ASTImporter] Convert ODR diagnostics inside ASTImporter implementation
Mon, Apr 1, 8:29 AM
martong committed rC357402: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.
[ASTImporter] Convert ODR diagnostics inside ASTImporter implementation
Mon, Apr 1, 8:29 AM
martong committed rL357402: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.
[ASTImporter] Convert ODR diagnostics inside ASTImporter implementation
Mon, Apr 1, 8:28 AM
martong closed D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.
Mon, Apr 1, 8:28 AM · Restricted Project, Restricted Project
martong committed rG60768cd89672: [ASTImporter] Make ODR error handling configurable (authored by martong).
[ASTImporter] Make ODR error handling configurable
Mon, Apr 1, 7:46 AM
martong committed rL357394: [ASTImporter] Make ODR error handling configurable.
[ASTImporter] Make ODR error handling configurable
Mon, Apr 1, 7:45 AM
martong committed rC357394: [ASTImporter] Make ODR error handling configurable.
[ASTImporter] Make ODR error handling configurable
Mon, Apr 1, 7:45 AM
martong closed D58897: [ASTImporter] Make ODR error handling configurable.
Mon, Apr 1, 7:45 AM · Restricted Project

Fri, Mar 29

martong accepted D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Hello Raphael,
I think we should accept this change. I don't see an easy way to merge the LLDB stuff into ASTImporter; also, this patch provides a good extension point for ASTImporter since it is designed to be a parent class. @martong @shafik Gabor, Shafik, what do you think?

Fri, Mar 29, 1:30 AM · Restricted Project

Thu, Mar 28

martong added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

Hi Shafik,
Thank you for the explanation, it is much more clear to me now. But, as I see, D59692 is going to discard the changes this patch introduces. @martong Gabor, do you expect the changes of this patch to be merged into yours, or should this patch be abandoned?

Thu, Mar 28, 3:12 PM · Restricted Project
martong added inline comments to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..
Thu, Mar 28, 2:51 AM · Restricted Project

Wed, Mar 27

martong added a comment to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Well, I still don't understand how LLDB synthesis the AST.
So you have a C++ module in a .pcm file. This means you could create an AST from that with ASTReader from it's .clang_ast section, right? In that case the AST should be complete with all type information. If this was the case then I don't see why it is not possible to use clang::ASTImporter to import templates and specializations, since we do exactly that in CTU.

Or do you guys create the AST from the debug info, from the .debug_info section of .pcm module file? And this is why AST is incomplete? I've got this from https://youtu.be/EgkZ8PTNSHQ?list=PL85Cf-ok7HpppFWlp2wX_-A1dkyFVlaEB&t=1565
If this is the case, then comes my naiive quiestion: Why don't you use the ASTReader?

There are no C++ modules involved in our use case beside the generic std module. No user-written code is read from a module and we don't have any PCM file beside the std module we build for the expression evaluator.

We use the ASTReader to directly read the std module contents into the expression evaluation ASTContext, but this doesn't give us the decls for the instantiations the user has made (e.g. std::vector<Foo>). We only have these user instantiations in the 'normal' debug info where we have a rather minimal AST (again, no modules are not involved in building this debug info AST). The InternalImport in the LLDB patch just stitches the module AST and the debug info AST together when we import something that we also have (in better quality from the C++ module) in the target ASTContext.

Thank you for the explanation.
Now I understand you directly create specializations from the std module and intercept the import to avoid importing broken specializations from the debug info, this makes sense.

Really, just one last question to see the whole picture: If clang::ASTImporter were capable of handling a specialization/instantiation with missing info then we could use that. So the reason for this interception is that clang::ASTImporter::VisitClassTemplateSpecializationDecl cannot handle the specialization it receives because that or its dependent nodes has too many missing data, right?

Feel free to ask! I'm just traveling so my internet access (and my reply rate) is a bit low at the moment.

Not sure if we can easily merge the logic of D59537 into the ASTImporter. It has no logic at all to actually determine if a source AST node has missing data but solely relies on our knowledge that our AST in LLDB isn't very useful for std templates. Also instantiating a template instead of importing an existing instantiation seems like a very rare scenario. I'm not even sure how we would test having a broken AST with Clang (the parser won't produce one, so we would have to hack our own AST builder for broken nodes).

If there is a reasonable way to get this logic into the ASTImporter I have no objection against doing so. The only problem I see is that I can't come up with a reasonable way of merging/testing the logic in the ASTImporter (and what other application would benefit from it).

Wed, Mar 27, 12:19 PM · Restricted Project
martong accepted D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

LGTM!

Wed, Mar 27, 8:42 AM · Restricted Project
martong accepted D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it.

LGTM!

Wed, Mar 27, 8:39 AM · Restricted Project
martong added a reviewer for D59826: [expression] Explicitly build the lookup table of any TagDecl's context: jingham.
Wed, Mar 27, 2:43 AM · Restricted Project

Tue, Mar 26

martong added a child revision for D59826: [expression] Explicitly build the lookup table of any TagDecl's context: D44100: [ASTImporter] Reorder fields after structure import is finished.
Tue, Mar 26, 9:37 AM · Restricted Project
martong added a parent revision for D44100: [ASTImporter] Reorder fields after structure import is finished: D59826: [expression] Explicitly build the lookup table of any TagDecl's context.
Tue, Mar 26, 9:37 AM · Restricted Project
martong added a comment to D59826: [expression] Explicitly build the lookup table of any TagDecl's context.

There is a lookup failure within the
ASTImporter during the expression evaluation. The clang::ASTImporter cannot
lookup previously created declarations thus it creates duplicated and redundant
declarations. These duplicated declarations then later can cause different
assertions.

Tue, Mar 26, 9:37 AM · Restricted Project
martong set the repository for D59826: [expression] Explicitly build the lookup table of any TagDecl's context to rLLDB LLDB.
Tue, Mar 26, 9:31 AM · Restricted Project
martong created D59826: [expression] Explicitly build the lookup table of any TagDecl's context.
Tue, Mar 26, 9:28 AM · Restricted Project
martong updated the diff for D59692: [ASTImporter] Fix name conflict handling.
  • Add braces around else
  • Remove falsely duplicated push_back
  • Use Expected<T> in HandleNameConflict
Tue, Mar 26, 5:34 AM · Restricted Project
martong added inline comments to D59692: [ASTImporter] Fix name conflict handling.
Tue, Mar 26, 5:34 AM · Restricted Project
martong added a reviewer for D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation: a_sidorin.
Tue, Mar 26, 5:04 AM · Restricted Project, Restricted Project
martong added inline comments to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.
Tue, Mar 26, 4:59 AM · Restricted Project
martong added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

Looks good for me now, but we should make a similar change in VisitRecordDecl too.

Tue, Mar 26, 4:59 AM · Restricted Project
martong added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

@martong your idea does not work b/c default construction DeclarationName() treats it the same as being empty. So if (!Name) is still true.

Tue, Mar 26, 4:51 AM · Restricted Project

Mon, Mar 25

martong added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Mon, Mar 25, 6:52 AM · Restricted Project, Restricted Project
martong added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Mon, Mar 25, 6:49 AM · Restricted Project, Restricted Project

Fri, Mar 22

martong added a comment to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Well, I still don't understand how LLDB synthesis the AST.
So you have a C++ module in a .pcm file. This means you could create an AST from that with ASTReader from it's .clang_ast section, right? In that case the AST should be complete with all type information. If this was the case then I don't see why it is not possible to use clang::ASTImporter to import templates and specializations, since we do exactly that in CTU.

Or do you guys create the AST from the debug info, from the .debug_info section of .pcm module file? And this is why AST is incomplete? I've got this from https://youtu.be/EgkZ8PTNSHQ?list=PL85Cf-ok7HpppFWlp2wX_-A1dkyFVlaEB&t=1565
If this is the case, then comes my naiive quiestion: Why don't you use the ASTReader?

There are no C++ modules involved in our use case beside the generic std module. No user-written code is read from a module and we don't have any PCM file beside the std module we build for the expression evaluator.

We use the ASTReader to directly read the std module contents into the expression evaluation ASTContext, but this doesn't give us the decls for the instantiations the user has made (e.g. std::vector<Foo>). We only have these user instantiations in the 'normal' debug info where we have a rather minimal AST (again, no modules are not involved in building this debug info AST). The InternalImport in the LLDB patch just stitches the module AST and the debug info AST together when we import something that we also have (in better quality from the C++ module) in the target ASTContext.

Thank you for the explanation.
Now I understand you directly create specializations from the std module and intercept the import to avoid importing broken specializations from the debug info, this makes sense.

Fri, Mar 22, 9:08 AM · Restricted Project
martong added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Fri, Mar 22, 8:41 AM · Restricted Project, Restricted Project
martong added a comment to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Well, I still don't understand how LLDB synthesis the AST.
So you have a C++ module in a .pcm file. This means you could create an AST from that with ASTReader from it's .clang_ast section, right? In that case the AST should be complete with all type information. If this was the case then I don't see why it is not possible to use clang::ASTImporter to import templates and specializations, since we do exactly that in CTU.

Or do you guys create the AST from the debug info, from the .debug_info section of .pcm module file? And this is why AST is incomplete? I've got this from https://youtu.be/EgkZ8PTNSHQ?list=PL85Cf-ok7HpppFWlp2wX_-A1dkyFVlaEB&t=1565
If this is the case, then comes my naiive quiestion: Why don't you use the ASTReader?

There are no C++ modules involved in our use case beside the generic std module. No user-written code is read from a module and we don't have any PCM file beside the std module we build for the expression evaluator.

We use the ASTReader to directly read the std module contents into the expression evaluation ASTContext, but this doesn't give us the decls for the instantiations the user has made (e.g. std::vector<Foo>). We only have these user instantiations in the 'normal' debug info where we have a rather minimal AST (again, no modules are not involved in building this debug info AST). The InternalImport in the LLDB patch just stitches the module AST and the debug info AST together when we import something that we also have (in better quality from the C++ module) in the target ASTContext.

Fri, Mar 22, 8:27 AM · Restricted Project
martong added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

I am aware of similar errors like this with other AST nodes. We had a patch in our fork to fix that in January (https://github.com/Ericsson/clang/pull/569/files) I am going to prepare a patch from that cause I see now this affects you guys in LLDB too.

Fri, Mar 22, 6:15 AM · Restricted Project
martong added a reviewer for D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.: a_sidorin.

@shafik, @a_sidorin Ping. Could you please take a look?
Guys, this and its child patch are very important patches, because without it the error handling of ASTImporter is not completed. This means we may encounter a nullptr DeclContext in the middle of the import process, etc...

Fri, Mar 22, 5:57 AM · Restricted Project, Restricted Project
martong added a reviewer for D55049: Changed every use of ASTImporter::Import to Import_New: a_sidorin.

Ping

Fri, Mar 22, 5:54 AM · Restricted Project
Herald added a reviewer for D55049: Changed every use of ASTImporter::Import to Import_New: martong.
Fri, Mar 22, 5:54 AM · Restricted Project
martong added a parent revision for D59692: [ASTImporter] Fix name conflict handling: D55049: Changed every use of ASTImporter::Import to Import_New.
Fri, Mar 22, 5:49 AM · Restricted Project
martong added a child revision for D55049: Changed every use of ASTImporter::Import to Import_New: D59692: [ASTImporter] Fix name conflict handling.
Fri, Mar 22, 5:49 AM · Restricted Project
martong created D59692: [ASTImporter] Fix name conflict handling.
Fri, Mar 22, 5:49 AM · Restricted Project
martong added a comment to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

@martong It's not related to lookup or anything like that, it's just that we don't have enough information in our debug info AST to allow people to use meta programming. The custom logic we have in LLDB looks into the std C++ module to fill out these gaps in the AST by hand when they are used in an expression.

The remark about the alternative being slow just means that fixing all the templates we have in our debug info AST seems like a costly approach. I'm also not sure how well it would work, as I never tried mixing a C++ module in an ASTContext that isn't currently being parsed by Clang.

Fri, Mar 22, 3:52 AM · Restricted Project
martong added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

Hi Shafik,

Honestly, I was always wondering what does HandleNameConflict actually do. Its implementation in ASTImporter is trivial and I don't see any of its overrides in LLDB code too. Why do we check its result to be non-empty is a question to me as well. And the more I look at it (and the bug you pointed in it), the more I think there is something wrong with it. Maybe it is better to just remove it at all? I hope LLDB developers have more knowledge about it. Shafik, Davide @davide , do you know its actual purpose?

Fri, Mar 22, 3:08 AM · Restricted Project
martong added a comment to D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.

Hi Shafik,

Fri, Mar 22, 2:50 AM · Restricted Project

Wed, Mar 20

martong accepted D59595: Remove the unused return value in ASTImporter::Imported [NFC].

LGTM!

Wed, Mar 20, 9:16 AM · Restricted Project, Restricted Project

Mar 19 2019

martong accepted D59134: [ASTImporter] Remove obsolete function ImportTemplateParameterList..
Mar 19 2019, 7:10 AM · Restricted Project, Restricted Project
martong committed rGdd59d27a1f8a: [ASTImporter] Fix redecl failures of FunctionTemplateSpec (authored by martong).
[ASTImporter] Fix redecl failures of FunctionTemplateSpec
Mar 19 2019, 7:05 AM
martong committed rL356455: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.
[ASTImporter] Fix redecl failures of FunctionTemplateSpec
Mar 19 2019, 7:04 AM
martong committed rC356455: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.
[ASTImporter] Fix redecl failures of FunctionTemplateSpec
Mar 19 2019, 7:04 AM
martong closed D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.
Mar 19 2019, 7:04 AM · Restricted Project, Restricted Project
martong updated the diff for D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.
  • Rebase to master
Mar 19 2019, 6:38 AM · Restricted Project, Restricted Project
martong committed rG7f8c400deb7c: [ASTImporter] Fix redecl failures of ClassTemplateSpec (authored by martong).
[ASTImporter] Fix redecl failures of ClassTemplateSpec
Mar 19 2019, 6:33 AM
martong committed rC356452: [ASTImporter] Fix redecl failures of ClassTemplateSpec.
[ASTImporter] Fix redecl failures of ClassTemplateSpec
Mar 19 2019, 6:33 AM
martong committed rL356452: [ASTImporter] Fix redecl failures of ClassTemplateSpec.
[ASTImporter] Fix redecl failures of ClassTemplateSpec
Mar 19 2019, 6:33 AM
martong closed D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec.
Mar 19 2019, 6:33 AM · Restricted Project, Restricted Project
martong added a reviewer for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.: a_sidorin.
Mar 19 2019, 5:31 AM · Restricted Project
martong added a comment to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

We can't reliable import templates with the ASTImporter, so actually reconstructing the template in the debug info AST and then importing it doesn't work.

Could you please elaborate how the import of templates fails in ASTImporter? Is it because the AST you build from the DWARF is incomplete? Or is there a lookup problem? Is there an assertion in one of the CodeGen functions once the import is finished?
If we could fix that error in the ASTImporter then other clients of it (like CTU) could benefit from the fix too. Perhaps, the best would be to have a test which reproduces the template import related errors, maybe a lit test with clang-import-test?

Mar 19 2019, 5:30 AM · Restricted Project
martong resigned from D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC.
Mar 19 2019, 3:59 AM

Mar 14 2019

martong added a comment to D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec.

@shafik Ping

Mar 14 2019, 9:40 AM · Restricted Project, Restricted Project
martong added a comment to D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.

@shafik Ping.

Mar 14 2019, 9:38 AM · Restricted Project, Restricted Project

Mar 8 2019

martong added a reviewer for D55358: [ASTImporter] Fix import of NestedNameSpecifierLoc.: a_sidorin.

Ping

Mar 8 2019, 6:21 AM · Restricted Project, Restricted Project
martong added a comment to D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.

Ping

Mar 8 2019, 6:20 AM · Restricted Project, Restricted Project
martong added a comment to D58897: [ASTImporter] Make ODR error handling configurable.

Ping

Mar 8 2019, 6:20 AM · Restricted Project
martong commandeered D44100: [ASTImporter] Reorder fields after structure import is finished.

@a_sidorin Aleksei, If you don't mind, I am going to investigate this further with macOS/LLDB and try to answer Adrian's comments too.

Mar 8 2019, 1:50 AM · Restricted Project
martong updated the diff for D44100: [ASTImporter] Reorder fields after structure import is finished.

Rebase to master.
There was a conflict in the tests, in ASTImporterTest.cpp.

Mar 8 2019, 1:44 AM · Restricted Project

Mar 7 2019

martong added a comment to D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter..

This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected<T>). Please see the "Stack" column above.

@balazske Or is it superseded by this one? https://reviews.llvm.org/D53818

Mar 7 2019, 7:19 AM · Restricted Project, Restricted Project
Herald added a reviewer for D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.: martong.

Ping. This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected<T>). Please see the "Stack" column above.

Mar 7 2019, 7:10 AM · Restricted Project, Restricted Project
martong committed rG5caba3069e81: [ASTImporter] Import member expr with explicit template args (authored by martong).
[ASTImporter] Import member expr with explicit template args
Mar 7 2019, 5:38 AM
martong committed rC355596: [ASTImporter] Import member expr with explicit template args.
[ASTImporter] Import member expr with explicit template args
Mar 7 2019, 5:37 AM
martong committed rL355596: [ASTImporter] Import member expr with explicit template args.
[ASTImporter] Import member expr with explicit template args
Mar 7 2019, 5:37 AM
martong closed D58830: [ASTImporter] Import member expr with explicit template args.
Mar 7 2019, 5:37 AM · Restricted Project, Restricted Project
martong added inline comments to D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec.
Mar 7 2019, 5:21 AM · Restricted Project, Restricted Project
martong committed rG16d98c206b75: [ASTImporter] Handle redecl chain of FunctionTemplateDecls (authored by martong).
[ASTImporter] Handle redecl chain of FunctionTemplateDecls
Mar 7 2019, 5:03 AM
martong committed rL355593: [ASTImporter] Handle redecl chain of FunctionTemplateDecls.
[ASTImporter] Handle redecl chain of FunctionTemplateDecls
Mar 7 2019, 5:02 AM
martong committed rC355593: [ASTImporter] Handle redecl chain of FunctionTemplateDecls.
[ASTImporter] Handle redecl chain of FunctionTemplateDecls
Mar 7 2019, 5:02 AM
martong closed D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls.
Mar 7 2019, 5:02 AM · Restricted Project
martong added inline comments to D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls.
Mar 7 2019, 1:50 AM · Restricted Project
martong updated the diff for D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls.
  • Add asserts
Mar 7 2019, 1:50 AM · Restricted Project

Mar 5 2019

martong committed rG41e38925ab6b: [ASTImporter] Fix redecl failures of Class and ClassTemplate (authored by martong).
[ASTImporter] Fix redecl failures of Class and ClassTemplate
Mar 5 2019, 3:23 AM
martong committed rC355390: [ASTImporter] Fix redecl failures of Class and ClassTemplate.
[ASTImporter] Fix redecl failures of Class and ClassTemplate
Mar 5 2019, 3:23 AM
martong committed rL355390: [ASTImporter] Fix redecl failures of Class and ClassTemplate.
[ASTImporter] Fix redecl failures of Class and ClassTemplate
Mar 5 2019, 3:22 AM
martong closed D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate.
Mar 5 2019, 3:22 AM · Restricted Project, Restricted Project

Mar 4 2019

martong added a comment to D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec.

Alexei, thanks for the review!

Mar 4 2019, 3:38 AM · Restricted Project, Restricted Project
martong updated the diff for D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec.
  • Fix some comments
Mar 4 2019, 3:38 AM · Restricted Project, Restricted Project
martong updated the diff for D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.
  • Add FindAndMapDefinition as member fun
  • Refactor CheckPreviousDecl
Mar 4 2019, 3:30 AM · Restricted Project, Restricted Project
martong added a comment to D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec.

Alexei, thanks for the review!

Mar 4 2019, 3:28 AM · Restricted Project, Restricted Project

Mar 1 2019

martong created D58830: [ASTImporter] Import member expr with explicit template args.
Mar 1 2019, 7:27 AM · Restricted Project, Restricted Project
martong abandoned D49840: [AST] Add MatchFinder::matchSubtree.
Mar 1 2019, 2:25 AM · Restricted Project