- User Since
- Oct 10 2017, 8:01 AM (105 w, 2 d)
Wed, Oct 9
Tue, Oct 8
Mon, Oct 7
Thu, Oct 3
Wed, Oct 2
With [modern-type-lookup], we completely evade the use of ASTImporterDelegate? That would be a wonderful thing to use only the the ExternalASTMerger on a long term...
Tue, Oct 1
Raphael, thanks for working on this. Overall, the changes look good to me, but please see my comment for the constructor.
Tue, Sep 24
Mon, Sep 23
2nd attempt to fix the windows build errors: 372646
Trying to fix in svn commit 372633.
Fri, Sep 20
BTW, I tried to access the bug reports rdar://55502701 and rdar://55129537, but could not.
I tried at openradar, but there the search for the ID was not successful.
I wonder if there is a publicly accessible (for non Apple employees) URL for these bugs?
Thanks for the thorough explanation about the different ASTContexts in LLDB.
The hack is indeed hideous, but seems good to me... for now until the real solution is born.
Looks good to me, thanks!
Wed, Sep 18
Sep 16 2019
- PrevF->ImportedF, remove braces
Sep 13 2019
I have reorganized the tests to group the ones which test ODR violation strategy independent behaviour.
- Reorganize ODRStrategy independent behaviour tests.
- Initialize the variable template in test
- Clean up tests for fun templates and for specializations
Sep 12 2019
Sep 6 2019
Sep 4 2019
- Fix wrong file comment
Aug 30 2019
Aug 29 2019
- Fix copy error
LGTM, other than a few comments.
Aug 28 2019
Looks good, I just have a comment about the matcher.
Aug 27 2019
Jenkins is not green http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/743/
However, the newly failing test is TestTargetCommand.py, which seems to be unrelated.
- Apply clang-format
- Revert changes in VisitFieldDecl and in VisitIndirectFieldDecl
- Remove test suite ConflictingDeclsWithConservativeStrategy
Aug 26 2019
- Fix typo: getTemplatedDec -> getTemplatedDecl
@shafik I have updated the patch with ODR handling strategies as per our discusson.
- Use resulting Name from HandleNameConflict if set
- Add ODRHandling strategies
- Refactor tests, to avoid some code repetition
Aug 23 2019
... it is highly probable that if some pairs were ever non-equivalent they will stay non-equivalent.
There is a third test which could be useful to test whether there is no faulty cache entries there:
I like this patch because it eliminates the need for checking the redeclaration chains.
The link for the diff went off, sorry about that.
Here is the new link which is going to work:
Aug 22 2019
It looks like that the original code is correct in the decision of structural equivalence of the original pair. If we have an (A,B) and (A,C) to compare, B and C are in different decl chain, then (A,B) or (A,C) will be non-equivalent (unless B and C are equivalent, but what to do in this case?). The problem was that the code assumed that in this case always A and B (or A and C) are non-equivalent. If NonEquivalentDecls is not filled in this case (or not used at all) the problem does not exist.
- Address review comments
Thanks for the review!
Aug 21 2019
- Add tests for default constructible and assignable stateless lambdas
Aug 16 2019
- Name -> SearchName
- Add tests for conflicting declarations