Page MenuHomePhabricator

rafauler (Rafael Auler)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 11:09 AM (179 w, 5 d)

Recent Activity

Jun 15 2021

rafauler added a comment to D97982: [MC] Introduce NeverAlign fragment type.

Probably the simplest way to ensure that computeFragmentSize() is sane is to establish the following rule: it should never examine fragments after the current fragment in the section. If we logically need to examine any fragment after the current fragment, we need to do that using relaxation, inside MCAssembler::layoutSectionOnce. This means we can compute the "current" layout using a single pass computeFragmentSize() calls.

Jun 15 2021, 6:33 PM · Restricted Project

May 18 2021

rafauler committed rGa33687ec584d: [RuntimeDyld] Add allowStubs/allowZeroSyms (authored by rafauler).
[RuntimeDyld] Add allowStubs/allowZeroSyms
May 18 2021, 11:36 AM
rafauler closed D97898: [RuntimeDyld] Add allowStubs/allowZeroSyms.
May 18 2021, 11:36 AM · Restricted Project

May 12 2021

rafauler added a comment to D102284: [Object] Add IsSectionReadOnly section interface.

Hi folks, this patch is part of an effort to bring BOLT to the LLVM repo, so the use case comes from BOLT.

May 12 2021, 11:58 AM · Restricted Project

Apr 27 2021

rafauler edited reviewers for D101353: [DebugInfo] do not add pc value if lsda value in fde is 0, added: rafauler, maksfb, JDevlieghere, dblaikie; removed: rafaelauler.
Apr 27 2021, 11:44 AM · Restricted Project
rafauler added a comment to D101353: [DebugInfo] do not add pc value if lsda value in fde is 0.

Hi @dongAxis1944, thanks for submitting this!

Apr 27 2021, 11:36 AM · Restricted Project

Apr 21 2021

rafauler added a comment to D97891: Add register size info back to MCRegisterClass.

Yes. Also, I'll rebase BOLT soon (past this patch).

Apr 21 2021, 9:08 PM · Restricted Project

Apr 14 2021

rafauler committed rGb7459a10dad1: [DWARF] Fix crash for DWARFDie::dump. (authored by ayermolo).
[DWARF] Fix crash for DWARFDie::dump.
Apr 14 2021, 6:47 PM
rafauler closed D99698: [DWARF] Fix crash for DWARFDie::dump..
Apr 14 2021, 6:47 PM · Restricted Project

Mar 23 2021

rafauler committed rG53196387c201: Add register size info back to MCRegisterClass (authored by rafauler).
Add register size info back to MCRegisterClass
Mar 23 2021, 3:05 PM
rafauler closed D97891: Add register size info back to MCRegisterClass.
Mar 23 2021, 3:05 PM · Restricted Project

Mar 18 2021

rafauler added a comment to D98560: [RuntimeDyld] Fix range checks for R_X86_64_{8,16}.

Linux only

Mar 18 2021, 4:55 PM · Restricted Project

Mar 16 2021

rafauler added a comment to D98560: [RuntimeDyld] Fix range checks for R_X86_64_{8,16}.

Thanks @lhames
Let me work on that
BOLT targets X86 and AArch64.

Mar 16 2021, 11:53 AM · Restricted Project

Mar 15 2021

rafauler added a comment to D98560: [RuntimeDyld] Fix range checks for R_X86_64_{8,16}.

Maybe, but this discussion is orthogonal to this fix, right? I can't answer for other clients of RuntimeDyld (JIT stuff), but having asserts in the library is fine for BOLT.

Mar 15 2021, 4:59 PM · Restricted Project

Mar 12 2021

rafauler requested review of D98560: [RuntimeDyld] Fix range checks for R_X86_64_{8,16}.
Mar 12 2021, 2:57 PM · Restricted Project

Mar 10 2021

rafauler added a comment to D97899: [RuntimeDyld] Support more relocations.

Thanks, MaskRay, I'll fix this

Mar 10 2021, 7:31 PM · Restricted Project
rafauler added inline comments to D97531: [RuntimeDyld] Speedup resolution of relocations to external symbols.
Mar 10 2021, 4:42 PM · Restricted Project
rafauler added a comment to D97899: [RuntimeDyld] Support more relocations.

I took a look at JITLink, including the design document, and it doesn't look like it will need to support 8B and 16B relocs. It looks like it was developed to support code generated by LLVM and LLVM will never emit those. According to the x86-64-psABI document:

Mar 10 2021, 3:19 PM · Restricted Project
rafauler committed rGe4b40616d4cd: [RuntimeDyld] Support more relocations (authored by rafauler).
[RuntimeDyld] Support more relocations
Mar 10 2021, 11:20 AM
rafauler closed D97899: [RuntimeDyld] Support more relocations.
Mar 10 2021, 11:20 AM · Restricted Project
rafauler added a comment to D97899: [RuntimeDyld] Support more relocations.

Sure, let me take a look at that.

Mar 10 2021, 10:54 AM · Restricted Project

Mar 9 2021

rafauler requested review of D98301: [RFC] Support DWARF expressions in CFI instructions.
Mar 9 2021, 3:43 PM · Restricted Project

Mar 8 2021

rafauler committed rG7a3e664db576: [DebugInfo] Do not error on unsupported CIE version (authored by rafauler).
[DebugInfo] Do not error on unsupported CIE version
Mar 8 2021, 7:53 PM
rafauler closed D97830: [DebugInfo] Do not error on unsupported CIE version.
Mar 8 2021, 7:52 PM · Restricted Project
rafauler updated the diff for D97830: [DebugInfo] Do not error on unsupported CIE version.

Rebasing

Mar 8 2021, 6:37 PM · Restricted Project

Mar 5 2021

rafauler added a comment to D97891: Add register size info back to MCRegisterClass.

I'm not ignoring the HW mode stuff, I added a short explanation in the comments instructing users to give TargetRegisterInfo a try if they can but that's all I could think of. Last time I checked, I couldn't access TargetRegisterInfo as a library user because everything is accessible only to code living inside libTarget, which itself exposes only a limited high-level interface to the outside world, such as "run backend passes". If there is a way to get this info as a library user, I'll be happy to do it. Let me know if it is possible and I'll try to hack BOLT code to get to it.

Mar 5 2021, 7:47 PM · Restricted Project
rafauler updated the diff for D97891: Add register size info back to MCRegisterClass.

clang format

Mar 5 2021, 4:26 PM · Restricted Project
rafauler added a comment to D97891: Add register size info back to MCRegisterClass.

I changed the function name to getSizeInBits() so that out of tree targets that rebase LLVM past the removal of getSize() and get it added back again won't be surprised by a different size being returned by a function with the same name.

Mar 5 2021, 3:58 PM · Restricted Project
rafauler updated the diff for D97891: Add register size info back to MCRegisterClass.

Addressing comments

Mar 5 2021, 3:55 PM · Restricted Project
rafauler retitled D97891: Add register size info back to MCRegisterClass from Revert "[MC] Remove PhysRegSize from MCRegisterClass" to Add register size info back to MCRegisterClass.
Mar 5 2021, 3:54 PM · Restricted Project

Mar 4 2021

rafauler added a comment to D97891: Add register size info back to MCRegisterClass.

If you need this I'd rather "add the needed support" than doing it as a revert

Mar 4 2021, 5:41 PM · Restricted Project

Mar 3 2021

rafauler requested review of D97899: [RuntimeDyld] Support more relocations.
Mar 3 2021, 5:50 PM · Restricted Project
rafauler requested review of D97898: [RuntimeDyld] Add allowStubs/allowZeroSyms.
Mar 3 2021, 5:46 PM · Restricted Project
rafauler added a comment to D97891: Add register size info back to MCRegisterClass.

Let me know if there is another way to solve this without reverting this.

Mar 3 2021, 3:12 PM · Restricted Project
rafauler added a reverting change for rGc8b782cec2da: [MC] Remove PhysRegSize from MCRegisterClass: D97891: Add register size info back to MCRegisterClass.
Mar 3 2021, 3:11 PM
rafauler requested review of D97891: Add register size info back to MCRegisterClass.
Mar 3 2021, 3:11 PM · Restricted Project
rafauler added a reverting change for D47199: [MC] Remove PhysRegSize from MCRegisterClass: D97891: Add register size info back to MCRegisterClass.
Mar 3 2021, 3:11 PM

Mar 2 2021

rafauler requested review of D97830: [DebugInfo] Do not error on unsupported CIE version.
Mar 2 2021, 8:54 PM · Restricted Project

Feb 23 2021

rafauler abandoned D58216: Support attribute used in member funcs of class templates II.
Feb 23 2021, 3:59 PM · Restricted Project

Mar 22 2019

rafauler added a comment to D59696: [CGP] Build the DominatorTree lazily.

Thanks for working on this!

Mar 22 2019, 11:35 AM · Restricted Project
rafauler added a comment to D58995: [CGP] Avoid repeatedly building DominatorTree causing long compile-time (NFC).

Hi, do we know whether this patch fully mitigated the issue or if there are still opportunities to improve compile time? I'm using clang trunk from Wednesday March 20th, and I cannot finish the compilation of a large project with ThinLTO and autofdo profile (compilation time was reasonable before, but ballooned to over 10 hours). When I run perf top to see what is happening, I see that the compiler is most of the time in code dealing with dominator trees or in CodeGenPrepare::runOnFunction. I don't remember seeing this issue before (Clang from February). A snapshot of hottest functions while waiting for the never finishing linking:

Mar 22 2019, 10:50 AM · Restricted Project

Mar 20 2019

rafauler committed rG9dde31ecc157: Recommit "Support attribute used in member funcs of class templates" (authored by rafauler).
Recommit "Support attribute used in member funcs of class templates"
Mar 20 2019, 12:26 PM
rafauler committed rL356598: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 20 2019, 12:21 PM
rafauler committed rC356598: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 20 2019, 12:21 PM
rafauler committed rG6dc53ccb0b09: [Linker] Fix crash handling appending linkage (authored by rafauler).
[Linker] Fix crash handling appending linkage
Mar 20 2019, 12:19 PM
rafauler committed rL356597: [Linker] Fix crash handling appending linkage.
[Linker] Fix crash handling appending linkage
Mar 20 2019, 12:19 PM
rafauler closed D59552: [Linker] Fix crash handling appending linkage.
Mar 20 2019, 12:18 PM · Restricted Project

Mar 19 2019

rafauler added inline comments to D59552: [Linker] Fix crash handling appending linkage.
Mar 19 2019, 3:34 PM · Restricted Project
rafauler updated the diff for D59552: [Linker] Fix crash handling appending linkage.

Eli's suggestions

Mar 19 2019, 3:02 PM · Restricted Project
rafauler added a comment to D59552: [Linker] Fix crash handling appending linkage.

Thanks for your feedback, Eli

Mar 19 2019, 3:01 PM · Restricted Project
rafauler created D59552: [Linker] Fix crash handling appending linkage.
Mar 19 2019, 10:32 AM · Restricted Project

Mar 8 2019

rafauler committed rG94b575b23bde: Revert "Recommit "Support attribute used in member funcs of class templates"" (authored by rafauler).
Revert "Recommit "Support attribute used in member funcs of class templates""
Mar 8 2019, 12:24 PM
rafauler committed rC355721: Revert "Recommit "Support attribute used in member funcs of class templates"".
Revert "Recommit "Support attribute used in member funcs of class templates""
Mar 8 2019, 12:23 PM
rafauler committed rL355721: Revert "Recommit "Support attribute used in member funcs of class templates"".
Revert "Recommit "Support attribute used in member funcs of class templates""
Mar 8 2019, 12:23 PM
rafauler added a comment to D58216: Support attribute used in member funcs of class templates II.

I definitely understand how the diagnostic can be confusing. However, it's the same diagnostic gcc provides too, so gcc users wouldn't be surprised. But you're right this can be improved by at least mentioning the attribute used in the diagnostic message. There's no bug report to this yet, it would be nice to file it.

Mar 8 2019, 10:40 AM · Restricted Project

Mar 7 2019

rafauler committed rG2ead8e899327: Recommit "Support attribute used in member funcs of class templates" (authored by rafauler).
Recommit "Support attribute used in member funcs of class templates"
Mar 7 2019, 11:14 AM
rafauler committed rL355627: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 7 2019, 11:13 AM
rafauler committed rC355627: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 7 2019, 11:13 AM

Mar 6 2019

rafauler added a comment to D58216: Support attribute used in member funcs of class templates II.

I'm not an expert in swift either. I'll wait for @davezarzycki input on what's happening, but I suspect the code base is indeed incompatible with gcc due to the nature of the error they experienced. This testcase is creduce-d from what I observed in swift.

Mar 6 2019, 3:04 PM · Restricted Project
rafauler updated subscribers of D58216: Support attribute used in member funcs of class templates II.

Both approaches make sense to me. I'll re-land the previous patch in favor of gcc compatibility, since the semantics of attribute used in member functions of class templates were first implemented in gcc.

Mar 6 2019, 11:03 AM · Restricted Project

Feb 18 2019

rafauler added a comment to D57904: [llvm-objdump] Allow short options to be grouped.

That’s fine by me.

Feb 18 2019, 2:33 PM · Restricted Project

Feb 13 2019

rafauler created D58216: Support attribute used in member funcs of class templates II.
Feb 13 2019, 4:26 PM · Restricted Project

Jan 31 2019

rafauler committed rC352748: Revert "Support attribute used in member funcs of class templates".
Revert "Support attribute used in member funcs of class templates"
Jan 31 2019, 5:31 AM
rafauler added a reverting change for rC352740: Support attribute used in member funcs of class templates: rC352748: Revert "Support attribute used in member funcs of class templates".
Jan 31 2019, 5:31 AM
rafauler committed rL352748: Revert "Support attribute used in member funcs of class templates".
Revert "Support attribute used in member funcs of class templates"
Jan 31 2019, 5:31 AM
rafauler added a reverting change for rL352740: Support attribute used in member funcs of class templates: rL352748: Revert "Support attribute used in member funcs of class templates".
Jan 31 2019, 5:31 AM
rafauler added a comment to D56928: Support attribute used in member funcs of class templates.

Hi davezarzycki, thanks for reporting this! This is not expected, I'll revert this diff for now. Sorry for this.

Jan 31 2019, 5:26 AM · Restricted Project
rafauler committed rL352740: Support attribute used in member funcs of class templates.
Support attribute used in member funcs of class templates
Jan 31 2019, 1:41 AM
rafauler committed rC352740: Support attribute used in member funcs of class templates.
Support attribute used in member funcs of class templates
Jan 31 2019, 1:40 AM
rafauler closed D56928: Support attribute used in member funcs of class templates.
Jan 31 2019, 1:40 AM · Restricted Project
rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

Thanks for reviewing!

Jan 31 2019, 12:55 AM · Restricted Project

Jan 29 2019

rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

Rebase + Aaron's suggestions. Thanks for the suggestions!

Jan 29 2019, 12:39 AM · Restricted Project

Jan 25 2019

rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

No problem, thanks for your suggestions!

Jan 25 2019, 4:34 PM · Restricted Project

Jan 18 2019

rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

Removing facebook tags

Jan 18 2019, 12:24 PM · Restricted Project
rafauler created D56928: Support attribute used in member funcs of class templates.
Jan 18 2019, 12:23 PM · Restricted Project

Jul 9 2018

rafauler added a comment to D49000: [DebugInfo] Change default value of FDEPointerEncoding.

@MaskRay this was originally reported here: https://github.com/facebookincubator/BOLT/issues/23

Jul 9 2018, 11:02 AM

Jul 5 2018

rafauler edited reviewers for D49000: [DebugInfo] Change default value of FDEPointerEncoding, added: rafauler; removed: rafaelauler.
Jul 5 2018, 3:39 PM

Mar 27 2018

rafauler added a comment to D44851: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.

Thanks for reviewing!

Mar 27 2018, 10:01 AM
rafauler committed rL328638: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.
[AArch64] Decorate AArch64 instrs with OPERAND_PCREL
Mar 27 2018, 10:01 AM
rafauler closed D44851: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.
Mar 27 2018, 10:00 AM

Mar 23 2018

rafauler created D44851: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.
Mar 23 2018, 3:59 PM

Mar 9 2018

rafauler added a comment to D44224: [llvm-objdump] Support disassembling by symbol name.

Thank you Rafael and Jonas for reviewing

Mar 9 2018, 11:20 AM
rafauler committed rL327164: [llvm-objdump] Support disassembling by symbol name.
[llvm-objdump] Support disassembling by symbol name
Mar 9 2018, 11:18 AM
rafauler closed D44224: [llvm-objdump] Support disassembling by symbol name.
Mar 9 2018, 11:18 AM
rafauler updated the diff for D44224: [llvm-objdump] Support disassembling by symbol name.

Removing the if

Mar 9 2018, 10:53 AM

Mar 8 2018

rafauler updated the diff for D44224: [llvm-objdump] Support disassembling by symbol name.

Implement suggestions

Mar 8 2018, 12:01 PM
rafauler updated subscribers of D44224: [llvm-objdump] Support disassembling by symbol name.

This is static because the function DisassembleObject potentially runs multiple times. So the static is to avoid re-creating the same set for each object, and it's also why it checks if it is empty.

Mar 8 2018, 4:43 AM

Mar 7 2018

rafauler committed rL326970: Reland "[DebugInfo] Support DWARF expressions in eh_frame".
Reland "[DebugInfo] Support DWARF expressions in eh_frame"
Mar 7 2018, 4:49 PM
rafauler created D44224: [llvm-objdump] Support disassembling by symbol name.
Mar 7 2018, 12:13 PM
rafauler added a comment to D43313: [DebugInfo] Support parsing DWARF expressions.

Thanks everyone that helped to review this, I appreciate your help.

Mar 7 2018, 11:29 AM
rafauler committed rL326932: [DebugInfo] Support DWARF expressions in eh_frame.
[DebugInfo] Support DWARF expressions in eh_frame
Mar 7 2018, 11:23 AM
rafauler closed D43313: [DebugInfo] Support parsing DWARF expressions.
Mar 7 2018, 11:23 AM

Mar 5 2018

rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Change the test case input from binary to YAML.

Mar 5 2018, 5:06 PM
rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Address comments.

Mar 5 2018, 3:43 PM
rafauler added inline comments to D43313: [DebugInfo] Support parsing DWARF expressions.
Mar 5 2018, 3:41 PM

Mar 1 2018

rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Address rafael's comments

Mar 1 2018, 4:24 PM
rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Addressing rafael's comments

Mar 1 2018, 2:59 PM
rafauler added inline comments to D43313: [DebugInfo] Support parsing DWARF expressions.
Mar 1 2018, 10:38 AM

Feb 28 2018

rafauler added a comment to D43313: [DebugInfo] Support parsing DWARF expressions.

Sorry I just saw rafael's comments, I'll address them too.

Feb 28 2018, 8:36 PM
rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Address comments.

Feb 28 2018, 8:29 PM