Page MenuHomePhabricator

rafauler (Rafael Auler)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2018, 11:09 AM (95 w, 2 d)

Recent Activity

Mar 22 2019

rafauler added a comment to D59696: [CGP] Build the DominatorTree lazily.

Thanks for working on this!

Mar 22 2019, 11:35 AM · Restricted Project
rafauler added a comment to D58995: [CGP] Avoid repeatedly building DominatorTree causing long compile-time (NFC).

Hi, do we know whether this patch fully mitigated the issue or if there are still opportunities to improve compile time? I'm using clang trunk from Wednesday March 20th, and I cannot finish the compilation of a large project with ThinLTO and autofdo profile (compilation time was reasonable before, but ballooned to over 10 hours). When I run perf top to see what is happening, I see that the compiler is most of the time in code dealing with dominator trees or in CodeGenPrepare::runOnFunction. I don't remember seeing this issue before (Clang from February). A snapshot of hottest functions while waiting for the never finishing linking:

Mar 22 2019, 10:50 AM · Restricted Project

Mar 20 2019

rafauler committed rG9dde31ecc157: Recommit "Support attribute used in member funcs of class templates" (authored by rafauler).
Recommit "Support attribute used in member funcs of class templates"
Mar 20 2019, 12:26 PM
rafauler committed rL356598: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 20 2019, 12:21 PM
rafauler committed rC356598: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 20 2019, 12:21 PM
rafauler committed rG6dc53ccb0b09: [Linker] Fix crash handling appending linkage (authored by rafauler).
[Linker] Fix crash handling appending linkage
Mar 20 2019, 12:19 PM
rafauler committed rL356597: [Linker] Fix crash handling appending linkage.
[Linker] Fix crash handling appending linkage
Mar 20 2019, 12:19 PM
rafauler closed D59552: [Linker] Fix crash handling appending linkage.
Mar 20 2019, 12:18 PM · Restricted Project

Mar 19 2019

rafauler added inline comments to D59552: [Linker] Fix crash handling appending linkage.
Mar 19 2019, 3:34 PM · Restricted Project
rafauler updated the diff for D59552: [Linker] Fix crash handling appending linkage.

Eli's suggestions

Mar 19 2019, 3:02 PM · Restricted Project
rafauler added a comment to D59552: [Linker] Fix crash handling appending linkage.

Thanks for your feedback, Eli

Mar 19 2019, 3:01 PM · Restricted Project
rafauler created D59552: [Linker] Fix crash handling appending linkage.
Mar 19 2019, 10:32 AM · Restricted Project

Mar 8 2019

rafauler committed rG94b575b23bde: Revert "Recommit "Support attribute used in member funcs of class templates"" (authored by rafauler).
Revert "Recommit "Support attribute used in member funcs of class templates""
Mar 8 2019, 12:24 PM
rafauler committed rC355721: Revert "Recommit "Support attribute used in member funcs of class templates"".
Revert "Recommit "Support attribute used in member funcs of class templates""
Mar 8 2019, 12:23 PM
rafauler committed rL355721: Revert "Recommit "Support attribute used in member funcs of class templates"".
Revert "Recommit "Support attribute used in member funcs of class templates""
Mar 8 2019, 12:23 PM
rafauler added a comment to D58216: Support attribute used in member funcs of class templates II.

I definitely understand how the diagnostic can be confusing. However, it's the same diagnostic gcc provides too, so gcc users wouldn't be surprised. But you're right this can be improved by at least mentioning the attribute used in the diagnostic message. There's no bug report to this yet, it would be nice to file it.

Mar 8 2019, 10:40 AM · Restricted Project

Mar 7 2019

rafauler committed rG2ead8e899327: Recommit "Support attribute used in member funcs of class templates" (authored by rafauler).
Recommit "Support attribute used in member funcs of class templates"
Mar 7 2019, 11:14 AM
rafauler committed rL355627: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 7 2019, 11:13 AM
rafauler committed rC355627: Recommit "Support attribute used in member funcs of class templates".
Recommit "Support attribute used in member funcs of class templates"
Mar 7 2019, 11:13 AM

Mar 6 2019

rafauler added a comment to D58216: Support attribute used in member funcs of class templates II.

I'm not an expert in swift either. I'll wait for @davezarzycki input on what's happening, but I suspect the code base is indeed incompatible with gcc due to the nature of the error they experienced. This testcase is creduce-d from what I observed in swift.

Mar 6 2019, 3:04 PM · Restricted Project
rafauler updated subscribers of D58216: Support attribute used in member funcs of class templates II.

Both approaches make sense to me. I'll re-land the previous patch in favor of gcc compatibility, since the semantics of attribute used in member functions of class templates were first implemented in gcc.

Mar 6 2019, 11:03 AM · Restricted Project

Feb 18 2019

rafauler added a comment to D57904: [llvm-objdump] Allow short options to be grouped.

That’s fine by me.

Feb 18 2019, 2:33 PM · Restricted Project

Feb 13 2019

rafauler created D58216: Support attribute used in member funcs of class templates II.
Feb 13 2019, 4:26 PM · Restricted Project

Jan 31 2019

rafauler committed rC352748: Revert "Support attribute used in member funcs of class templates".
Revert "Support attribute used in member funcs of class templates"
Jan 31 2019, 5:31 AM
rafauler added a reverting change for rC352740: Support attribute used in member funcs of class templates: rC352748: Revert "Support attribute used in member funcs of class templates".
Jan 31 2019, 5:31 AM
rafauler committed rL352748: Revert "Support attribute used in member funcs of class templates".
Revert "Support attribute used in member funcs of class templates"
Jan 31 2019, 5:31 AM
rafauler added a reverting change for rL352740: Support attribute used in member funcs of class templates: rL352748: Revert "Support attribute used in member funcs of class templates".
Jan 31 2019, 5:31 AM
rafauler added a comment to D56928: Support attribute used in member funcs of class templates.

Hi davezarzycki, thanks for reporting this! This is not expected, I'll revert this diff for now. Sorry for this.

Jan 31 2019, 5:26 AM · Restricted Project
rafauler committed rL352740: Support attribute used in member funcs of class templates.
Support attribute used in member funcs of class templates
Jan 31 2019, 1:41 AM
rafauler committed rC352740: Support attribute used in member funcs of class templates.
Support attribute used in member funcs of class templates
Jan 31 2019, 1:40 AM
rafauler closed D56928: Support attribute used in member funcs of class templates.
Jan 31 2019, 1:40 AM · Restricted Project
rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

Thanks for reviewing!

Jan 31 2019, 12:55 AM · Restricted Project

Jan 29 2019

rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

Rebase + Aaron's suggestions. Thanks for the suggestions!

Jan 29 2019, 12:39 AM · Restricted Project

Jan 25 2019

rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

No problem, thanks for your suggestions!

Jan 25 2019, 4:34 PM · Restricted Project

Jan 18 2019

rafauler updated the diff for D56928: Support attribute used in member funcs of class templates.

Removing facebook tags

Jan 18 2019, 12:24 PM · Restricted Project
rafauler created D56928: Support attribute used in member funcs of class templates.
Jan 18 2019, 12:23 PM · Restricted Project

Jul 9 2018

rafauler added a comment to D49000: [DebugInfo] Change default value of FDEPointerEncoding.

@MaskRay this was originally reported here: https://github.com/facebookincubator/BOLT/issues/23

Jul 9 2018, 11:02 AM

Jul 5 2018

rafauler edited reviewers for D49000: [DebugInfo] Change default value of FDEPointerEncoding, added: rafauler; removed: rafaelauler.
Jul 5 2018, 3:39 PM

Mar 27 2018

rafauler added a comment to D44851: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.

Thanks for reviewing!

Mar 27 2018, 10:01 AM
rafauler committed rL328638: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.
[AArch64] Decorate AArch64 instrs with OPERAND_PCREL
Mar 27 2018, 10:01 AM
rafauler closed D44851: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.
Mar 27 2018, 10:00 AM

Mar 23 2018

rafauler created D44851: [AArch64] Decorate AArch64 instrs with OPERAND_PCREL.
Mar 23 2018, 3:59 PM

Mar 9 2018

rafauler added a comment to D44224: [llvm-objdump] Support disassembling by symbol name.

Thank you Rafael and Jonas for reviewing

Mar 9 2018, 11:20 AM
rafauler committed rL327164: [llvm-objdump] Support disassembling by symbol name.
[llvm-objdump] Support disassembling by symbol name
Mar 9 2018, 11:18 AM
rafauler closed D44224: [llvm-objdump] Support disassembling by symbol name.
Mar 9 2018, 11:18 AM
rafauler updated the diff for D44224: [llvm-objdump] Support disassembling by symbol name.

Removing the if

Mar 9 2018, 10:53 AM

Mar 8 2018

rafauler updated the diff for D44224: [llvm-objdump] Support disassembling by symbol name.

Implement suggestions

Mar 8 2018, 12:01 PM
rafauler updated subscribers of D44224: [llvm-objdump] Support disassembling by symbol name.

This is static because the function DisassembleObject potentially runs multiple times. So the static is to avoid re-creating the same set for each object, and it's also why it checks if it is empty.

Mar 8 2018, 4:43 AM

Mar 7 2018

rafauler committed rL326970: Reland "[DebugInfo] Support DWARF expressions in eh_frame".
Reland "[DebugInfo] Support DWARF expressions in eh_frame"
Mar 7 2018, 4:49 PM
rafauler created D44224: [llvm-objdump] Support disassembling by symbol name.
Mar 7 2018, 12:13 PM
rafauler added a comment to D43313: [DebugInfo] Support parsing DWARF expressions.

Thanks everyone that helped to review this, I appreciate your help.

Mar 7 2018, 11:29 AM
rafauler committed rL326932: [DebugInfo] Support DWARF expressions in eh_frame.
[DebugInfo] Support DWARF expressions in eh_frame
Mar 7 2018, 11:23 AM
rafauler closed D43313: [DebugInfo] Support parsing DWARF expressions.
Mar 7 2018, 11:23 AM

Mar 5 2018

rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Change the test case input from binary to YAML.

Mar 5 2018, 5:06 PM
rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Address comments.

Mar 5 2018, 3:43 PM
rafauler added inline comments to D43313: [DebugInfo] Support parsing DWARF expressions.
Mar 5 2018, 3:41 PM

Mar 1 2018

rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Address rafael's comments

Mar 1 2018, 4:24 PM
rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Addressing rafael's comments

Mar 1 2018, 2:59 PM
rafauler added inline comments to D43313: [DebugInfo] Support parsing DWARF expressions.
Mar 1 2018, 10:38 AM

Feb 28 2018

rafauler added a comment to D43313: [DebugInfo] Support parsing DWARF expressions.

Sorry I just saw rafael's comments, I'll address them too.

Feb 28 2018, 8:36 PM
rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

Address comments.

Feb 28 2018, 8:29 PM

Feb 20 2018

rafauler updated the diff for D43313: [DebugInfo] Support parsing DWARF expressions.

The fact that DataExtractor already has read*LEB128 is an important
point. So I decided to move the only missing helper,
"readEncodedPointer", into DataExtractor. However, it is DWARF-specific.
So I've put it into DWARFDataExtractor and made the necessary
adjustments. I've addressed your other concerns as well, let me know if
this is fine.

Feb 20 2018, 1:05 PM

Feb 15 2018

rafauler added a comment to D43313: [DebugInfo] Support parsing DWARF expressions.

Thanks Adrian, I'll drop the \brief. That makes sense, thanks for the context on DataExtractor versus other approaches. In our client code, it never made a lot of sense to use DataExtractor and that's part of the reason I was lifting DWARF decoding helpers to live on their own. Then I was using readobj as a proxy for our client code so we have something upstream that demonstrates how we are accessing and manipulating DWARF CFIs (both coming from FDEs and CIEs). Then I'll take a second look on this design to avoid pitfalls with unchecked bounds.

Feb 15 2018, 1:59 PM
rafauler committed rL325295: [X86][3DNOW] Teach decoder about AMD 3DNow! instrs.
[X86][3DNOW] Teach decoder about AMD 3DNow! instrs
Feb 15 2018, 1:23 PM
rafauler closed D43311: [X86][3DNOW] Teach decoder about AMD 3DNow! instrs.
Feb 15 2018, 1:23 PM
rafauler updated the diff for D43311: [X86][3DNOW] Teach decoder about AMD 3DNow! instrs.

Add a more complete LIT file that tests all opcodes

Feb 15 2018, 11:37 AM

Feb 14 2018

rafauler added inline comments to D43311: [X86][3DNOW] Teach decoder about AMD 3DNow! instrs.
Feb 14 2018, 4:18 PM
rafauler created D43313: [DebugInfo] Support parsing DWARF expressions.
Feb 14 2018, 12:15 PM
rafauler added a comment to D43311: [X86][3DNOW] Teach decoder about AMD 3DNow! instrs.

np, thanks for reviewing this!

Feb 14 2018, 12:05 PM
rafauler created D43311: [X86][3DNOW] Teach decoder about AMD 3DNow! instrs.
Feb 14 2018, 11:44 AM