- User Since
- Feb 14 2018, 11:09 AM (293 w, 2 d)
Tue, Sep 12
Mon, Sep 11
Fix stack alignment in testcases, which caused libc's puts() stack to
crash in ubuntu systems because libc was using movaps in malloc
Aug 29 2023
Triggering build tests again after removing parent revs
In this solution, we don't need to mark any symbols as globals and therefore I've removed the dependency on the parent diff "[BOLT] Local hidden should be global syms."
Aug 28 2023
Thanks a bunch @lhames , that works!
Thanks for the review!
Aug 25 2023
I'll commit this fix since this seems low-risk enough to unblock buildbots crosscompiling. If it is not an adequate fix, feel free to revert it.
Aug 24 2023
I'm not sure why runtime/X86/reg-reassign-swap-cold.s is failing. I can't repro the failure. I would suggest submitting your changes on another revision using arc diff --draft, so it is not published, but you can still run the tests to see if they pass, and they debug it from there -- perhaps by removing modifications you did to see if the test pass, getting hints on what is wrong.
Aug 23 2023
Thanks for working on this. LGTM
Aug 22 2023
Aug 18 2023
I think you forgot to delete the now unnecessary CodePointerSize parameter.
Thanks Elvina! LGTM
Aug 16 2023
Aug 9 2023
Aug 8 2023
Thanks! LGTM with some modifications I made to the test file available here: https://pastebin.com/3abP1S5G
Aug 7 2023
Thanks! I can start looking into this next week (and the week after it) during my shift.
Thanks! Mostly formatting nits:
Jul 31 2023
Thanks for the context, the fix looks good to me. Unfortunately, we can't check in the test as is because we can't guarantee the .fdata file will always make sense -- we would typically write this test in assembly language to guarantee offsets remain the same.
Jul 20 2023
Jul 18 2023
Jul 11 2023
Thanks for fixing this. We do need context for the diff and a test case.
Jul 10 2023
Jul 6 2023
Jul 5 2023
I wonder why is this diff not showing up on top of the D151899 diff stack anymore? Isn't it dependent on that stack?
Thanks for working on this @treapster . Can you add to your diff stack a diff that adds a test that uses this improved mechanism?
Jun 29 2023
LGTM without the test
Jun 28 2023
Jun 27 2023
Jun 26 2023
Thanks @treapster , can you try to rebase on top of current bolt now? I can't test it if the diff doesn't cleanly apply on top of what we have on trunk, and JITLink changed BOLT quite a bit.
We need a test that checks indirect calls are correctly handled, like the one we have in D153771
Thanks for working on fixing these issues, @treapster! I have some suggestions below.
Jun 22 2023
Jun 21 2023
Jun 20 2023
Can we have a small test case showing the bug?
Ping. Can't we just remove this assertion? Is it worth making the runtime much slower to check that we don't have a duplicate external symbol?
Jun 15 2023
Jun 8 2023
Jun 7 2023
Jun 5 2023
Where does this happen?