Page MenuHomePhabricator
Differential D88613

[flang] Semantic analysis for FINAL subroutines
ClosedPublic
Actions

Authored by klausler on Sep 30 2020, 1:27 PM.

Details

Reviewers
tskeith
jdoerfert
Commits
rG37b2e2b04cf4: [flang] Semantic analysis for FINAL subroutines
Summary

Represent FINAL subroutines in the symbol table entries of
derived types. Enforce constraints. Update tests that have
inadvertent violations or modified messages. Added a test.

The specific procedure distinguishability checking code for generics
was used to enforce distinguishability of FINAL procedures.
(Also cleaned up some confusion and redundancy noticed in the
type compatibility infrastructure while digging into that area.)

Diff Detail

Event Timeline

klausler created this revision.Sep 30 2020, 1:27 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptSep 30 2020, 1:27 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
klausler requested review of this revision.Sep 30 2020, 1:27 PM
Harbormaster completed remote builds in B73574: Diff 295392.Sep 30 2020, 1:41 PM
tskeith added inline comments.Sep 30 2020, 1:50 PM
flang/lib/Semantics/check-declarations.cpp
849

With clang 9 I get this error:

error: reference to local binding 'ref' declared in enclosing function 'Fortran::semantics::CheckHelper::CheckDerivedType'

And same for source.

klausler added inline comments.Sep 30 2020, 1:57 PM
flang/lib/Semantics/check-declarations.cpp
849

Thanks, I'll work around that and push an update shortly.

klausler updated this revision to Diff 295417.Sep 30 2020, 2:54 PM

Worked around clang error noticed by code reviewer, & added
a "const" suggested by the clang-tidy bot.

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptSep 30 2020, 2:54 PM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: JDevlieghere. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, lldb-commits, Restricted Project and 28 others. · View Herald Transcript
klausler updated this revision to Diff 295423.Sep 30 2020, 3:09 PM

Previous update to this review had inadvertent changes to other files because I neglected to rebase after updating master; now fixed. Sorry for the scare!

klausler removed reviewers: nicolasvasilache, aartbik, JDevlieghere, Restricted Project.Sep 30 2020, 3:11 PM
klausler removed projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project.
klausler removed subscribers: mgorny, sbc100, fedor.sergeev and 29 others.
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2020, 3:11 PM
Harbormaster completed remote builds in B73588: Diff 295423.Sep 30 2020, 3:27 PM
tskeith accepted this revision.Sep 30 2020, 3:35 PM
This revision is now accepted and ready to land.Sep 30 2020, 3:35 PM
Closed by commit rG37b2e2b04cf4: [flang] Semantic analysis for FINAL subroutines (authored by klausler). · Explain WhySep 30 2020, 3:47 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG37b2e2b04cf4: [flang] Semantic analysis for FINAL subroutines.
Harbormaster completed remote builds in B73585: Diff 295417.Sep 30 2020, 4:25 PM

Large Diff

This large diff affects 106 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
clang/
lib/
AST/
8 lines
2 lines
CodeGen/
3 lines
Driver/
ToolChains/
3 lines
Sema/
2 lines
7 lines
test/
CodeGen/
Driver/
25 lines
Sema/
4 lines
SemaCXX/
compiler-rt/
lib/
scudo/
standalone/
14 lines
117 lines
8 lines
16 lines
12 lines
test/
asan/
TestCases/
Posix/
2 lines
23 lines
debuginfo-tests/
10 lines
6 lines
2 lines
llvm-prettyprinters/
gdb/
4 lines
15 lines
flang/
include/
flang/
Evaluate/
2 lines
6 lines
Semantics/
7 lines
15 lines
lib/
Evaluate/
2 lines
1 line
90 lines
Semantics/
27 lines
167 lines
3 lines
20 lines
2 lines
18 lines
2 lines
64 lines
runtime/
16 lines
test/
Semantics/
4 lines
4 lines
119 lines
2 lines
2 lines
19 lines
unittests/
Runtime/
36 lines
libcxx/
lib/
abi/
3 lines
lldb/
include/
lldb/
Core/
14 lines
packages/
Python/
lldbsuite/
test/
tools/
lldb-server/
10 lines
lldb-vscode/
22 lines
source/
Plugins/
Process/
gdb-remote/
4 lines
test/
API/
functionalities/
gdb_remote_client/
13 lines
python_api/
sbstructureddata/
7 lines
tools/
lldb-server/
commandline/
14 lines
lldb-vscode/
breakpoint/
42 lines
tools/
lldb-server/
3 lines
lldb-vscode/
43 lines
unittests/
Host/
69 lines
11 lines
llvm/
include/
llvm/
CodeGen/
11 lines
3 lines
Target/
6 lines
lib/
CodeGen/
AsmPrinter/
11 lines
7 lines
43 lines
268 lines
1 line
1 line
21 lines
Target/
AArch64/
9 lines
ARM/
2 lines
Hexagon/
2 lines
13 lines
X86/
16 lines
test/
CodeGen/
AArch64/
Hexagon/
X86/
24 lines
Transforms/
SampleProfile/
6 lines
4 lines
6 lines
6 lines
8 lines
4 lines
4 lines
10 lines
4 lines
6 lines
tools/
opt/
3 lines
mlir/
include/
mlir/
Dialect/
Async/
IR/
16 lines
20 lines
20 lines
Vector/
105 lines
41 lines
lib/
Dialect/
Async/
IR/
120 lines
Vector/
47 lines
34 lines
test/
Dialect/
Async/
38 lines
Vector/
28 lines
11 lines
lib/
Transforms/
26 lines
utils/
gdb-scripts/

Diff 295417

View Options

clang/lib/AST/Decl.cpp

View Options

clang/lib/AST/ExprConstant.cpp

View Options

clang/lib/CodeGen/BackendUtil.cpp

View Options

clang/lib/Driver/ToolChains/AIX.cpp

View Options

clang/lib/Sema/SemaDeclCXX.cpp

View Options

clang/lib/Sema/SemaExpr.cpp

View Options

clang/test/CodeGen/builtin-nan-exception.c

View Options

clang/test/Driver/aix-ld.c

View Options

clang/test/Sema/fp16vec-sema.c

View Options

clang/test/SemaCXX/cxx20-constinit.cpp

View Options

compiler-rt/lib/scudo/standalone/atomic_helpers.h

View Options

compiler-rt/lib/scudo/standalone/combined.h

View Options

compiler-rt/lib/scudo/standalone/options.h

View Options

compiler-rt/lib/scudo/standalone/primary32.h

View Options

compiler-rt/lib/scudo/standalone/primary64.h

View Options

compiler-rt/lib/scudo/standalone/wrappers_c.inc

View Options

compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c

View Options

compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp

View Options

debuginfo-tests/CMakeLists.txt

View Options

debuginfo-tests/lit.cfg.py

View Options

debuginfo-tests/lit.site.cfg.py.in

View Options

debuginfo-tests/llvm-prettyprinters/gdb/lit.local.cfg

View Options

debuginfo-tests/llvm-prettyprinters/gdb/llvm-support.cpp

View Options

debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp

View Options

debuginfo-tests/llvm-prettyprinters/gdb/mlir-support.gdb

View Options

flang/include/flang/Evaluate/characteristics.h

View Options

flang/include/flang/Evaluate/type.h

View Options

flang/include/flang/Semantics/symbol.h

View Options

flang/include/flang/Semantics/tools.h

View Options

flang/lib/Evaluate/characteristics.cpp

View Options

flang/lib/Evaluate/tools.cpp

View Options

flang/lib/Evaluate/type.cpp

View Options

flang/lib/Semantics/check-call.cpp

View Options

flang/lib/Semantics/check-declarations.cpp

Loading...
View Options

flang/lib/Semantics/mod-file.h

View Options

flang/lib/Semantics/mod-file.cpp

View Options

flang/lib/Semantics/pointer-assignment.cpp

View Options

flang/lib/Semantics/resolve-names.cpp

View Options

flang/lib/Semantics/symbol.cpp

View Options

flang/lib/Semantics/tools.cpp

View Options

flang/runtime/descriptor-io.h

View Options

flang/test/Semantics/call03.f90

View Options

flang/test/Semantics/call05.f90

View Options

flang/test/Semantics/final01.f90

View Options

flang/test/Semantics/modfile10.f90

View Options

flang/test/Semantics/resolve32.f90

View Options

flang/test/Semantics/resolve55.f90

View Options

flang/unittests/Runtime/hello.cpp

View Options

libcxx/lib/abi/CMakeLists.txt

View Options

lldb/include/lldb/Core/StructuredDataImpl.h

View Options

lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

View Options

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py

View Options

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

View Options

lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py

View Options

lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py

View Options

lldb/test/API/tools/lldb-server/commandline/TestStubReverseConnect.py

View Options

lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py

View Options

lldb/tools/lldb-server/lldb-gdbserver.cpp

View Options

lldb/tools/lldb-vscode/lldb-vscode.cpp

View Options

lldb/unittests/Host/SocketTest.cpp

View Options

lldb/unittests/Host/SocketTestUtilities.cpp

View Options

llvm/include/llvm/CodeGen/AsmPrinter.h

View Options

llvm/include/llvm/CodeGen/AsmPrinterHandler.h

View Options

llvm/include/llvm/Target/TargetMachine.h

View Options

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

View Options

llvm/lib/CodeGen/AsmPrinter/DwarfCFIException.cpp

View Options

llvm/lib/CodeGen/AsmPrinter/EHStreamer.h

View Options

llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp

View Options

llvm/lib/CodeGen/AsmPrinter/WasmException.h

View Options

llvm/lib/CodeGen/AsmPrinter/WasmException.cpp

View Options

llvm/lib/CodeGen/BasicBlockSections.cpp

View Options

llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp

View Options

llvm/lib/Target/ARM/ARMAsmPrinter.cpp

View Options

llvm/lib/Target/Hexagon/HexagonTargetMachine.h

View Options

llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp

View Options

llvm/lib/Target/X86/X86ISelLowering.cpp

View Options

llvm/test/CodeGen/AArch64/aarch64-ldst-modified-baseReg.mir

View Options

llvm/test/CodeGen/Hexagon/registerpassbuildercallbacks.ll

View Options

llvm/test/CodeGen/X86/cmov.ll

View Options

llvm/test/CodeGen/X86/gcc_except_table_bb_sections.ll

View Options

llvm/test/CodeGen/X86/gcc_except_table_bb_sections_ehpad_groups_with_cold.ll

View Options

llvm/test/Transforms/SampleProfile/branch.ll

View Options

llvm/test/Transforms/SampleProfile/calls.ll

View Options

llvm/test/Transforms/SampleProfile/discriminator.ll

View Options

llvm/test/Transforms/SampleProfile/flattened.ll

View Options

llvm/test/Transforms/SampleProfile/fnptr.ll

View Options

llvm/test/Transforms/SampleProfile/inline-mergeprof.ll

View Options

llvm/test/Transforms/SampleProfile/offset.ll

View Options

llvm/test/Transforms/SampleProfile/profile-sample-accurate.ll

View Options

llvm/test/Transforms/SampleProfile/propagate.ll

View Options

llvm/test/Transforms/SampleProfile/remap.ll

View Options

llvm/tools/opt/NewPMDriver.cpp

View Options

mlir/include/mlir/Dialect/Async/IR/Async.h

View Options

mlir/include/mlir/Dialect/Async/IR/AsyncBase.td

View Options

mlir/include/mlir/Dialect/Async/IR/AsyncOps.td

View Options

mlir/include/mlir/Dialect/Vector/VectorOps.td

View Options

mlir/include/mlir/Dialect/Vector/VectorTransforms.h

View Options

mlir/lib/Dialect/Async/IR/Async.cpp

View Options

mlir/lib/Dialect/Vector/VectorOps.cpp

View Options

mlir/lib/Dialect/Vector/VectorTransforms.cpp

View Options

mlir/test/Dialect/Async/ops.mlir

View Options

mlir/test/Dialect/Vector/invalid.mlir

View Options

mlir/test/Dialect/Vector/ops.mlir

View Options

mlir/test/Dialect/Vector/vector-distribution.mlir

View Options

mlir/test/lib/Transforms/TestVectorTransforms.cpp

View Options

mlir/utils/gdb-scripts/prettyprinters.py