Revision of tests

@awarzynski, can you confirm whether your concerns have been addressed? Thank you!

Thanks again for helping improving this patch. I made most of the changes requested, and tried to clarify a bit better the approach followed for this implementation, to see if it is acceptable or if some more fundamental changes have to be done.

Changes to tests and path manipulation

Thank you for the feedback! I'll wait for confirmation before landing this patch, in case there are further comments relating to tests.

Address reviewers comments and update tests

Thank you for all the suggestions!

Address last reviewer's comments

Fix error in comment

Implement translation from builtin dialect to LLVM IR like for all other dialects

I think it would be good if you added a unit test for it. Thanks!

In D143493#4110323, @awarzynski wrote:

In D143493#4110272, @skatrak wrote:

It is introduced to the arguments list in Clang::AddPreprocessingOptions in certain cases to add the OpenMP wrapper "__clang_openmp_device_functions.h" to the list of includes for device offload.

This is a use case in Clang ;-)

It seemed likely that we would need to add a similar mechanism eventually to flang as well

Possibly, but it's not needed yet?

I would rather refrain from adding flags to Flang only because a similar flag exists in Clang. I suggest abandoning this until there's a clear need for this in Flang.

In D143493#4110230, @awarzynski wrote:

In what cases would this flag be used in practice? I've scanned Clang and couldn't find any answers.

• Add further unit tests

Reorder clauses