Page MenuHomePhabricator

[MIPS][CallSiteInfo][NFC] Fill CallSiteInfo only when needed
AcceptedPublic

Authored by necipfazil on Jul 29 2021, 2:41 PM.

Details

Summary

Argument-register pairs in CallSiteInfo is only needed when EmitCallSiteInfo
is on. Currently, the pairs are always pushed to the vector but only used
when EmitCallSiteInfo is on.

Don't fill the CallSiteInfo vector unless used.

Diff Detail

Unit TestsFailed

TimeTest
20 msx64 windows > flang-Unit.RuntimeGTest/_/FlangRuntimeTests_exe::Reductions.Logical
Script: -- C:\ws\w9\llvm-project\premerge-checks\build\tools\flang\unittests\RuntimeGTest\.\FlangRuntimeTests.exe --gtest_filter=Reductions.Logical

Event Timeline

necipfazil created this revision.Jul 29 2021, 2:41 PM
necipfazil requested review of this revision.Jul 29 2021, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2021, 2:41 PM
This revision is now accepted and ready to land.Jul 29 2021, 3:53 PM
djtodoro added inline comments.Aug 3 2021, 12:23 AM
llvm/lib/Target/Mips/MipsISelLowering.cpp
3352

I think we should fill the CallSiteInfo iff the Options.EmitCallSiteInfo is true only. The Options.SupportsDebugEntryValues is related to debug information that uses these call-site-info, but the CSInfo can be used for something else (even if the -g is not present; for example for the feature you are adding).
(Also, X86 and ARM fill that way).