- User Since
- Nov 23 2015, 4:41 AM (130 w, 3 d)
Fri, May 4
Instead of adding a new flag, would it be possible to make this part of the machine verifier? (-verify-machineinstrs)
Thu, May 3
LGTM with a small refactoring. I would wait until tomorrow for other reviewers to react, if not you can go ahead and commit this.
Wed, May 2
Tue, May 1
I see the problem. The solution feels a little hacky though. Would it make more sense to get rid of MIToken::IntegerType and lex i32 to identifier?
Mon, Apr 30
Fri, Apr 27
Sorry for the wait, this looks very good! Did you see any compile time impact on this?
Wed, Apr 25
LGTM with a small comment. Thanks!
Add comment for int Slot;.
Fix a few tests.
- Rename di-* to debug-info-* for fixedStack: and stack:
- Add comments to test to explain what they're testing
Tue, Apr 24
Apr 24 2018
Apr 23 2018
Apr 21 2018
Apr 20 2018
I think @gberry's solution is actually the correct fix. I don't really see why we shouldn't use empty stack slots if we can.
I have some tests failing on my side:
Thanks for working on this again!
Apr 19 2018
Apr 18 2018
local_unnamed_addr is probably not needed either.
Apr 17 2018
Sorry for not looking thoroughly at the test in the previous patch.
IIRC, there was a test case in the original patch but I can't see it in the landed commit. Any idea what happened?
This seems to break the Machine Verifier. I filed PR37153. Do you mind taking a look please? Thanks!
Apr 16 2018
Thanks for working on this! This looks good to me. Adding Tim for the AArch64LDST part.
Apr 15 2018
Thanks. LGTM + one more comment.
Apr 12 2018
Thanks! Your suggestion is much more readable.
Apr 11 2018
Thanks for this! If it's possible, could you also write a MIR test for this?
Apr 10 2018
Apr 9 2018
Apr 8 2018
Thanks for working on this.
Apr 6 2018
Sorry for the delay.
Apr 3 2018
LGTM, Thank you!
This LGTM. If you (or anyone else) can come up with some kind of test it wouldn't hurt, but I remember your test from the previous patch was all right.
Apr 2 2018
The shrink-wrap pass would already assert here. Could you add the property to ShrinkWrap as well?
Mar 30 2018
Mar 29 2018
Mar 27 2018
Sorry for breaking this. There is already a patch here: https://reviews.llvm.org/D44871.
Mar 24 2018
LGTM. Thanks for fixing this the right way, it looks much better now!
Thanks! I remember wanting to do this, I must have missed it, sorry.
Mar 21 2018
Mar 20 2018
Added @craig.topper for the X86FrameLowering::mergeSPUpdates changes.
Mar 19 2018
Thanks for this @junbuml! I did some runs on arm64 and I see a regression on 176.gcc, in average of 1.5%.
Mar 18 2018
Mar 15 2018
Mar 14 2018
Thanks for the review Justin!
Handle (hopefully) all the different cases.