Page MenuHomePhabricator

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (383 w, 5 d)

Recent Activity

Yesterday

thegameg accepted D147330: [Matrix] Refine cost estimate for dot-product..

LGTM.

Fri, Mar 31, 9:51 AM · Restricted Project, Restricted Project

Mon, Mar 20

thegameg added inline comments to D42600: [CodeGen][Shrink-wrap]split restore point.
Mon, Mar 20, 5:10 PM · Restricted Project, Restricted Project

Jan 25 2023

thegameg accepted D142529: [MISched] Dump the execution trace of the schedule..
Jan 25 2023, 4:51 PM · Restricted Project, Restricted Project
thegameg added inline comments to D142529: [MISched] Dump the execution trace of the schedule..
Jan 25 2023, 9:27 AM · Restricted Project, Restricted Project

Jan 13 2023

thegameg accepted D135488: [codegen] Add StackFrameLayoutAnalysisPass.
Jan 13 2023, 12:52 PM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

thegameg added a comment to D135488: [codegen] Add StackFrameLayoutAnalysisPass.

Actually if we add

if (!isFunctionInPrintList(MF.getName()))
     return false;

we can filter by name

Jan 12 2023, 4:30 PM · Restricted Project, Restricted Project, Restricted Project
thegameg added a comment to D135488: [codegen] Add StackFrameLayoutAnalysisPass.

It would be really nice if we could limit this to a specific function somehow.

I think you can do that, right ?
see:
https://llvm.org/docs/Remarks.html#cmdoption-pass-remarks-filter

Jan 12 2023, 3:14 PM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

thegameg committed rGda09b35334ab: [Matrix] Optimize matrix transposes around additions (authored by thegameg).
[Matrix] Optimize matrix transposes around additions
Jan 11 2023, 3:23 PM · Restricted Project, Restricted Project
thegameg closed D133657: [Matrix] Optimize matrix transposes around additions.
Jan 11 2023, 3:23 PM · Restricted Project, Restricted Project
thegameg accepted D135488: [codegen] Add StackFrameLayoutAnalysisPass.

Looks great with the leftover minor changes, feel free to land this, thanks! I'll give this a try internally and provide feedback if any.

Jan 11 2023, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
thegameg added a comment to D135488: [codegen] Add StackFrameLayoutAnalysisPass.

BTW, is there a way to nest some of the items? Ideally we'd be able to have a Slot in the YAML that contains all the various data, similar to how DebugLoc is a more complex object with fields for File, Line, and Column. That way we could group all the data for each slot including variable locations.

I know how that would look in YAML, but I'm unaware of how we'd do that with the existing remarks interfaces... or if doing so would massively change the CLI output. any pointers here?

Jan 11 2023, 10:58 AM · Restricted Project, Restricted Project, Restricted Project
thegameg updated the diff for D133657: [Matrix] Optimize matrix transposes around additions.

Rebase.

Jan 11 2023, 10:26 AM · Restricted Project, Restricted Project

Jan 10 2023

thegameg added a comment to D135488: [codegen] Add StackFrameLayoutAnalysisPass.

This looks great, thanks for updating this! A few more comments inline.

Jan 10 2023, 4:32 PM · Restricted Project, Restricted Project, Restricted Project

Jan 9 2023

thegameg added a comment to D135488: [codegen] Add StackFrameLayoutAnalysisPass.

I don't think I understand why we can't achieve B with remarks? In C and D you generate one remark for each line, can't we generate a single multi-line remark instead?

Jan 9 2023, 5:59 PM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

thegameg added a comment to D135488: [codegen] Add StackFrameLayoutAnalysisPass.

@arsenm @thegameg @nickdesaulniers @dblaikie @phosek Can we reach a consensus here on how to output this kind of information? I feel like I've been told to move towards remarks as the output method, but that the current diagnostic that tries to lay out the stack visually isn't a good fit since remarks are also serialized ... I'm not all that convinced that providing output other than a visual layout for this information is all that useful in this particular case, but I don't have an issue with supporting it either. I think this is especially true, since memory layouts are tricky to reason about.

For that reason, I'm pretty sure we want to actually show the user the layout directly in the diagnostic. My concern is that if we change the output to better fit within the remarks infrastructure, we lose an effective way to show users what's happening. If we take away the visual representation, then we'll end up needing to run a separate tool and post-process the serialized output to have a user make any real sense of how things are layed out. That seems like a pretty bad user experience, so I'd much rather find a way to have the compiler emit this information directly.

Does anyone have thoughts here on how to move forward?

Jan 3 2023, 6:53 PM · Restricted Project, Restricted Project, Restricted Project
thegameg added inline comments to D135488: [codegen] Add StackFrameLayoutAnalysisPass.
Jan 3 2023, 4:53 PM · Restricted Project, Restricted Project, Restricted Project
thegameg added a comment to D135488: [codegen] Add StackFrameLayoutAnalysisPass.

This is great! Any chance we can use MachineFrameInfo::StackProtectorIdx to annotate the slot that is reserved for the stack protector?

Jan 3 2023, 11:30 AM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2022

thegameg added a comment to D133657: [Matrix] Optimize matrix transposes around additions.

ping?

Dec 13 2022, 2:22 PM · Restricted Project, Restricted Project

Nov 28 2022

thegameg added a comment to D133657: [Matrix] Optimize matrix transposes around additions.

ping?

Nov 28 2022, 8:53 AM · Restricted Project, Restricted Project

Oct 11 2022

thegameg added a comment to D133657: [Matrix] Optimize matrix transposes around additions.

Ping?

Oct 11 2022, 2:32 PM · Restricted Project, Restricted Project

Oct 5 2022

thegameg updated the diff for D133657: [Matrix] Optimize matrix transposes around additions.

Rebase for build to pass.

Oct 5 2022, 10:55 AM · Restricted Project, Restricted Project

Oct 4 2022

thegameg committed rGffecb643ee2c: [objdump] Support finding --source via --dsym files (authored by radford).
[objdump] Support finding --source via --dsym files
Oct 4 2022, 11:16 AM · Restricted Project, Restricted Project
thegameg closed D135117: [objdump] Support finding --source via --dsym files.
Oct 4 2022, 11:15 AM · Restricted Project, Restricted Project
thegameg accepted D135117: [objdump] Support finding --source via --dsym files.

Thanks Jim!

Oct 4 2022, 8:06 AM · Restricted Project, Restricted Project

Sep 28 2022

thegameg accepted D134765: [llvm-remarkutil] Add an option to print out function sizes.

Thanks!

Sep 28 2022, 2:11 PM · Restricted Project, Restricted Project

Sep 27 2022

thegameg added a comment to D134765: [llvm-remarkutil] Add an option to print out function sizes.

I wonder if it's not more appropriate to use instruction-count instead of size?

Sep 27 2022, 2:53 PM · Restricted Project, Restricted Project

Sep 26 2022

thegameg added inline comments to D133657: [Matrix] Optimize matrix transposes around additions.
Sep 26 2022, 3:17 PM · Restricted Project, Restricted Project
thegameg updated the diff for D133657: [Matrix] Optimize matrix transposes around additions.
Sep 26 2022, 3:17 PM · Restricted Project, Restricted Project
thegameg committed rG0fcc99ade4d6: [Matrix] Add tests for addition transpose optimizations (authored by thegameg).
[Matrix] Add tests for addition transpose optimizations
Sep 26 2022, 1:28 PM · Restricted Project, Restricted Project
thegameg closed D133656: [Matrix] Add tests for addition transpose optimizations.
Sep 26 2022, 1:27 PM · Restricted Project, Restricted Project

Sep 12 2022

thegameg accepted D133646: Add a utility for converting between different types of remarks.

That'd be pretty separate from conversion, which is why I'm somewhat inclined to keep these as suboptions versus regular flags.

Sep 12 2022, 10:35 AM · Restricted Project, Restricted Project
thegameg added inline comments to D133695: [InstCombine] Optimize multiplication where both operands are negated.
Sep 12 2022, 9:29 AM · Restricted Project, Restricted Project

Sep 10 2022

thegameg requested review of D133657: [Matrix] Optimize matrix transposes around additions.
Sep 10 2022, 10:44 PM · Restricted Project, Restricted Project
thegameg requested review of D133656: [Matrix] Add tests for addition transpose optimizations.
Sep 10 2022, 10:41 PM · Restricted Project, Restricted Project
thegameg added a comment to D133646: Add a utility for converting between different types of remarks.

Also maybe something you would want to do in a separate patch, adding a -dump option that only calls llvm::remarks::Remark::dump() on all the parsed remarks would be very helpful (with maybe a -filter too)

Sep 10 2022, 5:17 PM · Restricted Project, Restricted Project
thegameg added a comment to D133646: Add a utility for converting between different types of remarks.

One suggestion would be to have a convert subcommand that takes bitstream2yaml or yaml2bitstream, assuming this tool will be extended to do more (for example, one thing I want to add is extract from a mach-o object file). I don't have strong opinions though so if everyone is fine with this I'm also fine.

What would this use-case look like in the (proposed) UI?

Sep 10 2022, 5:15 PM · Restricted Project, Restricted Project
thegameg accepted D133646: Add a utility for converting between different types of remarks.

Looks straightforward and pretty good to me. Thanks for working on this.

Sep 10 2022, 1:28 PM · Restricted Project, Restricted Project

Sep 6 2022

thegameg added a comment to D133300: [InstCombine] Matrix multiplication negation optimisation.

Are we looking to also support -(A * B) -> -A * B with the negation on the cheapest operand? (might need to check what the required fast math flags are)

Sep 6 2022, 6:43 AM · Restricted Project, Restricted Project

Sep 2 2022

thegameg committed rGc5b10f348e7d: [Matrix] Use print instead of dump for matrix-print-after-transpose-opt (authored by thegameg).
[Matrix] Use print instead of dump for matrix-print-after-transpose-opt
Sep 2 2022, 4:12 PM · Restricted Project, Restricted Project
thegameg committed rG81bdb4068d92: [Matrix] Simplify matmuls with scalars (authored by thegameg).
[Matrix] Simplify matmuls with scalars
Sep 2 2022, 3:50 PM · Restricted Project, Restricted Project
thegameg closed D130177: [Matrix] Simplify matmuls with scalars.
Sep 2 2022, 3:50 PM · Restricted Project, Restricted Project
thegameg added inline comments to D130177: [Matrix] Simplify matmuls with scalars.
Sep 2 2022, 11:59 AM · Restricted Project, Restricted Project
thegameg updated the diff for D130177: [Matrix] Simplify matmuls with scalars.
Sep 2 2022, 11:59 AM · Restricted Project, Restricted Project

Sep 1 2022

thegameg updated the diff for D130177: [Matrix] Simplify matmuls with scalars.
Sep 1 2022, 1:16 PM · Restricted Project, Restricted Project
thegameg added inline comments to D130177: [Matrix] Simplify matmuls with scalars.
Sep 1 2022, 12:10 PM · Restricted Project, Restricted Project

Aug 16 2022

thegameg accepted D131790: [unittests/CodeGen] Remove unique_ptr from the result of createTargetMachine.
Aug 16 2022, 12:39 PM · Restricted Project, Restricted Project
thegameg added inline comments to D131790: [unittests/CodeGen] Remove unique_ptr from the result of createTargetMachine.
Aug 16 2022, 10:03 AM · Restricted Project, Restricted Project

Aug 15 2022

thegameg accepted D131932: RAGreedyStats: Ignore identity COPYs; count COPYs from/to physregs.
Aug 15 2022, 10:11 PM · Restricted Project, Restricted Project
thegameg added inline comments to D131125: [Matrix] Add special case dot product lowering.
Aug 15 2022, 4:57 PM · Restricted Project, Restricted Project

Aug 11 2022

thegameg accepted D131125: [Matrix] Add special case dot product lowering.

LGTM, thank you!

Aug 11 2022, 12:02 PM · Restricted Project, Restricted Project

Aug 4 2022

thegameg added inline comments to D131125: [Matrix] Add special case dot product lowering.
Aug 4 2022, 9:41 AM · Restricted Project, Restricted Project

Jul 28 2022

thegameg closed D130174: [Matrix] Refactor transpose distribution. NFC.

https://github.com/llvm/llvm-project/commit/bfd3883e83dd61c68bd920d933f8ca679b788ad9

Jul 28 2022, 5:31 PM · Restricted Project, Restricted Project
thegameg committed rGbfd3883e83dd: [Matrix] Refactor transpose distribution. NFC (authored by thegameg).
[Matrix] Refactor transpose distribution. NFC
Jul 28 2022, 5:30 PM · Restricted Project, Restricted Project

Jul 26 2022

thegameg committed rG448a094d3e57: [Matrix] Add assert to catch extracted vectors with poison elements (authored by thegameg).
[Matrix] Add assert to catch extracted vectors with poison elements
Jul 26 2022, 11:17 AM · Restricted Project, Restricted Project
thegameg closed D130173: [Matrix] Add assert to extractVector with undef values.
Jul 26 2022, 11:17 AM · Restricted Project, Restricted Project
thegameg added inline comments to D130173: [Matrix] Add assert to extractVector with undef values.
Jul 26 2022, 11:06 AM · Restricted Project, Restricted Project
thegameg closed D130172: [Matrix] Refactor tiled loops in a struct. NFC.

https://github.com/llvm/llvm-project/commit/2c6e8b4636700f22a76eeda01e4a3258692b80f3

Jul 26 2022, 11:03 AM · Restricted Project, Restricted Project
thegameg committed rG2c6e8b463670: [Matrix] Refactor tiled loops in a struct. NFC (authored by thegameg).
[Matrix] Refactor tiled loops in a struct. NFC
Jul 26 2022, 11:03 AM · Restricted Project, Restricted Project

Jul 20 2022

thegameg requested review of D130177: [Matrix] Simplify matmuls with scalars.
Jul 20 2022, 7:59 AM · Restricted Project, Restricted Project
thegameg updated the diff for D130174: [Matrix] Refactor transpose distribution. NFC.
Jul 20 2022, 7:54 AM · Restricted Project, Restricted Project
thegameg updated the diff for D130173: [Matrix] Add assert to extractVector with undef values.
Jul 20 2022, 7:53 AM · Restricted Project, Restricted Project
thegameg updated the diff for D130172: [Matrix] Refactor tiled loops in a struct. NFC.
Jul 20 2022, 7:52 AM · Restricted Project, Restricted Project
thegameg requested review of D130174: [Matrix] Refactor transpose distribution. NFC.
Jul 20 2022, 7:42 AM · Restricted Project, Restricted Project
thegameg requested review of D130173: [Matrix] Add assert to extractVector with undef values.
Jul 20 2022, 7:40 AM · Restricted Project, Restricted Project
thegameg requested review of D130172: [Matrix] Refactor tiled loops in a struct. NFC.
Jul 20 2022, 7:38 AM · Restricted Project, Restricted Project

Jun 23 2022

thegameg accepted D128399: MIR: Fix parse error on empty CustomRegMask.
Jun 23 2022, 5:31 AM · Restricted Project, Restricted Project

Jun 14 2022

thegameg accepted D127736: [Matrix] Check if iterator is at beginning of BB in optimizeTranspose..

LGTM thanks!

Jun 14 2022, 11:55 AM · Restricted Project, Restricted Project
thegameg added a comment to D127591: [X86] Emit .cfi_restore after popping callee-saved-registers if no red zone.

Can you please add a test?

Jun 14 2022, 11:36 AM · Restricted Project, Restricted Project

Jun 3 2022

thegameg accepted D126942: [LowerMatrixIntrinsics] Add dot product tests.

LGTM! If you think it's valuable, you could also add a TN test ((Nx1)^T * Nx1) in case we end up optimizing that in the future, but up to you.

Jun 3 2022, 12:02 PM · Restricted Project, Restricted Project

Mar 30 2022

thegameg accepted D122744: [Docs] Add documentation for llvm-remark-size-diff.
Mar 30 2022, 11:28 AM · Restricted Project, Restricted Project

Mar 28 2022

thegameg accepted D122583: MIRParser: Fix asserting with invalid flags on machine operands.
Mar 28 2022, 12:02 PM · Restricted Project, Restricted Project

Feb 18 2022

thegameg accepted D120166: MIR: Start diagnosing too many operands on an instruction.

Maybe we can do this in the MachineVerifier too?

Feb 18 2022, 3:47 PM · Restricted Project

Feb 2 2022

thegameg accepted D112940: Add a tool for diffing instruction count + stack size remarks.

LGTM on my side. If this needs to grow into a more generic tool I think we can go with the python bindings and other things at that time.

Feb 2 2022, 2:13 PM · Restricted Project

Jan 28 2022

thegameg accepted D118506: Cleanup LLVMRemarks includes.

Thank you!

Jan 28 2022, 2:33 PM · Restricted Project

Jan 27 2022

thegameg accepted D118239: [Matrix] Use ArrayType for allocas instead of VectorType..

LGTM

Jan 27 2022, 1:06 PM · Restricted Project

Nov 18 2021

thegameg added a comment to D112940: Add a tool for diffing instruction count + stack size remarks.

I think it could be generalized though. I think that a really important next step for this is to have a machine-consumable output mode (e.g. JSON) which could have custom views built around it.

Maybe having python bindings that work with bitstream on top of the C API can make this even easier? Going back to a textual format seems wasteful and won't scale when a lot more remarks are enabled.

Nov 18 2021, 4:48 PM · Restricted Project

Nov 1 2021

thegameg added a comment to D112940: Add a tool for diffing instruction count + stack size remarks.

This is great, thanks! In general everything looks pretty good to me. I'll take a second look while others get some time to comment too!

Nov 1 2021, 6:46 PM · Restricted Project

Aug 30 2021

thegameg added a comment to D106408: Allow rematerialization of virtual reg uses.

This might be related to https://bugs.llvm.org/show_bug.cgi?id=51655. Do you mind checking it out?

What happened to it? Lldb is green now. Also do you mind to attach ll to the bug? For some reason I cannot build compiler-rt with sanitizers now, still trying to sort it out. This is all not needed to check RA though, if there is an ll.

Aug 30 2021, 9:24 AM · Restricted Project, Restricted Project

Aug 27 2021

thegameg added a comment to D106408: Allow rematerialization of virtual reg uses.

This might be related to https://bugs.llvm.org/show_bug.cgi?id=51655. Do you mind checking it out?

Aug 27 2021, 5:15 PM · Restricted Project, Restricted Project

Jul 1 2021

thegameg accepted D105193: [Matrix] Hoist address computation before multiply to enable fusion..
Jul 1 2021, 3:38 PM · Restricted Project

Jun 21 2021

thegameg accepted D104078: [Remarks] Make memsize remarks report as an analysis, not a missed opportunity..

LGTM

Jun 21 2021, 5:18 PM · Restricted Project

Jun 1 2021

thegameg added a comment to D102870: [RFC] CodeGen: Print/parse LLTs in MachineMemOperands.

In general I think the syntax looks fine. Not sure I get how hard it is to get rid of the parenthesis, but if we end up changing many tests, we should probably do it only once.

Jun 1 2021, 9:54 AM · Restricted Project

May 21 2021

thegameg accepted D102935: [Remarks] Look through inttoptr/ptrtoint for -ftrivial-auto-var-init remarks..

Good catch, thanks!

May 21 2021, 11:09 PM · Restricted Project

May 19 2021

thegameg accepted D102784: [Diagnostics] Allow emitting analysis and missed remarks on functions.

LGTM on the new constructors.

May 19 2021, 10:58 AM · Restricted Project, Restricted Project

May 18 2021

thegameg accepted D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 18 2021, 4:28 PM · Restricted Project
thegameg added a reviewer for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths: paquette.

This looks great! Adding Jessica since she reviewed the original auto-init patches too.

May 18 2021, 4:21 PM · Restricted Project

May 17 2021

thegameg added inline comments to D102627: [LTO] Support new PM in ThinLTOCodeGenerator..
May 17 2021, 2:14 PM · Restricted Project

May 14 2021

thegameg added a comment to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.

Is there anything you would want to share from llvm/lib/Transforms/Utils/AutoInitRemark.cpp ? You can see some examples in llvm/test/Transforms/Util/trivial-auto-var-init-call.ll.

May 14 2021, 9:53 AM · Restricted Project
thegameg accepted D102444: [Attributor] Add interface to emit remarks in Attributor.

LGTM with a test.

May 14 2021, 9:51 AM · Restricted Project, Restricted Project

May 11 2021

thegameg accepted D95044: IR+AArch64: add `swiftasync` function parameter attribute.

Flags/attributes/calling conventions look very straightforward.

May 11 2021, 10:23 AM · Restricted Project

Apr 29 2021

thegameg accepted D101508: [EarlyIfConversion] Avoid producing selects with identical operands.

LGTM, thanks! In general, I like this direction more than the TII::optimizeSelect one.

Apr 29 2021, 9:24 AM · Restricted Project

Apr 28 2021

thegameg added inline comments to D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 28 2021, 6:59 PM · Restricted Project

Apr 27 2021

thegameg added a comment to D101417: [CMake][llvm] add missing include to LLVMCheckLinkerFlag.

@JDevlieghere pushing to fix a build failure (https://lab.llvm.org/buildbot/#/builders/149/builds/1934), feel free to still review it!

Apr 27 2021, 6:54 PM · Restricted Project
thegameg committed rGe8b3a97ff742: [CMake][llvm] add missing include to LLVMCheckLinkerFlag (authored by radford).
[CMake][llvm] add missing include to LLVMCheckLinkerFlag
Apr 27 2021, 6:53 PM
thegameg closed D101417: [CMake][llvm] add missing include to LLVMCheckLinkerFlag.
Apr 27 2021, 6:53 PM · Restricted Project
thegameg committed rG06d06f2f6403: [CMake][llvm] avoid conflict w/ (and use when available) new builtin… (authored by radford).
[CMake][llvm] avoid conflict w/ (and use when available) new builtin…
Apr 27 2021, 4:43 PM
thegameg closed D100901: [CMake][llvm] avoid conflict w/ (and use when available) new builtin check_linker_flag.
Apr 27 2021, 4:43 PM · Restricted Project, Restricted Project

Apr 20 2021

thegameg committed rG16a0d80912ed: [CMake][llvm] avoid changing global flags (may be used outside of llvm) (authored by radford).
[CMake][llvm] avoid changing global flags (may be used outside of llvm)
Apr 20 2021, 4:07 PM
thegameg closed D100900: [CMake][llvm] avoid changing global flags (may be used outside of llvm).
Apr 20 2021, 4:07 PM · Restricted Project

Apr 12 2021

thegameg accepted D100168: [GreedyRA ORE] Add debug location for function level report.
Apr 12 2021, 9:57 AM · Restricted Project