- User Since
- Nov 23 2015, 4:41 AM (187 w, 2 d)
Any way we can get a test case for this? Other than that, LGTM.
Wed, Jun 19
Mon, Jun 17
Fri, Jun 14
Thu, Jun 13
Tue, Jun 11
I agree this needs to be fixed.
Mon, Jun 10
Tue, Jun 4
Thu, May 30
Sorry about that. Thanks @sbc100!
Sorry about this! This LGTM, thanks for fixing it!
Wed, May 29
May 23 2019
May 21 2019
I think you can just commit a fix to move it to the right place. Thanks!
Seems like this went into /test instead of /llvm/test.
May 14 2019
This sounds like it will report the wrong stack size in PEI for the StackSize remark and the stack size warning. Is that expected?
May 13 2019
I think this is the first type of entry in MIR that references instructions directly, and it seems quite easy to forget to update the offset in the block when adding/removing instructions, but I guess checking for ranges and if the instruction is a call might help.
Apr 23 2019
- Use Value:: stripPointerCasts instead of checking for BitCastInst.
- Add opt -codegenprepare test and full codegen test separately (to commit before this).
- Use utils/update_test_checks.py and utils/update_llc_test_checks.py for the new tests.
Apr 17 2019
Apr 8 2019
Apr 5 2019
Apr 3 2019
Address Jonas' remarks.
Apr 2 2019
This is definitely nicer, thanks for working on it.
Mar 26 2019
This LGTM with one comment.
I would have a slight preference for just:
It would be good to have a test case for this, but I assume you're planning on changing SIRegisterInfo::requiresFrameIndexReplacementScavenging? Maybe you can merge both patches since AMDGPU seems to be the only user of the hook.
Mar 20 2019
Update test to use a real path instead of /dev/null. Thanks @ormris, I didn't know lit could do all that!
Mar 19 2019
Forgot to add it to the diff.
Mar 13 2019
This is awesome, thanks for working on this!
Mar 12 2019
Address Jonas' comments.