In rG6e19543a2a2013bd357eb15e383b435cd0cbb810#651653, @Yi-Hong.Lyu wrote:

Done here https://reviews.llvm.org/rG00e85f753583. Sorry for the inconvenience

May 21 2019, 1:39 PM

thegameg added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

I think you can just commit a fix to move it to the right place. Thanks!

May 21 2019, 1:15 PM

thegameg added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

Seems like this went into /test instead of /llvm/test.

May 21 2019, 12:54 PM

May 14 2019

thegameg added a comment to D61437: [AArch64] Static (de)allocation of SVE stack objects..

This sounds like it will report the wrong stack size in PEI for the StackSize remark and the stack size warning. Is that expected?

May 14 2019, 8:32 AM

May 13 2019

thegameg added a reviewer for D61061: [MachineFunction] Base support for call site info tracking: qcolombet.

I think this is the first type of entry in MIR that references instructions directly, and it seems quite easy to forget to update the offset in the block when adding/removing instructions, but I guess checking for ranges and if the instruction is a call might help.

May 13 2019, 11:02 AM · debug-info

Apr 23 2019

thegameg committed rG465415f1db2b: [Remarks] Fix documentation indentation (authored by thegameg).

[Remarks] Fix documentation indentation

Apr 23 2019, 5:27 PM

thegameg committed rL359053: [Remarks] Fix documentation indentation.

[Remarks] Fix documentation indentation

Apr 23 2019, 5:26 PM

thegameg committed rG7fee2b89fd6e: [Remarks] Add string deduplication using a string table (authored by thegameg).

[Remarks] Add string deduplication using a string table

Apr 23 2019, 5:07 PM

thegameg committed rL359050: [Remarks] Add string deduplication using a string table.

[Remarks] Add string deduplication using a string table

Apr 23 2019, 5:07 PM

thegameg closed D60227: [Remarks] Add string deduplication using a string table.

Apr 23 2019, 5:07 PM · Restricted Project

thegameg added a comment to D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.

In D60837#1476259, @spatel wrote:

LGTM.

Apr 23 2019, 3:00 PM · Restricted Project

thegameg committed rG1646851b87cf: [CGP] Look through bitcasts when duplicating returns for tail calls (authored by thegameg).

[CGP] Look through bitcasts when duplicating returns for tail calls

Apr 23 2019, 2:56 PM

thegameg committed rGeea9da5921de: [X86] Add codegen prepare test exercising a bitcast + tail call (authored by thegameg).

[X86] Add codegen prepare test exercising a bitcast + tail call

Apr 23 2019, 2:56 PM

thegameg committed rL359041: [CGP] Look through bitcasts when duplicating returns for tail calls.

[CGP] Look through bitcasts when duplicating returns for tail calls

Apr 23 2019, 2:56 PM

thegameg closed D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.

Apr 23 2019, 2:56 PM · Restricted Project

thegameg committed rL359040: [X86] Add codegen prepare test exercising a bitcast + tail call.

[X86] Add codegen prepare test exercising a bitcast + tail call

Apr 23 2019, 2:56 PM

thegameg added inline comments to D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.

Apr 23 2019, 2:31 PM · Restricted Project

thegameg updated the diff for D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.

Use Value:: stripPointerCasts instead of checking for BitCastInst.
Add opt -codegenprepare test and full codegen test separately (to commit before this).
Use utils/update_test_checks.py and utils/update_llc_test_checks.py for the new tests.

Apr 23 2019, 2:27 PM · Restricted Project

Apr 17 2019

thegameg added inline comments to D60227: [Remarks] Add string deduplication using a string table.

Apr 17 2019, 3:08 PM · Restricted Project

thegameg created D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.

Apr 17 2019, 2:48 PM · Restricted Project

Apr 8 2019

thegameg added a reviewer for D60137: Describe stack-id as an enum: qcolombet.

Apr 8 2019, 11:11 AM · Restricted Project

Apr 5 2019

thegameg committed rG9d9d1b6b2ba0: [X86] Enable tail calls for CallingConv::Swift (authored by thegameg).

[X86] Enable tail calls for CallingConv::Swift

Apr 5 2019, 1:18 PM

thegameg committed rGab051a378c9c: [X86] Preserve operand flag when expanding TCRETURNri (authored by thegameg).

[X86] Preserve operand flag when expanding TCRETURNri

Apr 5 2019, 1:17 PM

thegameg committed rL357809: [X86] Enable tail calls for CallingConv::Swift.

[X86] Enable tail calls for CallingConv::Swift

Apr 5 2019, 1:16 PM

thegameg committed rL357808: [X86] Preserve operand flag when expanding TCRETURNri.

[X86] Preserve operand flag when expanding TCRETURNri

Apr 5 2019, 1:16 PM

Apr 3 2019

thegameg added a comment to D60227: [Remarks] Add string deduplication using a string table.

In D60227#1454110, @hfinkel wrote:

Is this transparent to tools that use LLVM's YAML library? Other tools?

If not, we'll need to update the llvm-opt-report tool and the opt-viewer tool.

Apr 3 2019, 8:30 PM · Restricted Project

thegameg updated the diff for D60227: [Remarks] Add string deduplication using a string table.

Address Jonas' remarks.

Apr 3 2019, 8:21 PM · Restricted Project

thegameg updated the diff for D60227: [Remarks] Add string deduplication using a string table.

Remove remarks::StringTable::get.

Apr 3 2019, 2:32 PM · Restricted Project

thegameg added inline comments to D60227: [Remarks] Add string deduplication using a string table.

Apr 3 2019, 2:32 PM · Restricted Project

thegameg created D60227: [Remarks] Add string deduplication using a string table.

Apr 3 2019, 12:44 PM · Restricted Project

Apr 2 2019

thegameg committed rG1ed4bbb9ab66: [Remarks][NFCI] Remove useless include (authored by thegameg).

[Remarks][NFCI] Remove useless include

Apr 2 2019, 10:50 AM

thegameg committed rL357503: [Remarks][NFCI] Remove useless include.

[Remarks][NFCI] Remove useless include

Apr 2 2019, 10:50 AM

thegameg added a comment to D60137: Describe stack-id as an enum.

This is definitely nicer, thanks for working on it.

Apr 2 2019, 9:41 AM · Restricted Project

Mar 26 2019

thegameg accepted D59853: MIR: Freeze reserved regs after parsing everything.

This LGTM with one comment.

Mar 26 2019, 6:46 PM

thegameg committed rGee1a6e70fa55: [Remarks] Emit a section containing remark diagnostics metadata (authored by thegameg).

[Remarks] Emit a section containing remark diagnostics metadata

Mar 26 2019, 6:13 PM

thegameg committed rL357043: [Remarks] Emit a section containing remark diagnostics metadata.

[Remarks] Emit a section containing remark diagnostics metadata

Mar 26 2019, 6:12 PM

thegameg closed D59571: [Remarks] Emit a section containing remark diagnostics metadata.

Mar 26 2019, 6:12 PM · Restricted Project

thegameg added a comment to D59842: RegScavenger: Fix !AllowSpill if no regs are available.

I would have a slight preference for just:

Mar 26 2019, 2:13 PM

thegameg accepted D59836: PEI: Delay checking requiresFrameIndexReplacementScavenging.

In D59836#1443555, @arsenm wrote:

I usually try to separate the target specific part when possible: D59840

Mar 26 2019, 1:34 PM

thegameg added a comment to D59836: PEI: Delay checking requiresFrameIndexReplacementScavenging.

It would be good to have a test case for this, but I assume you're planning on changing SIRegisterInfo::requiresFrameIndexReplacementScavenging? Maybe you can merge both patches since AMDGPU seems to be the only user of the hook.

Mar 26 2019, 12:58 PM