Page MenuHomePhabricator
People thegameg

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (203 w, 5 h)

Recent Activity
View All

Today

Herald updated subscribers of D67216: [cfi] Add flag to always generate .debug_frame.
Mon, Oct 14, 10:06 AM · Restricted Project, Restricted Project

Fri, Oct 11

thegameg committed rL374586: Request commit access for thegameg.
Request commit access for thegameg
Fri, Oct 11, 1:00 PM

Tue, Oct 8

thegameg committed rG143f6b837790: [IRGen] Emit lifetime markers for temporary struct allocas (authored by thegameg).
[IRGen] Emit lifetime markers for temporary struct allocas
Tue, Oct 8, 3:12 PM
thegameg closed D68611: [IRGen] Emit lifetime markers for temporary struct allocas.
Tue, Oct 8, 3:12 PM · Restricted Project
thegameg committed rL374126: [IRGen] Emit lifetime markers for temporary struct allocas.
[IRGen] Emit lifetime markers for temporary struct allocas
Tue, Oct 8, 3:12 PM
thegameg updated the diff for D68611: [IRGen] Emit lifetime markers for temporary struct allocas.

Move cleanup code after emitting lifetime start.

Tue, Oct 8, 11:25 AM · Restricted Project

Mon, Oct 7

thegameg created D68611: [IRGen] Emit lifetime markers for temporary struct allocas.
Mon, Oct 7, 4:53 PM · Restricted Project
thegameg accepted D68571: [Remarks] Pass StringBlockValue as StringRef..

LGTM, thanks.

Mon, Oct 7, 8:57 AM · Restricted Project

Thu, Oct 3

thegameg accepted D68361: [dsymutil] Tablegenify option parsing.

I noticed a bunch of explicit llvm:: prefixes like llvm::Error, llvm::StringRef, etc. Did you intentionally leave that there?

Thu, Oct 3, 7:52 AM · Restricted Project, Restricted Project

Mon, Sep 23

Herald added a project to D31898: Introduce libLTO C APIs to target the "resolution-based" new LTO API: Restricted Project.
Mon, Sep 23, 4:56 PM · Restricted Project

Wed, Sep 18

thegameg added a comment to D66459: Make ShrinkWrap more consistent..
In D66459#1673510, @linzj wrote:
In D66459#1673212, @thegameg wrote:

You can try to reproduce the behavior of the calling convention through a MIR test: https://llvm.org/docs/MIRLangRef.html, using $REG = IMPLICIT_DEF to clobber a CSR.

Not that simple. Your solution just handles the call instructions. The the prologue is inserted by the prologue inserter. I can't simply add a prologue to a function's MIR script, right?

Wed, Sep 18, 10:29 AM · Restricted Project
thegameg added inline comments to D67696: [tools] Mark output of tools as text if it is really text.
Wed, Sep 18, 10:01 AM · Restricted Project

Tue, Sep 17

thegameg committed rGba2e752c520b: [Remarks] Allow the RemarkStreamer to be used directly with a stream (authored by thegameg).
[Remarks] Allow the RemarkStreamer to be used directly with a stream
Tue, Sep 17, 6:04 PM
thegameg committed rL372195: [Remarks] Allow the RemarkStreamer to be used directly with a stream.
[Remarks] Allow the RemarkStreamer to be used directly with a stream
Tue, Sep 17, 6:04 PM
thegameg accepted D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..

LGTM, thanks!

Tue, Sep 17, 4:19 PM · Restricted Project
thegameg added a comment to D66459: Make ShrinkWrap more consistent..

You can try to reproduce the behavior of the calling convention through a MIR test: https://llvm.org/docs/MIRLangRef.html, using $REG = IMPLICIT_DEF to clobber a CSR.

Tue, Sep 17, 2:11 PM · Restricted Project

Mon, Sep 16

thegameg committed rG77383d83eb3f: [Remarks] Allow remarks::Format::YAML to take a string table (authored by thegameg).
[Remarks] Allow remarks::Format::YAML to take a string table
Mon, Sep 16, 3:45 PM
thegameg committed rL372042: [Remarks] Allow remarks::Format::YAML to take a string table.
[Remarks] Allow remarks::Format::YAML to take a string table
Mon, Sep 16, 3:44 PM

Sep 13 2019

thegameg committed rG2f9b2eb4b726: [llvm-opt-report] Improve error handling (authored by thegameg).
[llvm-opt-report] Improve error handling
Sep 13 2019, 1:51 PM
thegameg committed rL371895: [llvm-opt-report] Improve error handling.
[llvm-opt-report] Improve error handling
Sep 13 2019, 1:50 PM
thegameg committed rGd38f63e5f492: [Remarks][NFC] Forward declare ParsedStringTable (authored by thegameg).
[Remarks][NFC] Forward declare ParsedStringTable
Sep 13 2019, 10:33 AM
thegameg committed rL371870: [Remarks][NFC] Forward declare ParsedStringTable.
[Remarks][NFC] Forward declare ParsedStringTable
Sep 13 2019, 10:26 AM
thegameg committed rG1d6fb061cf5a: [Remarks][NFC] Use StringLiteral for magic numbers (authored by thegameg).
[Remarks][NFC] Use StringLiteral for magic numbers
Sep 13 2019, 9:46 AM
thegameg committed rL371869: [Remarks][NFC] Use StringLiteral for magic numbers.
[Remarks][NFC] Use StringLiteral for magic numbers
Sep 13 2019, 9:46 AM

Sep 9 2019

thegameg committed rG3d85013b63ea: [Remarks] Fix warning for uint8_t < 0 comparison (authored by thegameg).
[Remarks] Fix warning for uint8_t < 0 comparison
Sep 9 2019, 12:47 PM
thegameg committed rL371443: [Remarks] Fix warning for uint8_t < 0 comparison.
[Remarks] Fix warning for uint8_t < 0 comparison
Sep 9 2019, 12:47 PM
thegameg committed rGa85d9ef11ae3: [Remarks] Add parser for bitstream remarks (authored by thegameg).
[Remarks] Add parser for bitstream remarks
Sep 9 2019, 10:45 AM
thegameg committed rL371429: [Remarks] Add parser for bitstream remarks.
[Remarks] Add parser for bitstream remarks
Sep 9 2019, 10:45 AM
thegameg closed D67134: [Remarks] Add parser for bitstream remarks.
Sep 9 2019, 10:45 AM · Restricted Project

Sep 6 2019

thegameg committed rGe14c0c5ae011: [Remarks] Add support for internalizing a remark in a string table (authored by thegameg).
[Remarks] Add support for internalizing a remark in a string table
Sep 6 2019, 10:23 AM
thegameg committed rL371233: [Remarks] Add support for internalizing a remark in a string table.
[Remarks] Add support for internalizing a remark in a string table
Sep 6 2019, 10:23 AM

Sep 5 2019

thegameg committed rGd39720399c7a: [Remarks] Add comparison operators to the Remark object (authored by thegameg).
[Remarks] Add comparison operators to the Remark object
Sep 5 2019, 3:35 PM
thegameg committed rL371134: [Remarks] Add comparison operators to the Remark object.
[Remarks] Add comparison operators to the Remark object
Sep 5 2019, 3:35 PM
thegameg committed rG07f967d94dd7: [Remarks] Don't serialize metadata if a string table is not used (authored by thegameg).
[Remarks] Don't serialize metadata if a string table is not used
Sep 5 2019, 11:34 AM
thegameg committed rL371106: [Remarks] Don't serialize metadata if a string table is not used.
[Remarks] Don't serialize metadata if a string table is not used
Sep 5 2019, 11:33 AM

Sep 4 2019

thegameg added a comment to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
In D67189#1658521, @paquette wrote:

I'm going to commit this as-is and put up a separate review for remarks.

I figured I'd add them for all of the failure cases, and the success cases. (Basically turn the debug output into remark output.) That makes for a large-ish patch, so I'd like to do it separately.

Sep 4 2019, 3:56 PM · Restricted Project
thegameg added inline comments to D67134: [Remarks] Add parser for bitstream remarks.
Sep 4 2019, 1:28 PM · Restricted Project
thegameg updated the diff for D67134: [Remarks] Add parser for bitstream remarks.

Address Jonas' comments. Thanks for the review!

Sep 4 2019, 1:28 PM · Restricted Project
thegameg accepted D65945: [LLVM][Alignment] Make functions using log of alignment explicit.

Thanks for fixing the MIR issues and tests. It would be great to document this somewhere in https://llvm.org/docs/MIRLangRef.html if you can. Other than that, this LGTM!

Sep 4 2019, 1:11 PM · Restricted Project
thegameg added inline comments to D67189: [AArch64][GlobalISel] Teach AArch64CallLowering to handle basic sibling calls.
Sep 4 2019, 11:28 AM · Restricted Project

Sep 3 2019

thegameg created D67134: [Remarks] Add parser for bitstream remarks.
Sep 3 2019, 4:21 PM · Restricted Project

Aug 27 2019

thegameg added a comment to D66459: Make ShrinkWrap more consistent..

Thanks for upstreaming your changes.

Aug 27 2019, 11:07 AM · Restricted Project

Aug 26 2019

thegameg accepted D63973: [MachineVerifier] Improve checks of target instructions operands..

Thanks, this LGTM. I quickly looked at the X86 tests, it seems that PATCHABLE_EVENT_CALL and PATCHABLE_TYPED_EVENT_CALL are always created with a register but expect immediates in Target.td. I'm not sure what was the intention so I'll leave it to @dberris.

Aug 26 2019, 3:24 PM

Aug 22 2019

thegameg committed rG5b5ee61b5fa9: [MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is local (authored by thegameg).
[MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is local
Aug 22 2019, 10:00 AM
thegameg committed rL369671: [MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is local.
[MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is local
Aug 22 2019, 9:59 AM
thegameg closed D66563: [MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is local.
Aug 22 2019, 9:59 AM · Restricted Project

Aug 21 2019

thegameg accepted D66500: [SlotIndexes] Add print-slotindexes to disable printing slotindexes.

LGTM, thanks!

Aug 21 2019, 3:44 PM · Restricted Project
thegameg created D66563: [MachO][TLOF] Use hasLocalLinkage to determine if indirect symbol is local.
Aug 21 2019, 3:39 PM · Restricted Project

Aug 20 2019

thegameg added a reviewer for D66500: [SlotIndexes] Add print-slotindexes to disable printing slotindexes: qcolombet.

Can we also get a test for this?

Aug 20 2019, 3:44 PM · Restricted Project

Aug 16 2019

thegameg added a reviewer for D65983: Autogenerate the shebang lines for tools/opt-viewer: anemet.
Aug 16 2019, 4:01 PM · Restricted Project

Aug 7 2019

thegameg added inline comments to D65653: [AArch64] Change location of frame-record within callee-save area..
Aug 7 2019, 9:51 AM · Restricted Project

Aug 6 2019

thegameg added a comment to rL368117: Added Tool as Dependency to tests & fixed warnings.

This is still failing in http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16047/steps/test/logs/stdio.

Aug 6 2019, 8:59 PM
thegameg updated subscribers of D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..
Aug 6 2019, 2:36 PM · Restricted Project, Restricted Project
thegameg added a comment to D65000: [ARM] Set default alignment to 64bits.
In D65000#1616368, @dnsampaio wrote:

I have tested this in our MacOS and linux environments. @thakis @thegameg @phosek, would it be possible for you to check if this works for you?

Aug 6 2019, 1:57 PM · Restricted Project, Restricted Project

Aug 5 2019

thegameg added a comment to rG4361da24acab: [Attributor][Fix] Resolve various liveness issues.

Hi, this seems to fail with asan enabled: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan/6498/.

Aug 5 2019, 9:48 AM

Jul 31 2019

thegameg added a comment to D64188: [NewPM] Port the MIR Printing pass to new pass manager..

The MIRPrinter is used to print MIR when used with -stop-before / -stop-after / -run-pass flags in llc (see https://llvm.org/docs/MIRLangRef.html#mir-testing-guide).

Jul 31 2019, 11:15 AM · Restricted Project
thegameg accepted D65504: [AArch64] Do not allocate unnecessary emergency slot..

This LGTM, thanks!

Jul 31 2019, 11:01 AM · Restricted Project

Jul 30 2019

thegameg committed rG84e80979b530: Reland: [Remarks] Add an LLVM-bitstream-based remark serializer (authored by thegameg).
Reland: [Remarks] Add an LLVM-bitstream-based remark serializer
Jul 30 2019, 5:18 PM
thegameg committed rL367372: Reland: [Remarks] Add an LLVM-bitstream-based remark serializer.
Reland: [Remarks] Add an LLVM-bitstream-based remark serializer
Jul 30 2019, 5:13 PM
thegameg committed rGd8e7967a22b6: Revert "[Remarks] Add an LLVM-bitstream-based remark serializer" (authored by thegameg).
Revert "[Remarks] Add an LLVM-bitstream-based remark serializer"
Jul 30 2019, 5:02 PM
thegameg committed rL367370: Revert "[Remarks] Add an LLVM-bitstream-based remark serializer".
Revert "[Remarks] Add an LLVM-bitstream-based remark serializer"
Jul 30 2019, 5:01 PM
thegameg committed rG6c3c9483e716: [Remarks] Add an LLVM-bitstream-based remark serializer (authored by thegameg).
[Remarks] Add an LLVM-bitstream-based remark serializer
Jul 30 2019, 4:13 PM
thegameg committed rL367364: [Remarks] Add an LLVM-bitstream-based remark serializer.
[Remarks] Add an LLVM-bitstream-based remark serializer
Jul 30 2019, 4:13 PM
thegameg closed D63466: [Remarks] Add an LLVM-bitstream-based remark serializer.
Jul 30 2019, 4:13 PM · Restricted Project
thegameg committed rGd9402ee03f90: [Docs] Fix sphinx warning in OCamlLangImpl5.rst (authored by thegameg).
[Docs] Fix sphinx warning in OCamlLangImpl5.rst
Jul 30 2019, 9:57 AM
thegameg committed rL367334: [Docs] Fix sphinx warning in OCamlLangImpl5.rst.
[Docs] Fix sphinx warning in OCamlLangImpl5.rst
Jul 30 2019, 9:57 AM
thegameg committed rG5ed3d146f87e: [Remarks] Add two serialization modes for remarks: separate and standalone (authored by thegameg).
[Remarks] Add two serialization modes for remarks: separate and standalone
Jul 30 2019, 9:02 AM
thegameg committed rL367328: [Remarks] Add two serialization modes for remarks: separate and standalone.
[Remarks] Add two serialization modes for remarks: separate and standalone
Jul 30 2019, 9:01 AM

Jul 29 2019

thegameg committed rGfb3c53af3407: Revert "[compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for… (authored by thegameg).
Revert "[compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for…
Jul 29 2019, 3:09 PM
thegameg committed rL367265: Revert "[compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for….
Revert "[compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for…
Jul 29 2019, 3:08 PM
thegameg added a comment to rL367250: [compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for xray (2).

Sorry, I had to revert this in rL367265 to unblock the macOS bots.

Jul 29 2019, 3:08 PM
thegameg added a comment to rL367250: [compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for xray (2).

http://lab.llvm.org:8080/green/job/clang-stage1-RA/482/console

Jul 29 2019, 1:50 PM
thegameg added a comment to rL367250: [compiler-rt] Appending COMPILER_RT_LIBCXX_PATH -isystem include for xray (2).

Hey Puyan,

Jul 29 2019, 1:25 PM
thegameg committed rG72d00802d848: [Remarks] Update error message format string (authored by thegameg).
[Remarks] Update error message format string
Jul 29 2019, 10:44 AM
thegameg committed rL367243: [Remarks] Update error message format string.
[Remarks] Update error message format string
Jul 29 2019, 10:44 AM
thegameg committed rGd42289e29166: [RISCV] Fix uninitialized variable after call to evaluateConstantImm (authored by thegameg).
[RISCV] Fix uninitialized variable after call to evaluateConstantImm
Jul 29 2019, 8:53 AM
thegameg added a comment to D65347: [RISCV] Fix uninitialized variable after call to evaluateConstantImm.

Thanks @asb!

Jul 29 2019, 8:53 AM · Restricted Project
thegameg committed rL367230: [RISCV] Fix uninitialized variable after call to evaluateConstantImm.
[RISCV] Fix uninitialized variable after call to evaluateConstantImm
Jul 29 2019, 8:51 AM
thegameg closed D65347: [RISCV] Fix uninitialized variable after call to evaluateConstantImm.
Jul 29 2019, 8:51 AM · Restricted Project

Jul 26 2019

thegameg committed rGf5a338369be4: [Remarks] Silence Wreturn-type warning (authored by thegameg).
[Remarks] Silence Wreturn-type warning
Jul 26 2019, 3:45 PM
thegameg committed rL367162: [Remarks] Silence Wreturn-type warning.
[Remarks] Silence Wreturn-type warning
Jul 26 2019, 3:45 PM
thegameg committed rGec63dc2c35fb: [Remarks] Update unit test to use StringRef::lower (authored by thegameg).
[Remarks] Update unit test to use StringRef::lower
Jul 26 2019, 3:37 PM
thegameg committed rL367161: [Remarks] Update unit test to use StringRef::lower.
[Remarks] Update unit test to use StringRef::lower
Jul 26 2019, 3:37 PM
thegameg added inline comments to rL367155: Reland: [Remarks] Support parsing remark metadata in the YAML remark parser.
Jul 26 2019, 3:13 PM
thegameg committed rG64a5f9e11257: Reland: [Remarks] Support parsing remark metadata in the YAML remark parser (authored by thegameg).
Reland: [Remarks] Support parsing remark metadata in the YAML remark parser
Jul 26 2019, 2:04 PM
thegameg committed rL367155: Reland: [Remarks] Support parsing remark metadata in the YAML remark parser.
Reland: [Remarks] Support parsing remark metadata in the YAML remark parser
Jul 26 2019, 2:03 PM
thegameg committed rGcdc74e219782: Revert "[Remarks] Support parsing remark metadata in the YAML remark parser" (authored by thegameg).
Revert "[Remarks] Support parsing remark metadata in the YAML remark parser"
Jul 26 2019, 1:55 PM
thegameg committed rL367151: Revert "[Remarks] Support parsing remark metadata in the YAML remark parser".
Revert "[Remarks] Support parsing remark metadata in the YAML remark parser"
Jul 26 2019, 1:54 PM
thegameg added inline comments to D65000: [ARM] Set default alignment to 64bits.
Jul 26 2019, 1:50 PM · Restricted Project, Restricted Project
thegameg created D65347: [RISCV] Fix uninitialized variable after call to evaluateConstantImm.
Jul 26 2019, 1:35 PM · Restricted Project
thegameg committed rGa41f61625a96: [Remarks] Support parsing remark metadata in the YAML remark parser (authored by thegameg).
[Remarks] Support parsing remark metadata in the YAML remark parser
Jul 26 2019, 1:14 PM
thegameg committed rL367148: [Remarks] Support parsing remark metadata in the YAML remark parser.
[Remarks] Support parsing remark metadata in the YAML remark parser
Jul 26 2019, 1:11 PM

Jul 25 2019

thegameg committed rG2d8fdcae9617: Reland: [Remarks] Add support for serializing metadata for every remark streamer (authored by thegameg).
Reland: [Remarks] Add support for serializing metadata for every remark streamer
Jul 25 2019, 6:35 PM
thegameg committed rL367078: Reland: [Remarks] Add support for serializing metadata for every remark streamer.
Reland: [Remarks] Add support for serializing metadata for every remark streamer
Jul 25 2019, 6:35 PM
thegameg committed rG0503add6dab5: [CodeGen] Don't resolve the stack protector frame accesses until PEI (authored by thegameg).
[CodeGen] Don't resolve the stack protector frame accesses until PEI
Jul 25 2019, 3:28 PM
thegameg committed rL367068: [CodeGen] Don't resolve the stack protector frame accesses until PEI.
[CodeGen] Don't resolve the stack protector frame accesses until PEI
Jul 25 2019, 3:27 PM
thegameg closed D64759: [CodeGen] Don't resolve the stack protector frame accesses until PEI.
Jul 25 2019, 3:27 PM · Restricted Project
thegameg added a comment to D64759: [CodeGen] Don't resolve the stack protector frame accesses until PEI.

I filed PR42764 for the missing documentation.

Jul 25 2019, 3:21 PM · Restricted Project
thegameg added a comment to rL366946: [Remarks] Add support for serializing metadata for every remark streamer.

Seems that the issue is that /externalfile becomes C:/externalfile.

Jul 25 2019, 9:22 AM

Jul 24 2019

thegameg committed rGab56cf89142d: [Remarks][NFC] Rename remarks::Parser to remarks::RemarkParser (authored by thegameg).
[Remarks][NFC] Rename remarks::Parser to remarks::RemarkParser
Jul 24 2019, 5:21 PM