thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (107 w, 1 d)

Recent Activity

Today

thegameg created D41116: [CodeGen] Print constant pool index operands as %const.0 + 8 in both MIR and debug output.
Tue, Dec 12, 8:24 AM

Fri, Dec 8

thegameg closed D40965: [CodeGen] Move printing MO_Immediate operands to MachineOperand::print.

Committed as r320209: [CodeGen] Move printing MO_Immediate operands to MachineOperand::print (failed the commit message...)

Fri, Dec 8, 2:59 PM
thegameg committed rL320209: [CodeGen] Move printing MO_Immediate operands to MachineOperand::print.
[CodeGen] Move printing MO_Immediate operands to MachineOperand::print
Fri, Dec 8, 2:54 PM
thegameg created D41027: [CodeGen] Print stack object references as %(fixed-)stack.0 in both MIR and debug output.
Fri, Dec 8, 10:49 AM
thegameg committed rL320141: [CodeGen] Move printing MO_MachineBasicBlock operands to MachineOperand::print.
[CodeGen] Move printing MO_MachineBasicBlock operands to MachineOperand::print
Fri, Dec 8, 3:48 AM
thegameg committed rL320140: [CodeGen] Move printing MO_CImmediate operands to MachineOperand::print.
[CodeGen] Move printing MO_CImmediate operands to MachineOperand::print
Fri, Dec 8, 3:40 AM
thegameg updated the diff for D40965: [CodeGen] Move printing MO_Immediate operands to MachineOperand::print.
Fri, Dec 8, 2:43 AM

Thu, Dec 7

thegameg updated the diff for D40965: [CodeGen] Move printing MO_Immediate operands to MachineOperand::print.

Make MIRLangRef more clear about subreg index immediate operands.

Thu, Dec 7, 9:29 AM
thegameg created D40965: [CodeGen] Move printing MO_Immediate operands to MachineOperand::print.
Thu, Dec 7, 9:17 AM
thegameg committed rL320061: [CodeGen] Fix index when printing tied machine operands.
[CodeGen] Fix index when printing tied machine operands
Thu, Dec 7, 9:13 AM
thegameg committed rL320046: [CodeGen] Use more getMFIfAvailable.
[CodeGen] Use more getMFIfAvailable
Thu, Dec 7, 6:32 AM
thegameg closed D40836: [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register..

Committed as r320022 [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register.

Thu, Dec 7, 2:55 AM
thegameg committed rL320022: [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register..
[CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register.
Thu, Dec 7, 2:42 AM

Wed, Dec 6

thegameg added inline comments to D40836: [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register..
Wed, Dec 6, 4:25 AM
thegameg updated the diff for D40836: [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register..
  • Move implementation from the MIRPrinter to MachineOperand.
  • Update tests.
Wed, Dec 6, 4:17 AM
thegameg committed rL319886: [CodeGen] Fix formatting error from r319885.
[CodeGen] Fix formatting error from r319885
Wed, Dec 6, 3:58 AM
thegameg committed rL319885: [CodeGen] Better handling of detached MachineOperands.
[CodeGen] Better handling of detached MachineOperands
Wed, Dec 6, 3:56 AM

Tue, Dec 5

thegameg created D40836: [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register..
Tue, Dec 5, 6:12 AM
thegameg added a reviewer for D40755: [WIP][shrink-wrap]Sink COPYs to CSR from entry to successors: MatzeB.

Thanks for working on this!

Tue, Dec 5, 2:59 AM

Mon, Dec 4

thegameg committed rL319665: [CodeGen] Unify MBB reference format in both MIR and debug output.
[CodeGen] Unify MBB reference format in both MIR and debug output
Mon, Dec 4, 9:27 AM
thegameg closed D40422: [CodeGen] Unify MBB reference format in both MIR and debug output by committing rL319665: [CodeGen] Unify MBB reference format in both MIR and debug output.
Mon, Dec 4, 9:22 AM
thegameg updated the diff for D40422: [CodeGen] Unify MBB reference format in both MIR and debug output.
Mon, Dec 4, 7:45 AM

Thu, Nov 30

thegameg committed rL319447: [MIR] Fix DebugInfo tests after r319445.
[MIR] Fix DebugInfo tests after r319445
Thu, Nov 30, 8:49 AM
thegameg committed rL319445: [CodeGen] Always use `printReg` to print registers in both MIR and debug.
[CodeGen] Always use `printReg` to print registers in both MIR and debug
Thu, Nov 30, 8:13 AM
thegameg closed D40421: [CodeGen] Always use `printReg` to print registers in both MIR and debug output by committing rL319445: [CodeGen] Always use `printReg` to print registers in both MIR and debug.
Thu, Nov 30, 8:13 AM
thegameg committed rL319427: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output.
[CodeGen] Print "%vreg0" as "%0" in both MIR and debug output
Thu, Nov 30, 4:13 AM
thegameg closed D40420: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output by committing rL319427: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output.
Thu, Nov 30, 4:13 AM

Wed, Nov 29

thegameg updated subscribers of D40418: [CodeGen] Print noreg as '_' in both MIR and debug output.
Wed, Nov 29, 8:42 AM
thegameg added inline comments to D40420: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output.
Wed, Nov 29, 8:15 AM
thegameg updated the diff for D40420: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output.

Address comments and rebase.

Wed, Nov 29, 8:13 AM

Tue, Nov 28

thegameg committed rL319207: [CodeGen] Fix doxygen \file comment style.
[CodeGen] Fix doxygen \file comment style
Tue, Nov 28, 11:24 AM
thegameg added inline comments to D40419: [CodeGen] Separate MachineOperand implementation from MachineInstr.
Tue, Nov 28, 11:17 AM
thegameg committed rL319206: [CodeGen] Fix doxygen.
[CodeGen] Fix doxygen
Tue, Nov 28, 11:16 AM
thegameg committed rL319194: [CodeGen] Separate MachineOperand implementation from MachineInstr.
[CodeGen] Separate MachineOperand implementation from MachineInstr
Tue, Nov 28, 9:59 AM
thegameg committed rL319193: [CodeGen] Cleanup MachineOperand.
[CodeGen] Cleanup MachineOperand
Tue, Nov 28, 9:59 AM
thegameg closed D40419: [CodeGen] Separate MachineOperand implementation from MachineInstr by committing rL319194: [CodeGen] Separate MachineOperand implementation from MachineInstr.
Tue, Nov 28, 9:59 AM
thegameg abandoned D30803: [RegionInfo] Don't return an invalid pointer when removing a subregion.
Tue, Nov 28, 9:39 AM
thegameg committed rL319187: [CodeGen] Print register names in lowercase in both MIR and debug output.
[CodeGen] Print register names in lowercase in both MIR and debug output
Tue, Nov 28, 9:17 AM
thegameg closed D40417: [CodeGen] Print register names in lowercase in both MIR and debug output by committing rL319187: [CodeGen] Print register names in lowercase in both MIR and debug output.
Tue, Nov 28, 9:16 AM
thegameg committed rL319177: [Support] Add unit test for printLowerCase.
[Support] Add unit test for printLowerCase
Tue, Nov 28, 8:12 AM
thegameg added a comment to D40417: [CodeGen] Print register names in lowercase in both MIR and debug output.

Uploaded separately r319171:Merge toLower / toUpper implementations.

Tue, Nov 28, 6:28 AM
thegameg committed rL319171: [Support] Merge toLower / toUpper implementations.
[Support] Merge toLower / toUpper implementations
Tue, Nov 28, 6:23 AM
thegameg updated subscribers of D40420: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output.
Tue, Nov 28, 5:36 AM
thegameg added inline comments to D40418: [CodeGen] Print noreg as '_' in both MIR and debug output.
Tue, Nov 28, 4:51 AM
thegameg committed rL319168: [CodeGen] Rename functions PrintReg* to printReg*.
[CodeGen] Rename functions PrintReg* to printReg*
Tue, Nov 28, 4:43 AM
thegameg closed D40416: [CodeGen] Rename functions PrintReg* to printReg* by committing rL319168: [CodeGen] Rename functions PrintReg* to printReg*.
Tue, Nov 28, 4:43 AM

Fri, Nov 24

thegameg updated the diff for D40419: [CodeGen] Separate MachineOperand implementation from MachineInstr.

Fix file header.

Fri, Nov 24, 6:31 AM
thegameg created D40422: [CodeGen] Unify MBB reference format in both MIR and debug output.
Fri, Nov 24, 3:33 AM
thegameg created D40420: [CodeGen] Print "%vreg0" as "%0" in both MIR and debug output.
Fri, Nov 24, 3:33 AM
thegameg created D40421: [CodeGen] Always use `printReg` to print registers in both MIR and debug output.
Fri, Nov 24, 3:33 AM
thegameg created D40419: [CodeGen] Separate MachineOperand implementation from MachineInstr.
Fri, Nov 24, 3:33 AM
thegameg created D40417: [CodeGen] Print register names in lowercase in both MIR and debug output.
Fri, Nov 24, 3:33 AM
thegameg created D40418: [CodeGen] Print noreg as '_' in both MIR and debug output.
Fri, Nov 24, 3:33 AM
thegameg created D40416: [CodeGen] Rename functions PrintReg* to printReg*.
Fri, Nov 24, 3:33 AM
thegameg abandoned D40414: [CodeGen] Always use `printReg` to print registers in both MIR and debug output.
Fri, Nov 24, 3:25 AM
thegameg created D40414: [CodeGen] Always use `printReg` to print registers in both MIR and debug output.
Fri, Nov 24, 3:21 AM

Fri, Nov 17

thegameg committed rL318585: [test-suite] Fix Xcode SDK cmake cache for benchmarks using re_comp.
[test-suite] Fix Xcode SDK cmake cache for benchmarks using re_comp
Fri, Nov 17, 6:19 PM
thegameg closed D40204: [test-suite] Fix Xcode SDK cmake cache for benchmarks using re_comp by committing rL318585: [test-suite] Fix Xcode SDK cmake cache for benchmarks using re_comp.
Fri, Nov 17, 6:18 PM
thegameg created D40204: [test-suite] Fix Xcode SDK cmake cache for benchmarks using re_comp.
Fri, Nov 17, 6:07 PM

Nov 3 2017

thegameg closed D35642: [PEI] Simplify handling of targets with no phys regs. NFC.

Rebased and commited in rL317309.

Nov 3 2017, 2:49 AM
thegameg committed rL317309: [PEI] Simplify handling of targets with no phys regs. NFC.
[PEI] Simplify handling of targets with no phys regs. NFC
Nov 3 2017, 2:47 AM

Nov 2 2017

thegameg committed rL317199: [AsmPrinterDwarf] Add support for .cfi_restore directive.
[AsmPrinterDwarf] Add support for .cfi_restore directive
Nov 2 2017, 5:01 AM
thegameg closed D36114: [AsmPrinterDwarf] Add support for .cfi_restore directive by committing rL317199: [AsmPrinterDwarf] Add support for .cfi_restore directive.
Nov 2 2017, 5:01 AM

Oct 5 2017

thegameg added inline comments to D35844: Correct dwarf unwind information in function epilogue.
Oct 5 2017, 2:35 PM
thegameg accepted D38597: [PEI] Remove required properties and use 'if' instead of std::function.
Oct 5 2017, 2:17 PM

Oct 3 2017

thegameg added a comment to D35844: Correct dwarf unwind information in function epilogue.

Hi Violeta,

Oct 3 2017, 9:36 AM

Aug 30 2017

thegameg added a comment to D36109: [CodeGen] Provide an advanced shrink-wrapping interface.
In D36109#856854, @lei wrote:

Can you provide documentation on the various functions? I was trying to extend this for PPC and I had a hard time trying to figure out what I needed to do enable to get this working.

Great! I tried to explain most of the bits here: https://lists.llvm.org/pipermail/llvm-dev/2017-August/116131.html. As I pointed out at the end of the email, you could take a look at:

Aug 30 2017, 11:22 AM

Aug 29 2017

thegameg updated the diff for D36109: [CodeGen] Provide an advanced shrink-wrapping interface.

Thanks @lei for taking a look. I addressed your concerns.

Aug 29 2017, 3:47 AM
thegameg added a comment to D30808: shrink-wrap: implement more advanced algorithm.

This now needs to update the "Restore" flag from CalleeSavedInfo, as of r310619: Add "Restored" flag to CalleeSavedInfo.

Aug 29 2017, 3:37 AM

Aug 1 2017

thegameg added inline comments to D36114: [AsmPrinterDwarf] Add support for .cfi_restore directive.
Aug 1 2017, 11:11 AM
thegameg updated the diff for D36114: [AsmPrinterDwarf] Add support for .cfi_restore directive.

Add / remove CHECK-LABELs.

Aug 1 2017, 10:38 AM

Jul 31 2017

thegameg updated the diff for D36114: [AsmPrinterDwarf] Add support for .cfi_restore directive.
  • Add MIR support (printing and parsing).
  • Add MIR test.
  • Update and rename CodeGen test.
  • Add MC test.
Jul 31 2017, 4:05 PM
thegameg created D36114: [AsmPrinterDwarf] Add support for .cfi_restore directive.
Jul 31 2017, 2:59 PM
thegameg created D36109: [CodeGen] Provide an advanced shrink-wrapping interface.
Jul 31 2017, 1:20 PM
thegameg reopened D35642: [PEI] Simplify handling of targets with no phys regs. NFC.

Reverted in r308581.

Jul 31 2017, 11:45 AM
thegameg added a comment to D35844: Correct dwarf unwind information in function epilogue.

I am not sure what you are suggesting here. Doesn't that mean that compact unwind would practically be disabled (would always fallback to DWARF)?

Jul 31 2017, 10:24 AM

Jul 25 2017

thegameg added a comment to D35844: Correct dwarf unwind information in function epilogue.

While trying to make this work with AArch64 and add the support for .cfi_offset / .cfi_restore directives, I came across a few questions and comments:

Jul 25 2017, 4:04 PM

Jul 24 2017

thegameg added a comment to D18046: [X86] Providing correct unwind info in function epilogue.

I see this has been reverted (r306676). Any plans to re-commit this @violetav ?

Jul 24 2017, 11:11 AM

Jul 20 2017

thegameg committed rL308666: [PEI] Fix refactoring from r308664.
[PEI] Fix refactoring from r308664
Jul 20 2017, 1:32 PM
thegameg committed rL308664: [PEI] Separate saving and restoring CSRs into different functions. NFC.
[PEI] Separate saving and restoring CSRs into different functions. NFC
Jul 20 2017, 1:19 PM

Jul 19 2017

thegameg committed rL308581: Revert "[PEI] Simplify handling of targets with no phys regs. NFC".
Revert "[PEI] Simplify handling of targets with no phys regs. NFC"
Jul 19 2017, 7:47 PM
thegameg committed rL308580: Revert "[PEI] Separate saving and restoring CSRs into different functions. NFC".
Revert "[PEI] Separate saving and restoring CSRs into different functions. NFC"
Jul 19 2017, 7:47 PM
thegameg committed rL308573: [PEI] Separate saving and restoring CSRs into different functions. NFC.
[PEI] Separate saving and restoring CSRs into different functions. NFC
Jul 19 2017, 5:59 PM
thegameg committed rL308562: Revert "[PEI] Separate saving and restoring CSRs into different functions. NFC".
Revert "[PEI] Separate saving and restoring CSRs into different functions. NFC"
Jul 19 2017, 5:09 PM
thegameg closed D35645: [PEI] Add basic opt-remarks support.

Committed in r308556: [PEI] Add basic opt-remarks support.

Jul 19 2017, 4:53 PM
thegameg committed rL308557: [AsmPrinter] Constify needsCFIMoves. NFC.
[AsmPrinter] Constify needsCFIMoves. NFC
Jul 19 2017, 4:49 PM
thegameg committed rL308556: [PEI] Add basic opt-remarks support.
[PEI] Add basic opt-remarks support
Jul 19 2017, 4:49 PM
thegameg committed rL308555: [PEI] Simplify handling of targets with no phys regs. NFC.
[PEI] Simplify handling of targets with no phys regs. NFC
Jul 19 2017, 4:48 PM
thegameg closed D35642: [PEI] Simplify handling of targets with no phys regs. NFC by committing rL308555: [PEI] Simplify handling of targets with no phys regs. NFC.
Jul 19 2017, 4:48 PM
thegameg committed rL308554: [PEI] Separate saving and restoring CSRs into different functions. NFC.
[PEI] Separate saving and restoring CSRs into different functions. NFC
Jul 19 2017, 4:48 PM
thegameg closed D35644: [PEI] Separate saving and restoring CSRs into different functions. NFC by committing rL308554: [PEI] Separate saving and restoring CSRs into different functions. NFC.
Jul 19 2017, 4:48 PM
thegameg updated the diff for D35644: [PEI] Separate saving and restoring CSRs into different functions. NFC.
Jul 19 2017, 4:32 PM
thegameg committed rL308545: [NFC] Fix typo in comment.
[NFC] Fix typo in comment
Jul 19 2017, 3:29 PM
thegameg updated the diff for D35645: [PEI] Add basic opt-remarks support.

Included the full YAML in the test cases.

Jul 19 2017, 3:03 PM
thegameg updated the diff for D35645: [PEI] Add basic opt-remarks support.

Added MIR tests for both AArch64 and X86.

Jul 19 2017, 2:46 PM
thegameg created D35645: [PEI] Add basic opt-remarks support.
Jul 19 2017, 2:12 PM
thegameg created D35644: [PEI] Separate saving and restoring CSRs into different functions. NFC.
Jul 19 2017, 2:07 PM
thegameg retitled D35642: [PEI] Simplify handling of targets with no phys regs. NFC from [PEI] Simplify handling of targets with no pays regs. NFC to [PEI] Simplify handling of targets with no phys regs. NFC.
Jul 19 2017, 2:02 PM
thegameg created D35642: [PEI] Simplify handling of targets with no phys regs. NFC.
Jul 19 2017, 2:02 PM

Jul 5 2017

thegameg added a comment to D18046: [X86] Providing correct unwind info in function epilogue.

Hi Violeta,

Jul 5 2017, 9:50 AM