Page MenuHomePhabricator

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (339 w, 5 h)

Recent Activity

Mar 30 2022

thegameg accepted D122744: [Docs] Add documentation for llvm-remark-size-diff.
Mar 30 2022, 11:28 AM · Restricted Project, Restricted Project

Mar 28 2022

thegameg accepted D122583: MIRParser: Fix asserting with invalid flags on machine operands.
Mar 28 2022, 12:02 PM · Restricted Project, Restricted Project

Feb 18 2022

thegameg accepted D120166: MIR: Start diagnosing too many operands on an instruction.

Maybe we can do this in the MachineVerifier too?

Feb 18 2022, 3:47 PM · Restricted Project

Feb 2 2022

thegameg accepted D112940: Add a tool for diffing instruction count + stack size remarks.

LGTM on my side. If this needs to grow into a more generic tool I think we can go with the python bindings and other things at that time.

Feb 2 2022, 2:13 PM · Restricted Project

Jan 28 2022

thegameg accepted D118506: Cleanup LLVMRemarks includes.

Thank you!

Jan 28 2022, 2:33 PM · Restricted Project

Jan 27 2022

thegameg accepted D118239: [Matrix] Use ArrayType for allocas instead of VectorType..

LGTM

Jan 27 2022, 1:06 PM · Restricted Project

Nov 18 2021

thegameg added a comment to D112940: Add a tool for diffing instruction count + stack size remarks.

I think it could be generalized though. I think that a really important next step for this is to have a machine-consumable output mode (e.g. JSON) which could have custom views built around it.

Maybe having python bindings that work with bitstream on top of the C API can make this even easier? Going back to a textual format seems wasteful and won't scale when a lot more remarks are enabled.

Nov 18 2021, 4:48 PM · Restricted Project

Nov 1 2021

thegameg added a comment to D112940: Add a tool for diffing instruction count + stack size remarks.

This is great, thanks! In general everything looks pretty good to me. I'll take a second look while others get some time to comment too!

Nov 1 2021, 6:46 PM · Restricted Project

Aug 30 2021

thegameg added a comment to D106408: Allow rematerialization of virtual reg uses.

This might be related to https://bugs.llvm.org/show_bug.cgi?id=51655. Do you mind checking it out?

What happened to it? Lldb is green now. Also do you mind to attach ll to the bug? For some reason I cannot build compiler-rt with sanitizers now, still trying to sort it out. This is all not needed to check RA though, if there is an ll.

Aug 30 2021, 9:24 AM · Restricted Project, Restricted Project

Aug 27 2021

thegameg added a comment to D106408: Allow rematerialization of virtual reg uses.

This might be related to https://bugs.llvm.org/show_bug.cgi?id=51655. Do you mind checking it out?

Aug 27 2021, 5:15 PM · Restricted Project, Restricted Project

Jul 1 2021

thegameg accepted D105193: [Matrix] Hoist address computation before multiply to enable fusion..
Jul 1 2021, 3:38 PM · Restricted Project

Jun 21 2021

thegameg accepted D104078: [Remarks] Make memsize remarks report as an analysis, not a missed opportunity..

LGTM

Jun 21 2021, 5:18 PM · Restricted Project

Jun 1 2021

thegameg added a comment to D102870: [RFC] CodeGen: Print/parse LLTs in MachineMemOperands.

In general I think the syntax looks fine. Not sure I get how hard it is to get rid of the parenthesis, but if we end up changing many tests, we should probably do it only once.

Jun 1 2021, 9:54 AM · Restricted Project

May 21 2021

thegameg accepted D102935: [Remarks] Look through inttoptr/ptrtoint for -ftrivial-auto-var-init remarks..

Good catch, thanks!

May 21 2021, 11:09 PM · Restricted Project

May 19 2021

thegameg accepted D102784: [Diagnostics] Allow emitting analysis and missed remarks on functions.

LGTM on the new constructors.

May 19 2021, 10:58 AM · Restricted Project, Restricted Project

May 18 2021

thegameg accepted D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 18 2021, 4:28 PM · Restricted Project
thegameg added a reviewer for D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths: paquette.

This looks great! Adding Jessica since she reviewed the original auto-init patches too.

May 18 2021, 4:21 PM · Restricted Project

May 17 2021

thegameg added inline comments to D102627: [LTO] Support new PM in ThinLTOCodeGenerator..
May 17 2021, 2:14 PM · Restricted Project

May 14 2021

thegameg added a comment to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.

Is there anything you would want to share from llvm/lib/Transforms/Utils/AutoInitRemark.cpp ? You can see some examples in llvm/test/Transforms/Util/trivial-auto-var-init-call.ll.

May 14 2021, 9:53 AM · Restricted Project
thegameg accepted D102444: [Attributor] Add interface to emit remarks in Attributor.

LGTM with a test.

May 14 2021, 9:51 AM · Restricted Project, Restricted Project

May 11 2021

thegameg accepted D95044: IR+AArch64: add `swiftasync` function parameter attribute.

Flags/attributes/calling conventions look very straightforward.

May 11 2021, 10:23 AM · Restricted Project

Apr 29 2021

thegameg accepted D101508: [EarlyIfConversion] Avoid producing selects with identical operands.

LGTM, thanks! In general, I like this direction more than the TII::optimizeSelect one.

Apr 29 2021, 9:24 AM · Restricted Project

Apr 28 2021

thegameg added inline comments to D101508: [EarlyIfConversion] Avoid producing selects with identical operands.
Apr 28 2021, 6:59 PM · Restricted Project

Apr 27 2021

thegameg added a comment to D101417: [CMake][llvm] add missing include to LLVMCheckLinkerFlag.

@JDevlieghere pushing to fix a build failure (https://lab.llvm.org/buildbot/#/builders/149/builds/1934), feel free to still review it!

Apr 27 2021, 6:54 PM · Restricted Project
thegameg committed rGe8b3a97ff742: [CMake][llvm] add missing include to LLVMCheckLinkerFlag (authored by radford).
[CMake][llvm] add missing include to LLVMCheckLinkerFlag
Apr 27 2021, 6:53 PM
thegameg closed D101417: [CMake][llvm] add missing include to LLVMCheckLinkerFlag.
Apr 27 2021, 6:53 PM · Restricted Project
thegameg committed rG06d06f2f6403: [CMake][llvm] avoid conflict w/ (and use when available) new builtin… (authored by radford).
[CMake][llvm] avoid conflict w/ (and use when available) new builtin…
Apr 27 2021, 4:43 PM
thegameg closed D100901: [CMake][llvm] avoid conflict w/ (and use when available) new builtin check_linker_flag.
Apr 27 2021, 4:43 PM · Restricted Project, Restricted Project

Apr 20 2021

thegameg committed rG16a0d80912ed: [CMake][llvm] avoid changing global flags (may be used outside of llvm) (authored by radford).
[CMake][llvm] avoid changing global flags (may be used outside of llvm)
Apr 20 2021, 4:07 PM
thegameg closed D100900: [CMake][llvm] avoid changing global flags (may be used outside of llvm).
Apr 20 2021, 4:07 PM · Restricted Project

Apr 12 2021

thegameg accepted D100168: [GreedyRA ORE] Add debug location for function level report.
Apr 12 2021, 9:57 AM · Restricted Project
thegameg added a comment to D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.

@thegameg, I landed NFC before to move from if-else to if-continue. Is it readable now or you still want me to separate added logic into utility function?

Apr 12 2021, 9:53 AM · Restricted Project

Apr 8 2021

thegameg added inline comments to D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.
Apr 8 2021, 12:14 PM · Restricted Project

Apr 6 2021

thegameg added a comment to D100017: [GreedyRA ORE] Add stats for copy of virtual registers..

Is this really useful as a user-surfacing remark? Won't it have a really high false positive rate due to coalescing?

To be honest - not sure. But if RA can assigned physical register and can eliminate copy it a good sign.
So probably I also need to check reg map whether physical registers are different or not... Need to check...

Apr 6 2021, 10:44 PM · Restricted Project
thegameg added a comment to D100017: [GreedyRA ORE] Add stats for copy of virtual registers..

Is this really useful as a user-surfacing remark? Won't it have a really high false positive rate due to coalescing?

Apr 6 2021, 10:35 PM · Restricted Project
thegameg added inline comments to D100013: [GreedyRA ORE] Extract computeNumberOfSplillsReloads to use in different places. NFC..
Apr 6 2021, 10:33 PM · Restricted Project
thegameg added inline comments to D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.
Apr 6 2021, 10:17 PM · Restricted Project
thegameg accepted D100013: [GreedyRA ORE] Extract computeNumberOfSplillsReloads to use in different places. NFC..
Apr 6 2021, 9:53 PM · Restricted Project
thegameg accepted D100014: [GreedyRA ORE] Add function level spill/reloads stats.

This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.

Apr 6 2021, 9:51 PM · Restricted Project
thegameg added a comment to D100012: [GreedyRA ORE] Extract stats in RAGreedyStats struct. NFC..

LGTM. Doesn't seem like there are any tests testing this remark, maybe you can add one if you have something handy?

There are some tests
./CodeGen/AArch64/arm64-spill-remarks-treshold-hotness.ll
./CodeGen/AArch64/arm64-spill-remarks.ll

I'll probably add something like this.

Apr 6 2021, 9:48 PM · Restricted Project
thegameg accepted D100012: [GreedyRA ORE] Extract stats in RAGreedyStats struct. NFC..

LGTM. Doesn't seem like there are any tests testing this remark, maybe you can add one if you have something handy?

Apr 6 2021, 9:44 PM · Restricted Project

Mar 4 2021

thegameg committed rG365b78396abf: [Remarks] Emit variable info in auto-init remarks (authored by thegameg).
[Remarks] Emit variable info in auto-init remarks
Mar 4 2021, 12:51 PM
thegameg closed D97734: [Remarks] Emit variable info in auto-init remarks.
Mar 4 2021, 12:51 PM · Restricted Project

Mar 2 2021

thegameg added inline comments to D97734: [Remarks] Emit variable info in auto-init remarks.
Mar 2 2021, 11:24 AM · Restricted Project
thegameg updated the diff for D97734: [Remarks] Emit variable info in auto-init remarks.

Address comments + comments in header.

Mar 2 2021, 11:24 AM · Restricted Project

Mar 1 2021

thegameg requested review of D97734: [Remarks] Emit variable info in auto-init remarks.
Mar 1 2021, 2:01 PM · Restricted Project

Feb 25 2021

thegameg committed rGfee9abe69c0e: [Remarks] Provide more information about auto-init calls (authored by thegameg).
[Remarks] Provide more information about auto-init calls
Feb 25 2021, 3:15 PM
thegameg committed rG4753a69a316b: [Remarks] Provide more information about auto-init stores (authored by thegameg).
[Remarks] Provide more information about auto-init stores
Feb 25 2021, 3:15 PM
thegameg committed rGc49b600b2f82: [Remarks] Emit remarks for "auto-init" !annotations (authored by thegameg).
[Remarks] Emit remarks for "auto-init" !annotations
Feb 25 2021, 3:15 PM
thegameg closed D97489: [Remarks] Provide more information about auto-init calls.
Feb 25 2021, 3:14 PM · Restricted Project
thegameg closed D97412: [Remarks] Provide more information about auto-init stores.
Feb 25 2021, 3:14 PM · Restricted Project
thegameg closed D97405: [Remarks] Emit remarks for "auto-init" !annotations.
Feb 25 2021, 3:14 PM · Restricted Project
thegameg accepted D97499: [PM] Show the pass argument in pre/post-pass IR dumps.

Thank you!

Feb 25 2021, 1:59 PM · Restricted Project, Restricted Project
thegameg requested review of D97489: [Remarks] Provide more information about auto-init calls.
Feb 25 2021, 11:06 AM · Restricted Project

Feb 24 2021

thegameg added inline comments to D97412: [Remarks] Provide more information about auto-init stores.
Feb 24 2021, 4:00 PM · Restricted Project
thegameg updated the diff for D97412: [Remarks] Provide more information about auto-init stores.

Add StoreVolatile: false and StoreAtomic: false under ExtraArgs.

Feb 24 2021, 4:00 PM · Restricted Project
thegameg added inline comments to D97412: [Remarks] Provide more information about auto-init stores.
Feb 24 2021, 3:50 PM · Restricted Project
thegameg requested review of D97412: [Remarks] Provide more information about auto-init stores.
Feb 24 2021, 1:27 PM · Restricted Project
thegameg requested review of D97405: [Remarks] Emit remarks for "auto-init" !annotations.
Feb 24 2021, 11:40 AM · Restricted Project

Feb 4 2021

thegameg accepted D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks.
Feb 4 2021, 7:29 AM · Restricted Project

Jan 22 2021

thegameg accepted D95280: [YAML I/O] Fix bug in emission of empty sequence.

LGTM. Not sure if there's a cleaner way.

Jan 22 2021, 6:03 PM · Restricted Project
thegameg committed rG0cc38acfc4e1: [Matrix] Propagate shape information through fneg (authored by thegameg).
[Matrix] Propagate shape information through fneg
Jan 22 2021, 2:35 PM
thegameg closed D95252: [Matrix] Propagate shape information through fneg.
Jan 22 2021, 2:35 PM · Restricted Project
thegameg added a reviewer for D95252: [Matrix] Propagate shape information through fneg: anemet.
Jan 22 2021, 11:22 AM · Restricted Project
thegameg requested review of D95252: [Matrix] Propagate shape information through fneg.
Jan 22 2021, 11:21 AM · Restricted Project

Jan 8 2021

thegameg added inline comments to D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it.
Jan 8 2021, 12:43 PM · Restricted Project, Restricted Project

Dec 16 2020

thegameg accepted D91444: [InstCombine] Preserve !annotation on newly created instructions..

LGTM, nice!

Dec 16 2020, 11:06 AM · Restricted Project, Restricted Project
thegameg accepted D93399: [InstCombine] Preserve !annotation for newly created instructions..

LGTM

Dec 16 2020, 11:02 AM · Restricted Project

Dec 4 2020

thegameg committed rG3d381a710220: [llvm-nm][MachO] Don't call getFlags on redacted symbols (authored by thegameg).
[llvm-nm][MachO] Don't call getFlags on redacted symbols
Dec 4 2020, 10:06 PM

Nov 13 2020

thegameg accepted D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations.

LGTM

Nov 13 2020, 3:50 PM · Restricted Project, Restricted Project
thegameg added inline comments to D91444: [InstCombine] Preserve !annotation on newly created instructions..
Nov 13 2020, 3:47 PM · Restricted Project, Restricted Project
thegameg accepted D91417: [IRGen] Add !annotation metadata for auto-init stores..

Looks good, thanks!

Nov 13 2020, 3:44 PM · Restricted Project, Restricted Project

Nov 10 2020

thegameg accepted D91188: Add !annotation metadata and remarks pass..

Looks great, thanks!

Nov 10 2020, 3:01 PM · Restricted Project

Nov 6 2020

thegameg added inline comments to D89240: Add initial infra to convert annotations to MD and display summary remarks (WIP).
Nov 6 2020, 12:07 PM · Restricted Project
thegameg added inline comments to D89240: Add initial infra to convert annotations to MD and display summary remarks (WIP).
Nov 6 2020, 12:02 PM · Restricted Project

Oct 26 2020

thegameg added inline comments to D90201: Try reading a smaller chunk when (p)read fails.
Oct 26 2020, 8:13 PM · Restricted Project
thegameg accepted D90201: Try reading a smaller chunk when (p)read fails.
Oct 26 2020, 8:06 PM · Restricted Project

Oct 23 2020

thegameg added a comment to D89892: [AsmPrinter] Add per BB instruction mix remark..

How about adding a total count as well? That should help quickly eye ball the ratios.

Oct 23 2020, 12:09 AM · Restricted Project

Oct 22 2020

thegameg accepted D89892: [AsmPrinter] Add per BB instruction mix remark..

This looks great! Thanks!

Oct 22 2020, 8:25 PM · Restricted Project

Oct 16 2020

thegameg added a comment to rG0345d88de654: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.

Is this really necessary to remove? For example, our backend is using EntrySU edges for top edges from the basic block entry, in order to account for clearances. It seems to make sense to have a node like this.

Oct 16 2020, 9:42 AM

Sep 21 2020

thegameg added a comment to D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.

I am totally fine with keeping this in-tree, even unused, if it helps several out-of-tree backends. Thanks for speaking up.

Sep 21 2020, 12:25 PM · Restricted Project

Sep 18 2020

thegameg accepted D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.

LGTM

Sep 18 2020, 3:06 PM · Restricted Project
thegameg committed rG0345d88de654: [NFC][ScheduleDAG] Remove unused EntrySU SUnit (authored by thegameg).
[NFC][ScheduleDAG] Remove unused EntrySU SUnit
Sep 18 2020, 9:52 AM
thegameg closed D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.
Sep 18 2020, 9:52 AM · Restricted Project

Sep 17 2020

thegameg abandoned D53490: [MIR] Provide a default alignment for stack objects.
Sep 17 2020, 4:31 PM
thegameg requested changes to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.

Can you wrap the condition around the whole file? The rest is not useful without the library anyway.

Sep 17 2020, 4:29 PM · Restricted Project
thegameg requested review of D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.
Sep 17 2020, 3:55 PM · Restricted Project
thegameg abandoned D34544: [libunwind] Don't assume the return address register is always saved and has CFI for it.

Won't be back to this anytime soon.

Sep 17 2020, 3:18 PM
thegameg accepted D85810: [clang] Pass-through remarks options to linker.

LGTM

Sep 17 2020, 2:58 PM · Restricted Project

Aug 28 2020

thegameg accepted D86797: [early-ifcvt] Add OptRemarks.

This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.

Aug 28 2020, 11:55 AM · Restricted Project

Aug 14 2020

thegameg added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Just to clarify, I wasn't suggesting putting it in another patch, but just bringing it back here (plus adding in the gold-plugin support). The other patch I was referring to was the follow on patch D85810 where I also suggested adding support to gold-plugin.cpp.

Aug 14 2020, 11:49 AM · Restricted Project
thegameg added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

I have removed the change to llvm-lto

Aug 14 2020, 11:41 AM · Restricted Project

Aug 12 2020

thegameg accepted D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

LGTM, thanks for plugging all these options through!

Aug 12 2020, 3:55 PM · Restricted Project

Jul 29 2020

thegameg added a reverting change for rGd8e8e32d85f1: build: always add support for assembly targets on Darwin: rG926c14798d31: Revert "build: always add support for assembly targets on Darwin".
Jul 29 2020, 3:45 PM
thegameg committed rG926c14798d31: Revert "build: always add support for assembly targets on Darwin" (authored by thegameg).
Revert "build: always add support for assembly targets on Darwin"
Jul 29 2020, 3:45 PM
thegameg added a reverting change for D84333: build: always add support for assembly targets on Darwin: rG926c14798d31: Revert "build: always add support for assembly targets on Darwin".
Jul 29 2020, 3:45 PM · Restricted Project
thegameg added a comment to D84333: build: always add support for assembly targets on Darwin.

Hi @compnerd, it looks like this fails to link: http://green.lab.llvm.org/green/job/clang-stage1-RA/13171/console

Jul 29 2020, 3:30 PM · Restricted Project
thegameg added a comment to D84690: Make iterators of BitVector easier to use by inheriting iterator_facade_base.

Indeed, sorry that fell through & I didn't understand enough about iterators to instead suggest falling back to an input iterator instead of figuring out how to fit the semantics of the forward iterator.

Jul 29 2020, 2:06 PM · Restricted Project

Jul 27 2020

thegameg added a comment to D84690: Make iterators of BitVector easier to use by inheriting iterator_facade_base.

I had an attempt here: https://reviews.llvm.org/D33419, I think similar concerns came up in that review.

Jul 27 2020, 2:12 PM · Restricted Project

Jul 21 2020

thegameg added a comment to D84207: [compiler-rt][test][profile] Fix missing include.

Not sure why our public bots didn't catch it.

Jul 21 2020, 11:39 AM · Restricted Project