Page MenuHomePhabricator
People thegameg

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (178 w, 1 d)

Recent Activity
View All

Today

thegameg committed rG465415f1db2b: [Remarks] Fix documentation indentation (authored by thegameg).
[Remarks] Fix documentation indentation
Tue, Apr 23, 5:27 PM
thegameg committed rL359053: [Remarks] Fix documentation indentation.
[Remarks] Fix documentation indentation
Tue, Apr 23, 5:26 PM
thegameg committed rG7fee2b89fd6e: [Remarks] Add string deduplication using a string table (authored by thegameg).
[Remarks] Add string deduplication using a string table
Tue, Apr 23, 5:07 PM
thegameg committed rL359050: [Remarks] Add string deduplication using a string table.
[Remarks] Add string deduplication using a string table
Tue, Apr 23, 5:07 PM
thegameg closed D60227: [Remarks] Add string deduplication using a string table.
Tue, Apr 23, 5:07 PM · Restricted Project
thegameg added a comment to D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
In D60837#1476259, @spatel wrote:

LGTM.

Tue, Apr 23, 3:00 PM · Restricted Project
thegameg committed rG1646851b87cf: [CGP] Look through bitcasts when duplicating returns for tail calls (authored by thegameg).
[CGP] Look through bitcasts when duplicating returns for tail calls
Tue, Apr 23, 2:56 PM
thegameg committed rGeea9da5921de: [X86] Add codegen prepare test exercising a bitcast + tail call (authored by thegameg).
[X86] Add codegen prepare test exercising a bitcast + tail call
Tue, Apr 23, 2:56 PM
thegameg committed rL359041: [CGP] Look through bitcasts when duplicating returns for tail calls.
[CGP] Look through bitcasts when duplicating returns for tail calls
Tue, Apr 23, 2:56 PM
thegameg closed D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
Tue, Apr 23, 2:56 PM · Restricted Project
thegameg committed rL359040: [X86] Add codegen prepare test exercising a bitcast + tail call.
[X86] Add codegen prepare test exercising a bitcast + tail call
Tue, Apr 23, 2:56 PM
thegameg added inline comments to D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
Tue, Apr 23, 2:31 PM · Restricted Project
thegameg updated the diff for D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
  • Use Value:: stripPointerCasts instead of checking for BitCastInst.
  • Add opt -codegenprepare test and full codegen test separately (to commit before this).
  • Use utils/update_test_checks.py and utils/update_llc_test_checks.py for the new tests.
Tue, Apr 23, 2:27 PM · Restricted Project

Wed, Apr 17

thegameg added inline comments to D60227: [Remarks] Add string deduplication using a string table.
Wed, Apr 17, 3:08 PM · Restricted Project
thegameg created D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
Wed, Apr 17, 2:48 PM · Restricted Project

Mon, Apr 8

thegameg added a reviewer for D60137: Describe stack-id as an enum: qcolombet.
Mon, Apr 8, 11:11 AM

Fri, Apr 5

thegameg committed rG9d9d1b6b2ba0: [X86] Enable tail calls for CallingConv::Swift (authored by thegameg).
[X86] Enable tail calls for CallingConv::Swift
Fri, Apr 5, 1:18 PM
thegameg committed rGab051a378c9c: [X86] Preserve operand flag when expanding TCRETURNri (authored by thegameg).
[X86] Preserve operand flag when expanding TCRETURNri
Fri, Apr 5, 1:17 PM
thegameg committed rL357809: [X86] Enable tail calls for CallingConv::Swift.
[X86] Enable tail calls for CallingConv::Swift
Fri, Apr 5, 1:16 PM
thegameg committed rL357808: [X86] Preserve operand flag when expanding TCRETURNri.
[X86] Preserve operand flag when expanding TCRETURNri
Fri, Apr 5, 1:16 PM

Wed, Apr 3

thegameg added a comment to D60227: [Remarks] Add string deduplication using a string table.
In D60227#1454110, @hfinkel wrote:

Is this transparent to tools that use LLVM's YAML library? Other tools?

If not, we'll need to update the llvm-opt-report tool and the opt-viewer tool.

Wed, Apr 3, 8:30 PM · Restricted Project
thegameg updated the diff for D60227: [Remarks] Add string deduplication using a string table.

Address Jonas' remarks.

Wed, Apr 3, 8:21 PM · Restricted Project
thegameg updated the diff for D60227: [Remarks] Add string deduplication using a string table.

Remove remarks::StringTable::get.

Wed, Apr 3, 2:32 PM · Restricted Project
thegameg added inline comments to D60227: [Remarks] Add string deduplication using a string table.
Wed, Apr 3, 2:32 PM · Restricted Project
thegameg created D60227: [Remarks] Add string deduplication using a string table.
Wed, Apr 3, 12:44 PM · Restricted Project

Tue, Apr 2

thegameg committed rG1ed4bbb9ab66: [Remarks][NFCI] Remove useless include (authored by thegameg).
[Remarks][NFCI] Remove useless include
Tue, Apr 2, 10:50 AM
thegameg committed rL357503: [Remarks][NFCI] Remove useless include.
[Remarks][NFCI] Remove useless include
Tue, Apr 2, 10:50 AM
thegameg added a comment to D60137: Describe stack-id as an enum.

This is definitely nicer, thanks for working on it.

Tue, Apr 2, 9:41 AM

Tue, Mar 26

thegameg accepted D59853: MIR: Freeze reserved regs after parsing everything.

This LGTM with one comment.

Tue, Mar 26, 6:46 PM
thegameg committed rGee1a6e70fa55: [Remarks] Emit a section containing remark diagnostics metadata (authored by thegameg).
[Remarks] Emit a section containing remark diagnostics metadata
Tue, Mar 26, 6:13 PM
thegameg committed rL357043: [Remarks] Emit a section containing remark diagnostics metadata.
[Remarks] Emit a section containing remark diagnostics metadata
Tue, Mar 26, 6:12 PM
thegameg closed D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Tue, Mar 26, 6:12 PM · Restricted Project
thegameg added a comment to D59842: RegScavenger: Fix !AllowSpill if no regs are available.

I would have a slight preference for just:

Tue, Mar 26, 2:13 PM
thegameg accepted D59836: PEI: Delay checking requiresFrameIndexReplacementScavenging.
In D59836#1443555, @arsenm wrote:

I usually try to separate the target specific part when possible: D59840

Tue, Mar 26, 1:34 PM
thegameg added a comment to D59836: PEI: Delay checking requiresFrameIndexReplacementScavenging.

It would be good to have a test case for this, but I assume you're planning on changing SIRegisterInfo::requiresFrameIndexReplacementScavenging? Maybe you can merge both patches since AMDGPU seems to be the only user of the hook.

Tue, Mar 26, 12:58 PM

Mar 20 2019

thegameg updated the diff for D59571: [Remarks] Emit a section containing remark diagnostics metadata.

Update test to use a real path instead of /dev/null. Thanks @ormris, I didn't know lit could do all that!

Mar 20 2019, 11:31 AM · Restricted Project
thegameg added inline comments to D59049: [Remarks] Add a new Remark / RemarkParser abstraction.
Mar 20 2019, 11:15 AM · Restricted Project
thegameg added inline comments to D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 20 2019, 9:55 AM · Restricted Project

Mar 19 2019

thegameg updated the diff for D59571: [Remarks] Emit a section containing remark diagnostics metadata.

Forgot to add it to the diff.

Mar 19 2019, 6:31 PM · Restricted Project
thegameg created D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 19 2019, 5:40 PM · Restricted Project
thegameg committed rG5616718c0875: [Remarks] Fix gcc build for r356519 (authored by thegameg).
[Remarks] Fix gcc build for r356519
Mar 19 2019, 2:32 PM
thegameg committed rL356522: [Remarks] Fix gcc build for r356519.
[Remarks] Fix gcc build for r356519
Mar 19 2019, 2:32 PM
thegameg committed rG5a05cc0eebd4: Reland "[Remarks] Add a new Remark / RemarkParser abstraction" (authored by thegameg).
Reland "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 2:14 PM
thegameg committed rL356519: Reland "[Remarks] Add a new Remark / RemarkParser abstraction".
Reland "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 2:14 PM
thegameg committed rG064774f753a0: Revert "[Remarks] Add a new Remark / RemarkParser abstraction" (authored by thegameg).
Revert "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 11:21 AM
thegameg committed rL356492: Revert "[Remarks] Add a new Remark / RemarkParser abstraction".
Revert "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 11:21 AM
thegameg committed rG9ef60a2539b2: [Remarks] Add a new Remark / RemarkParser abstraction (authored by thegameg).
[Remarks] Add a new Remark / RemarkParser abstraction
Mar 19 2019, 11:09 AM
thegameg committed rL356491: [Remarks] Add a new Remark / RemarkParser abstraction.
[Remarks] Add a new Remark / RemarkParser abstraction
Mar 19 2019, 11:09 AM
thegameg closed D59049: [Remarks] Add a new Remark / RemarkParser abstraction.
Mar 19 2019, 11:09 AM · Restricted Project

Mar 13 2019

thegameg accepted D59271: MIR: Allow targets to serialize MachineFunctionInfo.

This is awesome, thanks for working on this!

Mar 13 2019, 4:45 PM

Mar 12 2019

thegameg updated the diff for D59049: [Remarks] Add a new Remark / RemarkParser abstraction.

Address Jonas' comments.

Mar 12 2019, 6:07 PM · Restricted Project
thegameg committed rGdd42236c6c12: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission" (authored by thegameg).
Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 2:22 PM
thegameg committed rL355984: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission".
Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 2:21 PM
thegameg committed rLLD355984: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission".
Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 2:21 PM
thegameg committed rC355984: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission".
Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 2:21 PM
thegameg committed rG1d6c47ad2bb2: Revert "[Remarks] Add -foptimization-record-passes to filter remark emission" (authored by thegameg).
Revert "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 1:54 PM
thegameg added a reverting change for rG20fff32b7d1f: [Remarks] Add -foptimization-record-passes to filter remark emission: rG1d6c47ad2bb2: Revert "[Remarks] Add -foptimization-record-passes to filter remark emission".
Mar 12 2019, 1:54 PM
thegameg committed rL355976: Revert "[Remarks] Add -foptimization-record-passes to filter remark emission".
Revert "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 1:54 PM
thegameg committed rC355976: Revert "[Remarks] Add -foptimization-record-passes to filter remark emission".
Revert "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 1:53 PM
thegameg committed rLLD355976: Revert "[Remarks] Add -foptimization-record-passes to filter remark emission".
Revert "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 1:53 PM
thegameg added a comment to D59268: [Remarks] Add -foptimization-record-passes to filter remark emission.

Thanks Jessica!

Mar 12 2019, 1:30 PM · Restricted Project
thegameg committed rG20fff32b7d1f: [Remarks] Add -foptimization-record-passes to filter remark emission (authored by thegameg).
[Remarks] Add -foptimization-record-passes to filter remark emission
Mar 12 2019, 1:30 PM
thegameg committed rC355964: [Remarks] Add -foptimization-record-passes to filter remark emission.
[Remarks] Add -foptimization-record-passes to filter remark emission
Mar 12 2019, 1:29 PM
thegameg committed rLLD355964: [Remarks] Add -foptimization-record-passes to filter remark emission.
[Remarks] Add -foptimization-record-passes to filter remark emission
Mar 12 2019, 1:29 PM
thegameg committed rL355964: [Remarks] Add -foptimization-record-passes to filter remark emission.
[Remarks] Add -foptimization-record-passes to filter remark emission
Mar 12 2019, 1:29 PM
thegameg closed D59268: [Remarks] Add -foptimization-record-passes to filter remark emission.
Mar 12 2019, 1:28 PM · Restricted Project
thegameg created D59268: [Remarks] Add -foptimization-record-passes to filter remark emission.
Mar 12 2019, 10:58 AM · Restricted Project

Mar 11 2019

thegameg added inline comments to D59222: MIR: Stop reinitializing target information for every use.
Mar 11 2019, 1:42 PM
thegameg accepted D59222: MIR: Stop reinitializing target information for every use.

LGTM, thanks!

Mar 11 2019, 1:00 PM

Mar 6 2019

thegameg added inline comments to D59049: [Remarks] Add a new Remark / RemarkParser abstraction.
Mar 6 2019, 5:11 PM · Restricted Project
thegameg updated the diff for D59049: [Remarks] Add a new Remark / RemarkParser abstraction.

Thanks Jonas! Addressed all the commends.

Mar 6 2019, 5:11 PM · Restricted Project
thegameg created D59049: [Remarks] Add a new Remark / RemarkParser abstraction.
Mar 6 2019, 1:53 PM · Restricted Project
thegameg committed rGc01140ef1ff6: [MC][MachO] Emit an error for emitting relocations of the form -SYM + cst (authored by thegameg).
[MC][MachO] Emit an error for emitting relocations of the form -SYM + cst
Mar 6 2019, 10:12 AM
thegameg committed rL355527: [MC][MachO] Emit an error for emitting relocations of the form -SYM + cst.
[MC][MachO] Emit an error for emitting relocations of the form -SYM + cst
Mar 6 2019, 10:10 AM
thegameg closed D58944: [MC][MachO] Emit an error for emitting relocations of the form -SYM + cst.
Mar 6 2019, 10:09 AM · Restricted Project
thegameg committed rGb8a847c0a3ed: Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer" (authored by thegameg).
Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"
Mar 6 2019, 7:21 AM
thegameg committed rC355514: Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer".
Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"
Mar 6 2019, 7:20 AM
thegameg committed rL355514: Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer".
Reland "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"
Mar 6 2019, 7:20 AM
thegameg committed rG6b622ebea01b: Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer" (authored by thegameg).
Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"
Mar 6 2019, 6:52 AM
thegameg committed rC355511: Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer".
Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"
Mar 6 2019, 6:52 AM
thegameg committed rL355511: Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer".
Revert "[Remarks] Refactor remark diagnostic emission in a RemarkStreamer"
Mar 6 2019, 6:51 AM
thegameg committed rG9052f50cb4c9: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer (authored by thegameg).
[Remarks] Refactor remark diagnostic emission in a RemarkStreamer
Mar 6 2019, 6:32 AM
thegameg committed rL355507: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer.
[Remarks] Refactor remark diagnostic emission in a RemarkStreamer
Mar 6 2019, 6:32 AM
thegameg committed rC355507: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer.
[Remarks] Refactor remark diagnostic emission in a RemarkStreamer
Mar 6 2019, 6:32 AM
thegameg closed D58996: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer.
Mar 6 2019, 6:31 AM · Restricted Project, Restricted Project

Mar 5 2019

thegameg updated the diff for D58996: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer.

Thanks Jonas!

Mar 5 2019, 4:32 PM · Restricted Project, Restricted Project
thegameg created D58996: [Remarks] Refactor remark diagnostic emission in a RemarkStreamer.
Mar 5 2019, 1:45 PM · Restricted Project, Restricted Project
thegameg committed rGcb056a1a3a98: [Remarks][NFC] Rename RemarkParser to YAMLRemarkParser (authored by thegameg).
[Remarks][NFC] Rename RemarkParser to YAMLRemarkParser
Mar 5 2019, 12:52 PM
thegameg committed rL355441: [Remarks][NFC] Rename RemarkParser to YAMLRemarkParser.
[Remarks][NFC] Rename RemarkParser to YAMLRemarkParser
Mar 5 2019, 12:49 PM
thegameg committed rGb1e36564c67d: [cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS (authored by thegameg).
[cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS
Mar 5 2019, 12:47 PM
thegameg committed rC355440: [cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS.
[cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS
Mar 5 2019, 12:46 PM
thegameg committed rL355440: [cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS.
[cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS
Mar 5 2019, 12:46 PM
thegameg committed rG1c4bab3ba4e0: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks (authored by thegameg).
[OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks
Mar 5 2019, 12:46 PM
thegameg committed rL355439: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.
[OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks
Mar 5 2019, 12:45 PM
thegameg closed D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.
Mar 5 2019, 12:45 PM · Restricted Project

Mar 4 2019

thegameg created D58944: [MC][MachO] Emit an error for emitting relocations of the form -SYM + cst.
Mar 4 2019, 5:47 PM · Restricted Project
thegameg added a comment to D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.

Ping?

Mar 4 2019, 3:28 PM · Restricted Project

Feb 25 2019

thegameg added a comment to D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.
In D58535#1409208, @Meinersbur wrote:

What is the motivation of the rename? What are the plans for more generic OptRemarks?

Feb 25 2019, 4:18 PM · Restricted Project
thegameg added inline comments to D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.
Feb 25 2019, 4:18 PM · Restricted Project
thegameg added inline comments to D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.
Feb 25 2019, 4:11 PM · Restricted Project