Page MenuHomePhabricator

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (187 w, 2 d)

Recent Activity

Today

thegameg accepted D63825: PEI: Add default handling of spills to registers.
Wed, Jun 26, 9:28 AM
thegameg added a comment to D63825: PEI: Add default handling of spills to registers.

Any way we can get a test case for this? Other than that, LGTM.

Wed, Jun 26, 9:02 AM

Yesterday

thegameg added inline comments to D63518: BitStream reader: propagate errors.
Tue, Jun 25, 4:43 PM · Restricted Project, Restricted Project
thegameg added inline comments to D63518: BitStream reader: propagate errors.
Tue, Jun 25, 2:21 PM · Restricted Project, Restricted Project

Wed, Jun 19

thegameg added inline comments to D63466: [Remarks] Add an LLVM-bitstream-based remark serializer.
Wed, Jun 19, 2:17 PM · Restricted Project

Mon, Jun 17

thegameg created D63466: [Remarks] Add an LLVM-bitstream-based remark serializer.
Mon, Jun 17, 6:20 PM · Restricted Project
thegameg committed rG36a7a9827223: [Remarks][Driver] Use the specified format in the remarks file extension (authored by thegameg).
[Remarks][Driver] Use the specified format in the remarks file extension
Mon, Jun 17, 3:47 PM
thegameg committed rL363627: [Remarks][Driver] Use the specified format in the remarks file extension.
[Remarks][Driver] Use the specified format in the remarks file extension
Mon, Jun 17, 3:46 PM
thegameg committed rG34667519dc19: [Remarks] Extend -fsave-optimization-record to specify the format (authored by thegameg).
[Remarks] Extend -fsave-optimization-record to specify the format
Mon, Jun 17, 9:05 AM
thegameg committed rL363573: [Remarks] Extend -fsave-optimization-record to specify the format.
[Remarks] Extend -fsave-optimization-record to specify the format
Mon, Jun 17, 9:05 AM

Fri, Jun 14

thegameg committed rG5501dda24795: [Remarks][NFC] Improve testing and documentation of -foptimization-record-passes (authored by thegameg).
[Remarks][NFC] Improve testing and documentation of -foptimization-record-passes
Fri, Jun 14, 2:36 PM
thegameg committed rL363463: [Remarks][NFC] Improve testing and documentation of -foptimization-record-passes.
[Remarks][NFC] Improve testing and documentation of -foptimization-record-passes
Fri, Jun 14, 2:36 PM
thegameg committed rG0b0851399e31: [Remarks] Use the RemarkSetup error in setupOptimizationRemarks (authored by thegameg).
[Remarks] Use the RemarkSetup error in setupOptimizationRemarks
Fri, Jun 14, 11:16 AM
thegameg committed rL363439: [Remarks] Use the RemarkSetup error in setupOptimizationRemarks.
[Remarks] Use the RemarkSetup error in setupOptimizationRemarks
Fri, Jun 14, 11:15 AM
thegameg committed rG7a21113ce800: Reland: [Remarks] Refactor optimization remarks setup (authored by thegameg).
Reland: [Remarks] Refactor optimization remarks setup
Fri, Jun 14, 9:19 AM
thegameg committed rL363415: Reland: [Remarks] Refactor optimization remarks setup.
Reland: [Remarks] Refactor optimization remarks setup
Fri, Jun 14, 9:19 AM
thegameg added inline comments to D63306: Add a remarks-based code size diffing tool.
Fri, Jun 14, 9:18 AM · Restricted Project

Thu, Jun 13

thegameg added inline comments to D63306: Add a remarks-based code size diffing tool.
Thu, Jun 13, 11:01 PM · Restricted Project
thegameg committed rGe4147ea1ef4d: Revert "[Remarks] Refactor optimization remarks setup" (authored by thegameg).
Revert "[Remarks] Refactor optimization remarks setup"
Thu, Jun 13, 5:03 PM
thegameg added a reverting change for rG6e6e3af55bb9: [Remarks] Refactor optimization remarks setup: rGe4147ea1ef4d: Revert "[Remarks] Refactor optimization remarks setup".
Thu, Jun 13, 5:03 PM
thegameg committed rL363343: Revert "[Remarks] Refactor optimization remarks setup".
Revert "[Remarks] Refactor optimization remarks setup"
Thu, Jun 13, 5:03 PM
thegameg committed rG6e6e3af55bb9: [Remarks] Refactor optimization remarks setup (authored by thegameg).
[Remarks] Refactor optimization remarks setup
Thu, Jun 13, 2:45 PM
thegameg committed rL363328: [Remarks] Refactor optimization remarks setup.
[Remarks] Refactor optimization remarks setup
Thu, Jun 13, 2:44 PM

Tue, Jun 11

thegameg accepted D63124: [NFC] Correct comments in RegisterCoalescer..

LGTM, thanks!

Tue, Jun 11, 2:17 PM · Restricted Project
thegameg edited reviewers for D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack, added: qcolombet; removed: lebedev.ri.

I agree this needs to be fixed.

Tue, Jun 11, 11:00 AM · Restricted Project

Mon, Jun 10

thegameg added a comment to D62361: [FastISel] Skip creating unnecessary vregs for arguments.

Thanks Hal!

Mon, Jun 10, 10:54 AM · Restricted Project
thegameg committed rGa438432accde: [FastISel] Skip creating unnecessary vregs for arguments (authored by thegameg).
[FastISel] Skip creating unnecessary vregs for arguments
Mon, Jun 10, 9:52 AM
thegameg committed rL362963: [FastISel] Skip creating unnecessary vregs for arguments.
[FastISel] Skip creating unnecessary vregs for arguments
Mon, Jun 10, 9:52 AM
thegameg closed D62361: [FastISel] Skip creating unnecessary vregs for arguments.
Mon, Jun 10, 9:51 AM · Restricted Project

Tue, Jun 4

thegameg added a comment to D62361: [FastISel] Skip creating unnecessary vregs for arguments.

Ping?

Tue, Jun 4, 6:29 AM · Restricted Project

Thu, May 30

thegameg added a comment to D62632: [Remarks][NFC] Move the serialization to lib/Remarks.

Sorry about that. Thanks @sbc100!

Thu, May 30, 5:37 PM · Restricted Project
thegameg accepted D62709: Fix -DBUILD_SHARED_LIBS=ON build after rL362160.

Sorry about this! This LGTM, thanks for fixing it!

Thu, May 30, 5:27 PM · Restricted Project, Restricted Project
thegameg committed rG48998d10e089: [Remarks] Fix usage of enum class (authored by thegameg).
[Remarks] Fix usage of enum class
Thu, May 30, 3:00 PM
thegameg committed rL362165: [Remarks] Fix usage of enum class.
[Remarks] Fix usage of enum class
Thu, May 30, 3:00 PM
thegameg committed rG6ada11f13466: [Remarks][NFC] Move the serialization to lib/Remarks (authored by thegameg).
[Remarks][NFC] Move the serialization to lib/Remarks
Thu, May 30, 2:44 PM
thegameg committed rL362160: [Remarks][NFC] Move the serialization to lib/Remarks.
[Remarks][NFC] Move the serialization to lib/Remarks
Thu, May 30, 2:43 PM
thegameg closed D62632: [Remarks][NFC] Move the serialization to lib/Remarks.
Thu, May 30, 2:43 PM · Restricted Project

Wed, May 29

thegameg created D62632: [Remarks][NFC] Move the serialization to lib/Remarks.
Wed, May 29, 3:28 PM · Restricted Project
thegameg accepted D62631: [LoopIdiom] Basic OptimizationRemarkEmitter handling.

LGTM, thanks!

Wed, May 29, 3:22 PM · Restricted Project
thegameg added inline comments to D62631: [LoopIdiom] Basic OptimizationRemarkEmitter handling.
Wed, May 29, 2:55 PM · Restricted Project

May 23 2019

thegameg created D62361: [FastISel] Skip creating unnecessary vregs for arguments.
May 23 2019, 6:01 PM · Restricted Project

May 21 2019

thegameg added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

Done here https://reviews.llvm.org/rG00e85f753583. Sorry for the inconvenience

May 21 2019, 1:39 PM
thegameg added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

I think you can just commit a fix to move it to the right place. Thanks!

May 21 2019, 1:15 PM
thegameg added a comment to rG6e19543a2a20: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the….

Seems like this went into /test instead of /llvm/test.

May 21 2019, 12:54 PM

May 14 2019

thegameg added a comment to D61437: [AArch64] Static (de)allocation of SVE stack objects..

This sounds like it will report the wrong stack size in PEI for the StackSize remark and the stack size warning. Is that expected?

May 14 2019, 8:32 AM

May 13 2019

thegameg added a reviewer for D61061: [MachineFunction] Base support for call site info tracking: qcolombet.

I think this is the first type of entry in MIR that references instructions directly, and it seems quite easy to forget to update the offset in the block when adding/removing instructions, but I guess checking for ranges and if the instruction is a call might help.

May 13 2019, 11:02 AM · debug-info

Apr 23 2019

thegameg committed rG465415f1db2b: [Remarks] Fix documentation indentation (authored by thegameg).
[Remarks] Fix documentation indentation
Apr 23 2019, 5:27 PM
thegameg committed rL359053: [Remarks] Fix documentation indentation.
[Remarks] Fix documentation indentation
Apr 23 2019, 5:26 PM
thegameg committed rG7fee2b89fd6e: [Remarks] Add string deduplication using a string table (authored by thegameg).
[Remarks] Add string deduplication using a string table
Apr 23 2019, 5:07 PM
thegameg committed rL359050: [Remarks] Add string deduplication using a string table.
[Remarks] Add string deduplication using a string table
Apr 23 2019, 5:07 PM
thegameg closed D60227: [Remarks] Add string deduplication using a string table.
Apr 23 2019, 5:07 PM · Restricted Project
thegameg added a comment to D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.

LGTM.

Apr 23 2019, 3:00 PM · Restricted Project
thegameg committed rG1646851b87cf: [CGP] Look through bitcasts when duplicating returns for tail calls (authored by thegameg).
[CGP] Look through bitcasts when duplicating returns for tail calls
Apr 23 2019, 2:56 PM
thegameg committed rGeea9da5921de: [X86] Add codegen prepare test exercising a bitcast + tail call (authored by thegameg).
[X86] Add codegen prepare test exercising a bitcast + tail call
Apr 23 2019, 2:56 PM
thegameg committed rL359041: [CGP] Look through bitcasts when duplicating returns for tail calls.
[CGP] Look through bitcasts when duplicating returns for tail calls
Apr 23 2019, 2:56 PM
thegameg closed D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
Apr 23 2019, 2:56 PM · Restricted Project
thegameg committed rL359040: [X86] Add codegen prepare test exercising a bitcast + tail call.
[X86] Add codegen prepare test exercising a bitcast + tail call
Apr 23 2019, 2:56 PM
thegameg added inline comments to D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
Apr 23 2019, 2:31 PM · Restricted Project
thegameg updated the diff for D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
  • Use Value:: stripPointerCasts instead of checking for BitCastInst.
  • Add opt -codegenprepare test and full codegen test separately (to commit before this).
  • Use utils/update_test_checks.py and utils/update_llc_test_checks.py for the new tests.
Apr 23 2019, 2:27 PM · Restricted Project

Apr 17 2019

thegameg added inline comments to D60227: [Remarks] Add string deduplication using a string table.
Apr 17 2019, 3:08 PM · Restricted Project
thegameg created D60837: [CGP] Look through bitcasts when duplicating returns for tail calls.
Apr 17 2019, 2:48 PM · Restricted Project

Apr 8 2019

thegameg added a reviewer for D60137: Describe stack-id as an enum: qcolombet.
Apr 8 2019, 11:11 AM · Restricted Project

Apr 5 2019

thegameg committed rG9d9d1b6b2ba0: [X86] Enable tail calls for CallingConv::Swift (authored by thegameg).
[X86] Enable tail calls for CallingConv::Swift
Apr 5 2019, 1:18 PM
thegameg committed rGab051a378c9c: [X86] Preserve operand flag when expanding TCRETURNri (authored by thegameg).
[X86] Preserve operand flag when expanding TCRETURNri
Apr 5 2019, 1:17 PM
thegameg committed rL357809: [X86] Enable tail calls for CallingConv::Swift.
[X86] Enable tail calls for CallingConv::Swift
Apr 5 2019, 1:16 PM
thegameg committed rL357808: [X86] Preserve operand flag when expanding TCRETURNri.
[X86] Preserve operand flag when expanding TCRETURNri
Apr 5 2019, 1:16 PM

Apr 3 2019

thegameg added a comment to D60227: [Remarks] Add string deduplication using a string table.

Is this transparent to tools that use LLVM's YAML library? Other tools?

If not, we'll need to update the llvm-opt-report tool and the opt-viewer tool.

Apr 3 2019, 8:30 PM · Restricted Project
thegameg updated the diff for D60227: [Remarks] Add string deduplication using a string table.

Address Jonas' remarks.

Apr 3 2019, 8:21 PM · Restricted Project
thegameg updated the diff for D60227: [Remarks] Add string deduplication using a string table.

Remove remarks::StringTable::get.

Apr 3 2019, 2:32 PM · Restricted Project
thegameg added inline comments to D60227: [Remarks] Add string deduplication using a string table.
Apr 3 2019, 2:32 PM · Restricted Project
thegameg created D60227: [Remarks] Add string deduplication using a string table.
Apr 3 2019, 12:44 PM · Restricted Project

Apr 2 2019

thegameg committed rG1ed4bbb9ab66: [Remarks][NFCI] Remove useless include (authored by thegameg).
[Remarks][NFCI] Remove useless include
Apr 2 2019, 10:50 AM
thegameg committed rL357503: [Remarks][NFCI] Remove useless include.
[Remarks][NFCI] Remove useless include
Apr 2 2019, 10:50 AM
thegameg added a comment to D60137: Describe stack-id as an enum.

This is definitely nicer, thanks for working on it.

Apr 2 2019, 9:41 AM · Restricted Project

Mar 26 2019

thegameg accepted D59853: MIR: Freeze reserved regs after parsing everything.

This LGTM with one comment.

Mar 26 2019, 6:46 PM
thegameg committed rGee1a6e70fa55: [Remarks] Emit a section containing remark diagnostics metadata (authored by thegameg).
[Remarks] Emit a section containing remark diagnostics metadata
Mar 26 2019, 6:13 PM
thegameg committed rL357043: [Remarks] Emit a section containing remark diagnostics metadata.
[Remarks] Emit a section containing remark diagnostics metadata
Mar 26 2019, 6:12 PM
thegameg closed D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 26 2019, 6:12 PM · Restricted Project
thegameg added a comment to D59842: RegScavenger: Fix !AllowSpill if no regs are available.

I would have a slight preference for just:

Mar 26 2019, 2:13 PM
thegameg accepted D59836: PEI: Delay checking requiresFrameIndexReplacementScavenging.

I usually try to separate the target specific part when possible: D59840

Mar 26 2019, 1:34 PM
thegameg added a comment to D59836: PEI: Delay checking requiresFrameIndexReplacementScavenging.

It would be good to have a test case for this, but I assume you're planning on changing SIRegisterInfo::requiresFrameIndexReplacementScavenging? Maybe you can merge both patches since AMDGPU seems to be the only user of the hook.

Mar 26 2019, 12:58 PM

Mar 20 2019

thegameg updated the diff for D59571: [Remarks] Emit a section containing remark diagnostics metadata.

Update test to use a real path instead of /dev/null. Thanks @ormris, I didn't know lit could do all that!

Mar 20 2019, 11:31 AM · Restricted Project
thegameg added inline comments to D59049: [Remarks] Add a new Remark / RemarkParser abstraction.
Mar 20 2019, 11:15 AM · Restricted Project
thegameg added inline comments to D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 20 2019, 9:55 AM · Restricted Project

Mar 19 2019

thegameg updated the diff for D59571: [Remarks] Emit a section containing remark diagnostics metadata.

Forgot to add it to the diff.

Mar 19 2019, 6:31 PM · Restricted Project
thegameg created D59571: [Remarks] Emit a section containing remark diagnostics metadata.
Mar 19 2019, 5:40 PM · Restricted Project
thegameg committed rG5616718c0875: [Remarks] Fix gcc build for r356519 (authored by thegameg).
[Remarks] Fix gcc build for r356519
Mar 19 2019, 2:32 PM
thegameg committed rL356522: [Remarks] Fix gcc build for r356519.
[Remarks] Fix gcc build for r356519
Mar 19 2019, 2:32 PM
thegameg committed rG5a05cc0eebd4: Reland "[Remarks] Add a new Remark / RemarkParser abstraction" (authored by thegameg).
Reland "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 2:14 PM
thegameg committed rL356519: Reland "[Remarks] Add a new Remark / RemarkParser abstraction".
Reland "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 2:14 PM
thegameg committed rG064774f753a0: Revert "[Remarks] Add a new Remark / RemarkParser abstraction" (authored by thegameg).
Revert "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 11:21 AM
thegameg committed rL356492: Revert "[Remarks] Add a new Remark / RemarkParser abstraction".
Revert "[Remarks] Add a new Remark / RemarkParser abstraction"
Mar 19 2019, 11:21 AM
thegameg committed rG9ef60a2539b2: [Remarks] Add a new Remark / RemarkParser abstraction (authored by thegameg).
[Remarks] Add a new Remark / RemarkParser abstraction
Mar 19 2019, 11:09 AM
thegameg committed rL356491: [Remarks] Add a new Remark / RemarkParser abstraction.
[Remarks] Add a new Remark / RemarkParser abstraction
Mar 19 2019, 11:09 AM
thegameg closed D59049: [Remarks] Add a new Remark / RemarkParser abstraction.
Mar 19 2019, 11:09 AM · Restricted Project

Mar 13 2019

thegameg accepted D59271: MIR: Allow targets to serialize MachineFunctionInfo.

This is awesome, thanks for working on this!

Mar 13 2019, 4:45 PM

Mar 12 2019

thegameg updated the diff for D59049: [Remarks] Add a new Remark / RemarkParser abstraction.

Address Jonas' comments.

Mar 12 2019, 6:07 PM · Restricted Project
thegameg committed rGdd42236c6c12: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission" (authored by thegameg).
Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 2:22 PM
thegameg committed rL355984: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission".
Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 2:21 PM
thegameg committed rLLD355984: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission".
Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"
Mar 12 2019, 2:21 PM