Page MenuHomePhabricator

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (217 w, 11 h)

Recent Activity

Fri, Jan 17

thegameg added a comment to D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block..

Hi @plotfi, this seems to cause failures with ASAN and UBSAN on green dragon: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6886/consoleFull

Fri, Jan 17, 10:41 AM · Restricted Project
thegameg committed rG03689fe97f23: [perf-training] Ignore ' (in-process)' prefix from -### (authored by thegameg).
[perf-training] Ignore ' (in-process)' prefix from -###
Fri, Jan 17, 9:45 AM

Wed, Jan 8

thegameg added a comment to D72425: [OptRemark] RFC: Introduce a message table for OptRemarks.

As Francis mentioned it before it would be good derive the pass name from the remark type (diag::remark_gvn_load_elim -> gvn) . I.e. I would drop the DEBUG_TYPE argument.

This is one of the things that I thought could be a field in the OptRemark class. I think it makes sense to have this kind of property tightly coupled with the message. Francis mentioned a potential problem with keeping that synchronized with where the remarks are emitted, but I think if we think of it in terms of a category of optimization rather than a pass name that isn't a problem, because the nature of the optimization being described won't change even if, for example, you move it from InstCombine to AggressiveInstCombine. Or perhaps I'm introducing a second concept here. There's a bit of a disconnect between compiler developers who want to use this feature and compiler users who want to use the feature. The latter group is probably more interested in being able to say, for example, show me all remarks related to loop optimization rather than show me remarks from the loop rotate pass.

Wed, Jan 8, 5:29 PM · Restricted Project

Fri, Jan 3

thegameg committed rGc8ab40ca0e76: [Remarks] Warn if a remark file is not found when processing static archives (authored by thegameg).
[Remarks] Warn if a remark file is not found when processing static archives
Fri, Jan 3, 5:07 PM

Dec 18 2019

thegameg committed rGf550961c6e83: [Docs] Fix indentation in remarks section (authored by thegameg).
[Docs] Fix indentation in remarks section
Dec 18 2019, 4:53 PM
thegameg committed rG07b8f8e5f5ca: [Remarks][Driver] Place temporary remark files next to temporary object files (authored by thegameg).
[Remarks][Driver] Place temporary remark files next to temporary object files
Dec 18 2019, 4:53 PM
thegameg committed rGd79b11fefb8e: [Remarks][Driver] Run dsymutil when remarks are enabled (authored by thegameg).
[Remarks][Driver] Run dsymutil when remarks are enabled
Dec 18 2019, 2:39 PM
thegameg committed rGa8c678cb9a90: [Remarks][Driver][NFC] Make shouldEmitRemarks more available in the Driver (authored by thegameg).
[Remarks][Driver][NFC] Make shouldEmitRemarks more available in the Driver
Dec 18 2019, 2:39 PM
thegameg closed D71675: [Remarks][Driver] Run dsymutil when remarks are enabled.
Dec 18 2019, 2:39 PM · debug-info, Restricted Project
thegameg added inline comments to D71675: [Remarks][Driver] Run dsymutil when remarks are enabled.
Dec 18 2019, 1:32 PM · debug-info, Restricted Project
thegameg created D71675: [Remarks][Driver] Run dsymutil when remarks are enabled.
Dec 18 2019, 1:22 PM · debug-info, Restricted Project

Dec 17 2019

thegameg accepted D71394: llvm-objdump should ignore Mach-O stab symbols for disassembly..

Thanks for the clarification in the comment. This LGTM!

Dec 17 2019, 1:50 PM · Restricted Project
thegameg accepted D70483: AArch64: add FastISel support for arm64_32.

I don't have much knowledge in this part of the code, but everything looks good to me. Maybe add a simple comment at the top of the file with an overview of what was needed to add support for ILP32 (maybe pointing out that it consists of using ands, extractsubregs, etc.) ?

Dec 17 2019, 1:35 PM · Restricted Project
thegameg accepted D71334: [AArch64] Enable clustering memory accesses to fixed stack objects.

LGTM. Thanks for fixing this.

Dec 17 2019, 1:15 PM · Restricted Project

Dec 12 2019

Visoiu Mistrih Francis <890283+francisvm@users.noreply.github.com> committed rG1169e77501a5: [ObjC] Override TailCallKind when lowering objc intrinsics (authored by thegameg).
[ObjC] Override TailCallKind when lowering objc intrinsics
Dec 12 2019, 3:50 PM
thegameg committed rGa5dd10591c76: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by thegameg).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Dec 12 2019, 2:27 PM
thegameg committed rGd822919c8db5: [clang] Fix build after FileManager changes (authored by thegameg).
[clang] Fix build after FileManager changes
Dec 12 2019, 2:26 PM
thegameg committed rGb53c383162a1: Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift (authored by thegameg).
Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift
Dec 12 2019, 2:26 PM
thegameg committed rGe130c5bc6a16: [Bitcode] Add proper inclues to unit test (authored by thegameg).
[Bitcode] Add proper inclues to unit test
Dec 12 2019, 2:17 PM
thegameg committed rGdb0c9a513a0e: [Frontend] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h (authored by thegameg).
[Frontend] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h
Dec 12 2019, 2:12 PM
thegameg committed rG9eba2ac9ed4e: [APINotes] Explicitly include Bitstream/BitCodes.h (authored by thegameg).
[APINotes] Explicitly include Bitstream/BitCodes.h
Dec 12 2019, 2:11 PM
thegameg committed rG9e2de3861a51: [Bitcode] Update includes: llvm/Bitcode -> llvm/Bitstream (authored by thegameg).
[Bitcode] Update includes: llvm/Bitcode -> llvm/Bitstream
Dec 12 2019, 2:09 PM
thegameg committed rG282612931a82: RecordLayout.h: llvm/Bitcode -> llvm/Bitstream (authored by thegameg).
RecordLayout.h: llvm/Bitcode -> llvm/Bitstream
Dec 12 2019, 2:09 PM
thegameg committed rGbcd16ae9d95a: Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift (authored by thegameg).
Merge branch 'master' of http://llvm.org/git/llvm into upstream-with-swift
Dec 12 2019, 2:09 PM
thegameg committed rG04f8ab0866ae: [ADT] Remove partial template specialization that Swift was relying on (authored by thegameg).
[ADT] Remove partial template specialization that Swift was relying on
Dec 12 2019, 1:00 PM
thegameg committed rG94358b8c4319: Merge branch 'master' of https://llvm.org/git/clang into upstream-with-swift (authored by thegameg).
Merge branch 'master' of https://llvm.org/git/clang into upstream-with-swift
Dec 12 2019, 12:36 PM
thegameg committed rG539aeba77f49: Merge branch 'master' of https://llvm.org/git/clang into upstream-with-swift (authored by thegameg).
Merge branch 'master' of https://llvm.org/git/clang into upstream-with-swift
Dec 12 2019, 12:23 PM
thegameg committed rGdc052754e5e5: [AST] Add another missing initialization from merge (authored by thegameg).
[AST] Add another missing initialization from merge
Dec 12 2019, 12:22 PM

Dec 11 2019

thegameg committed rG60590b149b33: [Remarks][Driver] Ask for line tables when remarks are enabled (authored by thegameg).
[Remarks][Driver] Ask for line tables when remarks are enabled
Dec 11 2019, 6:02 PM
thegameg closed D71325: [Remarks][Driver] Ask for line tables when remarks are enabled.
Dec 11 2019, 6:02 PM · debug-info, Restricted Project
thegameg updated the diff for D71325: [Remarks][Driver] Ask for line tables when remarks are enabled.
Dec 11 2019, 3:33 PM · debug-info, Restricted Project

Dec 10 2019

thegameg created D71325: [Remarks][Driver] Ask for line tables when remarks are enabled.
Dec 10 2019, 9:01 PM · debug-info, Restricted Project
thegameg accepted D71257: Verifier: Check frame-pointer attribute values.

Sounds like a good idea.

Dec 10 2019, 2:55 PM · Restricted Project
thegameg committed rG3bd7cbb90cdb: [Remarks][Docs] Enhance documentation for opt-remarks driver options (authored by thegameg).
[Remarks][Docs] Enhance documentation for opt-remarks driver options
Dec 10 2019, 1:24 PM

Dec 9 2019

thegameg committed rGae09dd86a9b7: [Remarks][Driver] Error on -foptimization-record-file with multiple -arch… (authored by thegameg).
[Remarks][Driver] Error on -foptimization-record-file with multiple -arch…
Dec 9 2019, 8:48 PM

Dec 6 2019

thegameg accepted D70691: Optimization record for bytecode input missing- PR44000.

LGTM

Dec 6 2019, 2:34 PM · Restricted Project

Dec 5 2019

thegameg accepted D71095: [X86] Fix prolog/epilog mismatch for stack protectors on win32-macho..

LGTM

Dec 5 2019, 4:14 PM · Restricted Project

Dec 4 2019

thegameg accepted D70691: Optimization record for bytecode input missing- PR44000.

LGTM with one last nit, thanks!

Dec 4 2019, 9:23 AM · Restricted Project

Dec 2 2019

thegameg committed rG7902d6cc8030: [Remarks][ThinLTO] Use the correct file extension based on the format (authored by thegameg).
[Remarks][ThinLTO] Use the correct file extension based on the format
Dec 2 2019, 1:12 PM
thegameg added inline comments to D70577: [Remarks][LTO] Infer remarks file path from -object_path_lto.
Dec 2 2019, 10:43 AM
thegameg added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Thanks for fixing this!

Dec 2 2019, 8:52 AM · Restricted Project
thegameg accepted D70748: [clang test] Do not assume default target.

LGTM, thanks for fixing this.

Dec 2 2019, 8:43 AM · Restricted Project

Nov 22 2019

thegameg committed rG4506afe3ca3b: [Remarks] Allow empty temporary remark files (authored by thegameg).
[Remarks] Allow empty temporary remark files
Nov 22 2019, 4:05 PM

Nov 21 2019

thegameg created D70577: [Remarks][LTO] Infer remarks file path from -object_path_lto.
Nov 21 2019, 4:56 PM

Nov 19 2019

thegameg committed rGbffdee8ef379: [LTO][Legacy] Add API for passing LLVM options separately (authored by thegameg).
[LTO][Legacy] Add API for passing LLVM options separately
Nov 19 2019, 4:41 PM
thegameg closed D70463: [LTO][Legacy] Add API for passing LLVM options separately.
Nov 19 2019, 4:41 PM · Restricted Project
thegameg updated the diff for D70463: [LTO][Legacy] Add API for passing LLVM options separately.
  • Move string splitting to lto_codegen_debug_options.
  • Remove null checks since none of the other lto_* functions do it.
Nov 19 2019, 4:05 PM · Restricted Project
thegameg created D70463: [LTO][Legacy] Add API for passing LLVM options separately.
Nov 19 2019, 2:15 PM · Restricted Project

Nov 18 2019

thegameg committed rGe15b26fbbd90: Reland: [Remarks][Driver] Use different remark files when targeting multiple… (authored by thegameg).
Reland: [Remarks][Driver] Use different remark files when targeting multiple…
Nov 18 2019, 11:18 AM
thegameg committed rGb4e2b112b581: [Remarks][Driver] Use different remark files when targeting multiple… (authored by thegameg).
[Remarks][Driver] Use different remark files when targeting multiple…
Nov 18 2019, 10:41 AM

Nov 14 2019

thegameg committed rGa4c76be50689: [InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI (authored by thegameg).
[InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI
Nov 14 2019, 5:58 PM
thegameg closed D70016: [InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI.
Nov 14 2019, 5:58 PM · Restricted Project
thegameg added inline comments to D70016: [InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI.
Nov 14 2019, 11:29 AM · Restricted Project

Nov 13 2019

thegameg committed rG3dfe4cf982d5: [dsymutil] Add -dump to llvm-bcanalyzer invocations (authored by thegameg).
[dsymutil] Add -dump to llvm-bcanalyzer invocations
Nov 13 2019, 12:28 PM
thegameg committed rG1ca85b3d33a1: [llvm-bcanalyzer] Don't dump the contents if -dump is not passed (authored by thegameg).
[llvm-bcanalyzer] Don't dump the contents if -dump is not passed
Nov 13 2019, 10:41 AM

Nov 12 2019

thegameg added a reviewer for D70016: [InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI: fhahn.
Nov 12 2019, 4:17 PM · Restricted Project

Nov 11 2019

thegameg committed rGa9a3781df81a: [ObjC] Override TailCallKind when lowering objc intrinsics (authored by thegameg).
[ObjC] Override TailCallKind when lowering objc intrinsics
Nov 11 2019, 8:40 AM
thegameg closed D69980: [ObjC] Override TailCallKind when lowering objc intrinsics.
Nov 11 2019, 8:40 AM · Restricted Project
thegameg accepted D70061: [AArch64ExpandPseudos] Preserve renamable state when expanding MOVi64 & co..

LGTM

Nov 11 2019, 7:27 AM · Restricted Project

Nov 10 2019

thegameg added inline comments to D70061: [AArch64ExpandPseudos] Preserve renamable state when expanding MOVi64 & co..
Nov 10 2019, 3:02 PM · Restricted Project

Nov 8 2019

thegameg created D70016: [InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI.
Nov 8 2019, 10:17 AM · Restricted Project

Nov 7 2019

thegameg updated the diff for D69980: [ObjC] Override TailCallKind when lowering objc intrinsics.

Remove useless #include.

Nov 7 2019, 6:18 PM · Restricted Project
thegameg created D69980: [ObjC] Override TailCallKind when lowering objc intrinsics.
Nov 7 2019, 6:10 PM · Restricted Project

Nov 5 2019

thegameg committed rG47d1029788b6: [ObjC][ARC] Ignore lifetime markers between *ReturnValue calls (authored by thegameg).
[ObjC][ARC] Ignore lifetime markers between *ReturnValue calls
Nov 5 2019, 7:05 AM
thegameg committed rG68f39de042ef: [NFC][ObjC][ARC] Add tests for OptimizeRetainRVCall (authored by thegameg).
[NFC][ObjC][ARC] Add tests for OptimizeRetainRVCall
Nov 5 2019, 7:05 AM
thegameg closed D69833: [ObjC][ARC] Ignore lifetime markers between *ReturnValue calls.
Nov 5 2019, 7:05 AM · Restricted Project

Nov 4 2019

thegameg updated the diff for D69833: [ObjC][ARC] Ignore lifetime markers between *ReturnValue calls.

Remove the double check for IsNoopInstruction.

Nov 4 2019, 6:02 PM · Restricted Project
thegameg created D69833: [ObjC][ARC] Ignore lifetime markers between *ReturnValue calls.
Nov 4 2019, 5:00 PM · Restricted Project

Nov 1 2019

thegameg committed rGcc9e963d6594: [dsymutil] Second attempt to fix dsymutil tests on non-darwin platforms (authored by thegameg).
[dsymutil] Second attempt to fix dsymutil tests on non-darwin platforms
Nov 1 2019, 9:15 PM
thegameg committed rG86cdf74dc871: [dsymutil] Require darwin in fat binary test (authored by thegameg).
[dsymutil] Require darwin in fat binary test
Nov 1 2019, 4:26 PM
thegameg committed rG1ee18f275e60: [dsymutil] Add support for linking remarks (authored by thegameg).
[dsymutil] Add support for linking remarks
Nov 1 2019, 3:40 PM
thegameg closed D69142: [dsymutil] Add support for linking remarks.
Nov 1 2019, 3:39 PM · Restricted Project

Oct 31 2019

thegameg committed rG6b82988f7e33: [Remarks] Fix error message check in unit test (authored by thegameg).
[Remarks] Fix error message check in unit test
Oct 31 2019, 3:58 PM
thegameg committed rGe72e59e90287: [Remarks] Add support for linking remarks (authored by thegameg).
[Remarks] Add support for linking remarks
Oct 31 2019, 3:30 PM
thegameg closed D69141: [Remarks] Add support for linking remarks.
Oct 31 2019, 3:30 PM · Restricted Project
thegameg updated the diff for D69142: [dsymutil] Add support for linking remarks.

Address comments.

Oct 31 2019, 2:52 PM · Restricted Project

Oct 28 2019

thegameg committed rGf5094e182947: [Remarks] Fix Sphinx formatting (authored by thegameg).
[Remarks] Fix Sphinx formatting
Oct 28 2019, 1:14 PM
thegameg committed rG025166cf4800: [Remarks] Add bitstream to the list of supported formats in clang (authored by thegameg).
[Remarks] Add bitstream to the list of supported formats in clang
Oct 28 2019, 1:08 PM
thegameg committed rGc7557dd69236: [Remarks] Remove references to ELF support (authored by thegameg).
[Remarks] Remove references to ELF support
Oct 28 2019, 12:51 PM
thegameg committed rG209d5a12c55f: [Remarks] Emit the remarks section by default for certain formats (authored by thegameg).
[Remarks] Emit the remarks section by default for certain formats
Oct 28 2019, 12:51 PM

Oct 24 2019

thegameg added inline comments to D69141: [Remarks] Add support for linking remarks.
Oct 24 2019, 3:49 PM · Restricted Project
thegameg updated the diff for D69141: [Remarks] Add support for linking remarks.
Oct 24 2019, 3:48 PM · Restricted Project

Oct 17 2019

thegameg added a child revision for D69142: [dsymutil] Add support for linking remarks: D69141: [Remarks] Add support for linking remarks.
Oct 17 2019, 2:37 PM · Restricted Project
thegameg added a parent revision for D69141: [Remarks] Add support for linking remarks: D69142: [dsymutil] Add support for linking remarks.
Oct 17 2019, 2:37 PM · Restricted Project
thegameg created D69142: [dsymutil] Add support for linking remarks.
Oct 17 2019, 2:37 PM · Restricted Project
thegameg created D69141: [Remarks] Add support for linking remarks.
Oct 17 2019, 2:37 PM · Restricted Project

Oct 16 2019

thegameg added inline comments to D69018: [AArch64] Fix offset calculation.
Oct 16 2019, 10:46 AM · Restricted Project
thegameg committed rG0947af7ac539: [Remarks] Fix warning for ambigous `else` behind EXPECT macro (authored by thegameg).
[Remarks] Fix warning for ambigous `else` behind EXPECT macro
Oct 16 2019, 9:51 AM
thegameg committed rG437f362c3380: [Remarks] Fix unit test by only checking for the path (authored by thegameg).
[Remarks] Fix unit test by only checking for the path
Oct 16 2019, 9:41 AM
thegameg committed rL375015: [Remarks] Fix warning for ambigous `else` behind EXPECT macro.
[Remarks] Fix warning for ambigous `else` behind EXPECT macro
Oct 16 2019, 9:41 AM
thegameg committed rL375014: [Remarks] Fix unit test by only checking for the path.
[Remarks] Fix unit test by only checking for the path
Oct 16 2019, 9:32 AM
thegameg committed rG0216a3c6d1c1: [Remarks] Use StringRef::contains to avoid differences in error string (authored by thegameg).
[Remarks] Use StringRef::contains to avoid differences in error string
Oct 16 2019, 9:22 AM
thegameg committed rL375011: [Remarks] Use StringRef::contains to avoid differences in error string.
[Remarks] Use StringRef::contains to avoid differences in error string
Oct 16 2019, 9:22 AM
thegameg committed rG684605ec0ea2: [Remarks] Add support for prepending a path to external files (authored by thegameg).
[Remarks] Add support for prepending a path to external files
Oct 16 2019, 8:46 AM
thegameg committed rL375008: [Remarks] Add support for prepending a path to external files.
[Remarks] Add support for prepending a path to external files
Oct 16 2019, 8:46 AM

Oct 14 2019

Herald updated subscribers of D67216: [cfi] Add flag to always generate .debug_frame.
Oct 14 2019, 10:06 AM · Restricted Project, Restricted Project

Oct 11 2019

thegameg committed rL374586: Request commit access for thegameg.
Request commit access for thegameg
Oct 11 2019, 1:00 PM

Oct 8 2019

thegameg committed rG143f6b837790: [IRGen] Emit lifetime markers for temporary struct allocas (authored by thegameg).
[IRGen] Emit lifetime markers for temporary struct allocas
Oct 8 2019, 3:12 PM
thegameg closed D68611: [IRGen] Emit lifetime markers for temporary struct allocas.
Oct 8 2019, 3:12 PM · Restricted Project
thegameg committed rL374126: [IRGen] Emit lifetime markers for temporary struct allocas.
[IRGen] Emit lifetime markers for temporary struct allocas
Oct 8 2019, 3:12 PM