- User Since
- Nov 23 2015, 4:41 AM (117 w, 3 d)
Mon, Feb 19
Thu, Feb 15
Forget the asserts part.
Wed, Feb 14
Thanks @CarlosAlbertoEnciso, I finally understood the original concern about shrink-wrapping. LGTM.
Tue, Feb 13
Fri, Feb 9
Thu, Feb 8
I might be missing a few details of what this change might affect.
Wed, Feb 7
- Fix typo
- Iterate on MBB in reverse to catch terminator uses first
Tue, Feb 6
For me this is generally ok, but I would wait for the other reviewers to see if there are any concerns.
Address review concerns.
Mon, Feb 5
- Stop looping if none of the elements are tracked anymore.
- Let the caller decide what to do with untracked elements.
- Comments / style updates.
One last comment and it should be good. Thanks!
Sun, Feb 4
Thanks for working on this!
Fri, Feb 2
It seems like this commit breaks all release bots:
Wed, Jan 31
Split DefaultShrinkWrapper and DefaultShrinkWrapInfo into:
I think MIRLangRef needs to be updated, but other than that, LGTM!
Tue, Jan 30
Thanks for working on this! I think the idea is worth pursuing. This kinda reminds me of Post Register Allocation Spill Code Optimization, Christopher Lupo, Kent D. Wilken. A similar issue is what they describe in §4.8. I think if you extract the blocks C, D, E, F from the example, that's your function.
Mon, Jan 29
- Added support for addrspace in r323521.
This LGTM, thanks.
Sat, Jan 27
Fri, Jan 26
Thu, Jan 25
Update some more failing tests.
Wed, Jan 24
Add test case with addrspace 0.
Thanks for working on this! I've seen a few 1-2% improvements on arm64 with this enabled and I think it solves one of the issue that has been frequently raised with shrink-wrapping.
Tue, Jan 23
Jan 22 2018
Jan 19 2018
Jan 18 2018
Sorry, I missed your comment @MatzeB. IsStandalone sounds better indeed, I fixed it in r322867.
Jan 17 2018
Jan 16 2018
Jan 15 2018
Jan 12 2018
Jan 10 2018
Go with Matthias' explanation.
Jan 9 2018
Jan 8 2018
Going forward with this: https://reviews.llvm.org/D41765 which is a more incremental approach.
DefaultShrinkWrapper doesn't need the RegScavenger, only DefaultShrinkWrapInfo.