- User Since
- Nov 23 2015, 4:41 AM (148 w, 1 d)
Thu, Sep 20
Thu, Sep 13
Thu, Sep 6
Can you please also add support for the new CFI directive in MIR? Mostly in lib/CodeGen/MIRParser/MIParser.cpp, lib/CodeGen/MIRParser/MILexer.cpp/h, lib/CodeGen/MIRPrinter.cpp and test/CodeGen/MIR/AArch64/cfi.mir.
Tue, Sep 4
LGTM, thanks for improving this!
Mon, Sep 3
I did a quick experiment to avoid storing the FrameIndex and get rid of the FrameAccess struct, by using this:
Fri, Aug 31
Thanks @sdesmalen, LGTM!
Thu, Aug 30
Added a test. Let me know if that's what you had in mind.
Looks good, thanks!
Could you also add what you said in the previous comment to the test case?
Thanks for working on this! Other than the comments I left it looks good to me.
Other than the comments it LGTM, thanks!
Thanks a lot Matthias, this looks really great! I hopefully did not miss anything, it LGTM!
Wed, Aug 29
Thank you! A few comments on the MIR test though. Thanks for putting up the test.
Tue, Aug 28
Sorry, not sure I can help much here. I haven't looked at the new PM yet.
Looks better now. Thanks for adding the MIR test.
Aug 21 2018
Aug 20 2018
This looks ok, but I am not sure the FrameSetup flag was made to be used in this way.
Aug 17 2018
I fixed a couple of issues in https://reviews.llvm.org/rL340034. Let me know if that doesn't work for you.
Aug 16 2018
Sorry, I'm afraid I can't help reviewing this patch as I know nothing about MachineTraceMetrics. Although, I suggest adding a test case, as it will help reviewers to understand better what the changes are.
Aug 15 2018
Aug 14 2018
Please add a MIR test for this, it would make the test much clearer.
Aug 6 2018
Aug 3 2018
Jul 31 2018
Jul 30 2018
Jul 14 2018
Jul 13 2018
Jul 12 2018
This seems to take care of my concerns from the other patch. LGTM, thanks for looking into this again!
Thanks @rinon for this. Are you still interested in committing this? I would like to get this in to fix some X86 machine verifier issues.
Some comments below, other than that it LGTM, I can commit this for you after that.
Thanks all for taking a look. I'll close this and push for D37582.
Jul 11 2018
Jul 10 2018
Jul 9 2018
Jul 2 2018
Thanks @pete !
Jun 27 2018
Looks fixed now, thank you!
Hi @tejohnson, seems that this commit breaks a bot here: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/50190/.
Jun 26 2018
Jun 25 2018
LLVM ERROR: unsupported relocation with subtraction expression, symbol '__GLOBAL_OFFSET_TABLE_' can not be undefined in a subtraction expression
Jun 23 2018
Jun 21 2018
This seems to break here: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/49895/consoleFull
I raised concern on the wrong commit: https://reviews.llvm.org/rL333740. It does reproduce with this commit as well.
Hi @fhahn, this commit seems to break some internal tests of ours. I managed to reduce the assert to the following test:
Jun 18 2018
Ah, sorry, I just saw that your second commit fixed the issue. Relanded in:
I reverted both commits in r335009 and r335010 to fix the bots.