Page MenuHomePhabricator

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (169 w, 22 h)

Recent Activity

Thu, Feb 14

thegameg committed rG0650f897a470: Revert "Fix implementation of [temp.local]p4." (authored by thegameg).
Revert "Fix implementation of [temp.local]p4."
Thu, Feb 14, 7:08 PM
thegameg added a reverting change for rG40bd10b77081: Fix implementation of [temp.local]p4.: rG0650f897a470: Revert "Fix implementation of [temp.local]p4.".
Thu, Feb 14, 7:08 PM
thegameg committed rL354097: Revert "Fix implementation of [temp.local]p4.".
Revert "Fix implementation of [temp.local]p4."
Thu, Feb 14, 7:08 PM
thegameg committed rC354097: Revert "Fix implementation of [temp.local]p4.".
Revert "Fix implementation of [temp.local]p4."
Thu, Feb 14, 7:08 PM
thegameg added a comment to D58240: [SystemZ] Make sure VEXTEND and VROUND nodes are not emitted without vector support..

This failed to pass the machine verifier in http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/13579/.

Thu, Feb 14, 7:07 PM
thegameg committed rG3fb7d4f55fa0: Revert "[SystemZ] Do not emit VEXTEND or VROUND nodes without vector support." (authored by thegameg).
Revert "[SystemZ] Do not emit VEXTEND or VROUND nodes without vector support."
Thu, Feb 14, 7:02 PM
thegameg added a reverting change for rGaa0b77d3395d: [SystemZ] Do not emit VEXTEND or VROUND nodes without vector support.: rG3fb7d4f55fa0: Revert "[SystemZ] Do not emit VEXTEND or VROUND nodes without vector support.".
Thu, Feb 14, 7:02 PM
thegameg committed rL354096: Revert "[SystemZ] Do not emit VEXTEND or VROUND nodes without vector support.".
Revert "[SystemZ] Do not emit VEXTEND or VROUND nodes without vector support."
Thu, Feb 14, 7:01 PM
thegameg added a comment to rL354064: Set hidden attribute on lprofMergeValueProfData.

It looks like this fails on Darwin:

Thu, Feb 14, 3:06 PM

Wed, Feb 13

thegameg committed rGee704c1d912d: [NewPM] Add explicit triple to test (authored by thegameg).
[NewPM] Add explicit triple to test
Wed, Feb 13, 8:17 PM
thegameg committed rC354008: [NewPM] Add explicit triple to test.
[NewPM] Add explicit triple to test
Wed, Feb 13, 8:17 PM
thegameg committed rL354008: [NewPM] Add explicit triple to test.
[NewPM] Add explicit triple to test
Wed, Feb 13, 8:17 PM

Tue, Feb 12

thegameg added inline comments to D56394: [Driver] Error out when using an older CPU than Haswell with x86_64h.
Tue, Feb 12, 4:37 PM

Mon, Feb 11

thegameg added a comment to rL353771: DebugInfo: Split DWARF + gmlt + no-split-dwarf-inlining shouldn't emit anything….

This seems to fail here on macOS: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/58065/console

Mon, Feb 11, 4:57 PM
thegameg committed rG1608c120275d: [NFC][clangd] Remove unused lambda capture (authored by thegameg).
[NFC][clangd] Remove unused lambda capture
Mon, Feb 11, 2:37 PM
thegameg committed rL353760: [NFC][clangd] Remove unused lambda capture.
[NFC][clangd] Remove unused lambda capture
Mon, Feb 11, 2:36 PM
thegameg committed rCTE353760: [NFC][clangd] Remove unused lambda capture.
[NFC][clangd] Remove unused lambda capture
Mon, Feb 11, 2:36 PM

Fri, Feb 8

thegameg committed rG8bc57953b77a: Re-apply r353553 "[GISel][NFC]: Add missing call to record CSE hits in the… (authored by thegameg).
Re-apply r353553 "[GISel][NFC]: Add missing call to record CSE hits in the…
Fri, Feb 8, 3:34 PM
thegameg committed rL353579: Re-apply r353553 "[GISel][NFC]: Add missing call to record CSE hits in the….
Re-apply r353553 "[GISel][NFC]: Add missing call to record CSE hits in the…
Fri, Feb 8, 3:34 PM
thegameg committed rGdecba8aa06f0: Revert r353553 "[GISel][NFC]: Add missing call to record CSE hits in the… (authored by thegameg).
Revert r353553 "[GISel][NFC]: Add missing call to record CSE hits in the…
Fri, Feb 8, 2:50 PM
thegameg committed rL353575: Revert r353553 "[GISel][NFC]: Add missing call to record CSE hits in the….
Revert r353553 "[GISel][NFC]: Add missing call to record CSE hits in the…
Fri, Feb 8, 2:49 PM
thegameg committed rGc716bee0535c: [InstrProf] Fix darwin errors after r353547 (authored by thegameg).
[InstrProf] Fix darwin errors after r353547
Fri, Feb 8, 12:38 PM
thegameg committed rL353560: [InstrProf] Fix darwin errors after r353547.
[InstrProf] Fix darwin errors after r353547
Fri, Feb 8, 12:37 PM
thegameg committed rCRT353560: [InstrProf] Fix darwin errors after r353547.
[InstrProf] Fix darwin errors after r353547
Fri, Feb 8, 12:37 PM

Fri, Feb 1

thegameg accepted D57599: Compute the correct symbol size in llvm-nm even without --print-size.

LGTM, thanks!

Fri, Feb 1, 12:55 PM · Restricted Project

Wed, Jan 30

thegameg added a reviewer for D56394: [Driver] Error out when using an older CPU than Haswell with x86_64h: craig.topper.

Ping

Wed, Jan 30, 1:08 PM

Mon, Jan 28

thegameg added a comment to D56384: [AArch64] Add 'apple-latest' CPU alias.

Thanks @fhahn!

Mon, Jan 28, 1:46 PM
thegameg committed rL352412: [AArch64] Add 'apple-latest' CPU alias.
[AArch64] Add 'apple-latest' CPU alias
Mon, Jan 28, 11:27 AM
thegameg closed D56384: [AArch64] Add 'apple-latest' CPU alias.
Mon, Jan 28, 11:27 AM
thegameg added a comment to D56384: [AArch64] Add 'apple-latest' CPU alias.

Ping?

Mon, Jan 28, 8:26 AM

Jan 17 2019

thegameg added a comment to D56384: [AArch64] Add 'apple-latest' CPU alias.

Ping?

Jan 17 2019, 7:08 AM

Jan 14 2019

thegameg committed rL351049: Replace "no-frame-pointer-*" function attributes with "frame-pointer".
Replace "no-frame-pointer-*" function attributes with "frame-pointer"
Jan 14 2019, 3:02 AM
thegameg closed D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".
Jan 14 2019, 3:01 AM

Jan 10 2019

thegameg committed rL350908: [llvm-objdump][MachO] Disable some invalid input tests.
[llvm-objdump][MachO] Disable some invalid input tests
Jan 10 2019, 3:50 PM
thegameg committed rL350871: [llvm-objdump][MachO] Fix test to work on Windows.
[llvm-objdump][MachO] Fix test to work on Windows
Jan 10 2019, 10:36 AM
thegameg committed rL350851: [llvm-objdump][MachO] Fix error reporting after r350848 and r350849.
[llvm-objdump][MachO] Fix error reporting after r350848 and r350849
Jan 10 2019, 9:42 AM
thegameg committed rL350849: [llvm-objdump][MachO] Use the -dsym file name when reporting errors.
[llvm-objdump][MachO] Use the -dsym file name when reporting errors
Jan 10 2019, 9:20 AM
thegameg committed rL350848: [llvm-objdump][MachO] Correctly handle the llvm::Error when -dsym has errors.
[llvm-objdump][MachO] Correctly handle the llvm::Error when -dsym has errors
Jan 10 2019, 9:20 AM

Jan 9 2019

thegameg committed rL350753: [CodeGen] Ignore return sext/zext attributes of unused results for tail calls.
[CodeGen] Ignore return sext/zext attributes of unused results for tail calls
Jan 9 2019, 11:51 AM
thegameg closed D56486: [CodeGen] Ignore return sext/zext attributes of unused results for tail calls.
Jan 9 2019, 11:51 AM
thegameg created D56486: [CodeGen] Ignore return sext/zext attributes of unused results for tail calls.
Jan 9 2019, 4:35 AM

Jan 8 2019

thegameg committed rL350623: [X86][Darwin] Emit compact-unwind for register-sized stack adjustments.
[X86][Darwin] Emit compact-unwind for register-sized stack adjustments
Jan 8 2019, 5:57 AM
thegameg closed D13793: [X86AsmBackend] Emit compact unwind for register-sized stacks.
Jan 8 2019, 5:56 AM
thegameg added a comment to D54155: [CodeGen] Make branch funnels pass the machine verifier.

Ping

Jan 8 2019, 2:22 AM

Jan 7 2019

thegameg created D56394: [Driver] Error out when using an older CPU than Haswell with x86_64h.
Jan 7 2019, 8:32 AM
thegameg updated the diff for D56384: [AArch64] Add 'apple-latest' CPU alias.

Fix RUN command in test.

Jan 7 2019, 7:48 AM
thegameg added a comment to D55775: [Driver] Don't override '-march' when using '-arch x86_64h'.

Should we emit an error if we request x86_64h with an arch older than haswell?

Jan 7 2019, 7:12 AM
thegameg accepted D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer".

This LGTM with one small comment change, thanks! You might want to add to the commit message the fact that the target now overrides the function attribute, which could change the behavior for (out of tree) targets.

Jan 7 2019, 6:55 AM
thegameg created D56384: [AArch64] Add 'apple-latest' CPU alias.
Jan 7 2019, 4:01 AM

Dec 17 2018

thegameg committed rC349381: [Driver] Don't override '-march' when using '-arch x86_64h'.
[Driver] Don't override '-march' when using '-arch x86_64h'
Dec 17 2018, 11:32 AM
thegameg committed rL349381: [Driver] Don't override '-march' when using '-arch x86_64h'.
[Driver] Don't override '-march' when using '-arch x86_64h'
Dec 17 2018, 11:32 AM
thegameg closed D55775: [Driver] Don't override '-march' when using '-arch x86_64h'.
Dec 17 2018, 11:32 AM
thegameg created D55775: [Driver] Don't override '-march' when using '-arch x86_64h'.
Dec 17 2018, 10:04 AM

Dec 13 2018

thegameg committed rL349060: [MachO][TLOF] Add support for local symbols in the indirect symbol table.
[MachO][TLOF] Add support for local symbols in the indirect symbol table
Dec 13 2018, 9:26 AM
thegameg closed D55573: [MachO][TLOF] Add support for local symbols in the indirect symbol table.
Dec 13 2018, 9:26 AM
thegameg updated the diff for D55573: [MachO][TLOF] Add support for local symbols in the indirect symbol table.

Add more comments regarding local indirect symbols.

Dec 13 2018, 6:28 AM

Dec 11 2018

thegameg created D55573: [MachO][TLOF] Add support for local symbols in the indirect symbol table.
Dec 11 2018, 1:08 PM

Dec 10 2018

thegameg committed rL348765: [DAGCombiner] Simplify test case from r348759.
[DAGCombiner] Simplify test case from r348759
Dec 10 2018, 8:10 AM
thegameg added inline comments to rL348759: [DAGCombiner] Use the result value type in visitCONCAT_VECTORS.
Dec 10 2018, 8:10 AM
thegameg committed rL348759: [DAGCombiner] Use the result value type in visitCONCAT_VECTORS.
[DAGCombiner] Use the result value type in visitCONCAT_VECTORS
Dec 10 2018, 6:37 AM
thegameg closed D55507: [DAGCombiner] Use the result value type in visitCONCAT_VECTORS.
Dec 10 2018, 6:36 AM
thegameg created D55507: [DAGCombiner] Use the result value type in visitCONCAT_VECTORS.
Dec 10 2018, 4:48 AM

Dec 3 2018

thegameg accepted D55082: WIP: Try adding method to stop after specific runs of passes.

LGTM, thanks!

Dec 3 2018, 9:34 PM

Nov 29 2018

thegameg added a comment to D54155: [CodeGen] Make branch funnels pass the machine verifier.

Ping?

Nov 29 2018, 12:26 PM
thegameg accepted D54776: Produce an error on non-encodable offsets for darwin ARM scattered relocations..

Sorry for the delay. LGTM, thanks!

Nov 29 2018, 12:25 PM
thegameg committed rL347906: [MachineScheduler] Order FI-based memops based on stack direction.
[MachineScheduler] Order FI-based memops based on stack direction
Nov 29 2018, 12:06 PM

Nov 28 2018

thegameg added a comment to D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands.

Thanks @niravd!

Nov 28 2018, 4:06 AM
thegameg added a comment to D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.

Thanks @sdesmalen, @niravd for the review!

Nov 28 2018, 4:06 AM
thegameg committed rL347747: [MachineScheduler] Add support for clustering mem ops with FI base operands.
[MachineScheduler] Add support for clustering mem ops with FI base operands
Nov 28 2018, 4:03 AM
thegameg closed D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands.
Nov 28 2018, 4:03 AM
thegameg committed rL347746: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.
[CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand
Nov 28 2018, 4:03 AM
thegameg closed D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.
Nov 28 2018, 4:03 AM

Nov 27 2018

thegameg added inline comments to D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.
Nov 27 2018, 10:20 AM
thegameg updated the diff for D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands.

Check for non equal FIs in shouldClusterMemOps. If they are both fixed objects, they can be used to access another slot, so check that the offsets match.

Nov 27 2018, 10:09 AM
thegameg added inline comments to D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands.
Nov 27 2018, 6:17 AM

Nov 26 2018

thegameg added inline comments to D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.
Nov 26 2018, 11:40 AM
thegameg updated the diff for D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.

Addressed some of the reviews.

Nov 26 2018, 11:36 AM

Nov 23 2018

thegameg added a child revision for D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand: D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands.
Nov 23 2018, 2:43 AM
thegameg added a parent revision for D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands: D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.
Nov 23 2018, 2:43 AM
thegameg created D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands.
Nov 23 2018, 2:41 AM
thegameg created D54846: [CodeGen][NFC] Make `TII::getMemOpBaseImmOfs` return a base operand.
Nov 23 2018, 2:31 AM

Nov 19 2018

thegameg committed rL347230: [llvm-nm] Fix use-after-free for MachOUniversalBinaries.
[llvm-nm] Fix use-after-free for MachOUniversalBinaries
Nov 19 2018, 9:22 AM
thegameg added a comment to D54155: [CodeGen] Make branch funnels pass the machine verifier.

Ping?

Nov 19 2018, 9:16 AM

Nov 6 2018

thegameg added a comment to D51524: [ARM64] [Windows] Handle funclets.

I am afraid I don't know much about exceptions on Windows in general. A few comments below.

Nov 6 2018, 8:40 AM
thegameg created D54155: [CodeGen] Make branch funnels pass the machine verifier.
Nov 6 2018, 7:08 AM

Nov 5 2018

thegameg committed rL346127: [CMake] Expose opt-remark tooling through libOptRemarks.dylib.
[CMake] Expose opt-remark tooling through libOptRemarks.dylib
Nov 5 2018, 4:00 AM

Oct 30 2018

thegameg accepted D53903: MachineOperand/MIParser: Do not print debug-use flag, infer it.

LGTM

Oct 30 2018, 3:42 PM
thegameg committed rL345593: [X86] Re-enable the machine verifier after fixing more tests.
[X86] Re-enable the machine verifier after fixing more tests
Oct 30 2018, 5:23 AM
thegameg committed rC345591: [CodeGen] Disable the machine verifier on a ThinLTO test.
[CodeGen] Disable the machine verifier on a ThinLTO test
Oct 30 2018, 5:20 AM
thegameg committed rL345591: [CodeGen] Disable the machine verifier on a ThinLTO test.
[CodeGen] Disable the machine verifier on a ThinLTO test
Oct 30 2018, 5:20 AM
thegameg committed rL345589: [llc] Error out when -print-machineinstrs is used with an unknown pass.
[llc] Error out when -print-machineinstrs is used with an unknown pass
Oct 30 2018, 5:09 AM

Oct 29 2018

thegameg committed rL345513: [X86] Enable the MachineVerifier by default.
[X86] Enable the MachineVerifier by default
Oct 29 2018, 9:59 AM
thegameg committed rL345501: [X86] Remove outdated test.
[X86] Remove outdated test
Oct 29 2018, 6:45 AM
thegameg closed D53767: [X86] Convert MIR test to IR test.
Oct 29 2018, 6:45 AM

Oct 26 2018

thegameg added inline comments to D53490: [MIR] Provide a default alignment for stack objects.
Oct 26 2018, 9:14 AM
thegameg committed rL345396: [MIR] Simplify and move MIR test.
[MIR] Simplify and move MIR test
Oct 26 2018, 9:04 AM
thegameg created D53767: [X86] Convert MIR test to IR test.
Oct 26 2018, 8:38 AM
thegameg committed rL345384: [CodeGen] Remove out operands from PATCHABLE_OP.
[CodeGen] Remove out operands from PATCHABLE_OP
Oct 26 2018, 6:39 AM

Oct 25 2018

thegameg committed rL345316: [CodeGen] Remove operands from FENTRY_CALL.
[CodeGen] Remove operands from FENTRY_CALL
Oct 25 2018, 2:15 PM
thegameg committed rL345266: [X86] Fix llc invocation on MIR test case.
[X86] Fix llc invocation on MIR test case
Oct 25 2018, 7:13 AM