- User Since
- Nov 23 2015, 4:41 AM (203 w, 5 h)
Fri, Oct 11
Tue, Oct 8
Move cleanup code after emitting lifetime start.
Mon, Oct 7
Thu, Oct 3
I noticed a bunch of explicit llvm:: prefixes like llvm::Error, llvm::StringRef, etc. Did you intentionally leave that there?
Mon, Sep 23
Wed, Sep 18
Tue, Sep 17
You can try to reproduce the behavior of the calling convention through a MIR test: https://llvm.org/docs/MIRLangRef.html, using $REG = IMPLICIT_DEF to clobber a CSR.
Mon, Sep 16
Sep 13 2019
Sep 9 2019
Sep 6 2019
Sep 5 2019
Sep 4 2019
Address Jonas' comments. Thanks for the review!
Thanks for fixing the MIR issues and tests. It would be great to document this somewhere in https://llvm.org/docs/MIRLangRef.html if you can. Other than that, this LGTM!
Sep 3 2019
Aug 27 2019
Thanks for upstreaming your changes.
Aug 26 2019
Thanks, this LGTM. I quickly looked at the X86 tests, it seems that PATCHABLE_EVENT_CALL and PATCHABLE_TYPED_EVENT_CALL are always created with a register but expect immediates in Target.td. I'm not sure what was the intention so I'll leave it to @dberris.
Aug 22 2019
Aug 21 2019
Aug 20 2019
Can we also get a test for this?
Aug 16 2019
Aug 7 2019
Aug 6 2019
This is still failing in http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16047/steps/test/logs/stdio.
Aug 5 2019
Hi, this seems to fail with asan enabled: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan/6498/.
Jul 31 2019
The MIRPrinter is used to print MIR when used with -stop-before / -stop-after / -run-pass flags in llc (see https://llvm.org/docs/MIRLangRef.html#mir-testing-guide).
This LGTM, thanks!
Jul 30 2019
Jul 29 2019
Sorry, I had to revert this in rL367265 to unblock the macOS bots.
Jul 26 2019
Jul 25 2019
I filed PR42764 for the missing documentation.
Seems that the issue is that /externalfile becomes C:/externalfile.