thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (156 w, 3 h)

Recent Activity

Tue, Nov 6

thegameg added a comment to D51524: [ARM64] [Windows] Handle funclets.

I am afraid I don't know much about exceptions on Windows in general. A few comments below.

Tue, Nov 6, 8:40 AM
thegameg created D54155: [CodeGen] Make branch funnels pass the machine verifier.
Tue, Nov 6, 7:08 AM

Mon, Nov 5

thegameg committed rL346127: [CMake] Expose opt-remark tooling through libOptRemarks.dylib.
[CMake] Expose opt-remark tooling through libOptRemarks.dylib
Mon, Nov 5, 4:00 AM

Tue, Oct 30

thegameg accepted D53903: MachineOperand/MIParser: Do not print debug-use flag, infer it.

LGTM

Tue, Oct 30, 3:42 PM
thegameg committed rL345593: [X86] Re-enable the machine verifier after fixing more tests.
[X86] Re-enable the machine verifier after fixing more tests
Tue, Oct 30, 5:23 AM
thegameg committed rC345591: [CodeGen] Disable the machine verifier on a ThinLTO test.
[CodeGen] Disable the machine verifier on a ThinLTO test
Tue, Oct 30, 5:20 AM
thegameg committed rL345591: [CodeGen] Disable the machine verifier on a ThinLTO test.
[CodeGen] Disable the machine verifier on a ThinLTO test
Tue, Oct 30, 5:20 AM
thegameg committed rL345589: [llc] Error out when -print-machineinstrs is used with an unknown pass.
[llc] Error out when -print-machineinstrs is used with an unknown pass
Tue, Oct 30, 5:09 AM

Mon, Oct 29

thegameg committed rL345513: [X86] Enable the MachineVerifier by default.
[X86] Enable the MachineVerifier by default
Mon, Oct 29, 9:59 AM
thegameg committed rL345501: [X86] Remove outdated test.
[X86] Remove outdated test
Mon, Oct 29, 6:45 AM
thegameg closed D53767: [X86] Convert MIR test to IR test.
Mon, Oct 29, 6:45 AM

Fri, Oct 26

thegameg added inline comments to D53490: [MIR] Provide a default alignment for stack objects.
Fri, Oct 26, 9:14 AM
thegameg committed rL345396: [MIR] Simplify and move MIR test.
[MIR] Simplify and move MIR test
Fri, Oct 26, 9:04 AM
thegameg created D53767: [X86] Convert MIR test to IR test.
Fri, Oct 26, 8:38 AM
thegameg committed rL345384: [CodeGen] Remove out operands from PATCHABLE_OP.
[CodeGen] Remove out operands from PATCHABLE_OP
Fri, Oct 26, 6:39 AM

Thu, Oct 25

thegameg committed rL345316: [CodeGen] Remove operands from FENTRY_CALL.
[CodeGen] Remove operands from FENTRY_CALL
Thu, Oct 25, 2:15 PM
thegameg committed rL345266: [X86] Fix llc invocation on MIR test case.
[X86] Fix llc invocation on MIR test case
Thu, Oct 25, 7:13 AM
thegameg added a comment to D53698: [X86] Fix llc invocation on MIR test case.

Thanks!

Thu, Oct 25, 7:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Oct 25, 7:13 AM
thegameg added a comment to D47372: StackColoring: better handling of statically unreachable code.

@thanm: can you please confirm that D53698 is the behavior you were testing?

Thu, Oct 25, 6:46 AM
thegameg created D53698: [X86] Fix llc invocation on MIR test case.
Thu, Oct 25, 6:46 AM

Wed, Oct 24

thegameg added reviewers for D53653: [Spectre] Fix MIR verifier errors in retpoline thunks: MatzeB, ab.
Wed, Oct 24, 11:38 AM
thegameg accepted D53535: [MC] Separate masm integer literal lexer support from inline asm.

LGTM, thanks for looking into this Reid!

Wed, Oct 24, 4:32 AM

Tue, Oct 23

thegameg abandoned D49139: [OptRemark] Demangle symbols when emitting remarks.

Thanks Hal!

Tue, Oct 23, 7:08 AM
thegameg added inline comments to D53333: [SystemZ] Make sure that SystemZAddressingMode::dump() does not crash..
Tue, Oct 23, 7:00 AM

Mon, Oct 22

thegameg created D53490: [MIR] Provide a default alignment for stack objects.
Mon, Oct 22, 4:35 AM

Oct 10 2018

thegameg committed rL344171: Reland: [OptRemarks] Add library for parsing optimization remarks.
Reland: [OptRemarks] Add library for parsing optimization remarks
Oct 10 2018, 11:45 AM
thegameg committed rL344164: Revert "[OptRemarks] Add library for parsing optimization remarks".
Revert "[OptRemarks] Add library for parsing optimization remarks"
Oct 10 2018, 11:10 AM
thegameg committed rL344162: [OptRemarks] Add library for parsing optimization remarks.
[OptRemarks] Add library for parsing optimization remarks
Oct 10 2018, 11:02 AM
thegameg closed D52776: [OptRemarks] Add library for parsing optimization remarks.
Oct 10 2018, 11:01 AM
thegameg added a comment to D52776: [OptRemarks] Add library for parsing optimization remarks.

Is there anything left to discuss or is this ready to land?

Oct 10 2018, 5:37 AM

Oct 8 2018

thegameg updated the diff for D52776: [OptRemarks] Add library for parsing optimization remarks.
  • Remove some out-of-date comments.
Oct 8 2018, 5:21 AM
thegameg added inline comments to D52776: [OptRemarks] Add library for parsing optimization remarks.
Oct 8 2018, 5:21 AM
thegameg committed rL343961: [AsmParser] Return an error in the case of empty symbol ref in an expression.
[AsmParser] Return an error in the case of empty symbol ref in an expression
Oct 8 2018, 3:30 AM
thegameg closed D52645: [AsmParser] Return an error in the case of empty symbol ref in an expression.
Oct 8 2018, 3:30 AM

Oct 5 2018

thegameg updated the diff for D52776: [OptRemarks] Add library for parsing optimization remarks.

And...update the tests.

Oct 5 2018, 3:43 AM
thegameg updated the diff for D52776: [OptRemarks] Add library for parsing optimization remarks.

Address Jessica's latest comments.

Oct 5 2018, 3:23 AM

Oct 3 2018

thegameg updated the diff for D52776: [OptRemarks] Add library for parsing optimization remarks.

Fix some spacing issues.

Oct 3 2018, 8:51 AM
thegameg updated the diff for D52776: [OptRemarks] Add library for parsing optimization remarks.

Address Jonas' comments.

Oct 3 2018, 8:18 AM
thegameg added inline comments to D52776: [OptRemarks] Add library for parsing optimization remarks.
Oct 3 2018, 6:05 AM
thegameg added inline comments to D52776: [OptRemarks] Add library for parsing optimization remarks.
Oct 3 2018, 6:04 AM
thegameg updated the diff for D52776: [OptRemarks] Add library for parsing optimization remarks.

Thanks Jessica for the review.

Oct 3 2018, 6:03 AM

Oct 2 2018

thegameg updated the diff for D52776: [OptRemarks] Add library for parsing optimization remarks.

Thanks Jonas for the review.

Oct 2 2018, 8:32 AM
thegameg updated the diff for D46278: [AArch64] Fold B = csel A, A into B = COPY A.
  • Fixed bugs where physregs were involved and were treated as having an unique def.
  • Added more tests.
  • Try harder to check the registers by looking through all the vregs until a physreg is found. Then compare definitions or check if it's part of the liveins list.
Oct 2 2018, 5:38 AM
thegameg created D52776: [OptRemarks] Add library for parsing optimization remarks.
Oct 2 2018, 3:22 AM

Sep 28 2018

thegameg created D52645: [AsmParser] Return an error in the case of empty symbol ref in an expression.
Sep 28 2018, 4:13 AM

Sep 27 2018

thegameg accepted D52605: [CodeGen] avoid broken successor probability in MBB dump.

LGTM. It would be nice to have a test too.

Sep 27 2018, 5:37 AM

Sep 26 2018

thegameg committed rL343107: [CodeGen] Always print register ties in MI::dump().
[CodeGen] Always print register ties in MI::dump()
Sep 26 2018, 6:34 AM

Sep 20 2018

thegameg added inline comments to D50136: [AArch64] - Return address signing dwarf support.
Sep 20 2018, 1:39 AM

Sep 13 2018

thegameg added inline comments to D50288: [ARM64] [Windows] Exception handling support in frame lowering.
Sep 13 2018, 9:06 AM

Sep 6 2018

thegameg accepted D51467: Output per-function size-info remarks.

Still LGTM.

Sep 6 2018, 11:45 AM
thegameg added a comment to D50136: [AArch64] - Return address signing dwarf support.

Can you please also add support for the new CFI directive in MIR? Mostly in lib/CodeGen/MIRParser/MIParser.cpp, lib/CodeGen/MIRParser/MILexer.cpp/h, lib/CodeGen/MIRPrinter.cpp and test/CodeGen/MIR/AArch64/cfi.mir.

Sep 6 2018, 4:00 AM

Sep 4 2018

thegameg added inline comments to D51474: Consider CSRs in computeRegisterLiveness.
Sep 4 2018, 1:25 PM
thegameg committed rL341379: [MachO] Fix inconsistency between error messages when validating LC_DYSYMTAB.
[MachO] Fix inconsistency between error messages when validating LC_DYSYMTAB
Sep 4 2018, 9:34 AM
thegameg committed rL341378: [MachO] Fix LC_DYSYMTAB validation for external symbols.
[MachO] Fix LC_DYSYMTAB validation for external symbols
Sep 4 2018, 9:34 AM
thegameg accepted D51617: Remove FrameAccess struct from hasLoadFromStackSlot.

LGTM, thanks for improving this!

Sep 4 2018, 2:58 AM
thegameg accepted D51479: [AArch64] Implement aarch64_vector_pcs codegen support..

LGTM, thanks!

Sep 4 2018, 2:58 AM
thegameg added inline comments to D51479: [AArch64] Implement aarch64_vector_pcs codegen support..
Sep 4 2018, 2:52 AM

Sep 3 2018

thegameg added inline comments to D51474: Consider CSRs in computeRegisterLiveness.
Sep 3 2018, 7:05 AM
thegameg added a reviewer for D51479: [AArch64] Implement aarch64_vector_pcs codegen support.: MatzeB.
Sep 3 2018, 7:05 AM
thegameg added inline comments to D50288: [ARM64] [Windows] Exception handling support in frame lowering.
Sep 3 2018, 6:43 AM
thegameg added a comment to D51537: Extend hasStoreToStackSlot with list of FI accesses..

I did a quick experiment to avoid storing the FrameIndex and get rid of the FrameAccess struct, by using this:

Sep 3 2018, 6:28 AM
thegameg added a reviewer for D51524: [ARM64] [Windows] Handle funclets: MatzeB.
Sep 3 2018, 3:41 AM

Aug 31 2018

thegameg committed rL341209: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.
[llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym
Aug 31 2018, 6:13 AM
thegameg closed D51365: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.
Aug 31 2018, 6:13 AM
thegameg accepted D51478: [AArch64] NFC: Refactoring to prepare for vector PCS..

Thanks @sdesmalen, LGTM!

Aug 31 2018, 5:17 AM

Aug 30 2018

thegameg updated the diff for D51365: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.

Added a test. Let me know if that's what you had in mind.

Aug 30 2018, 11:24 AM
thegameg added a comment to D51161: Allow inconsistent offsets for 'noreturn' basic blocks when '-verify-cfiinstrs'.

Looks good, thanks!

Aug 30 2018, 9:51 AM
thegameg added inline comments to D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack.
Aug 30 2018, 8:36 AM
thegameg accepted D51161: Allow inconsistent offsets for 'noreturn' basic blocks when '-verify-cfiinstrs'.

Could you also add what you said in the previous comment to the test case?

Aug 30 2018, 8:11 AM
thegameg added a comment to D51479: [AArch64] Implement aarch64_vector_pcs codegen support..

Thanks for working on this! Other than the comments I left it looks good to me.

Aug 30 2018, 6:37 AM
thegameg added inline comments to D51478: [AArch64] NFC: Refactoring to prepare for vector PCS..
Aug 30 2018, 5:57 AM
thegameg accepted D51467: Output per-function size-info remarks.

Other than the comments it LGTM, thanks!

Aug 30 2018, 5:43 AM
thegameg accepted D51465: Revamp test-suite documentation.

Thanks a lot Matthias, this looks really great! I hopefully did not miss anything, it LGTM!

Aug 30 2018, 5:03 AM

Aug 29 2018

thegameg added a comment to D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack.

Thank you! A few comments on the MIR test though. Thanks for putting up the test.

Aug 29 2018, 6:38 AM

Aug 28 2018

thegameg created D51365: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.
Aug 28 2018, 10:02 AM
thegameg added reviewers for D51274: [NFC][PassTiming] factor out generic PassTimingInfo: MatzeB, paquette.
Aug 28 2018, 5:46 AM
thegameg added reviewers for D51276: [New PM][PassTiming] implement -time-passes for the new pass manager: MatzeB, paquette.
Aug 28 2018, 5:46 AM
thegameg resigned from D51276: [New PM][PassTiming] implement -time-passes for the new pass manager.

Sorry, not sure I can help much here. I haven't looked at the new PM yet.

Aug 28 2018, 5:28 AM
thegameg accepted D50986: [mips] Prevent shrink-wrap for BuildPairF64, ExtractElementF64 when they use $sp.

Looks better now. Thanks for adding the MIR test.

Aug 28 2018, 3:55 AM

Aug 21 2018

thegameg added inline comments to D50986: [mips] Prevent shrink-wrap for BuildPairF64, ExtractElementF64 when they use $sp.
Aug 21 2018, 11:04 AM

Aug 20 2018

thegameg added reviewers for D50986: [mips] Prevent shrink-wrap for BuildPairF64, ExtractElementF64 when they use $sp: thegameg, MatzeB.

This looks ok, but I am not sure the FrameSetup flag was made to be used in this way.

Aug 20 2018, 1:08 PM

Aug 17 2018

thegameg added a comment to D50833: [x86/MIR] Implement support for pre- and post-instruction symbols, as well as MIR parsing support for `MCSymbol` `MachineOperand`s..

I fixed a couple of issues in https://reviews.llvm.org/rL340034. Let me know if that doesn't work for you.

Aug 17 2018, 7:49 AM
thegameg committed rL340034: [x86] Fix test breaking on Darwin after r339962.
[x86] Fix test breaking on Darwin after r339962
Aug 17 2018, 7:48 AM
thegameg committed rL340033: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.
[X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64
Aug 17 2018, 7:47 AM
thegameg closed D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.
Aug 17 2018, 7:47 AM

Aug 16 2018

thegameg added a comment to D41572: [MachineTraceMetrics] Fix bug in pickTracePred.

Sorry, I'm afraid I can't help reviewing this patch as I know nothing about MachineTraceMetrics. Although, I suggest adding a test case, as it will help reviewers to understand better what the changes are.

Aug 16 2018, 7:42 AM
thegameg added a comment to D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.

Ping

Aug 16 2018, 7:40 AM
thegameg edited reviewers for D41572: [MachineTraceMetrics] Fix bug in pickTracePred, added: MatzeB; removed: thegameg.
Aug 16 2018, 7:40 AM

Aug 15 2018

thegameg added a comment to D43136: Make LLVM timer reprintable: that is, make more than one print action on the same timer feasible.

I'm not sure whether anyone else would object ( @MatzeB @ab @thegameg ?)

Aug 15 2018, 2:28 AM

Aug 14 2018

thegameg accepted D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack.

Please add a MIR test for this, it would make the test much clearer.

Aug 14 2018, 2:46 AM

Aug 6 2018

Herald added a reviewer for D26291: [AArch64] Spill instructions w/o immediate field may require an emergency spill slot: javed.absar.

Looks like it's fixed on trunk. Could this be fixed by: https://reviews.llvm.org/rL329691, https://reviews.llvm.org/rL329797, https://reviews.llvm.org/rL329805 and https://reviews.llvm.org/rL330976?

Aug 6 2018, 3:35 AM
thegameg added inline comments to D50288: [ARM64] [Windows] Exception handling support in frame lowering.
Aug 6 2018, 3:22 AM

Aug 3 2018

thegameg created D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.
Aug 3 2018, 9:05 AM

Jul 31 2018

thegameg committed rL338400: [X86] Preserve more liveness information in emitStackProbeInline.
[X86] Preserve more liveness information in emitStackProbeInline
Jul 31 2018, 9:41 AM
thegameg closed D50020: [X86] Preserve more liveness information in emitStackProbeInline.
Jul 31 2018, 9:41 AM

Jul 30 2018

thegameg created D50020: [X86] Preserve more liveness information in emitStackProbeInline.
Jul 30 2018, 3:32 PM
thegameg committed rL338237: [MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction.
[MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction
Jul 30 2018, 2:59 AM
thegameg closed D49299: [MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction.
Jul 30 2018, 2:59 AM

Jul 14 2018

thegameg committed rL337090: [MachineOutliner] Check the last instruction from the sequence when updating….
[MachineOutliner] Check the last instruction from the sequence when updating…
Jul 14 2018, 2:45 AM