- User Since
- Nov 23 2015, 4:41 AM (156 w, 3 h)
Tue, Nov 6
I am afraid I don't know much about exceptions on Windows in general. A few comments below.
Mon, Nov 5
Tue, Oct 30
Mon, Oct 29
Fri, Oct 26
Thu, Oct 25
Wed, Oct 24
LGTM, thanks for looking into this Reid!
Tue, Oct 23
Mon, Oct 22
Oct 10 2018
Is there anything left to discuss or is this ready to land?
Oct 8 2018
- Remove some out-of-date comments.
Oct 5 2018
And...update the tests.
Address Jessica's latest comments.
Oct 3 2018
Fix some spacing issues.
Address Jonas' comments.
Thanks Jessica for the review.
Oct 2 2018
Thanks Jonas for the review.
- Fixed bugs where physregs were involved and were treated as having an unique def.
- Added more tests.
- Try harder to check the registers by looking through all the vregs until a physreg is found. Then compare definitions or check if it's part of the liveins list.
Sep 28 2018
Sep 27 2018
LGTM. It would be nice to have a test too.
Sep 26 2018
Sep 20 2018
Sep 13 2018
Sep 6 2018
Can you please also add support for the new CFI directive in MIR? Mostly in lib/CodeGen/MIRParser/MIParser.cpp, lib/CodeGen/MIRParser/MILexer.cpp/h, lib/CodeGen/MIRPrinter.cpp and test/CodeGen/MIR/AArch64/cfi.mir.
Sep 4 2018
LGTM, thanks for improving this!
Sep 3 2018
I did a quick experiment to avoid storing the FrameIndex and get rid of the FrameAccess struct, by using this:
Aug 31 2018
Thanks @sdesmalen, LGTM!
Aug 30 2018
Added a test. Let me know if that's what you had in mind.
Looks good, thanks!
Could you also add what you said in the previous comment to the test case?
Thanks for working on this! Other than the comments I left it looks good to me.
Other than the comments it LGTM, thanks!
Thanks a lot Matthias, this looks really great! I hopefully did not miss anything, it LGTM!
Aug 29 2018
Thank you! A few comments on the MIR test though. Thanks for putting up the test.
Aug 28 2018
Sorry, not sure I can help much here. I haven't looked at the new PM yet.
Looks better now. Thanks for adding the MIR test.
Aug 21 2018
Aug 20 2018
This looks ok, but I am not sure the FrameSetup flag was made to be used in this way.
Aug 17 2018
I fixed a couple of issues in https://reviews.llvm.org/rL340034. Let me know if that doesn't work for you.
Aug 16 2018
Sorry, I'm afraid I can't help reviewing this patch as I know nothing about MachineTraceMetrics. Although, I suggest adding a test case, as it will help reviewers to understand better what the changes are.
Aug 15 2018
Aug 14 2018
Please add a MIR test for this, it would make the test much clearer.