thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (148 w, 1 d)

Recent Activity

Thu, Sep 20

thegameg added inline comments to D50136: [AArch64] - Return address signing dwarf support.
Thu, Sep 20, 1:39 AM

Thu, Sep 13

thegameg added inline comments to D50288: [ARM64] [Windows] Exception handling support in frame lowering.
Thu, Sep 13, 9:06 AM

Thu, Sep 6

thegameg accepted D51467: Output per-function size-info remarks.

Still LGTM.

Thu, Sep 6, 11:45 AM
thegameg added a comment to D50136: [AArch64] - Return address signing dwarf support.

Can you please also add support for the new CFI directive in MIR? Mostly in lib/CodeGen/MIRParser/MIParser.cpp, lib/CodeGen/MIRParser/MILexer.cpp/h, lib/CodeGen/MIRPrinter.cpp and test/CodeGen/MIR/AArch64/cfi.mir.

Thu, Sep 6, 4:00 AM

Tue, Sep 4

thegameg added inline comments to D51474: Consider CSRs in computeRegisterLiveness.
Tue, Sep 4, 1:25 PM
thegameg committed rL341379: [MachO] Fix inconsistency between error messages when validating LC_DYSYMTAB.
[MachO] Fix inconsistency between error messages when validating LC_DYSYMTAB
Tue, Sep 4, 9:34 AM
thegameg committed rL341378: [MachO] Fix LC_DYSYMTAB validation for external symbols.
[MachO] Fix LC_DYSYMTAB validation for external symbols
Tue, Sep 4, 9:34 AM
thegameg accepted D51617: Remove FrameAccess struct from hasLoadFromStackSlot.

LGTM, thanks for improving this!

Tue, Sep 4, 2:58 AM
thegameg accepted D51479: [AArch64] Implement aarch64_vector_pcs codegen support..

LGTM, thanks!

Tue, Sep 4, 2:58 AM
thegameg added inline comments to D51479: [AArch64] Implement aarch64_vector_pcs codegen support..
Tue, Sep 4, 2:52 AM

Mon, Sep 3

thegameg added inline comments to D51474: Consider CSRs in computeRegisterLiveness.
Mon, Sep 3, 7:05 AM
thegameg added a reviewer for D51479: [AArch64] Implement aarch64_vector_pcs codegen support.: MatzeB.
Mon, Sep 3, 7:05 AM
thegameg added inline comments to D50288: [ARM64] [Windows] Exception handling support in frame lowering.
Mon, Sep 3, 6:43 AM
thegameg added a comment to D51537: Extend hasStoreToStackSlot with list of FI accesses..

I did a quick experiment to avoid storing the FrameIndex and get rid of the FrameAccess struct, by using this:

Mon, Sep 3, 6:28 AM
thegameg added a reviewer for D51524: [ARM64] [Windows] Handle funclets: MatzeB.
Mon, Sep 3, 3:41 AM

Fri, Aug 31

thegameg committed rL341209: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.
[llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym
Fri, Aug 31, 6:13 AM
thegameg closed D51365: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.
Fri, Aug 31, 6:13 AM
thegameg accepted D51478: [AArch64] NFC: Refactoring to prepare for vector PCS..

Thanks @sdesmalen, LGTM!

Fri, Aug 31, 5:17 AM

Thu, Aug 30

thegameg updated the diff for D51365: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.

Added a test. Let me know if that's what you had in mind.

Thu, Aug 30, 11:24 AM
thegameg added a comment to D51161: Allow inconsistent offsets for 'noreturn' basic blocks when '-verify-cfiinstrs'.

Looks good, thanks!

Thu, Aug 30, 9:51 AM
thegameg added inline comments to D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack.
Thu, Aug 30, 8:36 AM
thegameg accepted D51161: Allow inconsistent offsets for 'noreturn' basic blocks when '-verify-cfiinstrs'.

Could you also add what you said in the previous comment to the test case?

Thu, Aug 30, 8:11 AM
thegameg added a comment to D51479: [AArch64] Implement aarch64_vector_pcs codegen support..

Thanks for working on this! Other than the comments I left it looks good to me.

Thu, Aug 30, 6:37 AM
thegameg added inline comments to D51478: [AArch64] NFC: Refactoring to prepare for vector PCS..
Thu, Aug 30, 5:57 AM
thegameg accepted D51467: Output per-function size-info remarks.

Other than the comments it LGTM, thanks!

Thu, Aug 30, 5:43 AM
thegameg accepted D51465: Revamp test-suite documentation.

Thanks a lot Matthias, this looks really great! I hopefully did not miss anything, it LGTM!

Thu, Aug 30, 5:03 AM

Wed, Aug 29

thegameg added a comment to D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack.

Thank you! A few comments on the MIR test though. Thanks for putting up the test.

Wed, Aug 29, 6:38 AM

Tue, Aug 28

thegameg created D51365: [llvm-objdump] Keep the memory buffer from the dSYM alive when using -g -dsym.
Tue, Aug 28, 10:02 AM
thegameg added reviewers for D51274: [NFC][PassTiming] factor out generic PassTimingInfo: MatzeB, paquette.
Tue, Aug 28, 5:46 AM
thegameg added reviewers for D51276: [New PM][PassTiming] implement -time-passes for the new pass manager: MatzeB, paquette.
Tue, Aug 28, 5:46 AM
thegameg resigned from D51276: [New PM][PassTiming] implement -time-passes for the new pass manager.

Sorry, not sure I can help much here. I haven't looked at the new PM yet.

Tue, Aug 28, 5:28 AM
thegameg accepted D50986: [mips] Prevent shrink-wrap for BuildPairF64, ExtractElementF64 when they use $sp.

Looks better now. Thanks for adding the MIR test.

Tue, Aug 28, 3:55 AM

Aug 21 2018

thegameg added inline comments to D50986: [mips] Prevent shrink-wrap for BuildPairF64, ExtractElementF64 when they use $sp.
Aug 21 2018, 11:04 AM

Aug 20 2018

thegameg added reviewers for D50986: [mips] Prevent shrink-wrap for BuildPairF64, ExtractElementF64 when they use $sp: thegameg, MatzeB.

This looks ok, but I am not sure the FrameSetup flag was made to be used in this way.

Aug 20 2018, 1:08 PM

Aug 17 2018

thegameg added a comment to D50833: [x86/MIR] Implement support for pre- and post-instruction symbols, as well as MIR parsing support for `MCSymbol` `MachineOperand`s..

I fixed a couple of issues in https://reviews.llvm.org/rL340034. Let me know if that doesn't work for you.

Aug 17 2018, 7:49 AM
thegameg committed rL340034: [x86] Fix test breaking on Darwin after r339962.
[x86] Fix test breaking on Darwin after r339962
Aug 17 2018, 7:48 AM
thegameg committed rL340033: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.
[X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64
Aug 17 2018, 7:47 AM
thegameg closed D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.
Aug 17 2018, 7:47 AM

Aug 16 2018

thegameg added a comment to D41572: [MachineTraceMetrics] Fix bug in pickTracePred.

Sorry, I'm afraid I can't help reviewing this patch as I know nothing about MachineTraceMetrics. Although, I suggest adding a test case, as it will help reviewers to understand better what the changes are.

Aug 16 2018, 7:42 AM
thegameg added a comment to D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.

Ping

Aug 16 2018, 7:40 AM
thegameg edited reviewers for D41572: [MachineTraceMetrics] Fix bug in pickTracePred, added: MatzeB; removed: thegameg.
Aug 16 2018, 7:40 AM

Aug 15 2018

thegameg added a comment to D43136: Make LLVM timer reprintable: that is, make more than one print action on the same timer feasible.

I'm not sure whether anyone else would object ( @MatzeB @ab @thegameg ?)

Aug 15 2018, 2:28 AM

Aug 14 2018

thegameg accepted D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack.

Please add a MIR test for this, it would make the test much clearer.

Aug 14 2018, 2:46 AM

Aug 6 2018

Herald added a reviewer for D26291: [AArch64] Spill instructions w/o immediate field may require an emergency spill slot: javed.absar.

Looks like it's fixed on trunk. Could this be fixed by: https://reviews.llvm.org/rL329691, https://reviews.llvm.org/rL329797, https://reviews.llvm.org/rL329805 and https://reviews.llvm.org/rL330976?

Aug 6 2018, 3:35 AM
thegameg added inline comments to D50288: [ARM64] [Windows] Exception handling support in frame lowering.
Aug 6 2018, 3:22 AM

Aug 3 2018

thegameg created D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.
Aug 3 2018, 9:05 AM

Jul 31 2018

thegameg committed rL338400: [X86] Preserve more liveness information in emitStackProbeInline.
[X86] Preserve more liveness information in emitStackProbeInline
Jul 31 2018, 9:41 AM
thegameg closed D50020: [X86] Preserve more liveness information in emitStackProbeInline.
Jul 31 2018, 9:41 AM

Jul 30 2018

thegameg created D50020: [X86] Preserve more liveness information in emitStackProbeInline.
Jul 30 2018, 3:32 PM
thegameg committed rL338237: [MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction.
[MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction
Jul 30 2018, 2:59 AM
thegameg closed D49299: [MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction.
Jul 30 2018, 2:59 AM

Jul 14 2018

thegameg committed rL337090: [MachineOutliner] Check the last instruction from the sequence when updating….
[MachineOutliner] Check the last instruction from the sequence when updating…
Jul 14 2018, 2:45 AM
thegameg closed D49295: [MachineOutliner] Check the last instruction from the sequence when updating liveness.
Jul 14 2018, 2:45 AM

Jul 13 2018

thegameg created D49299: [MachineOutliner][X86] Use TAILJMPd64 instead of JMP_1 for TailCall construction.
Jul 13 2018, 8:31 AM
thegameg edited reviewers for D49295: [MachineOutliner] Check the last instruction from the sequence when updating liveness, added: paquette; removed: jpaquette.
Jul 13 2018, 7:49 AM
thegameg created D49295: [MachineOutliner] Check the last instruction from the sequence when updating liveness.
Jul 13 2018, 7:49 AM

Jul 12 2018

thegameg accepted D49256: CodeGen: Remove pipeline dependencies on StackProtector; NFC.

This seems to take care of my concerns from the other patch. LGTM, thanks for looking into this again!

Jul 12 2018, 11:28 AM
thegameg committed rL336907: [DebugInfo][X86] Add start-after flags to MIR tests.
[DebugInfo][X86] Add start-after flags to MIR tests
Jul 12 2018, 7:42 AM
thegameg closed D49191: [DebugInfo][X86] Add start-after flags to MIR tests.
Jul 12 2018, 7:41 AM
thegameg committed rL336906: [XRay] Fix machine verifier issues in X86.
[XRay] Fix machine verifier issues in X86
Jul 12 2018, 7:41 AM
thegameg closed D49187: [XRay] Fix machine verifier issues in X86.
Jul 12 2018, 7:41 AM
thegameg added a comment to D37582: CodeGen: Remove pipeline dependencies on StackProtector; NFC.

Thanks @rinon for this. Are you still interested in committing this? I would like to get this in to fix some X86 machine verifier issues.
Some comments below, other than that it LGTM, I can commit this for you after that.

Jul 12 2018, 7:17 AM
thegameg abandoned D49203: [PM] Use getAnalysisIfAvailable / addUsedIfAvailable with StackProtector.

Thanks all for taking a look. I'll close this and push for D37582.

Jul 12 2018, 7:04 AM

Jul 11 2018

thegameg created D49203: [PM] Use getAnalysisIfAvailable / addUsedIfAvailable with StackProtector.
Jul 11 2018, 1:15 PM
thegameg added a reviewer for D49191: [DebugInfo][X86] Add start-after flags to MIR tests: JDevlieghere.
Jul 11 2018, 8:37 AM
thegameg created D49191: [DebugInfo][X86] Add start-after flags to MIR tests.
Jul 11 2018, 8:33 AM
thegameg created D49187: [XRay] Fix machine verifier issues in X86.
Jul 11 2018, 7:35 AM

Jul 10 2018

thegameg created D49139: [OptRemark] Demangle symbols when emitting remarks.
Jul 10 2018, 8:58 AM
thegameg accepted D49131: [MC] Add interface to finish pending labels..

LGTM

Jul 10 2018, 8:00 AM

Jul 9 2018

thegameg accepted D49079: [dsymutil] Add support for outputting assembly.

LGTM

Jul 9 2018, 9:35 AM

Jul 2 2018

thegameg added a comment to D48517: [MC] Error on a .zerofill directive in a non-virtual section.

Thanks @pete !

Jul 2 2018, 10:35 AM
thegameg committed rL336127: [MC] Error on a .zerofill directive in a non-virtual section.
[MC] Error on a .zerofill directive in a non-virtual section
Jul 2 2018, 10:34 AM
thegameg closed D48517: [MC] Error on a .zerofill directive in a non-virtual section.
Jul 2 2018, 10:34 AM
thegameg added a comment to D48517: [MC] Error on a .zerofill directive in a non-virtual section.

Ping?

Jul 2 2018, 4:31 AM

Jun 27 2018

thegameg added a comment to rL335760: [ThinLTO] Print names in function import debug messages when available.

Looks fixed now, thank you!

Jun 27 2018, 1:14 PM
thegameg added a comment to rL335760: [ThinLTO] Print names in function import debug messages when available.

Hi @tejohnson, seems that this commit breaks a bot here: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/50190/.

Jun 27 2018, 11:34 AM
JDevlieghere awarded rC335750: [NEON] Remove empty test file from r335734 a Like token.
Jun 27 2018, 9:23 AM
thegameg committed rC335750: [NEON] Remove empty test file from r335734.
[NEON] Remove empty test file from r335734
Jun 27 2018, 9:22 AM
thegameg committed rL335750: [NEON] Remove empty test file from r335734.
[NEON] Remove empty test file from r335734
Jun 27 2018, 9:22 AM

Jun 26 2018

thegameg committed rC335628: Revert "[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.".
Revert "[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename."
Jun 26 2018, 10:09 AM
thegameg committed rL335628: Revert "[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.".
Revert "[CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename."
Jun 26 2018, 10:09 AM

Jun 25 2018

thegameg committed rL335548: [OrcMCJIT] Fix test after r335508 causing it to fail on green dragon.
[OrcMCJIT] Fix test after r335508 causing it to fail on green dragon
Jun 25 2018, 4:18 PM
thegameg added a comment to rL335508: Re-land r335297 "[X86] Implement more of x86-64 large and medium PIC code….
LLVM ERROR: unsupported relocation with subtraction expression, symbol '__GLOBAL_OFFSET_TABLE_' can not be undefined in a subtraction expression
Jun 25 2018, 4:04 PM

Jun 23 2018

thegameg created D48517: [MC] Error on a .zerofill directive in a non-virtual section.
Jun 23 2018, 2:35 AM

Jun 21 2018

thegameg added a comment to rL335297: [X86] Implement more of x86-64 large and medium PIC code models.

This seems to break here: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/49895/consoleFull

Jun 21 2018, 3:19 PM
thegameg added a comment to rL333740: Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts from cmp….

I have to run now, and will only be able to have a look tomorrow. If it's a big issue for you, would you mind reverting the patch?

Jun 21 2018, 12:23 PM
thegameg committed rL335272: Revert r335206 "Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts….
Revert r335206 "Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts…
Jun 21 2018, 12:23 PM
thegameg added a comment to rL333740: Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts from cmp….

Interesting, thanks for raising that! Looks like an issue with PredicateInfo (which is just used by this change). I'll prepare a fix.

Jun 21 2018, 9:19 AM
thegameg raised a concern with rL335206: Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts from cmp….

I raised concern on the wrong commit: https://reviews.llvm.org/rL333740. It does reproduce with this commit as well.

Jun 21 2018, 9:01 AM
thegameg raised a concern with rL333740: Recommit r333268: [IPSCCP] Use PredicateInfo to propagate facts from cmp….

Hi @fhahn, this commit seems to break some internal tests of ours. I managed to reduce the assert to the following test:

Jun 21 2018, 8:46 AM

Jun 18 2018

thegameg committed rL335013: Fix bots after r334981.
Fix bots after r334981
Jun 18 2018, 8:01 PM
thegameg committed rCRT335013: Fix bots after r334981.
Fix bots after r334981
Jun 18 2018, 8:00 PM
thegameg added a comment to D47484: [test-suite] Corrections for MiniGMG.

Ah, sorry, I just saw that your second commit fixed the issue. Relanded in:

Jun 18 2018, 7:18 PM
thegameg committed rT335011: Reland r334954: [test-suite] Corrections for MiniGMG.
Reland r334954: [test-suite] Corrections for MiniGMG
Jun 18 2018, 7:17 PM
thegameg committed rT335012: Reland r334974: [test-suite] Corrections for MiniGMG.
Reland r334974: [test-suite] Corrections for MiniGMG
Jun 18 2018, 7:17 PM
thegameg committed rL335011: Reland r334954: [test-suite] Corrections for MiniGMG.
Reland r334954: [test-suite] Corrections for MiniGMG
Jun 18 2018, 7:17 PM
thegameg committed rL335012: Reland r334974: [test-suite] Corrections for MiniGMG.
Reland r334974: [test-suite] Corrections for MiniGMG
Jun 18 2018, 7:17 PM
thegameg added a comment to D47484: [test-suite] Corrections for MiniGMG.

I reverted both commits in r335009 and r335010 to fix the bots.

Jun 18 2018, 7:01 PM
thegameg committed rL335010: Revert r334954 "[test-suite] Corrections for MiniGMG".
Revert r334954 "[test-suite] Corrections for MiniGMG"
Jun 18 2018, 7:01 PM
thegameg committed rT335010: Revert r334954 "[test-suite] Corrections for MiniGMG".
Revert r334954 "[test-suite] Corrections for MiniGMG"
Jun 18 2018, 7:00 PM