User Details
- User Since
- Nov 23 2015, 4:41 AM (282 w, 1 d)
Today
Mon, Apr 12
Thu, Apr 8
Tue, Apr 6
Is this really useful as a user-surfacing remark? Won't it have a really high false positive rate due to coalescing?
This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.
LGTM. Doesn't seem like there are any tests testing this remark, maybe you can add one if you have something handy?
Mar 4 2021
Mar 2 2021
Address comments + comments in header.
Mar 1 2021
Feb 25 2021
Thank you!
Feb 24 2021
Add StoreVolatile: false and StoreAtomic: false under ExtraArgs.
Feb 4 2021
Jan 22 2021
LGTM. Not sure if there's a cleaner way.
Jan 8 2021
Dec 16 2020
LGTM, nice!
LGTM
Dec 4 2020
Nov 13 2020
LGTM
Looks good, thanks!
Nov 10 2020
Looks great, thanks!
Nov 6 2020
Oct 26 2020
Oct 23 2020
Oct 22 2020
This looks great! Thanks!
Oct 16 2020
Sep 21 2020
I am totally fine with keeping this in-tree, even unused, if it helps several out-of-tree backends. Thanks for speaking up.
Sep 18 2020
LGTM
Sep 17 2020
Can you wrap the condition around the whole file? The rest is not useful without the library anyway.
Won't be back to this anytime soon.
LGTM
Aug 28 2020
This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.
Aug 14 2020
Aug 12 2020
LGTM, thanks for plugging all these options through!
Jul 29 2020
Hi @compnerd, it looks like this fails to link: http://green.lab.llvm.org/green/job/clang-stage1-RA/13171/console
Jul 27 2020
I had an attempt here: https://reviews.llvm.org/D33419, I think similar concerns came up in that review.
Jul 21 2020
Jul 20 2020
Jul 17 2020
Hi, I see CodeGen/X86/statepoint-vreg.mir failing with UBSAN enabled on our internal bots:
Jul 14 2020
Jul 9 2020
LGTM, thanks!