Page MenuHomePhabricator

thegameg (Francis Visoiu Mistrih)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2015, 4:41 AM (256 w, 21 h)

Recent Activity

Fri, Oct 16

thegameg added a comment to rG0345d88de654: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.

Is this really necessary to remove? For example, our backend is using EntrySU edges for top edges from the basic block entry, in order to account for clearances. It seems to make sense to have a node like this.

Fri, Oct 16, 9:42 AM

Mon, Sep 21

thegameg added a comment to D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.

I am totally fine with keeping this in-tree, even unused, if it helps several out-of-tree backends. Thanks for speaking up.

Mon, Sep 21, 12:25 PM · Restricted Project

Sep 18 2020

thegameg accepted D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.

LGTM

Sep 18 2020, 3:06 PM · Restricted Project
thegameg committed rG0345d88de654: [NFC][ScheduleDAG] Remove unused EntrySU SUnit (authored by thegameg).
[NFC][ScheduleDAG] Remove unused EntrySU SUnit
Sep 18 2020, 9:52 AM
thegameg closed D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.
Sep 18 2020, 9:52 AM · Restricted Project

Sep 17 2020

thegameg abandoned D53490: [MIR] Provide a default alignment for stack objects.
Sep 17 2020, 4:31 PM
thegameg requested changes to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.

Can you wrap the condition around the whole file? The rest is not useful without the library anyway.

Sep 17 2020, 4:29 PM · Restricted Project
thegameg requested review of D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit.
Sep 17 2020, 3:55 PM · Restricted Project
thegameg abandoned D34544: [libunwind] Don't assume the return address register is always saved and has CFI for it.

Won't be back to this anytime soon.

Sep 17 2020, 3:18 PM
thegameg accepted D85810: [clang] Pass-through remarks options to linker.

LGTM

Sep 17 2020, 2:58 PM · Restricted Project

Aug 28 2020

thegameg accepted D86797: [early-ifcvt] Add OptRemarks.

This looks great, thanks! Since it's a CodeGen pass, I would suggest using a MIR test instead of an IR one, but I think it's probably easier to read it as it is right now.

Aug 28 2020, 11:55 AM · Restricted Project

Aug 14 2020

thegameg added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

Just to clarify, I wasn't suggesting putting it in another patch, but just bringing it back here (plus adding in the gold-plugin support). The other patch I was referring to was the follow on patch D85810 where I also suggested adding support to gold-plugin.cpp.

Aug 14 2020, 11:49 AM · Restricted Project
thegameg added a comment to D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

I have removed the change to llvm-lto

Aug 14 2020, 11:41 AM · Restricted Project

Aug 12 2020

thegameg accepted D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.

LGTM, thanks for plugging all these options through!

Aug 12 2020, 3:55 PM · Restricted Project

Jul 29 2020

thegameg added a reverting change for rGd8e8e32d85f1: build: always add support for assembly targets on Darwin: rG926c14798d31: Revert "build: always add support for assembly targets on Darwin".
Jul 29 2020, 3:45 PM
thegameg committed rG926c14798d31: Revert "build: always add support for assembly targets on Darwin" (authored by thegameg).
Revert "build: always add support for assembly targets on Darwin"
Jul 29 2020, 3:45 PM
thegameg added a reverting change for D84333: build: always add support for assembly targets on Darwin: rG926c14798d31: Revert "build: always add support for assembly targets on Darwin".
Jul 29 2020, 3:45 PM · Restricted Project
thegameg added a comment to D84333: build: always add support for assembly targets on Darwin.

Hi @compnerd, it looks like this fails to link: http://green.lab.llvm.org/green/job/clang-stage1-RA/13171/console

Jul 29 2020, 3:30 PM · Restricted Project
thegameg added a comment to D84690: Make iterators of BitVector easier to use by inheriting iterator_facade_base.

Indeed, sorry that fell through & I didn't understand enough about iterators to instead suggest falling back to an input iterator instead of figuring out how to fit the semantics of the forward iterator.

Jul 29 2020, 2:06 PM · Restricted Project

Jul 27 2020

thegameg added a comment to D84690: Make iterators of BitVector easier to use by inheriting iterator_facade_base.

I had an attempt here: https://reviews.llvm.org/D33419, I think similar concerns came up in that review.

Jul 27 2020, 2:12 PM · Restricted Project

Jul 21 2020

thegameg added a comment to D84207: [compiler-rt][test][profile] Fix missing include.

Not sure why our public bots didn't catch it.

Jul 21 2020, 11:39 AM · Restricted Project

Jul 20 2020

thegameg added a comment to D81645: MIR Statepoint refactoring. Part 1: Basic MI level changes..

Hi, I see CodeGen/X86/statepoint-vreg.mir failing with UBSAN enabled on our internal bots:

Should be fixed already.
Does your sources include e04fe9aefd4?

Jul 20 2020, 9:08 AM · Restricted Project

Jul 17 2020

thegameg added a comment to D81645: MIR Statepoint refactoring. Part 1: Basic MI level changes..

Hi, I see CodeGen/X86/statepoint-vreg.mir failing with UBSAN enabled on our internal bots:

Jul 17 2020, 6:03 PM · Restricted Project

Jul 14 2020

thegameg committed rG2cffd7c40ea5: [Driver] Only pass LTO remark arguments if the driver asks for it (authored by thegameg).
[Driver] Only pass LTO remark arguments if the driver asks for it
Jul 14 2020, 4:39 PM
thegameg committed rG684a9d17ba95: [Driver] Handle all optimization-record options for Darwin LTO (authored by thegameg).
[Driver] Handle all optimization-record options for Darwin LTO
Jul 14 2020, 4:39 PM
thegameg committed rG8769525acbe2: [MachO] Add cpu(sub)type tests and improve error handling (authored by thegameg).
[MachO] Add cpu(sub)type tests and improve error handling
Jul 14 2020, 4:30 PM
thegameg committed rGb772ba713bc2: [LTO][Legacy] Add new API to query Mach-O CPU (sub)type (authored by thegameg).
[LTO][Legacy] Add new API to query Mach-O CPU (sub)type
Jul 14 2020, 4:30 PM
thegameg committed rG42d75cc662ec: [Target] Remove libObject dependency in lib/Target (authored by thegameg).
[Target] Remove libObject dependency in lib/Target
Jul 14 2020, 4:30 PM
thegameg committed rGf8a4e3f0ae8f: [macho][NFC] Extract all CPU_(SUB_)TYPE logic to BinaryFormat (authored by thegameg).
[macho][NFC] Extract all CPU_(SUB_)TYPE logic to BinaryFormat
Jul 14 2020, 4:30 PM
thegameg committed rG5b8fc9c3fec2: [AArch64] Delete an unneeded dependency on Object after… (authored by MaskRay).
[AArch64] Delete an unneeded dependency on Object after…
Jul 14 2020, 4:30 PM
thegameg committed rG7af3216fdaa8: [AArch64][SVE] Fix -DBUILD_SHARED_LIBS=on builds after… (authored by MaskRay).
[AArch64][SVE] Fix -DBUILD_SHARED_LIBS=on builds after…
Jul 14 2020, 4:30 PM
thegameg committed rG7737edf28d39: [llvm][build] Fix shared lib builds. [NFC] (authored by fpetrogalli).
[llvm][build] Fix shared lib builds. [NFC]
Jul 14 2020, 4:30 PM
thegameg committed rG2c21cfcb35a0: [Remarks] Fix gcc build (authored by thegameg).
[Remarks] Fix gcc build
Jul 14 2020, 4:20 PM
thegameg committed rG1fee4c40a623: Fix warning on trailing `;`. NFC. (authored by hliao).
Fix warning on trailing `;`. NFC.
Jul 14 2020, 4:20 PM
thegameg committed rGe16ee7d4f600: [Remarks] Extend the RemarkStreamer to support other emitters (authored by thegameg).
[Remarks] Extend the RemarkStreamer to support other emitters
Jul 14 2020, 4:20 PM
thegameg committed rG805a8329c87a: [AArch64] Provide Darwin variants of most calling conventions (authored by thegameg).
[AArch64] Provide Darwin variants of most calling conventions
Jul 14 2020, 4:19 PM
Visoiu Mistrih Francis <890283+francisvm@users.noreply.github.com> committed rGdb1b0e41b0cc: Revert " Renable r314928" (authored by thegameg).
Revert " Renable r314928"
Jul 14 2020, 4:18 PM
thegameg added a reverting change for rG4cdc9dab0ac9: Renable r314928: rGdb1b0e41b0cc: Revert " Renable r314928".
Jul 14 2020, 4:18 PM
Visoiu Mistrih Francis <890283+francisvm@users.noreply.github.com> committed rGbcf51f094d48: Revert "[InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI" (authored by thegameg).
Revert "[InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI"
Jul 14 2020, 4:18 PM
thegameg added a reverting change for rGa4c76be50689: [InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI: rGbcf51f094d48: Revert "[InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI".
Jul 14 2020, 4:18 PM
thegameg committed rGfc9cafb98660: [CodeGen] Attach no-builtin attributes to function definitions with no Decl (authored by thegameg).
[CodeGen] Attach no-builtin attributes to function definitions with no Decl
Jul 14 2020, 4:18 PM

Jul 9 2020

thegameg accepted D83456: [NFC][AArch64] Refactor getArgumentPopSize.

LGTM, thanks!

Jul 9 2020, 10:13 AM · Restricted Project

Jul 3 2020

thegameg committed rGaa5ec34e3126: [LoopDeletion] Emit a remark when a dead loop is deleted (authored by thegameg).
[LoopDeletion] Emit a remark when a dead loop is deleted
Jul 3 2020, 3:48 PM
thegameg closed D83113: [LoopDeletion] Emit a remark when a dead loop is deleted.
Jul 3 2020, 3:46 PM · Restricted Project
thegameg added inline comments to D83113: [LoopDeletion] Emit a remark when a dead loop is deleted.
Jul 3 2020, 3:39 PM · Restricted Project
thegameg updated the diff for D83113: [LoopDeletion] Emit a remark when a dead loop is deleted.
Jul 3 2020, 3:39 PM · Restricted Project

Jul 2 2020

thegameg created D83113: [LoopDeletion] Emit a remark when a dead loop is deleted.
Jul 2 2020, 10:39 PM · Restricted Project

Jul 1 2020

thegameg added inline comments to D82763: MIR: Infer not-SSA for subregister defs.
Jul 1 2020, 8:09 AM · Restricted Project

Jun 24 2020

thegameg accepted D82478: [MIR] Fix CFI_INSTRUCTION escape printing.
Jun 24 2020, 1:34 PM · Restricted Project

Jun 19 2020

thegameg updated subscribers of D82213: [Remarks] Add callsite locations to inline remarks.

This sounds useful indeed. @fhahn, @anemet might want to take a look.

Jun 19 2020, 11:26 AM · Restricted Project, Restricted Project
thegameg accepted D82033: [LTO] Use StringRef instead of C-style strings in setCodeGenDebugOptions.

LGTM, thanks.

Jun 19 2020, 9:12 AM · Restricted Project

Jun 17 2020

thegameg added a comment to D82033: [LTO] Use StringRef instead of C-style strings in setCodeGenDebugOptions.

Would it be cleaner to make setCodeGenDebugOptions take an ArrayRef<StringRef>?

Jun 17 2020, 11:50 AM · Restricted Project

Jun 16 2020

thegameg added a comment to D80249: CodeGen: Don't lazily construct MachineFunctionInfo.

I think there are a bunch of APIs that have this issue, so I think the general direction is good. I don't expect this to have any memory/compile-time impact, since probably even the smallest input will create the MachineFunctionInfo anyway. Was this the initial intention of having it build lazily?

Jun 16 2020, 7:10 PM · Restricted Project
thegameg added inline comments to D72425: [OptRemark] RFC: Introduce a message table for OptRemarks.
Jun 16 2020, 6:38 PM · Restricted Project

May 20 2020

thegameg committed rG770ba4f0516e: [AArch64] Fix GlobalISel tests on non-darwin platforms (authored by thegameg).
[AArch64] Fix GlobalISel tests on non-darwin platforms
May 20 2020, 4:35 PM
thegameg committed rG161122ea1c61: [AArch64] Provide Darwin variants of most calling conventions (authored by thegameg).
[AArch64] Provide Darwin variants of most calling conventions
May 20 2020, 4:35 PM
thegameg closed D73805: [AArch64] Provide Darwin variants of most calling conventions.
May 20 2020, 4:34 PM · Restricted Project
thegameg updated the diff for D73805: [AArch64] Provide Darwin variants of most calling conventions.

Address reviewer comments.

May 20 2020, 12:03 PM · Restricted Project

May 11 2020

thegameg accepted D79745: [YAMLTraits] Add trait for char.

LGTM.

May 11 2020, 3:07 PM · Restricted Project

Apr 29 2020

thegameg accepted D79070: [NFCi] Iterative Outliner + clang-format refactoring..

Looks pretty straightforward. Thanks!

Apr 29 2020, 11:16 AM · Restricted Project

Apr 28 2020

thegameg committed rGe770153865c5: [AArch64] Add support for -ffixed-x30 (authored by thegameg).
[AArch64] Add support for -ffixed-x30
Apr 28 2020, 9:07 AM

Apr 25 2020

thegameg accepted D78815: [Pass] Ensure we don't include PassSupport.h/PassAnalysisSupport.h directly.

LGTM, thanks!

Apr 25 2020, 11:21 PM · Restricted Project

Apr 24 2020

thegameg added a comment to D78815: [Pass] Ensure we don't include PassSupport.h/PassAnalysisSupport.h directly.

There are still a bunch of other users of the headers in tree, but the error doesn't trigger since Pass.h gets included before. Is that worth changing as well?

Apr 24 2020, 12:26 PM · Restricted Project

Apr 23 2020

thegameg accepted D74303: [CFI] cfi directive insertion for callee-save-registers in CFIInstrInserter pass.

Thank you, this LGTM!

Apr 23 2020, 1:34 AM · Restricted Project

Apr 17 2020

thegameg added inline comments to D74303: [CFI] cfi directive insertion for callee-save-registers in CFIInstrInserter pass.
Apr 17 2020, 11:20 AM · Restricted Project

Apr 13 2020

thegameg accepted D77852: Outline CFI Instructions in Tail Calls.
Apr 13 2020, 10:44 AM · Restricted Project
thegameg added a comment to D77852: Outline CFI Instructions in Tail Calls.

Thanks Andrew! A few coments inline and below:

Apr 13 2020, 10:44 AM · Restricted Project

Apr 7 2020

thegameg committed rG9e6670b03cea: [Driver] Only pass LTO remark arguments if the driver asks for it (authored by thegameg).
[Driver] Only pass LTO remark arguments if the driver asks for it
Apr 7 2020, 2:12 PM

Apr 3 2020

thegameg committed rGba8b3052b59e: [Driver] Handle all optimization-record options for Darwin LTO (authored by thegameg).
[Driver] Handle all optimization-record options for Darwin LTO
Apr 3 2020, 3:44 PM

Mar 27 2020

thegameg accepted D76916: [Darwin] Respect -fno-unroll-loops during LTO..

LGTM, thanks!

Mar 27 2020, 10:16 AM · Restricted Project

Mar 10 2020

thegameg added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

This also fixes https://bugs.llvm.org/show_bug.cgi?id=44253. Is there any update on the ppc reproducer?

Mar 10 2020, 12:00 PM

Mar 4 2020

thegameg accepted D74303: [CFI] cfi directive insertion for callee-save-registers in CFIInstrInserter pass.

LGTM, this looks great, thanks @wmi.

Mar 4 2020, 10:05 AM · Restricted Project

Mar 3 2020

thegameg added a comment to D74303: [CFI] cfi directive insertion for callee-save-registers in CFIInstrInserter pass.

Sorry for the delay.

Mar 3 2020, 10:56 AM · Restricted Project

Feb 28 2020

thegameg committed rG94cbe1307373: [LTO][Legacy] Add explicit dependency on BinaryFormat (authored by thegameg).
[LTO][Legacy] Add explicit dependency on BinaryFormat
Feb 28 2020, 3:57 PM
thegameg committed rGe551b737c3c7: [LTO][Legacy] Add new API to query Mach-O CPU (sub)type (authored by thegameg).
[LTO][Legacy] Add new API to query Mach-O CPU (sub)type
Feb 28 2020, 1:06 PM
thegameg closed D75067: [LTO][Legacy] Add new API to query Mach-O CPU (sub)type.
Feb 28 2020, 1:06 PM · Restricted Project

Feb 25 2020

thegameg added a comment to D72425: [OptRemark] RFC: Introduce a message table for OptRemarks.

This is great! Sorry for the delay. More comments inline.

Feb 25 2020, 11:24 AM · Restricted Project

Feb 24 2020

thegameg updated the diff for D75067: [LTO][Legacy] Add new API to query Mach-O CPU (sub)type.

Add test through llvm-lto. More extensive testing of the BinaryFormat logic was added in https://reviews.llvm.org/rG7b0a5683fa09be4e60bc93526aad7b63bbca687c.

Feb 24 2020, 2:48 PM · Restricted Project
thegameg committed rG7b0a5683fa09: [MachO] Add cpu(sub)type tests and improve error handling (authored by thegameg).
[MachO] Add cpu(sub)type tests and improve error handling
Feb 24 2020, 10:58 AM
thegameg created D75067: [LTO][Legacy] Add new API to query Mach-O CPU (sub)type.
Feb 24 2020, 10:58 AM · Restricted Project

Feb 21 2020

thegameg committed rGa32d539798e4: [Target] Remove libObject dependency in lib/Target (authored by thegameg).
[Target] Remove libObject dependency in lib/Target
Feb 21 2020, 2:57 PM
thegameg added a comment to D74808: [MachO][NFC] Extract all CPU_(SUB_)TYPE logic to libObject.

Thanks @fpetrogalli and @MaskRay. I did one more cleanup: a32d539798e4 [Target] Remove libObject dependency in lib/Target.

Feb 21 2020, 2:57 PM · Restricted Project
thegameg committed rG1874dee56626: [macho][NFC] Extract all CPU_(SUB_)TYPE logic to BinaryFormat (authored by thegameg).
[macho][NFC] Extract all CPU_(SUB_)TYPE logic to BinaryFormat
Feb 21 2020, 12:49 PM

Feb 20 2020

thegameg added a reverting change for rG726c342ce27a: [macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject: rG3f785212e9ce: Revert "[macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject".
Feb 20 2020, 10:56 AM
thegameg committed rG3f785212e9ce: Revert "[macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject" (authored by thegameg).
Revert "[macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject"
Feb 20 2020, 10:56 AM
thegameg committed rG726c342ce27a: [macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject (authored by thegameg).
[macho][NFC] Extract all CPU_(SUB_)TYPE logic to libObject
Feb 20 2020, 10:29 AM
thegameg closed D74808: [MachO][NFC] Extract all CPU_(SUB_)TYPE logic to libObject.
Feb 20 2020, 10:29 AM · Restricted Project

Feb 18 2020

thegameg created D74808: [MachO][NFC] Extract all CPU_(SUB_)TYPE logic to libObject.
Feb 18 2020, 5:08 PM · Restricted Project

Feb 11 2020

thegameg added a comment to D74303: [CFI] cfi directive insertion for callee-save-registers in CFIInstrInserter pass.

Thanks for working on this, I think in general it looks good.

Feb 11 2020, 10:14 AM · Restricted Project

Feb 7 2020

thegameg added inline comments to D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 7 2020, 11:30 AM · Restricted Project

Feb 4 2020

thegameg committed rG3125887845ca: [Remarks] Fix gcc build (authored by thegameg).
[Remarks] Fix gcc build
Feb 4 2020, 5:45 PM
thegameg committed rG7531a5039fd7: [Remarks] Extend the RemarkStreamer to support other emitters (authored by thegameg).
[Remarks] Extend the RemarkStreamer to support other emitters
Feb 4 2020, 5:26 PM
thegameg closed D73676: [Remarks] Extend the RemarkStreamer to support other emitters.
Feb 4 2020, 5:26 PM · Restricted Project, Restricted Project

Feb 3 2020

thegameg added inline comments to D73805: [AArch64] Provide Darwin variants of most calling conventions.
Feb 3 2020, 2:43 PM · Restricted Project

Jan 31 2020

thegameg created D73805: [AArch64] Provide Darwin variants of most calling conventions.
Jan 31 2020, 1:58 PM · Restricted Project

Jan 29 2020

thegameg created D73676: [Remarks] Extend the RemarkStreamer to support other emitters.
Jan 29 2020, 5:18 PM · Restricted Project, Restricted Project
thegameg added inline comments to D73597: [LTO] Add optimization remarks for removed functions.
Jan 29 2020, 4:06 PM · Restricted Project

Jan 28 2020

thegameg added inline comments to D73597: [LTO] Add optimization remarks for removed functions.
Jan 28 2020, 5:47 PM · Restricted Project
thegameg committed rGb1a8189d7d75: [NFC] Fix comment typo (authored by thegameg).
[NFC] Fix comment typo
Jan 28 2020, 3:30 PM
thegameg committed rG4e799ada5860: [CodeGen] Attach no-builtin attributes to function definitions with no Decl (authored by thegameg).
[CodeGen] Attach no-builtin attributes to function definitions with no Decl
Jan 28 2020, 2:06 PM