Page MenuHomePhabricator

kcc (Kostya Serebryany)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2012, 4:55 AM (359 w, 2 d)

Recent Activity

Fri, Aug 16

kcc added a comment to D66107: [libFuzzer] Improve -merge= process to account for REDUCED corpus units..

I would prefer to not introduce this complexity.
For periodic pruning we can use an empty dir, like you describe.
For stats, we can use the overal corpus size (in bytes and in files)

Fri, Aug 16, 12:50 PM · Restricted Project, Restricted Project

Jul 16 2019

kcc accepted D64453: [GWP-ASan] Add thread ID to PRNG seed..

LGTM

Jul 16 2019, 12:51 PM · Restricted Project, Restricted Project

Jul 9 2019

kcc added a comment to D62875: [GWP-ASan] Add public-facing documentation [6]..

With a build command line, of course

clang++ -g -std=c++17 string-view-use-after-free.cc  -fsanitize=scudo
Jul 9 2019, 2:48 PM · Restricted Project, Restricted Project
kcc added a comment to D62875: [GWP-ASan] Add public-facing documentation [6]..

Maybe add an example?
something like my favorite

#include <iostream>
#include <string>
#include <string_view>
Jul 9 2019, 2:48 PM · Restricted Project, Restricted Project

Jul 2 2019

kcc added a comment to D63877: Avoid infinite loop with asan interception.

Vitaly, please take a look as well.

Jul 2 2019, 2:50 PM · Restricted Project, Restricted Project
kcc added inline comments to D63877: Avoid infinite loop with asan interception.
Jul 2 2019, 11:18 AM · Restricted Project, Restricted Project
kcc added a comment to D63785: Add support for MUSL libc.

Frankly, I would like to see a parallel effort in Musl.
I've seen the recent comment at https://github.com/google/sanitizers/issues/1080#issuecomment-506565699
suggesting that Musl is not likely to accept this approach.
But please look at the situation from our perspective:
this amount of #ifdefs in the code will increase the cost of maintenance for us, w/o giving much to anyone who doesn't use Musl.
And this is a wrong technical decision anyway, as we've known in 2011 (just didn't have other choice)
and as we've confirmed with our current implementation of HWASAN in Bionic.

Jul 2 2019, 11:12 AM · Restricted Project, Restricted Project

Jun 27 2019

kcc added a comment to D62680: [ARM] Add MVE vector load/store instructions..

Actually, the test started failing in ubsan mode right after this commit. Please fix ASAP. Reproduce: build with -DLLVM_USE_SANITIZER=Undefined, then "ninja check-llvm"

Jun 27 2019, 2:01 PM · Restricted Project
kcc added a comment to D62680: [ARM] Add MVE vector load/store instructions..

This new test is currently failing on the ubsan build.
Could you please take a look?
I don't yet know is the breaking change.

Jun 27 2019, 1:46 PM · Restricted Project
kcc added a reviewer for D63877: Avoid infinite loop with asan interception: vitalybuka.

I like the simplicity of the fix!
Please add a comment explaining the fix, and a test that verifies how it works.

Jun 27 2019, 10:58 AM · Restricted Project, Restricted Project

Jun 26 2019

kcc removed a reviewer for D63785: Add support for MUSL libc: samsonov.

Thanks for doing this!

Jun 26 2019, 11:22 AM · Restricted Project, Restricted Project
kcc added a comment to D63104: Add GSYM utility files along with unit tests..

Hi, 
I think this is causing a failure on the asan bot. Please fix or revert ASAP

Jun 26 2019, 10:03 AM · Restricted Project

Jun 20 2019

kcc committed rG679669a77e5b: [libFuzzer] split DataFlow.cpp into two .cpp files, one of which can be… (authored by kcc).
[libFuzzer] split DataFlow.cpp into two .cpp files, one of which can be…
Jun 20 2019, 6:38 PM
kcc committed rL364002: [libFuzzer] split DataFlow.cpp into two .cpp files, one of which can be….
[libFuzzer] split DataFlow.cpp into two .cpp files, one of which can be…
Jun 20 2019, 6:38 PM

Jun 19 2019

kcc committed rG27cf743bff0c: [libFuzzer] ensure that DFT and autofocus works for C++ (mangled) functions (authored by kcc).
[libFuzzer] ensure that DFT and autofocus works for C++ (mangled) functions
Jun 19 2019, 6:47 PM
kcc committed rL363905: [libFuzzer] ensure that DFT and autofocus works for C++ (mangled) functions.
[libFuzzer] ensure that DFT and autofocus works for C++ (mangled) functions
Jun 19 2019, 6:46 PM

Jun 14 2019

kcc committed rG0feed5d585f7: [libFuzzer] in autofocus mode, give more weight to functions with DFT (authored by kcc).
[libFuzzer] in autofocus mode, give more weight to functions with DFT
Jun 14 2019, 4:30 PM
kcc committed rL363473: [libFuzzer] in autofocus mode, give more weight to functions with DFT.
[libFuzzer] in autofocus mode, give more weight to functions with DFT
Jun 14 2019, 4:30 PM
kcc committed rGdb88fc56b967: [libFuzzer] implement a better queue for the fork mode. Add an internal flag… (authored by kcc).
[libFuzzer] implement a better queue for the fork mode. Add an internal flag…
Jun 14 2019, 3:54 PM
kcc committed rL363470: [libFuzzer] implement a better queue for the fork mode. Add an internal flag….
[libFuzzer] implement a better queue for the fork mode. Add an internal flag…
Jun 14 2019, 3:54 PM
kcc committed rG2fa6838e5fe9: [libFuzzer] fix -Werror build (authored by kcc).
[libFuzzer] fix -Werror build
Jun 14 2019, 3:34 PM
kcc committed rL363469: [libFuzzer] fix -Werror build.
[libFuzzer] fix -Werror build
Jun 14 2019, 3:31 PM
kcc committed rG3f39123d15ba: [libFuzzer] simplify the DFT trace collection using the new faster DFSan mode… (authored by kcc).
[libFuzzer] simplify the DFT trace collection using the new faster DFSan mode…
Jun 14 2019, 12:52 PM
kcc committed rL363445: [libFuzzer] simplify the DFT trace collection using the new faster DFSan mode….
[libFuzzer] simplify the DFT trace collection using the new faster DFSan mode…
Jun 14 2019, 12:51 PM
kcc accepted D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..

LGTM given a test
Thanks!

Jun 14 2019, 11:41 AM · Restricted Project, Restricted Project

Jun 13 2019

kcc committed rGa5b12be60f98: fix whitespaces (authored by kcc).
fix whitespaces
Jun 13 2019, 2:15 PM
kcc committed rG2fa83cb7ee0c: [libFuzzer] simplify the DFT trace collection using the new faster DFSan mode… (authored by kcc).
[libFuzzer] simplify the DFT trace collection using the new faster DFSan mode…
Jun 13 2019, 2:15 PM
kcc committed rL363327: fix whitespaces.
fix whitespaces
Jun 13 2019, 2:15 PM
kcc committed rL363326: [libFuzzer] simplify the DFT trace collection using the new faster DFSan mode….
[libFuzzer] simplify the DFT trace collection using the new faster DFSan mode…
Jun 13 2019, 2:15 PM
kcc committed rG6b936d88a46b: [dfsan] Introduce dfsan_flush(). (authored by kcc).
[dfsan] Introduce dfsan_flush().
Jun 13 2019, 1:09 PM
kcc committed rL363321: [dfsan] Introduce dfsan_flush()..
[dfsan] Introduce dfsan_flush().
Jun 13 2019, 1:09 PM
kcc closed D63037: [dfsan] Introduce dfsan_flush()..
Jun 13 2019, 1:09 PM · Restricted Project, Restricted Project

Jun 7 2019

kcc created D63037: [dfsan] Introduce dfsan_flush()..
Jun 7 2019, 5:38 PM · Restricted Project, Restricted Project
kcc committed rG300c0c79de66: Experimantal dfsan mode "fast16labels=1" (authored by kcc).
Experimantal dfsan mode "fast16labels=1"
Jun 7 2019, 5:21 PM
kcc committed rL362859: Experimantal dfsan mode "fast16labels=1".
Experimantal dfsan mode "fast16labels=1"
Jun 7 2019, 5:21 PM
kcc closed D62870: Experimantal dfsan mode "fast16labels=1".
Jun 7 2019, 5:21 PM · Restricted Project, Restricted Project
kcc added a comment to D62870: Experimantal dfsan mode "fast16labels=1".

All other dfsan functions will actually continue working - most of them just won't be needed.

Jun 7 2019, 5:21 PM · Restricted Project, Restricted Project

Jun 4 2019

kcc edited reviewers for D62870: Experimantal dfsan mode "fast16labels=1", added: pcc; removed: kcc.
Jun 4 2019, 11:31 AM · Restricted Project, Restricted Project
kcc created D62870: Experimantal dfsan mode "fast16labels=1".
Jun 4 2019, 11:26 AM · Restricted Project, Restricted Project

May 23 2019

kcc committed rCRT361579: [libFuzzer] when using data-flow-trace (DFT) only load the DFT for the files….
[libFuzzer] when using data-flow-trace (DFT) only load the DFT for the files…
May 23 2019, 5:44 PM
kcc committed rG060f4b48d55c: [libFuzzer] when using data-flow-trace (DFT) only load the DFT for the files… (authored by kcc).
[libFuzzer] when using data-flow-trace (DFT) only load the DFT for the files…
May 23 2019, 5:44 PM
kcc committed rL361579: [libFuzzer] when using data-flow-trace (DFT) only load the DFT for the files….
[libFuzzer] when using data-flow-trace (DFT) only load the DFT for the files…
May 23 2019, 5:41 PM

May 22 2019

kcc committed rGeac9a7830b6b: [libFuzzer] remove the data-flow-trace (DFT) python scripts; their… (authored by kcc).
[libFuzzer] remove the data-flow-trace (DFT) python scripts; their…
May 22 2019, 6:04 PM
kcc committed rCRT361452: [libFuzzer] remove the data-flow-trace (DFT) python scripts; their….
[libFuzzer] remove the data-flow-trace (DFT) python scripts; their…
May 22 2019, 6:04 PM
kcc committed rL361452: [libFuzzer] remove the data-flow-trace (DFT) python scripts; their….
[libFuzzer] remove the data-flow-trace (DFT) python scripts; their…
May 22 2019, 6:04 PM
kcc committed rGb7cc3d995331: [libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if… (authored by kcc).
[libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if…
May 22 2019, 5:21 PM
kcc committed rCRT361448: [libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if….
[libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if…
May 22 2019, 5:20 PM
kcc committed rL361448: [libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if….
[libFuzzer] automatically collect the data flow trace (DFT) in the fork mode if…
May 22 2019, 5:20 PM

May 14 2019

kcc committed rG2e2dfe218615: [libFuzzer] replace string_view with string to fix the bots. This is NFC, just… (authored by kcc).
[libFuzzer] replace string_view with string to fix the bots. This is NFC, just…
May 14 2019, 3:14 PM
kcc committed rL360717: [libFuzzer] replace string_view with string to fix the bots. This is NFC, just….
[libFuzzer] replace string_view with string to fix the bots. This is NFC, just…
May 14 2019, 3:14 PM
kcc committed rCRT360717: [libFuzzer] replace string_view with string to fix the bots. This is NFC, just….
[libFuzzer] replace string_view with string to fix the bots. This is NFC, just…
May 14 2019, 3:14 PM
kcc committed rG1e8104daf2d4: [libFuzzer] #include <string_view>, hopefully should fix the windows build (authored by kcc).
[libFuzzer] #include <string_view>, hopefully should fix the windows build
May 14 2019, 3:04 PM
kcc committed rCRT360715: [libFuzzer] #include <string_view>, hopefully should fix the windows build .
[libFuzzer] #include <string_view>, hopefully should fix the windows build
May 14 2019, 3:03 PM
kcc committed rL360715: [libFuzzer] #include <string_view>, hopefully should fix the windows build .
[libFuzzer] #include <string_view>, hopefully should fix the windows build
May 14 2019, 3:03 PM
kcc committed rCRT360712: [libFuzzer] reimplement DFT's collect_data_flow inside libFuzzer so that we….
[libFuzzer] reimplement DFT's collect_data_flow inside libFuzzer so that we…
May 14 2019, 2:54 PM
kcc committed rG27d22b6b7a6e: [libFuzzer] reimplement DFT's collect_data_flow inside libFuzzer so that we… (authored by kcc).
[libFuzzer] reimplement DFT's collect_data_flow inside libFuzzer so that we…
May 14 2019, 2:47 PM
kcc committed rL360712: [libFuzzer] reimplement DFT's collect_data_flow inside libFuzzer so that we….
[libFuzzer] reimplement DFT's collect_data_flow inside libFuzzer so that we…
May 14 2019, 2:47 PM

May 9 2019

kcc committed rG4c7353c53bdd: [libFuzzer] code refactoring; NFC (authored by kcc).
[libFuzzer] code refactoring; NFC
May 9 2019, 6:33 PM
kcc committed rCRT360400: [libFuzzer] code refactoring; NFC.
[libFuzzer] code refactoring; NFC
May 9 2019, 6:32 PM
kcc committed rL360400: [libFuzzer] code refactoring; NFC.
[libFuzzer] code refactoring; NFC
May 9 2019, 6:31 PM
kcc committed rGda96d92175f7: [libFuzzer] small refactoring in the driver; dummy implementation of… (authored by kcc).
[libFuzzer] small refactoring in the driver; dummy implementation of…
May 9 2019, 5:58 PM
kcc committed rCRT360399: [libFuzzer] small refactoring in the driver; dummy implementation of….
[libFuzzer] small refactoring in the driver; dummy implementation of…
May 9 2019, 5:58 PM
kcc committed rL360399: [libFuzzer] small refactoring in the driver; dummy implementation of….
[libFuzzer] small refactoring in the driver; dummy implementation of…
May 9 2019, 5:58 PM
kcc committed rG4a5793f7d07c: [libFuzzer] perform more agressive value profiling in memcmp (authored by kcc).
[libFuzzer] perform more agressive value profiling in memcmp
May 9 2019, 3:08 PM
kcc committed rCRT360385: [libFuzzer] perform more agressive value profiling in memcmp.
[libFuzzer] perform more agressive value profiling in memcmp
May 9 2019, 3:08 PM
kcc committed rL360385: [libFuzzer] perform more agressive value profiling in memcmp.
[libFuzzer] perform more agressive value profiling in memcmp
May 9 2019, 3:08 PM
kcc committed rGe9aaa5582fa1: [libFuzzer] implement -focus_function=auto, to be used with Data Flow Traces (authored by kcc).
[libFuzzer] implement -focus_function=auto, to be used with Data Flow Traces
May 9 2019, 2:29 PM
kcc committed rL360378: [libFuzzer] implement -focus_function=auto, to be used with Data Flow Traces.
[libFuzzer] implement -focus_function=auto, to be used with Data Flow Traces
May 9 2019, 2:29 PM
kcc committed rCRT360378: [libFuzzer] implement -focus_function=auto, to be used with Data Flow Traces.
[libFuzzer] implement -focus_function=auto, to be used with Data Flow Traces
May 9 2019, 2:29 PM
kcc committed rCRT360372: [libFuzzer] simplify value-profile-mem.test a little bit.
[libFuzzer] simplify value-profile-mem.test a little bit
May 9 2019, 1:20 PM
kcc committed rG194b1c3078e7: [libFuzzer] simplify value-profile-mem.test a little bit (authored by kcc).
[libFuzzer] simplify value-profile-mem.test a little bit
May 9 2019, 1:20 PM
kcc committed rL360372: [libFuzzer] simplify value-profile-mem.test a little bit.
[libFuzzer] simplify value-profile-mem.test a little bit
May 9 2019, 1:18 PM
kcc added a comment to D61751: [MSan] Introduce __msan_unpoison_param()..

make total sense, but please wait for Evgenii's LGTM

May 9 2019, 12:43 PM · Restricted Project, Restricted Project
kcc accepted D61753: [libFuzzer] Unpoison parameters before calling user callback..

LGTM, thanks!

May 9 2019, 12:43 PM · Restricted Project, Restricted Project

May 8 2019

kcc committed rGe13eff293db2: [libFuzzer] DFT: when dumping coverage, also dump the total number of… (authored by kcc).
[libFuzzer] DFT: when dumping coverage, also dump the total number of…
May 8 2019, 10:18 AM
kcc committed rCRT360272: [libFuzzer] DFT: when dumping coverage, also dump the total number of….
[libFuzzer] DFT: when dumping coverage, also dump the total number of…
May 8 2019, 10:18 AM
kcc committed rL360272: [libFuzzer] DFT: when dumping coverage, also dump the total number of….
[libFuzzer] DFT: when dumping coverage, also dump the total number of…
May 8 2019, 10:18 AM

May 7 2019

kcc committed rGba670b404e3f: [libFuzzer] extend the test for data flow tracer and coverage; also hopefully… (authored by kcc).
[libFuzzer] extend the test for data flow tracer and coverage; also hopefully…
May 7 2019, 6:05 PM
kcc committed rCRT360215: [libFuzzer] extend the test for data flow tracer and coverage; also hopefully….
[libFuzzer] extend the test for data flow tracer and coverage; also hopefully…
May 7 2019, 6:01 PM
kcc committed rL360215: [libFuzzer] extend the test for data flow tracer and coverage; also hopefully….
[libFuzzer] extend the test for data flow tracer and coverage; also hopefully…
May 7 2019, 6:00 PM
kcc committed rG219b2b3a4a78: [libFuzzer] extend the data flow tracer to also produce basic block coverage… (authored by kcc).
[libFuzzer] extend the data flow tracer to also produce basic block coverage…
May 7 2019, 5:52 PM
kcc committed rL360213: [libFuzzer] extend the data flow tracer to also produce basic block coverage….
[libFuzzer] extend the data flow tracer to also produce basic block coverage…
May 7 2019, 5:49 PM
kcc committed rCRT360213: [libFuzzer] extend the data flow tracer to also produce basic block coverage….
[libFuzzer] extend the data flow tracer to also produce basic block coverage…
May 7 2019, 5:48 PM
kcc committed rGa27a0914d343: [libFuzzer] disable two tests on i386 that are causing timeouts on the bots (authored by kcc).
[libFuzzer] disable two tests on i386 that are causing timeouts on the bots
May 7 2019, 5:42 PM
kcc committed rCRT360211: [libFuzzer] disable two tests on i386 that are causing timeouts on the bots.
[libFuzzer] disable two tests on i386 that are causing timeouts on the bots
May 7 2019, 5:41 PM
kcc committed rL360211: [libFuzzer] disable two tests on i386 that are causing timeouts on the bots.
[libFuzzer] disable two tests on i386 that are causing timeouts on the bots
May 7 2019, 5:41 PM
kcc committed rGb9c57683026e: revert r360162 as it breaks most of the buildbots (authored by kcc).
revert r360162 as it breaks most of the buildbots
May 7 2019, 1:56 PM
kcc added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

reverted in r360190.

May 7 2019, 1:55 PM · debug-info, Restricted Project
kcc committed rL360190: revert r360162 as it breaks most of the buildbots.
revert r360162 as it breaks most of the buildbots
May 7 2019, 1:54 PM
kcc added a comment to D60831: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion.

This change broke most of the buildbots:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/32015/steps/check-llvm%20asan/logs/stdio
lib/CodeGen/LexicalScopes.cpp:176: llvm::LexicalScope *llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope *): Assertion `cast<DISubprogram>(Scope)->describes(&MF->getFunction())' failed.

May 7 2019, 1:49 PM · debug-info, Restricted Project

May 6 2019

kcc added a reviewer for D56672: [HWASAN] Instrument globals: hctim.
May 6 2019, 6:30 PM

May 1 2019

kcc accepted D61168: [sanitizer] NFC:Get type of LargeMmapAllocator from PrimaryAllocator.
May 1 2019, 10:41 AM · Restricted Project, Restricted Project
kcc accepted D61155: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator.
May 1 2019, 10:41 AM · Restricted Project, Restricted Project

Apr 30 2019

kcc accepted D61353: [libFuzzer] Fix failing test: sigint.test.
Apr 30 2019, 4:40 PM · Restricted Project, Restricted Project
kcc committed rG905e60c422fe: [libFuzzer] temporarily disable a test on windows, where there is no memmem in… (authored by kcc).
[libFuzzer] temporarily disable a test on windows, where there is no memmem in…
Apr 30 2019, 3:27 PM
kcc committed rL359624: [libFuzzer] temporarily disable a test on windows, where there is no memmem in….
[libFuzzer] temporarily disable a test on windows, where there is no memmem in…
Apr 30 2019, 3:27 PM
kcc committed rCRT359624: [libFuzzer] temporarily disable a test on windows, where there is no memmem in….
[libFuzzer] temporarily disable a test on windows, where there is no memmem in…
Apr 30 2019, 3:27 PM
kcc committed rGc239eda8a0e2: [libFuzzer] add MagicSeparatorTest (authored by kcc).
[libFuzzer] add MagicSeparatorTest
Apr 30 2019, 3:07 PM
kcc committed rCRT359620: [libFuzzer] add MagicSeparatorTest.
[libFuzzer] add MagicSeparatorTest
Apr 30 2019, 3:07 PM
kcc committed rL359620: [libFuzzer] add MagicSeparatorTest.
[libFuzzer] add MagicSeparatorTest
Apr 30 2019, 3:06 PM