User Details
- User Since
- Oct 3 2012, 4:55 AM (546 w, 3 d)
Oct 10 2022
LGTM, thanks!
I spotted a typo
thanks! :)
Oct 7 2022
Oct 5 2022
Sep 14 2022
LGTM
Sep 13 2022
Sep 1 2022
Cool!
please add the documentation and the run-time test to the same CL.
Aug 24 2022
not arguing for or against, but I wonder how many output parsers will break.
Aug 10 2022
dropping the function name is fine, we have it from the stack traces.
the variable name can't be found anywhere else because in most cases
msan is used with -gline-tables-only, i.e. DWARF doesn't have the names of locals.
Where can I get the name of the variable? (I think it is buried in the debug info some place, but I would need an example to help me extract it.)
An alternative I thought of was putting this behind a flag.
please show an error message on a non-trivial test case
(lots of variables, some defined on the same line) before and after.
Code size is important, but we cannot decrease the report quality
Aug 2 2022
Jul 14 2022
needed to add the same callbacks in more places.
Now the tests pass.
Jun 30 2022
Jun 29 2022
removed unneeded (void)CBRes;
Jun 28 2022
Nov 22 2021
LGTM, but please wait for Vitaly
Nov 19 2021
Nov 9 2021
addressed review comments
Nov 8 2021
Sep 21 2021
Sep 20 2021
Sep 1 2021
Aug 24 2021
Aug 20 2021
one more test fix (can't expect xxd to be present)
fix a test
Aug 19 2021
fix dfsan build
Aug 18 2021
What's the code size implications?
Aug 4 2021
limit the test to x86_64 linux as it is too experimental to be used elsewhere,
and __libfuzzer_extra_counters are linux-only anyway, currently.
fixing incomplete fix, sorry
addressed one more review comment
addressed review comments
Aug 3 2021
One comment that I have is a request to limit the number of #ifdefs in the code to at most one.
We typically achieve this by having platform-specific code in a platform-specific file, guarded with an ifdef.
Aug 2 2021
Jul 15 2021
LGTM
Jul 12 2021
Thanks for the change!
Indeed, the current single-pass merge is far from perfect, and it's nice to see your numbers.
Jun 17 2021
Yey, great idea! :)
(I am not reviewing the code; but the change looks straightforward)
Jun 7 2021
+Vitaly Buka <vitalybuka@google.com> +Matt Morehouse <mascasa@google.com>
Mar 2 2021
We can't possibly maintain two variants of scudo.
All effort is currently spent on the newer (standalone) version.
I am afraid we will have to delete the older (non-standalone) variant entirely.
(And the sooner the better)
Feb 24 2021
ugh..
If I were the maintainer of this file, I would run away from this change.
Not because there is something wrong with it functionality-wise, but because of the ifdefs :(
We ourselves in the sanitizer land would reject a change with this many ifdefs w/o looking further.
Feb 17 2021
(2 bytes per bit!)
1 byte per bit, hopefully. (for the new 8-bit mode only)
Why not?
DFSan is a separate ABI, you can't mix DFSan-ified code with non-DFSan-ified code.
There is no annotation that we can imagine to work in this case.
DFSan's metadata is per-byte, if we mix different taints in a single byte (8 packet bits) we get an overtaint, i.e. a false positive.
The only other solution for our users is to not use vector<bool>
Feb 11 2021
LGTM, thanks for the better fix!
Feb 8 2021
yea, I am afraid that removing -O1 weakens our ability to find subtle bugs in how sanitizers work with the optimized code.
After all, most of the uses for the sanitizers are with -O1 and higher, so by testing with -O0 we are hiding potential problems.
I think the best is to prevent inlining (noinline attribute, or a command line if available)
Jan 11 2021
I am reluctant to extend the public interface in ways that
a) are likely to be useful for only few cases
b) are likely to remain libFuzzer-specific
c) already have an existing functionality that can be used instead). I mean the existing -dict flag (it's not exactly what you describe though)
Dec 4 2020
This header is intentionally private, so that the fuzz targets remain engine-neutral.
Dec 2 2020
This worked for us for many years.
Changing the default is likely to break some of the existing users.
Nov 3 2020
did you consider approaches where the emitted code doesn't change, but the binary contains a debug-like metadata that corresponds to the trap instructions?
Matt (CC-ed) has a patch if this kind (for a different purpose) in the works .
Oct 20 2020
LGTM, thanks!
Oct 19 2020
But I'm not sure how best to integrate this -- are there existing crashing tests somewhere I should add this to?
compiler-rt/test/fuzzer
please no #ifdefs.
please add a test.
Oct 16 2020
Sep 23 2020
a drive-by comment -- I would really appreciate *not* adding any new uses of C preprocessor.
Sep 2 2020
Aug 17 2020
+Matt
Aug 14 2020
Would it be possible to add a threaded test that fails w/o this change?
LGTM otherwise, thanks!
Aug 11 2020
Aug 10 2020
would it be acceptable to have an environment variable or launch parameter that could allow the silent creation of these directories?
Aug 6 2020
O, wow, thanks for catching this.
Could you please add a test (in compiler-rt/test/fuzzer) that would reliably fail currently
and reliably pass with this change?
Aug 4 2020
From the description:
this PR adds automatic directory creation for locations in which libFuzzer expects to write data.
I'd rather fail instead of silently creating new dirs, to be consistent with the other behavior
Please fix two nits, then good to go.
Thanks!