Page MenuHomePhabricator

kcc (Kostya Serebryany)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2012, 4:55 AM (341 w, 3 d)

Recent Activity

Thu, Apr 18

kcc committed rG14ada6d1ad8d: [libFuzzer] revert part of r358726 committed by mistake (oops) (authored by kcc).
[libFuzzer] revert part of r358726 committed by mistake (oops)
Thu, Apr 18, 6:40 PM
kcc committed rCRT358727: [libFuzzer] revert part of r358726 committed by mistake (oops).
[libFuzzer] revert part of r358726 committed by mistake (oops)
Thu, Apr 18, 6:40 PM
kcc committed rL358727: [libFuzzer] revert part of r358726 committed by mistake (oops).
[libFuzzer] revert part of r358726 committed by mistake (oops)
Thu, Apr 18, 6:40 PM
kcc committed rGbbb8522bdeff: [libFuzzer] in fork mode, make sure the child stats are always collected. This… (authored by kcc).
[libFuzzer] in fork mode, make sure the child stats are always collected. This…
Thu, Apr 18, 6:40 PM
kcc committed rL358726: [libFuzzer] in fork mode, make sure the child stats are always collected. This….
[libFuzzer] in fork mode, make sure the child stats are always collected. This…
Thu, Apr 18, 6:39 PM
kcc committed rCRT358726: [libFuzzer] in fork mode, make sure the child stats are always collected. This….
[libFuzzer] in fork mode, make sure the child stats are always collected. This…
Thu, Apr 18, 6:39 PM

Wed, Apr 17

kcc added a reviewer for D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 47-bit VMA : vitalybuka.

sorry for delay.
Vitaly, can you give a recommendation on how to avoid #ifdefs and avoid too much code duplication in this case.

Wed, Apr 17, 6:20 PM · Restricted Project

Fri, Apr 12

kcc committed rG5e67abd91f40: [libFuzzer] speedup the merge step in the fork mode by merging only the files… (authored by kcc).
[libFuzzer] speedup the merge step in the fork mode by merging only the files…
Fri, Apr 12, 6:57 PM
kcc committed rL358320: [libFuzzer] speedup the merge step in the fork mode by merging only the files….
[libFuzzer] speedup the merge step in the fork mode by merging only the files…
Fri, Apr 12, 6:56 PM
kcc committed rCRT358320: [libFuzzer] speedup the merge step in the fork mode by merging only the files….
[libFuzzer] speedup the merge step in the fork mode by merging only the files…
Fri, Apr 12, 6:56 PM
kcc committed rG4614cc3dfd2b: [libFuzzer] add -features_dir= flag to dump unique input features on disk (authored by kcc).
[libFuzzer] add -features_dir= flag to dump unique input features on disk
Fri, Apr 12, 5:19 PM
kcc committed rL358317: [libFuzzer] add -features_dir= flag to dump unique input features on disk.
[libFuzzer] add -features_dir= flag to dump unique input features on disk
Fri, Apr 12, 5:19 PM
kcc committed rCRT358317: [libFuzzer] add -features_dir= flag to dump unique input features on disk.
[libFuzzer] add -features_dir= flag to dump unique input features on disk
Fri, Apr 12, 5:19 PM
kcc accepted D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

LGTM++

Fri, Apr 12, 1:32 PM · Restricted Project, Restricted Project
kcc committed rG65132e211814: [libFuzzer] support -runs=N in the fork mode. Make sure we see one-line reports… (authored by kcc).
[libFuzzer] support -runs=N in the fork mode. Make sure we see one-line reports…
Fri, Apr 12, 1:23 PM
kcc committed rCRT358306: [libFuzzer] support -runs=N in the fork mode. Make sure we see one-line reports….
[libFuzzer] support -runs=N in the fork mode. Make sure we see one-line reports…
Fri, Apr 12, 1:22 PM
kcc committed rL358306: [libFuzzer] support -runs=N in the fork mode. Make sure we see one-line reports….
[libFuzzer] support -runs=N in the fork mode. Make sure we see one-line reports…
Fri, Apr 12, 1:22 PM
kcc added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

Code LGTM, but please also add a test that would fail with current code and pass with your change.
Either extend test/fuzzer/dataflow.test or add another one nearby.

Fri, Apr 12, 12:26 PM · Restricted Project, Restricted Project

Thu, Apr 11

kcc added inline comments to D60589: [sanitizer_common] Expose a variadic version of the sanitizer Printf function..
Thu, Apr 11, 5:41 PM · Restricted Project, Restricted Project
kcc accepted D60571: [libFuzzer] Make MutateWithMask work when the Mask is shorter than the input..
Thu, Apr 11, 11:15 AM · Restricted Project, Restricted Project
kcc accepted D60567: [libFuzzer] Fallback to default Mutate when MutateWithMask fails..
Thu, Apr 11, 9:14 AM · Restricted Project, Restricted Project

Wed, Apr 10

kcc added a comment to D60538: [libFuzzer] Fix DataFlow.cpp logic when tracing long inputs..

I don't think this is right. This subprocess is *expected* to fail with exactly this message when we run out of labels,
and then we handle the input as two subsets, and so on.
But this error must not happen if the range is >= 2 (two labels should not cause this error), so the process converges.
We can not predict when we run out of labels -- for some 8k inputs it will work from the first attempt,
for some much smaller inputs it will require several bisections.

Wed, Apr 10, 4:49 PM · Restricted Project, Restricted Project

Mon, Apr 8

kcc added a comment to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 47-bit VMA .

Hm... But this is so much code duplication... Can we have few #ifdefs but also not too much duplication?

Mon, Apr 8, 1:19 PM · Restricted Project

Fri, Apr 5

kcc added a reviewer for D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 47-bit VMA : eugenis.

Please don't use this many #ifdefs.
If should not need more than one ifdef for this patch,
Split the logic into separate files, when needed.

Fri, Apr 5, 4:51 PM · Restricted Project
kcc added a reviewer for D60334: Summary: Add close_fd_mask functionality to AFL driver.: morehouse.
Fri, Apr 5, 12:38 PM · Restricted Project, Restricted Project

Mar 18 2019

kcc committed rG9aac4c1be3c4: [libFuzzer] document -len_control (authored by kcc).
[libFuzzer] document -len_control
Mar 18 2019, 3:22 PM
kcc committed rL356422: [libFuzzer] document -len_control.
[libFuzzer] document -len_control
Mar 18 2019, 3:22 PM

Mar 11 2019

kcc added a reviewer for D59220: [asan] Add options -asan-detect-invalid-pointer-cmp and -asan-detect-invalid-pointer-sub options.: morehouse.
Mar 11 2019, 6:04 PM · Restricted Project

Feb 28 2019

kcc added a comment to D58117: Workaround std::thread begin not copy-constructible.
  1. I am not sure what problem does it solve. Everything seems to work.
  2. We can now safely remove fuzzer_allocator and rename Vector to just plain std::vector. (we don't need this monstrosity any more since we are using private STL now)
Feb 28 2019, 8:49 PM · Restricted Project, Restricted Project

Feb 27 2019

kcc added a reviewer for D58740: [sancov] Instrument reachable blocks that end in unreachable: morehouse.
Feb 27 2019, 5:36 PM · Restricted Project
kcc added a comment to D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.

Reid has a good point, and it equally applies to the current code, which doesn't instrument unreachable blocks.

Feb 27 2019, 1:16 PM · Restricted Project

Feb 25 2019

kcc added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Feb 25 2019, 6:23 PM · Restricted Project, Restricted Project

Feb 21 2019

kcc added a reviewer for D58513: [libFuzzer][Windows] Port fork mode to Windows: zturner.

Test change LGTM.
I don't know much about Windows, so will rely on Zach's os someone else's review.

Feb 21 2019, 9:54 AM · Restricted Project, Restricted Project

Feb 20 2019

kcc committed rG2ea42b3bebea: [libFuzzer] fix the docs (authored by kcc).
[libFuzzer] fix the docs
Feb 20 2019, 4:43 PM
kcc committed rL354536: [libFuzzer] fix the docs.
[libFuzzer] fix the docs
Feb 20 2019, 4:43 PM
kcc committed rG9c9a8a96d367: [libFuzzer] document -fork=N (authored by kcc).
[libFuzzer] document -fork=N
Feb 20 2019, 4:35 PM
kcc committed rL354533: [libFuzzer] document -fork=N.
[libFuzzer] document -fork=N
Feb 20 2019, 4:32 PM

Feb 19 2019

kcc committed rGbf223e9d59f4: [libFuzzer] docs: add a FAQ entry about dlclose (authored by kcc).
[libFuzzer] docs: add a FAQ entry about dlclose
Feb 19 2019, 2:12 PM
kcc committed rL354392: [libFuzzer] docs: add a FAQ entry about dlclose.
[libFuzzer] docs: add a FAQ entry about dlclose
Feb 19 2019, 2:11 PM
kcc committed rG64c7b060bc59: [sanitizers] add a regression test for the bug fixed in r354366 (authored by kcc).
[sanitizers] add a regression test for the bug fixed in r354366
Feb 19 2019, 11:28 AM
kcc committed rL354373: [sanitizers] add a regression test for the bug fixed in r354366.
[sanitizers] add a regression test for the bug fixed in r354366
Feb 19 2019, 11:27 AM
kcc committed rCRT354373: [sanitizers] add a regression test for the bug fixed in r354366.
[sanitizers] add a regression test for the bug fixed in r354366
Feb 19 2019, 11:27 AM
kcc committed rG6bde702ac966: [sanitizer] fix a memory safety bug (!!!) in sanitizer suppressions code… (authored by kcc).
[sanitizer] fix a memory safety bug (!!!) in sanitizer suppressions code…
Feb 19 2019, 10:46 AM
kcc committed rL354366: [sanitizer] fix a memory safety bug (!!!) in sanitizer suppressions code….
[sanitizer] fix a memory safety bug (!!!) in sanitizer suppressions code…
Feb 19 2019, 10:45 AM
kcc committed rCRT354366: [sanitizer] fix a memory safety bug (!!!) in sanitizer suppressions code….
[sanitizer] fix a memory safety bug (!!!) in sanitizer suppressions code…
Feb 19 2019, 10:45 AM

Feb 15 2019

kcc committed rGb6ca1e72594a: [libFuzzer] make len_control less agressive: set the initial max len to the… (authored by kcc).
[libFuzzer] make len_control less agressive: set the initial max len to the…
Feb 15 2019, 5:27 PM
kcc committed rL354191: [libFuzzer] make len_control less agressive: set the initial max len to the….
[libFuzzer] make len_control less agressive: set the initial max len to the…
Feb 15 2019, 5:26 PM
kcc committed rCRT354191: [libFuzzer] make len_control less agressive: set the initial max len to the….
[libFuzzer] make len_control less agressive: set the initial max len to the…
Feb 15 2019, 5:26 PM
kcc committed rG312af158b0b8: [libFuzzer] fork mode: try harder to cleanup after itself (authored by kcc).
[libFuzzer] fork mode: try harder to cleanup after itself
Feb 15 2019, 4:16 PM
kcc committed rCRT354186: [libFuzzer] fork mode: try harder to cleanup after itself.
[libFuzzer] fork mode: try harder to cleanup after itself
Feb 15 2019, 4:16 PM
kcc committed rL354186: [libFuzzer] fork mode: try harder to cleanup after itself.
[libFuzzer] fork mode: try harder to cleanup after itself
Feb 15 2019, 4:16 PM
kcc committed rG9982ee5472f8: [libFuzzer] form mode: add -ignore_crashes flag, honor the max_total_time flag… (authored by kcc).
[libFuzzer] form mode: add -ignore_crashes flag, honor the max_total_time flag…
Feb 15 2019, 1:53 PM
kcc committed rCRT354175: [libFuzzer] form mode: add -ignore_crashes flag, honor the max_total_time flag….
[libFuzzer] form mode: add -ignore_crashes flag, honor the max_total_time flag…
Feb 15 2019, 1:52 PM
kcc committed rL354175: [libFuzzer] form mode: add -ignore_crashes flag, honor the max_total_time flag….
[libFuzzer] form mode: add -ignore_crashes flag, honor the max_total_time flag…
Feb 15 2019, 1:52 PM

Feb 14 2019

kcc committed rG77cbc62544cd: [libFuzzer] print new functions as they are discovered in the fork mode (authored by kcc).
[libFuzzer] print new functions as they are discovered in the fork mode
Feb 14 2019, 5:22 PM
kcc committed rL354092: [libFuzzer] print new functions as they are discovered in the fork mode.
[libFuzzer] print new functions as they are discovered in the fork mode
Feb 14 2019, 5:22 PM
kcc committed rCRT354092: [libFuzzer] print new functions as they are discovered in the fork mode.
[libFuzzer] print new functions as they are discovered in the fork mode
Feb 14 2019, 5:22 PM
kcc committed rGb96b10d1a3c9: [libFuzzer] fix the unit tests (authored by kcc).
[libFuzzer] fix the unit tests
Feb 14 2019, 4:15 PM
kcc committed rL354088: [libFuzzer] fix the unit tests.
[libFuzzer] fix the unit tests
Feb 14 2019, 4:14 PM
kcc committed rCRT354088: [libFuzzer] fix the unit tests.
[libFuzzer] fix the unit tests
Feb 14 2019, 4:14 PM
kcc committed rG8c2791469dea: [libFuzzer] when doing the merge, keep track of the coveraged edges, not just… (authored by kcc).
[libFuzzer] when doing the merge, keep track of the coveraged edges, not just…
Feb 14 2019, 4:12 PM
kcc committed rL354087: [libFuzzer] when doing the merge, keep track of the coveraged edges, not just….
[libFuzzer] when doing the merge, keep track of the coveraged edges, not just…
Feb 14 2019, 4:12 PM
kcc committed rCRT354087: [libFuzzer] when doing the merge, keep track of the coveraged edges, not just….
[libFuzzer] when doing the merge, keep track of the coveraged edges, not just…
Feb 14 2019, 4:12 PM
kcc committed rG96f81bc679c6: [libFuzzer] when doing the merge, keep track of the coveraged edges, not just… (authored by kcc).
[libFuzzer] when doing the merge, keep track of the coveraged edges, not just…
Feb 14 2019, 3:12 PM
kcc committed rL354076: [libFuzzer] when doing the merge, keep track of the coveraged edges, not just….
[libFuzzer] when doing the merge, keep track of the coveraged edges, not just…
Feb 14 2019, 3:12 PM
kcc committed rCRT354076: [libFuzzer] when doing the merge, keep track of the coveraged edges, not just….
[libFuzzer] when doing the merge, keep track of the coveraged edges, not just…
Feb 14 2019, 3:12 PM
kcc committed rG8e918d6eadba: [libFuzzer] better stats for the fork mode (authored by kcc).
[libFuzzer] better stats for the fork mode
Feb 14 2019, 1:14 PM
kcc committed rL354061: [libFuzzer] better stats for the fork mode.
[libFuzzer] better stats for the fork mode
Feb 14 2019, 1:14 PM
kcc committed rCRT354061: [libFuzzer] better stats for the fork mode.
[libFuzzer] better stats for the fork mode
Feb 14 2019, 1:14 PM

Feb 13 2019

kcc committed rGdebf0af71db5: [libFuzzer] trying to fix the bot (can't reproduce the build failure locally) (authored by kcc).
[libFuzzer] trying to fix the bot (can't reproduce the build failure locally)
Feb 13 2019, 5:12 PM
kcc committed rL354000: [libFuzzer] trying to fix the bot (can't reproduce the build failure locally).
[libFuzzer] trying to fix the bot (can't reproduce the build failure locally)
Feb 13 2019, 5:11 PM
kcc committed rCRT354000: [libFuzzer] trying to fix the bot (can't reproduce the build failure locally).
[libFuzzer] trying to fix the bot (can't reproduce the build failure locally)
Feb 13 2019, 5:11 PM
kcc committed rG60c5ded2692d: [libFuzzer] add threads to the fork mode: now you can pass -fork=N to run N… (authored by kcc).
[libFuzzer] add threads to the fork mode: now you can pass -fork=N to run N…
Feb 13 2019, 4:26 PM
kcc committed rCRT353997: [libFuzzer] add threads to the fork mode: now you can pass -fork=N to run N….
[libFuzzer] add threads to the fork mode: now you can pass -fork=N to run N…
Feb 13 2019, 4:26 PM
kcc committed rL353997: [libFuzzer] add threads to the fork mode: now you can pass -fork=N to run N….
[libFuzzer] add threads to the fork mode: now you can pass -fork=N to run N…
Feb 13 2019, 4:25 PM
kcc accepted D58195: [HWASAN] Updated HWASAN design document to better portray the chance of missing a bug..

LGTM
and welcome back to the project! :)

Feb 13 2019, 2:23 PM · Restricted Project

Feb 12 2019

kcc committed rGd08574848419: [libFuzzer] a bit of refactoring of the fork mode (authored by kcc).
[libFuzzer] a bit of refactoring of the fork mode
Feb 12 2019, 8:05 PM
kcc committed rL353910: [libFuzzer] a bit of refactoring of the fork mode.
[libFuzzer] a bit of refactoring of the fork mode
Feb 12 2019, 8:04 PM
kcc committed rCRT353910: [libFuzzer] a bit of refactoring of the fork mode.
[libFuzzer] a bit of refactoring of the fork mode
Feb 12 2019, 8:04 PM
kcc committed rG5c08e811dec0: [libFuzzer] move the implementation of the fork mode into a separate file (authored by kcc).
[libFuzzer] move the implementation of the fork mode into a separate file
Feb 12 2019, 2:49 PM
kcc committed rCRT353891: [libFuzzer] move the implementation of the fork mode into a separate file.
[libFuzzer] move the implementation of the fork mode into a separate file
Feb 12 2019, 2:49 PM
kcc committed rL353891: [libFuzzer] move the implementation of the fork mode into a separate file.
[libFuzzer] move the implementation of the fork mode into a separate file
Feb 12 2019, 2:48 PM

Feb 11 2019

kcc committed rG2b9a8f37a484: [libFuzzer] make the fork mode less verbose (authored by kcc).
[libFuzzer] make the fork mode less verbose
Feb 11 2019, 7:14 PM
kcc committed rL353794: [libFuzzer] make the fork mode less verbose.
[libFuzzer] make the fork mode less verbose
Feb 11 2019, 7:12 PM
kcc committed rCRT353794: [libFuzzer] make the fork mode less verbose.
[libFuzzer] make the fork mode less verbose
Feb 11 2019, 7:12 PM
kcc committed rGcdbb9dc9625a: [libFuzzer] teach the fork mode to ignore OOMs and timeouts (authored by kcc).
[libFuzzer] teach the fork mode to ignore OOMs and timeouts
Feb 11 2019, 6:19 PM
kcc committed rL353792: [libFuzzer] teach the fork mode to ignore OOMs and timeouts.
[libFuzzer] teach the fork mode to ignore OOMs and timeouts
Feb 11 2019, 6:18 PM
kcc committed rCRT353792: [libFuzzer] teach the fork mode to ignore OOMs and timeouts.
[libFuzzer] teach the fork mode to ignore OOMs and timeouts
Feb 11 2019, 6:18 PM
kcc committed rG73bf6d5b3500: [libFuzzer] replace slow std::mt19937 with a much faster std::minstd_rand… (authored by kcc).
[libFuzzer] replace slow std::mt19937 with a much faster std::minstd_rand…
Feb 11 2019, 5:00 PM
kcc committed rCRT353782: [libFuzzer] replace slow std::mt19937 with a much faster std::minstd_rand….
[libFuzzer] replace slow std::mt19937 with a much faster std::minstd_rand…
Feb 11 2019, 5:00 PM
kcc committed rL353782: [libFuzzer] replace slow std::mt19937 with a much faster std::minstd_rand….
[libFuzzer] replace slow std::mt19937 with a much faster std::minstd_rand…
Feb 11 2019, 4:59 PM
kcc committed rG56b2d57cbf6b: [libFuzzer] simplify the code for print_coverage=1 so that it doesn't fail on… (authored by kcc).
[libFuzzer] simplify the code for print_coverage=1 so that it doesn't fail on…
Feb 11 2019, 4:54 PM
kcc committed rL353781: [libFuzzer] simplify the code for print_coverage=1 so that it doesn't fail on….
[libFuzzer] simplify the code for print_coverage=1 so that it doesn't fail on…
Feb 11 2019, 4:51 PM
kcc committed rCRT353781: [libFuzzer] simplify the code for print_coverage=1 so that it doesn't fail on….
[libFuzzer] simplify the code for print_coverage=1 so that it doesn't fail on…
Feb 11 2019, 4:51 PM
kcc committed rG8cc38effe2a3: [libFuzzer] run the -fork=1 tests only on linux (authored by kcc).
[libFuzzer] run the -fork=1 tests only on linux
Feb 11 2019, 4:30 PM
kcc accepted D58087: [libFuzzer] Make coverage.test work on ARM64.

LGTM

Feb 11 2019, 4:30 PM · Restricted Project, Restricted Project
kcc committed rL353777: [libFuzzer] run the -fork=1 tests only on linux.
[libFuzzer] run the -fork=1 tests only on linux
Feb 11 2019, 4:30 PM
kcc committed rCRT353777: [libFuzzer] run the -fork=1 tests only on linux.
[libFuzzer] run the -fork=1 tests only on linux
Feb 11 2019, 4:30 PM
kcc committed rG63f48717b58d: [libFuzzer] extend the -fork=1 functionality. Still not fully usable, but good… (authored by kcc).
[libFuzzer] extend the -fork=1 functionality. Still not fully usable, but good…
Feb 11 2019, 4:12 PM
kcc committed rL353775: [libFuzzer] extend the -fork=1 functionality. Still not fully usable, but good….
[libFuzzer] extend the -fork=1 functionality. Still not fully usable, but good…
Feb 11 2019, 4:12 PM