kcc (Kostya Serebryany)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2012, 4:55 AM (289 w, 5 d)

Recent Activity

Today

kcc accepted D45996: [HWASan] Update HWASan assembly snippet in the docs.

LGTM

Mon, Apr 23, 6:09 PM
kcc accepted D45950: Change kAllocatorSpace for powerpc64..

LGTM

Mon, Apr 23, 8:35 AM

Fri, Apr 20

kcc accepted D45744: [libFuzzer] Add experimental feature to not use AFL's deferred forkserver..

LGTM

Fri, Apr 20, 10:48 AM
kcc added a comment to D45744: [libFuzzer] Add experimental feature to not use AFL's deferred forkserver..

is this testable?

Fri, Apr 20, 10:07 AM
kcc accepted D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..

LGTM with a nit.

Fri, Apr 20, 8:21 AM

Thu, Apr 19

kcc added a comment to D45840: [HWASan] Introduce non-zero based and dynamic shadow memory (LLVM)..

plz don't forget to update the documentation (the asm snippet) at clang.llvm.org/docs/HardwareAssistedAddressSanitizerDesign.html

Thu, Apr 19, 5:01 PM

Wed, Apr 18

kcc accepted D45767: [LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test.

LGTM

Wed, Apr 18, 12:11 PM
kcc accepted D45765: [LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3..

LGTM

Wed, Apr 18, 12:10 PM
kcc added a comment to D45762: [LibFuzzer] Add support for an optional user defined callback (`LLVMFuzzerOnExitHandler()`).

Why is it not enough to cal atexit() in LLVMFuzzerInitialize?

Wed, Apr 18, 12:09 PM
kcc added a comment to D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..

Ok, sounds good.
Yes, please add a test that calls Mutate_CopyPart many times and always sees it return MaxSize

Wed, Apr 18, 12:08 PM
kcc added a comment to D45730: [libFuzzer] Add -detect_exits flag..

libFuzzer is in-process fuzzer, exit is not a libFuzzer-friendly thing.
I am reluctant to allow exits even under a flag -- it will discourage people from making their APIs more fuzzable.
For legacy code that nobody is willing to change we have the out-of-process AFL

Wed, Apr 18, 11:27 AM

Tue, Apr 17

kcc added a comment to D45730: [libFuzzer] Add -detect_exits flag..

why is this needed?

Tue, Apr 17, 9:11 PM

Mon, Apr 16

kcc added a reviewer for D45701: Add Logging API Callback for All *SAN Passes: vitalybuka.

Don't we already have something like this in another form?

Mon, Apr 16, 2:44 PM
kcc accepted D45693: [LibFuzzer] Tweak `MutationDispatcher::Mutate_CopyPart` mutation..

LGTM
I wonder how you can observe the change?
It's just a slight change in probabilities.
Or not slight?

Mon, Apr 16, 1:07 PM
kcc accepted D45675: [LibFuzzer] Report when custom counters are available..

LGTM

Mon, Apr 16, 1:07 PM

Fri, Apr 13

kcc added a comment to D45588: Start reserving x18 by default on Android targets..

Yep, that's the one, thanks!

Fri, Apr 13, 11:35 AM
kcc accepted D45605: Resize vector have does not work correctly.

LGTM, thanks!
Vitaly, please land.
This doesn't affect this review, but next time please upload patches with full context (the 'arc' tool is pretty good at it).

Fri, Apr 13, 11:12 AM
kcc added a comment to D45588: Start reserving x18 by default on Android targets..

This test is great, but I'd like to also see some more direct test, maybe something in tools/clang/test/Driver/aarch64-fixed-x18.c?

Fri, Apr 13, 11:07 AM

Thu, Apr 12

kcc added a comment to D45605: Resize vector have does not work correctly.

Hm... interesting. how did you find it? what does this affect now?
I think it should be fixed in Resize().
Also, please add a test here: lib/sanitizer_common/tests/sanitizer_vector_test.cc

Thu, Apr 12, 7:14 PM
kcc added a comment to D45588: Start reserving x18 by default on Android targets..

Don't you need a test?
srhines@, what kind of documentation change need to be done?

Thu, Apr 12, 5:18 PM

Tue, Apr 3

kcc added reviewers for D45235: [libFuzzer] Enable multi-architecture and multi-platform build for libFuzzer : vitalybuka, morehouse.
Tue, Apr 3, 4:02 PM

Tue, Mar 27

kcc added a reviewer for D44802: Add the ShadowCallStack pass: vitalybuka.

+Vitaly for another set of eyes.

Tue, Mar 27, 5:20 PM
kcc accepted D44800: Add the ShadowCallStack attribute.

LGTM with a nit

Tue, Mar 27, 5:17 PM
kcc accepted D44801: Add the -fsanitize=shadow-call-stack flag.

LGTM modulo prolog vs prlogue and epilog vs epilogue

Tue, Mar 27, 5:15 PM

Mar 22 2018

kcc added a comment to D44801: Add the -fsanitize=shadow-call-stack flag.

please also add a short comparison with Intel CET.

Mar 22 2018, 9:53 PM
kcc added a comment to D44801: Add the -fsanitize=shadow-call-stack flag.

[didn't look at the code yet, just at the docs]

Mar 22 2018, 9:50 PM

Mar 19 2018

kcc updated subscribers of D44360: [compiler-rt] Change std::sort to llvm::sort in response to r327219.

Also: this change has been committed w/o an approval from any of the
owners.
please try to avoid this in future.

Mar 19 2018, 7:46 PM
kcc added a reviewer for D44623: Fix asan on i?86-linux (32-bit) against glibc 2.27 and later: vitalybuka.

Is this related to https://github.com/google/sanitizers/issues/914 or this is another problem?
(also: https://sourceware.org/ml/libc-alpha/2018-02/msg00567.html)

Mar 19 2018, 6:34 PM · Restricted Project

Mar 13 2018

kcc committed rL327471: [hwasan] update docs.
[hwasan] update docs
Mar 13 2018, 7:00 PM
kcc committed rC327471: [hwasan] update docs.
[hwasan] update docs
Mar 13 2018, 7:00 PM

Feb 28 2018

kcc committed rC326373: [hwasan] update the asm snippet in the docs to match the current default….
[hwasan] update the asm snippet in the docs to match the current default…
Feb 28 2018, 2:00 PM
kcc committed rL326373: [hwasan] update the asm snippet in the docs to match the current default….
[hwasan] update the asm snippet in the docs to match the current default…
Feb 28 2018, 2:00 PM

Feb 23 2018

kcc added a comment to D43672: [libFuzzer] Adds experimental flag -ngram that changes the fuzzer fitness function.

I am indeed interested in experimenting with bounded path coverage, similar to this.
My prior experiments demonstrated some value but also huge corpus expansion (bad).
It might be worth submitting something like this to simplify further experiments.

Feb 23 2018, 3:10 PM

Feb 22 2018

kcc accepted D43597: [libFuzzer] Include TEMP_MAX_LEN in Fuzzer::PrintStats..

LGTM

Feb 22 2018, 10:57 AM

Feb 21 2018

kcc added a comment to D43597: [libFuzzer] Include TEMP_MAX_LEN in Fuzzer::PrintStats..

ouch. 10 is too magic.
I've seen hundreds of these printed in a row, i.e. 10 will be too small.
in other cases 10 will be to large.
I wonder if we want to print it as one more number in regular Fuzzer::PrintStats lines, e.g. "lim: 123", like here:
#3145 REDUCE cov: 6 ft: 7 corp: 5/9b lim: 123 exec/s: 0 rss: 37Mb

Feb 21 2018, 4:40 PM

Feb 20 2018

kcc added a comment to D43423: [SimplifyCFG] Create flag to disable simplifyCFG..

We use function attributes in similar situations for asan/tsan/msan.
Similar, but not equivalent, so I don't know if we must follow the same pattern here.
The difference here is that we should keep the ability to turn optimization on and off from command line, regardless of what are the coverage instrumentation flags.

Feb 20 2018, 11:38 AM

Feb 16 2018

kcc added a reviewer for D43423: [SimplifyCFG] Create flag to disable simplifyCFG.: vitalybuka.
Feb 16 2018, 4:50 PM

Feb 13 2018

kcc accepted D42932: [libFuzzer] Set -experimental_len_control=1000 as default..

LGTM

Feb 13 2018, 12:52 PM
kcc added a reviewer for D43135: hwasan: fix inline instrumentation: ramana.
Feb 13 2018, 9:48 AM

Feb 12 2018

kcc added a reviewer for D43213: [Fuzzer] Avoid the unnecessary rebuild of the custom libc++: morehouse.
Feb 12 2018, 4:07 PM

Feb 9 2018

kcc added a comment to D43135: hwasan: fix inline instrumentation.

please add a lit test.

Feb 9 2018, 11:15 AM

Feb 5 2018

kcc accepted D42941: [hwasan] Fix kernel instrumentation of stack..

LGTM with a nit

Feb 5 2018, 5:56 PM

Feb 2 2018

kcc accepted D42874: [hwasan] Add a paragraph on stack instrumentation..

LGTM++

Feb 2 2018, 5:07 PM

Jan 31 2018

kcc added a reviewer for D42644: [asan] Intercept std::rethrow_exception indirectly.: vitalybuka.
Jan 31 2018, 9:21 AM · Restricted Project

Jan 16 2018

kcc accepted D42141: [hwasan] LLVM-level flags for linux kernel-compatible hwasan instrumentation..

LGTM

Jan 16 2018, 4:42 PM
kcc added a comment to D41664: Remove test which assumed array cookies can't be poisoned when using an operator new defined in a class.

How about this:
A -fsanitize-address-poison-all-array-new or similar (it would be all *except* placement new... Haven't got a better name, though).
That way, a user would be able to poison more array-new operators than the current solution. But we wouldn't break any legal C++ code.

Jan 16 2018, 3:19 PM
kcc accepted D42138: [hwasan] Rename sized load/store callbacks to be consistent with ASan..

LGTM

Jan 16 2018, 3:15 PM
kcc accepted D42121: [hwasan] Build runtime library with -fPIC, not -fPIE..

LGTM

Jan 16 2018, 11:14 AM

Jan 12 2018

kcc added a comment to D41664: Remove test which assumed array cookies can't be poisoned when using an operator new defined in a class.

Technically it is. Just like overriding malloc,

Jan 12 2018, 12:41 PM

Jan 11 2018

kcc added inline comments to D41602: [hwasan] Stack instrumentation..
Jan 11 2018, 2:42 PM
kcc added a comment to D41664: Remove test which assumed array cookies can't be poisoned when using an operator new defined in a class.

Let me rephrase the question.
Is the code in new_array_cookie_with_new_from_class.cc a valid C++?
I.e. is the code allowed to access *reinterpret_cast<uintptr_t*>(Foo::allocated) at line 38?

Jan 11 2018, 12:59 PM
kcc added inline comments to D41602: [hwasan] Stack instrumentation..
Jan 11 2018, 12:29 PM
kcc accepted D41602: [hwasan] Stack instrumentation..

LGTM with two nits, feel free to address them separately.

Jan 11 2018, 12:28 PM

Jan 10 2018

kcc added a reviewer for D41642: lib Fuzzer FreeBSD support: morehouse.
Jan 10 2018, 12:58 PM
kcc added a comment to D41664: Remove test which assumed array cookies can't be poisoned when using an operator new defined in a class.

The original commit doesn't provide any rationale for this test,

Jan 10 2018, 11:37 AM
kcc accepted D41882: [hwasan] An option to disable tag randomization..

LGTM

Jan 10 2018, 11:18 AM

Dec 21 2017

kcc added a reviewer for D41479: Make detect_invalid_pointer_pairs option to be tristate.: alekseyshl.
Dec 21 2017, 9:00 AM
kcc added a reviewer for D41481: Small fixes for detect_invalid_pointer_pairs.: alekseyshl.
Dec 21 2017, 8:58 AM

Dec 20 2017

kcc accepted D41457: [libfuzzer] Fix UB when calculating Log(0) in StackDepthStepFunction()..

LGTM

Dec 20 2017, 11:10 AM

Dec 19 2017

kcc accepted D41417: [hwasan] Implement -fsanitize-recover=hwaddress..

LGTM with a nit

Dec 19 2017, 4:10 PM
kcc added a comment to D41243: [ASan] Add interceptros for fortified strcat, strncat, strcpy, strncpy..

I suggest to restart the discussion of this topic with the owners of fortify.
So far I am not convinced that we need/want this code in asan.

Dec 19 2017, 11:15 AM · Restricted Project
kcc added a comment to D41243: [ASan] Add interceptros for fortified strcat, strncat, strcpy, strncpy..

The discussion about asan+fortify has been going on for ages and I don't think we ever reached an agreement on how to proceed. Did we?

Dec 19 2017, 10:52 AM · Restricted Project

Dec 18 2017

kcc committed rC321027: [hwasan] update the design doc.
[hwasan] update the design doc
Dec 18 2017, 1:41 PM
kcc committed rL321027: [hwasan] update the design doc.
[hwasan] update the design doc
Dec 18 2017, 1:40 PM

Dec 14 2017

kcc committed rCRT320787: [libFuzzer] make the tests depend on ubsan.
[libFuzzer] make the tests depend on ubsan
Dec 14 2017, 5:40 PM
kcc committed rL320787: [libFuzzer] make the tests depend on ubsan.
[libFuzzer] make the tests depend on ubsan
Dec 14 2017, 5:40 PM

Dec 13 2017

kcc added a comment to D37631: [libFuzzer] Support using libc++.

So I finally ended up with something that works reliably with both libstdc++ and libc++. I plan on doing a bit more cleanup, but a question is what to do on Darwin and Windows. I'm relying on partial linking. That appears to be supported by ld64, but there doesn't seem be the --whole-archive option that we need as well (unless we upgrade CMake to 3.9). On Windows, I don't know if partial linking is supported at all. However, I also don't know if we even need this on Darwin and Windows rather than simply relying on the host C++ library?

Dec 13 2017, 3:43 PM
kcc accepted D41193: [libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver..

LGTM
Matt, please land

Dec 13 2017, 1:44 PM
kcc added a comment to D41164: Added a separate install target for compilert-rt-headers.

Aleksey, please review.
Please also remove samsonov@ from owners (he is not active in LLVM any more, AFAICT) and replace with yourself.

Dec 13 2017, 9:45 AM

Dec 12 2017

kcc committed rCRT320531: [libFuzzer] change the strategy for -experimental_len_control to grow max_len….
[libFuzzer] change the strategy for -experimental_len_control to grow max_len…
Dec 12 2017, 3:12 PM
kcc committed rL320531: [libFuzzer] change the strategy for -experimental_len_control to grow max_len….
[libFuzzer] change the strategy for -experimental_len_control to grow max_len…
Dec 12 2017, 3:12 PM
kcc accepted D41137: [hwasan] Inline instrumentation & fixed shadow..

LGTM with one optional question.

Dec 12 2017, 2:58 PM

Dec 9 2017

kcc committed rCRT320259: [libFuzzer] even less aggressive step function for stack depth. Also don't use….
[libFuzzer] even less aggressive step function for stack depth. Also don't use…
Dec 9 2017, 11:18 AM
kcc committed rL320259: [libFuzzer] even less aggressive step function for stack depth. Also don't use….
[libFuzzer] even less aggressive step function for stack depth. Also don't use…
Dec 9 2017, 11:18 AM

Dec 8 2017

kcc committed rCRT320237: [libFuzzer] make the stack depth signal less agressive, otherwise we are….
[libFuzzer] make the stack depth signal less agressive, otherwise we are…
Dec 8 2017, 6:46 PM
kcc committed rL320237: [libFuzzer] make the stack depth signal less agressive, otherwise we are….
[libFuzzer] make the stack depth signal less agressive, otherwise we are…
Dec 8 2017, 6:46 PM
kcc accepted D40935: Hardware-assisted AddressSanitizer (compiler-rt).

LGTM, let's iterate from here.

Dec 8 2017, 3:58 PM
kcc committed rCRT320205: [libFuzzer] honor -use_counters, sligntly change the meaning of….
[libFuzzer] honor -use_counters, sligntly change the meaning of…
Dec 8 2017, 2:22 PM
kcc committed rL320205: [libFuzzer] honor -use_counters, sligntly change the meaning of….
[libFuzzer] honor -use_counters, sligntly change the meaning of…
Dec 8 2017, 2:22 PM
kcc accepted D40974: [libFuzzer] Add support for Fuchsia OS.

Matt, please land.

Dec 8 2017, 1:46 PM
kcc added a comment to D40935: Hardware-assisted AddressSanitizer (compiler-rt).

My top level comment: can we delete all non-aarch64 code?
The arch owners can reinstate it if needed, but they will only need it if/when they have the TBI feature in HW.

Dec 8 2017, 10:37 AM
kcc committed rL320168: [hwasan] typo in docs.
[hwasan] typo in docs
Dec 8 2017, 10:14 AM
kcc committed rC320168: [hwasan] typo in docs.
[hwasan] typo in docs
Dec 8 2017, 10:14 AM

Dec 7 2017

kcc committed rL320075: update hwasan docs.
update hwasan docs
Dec 7 2017, 11:22 AM
kcc committed rC320075: update hwasan docs.
update hwasan docs
Dec 7 2017, 11:22 AM
kcc closed D40938: update hwasan docs by committing rC320075: update hwasan docs.
Dec 7 2017, 11:22 AM
kcc added a comment to D40932: Hardware-assisted AddressSanitizer (llvm part)..

LGTM, please wait for (at least) Aleksey's review.

Dec 7 2017, 11:21 AM
kcc added a comment to D40974: [libFuzzer] Add support for Fuchsia OS.

Common code LGTM

Dec 7 2017, 11:15 AM
kcc updated the diff for D40938: update hwasan docs.

mention https://www.kernel.org/doc/Documentation/arm64/tagged-pointers.txt

Dec 7 2017, 11:04 AM

Dec 6 2017

kcc added inline comments to D40935: Hardware-assisted AddressSanitizer (compiler-rt).
Dec 6 2017, 7:24 PM
kcc accepted D40936: Hardware-assisted AddressSanitizer (clang part)..

LGTM
please give at least Aleksey a chance to review as well.

Dec 6 2017, 7:20 PM
kcc created D40938: update hwasan docs.
Dec 6 2017, 6:28 PM
kcc added inline comments to D40932: Hardware-assisted AddressSanitizer (llvm part)..
Dec 6 2017, 6:11 PM
kcc added a comment to D40932: Hardware-assisted AddressSanitizer (llvm part)..

Please document the new attribute and explain why the old attribute doesn't work for us (there are cases when we need one, but not the other, in both directions)

Dec 6 2017, 5:06 PM
kcc committed rL319988: [libFuzzer] Decrease stack usage in unit tests.
[libFuzzer] Decrease stack usage in unit tests
Dec 6 2017, 3:35 PM
kcc committed rCRT319988: [libFuzzer] Decrease stack usage in unit tests.
[libFuzzer] Decrease stack usage in unit tests
Dec 6 2017, 3:35 PM
kcc closed D40926: [libFuzzer] Decrease stack usage in unit tests.
Dec 6 2017, 3:35 PM
kcc accepted D40926: [libFuzzer] Decrease stack usage in unit tests.

LGTM,
I'll land

Dec 6 2017, 3:33 PM
kcc committed rCRT319975: [libFuzzer] fix a minor regression in printing.
[libFuzzer] fix a minor regression in printing
Dec 6 2017, 2:13 PM
kcc committed rL319975: [libFuzzer] fix a minor regression in printing.
[libFuzzer] fix a minor regression in printing
Dec 6 2017, 2:13 PM