Page MenuHomePhabricator

erichkeane (Erich Keane)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 8:37 AM (259 w, 6 d)

Recent Activity

Today

erichkeane added a reverting change for rG501313187540: [SYCL][NFC] Ensure SYCL kernel for unique-stable-name is unqualified.: rGb3634d3e88b7: Revert "[SYCL][NFC] Ensure SYCL kernel for unique-stable-name is unqualified.".
Mon, Jun 21, 1:24 PM
erichkeane committed rGb3634d3e88b7: Revert "[SYCL][NFC] Ensure SYCL kernel for unique-stable-name is unqualified." (authored by erichkeane).
Revert "[SYCL][NFC] Ensure SYCL kernel for unique-stable-name is unqualified."
Mon, Jun 21, 1:24 PM
erichkeane committed rG501313187540: [SYCL][NFC] Ensure SYCL kernel for unique-stable-name is unqualified. (authored by erichkeane).
[SYCL][NFC] Ensure SYCL kernel for unique-stable-name is unqualified.
Mon, Jun 21, 12:51 PM

Thu, Jun 17

erichkeane accepted D104424: [Sema] Fix for PR50741.

Yep, that works, still approved.

Thu, Jun 17, 7:15 AM · Restricted Project

Wed, Jun 16

erichkeane accepted D104424: [Sema] Fix for PR50741.

Two small changes to the test that you can do as a part of committing. Thanks!

Wed, Jun 16, 4:46 PM · Restricted Project
erichkeane added a comment to D98895: [X86][Draft] Disable long double type for -mno-x87 option.

This seems to do a lot of work that I think already exists, I believe I've seen that SPIRV targets already prohibit long-double, so doing another implementation specifically for x86 seems like the wrong approach. I'd suggest seeing if the SPIRV version works for these. If it doesn't, I'd prefer you generalize that implementation.

Wed, Jun 16, 8:44 AM · Restricted Project

Tue, Jun 15

erichkeane added inline comments to rGce44fe199bbf: [Sema] Address-space sensitive check for unbounded arrays (v2).
Tue, Jun 15, 5:15 PM
erichkeane added inline comments to rGce44fe199bbf: [Sema] Address-space sensitive check for unbounded arrays (v2).
Tue, Jun 15, 5:12 PM
erichkeane accepted D102478: [Matrix] Emit assumption that matrix indices are valid..
Tue, Jun 15, 6:20 AM · Restricted Project, Restricted Project

Mon, Jun 14

erichkeane added a comment to D102478: [Matrix] Emit assumption that matrix indices are valid..

Just a couple of nits here, basically see how much we can put in the 'cheap to check' branch.

Mon, Jun 14, 12:43 PM · Restricted Project, Restricted Project

Wed, Jun 2

erichkeane committed rGd8e0ae9a76a6: [SYCL] Fix __builtin_sycl_unique_stable_name to work on windows/spir (authored by erichkeane).
[SYCL] Fix __builtin_sycl_unique_stable_name to work on windows/spir
Wed, Jun 2, 1:16 PM
erichkeane committed rG8beaca8c1493: Remove unused function from a previous iteration of unique-stable-name (authored by erichkeane).
Remove unused function from a previous iteration of unique-stable-name
Wed, Jun 2, 12:15 PM

Tue, Jun 1

erichkeane accepted D103485: Fix a diagnoses-valid bug with using declarations.

Ah! Thats what I missed!

Tue, Jun 1, 12:59 PM · Restricted Project
erichkeane added a comment to D103485: Fix a diagnoses-valid bug with using declarations.

The patch looks fine to me, though I don't particularly get the test changes that move a diagnostic by 1 line?

Tue, Jun 1, 12:54 PM · Restricted Project

Thu, May 27

erichkeane committed rGcb66bf2c6d20: Replace 'magic static' with a member variable for SCYL kernel names (authored by erichkeane).
Replace 'magic static' with a member variable for SCYL kernel names
Thu, May 27, 1:47 PM
erichkeane committed rG023fbf3df32d: Correct the 'KEYALL' mask. (authored by erichkeane).
Correct the 'KEYALL' mask.
Thu, May 27, 7:21 AM
erichkeane committed rGeba69b59d1a3: Reimplement __builtin_unique_stable_name- (authored by erichkeane).
Reimplement __builtin_unique_stable_name-
Thu, May 27, 7:12 AM
erichkeane closed D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.
Thu, May 27, 7:12 AM · Restricted Project
erichkeane added inline comments to D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.
Thu, May 27, 6:25 AM · Restricted Project
erichkeane added inline comments to D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.
Thu, May 27, 6:06 AM · Restricted Project

Wed, May 26

erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Apply clang-format patch, except for the changes to IdentifierTable.

Wed, May 26, 6:51 PM · Restricted Project
erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Ok, this should get me up to date! Fixed a bunch of the comments referring to 'expression', added LangOpts::isSYCL, and changed it to DiscriminatorOverride.

Wed, May 26, 4:37 PM · Restricted Project
erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Woops! Last update was JUST the changes, and I forgot to squash. Here is the whole patch.

Wed, May 26, 3:14 PM · Restricted Project
erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Replace the DeviceLambdaManglingNumber mechanism with the callback mechanism.

Wed, May 26, 3:12 PM · Restricted Project
erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Remove 'expression' form per suggestion. Still need to do the device-mangling-number removal/rewrite business.

Wed, May 26, 12:54 PM · Restricted Project
erichkeane added inline comments to D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.
Wed, May 26, 11:45 AM · Restricted Project
erichkeane added inline comments to D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.
Wed, May 26, 11:16 AM · Restricted Project
erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Fix comments from aaron.

Wed, May 26, 11:16 AM · Restricted Project
erichkeane accepted D103157: Disable misc-no-recursion checking in Clang.

I like this, since the entire CFE does a ton of recursion on purpose for all AST related things. Please give others time to disagree however :)

Wed, May 26, 11:00 AM · Restricted Project
erichkeane retitled D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name from Reimplement __builtin_unique_stable_name- to Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.
Wed, May 26, 9:21 AM · Restricted Project
erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Do all the things requested by @aaron.ballman and @rjmccall except for limiting the syntax to 'types only'. Currently evaluating whether this is something we can accept.

Wed, May 26, 9:20 AM · Restricted Project

Tue, May 25

erichkeane updated the diff for D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.

Apply the clang-format patch from CI, also apply the unused variable fix clang-tidy suggested. The rest of the issues in clang-tidy are identifying functions in a recursive call-chain, but they are all part of the various visitors, so I don't think I have a way to fix those.

Tue, May 25, 3:27 PM · Restricted Project
erichkeane requested review of D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name.
Tue, May 25, 1:32 PM · Restricted Project
erichkeane added inline comments to D102871: Compiler crashing when compiling coroutine intrinsics without the fcoroutines-ts option..
Tue, May 25, 7:47 AM
erichkeane added a comment to D102871: Compiler crashing when compiling coroutine intrinsics without the fcoroutines-ts option..

No real feedback, however I note that the bug link you have is one that was resolved in 2009, so I suspect it is completely unrelated.

Tue, May 25, 7:45 AM

May 21 2021

erichkeane added inline comments to D102663: Bug 49633 - Added warning for static inline global and namespaced declarations.
May 21 2021, 5:55 AM · Restricted Project

May 12 2021

erichkeane committed rG08ba9ce1ef72: Suppress Deferred Diagnostics in discarded statements. (authored by erichkeane).
Suppress Deferred Diagnostics in discarded statements.
May 12 2021, 12:49 PM
erichkeane closed D102251: Suppress Deferred Diagnostics in discarded statements..
May 12 2021, 12:49 PM · Restricted Project
erichkeane added inline comments to D102251: Suppress Deferred Diagnostics in discarded statements..
May 12 2021, 12:08 PM · Restricted Project
erichkeane updated the diff for D102251: Suppress Deferred Diagnostics in discarded statements..

Moved IfStmt/discarded case logic to ExprEvaluatorBase per @rsmith 's suggestion. This is the 'highest' in the tree that has a Sema/ASTContext reference, so anything 'higher' in the tree would be higher touch. @rsmith: WDYT?

May 12 2021, 7:08 AM · Restricted Project
erichkeane added inline comments to D102251: Suppress Deferred Diagnostics in discarded statements..
May 12 2021, 6:11 AM · Restricted Project

May 11 2021

erichkeane added a comment to D102261: Introduce SYCL 2020 mode.

The Ver in Ver2020 is redundant ::2020 would suffice.

May 11 2021, 12:35 PM · Restricted Project
erichkeane added a comment to D102261: Introduce SYCL 2020 mode.

But there is no SYCLMinorVersion today. So enum class SYCLVersion would suffice.

May 11 2021, 12:29 PM · Restricted Project
erichkeane added a comment to D102261: Introduce SYCL 2020 mode.

LGTM, but want others to look first.

May 11 2021, 11:00 AM · Restricted Project
erichkeane added a comment to D102251: Suppress Deferred Diagnostics in discarded statements..

LG

May 11 2021, 10:27 AM · Restricted Project
erichkeane added inline comments to D102251: Suppress Deferred Diagnostics in discarded statements..
May 11 2021, 9:58 AM · Restricted Project
erichkeane requested review of D102251: Suppress Deferred Diagnostics in discarded statements..
May 11 2021, 9:35 AM · Restricted Project

Apr 30 2021

erichkeane added reviewers for D101341: Initialize optional members of ELFYAML types.: rahmanl, jhenderson, MaskRay.
Apr 30 2021, 9:38 AM · Restricted Project
erichkeane added reviewers for D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls: rnk, rjmccall, lebedev.ri.
Apr 30 2021, 8:22 AM · Restricted Project, Restricted Project

Apr 27 2021

erichkeane added inline comments to D70340: Add a key method to Sema to optimize debug info size.
Apr 27 2021, 5:54 AM · Restricted Project

Apr 23 2021

erichkeane added a comment to D101192: Add support for #elifdef and #elifndef.

I have one 'nit of preference', otherwise I think I don't want to +1 this without giving people a few days to take a look. Based on my looks through the surrounding code, this _LOOKS_ right enough as far as I can tell, but I still want to give others a few days.

Apr 23 2021, 1:59 PM · Restricted Project
erichkeane added a comment to D70340: Add a key method to Sema to optimize debug info size.

I guess my point is: a better comment would have saved me some time. Basically point out that the 'debug' info for the whole type is emitted with a virtual method, and that non-virtual types have it emitted in every TU. Also that this causes it to be emitted in only 1 place, since now there is only a single virtual method definition in a single TU.

Apr 23 2021, 1:38 PM · Restricted Project
erichkeane added inline comments to D101192: Add support for #elifdef and #elifndef.
Apr 23 2021, 12:41 PM · Restricted Project
erichkeane added inline comments to D101192: Add support for #elifdef and #elifndef.
Apr 23 2021, 12:30 PM · Restricted Project

Apr 20 2021

erichkeane committed rG0ed613612c5d: Ensure target-multiversioning emits deferred declarations (authored by erichkeane).
Ensure target-multiversioning emits deferred declarations
Apr 20 2021, 8:10 AM

Apr 14 2021

erichkeane committed rG92aba5ae49a6: CPUDispatch- allow out of line member definitions (authored by erichkeane).
CPUDispatch- allow out of line member definitions
Apr 14 2021, 6:20 AM

Apr 7 2021

erichkeane committed rG7d8513b7f2e9: [clang] Move int <-> float scalar conversion to a separate function (authored by SaurabhJha).
[clang] Move int <-> float scalar conversion to a separate function
Apr 7 2021, 12:34 PM
erichkeane closed D100051: [clang] Move int <-> float scalar conversion to a separate function.
Apr 7 2021, 12:34 PM · Restricted Project
erichkeane added a comment to D100051: [clang] Move int <-> float scalar conversion to a separate function.

Alright, validating it now, then I'll push.

Apr 7 2021, 12:11 PM · Restricted Project
erichkeane accepted D100051: [clang] Move int <-> float scalar conversion to a separate function.
Apr 7 2021, 11:44 AM · Restricted Project
erichkeane added a comment to D100051: [clang] Move int <-> float scalar conversion to a separate function.

Hrmph... Phab ate my other comment, which was that the name EmitCastBetweenScalarTypes feels clunky. Does EmitScalarCast or EmitScalarScalarCast sound better and capture the meaning correctly?

Apr 7 2021, 11:31 AM · Restricted Project
erichkeane added inline comments to D100051: [clang] Move int <-> float scalar conversion to a separate function.
Apr 7 2021, 11:30 AM · Restricted Project

Apr 5 2021

erichkeane accepted D99896: Rework the way statement attributes are processed; NFC.

SGTM.

Apr 5 2021, 1:21 PM · Restricted Project
erichkeane added a comment to D99896: Rework the way statement attributes are processed; NFC.

It is really sad that the attributes can't 'auto transform' themselves. ParsedAttr could (since it has a union of expressions/identifiers), but we don't really seem to have a good way to do it for Attr.

Apr 5 2021, 1:14 PM · Restricted Project

Mar 26 2021

erichkeane added a comment to D73967: Implement _ExtInt as an extended int type specifier..

Why do you not allow a type able to represent {-1, 0}?

Our FPGA team didn't see any value in it, so we didn't propose it to WG14, so we didn't implement it here. I'm sure a follow-up paper to WG14 would be considered, and if it shows promise/positive reception, we'd welcome a patch here.

It comes from an FPGA tool programmer who knows about HLS *and* modern C++, so probably a very rare specie. :-)
The typical FPGA programmer and tool writer is often more focused on C, so knows barely nothing about generic programming.
In the meantime we can probably use C++20 concepts, a C++ wrapping type and some specialization for the 1bit case to handle this negative cases or just have a SYCL-specific fork...
Probably simpler to have a fork than trying to convince the C committee or FPGA people not understanding C++.

Mar 26 2021, 10:17 AM · Restricted Project
erichkeane added a comment to D73967: Implement _ExtInt as an extended int type specifier..

An FPGA programmer is hitting this issue from your unit test:

c++
  signed _ExtInt(1) m; // expected-error{{signed _ExtInt must have a bit size of at least 2}}

Why do you not allow a type able to represent {-1, 0}?

Mar 26 2021, 8:48 AM · Restricted Project

Mar 24 2021

erichkeane added a comment to D99240: [ConstantFolding] Look through local aliases when simplify GEPs.

So I guess I don't understand what this does differently than stripPointerCastsAndAliases? Is limiting this to local aliases that important?

Mar 24 2021, 6:44 PM · Restricted Project

Mar 11 2021

erichkeane accepted D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions.

The description of the problem, and hte patch and tests seem to make sense, so I think this should be ok. Please give some of the others a little bit of time before committing to speak their final bit, but LGTM .

Mar 11 2021, 6:24 AM · Restricted Project

Mar 8 2021

erichkeane accepted D98055: [ExtVectorType] Support conditional select operator for C++..
Mar 8 2021, 5:54 AM · Restricted Project

Mar 5 2021

erichkeane committed rGc2de5aff1a08: [OpenMP] Handle non-function context before checking for diagnostic (authored by pmrao).
[OpenMP] Handle non-function context before checking for diagnostic
Mar 5 2021, 12:38 PM
erichkeane closed D97573: [OpenMP] Handle non-function context before checking for diagnostic emission.
Mar 5 2021, 12:38 PM · Restricted Project
erichkeane added inline comments to D98055: [ExtVectorType] Support conditional select operator for C++..
Mar 5 2021, 9:49 AM · Restricted Project

Mar 1 2021

erichkeane added inline comments to D97573: [OpenMP] Handle non-function context before checking for diagnostic emission.
Mar 1 2021, 8:09 AM · Restricted Project
erichkeane added inline comments to D97573: [OpenMP] Handle non-function context before checking for diagnostic emission.
Mar 1 2021, 7:59 AM · Restricted Project
erichkeane added inline comments to D97573: [OpenMP] Handle non-function context before checking for diagnostic emission.
Mar 1 2021, 6:43 AM · Restricted Project

Feb 23 2021

erichkeane added a comment to D97324: [NFC] Make TrailingObjects non-copyable/non-movable.

I can imagine there being some cases where these could theoretically be useful.

But if you've tested this change and it doesn't cause build failures with any existing uses of TrailingObjects in llvm-project, then LGTM.

Feb 23 2021, 4:36 PM · Restricted Project
erichkeane committed rGaf4451eb4f38: [NFC] Make TrailingObjects non-copyable/non-movable (authored by erichkeane).
[NFC] Make TrailingObjects non-copyable/non-movable
Feb 23 2021, 4:30 PM
erichkeane closed D97324: [NFC] Make TrailingObjects non-copyable/non-movable.
Feb 23 2021, 4:30 PM · Restricted Project
erichkeane requested review of D97324: [NFC] Make TrailingObjects non-copyable/non-movable.
Feb 23 2021, 12:02 PM · Restricted Project

Jan 29 2021

erichkeane added a comment to D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins.

For target-specific builtins I ended up implementing this: https://github.com/llvm/llvm-project/commit/81a73fde5cea304d31294fd26c2f051f1685e97c at one point to make sure that 'host' builtins get looked up in the aux-target if necessary.

Jan 29 2021, 8:25 AM · Restricted Project
erichkeane added a comment to D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins.

Can you show any tests where this builtin would be a part of the aux-triple, and not in active code? So an nvptx triple, x86_64 aux-triple, and in non-device code? (such as in a CUDA app)?

Jan 29 2021, 6:53 AM · Restricted Project

Jan 20 2021

erichkeane committed rG8776e3f289c1: [EXTINT][OMP] Fix _ExtInt type checking in device code (authored by erichkeane).
[EXTINT][OMP] Fix _ExtInt type checking in device code
Jan 20 2021, 11:36 AM

Jan 14 2021

erichkeane committed rG9e53c94d8dd7: [NFC] Update test to not check for 'opaque' in the file name. (authored by erichkeane).
[NFC] Update test to not check for 'opaque' in the file name.
Jan 14 2021, 11:24 AM

Jan 11 2021

erichkeane accepted D94438: Fis for Assertion failure on dependent expression..

Fix looks fine, I'm on the fence about how to handle the test, whether it is valuable to convert it to a C++ test and omit the #ifdef/extra run line, or leave it as it is (without the 2nd run with Wmost).

Jan 11 2021, 11:34 AM · Restricted Project

Jan 7 2021

erichkeane added a comment to D92715: [Clang][RISCV] Define RISC-V V builtin types.

I think it would be possible to add a new attribute to define these types. But only specific values for parameters would be allowed so that it could only generate the exact types we see here and the future segment load patches. It wouldn't be general purpose like vector_size since the backend design has a contract about how to translate the LMUL value from the scalable type.

This would introduce a new type in the AST or at least new subtype of VectorType. This new type would need to be checked for in multiple places in the compiler to define its behavior. As a datapoint VectorType::SveFixedLengthDataVector appears 20 times. It's not clear that's a reduction in complexity versus following what was already done with AArch64SVEACLETypes.def. But I'm not a frontend expert.

Jan 7 2021, 4:03 PM · Restricted Project
erichkeane committed rG43043adcfbc6: Add element-type to the Vector TypeLoc types. (authored by erichkeane).
Add element-type to the Vector TypeLoc types.
Jan 7 2021, 9:15 AM
erichkeane closed D93483: Add element-type to the Vector TypeLoc types..
Jan 7 2021, 9:14 AM · Restricted Project

Jan 6 2021

erichkeane committed rG3fa6cedb6be8: Fix MaterializeTemporaryExpr's type when its an incomplete array. (authored by erichkeane).
Fix MaterializeTemporaryExpr's type when its an incomplete array.
Jan 6 2021, 7:25 AM
erichkeane closed D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array..
Jan 6 2021, 7:25 AM · Restricted Project
erichkeane added a comment to D94092: [Clang] Remove unnecessary Attr.isArgIdent checks..

Without bothering to look it up, I would guess that the attribute-parsing code used to generically handle the ambiguity between identifier expressions and identifier attribute arguments by just always parsing simple identifiers as identifier arguments, making it Sema's responsibility to turn that back into an expression. At some point, the parser was made sensitive to the actual attribute being parsed, but we never bothered to simplify Sema. At any rate, the parser does now know exactly which argument of which attribute it's parsing, so there's zero reason for it to force this complexity on Sema anymore; if we find a case that parses identifier arguments, we should fix it in the parser to parse an expression instead.

I don't think it will be quite that trivial (switching all identifiers to be parsed as expressions instead). For instance, attributes that take enumeration arguments can parse those arguments as identifiers, but those identifiers will never be found by usual expression lookup because they don't really exist. That said, any attribute that currently accepts an identifier because it really wants to use that identifier in an expression in Sema should update the attribute argument clauses in Attr.td and make the corresponding changes in SemaDeclAttr.cpp/SemaStmt.cpp/SemaType.cpp as appropriate.

Jan 6 2021, 6:15 AM · Restricted Project

Jan 5 2021

erichkeane added inline comments to D93483: Add element-type to the Vector TypeLoc types..
Jan 5 2021, 9:15 AM · Restricted Project
erichkeane accepted D94092: [Clang] Remove unnecessary Attr.isArgIdent checks..

I tried a few different things to construct matrix_type attributes with ArgIdents, but failed. The patch also adjusts the code for a bunch of attributes. So if there are indeed cases where ArgIdents can show up, we will get some examples for unit tests.

The comment claims: "// Special case where the argument is a template id.". I would expect one of the following to hit that:
https://godbolt.org/z/znYW1s

I tried this snippet with the patch (and also an added assert(!Attr.isArgIdent(0)); to HandleVectorSizeAttr just to be sure). Compiled as expected, no crash.

Jan 5 2021, 9:04 AM · Restricted Project
erichkeane added a comment to D94092: [Clang] Remove unnecessary Attr.isArgIdent checks..

I'm not sure how well Attr.td's constraints are enforced on type attributes, as these often happen before parsing is completely done. I'd imagine this code was put into place at least the 1st time for good reason, but I'm curious as to why we wouldn't have tests that cover that (or, as you assert, it could simply be that this is simply dead code).

I'm generally OK with this (the asserts are unnecessary), but would like @aaron.ballman to double check my expectations here.

It would be great if we could get confirmation!

I tried a few different things to construct matrix_type attributes with ArgIdents, but failed. The patch also adjusts the code for a bunch of attributes. So if there are indeed cases where ArgIdents can show up, we will get some examples for unit tests.

Jan 5 2021, 8:56 AM · Restricted Project
erichkeane added a comment to D94092: [Clang] Remove unnecessary Attr.isArgIdent checks..

I'm not sure how well Attr.td's constraints are enforced on type attributes, as these often happen before parsing is completely done. I'd imagine this code was put into place at least the 1st time for good reason, but I'm curious as to why we wouldn't have tests that cover that (or, as you assert, it could simply be that this is simply dead code).

Jan 5 2021, 8:44 AM · Restricted Project
erichkeane added a comment to D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array..

Ping!

Jan 5 2021, 5:48 AM · Restricted Project
erichkeane added a comment to D93483: Add element-type to the Vector TypeLoc types..

Ping!

Jan 5 2021, 5:48 AM · Restricted Project

Jan 4 2021

erichkeane added a comment to D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC).
Jan 4 2021, 12:47 PM · Restricted Project
erichkeane added a comment to D92523: Small improvements to Intrinsic::getName.

I note here: https://llvm.org/doxygen/namespacellvm_1_1Intrinsic.html#a7157f9fa9dd11f234ec3c58517cb6d96 that the documentatoin to the getName function variant says:

Jan 4 2021, 10:16 AM · Restricted Project

Dec 17 2020

erichkeane requested review of D93483: Add element-type to the Vector TypeLoc types..
Dec 17 2020, 12:15 PM · Restricted Project

Dec 15 2020

erichkeane updated the diff for D51650: Implement target_clones multiversioning.

Since there seems to be at least a little renewed interest in this from a handful of people lately, I spend the time to rebase this and do some minor cleanup tasks.

Dec 15 2020, 6:36 AM