- User Since
- Jun 28 2016, 8:37 AM (125 w, 1 d)
Fix @rsmith s comments, rebase on the big CPUDispatch refactor.
Tue, Nov 20
Mon, Nov 19
Submitter: Any update on the status? It seems that Richard's feedback should be trivial enough, so I was wondering if you need this taken up?
Fri, Nov 16
Thu, Nov 15
Added to the release notes. Also, an email was sent out to cfe-dev.
Wed, Nov 14
Tue, Nov 13
You'll not be able to get the C++ spelling without it getting into the standard. Additionally, it seems easy enough to calculate upon need, so storing it in the AST is a waste. @aaron.ballman is likely another person who can review this.
Mon, Nov 12
Thu, Nov 1
Mon, Oct 29
Thu, Oct 25
Add to the test
Update the 2 failing tests. Would love some help looking at the Analysis fix, it seems to no longer have to 'assume' stuff due to the this now being defined behavior.
Woops, apparently a couple of tests fail on this that I somehow missed the 1st time. Looking into it.
ACTUALLY add the test this time :/ sorry about that!
Added test as requested by @rnk. How's it look? I hope I got the balance of check-lines right.
Wed, Oct 24
did everything suggested by @rnk as far as I know. Thanks again for the reviews!
@rnk: I looked into the EmitMustTailThunk code, and don't terribly see what I'm doing wrong. I clearly cannot CALL that function (since this works with non-CXXMethodDecls), so I looked into using it. However, I saw that it does a couple of small things that seem useful, but not anything that seems to fix your concerns.
Tue, Oct 23
Oct 22 2018
Yikes, good catch!
Oct 16 2018
Superseding with a version that seems to work
Oct 12 2018
@aaron.ballman or @rsmith any chance you guys could give me a hand on the direction here? I'm growing GlobalDecl by quite a bit, so I want to make sure this is both permissible and the right way to go. Additionally, feedback on how to get a GlobalDecl down to getFunctionFeatureMap would be appreciated.
Oct 4 2018
Can you write tests for this please? Particularly validate the results in a constexpr context.
Oct 3 2018
Sep 19 2018
Does this still work with 32 bit hosts? Does PointerIntPair have 3 bits in that case? Is the alignof static_assert valid in that case?
A few drive-by comments... This is a patch with interactions I'm not sure I feel comfortable approving myself, so I'll count on @rjmccall to do so.
Sep 13 2018
Sep 12 2018
Sep 10 2018
Thanks for the feedback @rsmith! I'm working through the lambda issue and a few other things, but will get to this as soon as I can.
Based on feedback from @rsmith I've been trying to get this to work with Lambdas like GCC does, though I'm quite confused about how to go about it here. It seems that the lambda definition call operator is deferred, however I'm having a hard time making sure that this happens in the "IFunc" case. I'm still working on it, but it might be a bit.
Sep 6 2018
fix aaron's comments.