Page MenuHomePhabricator

erichkeane (Erich Keane)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 8:37 AM (146 w, 3 d)

Recent Activity

Thu, Mar 21

erichkeane committed rG505427cb2fe4: Permit redeclarations of a builtin to specify calling convention. (authored by erichkeane).
Permit redeclarations of a builtin to specify calling convention.
Thu, Mar 21, 6:32 AM
erichkeane committed rL356663: Permit redeclarations of a builtin to specify calling convention..
Permit redeclarations of a builtin to specify calling convention.
Thu, Mar 21, 6:32 AM
erichkeane committed rC356663: Permit redeclarations of a builtin to specify calling convention..
Permit redeclarations of a builtin to specify calling convention.
Thu, Mar 21, 6:32 AM
erichkeane closed D59560: Permit redeclarations of a builtin to specify calling convention. .
Thu, Mar 21, 6:32 AM · Restricted Project

Mar 20 2019

erichkeane updated the diff for D59560: Permit redeclarations of a builtin to specify calling convention. .

Woops! Look like I left without actually changing the revision *shame*.

Mar 20 2019, 6:36 AM · Restricted Project
erichkeane accepted D59578: [X86] Remove getCPUKindCanonicalName which seems to be unused..
Mar 20 2019, 6:05 AM · Restricted Project, Restricted Project

Mar 19 2019

erichkeane updated the diff for D59560: Permit redeclarations of a builtin to specify calling convention. .

As @rnk suggested, switch to an enum. SemaType.cpp unfortunately has Sema as a forward declaration, so it has to use integers.

Mar 19 2019, 3:00 PM · Restricted Project
erichkeane added inline comments to D59560: Permit redeclarations of a builtin to specify calling convention. .
Mar 19 2019, 2:18 PM · Restricted Project
erichkeane created D59560: Permit redeclarations of a builtin to specify calling convention. .
Mar 19 2019, 1:53 PM · Restricted Project
Herald added a reviewer for D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin: jfb.

@mgorny @hfinkel @eli.friedman @jyknight @dim
Is there any chance we can get this in any time soon? It fixes a couple of header issues that we've noticed. Others added, since it appears this dependent on https://reviews.llvm.org/D29542 ?

Mar 19 2019, 1:04 PM · Restricted Project

Mar 13 2019

erichkeane added a comment to D59307: Patch llvm bug 41033 concerning atomicity of statement expressions.

This is my concern here:
https://godbolt.org/z/icS4fa
The patch will change template instantiation.

Mar 13 2019, 11:32 AM · Restricted Project
erichkeane added a reviewer for D59307: Patch llvm bug 41033 concerning atomicity of statement expressions: rnk.
Mar 13 2019, 9:54 AM · Restricted Project

Mar 8 2019

erichkeane committed rG92146ce399cd: Re-fix _lrotl/_lrotr to always take Long, no matter the platform. (authored by erichkeane).
Re-fix _lrotl/_lrotr to always take Long, no matter the platform.
Mar 8 2019, 7:10 AM
erichkeane committed rG00a5b4a27577: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms." (authored by erichkeane).
Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."
Mar 8 2019, 7:10 AM
erichkeane committed rC355698: Re-fix _lrotl/_lrotr to always take Long, no matter the platform..
Re-fix _lrotl/_lrotr to always take Long, no matter the platform.
Mar 8 2019, 7:10 AM
erichkeane committed rC355697: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.".
Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."
Mar 8 2019, 7:10 AM
erichkeane committed rL355698: Re-fix _lrotl/_lrotr to always take Long, no matter the platform..
Re-fix _lrotl/_lrotr to always take Long, no matter the platform.
Mar 8 2019, 7:10 AM
erichkeane committed rL355697: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.".
Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."
Mar 8 2019, 7:10 AM
erichkeane added a comment to D59105: [RFC] Create an Arbitrary Precision Integer Type..

Thank you @rsmith for the quick review! I really appreciate it.

Mar 8 2019, 6:41 AM

Mar 7 2019

erichkeane created D59105: [RFC] Create an Arbitrary Precision Integer Type..
Mar 7 2019, 12:28 PM

Mar 4 2019

erichkeane committed rGac8d1b7017ff: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms. (authored by erichkeane).
Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.
Mar 4 2019, 10:51 AM
erichkeane committed rC355322: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms..
Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.
Mar 4 2019, 10:50 AM
erichkeane committed rL355322: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms..
Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.
Mar 4 2019, 10:50 AM
erichkeane committed rC355317: Give builtins and alloc/dealloc operators the default calling convention..
Give builtins and alloc/dealloc operators the default calling convention.
Mar 4 2019, 6:55 AM
erichkeane committed rG881e83d8b94f: Give builtins and alloc/dealloc operators the default calling convention. (authored by erichkeane).
Give builtins and alloc/dealloc operators the default calling convention.
Mar 4 2019, 6:54 AM
erichkeane committed rL355317: Give builtins and alloc/dealloc operators the default calling convention..
Give builtins and alloc/dealloc operators the default calling convention.
Mar 4 2019, 6:54 AM
erichkeane closed D58844: Give builtins and alloc/dealloc operators the default calling convention..
Mar 4 2019, 6:54 AM · Restricted Project, Restricted Project

Mar 1 2019

erichkeane created D58844: Give builtins and alloc/dealloc operators the default calling convention..
Mar 1 2019, 1:15 PM · Restricted Project, Restricted Project

Feb 8 2019

erichkeane accepted D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack..

The justification is correct based on my research into this problem, and the code changes themselves look correct. I cannot think of any reason why re-stating the alignment will matter in GCC mode, so I think this is OK.

Feb 8 2019, 10:09 AM · Restricted Project

Feb 7 2019

erichkeane committed rG892e63319497: Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS. (authored by erichkeane).
Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS.
Feb 7 2019, 7:14 AM
erichkeane committed rL353411: Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS..
Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS.
Feb 7 2019, 7:14 AM
erichkeane committed rC353411: Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS..
Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS.
Feb 7 2019, 7:14 AM

Feb 1 2019

erichkeane added a comment to D57581: Explicitly add language standard option to test cases that rely on the C++14 default.

This seems innocuous to me. I don't see any problem with it, but please don't commit until the others have had time to look.

Feb 1 2019, 5:56 AM · Restricted Project, Restricted Project

Jan 29 2019

erichkeane accepted D57264: Bump minimum toolchain version.
Jan 29 2019, 9:37 AM · Restricted Project

Jan 25 2019

erichkeane accepted D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86.

LGTM, thanks for doing this!

Jan 25 2019, 10:54 AM
erichkeane committed rL352229: Remove F16 literal support based on Float16 support..
Remove F16 literal support based on Float16 support.
Jan 25 2019, 10:36 AM
erichkeane committed rC352229: Remove F16 literal support based on Float16 support..
Remove F16 literal support based on Float16 support.
Jan 25 2019, 10:36 AM
erichkeane committed rC352222: Fix incorrect indent from r352221.
Fix incorrect indent from r352221
Jan 25 2019, 9:40 AM
erichkeane committed rL352222: Fix incorrect indent from r352221.
Fix incorrect indent from r352221
Jan 25 2019, 9:40 AM
erichkeane committed rC352221: Disable _Float16 for non ARM/SPIR Targets.
Disable _Float16 for non ARM/SPIR Targets
Jan 25 2019, 9:30 AM
erichkeane committed rL352221: Disable _Float16 for non ARM/SPIR Targets.
Disable _Float16 for non ARM/SPIR Targets
Jan 25 2019, 9:30 AM
erichkeane closed D57188: Disable _Float16 for non ARM/SPIR Targets.
Jan 25 2019, 9:30 AM
erichkeane committed rL352219: Allow 'static' storage specifier on an out-of-line member function template.
Allow 'static' storage specifier on an out-of-line member function template
Jan 25 2019, 9:02 AM
erichkeane committed rC352219: Allow 'static' storage specifier on an out-of-line member function template.
Allow 'static' storage specifier on an out-of-line member function template
Jan 25 2019, 9:02 AM
erichkeane closed D56473: Allow 'static' storage specifier on an out-of-line member function template declaration in MSVCCompat mode.
Jan 25 2019, 9:02 AM
erichkeane updated the diff for D57188: Disable _Float16 for non ARM/SPIR Targets.
Jan 25 2019, 7:02 AM
erichkeane added inline comments to D57188: Disable _Float16 for non ARM/SPIR Targets.
Jan 25 2019, 7:02 AM

Jan 24 2019

erichkeane created D57188: Disable _Float16 for non ARM/SPIR Targets.
Jan 24 2019, 1:45 PM
erichkeane committed rC352054: [CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias..
[CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias.
Jan 24 2019, 7:29 AM
erichkeane committed rL352054: [CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias..
[CPU-Dispatch] Make pentium_iii_no_xmm_regs and pentium_iii alias.
Jan 24 2019, 7:29 AM
erichkeane added a comment to D54653: [IRBuilder] Remove positivity check from CreateAlignmentAssumption().

@erichkeane are you still going to land this?
If you don't want to bother with updating my tests, want me to take over so this doesn't get abandoned?

Jan 24 2019, 6:04 AM

Jan 18 2019

erichkeane committed rC351576: [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics.
[NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics
Jan 18 2019, 11:35 AM
erichkeane committed rL351576: [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics.
[NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics
Jan 18 2019, 11:35 AM
erichkeane added inline comments to D56819: Document toolchain update policy.
Jan 18 2019, 10:00 AM
erichkeane added a comment to D45978: dllexport const variables must have external linkage..

@rnk and @aaron.ballman, does this look appropriate here?

Jan 18 2019, 9:26 AM
erichkeane added a reviewer for D45978: dllexport const variables must have external linkage.: aaron.ballman.
Jan 18 2019, 9:25 AM
erichkeane added a comment to rL351495: Make integral-o-pointer conversions in SFINAE illegal..

Taking a look now, thank you for letting me know!

Jan 18 2019, 6:02 AM
erichkeane committed rL351550: Fix test failure from r351495.
Fix test failure from r351495
Jan 18 2019, 6:02 AM
erichkeane committed rC351550: Fix test failure from r351495.
Fix test failure from r351495
Jan 18 2019, 6:01 AM
erichkeane added a comment to rL351495: Make integral-o-pointer conversions in SFINAE illegal..

Taking a look now, thank you for letting me know!

Jan 18 2019, 5:57 AM

Jan 17 2019

erichkeane committed rC351495: Make integral-o-pointer conversions in SFINAE illegal..
Make integral-o-pointer conversions in SFINAE illegal.
Jan 17 2019, 3:15 PM
erichkeane committed rL351495: Make integral-o-pointer conversions in SFINAE illegal..
Make integral-o-pointer conversions in SFINAE illegal.
Jan 17 2019, 3:15 PM
erichkeane accepted D56819: Document toolchain update policy.
Jan 17 2019, 10:28 AM

Jan 16 2019

erichkeane added a comment to D56799: [NFC] Factor out + document build requirements.

I think this is a good start. That said, this is also a bug-fix (not exactly NFC), since it adds the Clang check to AppleClang.

Jan 16 2019, 1:35 PM · Restricted Project
erichkeane abandoned D47073: Document and Enforce new Host Compiler Policy.

This patch has run its course.

Jan 16 2019, 9:17 AM
erichkeane committed rL351357: Remove misleading line about git's lack of revision numbers..
Remove misleading line about git's lack of revision numbers.
Jan 16 2019, 9:05 AM

Jan 15 2019

erichkeane added a comment to D47073: Document and Enforce new Host Compiler Policy.

For what it's worth, the stricter version of this patch received quite overwhelming support in May. We delayed it due to Google's limitations and yet we still don't seem to have made progress. This current patch is a result of a continued set of compromises to try to satisfy a few in the vocal minority. I'd suggest that we all agree to have an ACTUAL decision made on llvm-dev, rather than this constant state of consensus derailed by vocal minority.

This *patch* does not matter to Google in any real sense that I'm aware of.... *All* of what I wrote in my latest comment is about this patch, and has nothing to do with the overall strategy of the LLVM project. And that feedback was given as a very active individual contributor to the project.

Does Google care a great deal about the overall state of host compiler support and C++ version support of LLVM? Yes, it does. We expressed that, and so did others. That was done on the -dev list as well as in the BoF. I'm not really interested in re-arguing it here.

But please try to take my feedback on this *patch* as just that. It is code review and feedback on the specific changes you are making. I'm genuinely trying to help get the CMake and documentation implementation *right* and useful for the project and the community, not for Google. I'm sorry that you're frustrated, I really am. But I am actually trying to help, and comments like this, IMO, are not constructive.

Jan 15 2019, 9:45 PM
erichkeane added a comment to D47073: Document and Enforce new Host Compiler Policy.

For what it's worth, the stricter version of this patch received quite overwhelming support in May. We delayed it due to Google's limitations and yet we still don't seem to have made progress. This current patch is a result of a continued set of compromises to try to satisfy a few in the vocal minority. I'd suggest that we all agree to have an ACTUAL decision made on llvm-dev, rather than this constant state of consensus derailed by vocal minority.

Jan 15 2019, 7:58 PM
erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.

Update branch date to match the 7.0.0 from 8.0.0 branch date.

Jan 15 2019, 1:18 PM
erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.
Jan 15 2019, 1:14 PM
erichkeane committed rC351212: Fix cpu-dispatch MV regression caused by r347812.
Fix cpu-dispatch MV regression caused by r347812
Jan 15 2019, 9:55 AM
erichkeane committed rL351212: Fix cpu-dispatch MV regression caused by r347812.
Fix cpu-dispatch MV regression caused by r347812
Jan 15 2019, 9:55 AM

Jan 11 2019

erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.

Fixed @lebedev.ri s comments.

Jan 11 2019, 10:48 AM
erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.

Added Policy guidance for the change process to CheckCompilerVersion.cmake.

Jan 11 2019, 10:33 AM
erichkeane committed rC350941: Fix a pair of Wfallthrough warnings in ScanfFormatString..
Fix a pair of Wfallthrough warnings in ScanfFormatString.
Jan 11 2019, 10:05 AM
erichkeane committed rL350941: Fix a pair of Wfallthrough warnings in ScanfFormatString..
Fix a pair of Wfallthrough warnings in ScanfFormatString.
Jan 11 2019, 10:05 AM

Jan 9 2019

erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.

Fixing my awful inattention to spelling in a few places, moving the AppleClang code to be more clear for future updates.

Jan 9 2019, 12:26 PM
erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.

Few more fixes suggested by @jfb . Also, added AppleClang to the check.

Jan 9 2019, 11:51 AM
erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.
Jan 9 2019, 10:46 AM
erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.

Change language to make this a 'guideline' instead of a hardline policy.

Jan 9 2019, 10:27 AM
erichkeane updated the diff for D47073: Document and Enforce new Host Compiler Policy.

Reworded a thing. Still needs direction feedback for 8.0.

Jan 9 2019, 6:25 AM
erichkeane added inline comments to D47073: Document and Enforce new Host Compiler Policy.
Jan 9 2019, 6:25 AM

Jan 8 2019

erichkeane committed rC350645: Fix opencl test broken on windows by r350643..
Fix opencl test broken on windows by r350643.
Jan 8 2019, 11:14 AM
erichkeane committed rL350645: Fix opencl test broken on windows by r350643..
Fix opencl test broken on windows by r350643.
Jan 8 2019, 11:14 AM
erichkeane committed rL350643: Limit COFF 'common' emission to <=32 alignment types..
Limit COFF 'common' emission to <=32 alignment types.
Jan 8 2019, 10:48 AM
erichkeane committed rC350643: Limit COFF 'common' emission to <=32 alignment types..
Limit COFF 'common' emission to <=32 alignment types.
Jan 8 2019, 10:48 AM
erichkeane closed D56391: Limit COFF 'common' emission to <=32 alignment types..
Jan 8 2019, 10:48 AM
erichkeane added a comment to D56407: Implement the TreeStructure interface through the TextNodeDumper.

I think this is a good approach to solving the problem, so let's go this route.

Jan 8 2019, 7:20 AM
erichkeane updated the diff for D56391: Limit COFF 'common' emission to <=32 alignment types..
Jan 8 2019, 6:16 AM

Jan 7 2019

erichkeane created D56391: Limit COFF 'common' emission to <=32 alignment types..
Jan 7 2019, 7:45 AM

Jan 4 2019

erichkeane added a comment to D47073: Document and Enforce new Host Compiler Policy.

Bumping again!

Jan 4 2019, 9:19 AM
erichkeane committed rC350398: Prevent unreachable when checking invalid multiversion decls..
Prevent unreachable when checking invalid multiversion decls.
Jan 4 2019, 7:31 AM
erichkeane committed rL350398: Prevent unreachable when checking invalid multiversion decls..
Prevent unreachable when checking invalid multiversion decls.
Jan 4 2019, 7:31 AM

Dec 18 2018

erichkeane committed rC349506: [NFC] Fix usage of Builder.insert(new Bitcast...)in CodeGenFunction.
[NFC] Fix usage of Builder.insert(new Bitcast...)in CodeGenFunction
Dec 18 2018, 8:27 AM
erichkeane committed rL349506: [NFC] Fix usage of Builder.insert(new Bitcast...)in CodeGenFunction.
[NFC] Fix usage of Builder.insert(new Bitcast...)in CodeGenFunction
Dec 18 2018, 8:26 AM

Dec 17 2018

erichkeane created D55778: Add /favor:<whatever> to CL-Compat's ignore list..
Dec 17 2018, 11:00 AM

Dec 14 2018

erichkeane committed rC349209: Add AddressSpace mangling to MS mode.
Add AddressSpace mangling to MS mode
Dec 14 2018, 3:20 PM
erichkeane committed rL349209: Add AddressSpace mangling to MS mode.
Add AddressSpace mangling to MS mode
Dec 14 2018, 3:20 PM
erichkeane closed D55715: Add AddressSpace mangling to MS mode.
Dec 14 2018, 3:20 PM
erichkeane added inline comments to D55715: Add AddressSpace mangling to MS mode.
Dec 14 2018, 3:15 PM