- User Since
- Jun 28 2016, 8:37 AM (156 w, 12 h)
Fri, Jun 21
Thu, Jun 20
Can someone take a look at this?
@sdesmalen in particular, I'd love it if you could take a look since you're the author of this code.
Tue, Jun 18
Thu, Jun 13
Update the comment as requested by @rjmccall
Tue, Jun 11
Wed, Jun 5
Tue, Jun 4
Mon, Jun 3
Fri, May 31
Thu, May 30
Wed, May 29
Conditional approval, commit with the comment fixed. Let me know if you need me to commit it for you.
A different (perhaps silly) question is why 'W' isn't sufficient? It represents int64_t, which I wonder if is sufficient.
'O' is an interesting choice. Any real justification for it, or just "what was available"? It definitely needs to be documented in the top of Builtins.def however.
Tue, May 28
Added warning + other comments from @aaron.ballman
Mon, May 27
May 25 2019
Reread @rsmith's comments and surrounding code and found what I believe is the correct answer to these comments :)
May 24 2019
May 23 2019
Mar 21 2019
Mar 20 2019
Woops! Look like I left without actually changing the revision *shame*.
Mar 19 2019
As @rnk suggested, switch to an enum. SemaType.cpp unfortunately has Sema as a forward declaration, so it has to use integers.
@mgorny @hfinkel @eli.friedman @jyknight @dim
Is there any chance we can get this in any time soon? It fixes a couple of header issues that we've noticed. Others added, since it appears this dependent on https://reviews.llvm.org/D29542 ?
Mar 13 2019
This is my concern here:
The patch will change template instantiation.
Mar 8 2019
Thank you @rsmith for the quick review! I really appreciate it.