Page MenuHomePhabricator

erichkeane (Erich Keane)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 8:37 AM (164 w, 3 d)

Recent Activity

Today

erichkeane committed rG23384a1c8dc8: [NFC] Move some variable declarations into their 'if' conditions. (authored by erichkeane).
[NFC] Move some variable declarations into their 'if' conditions.
Fri, Aug 23, 8:58 AM
erichkeane committed rL369773: [NFC] Move some variable declarations into their 'if' conditions..
[NFC] Move some variable declarations into their 'if' conditions.
Fri, Aug 23, 8:58 AM
erichkeane added a comment to D66597: [preprocessor] Add an opportunity to retain excluded conditional blocks.

I don't have a good idea of the intent of this patch. It seems to me that this could do some pretty nasty damage to C code, right?

Fri, Aug 23, 8:51 AM · Restricted Project

Mon, Aug 19

erichkeane committed rGa8abe1f82899: Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668. (authored by erichkeane).
Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668.
Mon, Aug 19, 11:19 AM
erichkeane committed rL369286: Fix poorly formatted HTML in the cxx_status.html file caused by adding.
Fix poorly formatted HTML in the cxx_status.html file caused by adding
Mon, Aug 19, 11:19 AM
erichkeane committed rGf04d246d7d13: Fix test where diagnostics changed in P1668 implementation (authored by erichkeane).
Fix test where diagnostics changed in P1668 implementation
Mon, Aug 19, 11:10 AM
erichkeane committed rL369284: Fix test where diagnostics changed in P1668 implementation.
Fix test where diagnostics changed in P1668 implementation
Mon, Aug 19, 11:09 AM
erichkeane committed rGab00f237ac9d: Update cxx_status.html with P1668 status. (authored by erichkeane).
Update cxx_status.html with P1668 status.
Mon, Aug 19, 11:00 AM
erichkeane committed rL369282: Update cxx_status.html with P1668 status..
Update cxx_status.html with P1668 status.
Mon, Aug 19, 10:59 AM
erichkeane committed rG62b072d413ee: Implement P1668R1 (authored by erichkeane).
Implement P1668R1
Mon, Aug 19, 10:42 AM
erichkeane committed rL369281: Implement P1668R1.
Implement P1668R1
Mon, Aug 19, 10:42 AM

Wed, Aug 14

erichkeane committed rG0e85f18ded9c: Add support in CMake to statically link the C++ standard library. (authored by erichkeane).
Add support in CMake to statically link the C++ standard library.
Wed, Aug 14, 12:56 PM
erichkeane committed rL368907: Add support in CMake to statically link the C++ standard library..
Add support in CMake to statically link the C++ standard library.
Wed, Aug 14, 12:55 PM
erichkeane closed D65603: Add support in CMake to statically link the C++ standard library..
Wed, Aug 14, 12:55 PM · Restricted Project

Mon, Aug 12

erichkeane added a comment to D65603: Add support in CMake to statically link the C++ standard library..

Does anyone have issues with this? Can I commit it?

Mon, Aug 12, 2:52 PM · Restricted Project

Fri, Aug 2

erichkeane added a comment to D65603: Add support in CMake to statically link the C++ standard library..

Unfortunately, this ends up adding a warning or two to the build if you enable this, since we have a couple of things built in "C" (flag not used...). In the 'clang' test I did, ./bin/count was the only one. Unfortunately, we don't have separate C vs C++ linking flags, so I think this is just something that someone using this flag needs to deal with.

Fri, Aug 2, 7:08 AM · Restricted Project

Thu, Aug 1

erichkeane created D65603: Add support in CMake to statically link the C++ standard library..
Thu, Aug 1, 1:04 PM · Restricted Project
erichkeane committed rG441f119789da: Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny (authored by erichkeane).
Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny
Thu, Aug 1, 10:31 AM
erichkeane committed rG1328cd0e3752: Document LLVM_ENABLE_LIBCXX in CMake.rst (authored by erichkeane).
Document LLVM_ENABLE_LIBCXX in CMake.rst
Thu, Aug 1, 10:31 AM
erichkeane committed rL367585: Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny.
Fix spacing of LLVM_USE_PERF in CMake.rst that caused it to be tabbed in funny
Thu, Aug 1, 10:29 AM
erichkeane committed rL367584: Document LLVM_ENABLE_LIBCXX in CMake.rst.
Document LLVM_ENABLE_LIBCXX in CMake.rst
Thu, Aug 1, 10:29 AM

Fri, Jul 26

erichkeane added 3 commit(s) for D65294: Make the CXXABIs respect the target's default calling convention.: rG61478ec6ac9f: Make the CXXABIs respect the target's default calling convention., rC367103: Make the CXXABIs respect the target's default calling convention., rL367103: Make the CXXABIs respect the target's default calling convention..
Fri, Jul 26, 5:45 AM
erichkeane closed D65294: Make the CXXABIs respect the target's default calling convention..
Fri, Jul 26, 5:45 AM
erichkeane added an edge to rL367103: Make the CXXABIs respect the target's default calling convention.: D65294: Make the CXXABIs respect the target's default calling convention..
Fri, Jul 26, 5:45 AM
erichkeane added an edge to rG61478ec6ac9f: Make the CXXABIs respect the target's default calling convention.: D65294: Make the CXXABIs respect the target's default calling convention..
Fri, Jul 26, 5:45 AM
erichkeane added a comment to D65294: Make the CXXABIs respect the target's default calling convention..

Committed, 9.0 release request here: https://bugs.llvm.org/show_bug.cgi?id=42774

Fri, Jul 26, 5:40 AM
erichkeane committed rG61478ec6ac9f: Make the CXXABIs respect the target's default calling convention. (authored by erichkeane).
Make the CXXABIs respect the target's default calling convention.
Fri, Jul 26, 5:39 AM
erichkeane committed rL367103: Make the CXXABIs respect the target's default calling convention..
Make the CXXABIs respect the target's default calling convention.
Fri, Jul 26, 5:36 AM

Thu, Jul 25

erichkeane created D65294: Make the CXXABIs respect the target's default calling convention..
Thu, Jul 25, 11:28 AM
erichkeane committed rG393094859e45: Remove CallingConvMethodType (authored by erichkeane).
Remove CallingConvMethodType
Thu, Jul 25, 10:17 AM
erichkeane committed rGad137fa78863: Fix cxx_status html for r367027 (authored by erichkeane).
Fix cxx_status html for r367027
Thu, Jul 25, 10:17 AM
erichkeane committed rL367039: Remove CallingConvMethodType.
Remove CallingConvMethodType
Thu, Jul 25, 10:16 AM
erichkeane committed rL367038: Fix cxx_status html for r367027.
Fix cxx_status html for r367027
Thu, Jul 25, 10:16 AM
erichkeane committed rG46441fdb3c1d: Implement P1771 (authored by erichkeane).
Implement P1771
Thu, Jul 25, 8:13 AM
erichkeane committed rL367027: Implement P1771.
Implement P1771
Thu, Jul 25, 8:12 AM
erichkeane closed D64914: Implement P1771.
Thu, Jul 25, 8:12 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D64914: Implement P1771.
Thu, Jul 25, 6:55 AM · Restricted Project, Restricted Project

Jul 24 2019

erichkeane updated the diff for D64914: Implement P1771.

Casting implementation had to happen in SemaStmt, because other 'warn unused result' stuff depends on them being the way they are.

Jul 24 2019, 7:37 AM · Restricted Project, Restricted Project
erichkeane added a comment to D64914: Implement P1771.

Disregard that last commit... i ended up breaking stuff apparently.

Jul 24 2019, 6:19 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D64914: Implement P1771.
Jul 24 2019, 6:02 AM · Restricted Project, Restricted Project

Jul 23 2019

erichkeane added a comment to D64914: Implement P1771.

Ugg... well conversion functions are an interesting bit, as well as Type{}; with no constructors. It ends up being a function style cast to an init-list-expr, so its going to require a bit more work. Stay tuned :)

Jul 23 2019, 1:55 PM · Restricted Project, Restricted Project

Jul 22 2019

erichkeane updated the diff for D64914: Implement P1771.

Rebased and did all the comments (including the www_status). @aaron.ballman : Wasn't positive what you meant about the conversion functions, but I think I got one? I would also love some bikeshedding on the documentation.

Jul 22 2019, 7:17 AM · Restricted Project, Restricted Project

Jul 19 2019

erichkeane added a comment to D64914: Implement P1771.

I'll need to rebase this on another patch soon anyway, so I'll hold off until next week to update this particularly since we have some open questions. The additional TableGen work is tempting to do, though I'm not completely sure it'll get more than just this use.

Jul 19 2019, 5:24 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D64914: Implement P1771.

Removes pure/const, limits change to just CXX11 spelling, and changes docs/FeatureTestMacro.

Jul 19 2019, 12:26 AM · Restricted Project, Restricted Project

Jul 18 2019

erichkeane added a comment to D64914: Implement P1771.

There seems to be some separable concerns in this patch. I'd rather real with warn_unused_result, const, and pure attributes separately only because those are under the gnu attribute namespace and I'd prefer to match GNU's semantics for those attributes (or at least understand better where the inconsistencies are).

This is also missing documentation changes and the updated feature test macro value.

Jul 18 2019, 11:30 PM · Restricted Project, Restricted Project
erichkeane created D64914: Implement P1771.
Jul 18 2019, 5:57 AM · Restricted Project, Restricted Project

Jul 8 2019

erichkeane added a comment to D63846: [clang] Preserve names of addrspacecast'ed values..

The change itself doesn't really bother me at all, however the test will fail if we build without preserving names. In order to validate this you'll have to do fno-discard-value-names on a test.

Jul 8 2019, 11:00 AM · Restricted Project, Restricted Project
erichkeane accepted D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code.

I think the function names are awkward, but otherwise I think this should be acceptable. I'll accept, but give 24 hrs for the other reviewers to get through their mondays.

Jul 8 2019, 6:36 AM · Restricted Project, Restricted Project

Jul 1 2019

erichkeane added a reviewer for D63846: [clang] Preserve names of addrspacecast'ed values.: yaxunl.
Jul 1 2019, 11:35 AM · Restricted Project, Restricted Project
erichkeane added a comment to D64015: [WIP][CUDA] Use shared MangleContext for CUDA and CXX CG.

I don't know of any problems that the shared mangle context would cause, though I'm not sure about using the shared_ptr. It seems to me that SOMEONE should own this, and the other should use a reference. IMO, the SharedMangleContexts should be a unique_ptr and CGCXXABI/CGCUDANV should have a reference to the proper implementation.

Jul 1 2019, 10:10 AM · Restricted Project

Jun 25 2019

erichkeane committed rGad28befcf49c: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty> (authored by erichkeane).
Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>
Jun 25 2019, 5:10 PM
erichkeane committed rL364364: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>
Jun 25 2019, 5:09 PM
erichkeane closed D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Jun 25 2019, 5:09 PM · Restricted Project

Jun 24 2019

erichkeane committed rGc6d0281d9163: First attempt at __unique_stable_name (authored by erichkeane).
First attempt at __unique_stable_name
Jun 24 2019, 12:03 PM

Jun 21 2019

erichkeane committed rGa9bfda08ca9d: Remove binary finally accidentially committed in r364109 (authored by erichkeane).
Remove binary finally accidentially committed in r364109
Jun 21 2019, 3:33 PM
erichkeane committed rG36176249d136: Ensure Target Features always_inline error happens in C++ cases. (authored by erichkeane).
Ensure Target Features always_inline error happens in C++ cases.
Jun 21 2019, 3:33 PM
erichkeane committed rL364110: Remove binary finally accidentially committed in r364109.
Remove binary finally accidentially committed in r364109
Jun 21 2019, 3:33 PM
erichkeane committed rL364109: Ensure Target Features always_inline error happens in C++ cases..
Ensure Target Features always_inline error happens in C++ cases.
Jun 21 2019, 3:30 PM
erichkeane added a comment to D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.

Can someone take a look at this?
@sdesmalen in particular, I'd love it if you could take a look since you're the author of this code.

Thanks, I definitely want to take a look but I’m currently traveling without access to my laptop, so I won’t be able to properly review it until Wednesday.

Jun 21 2019, 10:17 AM · Restricted Project

Jun 20 2019

erichkeane updated the diff for D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Jun 20 2019, 1:37 PM · Restricted Project
erichkeane added inline comments to D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Jun 20 2019, 1:37 PM · Restricted Project
erichkeane added a comment to D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.

Can someone take a look at this?
@sdesmalen in particular, I'd love it if you could take a look since you're the author of this code.

Jun 20 2019, 7:22 AM · Restricted Project
erichkeane added a reviewer for D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>: craig.topper.
Jun 20 2019, 7:22 AM · Restricted Project

Jun 18 2019

erichkeane created D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Jun 18 2019, 11:30 AM · Restricted Project
erichkeane closed D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Jun 18 2019, 10:21 AM · Restricted Project
erichkeane added an edge to rL363288: PR42182: Allow thread-local to use __cxa_thread_atexit when: D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Jun 18 2019, 10:21 AM
erichkeane added 3 commit(s) for D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used: rL363288: PR42182: Allow thread-local to use __cxa_thread_atexit when, rC363288: PR42182: Allow thread-local to use __cxa_thread_atexit when, rG34ec6929a1fb: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit….
Jun 18 2019, 10:21 AM · Restricted Project
erichkeane added an edge to rG34ec6929a1fb: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit…: D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Jun 18 2019, 10:21 AM

Jun 13 2019

erichkeane committed rG34ec6929a1fb: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit… (authored by erichkeane).
PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit…
Jun 13 2019, 11:18 AM
erichkeane committed rL363288: PR42182: Allow thread-local to use __cxa_thread_atexit when.
PR42182: Allow thread-local to use __cxa_thread_atexit when
Jun 13 2019, 11:18 AM
erichkeane updated the diff for D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.

Update the comment as requested by @rjmccall

Jun 13 2019, 11:12 AM · Restricted Project
erichkeane created D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Jun 13 2019, 10:08 AM · Restricted Project

Jun 11 2019

erichkeane committed rGd65ef6735aca: Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp (authored by erichkeane).
Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp
Jun 11 2019, 7:56 AM
erichkeane committed rL363074: Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp.
Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp
Jun 11 2019, 7:55 AM

Jun 5 2019

erichkeane committed rGda59652c1ba1: Avoid using NoThrow Exception Specifier in non-C++ Modes. (authored by erichkeane).
Avoid using NoThrow Exception Specifier in non-C++ Modes.
Jun 5 2019, 7:09 AM
erichkeane committed rL362607: Avoid using NoThrow Exception Specifier in non-C++ Modes..
Avoid using NoThrow Exception Specifier in non-C++ Modes.
Jun 5 2019, 7:07 AM

Jun 4 2019

erichkeane added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

Was this committed accidentally?

Today in master I see:

  • r362106: Revert "clang support gnu asm goto." Erich Keane <erich.keane@intel.com>
  • r362059: Mark CodeGen/asm-goto.c as x86 specific after r362045 Fangrui Song <maskray@google.com>
  • r362045: clang support gnu asm goto. Jennifer Yu <jennifer.yu@intel.com>

    and yet this Phabricator review is still open.

    It may be easier to rebase this into a monorepo checkout, then commit with git llvm push. https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git

    As @kees noted, for new test files that contain x86 assembly, they need a -triple that specifies an x86 target, otherwise the implicit target is based on the host, which may not be x86. We still want to verify that non-x86 host can cross compile to x86 correctly. Sorry we did not catch this earlier in code review.
Jun 4 2019, 8:52 AM

Jun 3 2019

erichkeane committed rGdd0adae65a70: Fix test failure from r362435 (authored by erichkeane).
Fix test failure from r362435
Jun 3 2019, 12:55 PM
erichkeane committed rL362443: Fix test failure from r362435.
Fix test failure from r362435
Jun 3 2019, 12:55 PM
erichkeane committed rGbf37536a351a: Make NoThrow FunctionLike, make FunctionLike include references, fix prettyprint (authored by erichkeane).
Make NoThrow FunctionLike, make FunctionLike include references, fix prettyprint
Jun 3 2019, 11:34 AM
erichkeane committed rG81ef625080cb: Permit Exception Spec mismatch with NoThrow on inherited Virtual (authored by erichkeane).
Permit Exception Spec mismatch with NoThrow on inherited Virtual
Jun 3 2019, 11:34 AM
erichkeane committed rL362435: Make NoThrow FunctionLike, make FunctionLike include references, fix.
Make NoThrow FunctionLike, make FunctionLike include references, fix
Jun 3 2019, 11:34 AM
erichkeane committed rL362434: Permit Exception Spec mismatch with NoThrow on inherited Virtual.
Permit Exception Spec mismatch with NoThrow on inherited Virtual
Jun 3 2019, 11:34 AM

May 31 2019

erichkeane committed rG68fa6ddb9d44: Replace 'default' in an enum-over-a-switch with the missing list. (authored by erichkeane).
Replace 'default' in an enum-over-a-switch with the missing list.
May 31 2019, 9:59 AM
erichkeane committed rL362245: Replace 'default' in an enum-over-a-switch with the missing list..
Replace 'default' in an enum-over-a-switch with the missing list.
May 31 2019, 9:59 AM
erichkeane committed rGc61762797ea4: Suppress nothrow/Exception spec conflict warning when we dont know the ES. (authored by erichkeane).
Suppress nothrow/Exception spec conflict warning when we dont know the ES.
May 31 2019, 9:47 AM
erichkeane committed rL362243: Suppress nothrow/Exception spec conflict warning when we dont know the ES..
Suppress nothrow/Exception spec conflict warning when we dont know the ES.
May 31 2019, 9:43 AM
erichkeane committed rG24016eb37466: Suppress nothrow/exception spec conflict warning when ES is parsed. (authored by erichkeane).
Suppress nothrow/exception spec conflict warning when ES is parsed.
May 31 2019, 8:59 AM
erichkeane committed rL362236: Suppress nothrow/exception spec conflict warning when ES is parsed..
Suppress nothrow/exception spec conflict warning when ES is parsed.
May 31 2019, 8:53 AM
erichkeane committed rG54182eb7b0db: Fix for PR42089, regression from r362119 (authored by erichkeane).
Fix for PR42089, regression from r362119
May 31 2019, 7:27 AM
erichkeane committed rL362225: Fix for PR42089, regression from r362119.
Fix for PR42089, regression from r362119
May 31 2019, 7:23 AM
erichkeane added a comment to D62435: Add Attribute NoThrow as an Exception Specifier Type.

This change broke compiling Qt on MinGW, see https://bugs.llvm.org/show_bug.cgi?id=42089. Trivially reproducible by trying to compile a snippet that looks like this:

class Foo {
public:
        __attribute__((nothrow)) void __attribute__((__stdcall__)) Bar();
};

void Foo::Bar() {
}

Reproducible by compiling the same snippet for a windows-msvc target as well.

May 31 2019, 6:30 AM · Restricted Project, Restricted Project

May 30 2019

erichkeane committed rGfc3dfd3e35a6: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand. (authored by erichkeane).
Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.
May 30 2019, 2:35 PM
erichkeane committed rL362157: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.
May 30 2019, 2:35 PM
erichkeane closed D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
May 30 2019, 2:35 PM · Restricted Project
erichkeane updated the diff for D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
May 30 2019, 12:13 PM · Restricted Project
erichkeane added inline comments to D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
May 30 2019, 11:56 AM · Restricted Project
erichkeane committed rGd02f4a1043c0: Add Attribute NoThrow as an Exception Specifier Type (authored by erichkeane).
Add Attribute NoThrow as an Exception Specifier Type
May 30 2019, 11:14 AM
erichkeane committed rL362119: Add Attribute NoThrow as an Exception Specifier Type.
Add Attribute NoThrow as an Exception Specifier Type
May 30 2019, 11:14 AM
erichkeane committed rC362119: Add Attribute NoThrow as an Exception Specifier Type.
Add Attribute NoThrow as an Exception Specifier Type
May 30 2019, 11:14 AM