erichkeane (Erich Keane)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 8:37 AM (86 w, 12 m)

Recent Activity

Fri, Feb 16

erichkeane committed rL325364: Clean up 'target' attribute diagnostics.
Clean up 'target' attribute diagnostics
Fri, Feb 16, 9:34 AM
erichkeane committed rC325364: Clean up 'target' attribute diagnostics.
Clean up 'target' attribute diagnostics
Fri, Feb 16, 9:34 AM
erichkeane closed D43359: Clean up 'target' attribute diagnostics.
Fri, Feb 16, 9:34 AM
erichkeane updated the diff for D43359: Clean up 'target' attribute diagnostics.

Do as @aaron.ballman suggested for the message. Also, removed properties from the new file.

Fri, Feb 16, 9:14 AM
erichkeane added inline comments to D43359: Clean up 'target' attribute diagnostics.
Fri, Feb 16, 8:37 AM

Thu, Feb 15

erichkeane added a comment to D43359: Clean up 'target' attribute diagnostics.

Thanks! I'll give @aaron.ballman a chance to take a look, so I'll probably do something about this tomorrow.

Thu, Feb 15, 3:29 PM
erichkeane created D43359: Clean up 'target' attribute diagnostics.
Thu, Feb 15, 3:24 PM
erichkeane added a reviewer for D43352: Add support for __declspec(code_seg("segname")): rnk.
Thu, Feb 15, 1:56 PM

Wed, Feb 14

erichkeane committed rL325186: Improve documentation for attribute artificial.
Improve documentation for attribute artificial
Wed, Feb 14, 3:04 PM
erichkeane committed rC325186: Improve documentation for attribute artificial.
Improve documentation for attribute artificial
Wed, Feb 14, 3:04 PM
erichkeane closed D43321: Improve documentation for attribute artificial.
Wed, Feb 14, 3:04 PM

Tue, Feb 13

erichkeane committed rC325081: Implement function attribute artificial.
Implement function attribute artificial
Tue, Feb 13, 4:16 PM
erichkeane committed rL325081: Implement function attribute artificial.
Implement function attribute artificial
Tue, Feb 13, 4:16 PM
erichkeane closed D43259: Implement function attribute artificial.
Tue, Feb 13, 4:16 PM
erichkeane added a comment to D40925: Add option -fkeep-static-consts.

OK. My concern is that users need to use attribute((used)) or something more robust if they want SVN identifiers to reliably appear in the output. Adding this flag just creates a trap that will fail once they turn on >>-O2. I'd rather not have it in the interface to avoid that user confusion.

Tue, Feb 13, 3:54 PM
erichkeane added a comment to D38803: Suppress generation of a deleting destructor for a dllimport record..

@zahiraam : See @rnk's comment here for steps that need to be taken: I didn't implement this logic, please rebase this on rL315656 and update the test case in it.

Tue, Feb 13, 3:47 PM
erichkeane added a reviewer for D43259: Implement function attribute artificial: rnk.
Tue, Feb 13, 2:47 PM

Mon, Feb 12

erichkeane committed rC324915: Further cleanup to Driver mode code, as suggested by dblaikie [NFC].
Further cleanup to Driver mode code, as suggested by dblaikie [NFC]
Mon, Feb 12, 9:49 AM
erichkeane committed rL324915: Further cleanup to Driver mode code, as suggested by dblaikie [NFC].
Further cleanup to Driver mode code, as suggested by dblaikie [NFC]
Mon, Feb 12, 9:49 AM
erichkeane committed rC324909: Update target-note-test to be current with the AMDGPU changes.
Update target-note-test to be current with the AMDGPU changes
Mon, Feb 12, 9:22 AM
erichkeane committed rL324909: Update target-note-test to be current with the AMDGPU changes.
Update target-note-test to be current with the AMDGPU changes
Mon, Feb 12, 9:21 AM
erichkeane committed rL324907: Make attribute-target on a Definition-after-use update the LLVM attributes.
Make attribute-target on a Definition-after-use update the LLVM attributes
Mon, Feb 12, 9:05 AM
erichkeane committed rC324907: Make attribute-target on a Definition-after-use update the LLVM attributes.
Make attribute-target on a Definition-after-use update the LLVM attributes
Mon, Feb 12, 9:05 AM
erichkeane closed D43095: Make attribute-target on a Definition-after-use update the LLVM attributes.
Mon, Feb 12, 9:05 AM
erichkeane added inline comments to D43095: Make attribute-target on a Definition-after-use update the LLVM attributes.
Mon, Feb 12, 9:05 AM
erichkeane committed rC324902: Add Invalid-note test negllected in R324673,324674,324675,324676.
Add Invalid-note test negllected in R324673,324674,324675,324676
Mon, Feb 12, 8:27 AM
erichkeane committed rL324902: Add Invalid-note test negllected in R324673,324674,324675,324676.
Add Invalid-note test negllected in R324673,324674,324675,324676
Mon, Feb 12, 8:26 AM

Thu, Feb 8

erichkeane committed rL324687: Fix UBSan issue with PPC::isValidCPUName.
Fix UBSan issue with PPC::isValidCPUName
Thu, Feb 8, 4:15 PM
erichkeane committed rC324687: Fix UBSan issue with PPC::isValidCPUName.
Fix UBSan issue with PPC::isValidCPUName
Thu, Feb 8, 4:15 PM
erichkeane committed rL324682: Add size to constexpr Arrays.
Add size to constexpr Arrays
Thu, Feb 8, 3:51 PM
erichkeane committed rC324682: Add size to constexpr Arrays.
Add size to constexpr Arrays
Thu, Feb 8, 3:51 PM
erichkeane created D43095: Make attribute-target on a Definition-after-use update the LLVM attributes.
Thu, Feb 8, 3:32 PM
erichkeane committed rL324676: Add Rest of Targets Support to ValidCPUList (enabling march notes).
Add Rest of Targets Support to ValidCPUList (enabling march notes)
Thu, Feb 8, 3:19 PM
erichkeane committed rC324676: Add Rest of Targets Support to ValidCPUList (enabling march notes).
Add Rest of Targets Support to ValidCPUList (enabling march notes)
Thu, Feb 8, 3:19 PM
erichkeane closed D43057: Add Rest of Targets Support to ValidCPUList (enabling march notes).
Thu, Feb 8, 3:18 PM
erichkeane committed rC324675: Add NVPTX Support to ValidCPUList (enabling march notes).
Add NVPTX Support to ValidCPUList (enabling march notes)
Thu, Feb 8, 3:18 PM
erichkeane committed rL324675: Add NVPTX Support to ValidCPUList (enabling march notes).
Add NVPTX Support to ValidCPUList (enabling march notes)
Thu, Feb 8, 3:18 PM
erichkeane closed D43045: Add NVPTX Support to ValidCPUList (enabling march notes).
Thu, Feb 8, 3:17 PM
erichkeane committed rC324674: Add X86 Support to ValidCPUList (enabling march notes).
Add X86 Support to ValidCPUList (enabling march notes)
Thu, Feb 8, 3:17 PM
erichkeane committed rL324674: Add X86 Support to ValidCPUList (enabling march notes).
Add X86 Support to ValidCPUList (enabling march notes)
Thu, Feb 8, 3:17 PM
erichkeane closed D43041: Add X86 Support to ValidCPUList (enabling march notes).
Thu, Feb 8, 3:17 PM
erichkeane committed rC324673: Make march/target-cpu print a note with the list of valid values for ARM.
Make march/target-cpu print a note with the list of valid values for ARM
Thu, Feb 8, 3:16 PM
erichkeane committed rL324673: Make march/target-cpu print a note with the list of valid values for ARM.
Make march/target-cpu print a note with the list of valid values for ARM
Thu, Feb 8, 3:16 PM
erichkeane closed D42978: Make march/target-cpu print a note with the list of valid values for ARM.
Thu, Feb 8, 3:16 PM
erichkeane committed rC324644: Fix improper indentation issue in CodeGenModule [NFC].
Fix improper indentation issue in CodeGenModule [NFC]
Thu, Feb 8, 12:06 PM
erichkeane committed rL324644: Fix improper indentation issue in CodeGenModule [NFC].
Fix improper indentation issue in CodeGenModule [NFC]
Thu, Feb 8, 12:06 PM
erichkeane added inline comments to D43045: Add NVPTX Support to ValidCPUList (enabling march notes).
Thu, Feb 8, 11:51 AM
erichkeane updated the diff for D43057: Add Rest of Targets Support to ValidCPUList (enabling march notes).

rebased, reflowed tests.

Thu, Feb 8, 11:30 AM
erichkeane updated the diff for D43045: Add NVPTX Support to ValidCPUList (enabling march notes).

rebased, reflowed tests.

Thu, Feb 8, 11:29 AM
erichkeane updated the diff for D43041: Add X86 Support to ValidCPUList (enabling march notes).

Cleaned up the test as suggested.

Thu, Feb 8, 11:14 AM
erichkeane updated the diff for D42978: Make march/target-cpu print a note with the list of valid values for ARM.

Relaxed the test further.

Thu, Feb 8, 10:57 AM
erichkeane added inline comments to D42978: Make march/target-cpu print a note with the list of valid values for ARM.
Thu, Feb 8, 10:56 AM
erichkeane added inline comments to D42978: Make march/target-cpu print a note with the list of valid values for ARM.
Thu, Feb 8, 10:36 AM
erichkeane updated the diff for D43041: Add X86 Support to ValidCPUList (enabling march notes).

removed careless newline, also rebases off ARM patch.

Thu, Feb 8, 9:47 AM
erichkeane updated the diff for D42978: Make march/target-cpu print a note with the list of valid values for ARM.

Removed extra newline.

Thu, Feb 8, 9:43 AM
erichkeane committed rL324625: Fix signed/unsigned compare warning I introduced.
Fix signed/unsigned compare warning I introduced
Thu, Feb 8, 9:14 AM
erichkeane updated the diff for D42978: Make march/target-cpu print a note with the list of valid values for ARM.

Simplified ARM tests as requested.

Thu, Feb 8, 9:01 AM
erichkeane added a comment to D42978: Make march/target-cpu print a note with the list of valid values for ARM.

That makes sense. I changed the ARM one to check ONLY the first one, since in each case that seems like the oldest anyway. It at least makes sure that the lists are distinct, and avoids this cross-repo fragility.

Thu, Feb 8, 9:00 AM
erichkeane closed D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets.
Thu, Feb 8, 8:51 AM
erichkeane added 1 commit(s) for D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets: rL324623: [ARM] Add 'fillValidCPUArchList' to ARM targets.
Thu, Feb 8, 8:51 AM
erichkeane added an edge to rL324623: [ARM] Add 'fillValidCPUArchList' to ARM targets: D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets.
Thu, Feb 8, 8:51 AM
erichkeane committed rL324623: [ARM] Add 'fillValidCPUArchList' to ARM targets.
[ARM] Add 'fillValidCPUArchList' to ARM targets
Thu, Feb 8, 8:51 AM

Wed, Feb 7

erichkeane created D43057: Add Rest of Targets Support to ValidCPUList (enabling march notes).
Wed, Feb 7, 6:04 PM
erichkeane committed rC324540: [NFCi] Replace a couple of usages of const StringRef& with StringRef.
[NFCi] Replace a couple of usages of const StringRef& with StringRef
Wed, Feb 7, 3:07 PM
erichkeane committed rL324540: [NFCi] Replace a couple of usages of const StringRef& with StringRef.
[NFCi] Replace a couple of usages of const StringRef& with StringRef
Wed, Feb 7, 3:07 PM
erichkeane created D43045: Add NVPTX Support to ValidCPUList (enabling march notes).
Wed, Feb 7, 2:00 PM
erichkeane created D43041: Add X86 Support to ValidCPUList (enabling march notes).
Wed, Feb 7, 1:19 PM
erichkeane updated the diff for D42978: Make march/target-cpu print a note with the list of valid values for ARM.
Wed, Feb 7, 12:31 PM
erichkeane updated the diff for D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets.

Added tests as requested. Should cover all current comments.

Wed, Feb 7, 12:24 PM
erichkeane added a comment to D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets.

Just realized I forgot the unittest, i'll toss a couple in, sorry about that!

Wed, Feb 7, 10:22 AM
erichkeane updated the diff for D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets.

Changed to using the CPUNames lists.

Wed, Feb 7, 10:19 AM

Tue, Feb 6

erichkeane committed rC324433: [NFC] Change odd cast-through-unknown behavior to an Optional.
[NFC] Change odd cast-through-unknown behavior to an Optional
Tue, Feb 6, 4:40 PM
erichkeane committed rL324433: [NFC] Change odd cast-through-unknown behavior to an Optional.
[NFC] Change odd cast-through-unknown behavior to an Optional
Tue, Feb 6, 4:40 PM
erichkeane committed rC324430: [NFC] Correct a typo'ed comment and reworded, since it is awkward..
[NFC] Correct a typo'ed comment and reworded, since it is awkward.
Tue, Feb 6, 4:22 PM
erichkeane committed rL324430: [NFC] Correct a typo'ed comment and reworded, since it is awkward..
[NFC] Correct a typo'ed comment and reworded, since it is awkward.
Tue, Feb 6, 4:22 PM
erichkeane added a comment to D42978: Make march/target-cpu print a note with the list of valid values for ARM.

LLVM patch here: https://reviews.llvm.org/D42979

Tue, Feb 6, 11:06 AM
erichkeane created D42979: [ARM] Add 'fillValidCPUArchList' to ARM targets.
Tue, Feb 6, 11:06 AM
erichkeane created D42978: Make march/target-cpu print a note with the list of valid values for ARM.
Tue, Feb 6, 11:05 AM
erichkeane accepted D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF.

Just 1 format question, otherwise Looks good.

Tue, Feb 6, 9:34 AM

Mon, Feb 5

erichkeane added a comment to D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF.

This seems pretty OK to me. I'd like to see @probinson s PS4 discussion bottom out, but I don't see any reason to hold this up otherwise.

Mon, Feb 5, 9:18 AM

Fri, Feb 2

erichkeane added inline comments to D42768: AST: support SwiftCC on MS ABI.
Fri, Feb 2, 2:45 PM
erichkeane accepted D42863: Make __has_unique_object_representations reject empty union types..

Yep, LGTM, thanks!

Fri, Feb 2, 12:33 PM
erichkeane added inline comments to D42768: AST: support SwiftCC on MS ABI.
Fri, Feb 2, 12:07 PM
erichkeane updated subscribers of rL324098: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen.

Actually, now that I mention that, i remembered that @EricWF is fixing that here: https://reviews.llvm.org/D42829

Fri, Feb 2, 12:05 PM
erichkeane added a comment to rL324098: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen.

Hi,

It seems like this commit breaks all release bots:

Fri, Feb 2, 12:01 PM
erichkeane added inline comments to D42768: AST: support SwiftCC on MS ABI.
Fri, Feb 2, 11:09 AM
erichkeane committed rL324098: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen.
[CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen
Fri, Feb 2, 7:57 AM
erichkeane committed rC324098: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen.
[CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen
Fri, Feb 2, 7:57 AM
erichkeane closed D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen.
Fri, Feb 2, 7:57 AM

Thu, Feb 1

erichkeane created D42811: [CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen.
Thu, Feb 1, 12:45 PM

Mon, Jan 29

erichkeane created D42664: Fix explicit template parameter reporting for narrowing conversions.
Mon, Jan 29, 3:08 PM
erichkeane committed rC323679: [NFC] Fixup comment with function name, actually incorrect name!.
[NFC] Fixup comment with function name, actually incorrect name!
Mon, Jan 29, 11:35 AM
erichkeane committed rL323679: [NFC] Fixup comment with function name, actually incorrect name!.
[NFC] Fixup comment with function name, actually incorrect name!
Mon, Jan 29, 11:35 AM

Jan 16 2018

erichkeane committed rL322592: Move target MV resolver to COMDAT.
Move target MV resolver to COMDAT
Jan 16 2018, 11:51 AM
erichkeane committed rC322592: Move target MV resolver to COMDAT.
Move target MV resolver to COMDAT
Jan 16 2018, 11:51 AM
erichkeane closed D42110: Move target MV resolver to COMDAT.
Jan 16 2018, 11:51 AM
erichkeane created D42110: Move target MV resolver to COMDAT.
Jan 16 2018, 9:45 AM

Jan 15 2018

erichkeane committed rC322518: Revert 319303: Add _Float128 as alias to __float128 to enable compilations on….
Revert 319303: Add _Float128 as alias to __float128 to enable compilations on…
Jan 15 2018, 1:18 PM
erichkeane added a reverting commit for rL319303: [ARM] Add support for armv7e-m to the .arch directive: rL322518: Revert 319303: Add _Float128 as alias to __float128 to enable compilations on….
Jan 15 2018, 1:17 PM
erichkeane committed rL322518: Revert 319303: Add _Float128 as alias to __float128 to enable compilations on….
Revert 319303: Add _Float128 as alias to __float128 to enable compilations on…
Jan 15 2018, 1:17 PM