Page MenuHomePhabricator

erichkeane (Erich Keane)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 8:37 AM (221 w, 5 d)

Recent Activity

Fri, Sep 25

erichkeane added inline comments to D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array..
Fri, Sep 25, 6:12 AM
erichkeane requested review of D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array..
Fri, Sep 25, 6:11 AM

Thu, Sep 24

erichkeane committed rGf8a92adfa242: Remove dead branch identified by @rsmith on post-commit for D88236 (authored by erichkeane).
Remove dead branch identified by @rsmith on post-commit for D88236
Thu, Sep 24, 1:05 PM
erichkeane added a comment to D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes.

Ok then, I'll take a look to see what it would take to make the MaterializeTemporaryExpr be created with the complete type here instead. Thanks!

Thu, Sep 24, 12:27 PM
erichkeane closed D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes.

Gah, forgot 'Differential Revision' again :/

Thu, Sep 24, 12:10 PM
erichkeane committed rG606a734755d1: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes (authored by erichkeane).
[PR47636] Fix tryEmitPrivate to handle non-constantarraytypes
Thu, Sep 24, 12:10 PM
erichkeane updated the diff for D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes.

@rjmccall Done!

Thu, Sep 24, 11:35 AM
erichkeane added a comment to D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes.

Note: @rsmith and @rjmccall were the last ones in this section based on Blame (by a wide margin!), so added both as reviewers.

Thu, Sep 24, 8:57 AM
erichkeane requested review of D88236: [PR47636] Fix tryEmitPrivate to handle non-constantarraytypes.
Thu, Sep 24, 8:57 AM

Aug 26 2020

erichkeane accepted D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization.
Aug 26 2020, 12:02 PM · Restricted Project
erichkeane added inline comments to D86488: [X86] Default to -mtune=generic unless -march is passed to the driver. Add TuneCPU to the AST serialization.
Aug 26 2020, 11:30 AM · Restricted Project

Aug 21 2020

erichkeane accepted D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249).

This looks right to me.

Aug 21 2020, 10:59 AM · Restricted Project
erichkeane accepted D86342: Enable constexpr on ROTATELEFT/ROTATERIGHT builtin intrinsics (PR47249).

Its a bit of a shame that the two implementations (left/right) differ by only a single character, an y ideas for combining them cleanly? I might also consider combining the two 'if' statements into a single one (if !EvalInteger(E->getArg(0)...) || !EvalInteger(E->getArg(1)...), but that is generally just preference.

Aug 21 2020, 10:43 AM · Restricted Project

Aug 19 2020

erichkeane added inline comments to D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446).
Aug 19 2020, 12:11 PM · Restricted Project
erichkeane accepted D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types.
Aug 19 2020, 10:10 AM · Restricted Project
erichkeane accepted D86187: [X86] Add support 'tune' in target attribute.

CFE changes look right to me. Please give the rest of the reviews a little while to take a look though

Aug 19 2020, 5:57 AM · Restricted Project

Aug 18 2020

erichkeane added a comment to D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types.

Were you able to make any progress on this?

Aug 18 2020, 4:01 PM · Restricted Project

Aug 17 2020

erichkeane added inline comments to D85384: [X86] Add basic support for -mtune command line option in clang.
Aug 17 2020, 12:32 PM · Restricted Project
erichkeane added a comment to D85384: [X86] Add basic support for -mtune command line option in clang.

1 comment, otherwise seems alright to me.

Aug 17 2020, 12:25 PM · Restricted Project

Aug 14 2020

erichkeane added inline comments to D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types.
Aug 14 2020, 12:46 PM · Restricted Project
erichkeane added a comment to D74361: [Clang] Undef attribute for global variables.

Yep! Declaring a global variable that isn't 'extern' with an incomplete type is disallowed anyway, so if you call RequireCompleteType, you're likely just diagnosing that early.

Aug 14 2020, 8:53 AM · Restricted Project
erichkeane added a comment to D74361: [Clang] Undef attribute for global variables.

I did a little debugging, and the problem is the template itself isn't a complete type until you require it with RequireCompleteType. You have this same problem with incomplete types: https://godbolt.org/z/hvf3M4

Aug 14 2020, 8:12 AM · Restricted Project
erichkeane added a comment to D74361: [Clang] Undef attribute for global variables.

Also, see this bug: This crashes immediately when used on a template instantiation: https://bugs.llvm.org/show_bug.cgi?id=47169

Aug 14 2020, 7:05 AM · Restricted Project
erichkeane added a comment to D74361: [Clang] Undef attribute for global variables.

This breaks tests on Windows: http://45.33.8.238/win/10664/step_7.txt

Please take a look, and if it takes some time please revert while you investigate.

Thanks! It seems Windows inserts 'dso_local' into the middle of the generated IR.

I can't test on Windows so the two that failed CI are now marked as "UNSUPPORTED: system-windows".

Do you know a usual work around for variation in symbol visibility? I'm happy to copy it from another test but am wary of guessing what might work on Windows.

Aug 14 2020, 7:04 AM · Restricted Project

Aug 12 2020

erichkeane committed rGaa4bc1cb7978: Limit Max Vector alignment on COFF targets to 8192. (authored by erichkeane).
Limit Max Vector alignment on COFF targets to 8192.
Aug 12 2020, 6:36 AM
erichkeane closed D85543: Limit Max Vector alignment on COFF targets to 8192.
Aug 12 2020, 6:35 AM · Restricted Project

Aug 10 2020

erichkeane added a reviewer for D85543: Limit Max Vector alignment on COFF targets to 8192: riccibruno.
Aug 10 2020, 3:41 PM · Restricted Project

Aug 7 2020

erichkeane requested review of D85543: Limit Max Vector alignment on COFF targets to 8192.
Aug 7 2020, 12:11 PM · Restricted Project

Aug 5 2020

erichkeane committed rG2143a90b34a7: Fix _ExtInt(1) to be a i1 in memory. (authored by erichkeane).
Fix _ExtInt(1) to be a i1 in memory.
Aug 5 2020, 10:55 AM

Aug 4 2020

erichkeane committed rG0a8ac91a0845: Permit nowthrow and nonnull with multiversioning. (authored by erichkeane).
Permit nowthrow and nonnull with multiversioning.
Aug 4 2020, 7:41 AM
erichkeane committed rG961da69d7eaf: Improve diagnostics for disallowed attributes used with multiversioning (authored by erichkeane).
Improve diagnostics for disallowed attributes used with multiversioning
Aug 4 2020, 7:40 AM

Aug 3 2020

erichkeane added a comment to D82562: Implement AVX ABI Warning/error.

@erichkeane, could you help me understand what is the action item of these warnings?

In Firefox we don't require AVX so our compilations generally don't enable the feature. (A very small number of files do come with AVX versions, mostly in imported media codecs, but they are reasonably well-isolated from other code.) It's not clear to me what the warning wants me to do. I can't enable AVX across the board, and I can't change all the code that uses large types as parameters. I feel like the only thing to do is silence the warning since there are enough instances that people will complain about log spam. Have I misunderstood the situation?

Aug 3 2020, 12:30 PM · Restricted Project

Jul 31 2020

erichkeane committed rGe704aa4f254a: DR2303: Prefer 'nearer' base classes during template deduction. (authored by erichkeane).
DR2303: Prefer 'nearer' base classes during template deduction.
Jul 31 2020, 5:40 AM
erichkeane closed D84048: DR2303: Prefer 'nearer' base classes during template deduction..
Jul 31 2020, 5:40 AM · Restricted Project

Jul 30 2020

erichkeane added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Thanks! I'm done for the day, so I'll push in the morning when I'll have a few hours to respond to build bots.

Jul 30 2020, 4:42 PM · Restricted Project

Jul 29 2020

erichkeane added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.
In D84049#2182370, @jfb wrote:
In D84049#2182011, @jfb wrote:

Hi, @jfb.

_Atomic appears to already have special logic for _ExtInt in clang::Sema::BuildAtomicType. If _Atomic is used with an _ExtInt whose size is not a power of 2, or whose size is less then 8 bits, then it's disallowed. Those cases already have tests in clang/test/SemaCXX/ext-int.cpp.

Interesting. It seems like __atomic ought to be consistent with this, and we'd make it official ABI?

std::atomic appears to use and call the __atomic builtins, so it emits this patch's new diagnostic that disallows _ExtInt. Unfortunately I can't add the std::atomic<_ExtInt(N)> to a sema lit test because I can't #include the real atomic, but I did verify it locally.

Can you add the test to libc++? @ldionne WDYT?

IF we are going as far as modifying libc++, perhaps we can just add a SFINAE test to std::atomic to disallow the _ExtInt types? That said, it won't help with libstdc++.

Either way, I suspect that is better placed in a different patch, and should no longer hold up this patch.

_Atomic and std::atomic ought to be compatible, they were designed to be. The original point I made was: "_ExtInt doesn't seem to be designed to work with atomic, please do something about it". It seems like disabling it for _Atomic is what you'd want at the moment, until a design for the entire thing is created?

We can ping @jwakely for libstdc++ 😃

Jul 29 2020, 9:35 AM · Restricted Project, Restricted Project
erichkeane added a comment to D84049: Disable use of _ExtInt with '__atomic' builtins.
In D84049#2182011, @jfb wrote:

Hi, @jfb.

_Atomic appears to already have special logic for _ExtInt in clang::Sema::BuildAtomicType. If _Atomic is used with an _ExtInt whose size is not a power of 2, or whose size is less then 8 bits, then it's disallowed. Those cases already have tests in clang/test/SemaCXX/ext-int.cpp.

Interesting. It seems like __atomic ought to be consistent with this, and we'd make it official ABI?

std::atomic appears to use and call the __atomic builtins, so it emits this patch's new diagnostic that disallows _ExtInt. Unfortunately I can't add the std::atomic<_ExtInt(N)> to a sema lit test because I can't #include the real atomic, but I did verify it locally.

Can you add the test to libc++? @ldionne WDYT?

Jul 29 2020, 9:17 AM · Restricted Project, Restricted Project

Jul 27 2020

erichkeane added inline comments to D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.
Jul 27 2020, 7:46 AM · Restricted Project
erichkeane added a comment to D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.

This seems like a strict improvement as well. That said, there are two opportunities to clean up the code that I suggest evaluating.

Jul 27 2020, 7:39 AM · Restricted Project
erichkeane accepted D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics..

I looked through the code changes, and they all seem quite mechanical. I believe they are all correct.

Jul 27 2020, 7:04 AM · Restricted Project
erichkeane added a comment to D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs..

Based on richard's suggestions, that seems about right. However I believe all the asserts should have a message to go along with them as we typicaly do.

Jul 27 2020, 6:17 AM · Restricted Project
erichkeane added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Ping! I believe I've done all of the requested changes.

Jul 27 2020, 6:10 AM · Restricted Project

Jul 24 2020

erichkeane added a comment to D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors.

I wasn't able to add you to the bug report, but I discovered this: https://bugs.llvm.org/show_bug.cgi?id=46837

Jul 24 2020, 11:33 AM · Restricted Project

Jul 23 2020

erichkeane updated the diff for D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Fix all the things that @rsmith suggested.

Jul 23 2020, 7:05 AM · Restricted Project
erichkeane committed rG7bf9e2204960: Update make_cxx_dr_status and cxx_dr_status.html for the new release. (authored by erichkeane).
Update make_cxx_dr_status and cxx_dr_status.html for the new release.
Jul 23 2020, 5:51 AM

Jul 22 2020

erichkeane added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Thanks for the review! I'll get this updated in the morning. I DO have a question on your suggestion for the ToVisit/Visited example, so if you could explain a little better, I'd be grateful.

Jul 22 2020, 4:45 PM · Restricted Project
erichkeane accepted D84292: Only enable -Wsuggest-override if it doesn't suggest adding override to functions that are already final.

Fix the comment as I mentioned, otherwise this LGTM.

Jul 22 2020, 10:00 AM · Restricted Project
erichkeane updated the diff for D84048: DR2303: Prefer 'nearer' base classes during template deduction..

As CWG seems unmoved by my argument as to why CWG2303 should change, I've opted to implement it as worded. As you can see, the implementation is somewhat more complicated, but I believe I made it at least reasonably understandable.

Jul 22 2020, 9:30 AM · Restricted Project
erichkeane added a comment to D84126: Enable -Wsuggest-override in the LLVM build.

Ive got a bit a of a problem here: This flag (suggest-override) on GCC 8.3 (and others) warns on missing-override EVEN WHEN the function is marked 'final'. This was not fixed until GCC 9.2: https://godbolt.org/z/55KeM3

Jul 22 2020, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 21 2020

erichkeane added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

I'd attempted to regenerate the cxx_dr_status.html using make_cxx_dr_status, but I get a 'no such

Jul 21 2020, 12:54 PM · Restricted Project
erichkeane updated the diff for D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Revert change to cxx_dr_status and update the test to have the right tag.

Jul 21 2020, 12:28 PM · Restricted Project
erichkeane added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Also make sure to update the the cxx_dr_status.html document.

It is auto-generated. You need to tag the test case: dr2303: 12.

Edit: And put it at the right place in the file (not at the end).

Do you have an example of this? I've not seen that anywhere before.

Jul 21 2020, 12:22 PM · Restricted Project
erichkeane added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Also make sure to update the the cxx_dr_status.html document.

It is auto-generated. You need to tag the test case: dr2303: 12.

Edit: And put it at the right place in the file (not at the end).

Jul 21 2020, 12:21 PM · Restricted Project
erichkeane updated the diff for D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Also make sure to update the the cxx_dr_status.html document.

Jul 21 2020, 11:52 AM · Restricted Project

Jul 20 2020

erichkeane committed rG66aff3239849: Issue error on invalid arithemtic conversions in C ternary (authored by erichkeane).
Issue error on invalid arithemtic conversions in C ternary
Jul 20 2020, 8:03 AM

Jul 17 2020

erichkeane accepted D84049: Disable use of _ExtInt with '__atomic' builtins.
Jul 17 2020, 10:24 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D84049: Disable use of _ExtInt with '__atomic' builtins.
Jul 17 2020, 10:02 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D84048: DR2303: Prefer 'nearer' base classes during template deduction..

Woops, left in a TODO from when I was planning on how to do this patch. Should be ready now :)

Jul 17 2020, 9:56 AM · Restricted Project
erichkeane added a comment to D84048: DR2303: Prefer 'nearer' base classes during template deduction..

I added @rsmith directly, since I suspect he's the most knowledgeable in SemaTemplateDeduction.cpp, but if anyone knows of someone else who is a good fit for this review, please add them as well!

Jul 17 2020, 9:55 AM · Restricted Project
erichkeane created D84048: DR2303: Prefer 'nearer' base classes during template deduction..
Jul 17 2020, 9:53 AM · Restricted Project
erichkeane added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

This patch doesn't seem to build for me:
/iusers/ekeane1/workspaces/llvm-project/llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp: In function ‘llvm::Error llvm::exegesis::parseDataBuffer(const char*, size_t, const void*, const void*, llvm::SmallVector<long int, 4>*)’:
/iusers/ekeane1/workspaces/llvm-project/llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp:99:37: error: ‘struct perf_branch_entry’ has no member named ‘cycles’

CycleArray->push_back(Entry.cycles);
Jul 17 2020, 7:25 AM · Restricted Project

Jul 14 2020

erichkeane added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

@jfb Ah, I feel I better understand your original question now. Thinking through how we would want __atomics to behave is great, and I'm genuinely glad someone's championing it. It also sounds a *smidgen* beyond the scope of what I was trying to accomplish with this particular patch. :-) This patch doesn't alter the behavior of the __atomic builtins one way or the other. It alters the behavior of the __sync builtins only to change a debug assert failure into a diagnostic error. I believe the _ExtInt authors are tracking new bugs related to that feature. A new bug report could keep the discussion going and keep the issue visible.

Jul 14 2020, 12:00 PM · Restricted Project
erichkeane committed rGd083adb068e7: Prohibit use of _ExtInt in atomic intrinsic (authored by jtmott-intel).
Prohibit use of _ExtInt in atomic intrinsic
Jul 14 2020, 6:11 AM
erichkeane closed D83340: Prohibit use of _ExtInt in atomic intrinsic.
Jul 14 2020, 6:11 AM · Restricted Project
erichkeane added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

@jfb Ah, I feel I better understand your original question now. Thinking through how we would want __atomics to behave is great, and I'm genuinely glad someone's championing it. It also sounds a *smidgen* beyond the scope of what I was trying to accomplish with this particular patch. :-) This patch doesn't alter the behavior of the __atomic builtins one way or the other. It alters the behavior of the __sync builtins only to change a debug assert failure into a diagnostic error. I believe the _ExtInt authors are tracking new bugs related to that feature. A new bug report could keep the discussion going and keep the issue visible.

Jul 14 2020, 5:30 AM · Restricted Project

Jul 13 2020

erichkeane accepted D83340: Prohibit use of _ExtInt in atomic intrinsic.

@erichkeane Assuming we're back to talking about the __sync functions, I get the following diagnostic.

test.c:22:6: error: address argument to atomic builtin must be a pointer to 1,2,4,8 or 16 byte type ('dtype *' (aka 'unsigned _ExtInt(512) *') invalid)
{    __sync_nand_and_fetch(pval1, val2); }
     ^                     ~~~~~
1 error generated.

Is this what you're referring to? (In highsight I probably could have piggybacked on this diagnostic for the _ExtInt check.)

Jul 13 2020, 5:17 PM · Restricted Project
erichkeane added a comment to D83340: Prohibit use of _ExtInt in atomic intrinsic.

What about powers-of-2 larger than, say, 256 bit? So a 512 bit value. Does this give reasonable codegen?

Jul 13 2020, 12:41 PM · Restricted Project
erichkeane added inline comments to D83340: Prohibit use of _ExtInt in atomic intrinsic.
Jul 13 2020, 12:02 PM · Restricted Project

Jul 9 2020

erichkeane accepted D82230: [ADT] Specialize std::swap() for SetVector.

Please fix the clang-format concerns, otherwise LGTM.

Jul 9 2020, 11:58 AM · Restricted Project
erichkeane closed D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding.

Gah, misspelled differential revision.

Jul 9 2020, 8:03 AM · Restricted Project
erichkeane committed rG4d4d9037670a: Fix warning caused by __builtin_expect_with_probability was not handled in… (authored by LukeZhuang).
Fix warning caused by __builtin_expect_with_probability was not handled in…
Jul 9 2020, 8:02 AM

Jul 8 2020

erichkeane accepted D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding.
Jul 8 2020, 3:56 PM · Restricted Project
erichkeane added inline comments to D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding.
Jul 8 2020, 12:21 PM · Restricted Project
erichkeane added inline comments to D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding.
Jul 8 2020, 6:10 AM · Restricted Project

Jul 7 2020

erichkeane added inline comments to D83340: Prohibit use of _ExtInt in atomic intrinsic.
Jul 7 2020, 1:28 PM · Restricted Project

Jul 6 2020

erichkeane accepted D83114: [clang] Fix the incorrect dependence bits for DependentExtIntType..
Jul 6 2020, 5:59 AM · Restricted Project

Jul 2 2020

erichkeane added a comment to D79279: Add overloaded versions of builtin mem* functions.

I just took a look at SemaChecking, the rest I'm not sure I get the intent of the patch sufficiently to understand.

Jul 2 2020, 6:25 AM · Restricted Project, Restricted Project

Jul 1 2020

erichkeane committed rG19c35526d986: Limit x86 test to require target to fix buildbot (from 2831a317b) (authored by erichkeane).
Limit x86 test to require target to fix buildbot (from 2831a317b)
Jul 1 2020, 8:07 AM
erichkeane committed rG2831a317b689: Implement AVX ABI Warning/error (authored by erichkeane).
Implement AVX ABI Warning/error
Jul 1 2020, 7:33 AM
erichkeane closed D82562: Implement AVX ABI Warning/error.
Jul 1 2020, 7:33 AM · Restricted Project

Jun 30 2020

erichkeane updated the diff for D82562: Implement AVX ABI Warning/error.

As @craig.topper suggested, extract the four lookups into 2 bool instead.

Jun 30 2020, 7:00 AM · Restricted Project

Jun 29 2020

erichkeane accepted D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation..
Jun 29 2020, 10:48 AM · Restricted Project, Restricted Project
erichkeane updated the diff for D82562: Implement AVX ABI Warning/error.

Do all feedback as @craig.topper recommended.

Jun 29 2020, 7:31 AM · Restricted Project
erichkeane accepted D82766: Compile the RecursiveASTVisitor callbacks test with "/bigobj".
Jun 29 2020, 6:59 AM · Restricted Project
erichkeane accepted D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation..

A bunch of clang-format, plus 1 odd looking equation, otherwise this like good.

Jun 29 2020, 6:58 AM · Restricted Project, Restricted Project

Jun 25 2020

erichkeane added a comment to D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC).

A few small nits, but I don't sufficiently care enough about the rule, so long as there IS one (hence my reason for opening this can of worms). I added @lattner since he requested that he be added to changes to the coding standards in the past.

Jun 25 2020, 2:11 PM · Restricted Project
erichkeane added a reviewer for D82594: Clarify a bit the guideline on omitting braces, including more examples (NFC): lattner.
Jun 25 2020, 2:11 PM · Restricted Project
erichkeane created D82562: Implement AVX ABI Warning/error.
Jun 25 2020, 8:33 AM · Restricted Project

Jun 24 2020

erichkeane committed rGdc3f8913d2ad: Fix crash on XCore on unused inline in EmitTargetMetadata (authored by nigelp-xmos).
Fix crash on XCore on unused inline in EmitTargetMetadata
Jun 24 2020, 1:02 PM
erichkeane committed rG56b530d92c42: Fix a pair of wtype-limits and 3 wparentheses warnings from 29125ddf1 (authored by erichkeane).
Fix a pair of wtype-limits and 3 wparentheses warnings from 29125ddf1
Jun 24 2020, 1:02 PM
erichkeane closed D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.
Jun 24 2020, 1:02 PM · Restricted Project
erichkeane accepted D77068: Fix crash on XCore on unused inline in EmitTargetMetadata.

I talked to others about the test, and they suggested the correct way to validate this is to make it simply a 'doesn't crash' test, so I'll remove the filecheck/check lines and submit this. The comment there seems sufficient to describe, so I'll live it in place.

Jun 24 2020, 12:28 PM · Restricted Project
erichkeane accepted D82414: [X86] Replace PROC macros with an enum and a lookup table of processor information..

1 nit, plus the clang-tidy suggestions.

Jun 24 2020, 6:27 AM · Restricted Project, Restricted Project

Jun 23 2020

erichkeane committed rG47fb21d2ea90: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp (authored by LukeZhuang).
fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp
Jun 23 2020, 2:00 PM
erichkeane closed D82403: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp.
Jun 23 2020, 1:59 PM · Restricted Project, Restricted Project
erichkeane accepted D82403: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp.

1 suggestion to the test, but otherwise looks OK. Let me know if you'd like this committed for you.

Jun 23 2020, 1:26 PM · Restricted Project, Restricted Project
erichkeane committed rG79ceda2e394c: Fix test added by D79830 (authored by erichkeane).
Fix test added by D79830
Jun 23 2020, 9:04 AM
erichkeane added a comment to D79830: Add support of __builtin_expect_with_probability.

@LukeZhuang : This patch causes the buildbots to fail, as O1 means something slightly different with the new pass manager :
http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/10542/steps/test-check-all/logs/FAIL%3A%20Clang%3A%3Abuiltin-expect-with-probability.cpp

Jun 23 2020, 9:04 AM · Restricted Project, Restricted Project

Jun 22 2020

erichkeane added a comment to D79830: Add support of __builtin_expect_with_probability.

Thank you very much!

Jun 22 2020, 2:31 PM · Restricted Project, Restricted Project
erichkeane added a comment to D79830: Add support of __builtin_expect_with_probability.

I'll get this fixed, thanks both of you for letting me know.

Jun 22 2020, 12:54 PM · Restricted Project, Restricted Project