- User Since
- Jun 28 2016, 8:37 AM (137 w, 6 d)
Fri, Feb 8
The justification is correct based on my research into this problem, and the code changes themselves look correct. I cannot think of any reason why re-stating the alignment will matter in GCC mode, so I think this is OK.
Thu, Feb 7
Fri, Feb 1
This seems innocuous to me. I don't see any problem with it, but please don't commit until the others have had time to look.
Tue, Jan 29
Fri, Jan 25
LGTM, thanks for doing this!
Thu, Jan 24
Jan 18 2019
Taking a look now, thank you for letting me know!
Jan 17 2019
Jan 16 2019
I think this is a good start. That said, this is also a bug-fix (not exactly NFC), since it adds the Clang check to AppleClang.
This patch has run its course.
Jan 15 2019
For what it's worth, the stricter version of this patch received quite overwhelming support in May. We delayed it due to Google's limitations and yet we still don't seem to have made progress. This current patch is a result of a continued set of compromises to try to satisfy a few in the vocal minority. I'd suggest that we all agree to have an ACTUAL decision made on llvm-dev, rather than this constant state of consensus derailed by vocal minority.
Update branch date to match the 7.0.0 from 8.0.0 branch date.
Jan 11 2019
Fixed @lebedev.ri s comments.
Added Policy guidance for the change process to CheckCompilerVersion.cmake.
Jan 9 2019
Fixing my awful inattention to spelling in a few places, moving the AppleClang code to be more clear for future updates.
Few more fixes suggested by @jfb . Also, added AppleClang to the check.
Change language to make this a 'guideline' instead of a hardline policy.
Reworded a thing. Still needs direction feedback for 8.0.
Jan 8 2019
Jan 7 2019
Jan 4 2019
Dec 18 2018
Dec 17 2018
Dec 14 2018
As stated in CFE commits (in response to Richard's comments):
Should catch me up on all comments except @zturner's llvm-undname feature request :)
@jfb encouraged me to ping this, whats the current status/thoughts on this?
Dec 13 2018
Is there any feedback here? Am I just completely incorrect in how I tried to fix this?
Dec 12 2018
As mentioned, the @rsmith comments that I thought were doable without feedback.
I got a couple of @rsmith's requests done. Most importantly I suspect is MultiVersionFuncs, though NotForDefinition vs ForDefinition is perhpas something you'll find important.
Dec 11 2018
Thanks @aaron.ballman . This should fix all of your complaints.