Page MenuHomePhabricator

erichkeane (Erich Keane)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 8:37 AM (156 w, 12 h)

Recent Activity

Today

erichkeane committed rGad28befcf49c: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty> (authored by erichkeane).
Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>
Tue, Jun 25, 5:10 PM
erichkeane committed rL364364: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>
Tue, Jun 25, 5:09 PM
erichkeane closed D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Tue, Jun 25, 5:09 PM · Restricted Project

Yesterday

erichkeane committed rGc6d0281d9163: First attempt at __unique_stable_name (authored by erichkeane).
First attempt at __unique_stable_name
Mon, Jun 24, 12:03 PM

Fri, Jun 21

erichkeane committed rGa9bfda08ca9d: Remove binary finally accidentially committed in r364109 (authored by erichkeane).
Remove binary finally accidentially committed in r364109
Fri, Jun 21, 3:33 PM
erichkeane committed rG36176249d136: Ensure Target Features always_inline error happens in C++ cases. (authored by erichkeane).
Ensure Target Features always_inline error happens in C++ cases.
Fri, Jun 21, 3:33 PM
erichkeane committed rL364110: Remove binary finally accidentially committed in r364109.
Remove binary finally accidentially committed in r364109
Fri, Jun 21, 3:33 PM
erichkeane committed rL364109: Ensure Target Features always_inline error happens in C++ cases..
Ensure Target Features always_inline error happens in C++ cases.
Fri, Jun 21, 3:30 PM
erichkeane added a comment to D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.

Can someone take a look at this?
@sdesmalen in particular, I'd love it if you could take a look since you're the author of this code.

Thanks, I definitely want to take a look but I’m currently traveling without access to my laptop, so I won’t be able to properly review it until Wednesday.

Fri, Jun 21, 10:17 AM · Restricted Project

Thu, Jun 20

erichkeane updated the diff for D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Thu, Jun 20, 1:37 PM · Restricted Project
erichkeane added inline comments to D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Thu, Jun 20, 1:37 PM · Restricted Project
erichkeane added a comment to D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.

Can someone take a look at this?
@sdesmalen in particular, I'd love it if you could take a look since you're the author of this code.

Thu, Jun 20, 7:22 AM · Restricted Project
erichkeane added a reviewer for D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>: craig.topper.
Thu, Jun 20, 7:22 AM · Restricted Project

Tue, Jun 18

erichkeane created D63507: Teach TableGen Intrin Emitter to handle LLVMPointerType<llvm_any_ty>.
Tue, Jun 18, 11:30 AM · Restricted Project
erichkeane closed D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Tue, Jun 18, 10:21 AM · Restricted Project
erichkeane added an edge to rL363288: PR42182: Allow thread-local to use __cxa_thread_atexit when: D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Tue, Jun 18, 10:21 AM
erichkeane added 3 commit(s) for D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used: rL363288: PR42182: Allow thread-local to use __cxa_thread_atexit when, rC363288: PR42182: Allow thread-local to use __cxa_thread_atexit when, rG34ec6929a1fb: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit….
Tue, Jun 18, 10:21 AM · Restricted Project
erichkeane added an edge to rG34ec6929a1fb: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit…: D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Tue, Jun 18, 10:21 AM

Thu, Jun 13

erichkeane committed rG34ec6929a1fb: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit… (authored by erichkeane).
PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit…
Thu, Jun 13, 11:18 AM
erichkeane committed rL363288: PR42182: Allow thread-local to use __cxa_thread_atexit when.
PR42182: Allow thread-local to use __cxa_thread_atexit when
Thu, Jun 13, 11:18 AM
erichkeane updated the diff for D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.

Update the comment as requested by @rjmccall

Thu, Jun 13, 11:12 AM · Restricted Project
erichkeane created D63283: PR42182: Allow thread-local to use __cxa_thread_atexit when -fno-use-cxx-atexit is used.
Thu, Jun 13, 10:08 AM · Restricted Project

Tue, Jun 11

erichkeane committed rGd65ef6735aca: Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp (authored by erichkeane).
Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp
Tue, Jun 11, 7:56 AM
erichkeane committed rL363074: Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp.
Fix for r42230, MSVC test failure in DependencyDirectivesSourceMinimizerTest.cpp
Tue, Jun 11, 7:55 AM

Wed, Jun 5

erichkeane committed rGda59652c1ba1: Avoid using NoThrow Exception Specifier in non-C++ Modes. (authored by erichkeane).
Avoid using NoThrow Exception Specifier in non-C++ Modes.
Wed, Jun 5, 7:09 AM
erichkeane committed rL362607: Avoid using NoThrow Exception Specifier in non-C++ Modes..
Avoid using NoThrow Exception Specifier in non-C++ Modes.
Wed, Jun 5, 7:07 AM

Tue, Jun 4

erichkeane added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

Was this committed accidentally?

Today in master I see:

  • r362106: Revert "clang support gnu asm goto." Erich Keane <erich.keane@intel.com>
  • r362059: Mark CodeGen/asm-goto.c as x86 specific after r362045 Fangrui Song <maskray@google.com>
  • r362045: clang support gnu asm goto. Jennifer Yu <jennifer.yu@intel.com>

    and yet this Phabricator review is still open.

    It may be easier to rebase this into a monorepo checkout, then commit with git llvm push. https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git

    As @kees noted, for new test files that contain x86 assembly, they need a -triple that specifies an x86 target, otherwise the implicit target is based on the host, which may not be x86. We still want to verify that non-x86 host can cross compile to x86 correctly. Sorry we did not catch this earlier in code review.
Tue, Jun 4, 8:52 AM

Mon, Jun 3

erichkeane committed rGdd0adae65a70: Fix test failure from r362435 (authored by erichkeane).
Fix test failure from r362435
Mon, Jun 3, 12:55 PM
erichkeane committed rL362443: Fix test failure from r362435.
Fix test failure from r362435
Mon, Jun 3, 12:55 PM
erichkeane committed rGbf37536a351a: Make NoThrow FunctionLike, make FunctionLike include references, fix prettyprint (authored by erichkeane).
Make NoThrow FunctionLike, make FunctionLike include references, fix prettyprint
Mon, Jun 3, 11:34 AM
erichkeane committed rG81ef625080cb: Permit Exception Spec mismatch with NoThrow on inherited Virtual (authored by erichkeane).
Permit Exception Spec mismatch with NoThrow on inherited Virtual
Mon, Jun 3, 11:34 AM
erichkeane committed rL362435: Make NoThrow FunctionLike, make FunctionLike include references, fix.
Make NoThrow FunctionLike, make FunctionLike include references, fix
Mon, Jun 3, 11:34 AM
erichkeane committed rL362434: Permit Exception Spec mismatch with NoThrow on inherited Virtual.
Permit Exception Spec mismatch with NoThrow on inherited Virtual
Mon, Jun 3, 11:34 AM

Fri, May 31

erichkeane committed rG68fa6ddb9d44: Replace 'default' in an enum-over-a-switch with the missing list. (authored by erichkeane).
Replace 'default' in an enum-over-a-switch with the missing list.
Fri, May 31, 9:59 AM
erichkeane committed rL362245: Replace 'default' in an enum-over-a-switch with the missing list..
Replace 'default' in an enum-over-a-switch with the missing list.
Fri, May 31, 9:59 AM
erichkeane committed rGc61762797ea4: Suppress nothrow/Exception spec conflict warning when we dont know the ES. (authored by erichkeane).
Suppress nothrow/Exception spec conflict warning when we dont know the ES.
Fri, May 31, 9:47 AM
erichkeane committed rL362243: Suppress nothrow/Exception spec conflict warning when we dont know the ES..
Suppress nothrow/Exception spec conflict warning when we dont know the ES.
Fri, May 31, 9:43 AM
erichkeane committed rG24016eb37466: Suppress nothrow/exception spec conflict warning when ES is parsed. (authored by erichkeane).
Suppress nothrow/exception spec conflict warning when ES is parsed.
Fri, May 31, 8:59 AM
erichkeane committed rL362236: Suppress nothrow/exception spec conflict warning when ES is parsed..
Suppress nothrow/exception spec conflict warning when ES is parsed.
Fri, May 31, 8:53 AM
erichkeane committed rG54182eb7b0db: Fix for PR42089, regression from r362119 (authored by erichkeane).
Fix for PR42089, regression from r362119
Fri, May 31, 7:27 AM
erichkeane committed rL362225: Fix for PR42089, regression from r362119.
Fix for PR42089, regression from r362119
Fri, May 31, 7:23 AM
erichkeane added a comment to D62435: Add Attribute NoThrow as an Exception Specifier Type.

This change broke compiling Qt on MinGW, see https://bugs.llvm.org/show_bug.cgi?id=42089. Trivially reproducible by trying to compile a snippet that looks like this:

class Foo {
public:
        __attribute__((nothrow)) void __attribute__((__stdcall__)) Bar();
};

void Foo::Bar() {
}

Reproducible by compiling the same snippet for a windows-msvc target as well.

Fri, May 31, 6:30 AM · Restricted Project, Restricted Project

Thu, May 30

erichkeane committed rGfc3dfd3e35a6: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand. (authored by erichkeane).
Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.
Thu, May 30, 2:35 PM
erichkeane committed rL362157: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
Fix constexpr __builtin_*_overflow issue when unsigned->signed operand.
Thu, May 30, 2:35 PM
erichkeane closed D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
Thu, May 30, 2:35 PM · Restricted Project
erichkeane updated the diff for D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
Thu, May 30, 12:13 PM · Restricted Project
erichkeane added inline comments to D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
Thu, May 30, 11:56 AM · Restricted Project
erichkeane committed rGd02f4a1043c0: Add Attribute NoThrow as an Exception Specifier Type (authored by erichkeane).
Add Attribute NoThrow as an Exception Specifier Type
Thu, May 30, 11:14 AM
erichkeane committed rL362119: Add Attribute NoThrow as an Exception Specifier Type.
Add Attribute NoThrow as an Exception Specifier Type
Thu, May 30, 11:14 AM
erichkeane committed rC362119: Add Attribute NoThrow as an Exception Specifier Type.
Add Attribute NoThrow as an Exception Specifier Type
Thu, May 30, 11:14 AM
erichkeane closed D62435: Add Attribute NoThrow as an Exception Specifier Type.
Thu, May 30, 11:13 AM · Restricted Project, Restricted Project
erichkeane added a reverting change for rG954ec09aed4f: clang support gnu asm goto. Syntax: asm [volatile] goto ( AssemblerTemplate…: rGd0f34fd19850: Revert "clang support gnu asm goto.".
Thu, May 30, 11:11 AM
erichkeane committed rGd0f34fd19850: Revert "clang support gnu asm goto." (authored by erichkeane).
Revert "clang support gnu asm goto."
Thu, May 30, 11:11 AM
erichkeane committed rC362106: Revert "clang support gnu asm goto.".
Revert "clang support gnu asm goto."
Thu, May 30, 11:11 AM
erichkeane committed rL362106: Revert "clang support gnu asm goto.".
Revert "clang support gnu asm goto."
Thu, May 30, 11:11 AM
erichkeane added inline comments to D62435: Add Attribute NoThrow as an Exception Specifier Type.
Thu, May 30, 10:06 AM · Restricted Project, Restricted Project
erichkeane created D62665: Fix constexpr __builtin_*_overflow issue when unsigned->signed operand..
Thu, May 30, 7:35 AM · Restricted Project

Wed, May 29

erichkeane accepted D62580: [OpenCL] Use long instead of long long in x86 builtins.

Conditional approval, commit with the comment fixed. Let me know if you need me to commit it for you.

Wed, May 29, 12:03 PM · Restricted Project, Restricted Project
erichkeane committed rGd2143c370805: Add curley brackets to case statement that declares a variable. (authored by erichkeane).
Add curley brackets to case statement that declares a variable.
Wed, May 29, 10:03 AM
erichkeane committed rC361992: Add curley brackets to case statement that declares a variable..
Add curley brackets to case statement that declares a variable.
Wed, May 29, 10:03 AM
erichkeane committed rL361992: Add curley brackets to case statement that declares a variable..
Add curley brackets to case statement that declares a variable.
Wed, May 29, 10:03 AM
erichkeane added a comment to D62580: [OpenCL] Use long instead of long long in x86 builtins.

A different (perhaps silly) question is why 'W' isn't sufficient? It represents int64_t, which I wonder if is sufficient.

Wed, May 29, 8:50 AM · Restricted Project, Restricted Project
erichkeane added a comment to D62580: [OpenCL] Use long instead of long long in x86 builtins.

'O' is an interesting choice. Any real justification for it, or just "what was available"? It definitely needs to be documented in the top of Builtins.def however.

Wed, May 29, 8:44 AM · Restricted Project, Restricted Project

Tue, May 28

erichkeane updated the diff for D62435: Add Attribute NoThrow as an Exception Specifier Type.

Added warning + other comments from @aaron.ballman

Tue, May 28, 7:49 AM · Restricted Project, Restricted Project

Mon, May 27

erichkeane added inline comments to D62435: Add Attribute NoThrow as an Exception Specifier Type.
Mon, May 27, 9:50 AM · Restricted Project, Restricted Project

May 25 2019

erichkeane updated the diff for D62435: Add Attribute NoThrow as an Exception Specifier Type.

Reread @rsmith's comments and surrounding code and found what I believe is the correct answer to these comments :)

May 25 2019, 8:49 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D62435: Add Attribute NoThrow as an Exception Specifier Type.
May 25 2019, 6:47 AM · Restricted Project, Restricted Project

May 24 2019

erichkeane created D62435: Add Attribute NoThrow as an Exception Specifier Type.
May 24 2019, 4:14 PM · Restricted Project, Restricted Project
erichkeane added inline comments to D53157: Teach the IRBuilder about constrained fadd and friends.
May 24 2019, 12:07 PM
erichkeane added reviewers for D61743: New clang option -MD-filter=prefix to filter files from make dependencies: probinson, eli.friedman, dstenb, vsapsai.
May 24 2019, 11:34 AM · Restricted Project, Restricted Project

May 23 2019

erichkeane committed rG000228183bf1: Ensure builtins use the target default Calling Convention (authored by erichkeane).
Ensure builtins use the target default Calling Convention
May 23 2019, 9:05 AM
erichkeane committed rL361507: Ensure builtins use the target default Calling Convention.
Ensure builtins use the target default Calling Convention
May 23 2019, 9:04 AM
erichkeane committed rC361507: Ensure builtins use the target default Calling Convention.
Ensure builtins use the target default Calling Convention
May 23 2019, 9:04 AM

Mar 21 2019

erichkeane committed rG505427cb2fe4: Permit redeclarations of a builtin to specify calling convention. (authored by erichkeane).
Permit redeclarations of a builtin to specify calling convention.
Mar 21 2019, 6:32 AM
erichkeane committed rL356663: Permit redeclarations of a builtin to specify calling convention..
Permit redeclarations of a builtin to specify calling convention.
Mar 21 2019, 6:32 AM
erichkeane committed rC356663: Permit redeclarations of a builtin to specify calling convention..
Permit redeclarations of a builtin to specify calling convention.
Mar 21 2019, 6:32 AM
erichkeane closed D59560: Permit redeclarations of a builtin to specify calling convention. .
Mar 21 2019, 6:32 AM · Restricted Project

Mar 20 2019

erichkeane updated the diff for D59560: Permit redeclarations of a builtin to specify calling convention. .

Woops! Look like I left without actually changing the revision *shame*.

Mar 20 2019, 6:36 AM · Restricted Project
erichkeane accepted D59578: [X86] Remove getCPUKindCanonicalName which seems to be unused..
Mar 20 2019, 6:05 AM · Restricted Project, Restricted Project

Mar 19 2019

erichkeane updated the diff for D59560: Permit redeclarations of a builtin to specify calling convention. .

As @rnk suggested, switch to an enum. SemaType.cpp unfortunately has Sema as a forward declaration, so it has to use integers.

Mar 19 2019, 3:00 PM · Restricted Project
erichkeane added inline comments to D59560: Permit redeclarations of a builtin to specify calling convention. .
Mar 19 2019, 2:18 PM · Restricted Project
erichkeane created D59560: Permit redeclarations of a builtin to specify calling convention. .
Mar 19 2019, 1:53 PM · Restricted Project
Herald added a reviewer for D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin: jfb.

@mgorny @hfinkel @eli.friedman @jyknight @dim
Is there any chance we can get this in any time soon? It fixes a couple of header issues that we've noticed. Others added, since it appears this dependent on https://reviews.llvm.org/D29542 ?

Mar 19 2019, 1:04 PM · Restricted Project

Mar 13 2019

erichkeane added a comment to D59307: Patch llvm bug 41033 concerning atomicity of statement expressions.

This is my concern here:
https://godbolt.org/z/icS4fa
The patch will change template instantiation.

Mar 13 2019, 11:32 AM · Restricted Project
erichkeane added a reviewer for D59307: Patch llvm bug 41033 concerning atomicity of statement expressions: rnk.
Mar 13 2019, 9:54 AM · Restricted Project

Mar 8 2019

erichkeane committed rG92146ce399cd: Re-fix _lrotl/_lrotr to always take Long, no matter the platform. (authored by erichkeane).
Re-fix _lrotl/_lrotr to always take Long, no matter the platform.
Mar 8 2019, 7:10 AM
erichkeane committed rG00a5b4a27577: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms." (authored by erichkeane).
Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."
Mar 8 2019, 7:10 AM
erichkeane committed rC355698: Re-fix _lrotl/_lrotr to always take Long, no matter the platform..
Re-fix _lrotl/_lrotr to always take Long, no matter the platform.
Mar 8 2019, 7:10 AM
erichkeane committed rC355697: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.".
Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."
Mar 8 2019, 7:10 AM
erichkeane committed rL355698: Re-fix _lrotl/_lrotr to always take Long, no matter the platform..
Re-fix _lrotl/_lrotr to always take Long, no matter the platform.
Mar 8 2019, 7:10 AM
erichkeane committed rL355697: Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.".
Revert "Enable _rotl, _lrotl, _rotr, _lrotr on all platforms."
Mar 8 2019, 7:10 AM
erichkeane added a comment to D59105: [RFC] Create an Arbitrary Precision Integer Type..

Thank you @rsmith for the quick review! I really appreciate it.

Mar 8 2019, 6:41 AM

Mar 7 2019

erichkeane created D59105: [RFC] Create an Arbitrary Precision Integer Type..
Mar 7 2019, 12:28 PM

Mar 4 2019

erichkeane committed rGac8d1b7017ff: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms. (authored by erichkeane).
Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.
Mar 4 2019, 10:51 AM
erichkeane committed rC355322: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms..
Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.
Mar 4 2019, 10:50 AM
erichkeane committed rL355322: Enable _rotl, _lrotl, _rotr, _lrotr on all platforms..
Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.
Mar 4 2019, 10:50 AM
erichkeane committed rC355317: Give builtins and alloc/dealloc operators the default calling convention..
Give builtins and alloc/dealloc operators the default calling convention.
Mar 4 2019, 6:55 AM
erichkeane committed rG881e83d8b94f: Give builtins and alloc/dealloc operators the default calling convention. (authored by erichkeane).
Give builtins and alloc/dealloc operators the default calling convention.
Mar 4 2019, 6:54 AM
erichkeane committed rL355317: Give builtins and alloc/dealloc operators the default calling convention..
Give builtins and alloc/dealloc operators the default calling convention.
Mar 4 2019, 6:54 AM
erichkeane closed D58844: Give builtins and alloc/dealloc operators the default calling convention..
Mar 4 2019, 6:54 AM · Restricted Project, Restricted Project