- User Since
- Jun 28 2016, 8:37 AM (146 w, 3 d)
Thu, Mar 21
Mar 20 2019
Woops! Look like I left without actually changing the revision *shame*.
Mar 19 2019
As @rnk suggested, switch to an enum. SemaType.cpp unfortunately has Sema as a forward declaration, so it has to use integers.
@mgorny @hfinkel @eli.friedman @jyknight @dim
Is there any chance we can get this in any time soon? It fixes a couple of header issues that we've noticed. Others added, since it appears this dependent on https://reviews.llvm.org/D29542 ?
Mar 13 2019
This is my concern here:
The patch will change template instantiation.
Mar 8 2019
Thank you @rsmith for the quick review! I really appreciate it.
Mar 7 2019
Mar 4 2019
Mar 1 2019
Feb 8 2019
The justification is correct based on my research into this problem, and the code changes themselves look correct. I cannot think of any reason why re-stating the alignment will matter in GCC mode, so I think this is OK.
Feb 7 2019
Feb 1 2019
This seems innocuous to me. I don't see any problem with it, but please don't commit until the others have had time to look.
Jan 29 2019
Jan 25 2019
LGTM, thanks for doing this!
Jan 24 2019
Jan 18 2019
Taking a look now, thank you for letting me know!
Jan 17 2019
Jan 16 2019
I think this is a good start. That said, this is also a bug-fix (not exactly NFC), since it adds the Clang check to AppleClang.
This patch has run its course.
Jan 15 2019
For what it's worth, the stricter version of this patch received quite overwhelming support in May. We delayed it due to Google's limitations and yet we still don't seem to have made progress. This current patch is a result of a continued set of compromises to try to satisfy a few in the vocal minority. I'd suggest that we all agree to have an ACTUAL decision made on llvm-dev, rather than this constant state of consensus derailed by vocal minority.
Update branch date to match the 7.0.0 from 8.0.0 branch date.
Jan 11 2019
Fixed @lebedev.ri s comments.
Added Policy guidance for the change process to CheckCompilerVersion.cmake.
Jan 9 2019
Fixing my awful inattention to spelling in a few places, moving the AppleClang code to be more clear for future updates.
Few more fixes suggested by @jfb . Also, added AppleClang to the check.
Change language to make this a 'guideline' instead of a hardline policy.
Reworded a thing. Still needs direction feedback for 8.0.
Jan 8 2019
Jan 7 2019
Jan 4 2019