- User Since
- Jun 28 2016, 8:37 AM (99 w, 1 d)
Fri, May 18
Wed, May 16
Woops, forgot the tests when commiting, so see R332492 for the lit tests.
Thu, May 10
Additionally, IMO, I'd think we would be better off specifying Clang 3.5. Being able to specify c++14 vs c++1y seems worth the minor inconvenience unless there is a platform we care about that ships 3.4. FWIW, 5.1 supports c++14.
Tue, May 8
Mon, May 7
Aaron's comments :)
Did Review-after-commit, in retrospect this is a pretty tiny change.
Fri, May 4
Thu, May 3
When building this, it didn't build since you'd reused the name. I changed the variable to be named "Dest" instead of "Destination"
This looks fine to me. Let me know if you need me to commit this for you.
Tue, May 1
Apr 19 2018
LGTM, Do you have commit access, or do you want me to commit it for you?
Can you make sure that this doesn't cause stackrealign to happen 2x if using -mstackrealign? Additionally, please provide the diff with full-context (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). What is the commit before this? The line numbers don't look right to me.
Apr 17 2018
FWIW, this demangles on both demangler.com and undname as "void cdecl Float16::f(struct clang::_Float16)", which seems like the right thing, since the "Complex" above demangles to: "void cdecl Complex::f(struct clang::_Complex<int>)"
Apr 16 2018
Revert unnecessary test changes... :/
Added the exception for MSVC's va_start. va_start is a normal function on Linux, so it isn't an error on non-windows either.
Apr 12 2018
Apr 10 2018
Restrict overloads as well.
Eli's suggestion for implementation.
Apr 9 2018
Apr 6 2018
One big issue with just disallowing redecls of builtins is we have is that a number of these are actually expected to be in the system headers/libraries (such as vprintf). A ton of the math.h functions are also builtins.
Mar 23 2018
My opinion matters less than @rsmith or @dblaikie on the review, but it seems to me that Typedef and Using are SO similar that the implementations should just be combined. You'd likely have to change a couple of types along the way to be more generic, but the implementations are essentially a copy/paste of eachother.
Mar 22 2018
Mar 20 2018
Mar 19 2018
Adding @mibintc to take a look, as she's a good representative of the ICC dev team.
Mar 8 2018
Mar 6 2018
Mar 2 2018
Talked to Aaron and came up with a way of covering with a testcase.
Feb 28 2018
Feb 26 2018
Feb 22 2018
It seems to me that the test here is very much lacking. It doesn't seem to include the example you've mentioned, and has no validation to ensure that there is a single instantiation happening. I'd like to see what happens when a UUID is passed as a pack, how SFINAE works on it, etc.