Page MenuHomePhabricator

erichkeane (Erich Keane)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2016, 8:37 AM (172 w, 1 d)

Recent Activity

Fri, Oct 11

erichkeane committed rGadd0786dbaa8: Fix test failure with 374562 on Hexagon (authored by erichkeane).
Fix test failure with 374562 on Hexagon
Fri, Oct 11, 9:38 AM
erichkeane committed rL374569: Fix test failure with 374562 on Hexagon.
Fix test failure with 374562 on Hexagon
Fri, Oct 11, 9:28 AM
erichkeane committed rGf75939599421: Reland r374450 with Richard Smith's comments and test fixed. (authored by erichkeane).
Reland r374450 with Richard Smith's comments and test fixed.
Fri, Oct 11, 8:05 AM
erichkeane committed rL374562: Reland r374450 with Richard Smith's comments and test fixed..
Reland r374450 with Richard Smith's comments and test fixed.
Fri, Oct 11, 8:05 AM
erichkeane updated subscribers of D68824: Fix __builtin_assume_aligned with too large values..

This seems to be missing a CodeGen test for what IR we generate on an overly-large alignment. (The warning says the alignment is ignored, but I don't see where you're actually doing anything different in that case when generating IR.)

Fri, Oct 11, 6:12 AM

Thu, Oct 10

erichkeane committed rG31e454c1ecac: Fix __builtin_assume_aligned with too large values. (authored by erichkeane).
Fix __builtin_assume_aligned with too large values.
Thu, Oct 10, 2:15 PM
erichkeane added an edge to rL374450: Fix __builtin_assume_aligned with too large values.: D68824: Fix __builtin_assume_aligned with too large values..
Thu, Oct 10, 2:15 PM
erichkeane closed D68824: Fix __builtin_assume_aligned with too large values..
Thu, Oct 10, 2:15 PM
erichkeane added 1 commit(s) for D68824: Fix __builtin_assume_aligned with too large values.: rL374450: Fix __builtin_assume_aligned with too large values..
Thu, Oct 10, 2:15 PM
erichkeane removed an edge from rL374450: Fix __builtin_assume_aligned with too large values.: D68824: Fix __builtin_assume_aligned with too large values..
Thu, Oct 10, 2:15 PM
erichkeane removed 1 commit(s) for D68824: Fix __builtin_assume_aligned with too large values.: rL374450: Fix __builtin_assume_aligned with too large values..
Thu, Oct 10, 2:15 PM
erichkeane committed rL374450: Fix __builtin_assume_aligned with too large values..
Fix __builtin_assume_aligned with too large values.
Thu, Oct 10, 2:06 PM
erichkeane updated the diff for D68824: Fix __builtin_assume_aligned with too large values..

cant use llvm::Value in Sema without some linker issues.

Thu, Oct 10, 1:07 PM
erichkeane updated the diff for D68824: Fix __builtin_assume_aligned with too large values..

Hal's comments

Thu, Oct 10, 12:57 PM
erichkeane updated the diff for D68824: Fix __builtin_assume_aligned with too large values..

Remove unused code

Thu, Oct 10, 12:39 PM
erichkeane created D68824: Fix __builtin_assume_aligned with too large values..
Thu, Oct 10, 12:28 PM

Wed, Oct 9

erichkeane added inline comments to D68521: [PATCH 36/38] [noalias] Clang CodeGen for restrict-qualified pointers.
Wed, Oct 9, 2:32 PM · Restricted Project
erichkeane added inline comments to D68519: [PATCH 35/38] [noalias] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers.
Wed, Oct 9, 2:31 PM

Tue, Oct 8

erichkeane added inline comments to D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize..
Tue, Oct 8, 9:24 AM · Restricted Project

Mon, Oct 7

erichkeane committed rG8a410bcef02c: Fix Calling Convention through aliases (authored by erichkeane).
Fix Calling Convention through aliases
Mon, Oct 7, 10:16 PM
erichkeane committed rL373929: Fix Calling Convention through aliases.
Fix Calling Convention through aliases
Mon, Oct 7, 10:16 PM
erichkeane closed D68584: Fix Calling Convention through aliases.
Mon, Oct 7, 10:16 PM · Restricted Project
erichkeane created D68584: Fix Calling Convention through aliases.
Mon, Oct 7, 8:46 AM · Restricted Project

Mon, Sep 30

erichkeane committed rG98f089994210: Make function static that didn't need linkage. (authored by erichkeane).
Make function static that didn't need linkage.
Mon, Sep 30, 2:24 PM
erichkeane committed rL373268: Make function static that didn't need linkage..
Make function static that didn't need linkage.
Mon, Sep 30, 2:23 PM
erichkeane committed rGa60ef724b4bb: Fix failure caused by r373247 (authored by erichkeane).
Fix failure caused by r373247
Mon, Sep 30, 1:46 PM
erichkeane committed rL373259: Fix failure caused by r373247.
Fix failure caused by r373247
Mon, Sep 30, 1:43 PM
erichkeane committed rG5c2c60d2fc27: Teach CallGraph to look into Generic Lambdas. (authored by erichkeane).
Teach CallGraph to look into Generic Lambdas.
Mon, Sep 30, 12:11 PM
erichkeane committed rL373247: Teach CallGraph to look into Generic Lambdas..
Teach CallGraph to look into Generic Lambdas.
Mon, Sep 30, 12:10 PM

Fri, Sep 27

erichkeane updated subscribers of D68050: WIP Make attribute target work better with AArch64.

Ah, Ugg... GCC must implement the target parsing handling different on a per-architecture basis (ARM vs X86). We've only got parsing in place to do the x86 way. That ends up making this a much more difficult thing to maintain I suspect.

Fri, Sep 27, 10:36 AM · Restricted Project

Thu, Sep 26

erichkeane added inline comments to D68050: WIP Make attribute target work better with AArch64.
Thu, Sep 26, 6:06 AM · Restricted Project

Wed, Sep 25

erichkeane created D68050: WIP Make attribute target work better with AArch64.
Wed, Sep 25, 2:00 PM · Restricted Project

Mon, Sep 23

erichkeane accepted D67924: [Sema] Fix the atomic expr rebuilding order..
Mon, Sep 23, 11:36 AM · Restricted Project, Restricted Project
erichkeane added a comment to D67924: [Sema] Fix the atomic expr rebuilding order..

Seems your test changes have disappeared as well? Otherwise, 1 comment then I'm ok with this.

Mon, Sep 23, 11:12 AM · Restricted Project, Restricted Project
erichkeane added a comment to D67924: [Sema] Fix the atomic expr rebuilding order..

Also, can you add a test for GNUCmpXchg in both situations (inside a template, and outside)? It is the most complicated, and would best reflect the issue.

Mon, Sep 23, 11:00 AM · Restricted Project, Restricted Project
erichkeane added a comment to D67924: [Sema] Fix the atomic expr rebuilding order..

It kinda stinks that we have to do this at such a late step. I'd have much preferred doing this as a part of the rebuild, but it appears that the 'form' takes quite a bit to calculate. Also, I'd likely have preferred that the initial reordering happened in codegen instead of this early, though perhaps thats too large of a change to do here.

Mon, Sep 23, 10:47 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67924: [Sema] Fix the atomic expr rebuilding order..
Mon, Sep 23, 10:21 AM · Restricted Project, Restricted Project
erichkeane added a comment to D67924: [Sema] Fix the atomic expr rebuilding order..

Yikes, good catch!

Mon, Sep 23, 10:21 AM · Restricted Project, Restricted Project
erichkeane committed rGa957eaad0091: Fix test atomic-expr.cpp after R372422 (authored by erichkeane).
Fix test atomic-expr.cpp after R372422
Mon, Sep 23, 7:12 AM
erichkeane committed rL372611: Fix test atomic-expr.cpp after R372422.
Fix test atomic-expr.cpp after R372422
Mon, Sep 23, 7:11 AM
erichkeane added a comment to D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform.

@erichkeane The atomic-expr.cpp test is failing on some MSVC buildbots, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/

On it. Buildbot never emailed me I guess *shrug*.

Mon, Sep 23, 6:31 AM · Restricted Project
erichkeane added a comment to D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform.

@erichkeane The atomic-expr.cpp test is failing on some MSVC buildbots, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/

Mon, Sep 23, 6:24 AM · Restricted Project

Fri, Sep 20

erichkeane committed rG830909b97a9a: Ensure AtomicExpr goes through SEMA checking after TreeTransform (authored by erichkeane).
Ensure AtomicExpr goes through SEMA checking after TreeTransform
Fri, Sep 20, 12:17 PM
erichkeane committed rL372422: Ensure AtomicExpr goes through SEMA checking after TreeTransform.
Ensure AtomicExpr goes through SEMA checking after TreeTransform
Fri, Sep 20, 12:16 PM
erichkeane closed D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform.
Fri, Sep 20, 12:15 PM · Restricted Project
erichkeane created D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform.
Fri, Sep 20, 11:37 AM · Restricted Project

Wed, Sep 18

erichkeane committed rGf124ab9fe115: Recommit -r372180 (authored by erichkeane).
Recommit -r372180
Wed, Sep 18, 8:16 AM
erichkeane committed rL372229: Recommit -r372180.
Recommit -r372180
Wed, Sep 18, 8:08 AM
erichkeane closed D67517: Create UsersManual section entitled 'Controlling Floating Point Behavior'.
Wed, Sep 18, 8:08 AM · Restricted Project

Tue, Sep 17

erichkeane committed rGf478c8bf9265: Revert "Create UsersManual section entitled 'Controlling Floating Point" (authored by erichkeane).
Revert "Create UsersManual section entitled 'Controlling Floating Point"
Tue, Sep 17, 2:28 PM
erichkeane added a reverting change for rGa08d5a4b0ebd: Create UsersManual section entitled 'Controlling Floating Point Behavior': rGf478c8bf9265: Revert "Create UsersManual section entitled 'Controlling Floating Point".
Tue, Sep 17, 2:28 PM
erichkeane committed rL372185: Revert "Create UsersManual section entitled 'Controlling Floating Point".
Revert "Create UsersManual section entitled 'Controlling Floating Point"
Tue, Sep 17, 2:27 PM
erichkeane committed rGa08d5a4b0ebd: Create UsersManual section entitled 'Controlling Floating Point Behavior' (authored by erichkeane).
Create UsersManual section entitled 'Controlling Floating Point Behavior'
Tue, Sep 17, 1:46 PM
erichkeane committed rL372180: Create UsersManual section entitled 'Controlling Floating Point.
Create UsersManual section entitled 'Controlling Floating Point
Tue, Sep 17, 1:44 PM
erichkeane closed D67517: Create UsersManual section entitled 'Controlling Floating Point Behavior'.
Tue, Sep 17, 1:44 PM · Restricted Project
erichkeane committed rG68b0977e646a: Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings (authored by erichkeane).
Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings
Tue, Sep 17, 7:20 AM
erichkeane committed rL372124: Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings.
Add SpellingNotCalculated to Attribute Enums to suppress UBSan warnings
Tue, Sep 17, 7:10 AM

Sep 16 2019

erichkeane committed rGb79f3319584c: Move some definitions from Sema to Basic to fix shared libs build (authored by erichkeane).
Move some definitions from Sema to Basic to fix shared libs build
Sep 16 2019, 6:59 AM
erichkeane committed rL371985: Move some definitions from Sema to Basic to fix shared libs build.
Move some definitions from Sema to Basic to fix shared libs build
Sep 16 2019, 6:58 AM
erichkeane added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..

Fixed in r371985.

Sep 16 2019, 6:58 AM · Restricted Project
erichkeane added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 16 2019, 6:18 AM · Restricted Project

Sep 15 2019

erichkeane added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 15 2019, 5:31 PM · Restricted Project

Sep 13 2019

erichkeane added a comment to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 13 2019, 11:17 AM · Restricted Project
erichkeane committed rGf9cd381fdfe5: Fix build error in 371875 (authored by erichkeane).
Fix build error in 371875
Sep 13 2019, 10:59 AM
erichkeane committed rL371876: Fix build error in 371875.
Fix build error in 371875
Sep 13 2019, 10:59 AM
erichkeane committed rG6a24e8068052: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr. (authored by erichkeane).
[NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.
Sep 13 2019, 10:43 AM
erichkeane committed rL371875: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
[NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.
Sep 13 2019, 10:43 AM
erichkeane closed D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 13 2019, 10:42 AM · Restricted Project

Sep 12 2019

erichkeane added inline comments to D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 12 2019, 10:02 AM · Restricted Project
erichkeane updated the diff for D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..

I think I've changed everything @aaron.ballman suggested. Despite the size of this patch, it actually removes ~1020 lines of code!

Sep 12 2019, 10:02 AM · Restricted Project

Sep 10 2019

erichkeane accepted D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 10:55 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 9:22 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 8:50 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 10 2019, 6:15 AM · Restricted Project, Restricted Project

Sep 9 2019

erichkeane created D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr..
Sep 9 2019, 1:25 PM · Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 9 2019, 1:16 PM · Restricted Project, Restricted Project

Sep 6 2019

erichkeane committed rL371239: Add myself to list.
Add myself to list
Sep 6 2019, 12:10 PM
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 6 2019, 6:41 AM · Restricted Project, Restricted Project

Sep 5 2019

erichkeane added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

Actually... I think it might need to be weak_odr based on https://llvm.org/docs/LangRef.html#linkage-types

Sep 5 2019, 6:29 AM · Restricted Project, Restricted Project
erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 5 2019, 6:26 AM · Restricted Project, Restricted Project

Sep 4 2019

erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 6:25 AM · Restricted Project, Restricted Project
erichkeane updated subscribers of D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 4 2019, 6:18 AM · Restricted Project, Restricted Project

Sep 3 2019

erichkeane added inline comments to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.
Sep 3 2019, 9:18 AM · Restricted Project, Restricted Project
erichkeane added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

I prefer this to be in the place where the ifunc gets created, otherwise we definitely need tests. There are sufficient tests for this that show the ifunc having been created, so I'd suggest just adding to them.

Sep 3 2019, 6:31 AM · Restricted Project, Restricted Project
erichkeane added a reviewer for D63061: [builtins] Fix overflow issue for complex division with big numbers: craig.topper.
Sep 3 2019, 6:19 AM · Restricted Project, Restricted Project

Sep 2 2019

erichkeane added a comment to D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type.

Tests missing.
Is that what gcc does? I'd personally thought those should be internalized.

Sep 2 2019, 11:12 AM · Restricted Project, Restricted Project

Aug 29 2019

erichkeane requested changes to D66862: Make lround builtin constexpr (and others).

Craig topper pointed out to me that constexpr cannot throw exceptions, and at least the rints can raise some exceptions, which aren't allowed in Constexpr. The round functions similarly hit unspecified behavior, so we need to match that behavior.

Aug 29 2019, 10:16 AM · Restricted Project
erichkeane accepted D66862: Make lround builtin constexpr (and others).

Small nit, just default construct the APFloats.

Aug 29 2019, 10:07 AM · Restricted Project

Aug 28 2019

erichkeane committed rG856f3fe5bbd6: Fix always_inline 'target' compatibility check code for Lambdas (authored by erichkeane).
Fix always_inline 'target' compatibility check code for Lambdas
Aug 28 2019, 2:01 PM
erichkeane committed rL370261: Fix always_inline 'target' compatibility check code for Lambdas.
Fix always_inline 'target' compatibility check code for Lambdas
Aug 28 2019, 2:01 PM

Aug 27 2019

erichkeane added a comment to D66800: Some notes in `LLVM_ENABLE_LIBCXX`.

If your system only has libc++ available but the compiler shipped with it doesn't work out of the box (i.e. without passing -stdlib=libc++), isn't your compiler broken? In other words, it seems to me that your system compiler should always work out of the box without having to pass -stdlib=XXX -- do we agree? If so, I think the bug should be reported to whoever vends the compiler on the platform where you encountered this issue.

Aug 27 2019, 8:31 AM · Restricted Project, Restricted Project
erichkeane added a comment to D66800: Some notes in `LLVM_ENABLE_LIBCXX`.

I would MUCH prefer that the compiler checker actually use the right library. Also, this isn't completely correct, MacOS Clang doesn't have libstdc++ available at all, yet works fine.

Aug 27 2019, 6:49 AM · Restricted Project, Restricted Project

Aug 26 2019

erichkeane committed rGe30b71f9dc0f: Fix -dA flag, it is not a preprocessor flag. (authored by erichkeane).
Fix -dA flag, it is not a preprocessor flag.
Aug 26 2019, 10:13 AM
erichkeane committed rL369926: Fix -dA flag, it is not a preprocessor flag..
Fix -dA flag, it is not a preprocessor flag.
Aug 26 2019, 10:13 AM

Aug 23 2019

erichkeane committed rG23384a1c8dc8: [NFC] Move some variable declarations into their 'if' conditions. (authored by erichkeane).
[NFC] Move some variable declarations into their 'if' conditions.
Aug 23 2019, 8:58 AM
erichkeane committed rL369773: [NFC] Move some variable declarations into their 'if' conditions..
[NFC] Move some variable declarations into their 'if' conditions.
Aug 23 2019, 8:58 AM
erichkeane added a comment to D66597: [preprocessor] Add an opportunity to retain excluded conditional blocks.

I don't have a good idea of the intent of this patch. It seems to me that this could do some pretty nasty damage to C code, right?

Aug 23 2019, 8:51 AM · Restricted Project, Restricted Project

Aug 19 2019

erichkeane committed rGa8abe1f82899: Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668. (authored by erichkeane).
Fix poorly formatted HTML in the cxx_status.html file caused by adding 1668.
Aug 19 2019, 11:19 AM
erichkeane committed rL369286: Fix poorly formatted HTML in the cxx_status.html file caused by adding.
Fix poorly formatted HTML in the cxx_status.html file caused by adding
Aug 19 2019, 11:19 AM
erichkeane committed rGf04d246d7d13: Fix test where diagnostics changed in P1668 implementation (authored by erichkeane).
Fix test where diagnostics changed in P1668 implementation
Aug 19 2019, 11:10 AM