Page MenuHomePhabricator

jsjodin (Jan Sjödin)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 14 2012, 10:49 AM (361 w, 3 d)

Recent Activity

Nov 7 2017

jsjodin added inline comments to D39670: [AMDGPU] Fix pointer info for pseudo source for r600.
Nov 7 2017, 9:38 AM

Sep 14 2017

jsjodin committed rL313302: Fix warnings in r313297..
Fix warnings in r313297.
Sep 14 2017, 2:51 PM
jsjodin committed rL313297: Add AddresSpace to PseudoSourceValue..
Add AddresSpace to PseudoSourceValue.
Sep 14 2017, 1:55 PM
jsjodin closed D35089: Add/Implement AddresSpace to PseudoSourceValue. by committing rL313297: Add AddresSpace to PseudoSourceValue..
Sep 14 2017, 1:55 PM

Sep 12 2017

jsjodin updated the diff for D35089: Add/Implement AddresSpace to PseudoSourceValue. .

Made changes to address comments by Hal Finkel.

Sep 12 2017, 11:17 AM
jsjodin added inline comments to D35089: Add/Implement AddresSpace to PseudoSourceValue. .
Sep 12 2017, 10:16 AM

Sep 11 2017

jsjodin updated the diff for D35089: Add/Implement AddresSpace to PseudoSourceValue. .

Merged code with TOT and made full context patch.

Sep 11 2017, 12:27 PM

Jul 7 2017

jsjodin updated the diff for D35089: Add/Implement AddresSpace to PseudoSourceValue. .

Make TII mandatory (assert if given nullptr) in PSV constructor. Add TII as a member to the PSV manager so that it is not needed in the method calls.

Jul 7 2017, 5:05 AM
jsjodin updated subscribers of D35089: Add/Implement AddresSpace to PseudoSourceValue. .
Jul 7 2017, 4:04 AM
jsjodin added inline comments to D35089: Add/Implement AddresSpace to PseudoSourceValue. .
Jul 7 2017, 3:53 AM

Jul 6 2017

jsjodin created D35089: Add/Implement AddresSpace to PseudoSourceValue. .
Jul 6 2017, 2:30 PM

May 15 2017

jsjodin committed rL303111: Re-submit AMDGPUMachineCFGStructurizer..
Re-submit AMDGPUMachineCFGStructurizer.
May 15 2017, 1:32 PM
jsjodin committed rL303098: Revert 303091..
Revert 303091.
May 15 2017, 11:53 AM
jsjodin added a reverting change for rL303091: Add AMDGPUMachineCFGStructurizer.: rL303098: Revert 303091..
May 15 2017, 11:53 AM
jsjodin committed rL303091: Add AMDGPUMachineCFGStructurizer..
Add AMDGPUMachineCFGStructurizer.
May 15 2017, 11:27 AM
jsjodin closed D23209: Machine Level CFG Structurizer by committing rL303091: Add AMDGPUMachineCFGStructurizer..
May 15 2017, 11:27 AM

May 12 2017

jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Made the implementation of materializeImmediate more compact as Matt suggested.

May 12 2017, 9:22 AM

May 9 2017

jsjodin added inline comments to D23209: Machine Level CFG Structurizer.
May 9 2017, 9:52 AM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Fixed issues raised by Matt.

May 9 2017, 9:50 AM

Apr 24 2017

jsjodin added inline comments to D23209: Machine Level CFG Structurizer.
Apr 24 2017, 1:53 PM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Fixed remaining comments.

Apr 24 2017, 1:50 PM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Fixed issues raised by Matt.

Apr 24 2017, 1:21 PM

Apr 11 2017

jsjodin added a comment to D23209: Machine Level CFG Structurizer.

Also fixed succ_empty.

Apr 11 2017, 11:19 AM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Removed the MachineRegion changes and submitted in a different patch. Fixed a few of the comments made by Matt.

Apr 11 2017, 11:18 AM
jsjodin committed rL299932: Add MachineRegionInfoPassID to Passes.h..
Add MachineRegionInfoPassID to Passes.h.
Apr 11 2017, 4:53 AM
jsjodin closed D31899: Add MachineRegionInfoPassID to Passes.h by committing rL299932: Add MachineRegionInfoPassID to Passes.h..
Apr 11 2017, 4:53 AM

Apr 10 2017

jsjodin created D31899: Add MachineRegionInfoPassID to Passes.h.
Apr 10 2017, 11:23 AM
jsjodin planned changes to D23209: Machine Level CFG Structurizer.
Apr 10 2017, 10:42 AM

Mar 31 2017

jsjodin committed rL299227: Refactor code to create getFallThrough method in MachineBasicBlock..
Refactor code to create getFallThrough method in MachineBasicBlock.
Mar 31 2017, 9:08 AM
jsjodin closed D27264: Refactor code to create getFallThrough method in MachineBasicBlock. by committing rL299227: Refactor code to create getFallThrough method in MachineBasicBlock..
Mar 31 2017, 9:08 AM

Mar 29 2017

jsjodin added a reviewer for D27264: Refactor code to create getFallThrough method in MachineBasicBlock.: qcolombet.
Mar 29 2017, 9:30 AM

Mar 27 2017

jsjodin added inline comments to D23209: Machine Level CFG Structurizer.
Mar 27 2017, 11:19 AM

Mar 9 2017

jsjodin committed rL297398: Add front() method to SetVector..
Add front() method to SetVector.
Mar 9 2017, 10:37 AM
jsjodin closed D27262: Add front() method to SetVector. by committing rL297398: Add front() method to SetVector..
Mar 9 2017, 10:37 AM

Mar 8 2017

jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Moved the code into the AMDGPU backend since there was little interest in a generic version. If someone wants to use this in the future, it is easy to lift it out into CodeGen again.

Mar 8 2017, 1:50 PM

Dec 14 2016

jsjodin added a reverting change for rL289721: Dummy commit.: rL289723: Revert revision 289721..
Dec 14 2016, 2:09 PM
jsjodin committed rL289723: Revert revision 289721..
Revert revision 289721.
Dec 14 2016, 2:09 PM
jsjodin committed rL289721: Dummy commit..
Dummy commit.
Dec 14 2016, 2:07 PM

Dec 9 2016

jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Added function to only run the structurizer on a region if there are non-uniform branch instructions present. The interface function should perhaps be called something more generic. Also synced with trunk.

Dec 9 2016, 1:35 PM

Dec 8 2016

jsjodin added a comment to D23209: Machine Level CFG Structurizer.

Revert back to "Not Done", accidentally checked the box.

Dec 8 2016, 9:32 AM
jsjodin added inline comments to D23209: Machine Level CFG Structurizer.
Dec 8 2016, 9:30 AM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Cleaned up the code a bit and and clang-formatted everything.

Dec 8 2016, 9:27 AM

Nov 30 2016

jsjodin retitled D27264: Refactor code to create getFallThrough method in MachineBasicBlock. from to Refactor code to create getFallThrough method in MachineBasicBlock..
Nov 30 2016, 9:38 AM
jsjodin abandoned D25336: Refactor code and create getFallThrough method..

Will create new diff and add correct mailing list.

Nov 30 2016, 9:29 AM
jsjodin retitled D27262: Add front() method to SetVector. from to Add front() method to SetVector..
Nov 30 2016, 9:20 AM
jsjodin abandoned D26925: Add front() method..

Will create another patch.

Nov 30 2016, 9:17 AM

Nov 29 2016

jsjodin updated subscribers of D25336: Refactor code and create getFallThrough method..
Nov 29 2016, 12:48 PM
jsjodin added reviewers for D26925: Add front() method.: tstellarAMD, arsenm.
Nov 29 2016, 11:37 AM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Fix insertSelect to handle VCCZ and VCCNZ conditions.

Nov 29 2016, 10:44 AM

Nov 23 2016

jsjodin updated the diff for D25336: Refactor code and create getFallThrough method..

Add missing file.

Nov 23 2016, 11:05 AM
jsjodin added a comment to D25336: Refactor code and create getFallThrough method..

Moved the canFallThrough code to the header file.

Nov 23 2016, 11:02 AM
jsjodin updated the diff for D25336: Refactor code and create getFallThrough method..

Put implementation of canFallThrough to the header.

Nov 23 2016, 11:01 AM

Nov 21 2016

jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Fixed various bugs. The code now transforms DAGs, Loops and nested regions, and the generated code executes correctly, for some small examples.

Nov 21 2016, 2:33 PM
jsjodin updated the diff for D26925: Add front() method..

Fix comment.

Nov 21 2016, 10:25 AM
jsjodin retitled D26925: Add front() method. from to Add front() method..
Nov 21 2016, 10:24 AM

Oct 7 2016

jsjodin added a reviewer for D25336: Refactor code and create getFallThrough method.: dexonsmith.
Oct 7 2016, 6:00 AM
jsjodin updated the diff for D25336: Refactor code and create getFallThrough method..

Fix whitespace

Oct 7 2016, 5:30 AM
jsjodin updated the diff for D25336: Refactor code and create getFallThrough method..

Add missing .h file.

Oct 7 2016, 5:28 AM

Oct 6 2016

jsjodin added a reviewer for D25336: Refactor code and create getFallThrough method.: asl.
Oct 6 2016, 11:03 AM
jsjodin retitled D25336: Refactor code and create getFallThrough method. from to Refactor code and create getFallThrough method..
Oct 6 2016, 10:51 AM
jsjodin added a comment to D23209: Machine Level CFG Structurizer.

What effect does this have on what instructions are emitted for the mask modifications? I noticed that sc emits fewer instructions to modify the exec mask. For example, we currently emit for if/then/else

if:
s_and_saveexec_b64 SaveExec, vcc
s_xor_b64 SaveExec, exec, SaveExec

else:
s_or_saveexec_b64 SaveExec, SaveExec
s_xor_b64 exec, exec, SaveExec

endif:
s_or_b64 exec, exec, SaveExec

While sc emits:
if:
s_and_saveexec_b64 SaveExec, vcc

else:
s_andn2_b64, exec, SaveExec, exec

endif:
s_mov_b64 exec, SaveExec

Switching this seems easy, but I tried with the current scheme, but I think it requires modification of how if.break and else.break are inserted

Oct 6 2016, 10:13 AM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Remove virtual

Oct 6 2016, 10:09 AM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Fixed various bugs related to maintaining live out information. Fixed merge issues.

Oct 6 2016, 9:25 AM

Aug 10 2016

jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Updated patch to use better debug locations when instructions are created.

Aug 10 2016, 12:02 PM

Aug 5 2016

jsjodin added a reviewer for D23209: Machine Level CFG Structurizer: cfang.
Aug 5 2016, 11:56 AM
jsjodin updated the diff for D23209: Machine Level CFG Structurizer.

Remove commented out code.

Aug 5 2016, 10:28 AM
jsjodin added a comment to D23209: Machine Level CFG Structurizer.

I see some commented out code that I missed to remove. I will fix that asap.

Aug 5 2016, 9:55 AM
jsjodin retitled D23209: Machine Level CFG Structurizer from to Machine Level CFG Structurizer.
Aug 5 2016, 9:54 AM

Aug 10 2015

jsjodin added inline comments to D11566: Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert..
Aug 10 2015, 12:01 PM

Jul 30 2015

jsjodin updated the diff for D11566: Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert..

Added check in branch inversion to break if we encounter a block without a single predecessor.

Jul 30 2015, 9:57 AM

Jul 29 2015

jsjodin added a reviewer for D11566: Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert.: jvesely.
Jul 29 2015, 4:51 AM
jsjodin removed a reviewer for D11566: Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert.: llvm-commits.
Jul 29 2015, 4:48 AM

Jul 28 2015

jsjodin added a reviewer for D11566: Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert.: chandlerc.
Jul 28 2015, 10:20 AM
jsjodin retitled D11566: Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert. from to Fix FlattenCFG to invert test when different index is encountered, and add one more operator to invert..
Jul 28 2015, 9:55 AM