Page MenuHomePhabricator

rsmith (Richard Smith - zygoloid)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2012, 2:19 PM (520 w, 5 d)

Recent Activity

Fri, Jul 1

rsmith added inline comments to D126694: [C++20][Modules] Implementation of GMF decl elision..
Fri, Jul 1, 6:56 PM · Restricted Project, Restricted Project

Wed, Jun 29

rsmith committed rGdcea10c3c6ac: Fix miscompile with [[no_unique_address]] struct fields. (authored by rsmith).
Fix miscompile with [[no_unique_address]] struct fields.
Wed, Jun 29, 1:09 PM · Restricted Project, Restricted Project
rsmith committed rG5086e05bb0cd: Repair tautological condition. (authored by rsmith).
Repair tautological condition.
Wed, Jun 29, 1:09 PM · Restricted Project, Restricted Project

Tue, Jun 28

rsmith accepted D113545: [C++20] [Module] Support reachable definition initially/partially.

A few comments, but they're all minor things or FIXMEs. I'm happy for this to land once they're addressed.

Tue, Jun 28, 1:51 PM · Restricted Project, Restricted Project

Fri, Jun 17

rsmith added inline comments to D128083: [C++20] Correctly handle constexpr/consteval explicitly defaulted special member instantiation behavior.
Fri, Jun 17, 12:53 PM · Restricted Project, Restricted Project

Wed, Jun 15

rsmith added a comment to D126960: [clang][sema] Unary not boolean to int conversion.

Thank you for the patch! This is certainly an improvement but I think there are still some cases where we compute the wrong range for ~ with this patch applied.

Wed, Jun 15, 1:25 PM · Restricted Project, Restricted Project

Tue, Jun 14

rsmith added inline comments to D116203: [clang] adds unary type transformations as compiler built-ins.
Tue, Jun 14, 2:07 PM · Restricted Project, Restricted Project
rsmith added inline comments to D116203: [clang] adds unary type transformations as compiler built-ins.
Tue, Jun 14, 1:58 PM · Restricted Project, Restricted Project

Mon, Jun 13

rsmith accepted D126061: [clang] Reject non-declaration C++11 attributes on declarations.

This is a bold direction but I like it a lot. Over to @aaron.ballman for final approval.

Mon, Jun 13, 1:16 PM · Restricted Project, Restricted Project

Fri, Jun 10

rsmith added inline comments to D127351: clang: fix early substitution of alias templates.
Fri, Jun 10, 5:27 PM · Restricted Project, Restricted Project

Wed, Jun 8

rsmith added inline comments to D126061: [clang] Reject non-declaration C++11 attributes on declarations.
Wed, Jun 8, 2:11 PM · Restricted Project, Restricted Project

Mon, Jun 6

rsmith accepted D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes.
Mon, Jun 6, 10:17 AM · Restricted Project, Restricted Project

Jun 5 2022

rsmith accepted D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.
Jun 5 2022, 8:38 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

rsmith added inline comments to D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.
Jun 3 2022, 4:50 PM · Restricted Project, Restricted Project, Restricted Project
rsmith added inline comments to D126757: [AST] Fix clang RecursiveASTVisitor for definition of XXXTemplateSpecializationDecl.
Jun 3 2022, 4:32 PM · Restricted Project, Restricted Project, Restricted Project
rsmith added inline comments to D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder.
Jun 3 2022, 12:36 PM · Restricted Project, Restricted Project
rsmith added a comment to D125919: Drop qualifiers from return types in C (DR423).

Now, the standard has chosen not to talk about _Atomic as a qualifier, I assume because there's a fair number of rules in the standard that assume that qualifiers can be freely added to pointers and don't change layout and so on, none of which apply to _Atomic. But those rules also don't apply to a large number of other extended qualifiers, like address spaces and the ARC ownership qualifiers and __ptrauth. The committee should probably just come to terms with the fact that it's the relatively easy-come-easy-go nature of the CVR qualifiers which is the special case. I've thought for awhile that Clang should really be representing _Atomic as a qualifier instead of having to treat AtomicType as a special case in a million places.

I'm not certain if we can get away with that. IIRC, Microsoft uses embedded locks on Windows in some circumstances. However, cl doesn't support _Atomic and so maybe we can get away with it on the assumption we have no other targets where the size/alignment would be different for an atomic type vs a non-atomic type?

Jun 3 2022, 12:22 PM · Restricted Project, Restricted Project
rsmith added inline comments to D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type.
Jun 3 2022, 12:08 PM · Restricted Project, Restricted Project

Jun 2 2022

rsmith added inline comments to D126903: [clang] Add support for __builtin_memset_inline.
Jun 2 2022, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
rsmith added inline comments to D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules.
Jun 2 2022, 12:25 PM · Restricted Project, Restricted Project

May 31 2022

rsmith added inline comments to D126694: [C++20][Modules] Implementation of GMF decl elision..
May 31 2022, 11:02 PM · Restricted Project, Restricted Project
rsmith added inline comments to D126694: [C++20][Modules] Implementation of GMF decl elision..
May 31 2022, 10:58 PM · Restricted Project, Restricted Project

May 27 2022

rsmith accepted D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`..

OK, fair enough.

May 27 2022, 6:04 PM · Restricted Project, Restricted Project
rsmith added a comment to D126566: [ODRHash][NFC] Add missing 'select' case for `ODRMismatchDecl`..

We perhaps can't or don't want to add test coverage for the "unexpected decl" case here. Can we add coverage for the "function template" case?

May 27 2022, 2:23 PM · Restricted Project, Restricted Project
rsmith added inline comments to D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order.
May 27 2022, 2:14 PM · Restricted Project, Restricted Project

May 26 2022

rsmith added inline comments to D125936: [Sema] Relax an assertion in BuildStmtExpr.
May 26 2022, 5:29 PM · Restricted Project, Restricted Project
rsmith added inline comments to D125936: [Sema] Relax an assertion in BuildStmtExpr.
May 26 2022, 5:24 PM · Restricted Project, Restricted Project
rsmith added inline comments to D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order.
May 26 2022, 4:02 PM · Restricted Project, Restricted Project
rsmith added inline comments to D123532: [clang] Introduce while and do..while condition checks.
May 26 2022, 2:20 PM · Restricted Project, Restricted Project
rsmith edited reviewers for D123532: [clang] Introduce while and do..while condition checks, added: rtrieu; removed: lattner.
May 26 2022, 2:09 PM · Restricted Project, Restricted Project

May 25 2022

rsmith added inline comments to D102122: Support warn_unused_result on typedefs.
May 25 2022, 7:20 PM · Restricted Project, Restricted Project
rsmith added a comment to D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order.

The underlying problem is basically wg21.link/cwg362 which has no concensus yet.

May 25 2022, 4:44 PM · Restricted Project, Restricted Project
rsmith added a comment to D126061: [clang] Reject non-declaration C++11 attributes on declarations.

I'm very happy with how this patch is looking.

May 25 2022, 3:25 PM · Restricted Project, Restricted Project
rsmith added inline comments to D126061: [clang] Reject non-declaration C++11 attributes on declarations.
May 25 2022, 2:35 PM · Restricted Project, Restricted Project

May 24 2022

Herald added a project to D112374: [clang] Implement ElaboratedType sugaring for types written bare: Restricted Project.

I've not looked at the test changes in any detail; please let me know if there's anything in there that deserves special attention.

May 24 2022, 5:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Herald added a project to D111283: [clang] template / auto deduction deduces common sugar: Restricted Project.
May 24 2022, 1:17 PM · Restricted Project, Restricted Project, Restricted Project
rsmith added inline comments to D126061: [clang] Reject non-declaration C++11 attributes on declarations.
May 24 2022, 11:19 AM · Restricted Project, Restricted Project
rsmith added a comment to D126183: Implement soft reset of the diagnostics engine..

I don't think we can live with the #define private public approach, not least because this violates the ODR and might lead to compile failures using modules as a result. As an alternative, how about:

May 24 2022, 11:00 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

rsmith added a comment to D125773: [Driver] Do not auto-enable header modules with -std=c++20.

It looks like this particular change actually breaks standard compatibility as we also use the same parsing action and don't build a module separately on import.

[module.import]p5
A module-import-declaration that specifies a header-name H imports a synthesized header unit, which is a
translation unit formed by applying phases 1 to 7 of translation (5.2) to the source file or header nominated
by H, which shall not contain a module-declaration.
May 23 2022, 3:19 PM · Restricted Project, Restricted Project

May 20 2022

rsmith added a comment to D126061: [clang] Reject non-declaration C++11 attributes on declarations.

This direction looks good to me. Thanks!

May 20 2022, 6:17 PM · Restricted Project, Restricted Project

May 18 2022

rsmith added a comment to D125773: [Driver] Do not auto-enable header modules with -std=c++20.

Header modules are part of the C++20 standard (where they are called "header units"), and module maps are an intended way for Clang to provide this functionality in C++20 mode. I don't think turning this off by default in C++20 is the right forward-looking plan; rather, I think we should be thinking about moving towards header modules simply always being something that Clang can do, with no flag to control that.

May 18 2022, 1:18 PM · Restricted Project, Restricted Project

May 10 2022

rsmith added inline comments to D111548: [Clang] Add the `annotate_type` attribute.
May 10 2022, 12:57 PM · Restricted Project, Restricted Project

May 9 2022

rsmith added inline comments to D111548: [Clang] Add the `annotate_type` attribute.
May 9 2022, 3:50 PM · Restricted Project, Restricted Project

May 5 2022

rsmith committed rGf6c74932b596: [docs] Fix uses of `foo` that should be ``foo`` throughout release notes. (authored by rsmith).
[docs] Fix uses of `foo` that should be ``foo`` throughout release notes.
May 5 2022, 4:05 PM · Restricted Project, Restricted Project
rsmith committed rGc2572d8b1fcc: [docs] Add blank lines to help Sphinx parse nested bullets. (authored by rsmith).
[docs] Add blank lines to help Sphinx parse nested bullets.
May 5 2022, 3:59 PM · Restricted Project, Restricted Project
rsmith committed rGc4f95ef86a22: Reimplement `__builtin_dump_struct` in Sema. (authored by rsmith).
Reimplement `__builtin_dump_struct` in Sema.
May 5 2022, 2:56 PM · Restricted Project, Restricted Project
rsmith closed D124221: Reimplement `__builtin_dump_struct` in Sema..
May 5 2022, 2:56 PM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Put ""s around %s formats and add a length limit.
May 5 2022, 2:53 PM · Restricted Project, Restricted Project

May 4 2022

rsmith added inline comments to D124221: Reimplement `__builtin_dump_struct` in Sema..
May 4 2022, 11:10 AM · Restricted Project, Restricted Project

May 3 2022

rsmith added inline comments to D124221: Reimplement `__builtin_dump_struct` in Sema..
May 3 2022, 1:33 PM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Rebase.
  • Reuse Clang's existing "guess a format specifier" logic.
  • Format signed/unsigned/plain char as numbers.
  • Add test for reference members.
May 3 2022, 1:30 PM · Restricted Project, Restricted Project
rsmith committed rGc7ecfadf9beb: Fix some places where PseudoObjectExpr handling assumed that a (authored by rsmith).
Fix some places where PseudoObjectExpr handling assumed that a
May 3 2022, 11:55 AM · Restricted Project, Restricted Project

May 2 2022

rsmith added inline comments to D124221: Reimplement `__builtin_dump_struct` in Sema..
May 2 2022, 2:45 PM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Add requested assert.
May 2 2022, 2:45 PM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Use printing policy more, and turn off anonymous tag locations.
May 2 2022, 2:27 PM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Respond to review comments.
May 2 2022, 1:58 PM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Update release notes
May 2 2022, 1:01 AM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Minor doc correction
May 2 2022, 12:54 AM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Fix example in documentation: the dump is terminated by a newline.
May 2 2022, 12:53 AM · Restricted Project, Restricted Project
rsmith added a comment to D124221: Reimplement `__builtin_dump_struct` in Sema..

I think we can address most of my concerns with __builtin_dump_struct without a new builtin, by incorporating things from this implementation

May 2 2022, 12:52 AM · Restricted Project, Restricted Project
rsmith retitled D124221: Reimplement `__builtin_dump_struct` in Sema. from Add new builtin __builtin_reflect_struct. to Reimplement `__builtin_dump_struct` in Sema..
May 2 2022, 12:47 AM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Reimplement __builtin_dump_struct in Sema.
May 2 2022, 12:46 AM · Restricted Project, Restricted Project

Apr 25 2022

rsmith added inline comments to D116203: [clang] adds unary type transformations as compiler built-ins.
Apr 25 2022, 5:05 PM · Restricted Project, Restricted Project
rsmith added inline comments to D124221: Reimplement `__builtin_dump_struct` in Sema..
Apr 25 2022, 1:23 PM · Restricted Project, Restricted Project
rsmith added a comment to D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Take any callable as the printing function and pass it the fields with their correct types, so that a C++ implementation can dispatch based on the type and print the values of types that we don't hard-code (eg, we'd generate calls like user_dump_function("%s = %p", "field_name", &p->field_name);, and a smart C++ formatting function can preserve the field type and do something suitable when formatting a corresponding %p).

+1, though I'm curious what we want to do about things like bit-fields (do we want to alert the caller that it's a bit-field and what the width is?), anonymous bit-fields, base classes vs fields of class type, etc.

I suspect we'd want some sort of 'depth' parameter to that as well so we can handle the 'tabbing' correctly,

Apr 25 2022, 1:13 PM · Restricted Project, Restricted Project

Apr 22 2022

rsmith added inline comments to D124258: [C89/C2x] Change the behavior of implicit int diagnostics.
Apr 22 2022, 4:47 PM · Restricted Project, Restricted Project, Restricted Project
rsmith added a comment to D124221: Reimplement `__builtin_dump_struct` in Sema..

Thank you for looking into this! I've also thought that the __builtin_dump_struct implementation hasn't been quite as robust as it could be. However, the primary use case for that builtin has been for kernel folks to debug when they have no access to an actual debugger -- it being a super limited interface is actually a feature rather than a bug, in some ways.

Apr 22 2022, 4:02 PM · Restricted Project, Restricted Project
rsmith added inline comments to D124258: [C89/C2x] Change the behavior of implicit int diagnostics.
Apr 22 2022, 12:03 PM · Restricted Project, Restricted Project, Restricted Project
rsmith added inline comments to D124221: Reimplement `__builtin_dump_struct` in Sema..
Apr 22 2022, 10:14 AM · Restricted Project, Restricted Project
rsmith added inline comments to D124221: Reimplement `__builtin_dump_struct` in Sema..
Apr 22 2022, 10:07 AM · Restricted Project, Restricted Project
rsmith added a comment to D124221: Reimplement `__builtin_dump_struct` in Sema..

I generally just question the usefulness of this. Despite its shortcomings, the 'dump struct' has the capability of runtime introspection into a type, whereas this seems to require that the user 'know' a significant amount about the type that they are introspecting (number of bases, number of fields, field TYPES).

Apr 22 2022, 9:15 AM · Restricted Project, Restricted Project

Apr 21 2022

rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Fix some code that was making incorrect assumptions that PseudoObjectExpr is only used for ObjC properties.
Apr 21 2022, 10:47 PM · Restricted Project, Restricted Project
rsmith updated the diff for D124221: Reimplement `__builtin_dump_struct` in Sema..
  • Some improvements.
Apr 21 2022, 6:14 PM · Restricted Project, Restricted Project
rsmith added a comment to D124221: Reimplement `__builtin_dump_struct` in Sema..

I'm not entirely sure whether I want to pursue this -- I'd prefer to have only a single mechanism that works well in both C and C++, rather than this (which is flexible but not really usable in C) and __builtin_dump_struct (which is inflexible but works well for C) -- but I've not found a good way to expose this functionality that provides good support for both use cases yet. Thoughts on that are welcome.

Apr 21 2022, 6:00 PM · Restricted Project, Restricted Project
rsmith updated the summary of D124221: Reimplement `__builtin_dump_struct` in Sema..
Apr 21 2022, 5:52 PM · Restricted Project, Restricted Project
rsmith requested review of D124221: Reimplement `__builtin_dump_struct` in Sema..
Apr 21 2022, 5:52 PM · Restricted Project, Restricted Project
rsmith committed rGf6a5ab6c8c31: Use builtin recognition to detect std::move / std::forward. (authored by rsmith).
Use builtin recognition to detect std::move / std::forward.
Apr 21 2022, 2:21 PM · Restricted Project, Restricted Project
rsmith added inline comments to D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name.
Apr 21 2022, 2:20 PM · Restricted Project, Restricted Project
rsmith added a comment to D119136: [clang] Implement Change scope of lambda trailing-return-type.

@rsmith @aaron.ballman Do you think it's worth resubmitting this patch with a look ahead of the mutable keyword (this seems to me a better strategy than other flimsy workaround suggested/tried), or would you rather wait for WG21 to come up with something?

Apr 21 2022, 12:09 PM · Restricted Project, Restricted Project
rsmith added a comment to D119136: [clang] Implement Change scope of lambda trailing-return-type.

@rsmith @aaron.ballman Do you think it's worth resubmitting this patch with a look ahead of the mutable keyword (this seems to me a better strategy than other flimsy workaround suggested/tried), or would you rather wait for WG21 to come up with something?

Apr 21 2022, 12:02 PM · Restricted Project, Restricted Project

Apr 20 2022

rsmith added a comment to D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..

I think your revert to fix the aix CI broke CI everywhere: http://45.33.8.238/linux/74239/step_7.txt

Please take a look and reland for now if it takes a while to fix.

Apr 20 2022, 6:01 PM · Restricted Project, Restricted Project
rsmith added a reverting change for rGaa643f455a53: Fixup D123950 to address revert of D123345: rG72315d02c432: Treat `std::move`, `forward`, etc. as builtins..
Apr 20 2022, 5:59 PM · Restricted Project, Restricted Project
rsmith committed rG72315d02c432: Treat `std::move`, `forward`, etc. as builtins. (authored by rsmith).
Treat `std::move`, `forward`, etc. as builtins.
Apr 20 2022, 5:59 PM · Restricted Project, Restricted Project, Restricted Project
rsmith added a comment to D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..

Hi, unfortunately there's a build failure on AIX: https://lab.llvm.org/buildbot/#/builders/214/builds/779/steps/9/logs/stdio. Could you take a look?

Hi, any feedback on the AIX break? Seems like this might be non-trivial to address (were on an older libc++ level), so perhaps this needs a revert till can be worked out.

Apr 20 2022, 5:12 PM · Restricted Project, Restricted Project
rsmith added a comment to D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause.

This looks like a true positive to me, at least for the moment (Core is still trying to decide what to do about CWG2569 which may relax some restrictions in this area).

@MaskRay -- your revert was incorrect, please un-revert.

Apr 20 2022, 12:13 PM · Restricted Project, Restricted Project

Apr 19 2022

rsmith committed rG63814be4fa23: [modules] Merge variable template specializations. (authored by rsmith).
[modules] Merge variable template specializations.
Apr 19 2022, 2:49 PM · Restricted Project, Restricted Project
rsmith accepted D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

LGTM; two non-blocking comments and a question.

Apr 19 2022, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rsmith accepted D123955: [C2x] Disallow functions without prototypes/functions with identifier lists.

LGTM. Some comments for potential improvements, but I'd be OK with this landing as-is if you don't find any of them sufficiently motivating :)

Apr 19 2022, 12:37 PM · Restricted Project, Restricted Project

Apr 18 2022

rsmith added inline comments to D123955: [C2x] Disallow functions without prototypes/functions with identifier lists.
Apr 18 2022, 1:01 PM · Restricted Project, Restricted Project
rsmith added inline comments to D122663: Mark identifier prefixes as substitutable.
Apr 18 2022, 12:33 PM · Restricted Project, Restricted Project
rsmith added a comment to D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..

I'm working on a fix. I'll revert if it takes me more than a few minutes. If you'd prefer to not wait, please feel free to revert it yourself.

Apr 18 2022, 11:12 AM · Restricted Project, Restricted Project
rsmith committed rGe43c93dd63cc: Don't treat 'T &forward(T&&)' as builtin. (authored by rsmith).
Don't treat 'T &forward(T&&)' as builtin.
Apr 18 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
rsmith added a comment to D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..

Hi, this is also breaking Fuchsia's clang CI builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8816531831869640417/overview). If this will be hard to address, would you mind reverting until a patch is ready?

Apr 18 2022, 10:47 AM · Restricted Project, Restricted Project

Apr 17 2022

rsmith committed rGc105bcbf98f3: Specify -fno-builtin when testing to make sure that certain stdlib (authored by rsmith).
Specify -fno-builtin when testing to make sure that certain stdlib
Apr 17 2022, 7:42 PM · Restricted Project, Restricted Project
rsmith committed rG3eeca5245697: Fix wrong signature for std::move and std::swap in test. (authored by rsmith).
Fix wrong signature for std::move and std::swap in test.
Apr 17 2022, 7:25 PM · Restricted Project, Restricted Project
rsmith committed rGb27430f9f46b: Treat `std::move`, `forward`, etc. as builtins. (authored by rsmith).
Treat `std::move`, `forward`, etc. as builtins.
Apr 17 2022, 1:36 PM · Restricted Project, Restricted Project
rsmith closed D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins..
Apr 17 2022, 1:36 PM · Restricted Project, Restricted Project

Apr 15 2022

rsmith accepted D123885: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'""".
Apr 15 2022, 5:31 PM · Restricted Project, Restricted Project, Restricted Project
rsmith committed rGfc3090109643: Extend support for std::move etc to also cover std::as_const and (authored by rsmith).
Extend support for std::move etc to also cover std::as_const and
Apr 15 2022, 4:32 PM · Restricted Project, Restricted Project
rsmith committed rGa571f82a5041: Update test to handle opaque pointers flag flip. (authored by rsmith).
Update test to handle opaque pointers flag flip.
Apr 15 2022, 2:52 PM · Restricted Project, Restricted Project