- User Since
- Jul 12 2012, 2:19 PM (520 w, 5 d)
Fri, Jul 1
Wed, Jun 29
Tue, Jun 28
A few comments, but they're all minor things or FIXMEs. I'm happy for this to land once they're addressed.
Fri, Jun 17
Wed, Jun 15
Thank you for the patch! This is certainly an improvement but I think there are still some cases where we compute the wrong range for ~ with this patch applied.
Tue, Jun 14
Mon, Jun 13
This is a bold direction but I like it a lot. Over to @aaron.ballman for final approval.
Fri, Jun 10
Wed, Jun 8
Mon, Jun 6
Jun 5 2022
Jun 3 2022
Jun 2 2022
May 31 2022
May 27 2022
OK, fair enough.
We perhaps can't or don't want to add test coverage for the "unexpected decl" case here. Can we add coverage for the "function template" case?
May 26 2022
May 25 2022
The underlying problem is basically wg21.link/cwg362 which has no concensus yet.
I'm very happy with how this patch is looking.
May 24 2022
I've not looked at the test changes in any detail; please let me know if there's anything in there that deserves special attention.
I don't think we can live with the #define private public approach, not least because this violates the ODR and might lead to compile failures using modules as a result. As an alternative, how about:
May 23 2022
May 20 2022
This direction looks good to me. Thanks!
May 18 2022
Header modules are part of the C++20 standard (where they are called "header units"), and module maps are an intended way for Clang to provide this functionality in C++20 mode. I don't think turning this off by default in C++20 is the right forward-looking plan; rather, I think we should be thinking about moving towards header modules simply always being something that Clang can do, with no flag to control that.
May 10 2022
May 9 2022
May 5 2022
- Put ""s around %s formats and add a length limit.
May 4 2022
May 3 2022
- Reuse Clang's existing "guess a format specifier" logic.
- Format signed/unsigned/plain char as numbers.
- Add test for reference members.
May 2 2022
- Add requested assert.
- Use printing policy more, and turn off anonymous tag locations.
- Respond to review comments.
- Update release notes
- Minor doc correction
- Fix example in documentation: the dump is terminated by a newline.
- Reimplement __builtin_dump_struct in Sema.
Apr 25 2022
Apr 22 2022
Apr 21 2022
- Fix some code that was making incorrect assumptions that PseudoObjectExpr is only used for ObjC properties.
- Some improvements.
I'm not entirely sure whether I want to pursue this -- I'd prefer to have only a single mechanism that works well in both C and C++, rather than this (which is flexible but not really usable in C) and __builtin_dump_struct (which is inflexible but works well for C) -- but I've not found a good way to expose this functionality that provides good support for both use cases yet. Thoughts on that are welcome.
Apr 20 2022
Apr 19 2022
LGTM; two non-blocking comments and a question.
LGTM. Some comments for potential improvements, but I'd be OK with this landing as-is if you don't find any of them sufficiently motivating :)