rsmith (Richard Smith - zygoloid)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2012, 2:19 PM (314 w, 4 h)

Recent Activity

Today

rsmith committed rC337508: Fix typo causing assert in self-host..
Fix typo causing assert in self-host.
Thu, Jul 19, 4:29 PM
rsmith committed rL337508: Fix typo causing assert in self-host..
Fix typo causing assert in self-host.
Thu, Jul 19, 4:29 PM
rsmith committed rC337498: When we choose to use zeroinitializer for a trailing portion of an array.
When we choose to use zeroinitializer for a trailing portion of an array
Thu, Jul 19, 2:44 PM
rsmith committed rL337498: When we choose to use zeroinitializer for a trailing portion of an array.
When we choose to use zeroinitializer for a trailing portion of an array
Thu, Jul 19, 2:44 PM
rsmith accepted D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets.
Thu, Jul 19, 1:29 PM
rsmith added a comment to D49511: [Sema/Attribute] Check for noderef attribute.

The way in which you're checking for the problematic cases is unnecessarily expensive. Instead of performing a separate AST traversal, please detect whether you should be producing the warning directly when forming the problematic expressions. (For example, you could store a list of pending "dereference of noderef" expressions in the ExpressionEvaluationContextRecord, remove items from the list if you find they're the operand of a unary address-of operator, and diagnose any remaining items once you've left the evaluation context.)

Thu, Jul 19, 1:18 PM · Restricted Project
rsmith committed rC337483: Fix failing testcase to actually be valid..
Fix failing testcase to actually be valid.
Thu, Jul 19, 12:10 PM
rsmith committed rL337483: Fix failing testcase to actually be valid..
Fix failing testcase to actually be valid.
Thu, Jul 19, 12:10 PM
rsmith committed rL337481: Fix template argument deduction when a parameter pack has a value.
Fix template argument deduction when a parameter pack has a value
Thu, Jul 19, 12:06 PM
rsmith committed rC337481: Fix template argument deduction when a parameter pack has a value.
Fix template argument deduction when a parameter pack has a value
Thu, Jul 19, 12:05 PM

Yesterday

rsmith committed rL337422: DR330: when determining whether a cast casts away constness, consider.
DR330: when determining whether a cast casts away constness, consider
Wed, Jul 18, 1:18 PM
rsmith committed rC337422: DR330: when determining whether a cast casts away constness, consider.
DR330: when determining whether a cast casts away constness, consider
Wed, Jul 18, 1:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Jul 18, 1:18 PM

Tue, Jul 17

rsmith added inline comments to D49457: DR330: when determining whether a cast casts away constness, consider qualifiers from all levels matching a multidimensional array.
Tue, Jul 17, 7:24 PM
rsmith added inline comments to D49439: [Sema] Fix a crash while converting constructors to deduction guides.
Tue, Jul 17, 5:04 PM
rsmith created D49457: DR330: when determining whether a cast casts away constness, consider qualifiers from all levels matching a multidimensional array.
Tue, Jul 17, 4:42 PM
rsmith committed rC337330: Replace LLVM_ALIGNAS with just alignas..
Replace LLVM_ALIGNAS with just alignas.
Tue, Jul 17, 3:29 PM
rsmith committed rL337330: Replace LLVM_ALIGNAS with just alignas..
Replace LLVM_ALIGNAS with just alignas.
Tue, Jul 17, 3:29 PM
rsmith committed rL337329: Restructure checking for, and warning on, lifetime extension..
Restructure checking for, and warning on, lifetime extension.
Tue, Jul 17, 3:29 PM
rsmith committed rC337329: Restructure checking for, and warning on, lifetime extension..
Restructure checking for, and warning on, lifetime extension.
Tue, Jul 17, 3:29 PM

Mon, Jul 16

rsmith accepted D48266: [Driver] Add -fno-digraphs.

Looks good with one cleanup.

Mon, Jul 16, 5:19 PM
rsmith committed rC337226: Restructure checking for, and warning on, lifetime extension..
Restructure checking for, and warning on, lifetime extension.
Mon, Jul 16, 5:17 PM
rsmith committed rL337226: Restructure checking for, and warning on, lifetime extension..
Restructure checking for, and warning on, lifetime extension.
Mon, Jul 16, 5:16 PM

Fri, Jul 13

rsmith committed rC337048: Make BuiltinType constructor private, and befriend ASTContext..
Make BuiltinType constructor private, and befriend ASTContext.
Fri, Jul 13, 2:34 PM
rsmith committed rL337048: Make BuiltinType constructor private, and befriend ASTContext..
Make BuiltinType constructor private, and befriend ASTContext.
Fri, Jul 13, 2:34 PM
rsmith committed rL337047: Use external layout information to layout bit-fields for MS ABI..
Use external layout information to layout bit-fields for MS ABI.
Fri, Jul 13, 2:12 PM
rsmith committed rC337047: Use external layout information to layout bit-fields for MS ABI..
Use external layout information to layout bit-fields for MS ABI.
Fri, Jul 13, 2:12 PM
rsmith closed D49227: Override a bit fields layout from an external source.
Fri, Jul 13, 2:12 PM · Restricted Project
rsmith closed D49227: Override a bit fields layout from an external source.
Fri, Jul 13, 2:12 PM · Restricted Project

Thu, Jul 12

rsmith accepted D49227: Override a bit fields layout from an external source.
Thu, Jul 12, 4:51 PM · Restricted Project
rsmith committed rL336962: PR38136: improve handling of template argument deduction of non-trailing.
PR38136: improve handling of template argument deduction of non-trailing
Thu, Jul 12, 4:38 PM
rsmith committed rC336962: PR38136: improve handling of template argument deduction of non-trailing.
PR38136: improve handling of template argument deduction of non-trailing
Thu, Jul 12, 4:37 PM
rsmith accepted D47423: Simplify recursive launder.invariant.group and strip.
Thu, Jul 12, 4:16 PM
rsmith committed rL336946: PR38141: check whether noexcept-specifications are equivalent in redeclarations.
PR38141: check whether noexcept-specifications are equivalent in redeclarations
Thu, Jul 12, 2:16 PM
rsmith committed rC336946: PR38141: check whether noexcept-specifications are equivalent in redeclarations.
PR38141: check whether noexcept-specifications are equivalent in redeclarations
Thu, Jul 12, 2:16 PM
rsmith committed rL336931: Add tests for function conversions in conversion function template.
Add tests for function conversions in conversion function template
Thu, Jul 12, 11:54 AM
rsmith committed rC336931: Add tests for function conversions in conversion function template.
Add tests for function conversions in conversion function template
Thu, Jul 12, 11:54 AM

Wed, Jul 11

rsmith committed rC336867: Fix deduction for conversion function templates converting to reference.
Fix deduction for conversion function templates converting to reference
Wed, Jul 11, 4:24 PM
rsmith committed rL336867: Fix deduction for conversion function templates converting to reference.
Fix deduction for conversion function templates converting to reference
Wed, Jul 11, 4:24 PM
rsmith committed rC336852: Fix determination of whether one set of cvr-qualifiers is compatible.
Fix determination of whether one set of cvr-qualifiers is compatible
Wed, Jul 11, 2:12 PM
rsmith committed rL336852: Fix determination of whether one set of cvr-qualifiers is compatible.
Fix determination of whether one set of cvr-qualifiers is compatible
Wed, Jul 11, 2:12 PM

Tue, Jul 10

rsmith committed rC336747: [docs] List correct default for -ftemplate-depth; also add missing.
[docs] List correct default for -ftemplate-depth; also add missing
Tue, Jul 10, 5:40 PM
rsmith committed rL336747: [docs] List correct default for -ftemplate-depth; also add missing.
[docs] List correct default for -ftemplate-depth; also add missing
Tue, Jul 10, 5:40 PM
rsmith committed rL336746: PR38095: Allow constant-folding of loads through bitcasted pointers if.
PR38095: Allow constant-folding of loads through bitcasted pointers if
Tue, Jul 10, 5:34 PM
rsmith committed rC336746: PR38095: Allow constant-folding of loads through bitcasted pointers if.
PR38095: Allow constant-folding of loads through bitcasted pointers if
Tue, Jul 10, 5:34 PM
rsmith committed rL336745: DR330: look through array types when forming the cv-decomposition of a type..
DR330: look through array types when forming the cv-decomposition of a type.
Tue, Jul 10, 5:24 PM
rsmith committed rC336745: DR330: look through array types when forming the cv-decomposition of a type..
DR330: look through array types when forming the cv-decomposition of a type.
Tue, Jul 10, 5:24 PM
rsmith committed rC336738: Fix determination of whether a reinterpret_cast casts away constness..
Fix determination of whether a reinterpret_cast casts away constness.
Tue, Jul 10, 4:09 PM
rsmith committed rL336738: Fix determination of whether a reinterpret_cast casts away constness..
Fix determination of whether a reinterpret_cast casts away constness.
Tue, Jul 10, 4:09 PM
rsmith accepted D37442: [C++17] Disallow lambdas in template parameters (PR33696)..
Tue, Jul 10, 2:53 PM
rsmith added a comment to D36357: Added a better diagnostic when using the delete operator with lambdas.

Thanks!

Tue, Jul 10, 2:48 PM · Restricted Project
rsmith added inline comments to D47423: Simplify recursive launder.invariant.group and strip.
Tue, Jul 10, 12:29 PM

Mon, Jul 9

rsmith added inline comments to D48266: [Driver] Add -fno-digraphs.
Mon, Jul 9, 2:27 PM
rsmith added inline comments to D47423: Simplify recursive launder.invariant.group and strip.
Mon, Jul 9, 11:59 AM
rsmith accepted D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation.
Mon, Jul 9, 11:37 AM
rsmith accepted D48894: [AST] Rename some Redeclarable functions to reduce confusion.
Mon, Jul 9, 11:34 AM · Restricted Project

Sat, Jul 7

rsmith added a comment to D45712: Diagnose invalid cv-qualifiers for friend decls..

Can we avoid the duplication by putting this check in Sema::ParsedFreeStandingDeclSpec instead?

Sat, Jul 7, 5:39 PM

Fri, Jul 6

rsmith committed rC336480: P0806R2 Implicit capture of this with a capture-default of [=] is.
P0806R2 Implicit capture of this with a capture-default of [=] is
Fri, Jul 6, 11:04 PM
rsmith committed rL336480: P0806R2 Implicit capture of this with a capture-default of [=] is.
P0806R2 Implicit capture of this with a capture-default of [=] is
Fri, Jul 6, 11:03 PM
rsmith added inline comments to D49005: [AST] [NFC] Introduce an abstract superclass for CallExpr | CXXConstructExpr | ObjCMessageExpr.
Fri, Jul 6, 3:15 PM

Thu, Jul 5

rsmith requested changes to D49005: [AST] [NFC] Introduce an abstract superclass for CallExpr | CXXConstructExpr | ObjCMessageExpr.
Thu, Jul 5, 9:18 PM

Tue, Jul 3

rsmith committed rL336240: PR33924: merge local declarations that have linkage of some kind within.
PR33924: merge local declarations that have linkage of some kind within
Tue, Jul 3, 7:30 PM
rsmith committed rC336240: PR33924: merge local declarations that have linkage of some kind within.
PR33924: merge local declarations that have linkage of some kind within
Tue, Jul 3, 7:30 PM
rsmith added inline comments to D48894: [AST] Rename some Redeclarable functions to reduce confusion.
Tue, Jul 3, 7:25 PM · Restricted Project
rsmith accepted D48905: [ADT] Guard our use of function pointers in a `PointerUnion` by a dynamic check that the pointer is actually sufficiently aligned..
Tue, Jul 3, 5:09 PM
rsmith added inline comments to D48863: [Sema] Explain coroutine_traits template in diag.
Tue, Jul 3, 4:44 PM
rsmith added inline comments to D48863: [Sema] Explain coroutine_traits template in diag.
Tue, Jul 3, 4:42 PM
rsmith accepted D48322: [Sema] Discarded statment should be an evaluatable context.

Is this what you were concerned about?

Tue, Jul 3, 2:48 PM
rsmith accepted D48880: [Sema] Fix crash in getConstructorName..
Tue, Jul 3, 2:44 PM
rsmith added a comment to D48880: [Sema] Fix crash in getConstructorName..

Looks fine, but please put the test case somewhere more appropriate (under SemaCXX, for instance).

Tue, Jul 3, 2:44 PM
rsmith committed rL336231: Factor out Clang's desired 8MB stack size constant from the various.
Factor out Clang's desired 8MB stack size constant from the various
Tue, Jul 3, 2:39 PM
rsmith committed rC336231: Factor out Clang's desired 8MB stack size constant from the various.
Factor out Clang's desired 8MB stack size constant from the various
Tue, Jul 3, 2:39 PM

Mon, Jul 2

rsmith committed rC336153: Per C++ [over.match.copy]p1, direct-initialization of a reference can.
Per C++ [over.match.copy]p1, direct-initialization of a reference can
Mon, Jul 2, 4:30 PM
rsmith committed rL336153: Per C++ [over.match.copy]p1, direct-initialization of a reference can.
Per C++ [over.match.copy]p1, direct-initialization of a reference can
Mon, Jul 2, 4:30 PM

Fri, Jun 29

rsmith accepted D48036: [CUDA] Make min/max shims host+device..

Looks right to me (other than the missing constexpr in C++14 onwards). Though this is subtle enough that I suspect the only way to know for sure is to try it.

Fri, Jun 29, 3:15 PM
rsmith committed rC336021: PR33924: merge local declarations that have linkage of some kind within.
PR33924: merge local declarations that have linkage of some kind within
Fri, Jun 29, 3:03 PM
rsmith committed rL336021: PR33924: merge local declarations that have linkage of some kind within.
PR33924: merge local declarations that have linkage of some kind within
Fri, Jun 29, 3:03 PM
rsmith committed rL336016: [modules] Emit the type of the TypeSourceInfo for a DeclaratorDecl (but.
[modules] Emit the type of the TypeSourceInfo for a DeclaratorDecl (but
Fri, Jun 29, 1:51 PM
rsmith committed rC336016: [modules] Emit the type of the TypeSourceInfo for a DeclaratorDecl (but.
[modules] Emit the type of the TypeSourceInfo for a DeclaratorDecl (but
Fri, Jun 29, 1:51 PM
rsmith added a comment to rC335925: PR37979: integral promotions in C++ treat enum bit-fields like enums,.

r336013

Fri, Jun 29, 1:46 PM
rsmith committed rC336013: Specify an explicit underlying type for this enum to fix Windows.
Specify an explicit underlying type for this enum to fix Windows
Fri, Jun 29, 1:46 PM
rsmith committed rL336013: Specify an explicit underlying type for this enum to fix Windows.
Specify an explicit underlying type for this enum to fix Windows
Fri, Jun 29, 1:46 PM
rsmith added a comment to rC335925: PR37979: integral promotions in C++ treat enum bit-fields like enums,.

Thanks, I think this test needs a target triple to avoid the funny msvc
enum rules. I'm working on it.

Fri, Jun 29, 1:23 PM
rsmith added a comment to D48322: [Sema] Discarded statment should be an evaluatable context.

Hmm, so this will mean that we can have internal linkage declarations marked Used for which there is no definition, and we need to not warn on that.

Fri, Jun 29, 1:19 PM

Thu, Jun 28

rsmith added a comment to D46940: [ASTImporter] make sure that ACtx::getParents still works.

This is not specific to the ASTImporter; any change to the AST after a call to getParents would have similar problems. Generally, responsibility for dealing with this must lie with the consumer of the parent map, not with the ASTContext, since the ASTContext generally doesn't even know when the AST gets mutated.

Thu, Jun 28, 4:42 PM
rsmith added a reviewer for D47423: Simplify recursive launder.invariant.group and strip: sanjoy.
Thu, Jun 28, 2:56 PM
rsmith added inline comments to D47423: Simplify recursive launder.invariant.group and strip.
Thu, Jun 28, 2:56 PM
rsmith accepted D47103: Implement strip.invariant.group.
Thu, Jun 28, 2:37 PM
rsmith committed rC335925: PR37979: integral promotions in C++ treat enum bit-fields like enums,.
PR37979: integral promotions in C++ treat enum bit-fields like enums,
Thu, Jun 28, 2:22 PM
rsmith committed rL335925: PR37979: integral promotions in C++ treat enum bit-fields like enums,.
PR37979: integral promotions in C++ treat enum bit-fields like enums,
Thu, Jun 28, 2:22 PM
rsmith accepted D47840: Make -Wgcc-compat complain about declarations in for loop init statements .

I'm not 100% thrilled that we're emitting two warnings about the same thing for slightly different reasons; alternatives welcome. :)

Thu, Jun 28, 2:13 PM
rsmith added inline comments to D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers.
Thu, Jun 28, 11:20 AM

Wed, Jun 27

rsmith committed rL335807: [modules] Do not serialize / deserialize pending new/delete mismatch.
[modules] Do not serialize / deserialize pending new/delete mismatch
Wed, Jun 27, 7:01 PM
rsmith committed rC335807: [modules] Do not serialize / deserialize pending new/delete mismatch.
[modules] Do not serialize / deserialize pending new/delete mismatch
Wed, Jun 27, 7:01 PM
rsmith committed rC335805: [modules] Ensure that an in-class function definition is attached to the.
[modules] Ensure that an in-class function definition is attached to the
Wed, Jun 27, 6:12 PM
rsmith committed rL335805: [modules] Ensure that an in-class function definition is attached to the.
[modules] Ensure that an in-class function definition is attached to the
Wed, Jun 27, 6:12 PM
rsmith committed rL335781: DR1687: When overload resolution selects a built-in operator, implicit.
DR1687: When overload resolution selects a built-in operator, implicit
Wed, Jun 27, 1:35 PM
rsmith committed rC335781: DR1687: When overload resolution selects a built-in operator, implicit.
DR1687: When overload resolution selects a built-in operator, implicit
Wed, Jun 27, 1:35 PM
rsmith committed rL335782: [www] Update cxx_dr_status for recent DR fixes..
[www] Update cxx_dr_status for recent DR fixes.
Wed, Jun 27, 1:35 PM
rsmith committed rC335782: [www] Update cxx_dr_status for recent DR fixes..
[www] Update cxx_dr_status for recent DR fixes.
Wed, Jun 27, 1:35 PM