Page MenuHomePhabricator

kiranchandramohan (Kiran Chandramohan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2017, 1:55 PM (307 w, 1 d)

Recent Activity

Fri, Mar 24

kiranchandramohan updated the summary of D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang.
Fri, Mar 24, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D146292: [Flang][OpenMP] Added TODO checks for unsupported map types.
Fri, Mar 24, 8:35 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D146814: [Flang] Add debug flag to enable current debug information pass.
Fri, Mar 24, 8:19 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan committed rG90d9c1ca74d3: [Flang][OpenMP] Add TODO message for common block privatisation (authored by kiranchandramohan).
[Flang][OpenMP] Add TODO message for common block privatisation
Fri, Mar 24, 4:23 AM · Restricted Project, Restricted Project
kiranchandramohan closed D146768: [Flang][OpenMP] Add TODO message for common block privatisation.
Fri, Mar 24, 4:23 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D146768: [Flang][OpenMP] Add TODO message for common block privatisation.
Fri, Mar 24, 3:49 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D141306: Add loop-versioning pass to improve unit-stride.

The loop versioning is inefficient for the following scenario, in which not all arrays are contiguous in a loop. Maybe there should be one cost model to perform the loop versioning, and be refined driven by the cases in real workloads?

subroutine vadd(c, a, b, n)
  implicit none
  real :: c(:), a(:), b(:)
  integer :: i, n

  print *, is_contiguous(b)  ! classic-flang is wrong here
  do i = 1, n
    c(i) = 5. * a(i) + 3. * b(i)
    c(i) = c(i) * a(i) + a(i) * 4.
  end do
end

interface
  subroutine vadd(c, a, b, n)
    implicit none
    integer :: n
    real :: c(:), a(:), b(:)
  end
end interface

  integer, parameter :: ub = 10
  real :: a(ub) = (/ (i, i=1, 10) /)
  real :: b(ub*2) = (/ (i, i=1, 20) /)
  real :: c(ub) = 0.
  call vadd(c(1:ub), a(1:ub), b(1:ub:2), 10)
  print *, c
end

BTW, classic-flang use copy-in-copy-out in caller for assumed-shape array, and all the strides are removed in the callee.

Fri, Mar 24, 3:48 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D144649: [flang] Implement isnan and ieee_is_nan intrinsics.

FYI I see couple of gfortran tests related to isnan are failing

maxlocval_2
maxlocval_4
minlocval_1
minlocval_4
namelist_42
namelist_43
nan_6
nearest_3

Fri, Mar 24, 3:16 AM · Restricted Project, Restricted Project

Thu, Mar 23

kiranchandramohan added a comment to D146766: [Flang][OpenMP] Support depend clause for task construct, excluding array sections.

Looks OK.

Thu, Mar 23, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested review of D146768: [Flang][OpenMP] Add TODO message for common block privatisation.
Thu, Mar 23, 3:55 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D144896: [OpenMP][MLIR] Add RTLModuleFlags attribute to OpenMP Dialect.

Sorry to ping

Pinging every week is not too much but considered OK.

FWIW, I think the patch is reasonable. I would remove the "rtl" part, and probably just call it "omp.flags" but otherwise it makes sense.
That said, @kiranchandramohan should give his opinion.

Thank you @jdoerfert I'll keep that in mind for the future!

Thank you, I'll wait on @kiranchandramohan's opinion before I update the name then, so as to get the next series of review comments done in a single update.

Sorry for the delay here. I would like to just have a quick check whether having an interface is possible. If not, we can continue with this. I will come back to this tomorrow.

I did not get much time to spend on this. But I have a patch ( https://reviews.llvm.org/D146721) with a trivial Device Interface. We can extend it later on and add attribute interfaces if required. It has two functions from one of @domada 's patch. As it is, the only benefits the interface gives are i) Put all the device related functions into a single place ii) Hide how the values are get and set (uses the module attributes that you have decided to use) iii) Makes it easy to change if there is a different mechanism iv) Also allows for an alternative implementation for other modules where these values are available differently. Please let me know how this looks. Also, given that this is straightforward I would also like to check whether I am missing anything.

HI Kiran, no worries, thank you very much for spending the time you could on it! I personally think it's quite a good method of doing things as far as getting and setting things go. If I am correct in my understanding (which perhaps I am not) it would alter this current patch by moving the set/get methods into the interface rather than the OpenMPDialect, but the attribute definition inside of OpenMPOps.td would remain the same? And would the lowering of module attributes within the OpenMPDialect change at all? or would it very much just be the same case of checking if the attribute exists on the operation as far as everything else is concerned (my assumption is it would be the same with my current knowledge of interfaces, I just want to double check).

Thu, Mar 23, 9:38 AM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D144896: [OpenMP][MLIR] Add RTLModuleFlags attribute to OpenMP Dialect.

Sorry to ping

Pinging every week is not too much but considered OK.

FWIW, I think the patch is reasonable. I would remove the "rtl" part, and probably just call it "omp.flags" but otherwise it makes sense.
That said, @kiranchandramohan should give his opinion.

Thank you @jdoerfert I'll keep that in mind for the future!

Thank you, I'll wait on @kiranchandramohan's opinion before I update the name then, so as to get the next series of review comments done in a single update.

Sorry for the delay here. I would like to just have a quick check whether having an interface is possible. If not, we can continue with this. I will come back to this tomorrow.

Thu, Mar 23, 7:03 AM · Restricted Project, Restricted Project
kiranchandramohan requested review of D146721: [Flang][OpenMP] WIP: Add a Device Interface.
Thu, Mar 23, 6:58 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 22

kiranchandramohan added a comment to D144896: [OpenMP][MLIR] Add RTLModuleFlags attribute to OpenMP Dialect.

Sorry to ping

Pinging every week is not too much but considered OK.

FWIW, I think the patch is reasonable. I would remove the "rtl" part, and probably just call it "omp.flags" but otherwise it makes sense.
That said, @kiranchandramohan should give his opinion.

Thank you @jdoerfert I'll keep that in mind for the future!

Thank you, I'll wait on @kiranchandramohan's opinion before I update the name then, so as to get the next series of review comments done in a single update.

Wed, Mar 22, 6:26 AM · Restricted Project, Restricted Project

Tue, Mar 21

kiranchandramohan added inline comments to D146292: [Flang][OpenMP] Added TODO checks for unsupported map types.
Tue, Mar 21, 10:10 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D146292: [Flang][OpenMP] Added TODO checks for unsupported map types.

You can test the TODOs if you want by adding tests like the following.
https://github.com/llvm/llvm-project/blob/main/flang/test/Lower/OpenMP/Todo/reduction-allocatable.f90

Tue, Mar 21, 7:53 AM · Restricted Project, Restricted Project

Mon, Mar 20

kiranchandramohan added a comment to D146063: [Flang][OpenMP][MLIR] Add lowering from parse tree to MLIR support for Declare Target for functions and subroutines.

The problem with doing this in two stages : i.e during lowering and a pass are that there are two representations for the same thing in the IR. One where the nested functions are not marked, and the other where they are not marked.

Mon, Mar 20, 6:54 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Mar 17

kiranchandramohan accepted D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..

LGTM. Please wait a day before submission. Move the flang portion to a separate commit.

Fri, Mar 17, 3:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Mar 16

kiranchandramohan updated subscribers of D141306: Add loop-versioning pass to improve unit-stride.

Thanks @MatsPetersson for working on this. I have started going through the patch and have some comments.

Thu, Mar 16, 4:48 PM · Restricted Project, Restricted Project

Wed, Mar 15

kiranchandramohan added a comment to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..

@jdoerfert Would using functions from compiler-rt cause issues with target offloading?
Context: We are thinking of using functions from compiler-rt for implementing the complex division operation. The existing implementations in Flang (an inline one) and the one on MLIR both have precision issues whereas the compiler-rt ones work fine.

Wed, Mar 15, 10:14 AM · Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D146075: [flang][driver][openmp] Write MLIR for -save-temps: MatsPetersson.
Wed, Mar 15, 8:12 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 14

kiranchandramohan committed rGc1125ae5b05f: [MLIR] : Add integer mul in scf to openmp conversion (authored by kiranchandramohan).
[MLIR] : Add integer mul in scf to openmp conversion
Tue, Mar 14, 2:57 PM · Restricted Project, Restricted Project
kiranchandramohan closed D145948: [MLIR] : Add integer mul in scf to openmp conversion.
Tue, Mar 14, 2:57 PM · Restricted Project, Restricted Project
kiranchandramohan committed rGf51bdae4e3d6: [Flang][OpenMP] Add support for OpenMP max reduction (authored by kiranchandramohan).
[Flang][OpenMP] Add support for OpenMP max reduction
Tue, Mar 14, 2:49 PM · Restricted Project, Restricted Project
kiranchandramohan closed D145083: [Flang][OpenMP] Add support for OpenMP max reduction.
Tue, Mar 14, 2:49 PM · Restricted Project, Restricted Project
kiranchandramohan reopened D145083: [Flang][OpenMP] Add support for OpenMP max reduction.
Tue, Mar 14, 12:02 PM · Restricted Project, Restricted Project
kiranchandramohan added a reverting change for rGa7d80f43cb8d: [Flang][OpenMP] Add support for OpenMP max reduction: rG62fbb4c34e74: Revert "[Flang][OpenMP] Add support for OpenMP max reduction".
Tue, Mar 14, 9:28 AM · Restricted Project, Restricted Project
kiranchandramohan committed rG62fbb4c34e74: Revert "[Flang][OpenMP] Add support for OpenMP max reduction" (authored by kiranchandramohan).
Revert "[Flang][OpenMP] Add support for OpenMP max reduction"
Tue, Mar 14, 9:28 AM · Restricted Project, Restricted Project
kiranchandramohan added a reverting change for D145083: [Flang][OpenMP] Add support for OpenMP max reduction: rG62fbb4c34e74: Revert "[Flang][OpenMP] Add support for OpenMP max reduction".
Tue, Mar 14, 9:28 AM · Restricted Project, Restricted Project
kiranchandramohan committed rGa7d80f43cb8d: [Flang][OpenMP] Add support for OpenMP max reduction (authored by kiranchandramohan).
[Flang][OpenMP] Add support for OpenMP max reduction
Tue, Mar 14, 9:02 AM · Restricted Project, Restricted Project
kiranchandramohan closed D145083: [Flang][OpenMP] Add support for OpenMP max reduction.
Tue, Mar 14, 9:02 AM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D143572: [RFC][Flang][driver] Try to support `flang -cc1as`.
Tue, Mar 14, 7:53 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D145819: [FuncSpec] Increase the maximum number of times the specializer can run..

@labrinea Is this patch the top-level patch for recursive function-specialization that benefits exchange2? Is there any setting required or would this perform specialization by default? Also, assuming this is with llvm-project/flang.

Tue, Mar 14, 5:16 AM · Restricted Project, Restricted Project

Mon, Mar 13

kiranchandramohan added inline comments to D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..
Mon, Mar 13, 3:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D145883: [Flang][RISCV] Emit target features for RISC-V.

LG. Please wait for and OK from @jrtc27.

Mon, Mar 13, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..

I wonder whether intermediate computations generated by ComplexToStandard conversion complex::DivOp honor the range of the element's data type. Maybe we can think of replacing the FIR operation with the one from the Complex dialect?

Mon, Mar 13, 10:32 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Mon, Mar 13, 9:55 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..
Mon, Mar 13, 9:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D145948: [MLIR] : Add integer mul in scf to openmp conversion.

Fixes one of the issues in https://github.com/llvm/llvm-project/issues/61342.

Mon, Mar 13, 8:46 AM · Restricted Project, Restricted Project
kiranchandramohan requested review of D145948: [MLIR] : Add integer mul in scf to openmp conversion.
Mon, Mar 13, 8:44 AM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Mon, Mar 13, 7:04 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D145932: [mlir] Support lowering of dialect attributes attached to top-level modules.
Mon, Mar 13, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D145883: [Flang][RISCV] Emit target features for RISC-V.
Mon, Mar 13, 3:45 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Mar 11

kiranchandramohan added reviewers for D145819: [FuncSpec] Increase the maximum number of times the specializer can run.: vzakhari, SBallantyne, kiranchandramohan.
Sat, Mar 11, 3:24 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D145410: [Flang][OpenMP] Add support for logical or reduction in worksharing-loop.
Sat, Mar 11, 2:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan committed rG890e6c871d31: [Flang][OpenMP] NFC: Fix a few format issues (authored by kiranchandramohan).
[Flang][OpenMP] NFC: Fix a few format issues
Sat, Mar 11, 2:56 AM · Restricted Project, Restricted Project

Fri, Mar 10

kiranchandramohan accepted D145410: [Flang][OpenMP] Add support for logical or reduction in worksharing-loop.

LG.

Fri, Mar 10, 9:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, Mar 9

kiranchandramohan added a comment to D145684: [flang] Fix host associated vars in OpenMP/OpenACC region.

@peixin Thanks for working on this. Could you check why the patch application is failing?

Thu, Mar 9, 3:02 PM · Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D129969: [flang][OpenMP][OpenACC] Support stop statement in OpenMP/OpenACC region: vdonaldson.

Adding @vdonaldson also to check whether this is the right way to do this and also for the interaction with the block construct.

Thu, Mar 9, 3:01 PM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..
Thu, Mar 9, 9:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D144203: [flang] Add basic support for alloca address space handling in FIR->LLVMIR codegen.

Sorry, I haven't had a chance to look at this in detail. I would need to get up to speed with addrspace in LLVM before proceeding with this. I would recommend someone from your organization review this patch and then @jeanPerier sign this off, if it is OK.

Thu, Mar 9, 8:36 AM · Restricted Project
kiranchandramohan added a reviewer for D145083: [Flang][OpenMP] Add support for OpenMP max reduction: do.
Thu, Mar 9, 6:22 AM · Restricted Project, Restricted Project
kiranchandramohan committed rG460c2eaa4ad5: [Flang][OpenMP] Restrict check to worksharing construct reductions (authored by kiranchandramohan).
[Flang][OpenMP] Restrict check to worksharing construct reductions
Thu, Mar 9, 6:14 AM · Restricted Project, Restricted Project
kiranchandramohan closed D144824: [Flang][OpenMP] Restrict check to worksharing construct reductions.
Thu, Mar 9, 6:13 AM · Restricted Project, Restricted Project
kiranchandramohan committed rG56164c3eb450: [Flang][MLIR][OpenMP] Add support for logical eqv in worksharing-loop (authored by DylanFleming-arm).
[Flang][MLIR][OpenMP] Add support for logical eqv in worksharing-loop
Thu, Mar 9, 6:04 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan closed D133442: [Flang][MLIR][OpenMP] Add support for logical eqv in worksharing-loop.
Thu, Mar 9, 6:04 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

kiranchandramohan requested changes to D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..
Wed, Mar 8, 8:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Mar 7

kiranchandramohan accepted D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute.

LG.

Tue, Mar 7, 10:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute.

LG. See one minor comment in the tests.

I would prefer having an Interface for Target Modules if that could be made to work. I guess this can be taken up separately after https://reviews.llvm.org/D144883.

Thank you Kiran, by interface for Target Modules do you mean a new omp.module or this type of external interface: https://mlir.llvm.org/docs/Interfaces/#external-models-for-attribute-operation-and-type-interfaces

And quite possibly, @skatrak is currently looking into the review comments in the referenced patch (as he found similar use for the patch), so we shall see where the results lead to. Never opposed to improving on the infrastructure and this is something we will iterate on as we progress with offloading! :)

Tue, Mar 7, 7:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute.

LG. See one minor comment in the tests.

Tue, Mar 7, 7:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..

Thanks for the update and the replies. See comments inline.

Tue, Mar 7, 2:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Mar 6

kiranchandramohan added a comment to D143077: [flang][OpenMP] Lowering support for lastprivate on unstructured sections construct.

Could you add a description in the summary or add a comment in the changed code on what this change does and how it fixes the issue?

Mon, Mar 6, 3:54 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..

I have some more comments.

Mon, Mar 6, 3:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Mar 3

kiranchandramohan committed rGfa5714387f20: [Flang][OpenMP] Fix unused variable warning/error (authored by kiranchandramohan).
[Flang][OpenMP] Fix unused variable warning/error
Fri, Mar 3, 8:10 AM · Restricted Project, Restricted Project
kiranchandramohan committed rGb512580cffc6: [Flang][OpenMP] NFC: Refactor privatization code in Lowering 1/n (authored by kiranchandramohan).
[Flang][OpenMP] NFC: Refactor privatization code in Lowering 1/n
Fri, Mar 3, 7:53 AM · Restricted Project, Restricted Project
kiranchandramohan closed D144766: [Flang][OpenMP] NFC: Refactor privatization code in Lowering 1/n.
Fri, Mar 3, 7:52 AM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..

Thanks for making the change.
I am still going through the patch, I have a few comments.

Fri, Mar 3, 5:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D145165: [Flang] Give fir.if RegionBranchOpInterface.
Fri, Mar 3, 4:36 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D144013: [MLIR][OpenMP] Add Lowering support for OpenMP Target Data with region.

It will also be helpful if you can add TODOs for the types that are not handled.

Hi, can you please tell me which types you are referring to here?

All types that can be present in a map clause. Should be most of the following, please consult the restrictions for the clause.
char, char array
integer, real, complex and arrays of these with both fixed and variable length
pointer, allocatable, assumed shape arrays
derived type
derived type components, array-sections
polymorphic

Yes all these types should work for map operands. Is this patch good to go?

Fri, Mar 3, 3:06 AM · Restricted Project, Restricted Project

Thu, Mar 2

kiranchandramohan committed rG0ca86a42f0c1: [Flang][OpenMP] Improved reduction clause TODO message (authored by kiranchandramohan).
[Flang][OpenMP] Improved reduction clause TODO message
Thu, Mar 2, 9:47 AM · Restricted Project, Restricted Project
kiranchandramohan closed D145061: [Flang][OpenMP] Improved reduction clause TODO message.
Thu, Mar 2, 9:47 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D144966: [flang] Implement ieee_is_normal.

LGTM.

Thu, Mar 2, 8:04 AM · Restricted Project, Restricted Project
kiranchandramohan updated the diff for D145083: [Flang][OpenMP] Add support for OpenMP max reduction.

Change name of operation in assert to fix CI failure.

Thu, Mar 2, 4:30 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D144896: [OpenMP][MLIR] Add RTLModuleFlags attribute to OpenMP Dialect.

The other option is for Modules to implement an interface and then the Translation can detect this and forward it to the OpenMP Dialect translation in OpenMPToLLVMIRTranslation.cpp.

Thu, Mar 2, 2:39 AM · Restricted Project, Restricted Project

Wed, Mar 1

kiranchandramohan requested review of D145083: [Flang][OpenMP] Add support for OpenMP max reduction.
Wed, Mar 1, 10:12 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D144203: [flang] Add basic support for alloca address space handling in FIR->LLVMIR codegen.

Thanks for the changes and the replies.

Wed, Mar 1, 6:02 AM · Restricted Project
kiranchandramohan added inline comments to D144966: [flang] Implement ieee_is_normal.
Wed, Mar 1, 5:40 AM · Restricted Project, Restricted Project
kiranchandramohan requested review of D145061: [Flang][OpenMP] Improved reduction clause TODO message.
Wed, Mar 1, 5:21 AM · Restricted Project, Restricted Project
kiranchandramohan committed rG86b8abc2dd08: [Flang][WWW] Update Bug Reports link to point to Github issues (authored by kiranchandramohan).
[Flang][WWW] Update Bug Reports link to point to Github issues
Wed, Mar 1, 4:18 AM · Restricted Project, Restricted Project

Tue, Feb 28

kiranchandramohan added a comment to D144013: [MLIR][OpenMP] Add Lowering support for OpenMP Target Data with region.

It will also be helpful if you can add TODOs for the types that are not handled.

Hi, can you please tell me which types you are referring to here?

Tue, Feb 28, 8:17 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D142420: [Flang] Add support to use LTO specific pipelines.

LGTM. Please wait for @awarzynski.

Tue, Feb 28, 5:56 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D144013: [MLIR][OpenMP] Add Lowering support for OpenMP Target Data with region.
Tue, Feb 28, 3:08 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D144824: [Flang][OpenMP] Restrict check to worksharing construct reductions.

Thanks @luporl for having a look. There are a few fixes that are going in the privatisation area. I think the issue you are pointing out with your example will also be fixed by that. This fix is not causing the issue that you are seeing.

Tue, Feb 28, 1:33 AM · Restricted Project, Restricted Project
kiranchandramohan updated the summary of D144824: [Flang][OpenMP] Restrict check to worksharing construct reductions.
Tue, Feb 28, 1:30 AM · Restricted Project, Restricted Project

Mon, Feb 27

kiranchandramohan added a comment to D144013: [MLIR][OpenMP] Add Lowering support for OpenMP Target Data with region.

It will also be helpful if you can add TODOs for the types that are not handled.

Mon, Feb 27, 2:16 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute.

Could you update the discourse thread (https://discourse.llvm.org/t/rfc-omp-module-and-omp-function-vs-dialect-attributes-to-encode-openmp-properties/67998) with the chosen approach and reasons before proceeding?

Mon, Feb 27, 2:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D144896: [OpenMP][MLIR] Add RTLModuleFlags attribute to OpenMP Dialect.

Could you update the discourse thread (https://discourse.llvm.org/t/rfc-omp-module-and-omp-function-vs-dialect-attributes-to-encode-openmp-properties/67998) with the chosen approach and reasons before proceeding?

Mon, Feb 27, 2:06 PM · Restricted Project, Restricted Project
kiranchandramohan committed rG7d7633bdf489: [Flang][OpenMP][OpenACC] Error for loop with no control (authored by kiranchandramohan).
[Flang][OpenMP][OpenACC] Error for loop with no control
Mon, Feb 27, 8:55 AM · Restricted Project, Restricted Project
kiranchandramohan closed D144290: [Flang][OpenMP][OpenACC] Error for loop with no control.
Mon, Feb 27, 8:55 AM · Restricted Project, Restricted Project
kiranchandramohan committed rG54acf9a3a31e: [Flang][OpenMP] NFC: Change a few message/comments to fit 80chars (authored by kiranchandramohan).
[Flang][OpenMP] NFC: Change a few message/comments to fit 80chars
Mon, Feb 27, 8:42 AM · Restricted Project, Restricted Project
kiranchandramohan closed D144874: [Flang][OpenMP] NFC: Change a few message/comments to fit 80chars Changes are all in the OpenMP semantic checks file..
Mon, Feb 27, 8:42 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D144013: [MLIR][OpenMP] Add Lowering support for OpenMP Target Data with region.

Thanks. LGTM.

Mon, Feb 27, 8:10 AM · Restricted Project, Restricted Project
kiranchandramohan requested review of D144874: [Flang][OpenMP] NFC: Change a few message/comments to fit 80chars Changes are all in the OpenMP semantic checks file..
Mon, Feb 27, 7:28 AM · Restricted Project, Restricted Project
kiranchandramohan added reviewers for D144869: [Flang][Tool][bbc] Emit Module Wrapper in addition to body: jeanPerier, clementval.

This will need a discussion with the FIR team.

Mon, Feb 27, 6:19 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D142420: [Flang] Add support to use LTO specific pipelines.

ping @mnadeem. Do you need any inputs or helpf to complete this patch?

Mon, Feb 27, 5:06 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D144290: [Flang][OpenMP][OpenACC] Error for loop with no control: DavidTruby.
Mon, Feb 27, 4:01 AM · Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D144766: [Flang][OpenMP] NFC: Refactor privatization code in Lowering 1/n: DavidTruby.
Mon, Feb 27, 3:34 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D144013: [MLIR][OpenMP] Add Lowering support for OpenMP Target Data with region.

Thanks, that looks good. The runtime is in charge of mapping and copying the data. I guess it will transparently map the address from the host pointer to the device address space since it stores the mapping.

Mon, Feb 27, 3:31 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D133442: [Flang][MLIR][OpenMP] Add support for logical eqv in worksharing-loop.

Note to self: Please add the relevant tests in flang/test/Fir/convert-to-llvm-openmp-and-fir.fir and mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir before submitting.

Mon, Feb 27, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan retitled D133442: [Flang][MLIR][OpenMP] Add support for logical eqv in worksharing-loop from [WIP][Flang][OpenMP] Add support for logical eqv in worksharing-loop to [Flang][MLIR][OpenMP] Add support for logical eqv in worksharing-loop.
Mon, Feb 27, 3:06 AM · Restricted Project, Restricted Project, Restricted Project