- User Since
- May 5 2017, 1:55 PM (152 w, 4 d)
Thanks @kiranktp for working on this. Looks OK to me.
Mar 5 2020
Thanks for the reviews. Committing with changes suggested.
Feb 28 2020
Just wanted to check whether @rriddle has more comments on this patch.
Feb 21 2020
Will tests come in a later patch?
Feb 20 2020
Added LLVMFrontendOpenMP and MLIROpenMP to the dependency of MLIRLLVMIR and also linking these libraries along with MLIRLLVMIR. Removed from other clients.
Feb 19 2020
This revision includes the following changes,
-> Removed the enable-openmp flag.
-> Addressed review comments from @ftynse.
Feb 12 2020
Thanks for your comments.
LGTM. You can wait for a day in case other reviewers have comments.
Feb 11 2020
Looks OK to me.
Couple of comments inline.
Feb 7 2020
Feb 6 2020
Feb 4 2020
Feb 3 2020
Had a quick look today. Will spend some more time tomorrow.
Please see a few comments inline.
Jan 28 2020
Thanks @ftynse for the comments. I will make a patch soon to address comments. The only question is regarding the necessity of the flag. Please see comment inline.
Jan 27 2020
The enable-openmp flag is now local to file mlir/lib/Target/LLVMIR/ModuleTranslation.cpp. Added a function to lazily create the OpenMPIR builder when an OpenMP dialect op is detected.
Jan 23 2020
I have taken @rriddle's suggestion and moved the translation into the LLVM translator. Also using unique pointer for the OpenMPIRBuilder. I believe this fixes the null pointer issue pointed out by @jdoerfert.
In this patch the code for translation is added to the existing LLVM dialect translation to LLVM IR. A new flag enable-openmp is used to enable the OpenMP translation.
Jan 17 2020
Made changes suggested by the clang-format bot.
Dec 10 2019
Dec 5 2019
Nov 29 2019
In general, I also worry that i might have missed some checks. I was hoping to get some pointers on how to run some tests so that we can minimise this. At the same time, I also feel that this change should not cause regressions.
Addressed review comments.
- Adding a test
- Change emitFlush to CreateFlush in OpenMPIRBuilder.cpp
- Use updateLoc
- Fixed formatting
Nov 28 2019
Nov 26 2019
Apologies, will wait for the reviews.
Does this patch need additional reviews or changes?
Nov 25 2019
- Fixed formatting in llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
- Updated test to work with minimal attributes and removed prefixes for checks
Nov 22 2019
Nov 20 2019
Nov 19 2019
Thanks @jdoerfert for working on this.
Sep 18 2019
Some minor comments about Filetypes and file extensions. Can be ignored or considered for a separate commit.