Page MenuHomePhabricator

kiranchandramohan (Kiran Chandramohan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2017, 1:55 PM (186 w, 3 d)

Recent Activity

Today

kiranchandramohan added inline comments to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.
Mon, Nov 30, 8:29 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested review of D92327: [MLIR][OpenMP][WIP] Pretty printer and parser for omp.wsloop.
Mon, Nov 30, 8:12 AM · Restricted Project
kiranchandramohan accepted D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

LGTM. Thanks @praveen.

Mon, Nov 30, 6:08 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Nov 25

kiranchandramohan added inline comments to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Wed, Nov 25, 2:12 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Wed, Nov 25, 5:35 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90184: [flang][openacc] Semantic check for cache directive.

LGTM.

Wed, Nov 25, 1:01 AM · Restricted Project, Restricted Project

Tue, Nov 24

kiranchandramohan added inline comments to D90184: [flang][openacc] Semantic check for cache directive.
Tue, Nov 24, 11:13 AM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D91982: [mlir] Add conversion from SCF parallel loops to OpenMP.

LGTM.

Do you need the lowering to LLVM IR also sometime soon?

Previously, did you mention something about a parallelisation strategy and SCF ops carrying an attribute to determine whether they should be lowered to OpenMP parallel loops.

@SouraVX we can discuss the lowering separately for Flang. Since we decided to represent the work-sharing loop as a loop like operation (omp.wsloop), lowering directly to the work-sharing loop from the parse tree will be the straight forward method. If there are difficulties with that we can think of lowering to fir.do_loop and then converting to omp.wsloop but I think this might need modification of fir.do_loop or addition of a directive like operation in FIR.

Thanks for the quick review!

I am in the process of writing a translation to LLVM IR, happy to use anything that is already available.

Tue, Nov 24, 9:52 AM · Restricted Project
kiranchandramohan accepted D91982: [mlir] Add conversion from SCF parallel loops to OpenMP.

Do you need the lowering to LLVM IR also sometime soon?

Tue, Nov 24, 9:15 AM · Restricted Project
kiranchandramohan updated subscribers of D91982: [mlir] Add conversion from SCF parallel loops to OpenMP.

Thanks for this patch.

Tue, Nov 24, 6:39 AM · Restricted Project
kiranchandramohan updated subscribers of D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Tue, Nov 24, 1:22 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Nov 23

kiranchandramohan added a comment to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

@praveen can you reply inline in each comment whether you have made the changes suggested, reply to the question asked, or give your opinion? That way it will be easier for me to review.

Mon, Nov 23, 2:35 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D91989: [mlir] Support WsLoopOp in OpenMP to LLVM dialect conversion.

Thanks. LGTM.

Mon, Nov 23, 2:02 PM · Restricted Project
kiranchandramohan requested changes to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Mon, Nov 23, 6:24 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Nov 22

kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan In the test file omp-clause-validity01.f90 , the following no symbol found errors are not being thrown.

!ERROR: Internal: no symbol found for 'i'
!$omp taskwait depend(sink:i-1)

!ERROR: Internal: no symbol found for 'first'
!$omp critical (first)

Since the errors related to copyprivate clause in omp-clause-validity01.f90 (line numbers 324 and 340 above) being thrown as part of the checks for copyprivate in resolve-directives.cpp are marked as fatal errors , the flag errorOnUnresolvedName_ is being set to false and the no symbol found error is not being thrown.

 RewriteMutator(SemanticsContext &context)
 : errorOnUnresolvedName_{!context.AnyFatalError()},
    messages_{context.messages()} {}

void RewriteMutator::Post(parser::Name &name) {
   if (!name.symbol && errorOnUnresolvedName_) {
     messages_.Say(name.source, "Internal: no symbol found for '%s'"_err_en_US,
       name.source);
    }
 }

Is it not necessary to throw the "no symbol found" error if there is any error marked as fatal while resolving the directives ?

Should all the checks related to copyprivate be moved to check-omp-structure.cpp?

Can you please suggest the approach to follow for these changes?

Thanks!

Sun, Nov 22, 3:38 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Nov 21

kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Flang.Semantics::omp-clause-validity01.f90

Script:

: 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/flang/test/Semantics/test_errors.sh /mnt/disks/ssd0/agent/llvm-project/flang/test/Semantics/omp-clause-validity01.f90 /mnt/disks/ssd0/agent/llvm- project/build/tools/flang/test/Semantics/Output/omp-clause-validity01.f90.tmp /mnt/disks/ssd0/agent/llvm-project/build/bin/f18 -intrinsic-module-directory /mnt/disks/ssd0/agent/llvm-project/build/tools/flang/include/flang -fopenmp

Sat, Nov 21, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Sat, Nov 21, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

No issues, please go ahead.

Sat, Nov 21, 2:57 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

LGTM.

Sat, Nov 21, 8:25 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

Looks OK to me. Couple of minor comments.

Sat, Nov 21, 6:29 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.

@kiranchandramohan does this seem ok from query which was raised in https://reviews.llvm.org/D89583#inline-836220 comment ?

Sat, Nov 21, 5:29 AM · Restricted Project, Restricted Project

Fri, Nov 20

kiranchandramohan accepted D91889: [flang][openacc] Add clause validity tests for the host_data directive.

LGTM.

Fri, Nov 20, 2:10 PM · Restricted Project
kiranchandramohan updated subscribers of D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

I will provide my understanding below. Can also check with @huntergr @Meinersbur.

Fri, Nov 20, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

I guess the only remaining point to address is to handle return the pass/fail status to MLIR module translation.

Fri, Nov 20, 8:36 AM · Restricted Project
kiranchandramohan retitled D88706: [OpenMP][MLIR] WIP : Fix for AllocaIP from [OpenMP][MLIR] WIP : Fix for nested parallel region to [OpenMP][MLIR] WIP : Fix for AllocaIP.
Fri, Nov 20, 7:28 AM · Restricted Project, Restricted Project

Thu, Nov 19

kiranchandramohan added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Thu, Nov 19, 3:37 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Nov 18

kiranchandramohan added a comment to D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Thanks @Meinersbur for your comments. I will have a look soon. I suspect these are only used now for generating string enum classes in mlir openmp.

Wed, Nov 18, 2:55 PM · Restricted Project, Restricted Project

Tue, Nov 17

kiranchandramohan added a reviewer for D91556: Add capturing of parameters to pass to omp::parallel: jdoerfert.

Thanks @llitchev for this patch.

Tue, Nov 17, 4:29 PM · Restricted Project

Mon, Nov 16

kiranchandramohan added a comment to D91159: [flang]Add General Semantic Checks for Allocate Directive.

I) Are you handling only a subset of the restrictions here? I see the following in,

  1. General restrictions.

-> allocate directives that appear in a target region must specify an allocator clause unless a requires directive with the dynamic_allocators clause is present in the same compilation unit.

Mon, Nov 16, 10:57 AM · Restricted Project
kiranchandramohan requested changes to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Mon, Nov 16, 10:43 AM · Restricted Project, Restricted Project
kiranchandramohan committed rG843525075b87: [MLIR][OpenMP] Add omp.wsloop operation (authored by DavidTruby).
[MLIR][OpenMP] Add omp.wsloop operation
Mon, Nov 16, 7:25 AM
kiranchandramohan closed D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Mon, Nov 16, 7:25 AM · Restricted Project, Restricted Project

Sun, Nov 15

kiranchandramohan added a comment to D91002: [OpenMP] Fix asm for arm64-darwin.

I tested with make check-openmp and make check-clang on an AArch64 linux machine and both versions (D91002,D88252) pass.
If you were asking for a different kind of testing then please let me know.

Sun, Nov 15, 1:47 PM · Restricted Project

Fri, Nov 13

kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

@clementval had some changes for the OpenACC reduction operator in the following commit. I am not sure whether it is related to this issue.
https://reviews.llvm.org/D86296

Fri, Nov 13, 7:45 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause.

LGTM.

Fri, Nov 13, 7:33 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 12

kiranchandramohan added a comment to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

ping.

Thu, Nov 12, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause.

Would need a response for questions above to proceed to acceptance.

Thu, Nov 12, 5:52 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Would need a response for questions above to proceed to acceptance.

Thu, Nov 12, 5:51 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

@yhegde please submit. If you require any inputs then please let me know. This will be helpful for D91159.

Thu, Nov 12, 5:48 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

@yhegde can this be submitted? If you require inputs from me please let me know.

Thu, Nov 12, 5:47 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.

@yhegde Can this be submitted? If you need any further inputs please let me know.

Thu, Nov 12, 5:45 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Nov 8

kiranchandramohan accepted D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

OK. LGTM.

Sun, Nov 8, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.

Nit: Please reply inline and mark suggested changes as done.

Sun, Nov 8, 4:00 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 6

kiranchandramohan added inline comments to D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Fri, Nov 6, 11:34 AM · Restricted Project, Restricted Project
kiranchandramohan updated the diff for D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Addressed formatting comments and description changes suggested by @ftynse.

Fri, Nov 6, 11:32 AM · Restricted Project, Restricted Project

Thu, Nov 5

kiranchandramohan accepted D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

LGTM.

Thu, Nov 5, 7:48 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive.

LGTM.

Thu, Nov 5, 7:17 AM · Restricted Project

Tue, Nov 3

kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thanks for this patch.

Tue, Nov 3, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan committed rGab8a4cec5585: [MLIR] NFC : Move OpenMP dialect include to translation (authored by kiranchandramohan).
[MLIR] NFC : Move OpenMP dialect include to translation
Tue, Nov 3, 2:14 PM
kiranchandramohan closed D90510: [MLIR] NFC : Move OpenMP dialect include to translation.
Tue, Nov 3, 2:14 PM · Restricted Project
kiranchandramohan accepted D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause..
Tue, Nov 3, 5:43 AM · Restricted Project, Restricted Project

Mon, Nov 2

kiranchandramohan accepted D90324: [Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it..

Thanks for the cleanup. If you can remove the macros in a later patch that would be great.

Mon, Nov 2, 3:02 PM · Restricted Project, Restricted Project
kiranchandramohan accepted D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.

LGTM.

Mon, Nov 2, 2:44 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.

LGTM. Have a nit comment inline about how to construct the message.

Mon, Nov 2, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90358: [openmp][openacc][NFC] Simplify access and validation of DirectiveBase information.

LGTM.

Mon, Nov 2, 2:04 PM · Restricted Project
kiranchandramohan added a comment to D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause..

Two more questions.

Mon, Nov 2, 1:14 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause..

Thanks @sameeranjoshi for this patch. Couple of questions inline.

Mon, Nov 2, 10:32 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

LGTM.
Please wait for approval from @clementval after uppercasing the clause names.

Mon, Nov 2, 8:11 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

A few questions. Otherwise LGTM.

Mon, Nov 2, 7:38 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D90510: [MLIR] NFC : Move OpenMP dialect include to translation.

CMake changes were made in https://reviews.llvm.org/D88351.

Mon, Nov 2, 12:33 AM · Restricted Project

Oct 31 2020

kiranchandramohan added a comment to D90324: [Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it..

What benefit do you see compared to the current approach?

We cannot put a breakpoint in macros.

Oct 31 2020, 12:12 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D90324: [Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it..

Another way would be to classify various OpenMP clauses similar to what is done in PFT.
https://github.com/llvm/llvm-project/blob/09662eeb46f76cda0a8d1102d8f67f7ad8ad64de/flang/include/flang/Lower/PFTBuilder.h#L115
https://github.com/llvm/llvm-project/blob/09662eeb46f76cda0a8d1102d8f67f7ad8ad64de/flang/include/flang/Lower/PFTBuilder.h#L145

Oct 31 2020, 11:44 AM · Restricted Project, Restricted Project

Oct 30 2020

kiranchandramohan requested review of D90510: [MLIR] NFC : Move OpenMP dialect include to translation.
Oct 30 2020, 3:42 PM · Restricted Project
kiranchandramohan added a comment to D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause.

Thanks for the patch. A few questions inline.

Oct 30 2020, 7:57 AM · Restricted Project, Restricted Project, Restricted Project

Oct 29 2020

kiranchandramohan requested changes to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

Thanks for this patch. A few comments inline.

Oct 29 2020, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D90324: [Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it..

We might even go further and generate these with TableGen. I guess we have most of the information in OMP.td or ACC.td for that.
Anyway might be wise to first land this patch and look at TableGen in a next step. Would be happy to look at it if it makes sense.

+1

Oct 29 2020, 2:54 AM · Restricted Project, Restricted Project

Oct 28 2020

kiranchandramohan accepted D90241: [openmp][openacc] Check for duplicate clauses for directive.

LGTM.

Oct 28 2020, 11:48 AM · Restricted Project
kiranchandramohan added inline comments to D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Oct 28 2020, 8:32 AM · Restricted Project, Restricted Project
kiranchandramohan updated the diff for D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Taking over from @DavidTruby on this patch. Contains the following modifications,
Added a yield terminator (omp.yield).
Restricted loop indices to llvm integer, integer, index types
Added an example
Addressed other minor text changes comments

Oct 28 2020, 8:27 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D90241: [openmp][openacc] Check for duplicate clauses for directive.
Oct 28 2020, 1:37 AM · Restricted Project

Oct 27 2020

kiranchandramohan added a comment to D90241: [openmp][openacc] Check for duplicate clauses for directive.

This is a good verification check. A few questions.

Oct 27 2020, 2:58 PM · Restricted Project
kiranchandramohan added a comment to D88655: [Flang][OpenMP][OpenACC] Fix exit out of a region in OpenMP parallel construct..

Nit: I believe this only handles exit out of a region. It does not fully handle the branching (goto etc) out issue. Can you update the title and description to reflect this?

Oct 27 2020, 9:00 AM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D88609: Use uint64_t for branch weights instead of uint32_t.

@thakis Can you revert the testcase fix in MLIR also which was necessary after this patch? https://reviews.llvm.org/rG0fc1aa22ee6ac337a5d51fa5666c9cd61da61b07

Oct 27 2020, 7:20 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D88609: Use uint64_t for branch weights instead of uint32_t.

Updated mlir test also to include this change.
https://reviews.llvm.org/rG0fc1aa22ee6ac337a5d51fa5666c9cd61da61b07

Oct 27 2020, 1:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
kiranchandramohan committed rG0fc1aa22ee6a: Updating llvm.mlir test to match recent IR change (authored by kiranchandramohan).
Updating llvm.mlir test to match recent IR change
Oct 27 2020, 1:18 AM

Oct 26 2020

kiranchandramohan added a comment to D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly..

I have added a fix to run the test only when the X86 target is available. Please feel free to change if it is not the correct fix.
https://github.com/llvm/llvm-project/commit/c551ba0e90bd2b49ef501d591f8362ba44e5484d

Oct 26 2020, 2:41 PM · Restricted Project, Restricted Project
kiranchandramohan committed rGc551ba0e90bd: Run test only if X86 target is available (authored by kiranchandramohan).
Run test only if X86 target is available
Oct 26 2020, 2:39 PM
kiranchandramohan added a comment to D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly..

This change probably requires the X86 target.
// REQUIRES: x86-registered-target

Oct 26 2020, 5:37 AM · Restricted Project, Restricted Project

Oct 25 2020

kiranchandramohan commandeered D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Oct 25 2020, 4:30 PM · Restricted Project, Restricted Project

Oct 23 2020

kiranchandramohan added reviewers for D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause: clementval, kiranktp, SouraVX.
Oct 23 2020, 8:59 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.

LGTM. A few nit comments. Please check that check-clang also passes (since you changed a shared file, OMP.td).

Oct 23 2020, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:34 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Oct 23 2020, 8:10 AM · Restricted Project, Restricted Project
kiranchandramohan added reviewers for D89562: [flang]Add Parser Support for OpenMP Allocate Directive: clementval, sameeranjoshi.
Oct 23 2020, 7:48 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D89769: [flang][OpenMP] Upstream lowering of `ParallelOp` clauses.

LGTM.

Oct 23 2020, 6:42 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D88628: [flang][openacc] Fix semantic check for wait and atomic directives.

LGTM.

Oct 23 2020, 6:41 AM · Restricted Project, Restricted Project

Oct 21 2020

kiranchandramohan added inline comments to D89583: [Flang][OpenMP] Semantic checks for Atomic construct..
Oct 21 2020, 2:18 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.

This looks fine. Can all the tests be in a single file?

Oct 21 2020, 3:08 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

Thanks for this patch. A few comments inline.

Oct 21 2020, 2:57 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2020

kiranchandramohan added reviewers for D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder.: SouraVX, alok.
Oct 20 2020, 1:19 PM · Restricted Project
kiranchandramohan added inline comments to D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.
Oct 20 2020, 2:46 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2020

kiranchandramohan added a comment to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

Can you provide more information about the allocate directive in the summary/description of this patch?
-> Point to the section in the standard.
-> Explain that the standard specifies a declarative and executable version.

Oct 19 2020, 2:57 AM · Restricted Project, Restricted Project
kiranchandramohan committed rGa71a0d6d219a: [OpenMP][MLIR] Fix for nested parallel regions (authored by kiranchandramohan).
[OpenMP][MLIR] Fix for nested parallel regions
Oct 19 2020, 12:50 AM
kiranchandramohan closed D88720: [OpenMP][MLIR] Fix for nested parallel regions.
Oct 19 2020, 12:50 AM · Restricted Project

Oct 16 2020

kiranchandramohan added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

Thanks for this patch. Did you miss the array element check?

Oct 16 2020, 2:54 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.

Thanks for this patch.

Oct 16 2020, 8:56 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.
  1. Does the EnumToString function in the parser work for this enum value?
Oct 16 2020, 8:30 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

File ./tools/mlir/include/mlir/Dialect/OpenMP/OpenMPOpsEnums.cpp.inc has the following function. Isn't it possible to use this function?
For e.g: If you pass it mlir::omp::ClauseProcBindKind::master it will return the string "master".

Oct 16 2020, 7:30 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2020

kiranchandramohan added a comment to D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.

Thanks @praveen for this patch. Can you add a few positive tests as well?

Oct 14 2020, 4:50 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.

I guess @clementval or @rriddle can approve the new extra functions added based on its need in Flang parse-tree lowering or on similar usage for StrEnumAttributes in rest of MLIR.

Oct 14 2020, 1:43 PM · Restricted Project, Restricted Project, Restricted Project