Page MenuHomePhabricator

kiranchandramohan (Kiran Chandramohan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2017, 1:55 PM (205 w, 3 d)

Recent Activity

Yesterday

kiranchandramohan requested changes to D100224: [flang][OpenMP] Add semantic check for occurrence of variables other than loop iteration variable in a `linear` clause associated with a `distribute` construct..
Mon, Apr 12, 12:42 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Apr 11

kiranchandramohan requested changes to D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
Sun, Apr 11, 4:16 PM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D100041: [flang][OpenMP] Add semantic checks for strict nesting inside `teams` construct..
Sun, Apr 11, 4:16 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D100041: [flang][OpenMP] Add semantic checks for strict nesting inside `teams` construct..
Sun, Apr 11, 4:16 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
Sun, Apr 11, 3:10 PM · Restricted Project, Restricted Project

Sat, Apr 10

kiranchandramohan accepted D100222: [flang][OpenMP] Modify semantic check for nesting of `ordered` regions to include `close` nesting check..

LGTM.

Sat, Apr 10, 7:09 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Sat, Apr 10, 6:50 AM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.
Sat, Apr 10, 3:19 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Apr 9

kiranchandramohan added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Two first comments. I will do a detailed review later.

Fri, Apr 9, 10:45 AM · Restricted Project, Restricted Project
kiranchandramohan committed rG9da35814e5fb: [Flang] Changes to mangling code (authored by schweitz).
[Flang] Changes to mangling code
Fri, Apr 9, 9:14 AM
kiranchandramohan closed D99967: [Flang] Changes to mangling code.
Fri, Apr 9, 9:14 AM · Restricted Project

Thu, Apr 8

kiranchandramohan accepted D99970: [flang][OpenMP] Add functionality to check "close nesting" of regions, which can be used for Semantic checks..

LGTM. Thanks for the changes and the tests.

Thu, Apr 8, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Apr 7

kiranchandramohan accepted D99645: [flang][driver] Add debug options not requiring semantic checks.

Might be good to have a test for fdebug-dump-parse-tree-no-sema.

Wed, Apr 7, 10:43 AM · Restricted Project, Restricted Project

Tue, Apr 6

kiranchandramohan added inline comments to D99970: [flang][OpenMP] Add functionality to check "close nesting" of regions, which can be used for Semantic checks..
Tue, Apr 6, 1:59 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D99645: [flang][driver] Add debug options not requiring semantic checks.
Tue, Apr 6, 11:20 AM · Restricted Project, Restricted Project
kiranchandramohan updated the summary of D99967: [Flang] Changes to mangling code.
Tue, Apr 6, 11:15 AM · Restricted Project
kiranchandramohan added inline comments to D99970: [flang][OpenMP] Add functionality to check "close nesting" of regions, which can be used for Semantic checks..
Tue, Apr 6, 11:09 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested review of D99967: [Flang] Changes to mangling code.
Tue, Apr 6, 9:06 AM · Restricted Project
kiranchandramohan added a comment to D99892: [flang] Improve constant folding for type parameter inquiries.

@PeteSteinfeld I have reverted this patch since I could not find a quick fix.
https://reviews.llvm.org/rGb7ef804807855e607da3eba221c1fc59e27f778e

Tue, Apr 6, 1:20 AM · Restricted Project, Restricted Project
kiranchandramohan added a reverting change for rG8c7bf2f93da9: [flang] Improve constant folding for type parameter inquiries: rGb7ef80480785: Revert "[flang] Improve constant folding for type parameter inquiries".
Tue, Apr 6, 1:13 AM
kiranchandramohan committed rGb7ef80480785: Revert "[flang] Improve constant folding for type parameter inquiries" (authored by kiranchandramohan).
Revert "[flang] Improve constant folding for type parameter inquiries"
Tue, Apr 6, 1:13 AM
kiranchandramohan added a reverting change for D99892: [flang] Improve constant folding for type parameter inquiries: rGb7ef80480785: Revert "[flang] Improve constant folding for type parameter inquiries".
Tue, Apr 6, 1:13 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D99892: [flang] Improve constant folding for type parameter inquiries.

We have a buildbot CI failure due to this patch.
https://lab.llvm.org/buildbot/#/builders/33/builds/3463

Tue, Apr 6, 12:23 AM · Restricted Project, Restricted Project

Mon, Apr 5

kiranchandramohan added inline comments to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Mon, Apr 5, 3:20 PM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Mon, Apr 5, 2:51 PM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Mon, Apr 5, 2:37 PM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Mon, Apr 5, 2:03 PM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Mon, Apr 5, 10:13 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
Mon, Apr 5, 7:35 AM · Restricted Project, Restricted Project

Fri, Apr 2

kiranchandramohan added a comment to D99666: [flang] Implement reductions in the runtime.

@klausler We have a buildbot failing with the following error. https://lab.llvm.org/buildbot/#/builders/33/builds/3439

Fri, Apr 2, 12:10 PM · Restricted Project, Restricted Project

Tue, Mar 30

kiranchandramohan accepted D99292: [flang][driver] Add support for `-cpp/-nocpp`.

LGTM.

Tue, Mar 30, 1:55 PM · Restricted Project, Restricted Project
kiranchandramohan accepted D99494: [flang] Move .f77 to the list of fixed-form file extension.

LGTM.

Tue, Mar 30, 1:54 PM · Restricted Project, Restricted Project

Thu, Mar 25

kiranchandramohan added a comment to D99292: [flang][driver] Add support for `-cpp/-nocpp`.

minor comments.

Thu, Mar 25, 7:32 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..

I made a trivial fix to get the builds to pass.
https://reviews.llvm.org/rG502f27e66fd9fe44cd45ec5acae3e18f15f2d8c6

Thu, Mar 25, 3:01 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D98468: Define a `NoTerminator` traits that allows operations with a single block region to not provide a terminator.
Thu, Mar 25, 2:37 AM · Restricted Project
kiranchandramohan committed rG502f27e66fd9: Trivial change to fix builds (authored by kiranchandramohan).
Trivial change to fix builds
Thu, Mar 25, 2:32 AM

Tue, Mar 23

kiranchandramohan accepted D99198: [flang] Fix output buffering bug.

LGTM. Thanks Peter for fixing this quickly.

Tue, Mar 23, 2:12 PM · Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D99198: [flang] Fix output buffering bug: Leporacanthicus.
Tue, Mar 23, 10:04 AM · Restricted Project, Restricted Project

Mon, Mar 22

kiranchandramohan added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mon, Mar 22, 12:24 PM · Restricted Project, Restricted Project

Sat, Mar 20

kiranchandramohan added a comment to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..

The OpenMP for Flang team has consistently been asking for upstreaming the fir-dev branch. I made an initial attempt to upstream a portion in May last year (https://reviews.llvm.org/D79731) which was discarded since it
did not have any community support. The current situation presents a few difficulties for the OpenMP team.

  1. The OpenMP dialect is in the llvm-project repo, while FIR codegen is developed in the fir-dev repo. So we have to first make a patch to llvm-project/mlir and then wait for it to be merged into the fir-dev repo (which can take from one to two weeks) and then make the relevant changes in the fir-dev repo. If FIR codegen was also upstream then this delay and committing to multiple repositories can be avoided.
  2. Since the bridge code (parse-tree to FIR) and codegen is not available in llvm-project/flang, any commits that we make to fir-dev cannot be upstreamed. So all our changes are also increasing the diff between fir-dev and upstream llvm-project/flang. Left uncontrolled this might become an untameable monster and we might never be able to fully upstream fir-dev.
  3. Since the OpenMP code which works with FIR is in fir-dev we cannot often show the context to MLIR core team. On at least one occasion this has become an issue while seeking help. If the code is upstream this will facilitate better discussions with the MLIR core team.
Sat, Mar 20, 9:30 AM · Restricted Project, Restricted Project

Thu, Mar 18

kiranchandramohan added a comment to D97346: [mlir] Add vector op support to cuda-runner including vector.print.

Failing a buildbot https://lab.llvm.org/buildbot/#/builders/33/builds/3150.

Thu, Mar 18, 4:17 PM · Restricted Project
kiranchandramohan accepted D98733: [Flang][OpenMP] Add more sema checks for ordered construct.

LGTM.

Thu, Mar 18, 2:47 PM · Restricted Project, Restricted Project
kiranchandramohan committed rGde155f4af2b5: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop (authored by DavidTruby).
[MLIR][OpenMP] Pretty printer and parser for omp.wsloop
Thu, Mar 18, 6:51 AM
kiranchandramohan closed D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.
Thu, Mar 18, 6:50 AM · Restricted Project
kiranchandramohan updated the diff for D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.

Addressed review comments.

Thu, Mar 18, 2:47 AM · Restricted Project

Wed, Mar 17

kiranchandramohan accepted D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`.
Wed, Mar 17, 12:27 PM · Restricted Project, Restricted Project

Tue, Mar 16

kiranchandramohan added a comment to D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`.

-fget-symbols-sources is not a debug option, it's intended for integrating with IDEs like vscode. So I think the original name is better. Unlike the "dump" options it actually is an action and not something that is intended to produce debug output on the way to doing something else.

Tue, Mar 16, 2:32 PM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D98733: [Flang][OpenMP] Add more sema checks for ordered construct.
Tue, Mar 16, 1:17 PM · Restricted Project, Restricted Project

Mon, Mar 15

kiranchandramohan accepted D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.

Thanks for this patch. Couple of nits.

Mon, Mar 15, 3:41 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Just a quick comment. I will review in detail later.

Mon, Mar 15, 8:36 AM · Restricted Project, Restricted Project, Restricted Project

Mar 13 2021

kiranchandramohan added inline comments to D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.
Mar 13 2021, 4:23 PM · Restricted Project
kiranchandramohan updated the diff for D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.

Address review comments.
Updated syntax to specify the type along with the index.
Using BNF for parsing function documentation
Minor fixes, using llvm::interleaveComma.

Mar 13 2021, 4:22 PM · Restricted Project
kiranchandramohan added a comment to D98580: [flang][OpenMP] Add support for getting parent context and clauses and modify the relevant sema checks to use the new functions..

@arnamoy10 can you submit this?

Mar 13 2021, 2:22 PM · Restricted Project
kiranchandramohan accepted D98580: [flang][OpenMP] Add support for getting parent context and clauses and modify the relevant sema checks to use the new functions..

LGTM. Approving quickly since it fixes failures. Might need to do a recce and check that usage is consistent.

Mar 13 2021, 8:31 AM · Restricted Project

Mar 11 2021

kiranchandramohan accepted D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

This patch is updated with a few more test cases with max/min etc in omp-reduction07.f90 and also TODO comments. Hope they are acceptable.

Thanks to @clementval and @kiranchandramohan for accepting this PR and for the review comments. Thanks to @praveen for the kind co operation.

Mar 11 2021, 2:34 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop: DavidTruby.
Mar 11 2021, 1:02 AM · Restricted Project
kiranchandramohan updated the diff for D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.

Added multi-block tests.

Mar 11 2021, 1:01 AM · Restricted Project

Mar 10 2021

kiranchandramohan retitled D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop from [MLIR][OpenMP][WIP] Pretty printer and parser for omp.wsloop to [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.
Mar 10 2021, 3:19 PM · Restricted Project
kiranchandramohan added reviewers for D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop: clementval, kiranktp, SouraVX.
Mar 10 2021, 3:11 PM · Restricted Project
kiranchandramohan added a comment to D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.

I find the linear(%data_var : memref<i32> -> %linear_var) a bit confusing, we are using an equivalent of linear(%linear_var = %data_var : memref<i32>) in SCF and GPU dialects, and generally the %within_region = %outside_region : type pattern applies even more operations. -> seems to be predominantly used for results, which makes it confusing for me here.

Mar 10 2021, 3:10 PM · Restricted Project
kiranchandramohan updated the diff for D92327: [MLIR][OpenMP] Pretty printer and parser for omp.wsloop.

Fixed failure in SCFToOpenMP.
Converted "->" to "=" for linear clause.

Mar 10 2021, 3:05 PM · Restricted Project
kiranchandramohan added a comment to D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel.

Ping @llitchev. Would you have time to take this forward?

Mar 10 2021, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Mar 10 2021, 8:34 AM · Restricted Project

Mar 9 2021

kiranchandramohan accepted D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.

LGTM. Please address all lint/clang-format errors. Please wait for @tskeith or @clementval to approve.

Mar 9 2021, 10:06 AM · Restricted Project

Mar 7 2021

kiranchandramohan accepted D96686: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for Threadprivate.

LGTM. Yes, using the symbol is the right way here.
Thanks @yhegde for separating this out into a new patch. Thanks also for you patience and all your work for semantic checks for OpenMP.

Mar 7 2021, 4:08 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

LGTM. Thanks for the patience.

Mar 7 2021, 4:01 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Mar 7 2021, 1:44 PM · Restricted Project

Mar 6 2021

kiranchandramohan updated subscribers of D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Mar 6 2021, 2:58 PM · Restricted Project

Mar 5 2021

kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

If popping the end_sections helps you move forward, I am fine with it. Please go ahead.

Mar 5 2021, 12:43 AM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2021

kiranchandramohan added a comment to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.

Thanks @arnamoy10 for this patch.

Mar 4 2021, 1:42 PM · Restricted Project

Mar 3 2021

kiranchandramohan added a comment to D97774: [flang] Detect circularly defined interfaces of procedures.

Thanks @PeteSteinfeld.

Mar 3 2021, 1:51 AM · Restricted Project, Restricted Project

Mar 2 2021

kiranchandramohan added a comment to D97774: [flang] Detect circularly defined interfaces of procedures.

I see a failure in the buildbot.
https://lab.llvm.org/buildbot/#/builders/33/builds/2845

Mar 2 2021, 2:04 PM · Restricted Project, Restricted Project

Mar 1 2021

kiranchandramohan added a comment to D97201: [flang] Detect circularly defined interfaces of procedures.

The aarch64 flang buildbots are failing since this commit.
https://lab.llvm.org/buildbot/#/builders/32/builds/3480
The x86 buildbot is passing. https://lab.llvm.org/buildbot/#/builders/132

Mar 1 2021, 12:17 AM · Restricted Project, Restricted Project

Feb 28 2021

kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan The test case flang/test/Semantics/resolve102.f90 is failing with the error messages possibly due to the commit

https://github.com/llvm/llvm-project/commit/07de0846a5055015b55dc2b8faa2143f9902e549#diff-bc82e30d81709b26f2c8030300784e95003f1b968e1ed7842fa717858e497336

actual at 13: Procedure 'p' is recursively defined. Procedures in the cycle: 'p2', 'sub', 'p'
expect at 13: Procedure 'p' is recursively defined. Procedures in the cycle: 'p2', 'p', 'sub'
actual at 25: Procedure 'p' is recursively defined. Procedures in the cycle: 'p2', 'sub', 'p'
expect at 25: Procedure 'p' is recursively defined. Procedures in the cycle: 'p2', 'p', 'sub'

Can I push this patch now or only after the above failed case is fixed ?

Feb 28 2021, 11:58 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

There are a few comments not marked as done. Are these not done or have been just not marked done?

Feb 28 2021, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

If you can add the autogen portion that will be great. It can be added either as part of this patch or a separate patch. But it need not be a blocker for this. I am approving this patch.

Feb 28 2021, 5:37 AM · Restricted Project, Restricted Project, Restricted Project

Feb 26 2021

kiranchandramohan accepted D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops..

Did you miss the fir-ops tests for the new ops?

Feb 26 2021, 3:42 PM · Restricted Project, Restricted Project
kiranchandramohan accepted D97502: [flang][fir] Upstream utility function valueHasFirAttribute().

LGTM. This will be tested in the subsequent usage.

Feb 26 2021, 2:15 PM · Restricted Project, Restricted Project

Feb 24 2021

kiranchandramohan added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 24 2021, 10:20 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan retitled D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic from [OpenMP IRBuilder] Add support for OpenMP do schedule dynamic to [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.
Feb 24 2021, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan retitled D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic from Add support for OpenMP do schedule dynamic to [OpenMP IRBuilder] Add support for OpenMP do schedule dynamic.
Feb 24 2021, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added reviewers for D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic: kiranktp, SouraVX, kiranchandramohan.
Feb 24 2021, 8:27 AM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2021

kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

A few more questions.

Feb 23 2021, 3:13 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Quick comments/questions before I have a final look.

Feb 23 2021, 9:47 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Can you mark all comments which you believe are handled as done?

Feb 23 2021, 9:43 AM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2021

kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

A few nits, comments and clarifications.

Feb 22 2021, 12:40 AM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2021

kiranchandramohan accepted D96912: [flang][fir][NFC] clang-tidy change. Add include..

I guess for small format/clang-tidy changes reviews are not required.

Feb 17 2021, 3:47 PM · Restricted Project, Restricted Project
kiranchandramohan accepted D96911: [flang][fir][NFC] clang-tidy change.

LGTM.

Feb 17 2021, 3:35 PM · Restricted Project

Feb 14 2021

kiranchandramohan added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 14 2021, 11:12 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

LGTM. I have a Nit comment.

Feb 14 2021, 9:18 AM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2021

kiranchandramohan added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 11 2021, 4:39 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

One question about blocks and a few nits.

Feb 11 2021, 5:56 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 11 2021, 1:02 AM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2021

kiranchandramohan requested changes to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

A few questions and change requests.

Feb 10 2021, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Thank you for the review comments @kiranchandramohan . Can I split this patch one with threadprivate and cycle , dowhile etc with another patch ?

Feb 10 2021, 1:03 AM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2021

kiranchandramohan accepted D96361: [flang][fir] Updates to internal name uniquer..

LGTM. Please address the clang-format comment before submission.

Feb 9 2021, 1:55 PM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 9 2021, 7:53 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.

Thanks @yhegde for the changes. I believe this threadprivate check needs some more design and work. I don' t think we can clear the threadprivate symbols in module subprograms because it will fail to catch the error in test1 below. I think the threadprivate information should be captured in a symbol so that it is available in places where the module is used like in test2.

Feb 9 2021, 7:52 AM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2021

kiranchandramohan accepted D96293: [flang][fir] Add OpaqueAttr..

LGTM. Please consider Mehdi's comments before submitting.

Feb 8 2021, 3:30 PM · Restricted Project, Restricted Project

Feb 5 2021

kiranchandramohan added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 5 2021, 1:54 PM · Restricted Project, Restricted Project, Restricted Project