Page MenuHomePhabricator

kiranchandramohan (Kiran Chandramohan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2017, 1:55 PM (152 w, 4 d)

Recent Activity

Today

kiranchandramohan updated subscribers of D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.

Thanks @kiranktp for working on this. Looks OK to me.

Tue, Apr 7, 10:20 AM · Restricted Project

Mar 5 2020

kiranchandramohan committed rG92a295eb3995: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR (authored by kiranchandramohan).
[MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR
Mar 5 2020, 4:24 AM
kiranchandramohan closed D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Mar 5 2020, 4:24 AM · Restricted Project
kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks for the reviews. Committing with changes suggested.

Mar 5 2020, 3:51 AM · Restricted Project

Feb 28 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Just wanted to check whether @rriddle has more comments on this patch.

Feb 28 2020, 3:45 AM · Restricted Project

Feb 21 2020

kiranchandramohan added a comment to D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing.

Will tests come in a later patch?

Feb 21 2020, 7:10 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Do @rriddle and @ftynse require further changes?

Feb 21 2020, 4:26 AM · Restricted Project

Feb 20 2020

kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Added LLVMFrontendOpenMP and MLIROpenMP to the dependency of MLIRLLVMIR and also linking these libraries along with MLIRLLVMIR. Removed from other clients.

Feb 20 2020, 1:44 PM · Restricted Project

Feb 19 2020

kiranchandramohan added inline comments to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Feb 19 2020, 11:01 AM · Restricted Project
kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

This revision includes the following changes,
-> Rebased.
-> Removed the enable-openmp flag.
-> Addressed review comments from @ftynse.

Feb 19 2020, 10:58 AM · Restricted Project

Feb 12 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks for your comments.

MLIROpenMP and LLVMFrontendOpenMP libraries looks like an additional dependency for MLIR users who wants LLVM lowering and doesn't want anything to do with the OpenMP! I think Toy example cmake file changes is one of the early symptoms.

One way to handle that would be to go back to the first version of this patch which implements translation by deriving from public LLVM::ModuleTranslation.

I think conversion patterns would be more appropriate. But, I think, that is dependent on the decision to emit LLVM IR instead of LLVM Dialect.

Feb 12 2020, 1:56 PM · Restricted Project
kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks for your comments.

Feb 12 2020, 10:15 AM · Restricted Project
kiranchandramohan accepted D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.

LGTM. You can wait for a day in case other reviewers have comments.

Feb 12 2020, 3:10 AM · Restricted Project, Restricted Project

Feb 11 2020

kiranchandramohan added inline comments to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.
Feb 11 2020, 3:44 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.

Looks OK to me.
Couple of comments inline.

Feb 11 2020, 3:26 PM · Restricted Project, Restricted Project

Feb 7 2020

kiranchandramohan added inline comments to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.
Feb 7 2020, 4:58 PM · Restricted Project, Restricted Project

Feb 6 2020

kiranchandramohan added inline comments to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.
Feb 6 2020, 8:24 AM · Restricted Project, Restricted Project

Feb 4 2020

kiranchandramohan committed rGa969e051a5d9: [OpenMP] Add Flush directive to OpenMPIRBuilder (authored by kiranchandramohan).
[OpenMP] Add Flush directive to OpenMPIRBuilder
Feb 4 2020, 3:00 PM
kiranchandramohan closed D70712: Adding Flush support in OpenMPIRBuilder.
Feb 4 2020, 3:00 PM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D70712: Adding Flush support in OpenMPIRBuilder.
Feb 4 2020, 3:39 AM · Restricted Project, Restricted Project

Feb 3 2020

kiranchandramohan added a comment to D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling.

Had a quick look today. Will spend some more time tomorrow.
Please see a few comments inline.

Feb 3 2020, 8:28 AM · Restricted Project, Restricted Project

Jan 28 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Thanks @ftynse for the comments. I will make a patch soon to address comments. The only question is regarding the necessity of the flag. Please see comment inline.

Jan 28 2020, 7:45 AM · Restricted Project

Jan 27 2020

kiranchandramohan added a comment to D72400: [MLIR] Add OpenMP dialect with barrier operation.

I don't remember that we ever fully resolved this(adding OpenMP Dialect). Can you make a ping on llvm.discourse.group to make sure?

Jan 27 2020, 4:07 AM · Restricted Project
kiranchandramohan added inline comments to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Jan 27 2020, 1:52 AM · Restricted Project
kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

The enable-openmp flag is now local to file mlir/lib/Target/LLVMIR/ModuleTranslation.cpp. Added a function to lazily create the OpenMPIR builder when an OpenMP dialect op is detected.

Jan 27 2020, 1:47 AM · Restricted Project

Jan 23 2020

kiranchandramohan added a comment to D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

I have taken @rriddle's suggestion and moved the translation into the LLVM translator. Also using unique pointer for the OpenMPIRBuilder. I believe this fixes the null pointer issue pointed out by @jdoerfert.

Jan 23 2020, 11:55 AM · Restricted Project
kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

In this patch the code for translation is added to the existing LLVM dialect translation to LLVM IR. A new flag enable-openmp is used to enable the OpenMP translation.

Jan 23 2020, 11:51 AM · Restricted Project

Jan 17 2020

kiranchandramohan updated the diff for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.

Made changes suggested by the clang-format bot.

Jan 17 2020, 4:08 PM · Restricted Project
kiranchandramohan added a reviewer for D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR: ftynse.
Jan 17 2020, 3:39 PM · Restricted Project
kiranchandramohan retitled D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR from Translation of OpenMP barrier construct to LLVM IR to [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Jan 17 2020, 3:39 PM · Restricted Project
kiranchandramohan created D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR.
Jan 17 2020, 3:39 PM · Restricted Project

Dec 10 2019

kiranchandramohan created D71267: [OpenMPIRBuilder] Add support for generating kmpc_for_static_fini.
Dec 10 2019, 6:29 AM · Restricted Project
kiranchandramohan committed rG965ed1e974e8: [AArch64] Fix issues with large arrays on stack (authored by kiranchandramohan).
[AArch64] Fix issues with large arrays on stack
Dec 10 2019, 3:54 AM
kiranchandramohan closed D70496: [AArch64] Fix issues with large arrays on stack.
Dec 10 2019, 3:54 AM · Restricted Project

Dec 5 2019

kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

Thanks @eli.friedman.
@fpetrogalli are you OK with the changes I made to your suggestions? Might need some handholding to land this patch.

Dec 5 2019, 4:41 AM · Restricted Project

Nov 29 2019

kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

In general, I also worry that i might have missed some checks. I was hoping to get some pointers on how to run some tests so that we can minimise this. At the same time, I also feel that this change should not cause regressions.

Nov 29 2019, 6:26 AM · Restricted Project
kiranchandramohan updated the diff for D70496: [AArch64] Fix issues with large arrays on stack.
Nov 29 2019, 6:14 AM · Restricted Project
kiranchandramohan retitled D70712: Adding Flush support in OpenMPIRBuilder from [WIP][NFC] Adding Flush support in OpenMPIRBuilder to Adding Flush support in OpenMPIRBuilder.
Nov 29 2019, 4:52 AM · Restricted Project, Restricted Project
kiranchandramohan updated the diff for D70712: Adding Flush support in OpenMPIRBuilder.

Addressed review comments.

  1. Adding a test
  2. Change emitFlush to CreateFlush in OpenMPIRBuilder.cpp
  3. Use updateLoc
  4. Fixed formatting
Nov 29 2019, 4:52 AM · Restricted Project, Restricted Project

Nov 28 2019

kiranchandramohan added inline comments to D69828: [OpenMP] Lower taskwait using OpenMP IR Builder.
Nov 28 2019, 4:27 PM · Restricted Project, Restricted Project

Nov 26 2019

kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

Apologies, will wait for the reviews.

Nov 26 2019, 2:48 PM · Restricted Project
kiranchandramohan updated the summary of D70712: Adding Flush support in OpenMPIRBuilder.
Nov 26 2019, 7:57 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D70496: [AArch64] Fix issues with large arrays on stack.

Does this patch need additional reviews or changes?

Nov 26 2019, 7:57 AM · Restricted Project
kiranchandramohan created D70712: Adding Flush support in OpenMPIRBuilder.
Nov 26 2019, 4:51 AM · Restricted Project, Restricted Project

Nov 25 2019

kiranchandramohan added inline comments to D70496: [AArch64] Fix issues with large arrays on stack.
Nov 25 2019, 4:23 AM · Restricted Project
kiranchandramohan updated the diff for D70496: [AArch64] Fix issues with large arrays on stack.

Addressed review comments by @fpetrogalli and @eli.friedman,

  1. Fixed formatting in llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
  2. Updated test to work with minimal attributes and removed prefixes for checks
Nov 25 2019, 4:16 AM · Restricted Project

Nov 22 2019

kiranchandramohan updated subscribers of D70496: [AArch64] Fix issues with large arrays on stack.

Thanks @fpetrogalli, @eli.friedman for the review.

Nov 22 2019, 7:54 AM · Restricted Project

Nov 20 2019

kiranchandramohan added reviewers for D70496: [AArch64] Fix issues with large arrays on stack: sdesmalen, efriedma, fhahn, aemerson.
Nov 20 2019, 9:28 AM · Restricted Project
kiranchandramohan created D70496: [AArch64] Fix issues with large arrays on stack.
Nov 20 2019, 7:57 AM · Restricted Project

Nov 19 2019

kiranchandramohan added a comment to D69922: [OpenMP] Use the OpenMP-IR-Builder.

Thanks @jdoerfert for working on this.

Nov 19 2019, 8:24 AM · Restricted Project, Restricted Project

Sep 18 2019

kiranchandramohan added a comment to D63607: [clang][driver] Add basic --driver-mode=flang support for fortran.

Some minor comments about Filetypes and file extensions. Can be ignored or considered for a separate commit.

Sep 18 2019, 6:30 AM · Restricted Project