Page MenuHomePhabricator

mgorny (Michał Górny)
Dev @ Moritz Systems

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (345 w, 1 d)

Recent Activity

Sun, Mar 26

mgorny accepted D146891: [Driver][NetBSD] Simplify NetBSD version handling.

WFM. Thanks!

Sun, Mar 26, 8:54 PM · Restricted Project, Restricted Project

Fri, Mar 24

mgorny added a comment to D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp.

Thank you. 16.x isn't affected.

Fri, Mar 24, 12:27 PM · Restricted Project, Restricted Project
mgorny committed rG3bff90e7e84a: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp (authored by mgorny).
[clang-tools-extra] Fix linking ClangdTests when using libclang-cpp
Fri, Mar 24, 12:26 PM · Restricted Project, Restricted Project
mgorny closed D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp.
Fri, Mar 24, 12:25 PM · Restricted Project, Restricted Project
mgorny added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

This commit broke building against libclang-cpp.so dylib. I've submitted a fix as D146427 but it haven't received any attention so far.

Fri, Mar 24, 10:14 AM · Restricted Project, Restricted Project, Restricted Project
mgorny added a reviewer for D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp: thesamesam.

Ping.

Fri, Mar 24, 10:13 AM · Restricted Project, Restricted Project

Mon, Mar 20

mgorny requested review of D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp.
Mon, Mar 20, 8:04 AM · Restricted Project, Restricted Project

Sat, Mar 18

mgorny added a comment to D146355: [compiler-rt] Allow finding LLVMConfig if CMAKE_FIND_ROOT_PATH_MODE_PACKAGE is set to ONLY.

Do you have a doc link or some precedent? Something to help us understand the implications of this.

Sat, Mar 18, 2:16 AM · Restricted Project

Wed, Mar 15

mgorny accepted D143419: lit: Fix formatting in README.rst.

LGTM. Thanks!

Wed, Mar 15, 4:10 AM · Restricted Project, Restricted Project

Mon, Mar 13

mgorny committed rG56464ba865b7: [lld] Use installed llvm_gtest in standalone builds (authored by mgorny).
[lld] Use installed llvm_gtest in standalone builds
Mon, Mar 13, 10:57 AM · Restricted Project
mgorny closed D145964: [lld] Use installed llvm_gtest in standalone builds.
Mon, Mar 13, 10:56 AM · Restricted Project, Restricted Project
mgorny requested review of D145964: [lld] Use installed llvm_gtest in standalone builds.
Mon, Mar 13, 10:25 AM · Restricted Project, Restricted Project
mgorny committed rGdde05b4b9132: [third-party] Respect LLVM_INSTALL_GTEST for llvm_gtest_main (authored by mgorny).
[third-party] Respect LLVM_INSTALL_GTEST for llvm_gtest_main
Mon, Mar 13, 9:12 AM · Restricted Project
mgorny closed D145946: [third-party] Respect LLVM_INSTALL_GTEST for llvm_gtest_main.
Mon, Mar 13, 9:12 AM · Restricted Project, Restricted Project
mgorny requested review of D145946: [third-party] Respect LLVM_INSTALL_GTEST for llvm_gtest_main.
Mon, Mar 13, 8:40 AM · Restricted Project, Restricted Project

Sun, Mar 12

mgorny added a comment to D137890: Add install targets for gtest.

First observation: third-party/unittest/UnitTestMain/CMakeLists.txt still has BUILDTREE_ONLY which makes it impossible to use this with LLVM_DISTRIBUTION_COMPONENTS. Could you adjust that as well?

Sun, Mar 12, 10:13 AM · Restricted Project, Restricted Project

Fri, Mar 10

mgorny accepted D137890: Add install targets for gtest.

I think it's good.

Fri, Mar 10, 11:15 AM · Restricted Project, Restricted Project

Feb 23 2023

mgorny requested changes to D143419: lit: Fix formatting in README.rst.
Feb 23 2023, 7:28 AM · Restricted Project, Restricted Project

Feb 4 2023

mgorny added a comment to D139752: cmake: Enable 64bit off_t on 32bit glibc systems.

I haven't been able to get Halide to configure successfully yet but I already spotted something suspicious. dependencies/llvm/CMakeLists.txt does:

Feb 4 2023, 9:17 AM · Restricted Project, Restricted Project

Jan 31 2023

mgorny added reviewers for D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected: MaskRay, thesamesam, tstellar.

Ok, this turned out to be surprisingly painless, at least within our packaging.

Jan 31 2023, 10:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 28 2023

mgorny added a comment to D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected.

While the general direction seems sound, I suspect this may be a real PITA given that for us:

Jan 28 2023, 11:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 24 2023

mgorny added a comment to D140315: [AMDGCN] Update search path for device libraries.

@scchan the test expects CLANG_INSTALL_LIBDIR_BASENAME to be lib. Maybe in the failed test it was not true.

Jan 24 2023, 7:35 AM · Restricted Project, Restricted Project
mgorny committed rG0f8b995b6362: [clang] Fix linking to LLVMTestingAnnotations in standalone build (authored by mgorny).
[clang] Fix linking to LLVMTestingAnnotations in standalone build
Jan 24 2023, 4:22 AM · Restricted Project, Restricted Project
mgorny closed D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build.
Jan 24 2023, 4:21 AM · Restricted Project, Restricted Project
mgorny added a comment to D140315: [AMDGCN] Update search path for device libraries.

I'm sorry for reporting it this late (clang's been broken for over two weeks, so we couldn't periodically test it) but this change is causing test regressions on Gentoo/amd64:

Jan 24 2023, 4:20 AM · Restricted Project, Restricted Project
mgorny added a comment to D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build.

Thanks for the superfast review! I'll push it later today.

Jan 24 2023, 3:49 AM · Restricted Project, Restricted Project
mgorny requested review of D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build.
Jan 24 2023, 3:40 AM · Restricted Project, Restricted Project

Jan 23 2023

mgorny added a comment to D141581: [build] Fix stand-alone builds of clang..

This is currently holding back further testing on our end which is concerning me a bit, especially as we approach the branch point. Could you revert this please if a fix isn't imminent? Thank you!

@thesamesam what do you mean with "revert"? Just by looking at this differential I cannot see that this patch has landed. Has it?

Jan 23 2023, 3:54 AM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

mgorny added a comment to D78025: Make sure z3 can be disabled from outside, even if detected on the system..

Are you sure about this? FWIU right now the default is to "use Z3 if available". If I read the patch right, it will be "default to requiring Z3, unless explicitly disabled". Not that I mind but I suppose it's a semantic change.

Jan 19 2023, 9:55 AM · Restricted Project, Restricted Project

Jan 16 2023

mgorny added a comment to rGac1ffd3caca1: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen..

Let me know if you think I should apply D141581

Jan 16 2023, 4:40 AM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2023

mgorny added a comment to rGac1ffd3caca1: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen..

Ping. Please either fix this or revert and put the new version back for review.

Jan 14 2023, 11:18 PM · Restricted Project, Restricted Project, Restricted Project
mgorny committed rGb1e92f8def98: [llvm] Don't require third-party components when cross-compiling (authored by chewi).
[llvm] Don't require third-party components when cross-compiling
Jan 14 2023, 9:13 AM · Restricted Project, Restricted Project
mgorny closed D141196: [cmake] Don't require third-party components when cross-compiling.
Jan 14 2023, 9:13 AM · Restricted Project, Restricted Project

Jan 13 2023

mgorny added a comment to rGac1ffd3caca1: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen..

Hi @mgorny - thank you for the heads up. Would this fix the issue? https://reviews.llvm.org/D141581

Jan 13 2023, 9:27 AM · Restricted Project, Restricted Project, Restricted Project
mgorny raised a concern with rGac1ffd3caca1: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen..

This version breaks standalone builds of clang:

Jan 13 2023, 8:29 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

mgorny accepted D141196: [cmake] Don't require third-party components when cross-compiling.

It looks good to me as-is.

Jan 12 2023, 11:17 PM · Restricted Project, Restricted Project
mgorny added a reviewer for D141196: [cmake] Don't require third-party components when cross-compiling: MaskRay.

I think it makes sense but I'd like to get @MaskRay's opinion as well.

Jan 12 2023, 1:10 PM · Restricted Project, Restricted Project

Jan 8 2023

mgorny added a comment to D141208: libc++: bring back the unsigned in the return type in wcstoull_l.

Our policy is to not accept patches where nobody is willing to provide a CI bot, which is the case here currently.

Jan 8 2023, 11:28 PM · Restricted Project, Restricted Project
mgorny added reviewers for D141248: [Clang] [Python] Fix tests when default config file contains -include: jbcoe, bkramer.

I'm wondering if we shouldn't just by setting CLANG_NO_DEFAULT_CONFIG=1 like in clang's test suite rather than tying to predict how different config files will affect these tests.

Jan 8 2023, 10:52 PM · Restricted Project, Restricted Project

Dec 26 2022

mgorny added a comment to D140671: [lldb] [utils] Fix linking lit-cpuid to LLVM dylib.

Thanks!

Dec 26 2022, 10:04 AM · Restricted Project, Restricted Project
mgorny committed rGdfc20708bcdf: [lldb] [utils] Fix linking lit-cpuid to LLVM dylib (authored by mgorny).
[lldb] [utils] Fix linking lit-cpuid to LLVM dylib
Dec 26 2022, 10:04 AM · Restricted Project
mgorny closed D140671: [lldb] [utils] Fix linking lit-cpuid to LLVM dylib.
Dec 26 2022, 10:03 AM · Restricted Project, Restricted Project
mgorny requested review of D140671: [lldb] [utils] Fix linking lit-cpuid to LLVM dylib.
Dec 26 2022, 5:34 AM · Restricted Project, Restricted Project
mgorny closed D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code.

I've pushed a fix in dab67c66932b9149842f7c8431e951f952125fc0, based on @jhuber6's fix from the other diff.

Dec 26 2022, 1:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mgorny committed rGdab67c66932b: [clang] [OpenMP] Test amdgcn_openmp_device_math_c.c test on 32-bit platforms (authored by mgorny).
[clang] [OpenMP] Test amdgcn_openmp_device_math_c.c test on 32-bit platforms
Dec 26 2022, 1:39 AM · Restricted Project, Restricted Project
mgorny closed D140155: [Clang][OpenMP] Allow host call to nohost function with host variant.

Thank you. I'm going to try if the same solution helps with D139723 too.

Dec 26 2022, 1:19 AM · Restricted Project, Restricted Project, Restricted Project

Dec 25 2022

mgorny reopened D140155: [Clang][OpenMP] Allow host call to nohost function with host variant.
Dec 25 2022, 5:45 AM · Restricted Project, Restricted Project, Restricted Project
mgorny added a comment to D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code.

Also, please link commits to diffs using Differential Revision: trailer in the future.

Dec 25 2022, 5:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mgorny reopened D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code.
Dec 25 2022, 5:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 21 2022

mgorny committed rGec11388b3342: [libc++] Rename __tuple to __tuple_dir to avoid file collision (authored by mgorny).
[libc++] Rename __tuple to __tuple_dir to avoid file collision
Dec 21 2022, 10:21 AM · Restricted Project, Restricted Project
mgorny closed D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.
Dec 21 2022, 10:21 AM · Restricted Project, Restricted Project
mgorny added inline comments to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.
Dec 21 2022, 8:07 AM · Restricted Project, Restricted Project
mgorny updated the diff for D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Use explicit mapping as requested.

Dec 21 2022, 8:07 AM · Restricted Project, Restricted Project
mgorny added inline comments to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.
Dec 21 2022, 7:10 AM · Restricted Project, Restricted Project

Dec 19 2022

mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

We also have the same problem for __string unless I am mistaken, @mgorny

Dec 19 2022, 9:00 AM · Restricted Project, Restricted Project
mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Let's use __tuple_dir for LLVM 16 and rename it back to __tuple in LLVM 17. We also have the same problem for __string unless I am mistaken, @mgorny
can you handle that in your patch?

Dec 19 2022, 8:56 AM · Restricted Project, Restricted Project

Dec 18 2022

mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Would __tuple_helpers or __tuple_utils be less ugly resp. obvious solutions to the challenge?

Dec 18 2022, 9:06 PM · Restricted Project, Restricted Project
mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Thinking about it more, probably the cleanest long term solution would be to simply use .h suffix for files but that obviously won't solve the existing upgrade problem.

Dec 18 2022, 12:24 PM · Restricted Project, Restricted Project
mgorny updated the diff for D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Rebased.

Dec 18 2022, 12:23 PM · Restricted Project, Restricted Project
mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

That question can be turned around; why should software authors need to rename their source files to work around deficiencies in package managers?

Dec 18 2022, 7:05 AM · Restricted Project, Restricted Project
mgorny updated the diff for D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Use __tuple_dir instead of the icky __tuple2.

Dec 18 2022, 6:56 AM · Restricted Project, Restricted Project

Dec 9 2022

mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Package managers track all installed files, and remove files that are no longer installed by the specific package version. However, the removal happens *after* installing the new version.

Dec 9 2022, 9:45 PM · Restricted Project, Restricted Project

Dec 8 2022

mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Gentle ping. Do you have any specific requests on how this could be improved? I'd love to see the problem fixed before the next weekend (that's when I do snapshots for Gentoo).

Dec 8 2022, 8:51 PM · Restricted Project, Restricted Project

Dec 5 2022

mgorny added a comment to D123394: [CodeGen] Late cleanup of redundant address/immediate definitions..

@MaskRay, I've reverted your M68k test fix since this change was reverted too, to get M68k tests to pass again.

Dec 5 2022, 7:49 AM · Restricted Project, Restricted Project
mgorny added a reverting change for rGf55880e830e1: [test] Fix CodeGen/M68k/pipeline.ll after D123394 MachineLateInstrsCleanupPass: rGe99edb92356b: Revert "[test] Fix CodeGen/M68k/pipeline.ll after D123394….
Dec 5 2022, 7:48 AM · Restricted Project, Restricted Project
mgorny committed rGe99edb92356b: Revert "[test] Fix CodeGen/M68k/pipeline.ll after D123394… (authored by mgorny).
Revert "[test] Fix CodeGen/M68k/pipeline.ll after D123394…
Dec 5 2022, 7:47 AM · Restricted Project, Restricted Project
mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Well, I'd prefer renaming them permanently but one release would be good enough for Gentoo. Alternatively, at least for private headers we could streamline this by using a distinct prefix/suffix for directories, e.g. __tuple for a file, and __tuple_dir for directory. This would probably be cleaner than temporarily appending 2.

Dec 5 2022, 6:27 AM · Restricted Project, Restricted Project

Dec 4 2022

mgorny accepted D139278: [AArch64] Use string comparison for ArchInfo equality.

Well, it fixes the problem for me as well. I don't know the code but FWICS you've added the original assumption, so I guess you know best.

Dec 4 2022, 10:13 PM · Restricted Project, Restricted Project
mgorny updated the diff for D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

Regenerate files.

Dec 4 2022, 11:10 AM · Restricted Project, Restricted Project
mgorny added a comment to D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.

I've regenerated files. However, I needed to modify the generator to strip the extra 2 from public header name. That's not the prettiest solution, I admit, so I'm open to better ideas.

Dec 4 2022, 11:10 AM · Restricted Project, Restricted Project
mgorny added a comment to D138792: [AArch64] Improve TargetParser API.

Hi, I bisected this change to lead to a couple of test failures when building with LLVM_LINK_LLVM_DYLIB. In the past, this had to do with global variable initialization order, but nothing immediately jumps to my eye in this patch. Is AARCH64_ARCH used to define global variables?

Dec 4 2022, 9:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 3 2022

mgorny requested review of D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision.
Dec 3 2022, 11:09 PM · Restricted Project, Restricted Project

Dec 2 2022

mgorny accepted D138255: [Driver] -p: change from unused warning to error for most targets.

LGTM

Dec 2 2022, 10:51 AM · Restricted Project, Restricted Project

Dec 1 2022

mgorny added a comment to D139107: [clangd] Allow to build Clangd without decision forest.

Thanks a lot for doing this!

Dec 1 2022, 6:29 AM · Restricted Project, Restricted Project
mgorny abandoned D138520: [clangd] Make decision forest model optional.

Closing in favor of D139107.

Dec 1 2022, 6:28 AM · Restricted Project, Restricted Project

Nov 30 2022

mgorny added a comment to D133081: [libc++] Granularize __tuple.

Replacing a file with a directory (and the other way arond) is problematic in general. E.g. if you attempt to ninja install it on top of the existing installation:

Nov 30 2022, 5:01 AM · Restricted Project, Restricted Project

Nov 28 2022

mgorny added inline comments to D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE.
Nov 28 2022, 9:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mgorny added inline comments to D138520: [clangd] Make decision forest model optional.
Nov 28 2022, 5:38 AM · Restricted Project, Restricted Project

Nov 26 2022

mgorny accepted D138750: [lldb][JITLoaderGDB] Resolve __jit_debug_register_code as eSymbolTypeCode.

Thanks. I can confirm that the two tests pass for me with this patch.

Nov 26 2022, 9:58 PM · Restricted Project, Restricted Project

Nov 24 2022

mgorny committed rGa6eb76f57c4a: [llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport (authored by mgorny).
[llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport
Nov 24 2022, 8:52 AM · Restricted Project, Restricted Project
mgorny closed D137035: [llvm] [cmake] Set EXCLUDE_FROM_ALL on gtest and TestingSupport.
Nov 24 2022, 8:52 AM · Restricted Project, Restricted Project

Nov 23 2022

mgorny committed rG02a2e18e60b9: [flang] Harmonize standalone gtest support with other projects (authored by mgorny).
[flang] Harmonize standalone gtest support with other projects
Nov 23 2022, 6:29 PM · Restricted Project, Restricted Project
mgorny closed D138573: [flang] Harmonize standalone gtest support with other projects.
Nov 23 2022, 6:29 PM · Restricted Project, Restricted Project
mgorny added a comment to D138573: [flang] Harmonize standalone gtest support with other projects.

Thanks!

Nov 23 2022, 6:29 PM · Restricted Project, Restricted Project
mgorny requested review of D138573: [flang] Harmonize standalone gtest support with other projects.
Nov 23 2022, 7:10 AM · Restricted Project, Restricted Project
mgorny committed rG58d1988b19a7: [flang] Fix unittests in standalone build for third-party move (authored by mgorny).
[flang] Fix unittests in standalone build for third-party move
Nov 23 2022, 6:13 AM · Restricted Project, Restricted Project
mgorny added a comment to D138562: [flang] Fix unittests in standalone build for third-party move.

Thanks!

Nov 23 2022, 6:13 AM · Restricted Project, Restricted Project
mgorny closed D138562: [flang] Fix unittests in standalone build for third-party move.
Nov 23 2022, 6:13 AM · Restricted Project, Restricted Project
mgorny requested review of D138562: [flang] Fix unittests in standalone build for third-party move.
Nov 23 2022, 4:22 AM · Restricted Project, Restricted Project

Nov 22 2022

mgorny committed rG5279e6a7d677: [cmake] Fix Findzstd.cmake to handle OpenBSD shared libraries (authored by mgorny).
[cmake] Fix Findzstd.cmake to handle OpenBSD shared libraries
Nov 22 2022, 9:51 PM · Restricted Project, Restricted Project
mgorny closed D138361: [cmake] Fix Findzstd.cmake to handle OpenBSD shared libraries.
Nov 22 2022, 9:51 PM · Restricted Project, Restricted Project
mgorny added a comment to D138361: [cmake] Fix Findzstd.cmake to handle OpenBSD shared libraries.

Thank you!

Nov 22 2022, 9:51 PM · Restricted Project, Restricted Project
mgorny added a comment to D138520: [clangd] Make decision forest model optional.

@thesamesam, could you test it on PPC32, please?

Nov 22 2022, 1:37 PM · Restricted Project, Restricted Project
mgorny requested review of D138520: [clangd] Make decision forest model optional.
Nov 22 2022, 1:37 PM · Restricted Project, Restricted Project
mgorny added inline comments to D137890: Add install targets for gtest.
Nov 22 2022, 9:08 AM · Restricted Project, Restricted Project
mgorny added a comment to D138361: [cmake] Fix Findzstd.cmake to handle OpenBSD shared libraries.

@phosek, very gentle ping ;-).

Nov 22 2022, 6:47 AM · Restricted Project, Restricted Project
mgorny added inline comments to D137890: Add install targets for gtest.
Nov 22 2022, 5:15 AM · Restricted Project, Restricted Project

Nov 21 2022

mgorny added a comment to D137890: Add install targets for gtest.

Plus there's the matter of LLVMTestingSupport library.

Nov 21 2022, 8:56 PM · Restricted Project, Restricted Project
mgorny added a comment to D137890: Add install targets for gtest.

I'll try to test this today. I suppose the main idea would be to enable LLVM_INSTALL_GTEST, then stop unpacking third-party directory when building other packages, correct? Perhaps it would make sense to update the checks like the one in clang while doing that:

Nov 21 2022, 8:55 PM · Restricted Project, Restricted Project
mgorny accepted D137451: [CMake] Use LLVM_RUNTIME_TRIPLE in runtimes.

LGTM

Nov 21 2022, 8:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project