Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (189 w, 1 d)

Recent Activity

Tue, Mar 17

mgorny committed rG06489eaa9216: [lldb] [Host/NetBSD] Rename Host.cpp to HostNetBSD.cpp (authored by mgorny).
[lldb] [Host/NetBSD] Rename Host.cpp to HostNetBSD.cpp
Tue, Mar 17, 3:44 AM

Sat, Mar 7

mgorny committed rG172d564c7381: [lldb] Un-XFAIL two tests on NetBSD (authored by mgorny).
[lldb] Un-XFAIL two tests on NetBSD
Sat, Mar 7, 9:45 AM

Feb 14 2020

mgorny added a comment to D72109: [cmake] Use relative cmake binary dir for processing pass plugins.

@mgorny can you try with https://reviews.llvm.org/D74602 applied?

Feb 14 2020, 6:51 AM · Restricted Project
mgorny added a comment to D72109: [cmake] Use relative cmake binary dir for processing pass plugins.

This broke standalone build of clang. It's trying to write into /include (as in, root directory) now! My guess is that LLVM_BINARY_DIR is undefined at this point of standalone build, later it might be defined to point to directory where LLVM was installed which also wouldn't be correct.

Feb 14 2020, 5:28 AM · Restricted Project
mgorny added a comment to D72501: [libcxx] Support Python 3.8 in the test suite.

@broadwaylamb, I've requested backporting this to 10.x: https://bugs.llvm.org/show_bug.cgi?id=44905. However, i wasn't able to find to find you on Bugzilla and CC you. Could you confirm whether it's fine to backport, please?

Feb 14 2020, 2:23 AM · Restricted Project

Feb 10 2020

mgorny added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

Gentoo, using the ebuilds. I think the most relevant is how libc++abi is configured:

Feb 10 2020, 10:37 AM · Restricted Project

Feb 7 2020

mgorny committed rG1ff411295f92: [lldb] Improve debugging 32-bit programs on NetBSD/amd64 (authored by mgorny).
[lldb] Improve debugging 32-bit programs on NetBSD/amd64
Feb 7 2020, 8:55 AM
mgorny closed D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64.
Feb 7 2020, 8:54 AM · Restricted Project

Feb 5 2020

mgorny committed rGdcab9736f01b: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb (authored by mgorny).
[lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb
Feb 5 2020, 9:37 AM
mgorny closed D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb.
Feb 5 2020, 9:37 AM · Restricted Project
mgorny committed rG5cc817be7501: [lldb] Introduce i386 support in NetBSD Process plugin (authored by mgorny).
[lldb] Introduce i386 support in NetBSD Process plugin
Feb 5 2020, 4:37 AM
mgorny closed D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 5 2020, 4:37 AM · Restricted Project

Feb 4 2020

mgorny added a parent revision for D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64: D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 4 2020, 9:35 AM · Restricted Project
mgorny added a child revision for D73802: [lldb] Introduce i386 support in NetBSD Process plugin: D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64.
Feb 4 2020, 9:35 AM · Restricted Project
mgorny created D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64.
Feb 4 2020, 9:35 AM · Restricted Project
mgorny updated the diff for D73802: [lldb] Introduce i386 support in NetBSD Process plugin.

Added tlsbase.

Feb 4 2020, 6:42 AM · Restricted Project
mgorny added a comment to D73816: [compiler-rt] implement sigaltstack interception.

This seems to have broken NetBSD:

Feb 4 2020, 5:56 AM · Restricted Project, Restricted Project

Feb 3 2020

mgorny committed rG98594a44aaa8: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches (authored by mgorny).
[lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches
Feb 3 2020, 8:51 PM
mgorny closed D73914: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches.
Feb 3 2020, 8:51 PM · Restricted Project
mgorny accepted D73850: [OpenMP][OMPT] fix reduction test for 32-bit x86.

I can confirm the tests pass both on i386 and amd64 for me, with this patch.

Feb 3 2020, 12:07 PM · Restricted Project
mgorny created D73914: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches.
Feb 3 2020, 11:39 AM · Restricted Project

Feb 2 2020

mgorny added a comment to D73850: [OpenMP][OMPT] fix reduction test for 32-bit x86.

While it fixes i386 tests, it seems to break amd64 now. Do you need me to paste the output or can you reproduce?

Feb 2 2020, 10:25 AM · Restricted Project

Feb 1 2020

mgorny added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 1 2020, 12:48 AM · Restricted Project

Jan 31 2020

mgorny accepted D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON.

Still LGTM.

Jan 31 2020, 10:34 PM · Restricted Project
mgorny added inline comments to D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Jan 31 2020, 10:25 PM · Restricted Project
mgorny created D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Jan 31 2020, 1:12 PM · Restricted Project
mgorny committed rG83a7a4aaad83: [lldb] [test] Skip 128-bit int tests on i386 (no __int128_t) (authored by mgorny).
[lldb] [test] Skip 128-bit int tests on i386 (no __int128_t)
Jan 31 2020, 1:03 PM
mgorny updated the diff for D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb.

Removed the aforementioned chunk.

Jan 31 2020, 7:21 AM · Restricted Project
mgorny added inline comments to D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb.
Jan 31 2020, 7:12 AM · Restricted Project
mgorny added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

Could you please show me how you're building libc++? I'm having trouble reproducing the issue.

Jan 31 2020, 6:54 AM · Restricted Project
mgorny updated the diff for D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb.

The question is, does this break any of the platform hacks? ;-)

Jan 31 2020, 3:35 AM · Restricted Project
mgorny added a comment to D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb.

I'm actually trying to make 10.0.0 a little less broken for Gentoo.

Jan 31 2020, 1:38 AM · Restricted Project
mgorny added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

That said, can we revert this from 10.x branch, please?

Jan 31 2020, 1:36 AM · Restricted Project
mgorny added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

This change broke stand-alone builds. They now try to use libc++abi from the wrong directory, instead of system instance:

Jan 31 2020, 1:36 AM · Restricted Project
mgorny created D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb.
Jan 31 2020, 12:46 AM · Restricted Project

Jan 30 2020

mgorny added a comment to D73384: [lldb/Lit] Change the lldbtest format to behave more like shell test..

I suppose you need to make the timeout branch entirely separate from the non-timeout branch, as the variable assignment does not take place then.

Jan 30 2020, 9:19 AM · Restricted Project

Jan 28 2020

mgorny committed rG6dea61215d2e: [lldb] [test] Restrict x86-64-write register test to x86-64 (authored by mgorny).
[lldb] [test] Restrict x86-64-write register test to x86-64
Jan 28 2020, 1:23 PM

Jan 23 2020

mgorny committed rG3c545e4b7318: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off (authored by mgorny).
[openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off
Jan 23 2020, 10:30 AM
mgorny closed D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off.
Jan 23 2020, 10:30 AM · Restricted Project
mgorny added a comment to D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off.

From my understanding of cmake scoping, this variable is visible because it's a cached option?

Jan 23 2020, 9:40 AM · Restricted Project
mgorny added a comment to D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off.

Yes, indeed the goal is to unbreak 10.x. I'd also agree to making bigger changes in 11.x separately.

Jan 23 2020, 12:58 AM · Restricted Project
mgorny added a comment to D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off.

I'm not sure LIBOMP_OMPT_SUPPORT is guaranteed to be there yet when defined in runtime/.

Jan 23 2020, 12:39 AM · Restricted Project

Jan 22 2020

mgorny created D73249: [openmp] Disable archer if LIBOMP_OMPT_SUPPORT is off.
Jan 22 2020, 10:02 PM · Restricted Project
mgorny added inline comments to D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON.
Jan 22 2020, 10:02 PM · Restricted Project
mgorny committed rG3215f7c7a81f: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT (authored by mgorny).
[compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT
Jan 22 2020, 8:12 AM
mgorny closed D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT.
Jan 22 2020, 8:12 AM · Restricted Project, Restricted Project

Jan 21 2020

mgorny accepted D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON.

Well, it looks correct to me. Not sure if it's the best approach but it can be refined in the future.

Jan 21 2020, 9:27 PM · Restricted Project

Jan 20 2020

mgorny added a comment to D72160: Optimize / partially inline basic_string copy constructor.

I'm afraid this breaks stuff. TableGen built against libc++ after this change misbehaves:

Jan 20 2020, 12:53 AM · Restricted Project

Jan 17 2020

mgorny accepted D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.

Besides the mentioned misindent, the CMake code looks correct. Could you test whether it works with standalone (out-of-LLVM) builds as well?

Jan 17 2020, 7:56 AM · Restricted Project, Restricted Project

Jan 14 2020

mgorny added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

This broke NetBSD buildbot:

Jan 14 2020, 6:07 AM · Restricted Project, Restricted Project

Jan 13 2020

mgorny committed rG1ab13f8cc3f7: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths (authored by mgorny).
[clang] [test] Fix riscv-toolchain-extra to be less picky about paths
Jan 13 2020, 7:09 PM
mgorny closed D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths.
Jan 13 2020, 7:09 PM · Restricted Project
mgorny added a comment to D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths.

Thanks!

Jan 13 2020, 7:09 PM · Restricted Project
mgorny created D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths.
Jan 13 2020, 1:20 AM · Restricted Project

Jan 12 2020

mgorny created D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT.
Jan 12 2020, 2:09 PM · Restricted Project, Restricted Project

Jan 11 2020

mgorny raised a concern with rG61bd19206f61: [libc++] Explicitly enumerate std::string external instantiations..

Also older versions of gcc. This broke bootstrap on NetBSD: http://lab.llvm.org:8014/builders/netbsd-amd64/builds/771/steps/ninja%20build%20local/logs/stdio

Jan 11 2020, 7:15 AM
mgorny abandoned D59249: [llvm] [Support] mallctl() is in malloc.h on NetBSD.
Jan 11 2020, 7:15 AM · Restricted Project

Jan 9 2020

mgorny added a comment to D72490: Fix cmake for zlib.

Is there a way to get the basename from ZLIB_LIBRARY by any chance? Not saying it's actually necessary, just wondering.

Jan 9 2020, 10:02 PM · Restricted Project

Jan 6 2020

mgorny committed rGbc763c42bbcf: [lldb] [Process/NetBSD] Remove unused orig_*ax use (authored by mgorny).
[lldb] [Process/NetBSD] Remove unused orig_*ax use
Jan 6 2020, 8:12 AM
mgorny closed D72195: [lldb] [Process/NetBSD] Remove unused orig_*ax use.
Jan 6 2020, 8:12 AM · Restricted Project

Jan 3 2020

mgorny created D72195: [lldb] [Process/NetBSD] Remove unused orig_*ax use.
Jan 3 2020, 8:39 PM · Restricted Project

Jan 2 2020

mgorny added inline comments to D72107: [lldb/CMake] Autodetect Python dependency.
Jan 2 2020, 11:03 PM · Restricted Project

Dec 26 2019

mgorny accepted D71700: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors.

LGTM, presuming you've tested it. If you need me to do a second test run, lemme know.

Dec 26 2019, 10:43 AM · Restricted Project, Restricted Project

Dec 20 2019

mgorny committed rGe73c662b9ea7: [compiler-rt] [test] Disable MPROTECT for XRay tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable MPROTECT for XRay tests on NetBSD
Dec 20 2019, 1:26 PM
mgorny committed rG190b9110c23c: [compiler-rt] [test] Disable MPROTECT on two builtin tests (authored by mgorny).
[compiler-rt] [test] Disable MPROTECT on two builtin tests
Dec 20 2019, 8:59 AM
mgorny closed D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests.
Dec 20 2019, 8:59 AM · Restricted Project, Restricted Project
mgorny committed rGe1882af9f670: [libc++] Update feature list for NetBSD (authored by mgorny).
[libc++] Update feature list for NetBSD
Dec 20 2019, 8:59 AM
mgorny closed D71511: [libc++] Update feature list for NetBSD.
Dec 20 2019, 8:59 AM · Restricted Project

Dec 19 2019

mgorny added inline comments to D71306: [RFC] Change how we deal with optional dependencies.
Dec 19 2019, 8:49 PM · Restricted Project
mgorny committed rG20345707b2c9: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test (authored by mgorny).
[compiler-rt] [test] Add missing %run to fread_fwrite MSAN test
Dec 19 2019, 11:34 AM
mgorny closed D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test.
Dec 19 2019, 11:33 AM · Restricted Project, Restricted Project
mgorny accepted D71306: [RFC] Change how we deal with optional dependencies.

Besides missing LZMA, looks good to me. However, I suspect you may want to wait for a second opinion ;-).

Dec 19 2019, 12:09 AM · Restricted Project

Dec 18 2019

mgorny committed rG4121399c1229: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP (authored by mgorny).
[clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP
Dec 18 2019, 1:41 PM
mgorny closed D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP.
Dec 18 2019, 1:41 PM · Restricted Project
mgorny created D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP.
Dec 18 2019, 1:22 PM · Restricted Project
mgorny added inline comments to D71306: [RFC] Change how we deal with optional dependencies.
Dec 18 2019, 1:03 PM · Restricted Project
mgorny added inline comments to D71306: [RFC] Change how we deal with optional dependencies.
Dec 18 2019, 12:14 PM · Restricted Project
mgorny requested changes to D71306: [RFC] Change how we deal with optional dependencies.
Dec 18 2019, 10:56 AM · Restricted Project
mgorny committed rGd3d1ca14ced3: [compiler-rt] [test] Disable ASLR on UBSAN+[AMT]SAN tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable ASLR on UBSAN+[AMT]SAN tests on NetBSD
Dec 18 2019, 8:23 AM
mgorny committed rG9102a59084fd: [compiler-rt] [test] Disable ASLR on LSAN+ASAN tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable ASLR on LSAN+ASAN tests on NetBSD
Dec 18 2019, 8:23 AM
mgorny committed rGd372576d8a3b: [compiler-rt] [test] Disable ASLR for fuzzer tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable ASLR for fuzzer tests on NetBSD
Dec 18 2019, 7:54 AM
mgorny committed rG6207b060ad80: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir (authored by mgorny).
[clang] [cmake] Fix gen_ast_dump_json_test.py binary dir
Dec 18 2019, 7:48 AM
mgorny closed D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir.
Dec 18 2019, 7:48 AM · Restricted Project

Dec 17 2019

mgorny created D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test.
Dec 17 2019, 12:54 PM · Restricted Project, Restricted Project
mgorny updated the diff for D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests.

Switch to using %run_nomprotect instead of extra %paxctl. This should be more consistent and should avoid potential issues with : on Windows.

Dec 17 2019, 11:36 AM · Restricted Project, Restricted Project
mgorny created D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir.
Dec 17 2019, 9:14 AM · Restricted Project
mgorny added a comment to D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully.

I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems.

Dec 17 2019, 8:53 AM · Restricted Project
mgorny created D71613: [cmake] Use 'llvm-config --components' to determine components.
Dec 17 2019, 8:53 AM · Restricted Project, Restricted Project

Dec 14 2019

mgorny raised a concern with rGd09e811cb4da: [gen_ast_dump_json_test.py] Copy to binary directory to omit --clang argument.
Dec 14 2019, 12:45 PM
mgorny created D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests.
Dec 14 2019, 8:10 AM · Restricted Project, Restricted Project
mgorny created D71511: [libc++] Update feature list for NetBSD.
Dec 14 2019, 5:26 AM · Restricted Project

Dec 13 2019

mgorny added inline comments to D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON.
Dec 13 2019, 1:19 PM · Restricted Project
mgorny added a comment to D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary.

I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.

This seems to be a very serious limitation. I have difficult to understand how such limitation could exist at all, but I think this should be straightforward to fix.

Dec 13 2019, 1:00 PM · Restricted Project
mgorny added inline comments to D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON.
Dec 13 2019, 12:51 PM · Restricted Project
mgorny added inline comments to D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON.
Dec 13 2019, 12:33 PM · Restricted Project

Dec 12 2019

mgorny added a comment to D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary.

I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.

Dec 12 2019, 11:10 PM · Restricted Project
mgorny committed rG4c6c1d0f4371: [clang] [test] Disable the test exhausting stack on NetBSD (authored by mgorny).
[clang] [test] Disable the test exhausting stack on NetBSD
Dec 12 2019, 3:56 PM
mgorny closed D71419: [clang] [test] Disable the test exhausting stack on NetBSD.
Dec 12 2019, 3:56 PM · Restricted Project
mgorny created D71419: [clang] [test] Disable the test exhausting stack on NetBSD.
Dec 12 2019, 6:27 AM · Restricted Project

Dec 10 2019

mgorny added a comment to D71306: [RFC] Change how we deal with optional dependencies.

I'm going to be blunt but if you dislike what LLVM does, improve that rather than proliferating inconsistencies between subprojects.

Dec 10 2019, 3:48 PM · Restricted Project