- User Since
- Aug 15 2016, 6:00 AM (27 w, 5 d)
Fri, Feb 24
If I read the git correctly, the change that forbid defining builtins was initially made in rL64639. @doug.gregor, any chance you could help us over here? Is clang supposed to unconditionally reject those definitions, and are we supposed to always work-around it in compiler-rt, or should we consider adding some additional switch to allow them in clang?
Le gentle ping.
Thu, Feb 23
Wed, Feb 22
Sun, Feb 19
Fri, Feb 17
LGTM modulo the test match split. But please wait for someone who has been longer here to confirm.
Thu, Feb 16
Thanks. The -L tests look good, -rpath is not perfect but I don't think you can improve it without additional changes to the Driver.
Following @labath's suggestion, I've changed my approach a little. Now I'm using PATH lookup only for CC/CXX, while for remaining tools I'm using either llvm_tools_dir or lldb_tools_dir appropriately.
Wed, Feb 15
I would like to point out that if you proactively reject all paths with spaces, you wouldn't be able to add additional tests that would test support for paths with spaces ;-). While I agree that we should avoid spaces whenever possible, I think it would be reasonable to add tests for paths with spaces wherever we expect them to be well-supported and want to avoid regressions.
I've opened http://bugs.llvm.org/show_bug.cgi?id=31964 to track this further. I don't really have time to look into it in more detail at the moment.
Mon, Feb 13
Le gentle ping.
Fri, Feb 10
Wed, Feb 8
A gentle ping.
A gentle ping.
Tue, Feb 7
Mon, Feb 6
Removed the i386 branch. Now the i486+ are used unconditionally.
Sun, Feb 5
CUDA: added the MaxAtomicPromoteWidth setting, and moved the CPU setting a little lower to ensure that it doesn't get called with null HostTarget.
Ok, this CUDA fix should be reasonable, i think. It simply assumes i586+ (i.e. all inline atomics enabled) for CUDA target builds. I seriously doubt it's technically possible that anyone will ever use CUDA on <i586 ;-).
Sat, Feb 4
Fri, Feb 3
Wed, Feb 1
Tue, Jan 31
Mon, Jan 30
Jan 26 2017
Here's a v2. It turns out that you also need -lunwind when using to link C programs with -static -rtlib=compiler-rt. I've also disabled the changes for Android targets.
Jan 25 2017
Well, it doesn't seem to break anything for me on Linux and it resembles the code below, so I guess it's good to go.
Technically the patch looks sane; however, I suggest you wait for some input from the others. As for Gentoo, I don't think we ever really cared for LLDB being versioned — only clang.
Jan 24 2017
I've filed https://llvm.org/bugs/show_bug.cgi?id=31745 to track it for 4.0.0 backport.
Builds fine for me.
Oh, and I thought that it was a feature since lld was linked statically anyway! ;-D
Jan 23 2017
Haha, I thought you meant you'll do it since you had the code already :-)
Jan 21 2017
Jan 20 2017
Fixed the missing change. Also created a local variable to avoid calling the sysconf three times.
Jan 19 2017
@compnerd, could you share your Windows knowledge? ;-)
Yeah, I think that'll work for me.
Just to be clear, the values also differ per -O0 vs -O2. I'm not sure if we can even reliably figure that out.
Updated to use page size logic on POSIX and Windows systems. I haven't tested the latter, though.
Jan 18 2017
Jan 17 2017
Still LGTM. I presume you have tested the final version ;-).