mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (118 w, 2 d)

Recent Activity

Today

mgorny accepted D54798: Move the llvm lit test dependencies to clang-tools-extra..

LGTM (assuming you've tested it).

Thu, Nov 22, 1:50 AM

Yesterday

mgorny accepted D54797: Revert r343473 "Move llvm util dependencies from clang-tools-extra to add_lit_target.".

Thank you.

Wed, Nov 21, 9:07 AM
mgorny added inline comments to D54798: Move the llvm lit test dependencies to clang-tools-extra..
Wed, Nov 21, 9:06 AM
mgorny added a comment to D52713: Move llvm util dependencies from clang-tools-extra to add_lit_target..

This particular build method uses system-wide installation of these tools.

Wed, Nov 21, 6:26 AM
mgorny added a comment to D52713: Move llvm util dependencies from clang-tools-extra to add_lit_target..

I would like to request reverting this. It's established standard within LLVM to explicitly specify the dependencies the particular test suite relies on.

Wed, Nov 21, 4:26 AM
mgorny committed rL347387: [nios2] Add missing Nios2CodeGen -> Nios2AsmPrinter linkage.
[nios2] Add missing Nios2CodeGen -> Nios2AsmPrinter linkage
Wed, Nov 21, 3:27 AM
mgorny closed D47810: [nios2] Add missing Nios2CodeGen -> Nios2AsmPrinter linkage.
Wed, Nov 21, 3:27 AM

Tue, Nov 20

mgorny committed rL347338: [cmake] Fix detecting terminfo library.
[cmake] Fix detecting terminfo library
Tue, Nov 20, 10:44 AM
mgorny committed rCRT347338: [cmake] Fix detecting terminfo library.
[cmake] Fix detecting terminfo library
Tue, Nov 20, 10:44 AM
mgorny closed D54641: [compiler-rt] [cmake] Fix detecting terminfo library.
Tue, Nov 20, 10:43 AM
mgorny committed rL347337: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
[unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled
Tue, Nov 20, 10:41 AM
mgorny closed D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Tue, Nov 20, 10:40 AM

Sun, Nov 18

mgorny updated the diff for D54641: [compiler-rt] [cmake] Fix detecting terminfo library.

Updated for check order change in master.

Sun, Nov 18, 4:35 AM
mgorny accepted D54650: Swap order of discovering of -ltinfo and -lterminfo.

LGTM. There's no terminfo on Linux (or majority of other systems, I suppose), so this shouldn't break anything. I've tested it on Linux, tests pass and there's no perceivable difference ;-).

Sun, Nov 18, 1:42 AM

Fri, Nov 16

mgorny added a comment to D54641: [compiler-rt] [cmake] Fix detecting terminfo library.

Well, sure but I think changing the order should be done separately from this. I'm fixing a bug resulting from people deciding to customize code instead of keeping it in sync; so I'd rather not combine it with intentionally mis-syncing the code.

Fri, Nov 16, 1:37 PM
mgorny created D54641: [compiler-rt] [cmake] Fix detecting terminfo library.
Fri, Nov 16, 11:32 AM

Sat, Nov 10

mgorny added a comment to D54120: [python] Support PathLike filenames and directories.

Merged. I will get back to you if something explodes ;-).

Sat, Nov 10, 3:45 AM
mgorny committed rC346586: [python] Support PathLike filenames and directories.
[python] Support PathLike filenames and directories
Sat, Nov 10, 3:44 AM
mgorny committed rL346586: [python] Support PathLike filenames and directories.
[python] Support PathLike filenames and directories
Sat, Nov 10, 3:44 AM
mgorny closed D54120: [python] Support PathLike filenames and directories.
Sat, Nov 10, 3:44 AM
mgorny accepted D54120: [python] Support PathLike filenames and directories.

LGTM, thanks!

Sat, Nov 10, 2:51 AM
mgorny requested changes to D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang.

Could you please rebase? I'm pretty sure this breaks our use but I can't test since it no longer applies cleanly.

Sat, Nov 10, 2:31 AM
mgorny accepted D32578: CMake: Set LLVM_MAIN_INCLUDE_DIR to LLVM_INCLUDE_DIR.

LGTM.

Sat, Nov 10, 2:25 AM
mgorny accepted D32577: CMake: Replace open-coded find_package.

LGTM

Sat, Nov 10, 1:32 AM
mgorny requested changes to D54120: [python] Support PathLike filenames and directories.

Also please remember to submit patches with -U9999, so that Phab has full context.

Sat, Nov 10, 12:19 AM
mgorny updated subscribers of D32578: CMake: Set LLVM_MAIN_INCLUDE_DIR to LLVM_INCLUDE_DIR.
Sat, Nov 10, 12:11 AM

Tue, Nov 6

mgorny added a comment to D54136: Prioritize the constructor call of __local_xray_dyninit().

This isn't normally used on Linux since .preinit_array is used. If I force it, I get the following warning (from gcc):

Tue, Nov 6, 12:24 AM · Restricted Project

Sat, Nov 3

mgorny added inline comments to D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Sat, Nov 3, 3:11 PM
mgorny added inline comments to D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Sat, Nov 3, 3:01 PM
mgorny updated the diff for D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.

Implemented all comments + moved CHECK_UNSUPPORTED below faster R+W checks.

Sat, Nov 3, 2:43 PM
mgorny created D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Sat, Nov 3, 2:25 PM

Tue, Oct 30

mgorny added a reviewer for D47810: [nios2] Add missing Nios2CodeGen -> Nios2AsmPrinter linkage: dblaikie.

Piiing.

Tue, Oct 30, 1:33 PM
mgorny added a comment to D49486: [cfe][CMake] Export the clang resource directory.

@philip.pfaffe, did you establish whether this is still necessary or can be abandoned?

Tue, Oct 30, 4:31 AM
mgorny accepted D53125: Detect Clear Linux and apply Clear's default linker options.

LGTM, presuming the tests pass for you.

Tue, Oct 30, 4:30 AM
mgorny updated the diff for D47819: [test] Support using libtirpc on Linux.

Rebased.

Tue, Oct 30, 2:08 AM · Restricted Project
mgorny updated the diff for D47817: [sanitizer_common] Fix using libtirpc on Linux.

Rebased.

Tue, Oct 30, 2:08 AM · Restricted Project

Oct 18 2018

mgorny committed rLLDB344746: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView.
[SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView
Oct 18 2018, 8:41 AM
mgorny committed rL344746: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView.
[SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView
Oct 18 2018, 8:41 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Oct 18 2018, 8:41 AM
mgorny created D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView.
Oct 18 2018, 8:03 AM

Oct 16 2018

mgorny added a comment to D53326: [python] [tests] Disable on known-broken arches.

Thanks for the review. I'm going to be away most of the day today, so if it breaks something (worse), feel free to revert.

Oct 16 2018, 8:15 PM
mgorny committed rL344666: [python] [tests] Disable on known-broken arches.
[python] [tests] Disable on known-broken arches
Oct 16 2018, 8:07 PM
mgorny committed rC344666: [python] [tests] Disable on known-broken arches.
[python] [tests] Disable on known-broken arches
Oct 16 2018, 8:07 PM
mgorny closed D53326: [python] [tests] Disable on known-broken arches.
Oct 16 2018, 8:07 PM
mgorny closed D53326: [python] [tests] Disable on known-broken arches.
Oct 16 2018, 8:07 PM
mgorny added a comment to D52840: Include Python binding tests in CMake rules.

Thanks for all your reports. I have filed https://reviews.llvm.org/D53326 to disable the tests on all three known-broken arches.

Oct 16 2018, 8:55 AM
mgorny created D53326: [python] [tests] Disable on known-broken arches.
Oct 16 2018, 8:55 AM

Oct 15 2018

mgorny added a comment to D52840: Include Python binding tests in CMake rules.

The first one seems to indicate that your libclang.so is broken in release mode (optimization error?). The second one is correct (some of the tests test for errors, and apparently don't silence the messages).

Oct 15 2018, 10:36 AM

Oct 14 2018

mgorny resigned from D53127: Fix missing defines in libc++abi when compiled against libgcc's arm unwind (follow-up of D42242).
Oct 14 2018, 10:32 AM
mgorny added a comment to D53127: Fix missing defines in libc++abi when compiled against libgcc's arm unwind (follow-up of D42242).

I think there's some confusion here. This has nothing to do with libsupc++ but FWIU with gcc's libunwind header which is apparently used when compiling it with gcc.

Oct 14 2018, 10:32 AM

Oct 13 2018

mgorny accepted D53239: [python] [tests] Disable python binding tests when building with LLVM_USE_SANITIZER=Address.

WFM. Thanks for analyzing the problem.

Oct 13 2018, 12:04 AM

Oct 12 2018

mgorny added inline comments to D53212: inhereit LLVM_ENABLE_LIBXML2.
Oct 12 2018, 1:11 PM
mgorny committed rL344411: [python] [tests] Re-add once again, this time without Windows.
[python] [tests] Re-add once again, this time without Windows
Oct 12 2018, 1:06 PM
mgorny committed rC344411: [python] [tests] Re-add once again, this time without Windows.
[python] [tests] Re-add once again, this time without Windows
Oct 12 2018, 1:05 PM
mgorny added a comment to rL344365: [tests] Readd Python binding tests to check-all.

Do you have any clue how to solve this? Or should I just if() the tests out of Windows?

Oct 12 2018, 12:57 PM
mgorny committed rC344365: [tests] Readd Python binding tests to check-all.
[tests] Readd Python binding tests to check-all
Oct 12 2018, 9:58 AM
mgorny committed rC344364: [python] [tests] Remove cdb lookup failure test.
[python] [tests] Remove cdb lookup failure test
Oct 12 2018, 9:57 AM
mgorny committed rL344365: [tests] Readd Python binding tests to check-all.
[tests] Readd Python binding tests to check-all
Oct 12 2018, 9:57 AM
mgorny committed rL344364: [python] [tests] Remove cdb lookup failure test.
[python] [tests] Remove cdb lookup failure test
Oct 12 2018, 9:57 AM
mgorny closed D53202: [python] [tests] Remove cdb lookup failure test.
Oct 12 2018, 9:57 AM
mgorny added a comment to D53202: [python] [tests] Remove cdb lookup failure test.

Thanks for the review!

Oct 12 2018, 9:55 AM
mgorny created D53202: [python] [tests] Remove cdb lookup failure test.
Oct 12 2018, 9:29 AM

Oct 11 2018

mgorny added a comment to D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files.

Unless my bisect is mistaken, this broke Clang Python binding test:
https://github.com/llvm-mirror/clang/blob/master/bindings/python/tests/cindex/test_cdb.py#L34

Oct 11 2018, 11:38 PM
mgorny committed rC344288: [python] [tests] Fix calling tests on Windows.
[python] [tests] Fix calling tests on Windows
Oct 11 2018, 1:28 PM
mgorny committed rL344288: [python] [tests] Fix calling tests on Windows.
[python] [tests] Fix calling tests on Windows
Oct 11 2018, 1:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Oct 11 2018, 1:28 PM
mgorny retitled D53151: [python] [tests] Fix calling tests on Windows (hopefully) from [python] [tests] Fix calling pytest on Windows (hopefully) to [python] [tests] Fix calling tests on Windows (hopefully).
Oct 11 2018, 11:00 AM
mgorny added reviewers for D53151: [python] [tests] Fix calling tests on Windows (hopefully): steveire, aaron.ballman.
Oct 11 2018, 10:59 AM
mgorny created D53151: [python] [tests] Fix calling tests on Windows (hopefully).
Oct 11 2018, 10:59 AM
mgorny committed rL344263: [python] [tests] Retab CMakeLists.txt for consistency (NFC).
[python] [tests] Retab CMakeLists.txt for consistency (NFC)
Oct 11 2018, 10:47 AM
mgorny committed rC344263: [python] [tests] Retab CMakeLists.txt for consistency (NFC).
[python] [tests] Retab CMakeLists.txt for consistency (NFC)
Oct 11 2018, 10:47 AM
mgorny committed rC344260: [tests] Remove Python tests from check-all due to breakage.
[tests] Remove Python tests from check-all due to breakage
Oct 11 2018, 10:27 AM
mgorny committed rL344260: [tests] Remove Python tests from check-all due to breakage.
[tests] Remove Python tests from check-all due to breakage
Oct 11 2018, 10:27 AM
mgorny committed rL344258: [tests] Include Python binding tests in CMake rules.
[tests] Include Python binding tests in CMake rules
Oct 11 2018, 9:34 AM
mgorny committed rC344258: [tests] Include Python binding tests in CMake rules.
[tests] Include Python binding tests in CMake rules
Oct 11 2018, 9:34 AM
mgorny closed D52840: Include Python binding tests in CMake rules.
Oct 11 2018, 9:34 AM
mgorny requested review of D52840: Include Python binding tests in CMake rules.

Please review the new version, addressing the issue caught by buildbots.

Oct 11 2018, 8:28 AM
mgorny added a reviewer for D52840: Include Python binding tests in CMake rules: aaron.ballman.
Oct 11 2018, 8:27 AM
mgorny reopened D52840: Include Python binding tests in CMake rules.
Oct 11 2018, 8:26 AM
mgorny updated the diff for D52840: Include Python binding tests in CMake rules.

v3: one more correction for stand-alone builds.

Oct 11 2018, 8:26 AM
mgorny updated the diff for D52840: Include Python binding tests in CMake rules.

v2: fixed appending to check-all to make it compatible both with in-tree and standalone builds

Oct 11 2018, 8:23 AM
mgorny committed rC344241: [tests] Include Python binding tests in CMake rules.
[tests] Include Python binding tests in CMake rules
Oct 11 2018, 5:00 AM
mgorny committed rC344240: [python] [tests] Support overriding library path via environment.
[python] [tests] Support overriding library path via environment
Oct 11 2018, 5:00 AM
mgorny committed rL344240: [python] [tests] Support overriding library path via environment.
[python] [tests] Support overriding library path via environment
Oct 11 2018, 5:00 AM
mgorny committed rL344241: [tests] Include Python binding tests in CMake rules.
[tests] Include Python binding tests in CMake rules
Oct 11 2018, 5:00 AM
mgorny closed D52840: Include Python binding tests in CMake rules.
Oct 11 2018, 5:00 AM
mgorny closed D52806: [python] [tests] Support overriding library path via environment.
Oct 11 2018, 5:00 AM
mgorny retitled D52806: [python] [tests] Support overriding library path via environment from [python] Support overriding library path via environment to [python] [tests] Support overriding library path via environment.
Oct 11 2018, 2:23 AM
mgorny added inline comments to D53125: Detect Clear Linux and apply Clear's default linker options.
Oct 11 2018, 1:28 AM
mgorny requested changes to D53127: Fix missing defines in libc++abi when compiled against libgcc's arm unwind (follow-up of D42242).

To be honest, I'm not really convinced this is the best way to do it. I don't really know why GCC's libunwind doesn't declare those constants, and I have no clue what the implications of forcing them on top of possibly-gcc libunwind might be.

Oct 11 2018, 1:22 AM

Oct 10 2018

mgorny added a comment to D42242: Make libc++abi work with gcc's ARM unwind library.

@bebuch, I agree with @mclow.lists here that the new errors are completely unrelated to the problem solved by this patch, and the fix to it belongs in a separate changeset. Can we get the original problem fixed first then?

Oct 10 2018, 3:11 AM
mgorny added a reviewer for D52806: [python] [tests] Support overriding library path via environment: steveire.

Gentle ping.

Oct 10 2018, 3:08 AM

Oct 7 2018

mgorny added a comment to D42242: Make libc++abi work with gcc's ARM unwind library.

@mclow.lists , ping. Any chance to get a proper version upstream? I'd rather not pull patches from Fedora when we can have something official.

Oct 7 2018, 10:07 AM

Oct 3 2018

mgorny added a comment to D52840: Include Python binding tests in CMake rules.

Yes, I've tested it on Linux. I'll commit it once the dep is approved, and hopefully build bots will answer if they work across all platforms.

Oct 3 2018, 8:09 PM
mgorny added reviewers for D52840: Include Python binding tests in CMake rules: bkramer, ilya-biryukov.
Oct 3 2018, 11:45 AM
mgorny added a dependent revision for D52806: [python] [tests] Support overriding library path via environment: D52840: Include Python binding tests in CMake rules.
Oct 3 2018, 11:44 AM
mgorny added a dependency for D52840: Include Python binding tests in CMake rules: D52806: [python] [tests] Support overriding library path via environment.
Oct 3 2018, 11:44 AM
mgorny created D52840: Include Python binding tests in CMake rules.
Oct 3 2018, 11:44 AM
mgorny updated the diff for D52806: [python] [tests] Support overriding library path via environment.

To avoid consumers of the bindings, I've changed the patch to set the path only through tests. As a result, the binding API is unchanged.

Oct 3 2018, 1:23 AM

Oct 2 2018

mgorny added a comment to D52762: [CMake] Use just basename when copying C++ ABI headers.

Thanks. I can confirm that it fixes installing libsupc++ headers for us on the main ABI. Apparently the headers in 32-bit multilib build aren't installed but I see the same issue with libcxx-6.0.1, so it's not a regression (and probably a bug on our end).

Oct 2 2018, 3:39 PM