Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (214 w, 3 d)

Recent Activity

Yesterday

mgorny added inline comments to D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>.
Wed, Sep 23, 3:31 AM · Restricted Project, Restricted Project

Tue, Sep 22

mgorny added a comment to D85278: [lld] Support building shared libLLD.so.

Ping.

Tue, Sep 22, 2:48 PM · lld
mgorny added a comment to D85464: [MLIR] [CMake] Support building MLIR standalone.

Ping.

Tue, Sep 22, 2:48 PM · Restricted Project

Fri, Sep 4

mgorny added inline comments to D87143: Check whether Gentoo-specific configuration directory exists.
Fri, Sep 4, 10:11 AM · Restricted Project

Aug 13 2020

mgorny added a comment to D85942: [lldb] Remove Python 2 fallback and make Python 3 the only supported configuration..

I wonder if we can remove the helper variables such as PYTHON_LIBRARIES now.

Aug 13 2020, 10:45 PM · Restricted Project

Aug 11 2020

mgorny added a comment to D74051: Move update_cc_test_checks.py tests to clang.

Nevermind, I figured out good enough workaround.

What was the workaround?

Aug 11 2020, 7:28 PM · Restricted Project, Restricted Project

Aug 9 2020

mgorny updated the diff for D85464: [MLIR] [CMake] Support building MLIR standalone.

Moved comment back to the top.

Aug 9 2020, 7:30 PM · Restricted Project
mgorny added inline comments to D85464: [MLIR] [CMake] Support building MLIR standalone.
Aug 9 2020, 7:30 PM · Restricted Project
mgorny committed rGc8b629a3a585: [Polly] Reuse LLVM's build rules for gtest/gmock (authored by mgorny).
[Polly] Reuse LLVM's build rules for gtest/gmock
Aug 9 2020, 3:54 AM
mgorny closed D85280: [Polly] Reuse LLVM's build rules for gtest/gmock.
Aug 9 2020, 3:54 AM · Restricted Project

Aug 8 2020

mgorny added a comment to D85299: [llvm] Support autoloading vendor-defined plugins.

I have some difficulties to understand the exact scenario: if one knows at compile-time that polly is needed, why no just build it as a linked-in plugin, as suggested by @Meinersbur?

Aug 8 2020, 10:29 PM · Restricted Project

Aug 7 2020

mgorny added a comment to D85299: [llvm] Support autoloading vendor-defined plugins.

If it is passes that (like Polly) using the in-tree static plugin mechanism, I recommend using the LLVM_<plugin>_LINK_INTO_TOOLS=ON flag.

Aug 7 2020, 10:52 PM · Restricted Project
mgorny added a comment to D85299: [llvm] Support autoloading vendor-defined plugins.

I don't really know about the two plugin mechanisms. To be honest, I haven't been able to get Polly to work yet — however, one of our users has done some testing for me, and IIRC the 'pass plugin' mechanism didn't work for some reason.

Aug 7 2020, 7:54 AM · Restricted Project

Aug 6 2020

mgorny committed rG96b02808afa7: [Polly] Support linking ScopPassManager against LLVM dylib (authored by mgorny).
[Polly] Support linking ScopPassManager against LLVM dylib
Aug 6 2020, 9:47 PM
mgorny closed D85281: [Polly] Support linking ScopPassManager against LLVM dylib.
Aug 6 2020, 9:47 PM · Restricted Project
mgorny added a comment to D85281: [Polly] Support linking ScopPassManager against LLVM dylib.

Thanks!

Aug 6 2020, 9:46 PM · Restricted Project
mgorny added inline comments to D85464: [MLIR] [CMake] Support building MLIR standalone.
Aug 6 2020, 1:24 PM · Restricted Project
mgorny requested review of D85464: [MLIR] [CMake] Support building MLIR standalone.
Aug 6 2020, 12:04 PM · Restricted Project

Aug 5 2020

mgorny added inline comments to D85281: [Polly] Support linking ScopPassManager against LLVM dylib.
Aug 5 2020, 6:51 PM · Restricted Project
mgorny updated the diff for D85281: [Polly] Support linking ScopPassManager against LLVM dylib.

Do not add dylib explicitly.

Aug 5 2020, 6:51 PM · Restricted Project
mgorny added a comment to D85281: [Polly] Support linking ScopPassManager against LLVM dylib.

Which configurations have you tested this with?

Aug 5 2020, 10:23 AM · Restricted Project
mgorny added inline comments to D85281: [Polly] Support linking ScopPassManager against LLVM dylib.
Aug 5 2020, 8:37 AM · Restricted Project
mgorny updated the diff for D85281: [Polly] Support linking ScopPassManager against LLVM dylib.

Updated to use LLVM_LINK_LLVM_DYLIB.

Aug 5 2020, 8:37 AM · Restricted Project
mgorny requested review of D85299: [llvm] Support autoloading vendor-defined plugins.
Aug 5 2020, 6:30 AM · Restricted Project
mgorny requested review of D85281: [Polly] Support linking ScopPassManager against LLVM dylib.
Aug 5 2020, 1:25 AM · Restricted Project
mgorny requested review of D85280: [Polly] Reuse LLVM's build rules for gtest/gmock.
Aug 5 2020, 1:18 AM · Restricted Project
mgorny requested review of D85278: [lld] Support building shared libLLD.so.
Aug 5 2020, 12:08 AM · lld

Aug 4 2020

mgorny accepted D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/.

I suppose this makes sense. Testing it on some more systems might be good but I guess buildbot will take care of that.

Aug 4 2020, 10:32 PM · Restricted Project

Aug 1 2020

mgorny committed rG21c165de2a1b: [CMake] Pass bugreport URL to standalone clang build (authored by mgorny).
[CMake] Pass bugreport URL to standalone clang build
Aug 1 2020, 11:33 PM
mgorny closed D84987: [CMake] Pass bugreport URL to standalone clang build.
Aug 1 2020, 11:33 PM · Restricted Project, Restricted Project
mgorny added a comment to D84987: [CMake] Pass bugreport URL to standalone clang build.

Thanks!

Aug 1 2020, 11:32 PM · Restricted Project, Restricted Project
mgorny added a comment to D84987: [CMake] Pass bugreport URL to standalone clang build.

Is RelA an actual result of install target, or just the build tree? I think it needs to be the former.

Aug 1 2020, 2:53 PM · Restricted Project, Restricted Project

Jul 30 2020

mgorny added a comment to D84987: [CMake] Pass bugreport URL to standalone clang build.

I am not familiar with the standalone clang build. Can you share a command?

Jul 30 2020, 10:49 PM · Restricted Project, Restricted Project
mgorny requested review of D84987: [CMake] Pass bugreport URL to standalone clang build.
Jul 30 2020, 3:19 PM · Restricted Project, Restricted Project
mgorny accepted D84929: [analyzer] Fix out-of-tree only clang build by not relaying on private header.

Seems to work fine for me.

Jul 30 2020, 2:11 PM · Restricted Project, Restricted Project

Jul 29 2020

mgorny added a comment to D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor.

This commit breaks standalone clang builds.

Jul 29 2020, 4:04 AM · Restricted Project

Jul 28 2020

mgorny accepted D84823: [CMake] find python should before include cmake-ix.

I suppose this makes sense and shouldn't break anything.

Jul 28 2020, 10:06 PM · Restricted Project

Jul 24 2020

mgorny resigned from D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

I'll remove my earlier protest but let's give others a chance to review.

Jul 24 2020, 9:47 AM · Restricted Project

Jul 22 2020

mgorny added a comment to D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

Did you forget to include a patch that uses LIBPFM_HAS_FIELD_CYCLES?

Jul 22 2020, 10:41 PM · Restricted Project

Jul 20 2020

mgorny updated the diff for D76665: [asan] Stop instrumenting user-defined ELF sections.

Here's a version with the extra test.

Jul 20 2020, 9:25 AM · Restricted Project, Restricted Project

Jul 17 2020

mgorny requested changes to D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

You shouldn't be checking the running kernel but the version of the kernel headers. Think of build hosts building LLVM for an entirely different system altogether.

Jul 17 2020, 7:36 PM · Restricted Project

Jul 7 2020

mgorny added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.
In D76665#2138050, @kcc wrote:

can we instead slap an attribute on these special variables?

Jul 7 2020, 11:24 PM · Restricted Project, Restricted Project
mgorny committed rG446e3df25483: [llvm] [docs] Do not require recommonmark for manpage build (authored by mgorny).
[llvm] [docs] Do not require recommonmark for manpage build
Jul 7 2020, 11:59 AM
mgorny closed D83161: [llvm] [docs] Do not require recommonmark for manpage build.
Jul 7 2020, 11:59 AM · Restricted Project

Jul 4 2020

mgorny added a comment to D83161: [llvm] [docs] Do not require recommonmark for manpage build.

(though personally I'd prefer just converting these three docs into .rst and having a single markup everywhere, without extra dependencies)

Jul 4 2020, 10:45 AM · Restricted Project
mgorny created D83161: [llvm] [docs] Do not require recommonmark for manpage build.
Jul 4 2020, 10:45 AM · Restricted Project

Jun 25 2020

mgorny added a comment to D82554: Update config.guess to more recent version.

See D55445. Long story short, this isn't gonna happen because of license change.

Jun 25 2020, 11:54 AM · Restricted Project

Jun 19 2020

mgorny added a comment to D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.

Ping. The current state is that c-index-test crashes for us, and I'd like to see it fixed for 10.0.1. I have a patch of my own but it doesn't handle all that _static magic, so I guess this one's better.

Jun 19 2020, 8:37 AM · Restricted Project
mgorny added a comment to D81385: Fix libdl linking for libclang in standalone mode.

Ping. It'd be nice to have this fixed.

Jun 19 2020, 6:59 AM · Restricted Project

Jun 17 2020

mgorny added a comment to D81326: lld: improve the `-arch` handling for MachO.

Thanks for the fix.

Jun 17 2020, 11:25 PM · Restricted Project, lld
mgorny added a comment to D81326: lld: improve the `-arch` handling for MachO.

This change broke standalone builds of LLD:

Jun 17 2020, 2:01 PM · Restricted Project, lld
mgorny committed rGd4f298c8206b: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib (authored by mgorny).
[clang-tools-extra] Prevent linking to duplicate .a libs and dylib
Jun 17 2020, 10:14 AM
mgorny committed rG1ad5e3cd6b81: [llvm] Disable linking llvm-exegesis to dylib (authored by mgorny).
[llvm] Disable linking llvm-exegesis to dylib
Jun 17 2020, 10:14 AM
mgorny committed rG352558e69b36: [llvm] Avoid linking llvm-cfi-verify to duplicate libs (authored by mgorny).
[llvm] Avoid linking llvm-cfi-verify to duplicate libs
Jun 17 2020, 10:14 AM
mgorny closed D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib.
Jun 17 2020, 10:14 AM · Restricted Project
mgorny closed D81922: [llvm] Disable linking llvm-exegesis to dylib.
Jun 17 2020, 10:14 AM · Restricted Project
mgorny committed rG5c621900a661: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup (authored by mgorny).
[llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup
Jun 17 2020, 10:13 AM
mgorny closed D81921: [llvm] Avoid linking llvm-cfi-verify to duplicate libs.
Jun 17 2020, 10:13 AM · Restricted Project
mgorny closed D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup.
Jun 17 2020, 10:13 AM · Restricted Project
mgorny added a comment to D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup.

I don't feel strongly about the inside/outside loop, let's stick with what you've proposed then.

LG with a test.

Jun 17 2020, 9:08 AM · Restricted Project
mgorny updated the diff for D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup.

Added a test that adds a hidden option that is closer to argv. Confirmed that it fails without the change, passes with the change.

Jun 17 2020, 9:08 AM · Restricted Project
mgorny added a comment to D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup.

(I'm working on the test)

Jun 17 2020, 6:58 AM · Restricted Project
mgorny added inline comments to D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup.
Jun 17 2020, 6:58 AM · Restricted Project
mgorny added inline comments to D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib.
Jun 17 2020, 6:58 AM · Restricted Project
mgorny added a comment to D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib.

Ok, I don't think this failure is due to my changes but I've proposed a solution as D82001 anyway.

Jun 17 2020, 4:16 AM · Restricted Project
mgorny created D82001: [llvm] [CommandLine] Do not suggest really hidden opts in nearest lookup.
Jun 17 2020, 3:44 AM · Restricted Project

Jun 16 2020

mgorny added a comment to D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib.

For the record, this seems to trigger some command-line option parser problem:

Jun 16 2020, 2:18 PM · Restricted Project
mgorny created D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib.
Jun 16 2020, 2:18 PM · Restricted Project
mgorny added a comment to D81922: [llvm] Disable linking llvm-exegesis to dylib.

Can you please add some messages about duplicate symbols?

Jun 16 2020, 9:21 AM · Restricted Project
mgorny created D81922: [llvm] Disable linking llvm-exegesis to dylib.
Jun 16 2020, 3:50 AM · Restricted Project
mgorny created D81921: [llvm] Avoid linking llvm-cfi-verify to duplicate libs.
Jun 16 2020, 3:50 AM · Restricted Project

Jun 15 2020

mgorny updated the diff for D76665: [asan] Stop instrumenting user-defined ELF sections.

Is this what you had in mind? I'm sorry it took me this long to get to it again.

Jun 15 2020, 4:18 AM · Restricted Project, Restricted Project

Jun 1 2020

mgorny added inline comments to D76665: [asan] Stop instrumenting user-defined ELF sections.
Jun 1 2020, 11:52 AM · Restricted Project, Restricted Project
mgorny added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Added a test.

Jun 1 2020, 8:33 AM · Restricted Project, Restricted Project
mgorny updated the diff for D76665: [asan] Stop instrumenting user-defined ELF sections.
Jun 1 2020, 8:33 AM · Restricted Project, Restricted Project
mgorny commandeered D76665: [asan] Stop instrumenting user-defined ELF sections.
Jun 1 2020, 8:33 AM · Restricted Project, Restricted Project

May 4 2020

mgorny resigned from D74051: Move update_cc_test_checks.py tests to clang.

Nevermind, I figured out good enough workaround.

May 4 2020, 1:01 AM · Restricted Project, Restricted Project

May 2 2020

mgorny added a comment to D74051: Move update_cc_test_checks.py tests to clang.

This broke running clang tests stand-alone:

Traceback (most recent call last):
  File "/var/tmp/portage/sys-devel/clang-11.0.0.9999/work/x/y/clang-abi_x86_64.amd64/bin/../../llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "/var/tmp/portage/sys-devel/clang-11.0.0.9999/work/x/y/clang/test/utils/update_cc_test_checks/lit.local.cfg", line 21, in <module>
    assert os.path.isfile(script_path)
AssertionError
                                                           
FAILED: test/CMakeFiles/check-clang

Obviously this fails when LLVM source tree is not available.

Is that a supported build mode for clang?

May 2 2020, 12:29 AM · Restricted Project, Restricted Project

May 1 2020

mgorny reopened D74051: Move update_cc_test_checks.py tests to clang.

This broke running clang tests stand-alone:

May 1 2020, 11:25 PM · Restricted Project, Restricted Project
mgorny requested changes to D74051: Move update_cc_test_checks.py tests to clang.
May 1 2020, 11:25 PM · Restricted Project, Restricted Project
mgorny committed rGcac8cd0a16e9: [clang] [unittest/AST] Fix linking to LLVMTestingSupport (authored by mgorny).
[clang] [unittest/AST] Fix linking to LLVMTestingSupport
May 1 2020, 5:28 PM

Apr 28 2020

mgorny added inline comments to D76102: Enforce that libc++ and libc++abi are built in a monorepo layout.
Apr 28 2020, 11:10 PM · Restricted Project, Restricted Project

Mar 17 2020

mgorny committed rG06489eaa9216: [lldb] [Host/NetBSD] Rename Host.cpp to HostNetBSD.cpp (authored by mgorny).
[lldb] [Host/NetBSD] Rename Host.cpp to HostNetBSD.cpp
Mar 17 2020, 3:44 AM

Mar 7 2020

mgorny committed rG172d564c7381: [lldb] Un-XFAIL two tests on NetBSD (authored by mgorny).
[lldb] Un-XFAIL two tests on NetBSD
Mar 7 2020, 9:45 AM

Feb 14 2020

mgorny added a comment to D72109: [cmake] Use relative cmake binary dir for processing pass plugins.

@mgorny can you try with https://reviews.llvm.org/D74602 applied?

Feb 14 2020, 6:51 AM · Restricted Project
mgorny added a comment to D72109: [cmake] Use relative cmake binary dir for processing pass plugins.

This broke standalone build of clang. It's trying to write into /include (as in, root directory) now! My guess is that LLVM_BINARY_DIR is undefined at this point of standalone build, later it might be defined to point to directory where LLVM was installed which also wouldn't be correct.

Feb 14 2020, 5:28 AM · Restricted Project
mgorny added a comment to D72501: [libcxx] Support Python 3.8 in the test suite.

@broadwaylamb, I've requested backporting this to 10.x: https://bugs.llvm.org/show_bug.cgi?id=44905. However, i wasn't able to find to find you on Bugzilla and CC you. Could you confirm whether it's fine to backport, please?

Feb 14 2020, 2:23 AM · Restricted Project

Feb 10 2020

mgorny added a comment to D69169: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH.

Gentoo, using the ebuilds. I think the most relevant is how libc++abi is configured:

Feb 10 2020, 10:37 AM · Restricted Project

Feb 7 2020

mgorny committed rG1ff411295f92: [lldb] Improve debugging 32-bit programs on NetBSD/amd64 (authored by mgorny).
[lldb] Improve debugging 32-bit programs on NetBSD/amd64
Feb 7 2020, 8:55 AM
mgorny closed D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64.
Feb 7 2020, 8:54 AM · Restricted Project

Feb 5 2020

mgorny committed rGdcab9736f01b: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb (authored by mgorny).
[lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb
Feb 5 2020, 9:37 AM
mgorny closed D73767: [lldb] [test] Pass LLVM_LIBS_DIR from CMake for linking liblldb.
Feb 5 2020, 9:37 AM · Restricted Project
mgorny committed rG5cc817be7501: [lldb] Introduce i386 support in NetBSD Process plugin (authored by mgorny).
[lldb] Introduce i386 support in NetBSD Process plugin
Feb 5 2020, 4:37 AM
mgorny closed D73802: [lldb] Introduce i386 support in NetBSD Process plugin.
Feb 5 2020, 4:37 AM · Restricted Project

Feb 4 2020

mgorny created D73974: [lldb] Improve debugging 32-bit programs on NetBSD/amd64.
Feb 4 2020, 9:35 AM · Restricted Project
mgorny updated the diff for D73802: [lldb] Introduce i386 support in NetBSD Process plugin.

Added tlsbase.

Feb 4 2020, 6:42 AM · Restricted Project
mgorny added a comment to D73816: [compiler-rt] implement sigaltstack interception.

This seems to have broken NetBSD:

Feb 4 2020, 5:56 AM · Restricted Project, Restricted Project

Feb 3 2020

mgorny committed rG98594a44aaa8: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches (authored by mgorny).
[lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches
Feb 3 2020, 8:51 PM
mgorny closed D73914: [lldb] [ObjectFile/ELF] Fix negated seg ids on 32-bit arches.
Feb 3 2020, 8:51 PM · Restricted Project
mgorny accepted D73850: [OpenMP][OMPT] fix reduction test for 32-bit x86.

I can confirm the tests pass both on i386 and amd64 for me, with this patch.

Feb 3 2020, 12:07 PM · Restricted Project