Besides the mentioned misindent, the CMake code looks correct. Could you test whether it works with standalone (out-of-LLVM) builds as well?

This broke NetBSD buildbot:

Thanks!

Also older versions of gcc. This broke bootstrap on NetBSD: http://lab.llvm.org:8014/builders/netbsd-amd64/builds/771/steps/ninja%20build%20local/logs/stdio

Is there a way to get the basename from ZLIB_LIBRARY by any chance? Not saying it's actually necessary, just wondering.

LGTM, presuming you've tested it. If you need me to do a second test run, lemme know.

Besides missing LZMA, looks good to me. However, I suspect you may want to wait for a second opinion ;-).

Switch to using %run_nomprotect instead of extra %paxctl. This should be more consistent and should avoid potential issues with : on Windows.

I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems.

In D58892#1783042, @MaskRay wrote:

In D58892#1783029, @mgorny wrote:

I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.

This seems to be a very serious limitation. I have difficult to understand how such limitation could exist at all, but I think this should be straightforward to fix.

I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.

I'm going to be blunt but if you dislike what LLVM does, improve that rather than proliferating inconsistencies between subprojects.

If it causes link-time error, why CMake checks don't catch that?

Updated to pass the 'prefix' via config object from common, and to use full path for paxctl.

In D70958#1769589, @eugenis wrote:

I meant you could define this path in the common lit config as something like "netbsd_noaslr_prefix" and then set up the %run substitution in subdirectories.

Ping.

I'll look into it a bit later. I've focused on libunwind since it's breaking NetBSD buildbot.

Switched to RegisterContextNetBSD & return type as suggested, and fixed formatting. Had to do some include shifting too.

Switched to %clang_host.

@labath, finally implemented the new tests. Covered two good (signal to one thread and to all threads) and two bad cases (signal to 1<i<n threads, two different signals to two threads). Please review.

That sounds like a bug in llvm-config. It shouldn't really return dylib for components that aren't part of it.

Implemented review suggestions. Thanks!

Added sys/types.h.

Went a bit further and implemented the missing feature.