mgorny (Michał Górny)
User

Projects

User does not belong to any projects.
User Since
Aug 15 2016, 6:00 AM (31 w, 6 d)

Recent Activity

Sat, Mar 25

mgorny committed rL298777: PluginUnwindAssemblyX86: add missing linkage to MCDisasm.
PluginUnwindAssemblyX86: add missing linkage to MCDisasm
Sat, Mar 25, 12:04 PM
mgorny committed rL298776: Expression: add missing linkage to RuntimeDyld component.
Expression: add missing linkage to RuntimeDyld component
Sat, Mar 25, 12:04 PM
mgorny closed D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm by committing rL298777: PluginUnwindAssemblyX86: add missing linkage to MCDisasm.
Sat, Mar 25, 12:04 PM · Restricted Project
mgorny closed D31367: Expression: add missing linkage to RuntimeDyld component by committing rL298776: Expression: add missing linkage to RuntimeDyld component.
Sat, Mar 25, 12:03 PM · Restricted Project
mgorny created D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm.
Sat, Mar 25, 7:02 AM · Restricted Project
mgorny created D31367: Expression: add missing linkage to RuntimeDyld component.
Sat, Mar 25, 6:53 AM · Restricted Project

Thu, Mar 23

mgorny added a reviewer for D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used: hfinkel.
Thu, Mar 23, 10:27 AM
mgorny added a dependent revision for D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used: D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.
Thu, Mar 23, 10:26 AM
mgorny added a dependency for D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin: D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Thu, Mar 23, 10:26 AM
mgorny reopened D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.

Reopening since it has been reverted.

Thu, Mar 23, 10:25 AM
mgorny added a reviewer for D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build: beanz.
Thu, Mar 23, 10:23 AM · Restricted Project

Fri, Mar 17

mgorny added a comment to D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.

@mgorny, we should only support this on shared libraries that we intend as vended libraries, not all libraries. For example we don't really want to support the CMake BUILD_SHARED_LIBS option's libraries as vended libraries on any platform.

Fri, Mar 17, 11:55 PM

Thu, Mar 16

mgorny added a comment to D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.
  1. Any reason not to use this for all shared libraries?
  2. AFAICS --default-symver is present on FreeBSD as well.
Thu, Mar 16, 12:09 AM

Tue, Mar 14

mgorny committed rL297807: [llvm-config] Add minimal sanity tests for path options.
[llvm-config] Add minimal sanity tests for path options
Tue, Mar 14, 11:09 PM
mgorny closed D28533: [llvm-config] Add minimal sanity tests for path options by committing rL297807: [llvm-config] Add minimal sanity tests for path options.
Tue, Mar 14, 11:09 PM
mgorny committed rL297806: [test] Fix test dependencies when using installed tools.
[test] Fix test dependencies when using installed tools
Tue, Mar 14, 11:07 PM
mgorny closed D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools by committing rL297806: [test] Fix test dependencies when using installed tools.
Tue, Mar 14, 11:07 PM · Restricted Project

Sat, Mar 11

mgorny added inline comments to D30773: Make git-clang-format python 3 compatible.
Sat, Mar 11, 3:10 AM
mgorny added a comment to D30733: [Driver] Add arch-specific rpath for libc++.

I'm sorry, I've completely forgot that the path contains version number. In this case, it indeed probably doesn't make much sense to add rpath for that.

Sat, Mar 11, 1:07 AM

Fri, Mar 10

mgorny added inline comments to D30773: Make git-clang-format python 3 compatible.
Fri, Mar 10, 11:35 PM
mgorny added a comment to D24921: [cfe] [Headers] Fix inttypes.h macros visibility in C++ with C99-compliant libc.

Ping II.

Fri, Mar 10, 11:41 AM
mgorny added a comment to D28533: [llvm-config] Add minimal sanity tests for path options.

@beanz, a little more of a ping since you've specifically asked for it ;-).

Fri, Mar 10, 11:41 AM
mgorny added a comment to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

A gentle ping.

Fri, Mar 10, 11:40 AM
mgorny added a comment to D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools.

PIng.

Fri, Mar 10, 11:39 AM · Restricted Project
mgorny added a comment to D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.

Ping.

Fri, Mar 10, 11:39 AM · Restricted Project
mgorny added a comment to D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

Another ping. Since 4.0.0 final has been tagged, I think we should get back to working on this. @compnerd, any suggestion how to proceed here?

Fri, Mar 10, 11:30 AM
mgorny added a comment to D30802: [Builtin] Implement lit-test support (part 1 of 2: test cases update).

First of all, thank you for doing this! This was long overdue ;-).

Fri, Mar 10, 6:52 AM

Thu, Mar 9

mgorny added inline comments to D30773: Make git-clang-format python 3 compatible.
Thu, Mar 9, 8:10 AM

Wed, Mar 8

mgorny added a comment to D30773: Make git-clang-format python 3 compatible.

There seem to be a couple cases where it's non-trivial to convert the output from bytes to str. I'll look into this further and update.

Wed, Mar 8, 11:22 PM
mgorny added a comment to D30668: Add llvm::sys::fs::real_path.

I'm sorry but what is the exact use case for this? I'm not exactly against having a function like this but 'realpath' logic is the kind of thing people frequently abuse, so I'd rather make sure we don't end up accidentally replacing 'canonical' paths provided by the user with 'real' paths.

Wed, Mar 8, 11:17 PM
mgorny added a comment to D25402: [Driver] Pass -lunwind along with compiler-rt when necessary on Linux.

@compnerd, I presume that the option would do nothing when using -rtlib=libgcc, correct? Or do we support combining libgcc with another unwinder?

Wed, Mar 8, 1:29 PM

Feb 24 2017

mgorny committed rL296183: [test] Try to link -latomic to provide atomics when available.
[test] Try to link -latomic to provide atomics when available
Feb 24 2017, 2:27 PM
mgorny closed D30083: [openmp] [test] Try to link -latomic to provide atomics when available by committing rL296183: [test] Try to link -latomic to provide atomics when available.
Feb 24 2017, 2:27 PM
mgorny added a reviewer for D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC: doug.gregor.

If I read the git correctly, the change that forbid defining builtins was initially made in rL64639. @doug.gregor, any chance you could help us over here? Is clang supposed to unconditionally reject those definitions, and are we supposed to always work-around it in compiler-rt, or should we consider adding some additional switch to allow them in clang?

Feb 24 2017, 11:29 AM
mgorny added a comment to D30083: [openmp] [test] Try to link -latomic to provide atomics when available.

Le gentle ping.

Feb 24 2017, 11:19 AM

Feb 23 2017

mgorny added inline comments to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Feb 23 2017, 9:32 PM

Feb 22 2017

mgorny committed rL295854: [Support] Provide linux/magic.h fallback for older kernels.
[Support] Provide linux/magic.h fallback for older kernels
Feb 22 2017, 10:21 AM
mgorny closed D30261: [Support] Provide linux/magic.h fallback for older kernels by committing rL295854: [Support] Provide linux/magic.h fallback for older kernels.
Feb 22 2017, 10:21 AM
mgorny created D30261: [Support] Provide linux/magic.h fallback for older kernels.
Feb 22 2017, 9:12 AM

Feb 19 2017

mgorny committed rL295621: [test] Fix finding LLDB tools when building stand-alone.
[test] Fix finding LLDB tools when building stand-alone
Feb 19 2017, 2:23 PM
mgorny closed D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone by committing rL295621: [test] Fix finding LLDB tools when building stand-alone.
Feb 19 2017, 2:23 PM · Restricted Project
mgorny created D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.
Feb 19 2017, 5:37 AM · Restricted Project

Feb 17 2017

mgorny accepted D30015: Add arch-specific directory to search path.

LGTM modulo the test match split. But please wait for someone who has been longer here to confirm.

Feb 17 2017, 2:39 PM
mgorny added inline comments to D30092: CMake: Clean up VersionFromVCS.cmake.
Feb 17 2017, 7:28 AM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 17 2017, 2:12 AM
mgorny created D30083: [openmp] [test] Try to link -latomic to provide atomics when available.
Feb 17 2017, 2:03 AM

Feb 16 2017

mgorny added a comment to D30015: Add arch-specific directory to search path.

Thanks. The -L tests look good, -rpath is not perfect but I don't think you can improve it without additional changes to the Driver.

Feb 16 2017, 11:37 PM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 16 2017, 2:14 PM
mgorny added a comment to D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone.

Following @labath's suggestion, I've changed my approach a little. Now I'm using PATH lookup only for CC/CXX, while for remaining tools I'm using either llvm_tools_dir or lldb_tools_dir appropriately.

Feb 16 2017, 1:03 PM · Restricted Project
mgorny updated the diff for D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone.
Feb 16 2017, 1:02 PM · Restricted Project
mgorny added a comment to D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC.

This code is working around something that's probably a clang bug. It would be better to fix the clang bug than add more complex workarounds.

Feb 16 2017, 4:30 AM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 16 2017, 12:05 AM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 16 2017, 12:03 AM

Feb 15 2017

mgorny created D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC.
Feb 15 2017, 11:14 PM
mgorny added a reviewer for D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone: labath.
Feb 15 2017, 10:27 AM · Restricted Project
mgorny added a comment to D29185: [lit] Allow llvm's build and test systems to support paths with spaces.

I would like to point out that if you proactively reject all paths with spaces, you wouldn't be able to add additional tests that would test support for paths with spaces ;-). While I agree that we should avoid spaces whenever possible, I think it would be reasonable to add tests for paths with spaces wherever we expect them to be well-supported and want to avoid regressions.

Feb 15 2017, 5:04 AM
mgorny created D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone.
Feb 15 2017, 4:57 AM · Restricted Project
mgorny abandoned D28862: [compiler-rt] [test] Use approximate comparison on float types.

I've opened http://bugs.llvm.org/show_bug.cgi?id=31964 to track this further. I don't really have time to look into it in more detail at the moment.

Feb 15 2017, 2:35 AM

Feb 13 2017

mgorny added a comment to D28533: [llvm-config] Add minimal sanity tests for path options.

Ping.

Feb 13 2017, 7:51 AM
mgorny added a comment to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

Le gentle ping.

Feb 13 2017, 7:51 AM

Feb 10 2017

mgorny created D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools.
Feb 10 2017, 2:39 PM · Restricted Project

Feb 8 2017

mgorny committed rL294508: [test] Fix zlib cond when building stand-alone, clean up.
[test] Fix zlib cond when building stand-alone, clean up
Feb 8 2017, 12:20 PM
mgorny closed D29340: [lld] [test] Fix zlib cond when building stand-alone, clean up by committing rL294508: [test] Fix zlib cond when building stand-alone, clean up.
Feb 8 2017, 12:20 PM · lld
mgorny committed rL294507: [test] Use LLD-specific binary&library dirs when building stand-alone.
[test] Use LLD-specific binary&library dirs when building stand-alone
Feb 8 2017, 12:19 PM
mgorny closed D29335: [lld] [test] Use LLD-specific binary&library dirs when building stand-alone by committing rL294507: [test] Use LLD-specific binary&library dirs when building stand-alone.
Feb 8 2017, 12:19 PM · lld
mgorny committed rL294438: [test] #ifdef new builtin tests for __arm__ platform.
[test] #ifdef new builtin tests for __arm__ platform
Feb 8 2017, 4:14 AM
mgorny closed D29708: [compiler-rt] [test] #ifdef new builtin tests for __arm__ platform by committing rL294438: [test] #ifdef new builtin tests for __arm__ platform.
Feb 8 2017, 4:14 AM
mgorny committed rL294431: [test] Fix hard_link_count test to account for fs with dir nlink==1.
[test] Fix hard_link_count test to account for fs with dir nlink==1
Feb 8 2017, 2:09 AM
mgorny closed D29706: [libcxx] [test] Fix hard_link_count test to account for fs with dir nlink==1 by committing rL294431: [test] Fix hard_link_count test to account for fs with dir nlink==1.
Feb 8 2017, 2:08 AM
mgorny created D29708: [compiler-rt] [test] #ifdef new builtin tests for __arm__ platform.
Feb 8 2017, 2:05 AM
mgorny created D29706: [libcxx] [test] Fix hard_link_count test to account for fs with dir nlink==1.
Feb 8 2017, 1:37 AM
mgorny committed rL294425: [test] Enable the strace_test only if strace is installed.
[test] Enable the strace_test only if strace is installed
Feb 8 2017, 12:55 AM
mgorny closed D29628: [compiler-rt] [test] Enable the strace_test only if strace is installed by committing rL294425: [test] Enable the strace_test only if strace is installed.
Feb 8 2017, 12:55 AM
mgorny added a comment to D29340: [lld] [test] Fix zlib cond when building stand-alone, clean up.

A gentle ping.

Feb 8 2017, 12:49 AM · lld
mgorny added a comment to D29335: [lld] [test] Use LLD-specific binary&library dirs when building stand-alone.

A gentle ping.

Feb 8 2017, 12:49 AM · lld

Feb 7 2017

mgorny created D29628: [compiler-rt] [test] Enable the strace_test only if strace is installed.
Feb 7 2017, 4:21 AM

Feb 6 2017

mgorny updated the diff for D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

Removed the i386 branch. Now the i486+ are used unconditionally.

Feb 6 2017, 2:52 PM
mgorny added inline comments to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Feb 6 2017, 10:11 AM
mgorny added a comment to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

At this point, I don't think there is any use on pretending that i386-as-default makes sense. So I would request that the i386 case should be made explicit or just dropped, with a preference for the latter.

Feb 6 2017, 9:43 AM
mgorny added inline comments to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Feb 6 2017, 9:32 AM
mgorny added inline comments to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Feb 6 2017, 12:19 AM

Feb 5 2017

mgorny updated the diff for D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

CUDA: added the MaxAtomicPromoteWidth setting, and moved the CPU setting a little lower to ensure that it doesn't get called with null HostTarget.

Feb 5 2017, 3:12 PM
mgorny added inline comments to D29555: [CMake] Fix pthread handling for out-of-tree builds.
Feb 5 2017, 4:32 AM
mgorny updated the diff for D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

Ok, this CUDA fix should be reasonable, i think. It simply assumes i586+ (i.e. all inline atomics enabled) for CUDA target builds. I seriously doubt it's technically possible that anyone will ever use CUDA on <i586 ;-).

Feb 5 2017, 1:42 AM

Feb 4 2017

mgorny added a comment to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

Could someone help me figure out what is the cause and correct solution to that failure? @jlebar?

You can see in NVPTXTargetInfo that we read properties from the host targetinfo so that we export the same macros. The problem here seems to be that we're mutating the x86 targetinfo after the nvptx targetinfo reads its properties.

Does that give you enough context to fix the problem?

Feb 4 2017, 12:49 PM
mgorny created D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Feb 4 2017, 10:24 AM
mgorny added a comment to D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.
In D28213#666269, @dim wrote:

What's the value of __atomic_always_lock_free(sizeof(long long), 0) for gcc and clang?

For gcc, it is always 0, for clang (I tested 3.4.1 through 4.0.0) it is always 1. Maybe that was always incorrect on 32-bit FreeBSD, then?

Feb 4 2017, 1:12 AM

Feb 3 2017

mgorny added a comment to D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.
In D28213#665967, @dim wrote:

I don't think FreeBSD has lock-free 64 bit atomic operations on 32-bit x86. IIRC we already had some trouble before with clang emitting libcalls to __atomic_fetch_add_8 and friends, which then lead to linking errors.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216745, where this is now occurring with boost.

Feb 3 2017, 12:52 PM
mgorny added a reviewer for D29335: [lld] [test] Use LLD-specific binary&library dirs when building stand-alone: beanz.
Feb 3 2017, 9:14 AM · lld
mgorny added a reviewer for D29340: [lld] [test] Fix zlib cond when building stand-alone, clean up: beanz.
Feb 3 2017, 9:14 AM · lld

Feb 1 2017

mgorny added inline comments to D27405: Make sancov.py py3-compatible.
Feb 1 2017, 12:34 AM

Jan 31 2017

mgorny added inline comments to D27405: Make sancov.py py3-compatible.
Jan 31 2017, 11:48 PM
mgorny added inline comments to D27404: Make asan_symbolize.py py3-compatible.
Jan 31 2017, 11:41 PM
mgorny created D29340: [lld] [test] Fix zlib cond when building stand-alone, clean up.
Jan 31 2017, 11:11 AM · lld
mgorny created D29335: [lld] [test] Use LLD-specific binary&library dirs when building stand-alone.
Jan 31 2017, 10:10 AM · lld
mgorny committed rL293632: [cmake] Hint find_package() to prefer LLVM installed alongside clang.
[cmake] Hint find_package() to prefer LLVM installed alongside clang
Jan 31 2017, 6:27 AM
mgorny closed D29304: [cmake] Hint find_package() to prefer LLVM installed alongside clang by committing rL293632: [cmake] Hint find_package() to prefer LLVM installed alongside clang.
Jan 31 2017, 6:27 AM
mgorny committed rL293630: [cmake] Support running tests in stand-alone builds.
[cmake] Support running tests in stand-alone builds
Jan 31 2017, 6:21 AM
mgorny closed D28750: [lld] [cmake] Support running tests in stand-alone builds by committing rL293630: [cmake] Support running tests in stand-alone builds.
Jan 31 2017, 6:21 AM

Jan 30 2017

mgorny created D29304: [cmake] Hint find_package() to prefer LLVM installed alongside clang.
Jan 30 2017, 1:55 PM