Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (152 w, 6 d)

Recent Activity

Yesterday

mgorny raised a concern with rL366585: AMDGPU/GlobalISel: Selection for fminnum/fmaxnum.

The added tests are failing for me, both on NetBSD and on one of my Linux systems:
http://lab.llvm.org:8011/builders/netbsd-amd64/builds/21070/steps/run%20unit%20tests

Sun, Jul 21, 11:10 AM

Thu, Jul 18

mgorny added inline comments to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.
Thu, Jul 18, 8:44 AM · Restricted Project, Restricted Project

Wed, Jul 17

mgorny accepted D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.

Makes sense. I suppose you want to update LLDBStandalone as well. And probably Python_ADDITIONAL_VERSIONS in clang & co are outdated.

Wed, Jul 17, 11:06 PM · Restricted Project, Restricted Project
mgorny added a comment to D64881: [Cmake] Use the modern way to find Python when possible.

Filed https://gitlab.kitware.com/cmake/cmake/issues/19492 for that.

Wed, Jul 17, 10:57 PM · Restricted Project
mgorny added a comment to D64848: Only build lit-cpuid if the target doesn't already exist.

To be honest, I don't think this is the correct solution. After all, lit-cpuid isn't installed, is it? (or are you using LLVM_INSTALL_UTILS?)

Wed, Jul 17, 10:46 PM
mgorny added a comment to D64881: [Cmake] Use the modern way to find Python when possible.

That said, I ended up having mixed feelings about this.

Wed, Jul 17, 10:44 PM · Restricted Project
mgorny added a comment to D64881: [Cmake] Use the modern way to find Python when possible.

Testing the matrix of 32/64, 64/32, Python 2/3, debug/release, seems like a lot of work. I'd be pretty surprised to learn that CMake did extra, Windows-specific work necessary to make find_package do the right thing in the face of registry and/or filesystem redirection.

Wed, Jul 17, 10:43 PM · Restricted Project
mgorny added a comment to D64848: Only build lit-cpuid if the target doesn't already exist.

Am I guessing correctly that this happens when you installed combined llvm+lldb build, and then try to build lldb standalone against that?

Wed, Jul 17, 1:47 AM

Tue, Jul 16

mgorny added inline comments to D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version .
Tue, Jul 16, 8:29 PM · Restricted Project, Restricted Project
mgorny added inline comments to D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version .
Tue, Jul 16, 11:57 AM · Restricted Project, Restricted Project
mgorny added a comment to D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version .

If that works in 3.4 I'm happy to go that way!

Tue, Jul 16, 11:44 AM · Restricted Project, Restricted Project
mgorny added a comment to D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version .

Hmm, I've just looked through CMake docs, and I think a better solution might be:

Tue, Jul 16, 11:27 AM · Restricted Project, Restricted Project

Fri, Jul 12

mgorny added a comment to D64647: [lldb] [Process/NetBSD] Implement per-thread execution control.

Something that we do not cover here is that once a tracee reports a signal (like someone poked it with SIGUSR1) and we want to pass it over to the tracee, we will reset siginfo.

This scenario should be covered by a test and we should handle it properly..

The solution in NetBSD for passing over signals without changing siginfo, is to not calling PT_SET_SIGINFO as the default one will be kept by the kernel. Optionally pick old siginfo with PT_GET_SIGINFO and optionally change destination lwp.

Fri, Jul 12, 11:30 PM · Restricted Project
mgorny committed rG1447b60eeb2b: [lldb] [test] Un-XFAIL TestFormattersSBAPI on NetBSD (authored by mgorny).
[lldb] [test] Un-XFAIL TestFormattersSBAPI on NetBSD
Fri, Jul 12, 11:25 PM
mgorny committed rL365991: [lldb] [test] Un-XFAIL TestFormattersSBAPI on NetBSD.
[lldb] [test] Un-XFAIL TestFormattersSBAPI on NetBSD
Fri, Jul 12, 11:23 PM
mgorny added inline comments to D64647: [lldb] [Process/NetBSD] Implement per-thread execution control.
Fri, Jul 12, 11:44 AM · Restricted Project
mgorny added a comment to D64647: [lldb] [Process/NetBSD] Implement per-thread execution control.

Shouldn't there be some tests that come along with this patch?

Fri, Jul 12, 11:19 AM · Restricted Project
mgorny updated the diff for D64647: [lldb] [Process/NetBSD] Implement per-thread execution control.
Fri, Jul 12, 11:10 AM · Restricted Project
mgorny added inline comments to D64647: [lldb] [Process/NetBSD] Implement per-thread execution control.
Fri, Jul 12, 11:06 AM · Restricted Project
mgorny retitled D64647: [lldb] [Process/NetBSD] Implement per-thread execution control from [lldb] [Process/NetBSD] Implement per-thread executation control to [lldb] [Process/NetBSD] Implement per-thread execution control.
Fri, Jul 12, 10:31 AM · Restricted Project
mgorny created D64647: [lldb] [Process/NetBSD] Implement per-thread execution control.
Fri, Jul 12, 10:24 AM · Restricted Project

Tue, Jul 9

mgorny added inline comments to D64443: Add support for building with Python 3.
Tue, Jul 9, 1:39 PM · Restricted Project
mgorny added inline comments to D64443: Add support for building with Python 3.
Tue, Jul 9, 1:13 PM · Restricted Project
mgorny added a comment to D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.

The build bots must specify -DLIBCXX_CXX_ABI=libcxxabi at the CMake configure step. Otherwise, they'll end up using the default ABI library on Linux, which uses the xxx_fallback.ipp files from libc++, and that doesn't implement everything we need.

Tue, Jul 9, 6:42 AM · Restricted Project, Restricted Project
mgorny raised a concern with rL365468: OpaquePtr: add Type parameter to Loads analysis API..

Unless I'm mistaken, this commit broke building Polly:

Tue, Jul 9, 6:41 AM

Mon, Jul 8

mgorny added a comment to D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.

Could you tell me specifically what change to buildbot is requested? I must've missed the original thread.

Mon, Jul 8, 12:26 PM · Restricted Project, Restricted Project
mgorny committed rG10c96cabc17e: [lldb] [test] Update NetBSD XFAILs in test suite (authored by mgorny).
[lldb] [test] Update NetBSD XFAILs in test suite
Mon, Jul 8, 9:20 AM
mgorny committed rL365338: [lldb] [test] Update NetBSD XFAILs in test suite.
[lldb] [test] Update NetBSD XFAILs in test suite
Mon, Jul 8, 9:20 AM
mgorny added a comment to D63883: [libc++] Do not cleverly link against libc++abi just because it happens to be there.

Am I guessing correctly that this broke the buildbots (again)?

Mon, Jul 8, 9:10 AM · Restricted Project, Restricted Project

Sun, Jul 7

mgorny accepted D64240: [LIT] emit timeout error message only if timeout was reached.

LGTM.

Sun, Jul 7, 3:09 AM · Restricted Project
mgorny accepted D58619: [NFC][cmake] Build fix in tools/llvm-config/CMakeLists.txt.

LGTM. According to CMake manual, plain + is the only correct form and if \+ worked at all, it was probably only by accident.

Sun, Jul 7, 3:04 AM · Restricted Project
mgorny planned changes to D59249: [llvm] [Support] mallctl() is in malloc.h on NetBSD.

The API has changed, and so the patch is no longer correct.

Sun, Jul 7, 3:01 AM · Restricted Project
mgorny accepted D63770: Options: Reduce code duplication.

LGTM.

Sun, Jul 7, 3:01 AM · Restricted Project

Sat, Jul 6

mgorny added a comment to D64163: Change LaunchThread interface to return an expected..

This seems to have broken the build for us:
http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20658

Sat, Jul 6, 4:13 AM · Restricted Project, Restricted Project

Tue, Jul 2

mgorny committed rG638cc0a47999: [llvm] [Support] Clean PrintStackTrace() ptr arithmetic up (authored by mgorny).
[llvm] [Support] Clean PrintStackTrace() ptr arithmetic up
Tue, Jul 2, 4:35 AM
mgorny committed rL364912: [llvm] [Support] Clean PrintStackTrace() ptr arithmetic up.
[llvm] [Support] Clean PrintStackTrace() ptr arithmetic up
Tue, Jul 2, 4:35 AM
mgorny closed D63888: [llvm] [Support] Clean PrintStackTrace() ptr arithmetic up.
Tue, Jul 2, 4:35 AM · Restricted Project

Mon, Jul 1

mgorny committed rG0856721e3a06: [lldb] [Process/NetBSD] Use global enable bits for watchpoints (authored by mgorny).
[lldb] [Process/NetBSD] Use global enable bits for watchpoints
Mon, Jul 1, 8:15 AM
mgorny committed rGbaf64b650569: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint (authored by mgorny).
[lldb] [Process/NetBSD] Fix segfault when handling watchpoint
Mon, Jul 1, 8:12 AM
mgorny committed rG2b2ad9342e65: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE (authored by mgorny).
[lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE
Mon, Jul 1, 8:12 AM
mgorny committed rL364781: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.
[lldb] [Process/NetBSD] Use global enable bits for watchpoints
Mon, Jul 1, 8:12 AM
mgorny closed D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.
Mon, Jul 1, 8:12 AM · Restricted Project
mgorny committed rL364780: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.
[lldb] [Process/NetBSD] Fix segfault when handling watchpoint
Mon, Jul 1, 8:12 AM
mgorny closed D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.
Mon, Jul 1, 8:12 AM · Restricted Project
mgorny committed rL364779: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.
[lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE
Mon, Jul 1, 8:11 AM
mgorny closed D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.
Mon, Jul 1, 8:11 AM · Restricted Project
mgorny committed rG535f39ce5217: Revert "[lldb] [Process/NetBSD] Fix constructor after r363707" (authored by mgorny).
Revert "[lldb] [Process/NetBSD] Fix constructor after r363707"
Mon, Jul 1, 7:41 AM
mgorny committed rL364776: Revert "[lldb] [Process/NetBSD] Fix constructor after r363707".
Revert "[lldb] [Process/NetBSD] Fix constructor after r363707"
Mon, Jul 1, 7:41 AM
mgorny updated the diff for D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.

Updated per review.

Mon, Jul 1, 3:15 AM · Restricted Project
mgorny added a comment to D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.

I'm going to ask Kamil to stamp those patches anyway but I always appreciate your advice wrt LLDB coding style and general integration. After all, we all want LLDB codebase to be more unified.

Mon, Jul 1, 3:09 AM · Restricted Project
mgorny added a comment to D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.

That's probably one of the reasons why NetBSD normally prevents unprivileged users from setting DRs.

Mon, Jul 1, 3:08 AM · Restricted Project
mgorny added a comment to D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.

Ping.

Mon, Jul 1, 12:55 AM · Restricted Project
mgorny added a comment to D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.

Ping.

Mon, Jul 1, 12:55 AM · Restricted Project
mgorny added a comment to D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.

Ping.

Mon, Jul 1, 12:55 AM · Restricted Project

Sat, Jun 29

mgorny added a comment to D53631: Fix libcxx build with MinGW winpthreads.

I'm sorry that nobody has replied to your request earlier. AFAICS the libcxx code has changed. Does it work now, or do we need to make thread_win32.cpp conditional to LIBCXX_HAS_WIN32_THREAD_API still?

Sat, Jun 29, 3:49 AM

Thu, Jun 27

mgorny created D63888: [llvm] [Support] Clean PrintStackTrace() ptr arithmetic up.
Thu, Jun 27, 12:21 PM · Restricted Project
mgorny added a comment to D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.

This is ready to be reviewed now.

Thu, Jun 27, 12:21 PM · Restricted Project
mgorny retitled D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE from [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE] to [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.
Thu, Jun 27, 12:18 PM · Restricted Project
mgorny committed rGe62456b35370: [lldb] [Plugins/SysV-x86_64] NetBSD is also using SysV ABI (authored by mgorny).
[lldb] [Plugins/SysV-x86_64] NetBSD is also using SysV ABI
Thu, Jun 27, 12:10 AM
mgorny committed rL364503: [lldb] [Plugins/SysV-x86_64] NetBSD is also using SysV ABI.
[lldb] [Plugins/SysV-x86_64] NetBSD is also using SysV ABI
Thu, Jun 27, 12:10 AM
mgorny added inline comments to D62213: [ABI] Implement Windows ABI for x86_64.
Thu, Jun 27, 12:06 AM · Restricted Project, Restricted Project

Wed, Jun 26

mgorny updated the diff for D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.

Removed XFAIL for tests fixed by this.

Wed, Jun 26, 12:14 PM · Restricted Project
mgorny added a parent revision for D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints: D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.
Wed, Jun 26, 12:12 PM · Restricted Project
mgorny added a child revision for D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint: D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.
Wed, Jun 26, 12:12 PM · Restricted Project

Tue, Jun 25

mgorny created D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.
Tue, Jun 25, 1:57 PM · Restricted Project
mgorny created D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.
Tue, Jun 25, 1:53 PM · Restricted Project

Mon, Jun 24

mgorny committed rGa5bb7b6c20e2: [libcxx] [test] Read files as bytestrings to fix py3 encoding issues (authored by mgorny).
[libcxx] [test] Read files as bytestrings to fix py3 encoding issues
Mon, Jun 24, 2:46 AM
mgorny committed rL364170: [libcxx] [test] Read files as bytestrings to fix py3 encoding issues.
[libcxx] [test] Read files as bytestrings to fix py3 encoding issues
Mon, Jun 24, 2:41 AM
mgorny closed D63346: [libcxx] [test] Read files as bytestrings to fix py3 encoding issues.
Mon, Jun 24, 2:41 AM · Restricted Project

Jun 21 2019

mgorny updated the diff for D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.

…and removed stale declarations.

Jun 21 2019, 7:53 AM · Restricted Project
mgorny updated the diff for D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.

Updated to use new XState conversion methods.

Jun 21 2019, 7:50 AM · Restricted Project
mgorny committed rG880582928920: [lldb] [Process] Introduce common helpers to split/recombine YMM data (authored by mgorny).
[lldb] [Process] Introduce common helpers to split/recombine YMM data
Jun 21 2019, 6:19 AM
mgorny committed rL364042: [lldb] [Process] Introduce common helpers to split/recombine YMM data.
[lldb] [Process] Introduce common helpers to split/recombine YMM data
Jun 21 2019, 6:18 AM
mgorny closed D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data.
Jun 21 2019, 6:18 AM · Restricted Project
mgorny added a comment to D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data.

It's not much, but it definitely does help.

// NB: I have no clue why FreeBSD code claims to belong in 'POSIX', and Linux does not.

I think that somehow fell out of the fact that FreeBSD uses an in-process debugging plugin, while linux uses lldb-server.

Jun 21 2019, 6:18 AM · Restricted Project

Jun 20 2019

mgorny requested changes to D63637: Do not set an RPATH on statically-linked LLVM executables..
Jun 20 2019, 8:27 PM · Restricted Project
mgorny added a comment to D63346: [libcxx] [test] Read files as bytestrings to fix py3 encoding issues.

…and confirmed.

Jun 20 2019, 11:45 AM · Restricted Project
mgorny added a comment to D63346: [libcxx] [test] Read files as bytestrings to fix py3 encoding issues.

Is this backwards compatible as well?

Jun 20 2019, 11:17 AM · Restricted Project
mgorny created D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data.
Jun 20 2019, 9:46 AM · Restricted Project
mgorny committed rGd687fa7d023a: [lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction (authored by mgorny).
[lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction
Jun 20 2019, 5:42 AM
mgorny committed rL363923: [lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction.
[lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction
Jun 20 2019, 5:42 AM
mgorny closed D63594: [lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction.
Jun 20 2019, 5:42 AM · Restricted Project
mgorny updated the diff for D63594: [lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction.

How about this? I've removed almost all abstraction, leaving only simple ptrace() wrapper.

Jun 20 2019, 5:11 AM · Restricted Project
mgorny added a comment to D63594: [lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction.

I'll try to simplify it in a few steps and see how that goes. All I'm saying is that ultimately having some DoRegisterSet() wrapper that calls ptrace() and avoids repeating getting PID/TID may help. Though admittely it saves very little actual code.

Jun 20 2019, 4:52 AM · Restricted Project
mgorny added a comment to D63594: [lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction.

BTW, is ReadGPR even called from some other place than NativeRegisterContextNetBSD_x86_64::ReadRegisterSet ? If not, then we could remove all of these functions (except the ReadRegisterSet I suggest above), and inline everything into NativeRegisterContextNetBSD_x86_64::ReadRegisterSet (one of these should be renamed, obviously), removing about 5 layers of indirection...

Jun 20 2019, 4:42 AM · Restricted Project
mgorny added a comment to D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.

We have the same XSTATE<->YMM conversion functions in NativeProcessLinux. It would be nice to extract them to some common place (Plugins/Process/Utility, I guess :P).

Hmm, I guess that's doable if we pass the relevant struct fields as pointers.

Maybe have GetYMM(unsigned num, YMM& reg)/SetYMM(unsigned num, const YMM &reg) methods on the XSAVE struct ?

Jun 20 2019, 4:37 AM · Restricted Project
mgorny created D63594: [lldb] [Process/NetBSD] Remove unnecessary register buffer abstraction.
Jun 20 2019, 4:20 AM · Restricted Project
mgorny added a comment to D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.

We have the same XSTATE<->YMM conversion functions in NativeProcessLinux. It would be nice to extract them to some common place (Plugins/Process/Utility, I guess :P).

Jun 20 2019, 3:57 AM · Restricted Project
mgorny updated the diff for D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.

Rebased for changes in NativeRegisterContextNetBSD_x86_64::GetSetForNativeRegNum(), and removed the conditions there.

Jun 20 2019, 2:41 AM · Restricted Project
mgorny added a comment to D63110: Fix a crash in option parsing..

@stella.stamenova could you try running the lldb invocation manually like I did? I'm wondering if you're getting the same issue.

Jun 20 2019, 2:37 AM · Restricted Project, Restricted Project
mgorny added a comment to D63110: Fix a crash in option parsing..

The added test broke NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/109/steps/run%20unit%20tests/logs/FAIL%3A%20LLDB%3A%3ATestProcessAttach.test

Jun 20 2019, 2:28 AM · Restricted Project, Restricted Project

Jun 19 2019

mgorny committed rGa5992997d9a9: [lldb] [Process/NetBSD] Fix constructor after r363707 (authored by mgorny).
[lldb] [Process/NetBSD] Fix constructor after r363707
Jun 19 2019, 8:48 AM
mgorny committed rL363827: [lldb] [Process/NetBSD] Fix constructor after r363707.
[lldb] [Process/NetBSD] Fix constructor after r363707
Jun 19 2019, 8:47 AM
mgorny committed rGa644b04b8cd8: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64 (authored by mgorny).
[lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64
Jun 19 2019, 8:33 AM
mgorny committed rL363823: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64.
[lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64
Jun 19 2019, 8:32 AM
mgorny closed D63554: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64.
Jun 19 2019, 8:32 AM · Restricted Project
mgorny created D63554: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64.
Jun 19 2019, 7:27 AM · Restricted Project
mgorny created D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.
Jun 19 2019, 5:53 AM · Restricted Project

Jun 17 2019

mgorny added a comment to D58587: Implement P0433: deduction guides for <map>.

Marshall, std/containers/associative/map/map.cons/deduct_const.pass.cpp test seems to be reliably failing from commit one on both Gentoo Linux and NetBSD. Could you please look at the classical example of totally cryptic C++ error? ;-)

Jun 17 2019, 9:30 AM · Restricted Project
mgorny committed rGd3d2edf901de: [lldb] [test] Watchpoint tests can be always run as root on NetBSD (authored by mgorny).
[lldb] [test] Watchpoint tests can be always run as root on NetBSD
Jun 17 2019, 5:30 AM