mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (79 w, 3 d)

Recent Activity

Mon, Feb 19

mgorny added a comment to D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.

Ping for the third time.

Mon, Feb 19, 4:55 AM

Mon, Jan 29

mgorny committed rL323673: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
[Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux
Mon, Jan 29, 10:26 AM
mgorny closed D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
Mon, Jan 29, 10:26 AM
mgorny added inline comments to D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
Mon, Jan 29, 8:56 AM

Jan 20 2018

mgorny created D42331: [cmake] Remove LLVM_HAVE_OPT_VIEWER_MODULES from LLVMConfig.
Jan 20 2018, 1:59 AM

Jan 19 2018

mgorny added a comment to D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.

Disclaimer: I have never seen a plugin for LLDB. I've just noticed the wrong path in strace output and fixed it ;-).

Jan 19 2018, 2:35 PM
mgorny created D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
Jan 19 2018, 2:34 PM
mgorny committed rL322973: [cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006.
[cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006
Jan 19 2018, 9:49 AM
mgorny closed D42252: [cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006.
Jan 19 2018, 9:49 AM

Jan 18 2018

mgorny created D42252: [cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006.
Jan 18 2018, 11:09 AM

Jan 9 2018

mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

I was talking of:

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

Ah, right. These uses were introduced before we developed a preference for llvm primitives. That said, I see a lot of compression stuff there, but I don't see mention of zlib directly.

Jan 9 2018, 6:51 AM
mgorny committed rL322081: [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.
[test] Fix tests to use more portable LLVM_ENABLE_ZLIB
Jan 9 2018, 6:45 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 9 2018, 6:45 AM

Jan 7 2018

mgorny updated the diff for D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

Updated the patch to use LLVM_ENABLE_ZLIB directly.

Jan 7 2018, 11:58 AM
mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

I was talking of:

Jan 7 2018, 2:11 AM

Jan 6 2018

mgorny committed rL321932: [test] Use full PATH lookup for tools.
[test] Use full PATH lookup for tools
Jan 6 2018, 2:21 AM
mgorny closed D41726: [test] Use full PATH lookup for tools.
Jan 6 2018, 2:21 AM
mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

Well, it's actually more complex. In Gentoo we want to let the user choose whether he wants to build against zlib or without zlib support. So in the end there are two uses to be considered:

Jan 6 2018, 2:15 AM
mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

Maybe we could. I presumed people are using the separate variables for some reason. We'd have to check that it's properly sanitized when building in-tree and given to cmake though.

Jan 6 2018, 1:28 AM

Jan 4 2018

mgorny created D41726: [test] Use full PATH lookup for tools.
Jan 4 2018, 5:58 AM
mgorny created D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.
Jan 4 2018, 5:54 AM

Dec 13 2017

mgorny added inline comments to D41134: [compiler-rt] [builtins] Implement __chkstk for arm64 windows.
Dec 13 2017, 10:53 AM

Dec 11 2017

mgorny added inline comments to D37326: Fix the OCaml external linking problem.
Dec 11 2017, 12:09 PM

Nov 30 2017

mgorny committed rL319461: [cmake] Include project name in Sphinx doctree dir to fix race conditions.
[cmake] Include project name in Sphinx doctree dir to fix race conditions
Nov 30 2017, 11:09 AM
mgorny closed D40656: [cmake] Include project name in Sphinx doctree dir to fix race conditions by committing rL319461: [cmake] Include project name in Sphinx doctree dir to fix race conditions.
Nov 30 2017, 11:09 AM
mgorny created D40656: [cmake] Include project name in Sphinx doctree dir to fix race conditions.
Nov 30 2017, 9:27 AM

Nov 27 2017

mgorny committed rL319105: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
[cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading
Nov 27 2017, 2:23 PM
mgorny closed D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading by committing rL319105: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 27 2017, 2:23 PM
mgorny reopened D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 27 2017, 1:51 PM
mgorny updated the diff for D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.

Updated to fix unittest failure.

Nov 27 2017, 1:50 PM
mgorny committed rL319076: Revert r319069 - [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Revert r319069 - [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading
Nov 27 2017, 11:19 AM
mgorny committed rL319069: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
[cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading
Nov 27 2017, 10:35 AM
mgorny closed D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading by committing rL319069: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 27 2017, 10:35 AM

Nov 25 2017

mgorny created D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 25 2017, 3:23 PM

Nov 18 2017

mgorny added a comment to D40217: [LIT] Fix testing out-of-tree Clang builds.

Or even more abstract (if we assume we don't have to check for presence of llvm_tools_dir):

Nov 18 2017, 2:50 PM
mgorny added a comment to D40217: [LIT] Fix testing out-of-tree Clang builds.

To be honest, as I said before, I'm entirely confused by the logic there, with all the prepending, appending and shuffling around. But if you believe it gives the correct result, I'm all for it.

Nov 18 2017, 2:49 PM

Nov 17 2017

mgorny committed rL318562: [cmake] Use llvm-lit directory when provided for stand-alone build.
[cmake] Use llvm-lit directory when provided for stand-alone build
Nov 17 2017, 2:21 PM
mgorny closed D40142: [cmake] Use llvm-lit directory when provided for stand-alone build by committing rL318562: [cmake] Use llvm-lit directory when provided for stand-alone build.
Nov 17 2017, 2:21 PM
mgorny added a reviewer for D40142: [cmake] Use llvm-lit directory when provided for stand-alone build: zturner.
Nov 17 2017, 1:58 PM
mgorny committed rL318532: [CMake] Allow for Solaris ld -V output on stdout.
[CMake] Allow for Solaris ld -V output on stdout
Nov 17 2017, 9:12 AM
mgorny closed D39601: [CMake] Allow for Solaris ld -V output on stdout by committing rL318532: [CMake] Allow for Solaris ld -V output on stdout.
Nov 17 2017, 9:12 AM
mgorny accepted D39601: [CMake] Allow for Solaris ld -V output on stdout.

I don't see how this could break anything, and it's a pretty straightforward change.

Nov 17 2017, 12:17 AM

Nov 16 2017

mgorny created D40142: [cmake] Use llvm-lit directory when provided for stand-alone build.
Nov 16 2017, 11:13 AM
mgorny added a comment to D39842: Allow to store precompiled preambles in memory..

Please revert this commit. You've just broken all the stand-alone builds of clang.

Nov 16 2017, 9:12 AM

Nov 15 2017

mgorny added a comment to D39939: [cmake] Allow appending a free-form suffix to SOVERSION.

I'm worried that having a different first component of VERSION and SOVERSION could confuse some tools like ldconfig. I'm going to see if we can solve it via different install prefixes with RPATHs first.

Nov 15 2017, 2:08 PM

Nov 14 2017

mgorny added a comment to D39939: [cmake] Allow appending a free-form suffix to SOVERSION.

Hmm, that's an interesting option too. I was thinking of using LLVM_VERSION_SUFFIX originally but it obviously did not go to SOVERSION. Can this have any unforeseen consequences? Should VERSION become *major+suffix-0-minor* then?

Nov 14 2017, 11:15 PM
mgorny added a comment to D39939: [cmake] Allow appending a free-form suffix to SOVERSION.

We = Gentoo. What for is already described = to install libstdc++ and libc++ versions of LLVM simultaneously for rebuild period. How long = for the time being, or until we find a better working solution.

Nov 14 2017, 12:00 AM

Nov 11 2017

mgorny committed rL317986: [python] [tests] Fix test_linkage for unique external linkage.
[python] [tests] Fix test_linkage for unique external linkage
Nov 11 2017, 12:01 PM
mgorny closed D39810: [python] [tests] Fix test_linkage for unique external linkage by committing rL317986: [python] [tests] Fix test_linkage for unique external linkage.
Nov 11 2017, 12:01 PM
mgorny created D39939: [cmake] Allow appending a free-form suffix to SOVERSION.
Nov 11 2017, 4:54 AM
mgorny updated the diff for D39810: [python] [tests] Fix test_linkage for unique external linkage.

Yay, I've found a way to get the desired linkage! ;-)

Nov 11 2017, 1:47 AM

Nov 10 2017

mgorny added a comment to D39161: [bindings] remove unique_external test failure.

I've rewritten the tests to use unittest, so this patch needs to be updated now. However, you may want to wait a while since @compnerd promised to look at it and he might have a way to get uniqueExternal() linkage.

Nov 10 2017, 8:55 AM
mgorny committed rL317897: [python] [tests] Rewrite to use standard unittest module.
[python] [tests] Rewrite to use standard unittest module
Nov 10 2017, 8:45 AM
mgorny closed D39763: [clang] [python] [tests] Rewrite to use standard unittest module by committing rL317897: [python] [tests] Rewrite to use standard unittest module.
Nov 10 2017, 8:45 AM
mgorny added a comment to D39763: [clang] [python] [tests] Rewrite to use standard unittest module.

Thanks. I'll update it to incorporate the lately committed test fixes, and push it later today.

Nov 10 2017, 8:11 AM

Nov 9 2017

mgorny added reviewers for D39161: [bindings] remove unique_external test failure: jbcoe, aaron.ballman.

Let's try some more reviewers.

Nov 9 2017, 12:30 PM
mgorny committed rL317828: [python] [tests] Update priority values in code completion test.
[python] [tests] Update priority values in code completion test
Nov 9 2017, 12:18 PM
mgorny closed D39838: [clang] [python] [tests] Update priority values in code completion test by committing rL317828: [python] [tests] Update priority values in code completion test.
Nov 9 2017, 12:18 PM
mgorny added a comment to D39838: [clang] [python] [tests] Update priority values in code completion test.

LGTM.

Can we run those tests as part of check-all cmake target or setup a buildbot that runs those? Seems surprising it went unnoticed for so long.

Nov 9 2017, 12:05 PM
mgorny created D39838: [clang] [python] [tests] Update priority values in code completion test.
Nov 9 2017, 5:29 AM

Nov 8 2017

mgorny added a comment to D39804: [clang] [python] [tests] Update TLSKind tests for newer MSVC versions.

I see that you haven't more luck than I did finding a better solution. How about the code completion failure? I suppose I still have to figure that one out on my own ;-).

Nov 8 2017, 11:15 AM
mgorny abandoned D39810: [python] [tests] Fix test_linkage for unique external linkage.

Duplicate of D39161.

Nov 8 2017, 11:13 AM
mgorny created D39810: [python] [tests] Fix test_linkage for unique external linkage.
Nov 8 2017, 10:49 AM
mgorny added a comment to D39804: [clang] [python] [tests] Update TLSKind tests for newer MSVC versions.

@frutiger, do you maybe happen to have fixes for the two other test failures? Maybe I'm tracking them down unnecessarily ;-).

Nov 8 2017, 10:25 AM
mgorny created D39804: [clang] [python] [tests] Update TLSKind tests for newer MSVC versions.
Nov 8 2017, 8:12 AM

Nov 7 2017

mgorny added a comment to D39763: [clang] [python] [tests] Rewrite to use standard unittest module.
======================================================================
FAIL: tests.cindex.test_code_completion.test_code_complete_availability
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/usr/src/llvm/tools/clang/bindings/python/tests/cindex/test_code_completion.py", line 75, in test_code_complete_availability
    check_completion_results(cr, expected)
  File "/usr/src/llvm/tools/clang/bindings/python/tests/cindex/test_code_completion.py", line 10, in check_completion_results
    assert c in completions
AssertionError
Nov 7 2017, 3:07 PM
mgorny added a comment to D39763: [clang] [python] [tests] Rewrite to use standard unittest module.

The diffs aren't very useful since I had to add a class for each test unit and so everything needed reindenting. You can take my word that changes boil down to:

Nov 7 2017, 3:05 PM
mgorny updated the summary of D39763: [clang] [python] [tests] Rewrite to use standard unittest module.
Nov 7 2017, 3:00 PM
mgorny updated the summary of D39763: [clang] [python] [tests] Rewrite to use standard unittest module.
Nov 7 2017, 2:59 PM
mgorny created D39763: [clang] [python] [tests] Rewrite to use standard unittest module.
Nov 7 2017, 2:59 PM

Nov 2 2017

mgorny added inline comments to D39464: Define fs::allocate_file which preallocates disk blocks..
Nov 2 2017, 1:53 PM
mgorny added inline comments to D39464: Define fs::allocate_file which preallocates disk blocks..
Nov 2 2017, 1:37 PM
mgorny added inline comments to D39464: Define fs::allocate_file which preallocates disk blocks..
Nov 2 2017, 12:14 PM

Nov 1 2017

mgorny added inline comments to D39464: Define fs::allocate_file which preallocates disk blocks..
Nov 1 2017, 12:55 AM

Oct 31 2017

mgorny added inline comments to D39464: Define fs::allocate_file which preallocates disk blocks..
Oct 31 2017, 4:15 PM

Oct 25 2017

mgorny requested changes to D37326: Fix the OCaml external linking problem.
Oct 25 2017, 2:29 AM

Oct 17 2017

mgorny added inline comments to D37326: Fix the OCaml external linking problem.
Oct 17 2017, 8:06 AM

Oct 12 2017

mgorny committed rL315620: [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.
[cmake] [asan] Remove unnecessary gtest dep from dynamic tests
Oct 12 2017, 2:07 PM
mgorny closed D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests by committing rL315620: [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.
Oct 12 2017, 2:07 PM
mgorny updated the diff for D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.

Ok, here's another idea. Since the objects have been compiled already (and they explicitly depend on gtest via their own deps), let's just remove the extraneous gtest dep.

Oct 12 2017, 12:31 PM
mgorny committed rL315605: [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS.
[cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS
Oct 12 2017, 11:52 AM
mgorny committed rL315604: [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile().
[cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()
Oct 12 2017, 11:52 AM
mgorny closed D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS by committing rL315605: [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS.
Oct 12 2017, 11:51 AM
mgorny closed D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile() by committing rL315604: [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile().
Oct 12 2017, 11:51 AM
mgorny added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

D38838 addresses the typo. Now that I know how it's supposed to work, D38839 and D38840 address the issues, and fix it for me.

Oct 12 2017, 1:54 AM
mgorny created D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.
Oct 12 2017, 1:50 AM
mgorny created D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS.
Oct 12 2017, 1:47 AM
mgorny created D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile().
Oct 12 2017, 1:46 AM
mgorny abandoned D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

Ok, I think I've found a better solution. Will start submitting patches soonish.

Oct 12 2017, 1:44 AM
mgorny added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

@mgorny I've replied via email, but the message didn't seem to appear here.

From my (maybe limited) understanding, running tests on standalone compiler-rt builds was never something which was supported, as that required a fresh compiler.
I've just tried running them, and for me even check-* targets don't exist.

How do you create the standalone build? I've checked out compiler-rt separately, and ran

cmake -GNinja -DLLVM_CONFIG=/Users/george/code/llvm/release-build/bin/llvm-config  ../.
Oct 12 2017, 12:20 AM

Oct 2 2017

mgorny added a comment to D38471: Allow compiler-rt test targets to work with multi-config CMake generators.

Yes, I did apply it both to the installed CMake files and the external LLVM source tree used by compiler-rt. I can't see where else it could have gotten an old version from, and I don't grep any AddLLVM includes either.

Oct 2 2017, 2:13 PM
mgorny added a comment to D38471: Allow compiler-rt test targets to work with multi-config CMake generators.

Well, I think I did everything right, yet I still get:

Oct 2 2017, 1:19 PM
mgorny added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

breaking stand-alone builds as a result

That's a strong statement. Could you clarify? We have a lot of buildbots performing standalone builds, and they are still green.

Oct 2 2017, 12:57 PM
mgorny added a comment to D38471: Allow compiler-rt test targets to work with multi-config CMake generators.

Could you give me a few minutes to test it before merging, please?

Oct 2 2017, 12:55 PM

Oct 1 2017

mgorny committed rL314646: [cmake] Add a separate CMake var to control profile runtime.
[cmake] Add a separate CMake var to control profile runtime
Oct 1 2017, 10:05 PM
mgorny closed D38441: [compiler-rt] [cmake] Add a separate CMake var to control profile runtime by committing rL314646: [cmake] Add a separate CMake var to control profile runtime.
Oct 1 2017, 10:05 PM
mgorny created D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.
Oct 1 2017, 4:28 AM
mgorny added reviewers for D38441: [compiler-rt] [cmake] Add a separate CMake var to control profile runtime: chapuni, beanz.
Oct 1 2017, 1:45 AM
mgorny committed rL314620: [lit] Fix running lit tests in unconfigured source dir.
[lit] Fix running lit tests in unconfigured source dir
Oct 1 2017, 12:15 AM
mgorny closed D38442: [lit] Fix running lit tests in unconfigured source dir by committing rL314620: [lit] Fix running lit tests in unconfigured source dir.
Oct 1 2017, 12:15 AM