mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (44 w, 6 d)

Recent Activity

Mon, Jun 19

mgorny created D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.
Mon, Jun 19, 2:06 PM

Mon, Jun 5

mgorny committed rL304715: [test] Fix baremetal test to allow any -resource-dir.
[test] Fix baremetal test to allow any -resource-dir
Mon, Jun 5, 7:14 AM
mgorny closed D33877: [test] Fix baremetal test to allow any -resource-dir by committing rL304715: [test] Fix baremetal test to allow any -resource-dir.
Mon, Jun 5, 7:14 AM

Sun, Jun 4

mgorny created D33877: [test] Fix baremetal test to allow any -resource-dir.
Sun, Jun 4, 3:36 AM

Sat, Jun 3

mgorny added a comment to D33259: Don't defer to the GCC driver for linking arm-baremetal.

This causes a test failure with non-standard CLANG_RESOURCE_DIR:

Sat, Jun 3, 12:43 PM

Wed, May 31

mgorny added a comment to D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang.

(note that I don't mind removing the llvm-config bit for it; but we need the cache variable to stay)

Wed, May 31, 12:10 PM
mgorny added a comment to D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang.

This is going to break Gentoo. We're relying on the ability to specify LLVM_MAIN_SRC_DIR to provide unpacked LLVM sources with gtest. Without that, I don't see how we can use tests.

Wed, May 31, 12:08 PM

Apr 26 2017

mgorny committed rL301387: [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on.
[test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on
Apr 26 2017, 12:48 AM
mgorny closed D32489: [compiler-rt] [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on by committing rL301387: [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on.
Apr 26 2017, 12:48 AM

Apr 25 2017

mgorny created D32489: [compiler-rt] [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on.
Apr 25 2017, 8:00 AM

Apr 14 2017

mgorny added a comment to D31996: Make Gentoo GNU GCC Config override whitespace tolerant.

Well, I've just checked gcc-config sources and it seems that it sources the file through bash, and gets the resulting ${CURRENT}. While I don't think we ought to do complete bash support here, I guess allowing the same degree of whitespace bash does makes sense.

Apr 14 2017, 8:51 AM
mgorny accepted D31996: Make Gentoo GNU GCC Config override whitespace tolerant.

Is there any specific reason you need this? Since the file is autogenerated, I don't think it matters very much to allow extra whiespace. But then, I do not think it hurts, so feel free to do it. The code LGTM; note that I haven't tested it, however.

Apr 14 2017, 7:22 AM

Apr 13 2017

mgorny abandoned D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.

D31864 covered all that was needed for Gentoo, and I lack the knowledge to push the full split properly forward.

Apr 13 2017, 9:34 AM

Apr 8 2017

mgorny committed rL299813: [cmake] Support Gentoo install for z3.
[cmake] Support Gentoo install for z3
Apr 8 2017, 7:51 AM
mgorny closed D31756: [cmake] Support Gentoo install for z3 by committing rL299813: [cmake] Support Gentoo install for z3.
Apr 8 2017, 7:50 AM

Apr 6 2017

mgorny created D31756: [cmake] Support Gentoo install for z3.
Apr 6 2017, 5:38 AM

Apr 4 2017

mgorny added a comment to D31617: [CMake][libcxx] Use builtins rather than gcc_s when compiler-rt is requested.

See also: D25568. It served the same goal, except that it didn't require the user to explicitly indicate which runtime is enabled in his compiler (i.e. supported clang with compiler-rt by default out of the box). I'm not sure if having both makes sense now; however, I feel like having to figure out whether the compiler is using compiler-rt or libgcc and setting flags appropriately would kinda suck.

Apr 4 2017, 11:10 PM
mgorny added a comment to D31687: CMake: Fix sphinx build with standalone clang.

See also: D23758, for SphInx + doxygen + relevant options.

Apr 4 2017, 11:06 PM
mgorny added a comment to D31367: Expression: add missing linkage to RuntimeDyld component.

Well, I can confirm that the hack works for me. Not that I like it but if it's meant to be only temporary, I'm fine with any solution that works.

Apr 4 2017, 10:54 AM · Restricted Project

Mar 30 2017

mgorny added a comment to D31367: Expression: add missing linkage to RuntimeDyld component.

Please revert your patch. It is *not* the right solution and is masking underlying problems.

Mar 30 2017, 11:41 AM · Restricted Project
mgorny committed rL299095: Revert r298776 - Expression: add missing linkage to RuntimeDyld ....
Revert r298776 - Expression: add missing linkage to RuntimeDyld ...
Mar 30 2017, 11:36 AM
mgorny added a comment to D31367: Expression: add missing linkage to RuntimeDyld component.

We don't depend on the RuntimeDyld component of llvm directy -- we only use it indirectly through the ExecutionEngine component. Shouldn't that be reflected as a dependency in the build system somehow, so that the former can be pulled in directly ?
RuntimeDyld is listed as a dependency of ExecutionEngine in lib/ExecutionEngine/LLVMBuild.txt, but that does not seem to be reflected in the cmake? Is that a bug on the llvm side?

Mar 30 2017, 7:13 AM · Restricted Project

Mar 29 2017

mgorny added inline comments to D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.
Mar 29 2017, 11:39 AM
mgorny added reviewers for D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests: weimingz, compnerd.
Mar 29 2017, 8:25 AM
mgorny updated the diff for D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.

Needed to rebase again.

Mar 29 2017, 12:00 AM

Mar 28 2017

mgorny added inline comments to D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.
Mar 28 2017, 11:59 PM
mgorny updated the diff for D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.

Rebased. Ping. Now that we have lit tests for builtins, it would be really useful for us to be able to build them without having to enable sanitizers.

Mar 28 2017, 2:06 PM

Mar 25 2017

mgorny committed rL298777: PluginUnwindAssemblyX86: add missing linkage to MCDisasm.
PluginUnwindAssemblyX86: add missing linkage to MCDisasm
Mar 25 2017, 12:04 PM
mgorny committed rL298776: Expression: add missing linkage to RuntimeDyld component.
Expression: add missing linkage to RuntimeDyld component
Mar 25 2017, 12:04 PM
mgorny closed D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm by committing rL298777: PluginUnwindAssemblyX86: add missing linkage to MCDisasm.
Mar 25 2017, 12:04 PM · Restricted Project
mgorny closed D31367: Expression: add missing linkage to RuntimeDyld component by committing rL298776: Expression: add missing linkage to RuntimeDyld component.
Mar 25 2017, 12:03 PM · Restricted Project
mgorny created D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm.
Mar 25 2017, 7:02 AM · Restricted Project
mgorny created D31367: Expression: add missing linkage to RuntimeDyld component.
Mar 25 2017, 6:53 AM · Restricted Project

Mar 23 2017

mgorny added a reviewer for D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used: hfinkel.
Mar 23 2017, 10:27 AM
mgorny added a dependent revision for D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used: D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.
Mar 23 2017, 10:26 AM
mgorny added a dependency for D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin: D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Mar 23 2017, 10:26 AM
mgorny reopened D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.

Reopening since it has been reverted.

Mar 23 2017, 10:25 AM
mgorny added a reviewer for D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build: beanz.
Mar 23 2017, 10:23 AM · Restricted Project

Mar 17 2017

mgorny added a comment to D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.

@mgorny, we should only support this on shared libraries that we intend as vended libraries, not all libraries. For example we don't really want to support the CMake BUILD_SHARED_LIBS option's libraries as vended libraries on any platform.

Mar 17 2017, 11:55 PM

Mar 16 2017

mgorny added a comment to D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.
  1. Any reason not to use this for all shared libraries?
  2. AFAICS --default-symver is present on FreeBSD as well.
Mar 16 2017, 12:09 AM

Mar 14 2017

mgorny committed rL297807: [llvm-config] Add minimal sanity tests for path options.
[llvm-config] Add minimal sanity tests for path options
Mar 14 2017, 11:09 PM
mgorny closed D28533: [llvm-config] Add minimal sanity tests for path options by committing rL297807: [llvm-config] Add minimal sanity tests for path options.
Mar 14 2017, 11:09 PM
mgorny committed rL297806: [test] Fix test dependencies when using installed tools.
[test] Fix test dependencies when using installed tools
Mar 14 2017, 11:07 PM
mgorny closed D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools by committing rL297806: [test] Fix test dependencies when using installed tools.
Mar 14 2017, 11:07 PM · Restricted Project

Mar 11 2017

mgorny added inline comments to D30773: Make git-clang-format python 3 compatible.
Mar 11 2017, 3:10 AM
mgorny added a comment to D30733: [Driver] Add arch-specific rpath for libc++.

I'm sorry, I've completely forgot that the path contains version number. In this case, it indeed probably doesn't make much sense to add rpath for that.

Mar 11 2017, 1:07 AM

Mar 10 2017

mgorny added inline comments to D30773: Make git-clang-format python 3 compatible.
Mar 10 2017, 11:35 PM
mgorny added a comment to D24921: [cfe] [Headers] Fix inttypes.h macros visibility in C++ with C99-compliant libc.

Ping II.

Mar 10 2017, 11:41 AM
mgorny added a comment to D28533: [llvm-config] Add minimal sanity tests for path options.

@beanz, a little more of a ping since you've specifically asked for it ;-).

Mar 10 2017, 11:41 AM
mgorny added a comment to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

A gentle ping.

Mar 10 2017, 11:40 AM
mgorny added a comment to D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools.

PIng.

Mar 10 2017, 11:39 AM · Restricted Project
mgorny added a comment to D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.

Ping.

Mar 10 2017, 11:39 AM · Restricted Project
mgorny added a comment to D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

Another ping. Since 4.0.0 final has been tagged, I think we should get back to working on this. @compnerd, any suggestion how to proceed here?

Mar 10 2017, 11:30 AM
mgorny added a comment to D30802: [Builtin] Implement lit-test support (part 1 of 2: test cases update).

First of all, thank you for doing this! This was long overdue ;-).

Mar 10 2017, 6:52 AM

Mar 9 2017

mgorny added inline comments to D30773: Make git-clang-format python 3 compatible.
Mar 9 2017, 8:10 AM

Mar 8 2017

mgorny added a comment to D30773: Make git-clang-format python 3 compatible.

There seem to be a couple cases where it's non-trivial to convert the output from bytes to str. I'll look into this further and update.

Mar 8 2017, 11:22 PM
mgorny added a comment to D30668: Add llvm::sys::fs::real_path.

I'm sorry but what is the exact use case for this? I'm not exactly against having a function like this but 'realpath' logic is the kind of thing people frequently abuse, so I'd rather make sure we don't end up accidentally replacing 'canonical' paths provided by the user with 'real' paths.

Mar 8 2017, 11:17 PM
mgorny added a comment to D25402: [Driver] Pass -lunwind along with compiler-rt when necessary on Linux.

@compnerd, I presume that the option would do nothing when using -rtlib=libgcc, correct? Or do we support combining libgcc with another unwinder?

Mar 8 2017, 1:29 PM

Feb 24 2017

mgorny committed rL296183: [test] Try to link -latomic to provide atomics when available.
[test] Try to link -latomic to provide atomics when available
Feb 24 2017, 2:27 PM
mgorny closed D30083: [openmp] [test] Try to link -latomic to provide atomics when available by committing rL296183: [test] Try to link -latomic to provide atomics when available.
Feb 24 2017, 2:27 PM
mgorny added a reviewer for D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC: doug.gregor.

If I read the git correctly, the change that forbid defining builtins was initially made in rL64639. @doug.gregor, any chance you could help us over here? Is clang supposed to unconditionally reject those definitions, and are we supposed to always work-around it in compiler-rt, or should we consider adding some additional switch to allow them in clang?

Feb 24 2017, 11:29 AM
mgorny added a comment to D30083: [openmp] [test] Try to link -latomic to provide atomics when available.

Le gentle ping.

Feb 24 2017, 11:19 AM

Feb 23 2017

mgorny added inline comments to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.
Feb 23 2017, 9:32 PM

Feb 22 2017

mgorny committed rL295854: [Support] Provide linux/magic.h fallback for older kernels.
[Support] Provide linux/magic.h fallback for older kernels
Feb 22 2017, 10:21 AM
mgorny closed D30261: [Support] Provide linux/magic.h fallback for older kernels by committing rL295854: [Support] Provide linux/magic.h fallback for older kernels.
Feb 22 2017, 10:21 AM
mgorny created D30261: [Support] Provide linux/magic.h fallback for older kernels.
Feb 22 2017, 9:12 AM

Feb 19 2017

mgorny committed rL295621: [test] Fix finding LLDB tools when building stand-alone.
[test] Fix finding LLDB tools when building stand-alone
Feb 19 2017, 2:23 PM
mgorny closed D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone by committing rL295621: [test] Fix finding LLDB tools when building stand-alone.
Feb 19 2017, 2:23 PM · Restricted Project
mgorny created D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.
Feb 19 2017, 5:37 AM · Restricted Project

Feb 17 2017

mgorny accepted D30015: Add arch-specific directory to search path.

LGTM modulo the test match split. But please wait for someone who has been longer here to confirm.

Feb 17 2017, 2:39 PM
mgorny added inline comments to D30092: CMake: Clean up VersionFromVCS.cmake.
Feb 17 2017, 7:28 AM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 17 2017, 2:12 AM
mgorny created D30083: [openmp] [test] Try to link -latomic to provide atomics when available.
Feb 17 2017, 2:03 AM

Feb 16 2017

mgorny added a comment to D30015: Add arch-specific directory to search path.

Thanks. The -L tests look good, -rpath is not perfect but I don't think you can improve it without additional changes to the Driver.

Feb 16 2017, 11:37 PM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 16 2017, 2:14 PM
mgorny added a comment to D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone.

Following @labath's suggestion, I've changed my approach a little. Now I'm using PATH lookup only for CC/CXX, while for remaining tools I'm using either llvm_tools_dir or lldb_tools_dir appropriately.

Feb 16 2017, 1:03 PM · Restricted Project
mgorny updated the diff for D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone.
Feb 16 2017, 1:02 PM · Restricted Project
mgorny added a comment to D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC.

This code is working around something that's probably a clang bug. It would be better to fix the clang bug than add more complex workarounds.

Feb 16 2017, 4:30 AM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 16 2017, 12:05 AM
mgorny added inline comments to D30015: Add arch-specific directory to search path.
Feb 16 2017, 12:03 AM

Feb 15 2017

mgorny created D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC.
Feb 15 2017, 11:14 PM
mgorny added a reviewer for D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone: labath.
Feb 15 2017, 10:27 AM · Restricted Project
mgorny added a comment to D29185: [lit] Allow llvm's build and test systems to support paths with spaces.

I would like to point out that if you proactively reject all paths with spaces, you wouldn't be able to add additional tests that would test support for paths with spaces ;-). While I agree that we should avoid spaces whenever possible, I think it would be reasonable to add tests for paths with spaces wherever we expect them to be well-supported and want to avoid regressions.

Feb 15 2017, 5:04 AM
mgorny created D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone.
Feb 15 2017, 4:57 AM · Restricted Project
mgorny abandoned D28862: [compiler-rt] [test] Use approximate comparison on float types.

I've opened http://bugs.llvm.org/show_bug.cgi?id=31964 to track this further. I don't really have time to look into it in more detail at the moment.

Feb 15 2017, 2:35 AM

Feb 13 2017

mgorny added a comment to D28533: [llvm-config] Add minimal sanity tests for path options.

Ping.

Feb 13 2017, 7:51 AM
mgorny added a comment to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used.

Le gentle ping.

Feb 13 2017, 7:51 AM

Feb 10 2017

mgorny created D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools.
Feb 10 2017, 2:39 PM · Restricted Project

Feb 8 2017

mgorny committed rL294508: [test] Fix zlib cond when building stand-alone, clean up.
[test] Fix zlib cond when building stand-alone, clean up
Feb 8 2017, 12:20 PM
mgorny closed D29340: [lld] [test] Fix zlib cond when building stand-alone, clean up by committing rL294508: [test] Fix zlib cond when building stand-alone, clean up.
Feb 8 2017, 12:20 PM · lld
mgorny committed rL294507: [test] Use LLD-specific binary&library dirs when building stand-alone.
[test] Use LLD-specific binary&library dirs when building stand-alone
Feb 8 2017, 12:19 PM
mgorny closed D29335: [lld] [test] Use LLD-specific binary&library dirs when building stand-alone by committing rL294507: [test] Use LLD-specific binary&library dirs when building stand-alone.
Feb 8 2017, 12:19 PM · lld
mgorny committed rL294438: [test] #ifdef new builtin tests for __arm__ platform.
[test] #ifdef new builtin tests for __arm__ platform
Feb 8 2017, 4:14 AM
mgorny closed D29708: [compiler-rt] [test] #ifdef new builtin tests for __arm__ platform by committing rL294438: [test] #ifdef new builtin tests for __arm__ platform.
Feb 8 2017, 4:14 AM
mgorny committed rL294431: [test] Fix hard_link_count test to account for fs with dir nlink==1.
[test] Fix hard_link_count test to account for fs with dir nlink==1
Feb 8 2017, 2:09 AM
mgorny closed D29706: [libcxx] [test] Fix hard_link_count test to account for fs with dir nlink==1 by committing rL294431: [test] Fix hard_link_count test to account for fs with dir nlink==1.
Feb 8 2017, 2:08 AM
mgorny created D29708: [compiler-rt] [test] #ifdef new builtin tests for __arm__ platform.
Feb 8 2017, 2:05 AM
mgorny created D29706: [libcxx] [test] Fix hard_link_count test to account for fs with dir nlink==1.
Feb 8 2017, 1:37 AM
mgorny committed rL294425: [test] Enable the strace_test only if strace is installed.
[test] Enable the strace_test only if strace is installed
Feb 8 2017, 12:55 AM
mgorny closed D29628: [compiler-rt] [test] Enable the strace_test only if strace is installed by committing rL294425: [test] Enable the strace_test only if strace is installed.
Feb 8 2017, 12:55 AM