mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (53 w, 1 d)

Recent Activity

Yesterday

mgorny added a comment to D36980: [LLVM] Moving libFuzzer from LLVM to compiler-rt.

Shouldn't the title be the other way around?

Mon, Aug 21, 2:10 PM
mgorny added a comment to D36908: Moving libFuzzer to compiler-rt.

Ok, the first thing that I've noticed is that the compiler-rt version does not build with gcc:

@mgorny this is actually due to change proposed in https://reviews.llvm.org/D36887.
I am not sure what is the correct strategy here: previously, the flag was behind the guard, which was never set for gcc.
I don't think it is correct to rely on LLVM_* variable from a compiler-rt repository.
I can also test whether the flag is available first before compiling.

Mon, Aug 21, 11:25 AM
mgorny committed rL311355: [unittests] Build LLVMTestingSupport for out-of-source builds.
[unittests] Build LLVMTestingSupport for out-of-source builds
Mon, Aug 21, 10:44 AM
mgorny committed rL311354: [cmake] Explicitly link dependency libraries in the Host library.
[cmake] Explicitly link dependency libraries in the Host library
Mon, Aug 21, 10:44 AM
mgorny closed D36886: [unittests] Build LLVMTestingSupport for out-of-source builds by committing rL311355: [unittests] Build LLVMTestingSupport for out-of-source builds.
Mon, Aug 21, 10:44 AM · Restricted Project
mgorny closed D36885: [cmake] Explicitly link dependency libraries in the Host library by committing rL311354: [cmake] Explicitly link dependency libraries in the Host library.
Mon, Aug 21, 10:43 AM · Restricted Project

Sat, Aug 19

mgorny added a comment to D36908: Moving libFuzzer to compiler-rt.

Ok, the first thing that I've noticed is that the compiler-rt version does not build with gcc:

Sat, Aug 19, 1:59 PM
mgorny added a comment to D36908: Moving libFuzzer to compiler-rt.

A side notice but wouldn't it be better to make libFuzzer a completely separate component (like openmp)? I've seen people take interest in it outside LLVM toolchain.

Sat, Aug 19, 12:29 AM
mgorny added inline comments to D36885: [cmake] Explicitly link dependency libraries in the Host library.
Sat, Aug 19, 12:08 AM · Restricted Project

Fri, Aug 18

mgorny created D36886: [unittests] Build LLVMTestingSupport for out-of-source builds.
Fri, Aug 18, 11:17 AM · Restricted Project
mgorny created D36885: [cmake] Explicitly link dependency libraries in the Host library.
Fri, Aug 18, 11:15 AM · Restricted Project

Thu, Aug 17

mgorny committed rL311122: [cmake] Add explicit linkage from Core to curses.
[cmake] Add explicit linkage from Core to curses
Thu, Aug 17, 1:35 PM
mgorny closed D36358: [lldb] [cmake] Add explicit linkage from Core to curses by committing rL311122: [cmake] Add explicit linkage from Core to curses.
Thu, Aug 17, 1:35 PM

Mon, Aug 14

mgorny added a comment to D36358: [lldb] [cmake] Add explicit linkage from Core to curses.

Ping.

Mon, Aug 14, 12:59 AM

Fri, Aug 11

mgorny requested changes to D36555: Move x86-specific sources to x86-specific source lists..

Also, I think that if you're splitting them up, it'd also logical to move them into a subdirectory, x86-common maybe.

Fri, Aug 11, 11:31 PM
mgorny committed rL310712: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.
[cmake] Expose the dependencies of ExecutionEngine as PUBLIC
Fri, Aug 11, 6:27 AM
mgorny closed D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC by committing rL310712: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.
Fri, Aug 11, 6:27 AM
mgorny added a comment to D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

No problem at all. Thanks a lot.

Fri, Aug 11, 6:27 AM
mgorny updated the diff for D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

Updated with @chapuni's patch. Please confirm it's good to go.

Fri, Aug 11, 6:12 AM

Sat, Aug 5

mgorny updated the diff for D36358: [lldb] [cmake] Add explicit linkage from Core to curses.

Updated to explicitly respect LLDB_DISABLE_CURSES and the LLVM HAVE_TERMINFO logic.

Sat, Aug 5, 1:49 PM
mgorny updated the diff for D36358: [lldb] [cmake] Add explicit linkage from Core to curses.

Forgive my poor eyesight, obviously this could go into existing LINK_LIBS ;-).

Sat, Aug 5, 9:15 AM
mgorny created D36358: [lldb] [cmake] Add explicit linkage from Core to curses.
Sat, Aug 5, 8:32 AM
mgorny added a comment to D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

@chapuni, this fixes the issue for me as well. Will you commit it or should I update this revision with your patch?

Sat, Aug 5, 2:57 AM
mgorny abandoned D31367: Expression: add missing linkage to RuntimeDyld component.
Sat, Aug 5, 2:54 AM · Restricted Project

Thu, Aug 3

mgorny committed rL309979: [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.
[test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build
Thu, Aug 3, 12:42 PM
mgorny closed D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build by committing rL309979: [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.
Thu, Aug 3, 12:42 PM · Restricted Project

Wed, Aug 2

mgorny reopened D31367: Expression: add missing linkage to RuntimeDyld component.

Well, @chapuni disagrees on D36211. Which way should we go then?

Wed, Aug 2, 1:26 AM · Restricted Project
mgorny added a reviewer for D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC: chapuni.
Wed, Aug 2, 1:09 AM
mgorny updated subscribers of D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

Well, that was my original idea but @beanz wanted it the other way around ;-). I'm fine either way, as long as it works.

Wed, Aug 2, 1:04 AM

Tue, Aug 1

mgorny created D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.
Tue, Aug 1, 11:12 PM

Sat, Jul 29

mgorny added a comment to D36026: [lit] Avoid copying llvm/utils/lit/tests/Inputs with lit site configs.

Well, I can confirm that it doesn't break running in place ;-).

Sat, Jul 29, 1:43 PM
mgorny added a comment to D35995: [OCaml] Install dynamic libraries in 'stubdirs' directory.

https://bugs.llvm.org/show_bug.cgi?id=33987 now open for that purpose.

Sat, Jul 29, 11:42 AM
mgorny added a comment to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

Yes, I've planned on doing that. https://bugs.llvm.org/show_bug.cgi?id=33987 now open for that purpose.

Sat, Jul 29, 11:41 AM
mgorny committed rL309483: [OCaml] Pass -D/-UNDEBUG through to ocamlc.
[OCaml] Pass -D/-UNDEBUG through to ocamlc
Sat, Jul 29, 1:11 AM
mgorny closed D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc by committing rL309483: [OCaml] Pass -D/-UNDEBUG through to ocamlc.
Sat, Jul 29, 1:11 AM
mgorny updated the diff for D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

Updated to only play with NDEBUG definitions.

Sat, Jul 29, 12:23 AM

Fri, Jul 28

mgorny committed rL309481: [OCaml] Install dynamic libraries in 'stubdirs' directory.
[OCaml] Install dynamic libraries in 'stubdirs' directory
Fri, Jul 28, 11:48 PM
mgorny closed D35995: [OCaml] Install dynamic libraries in 'stubdirs' directory by committing rL309481: [OCaml] Install dynamic libraries in 'stubdirs' directory.
Fri, Jul 28, 11:48 PM
mgorny added a comment to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

All right, I'll update it to tackle [-/][DU]NDEBUG and move on.

Fri, Jul 28, 11:44 PM
mgorny added a comment to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.
message(FATAL_ERROR "LLVM_OCAML_OUT_OF_TREE cannot be enabled while on Debug mode. Use -DCMAKE_BUILD_TYPE=Release instead.")

Why not just ignore CMAKE_C_COMPILER &c when building out of tree? What's the problem here exactly? This seems like an arbitrary restriction.

Fri, Jul 28, 3:12 PM
mgorny added a comment to D35995: [OCaml] Install dynamic libraries in 'stubdirs' directory.

I suppose both should work but I only tested with plain LD_LIBRARY_PATH.

Fri, Jul 28, 2:49 PM
mgorny added a comment to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

@jpdeplaix, well, I don't know how NDEBUG affects you but in Gentoo it's more complex. We wipe out the CMake defaults that play with NDEBUG and set it manually so that we don't need to depend on CMAKE_BUILD_TYPE to enable assertions&co.

Fri, Jul 28, 2:39 PM
mgorny created D35995: [OCaml] Install dynamic libraries in 'stubdirs' directory.
Fri, Jul 28, 7:08 AM
mgorny updated the diff for D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

v2: sets the compiler and with the flags so that we won't try to pass incorrect flags to another compiler. Since C compilers are reasonably compatible with each other, it shouldn't be a problem if OCaml was built with another.

Fri, Jul 28, 5:20 AM
mgorny requested review of D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.
Fri, Jul 28, 5:20 AM

Thu, Jul 27

mgorny planned changes to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.
Thu, Jul 27, 9:30 PM
mgorny reopened D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.

This broke some buildbots due to C compiler mismatch between OCaml and LLVM. Will have to think it over.

Thu, Jul 27, 9:30 PM
mgorny committed rL309364: Revert rL309320 - "[OCaml] Respect CMAKE_C_FLAGS for OCaml C files".
Revert rL309320 - "[OCaml] Respect CMAKE_C_FLAGS for OCaml C files"
Thu, Jul 27, 9:30 PM
mgorny added a reverting commit for rL309320: [OCaml] Respect CMAKE_C_FLAGS for OCaml C files: rL309364: Revert rL309320 - "[OCaml] Respect CMAKE_C_FLAGS for OCaml C files".
Thu, Jul 27, 9:30 PM
mgorny committed rL309321: [OCaml] Fix undefined reference to LLVMDumpType() with NDEBUG.
[OCaml] Fix undefined reference to LLVMDumpType() with NDEBUG
Thu, Jul 27, 2:15 PM
mgorny closed D35899: [OCaml] Fix undefined reference to LLVMDumpType() with NDEBUG by committing rL309321: [OCaml] Fix undefined reference to LLVMDumpType() with NDEBUG.
Thu, Jul 27, 2:15 PM
mgorny committed rL309320: [OCaml] Respect CMAKE_C_FLAGS for OCaml C files.
[OCaml] Respect CMAKE_C_FLAGS for OCaml C files
Thu, Jul 27, 2:15 PM
mgorny closed D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc by committing rL309320: [OCaml] Respect CMAKE_C_FLAGS for OCaml C files.
Thu, Jul 27, 2:15 PM
mgorny added inline comments to D35880: Un-revert "Teach the CMake build system to run lit's test suite. These can be run".
Thu, Jul 27, 11:05 AM
mgorny added a comment to rL309227: [lit] Fix race between shtest-shell and max-failures tests.

Well, I wanted to suggest creating completely separate test inputs for max-failures to avoid implicitly relying on the number of failures in shtest-shell but this works as well ;-).

Thu, Jul 27, 9:05 AM

Wed, Jul 26

mgorny updated the diff for D35899: [OCaml] Fix undefined reference to LLVMDumpType() with NDEBUG.
Wed, Jul 26, 10:18 AM
mgorny updated the diff for D35899: [OCaml] Fix undefined reference to LLVMDumpType() with NDEBUG.
Wed, Jul 26, 10:08 AM
mgorny added inline comments to D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.
Wed, Jul 26, 9:46 AM
mgorny added a comment to D35880: Un-revert "Teach the CMake build system to run lit's test suite. These can be run".

Well, I can't reproduce that one now but I've got another one. An easy way to reproduce:

Wed, Jul 26, 9:40 AM
mgorny created D35899: [OCaml] Fix undefined reference to LLVMDumpType() with NDEBUG.
Wed, Jul 26, 9:29 AM
mgorny created D35898: [OCaml] Pass -D/-UNDEBUG through to ocamlc.
Wed, Jul 26, 9:28 AM
mgorny added a comment to D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.

Another ping. @beanz, any chance you could take a look at this?

Wed, Jul 26, 7:50 AM · Restricted Project
mgorny added a comment to D34091: Support for querying the exception specification type through libclang.

This patch has introduced a test suite failure:

Wed, Jul 26, 7:43 AM
mgorny added inline comments to D28558: [CMake] Ignore hidden/metadata files when adding lit check-* testsuites.
Wed, Jul 26, 4:47 AM
mgorny resigned from D35879: [lit] Mark several of lit's tests XFAIL on Windows.

Technically LGTM but I don't have a Windows setup to test.

Wed, Jul 26, 4:43 AM
mgorny accepted D35880: Un-revert "Teach the CMake build system to run lit's test suite. These can be run".

The code looks good, and seems to work. I'm sometimes getting a failure from shtest-timeout.py but I suspect that's an irrelevant race condition.

Wed, Jul 26, 4:39 AM
mgorny accepted D35877: Revert "[lit] Remove dead code not referenced in the LLVM SVN repo.".

LGTM. I've confirmed that it fixes lit test suite, and no additional tests from the LLVM test suite fails (except the one that failed before applying the patch). I haven't tested other LLVM projects though.

Wed, Jul 26, 3:53 AM
mgorny accepted D35878: [lit] Fix type error for parallelism groups.

LGTM. I've confirmed that it fixes lit test suite, and no additional tests from the LLVM test suite fails (except the one that failed before applying the patch). I haven't tested other LLVM projects though.

Wed, Jul 26, 3:53 AM
mgorny added a comment to D31677: [lit] Use process pools for test execution by default.

Oh, I see there's D35878 supposedly addressing this. Sorry for missing it.

Wed, Jul 26, 1:28 AM
mgorny added a comment to D31677: [lit] Use process pools for test execution by default.

Thanks for the fix. Now it fails on another problem:

Wed, Jul 26, 1:24 AM
mgorny accepted D35867: Fix LIT test breakage.

Green on Linux as well. I suppose Windows will be broken but we can mark it appropriately when the buildbots are up and confirm.

Wed, Jul 26, 12:34 AM
mgorny added a comment to D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.

Ping.

Wed, Jul 26, 12:22 AM

Tue, Jul 25

mgorny added a comment to D34792: [lit] Remove dead code not referenced in the LLVM SVN repo..

I'm sorry, I was wrong. It breaks four tests:

Tue, Jul 25, 3:40 PM
mgorny committed rL309044: [lit] Fix UnboundLocalError for invalid shtest redirects.
[lit] Fix UnboundLocalError for invalid shtest redirects
Tue, Jul 25, 3:40 PM
mgorny closed D35857: [lit] Fix UnboundLocalError for invalid shtest redirects by committing rL309044: [lit] Fix UnboundLocalError for invalid shtest redirects.
Tue, Jul 25, 3:40 PM
mgorny added a comment to D35857: [lit] Fix UnboundLocalError for invalid shtest redirects.

Please do it. I've got my plate full. I'm going just to finish complaining on the patches that broke stuff and hopefully get some good out of that.

Tue, Jul 25, 3:37 PM
mgorny added a comment to D31677: [lit] Use process pools for test execution by default.

This commit breaks the unittest adaptor:

Tue, Jul 25, 3:26 PM
mgorny added a comment to D34792: [lit] Remove dead code not referenced in the LLVM SVN repo..

This broke two lit tests:

Tue, Jul 25, 3:10 PM
mgorny added a comment to D35091: Modify LIT to accept environment variable LIT_FILTER to select tests..

@mgorny I still can't run them:

  1. No class called FileBasedTest: where is it?
Tue, Jul 25, 3:02 PM
mgorny added a comment to D35091: Modify LIT to accept environment variable LIT_FILTER to select tests..

TBH I haven't been able to run tests: how did you do that? I've even opened a bug about this: https://bugs.llvm.org/show_bug.cgi?id=33704

Tue, Jul 25, 2:51 PM
mgorny added a comment to D35857: [lit] Fix UnboundLocalError for invalid shtest redirects.

Yes, I had a similar idea but I think we need to get the tests to pass first. Do you want me to continue bisecting bugs or are you planning to do some yourself? I've found one caused by D35091 but I don't see an obvious solution there, so any help would be appreciated.

Tue, Jul 25, 2:49 PM
mgorny updated subscribers of D35091: Modify LIT to accept environment variable LIT_FILTER to select tests..
Tue, Jul 25, 2:45 PM
mgorny added a comment to D35091: Modify LIT to accept environment variable LIT_FILTER to select tests..

I'm sorry to crash the party but the added test fails on Linux:

Tue, Jul 25, 2:45 PM
mgorny created D35857: [lit] Fix UnboundLocalError for invalid shtest redirects.
Tue, Jul 25, 2:35 PM

Jun 19 2017

mgorny created D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.
Jun 19 2017, 2:06 PM

Jun 5 2017

mgorny committed rL304715: [test] Fix baremetal test to allow any -resource-dir.
[test] Fix baremetal test to allow any -resource-dir
Jun 5 2017, 7:14 AM
mgorny closed D33877: [test] Fix baremetal test to allow any -resource-dir by committing rL304715: [test] Fix baremetal test to allow any -resource-dir.
Jun 5 2017, 7:14 AM

Jun 4 2017

mgorny created D33877: [test] Fix baremetal test to allow any -resource-dir.
Jun 4 2017, 3:36 AM

Jun 3 2017

mgorny added a comment to D33259: Don't defer to the GCC driver for linking arm-baremetal.

This causes a test failure with non-standard CLANG_RESOURCE_DIR:

Jun 3 2017, 12:43 PM

May 31 2017

mgorny added a comment to D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang.

(note that I don't mind removing the llvm-config bit for it; but we need the cache variable to stay)

May 31 2017, 12:10 PM
mgorny added a comment to D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang.

This is going to break Gentoo. We're relying on the ability to specify LLVM_MAIN_SRC_DIR to provide unpacked LLVM sources with gtest. Without that, I don't see how we can use tests.

May 31 2017, 12:08 PM

Apr 26 2017

mgorny committed rL301387: [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on.
[test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on
Apr 26 2017, 12:48 AM
mgorny closed D32489: [compiler-rt] [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on by committing rL301387: [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on.
Apr 26 2017, 12:48 AM

Apr 25 2017

mgorny created D32489: [compiler-rt] [test] Build sanitizer/xray tests only if COMPILER_RT_BUILD_* is on.
Apr 25 2017, 8:00 AM

Apr 14 2017

mgorny added a comment to D31996: Make Gentoo GNU GCC Config override whitespace tolerant.

Well, I've just checked gcc-config sources and it seems that it sources the file through bash, and gets the resulting ${CURRENT}. While I don't think we ought to do complete bash support here, I guess allowing the same degree of whitespace bash does makes sense.

Apr 14 2017, 8:51 AM
mgorny accepted D31996: Make Gentoo GNU GCC Config override whitespace tolerant.

Is there any specific reason you need this? Since the file is autogenerated, I don't think it matters very much to allow extra whiespace. But then, I do not think it hurts, so feel free to do it. The code LGTM; note that I haven't tested it, however.

Apr 14 2017, 7:22 AM

Apr 13 2017

mgorny abandoned D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests.

D31864 covered all that was needed for Gentoo, and I lack the knowledge to push the full split properly forward.

Apr 13 2017, 9:34 AM

Apr 8 2017

mgorny committed rL299813: [cmake] Support Gentoo install for z3.
[cmake] Support Gentoo install for z3
Apr 8 2017, 7:51 AM
mgorny closed D31756: [cmake] Support Gentoo install for z3 by committing rL299813: [cmake] Support Gentoo install for z3.
Apr 8 2017, 7:50 AM

Apr 6 2017

mgorny created D31756: [cmake] Support Gentoo install for z3.
Apr 6 2017, 5:38 AM