- User Since
- Aug 15 2016, 6:00 AM (301 w, 4 d)
Wed, May 25
Sat, May 21
Implemented vCtrlC packet and added a test for it.
Fri, May 20
Fix missing OK response for c/C/vCont/… packets.
Fri, May 13
Thu, May 5
Ah, sorry, now I see that a few other tests are also affected by this, so I guess something else has changed. Probably glibc upgrade once again :-(.
This one's failing for me on Gentoo. Apparently, the test executable outputs:
Thu, Apr 28
Could you also include checking llvm/utils/lit/lit/__init__.py while at it?
Apr 23 2022
For the record, we're using standalone builds on Gentoo and I don't think we need anything like this — we have to fetch the complete llvmorg tarball anyway, so we have no problem unpacking the header files from libunwind.
Apr 4 2022
Well, I don't see anything wrong with it and it doesn't seem to cause any regressions on FreeBSD. I wouldn't call myself an expert on this though.
Apr 1 2022
Used __builtin_ia32_crc32* along with -mcrc32 to fix compatibility with GCC.
@nikic, I'm sorry but I must have missed your communication to me about the problem. Could you please help me locate it?
Mar 31 2022
Mar 25 2022
Thanks. Technically, it looks good to me. However, I'd suggest waiting until Jannik is able to test it.
Mar 24 2022
Mar 14 2022
I'm sorry, my replacement PSU just arrived today and I'm slowly catching up with everything. I presume we don't need to worry about backwards compatibility, so LGTM.
Thanks for catching this!
Mar 3 2022
LGTM (but I cannot test)
Mar 2 2022
Mar 1 2022
Could you push it for me, please? My PC died yesterday and I won't have it fixed in the next few days.
Feb 26 2022
Feb 25 2022
Feb 23 2022
Ping. I'd like to try to backport the fixes to 14.x, so would be nice to get it sorted out before it goes out.
Feb 17 2022
Add another LIBCXX_CXX_ABI variant instead, as requested.
Feb 16 2022
Do you think this should be backported to 14.x? On one hand, it isn't exactly urgent, but it kinda sucks to require this unused dep for another release.
Feb 15 2022
Feb 14 2022
Heh, this possibility didn't even occur to me. I suppose the easiest way to check would be to remove ounit2, remove the lit restriction and see if tests still pass.
Feb 13 2022
That entry in lit.local.cfg.py makes lit mark all OCaml binding tests as unsupported if ounit is not present.
I'm not really using OCaml — I'm just maintaining LLVM in Gentoo, and since someone before me added the OCaml bindings, I just keep them working.
Feb 12 2022
When enabled, this seems to break a fair number of tests:
Feb 11 2022
I'm sorry about my tone and thank you for the explanation.
That said, I'm sorry but I'm confused. Could you explain in greater detail what are you doing? llvm-config doesn't sound like something you should use for cross-compiling.
Please upload patches generated with -U9999, so that Phabricator has the complete context to show.
Feb 10 2022
Thanks for the prompt review!
@vitalybuka, I suspect this might also fix the test on Android but I don't have an environment to test it.
@jberdine, you seem to be the only person touching OCaml "recently". Any chance you'd be able to review this?
For the record, I just want to say that this sucks a lot for Gentoo and I'm really unhappy with the recent trend of ignoring other people's effort and destroying their use cases for one's own convenience. But I guess I have to live with it. It's just sad how much effort I've wasted fixing things every time standalone builds were broken, and in the end the working code is being broken for the sake of preventing others from maintaining standalone builds. In the end, we'll manage but probably at the cost of preventing our users from installing GNU libunwind and libc++ simultaneously but I guess people using binary distros just don't care that could be a better way.
Feb 9 2022
Sounds like you're trying hard to make me step down from contributing to LLVM anymore.
Feb 7 2022
LLVMHello part LGTM. Dunno about the other part.
LGTM! Please request backport to 14.x once you've pushed it.
Thanks. Please give me an hour to test it.
Feb 6 2022
This breaks build of clang against system-installed LLVM:
Feb 2 2022
Thanks for all the reviews and helpful suggestions!
Removed the comment and added thread info-style status above siginfos.
Jan 28 2022
Add Thread::GetSiginfoValue() to perform baseline value construction, and limit SBThread::GetSiginfo() to wrapping that. Return errors via ValueObjectConstResult.
Jan 27 2022