- User Since
- Aug 15 2016, 6:00 AM (136 w, 14 h)
Thu, Mar 21
Now, the curious thing is that so far I have 2 more test failures with this. I'll investigate closer, maybe it's just flakiness.
Applied requested changes.
Thanks for the review. Addressed comments.
Covered more callsites.
Wed, Mar 20
Got rid of close() and fclose() wrapping, for now.
Hmm, I also see that LLVM has signal-safe Process::SafelyCloseFileDescriptor(). Should I use that, or just ignore potential issues with close()?
Tue, Mar 19
I'd also like to update the output of lldb-instr but I think that'd be better done in a separate patch.
Declare 'R' in unittest to fix build failure.
Hmm but the tests fail to build for me ;-). I'm going to update this shortly.
Correct rebase: account for LLDB_DISABLE_PYTHON removal correctly.
Ok, here's the complete version, rebased. Note that I've built it before rebasing, and it's going to take a while before I rebuild it.
Mon, Mar 18
Hmm, actually with that local R declaration I don't have to have an additional set of macros ;-).
Does this look right? I've added temporary *2 versions of the macros to make it build without having to port everything. If it looks fine, I'll go with other files.
Sat, Mar 16
Ok, here's my first attempt at moving stuff but I'm getting load of errors and I can't figure out what I need to do to get the right symbols.
Fri, Mar 15
Thu, Mar 14
Implemented @ruiu's suggestions.
Wed, Mar 13
Tue, Mar 12
Updated to use dedicated header checks, as requested by @krytarowski
Mon, Mar 11
Sun, Mar 10
Updated as requested by @krytarowski
This is causing build failures to some of our users: https://bugs.gentoo.org/674662
Sat, Mar 9
Fri, Mar 8
Thu, Mar 7
If you have to bundle a new hash, have you considered using one of the modern fast hashes (such as xxHash, CityHash, …)?
I've added one more test case, and added stop reason/signal checking for both threads. I think it's ready for review now.
Wed, Mar 6
This is still breaking NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/19339/steps/ninja%20build%20local/logs/stdio
Added two tests, more pending. Sadly, I wasn't able to reuse even the test cases since -nostdlib doesn't really work on NetBSD (resulting executables are not recognized as valid executables).
Updated to read PID and make unknown notes non-fatal.
I've attempted to rebase Kamil's patch against the current sources. Please note that this is not the final version; I'll add a test case and PID reading later.
Tue, Mar 5
Updated to make it all conditional to NetBSD, as discussed.
Mon, Mar 4
Sun, Mar 3
I'm not going to pursue this further.
Reverted in r355302. It seems that it is unreliable and sometimes evaluates to empty path, breaking clang.
Thanks. I'm going to retest/update it for master first.