Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (178 w, 4 d)

Recent Activity

Yesterday

mgorny accepted D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target.

Besides the mentioned misindent, the CMake code looks correct. Could you test whether it works with standalone (out-of-LLVM) builds as well?

Fri, Jan 17, 7:56 AM · Restricted Project, Restricted Project

Tue, Jan 14

mgorny added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

This broke NetBSD buildbot:

Tue, Jan 14, 6:07 AM · Restricted Project, Restricted Project

Mon, Jan 13

mgorny committed rG1ab13f8cc3f7: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths (authored by mgorny).
[clang] [test] Fix riscv-toolchain-extra to be less picky about paths
Mon, Jan 13, 7:09 PM
mgorny closed D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths.
Mon, Jan 13, 7:09 PM · Restricted Project
mgorny added a comment to D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths.

Thanks!

Mon, Jan 13, 7:09 PM · Restricted Project
mgorny created D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths.
Mon, Jan 13, 1:20 AM · Restricted Project

Sun, Jan 12

mgorny created D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT.
Sun, Jan 12, 2:09 PM · Restricted Project

Sat, Jan 11

mgorny raised a concern with rG61bd19206f61: [libc++] Explicitly enumerate std::string external instantiations..

Also older versions of gcc. This broke bootstrap on NetBSD: http://lab.llvm.org:8014/builders/netbsd-amd64/builds/771/steps/ninja%20build%20local/logs/stdio

Sat, Jan 11, 7:15 AM
mgorny abandoned D59249: [llvm] [Support] mallctl() is in malloc.h on NetBSD.
Sat, Jan 11, 7:15 AM · Restricted Project

Thu, Jan 9

mgorny added a comment to D72490: Fix cmake for zlib.

Is there a way to get the basename from ZLIB_LIBRARY by any chance? Not saying it's actually necessary, just wondering.

Thu, Jan 9, 10:02 PM · Restricted Project

Mon, Jan 6

mgorny committed rGbc763c42bbcf: [lldb] [Process/NetBSD] Remove unused orig_*ax use (authored by mgorny).
[lldb] [Process/NetBSD] Remove unused orig_*ax use
Mon, Jan 6, 8:12 AM
mgorny closed D72195: [lldb] [Process/NetBSD] Remove unused orig_*ax use.
Mon, Jan 6, 8:12 AM · Restricted Project

Fri, Jan 3

mgorny created D72195: [lldb] [Process/NetBSD] Remove unused orig_*ax use.
Fri, Jan 3, 8:39 PM · Restricted Project

Thu, Jan 2

mgorny added inline comments to D72107: [lldb/CMake] Autodetect Python dependency.
Thu, Jan 2, 11:03 PM · Restricted Project

Thu, Dec 26

mgorny accepted D71700: [compiler-rt] [netbsd] Add support for versioned statvfs interceptors.

LGTM, presuming you've tested it. If you need me to do a second test run, lemme know.

Thu, Dec 26, 10:43 AM · Restricted Project, Restricted Project

Fri, Dec 20

mgorny committed rGe73c662b9ea7: [compiler-rt] [test] Disable MPROTECT for XRay tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable MPROTECT for XRay tests on NetBSD
Fri, Dec 20, 1:26 PM
mgorny committed rG190b9110c23c: [compiler-rt] [test] Disable MPROTECT on two builtin tests (authored by mgorny).
[compiler-rt] [test] Disable MPROTECT on two builtin tests
Fri, Dec 20, 8:59 AM
mgorny closed D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests.
Fri, Dec 20, 8:59 AM · Restricted Project, Restricted Project
mgorny committed rGe1882af9f670: [libc++] Update feature list for NetBSD (authored by mgorny).
[libc++] Update feature list for NetBSD
Fri, Dec 20, 8:59 AM
mgorny closed D71511: [libc++] Update feature list for NetBSD.
Fri, Dec 20, 8:59 AM · Restricted Project

Thu, Dec 19

mgorny added inline comments to D71306: [RFC] Change how we deal with optional dependencies.
Thu, Dec 19, 8:49 PM · Restricted Project
mgorny committed rG20345707b2c9: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test (authored by mgorny).
[compiler-rt] [test] Add missing %run to fread_fwrite MSAN test
Thu, Dec 19, 11:34 AM
mgorny closed D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test.
Thu, Dec 19, 11:33 AM · Restricted Project, Restricted Project

Dec 19 2019

mgorny accepted D71306: [RFC] Change how we deal with optional dependencies.

Besides missing LZMA, looks good to me. However, I suspect you may want to wait for a second opinion ;-).

Dec 19 2019, 12:09 AM · Restricted Project

Dec 18 2019

mgorny committed rG4121399c1229: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP (authored by mgorny).
[clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP
Dec 18 2019, 1:41 PM
mgorny closed D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP.
Dec 18 2019, 1:41 PM · Restricted Project
mgorny created D71674: [clang-tools-extra] Fix linking dylib for LLVMFrontendOpenMP.
Dec 18 2019, 1:22 PM · Restricted Project
mgorny added inline comments to D71306: [RFC] Change how we deal with optional dependencies.
Dec 18 2019, 1:03 PM · Restricted Project
mgorny added inline comments to D71306: [RFC] Change how we deal with optional dependencies.
Dec 18 2019, 12:14 PM · Restricted Project
mgorny requested changes to D71306: [RFC] Change how we deal with optional dependencies.
Dec 18 2019, 10:56 AM · Restricted Project
mgorny committed rGd3d1ca14ced3: [compiler-rt] [test] Disable ASLR on UBSAN+[AMT]SAN tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable ASLR on UBSAN+[AMT]SAN tests on NetBSD
Dec 18 2019, 8:23 AM
mgorny committed rG9102a59084fd: [compiler-rt] [test] Disable ASLR on LSAN+ASAN tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable ASLR on LSAN+ASAN tests on NetBSD
Dec 18 2019, 8:23 AM
mgorny committed rGd372576d8a3b: [compiler-rt] [test] Disable ASLR for fuzzer tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable ASLR for fuzzer tests on NetBSD
Dec 18 2019, 7:54 AM
mgorny committed rG6207b060ad80: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir (authored by mgorny).
[clang] [cmake] Fix gen_ast_dump_json_test.py binary dir
Dec 18 2019, 7:48 AM
mgorny closed D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir.
Dec 18 2019, 7:48 AM · Restricted Project

Dec 17 2019

mgorny created D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test.
Dec 17 2019, 12:54 PM · Restricted Project, Restricted Project
mgorny updated the diff for D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests.

Switch to using %run_nomprotect instead of extra %paxctl. This should be more consistent and should avoid potential issues with : on Windows.

Dec 17 2019, 11:36 AM · Restricted Project, Restricted Project
mgorny created D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir.
Dec 17 2019, 9:14 AM · Restricted Project
mgorny added a comment to D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully.

I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems.

Dec 17 2019, 8:53 AM · Restricted Project
mgorny created D71613: [cmake] Use 'llvm-config --components' to determine components.
Dec 17 2019, 8:53 AM · Restricted Project, Restricted Project

Dec 14 2019

mgorny raised a concern with rGd09e811cb4da: [gen_ast_dump_json_test.py] Copy to binary directory to omit --clang argument.
Dec 14 2019, 12:45 PM
mgorny created D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests.
Dec 14 2019, 8:10 AM · Restricted Project, Restricted Project
mgorny created D71511: [libc++] Update feature list for NetBSD.
Dec 14 2019, 5:26 AM · Restricted Project

Dec 13 2019

mgorny added inline comments to D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON.
Dec 13 2019, 1:19 PM · Restricted Project
mgorny added a comment to D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary.

I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.

This seems to be a very serious limitation. I have difficult to understand how such limitation could exist at all, but I think this should be straightforward to fix.

Dec 13 2019, 1:00 PM · Restricted Project
mgorny added inline comments to D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON.
Dec 13 2019, 12:51 PM · Restricted Project
mgorny added inline comments to D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON.
Dec 13 2019, 12:33 PM · Restricted Project

Dec 12 2019

mgorny added a comment to D58892: [ELF] Split RW PT_LOAD on the PT_GNU_RELRO boundary.

I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.

Dec 12 2019, 11:10 PM · Restricted Project
mgorny committed rG4c6c1d0f4371: [clang] [test] Disable the test exhausting stack on NetBSD (authored by mgorny).
[clang] [test] Disable the test exhausting stack on NetBSD
Dec 12 2019, 3:56 PM
mgorny closed D71419: [clang] [test] Disable the test exhausting stack on NetBSD.
Dec 12 2019, 3:56 PM · Restricted Project
mgorny created D71419: [clang] [test] Disable the test exhausting stack on NetBSD.
Dec 12 2019, 6:27 AM · Restricted Project

Dec 10 2019

mgorny added a comment to D71306: [RFC] Change how we deal with optional dependencies.

I'm going to be blunt but if you dislike what LLVM does, improve that rather than proliferating inconsistencies between subprojects.

Dec 10 2019, 3:48 PM · Restricted Project
mgorny added inline comments to D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter.
Dec 10 2019, 3:18 AM · Restricted Project

Dec 6 2019

mgorny added a comment to D71135: [cxx][cxxabi] Don't link libpthread and libdl on Fuchsia.

If it causes link-time error, why CMake checks don't catch that?

Dec 6 2019, 11:27 AM · Restricted Project

Dec 5 2019

mgorny committed rG6c2b2b9e20ab: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD (authored by mgorny).
[compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD
Dec 5 2019, 11:11 PM
mgorny closed D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD.
Dec 5 2019, 11:11 PM · Restricted Project, Restricted Project
mgorny updated the diff for D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD.

Updated to pass the 'prefix' via config object from common, and to use full path for paxctl.

Dec 5 2019, 12:26 AM · Restricted Project, Restricted Project

Dec 4 2019

mgorny added a comment to D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD.

I meant you could define this path in the common lit config as something like "netbsd_noaslr_prefix" and then set up the %run substitution in subdirectories.

Dec 4 2019, 11:35 PM · Restricted Project, Restricted Project

Dec 3 2019

mgorny added a comment to D66390: [PATCH] [llvm] [Support] Update license on ConvertUTF.* per upstream license change.

Ping.

Dec 3 2019, 11:20 PM · Restricted Project
mgorny created D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD.
Dec 3 2019, 5:54 AM · Restricted Project, Restricted Project

Dec 2 2019

mgorny committed rGa9b5fff591d4: [libcxx{,abi}] Emit deplibs only when detected by CMake (authored by mgorny).
[libcxx{,abi}] Emit deplibs only when detected by CMake
Dec 2 2019, 1:24 PM
mgorny closed D70888: [libcxx{,abi}] Emit deplibs only when detected by CMake.
Dec 2 2019, 1:24 PM · Restricted Project
mgorny created D70888: [libcxx{,abi}] Emit deplibs only when detected by CMake.
Dec 2 2019, 2:59 AM · Restricted Project

Dec 1 2019

mgorny committed rG35bc5276ca31: [libunwind] Emit dependent libraries only when detected by CMake (authored by mgorny).
[libunwind] Emit dependent libraries only when detected by CMake
Dec 1 2019, 8:23 AM
mgorny closed D70868: [libunwind] Emit dependent libraries only when detected by CMake.
Dec 1 2019, 8:23 AM · Restricted Project
mgorny added a comment to D70868: [libunwind] Emit dependent libraries only when detected by CMake.

I'll look into it a bit later. I've focused on libunwind since it's breaking NetBSD buildbot.

Dec 1 2019, 8:18 AM · Restricted Project

Nov 30 2019

mgorny created D70868: [libunwind] Emit dependent libraries only when detected by CMake.
Nov 30 2019, 6:22 AM · Restricted Project

Nov 26 2019

mgorny committed rG3cd9a8b7dc61: [lldb] [test] Un-XFAIL lldb-server tests fixed on NetBSD (authored by mgorny).
[lldb] [test] Un-XFAIL lldb-server tests fixed on NetBSD
Nov 26 2019, 7:48 AM

Nov 25 2019

mgorny committed rG7644d8ba4dc4: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events (authored by mgorny).
[lldb] [Process/NetBSD] Fix handling concurrent watchpoint events
Nov 25 2019, 11:14 AM
mgorny committed rGd970d4d4aa73: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads (authored by mgorny).
[lldb] [Process/NetBSD] Copy watchpoints to newly-created threads
Nov 25 2019, 11:14 AM
mgorny closed D70025: [lldb] [Process/NetBSD] Fix handling concurrent watchpoint events.
Nov 25 2019, 11:14 AM · Restricted Project
mgorny committed rG8d9400b65b97: [lldb] [Process/NetBSD] Improve threading support (authored by mgorny).
[lldb] [Process/NetBSD] Improve threading support
Nov 25 2019, 11:14 AM
mgorny closed D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads.
Nov 25 2019, 11:13 AM · Restricted Project
mgorny closed D70022: [lldb] [Process/NetBSD] Improve threading support.
Nov 25 2019, 11:13 AM · Restricted Project
mgorny committed rG6a7f6145d08b: [lldb] [test] XFAIL ASAN tests on NetBSD (authored by mgorny).
[lldb] [test] XFAIL ASAN tests on NetBSD
Nov 25 2019, 11:04 AM

Nov 23 2019

mgorny added inline comments to D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads.
Nov 23 2019, 2:31 AM · Restricted Project

Nov 22 2019

mgorny committed rG06e03bce802e: [lldb] [test] XFAIL TestExpressionEvaluation on NetBSD (authored by mgorny).
[lldb] [test] XFAIL TestExpressionEvaluation on NetBSD
Nov 22 2019, 4:07 AM
mgorny updated the diff for D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads.

Switched to RegisterContextNetBSD & return type as suggested, and fixed formatting. Had to do some include shifting too.

Nov 22 2019, 1:35 AM · Restricted Project
mgorny updated the diff for D70023: [lldb] [Process/NetBSD] Copy watchpoints to newly-created threads.

Switched to %clang_host.

Nov 22 2019, 12:59 AM · Restricted Project
mgorny added inline comments to D70022: [lldb] [Process/NetBSD] Improve threading support.
Nov 22 2019, 12:41 AM · Restricted Project

Nov 21 2019

mgorny added inline comments to D70460: export.sh: Fetch sources from GitHub instead of SVN.
Nov 21 2019, 10:52 PM · Restricted Project
mgorny updated the diff for D70022: [lldb] [Process/NetBSD] Improve threading support.

@labath, finally implemented the new tests. Covered two good (signal to one thread and to all threads) and two bad cases (signal to 1<i<n threads, two different signals to two threads). Please review.

Nov 21 2019, 8:57 AM · Restricted Project
mgorny added inline comments to D70460: export.sh: Fetch sources from GitHub instead of SVN.
Nov 21 2019, 1:49 AM · Restricted Project

Nov 20 2019

mgorny committed rG923afb4a6170: [lldb] [test] Un-XFAIL one lldb-server test on NetBSD (authored by mgorny).
[lldb] [test] Un-XFAIL one lldb-server test on NetBSD
Nov 20 2019, 12:20 PM

Nov 19 2019

mgorny added a comment to D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully.

That sounds like a bug in llvm-config. It shouldn't really return dylib for components that aren't part of it.

Nov 19 2019, 6:13 AM · Restricted Project

Nov 18 2019

mgorny committed rG085486779890: [lldb] [test] XFAIL more lldb-server tests on NetBSD (authored by mgorny).
[lldb] [test] XFAIL more lldb-server tests on NetBSD
Nov 18 2019, 1:37 PM
mgorny committed rG4539a2d20c5c: [lldb] [test] Mark segv-related tests XFAIL on NetBSD (authored by mgorny).
[lldb] [test] Mark segv-related tests XFAIL on NetBSD
Nov 18 2019, 1:37 PM
mgorny committed rGb59af82805cf: [lldb] [unittest] Skip TestStopReplyContainsThreadPcs on NetBSD (authored by mgorny).
[lldb] [unittest] Skip TestStopReplyContainsThreadPcs on NetBSD
Nov 18 2019, 1:36 PM
mgorny committed rGd82dd6ac9a85: [lldb] [unittest] Reenable MainLoopTest.DetectsEOF on NetBSD (authored by mgorny).
[lldb] [unittest] Reenable MainLoopTest.DetectsEOF on NetBSD
Nov 18 2019, 1:36 PM
mgorny committed rG23a766dcad47: [lldb] [Process/NetBSD] Implement thread name getting (authored by mgorny).
[lldb] [Process/NetBSD] Implement thread name getting
Nov 18 2019, 2:23 AM
mgorny committed rGe8924d6403eb: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs (authored by mgorny).
[lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs
Nov 18 2019, 2:22 AM
mgorny closed D70363: [lldb] [Process/NetBSD] Implement thread name getting.
Nov 18 2019, 2:22 AM · Restricted Project
mgorny closed D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs.
Nov 18 2019, 2:22 AM · Restricted Project
mgorny updated the diff for D70363: [lldb] [Process/NetBSD] Implement thread name getting.

Implemented review suggestions. Thanks!

Nov 18 2019, 1:29 AM · Restricted Project

Nov 17 2019

mgorny updated the diff for D70363: [lldb] [Process/NetBSD] Implement thread name getting.

Added sys/types.h.

Nov 17 2019, 11:35 PM · Restricted Project
mgorny updated the summary of D70363: [lldb] [Process/NetBSD] Implement thread name getting.
Nov 17 2019, 3:12 PM · Restricted Project
mgorny updated the diff for D70363: [lldb] [Process/NetBSD] Implement thread name getting.

Went a bit further and implemented the missing feature.

Nov 17 2019, 2:35 PM · Restricted Project
mgorny added a parent revision for D70363: [lldb] [Process/NetBSD] Implement thread name getting: D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs.
Nov 17 2019, 1:10 PM · Restricted Project
mgorny added a child revision for D70335: [lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs: D70363: [lldb] [Process/NetBSD] Implement thread name getting.
Nov 17 2019, 1:10 PM · Restricted Project
mgorny created D70363: [lldb] [Process/NetBSD] Implement thread name getting.
Nov 17 2019, 1:08 PM · Restricted Project