Page MenuHomePhabricator

mgorny (Michał Górny)
Dev @ Moritz Systems

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (301 w, 4 d)

Recent Activity

Wed, May 25

mgorny committed rGe40c4dd66218: [llvm-rc] Avoid which(1) dependency in windres-prefix.test (authored by mgorny).
[llvm-rc] Avoid which(1) dependency in windres-prefix.test
Wed, May 25, 7:15 AM · Restricted Project, Restricted Project
mgorny closed D126366: [llvm-rc] Avoid which(1) dependency in windres-prefix.test.
Wed, May 25, 7:15 AM · Restricted Project, Restricted Project
mgorny added a comment to D126366: [llvm-rc] Avoid which(1) dependency in windres-prefix.test.

Thanks!

Wed, May 25, 7:15 AM · Restricted Project, Restricted Project
mgorny requested review of D126366: [llvm-rc] Avoid which(1) dependency in windres-prefix.test.
Wed, May 25, 4:07 AM · Restricted Project, Restricted Project

Sat, May 21

mgorny updated the diff for D125575: [lldb] [llgs] Implement non-stop style stop notification packets.

Implemented vCtrlC packet and added a test for it.

Sat, May 21, 8:56 AM · Restricted Project

Fri, May 20

mgorny updated the diff for D125575: [lldb] [llgs] Implement non-stop style stop notification packets.

Fix missing OK response for c/C/vCont/… packets.

Fri, May 20, 10:04 PM · Restricted Project
mgorny updated the diff for D125575: [lldb] [llgs] Implement non-stop style stop notification packets.

Rebase.

Fri, May 20, 7:38 AM · Restricted Project

Fri, May 13

mgorny requested review of D125575: [lldb] [llgs] Implement non-stop style stop notification packets.
Fri, May 13, 11:52 AM · Restricted Project

Thu, May 5

mgorny added a comment to D123562: [ubsan] Fix print_stacktrace=1:fast_unwind_on_fatal=0 to correctly fallback to fast unwinder.

Ah, sorry, now I see that a few other tests are also affected by this, so I guess something else has changed. Probably glibc upgrade once again :-(.

Thu, May 5, 9:01 AM · Restricted Project, Restricted Project
mgorny added a comment to D123562: [ubsan] Fix print_stacktrace=1:fast_unwind_on_fatal=0 to correctly fallback to fast unwinder.

This one's failing for me on Gentoo. Apparently, the test executable outputs:

Thu, May 5, 8:57 AM · Restricted Project, Restricted Project

Thu, Apr 28

mgorny added a comment to D124539: workflows: Add a test to ensure that the LLVM version is correct.

Could you also include checking llvm/utils/lit/lit/__init__.py while at it?

Thu, Apr 28, 1:45 AM · Restricted Project, Restricted Project

Apr 23 2022

mgorny added a comment to D124315: lld: Bundle compact_unwind_encoding.h in lld to fix stand-alone builds.

For the record, we're using standalone builds on Gentoo and I don't think we need anything like this — we have to fetch the complete llvmorg tarball anyway, so we have no problem unpacking the header files from libunwind.

Apr 23 2022, 11:34 PM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2022

mgorny accepted D122716: [lldb/linux] Handle main thread exits.

Makes sense.

Apr 4 2022, 1:36 PM · Restricted Project, Restricted Project
mgorny accepted D122660: [lldb] Avoid duplicate vdso modules when opening core files.

Well, I don't see anything wrong with it and it doesn't seem to cause any regressions on FreeBSD. I wouldn't call myself an expert on this though.

Apr 4 2022, 1:36 PM · Restricted Project, Restricted Project

Apr 1 2022

mgorny committed rGfd1da784ac64: [compiler-rt] [scudo] Use -mcrc32 on x86 when available (authored by mgorny).
[compiler-rt] [scudo] Use -mcrc32 on x86 when available
Apr 1 2022, 4:01 AM · Restricted Project, Restricted Project
mgorny closed D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.
Apr 1 2022, 4:01 AM · Restricted Project, Restricted Project
mgorny requested review of D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.
Apr 1 2022, 1:35 AM · Restricted Project, Restricted Project
mgorny updated the diff for D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.

Used __builtin_ia32_crc32* along with -mcrc32 to fix compatibility with GCC.

Apr 1 2022, 1:35 AM · Restricted Project, Restricted Project
mgorny updated the summary of D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.
Apr 1 2022, 1:35 AM · Restricted Project, Restricted Project
mgorny reopened D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.
Apr 1 2022, 1:14 AM · Restricted Project, Restricted Project
mgorny added a comment to rG985c717cdbff: Revert "[compiler-rt] [scudo] Use -mcrc32 on x86 when available".

@nikic, I'm sorry but I must have missed your communication to me about the problem. Could you please help me locate it?

Apr 1 2022, 1:13 AM · Restricted Project, Restricted Project

Mar 31 2022

mgorny committed rG09b53121c323: [compiler-rt] [scudo] Use -mcrc32 on x86 when available (authored by mgorny).
[compiler-rt] [scudo] Use -mcrc32 on x86 when available
Mar 31 2022, 8:50 AM · Restricted Project, Restricted Project
mgorny closed D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.
Mar 31 2022, 8:50 AM · Restricted Project, Restricted Project
mgorny updated the summary of D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.
Mar 31 2022, 1:23 AM · Restricted Project, Restricted Project
mgorny requested review of D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available.
Mar 31 2022, 1:16 AM · Restricted Project, Restricted Project

Mar 25 2022

mgorny accepted D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds.

Thanks. Technically, it looks good to me. However, I'd suggest waiting until Jannik is able to test it.

Mar 25 2022, 9:53 AM · Restricted Project, Restricted Project
mgorny added inline comments to D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds.
Mar 25 2022, 1:47 AM · Restricted Project, Restricted Project

Mar 24 2022

mgorny added a comment to D122424: [clang] [Driver] Add clang's relative `../lib` path only when in build tree.

Is addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); from D108286 the issue?

Mar 24 2022, 2:21 PM · Restricted Project
mgorny requested review of D122424: [clang] [Driver] Add clang's relative `../lib` path only when in build tree.
Mar 24 2022, 12:17 PM · Restricted Project

Mar 14 2022

mgorny accepted D121015: [libunwind] Add a _LIBUNWIND_VERSION macro.

I'm sorry, my replacement PSU just arrived today and I'm slowly catching up with everything. I presume we don't need to worry about backwards compatibility, so LGTM.

Mar 14 2022, 9:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mgorny accepted D121487: [lldb] Require native for command-thread-siginfo.test.

Thanks for catching this!

Mar 14 2022, 6:21 AM · Restricted Project, Restricted Project

Mar 3 2022

mgorny accepted D120320: [lldb/driver] Fix SIGTSTP handling.

LGTM (but I cannot test)

Mar 3 2022, 2:37 AM · Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D120320: [lldb/driver] Fix SIGTSTP handling: Restricted Project.
Mar 2 2022, 11:24 AM · Restricted Project, Restricted Project

Mar 1 2022

mgorny added a comment to D119539: [libcxx] Add an explicit option to build against system-libcxxabi.

Could you push it for me, please? My PC died yesterday and I won't have it fixed in the next few days.

Mar 1 2022, 10:35 AM · Restricted Project

Feb 26 2022

mgorny added reviewers for D119539: [libcxx] Add an explicit option to build against system-libcxxabi: EricWF, phosek, mstorsjo.
Feb 26 2022, 10:15 AM · Restricted Project

Feb 25 2022

mgorny requested review of D120577: [14.x] [clang] [test] Skip hip-fpie-option.hip if default-pie.
Feb 25 2022, 11:02 AM

Feb 23 2022

mgorny added a comment to D119539: [libcxx] Add an explicit option to build against system-libcxxabi.

Ping. I'd like to try to backport the fixes to 14.x, so would be nice to get it sorted out before it goes out.

Feb 23 2022, 8:38 AM · Restricted Project

Feb 17 2022

mgorny updated the diff for D119539: [libcxx] Add an explicit option to build against system-libcxxabi.

Add another LIBCXX_CXX_ABI variant instead, as requested.

Feb 17 2022, 11:28 AM · Restricted Project
mgorny added inline comments to D119539: [libcxx] Add an explicit option to build against system-libcxxabi.
Feb 17 2022, 11:12 AM · Restricted Project

Feb 16 2022

mgorny added a comment to D119884: [llvm] [bindings/OCaml] Remove unused dep on ounit2.

Do you think this should be backported to 14.x? On one hand, it isn't exactly urgent, but it kinda sucks to require this unused dep for another release.

Feb 16 2022, 12:12 PM · Restricted Project
mgorny committed rG2c5c243bb515: [llvm] [bindings/OCaml] Remove unused dep on ounit2 (authored by mgorny).
[llvm] [bindings/OCaml] Remove unused dep on ounit2
Feb 16 2022, 10:31 AM
mgorny committed rG5244ef0faf55: [libcxxabi] [test] Depend on unwind only if available (authored by mgorny).
[libcxxabi] [test] Depend on unwind only if available
Feb 16 2022, 10:31 AM
mgorny closed D119884: [llvm] [bindings/OCaml] Remove unused dep on ounit2.
Feb 16 2022, 10:30 AM · Restricted Project
mgorny closed D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 16 2022, 10:30 AM · Restricted Project, Restricted Project
mgorny added a comment to D119884: [llvm] [bindings/OCaml] Remove unused dep on ounit2.

Note that it was @arbipher who first noticed that ounit is no longer used.

Feb 16 2022, 10:17 AM · Restricted Project
mgorny added inline comments to D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 16 2022, 10:13 AM · Restricted Project, Restricted Project

Feb 15 2022

mgorny added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

It's basically https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-ml/llvm-ocaml/llvm-ocaml-15.0.0.9999.ebuild#n41.

Feb 15 2022, 2:01 PM · Restricted Project
mgorny requested review of D119884: [llvm] [bindings/OCaml] Remove unused dep on ounit2.
Feb 15 2022, 12:26 PM · Restricted Project
mgorny added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

Heh, yeah, it seems that the best fix would be to just remove the traces of ounit. I also don't see where they are used, so just removing and seeing if the tests pass in a context with no ounit installed seems like a good plan.

Feb 15 2022, 12:17 PM · Restricted Project
mgorny added inline comments to D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 15 2022, 10:18 AM · Restricted Project, Restricted Project

Feb 14 2022

mgorny added inline comments to D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 14 2022, 3:40 PM · Restricted Project, Restricted Project
mgorny added inline comments to D119539: [libcxx] Add an explicit option to build against system-libcxxabi.
Feb 14 2022, 3:39 PM · Restricted Project
mgorny added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

Heh, this possibility didn't even occur to me. I suppose the easiest way to check would be to remove ounit2, remove the lit restriction and see if tests still pass.

Feb 14 2022, 12:14 AM · Restricted Project

Feb 13 2022

mgorny added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

That entry in lit.local.cfg.py makes lit mark all OCaml binding tests as unsupported if ounit is not present.

Feb 13 2022, 1:19 PM · Restricted Project
mgorny added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

I'm not really using OCaml — I'm just maintaining LLVM in Gentoo, and since someone before me added the OCaml bindings, I just keep them working.

Feb 13 2022, 1:10 AM · Restricted Project

Feb 12 2022

mgorny committed rG919dba9248f6: [llvm] [cmake] Fix finding modern ounit2 (authored by mgorny).
[llvm] [cmake] Fix finding modern ounit2
Feb 12 2022, 4:45 AM
mgorny closed D119079: [llvm] [cmake] Fix finding modern ounit2.
Feb 12 2022, 4:45 AM · Restricted Project
mgorny added a comment to D119079: [llvm] [cmake] Fix finding modern ounit2.

Thanks!

Feb 12 2022, 4:45 AM · Restricted Project
mgorny added a comment to D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie.

When enabled, this seems to break a fair number of tests:

Feb 12 2022, 4:44 AM · Restricted Project, Restricted Project

Feb 11 2022

mgorny requested review of D119539: [libcxx] Add an explicit option to build against system-libcxxabi.
Feb 11 2022, 3:59 AM · Restricted Project
mgorny requested review of D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 11 2022, 3:51 AM · Restricted Project, Restricted Project
mgorny added a comment to D119255: [runtimes] Remove support for standalone builds.

I'm sorry about my tone and thank you for the explanation.

Feb 11 2022, 2:57 AM · Restricted Project, Restricted Project, Restricted Project
mgorny added a comment to D118360: [NFC][cmake] Respect LLVM_ENABLE_TERMINFO when building llvm-config.

That said, I'm sorry but I'm confused. Could you explain in greater detail what are you doing? llvm-config doesn't sound like something you should use for cross-compiling.

Feb 11 2022, 2:55 AM · Restricted Project
mgorny added a comment to D118360: [NFC][cmake] Respect LLVM_ENABLE_TERMINFO when building llvm-config.

Please upload patches generated with -U9999, so that Phabricator has the complete context to show.

Feb 11 2022, 2:53 AM · Restricted Project

Feb 10 2022

mgorny committed rGc65fb0cdf262: [compiler-rt] Fix endianness in get_sock_peer_name test (authored by mgorny).
[compiler-rt] Fix endianness in get_sock_peer_name test
Feb 10 2022, 11:16 AM
mgorny closed D119461: [compiler-rt] Fix endianness in get_sock_peer_name test.
Feb 10 2022, 11:16 AM · Restricted Project
mgorny added a comment to D119461: [compiler-rt] Fix endianness in get_sock_peer_name test.

Thanks for the prompt review!

Feb 10 2022, 11:16 AM · Restricted Project
mgorny added a comment to D119461: [compiler-rt] Fix endianness in get_sock_peer_name test.

@vitalybuka, I suspect this might also fix the test on Android but I don't have an environment to test it.

Feb 10 2022, 10:47 AM · Restricted Project
mgorny requested review of D119461: [compiler-rt] Fix endianness in get_sock_peer_name test.
Feb 10 2022, 10:45 AM · Restricted Project
mgorny added a reviewer for D119079: [llvm] [cmake] Fix finding modern ounit2: jberdine.

@jberdine, you seem to be the only person touching OCaml "recently". Any chance you'd be able to review this?

Feb 10 2022, 5:25 AM · Restricted Project
mgorny added reviewers for D119079: [llvm] [cmake] Fix finding modern ounit2: MaskRay, tstellar.
Feb 10 2022, 5:23 AM · Restricted Project
mgorny added a comment to D119255: [runtimes] Remove support for standalone builds.

For the record, I just want to say that this sucks a lot for Gentoo and I'm really unhappy with the recent trend of ignoring other people's effort and destroying their use cases for one's own convenience. But I guess I have to live with it. It's just sad how much effort I've wasted fixing things every time standalone builds were broken, and in the end the working code is being broken for the sake of preventing others from maintaining standalone builds. In the end, we'll manage but probably at the cost of preventing our users from installing GNU libunwind and libc++ simultaneously but I guess people using binary distros just don't care that could be a better way.

Feb 10 2022, 4:11 AM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2022

mgorny added a comment to D119380: [lld][CMake] Add a warning about the Standalone build being deprecated.

Sounds like you're trying hard to make me step down from contributing to LLVM anymore.

Feb 9 2022, 11:50 PM · Restricted Project

Feb 7 2022

mgorny accepted D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests.

LLVMHello part LGTM. Dunno about the other part.

Feb 7 2022, 4:33 PM · Restricted Project, Restricted Project
mgorny added a comment to D111100: enable plugins for clang-tidy.

It is a somewhat worthless test IMO, and might belong better in LLVM itself (where this functionality is defined), but there does not appear to be any other like it currently, and it was requested by a previous reviewer. Comparing to the code in LLVMTestingSupport, does this fix it for you:

Feb 7 2022, 3:04 PM · Restricted Project
mgorny accepted D119058: Fix lld standalone build.

LGTM! Please request backport to 14.x once you've pushed it.

Feb 7 2022, 2:18 AM · Restricted Project, lld
mgorny added a comment to D119058: Fix lld standalone build.

Thanks. Please give me an hour to test it.

Feb 7 2022, 1:28 AM · Restricted Project, lld

Feb 6 2022

mgorny requested review of D119079: [llvm] [cmake] Fix finding modern ounit2.
Feb 6 2022, 7:01 AM · Restricted Project
mgorny requested changes to D117853: [ELF] Parallelize --compress-debug-sections=zlib.
Feb 6 2022, 5:10 AM · Restricted Project
mgorny reopened D117853: [ELF] Parallelize --compress-debug-sections=zlib.
Feb 6 2022, 5:10 AM · Restricted Project
mgorny requested changes to D111100: enable plugins for clang-tidy.
Feb 6 2022, 3:28 AM · Restricted Project
mgorny reopened D111100: enable plugins for clang-tidy.

This breaks build of clang against system-installed LLVM:

Feb 6 2022, 3:28 AM · Restricted Project

Feb 2 2022

mgorny committed rG287ce6b51675: [lldb] [Commands] Implement "thread siginfo" (authored by mgorny).
[lldb] [Commands] Implement "thread siginfo"
Feb 2 2022, 10:32 AM
mgorny added a comment to D118473: [lldb] [Commands] Implement "thread siginfo".

Thanks for all the reviews and helpful suggestions!

Feb 2 2022, 10:32 AM · Restricted Project
mgorny closed D118473: [lldb] [Commands] Implement "thread siginfo".
Feb 2 2022, 10:32 AM · Restricted Project
mgorny updated the diff for D118473: [lldb] [Commands] Implement "thread siginfo".

Removed the comment and added thread info-style status above siginfos.

Feb 2 2022, 6:35 AM · Restricted Project
mgorny added inline comments to D118473: [lldb] [Commands] Implement "thread siginfo".
Feb 2 2022, 6:35 AM · Restricted Project

Jan 28 2022

mgorny committed rGac666d1799c4: [lldb] [gdb-remote] Support getting siginfo via API (authored by mgorny).
[lldb] [gdb-remote] Support getting siginfo via API
Jan 28 2022, 8:48 AM
mgorny closed D118055: [lldb] [gdb-remote] Support getting siginfo via API.
Jan 28 2022, 8:48 AM · Restricted Project
mgorny requested review of D118473: [lldb] [Commands] Implement "thread siginfo".
Jan 28 2022, 7:44 AM · Restricted Project
mgorny updated the diff for D118055: [lldb] [gdb-remote] Support getting siginfo via API.

Add Thread::GetSiginfoValue() to perform baseline value construction, and limit SBThread::GetSiginfo() to wrapping that. Return errors via ValueObjectConstResult.

Jan 28 2022, 3:18 AM · Restricted Project
mgorny added a reverting change for rG1a8f60f5f5b8: [lldb] [gdb-remote] Support getting siginfo via API: rG59a3f65f5ed6: Revert "[lldb] [gdb-remote] Support getting siginfo via API".
Jan 28 2022, 1:16 AM
mgorny committed rG59a3f65f5ed6: Revert "[lldb] [gdb-remote] Support getting siginfo via API" (authored by mgorny).
Revert "[lldb] [gdb-remote] Support getting siginfo via API"
Jan 28 2022, 1:16 AM
mgorny added a reverting change for D118055: [lldb] [gdb-remote] Support getting siginfo via API: rG59a3f65f5ed6: Revert "[lldb] [gdb-remote] Support getting siginfo via API".
Jan 28 2022, 1:16 AM · Restricted Project

Jan 27 2022

mgorny committed rG11c2ef5638c3: unwind: fix typo for __powerpc__ (authored by thesamesam).
unwind: fix typo for __powerpc__
Jan 27 2022, 2:21 PM
mgorny committed rGcd20e579df07: [unwind] fix build with GCC on PPC32 (authored by thesamesam).
[unwind] fix build with GCC on PPC32
Jan 27 2022, 2:05 PM
mgorny closed D118320: [libunwind] build fix for GCC on PPC32.
Jan 27 2022, 2:05 PM · Restricted Project, Restricted Project
mgorny added a comment to D118055: [lldb] [gdb-remote] Support getting siginfo via API.

We don't return errors separately for any of the API's that return an SBValue. SBValue's carry their error with them (SBValue.GetError()) so it would be confusing to have two errors.

Jan 27 2022, 1:39 PM · Restricted Project
mgorny accepted D118320: [libunwind] build fix for GCC on PPC32.

LGTM. Thanks.

Jan 27 2022, 1:13 PM · Restricted Project, Restricted Project
mgorny committed rG1a8f60f5f5b8: [lldb] [gdb-remote] Support getting siginfo via API (authored by mgorny).
[lldb] [gdb-remote] Support getting siginfo via API
Jan 27 2022, 4:34 AM