- User Since
- Aug 15 2016, 6:00 AM (152 w, 6 d)
The added tests are failing for me, both on NetBSD and on one of my Linux systems:
Thu, Jul 18
Wed, Jul 17
Makes sense. I suppose you want to update LLDBStandalone as well. And probably Python_ADDITIONAL_VERSIONS in clang & co are outdated.
Filed https://gitlab.kitware.com/cmake/cmake/issues/19492 for that.
To be honest, I don't think this is the correct solution. After all, lit-cpuid isn't installed, is it? (or are you using LLVM_INSTALL_UTILS?)
That said, I ended up having mixed feelings about this.
Am I guessing correctly that this happens when you installed combined llvm+lldb build, and then try to build lldb standalone against that?
Tue, Jul 16
Hmm, I've just looked through CMake docs, and I think a better solution might be:
Fri, Jul 12
Tue, Jul 9
Unless I'm mistaken, this commit broke building Polly:
Mon, Jul 8
Could you tell me specifically what change to buildbot is requested? I must've missed the original thread.
Am I guessing correctly that this broke the buildbots (again)?
Sun, Jul 7
LGTM. According to CMake manual, plain + is the only correct form and if \+ worked at all, it was probably only by accident.
The API has changed, and so the patch is no longer correct.
Sat, Jul 6
This seems to have broken the build for us:
Tue, Jul 2
Mon, Jul 1
Updated per review.
I'm going to ask Kamil to stamp those patches anyway but I always appreciate your advice wrt LLDB coding style and general integration. After all, we all want LLDB codebase to be more unified.
That's probably one of the reasons why NetBSD normally prevents unprivileged users from setting DRs.
Sat, Jun 29
I'm sorry that nobody has replied to your request earlier. AFAICS the libcxx code has changed. Does it work now, or do we need to make thread_win32.cpp conditional to LIBCXX_HAS_WIN32_THREAD_API still?
Thu, Jun 27
This is ready to be reviewed now.
Wed, Jun 26
Removed XFAIL for tests fixed by this.
Tue, Jun 25
Mon, Jun 24
Jun 21 2019
…and removed stale declarations.
Updated to use new XState conversion methods.
Jun 20 2019
How about this? I've removed almost all abstraction, leaving only simple ptrace() wrapper.
I'll try to simplify it in a few steps and see how that goes. All I'm saying is that ultimately having some DoRegisterSet() wrapper that calls ptrace() and avoids repeating getting PID/TID may help. Though admittely it saves very little actual code.
Rebased for changes in NativeRegisterContextNetBSD_x86_64::GetSetForNativeRegNum(), and removed the conditions there.
@stella.stamenova could you try running the lldb invocation manually like I did? I'm wondering if you're getting the same issue.
The added test broke NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/109/steps/run%20unit%20tests/logs/FAIL%3A%20LLDB%3A%3ATestProcessAttach.test
Jun 19 2019
Jun 17 2019
Marshall, std/containers/associative/map/map.cons/deduct_const.pass.cpp test seems to be reliably failing from commit one on both Gentoo Linux and NetBSD. Could you please look at the classical example of totally cryptic C++ error? ;-)