Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (127 w, 2 d)

Recent Activity

Today

mgorny added inline comments to D57063: [CMake] Unify scripts for generating VCS headers.
Wed, Jan 23, 2:55 AM

Yesterday

mgorny added inline comments to D57063: [CMake] Unify scripts for generating VCS headers.
Tue, Jan 22, 12:33 PM
mgorny committed rL351808: Fix/unify top comment in lib/Analysis/PolyhedralInfo.cpp.
Fix/unify top comment in lib/Analysis/PolyhedralInfo.cpp
Tue, Jan 22, 4:18 AM

Mon, Jan 21

mgorny added a comment to rL350973: [CMake] Fix standalone build after LLVM exports utility targets.

How is this supposed to work? I've just rebuilt and reinstalled LLVM with LLVM_INSTALL_UTILS=ON, I certainly see FileCheck when grepping /usr/local/lib/cmake/llvm/LLVMConfig.cmake yet I can't build compiler-rt anymore:

Mon, Jan 21, 9:13 AM
mgorny committed rC351752: [test] Pass -ccc-install-dir in mac compilation db test.
[test] Pass -ccc-install-dir in mac compilation db test
Mon, Jan 21, 9:06 AM
mgorny committed rL351752: [test] Pass -ccc-install-dir in mac compilation db test.
[test] Pass -ccc-install-dir in mac compilation db test
Mon, Jan 21, 9:06 AM
mgorny closed D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.
Mon, Jan 21, 9:05 AM
mgorny added a comment to D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.

Was confused about your comment, so it works on other systems because they don't rely on argv[0] to get the path to main executable. Got you.

Mon, Jan 21, 6:31 AM
mgorny updated the diff for D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.

Added a comment as requested.

Mon, Jan 21, 6:31 AM
mgorny added a comment to D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.

LGTM to unbreak the tests on *BSD, but could you please leave a comment?
It would probably be best to take argv[0] into account on *BSD systems as well (possibly only if clang could not be found).

At least if that's the behaviour on all other systems.

Mon, Jan 21, 3:04 AM

Sun, Jan 20

mgorny created D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.
Sun, Jan 20, 5:48 AM
mgorny updated the diff for D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

Added FreeBSD warning comment.

Sun, Jan 20, 5:25 AM
mgorny created D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.
Sun, Jan 20, 5:13 AM

Fri, Jan 18

mgorny created D56932: [Driver] [NetBSD] Pass default library search paths to linker.
Fri, Jan 18, 1:38 PM
mgorny accepted D56912: Use llvm_canonicalize_cmake_booleans for LLVM_LIBXML2_ENABLED.

Looks good. Optionally, I'm suggesting one cleanup.

Fri, Jan 18, 11:41 AM

Wed, Jan 16

mgorny added inline comments to D56826: Clean up FindPythonInterp and FindPythonLibs usage.
Wed, Jan 16, 11:22 PM
mgorny committed rC351304: [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF.
[test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF
Wed, Jan 16, 12:09 AM
mgorny committed rL351304: [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF.
[test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF
Wed, Jan 16, 12:09 AM
mgorny closed D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF.
Wed, Jan 16, 12:09 AM

Tue, Jan 15

mgorny created D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF.
Tue, Jan 15, 10:32 AM

Mon, Jan 14

mgorny added a comment to D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.

@ruiu, what do you think? The current logic forces some precedence, i.e. if you pass -z nognustack, further -z {no,}execstack are ignored. I suppose we could just force passing -z nognustack as last option clang-wise.

Mon, Jan 14, 8:55 PM
mgorny committed rL351109: [test] Disable sunrpc tests when rpc/xdr.h is missing.
[test] Disable sunrpc tests when rpc/xdr.h is missing
Mon, Jan 14, 11:22 AM
mgorny committed rCRT351109: [test] Disable sunrpc tests when rpc/xdr.h is missing.
[test] Disable sunrpc tests when rpc/xdr.h is missing
Mon, Jan 14, 11:22 AM
mgorny closed D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.
Mon, Jan 14, 11:22 AM · Restricted Project
mgorny added a comment to D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.
PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_bytes.cc (2932 of 6195)
PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_string.cc (2935 of 6195)
PASS: MemorySanitizer-X86_64 :: Linux/sunrpc.cc (2974 of 6195)
PASS: ThreadSanitizer-x86_64 :: sunrpc.cc (5110 of 6195)
Mon, Jan 14, 10:34 AM · Restricted Project
mgorny added a comment to D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.

The direction of this patch looks reasonable to me. Is it worth mentioning the issue (https://github.com/google/sanitizers/issues/974) in the commit message?

Mon, Jan 14, 10:06 AM · Restricted Project
mgorny updated the diff for D56650: [lld] [ELF] Support customizing behavior on target triple.

Fixed leaving triple unset on invalid --target.

Mon, Jan 14, 7:18 AM
mgorny added inline comments to D56650: [lld] [ELF] Support customizing behavior on target triple.
Mon, Jan 14, 7:10 AM
mgorny updated the diff for D56650: [lld] [ELF] Support customizing behavior on target triple.
Mon, Jan 14, 7:09 AM
mgorny added a comment to D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.

Ping. I'd really like to merge this before the branch.

Mon, Jan 14, 1:49 AM · Restricted Project

Sun, Jan 13

mgorny added inline comments to D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Sun, Jan 13, 2:05 PM · lld
mgorny added a parent revision for D56288: [ELF] Do not enable 'new dtags' on NetBSD by default: D56650: [lld] [ELF] Support customizing behavior on target triple.
Sun, Jan 13, 2:05 PM
mgorny added a child revision for D56650: [lld] [ELF] Support customizing behavior on target triple: D56288: [ELF] Do not enable 'new dtags' on NetBSD by default.
Sun, Jan 13, 2:05 PM
mgorny removed child revisions for D56215: [lld] [ELF] Include default search paths for NetBSD driver: D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK, D56288: [ELF] Do not enable 'new dtags' on NetBSD by default.
Sun, Jan 13, 2:05 PM · lld
mgorny removed a parent revision for D56288: [ELF] Do not enable 'new dtags' on NetBSD by default: D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Sun, Jan 13, 2:05 PM
mgorny added a child revision for D56650: [lld] [ELF] Support customizing behavior on target triple: D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Sun, Jan 13, 2:05 PM
mgorny removed a parent revision for D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK: D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Sun, Jan 13, 2:05 PM
mgorny added a parent revision for D56215: [lld] [ELF] Include default search paths for NetBSD driver: D56650: [lld] [ELF] Support customizing behavior on target triple.
Sun, Jan 13, 2:05 PM · lld
mgorny updated the diff for D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Split target logic into D56650, switched to using target to determine which paths to apply. While at it, copied the code from clang since it now can match exactly.

Sun, Jan 13, 2:05 PM · lld
mgorny created D56650: [lld] [ELF] Support customizing behavior on target triple.
Sun, Jan 13, 2:00 PM
mgorny created D56647: [WIP] [ELF] Implement --copy-dt-needed-entries.
Sun, Jan 13, 3:19 AM

Sat, Jan 12

mgorny committed rC351002: [NetBSD] Enable additional sanitizer types.
[NetBSD] Enable additional sanitizer types
Sat, Jan 12, 3:23 AM
mgorny committed rL351002: [NetBSD] Enable additional sanitizer types.
[NetBSD] Enable additional sanitizer types
Sat, Jan 12, 3:22 AM
mgorny closed D56607: [clang] [NetBSD] Enable additional sanitizer types.
Sat, Jan 12, 3:22 AM

Fri, Jan 11

mgorny updated the diff for D56607: [clang] [NetBSD] Enable additional sanitizer types.

Updated the tests to account for most of the known sanitizer types.

Fri, Jan 11, 12:52 PM
mgorny created D56607: [clang] [NetBSD] Enable additional sanitizer types.
Fri, Jan 11, 9:23 AM
mgorny added a comment to D55763: [Sparc] Add Sparc V8 support.

Thanks, builds fine now.

Fri, Jan 11, 8:21 AM
mgorny added inline comments to D55763: [Sparc] Add Sparc V8 support.
Fri, Jan 11, 8:10 AM
mgorny updated the diff for D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Implemented checking the triple against target registry. Also made --version output the detected target.

Fri, Jan 11, 7:39 AM · lld
mgorny added inline comments to D55763: [Sparc] Add Sparc V8 support.
Fri, Jan 11, 6:39 AM
mgorny added inline comments to D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages.
Fri, Jan 11, 12:23 AM
mgorny added a comment to D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.

Actually, I've just researched a bit and default stack permissions depend on arch in glibc, so assuming it's RWX by default is wrong.

Fri, Jan 11, 12:06 AM

Thu, Jan 10

mgorny added a comment to D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.

@ruiu, what if one of the systems changes defaults (e.g. due to Hardening) and starts defaulting to noexecstack? In that case we'd want `-z execstack' to actually emit PT_GNU_STACK, and I don't think we really are able to 100% detect the default in clang. I'd really see this as a trinary option: emit RW, emit RWX or not emit at all. I don't think it's a good idea to make linker rely on implicit assumptions or hidden guesses that could easily confuse user as to what's happening and why.

Thu, Jan 10, 11:47 PM
mgorny updated the diff for D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.

Following the changes to D47817, updated this one to disable relevant tests when sunrpc headers are not available.

Thu, Jan 10, 12:45 PM · Restricted Project
mgorny added inline comments to D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.
Thu, Jan 10, 12:10 PM
mgorny created D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.
Thu, Jan 10, 12:01 PM
mgorny committed rL350882: [sanitizer_common] Define __sanitizer_FILE on NetBSD.
[sanitizer_common] Define __sanitizer_FILE on NetBSD
Thu, Jan 10, 12:00 PM
mgorny committed rCRT350882: [sanitizer_common] Define __sanitizer_FILE on NetBSD.
[sanitizer_common] Define __sanitizer_FILE on NetBSD
Thu, Jan 10, 12:00 PM
mgorny closed D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD.
Thu, Jan 10, 12:00 PM
mgorny committed rCRT350881: [sanitizer_common] Remove support for tirpc/rpc/xdr.h.
[sanitizer_common] Remove support for tirpc/rpc/xdr.h
Thu, Jan 10, 12:00 PM
mgorny committed rL350881: [sanitizer_common] Remove support for tirpc/rpc/xdr.h.
[sanitizer_common] Remove support for tirpc/rpc/xdr.h
Thu, Jan 10, 12:00 PM
mgorny closed D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h.
Thu, Jan 10, 12:00 PM · Restricted Project

Wed, Jan 9

mgorny added a comment to D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages.

Please don't risk merging this before the branching.

Wed, Jan 9, 7:37 PM
mgorny added a comment to D55763: [Sparc] Add Sparc V8 support.

Thank you.

Wed, Jan 9, 7:37 PM
mgorny planned changes to D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing.

Need to update this for the new idea of not using libtirpc at all.

Wed, Jan 9, 7:31 PM · Restricted Project
mgorny added a comment to D56479: [compiler-rt] Add option to disable libc++ build.

I think it'd be better to have a positive version, e.g. something like COMPILER_RT_USE_LIBCXX_SOURCES. Maybe it could default to ${LLVM_TOOL_LIBCXX_BUILD}.

Wed, Jan 9, 11:47 AM
mgorny updated the diff for D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Adjusted to make paths sysroot-relative.

Wed, Jan 9, 11:13 AM · lld
mgorny added a comment to D38057: Try again to fix libcxx CMake so that it doesn't break when no LLVM source tree is available.

This actually breaks using external lit. It no longer respects -DLLVM_EXTERNAL_LIT passed to CMake, and instead forces the hardcoded libcxx path, which — since the file listed there doesn't exist — causes fallback to also-non-existing llvm-lit to happen.

Wed, Jan 9, 9:53 AM
mgorny added a comment to D55763: [Sparc] Add Sparc V8 support.

This commit is causing regression when building with -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON:

Wed, Jan 9, 7:30 AM
mgorny committed rL350717: [test] Detect glibc-2.27+ and XFAIL appropriate tests.
[test] Detect glibc-2.27+ and XFAIL appropriate tests
Wed, Jan 9, 5:31 AM
mgorny committed rCRT350717: [test] Detect glibc-2.27+ and XFAIL appropriate tests.
[test] Detect glibc-2.27+ and XFAIL appropriate tests
Wed, Jan 9, 5:31 AM
mgorny closed D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests.
Wed, Jan 9, 5:31 AM
mgorny added a comment to D56479: [compiler-rt] Add option to disable libc++ build.

Could you also add a local switch to control using it independently of main build? The sanitized builds are quite time-consuming.

Wed, Jan 9, 3:58 AM

Tue, Jan 8

mgorny added inline comments to D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Tue, Jan 8, 1:07 PM · lld
mgorny added a parent revision for D56288: [ELF] Do not enable 'new dtags' on NetBSD by default: D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Tue, Jan 8, 12:43 PM
mgorny added a child revision for D56215: [lld] [ELF] Include default search paths for NetBSD driver: D56288: [ELF] Do not enable 'new dtags' on NetBSD by default.
Tue, Jan 8, 12:43 PM · lld
mgorny updated the diff for D56288: [ELF] Do not enable 'new dtags' on NetBSD by default.

Updating for completeness.

Tue, Jan 8, 12:43 PM
mgorny updated the diff for D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Next version, based on recognizing NetBSD from triple.

Tue, Jan 8, 12:40 PM · lld
mgorny added a comment to D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD.

Ping.

Tue, Jan 8, 9:50 AM
mgorny added a comment to D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests.

Ping.

Tue, Jan 8, 9:50 AM
mgorny added a comment to D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h.

Ping again.

Tue, Jan 8, 9:50 AM · Restricted Project

Mon, Jan 7

mgorny added a comment to D56288: [ELF] Do not enable 'new dtags' on NetBSD by default.

Ok, maybe I'm being silly but since clang driver has to pass --enable-new-dtags for GNU ld compatibility anyway, wouldn't it make sense to keep the default as disabled in order to match GNU ld behavior?

Mon, Jan 7, 6:13 AM

Thu, Jan 3

mgorny added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

For the record, another option is to actually fix other software not to call LD directly.

Thu, Jan 3, 9:52 PM · lld
mgorny added a comment to D56215: [lld] [ELF] Include default search paths for NetBSD driver.

We've discussed this a bit and given other changes we need to do, and I see pretty much three options here:

  1. We hardcode stuff under defined(__NetBSD__) which kinda solves the problem, except lld won't be very cross-friendly.
  2. We try to do conditionals based on triple but this works only when we customize the install to include it in executable name. We probably would still need to default based on defined(__NetBSD__) when triple isn't available via process name.
  3. We create *nbsd* emulations for all arches (e.g. amd64/x86 don't have such emulations right now), and use that to switch logic. This would be closer to what FreeBSD does, I think. However, if we do this, then I suppose we should also add similar aliases to GNU ld.
Thu, Jan 3, 12:33 PM · lld
mgorny created D56288: [ELF] Do not enable 'new dtags' on NetBSD by default.
Thu, Jan 3, 12:18 PM
mgorny updated the diff for D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Removed non-x86.

Thu, Jan 3, 12:12 PM · lld
mgorny added inline comments to D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Thu, Jan 3, 12:05 PM · lld
mgorny updated the diff for D56215: [lld] [ELF] Include default search paths for NetBSD driver.

Updated to use clang's libdir logic.

Thu, Jan 3, 11:41 AM · lld
mgorny added a comment to D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h.

@ygribov, ping.

Thu, Jan 3, 8:47 AM · Restricted Project
mgorny committed rL350329: [clangd] Fix detecting atomics in stand-alone builds.
[clangd] Fix detecting atomics in stand-alone builds
Thu, Jan 3, 8:47 AM
mgorny committed rCTE350329: [clangd] Fix detecting atomics in stand-alone builds.
[clangd] Fix detecting atomics in stand-alone builds
Thu, Jan 3, 8:47 AM
mgorny closed D56061: [clang-tools-extra] [clangd] Fix detecting atomics in stand-alone builds.
Thu, Jan 3, 8:47 AM

Wed, Jan 2

mgorny added a comment to D56162: [test] Fix propagating HOME envvar to unittests.

Thank you for addressing this!

Wed, Jan 2, 8:56 PM
mgorny created D56215: [lld] [ELF] Include default search paths for NetBSD driver.
Wed, Jan 2, 12:39 PM · lld
mgorny committed rLLD350253: [test] Enable system-linker-elf feature on NetBSD [NFC].
[test] Enable system-linker-elf feature on NetBSD [NFC]
Wed, Jan 2, 11:55 AM
mgorny committed rL350253: [test] Enable system-linker-elf feature on NetBSD [NFC].
[test] Enable system-linker-elf feature on NetBSD [NFC]
Wed, Jan 2, 11:43 AM
mgorny committed rCRT350232: [sanitizer_common] Implement popen, popenve, pclose interceptors.
[sanitizer_common] Implement popen, popenve, pclose interceptors
Wed, Jan 2, 10:00 AM
mgorny committed rCRT350233: [sanitizer_common] Implement funopen*() interceptors for NetBSD.
[sanitizer_common] Implement funopen*() interceptors for NetBSD
Wed, Jan 2, 10:00 AM
mgorny committed rCRT350231: [sanitizer_common] Add tests for NetBSD funopen*() functions.
[sanitizer_common] Add tests for NetBSD funopen*() functions
Wed, Jan 2, 10:00 AM
mgorny committed rCRT350229: [sanitizer_common] Add tests for more *putc and *getc variants.
[sanitizer_common] Add tests for more *putc and *getc variants
Wed, Jan 2, 10:00 AM