mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (88 w, 3 d)

Recent Activity

Tue, Apr 24

mgorny added a comment to D42274: [Support] Remove the terminfo dependency and rely on TERM.

But of course nbjoerg will complain because it will break all the people who run clang outputting to Tektronix 4012 graphics terminals which can't parse vt100/ansi escape sequence syntax. And I don't have the will to argue the point.

Tue, Apr 24, 9:12 AM

Mon, Apr 9

mgorny committed rCTE329594: [cmake] Include LLVMTestingSupport when doing stand-alone build.
[cmake] Include LLVMTestingSupport when doing stand-alone build
Mon, Apr 9, 10:13 AM
mgorny committed rL329594: [cmake] Include LLVMTestingSupport when doing stand-alone build.
[cmake] Include LLVMTestingSupport when doing stand-alone build
Mon, Apr 9, 10:13 AM
mgorny closed D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build.
Mon, Apr 9, 10:13 AM
mgorny closed D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build.
Mon, Apr 9, 10:13 AM
mgorny added a comment to D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build.

I've based this change on an earlier fix to lldb when that project started using LLVMTestingSupport.

Mon, Apr 9, 2:43 AM

Sun, Apr 8

mgorny added a comment to D45406: Document -std= values for different languages.

I think you'd want a definition list instead then. But I haven't tested if they can be nested inside option lists.

Sun, Apr 8, 3:29 AM

Sat, Apr 7

mgorny committed rL329522: [LLVMTestingSupport] Add explicit linkage to LLVMSupport.
[LLVMTestingSupport] Add explicit linkage to LLVMSupport
Sat, Apr 7, 11:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, Apr 7, 11:53 PM
mgorny updated subscribers of D45408: [LLVMTestingSupport] Add explicit linkage to LLVMSupport.

W dniu nie, 08.04.2018 o godzinie 00∶13 +0000, użytkownik Zachary Turner
napisał:

Lgtm

Sat, Apr 7, 11:53 PM
mgorny added a comment to D45406: Document -std= values for different languages.

Well, my idea was to list the standards one per line (like on GCC manpage), and then the '(deprecated)' comments would probably stand out enough to apply to a single line. Also, FWICS the gcc manpage simply lists which aliases are deprecated in the description text. But skipping them entirely also works for me.

Sat, Apr 7, 11:49 PM
mgorny added a dependent revision for D45408: [LLVMTestingSupport] Add explicit linkage to LLVMSupport: D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build.
Sat, Apr 7, 1:46 PM
mgorny added a dependency for D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build: D45408: [LLVMTestingSupport] Add explicit linkage to LLVMSupport.
Sat, Apr 7, 1:46 PM
mgorny created D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build.
Sat, Apr 7, 1:46 PM
mgorny created D45408: [LLVMTestingSupport] Add explicit linkage to LLVMSupport.
Sat, Apr 7, 1:41 PM
mgorny added a comment to D45406: Document -std= values for different languages.

To be honest, I find those '(deprecated)' confusing — the user may mistakenly assume that it's about all values rather than the alias.

Sat, Apr 7, 12:29 PM
mgorny accepted D45233: [Driver] Update GCC libraries detection logic for Gentoo..

Works fine, thanks a lot! Note that I haven't tested crossdev or anything special, just regular multilib.

Sat, Apr 7, 12:26 PM
mgorny added a comment to D45233: [Driver] Update GCC libraries detection logic for Gentoo..

I'm sorry, I see the problem now — the diff generated by Phabricator does not include the empty files x_x (seriously, this thing keeps surprising me in how broken it could be). I'm going to try again with correct file set tonight or tomorrow. If you could send the complete patch (preferably -p1 if you have one) to mgorny AT gentoo.org, that would also be helpful.

Sat, Apr 7, 4:03 AM

Fri, Apr 6

mgorny added a comment to D45233: [Driver] Update GCC libraries detection logic for Gentoo..

Well, it's better:

Fri, Apr 6, 2:44 AM
mgorny added a comment to D45233: [Driver] Update GCC libraries detection logic for Gentoo..

To be honest, I don't really know. But since we're not installing it straight to /usr, I suppose that's not a problem we need to solve right now.

Fri, Apr 6, 12:02 AM

Thu, Apr 5

mgorny added a comment to D45233: [Driver] Update GCC libraries detection logic for Gentoo..

Ok, that's a problem. I think we really ought to consider all possibilites of sysroot first, and either do not fall back to main system at all or do that only if sysroot doesn't have any install at all. Basically, it is important that we don't break non-Gentoo sysroots, even when running on top of Gentoo.

Thu, Apr 5, 2:23 PM
mgorny added a comment to D45233: [Driver] Update GCC libraries detection logic for Gentoo..

Ok, I've tried it on top of clang-6.0.0 and I get the following test failures:

Thu, Apr 5, 12:49 PM

Wed, Apr 4

mgorny added a comment to D45233: [Driver] Update GCC libraries detection logic for Gentoo..

If that's not a problem, then the more tests, the merrier ;-). Preferably something specific to crossdev would be helpful, given this is a new use case, and/or something that would actually have directory mismatches with CURRENT entry name (i.e. that wouldn't have worked before).

Wed, Apr 4, 10:51 PM
mgorny added a comment to D45233: [Driver] Update GCC libraries detection logic for Gentoo..

Thanks. Besides that one tiny nit, looks good at a first glance. I'll test it tomorrow or the next day (but only for the most basic use, sorry).

Wed, Apr 4, 1:13 PM
mgorny requested changes to D45233: [Driver] Update GCC libraries detection logic for Gentoo..
Wed, Apr 4, 12:09 AM

Thu, Mar 29

mgorny abandoned D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt.
Thu, Mar 29, 12:20 AM

Mar 20 2018

mgorny added a comment to D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt.

@eugenis, updated.

Mar 20 2018, 8:55 AM
mgorny updated the diff for D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt.
Mar 20 2018, 8:55 AM

Mar 19 2018

mgorny created D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt.
Mar 19 2018, 1:03 PM
mgorny added inline comments to D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt.
Mar 19 2018, 1:03 PM

Mar 15 2018

mgorny abandoned D26175: [Driver] Fall back to plain '-plugin LLVMgold.so' if no lib at std path.
Mar 15 2018, 10:27 AM

Mar 12 2018

mgorny accepted D44391: Export LLVM_DYLIB_COMPONENTS in LLVMConfig.cmake.

Aye, sorry, I confused it with generated config ;-). It looks sane to me.

Mar 12 2018, 10:07 AM
mgorny added a comment to D44391: Export LLVM_DYLIB_COMPONENTS in LLVMConfig.cmake.

I don't see why not but I'm not sure if it has any value by itself. FWICS, LLVM_DYLIB_COMPONENTS is not used anywhere in cmake/*.

Mar 12 2018, 9:51 AM
mgorny added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:18 AM
mgorny added a comment to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).

Yes, full standalone.

Mar 12 2018, 8:03 AM
mgorny added a comment to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).

I can't test this right now but please make sure not to break linking to split shared libraries without dylib.

Mar 12 2018, 7:04 AM

Mar 8 2018

mgorny committed rL327007: [cmake] Append -Wl,-rpath-link conditionally to GNULD.
[cmake] Append -Wl,-rpath-link conditionally to GNULD
Mar 8 2018, 7:12 AM
mgorny closed D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.
Mar 8 2018, 7:12 AM
mgorny added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

Thanks for the review. As for the -Wl,-z,origin part, I'd rather leave that alone unless we have a clear indication that either it is not necessary for any of the supported FreeBSD and DragonFly BSD versions, or that it can be passed unconditionally without breaking any of the supported systems (and which linkers accept it).

Mar 8 2018, 7:11 AM

Mar 6 2018

mgorny committed rC326836: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.
[FrontEnd] Allow overriding the default C/C++ -std via CMake vars
Mar 6 2018, 1:28 PM
mgorny committed rL326836: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.
[FrontEnd] Allow overriding the default C/C++ -std via CMake vars
Mar 6 2018, 1:28 PM
mgorny closed D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.
Mar 6 2018, 1:28 PM
mgorny updated the diff for D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.

@rnk, could you confirm the rebased patch? I'm not sure if I should override InputKind::RenderScript as well.

Mar 6 2018, 10:38 AM

Mar 5 2018

mgorny added reviewers for D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD: ruiu, chapuni.
Mar 5 2018, 8:07 AM

Mar 2 2018

mgorny added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

Ping. I'd like to have this reviewed before I roll 6.0.0 final for Gentoo.

Mar 2 2018, 1:46 AM
mgorny added a comment to D43701: [cmake] Store LLVM_VERSION_SUFFIX in LLVMConfig.cmake.

Ping.

Mar 2 2018, 1:45 AM
mgorny added a comment to D39939: [cmake] Append LLVM_VERSION_SUFFIX to SOVERSION.

Ping.

Mar 2 2018, 1:45 AM

Feb 26 2018

mgorny created D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.
Feb 26 2018, 12:15 AM

Feb 24 2018

mgorny updated the diff for D39939: [cmake] Append LLVM_VERSION_SUFFIX to SOVERSION.

@beanz, updated as requested.

Feb 24 2018, 2:01 AM

Feb 23 2018

mgorny created D43701: [cmake] Store LLVM_VERSION_SUFFIX in LLVMConfig.cmake.
Feb 23 2018, 4:01 PM

Feb 19 2018

mgorny added a comment to D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.

Ping for the third time.

Feb 19 2018, 4:55 AM

Jan 29 2018

mgorny committed rL323673: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
[Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux
Jan 29 2018, 10:26 AM
mgorny closed D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
Jan 29 2018, 10:26 AM
mgorny added inline comments to D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
Jan 29 2018, 8:56 AM

Jan 20 2018

mgorny created D42331: [cmake] Remove LLVM_HAVE_OPT_VIEWER_MODULES from LLVMConfig.
Jan 20 2018, 1:59 AM

Jan 19 2018

mgorny added a comment to D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.

Disclaimer: I have never seen a plugin for LLDB. I've just noticed the wrong path in strace output and fixed it ;-).

Jan 19 2018, 2:35 PM
mgorny created D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux.
Jan 19 2018, 2:34 PM
mgorny committed rL322973: [cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006.
[cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006
Jan 19 2018, 9:49 AM
mgorny closed D42252: [cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006.
Jan 19 2018, 9:49 AM

Jan 18 2018

mgorny created D42252: [cmake] Include LLVM_LIBXML2_ENABLED in LLVMConfig.cmake, PR36006.
Jan 18 2018, 11:09 AM

Jan 9 2018

mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

I was talking of:

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

Ah, right. These uses were introduced before we developed a preference for llvm primitives. That said, I see a lot of compression stuff there, but I don't see mention of zlib directly.

Jan 9 2018, 6:51 AM
mgorny committed rL322081: [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.
[test] Fix tests to use more portable LLVM_ENABLE_ZLIB
Jan 9 2018, 6:45 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 9 2018, 6:45 AM

Jan 7 2018

mgorny updated the diff for D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

Updated the patch to use LLVM_ENABLE_ZLIB directly.

Jan 7 2018, 11:58 AM
mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

I was talking of:

Jan 7 2018, 2:11 AM

Jan 6 2018

mgorny committed rL321932: [test] Use full PATH lookup for tools.
[test] Use full PATH lookup for tools
Jan 6 2018, 2:21 AM
mgorny closed D41726: [test] Use full PATH lookup for tools.
Jan 6 2018, 2:21 AM
mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

Well, it's actually more complex. In Gentoo we want to let the user choose whether he wants to build against zlib or without zlib support. So in the end there are two uses to be considered:

Jan 6 2018, 2:15 AM
mgorny added a comment to D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.

Maybe we could. I presumed people are using the separate variables for some reason. We'd have to check that it's properly sanitized when building in-tree and given to cmake though.

Jan 6 2018, 1:28 AM

Jan 4 2018

mgorny created D41726: [test] Use full PATH lookup for tools.
Jan 4 2018, 5:58 AM
mgorny created D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB.
Jan 4 2018, 5:54 AM

Dec 13 2017

mgorny added inline comments to D41134: [compiler-rt] [builtins] Implement __chkstk for arm64 windows.
Dec 13 2017, 10:53 AM

Dec 11 2017

mgorny added inline comments to D37326: Fix the OCaml external linking problem.
Dec 11 2017, 12:09 PM

Nov 30 2017

mgorny committed rL319461: [cmake] Include project name in Sphinx doctree dir to fix race conditions.
[cmake] Include project name in Sphinx doctree dir to fix race conditions
Nov 30 2017, 11:09 AM
mgorny closed D40656: [cmake] Include project name in Sphinx doctree dir to fix race conditions by committing rL319461: [cmake] Include project name in Sphinx doctree dir to fix race conditions.
Nov 30 2017, 11:09 AM
mgorny created D40656: [cmake] Include project name in Sphinx doctree dir to fix race conditions.
Nov 30 2017, 9:27 AM

Nov 27 2017

mgorny committed rL319105: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
[cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading
Nov 27 2017, 2:23 PM
mgorny closed D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading by committing rL319105: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 27 2017, 2:23 PM
mgorny reopened D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 27 2017, 1:51 PM
mgorny updated the diff for D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.

Updated to fix unittest failure.

Nov 27 2017, 1:50 PM
mgorny committed rL319076: Revert r319069 - [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Revert r319069 - [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading
Nov 27 2017, 11:19 AM
mgorny committed rL319069: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
[cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading
Nov 27 2017, 10:35 AM
mgorny closed D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading by committing rL319069: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 27 2017, 10:35 AM

Nov 25 2017

mgorny created D40459: [cmake] Pass -Wl,-z,nodelete on Linux to prevent unloading.
Nov 25 2017, 3:23 PM

Nov 18 2017

mgorny added a comment to D40217: [LIT] Fix testing out-of-tree Clang builds.

Or even more abstract (if we assume we don't have to check for presence of llvm_tools_dir):

Nov 18 2017, 2:50 PM
mgorny added a comment to D40217: [LIT] Fix testing out-of-tree Clang builds.

To be honest, as I said before, I'm entirely confused by the logic there, with all the prepending, appending and shuffling around. But if you believe it gives the correct result, I'm all for it.

Nov 18 2017, 2:49 PM

Nov 17 2017

mgorny committed rL318562: [cmake] Use llvm-lit directory when provided for stand-alone build.
[cmake] Use llvm-lit directory when provided for stand-alone build
Nov 17 2017, 2:21 PM
mgorny closed D40142: [cmake] Use llvm-lit directory when provided for stand-alone build by committing rL318562: [cmake] Use llvm-lit directory when provided for stand-alone build.
Nov 17 2017, 2:21 PM
mgorny added a reviewer for D40142: [cmake] Use llvm-lit directory when provided for stand-alone build: zturner.
Nov 17 2017, 1:58 PM
mgorny committed rL318532: [CMake] Allow for Solaris ld -V output on stdout.
[CMake] Allow for Solaris ld -V output on stdout
Nov 17 2017, 9:12 AM
mgorny closed D39601: [CMake] Allow for Solaris ld -V output on stdout by committing rL318532: [CMake] Allow for Solaris ld -V output on stdout.
Nov 17 2017, 9:12 AM
mgorny accepted D39601: [CMake] Allow for Solaris ld -V output on stdout.

I don't see how this could break anything, and it's a pretty straightforward change.

Nov 17 2017, 12:17 AM

Nov 16 2017

mgorny created D40142: [cmake] Use llvm-lit directory when provided for stand-alone build.
Nov 16 2017, 11:13 AM
mgorny added a comment to D39842: Allow to store precompiled preambles in memory..

Please revert this commit. You've just broken all the stand-alone builds of clang.

Nov 16 2017, 9:12 AM

Nov 15 2017

mgorny added a comment to D39939: [cmake] Append LLVM_VERSION_SUFFIX to SOVERSION.

I'm worried that having a different first component of VERSION and SOVERSION could confuse some tools like ldconfig. I'm going to see if we can solve it via different install prefixes with RPATHs first.

Nov 15 2017, 2:08 PM

Nov 14 2017

mgorny added a comment to D39939: [cmake] Append LLVM_VERSION_SUFFIX to SOVERSION.

Hmm, that's an interesting option too. I was thinking of using LLVM_VERSION_SUFFIX originally but it obviously did not go to SOVERSION. Can this have any unforeseen consequences? Should VERSION become *major+suffix-0-minor* then?

Nov 14 2017, 11:15 PM
mgorny added a comment to D39939: [cmake] Append LLVM_VERSION_SUFFIX to SOVERSION.

We = Gentoo. What for is already described = to install libstdc++ and libc++ versions of LLVM simultaneously for rebuild period. How long = for the time being, or until we find a better working solution.

Nov 14 2017, 12:00 AM

Nov 11 2017

mgorny committed rL317986: [python] [tests] Fix test_linkage for unique external linkage.
[python] [tests] Fix test_linkage for unique external linkage
Nov 11 2017, 12:01 PM
mgorny closed D39810: [python] [tests] Fix test_linkage for unique external linkage by committing rL317986: [python] [tests] Fix test_linkage for unique external linkage.
Nov 11 2017, 12:01 PM
mgorny created D39939: [cmake] Append LLVM_VERSION_SUFFIX to SOVERSION.
Nov 11 2017, 4:54 AM