Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (136 w, 14 h)

Recent Activity

Today

mgorny committed rGc5d7bc86b89d: [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction (authored by mgorny).
[lldb] [Process/NetBSD] Use nullptr to fix template arg deduction
Mon, Mar 25, 3:29 PM
mgorny committed rLLDB356960: [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction.
[lldb] [Process/NetBSD] Use nullptr to fix template arg deduction
Mon, Mar 25, 3:28 PM
mgorny committed rL356960: [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction.
[lldb] [Process/NetBSD] Use nullptr to fix template arg deduction
Mon, Mar 25, 3:28 PM

Thu, Mar 21

mgorny committed rG2819136f0a3d: [lldb] Add missing EINTR handling (authored by mgorny).
[lldb] Add missing EINTR handling
Thu, Mar 21, 12:37 PM
mgorny committed rLLDB356703: [lldb] Add missing EINTR handling.
[lldb] Add missing EINTR handling
Thu, Mar 21, 12:36 PM
mgorny committed rL356703: [lldb] Add missing EINTR handling.
[lldb] Add missing EINTR handling
Thu, Mar 21, 12:36 PM
mgorny closed D59606: [lldb] Add missing EINTR handling.
Thu, Mar 21, 12:36 PM · Restricted Project, Restricted Project
mgorny added a comment to D59606: [lldb] Add missing EINTR handling.

Now, the curious thing is that so far I have 2 more test failures with this. I'll investigate closer, maybe it's just flakiness.

Thu, Mar 21, 4:01 AM · Restricted Project, Restricted Project
mgorny added inline comments to D59606: [lldb] Add missing EINTR handling.
Thu, Mar 21, 4:01 AM · Restricted Project, Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Applied requested changes.

Thu, Mar 21, 4:01 AM · Restricted Project, Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Thanks for the review. Addressed comments.

Thu, Mar 21, 1:39 AM · Restricted Project, Restricted Project
mgorny added inline comments to D59606: [lldb] Add missing EINTR handling.
Thu, Mar 21, 1:39 AM · Restricted Project, Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Covered more callsites.

Thu, Mar 21, 12:15 AM · Restricted Project, Restricted Project

Wed, Mar 20

mgorny created D59632: [llvm] [cmake] Add additional headers only if they exist.
Wed, Mar 20, 11:18 PM · Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Got rid of close() and fclose() wrapping, for now.

Wed, Mar 20, 12:08 PM · Restricted Project, Restricted Project
mgorny added a comment to D59606: [lldb] Add missing EINTR handling.

Hmm, I also see that LLVM has signal-safe Process::SafelyCloseFileDescriptor(). Should I use that, or just ignore potential issues with close()?

Wed, Mar 20, 11:58 AM · Restricted Project, Restricted Project
mgorny added a comment to D59606: [lldb] Add missing EINTR handling.

The "problem" I have with this is that (IIRC) retrying close(2) on EINTR is the *wrong* thing to do on linux (because the fd will be closed anyway, and so we may end up closing someone else's file the second time around). I'll try to dig up more info about that tomorrow.

Wed, Mar 20, 11:55 AM · Restricted Project, Restricted Project
mgorny created D59606: [lldb] Add missing EINTR handling.
Wed, Mar 20, 11:26 AM · Restricted Project, Restricted Project

Tue, Mar 19

mgorny committed rGae211ece6a90: [lldb] [Reproducer] Move SBRegistry registration into declaring files (authored by mgorny).
[lldb] [Reproducer] Move SBRegistry registration into declaring files
Tue, Mar 19, 10:14 AM
mgorny committed rL356481: [lldb] [Reproducer] Move SBRegistry registration into declaring files.
[lldb] [Reproducer] Move SBRegistry registration into declaring files
Tue, Mar 19, 10:14 AM
mgorny committed rLLDB356481: [lldb] [Reproducer] Move SBRegistry registration into declaring files.
[lldb] [Reproducer] Move SBRegistry registration into declaring files
Tue, Mar 19, 10:14 AM
mgorny closed D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.
Tue, Mar 19, 10:14 AM · Restricted Project
mgorny added a comment to D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

I'd also like to update the output of lldb-instr but I think that'd be better done in a separate patch.

Tue, Mar 19, 10:00 AM · Restricted Project
mgorny updated the diff for D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

Declare 'R' in unittest to fix build failure.

Tue, Mar 19, 9:59 AM · Restricted Project
mgorny added a comment to D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

Hmm but the tests fail to build for me ;-). I'm going to update this shortly.

Tue, Mar 19, 9:41 AM · Restricted Project
mgorny updated the diff for D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

Correct rebase: account for LLDB_DISABLE_PYTHON removal correctly.

Tue, Mar 19, 7:26 AM · Restricted Project
mgorny updated the diff for D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

Ok, here's the complete version, rebased. Note that I've built it before rebasing, and it's going to take a while before I rebuild it.

Tue, Mar 19, 7:22 AM · Restricted Project

Mon, Mar 18

mgorny updated the diff for D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

Hmm, actually with that local R declaration I don't have to have an additional set of macros ;-).

Mon, Mar 18, 10:53 AM · Restricted Project
mgorny updated the diff for D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

Does this look right? I've added temporary *2 versions of the macros to make it build without having to port everything. If it looks fine, I'll go with other files.

Mon, Mar 18, 10:47 AM · Restricted Project

Sat, Mar 16

mgorny updated the diff for D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

Ok, here's my first attempt at moving stuff but I'm getting load of errors and I can't figure out what I need to do to get the right symbols.

Sat, Mar 16, 11:56 AM · Restricted Project

Fri, Mar 15

mgorny created D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.
Fri, Mar 15, 12:21 PM · Restricted Project

Thu, Mar 14

mgorny updated the diff for D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.

Implemented @ruiu's suggestions.

Thu, Mar 14, 11:10 AM · Restricted Project
mgorny added inline comments to D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK.
Thu, Mar 14, 11:09 AM · Restricted Project

Wed, Mar 13

mgorny added a comment to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].

-lunwind has the disadvantage of picking up whatever libunwind happens to be first in the search path. Fixing that would require moving llvm-libunwind into compiler-rt and naming it differently.

Wed, Mar 13, 10:16 AM · Restricted Project

Tue, Mar 12

mgorny updated the diff for D59249: [llvm] [Support] mallctl() is in malloc.h on NetBSD.

Updated to use dedicated header checks, as requested by @krytarowski

Tue, Mar 12, 12:54 PM · Restricted Project
mgorny created D59249: [llvm] [Support] mallctl() is in malloc.h on NetBSD.
Tue, Mar 12, 6:24 AM · Restricted Project

Mon, Mar 11

mgorny committed rGb94c24e2acc7: [lldb] [test] Mark more tests flakey on NetBSD (authored by mgorny).
[lldb] [test] Mark more tests flakey on NetBSD
Mon, Mar 11, 10:03 AM
mgorny committed rLLDB355838: [lldb] [test] Mark more tests flakey on NetBSD.
[lldb] [test] Mark more tests flakey on NetBSD
Mon, Mar 11, 10:03 AM
mgorny committed rL355838: [lldb] [test] Mark more tests flakey on NetBSD.
[lldb] [test] Mark more tests flakey on NetBSD
Mon, Mar 11, 10:03 AM
mgorny committed rG3aa36c9a47f0: [lldb] [test] Mark a few tests flakey on NetBSD (authored by mgorny).
[lldb] [test] Mark a few tests flakey on NetBSD
Mon, Mar 11, 8:46 AM
mgorny committed rL355830: [lldb] [test] Mark a few tests flakey on NetBSD.
[lldb] [test] Mark a few tests flakey on NetBSD
Mon, Mar 11, 8:45 AM
mgorny committed rLLDB355830: [lldb] [test] Mark a few tests flakey on NetBSD.
[lldb] [test] Mark a few tests flakey on NetBSD
Mon, Mar 11, 8:45 AM

Sun, Mar 10

mgorny committed rLLDB355786: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable.
[lldb] [test] Make 2lwp_process_SIGSEGV test more portable
Sun, Mar 10, 1:51 AM
mgorny committed rG369a011cee07: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable (authored by mgorny).
[lldb] [test] Make 2lwp_process_SIGSEGV test more portable
Sun, Mar 10, 1:51 AM
mgorny committed rL355786: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable.
[lldb] [test] Make 2lwp_process_SIGSEGV test more portable
Sun, Mar 10, 1:49 AM
mgorny closed D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable.
Sun, Mar 10, 1:49 AM · Restricted Project, Restricted Project
mgorny updated the diff for D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable.

Updated as requested by @krytarowski

Sun, Mar 10, 12:42 AM · Restricted Project, Restricted Project
mgorny added a comment to rL344218: [CMake] Unconditionally add .h and .td files to target sources.

This is causing build failures to some of our users: https://bugs.gentoo.org/674662

Sun, Mar 10, 12:33 AM
mgorny raised a concern with rL344218: [CMake] Unconditionally add .h and .td files to target sources.
Sun, Mar 10, 12:33 AM

Sat, Mar 9

mgorny created D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable.
Sat, Mar 9, 10:03 AM · Restricted Project, Restricted Project
mgorny committed rG377d9dc8728a: [lldb] [test] Adjust XFAIL list to match buildbot results (authored by mgorny).
[lldb] [test] Adjust XFAIL list to match buildbot results
Sat, Mar 9, 4:47 AM
mgorny committed rLLDB355774: [lldb] [test] Adjust XFAIL list to match buildbot results.
[lldb] [test] Adjust XFAIL list to match buildbot results
Sat, Mar 9, 4:47 AM
mgorny committed rL355774: [lldb] [test] Adjust XFAIL list to match buildbot results.
[lldb] [test] Adjust XFAIL list to match buildbot results
Sat, Mar 9, 4:46 AM

Fri, Mar 8

mgorny committed rG942e6c7c9e36: [lldb] [test] Skip broken NetBSD core test (authored by mgorny).
[lldb] [test] Skip broken NetBSD core test
Fri, Mar 8, 2:41 PM
mgorny committed rLLDB355750: [lldb] [test] Skip broken NetBSD core test.
[lldb] [test] Skip broken NetBSD core test
Fri, Mar 8, 2:41 PM
mgorny committed rL355750: [lldb] [test] Skip broken NetBSD core test.
[lldb] [test] Skip broken NetBSD core test
Fri, Mar 8, 2:41 PM
mgorny committed rG7b374be94652: [lldb] [test] Do not check libc function names in NetBSD core test (authored by mgorny).
[lldb] [test] Do not check libc function names in NetBSD core test
Fri, Mar 8, 2:34 PM
mgorny committed rL355747: [lldb] [test] Do not check libc function names in NetBSD core test.
[lldb] [test] Do not check libc function names in NetBSD core test
Fri, Mar 8, 2:34 PM
mgorny committed rLLDB355747: [lldb] [test] Do not check libc function names in NetBSD core test.
[lldb] [test] Do not check libc function names in NetBSD core test
Fri, Mar 8, 2:34 PM
mgorny committed rGc12f159788dc: [lldb] [Process] Add proper support for NetBSD core files with threads (authored by mgorny).
[lldb] [Process] Add proper support for NetBSD core files with threads
Fri, Mar 8, 1:10 PM
mgorny committed rLLDB355736: [lldb] [Process] Add proper support for NetBSD core files with threads.
[lldb] [Process] Add proper support for NetBSD core files with threads
Fri, Mar 8, 1:10 PM
mgorny committed rL355736: [lldb] [Process] Add proper support for NetBSD core files with threads.
[lldb] [Process] Add proper support for NetBSD core files with threads
Fri, Mar 8, 1:09 PM
mgorny closed D32149: [lldb] [Process] Add proper support for NetBSD core files with threads.
Fri, Mar 8, 1:09 PM · Restricted Project, Restricted Project

Thu, Mar 7

mgorny added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Thu, Mar 7, 8:15 PM · Restricted Project
mgorny added a comment to D59116: [scudo][standalone] Implement checksumming functions.

If you have to bundle a new hash, have you considered using one of the modern fast hashes (such as xxHash, CityHash, …)?

Thu, Mar 7, 8:07 PM · Restricted Project, Restricted Project
mgorny updated the diff for D32149: [lldb] [Process] Add proper support for NetBSD core files with threads.

I've added one more test case, and added stop reason/signal checking for both threads. I think it's ready for review now.

Thu, Mar 7, 12:33 AM · Restricted Project, Restricted Project

Wed, Mar 6

mgorny added a comment to D57475: [Reproducers] Add SBReproducer macros.

This is still breaking NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/19339/steps/ninja%20build%20local/logs/stdio

Wed, Mar 6, 11:16 PM · Restricted Project
mgorny updated the diff for D32149: [lldb] [Process] Add proper support for NetBSD core files with threads.

Added two tests, more pending. Sadly, I wasn't able to reuse even the test cases since -nostdlib doesn't really work on NetBSD (resulting executables are not recognized as valid executables).

Wed, Mar 6, 12:04 PM · Restricted Project, Restricted Project
mgorny updated the diff for D32149: [lldb] [Process] Add proper support for NetBSD core files with threads.

Updated to read PID and make unknown notes non-fatal.

Wed, Mar 6, 10:43 AM · Restricted Project, Restricted Project
mgorny committed rG2508fcff605a: [lldb] [lit] Attempt to fix regex in toolchain-clang.test (authored by mgorny).
[lldb] [lit] Attempt to fix regex in toolchain-clang.test
Wed, Mar 6, 6:49 AM
mgorny committed rL355510: [lldb] [lit] Attempt to fix regex in toolchain-clang.test.
[lldb] [lit] Attempt to fix regex in toolchain-clang.test
Wed, Mar 6, 6:49 AM
mgorny committed rLLDB355510: [lldb] [lit] Attempt to fix regex in toolchain-clang.test.
[lldb] [lit] Attempt to fix regex in toolchain-clang.test
Wed, Mar 6, 6:49 AM
mgorny updated the diff for D32149: [lldb] [Process] Add proper support for NetBSD core files with threads.

I've attempted to rebase Kamil's patch against the current sources. Please note that this is not the final version; I'll add a test case and PID reading later.

Wed, Mar 6, 6:47 AM · Restricted Project, Restricted Project
mgorny committed rGa2cc148f9fee: [lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD (authored by mgorny).
[lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD
Wed, Mar 6, 6:03 AM
mgorny committed rLLDB355502: [lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD.
[lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD
Wed, Mar 6, 6:03 AM
mgorny committed rL355502: [lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD.
[lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD
Wed, Mar 6, 6:03 AM
mgorny closed D58630: [lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD.
Wed, Mar 6, 6:03 AM · Restricted Project, Restricted Project

Tue, Mar 5

mgorny updated the diff for D58630: [lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD.

Updated to make it all conditional to NetBSD, as discussed.

Tue, Mar 5, 10:52 AM · Restricted Project, Restricted Project

Mon, Mar 4

mgorny committed rLLDB355320: [lldb] [test] Mark failing tests XFAIL on NetBSD.
[lldb] [test] Mark failing tests XFAIL on NetBSD
Mon, Mar 4, 8:57 AM
mgorny committed rGde11105d2ece: [lldb] [test] Mark failing tests XFAIL on NetBSD (authored by mgorny).
[lldb] [test] Mark failing tests XFAIL on NetBSD
Mon, Mar 4, 8:55 AM
mgorny committed rL355320: [lldb] [test] Mark failing tests XFAIL on NetBSD.
[lldb] [test] Mark failing tests XFAIL on NetBSD
Mon, Mar 4, 8:55 AM
mgorny closed D58527: [lldb] [test] Mark failing tests XFAIL on NetBSD.
Mon, Mar 4, 8:53 AM · Restricted Project, Restricted Project
mgorny added inline comments to D35169: Refactor DragonFly BSD toolchain driver..
Mon, Mar 4, 6:49 AM
mgorny accepted D35125: Unbreak shared library linkage on DragonFlyBSD..
Mon, Mar 4, 6:29 AM · Restricted Project

Sun, Mar 3

mgorny abandoned D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

I'm not going to pursue this further.

Sun, Mar 3, 8:54 PM · Restricted Project
mgorny reopened D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

Reverted in r355302. It seems that it is unreliable and sometimes evaluates to empty path, breaking clang.

Sun, Mar 3, 8:53 PM · Restricted Project
mgorny committed rG2d8be64401e8: [llvm] [Support] Revert "Reimplement getMainExecutable() using sysctl on NetBSD" (authored by mgorny).
[llvm] [Support] Revert "Reimplement getMainExecutable() using sysctl on NetBSD"
Sun, Mar 3, 8:53 PM
mgorny committed rL355302: [llvm] [Support] Revert "Reimplement getMainExecutable() using sysctl on NetBSD".
[llvm] [Support] Revert "Reimplement getMainExecutable() using sysctl on NetBSD"
Sun, Mar 3, 8:52 PM
mgorny added a comment to D58527: [lldb] [test] Mark failing tests XFAIL on NetBSD.

Thanks. I'm going to retest/update it for master first.

Sun, Mar 3, 7:17 AM · Restricted Project, Restricted Project
mgorny committed rGe39ec43be77b: [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally() (authored by mgorny).
[lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()
Sun, Mar 3, 4:45 AM
mgorny committed rLLDB355285: [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally().
[lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()
Sun, Mar 3, 4:44 AM
mgorny committed rL355285: [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally().
[lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()
Sun, Mar 3, 4:44 AM
mgorny closed D58883: [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally().
Sun, Mar 3, 4:44 AM · Restricted Project, Restricted Project
mgorny committed rG8f04766d1334: [llvm] [Support] Reimplement getMainExecutable() using sysctl on NetBSD (authored by mgorny).
[llvm] [Support] Reimplement getMainExecutable() using sysctl on NetBSD
Sun, Mar 3, 2:07 AM
mgorny committed rGd3516b51cae6: [clang] [ToolChains/NetBSD] Support relative libc++ header path (authored by mgorny).
[clang] [ToolChains/NetBSD] Support relative libc++ header path
Sun, Mar 3, 2:06 AM
mgorny committed rC355282: [clang] [ToolChains/NetBSD] Support relative libc++ header path.
[clang] [ToolChains/NetBSD] Support relative libc++ header path
Sun, Mar 3, 2:06 AM
mgorny committed rL355283: [llvm] [Support] Reimplement getMainExecutable() using sysctl on NetBSD.
[llvm] [Support] Reimplement getMainExecutable() using sysctl on NetBSD
Sun, Mar 3, 2:06 AM
mgorny closed D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.
Sun, Mar 3, 2:06 AM · Restricted Project
mgorny committed rL355282: [clang] [ToolChains/NetBSD] Support relative libc++ header path.
[clang] [ToolChains/NetBSD] Support relative libc++ header path
Sun, Mar 3, 2:06 AM
mgorny closed D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path.
Sun, Mar 3, 2:06 AM · Restricted Project, Restricted Project