mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (61 w, 2 d)

Recent Activity

Yesterday

mgorny added inline comments to D37326: Fix the OCaml external linking problem.
Tue, Oct 17, 8:06 AM

Thu, Oct 12

mgorny committed rL315620: [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.
[cmake] [asan] Remove unnecessary gtest dep from dynamic tests
Thu, Oct 12, 2:07 PM
mgorny closed D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests by committing rL315620: [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.
Thu, Oct 12, 2:07 PM
mgorny updated the diff for D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.

Ok, here's another idea. Since the objects have been compiled already (and they explicitly depend on gtest via their own deps), let's just remove the extraneous gtest dep.

Thu, Oct 12, 12:31 PM
mgorny committed rL315605: [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS.
[cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS
Thu, Oct 12, 11:52 AM
mgorny committed rL315604: [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile().
[cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()
Thu, Oct 12, 11:52 AM
mgorny closed D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS by committing rL315605: [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS.
Thu, Oct 12, 11:51 AM
mgorny closed D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile() by committing rL315604: [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile().
Thu, Oct 12, 11:51 AM
mgorny added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

D38838 addresses the typo. Now that I know how it's supposed to work, D38839 and D38840 address the issues, and fix it for me.

Thu, Oct 12, 1:54 AM
mgorny created D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.
Thu, Oct 12, 1:50 AM
mgorny created D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS.
Thu, Oct 12, 1:47 AM
mgorny created D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile().
Thu, Oct 12, 1:46 AM
mgorny abandoned D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

Ok, I think I've found a better solution. Will start submitting patches soonish.

Thu, Oct 12, 1:44 AM
mgorny added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

@mgorny I've replied via email, but the message didn't seem to appear here.

From my (maybe limited) understanding, running tests on standalone compiler-rt builds was never something which was supported, as that required a fresh compiler.
I've just tried running them, and for me even check-* targets don't exist.

How do you create the standalone build? I've checked out compiler-rt separately, and ran

cmake -GNinja -DLLVM_CONFIG=/Users/george/code/llvm/release-build/bin/llvm-config  ../.
Thu, Oct 12, 12:20 AM

Mon, Oct 2

mgorny added a comment to D38471: Allow compiler-rt test targets to work with multi-config CMake generators.

Yes, I did apply it both to the installed CMake files and the external LLVM source tree used by compiler-rt. I can't see where else it could have gotten an old version from, and I don't grep any AddLLVM includes either.

Mon, Oct 2, 2:13 PM
mgorny added a comment to D38471: Allow compiler-rt test targets to work with multi-config CMake generators.

Well, I think I did everything right, yet I still get:

Mon, Oct 2, 1:19 PM
mgorny added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

breaking stand-alone builds as a result

That's a strong statement. Could you clarify? We have a lot of buildbots performing standalone builds, and they are still green.

Mon, Oct 2, 12:57 PM
mgorny added a comment to D38471: Allow compiler-rt test targets to work with multi-config CMake generators.

Could you give me a few minutes to test it before merging, please?

Mon, Oct 2, 12:55 PM

Sun, Oct 1

mgorny committed rL314646: [cmake] Add a separate CMake var to control profile runtime.
[cmake] Add a separate CMake var to control profile runtime
Sun, Oct 1, 10:05 PM
mgorny closed D38441: [compiler-rt] [cmake] Add a separate CMake var to control profile runtime by committing rL314646: [cmake] Add a separate CMake var to control profile runtime.
Sun, Oct 1, 10:05 PM
mgorny created D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.
Sun, Oct 1, 4:28 AM
mgorny added reviewers for D38441: [compiler-rt] [cmake] Add a separate CMake var to control profile runtime: chapuni, beanz.
Sun, Oct 1, 1:45 AM
mgorny committed rL314620: [lit] Fix running lit tests in unconfigured source dir.
[lit] Fix running lit tests in unconfigured source dir
Sun, Oct 1, 12:15 AM
mgorny closed D38442: [lit] Fix running lit tests in unconfigured source dir by committing rL314620: [lit] Fix running lit tests in unconfigured source dir.
Sun, Oct 1, 12:15 AM

Sat, Sep 30

mgorny created D38442: [lit] Fix running lit tests in unconfigured source dir.
Sat, Sep 30, 2:17 PM
mgorny created D38441: [compiler-rt] [cmake] Add a separate CMake var to control profile runtime.
Sat, Sep 30, 1:09 AM

Sep 8 2017

mgorny closed D37378: [clang] [python] Move test_exception_specification_kind to correct subdir.

It seems that somebody already moved the file in D37490.

Sep 8 2017, 3:17 AM
mgorny added a reviewer for D37378: [clang] [python] Move test_exception_specification_kind to correct subdir: chapuni.
Sep 8 2017, 2:03 AM
mgorny added a comment to D37378: [clang] [python] Move test_exception_specification_kind to correct subdir.

Ping.

Sep 8 2017, 2:03 AM

Sep 1 2017

mgorny created D37378: [clang] [python] Move test_exception_specification_kind to correct subdir.
Sep 1 2017, 6:47 AM
mgorny added a comment to D34091: Support for querying the exception specification type through libclang.

Nevermind. I found out what's wrong via looking at the older patch versions.

Sep 1 2017, 6:42 AM
mgorny added a comment to D34091: Support for querying the exception specification type through libclang.

@ajbennieston, ping.

Sep 1 2017, 6:36 AM

Aug 31 2017

mgorny added inline comments to D37326: Fix the OCaml external linking problem.
Aug 31 2017, 7:06 AM

Aug 30 2017

mgorny added reviewers for D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars: compnerd, rnk.
Aug 30 2017, 4:09 AM
mgorny added a comment to D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars.

Ping again.

Aug 30 2017, 4:09 AM

Aug 29 2017

mgorny added a comment to D37278: Restore clang_rt library name on i686-android..

Thanks a lot for taking care of this.

Aug 29 2017, 11:22 PM
mgorny added a comment to D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386.

I'm happy to help with whatever needs to be done to keep breakage to the minimum, provided that we determine some clear path forward that doesn't involve regressing to the half-broken state for non-Android Linux systems and it's doable in the free time I can spare. However, I should point out that it was a very bad idea to hardcode paths all over the projects in the first place.

Aug 29 2017, 12:09 PM

Aug 28 2017

mgorny committed rL311983: [cmake] Support running extra clang tool tests without static analyzer.
[cmake] Support running extra clang tool tests without static analyzer
Aug 28 2017, 10:59 PM
mgorny closed D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer by committing rL311983: [cmake] Support running extra clang tool tests without static analyzer.
Aug 28 2017, 10:59 PM
mgorny added a comment to D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer.

Thanks for the clarification.

Aug 28 2017, 10:57 PM
mgorny committed rL311925: [sanitizer] Update i686->i386 to match rename in compiler-rt.
[sanitizer] Update i686->i386 to match rename in compiler-rt
Aug 28 2017, 1:32 PM
mgorny committed rL311926: [sanitizer] Move Android arm comment earlier (requested by eugenis).
[sanitizer] Move Android arm comment earlier (requested by eugenis)
Aug 28 2017, 1:32 PM
mgorny closed D37226: [zorg] [sanitizer] Update i686->i386 to match rename in compiler-rt by committing rL311925: [sanitizer] Update i686->i386 to match rename in compiler-rt.
Aug 28 2017, 1:32 PM · Restricted Project
mgorny committed rL311924: Reland r311842 - [cmake] Remove i686 target that is duplicate to i386.
Reland r311842 - [cmake] Remove i686 target that is duplicate to i386
Aug 28 2017, 1:31 PM
mgorny closed D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386 by committing rL311924: Reland r311842 - [cmake] Remove i686 target that is duplicate to i386.
Aug 28 2017, 1:31 PM
mgorny committed rL311923: Reland r311836 - [Driver] Use arch type to find compiler-rt libraries (on Linux).
Reland r311836 - [Driver] Use arch type to find compiler-rt libraries (on Linux)
Aug 28 2017, 1:31 PM
mgorny closed D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux) by committing rL311923: Reland r311836 - [Driver] Use arch type to find compiler-rt libraries (on Linux).
Aug 28 2017, 1:31 PM
mgorny added inline comments to D37226: [zorg] [sanitizer] Update i686->i386 to match rename in compiler-rt.
Aug 28 2017, 1:00 PM · Restricted Project
mgorny added a comment to D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

@eugenis, thanks for the suggestion. I've found the problematic push (that attempts to move the wrong file) and filed D37226 for review.

Aug 28 2017, 11:53 AM
mgorny added a dependency for D37226: [zorg] [sanitizer] Update i686->i386 to match rename in compiler-rt: D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386.
Aug 28 2017, 11:52 AM · Restricted Project
mgorny added a dependent revision for D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386: D37226: [zorg] [sanitizer] Update i686->i386 to match rename in compiler-rt.
Aug 28 2017, 11:52 AM
mgorny created D37226: [zorg] [sanitizer] Update i686->i386 to match rename in compiler-rt.
Aug 28 2017, 11:52 AM · Restricted Project
mgorny added a comment to D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer.

I might be missing something but currently clang-tidy is not built at all when static analyzer is disabled.

Aug 28 2017, 9:07 AM

Aug 27 2017

mgorny reopened D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386.

I have reverted the changes for now to fix Android.

Aug 27 2017, 1:59 PM
mgorny reopened D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

I have reverted the changes for now to fix Android.

Aug 27 2017, 1:59 PM
mgorny committed rL311861: Revert r311836 - [Driver] Use arch type to find compiler-rt libraries (on Linux).
Revert r311836 - [Driver] Use arch type to find compiler-rt libraries (on Linux)
Aug 27 2017, 1:40 PM
mgorny committed rL311859: Revert r311842 - [cmake] Remove i686 target that is duplicate to i386.
Revert r311842 - [cmake] Remove i686 target that is duplicate to i386
Aug 27 2017, 1:40 PM
mgorny added inline comments to D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer.
Aug 27 2017, 3:18 AM
mgorny created D37188: [clang-tools-extra] [cmake] Support running extra clang tool tests without static analyzer.
Aug 27 2017, 3:18 AM
mgorny resigned from D36555: Move x86-specific sources to x86-specific source lists..

I'm not going to block this but I agree with others that the PPC changes look like they belong in a separate commit.

Aug 27 2017, 3:11 AM
mgorny added a comment to D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

The problems:

Aug 27 2017, 1:44 AM
mgorny added a comment to D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

@eugenis, it seems that this broke the Android buildbot. Could you suggest an appropriate course of action? I suppose we either have to fix Android-something to use i386, or keep using i686 for Android. The latter I know how to do but for the former, I have no clue where the issue might be.

Aug 27 2017, 1:43 AM
mgorny committed rL311842: [cmake] Remove i686 target that is duplicate to i386.
[cmake] Remove i686 target that is duplicate to i386
Aug 27 2017, 12:48 AM
mgorny closed D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386 by committing rL311842: [cmake] Remove i686 target that is duplicate to i386.
Aug 27 2017, 12:48 AM
mgorny updated the diff for D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386.

I'm going to commit this now to see if it helps with the Android buildbot. Updating to the rebased patch that's going to be committed.

Aug 27 2017, 12:48 AM

Aug 26 2017

mgorny added a comment to D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

Thanks a lot. Let's hope no buildbot complains now ;-).

Aug 26 2017, 2:36 PM
mgorny committed rL311836: [Driver] Use arch type to find compiler-rt libraries (on Linux).
[Driver] Use arch type to find compiler-rt libraries (on Linux)
Aug 26 2017, 2:36 PM
mgorny closed D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux) by committing rL311836: [Driver] Use arch type to find compiler-rt libraries (on Linux).
Aug 26 2017, 2:36 PM
mgorny updated the diff for D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux).

Rebased the patch since it no longer applied.

Aug 26 2017, 12:59 PM

Aug 22 2017

mgorny added inline comments to D36555: Move x86-specific sources to x86-specific source lists..
Aug 22 2017, 9:29 PM

Aug 21 2017

mgorny added a comment to D36980: [LLVM] Moving libFuzzer from LLVM to compiler-rt.

Shouldn't the title be the other way around?

Aug 21 2017, 2:10 PM
mgorny added a comment to D36908: Moving libFuzzer to compiler-rt.

Ok, the first thing that I've noticed is that the compiler-rt version does not build with gcc:

@mgorny this is actually due to change proposed in https://reviews.llvm.org/D36887.
I am not sure what is the correct strategy here: previously, the flag was behind the guard, which was never set for gcc.
I don't think it is correct to rely on LLVM_* variable from a compiler-rt repository.
I can also test whether the flag is available first before compiling.

Aug 21 2017, 11:25 AM
mgorny committed rL311355: [unittests] Build LLVMTestingSupport for out-of-source builds.
[unittests] Build LLVMTestingSupport for out-of-source builds
Aug 21 2017, 10:44 AM
mgorny committed rL311354: [cmake] Explicitly link dependency libraries in the Host library.
[cmake] Explicitly link dependency libraries in the Host library
Aug 21 2017, 10:44 AM
mgorny closed D36886: [unittests] Build LLVMTestingSupport for out-of-source builds by committing rL311355: [unittests] Build LLVMTestingSupport for out-of-source builds.
Aug 21 2017, 10:44 AM · Restricted Project
mgorny closed D36885: [cmake] Explicitly link dependency libraries in the Host library by committing rL311354: [cmake] Explicitly link dependency libraries in the Host library.
Aug 21 2017, 10:43 AM · Restricted Project

Aug 19 2017

mgorny added a comment to D36908: Moving libFuzzer to compiler-rt.

Ok, the first thing that I've noticed is that the compiler-rt version does not build with gcc:

Aug 19 2017, 1:59 PM
mgorny added a comment to D36908: Moving libFuzzer to compiler-rt.

A side notice but wouldn't it be better to make libFuzzer a completely separate component (like openmp)? I've seen people take interest in it outside LLVM toolchain.

Aug 19 2017, 12:29 AM
mgorny added inline comments to D36885: [cmake] Explicitly link dependency libraries in the Host library.
Aug 19 2017, 12:08 AM · Restricted Project

Aug 18 2017

mgorny created D36886: [unittests] Build LLVMTestingSupport for out-of-source builds.
Aug 18 2017, 11:17 AM · Restricted Project
mgorny created D36885: [cmake] Explicitly link dependency libraries in the Host library.
Aug 18 2017, 11:15 AM · Restricted Project

Aug 17 2017

mgorny committed rL311122: [cmake] Add explicit linkage from Core to curses.
[cmake] Add explicit linkage from Core to curses
Aug 17 2017, 1:35 PM
mgorny closed D36358: [lldb] [cmake] Add explicit linkage from Core to curses by committing rL311122: [cmake] Add explicit linkage from Core to curses.
Aug 17 2017, 1:35 PM

Aug 14 2017

mgorny added a comment to D36358: [lldb] [cmake] Add explicit linkage from Core to curses.

Ping.

Aug 14 2017, 12:59 AM

Aug 11 2017

mgorny requested changes to D36555: Move x86-specific sources to x86-specific source lists..

Also, I think that if you're splitting them up, it'd also logical to move them into a subdirectory, x86-common maybe.

Aug 11 2017, 11:31 PM
mgorny committed rL310712: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.
[cmake] Expose the dependencies of ExecutionEngine as PUBLIC
Aug 11 2017, 6:27 AM
mgorny closed D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC by committing rL310712: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.
Aug 11 2017, 6:27 AM
mgorny added a comment to D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

No problem at all. Thanks a lot.

Aug 11 2017, 6:27 AM
mgorny updated the diff for D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

Updated with @chapuni's patch. Please confirm it's good to go.

Aug 11 2017, 6:12 AM

Aug 5 2017

mgorny updated the diff for D36358: [lldb] [cmake] Add explicit linkage from Core to curses.

Updated to explicitly respect LLDB_DISABLE_CURSES and the LLVM HAVE_TERMINFO logic.

Aug 5 2017, 1:49 PM
mgorny updated the diff for D36358: [lldb] [cmake] Add explicit linkage from Core to curses.

Forgive my poor eyesight, obviously this could go into existing LINK_LIBS ;-).

Aug 5 2017, 9:15 AM
mgorny created D36358: [lldb] [cmake] Add explicit linkage from Core to curses.
Aug 5 2017, 8:32 AM
mgorny added a comment to D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

@chapuni, this fixes the issue for me as well. Will you commit it or should I update this revision with your patch?

Aug 5 2017, 2:57 AM
mgorny abandoned D31367: Expression: add missing linkage to RuntimeDyld component.
Aug 5 2017, 2:54 AM · Restricted Project

Aug 3 2017

mgorny committed rL309979: [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.
[test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build
Aug 3 2017, 12:42 PM
mgorny closed D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build by committing rL309979: [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build.
Aug 3 2017, 12:42 PM · Restricted Project

Aug 2 2017

mgorny reopened D31367: Expression: add missing linkage to RuntimeDyld component.

Well, @chapuni disagrees on D36211. Which way should we go then?

Aug 2 2017, 1:26 AM · Restricted Project
mgorny added a reviewer for D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC: chapuni.
Aug 2 2017, 1:09 AM
mgorny updated subscribers of D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.

Well, that was my original idea but @beanz wanted it the other way around ;-). I'm fine either way, as long as it works.

Aug 2 2017, 1:04 AM

Aug 1 2017

mgorny created D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC.
Aug 1 2017, 11:12 PM