Page MenuHomePhabricator

mgorny (Michał Górny)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2016, 6:00 AM (252 w, 3 d)

Recent Activity

Fri, Jun 4

mgorny abandoned D85278: [lld] Support building shared libLLD.so.

I'm not going to put any more effort into this. If you have time and motivation to work on this, feel free to take it over.

Fri, Jun 4, 8:18 AM · lld

May 12 2021

mgorny committed rG71e66da04cf1: [Process/elf-core] Read PID from FreeBSD prpsinfo (authored by mgorny).
[Process/elf-core] Read PID from FreeBSD prpsinfo
May 12 2021, 2:52 AM
mgorny committed rGb6c0edb9792c: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores (authored by mgorny).
[lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores
May 12 2021, 2:52 AM
mgorny closed D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.
May 12 2021, 2:52 AM · Restricted Project
mgorny closed D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.
May 12 2021, 2:52 AM · Restricted Project

May 5 2021

mgorny requested review of D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.
May 5 2021, 4:09 AM · Restricted Project

May 3 2021

mgorny added inline comments to D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers.
May 3 2021, 4:10 AM

May 1 2021

mgorny committed rGdb457e64794c: [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes (authored by mgorny).
[lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes
May 1 2021, 1:51 PM
mgorny closed D101521: [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes.
May 1 2021, 1:51 PM · Restricted Project
mgorny retitled D101329: [lldb] Support SaveCore() from gdb-remote client from [lldb] Support SaveCore() from gdb-remote client [WIP] to [lldb] Support SaveCore() from gdb-remote client.
May 1 2021, 1:14 PM

Apr 29 2021

mgorny requested review of D101563: [lldb] [test] Extend aarch64-gp-read test to cover all registers.
Apr 29 2021, 12:54 PM
mgorny requested review of D101521: [lldb] [Process/FreeBSD] Fix arm64 build after RegisterInfoPOSIX_arm64 changes.
Apr 29 2021, 4:57 AM · Restricted Project
mgorny added a comment to D96458: [LLDB] Add support for Arm64/Linux dynamic register sets.

This changed the API of RegisterInfoPOSIX_arm64 and broke the FreeBSD plugin. I'm going to try to fix it but next time it'd be nice if you checked that the class isn't used by something before making changes to its API.

Apr 29 2021, 4:26 AM · Restricted Project
mgorny added a comment to D101509: An attempt to abandon omptarget out-of-tree builds..

Is this going to block all direct builds of openmp or just these that don't have an LLVM source tree handy?

This is aimed at libomptarget, libopenmp can still build without llvm, provided it excludes the target part.

Apr 29 2021, 3:12 AM · Restricted Project
mgorny added a comment to D101157: [lldb] [test] Add tests for coredumps with multiple threads.

@labath, could you give me at least a rough idea how you feel about this one? I'd like to know if I need to change the test code before I start adding coredumps for more architectures.

Apr 29 2021, 2:19 AM
mgorny added a comment to D101509: An attempt to abandon omptarget out-of-tree builds..

Is this going to block all direct builds of openmp or just these that don't have an LLVM source tree handy? Also, do you really need *sources* and not just compiled libLLVM?

Apr 29 2021, 12:02 AM · Restricted Project

Apr 28 2021

mgorny added inline comments to D97282: [lldb][AArch64] Add memory-tagging qSupported feature.
Apr 28 2021, 8:30 AM · Restricted Project
mgorny added a comment to D97282: [lldb][AArch64] Add memory-tagging qSupported feature.

@mgorny Can you take a quick look and see if I'm adding this new feature correctly?

Apr 28 2021, 8:29 AM · Restricted Project
mgorny updated the diff for D101285: [lldb] [llgs server] Support creating core dumps on NetBSD.

Use a temporary file if path-hint is not writable.

Apr 28 2021, 4:05 AM
mgorny updated the diff for D101329: [lldb] Support SaveCore() from gdb-remote client.

Send path-hint to the server. Add a test.

Apr 28 2021, 3:50 AM
mgorny added inline comments to D100261: [lldb] [gdb-remote server] Support selecting process via Hg.
Apr 28 2021, 3:22 AM
mgorny updated the diff for D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*().

typeop.

Apr 28 2021, 2:42 AM
mgorny added a comment to D100459: [lldb] [gdb-remote client] Refactor SetCurrentThread*().

This looks good to me, but I'll let others comment on whether or not we want to send extra leading zeroes for the thread ID. In my opinion it would be nice to 1) be consistent between all packages that deal with thread ids, and 2) send as little clutter as possible. But these are just theoretical concerns, I'm not sure if it matters in practice.

Apr 28 2021, 2:41 AM

Apr 27 2021

mgorny committed rGca7824c2a8db: [lldb] [gdb-remote] Report QPassSignals and qXfer via extensions API (authored by mgorny).
[lldb] [gdb-remote] Report QPassSignals and qXfer via extensions API
Apr 27 2021, 10:34 AM
mgorny closed D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API.
Apr 27 2021, 10:34 AM · Restricted Project
mgorny added inline comments to D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS.
Apr 27 2021, 10:00 AM · Restricted Project
mgorny added a comment to D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API.

Thanks for the review. I'm going to update the tests as you suggested before pushing.

Apr 27 2021, 9:57 AM · Restricted Project
mgorny added inline comments to D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API.
Apr 27 2021, 5:32 AM · Restricted Project
mgorny added inline comments to D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS.
Apr 27 2021, 5:30 AM · Restricted Project

Apr 26 2021

mgorny added a comment to D101329: [lldb] Support SaveCore() from gdb-remote client.

I need to implement path hints and add tests still.

Apr 26 2021, 3:04 PM
mgorny retitled D101329: [lldb] Support SaveCore() from gdb-remote client from [lldb] Support SaveCore() from gdb-remote client to [lldb] Support SaveCore() from gdb-remote client [WIP].
Apr 26 2021, 3:04 PM
mgorny requested review of D101329: [lldb] Support SaveCore() from gdb-remote client.
Apr 26 2021, 3:04 PM
mgorny updated the diff for D101285: [lldb] [llgs server] Support creating core dumps on NetBSD.

Fix missing + in qSupported. Fix known stub features.

Apr 26 2021, 1:58 PM
mgorny updated the diff for D101157: [lldb] [test] Add tests for coredumps with multiple threads.

Add FreeBSD/aarch64 test.

Apr 26 2021, 10:57 AM
mgorny updated the diff for D101285: [lldb] [llgs server] Support creating core dumps on NetBSD.

Remove unnecessary const_cast, reformat.

Apr 26 2021, 9:28 AM
mgorny updated the diff for D101285: [lldb] [llgs server] Support creating core dumps on NetBSD.

Create a temporary file if path-hint is not provided.

Apr 26 2021, 9:26 AM
mgorny requested review of D101285: [lldb] [llgs server] Support creating core dumps on NetBSD.
Apr 26 2021, 4:52 AM

Apr 25 2021

mgorny committed rG06215023f450: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS (authored by mgorny).
[lldb] [Process/NetBSD] Report fork/vfork events to LLGS
Apr 25 2021, 10:41 AM
mgorny committed rG65f2a757371e: [lldb] [Process/FreeBSD] Report fork/vfork events to LLGS (authored by mgorny).
[lldb] [Process/FreeBSD] Report fork/vfork events to LLGS
Apr 25 2021, 10:41 AM
mgorny closed D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS.
Apr 25 2021, 10:41 AM · Restricted Project
mgorny closed D100547: [lldb] [Process/FreeBSD] Report fork/vfork events to LLGS.
Apr 25 2021, 10:41 AM · Restricted Project

Apr 24 2021

mgorny requested review of D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API.
Apr 24 2021, 2:20 PM · Restricted Project
mgorny updated the diff for D100261: [lldb] [gdb-remote server] Support selecting process via Hg.

Add tests.

Apr 24 2021, 1:17 PM
mgorny updated the diff for D100206: [lldb] [llgs client] Support minimal fork/vfork handling.

Add gdb_remote_client tests for fork/vfork stop reason handling.

Apr 24 2021, 9:50 AM
mgorny added a comment to D100206: [lldb] [llgs client] Support minimal fork/vfork handling.

@labath, now's a curious problem I've seen very rarely (I mean, 1 out of 150 attempts or so):

Apr 24 2021, 9:01 AM
mgorny abandoned D100541: [lldb] [gdb-remote client] Support detaching by PID.

Merged into D100206.

Apr 24 2021, 8:57 AM
mgorny updated the diff for D100206: [lldb] [llgs client] Support minimal fork/vfork handling.

Merged D100541 and client fork/vfork stop infos from D100208 into this one. Included fork-events+ and vfork-events+ in client qSupported.

Apr 24 2021, 8:56 AM
mgorny committed rGbbae0c1f7b4f: [lldb] [llgs] Support owning and detaching extra processes (authored by mgorny).
[lldb] [llgs] Support owning and detaching extra processes
Apr 24 2021, 2:27 AM
mgorny committed rGfd0af0cf0828: [lldb] [Process/Linux] Report fork/vfork stop reason (authored by mgorny).
[lldb] [Process/Linux] Report fork/vfork stop reason
Apr 24 2021, 2:27 AM
mgorny committed rG6c37984ebaf4: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork (authored by mgorny).
[lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork
Apr 24 2021, 2:27 AM
mgorny closed D100208: [lldb] [Process/Linux] Report fork/vfork stop reason.
Apr 24 2021, 2:26 AM · Restricted Project
mgorny committed rG312257688eb0: [lldb] [Process] Introduce protocol extension support API (authored by mgorny).
[lldb] [Process] Introduce protocol extension support API
Apr 24 2021, 2:26 AM
mgorny closed D100191: [lldb] [llgs] Support owning and detaching extra processes.
Apr 24 2021, 2:26 AM · Restricted Project
mgorny closed D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork.
Apr 24 2021, 2:26 AM · Restricted Project
mgorny closed D100153: [lldb] [Process] Introduce protocol extension support API.
Apr 24 2021, 2:26 AM · Restricted Project
mgorny updated the diff for D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS.

Synced to the Linux plugin.

Apr 24 2021, 2:06 AM · Restricted Project

Apr 23 2021

mgorny updated the diff for D100547: [lldb] [Process/FreeBSD] Report fork/vfork events to LLGS.

Sync to changes in the Linux plugin.

Apr 23 2021, 11:48 PM · Restricted Project
mgorny updated the diff for D100208: [lldb] [Process/Linux] Report fork/vfork stop reason.

Add multiprocess to supported features.

Apr 23 2021, 3:49 PM · Restricted Project
mgorny updated the diff for D100191: [lldb] [llgs] Support owning and detaching extra processes.

Fix tests to include multiprocess+ in qSupported.

Apr 23 2021, 3:48 PM · Restricted Project
mgorny updated the diff for D100191: [lldb] [llgs] Support owning and detaching extra processes.

Add the comment for mock stuff.

Apr 23 2021, 3:40 PM · Restricted Project
mgorny updated the diff for D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork.

Actually, add asserts for fork/vfork extensions too.

Apr 23 2021, 3:24 PM · Restricted Project
mgorny updated the diff for D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork.

Add an assert to make sure that process doesn't report fork/vfork stop reason without multiprocess support.

Apr 23 2021, 3:22 PM · Restricted Project
mgorny updated the diff for D100153: [lldb] [Process] Introduce protocol extension support API.

Added Extension bit for multiprocess. Made fork-events and vfork-events both depend on it — i.e. be implicitly disabled if multiprocess wasn't reported as supported.

Apr 23 2021, 3:19 PM · Restricted Project
mgorny added inline comments to D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork.
Apr 23 2021, 2:07 PM · Restricted Project
mgorny added inline comments to D100208: [lldb] [Process/Linux] Report fork/vfork stop reason.
Apr 23 2021, 1:20 PM · Restricted Project
mgorny retitled D101157: [lldb] [test] Add tests for coredumps with multiple threads from [lldb] [test] Add tests for core dumps of multithreaded programs [WIP] to [lldb] [test] Add tests for coredumps with multiple threads.
Apr 23 2021, 8:01 AM
mgorny updated the diff for D101157: [lldb] [test] Add tests for coredumps with multiple threads.

Complete set of tests.

Apr 23 2021, 8:01 AM
mgorny updated the diff for D101157: [lldb] [test] Add tests for coredumps with multiple threads.

Now with complete set of amd64 tests.

Apr 23 2021, 7:40 AM
mgorny added inline comments to D101157: [lldb] [test] Add tests for coredumps with multiple threads.
Apr 23 2021, 6:42 AM
mgorny updated the diff for D101157: [lldb] [test] Add tests for coredumps with multiple threads.

Check for thread select instructions rather than output.

Apr 23 2021, 6:41 AM
mgorny requested review of D101157: [lldb] [test] Add tests for coredumps with multiple threads.
Apr 23 2021, 5:24 AM

Apr 22 2021

mgorny updated the diff for D101091: [lldb] [Process/elf-core] Fix reading NetBSD/i386 core dumps.

Use split code branches for i386 and amd64.

Apr 22 2021, 1:21 PM
mgorny updated the diff for D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.

Also add FPU-specific checks to x86-32-freebsd-addr.test.

Apr 22 2021, 10:46 AM · Restricted Project
mgorny requested review of D101091: [lldb] [Process/elf-core] Fix reading NetBSD/i386 core dumps.
Apr 22 2021, 10:44 AM
mgorny requested review of D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.
Apr 22 2021, 10:23 AM · Restricted Project
mgorny added inline comments to D100208: [lldb] [Process/Linux] Report fork/vfork stop reason.
Apr 22 2021, 8:05 AM · Restricted Project

Apr 21 2021

mgorny updated the diff for D100208: [lldb] [Process/Linux] Report fork/vfork stop reason.

Implemented all the requests, modulo claim that PID and TID are duplicate ;-). Also found cases for bool() with Extension stuff.

Apr 21 2021, 12:34 PM · Restricted Project
mgorny added a comment to D100208: [lldb] [Process/Linux] Report fork/vfork stop reason.

This seems reasonable.

Why don't we have tests that detach from the parent process (and maybe continue the child)? Does that already work? (or in general, what is expected to work after this patch?)

Apr 21 2021, 10:43 AM · Restricted Project
mgorny committed rGe414ede2cd54: [lldb] [test/Register] Initial tests for regsets in core dumps (authored by mgorny).
[lldb] [test/Register] Initial tests for regsets in core dumps
Apr 21 2021, 10:41 AM
mgorny closed D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP].
Apr 21 2021, 10:41 AM · Restricted Project
mgorny added a comment to D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP].

I'll try to keep this in mind. I expect to have some vacation time ~1 month from now, so maybe then ;-).

Apr 21 2021, 10:38 AM · Restricted Project
mgorny updated the diff for D100208: [lldb] [Process/Linux] Report fork/vfork stop reason.

Now includes lldb-server tests.

Apr 21 2021, 8:44 AM · Restricted Project
mgorny updated the diff for D100191: [lldb] [llgs] Support owning and detaching extra processes.

Remove the test, update the API to pass std::unique_ptr<> instance instead of ref.

Apr 21 2021, 6:42 AM · Restricted Project
mgorny added a comment to D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork.

For other readers: as discussed in D100191, I've stripped client part of this (except for trivial enumerations). The server part will be used in tests but the stop reasons won't be reported to regular clients as they don't report fork-events support.

Apr 21 2021, 6:05 AM · Restricted Project
mgorny updated the diff for D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork.

@labath, does this subset look better?

Apr 21 2021, 5:46 AM · Restricted Project
mgorny updated the diff for D100153: [lldb] [Process] Introduce protocol extension support API.

Implemented the suggested changes, including bool() use in SetEnabledExtensions(). Removed the client announcements of fork-events and vfork-events support.

Apr 21 2021, 5:19 AM · Restricted Project
mgorny added a comment to D100191: [lldb] [llgs] Support owning and detaching extra processes.

Let's identify the set of patches needed to make this testable via the lldb-server suite (this one, D100153, D100208 (or equivalent for some other os), and what else?) and test that?

In its current form, D100208 relies at least on D100196 as well. I suppose we might get away without other patches for now. My logic is that as long as client doesn't indicate fork support, the regular LLDB behavior won't change. We can mock-enable fork-events in the server tests to get things rolling, unless I'm missing something.

Sounds great.

I think we could avoid merging D100196 if I split D100208 into two parts, the earlier part just calling NewSubprocess() without actually reporting stop. This won't be really functional (or used in real sessions) but should suffice for testing.

I'm not sure how would that work -- you'd still have to provide a way to notify the client (test) about the new process and its pid, so that the test can assert something meaningful. Let's just keep D100196, but leave out the client specific parts -- just keep it about adding the new enums and relevant server code (trivial case switches are fine).

Apr 21 2021, 4:50 AM · Restricted Project
mgorny added inline comments to D100153: [lldb] [Process] Introduce protocol extension support API.
Apr 21 2021, 3:41 AM · Restricted Project
mgorny committed rG08ce2ba51803: [lldb] [MainLoop] Support multiple callbacks per signal (authored by mgorny).
[lldb] [MainLoop] Support multiple callbacks per signal
Apr 21 2021, 3:18 AM
mgorny closed D100418: [lldb] [MainLoop] Support multiple callbacks per signal.
Apr 21 2021, 3:18 AM · Restricted Project
mgorny added inline comments to D100153: [lldb] [Process] Introduce protocol extension support API.
Apr 21 2021, 3:17 AM · Restricted Project
mgorny added a comment to D100191: [lldb] [llgs] Support owning and detaching extra processes.

Let's identify the set of patches needed to make this testable via the lldb-server suite (this one, D100153, D100208 (or equivalent for some other os), and what else?) and test that?

Apr 21 2021, 2:52 AM · Restricted Project

Apr 19 2021

mgorny added a comment to D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP].

New sizes:

$ ls -lh *.core
-rw------- 1 mgorny mgorny  13K 04-19 17:11 x86-32-freebsd.core
-rw------- 1 mgorny mgorny 5,1K 04-19 17:11 x86-32-linux.core
-rw------- 1 mgorny mgorny 2,7K 04-19 17:11 x86-32-netbsd.core
-rw------- 1 mgorny mgorny  15K 04-19 17:11 x86-64-freebsd.core
-rw------- 1 mgorny mgorny 6,6K 04-19 17:11 x86-64-linux.core
-rw------- 1 mgorny mgorny 5,2K 04-19 17:11 x86-64-netbsd.core
Apr 19 2021, 8:15 AM · Restricted Project
mgorny updated the diff for D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP].

Now includes a small-ish Python scripts to strip unnecessary data from coredumps. For now, it just strips everything but the PT_NOTE segment. Headers aren't modified, so holes are inserted before PT_NOTE segments, and the file is truncated after the last one. It uses the pyelftools library to portably read ELF headers.

Apr 19 2021, 8:14 AM · Restricted Project

Apr 16 2021

mgorny updated the diff for D100191: [lldb] [llgs] Support owning and detaching extra processes.

Added a unittest covering the whole server life cycle, including attaching a (mocked) process, forking, detaching a child, detaching the parent, forking from the child and detaching all processes.

Apr 16 2021, 2:13 PM · Restricted Project
mgorny updated the diff for D100418: [lldb] [MainLoop] Support multiple callbacks per signal.

Fixed the iterator, formatting and added a test for adding, running and removing multiple handlers.

Apr 16 2021, 11:09 AM · Restricted Project

Apr 15 2021

mgorny added a comment to D100191: [lldb] [llgs] Support owning and detaching extra processes.

We should also start thinking about tests. I suppose the smallest piece of functionality that could be usefully tested (with a lldb-server test) is debugging a process that forks, stopping after the fork, and detaching from the child. Shall we try making that work first?

Apr 15 2021, 2:00 PM · Restricted Project
mgorny requested review of D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS.
Apr 15 2021, 6:09 AM · Restricted Project
mgorny requested review of D100547: [lldb] [Process/FreeBSD] Report fork/vfork events to LLGS.
Apr 15 2021, 4:19 AM · Restricted Project
mgorny requested review of D100541: [lldb] [gdb-remote client] Support detaching by PID.
Apr 15 2021, 3:45 AM