- User Since
- Aug 15 2016, 6:00 AM (189 w, 1 d)
Tue, Mar 17
Sat, Mar 7
Feb 14 2020
This broke standalone build of clang. It's trying to write into /include (as in, root directory) now! My guess is that LLVM_BINARY_DIR is undefined at this point of standalone build, later it might be defined to point to directory where LLVM was installed which also wouldn't be correct.
@broadwaylamb, I've requested backporting this to 10.x: https://bugs.llvm.org/show_bug.cgi?id=44905. However, i wasn't able to find to find you on Bugzilla and CC you. Could you confirm whether it's fine to backport, please?
Feb 10 2020
Gentoo, using the ebuilds. I think the most relevant is how libc++abi is configured:
Feb 7 2020
Feb 5 2020
Feb 4 2020
This seems to have broken NetBSD:
Feb 3 2020
I can confirm the tests pass both on i386 and amd64 for me, with this patch.
Feb 2 2020
While it fixes i386 tests, it seems to break amd64 now. Do you need me to paste the output or can you reproduce?
Feb 1 2020
Jan 31 2020
Removed the aforementioned chunk.
The question is, does this break any of the platform hacks? ;-)
I'm actually trying to make 10.0.0 a little less broken for Gentoo.
That said, can we revert this from 10.x branch, please?
This change broke stand-alone builds. They now try to use libc++abi from the wrong directory, instead of system instance:
Jan 30 2020
I suppose you need to make the timeout branch entirely separate from the non-timeout branch, as the variable assignment does not take place then.
Jan 28 2020
Jan 23 2020
Yes, indeed the goal is to unbreak 10.x. I'd also agree to making bigger changes in 11.x separately.
Jan 22 2020
Jan 21 2020
Well, it looks correct to me. Not sure if it's the best approach but it can be refined in the future.
Jan 20 2020
I'm afraid this breaks stuff. TableGen built against libc++ after this change misbehaves:
Jan 17 2020
Besides the mentioned misindent, the CMake code looks correct. Could you test whether it works with standalone (out-of-LLVM) builds as well?
Jan 14 2020
This broke NetBSD buildbot:
Jan 13 2020
Jan 12 2020
Jan 11 2020
Also older versions of gcc. This broke bootstrap on NetBSD: http://lab.llvm.org:8014/builders/netbsd-amd64/builds/771/steps/ninja%20build%20local/logs/stdio
Jan 9 2020
Is there a way to get the basename from ZLIB_LIBRARY by any chance? Not saying it's actually necessary, just wondering.
Jan 6 2020
Jan 3 2020
Jan 2 2020
Dec 26 2019
LGTM, presuming you've tested it. If you need me to do a second test run, lemme know.
Dec 20 2019
Dec 19 2019
Besides missing LZMA, looks good to me. However, I suspect you may want to wait for a second opinion ;-).
Dec 18 2019
Dec 17 2019
Switch to using %run_nomprotect instead of extra %paxctl. This should be more consistent and should avoid potential issues with : on Windows.
I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems.
Dec 14 2019
Dec 13 2019
Dec 12 2019
I know I'm late to the party but this change thoroughly destroyed NetBSD support. The NetBSD loader doesn't support having more than two PT_LOAD sections. -z norosegment helped with that so far but after this change practically everything fails to run.
Dec 10 2019
I'm going to be blunt but if you dislike what LLVM does, improve that rather than proliferating inconsistencies between subprojects.