sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (48 w, 4 d)

Recent Activity

Yesterday

sbc100 retitled D37048: [lld] Update comments: parallel_for_each -> parallelForEach from Update comments: parallel_for_each -> parallelForEach to [lld] Update comments: parallel_for_each -> parallelForEach.
Tue, Aug 22, 7:03 PM
sbc100 created D37048: [lld] Update comments: parallel_for_each -> parallelForEach.
Tue, Aug 22, 7:01 PM

Fri, Aug 11

sbc100 added inline comments to D34851: [WebAssembly] Initial wasm linker implementation.
Fri, Aug 11, 11:50 AM

Thu, Aug 10

sbc100 retitled D36595: [WebAssembly] Remove invalid lld arguments from [WebAssembly] Remove lld arguments to [WebAssembly] Remove invalid lld arguments.
Thu, Aug 10, 3:03 PM
sbc100 retitled D36595: [WebAssembly] Remove invalid lld arguments from [WebAssembly] Remove lld argument to [WebAssembly] Remove lld arguments.
Thu, Aug 10, 3:03 PM
sbc100 added a reviewer for D36595: [WebAssembly] Remove invalid lld arguments: dschuff.
Thu, Aug 10, 3:03 PM
sbc100 created D36595: [WebAssembly] Remove invalid lld arguments.
Thu, Aug 10, 3:02 PM
sbc100 added inline comments to D34851: [WebAssembly] Initial wasm linker implementation.
Thu, Aug 10, 11:59 AM
sbc100 updated the diff for D34851: [WebAssembly] Initial wasm linker implementation.
  • [WebAssembly] Add support for data relocations
  • Merge remote-tracking branch 'origin/master' into wasm
  • [WebAssembly] Add tests for --allow-undefined flags
  • [WebAssembly] Fixes from code review
Thu, Aug 10, 11:59 AM

Jul 12 2017

sbc100 accepted D35322: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.
Jul 12 2017, 1:45 PM
sbc100 accepted D35322: [WebAssembly] Mark element atomic memcpy/memmove intrinsics as unsupported.

Thanks!

Jul 12 2017, 1:08 PM
sbc100 updated the diff for D34851: [WebAssembly] Initial wasm linker implementation.

Rebase + fixes

Jul 12 2017, 11:20 AM

Jul 11 2017

sbc100 retitled D34916: Remove unneeded use of #undef DEBUG_TYPE. NFC from Remove unneeded use of #undef DEBUG_TYPE to Remove unneeded use of #undef DEBUG_TYPE. NFC.
Jul 11 2017, 5:13 PM
sbc100 added a reviewer for D34916: Remove unneeded use of #undef DEBUG_TYPE. NFC: dschuff.
Jul 11 2017, 5:12 PM
sbc100 added a comment to D35234: [WebAssembly] Expose the offset of each data segment.

No the motivation is to allow the linker to know which relocations apply to a given segment. Since the relocations all defined as offsets in to the section. Does that make sense? We could go back to the drawing board and define relocations for each segment separately, but that also complicated the definition of relocations. Alternatively the linker could parse the data section itself rather then relying on the libObject abstraction.

Jul 11 2017, 5:09 PM
sbc100 added a comment to D35234: [WebAssembly] Expose the offset of each data segment.

@dschuff PTAL? (or sunfish if you have time?)

Jul 11 2017, 11:49 AM
sbc100 added a reviewer for D35234: [WebAssembly] Expose the offset of each data segment: sunfish.
Jul 11 2017, 11:49 AM

Jul 10 2017

sbc100 added a reviewer for D35234: [WebAssembly] Expose the offset of each data segment: dschuff.
Jul 10 2017, 6:09 PM
sbc100 updated the diff for D35234: [WebAssembly] Expose the offset of each data segment.
  • remove debugging
Jul 10 2017, 6:08 PM
sbc100 created D35234: [WebAssembly] Expose the offset of each data segment.
Jul 10 2017, 6:04 PM
sbc100 added a reviewer for D35233: [WebAssembly] Fix use of cast vs dyn_cast: mehdi_amini.
Jul 10 2017, 5:53 PM
sbc100 created D35233: [WebAssembly] Fix use of cast vs dyn_cast.
Jul 10 2017, 5:52 PM
sbc100 added a comment to D35208: [WebAssembly] Add more details to llvm-readobj for wasm files.

Yes this patch depends on the one that just landed that updated the binary.

Jul 10 2017, 1:45 PM
sbc100 added inline comments to D35213: [WebAssembly] Be consistent in generating trivial test input files.
Jul 10 2017, 1:31 PM
sbc100 updated the diff for D35213: [WebAssembly] Be consistent in generating trivial test input files.
  • add comments
Jul 10 2017, 1:30 PM
sbc100 updated the diff for D35208: [WebAssembly] Add more details to llvm-readobj for wasm files.
  • rebase and update test
Jul 10 2017, 11:21 AM
sbc100 updated the diff for D35213: [WebAssembly] Be consistent in generating trivial test input files.
  • rebase
Jul 10 2017, 11:03 AM
sbc100 added a comment to D35213: [WebAssembly] Be consistent in generating trivial test input files.

This change should ensure that that https://reviews.llvm.org/D35208 is tested

Jul 10 2017, 10:57 AM
sbc100 updated the summary of D35213: [WebAssembly] Be consistent in generating trivial test input files.
Jul 10 2017, 10:56 AM
sbc100 updated the diff for D35213: [WebAssembly] Be consistent in generating trivial test input files.
  • revert
Jul 10 2017, 10:54 AM
sbc100 updated the diff for D35213: [WebAssembly] Be consistent in generating trivial test input files.

Update expected test output

Jul 10 2017, 10:53 AM
sbc100 created D35213: [WebAssembly] Be consistent in generating trivial test input files.
Jul 10 2017, 10:51 AM
sbc100 added a reviewer for D35208: [WebAssembly] Add more details to llvm-readobj for wasm files: dschuff.
Jul 10 2017, 9:42 AM
sbc100 created D35208: [WebAssembly] Add more details to llvm-readobj for wasm files.
Jul 10 2017, 9:41 AM
sbc100 abandoned D35151: [pdbutil] Only output color diff if the stream supports it.
Jul 10 2017, 9:24 AM

Jul 9 2017

sbc100 added a comment to D35090: [WebAssembly] Use the correct size for MCFillFragment.

Can this land now? Its effecting a change that I'm working on.

Jul 9 2017, 6:13 AM
sbc100 updated subscribers of D35151: [pdbutil] Only output color diff if the stream supports it.
Jul 9 2017, 6:13 AM
sbc100 created D35151: [pdbutil] Only output color diff if the stream supports it.
Jul 9 2017, 6:13 AM

Jul 6 2017

sbc100 accepted D35090: [WebAssembly] Use the correct size for MCFillFragment.
Jul 6 2017, 3:17 PM

Jul 5 2017

sbc100 updated the diff for D35029: [WebAssembly] Support weak defined symbols.
  • remove bitcast
Jul 5 2017, 4:40 PM
sbc100 updated the diff for D35029: [WebAssembly] Support weak defined symbols.
  • rebase
Jul 5 2017, 4:36 PM
sbc100 created D35029: [WebAssembly] Support weak defined symbols.
Jul 5 2017, 1:29 PM
sbc100 updated the diff for D34966: [WebAssembly] Fix types for address taken functions.
  • use 1 element vector for results
Jul 5 2017, 1:15 PM
sbc100 updated the diff for D34734: [WebAssembly] MC: Don't generate extra types for weak alias.
  • add comment
Jul 5 2017, 1:00 PM
sbc100 added inline comments to D34988: Reduce duplication in pcrel reloc creation.
Jul 5 2017, 10:24 AM

Jul 3 2017

sbc100 updated the diff for D34966: [WebAssembly] Fix types for address taken functions.
  • simplify patch
Jul 3 2017, 3:54 PM
sbc100 updated the summary of D34966: [WebAssembly] Fix types for address taken functions.
Jul 3 2017, 3:48 PM
sbc100 created D34966: [WebAssembly] Fix types for address taken functions.
Jul 3 2017, 3:45 PM
sbc100 updated the diff for D34734: [WebAssembly] MC: Don't generate extra types for weak alias.
  • Revert
Jul 3 2017, 3:45 PM
sbc100 updated the diff for D34734: [WebAssembly] MC: Don't generate extra types for weak alias.
  • [WebAssembly] Fix types for address taken functions
Jul 3 2017, 3:38 PM
sbc100 updated the diff for D34734: [WebAssembly] MC: Don't generate extra types for weak alias.
  • [WebAssembly] Fix types for address taken functions
Jul 3 2017, 3:35 PM
sbc100 added inline comments to D34734: [WebAssembly] MC: Don't generate extra types for weak alias.
Jul 3 2017, 3:32 PM

Jun 30 2017

sbc100 updated subscribers of D34916: Remove unneeded use of #undef DEBUG_TYPE. NFC.
Jun 30 2017, 3:46 PM
sbc100 created D34916: Remove unneeded use of #undef DEBUG_TYPE. NFC.
Jun 30 2017, 3:45 PM

Jun 29 2017

sbc100 updated the diff for D34851: [WebAssembly] Initial wasm linker implementation.
  • rebase
Jun 29 2017, 7:40 PM
sbc100 updated the diff for D34851: [WebAssembly] Initial wasm linker implementation.
  • Merge remote-tracking branch 'origin/master' into add_wasm_linker
  • Revert
Jun 29 2017, 7:15 PM
sbc100 added a reviewer for D34852: Remove unused declarations: ruiu.
Jun 29 2017, 5:32 PM
sbc100 created D34852: Remove unused declarations.
Jun 29 2017, 5:31 PM
sbc100 created D34851: [WebAssembly] Initial wasm linker implementation.
Jun 29 2017, 5:23 PM
sbc100 added inline comments to D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
Jun 29 2017, 12:03 PM
sbc100 updated the diff for D33906: Remove `inline` keyword from inline `classof` methods.
  • rebase
Jun 29 2017, 11:31 AM
sbc100 updated the diff for D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
  • remove redundant size check
Jun 29 2017, 11:28 AM

Jun 27 2017

sbc100 updated the summary of D34734: [WebAssembly] MC: Don't generate extra types for weak alias.
Jun 27 2017, 8:10 PM
sbc100 added a reviewer for D34734: [WebAssembly] MC: Don't generate extra types for weak alias: dschuff.
Jun 27 2017, 8:08 PM
sbc100 created D34734: [WebAssembly] MC: Don't generate extra types for weak alias.
Jun 27 2017, 8:08 PM
sbc100 updated the diff for D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
  • simlify test case
  • only strip leaning _ on MachO
Jun 27 2017, 4:05 PM
sbc100 added a reviewer for D34712: [WebAssembly] Only run WebAssembly objdump tests if it is enabled as a target: dschuff.
Jun 27 2017, 2:18 PM
sbc100 created D34712: [WebAssembly] Only run WebAssembly objdump tests if it is enabled as a target.
Jun 27 2017, 2:17 PM
sbc100 updated the diff for D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
  • simplify test case
Jun 27 2017, 1:58 PM
sbc100 updated the diff for D34658: [WebAssembly] Add support for printing relocations with llvm-objdump.
  • No return after else
Jun 27 2017, 12:30 PM
sbc100 added inline comments to D34657: [WebAssembly] Add data size and alignment to linking section.
Jun 27 2017, 12:28 PM
sbc100 updated the diff for D34657: [WebAssembly] Add data size and alignment to linking section.
  • - add default alignment of 1
Jun 27 2017, 12:27 PM
sbc100 added a comment to D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).

Turned out to be mach-o thing. I added test coverage and a comment,

Jun 27 2017, 11:58 AM
sbc100 updated the diff for D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
  • Add test coverage for Mach-O symbols which start with _
Jun 27 2017, 11:58 AM
sbc100 added inline comments to D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
Jun 27 2017, 11:37 AM
sbc100 added a reviewer for D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle): davide.
Jun 27 2017, 11:22 AM
sbc100 updated the diff for D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
  • add test
Jun 27 2017, 11:20 AM

Jun 26 2017

sbc100 created D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle).
Jun 26 2017, 10:54 PM
sbc100 updated the summary of D34658: [WebAssembly] Add support for printing relocations with llvm-objdump.
Jun 26 2017, 5:36 PM
sbc100 created D34658: [WebAssembly] Add support for printing relocations with llvm-objdump.
Jun 26 2017, 5:35 PM
sbc100 retitled D34657: [WebAssembly] Add data size and alignment to linking section from [WebAssembly] Add data size and alignement to linking section to [WebAssembly] Add data size and alignment to linking section.
Jun 26 2017, 5:33 PM
sbc100 created D34657: [WebAssembly] Add data size and alignment to linking section.
Jun 26 2017, 5:33 PM
sbc100 updated subscribers of D34635: [WebAssembly] Add more support for weak symbols.
Jun 26 2017, 11:29 AM
sbc100 added reviewers for D34635: [WebAssembly] Add more support for weak symbols: sunfish, dschuff.
Jun 26 2017, 11:29 AM
sbc100 created D34635: [WebAssembly] Add more support for weak symbols.
Jun 26 2017, 11:28 AM

Jun 21 2017

sbc100 retitled D34477: [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC from [WebAssemly] Cleanup WasmObjectWriter.cpp. NFC to [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC.
Jun 21 2017, 4:45 PM
sbc100 retitled D34486: MC: Fix dumping of MCFragment values from Fix dumping of fill fragment values to MC: Fix dumping of MCFragment values.
Jun 21 2017, 4:42 PM
sbc100 updated subscribers of D34486: MC: Fix dumping of MCFragment values.
Jun 21 2017, 4:40 PM
sbc100 updated the summary of D34486: MC: Fix dumping of MCFragment values.
Jun 21 2017, 4:38 PM
sbc100 updated the diff for D34486: MC: Fix dumping of MCFragment values.

use cast

Jun 21 2017, 4:37 PM
sbc100 created D34486: MC: Fix dumping of MCFragment values.
Jun 21 2017, 4:35 PM
sbc100 abandoned D34483: Fix build of SystemZ target after r305963.

Looks like this got fixed in r305967 9

Jun 21 2017, 4:05 PM
sbc100 added a reviewer for D34483: Fix build of SystemZ target after r305963: dschuff.
Jun 21 2017, 4:03 PM
sbc100 created D34483: Fix build of SystemZ target after r305963.
Jun 21 2017, 4:02 PM
sbc100 updated subscribers of D33565: [WebAssembly] Add default -allow-undefined-file to linker args.
Jun 21 2017, 3:18 PM
sbc100 updated subscribers of D33565: [WebAssembly] Add default -allow-undefined-file to linker args.
Jun 21 2017, 3:16 PM
sbc100 updated subscribers of D34477: [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC.
Jun 21 2017, 3:16 PM
sbc100 updated subscribers of D33906: Remove `inline` keyword from inline `classof` methods.
Jun 21 2017, 3:15 PM
sbc100 added a reviewer for D34481: Mark dump() methods as const. NFC: dschuff.
Jun 21 2017, 3:11 PM
sbc100 created D34481: Mark dump() methods as const. NFC.
Jun 21 2017, 3:10 PM