Page MenuHomePhabricator

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (297 w, 2 h)

Recent Activity

Today

sbc100 committed rG0e8f4ce31df1: [lld][WebAssembly] Fix crash on undefined+weak function syms in LTO objects (authored by sbc100).
[lld][WebAssembly] Fix crash on undefined+weak function syms in LTO objects
Fri, May 27, 11:41 AM · Restricted Project
sbc100 closed D126554: [lld][WebAssembly] Fix crash on undefined/weak function symbols in LTO objects.
Fri, May 27, 11:41 AM · Restricted Project, Restricted Project
sbc100 updated the diff for D126554: [lld][WebAssembly] Fix crash on undefined/weak function symbols in LTO objects.
  • typo
Fri, May 27, 9:22 AM · Restricted Project, Restricted Project
sbc100 updated the diff for D126554: [lld][WebAssembly] Fix crash on undefined/weak function symbols in LTO objects.
  • add test
Fri, May 27, 9:21 AM · Restricted Project, Restricted Project
sbc100 accepted D126553: [WebAssembly] Consolidate sectionTypeToString in BinaryFormat [NFC].
Fri, May 27, 9:17 AM · Restricted Project, Restricted Project
sbc100 added a comment to D126554: [lld][WebAssembly] Fix crash on undefined/weak function symbols in LTO objects.

Still working on a test..

Fri, May 27, 8:41 AM · Restricted Project, Restricted Project
sbc100 added a reviewer for D126554: [lld][WebAssembly] Fix crash on undefined/weak function symbols in LTO objects: dschuff.
Fri, May 27, 8:41 AM · Restricted Project, Restricted Project
sbc100 requested review of D126554: [lld][WebAssembly] Fix crash on undefined/weak function symbols in LTO objects.
Fri, May 27, 8:41 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D126553: [WebAssembly] Consolidate sectionTypeToString in BinaryFormat [NFC].
Fri, May 27, 8:33 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D126535: [WebAssembly][NFC] Update reftype and table tests to use opaque pointers.
Fri, May 27, 7:39 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D126509: [Objcopy][Wasm] Allow selecting known sections by name.
Fri, May 27, 7:03 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D126535: [WebAssembly][NFC] Update reftype and table tests to use opaque pointers.
Fri, May 27, 6:51 AM · Restricted Project, Restricted Project

Yesterday

sbc100 added inline comments to D126509: [Objcopy][Wasm] Allow selecting known sections by name.
Thu, May 26, 5:01 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D126509: [Objcopy][Wasm] Allow selecting known sections by name.
Thu, May 26, 4:59 PM · Restricted Project, Restricted Project
sbc100 committed rG98ff205fd86e: [lld][WebAssembly] Update test after 87628f5804e2 (authored by sbc100).
[lld][WebAssembly] Update test after 87628f5804e2
Thu, May 26, 2:58 PM · Restricted Project
sbc100 committed rG87628f5804e2: [lld][WebAssembly] Require double dash for modern linker flags (authored by sbc100).
[lld][WebAssembly] Require double dash for modern linker flags
Thu, May 26, 2:43 PM · Restricted Project
sbc100 closed D126500: [lld][WebAssembly] Require double dash for modern linker flags.
Thu, May 26, 2:43 PM · Restricted Project, Restricted Project
sbc100 added a comment to D126500: [lld][WebAssembly] Require double dash for modern linker flags.

LGTM but will this require a change to clang and/or EMCC first?

Thu, May 26, 2:33 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D126500: [lld][WebAssembly] Require double dash for modern linker flags: dschuff.
Thu, May 26, 2:10 PM · Restricted Project, Restricted Project
sbc100 requested review of D126500: [lld][WebAssembly] Require double dash for modern linker flags.
Thu, May 26, 2:10 PM · Restricted Project, Restricted Project
sbc100 committed rG198815e18dad: [lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries (authored by sbc100).
[lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries
Thu, May 26, 1:43 PM · Restricted Project
sbc100 closed D126491: [lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries.
Thu, May 26, 1:43 PM · Restricted Project, Restricted Project
sbc100 committed rG966427b8471d: [lld][WebAssemlby] Check for command line flags with missing arguments (authored by sbc100).
[lld][WebAssemlby] Check for command line flags with missing arguments
Thu, May 26, 1:36 PM · Restricted Project
sbc100 closed D126497: [lld][WebAssemlby] Check for command line flags with missing arguments.
Thu, May 26, 1:35 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D126497: [lld][WebAssemlby] Check for command line flags with missing arguments.
Thu, May 26, 1:23 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D126497: [lld][WebAssemlby] Check for command line flags with missing arguments.
  • split
Thu, May 26, 1:23 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D126491: [lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries.
  • feedback
Thu, May 26, 1:20 PM · Restricted Project, Restricted Project
sbc100 added a comment to D126491: [lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries.

what happens when you use attribute(export-name) in clang, along with -fvisibility=hidden? (or is there some other way force an export?)

Thu, May 26, 1:20 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D126497: [lld][WebAssemlby] Check for command line flags with missing arguments: dschuff.
Thu, May 26, 1:15 PM · Restricted Project, Restricted Project
sbc100 requested review of D126497: [lld][WebAssemlby] Check for command line flags with missing arguments.
Thu, May 26, 1:14 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D126491: [lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries: dschuff.
Thu, May 26, 11:40 AM · Restricted Project, Restricted Project
sbc100 requested review of D126491: [lld][WebAssembly] Avoid importing/exporting hidden symbols in shared libraries.
Thu, May 26, 11:40 AM · Restricted Project, Restricted Project

Mon, May 23

sbc100 committed rG74f984197700: [lld][WebAssembly] Allow use of statically allocated TLS region. (authored by sbc100).
[lld][WebAssembly] Allow use of statically allocated TLS region.
Mon, May 23, 5:28 PM · Restricted Project, Restricted Project
sbc100 closed D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
Mon, May 23, 5:27 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
  • fix test
Mon, May 23, 5:26 PM · Restricted Project, Restricted Project
sbc100 updated the summary of D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
Mon, May 23, 5:19 PM · Restricted Project, Restricted Project

Sun, May 22

sbc100 added a comment to D126107: [lld][WebAssembly] Allow first thread to use static TLS region.

OK I simplified and refactored and re-wrote the description. Maybe it will be more clear what is going on here now?

Sun, May 22, 1:16 PM · Restricted Project, Restricted Project
sbc100 retitled D126107: [lld][WebAssembly] Allow first thread to use static TLS region from [lld][WebAssembly] Allow first-loader to use static TLS region to [lld][WebAssembly] Allow first thread to use static TLS region.
Sun, May 22, 1:15 PM · Restricted Project, Restricted Project
sbc100 updated the summary of D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
Sun, May 22, 1:15 PM · Restricted Project, Restricted Project
sbc100 updated the summary of D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
Sun, May 22, 1:14 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
  • simplify
Sun, May 22, 1:14 PM · Restricted Project, Restricted Project

Fri, May 20

sbc100 committed rG4f6ac969267d: [lld][WebAssemlby] Add TLS test to lld/test/wasm/data-segments.ll. NFC (authored by sbc100).
[lld][WebAssemlby] Add TLS test to lld/test/wasm/data-segments.ll. NFC
Fri, May 20, 5:45 PM · Restricted Project
sbc100 closed D126104: [lld][WebAssemlby] Add TLS test to lld/test/wasm/data-segments.ll. NFC.
Fri, May 20, 5:45 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
  • tweaks
Fri, May 20, 5:01 PM · Restricted Project, Restricted Project
sbc100 added reviewers for D126107: [lld][WebAssembly] Allow first thread to use static TLS region: dschuff, tlively.
Fri, May 20, 4:52 PM · Restricted Project, Restricted Project
sbc100 updated the summary of D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
Fri, May 20, 4:52 PM · Restricted Project, Restricted Project
sbc100 requested review of D126107: [lld][WebAssembly] Allow first thread to use static TLS region.
Fri, May 20, 4:52 PM · Restricted Project, Restricted Project
sbc100 added reviewers for D126104: [lld][WebAssemlby] Add TLS test to lld/test/wasm/data-segments.ll. NFC: dschuff, tlively.
Fri, May 20, 4:19 PM · Restricted Project, Restricted Project
sbc100 requested review of D126104: [lld][WebAssemlby] Add TLS test to lld/test/wasm/data-segments.ll. NFC.
Fri, May 20, 4:19 PM · Restricted Project, Restricted Project
sbc100 added a comment to D125730: [WebAssembly] Strip TLS when "atomics" is not enabled.

I think I've got a test case pending that actually needs this change.. can this be landed?

Fri, May 20, 3:07 PM · Restricted Project, Restricted Project

Thu, May 19

sbc100 added inline comments to D115319: [lsan] Move out suppression of invalid PCs from StopTheWorld.
Thu, May 19, 7:30 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D115319: [lsan] Move out suppression of invalid PCs from StopTheWorld.
Thu, May 19, 5:24 PM · Restricted Project, Restricted Project

Tue, May 17

sbc100 accepted D125730: [WebAssembly] Strip TLS when "atomics" is not enabled.

The addition of -mcpu seem seperate to the TLS issue.. maybe it can land separately? I wonder if we should rename or alias mvp to something more widely understandable such as v1 ?

Tue, May 17, 9:39 PM · Restricted Project, Restricted Project

Tue, May 10

sbc100 added inline comments to D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen.
Tue, May 10, 5:55 PM · Restricted Project, Restricted Project

Mon, May 2

sbc100 added a comment to D123763: [randstruct] Enforce using a designated init for a randomized struct.

This new test has been failing on the emscripten builders.. seemingly ever since it landed:

Mon, May 2, 8:49 AM · Restricted Project, Restricted Project

Apr 21 2022

sbc100 added inline comments to D124162: [clang][Webassembly] Implement builtins for tables.
Apr 21 2022, 10:11 AM · Restricted Project

Mar 22 2022

sbc100 accepted D122020: [WebAssembly] Add tests for the Asm type checker.
Mar 22 2022, 8:40 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D122020: [WebAssembly] Add tests for the Asm type checker.
Mar 22 2022, 8:39 AM · Restricted Project, Restricted Project

Mar 21 2022

sbc100 accepted D122134: [WebAssembly] Always emit functype directives for defined functions.
Mar 21 2022, 4:11 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D122020: [WebAssembly] Add tests for the Asm type checker.
Mar 21 2022, 9:12 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D122020: [WebAssembly] Add tests for the Asm type checker.
Mar 21 2022, 8:45 AM · Restricted Project, Restricted Project
sbc100 accepted D122128: [WebAssembly] Fix error location for parsed symbol/label operands.
Mar 21 2022, 8:42 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D122134: [WebAssembly] Always emit functype directives for defined functions.
Mar 21 2022, 8:38 AM · Restricted Project, Restricted Project

Mar 18 2022

sbc100 added a comment to D122020: [WebAssembly] Add tests for the Asm type checker.

Thanks for working on this!

Mar 18 2022, 10:06 AM · Restricted Project, Restricted Project

Mar 17 2022

sbc100 committed rGa04a5077140b: [lld][WebAssembly] Fix crash accessing non-live __tls_base symbol (authored by sbc100).
[lld][WebAssembly] Fix crash accessing non-live __tls_base symbol
Mar 17 2022, 2:03 PM · Restricted Project
sbc100 closed D121931: [lld][WebAssembly] Fix crash accessing non-live __tls_base symbol.
Mar 17 2022, 2:02 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D121931: [lld][WebAssembly] Fix crash accessing non-live __tls_base symbol.
  • typos
Mar 17 2022, 10:42 AM · Restricted Project, Restricted Project
sbc100 added a reviewer for D121931: [lld][WebAssembly] Fix crash accessing non-live __tls_base symbol: dschuff.
Mar 17 2022, 10:41 AM · Restricted Project, Restricted Project
sbc100 requested review of D121931: [lld][WebAssembly] Fix crash accessing non-live __tls_base symbol.
Mar 17 2022, 10:40 AM · Restricted Project, Restricted Project

Mar 15 2022

sbc100 committed rG4690bf2ed31b: [lld][WebAssembly] Take advantage of extended const expressions when available (authored by sbc100).
[lld][WebAssembly] Take advantage of extended const expressions when available
Mar 15 2022, 5:50 PM · Restricted Project
sbc100 closed D121420: [lld][WebAssembly] Take advantage of extended const expression when available.
Mar 15 2022, 5:50 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D121420: [lld][WebAssembly] Take advantage of extended const expression when available.
  • feedback
Mar 15 2022, 5:47 PM · Restricted Project, Restricted Project
sbc100 committed rG86c90f9bfdc4: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic (authored by sbc100).
[lld][WebAssembly] Add --unresolved-symbols=import-dynamic
Mar 15 2022, 3:14 PM · Restricted Project
sbc100 closed D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
Mar 15 2022, 3:14 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.

-docs

Mar 15 2022, 3:11 PM · Restricted Project, Restricted Project
sbc100 added a comment to D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.

I re-wrote the documentation to make this a little more clear

Mar 15 2022, 3:11 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
Mar 15 2022, 3:10 PM · Restricted Project, Restricted Project
sbc100 updated the summary of D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
Mar 15 2022, 2:37 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
  • update docs
Mar 15 2022, 1:59 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D121420: [lld][WebAssembly] Take advantage of extended const expression when available.
  • rebase
Mar 15 2022, 11:44 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D121420: [lld][WebAssembly] Take advantage of extended const expression when available.
Mar 15 2022, 11:43 AM · Restricted Project, Restricted Project
sbc100 committed rG9b27fbd19c56: [WebAssembly] Fix asan issue from https://reviews.llvm.org/D121349 (authored by sbc100).
[WebAssembly] Fix asan issue from https://reviews.llvm.org/D121349
Mar 15 2022, 11:38 AM · Restricted Project

Mar 14 2022

sbc100 added a comment to D121349: [WebAssembly] Second phase of implementing extended const proposal..

Attempted fix for ASAN issue: https://github.com/llvm/llvm-project/commit/2481adb59cb63c90879f4537ad36339da3ad61a6

Mar 14 2022, 8:05 PM · Restricted Project, Restricted Project
sbc100 committed rG2481adb59cb6: [WebAssembly] Fix asan issue from https://reviews.llvm.org/D121349 (authored by sbc100).
[WebAssembly] Fix asan issue from https://reviews.llvm.org/D121349
Mar 14 2022, 8:03 PM · Restricted Project
sbc100 updated the diff for D121420: [lld][WebAssembly] Take advantage of extended const expression when available.
  • feedback
Mar 14 2022, 4:19 PM · Restricted Project, Restricted Project
sbc100 added a comment to D121349: [WebAssembly] Second phase of implementing extended const proposal..

This patch triggers a bunch of uninitialized memory under msan errors when running llvm-project/lld/test/wasm:data-layout.s (and several others) as below:

exit status 2
==1915==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x55e0ff9ca683 in (anonymous namespace)::WasmDumper::dump() /llvm-project/llvm/tools/obj2yaml/wasm2yaml.cpp:374:13
    #1 0x55e0ff9c1b87 in wasm2yaml(llvm::raw_ostream&, llvm::object::WasmObjectFile const&) llvm-project/llvm/tools/obj2yaml/wasm2yaml.cpp:411:50
    #2 0x55e0ff9be3c9 in dumpObject llvm-project/llvm/tools/obj2yaml/obj2yaml.cpp:40:29
    #3 0x55e0ff9be3c9 in dumpInput llvm-project/llvm/tools/obj2yaml/obj2yaml.cpp:67:12
    #4 0x55e0ff9be3c9 in main llvm-project/llvm/tools/obj2yaml/obj2yaml.cpp:89:19
    #5 0x7f7a5befc8d2 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x628d2) (BuildId: 7cfed7708e5ab7fcb286b373de21ee76)
    #6 0x55e0ff798429 in _start /usr/grte/v5/debug-src/src/csu/../sysdeps/x86_64/start.S:120

SUMMARY: MemorySanitizer: use-of-uninitialized-value llvm-project/llvm/tools/obj2yaml/wasm2yaml.cpp:374:13 in (anonymous namespace)::WasmDumper::dump()
Exiting
FileCheck error: '<stdin>' is empty.
FileCheck command line:  llvm-project/llvm/FileCheck --allow-unused-prefixes llvm-project/lld/test/wasm/data-layout.s -check-prefix=CHECK-SHARED
Mar 14 2022, 2:37 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
  • comments
Mar 14 2022, 2:06 PM · Restricted Project, Restricted Project
sbc100 updated the summary of D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
Mar 14 2022, 2:02 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
  • rebase
Mar 14 2022, 1:46 PM · Restricted Project, Restricted Project
sbc100 committed rG2f5c4083eab5: [WebAssembly] Remove unused method from WebAssemblyTargetStreamer. NFC (authored by sbc100).
[WebAssembly] Remove unused method from WebAssemblyTargetStreamer. NFC
Mar 14 2022, 10:17 AM · Restricted Project
sbc100 closed D121538: [WebAssembly] Remove unused method from WebAssemblyTargetStreamer. NFC.
Mar 14 2022, 10:17 AM · Restricted Project, Restricted Project
sbc100 committed rG20f7f733fe93: [WebAssembly] Rename member in WasmYAML.h to avoid compiler warning (authored by sbc100).
[WebAssembly] Rename member in WasmYAML.h to avoid compiler warning
Mar 14 2022, 9:10 AM · Restricted Project
sbc100 added a comment to rG9504ab32b766: [WebAssembly] Second phase of implemented extended const proposal.

Looks like some of the builders didn't like this change:

Mar 14 2022, 9:05 AM · Restricted Project
sbc100 updated the diff for D121420: [lld][WebAssembly] Take advantage of extended const expression when available.
  • rebase
Mar 14 2022, 9:03 AM · Restricted Project, Restricted Project
sbc100 added a comment to D121420: [lld][WebAssembly] Take advantage of extended const expression when available.

Would there still be an advantage to combining the segments? e.g. would the library load faster if there were only one?

We already combine segments of the same type/prefix unless --no-merge-data-segments is passed... so in the normal case there are just a fixed number or possible output segments: .data .bss .tdata .tbss, plus any user-defined segments. This later-phase combining was always just a stop gap to handler the lack of extended const expressions. See the description of https://reviews.llvm.org/D96453 for why we delay the merging in this case.

Mar 14 2022, 9:03 AM · Restricted Project, Restricted Project
sbc100 committed rG9504ab32b766: [WebAssembly] Second phase of implemented extended const proposal (authored by sbc100).
[WebAssembly] Second phase of implemented extended const proposal
Mar 14 2022, 8:56 AM · Restricted Project
sbc100 closed D121349: [WebAssembly] Second phase of implementing extended const proposal..
Mar 14 2022, 8:56 AM · Restricted Project, Restricted Project
sbc100 added a comment to D121420: [lld][WebAssembly] Take advantage of extended const expression when available.

Would there still be an advantage to combining the segments? e.g. would the library load faster if there were only one?

Mar 14 2022, 8:46 AM · Restricted Project, Restricted Project

Mar 13 2022

sbc100 removed a reviewer for D112964: [WebAssembly] Disable test that doesn't work on Windows: sbc100.
Mar 13 2022, 8:43 AM · Restricted Project

Mar 12 2022

sbc100 added a reviewer for D121538: [WebAssembly] Remove unused method from WebAssemblyTargetStreamer. NFC: dschuff.
Mar 12 2022, 9:13 PM · Restricted Project, Restricted Project