sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.
User Since
Sep 16 2016, 10:22 AM (27 w, 1 d)

Recent Activity

Fri, Mar 24

sbc100 added inline comments to D31099: [WebAssembly] Improve support for WebAssembly binary format.
Fri, Mar 24, 2:01 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • add index to types in yaml
  • Merge remote-tracking branch 'origin/master' into add_wasm_object_type
  • Split out unrelated change
Fri, Mar 24, 2:01 PM
sbc100 added a reviewer for D31351: yaml2obj: Prefix errors with "Error: " to match obj2yaml: davide.
Fri, Mar 24, 1:43 PM
sbc100 created D31351: yaml2obj: Prefix errors with "Error: " to match obj2yaml.
Fri, Mar 24, 1:42 PM

Thu, Mar 23

sbc100 added a reviewer for D31099: [WebAssembly] Improve support for WebAssembly binary format: Bigcheese.
Thu, Mar 23, 1:23 PM

Tue, Mar 21

sbc100 added a reviewer for D31227: [WebAssembly] Fix import type to be signed LEBs: sunfish.
Tue, Mar 21, 5:47 PM
sbc100 created D31227: [WebAssembly] Fix import type to be signed LEBs.
Tue, Mar 21, 5:46 PM
sbc100 abandoned D31214: revert some parts to keep change smalle.
Tue, Mar 21, 2:55 PM
sbc100 added a comment to D31099: [WebAssembly] Improve support for WebAssembly binary format.

I agree this change was a little large. I removed the parts that I could. Now its pretty much only overs obj2yaml and yaml2obj.

Tue, Mar 21, 2:50 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • remove trivial accessors
Tue, Mar 21, 2:49 PM
sbc100 updated the summary of D31099: [WebAssembly] Improve support for WebAssembly binary format.
Tue, Mar 21, 2:49 PM
sbc100 updated the summary of D31099: [WebAssembly] Improve support for WebAssembly binary format.
Tue, Mar 21, 2:48 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • revert some parts to keep change smalle
Tue, Mar 21, 2:41 PM
sbc100 created D31214: revert some parts to keep change smalle.
Tue, Mar 21, 2:40 PM

Mon, Mar 20

sbc100 added a reviewer for D31099: [WebAssembly] Improve support for WebAssembly binary format: davide.
Mon, Mar 20, 4:13 PM
sbc100 added inline comments to D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mon, Mar 20, 3:59 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • add support for reading and dumping relocations
Mon, Mar 20, 3:58 PM

Fri, Mar 17

sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • cleanup based on feedback
Fri, Mar 17, 5:23 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • refactor section parsing
Fri, Mar 17, 1:47 PM
sbc100 added a reviewer for D31099: [WebAssembly] Improve support for WebAssembly binary format: sunfish.
Fri, Mar 17, 1:40 PM
sbc100 abandoned D30318: [WebAssembly] Add initial support for llvm-nm.

Abandoning in favor of larger change that handles imports and exports too: https://reviews.llvm.org/D31099

Fri, Mar 17, 1:40 PM
sbc100 created D31099: [WebAssembly] Improve support for WebAssembly binary format.
Fri, Mar 17, 1:37 PM

Thu, Mar 16

sbc100 added inline comments to D31064: [WebAssembly] Linking metadata support.
Thu, Mar 16, 5:56 PM
sbc100 updated the diff for D31014: [WebAssembly] Fix some broken type encodings in wasm binary.
  • make emitValueType protected
Thu, Mar 16, 11:08 AM

Wed, Mar 15

sbc100 added a reviewer for D31014: [WebAssembly] Fix some broken type encodings in wasm binary: sunfish.
Wed, Mar 15, 4:45 PM
sbc100 created D31014: [WebAssembly] Fix some broken type encodings in wasm binary.
Wed, Mar 15, 4:45 PM
sbc100 updated the diff for D30950: [WebAssembly] Update format of 'names' section..
  • prefer preincrement
Wed, Mar 15, 10:31 AM

Tue, Mar 14

sbc100 retitled D30950: [WebAssembly] Update format of 'names' section. from [WebAssembly] Update format of 'names' sectionThis change updates to the format of the 'names' sectionin the generated wasm binary to match the latest changesto the design and 'wabt'. to [WebAssembly] Update format of 'names' section..
Tue, Mar 14, 2:36 PM
sbc100 updated the diff for D30950: [WebAssembly] Update format of 'names' section..
  • Merge remote-tracking branch 'origin/master' into new_names_section
Tue, Mar 14, 2:32 PM
sbc100 retitled D30950: [WebAssembly] Update format of 'names' section. from [WebAssembly] Update format of 'names' section This change updates to the format of the 'names' section in the generated wasm binary to match the latest changes to the design and 'wabt'. to [WebAssembly] Update format of 'names' sectionThis change updates to the format of the 'names' sectionin the generated wasm binary to match the latest changesto the design and 'wabt'..
Tue, Mar 14, 12:05 PM
sbc100 created D30950: [WebAssembly] Update format of 'names' section..
Tue, Mar 14, 12:04 PM
sbc100 added a comment to D30847: [WebAssembly] Use LEB encoding for value types.

Ping? Hopefully this change is good to go now.

Tue, Mar 14, 10:47 AM

Mon, Mar 13

sbc100 updated the diff for D30318: [WebAssembly] Add initial support for llvm-nm.
  • update wasm binaries
  • Update to new names section format
Mon, Mar 13, 5:40 PM
sbc100 added a comment to D30847: [WebAssembly] Use LEB encoding for value types.

In terms the namespacing, yes it probably makes sense to try to merge them and be consistent, but thats not something for this PR.

Mon, Mar 13, 11:39 AM
sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.
  • remove MVT2WasmType in favor of WebAssembly::toValType
  • Merge remote-tracking branch 'refs/remotes/origin/master' into fix_value_types
Mon, Mar 13, 9:59 AM

Fri, Mar 10

sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.
  • Move more types to Support/Wasm.h
  • clang-format
Fri, Mar 10, 6:22 PM
sbc100 added inline comments to D30847: [WebAssembly] Use LEB encoding for value types.
Fri, Mar 10, 3:17 PM
sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.
  • Revert change of Nop and End types
Fri, Mar 10, 3:12 PM
sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.

Update types in WebAssemblyMCTargetDesc.h

Fri, Mar 10, 3:10 PM
sbc100 added a reviewer for D30847: [WebAssembly] Use LEB encoding for value types: sunfish.
Fri, Mar 10, 2:19 PM
sbc100 created D30847: [WebAssembly] Use LEB encoding for value types.
Fri, Mar 10, 2:18 PM

Feb 23 2017

sbc100 added a reviewer for D30318: [WebAssembly] Add initial support for llvm-nm: Bigcheese.
Feb 23 2017, 6:10 PM
sbc100 created D30318: [WebAssembly] Add initial support for llvm-nm.
Feb 23 2017, 6:09 PM

Jan 30 2017

sbc100 added inline comments to D27355: [WebAssembly] Add wasm support for llvm-readobj.
Jan 30 2017, 2:41 PM
sbc100 updated the diff for D27355: [WebAssembly] Add wasm support for llvm-readobj.
  • switch to assert()
Jan 30 2017, 2:39 PM
sbc100 added inline comments to D27355: [WebAssembly] Add wasm support for llvm-readobj.
Jan 30 2017, 2:15 PM
sbc100 updated the diff for D27355: [WebAssembly] Add wasm support for llvm-readobj.
  • Run clang-format
  • Rename sections to
  • clang-format
  • Dump custom section name
  • update comment
  • Add rebuild instructions for trivial.obj.wasm
Jan 30 2017, 2:13 PM

Jan 6 2017

sbc100 added a comment to D27355: [WebAssembly] Add wasm support for llvm-readobj.

Ping. Can we land this Derek?

Jan 6 2017, 7:04 AM

Dec 20 2016

sbc100 added a comment to D27355: [WebAssembly] Add wasm support for llvm-readobj.

Any other comments on this?

Dec 20 2016, 3:53 PM
sbc100 updated the diff for D27355: [WebAssembly] Add wasm support for llvm-readobj.
  • Merge remote-tracking branch 'origin/master' into wasm_readobj_support
  • Dump custom section name
Dec 20 2016, 3:51 PM

Dec 6 2016

sbc100 updated the diff for D27355: [WebAssembly] Add wasm support for llvm-readobj.
  • clang-format
Dec 6 2016, 1:49 PM
sbc100 added inline comments to D27355: [WebAssembly] Add wasm support for llvm-readobj.
Dec 6 2016, 1:48 PM
sbc100 updated the diff for D27355: [WebAssembly] Add wasm support for llvm-readobj.
  • Rename sections to
  • Merge remote-tracking branch 'origin/master' into wasm_readobj_support
  • Merge remote-tracking branch 'origin/master' into wasm_readobj_support
Dec 6 2016, 1:48 PM

Dec 2 2016

sbc100 updated the diff for D27355: [WebAssembly] Add wasm support for llvm-readobj.
  • Run clang-format
Dec 2 2016, 1:01 PM
sbc100 added reviewers for D27355: [WebAssembly] Add wasm support for llvm-readobj: sunfish, Bigcheese.
Dec 2 2016, 10:18 AM
sbc100 retitled D27355: [WebAssembly] Add wasm support for llvm-readobj from to [WebAssembly] Add wasm support for llvm-readobj.
Dec 2 2016, 10:16 AM

Nov 21 2016

sbc100 added inline comments to D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
Nov 21 2016, 5:42 PM
sbc100 updated the diff for D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
  • Remove inline from classof and use StringError
Nov 21 2016, 5:41 PM
sbc100 added inline comments to D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
Nov 21 2016, 5:25 PM
sbc100 updated the diff for D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
  • Better support for user sections
  • Update identify_magic change to match recent changes
  • Remove unused parse functions
  • Run clang-format
  • Cleanup program header
  • Add comments to Wasm.h
  • Add check for empty section
  • Add comment and remove unneeded friend declartions
Nov 21 2016, 5:25 PM
sbc100 added a comment to D26172: [WebAssembly] Add llvm-objdump support for wasm file format.

Anything else blocking this CL? I think I addressed all the feedback so far.

Nov 21 2016, 10:26 AM

Nov 16 2016

sbc100 added inline comments to D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
Nov 16 2016, 10:38 AM
sbc100 updated the diff for D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
  • Better support for user sections
  • Update identify_magic change to match recent changes
  • Remove unused parse functions
  • Run clang-format
  • Cleanup program header
  • Add comments to Wasm.h
  • Add check for empty section
Nov 16 2016, 10:35 AM

Nov 15 2016

sbc100 retitled D26172: [WebAssembly] Add llvm-objdump support for wasm file format from Add llvm-objdump support for wasm file format to [WebAssembly] Add llvm-objdump support for wasm file format.
Nov 15 2016, 6:06 PM
sbc100 added a comment to D26172: [WebAssembly] Add llvm-objdump support for wasm file format.

I removed a lot of the code that is not needed for this initial PR.

Nov 15 2016, 5:48 PM
sbc100 updated the diff for D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
  • Better support for user sections
  • Update identify_magic change to match recent changes
  • Remove unused parse functions
  • Run clang-format
  • Cleanup program header
Nov 15 2016, 5:41 PM
sbc100 added a comment to D26172: [WebAssembly] Add llvm-objdump support for wasm file format.

I could probably remove a all/most of the parseXXXSection functions from the PR actually since they are not used by objdump directly. Would make the PR smaller and mean less up-front parsing in the WasmObjectFile.cpp.

Nov 15 2016, 3:12 PM
sbc100 updated the diff for D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
  • Update identify_magic change to match recent changes
Nov 15 2016, 12:03 PM
sbc100 added a comment to D26172: [WebAssembly] Add llvm-objdump support for wasm file format.

@Bigcheese would you mind taking a look? I think this is the smallest testable unit that makes sense.

Nov 15 2016, 11:57 AM
sbc100 updated the diff for D26172: [WebAssembly] Add llvm-objdump support for wasm file format.
  • Better support for user sections
Nov 15 2016, 10:54 AM

Nov 14 2016

sbc100 abandoned D25590: Add initial support for WebAssembly binary format.
Nov 14 2016, 4:11 PM
sbc100 added a comment to D25590: Add initial support for WebAssembly binary format.

Closing in favor of https://reviews.llvm.org/D26172

Nov 14 2016, 4:08 PM
sbc100 updated the diff for D26172: [WebAssembly] Add llvm-objdump support for wasm file format.

Handle USER sections

Nov 14 2016, 4:08 PM

Oct 31 2016

sbc100 added reviewers for D26172: [WebAssembly] Add llvm-objdump support for wasm file format: sunfish, Bigcheese.
Oct 31 2016, 4:36 PM
sbc100 retitled D26172: [WebAssembly] Add llvm-objdump support for wasm file format from to Add llvm-objdump support for wasm file format.
Oct 31 2016, 4:27 PM
sbc100 added inline comments to D25590: Add initial support for WebAssembly binary format.
Oct 31 2016, 3:02 PM
sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.
  • Fixes based on code review
Oct 31 2016, 3:00 PM

Oct 28 2016

sbc100 added a reviewer for D25590: Add initial support for WebAssembly binary format: Bigcheese.
Oct 28 2016, 11:04 AM

Oct 27 2016

sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.
  • Add support for START and GLOBAL sections and add tests
Oct 27 2016, 9:28 PM

Oct 26 2016

sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.
  • Add support for global section
Oct 26 2016, 8:23 PM
sbc100 updated D25590: Add initial support for WebAssembly binary format.
Oct 26 2016, 7:52 PM
sbc100 updated D25590: Add initial support for WebAssembly binary format.
Oct 26 2016, 7:49 PM
sbc100 updated D25590: Add initial support for WebAssembly binary format.
Oct 26 2016, 7:49 PM
sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.
  • Add objdump support
Oct 26 2016, 7:40 PM
sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.
  • Update to 0xd
Oct 26 2016, 4:49 PM
sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.

Add data section handling
Remove un-needed opcodes

Oct 26 2016, 3:34 PM
sbc100 added inline comments to D25590: Add initial support for WebAssembly binary format.
Oct 26 2016, 9:20 AM
sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.

Parse all non-code sections.

Oct 26 2016, 9:17 AM

Oct 18 2016

sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.

Remove some debugging

Oct 18 2016, 5:03 PM
sbc100 updated the diff for D25590: Add initial support for WebAssembly binary format.

Add objdump support

Oct 18 2016, 4:58 PM

Oct 13 2016

sbc100 updated D25590: Add initial support for WebAssembly binary format.
Oct 13 2016, 7:24 PM
sbc100 retitled D25590: Add initial support for WebAssembly binary format from to Add initial support for WebAssembly binary format.
Oct 13 2016, 7:20 PM

Sep 16 2016

sbc100 added a comment to D24676: Install libLLVM if needed with LLVM_INSTALL_TOOLCHAIN_ONLY.

My first llvm change... please excuse my lack of knowledge.

Sep 16 2016, 11:02 AM
sbc100 added reviewers for D24676: Install libLLVM if needed with LLVM_INSTALL_TOOLCHAIN_ONLY: dschuff, beanz.
Sep 16 2016, 11:01 AM
sbc100 retitled D24676: Install libLLVM if needed with LLVM_INSTALL_TOOLCHAIN_ONLY from to Install libLLVM if needed with LLVM_INSTALL_TOOLCHAIN_ONLY.
Sep 16 2016, 10:33 AM