sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (32 w, 1 d)

Recent Activity

Fri, Apr 28

sbc100 added inline comments to D32513: [WebAssembly] Fix offsets for data relocations.
Fri, Apr 28, 2:33 PM
sbc100 updated the diff for D32513: [WebAssembly] Fix offsets for data relocations.
  • Merge remote-tracking branch 'origin/master' into fix_data_relocations
  • formatting
Fri, Apr 28, 2:32 PM
sbc100 updated the diff for D32660: [WebAssembly] Write initial memory in pages not bytes.
  • fix typo
Fri, Apr 28, 2:24 PM
sbc100 added reviewers for D32660: [WebAssembly] Write initial memory in pages not bytes: sunfish, dschuff.
Fri, Apr 28, 2:13 PM
sbc100 created D32660: [WebAssembly] Write initial memory in pages not bytes.
Fri, Apr 28, 2:13 PM
sbc100 added a comment to D32513: [WebAssembly] Fix offsets for data relocations.

Don't have a strong opinion but this seems better than fixing up the relocations separately. Maybe the comment on the SectionOffset field of MCSectionWasm should be updated (or some other place) to say that the section offsets don't include headers. Also it says "code section" when it's really more general than that now.

Fri, Apr 28, 1:49 PM
sbc100 updated the diff for D32513: [WebAssembly] Fix offsets for data relocations.
  • formatting + comment fix
Fri, Apr 28, 1:49 PM
sbc100 updated the diff for D32513: [WebAssembly] Fix offsets for data relocations.
  • Merge remote-tracking branch 'origin/master' into fix_data_relocations
  • add offsets
  • Merge remote-tracking branch 'origin/master' into fix_data_relocations
  • Merge remote-tracking branch 'origin/master' into fix_data_relocations
  • use signed addend
Fri, Apr 28, 1:28 PM

Thu, Apr 27

sbc100 added inline comments to D32558: [WebAssembly] Add some tests for wasm MC layer.
Thu, Apr 27, 5:25 PM
sbc100 updated the summary of D32558: [WebAssembly] Add some tests for wasm MC layer.
Thu, Apr 27, 5:25 PM
sbc100 updated the diff for D32558: [WebAssembly] Add some tests for wasm MC layer.
  • Merge remote-tracking branch 'origin/master' into add_tests
  • Only emit addends for relevant relocations
Thu, Apr 27, 5:22 PM
sbc100 updated the diff for D32513: [WebAssembly] Fix offsets for data relocations.
  • simplify
Thu, Apr 27, 12:06 PM

Wed, Apr 26

sbc100 updated the diff for D32513: [WebAssembly] Fix offsets for data relocations.
  • update comment
Wed, Apr 26, 2:48 PM
sbc100 updated the summary of D32513: [WebAssembly] Fix offsets for data relocations.
Wed, Apr 26, 2:45 PM
sbc100 updated the diff for D32513: [WebAssembly] Fix offsets for data relocations.
  • Merge remote-tracking branch 'origin/master' into fix_data_relocations
  • Add test
Wed, Apr 26, 2:44 PM
sbc100 added a reviewer for D32558: [WebAssembly] Add some tests for wasm MC layer: sunfish.
Wed, Apr 26, 2:14 PM
sbc100 updated the diff for D32558: [WebAssembly] Add some tests for wasm MC layer.
  • Add sections test
Wed, Apr 26, 2:14 PM
sbc100 created D32558: [WebAssembly] Add some tests for wasm MC layer.
Wed, Apr 26, 2:12 PM

Tue, Apr 25

sbc100 retitled D32513: [WebAssembly] Fix offsets for data relocations from [WebAssembly] Add size of section header to data relocation offsets. to [WebAssembly] Fix offsets for data relocations.
Tue, Apr 25, 5:31 PM
sbc100 created D32513: [WebAssembly] Fix offsets for data relocations.
Tue, Apr 25, 5:25 PM
sbc100 added a comment to rL301370: revert debugging.

Sorry, I forgot to squash this fixup before dcommit'ing. I will be more careful next time.

Tue, Apr 25, 5:23 PM
sbc100 updated the summary of D32507: [WebAssembly] Allow for signed relocation addends.
Tue, Apr 25, 3:13 PM
sbc100 updated the diff for D32507: [WebAssembly] Allow for signed relocation addends.
  • revert debugging
Tue, Apr 25, 3:12 PM
sbc100 created D32507: [WebAssembly] Allow for signed relocation addends.
Tue, Apr 25, 3:11 PM
sbc100 added a comment to D32459: [WebAssembly] Fix relocation count in wasm binaries with call_indirect.

Yes, I believe we are now in a position to write tests for this stuff, but I've not looked into the details yet, and would rather not block this minor fix on that larger change.

Tue, Apr 25, 10:05 AM

Mon, Apr 24

sbc100 updated the summary of D32462: [WebAssembly] Read global index in init expression as LEB.
Mon, Apr 24, 6:05 PM
sbc100 created D32462: [WebAssembly] Read global index in init expression as LEB.
Mon, Apr 24, 6:04 PM
sbc100 updated the summary of D32459: [WebAssembly] Fix relocation count in wasm binaries with call_indirect.
Mon, Apr 24, 5:35 PM
sbc100 added reviewers for D32459: [WebAssembly] Fix relocation count in wasm binaries with call_indirect: dschuff, sunfish.
Mon, Apr 24, 5:33 PM
sbc100 created D32459: [WebAssembly] Fix relocation count in wasm binaries with call_indirect.
Mon, Apr 24, 5:33 PM

Thu, Apr 20

sbc100 added a reviewer for D32300: [WebAssembly] Add known failures for wasm object file backend: dschuff.
Thu, Apr 20, 9:51 AM
sbc100 created D32300: [WebAssembly] Add known failures for wasm object file backend.
Thu, Apr 20, 9:49 AM

Thu, Apr 6

sbc100 added a comment to D31514: [WebAssembly] Improve readobj and nm support for wasm.

ping

Thu, Apr 6, 5:24 PM

Mon, Apr 3

sbc100 added reviewers for D31514: [WebAssembly] Improve readobj and nm support for wasm: sunfish, dschuff.
Mon, Apr 3, 3:57 PM
sbc100 added inline comments to D31514: [WebAssembly] Improve readobj and nm support for wasm.
Mon, Apr 3, 3:57 PM
sbc100 updated the diff for D31514: [WebAssembly] Improve readobj and nm support for wasm.
  • Merge remote-tracking branch 'origin/master' into better_nm_readobj_support
  • use printEnum in WasmDumper.cpp
Mon, Apr 3, 3:53 PM
sbc100 added a comment to D31351: [yaml2obj] Improve error message when output file cannot be opened.

Could you land this for me? (I'm not yet a committer)

Mon, Apr 3, 3:27 PM

Fri, Mar 31

sbc100 updated the diff for D31551: Add virtual destructor to WasmYAML::Section or avoid memory leak.
  • move virtual method to cpp file
Fri, Mar 31, 3:17 PM
sbc100 updated subscribers of D31551: Add virtual destructor to WasmYAML::Section or avoid memory leak.
Fri, Mar 31, 2:54 PM
sbc100 added a reviewer for D31551: Add virtual destructor to WasmYAML::Section or avoid memory leak: dschuff.
Fri, Mar 31, 2:53 PM
sbc100 added a comment to D31099: [WebAssembly] Improve support for WebAssembly binary format.

https://reviews.llvm.org/D31551 should fix the leak.

Fri, Mar 31, 2:52 PM
sbc100 created D31551: Add virtual destructor to WasmYAML::Section or avoid memory leak.
Fri, Mar 31, 2:52 PM
sbc100 added a comment to D31099: [WebAssembly] Improve support for WebAssembly binary format.
Fri, Mar 31, 1:36 PM

Mar 30 2017

sbc100 created D31514: [WebAssembly] Improve readobj and nm support for wasm.
Mar 30 2017, 3:42 PM
sbc100 added inline comments to D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mar 30 2017, 9:29 AM

Mar 28 2017

sbc100 added a comment to D31351: [yaml2obj] Improve error message when output file cannot be opened.

This change should wait until D31436 lands

Mar 28 2017, 4:16 PM
sbc100 retitled D31351: [yaml2obj] Improve error message when output file cannot be opened from yaml2obj: Improve error message when output file cannot be opened to [yaml2obj] Improve error message when output file cannot be opened.
Mar 28 2017, 4:16 PM
sbc100 added a comment to D31436: [yaml2obj] Enable and fix tests.

Would you mind committing this (I'm not yet a committer).

Mar 28 2017, 4:00 PM
sbc100 updated the summary of D31436: [yaml2obj] Enable and fix tests.
Mar 28 2017, 4:00 PM
sbc100 added inline comments to D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mar 28 2017, 1:40 PM
sbc100 added a reviewer for D31436: [yaml2obj] Enable and fix tests: beanz.
Mar 28 2017, 1:37 PM
sbc100 retitled D31436: [yaml2obj] Enable and fix tests from Enable yaml2obj tests to [yaml2obj] Enable and fix tests.
Mar 28 2017, 1:36 PM
sbc100 created D31436: [yaml2obj] Enable and fix tests.
Mar 28 2017, 1:36 PM
sbc100 added a comment to D31351: [yaml2obj] Improve error message when output file cannot be opened.

While working on this I noticed that the other tests in test/yaml2obj/ don't even run because they have the wrong extension. I upload a separate change for that

Mar 28 2017, 1:11 PM
sbc100 retitled D31351: [yaml2obj] Improve error message when output file cannot be opened from yaml2obj: Prefix errors with "Error: " to match obj2yaml to yaml2obj: Improve error message when output file cannot be opened.
Mar 28 2017, 1:11 PM
sbc100 updated the diff for D31351: [yaml2obj] Improve error message when output file cannot be opened.
  • add test
  • Merge remote-tracking branch 'origin/master' into yaml2obj_error
  • update expected output
Mar 28 2017, 1:10 PM

Mar 24 2017

sbc100 added inline comments to D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mar 24 2017, 2:01 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • add index to types in yaml
  • Merge remote-tracking branch 'origin/master' into add_wasm_object_type
  • Split out unrelated change
Mar 24 2017, 2:01 PM
sbc100 added a reviewer for D31351: [yaml2obj] Improve error message when output file cannot be opened: davide.
Mar 24 2017, 1:43 PM
sbc100 created D31351: [yaml2obj] Improve error message when output file cannot be opened.
Mar 24 2017, 1:42 PM

Mar 23 2017

sbc100 added a reviewer for D31099: [WebAssembly] Improve support for WebAssembly binary format: Bigcheese.
Mar 23 2017, 1:23 PM

Mar 21 2017

sbc100 added a reviewer for D31227: [WebAssembly] Fix import type to be signed LEBs: sunfish.
Mar 21 2017, 5:47 PM
sbc100 created D31227: [WebAssembly] Fix import type to be signed LEBs.
Mar 21 2017, 5:46 PM
sbc100 abandoned D31214: revert some parts to keep change smalle.
Mar 21 2017, 2:55 PM
sbc100 added a comment to D31099: [WebAssembly] Improve support for WebAssembly binary format.

I agree this change was a little large. I removed the parts that I could. Now its pretty much only overs obj2yaml and yaml2obj.

Mar 21 2017, 2:50 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • remove trivial accessors
Mar 21 2017, 2:49 PM
sbc100 updated the summary of D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mar 21 2017, 2:49 PM
sbc100 updated the summary of D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mar 21 2017, 2:48 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • revert some parts to keep change smalle
Mar 21 2017, 2:41 PM
sbc100 created D31214: revert some parts to keep change smalle.
Mar 21 2017, 2:40 PM

Mar 20 2017

sbc100 added a reviewer for D31099: [WebAssembly] Improve support for WebAssembly binary format: davide.
Mar 20 2017, 4:13 PM
sbc100 added inline comments to D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mar 20 2017, 3:59 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • add support for reading and dumping relocations
Mar 20 2017, 3:58 PM

Mar 17 2017

sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • cleanup based on feedback
Mar 17 2017, 5:23 PM
sbc100 updated the diff for D31099: [WebAssembly] Improve support for WebAssembly binary format.
  • refactor section parsing
Mar 17 2017, 1:47 PM
sbc100 added a reviewer for D31099: [WebAssembly] Improve support for WebAssembly binary format: sunfish.
Mar 17 2017, 1:40 PM
sbc100 abandoned D30318: [WebAssembly] Add initial support for llvm-nm.

Abandoning in favor of larger change that handles imports and exports too: https://reviews.llvm.org/D31099

Mar 17 2017, 1:40 PM
sbc100 created D31099: [WebAssembly] Improve support for WebAssembly binary format.
Mar 17 2017, 1:37 PM

Mar 16 2017

sbc100 added inline comments to D31064: [WebAssembly] Linking metadata support.
Mar 16 2017, 5:56 PM
sbc100 updated the diff for D31014: [WebAssembly] Fix some broken type encodings in wasm binary.
  • make emitValueType protected
Mar 16 2017, 11:08 AM

Mar 15 2017

sbc100 added a reviewer for D31014: [WebAssembly] Fix some broken type encodings in wasm binary: sunfish.
Mar 15 2017, 4:45 PM
sbc100 created D31014: [WebAssembly] Fix some broken type encodings in wasm binary.
Mar 15 2017, 4:45 PM
sbc100 updated the diff for D30950: [WebAssembly] Update format of 'names' section..
  • prefer preincrement
Mar 15 2017, 10:31 AM

Mar 14 2017

sbc100 retitled D30950: [WebAssembly] Update format of 'names' section. from [WebAssembly] Update format of 'names' sectionThis change updates to the format of the 'names' sectionin the generated wasm binary to match the latest changesto the design and 'wabt'. to [WebAssembly] Update format of 'names' section..
Mar 14 2017, 2:36 PM
sbc100 updated the diff for D30950: [WebAssembly] Update format of 'names' section..
  • Merge remote-tracking branch 'origin/master' into new_names_section
Mar 14 2017, 2:32 PM
sbc100 retitled D30950: [WebAssembly] Update format of 'names' section. from [WebAssembly] Update format of 'names' section This change updates to the format of the 'names' section in the generated wasm binary to match the latest changes to the design and 'wabt'. to [WebAssembly] Update format of 'names' sectionThis change updates to the format of the 'names' sectionin the generated wasm binary to match the latest changesto the design and 'wabt'..
Mar 14 2017, 12:05 PM
sbc100 created D30950: [WebAssembly] Update format of 'names' section..
Mar 14 2017, 12:04 PM
sbc100 added a comment to D30847: [WebAssembly] Use LEB encoding for value types.

Ping? Hopefully this change is good to go now.

Mar 14 2017, 10:47 AM

Mar 13 2017

sbc100 updated the diff for D30318: [WebAssembly] Add initial support for llvm-nm.
  • update wasm binaries
  • Update to new names section format
Mar 13 2017, 5:40 PM
sbc100 added a comment to D30847: [WebAssembly] Use LEB encoding for value types.

In terms the namespacing, yes it probably makes sense to try to merge them and be consistent, but thats not something for this PR.

Mar 13 2017, 11:39 AM
sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.
  • remove MVT2WasmType in favor of WebAssembly::toValType
  • Merge remote-tracking branch 'refs/remotes/origin/master' into fix_value_types
Mar 13 2017, 9:59 AM

Mar 10 2017

sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.
  • Move more types to Support/Wasm.h
  • clang-format
Mar 10 2017, 6:22 PM
sbc100 added inline comments to D30847: [WebAssembly] Use LEB encoding for value types.
Mar 10 2017, 3:17 PM
sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.
  • Revert change of Nop and End types
Mar 10 2017, 3:12 PM
sbc100 updated the diff for D30847: [WebAssembly] Use LEB encoding for value types.

Update types in WebAssemblyMCTargetDesc.h

Mar 10 2017, 3:10 PM
sbc100 added a reviewer for D30847: [WebAssembly] Use LEB encoding for value types: sunfish.
Mar 10 2017, 2:19 PM
sbc100 created D30847: [WebAssembly] Use LEB encoding for value types.
Mar 10 2017, 2:18 PM

Feb 23 2017

sbc100 added a reviewer for D30318: [WebAssembly] Add initial support for llvm-nm: Bigcheese.
Feb 23 2017, 6:10 PM
sbc100 created D30318: [WebAssembly] Add initial support for llvm-nm.
Feb 23 2017, 6:09 PM

Jan 30 2017

sbc100 added inline comments to D27355: [WebAssembly] Add wasm support for llvm-readobj.
Jan 30 2017, 2:41 PM