Page MenuHomePhabricator

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (174 w, 19 h)

Recent Activity

Yesterday

sbc100 updated the diff for D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
  • revert
Fri, Jan 17, 2:05 PM · Restricted Project
sbc100 added a comment to D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.

@ruiu I'm curious what you think about this problem, and this approach to solving it.

Fri, Jan 17, 2:05 PM · Restricted Project
sbc100 added a comment to D71793: [WebAssembly] Support wasm exports with zero-length names..

Shall we land this?

Fri, Jan 17, 1:55 PM · Restricted Project
sbc100 committed rG2754a67ba9e9: Revert "[llvm-nm] Don't report "no symbols" error for files that contain… (authored by sbc100).
Revert "[llvm-nm] Don't report "no symbols" error for files that contain…
Fri, Jan 17, 10:04 AM
sbc100 added a reverting change for rGab974161ba69: [llvm-nm] Don't report "no symbols" error for files that contain symbols: rG2754a67ba9e9: Revert "[llvm-nm] Don't report "no symbols" error for files that contain….
Fri, Jan 17, 10:03 AM
sbc100 added a comment to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.

Oops, looks like this broke some tests. Investigating.

Fri, Jan 17, 9:53 AM · Restricted Project
sbc100 committed rGab974161ba69: [llvm-nm] Don't report "no symbols" error for files that contain symbols (authored by sbc100).
[llvm-nm] Don't report "no symbols" error for files that contain symbols
Fri, Jan 17, 9:35 AM
sbc100 closed D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
Fri, Jan 17, 9:35 AM · Restricted Project

Thu, Jan 16

sbc100 committed rG51b521c07a7a: [lld][WebAssembly] Use a more meaningful name for stub functions (authored by sbc100).
[lld][WebAssembly] Use a more meaningful name for stub functions
Thu, Jan 16, 3:04 PM
sbc100 closed D72881: [lld][WebAssembly] Use a more meaningful name for stub functions.
Thu, Jan 16, 3:03 PM · Restricted Project
sbc100 created D72881: [lld][WebAssembly] Use a more meaningful name for stub functions.
Thu, Jan 16, 2:43 PM · Restricted Project
sbc100 added a reviewer for D72881: [lld][WebAssembly] Use a more meaningful name for stub functions: ruiu.
Thu, Jan 16, 2:43 PM · Restricted Project
sbc100 added a comment to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.

D72718 landed first so switched to StringRef for args. Also remove extra indentation in yaml.

Thu, Jan 16, 2:15 PM · Restricted Project
sbc100 updated the diff for D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
  • remove indentation
Thu, Jan 16, 2:15 PM · Restricted Project
sbc100 updated the diff for D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
  • rebase
Thu, Jan 16, 2:15 PM · Restricted Project
sbc100 committed rGfa4112fffc6b: [llvm-nm] Use `StringRef` over `const std::string &` params (authored by sbc100).
[llvm-nm] Use `StringRef` over `const std::string &` params
Thu, Jan 16, 2:06 PM
sbc100 closed D72718: [llvm-nm] Use `StringRef` over `const std::string &` params.
Thu, Jan 16, 2:06 PM · Restricted Project
sbc100 updated the diff for D72718: [llvm-nm] Use `StringRef` over `const std::string &` params.

clang-format

Thu, Jan 16, 2:06 PM · Restricted Project
sbc100 updated the diff for D72718: [llvm-nm] Use `StringRef` over `const std::string &` params.
  • rebase
Thu, Jan 16, 2:06 PM · Restricted Project

Wed, Jan 15

sbc100 accepted D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`.
Wed, Jan 15, 3:15 PM · Restricted Project, Restricted Project
sbc100 added a comment to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.

ptal

Wed, Jan 15, 10:12 AM · Restricted Project
sbc100 updated the diff for D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
  • remove old check
Wed, Jan 15, 10:12 AM · Restricted Project

Tue, Jan 14

sbc100 abandoned D72727: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
Tue, Jan 14, 11:52 AM · Restricted Project
sbc100 added a comment to D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.

@ruiu, I tested the ELF linking I an believe it has the same problem. With ELF it looks like the effect is that bitcode symbols all end up with address 0 in the final binary. I think its better to fail at link time.. so we should probably port this change, or something like it to ELF.

Tue, Jan 14, 11:43 AM · Restricted Project
sbc100 updated the diff for D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
  • feedback
Tue, Jan 14, 11:42 AM · Restricted Project
sbc100 updated the summary of D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
Tue, Jan 14, 11:42 AM · Restricted Project
sbc100 planned changes to D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
Tue, Jan 14, 11:42 AM · Restricted Project
sbc100 updated the summary of D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
Tue, Jan 14, 11:42 AM · Restricted Project
sbc100 updated the diff for D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
  • rebase
Tue, Jan 14, 11:41 AM · Restricted Project
sbc100 created D72727: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
Tue, Jan 14, 11:41 AM · Restricted Project
sbc100 created D72718: [llvm-nm] Use `StringRef` over `const std::string &` params.
Tue, Jan 14, 9:55 AM · Restricted Project
sbc100 added a comment to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.

Followup change to convert params to StringRef: https://reviews.llvm.org/D72718

Tue, Jan 14, 9:55 AM · Restricted Project
sbc100 abandoned D72716: static.
Tue, Jan 14, 9:55 AM · Restricted Project
sbc100 updated the diff for D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
  • static
Tue, Jan 14, 9:55 AM · Restricted Project
sbc100 updated the diff for D72716: static.

static

Tue, Jan 14, 9:45 AM · Restricted Project
sbc100 created D72716: static.
Tue, Jan 14, 9:45 AM · Restricted Project
sbc100 updated the diff for D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
  • double comments
  • use [[FILE]]
Tue, Jan 14, 9:36 AM · Restricted Project
sbc100 added inline comments to D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
Tue, Jan 14, 9:36 AM · Restricted Project
sbc100 updated the diff for D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
  • use count
Tue, Jan 14, 9:18 AM · Restricted Project

Mon, Jan 13

sbc100 updated the summary of D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
Mon, Jan 13, 3:17 PM · Restricted Project
sbc100 added a reviewer for D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols: rupprecht.
Mon, Jan 13, 3:17 PM · Restricted Project
sbc100 created D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.
Mon, Jan 13, 3:17 PM · Restricted Project
sbc100 added a comment to D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols.

In emscripten we don't parse "no symbols" but we do run "llvm-nm -print-armap" and out users are seeing noise when they have objects with no symbols (not because they are stripped but simply because there are no public symbols).

Mon, Jan 13, 3:08 PM · Restricted Project
Herald added a reviewer for D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols: jhenderson.

I it seems that the printing of this error message only occurs with GNU nm if the object doesn't have a symbols table at all. Have no symbols in the table does not print the error message.

Mon, Jan 13, 1:05 PM · Restricted Project

Sat, Jan 11

sbc100 added inline comments to D71823: Support Swift calling convention for WebAssembly targets.
Sat, Jan 11, 9:42 AM · Restricted Project, Restricted Project

Fri, Jan 10

sbc100 committed rG9cd985815abf: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used. (authored by sbc100).
[lld][WebAssembly] Add libcall symbols to the link when LTO is being used.
Fri, Jan 10, 11:09 AM
sbc100 closed D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..
Fri, Jan 10, 11:09 AM · Restricted Project

Thu, Jan 9

sbc100 updated the diff for D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..
  • add comment
Thu, Jan 9, 11:57 AM · Restricted Project
sbc100 added a comment to D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..

friendly ping.

Thu, Jan 9, 11:11 AM · Restricted Project

Sun, Jan 5

sbc100 accepted D71793: [WebAssembly] Support wasm exports with zero-length names..
Sun, Jan 5, 9:17 AM · Restricted Project

Fri, Dec 20

sbc100 added a comment to D71788: [llvm-strip] Add WebAssembly support.

Is this an in-flight collision with https://reviews.llvm.org/D70930?

Fri, Dec 20, 4:10 PM · Restricted Project
sbc100 committed rG538b485c59fa: Fix name of InitLibcalls() function in comment (authored by sbc100).
Fix name of InitLibcalls() function in comment
Fri, Dec 20, 2:39 PM
sbc100 closed D71781: Fix name of InitLibcalls function in comment.
Fri, Dec 20, 2:38 PM · Restricted Project
sbc100 added inline comments to D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..
Fri, Dec 20, 2:18 PM · Restricted Project
sbc100 updated the summary of D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..
Fri, Dec 20, 1:25 PM · Restricted Project
sbc100 updated the diff for D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..

rebase

Fri, Dec 20, 1:25 PM · Restricted Project
sbc100 added a reviewer for D71781: Fix name of InitLibcalls function in comment: dschuff.
Fri, Dec 20, 1:04 PM · Restricted Project
sbc100 created D71781: Fix name of InitLibcalls function in comment.
Fri, Dec 20, 1:04 PM · Restricted Project
sbc100 added a comment to D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..

Adding pcc who wrote the original code.

Fri, Dec 20, 12:49 PM · Restricted Project
sbc100 added a comment to D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..

ping.. should be uncontroversial since this code its basically identical to ELF/COFF backends,.

Fri, Dec 20, 12:49 PM · Restricted Project
sbc100 added a reviewer for D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used.: pcc.
Fri, Dec 20, 12:49 PM · Restricted Project
sbc100 added a comment to D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`.

wasm_argc_argv -> main_argc_argv in the title?

Fri, Dec 20, 12:23 PM · Restricted Project, Restricted Project

Thu, Dec 19

sbc100 added reviewers for D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used.: dschuff, ruiu.
Thu, Dec 19, 5:34 PM · Restricted Project
sbc100 created D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..
Thu, Dec 19, 5:28 PM · Restricted Project

Dec 18 2019

sbc100 added a comment to D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.

I'm going abandon this change in favor of copying the code that already exists in COFF and ELF for handling this.

Dec 18 2019, 11:26 AM · Restricted Project

Dec 17 2019

sbc100 added a comment to D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.

Actually it looks like we can handle this more gracefully, like ELF does:
https://reviews.llvm.org/D50017
https://reviews.llvm.org/D50475

Dec 17 2019, 4:32 PM · Restricted Project
sbc100 added a comment to D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.

I think this problem could also effect other backend.. working on test case to verify if this is true.

Dec 17 2019, 2:56 PM · Restricted Project
sbc100 added a reviewer for D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO: ruiu.
Dec 17 2019, 2:51 PM · Restricted Project
sbc100 updated the diff for D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
  • spelling
Dec 17 2019, 2:51 PM · Restricted Project
sbc100 added a reviewer for D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO: dschuff.
Dec 17 2019, 2:50 PM · Restricted Project
sbc100 created D71632: [lld][WebAssembly] Fail if bitcode objects are pulled in after LTO.
Dec 17 2019, 2:50 PM · Restricted Project
sbc100 committed rG8aee6b414a89: [WebAssembly] Convert MC tests to from bitcode to asm (authored by sbc100).
[WebAssembly] Convert MC tests to from bitcode to asm
Dec 17 2019, 11:36 AM
sbc100 closed D71506: [WebAssembly] Convert MC tests to from bitcode to asm.
Dec 17 2019, 11:36 AM · Restricted Project

Dec 16 2019

sbc100 added a comment to D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging.

I don't know the lldb codebase, but from a webassembly perspective this looks promising.

Dec 16 2019, 3:57 PM · Restricted Project
sbc100 updated the diff for D71506: [WebAssembly] Convert MC tests to from bitcode to asm.
  • remove attrs
Dec 16 2019, 3:02 PM · Restricted Project
sbc100 committed rG0a1e349a7933: [WebAssembly] Setting export_name implies llvm.used (authored by sbc100).
[WebAssembly] Setting export_name implies llvm.used
Dec 16 2019, 2:49 PM
sbc100 closed D71493: [WebAssembly] Setting export_name implies no_dead_strip.
Dec 16 2019, 2:49 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D71493: [WebAssembly] Setting export_name implies no_dead_strip.
  • revert part
Dec 16 2019, 2:44 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D71493: [WebAssembly] Setting export_name implies no_dead_strip.
Dec 16 2019, 2:44 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D71493: [WebAssembly] Setting export_name implies no_dead_strip.

rebase

Dec 16 2019, 1:58 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D71506: [WebAssembly] Convert MC tests to from bitcode to asm.

rebase

Dec 16 2019, 1:49 PM · Restricted Project

Dec 13 2019

sbc100 added reviewers for D71506: [WebAssembly] Convert MC tests to from bitcode to asm: dschuff, aardappel.
Dec 13 2019, 7:31 PM · Restricted Project
sbc100 created D71506: [WebAssembly] Convert MC tests to from bitcode to asm.
Dec 13 2019, 7:31 PM · Restricted Project
sbc100 added reviewers for D71493: [WebAssembly] Setting export_name implies no_dead_strip: dschuff, sunfish.
Dec 13 2019, 2:50 PM · Restricted Project, Restricted Project
sbc100 created D71493: [WebAssembly] Setting export_name implies no_dead_strip.
Dec 13 2019, 2:50 PM · Restricted Project, Restricted Project
sbc100 added a comment to D71484: [WebAssembly][InstrEmitter] Foundation for multivalue call lowering.

In the description you say " .. unique among upstream targets", and later "... WebAssembly and similar downstream targets.". Was it deliberate to use both "upstream" and "downstream", what do these term mean here? Also the "unique" statement seems to contract the "and similar" statement.

Dec 13 2019, 11:28 AM · Restricted Project
sbc100 accepted D70930: [llvm-objcopy][WebAssembly] Initial support for wasm in llvm-objcopy.

Looks fine from a wasm perspective.

Dec 13 2019, 9:28 AM · Restricted Project

Dec 12 2019

sbc100 added a comment to D71156: [WebAssembly] Don't crash when gnu-style pubnames are requested.

(sorry.. I wrote those comments a while back and forgot to hit send)..

Dec 12 2019, 2:27 PM · Restricted Project
sbc100 added a comment to D71156: [WebAssembly] Don't crash when gnu-style pubnames are requested.

I have be working on CL that does basically a superset of this to support -gsplit-dwarf. But maybe can land this first.

Dec 12 2019, 2:26 PM · Restricted Project

Dec 11 2019

sbc100 committed rG881d877846e2: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export… (authored by sbc100).
[WebAssembly] Add new `export_name` clang attribute for controlling wasm export…
Dec 11 2019, 11:59 AM
sbc100 closed D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names.
Dec 11 2019, 11:57 AM · Restricted Project, Restricted Project

Dec 9 2019

sbc100 added inline comments to D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names.
Dec 9 2019, 5:10 PM · Restricted Project, Restricted Project
sbc100 added a comment to D71203: [llvm-readobj][test] - Move platform specific test cases and their inputs to separate folders..

Would mind calling the WebAssembly subdirectory just "wasm". I know we currently have a bit of a mix of WebAssembly, wasm and Wasm in the codebase. I'm hoping to reduce this to just WebAssembly (for the target arch) and wasm (for the container format).

Dec 9 2019, 8:52 AM · Restricted Project

Dec 6 2019

sbc100 added a comment to D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names.

Ping .. I think this is good to go now.

Dec 6 2019, 5:38 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names.

Rebase

Dec 6 2019, 4:25 PM · Restricted Project, Restricted Project
sbc100 committed rGb4f4e370b59a: [WebAssebmly][MC] Support .import_name/.import_field asm directives (authored by sbc100).
[WebAssebmly][MC] Support .import_name/.import_field asm directives
Dec 6 2019, 3:12 PM
sbc100 closed D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives.
Dec 6 2019, 3:12 PM · Restricted Project, Restricted Project
sbc100 added a comment to D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives.

Ping ..

Dec 6 2019, 1:20 PM · Restricted Project, Restricted Project

Dec 5 2019

sbc100 added inline comments to D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives.
Dec 5 2019, 2:35 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives.
Dec 5 2019, 2:26 PM · Restricted Project, Restricted Project