Page MenuHomePhabricator

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (238 w, 5 d)

Recent Activity

Wed, Apr 7

sbc100 committed rGf23b259e1877: [WebAssembly] Improve error messages regarding missing indirect function table. (authored by sbc100).
[WebAssembly] Improve error messages regarding missing indirect function table.
Wed, Apr 7, 7:59 AM
sbc100 closed D99960: [WebAssembly] Improve error messages regarding missing indirect function table. NFC.
Wed, Apr 7, 7:59 AM · Restricted Project

Tue, Apr 6

sbc100 added a reviewer for D99960: [WebAssembly] Improve error messages regarding missing indirect function table. NFC: wingo.
Tue, Apr 6, 8:10 AM · Restricted Project
sbc100 updated the diff for D99960: [WebAssembly] Improve error messages regarding missing indirect function table. NFC.

typo

Tue, Apr 6, 8:10 AM · Restricted Project
sbc100 requested review of D99960: [WebAssembly] Improve error messages regarding missing indirect function table. NFC.
Tue, Apr 6, 8:09 AM · Restricted Project

Mon, Apr 5

sbc100 added a comment to D99887: [lld][WebAssembly] Add `--export-if-defined`.

I don't know wasm enough... In ELF, --export-dynamic-symbol only affects defined symbols. --export-dynamic affects all defined symbols. They don't have effect on other symbols.

Mon, Apr 5, 4:16 PM · Restricted Project
sbc100 added a comment to D99887: [lld][WebAssembly] Add `--export-if-defined`.

Pre-existing, but what does --export plus --allow-undefined do?

Mon, Apr 5, 4:15 PM · Restricted Project
sbc100 accepted D99904: [WebAssembly] Fix for PIC external symbol ISEL.
Mon, Apr 5, 4:13 PM · Restricted Project
sbc100 added a comment to D99887: [lld][WebAssembly] Add `--export-if-defined`.

I dont love the name of this option.. but I failed to come up with any thing nicer.

Mon, Apr 5, 11:24 AM · Restricted Project
sbc100 updated the diff for D99887: [lld][WebAssembly] Add `--export-if-defined`.

rebase

Mon, Apr 5, 11:17 AM · Restricted Project
sbc100 committed rGdc1a08caeff4: [lld][WebAssembly] Rewrite exports test in assembly. NFC (authored by sbc100).
[lld][WebAssembly] Rewrite exports test in assembly. NFC
Mon, Apr 5, 11:14 AM
sbc100 closed D99885: [lld][WebAssembly] Rewrite exports test in assembly. NFC.
Mon, Apr 5, 11:14 AM · Restricted Project
sbc100 added a reviewer for D99887: [lld][WebAssembly] Add `--export-if-defined`: dschuff.
Mon, Apr 5, 9:03 AM · Restricted Project
sbc100 requested review of D99887: [lld][WebAssembly] Add `--export-if-defined`.
Mon, Apr 5, 9:02 AM · Restricted Project
sbc100 updated the diff for D99885: [lld][WebAssembly] Rewrite exports test in assembly. NFC.

cleanup

Mon, Apr 5, 8:18 AM · Restricted Project
sbc100 added a reviewer for D99885: [lld][WebAssembly] Rewrite exports test in assembly. NFC: dschuff.
Mon, Apr 5, 8:17 AM · Restricted Project
sbc100 requested review of D99885: [lld][WebAssembly] Rewrite exports test in assembly. NFC.
Mon, Apr 5, 8:17 AM · Restricted Project

Sun, Apr 4

sbc100 added inline comments to D99171: [WebAssembly] Fold xor by inverting branch target.
Sun, Apr 4, 6:23 PM · Restricted Project

Tue, Mar 30

sbc100 added a comment to D99627: [WebAssembly] Encode numbers in ULEB128 in event section.

Man, these kind of bug are so common, and so hard to test and occur across so many different tools.. I wonder if we would have made a different choice if we have known how many issues LEB128 would cause.

Tue, Mar 30, 10:44 PM · Restricted Project

Wed, Mar 24

sbc100 accepted D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions.

Nice!

Wed, Mar 24, 10:32 AM · Restricted Project

Tue, Mar 23

sbc100 accepted D99191: [WebAssembly][MC] Record limit constraints for table sizes.

Great!

Tue, Mar 23, 9:27 AM · Restricted Project
sbc100 accepted D99186: [WebAssembly] Rename WasmLimits::Initial to ::Minimum. NFC..
Tue, Mar 23, 8:44 AM · Restricted Project

Mar 10 2021

sbc100 added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 10 2021, 4:26 PM · Restricted Project

Mar 8 2021

sbc100 committed rGaa0c571a5fa9: [WebAssembly] Add new relocation for location relative data (authored by kateinoigakukun).
[WebAssembly] Add new relocation for location relative data
Mar 8 2021, 11:35 AM
sbc100 closed D96659: [WebAssembly] Add new relocation for location relative data.
Mar 8 2021, 11:34 AM · Restricted Project

Mar 6 2021

sbc100 added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 6 2021, 6:46 PM · Restricted Project

Mar 5 2021

sbc100 updated the diff for D46443: [libc++] Add missing cstdalign header.

feedback

Mar 5 2021, 9:43 AM · Restricted Project
sbc100 updated the diff for D46443: [libc++] Add missing cstdalign header.

feedback

Mar 5 2021, 9:40 AM · Restricted Project
sbc100 added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 5 2021, 9:40 AM · Restricted Project
sbc100 added a comment to D81803: [Support] PR42623: Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive.

Just FTR, this change had to be reverted in Rust's LLVM fork because it breaks compilation on Windows 7, see https://github.com/rust-lang/rust/issues/81051.

Mar 5 2021, 8:31 AM · Restricted Project
sbc100 updated the diff for D46443: [libc++] Add missing cstdalign header.

add tests

Mar 5 2021, 8:27 AM · Restricted Project
sbc100 added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 5 2021, 8:26 AM · Restricted Project
sbc100 added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 5 2021, 8:12 AM · Restricted Project
sbc100 updated the diff for D46443: [libc++] Add missing cstdalign header.

feedback

Mar 5 2021, 7:27 AM · Restricted Project
sbc100 updated the diff for D46443: [libc++] Add missing cstdalign header.

Rebase against mono-repo

Mar 5 2021, 7:23 AM · Restricted Project

Mar 4 2021

sbc100 accepted D97923: [WebAssembly][yaml2obj][obj2yaml] Elem sections for nonzero tables.

lgtm!

Mar 4 2021, 8:03 AM · Restricted Project
sbc100 accepted D92321: [lld][WebAssembly] Allow element sections for nonzero table numbers.
Mar 4 2021, 7:55 AM · Restricted Project
sbc100 accepted D96659: [WebAssembly] Add new relocation for location relative data.
Mar 4 2021, 12:06 AM · Restricted Project

Mar 3 2021

sbc100 added a comment to D97843: [lld][WebAssembly] -Bsymbolic creates indirect function table if needed.

lgtm % comments / nits

Mar 3 2021, 7:30 AM · Restricted Project
sbc100 added inline comments to D92321: [lld][WebAssembly] Allow element sections for nonzero table numbers.
Mar 3 2021, 7:09 AM · Restricted Project

Mar 2 2021

sbc100 added inline comments to D92321: [lld][WebAssembly] Allow element sections for nonzero table numbers.
Mar 2 2021, 7:21 AM · Restricted Project

Mar 1 2021

sbc100 committed rG7d09e1d7cf27: [lld][WebAssembly] Minor refactor in preparation for SHF_STRINGS supports. NFC. (authored by sbc100).
[lld][WebAssembly] Minor refactor in preparation for SHF_STRINGS supports. NFC.
Mar 1 2021, 4:19 PM
sbc100 closed D97654: [lld][WebAssembly] Minor refactor in preparation for SHF_STRINGS supports. NFC..
Mar 1 2021, 4:19 PM · Restricted Project
sbc100 committed rG74ca5c2c1e02: [lld][WebAssembly] Convert lld/test/wasm/data-layout.ll to asm. NFC. (authored by sbc100).
[lld][WebAssembly] Convert lld/test/wasm/data-layout.ll to asm. NFC.
Mar 1 2021, 4:16 PM
sbc100 closed D97651: [lld][WebAssembly] Convert lld/test/wasm/data-layout.ll to asm. NFC..
Mar 1 2021, 4:16 PM · Restricted Project
sbc100 added a comment to D96659: [WebAssembly] Add new relocation for location relative data.

I don't have any more objections myself. @sunfish , WDYT of this addition? My feeling is that if it helps swift then its probably worth adding.

Mar 1 2021, 2:15 PM · Restricted Project

Feb 28 2021

sbc100 added a reviewer for D97657: [lld][WebAssembly] Initial support merging string data: dschuff.
Feb 28 2021, 10:03 PM · Restricted Project
sbc100 requested review of D97657: [lld][WebAssembly] Initial support merging string data.
Feb 28 2021, 10:03 PM · Restricted Project
sbc100 updated the diff for D97654: [lld][WebAssembly] Minor refactor in preparation for SHF_STRINGS supports. NFC..

cleanup

Feb 28 2021, 6:39 PM · Restricted Project
sbc100 added a reviewer for D97654: [lld][WebAssembly] Minor refactor in preparation for SHF_STRINGS supports. NFC.: dschuff.
Feb 28 2021, 6:38 PM · Restricted Project
sbc100 requested review of D97654: [lld][WebAssembly] Minor refactor in preparation for SHF_STRINGS supports. NFC..
Feb 28 2021, 6:37 PM · Restricted Project
sbc100 committed rGd49270b087e8: [lld][ELF] Removing redundant cast. NFC. (authored by sbc100).
[lld][ELF] Removing redundant cast. NFC.
Feb 28 2021, 6:22 PM
sbc100 closed D97647: [lld][ELF] Removing redundant cast. NFC..
Feb 28 2021, 6:22 PM · Restricted Project
sbc100 updated the summary of D97651: [lld][WebAssembly] Convert lld/test/wasm/data-layout.ll to asm. NFC..
Feb 28 2021, 6:20 PM · Restricted Project
sbc100 requested review of D97651: [lld][WebAssembly] Convert lld/test/wasm/data-layout.ll to asm. NFC..
Feb 28 2021, 6:17 PM · Restricted Project
sbc100 updated the diff for D97647: [lld][ELF] Removing redundant cast. NFC..

cleanup

Feb 28 2021, 4:50 PM · Restricted Project
sbc100 updated the summary of D97647: [lld][ELF] Removing redundant cast. NFC..
Feb 28 2021, 4:48 PM · Restricted Project
sbc100 requested review of D97647: [lld][ELF] Removing redundant cast. NFC..
Feb 28 2021, 4:44 PM · Restricted Project

Feb 26 2021

sbc100 committed rG14ffbb84aa45: [lld][WebAssembly] Rename methods/members to match ELF backend. NFC. (authored by sbc100).
[lld][WebAssembly] Rename methods/members to match ELF backend. NFC.
Feb 26 2021, 5:09 PM
sbc100 closed D97595: [lld][WebAssembly] Rename methods/members to match ELF backend. NFC..
Feb 26 2021, 5:08 PM · Restricted Project
sbc100 retitled D97595: [lld][WebAssembly] Rename methods/members to match ELF backend. NFC. from [lld][WebAssembly] Rename methods/members members to match ELF backend. NFC. to [lld][WebAssembly] Rename methods/members to match ELF backend. NFC..
Feb 26 2021, 4:16 PM · Restricted Project
sbc100 added a reviewer for D97595: [lld][WebAssembly] Rename methods/members to match ELF backend. NFC.: dschuff.
Feb 26 2021, 4:07 PM · Restricted Project
sbc100 requested review of D97595: [lld][WebAssembly] Rename methods/members to match ELF backend. NFC..
Feb 26 2021, 4:07 PM · Restricted Project
sbc100 accepted D97490: [WebAssembly] Avoid `bit_cast` when printing f32 and f64 immediates.
Feb 26 2021, 7:26 AM · Restricted Project

Feb 23 2021

sbc100 added a comment to D96659: [WebAssembly] Add new relocation for location relative data.

Mostly lgtm. Just a few nits at this point.

Feb 23 2021, 1:35 PM · Restricted Project

Feb 18 2021

sbc100 added inline comments to D92321: [lld][WebAssembly] Allow element sections for nonzero table numbers.
Feb 18 2021, 7:27 AM · Restricted Project

Feb 17 2021

sbc100 accepted D96770: [lld][WebAssembly] Fix resolveIndirectFunctionTable for relocatable output.

lgtm with a test for the new error(s).

Feb 17 2021, 11:09 AM · Restricted Project
sbc100 accepted D96872: [WebAssembly][lld] --importTable flag only imports table if needed.

Emscripten test suite passes. lgtm.

Feb 17 2021, 9:28 AM · Restricted Project
sbc100 added inline comments to D96872: [WebAssembly][lld] --importTable flag only imports table if needed.
Feb 17 2021, 8:50 AM · Restricted Project
sbc100 added a comment to D96872: [WebAssembly][lld] --importTable flag only imports table if needed.

I'm trying to think how this could effect either wasi-sdk or emscripten and I can't think of any ways.. but I will run the emscripten test suite with this change just in case.

Feb 17 2021, 8:31 AM · Restricted Project
sbc100 accepted D96872: [WebAssembly][lld] --importTable flag only imports table if needed.

Assuming all the tests pass this lgtm!

Feb 17 2021, 8:31 AM · Restricted Project
sbc100 added a comment to D96863: [WebAssembly] Change catch_all's opcode.

No thats fine. I was just making sure we wouldn't break an existing test..

Feb 17 2021, 7:57 AM · Restricted Project
sbc100 added inline comments to D96770: [lld][WebAssembly] Fix resolveIndirectFunctionTable for relocatable output.
Feb 17 2021, 7:37 AM · Restricted Project
sbc100 added inline comments to D96770: [lld][WebAssembly] Fix resolveIndirectFunctionTable for relocatable output.
Feb 17 2021, 7:33 AM · Restricted Project
sbc100 accepted D96863: [WebAssembly] Change catch_all's opcode.

Is there no test that includes this encoding?

Feb 17 2021, 7:24 AM · Restricted Project

Feb 16 2021

sbc100 added a comment to D96770: [lld][WebAssembly] Fix resolveIndirectFunctionTable for relocatable output.

Does this mean the --relocatable always produces output with an entry in the symbol table for __indirect_function_table? i.e. does the linker always produce non-MVP object files?

Feb 16 2021, 8:09 AM · Restricted Project
sbc100 added inline comments to D92321: [lld][WebAssembly] Allow element sections for nonzero table numbers.
Feb 16 2021, 7:54 AM · Restricted Project

Feb 14 2021

sbc100 added a comment to D96659: [WebAssembly] Add new relocation for location relative data.

Is the "pc-rel" in the title a little misleading? How about just "relative" or "location relative"?

Feb 14 2021, 12:28 PM · Restricted Project

Feb 12 2021

sbc100 added a reverting change for rGac2be2b6a366: [lld][WebAssembly] Fix for weak undefined functions in -pie mode: rGe1617d23ff06: Revert "[lld][WebAssembly] Fix for weak undefined functions in -pie mode".
Feb 12 2021, 9:04 AM
sbc100 committed rGe1617d23ff06: Revert "[lld][WebAssembly] Fix for weak undefined functions in -pie mode" (authored by sbc100).
Revert "[lld][WebAssembly] Fix for weak undefined functions in -pie mode"
Feb 12 2021, 9:04 AM
sbc100 added a reverting change for D95914: [lld][WebAssembly] Fix for weak undefined functions in -pie mode: rGe1617d23ff06: Revert "[lld][WebAssembly] Fix for weak undefined functions in -pie mode".
Feb 12 2021, 9:04 AM · Restricted Project
sbc100 added a comment to D95914: [lld][WebAssembly] Fix for weak undefined functions in -pie mode.

@sbc100 This revision is responsible for the sanitizer errors on the emscripten autorollers: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket.appspot.com/8855537012484712752/+/steps/Emscripten_testsuite__upstream__wasm3_/0/stdout

Would you be able to take a look?

Feb 12 2021, 8:53 AM · Restricted Project
sbc100 added inline comments to D96001: [WebAssembly][lld] Preassign table number 0 to indirect function table for MVP inputs.
Feb 12 2021, 8:10 AM · Restricted Project
sbc100 accepted D96001: [WebAssembly][lld] Preassign table number 0 to indirect function table for MVP inputs.

Nice! I like this much better now. Thanks for making all those changes.

Feb 12 2021, 7:50 AM · Restricted Project

Feb 11 2021

sbc100 committed rGac2be2b6a366: [lld][WebAssembly] Fix for weak undefined functions in -pie mode (authored by sbc100).
[lld][WebAssembly] Fix for weak undefined functions in -pie mode
Feb 11 2021, 5:16 PM
sbc100 closed D95914: [lld][WebAssembly] Fix for weak undefined functions in -pie mode.
Feb 11 2021, 5:16 PM · Restricted Project
sbc100 accepted D96473: [WebAssembly] Fix assert in lookup of section symbols.
Feb 11 2021, 4:40 PM · Restricted Project
sbc100 added inline comments to D96001: [WebAssembly][lld] Preassign table number 0 to indirect function table for MVP inputs.
Feb 11 2021, 2:03 PM · Restricted Project
sbc100 added a comment to D96001: [WebAssembly][lld] Preassign table number 0 to indirect function table for MVP inputs.

we when we comes to assigning indexes we do something like this:

Feb 11 2021, 1:58 PM · Restricted Project
sbc100 committed rG70f3c6e9e6b8: [lld][WebAssembly] Delay the merging of data section when dynamic linking (authored by sbc100).
[lld][WebAssembly] Delay the merging of data section when dynamic linking
Feb 11 2021, 10:54 AM
sbc100 closed D96453: [lld][WebAssembly] Delay the merging of section when dynamic linking.
Feb 11 2021, 10:54 AM · Restricted Project
sbc100 accepted D89274: [WebAssembly] Use the new crt1-command.o if present..

Ok so we can see this as an interim thing. I think I'm OK with that. Could you add a comment about that, or at least say why we want to support both the old crt1 and the new crt1-command at the same time (i.e. so that wasi-libc can easily suppot both old and new llvm right?)

Feb 11 2021, 10:52 AM · Restricted Project

Feb 10 2021

sbc100 added a comment to D89274: [WebAssembly] Use the new crt1-command.o if present..

It's to ensure that older LLVM works with newer WASI libc, and newer clang works with older WASI libc. New-style commands require [lld support]. We can assume that if clang is updated, lld has the requisite support.

That said, I'm open to other ideas here.

[lld support]: https://github.com/llvm/llvm-project/commit/6cd8511e5932e4a53b2bb7780f69489355fc7783

Feb 10 2021, 4:16 PM · Restricted Project
sbc100 added a comment to D89274: [WebAssembly] Use the new crt1-command.o if present..

Why not just use crt1.o in both cases? If you are going to prefer crt1-command.o in all cases then a toolchain would have no reason to ever ship crt1.o would it? (since it would always be ignored?)

Feb 10 2021, 2:45 PM · Restricted Project
sbc100 added a reviewer for D96453: [lld][WebAssembly] Delay the merging of section when dynamic linking: dschuff.
Feb 10 2021, 2:27 PM · Restricted Project
sbc100 updated the diff for D96453: [lld][WebAssembly] Delay the merging of section when dynamic linking.

rebase

Feb 10 2021, 2:27 PM · Restricted Project
sbc100 requested review of D96453: [lld][WebAssembly] Delay the merging of section when dynamic linking.
Feb 10 2021, 2:25 PM · Restricted Project

Feb 9 2021

sbc100 accepted D88369: [lld][WebAssembly] Fix segfault in map file support.
Feb 9 2021, 2:39 PM · Restricted Project
sbc100 committed rG34d033ca129f: [lld][WebAssembly] Allow --export of optional start/stop symbols (authored by sbc100).
[lld][WebAssembly] Allow --export of optional start/stop symbols
Feb 9 2021, 1:15 PM
sbc100 closed D96318: [lld][WebAssembly] Allow export for optional symbols.
Feb 9 2021, 1:15 PM · Restricted Project