rebased. PTAL

• rebase

• rebase

The convention I've been using is to prefex the commit subject with [WebAssembly]

• cleanup

• feedback

reserve -> resize

• comments

• rename InStruct

• clang-format
• feedback

rebase

• rebase

Does it make sense to support the flags before we support the feature?

• whitespace

• reduce diff

• rebase

• remove isNeeded

Split out part of this change into a smaller CL: https://reviews.llvm.org/D61971

@grosbach do you have time to take quick look? Should be fairly straight forward.

• rebase

In D61924#1502458, @ruiu wrote:

Even though what this code does is the same as what we do for the ELF linker, the code looks different. In ELF, we pass ComdatGroups (which is a set of comdat signature strings we've seen so far) around. I don't remember if there was a reason to do it differently for Wasm. Do you remmeber?

In D61929#1502456, @ruiu wrote:

Undefined symbols are indeed not currently displayed by --trace-symbol under the condition you mentioned, but that's also true for other types of symbols such as shared symbols.

A large refactoring is going on, and https://reviews.llvm.org/D61898, and once it's landed, I think we can fix the issue for all symbol types. Do you think you can wait until then?

• Fix special symbol crash

• comment

Let me know if this is too much to review. I could try to break it down, but it is mostly a pure refactor.

• refactor all the things

• move work from OutputSection constructors to finalizeContent

• remove comments

In D61772#1498187, @kripken wrote:

This may have broken CI, as it shows as one of the commits in the first broken roll here:

https://chromium-review.googlesource.com/c/emscripten-releases/+/1604139

other.test_binaryen_metadce_hello is broken there. Maybe we just need to update expectations? Looks like they rose though, which is odd?

Waterfall CI also shows wasm2.test_dylink_raii_exceptions is broken on Module.dynCall_ifdi is not a function which is maybe also related to this, but just a guess.

Remove newline

Update tests

cleanup

OK, I'll revert this for now while I investigate.

• revert

Are you able to generate and consume the __clangast now? It should show up as a custom section

• feedback

• remove restriction

• remove comment

Even in the case of wasm64 it might well be that somebody wants to build two different sysroots (as they would be arm and arm64 on linux). Even if we don't choose to ship a single arch sysroot for wasi somebody else might.

In D61452#1488330, @sunfish wrote:

If libraries don't correctly install into multi-arch directories, can we fix the libraries? We do this in the wasi-sdk repo to fix up the libc++ and libc++abi libraries, for example.

• update comment