- User Since
- Sep 16 2016, 10:22 AM (174 w, 19 h)
@ruiu I'm curious what you think about this problem, and this approach to solving it.
Shall we land this?
Oops, looks like this broke some tests. Investigating.
Thu, Jan 16
D72718 landed first so switched to StringRef for args. Also remove extra indentation in yaml.
- remove indentation
Wed, Jan 15
- remove old check
Tue, Jan 14
@ruiu, I tested the ELF linking I an believe it has the same problem. With ELF it looks like the effect is that bitcode symbols all end up with address 0 in the final binary. I think its better to fail at link time.. so we should probably port this change, or something like it to ELF.
Followup change to convert params to StringRef: https://reviews.llvm.org/D72718
- double comments
- use [[FILE]]
- use count
Mon, Jan 13
In emscripten we don't parse "no symbols" but we do run "llvm-nm -print-armap" and out users are seeing noise when they have objects with no symbols (not because they are stripped but simply because there are no public symbols).
I it seems that the printing of this error message only occurs with GNU nm if the object doesn't have a symbols table at all. Have no symbols in the table does not print the error message.
Sat, Jan 11
Fri, Jan 10
Thu, Jan 9
- add comment
Sun, Jan 5
Fri, Dec 20
Is this an in-flight collision with https://reviews.llvm.org/D70930?
Adding pcc who wrote the original code.
ping.. should be uncontroversial since this code its basically identical to ELF/COFF backends,.
wasm_argc_argv -> main_argc_argv in the title?
Thu, Dec 19
Dec 18 2019
I'm going abandon this change in favor of copying the code that already exists in COFF and ELF for handling this.
Dec 17 2019
I think this problem could also effect other backend.. working on test case to verify if this is true.
Dec 16 2019
I don't know the lldb codebase, but from a webassembly perspective this looks promising.
- remove attrs
- revert part
Dec 13 2019
In the description you say " .. unique among upstream targets", and later "... WebAssembly and similar downstream targets.". Was it deliberate to use both "upstream" and "downstream", what do these term mean here? Also the "unique" statement seems to contract the "and similar" statement.
Looks fine from a wasm perspective.
Dec 12 2019
(sorry.. I wrote those comments a while back and forgot to hit send)..
I have be working on CL that does basically a superset of this to support -gsplit-dwarf. But maybe can land this first.
Dec 11 2019
Dec 9 2019
Would mind calling the WebAssembly subdirectory just "wasm". I know we currently have a bit of a mix of WebAssembly, wasm and Wasm in the codebase. I'm hoping to reduce this to just WebAssembly (for the target arch) and wasm (for the container format).
Dec 6 2019
Ping .. I think this is good to go now.