Page MenuHomePhabricator

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (131 w, 1 d)

Recent Activity

Yesterday

sbc100 added reviewers for D59743: [WebAssembly] Don't use default GetLinkerPath: dschuff, phosek.
Sat, Mar 23, 6:30 PM · Restricted Project
sbc100 created D59743: [WebAssembly] Don't use default GetLinkerPath.
Sat, Mar 23, 6:29 PM · Restricted Project
sbc100 added a comment to D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory.

Fixed in rL356847.

Sat, Mar 23, 6:08 PM · Restricted Project, Restricted Project
sbc100 committed rG4b7bf6a02c97: [WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of… (authored by sbc100).
[WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of…
Sat, Mar 23, 5:03 PM

Fri, Mar 22

sbc100 accepted D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory.
Fri, Mar 22, 3:15 PM · Restricted Project, Restricted Project

Thu, Mar 21

sbc100 updated the summary of D54647: [WebAssembly] Initial implementation of PIC code generation.
Thu, Mar 21, 6:15 PM · Restricted Project
sbc100 updated the summary of D54647: [WebAssembly] Initial implementation of PIC code generation.
Thu, Mar 21, 6:15 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • add GOT.mem and GOT.func
Thu, Mar 21, 6:07 PM · Restricted Project
sbc100 accepted D59274: [WebAssembly] Add linker options to control feature checking.
Thu, Mar 21, 12:24 PM · Restricted Project

Wed, Mar 20

sbc100 accepted D59614: [AMDGPU] Add missing dependency on BinaryFormat.
Wed, Mar 20, 2:41 PM · Restricted Project
sbc100 added a reviewer for D59614: [AMDGPU] Add missing dependency on BinaryFormat: tpr.
Wed, Mar 20, 2:24 PM · Restricted Project
sbc100 created D59614: [AMDGPU] Add missing dependency on BinaryFormat.
Wed, Mar 20, 2:24 PM · Restricted Project
sbc100 added inline comments to D59281: [WebAssembly] "atomics" feature requires shared memory.
Wed, Mar 20, 2:14 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • cleanup
Wed, Mar 20, 12:36 PM · Restricted Project
sbc100 retitled D54647: [WebAssembly] Initial implementation of PIC code generation from [WebAssembly] Initial implementation of -fPIC codegeneration to [WebAssembly] Initial implementation of PIC code generation.
Wed, Mar 20, 12:28 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • revert fast isel changes
  • cleanup
Wed, Mar 20, 12:25 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • cleanup test
  • revert fast isel changes for now
Wed, Mar 20, 12:14 PM · Restricted Project

Mon, Mar 18

sbc100 added inline comments to D54647: [WebAssembly] Initial implementation of PIC code generation.
Mon, Mar 18, 3:07 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • add more tests
Mon, Mar 18, 3:01 PM · Restricted Project
sbc100 committed rGb7708ec87fcf: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. (authored by sbc100).
[WebAssembly] Don't override default implementation of isOffsetFoldingLegal.
Mon, Mar 18, 2:23 PM
sbc100 committed rG1d716acf76d1: Restore comment regarding why Reloc::PIC_ can't be PIC (authored by sbc100).
Restore comment regarding why Reloc::PIC_ can't be PIC
Mon, Mar 18, 1:04 PM
sbc100 accepted D59469: [WebAssembly] Rename methods according to instruction name changes (NFC).
Mon, Mar 18, 12:09 PM · Restricted Project

Fri, Mar 15

sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • remove_lld_todo
Fri, Mar 15, 7:51 PM · Restricted Project
sbc100 added a comment to D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..

@dschuff i updated the PR description and hopefully this a good to go now?

Fri, Mar 15, 7:17 PM · Restricted Project
sbc100 updated the summary of D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..
Fri, Mar 15, 7:16 PM · Restricted Project
sbc100 updated the summary of D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..
Fri, Mar 15, 7:16 PM · Restricted Project
sbc100 updated the summary of D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..
Fri, Mar 15, 7:16 PM · Restricted Project
sbc100 added a reviewer for D59445: Restore comment regarding why Reloc::PIC_ can't be PIC: dschuff.
Fri, Mar 15, 7:11 PM · Restricted Project
sbc100 created D59445: Restore comment regarding why Reloc::PIC_ can't be PIC.
Fri, Mar 15, 7:10 PM · Restricted Project
sbc100 added a comment to D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..

This is needed for my PIC change: https://reviews.llvm.org/D54647

Fri, Mar 15, 6:56 PM · Restricted Project
sbc100 updated the diff for D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..

-rebase

Fri, Mar 15, 6:45 PM · Restricted Project
sbc100 added inline comments to D54647: [WebAssembly] Initial implementation of PIC code generation.
Fri, Mar 15, 6:29 PM · Restricted Project
sbc100 committed rG632c217921c0: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data… (authored by sbc100).
[WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data…
Fri, Mar 15, 6:18 PM
sbc100 added inline comments to D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols..
Fri, Mar 15, 6:18 PM · Restricted Project
sbc100 updated the diff for D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols..
  • split out lambda
Fri, Mar 15, 6:16 PM · Restricted Project
sbc100 added inline comments to D54647: [WebAssembly] Initial implementation of PIC code generation.
Fri, Mar 15, 4:29 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • clang-format
  • remove 64
Fri, Mar 15, 4:29 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • feedback
  • cleanup
Fri, Mar 15, 4:22 PM · Restricted Project
sbc100 added a reviewer for D54647: [WebAssembly] Initial implementation of PIC code generation: tlively.
Fri, Mar 15, 3:40 PM · Restricted Project
sbc100 retitled D54647: [WebAssembly] Initial implementation of PIC code generation from WIP: [WebAssembly] First pass the implement -fPIC to [WebAssembly] Initial implementation of -fPIC codegeneration.
Fri, Mar 15, 3:40 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • cleaup test code
  • add MC test
Fri, Mar 15, 3:34 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • improve test
Fri, Mar 15, 2:38 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • selection dag working
Fri, Mar 15, 2:09 PM · Restricted Project
sbc100 added inline comments to D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols..
Fri, Mar 15, 10:49 AM · Restricted Project

Thu, Mar 14

sbc100 created D59399: [SelectionDAG] Remove some unused defs.
Thu, Mar 14, 5:27 PM · Restricted Project
sbc100 added a reviewer for D59399: [SelectionDAG] Remove some unused defs: dschuff.
Thu, Mar 14, 5:27 PM · Restricted Project
sbc100 committed rG3d70a2b7d162: [WebAssembly] Remove unused load/store patterns that use texternalsym (authored by sbc100).
[WebAssembly] Remove unused load/store patterns that use texternalsym
Thu, Mar 14, 5:20 PM
sbc100 updated the diff for D59395: [WebAssembly] Remove unused LoadPatExternalSym patterns.
  • and more!
Thu, Mar 14, 5:06 PM · Restricted Project
sbc100 updated the diff for D59395: [WebAssembly] Remove unused LoadPatExternalSym patterns.
  • remove even more
Thu, Mar 14, 5:04 PM · Restricted Project
sbc100 added a reviewer for D59395: [WebAssembly] Remove unused LoadPatExternalSym patterns: dschuff.
Thu, Mar 14, 4:20 PM · Restricted Project
sbc100 created D59395: [WebAssembly] Remove unused LoadPatExternalSym patterns.
Thu, Mar 14, 4:18 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • isel start
Thu, Mar 14, 2:41 PM · Restricted Project
sbc100 committed rG595a97a20028: Line wrap README file (authored by sbc100).
Line wrap README file
Thu, Mar 14, 2:08 PM
sbc100 added inline comments to D59343: [WebAssembly] Use passive segments when memory is shared.
Thu, Mar 14, 2:01 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.

revert parts

Thu, Mar 14, 12:46 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.

update

Thu, Mar 14, 12:36 PM · Restricted Project
sbc100 updated the diff for D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols..
  • fix error
Thu, Mar 14, 9:23 AM · Restricted Project
sbc100 added a comment to D59343: [WebAssembly] Use passive segments when memory is shared.

Mostly lgtm

Thu, Mar 14, 9:07 AM · Restricted Project
sbc100 added a comment to D59281: [WebAssembly] "atomics" feature requires shared memory.

In the future, atomics will likely be enabled by default, however it will continue to be desirable to be able to select non-shared memory, since non-shared memory doesn't require a maximum size, and since it can make interoperating with JS and other external code simpler. Is it possible to structure this patch in a way that supports this?

Thu, Mar 14, 8:59 AM · Restricted Project
sbc100 added inline comments to D59278: [WebAssembly] Apply data relocations at runtime in shared objects.
Thu, Mar 14, 8:56 AM · Restricted Project

Wed, Mar 13

sbc100 accepted D59173: [WebAssembly] Target features section.
Wed, Mar 13, 6:46 PM · Restricted Project
sbc100 added reviewers for D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols.: ruiu, jgravelle-google.
Wed, Mar 13, 3:41 PM · Restricted Project
sbc100 updated the diff for D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols..

Add test

Wed, Mar 13, 3:38 PM · Restricted Project
sbc100 created D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols..
Wed, Mar 13, 3:33 PM · Restricted Project
sbc100 committed rGa688a42cdda4: [WebAssembly] Improve support for "needed" list in dylink section (authored by sbc100).
[WebAssembly] Improve support for "needed" list in dylink section
Wed, Mar 13, 2:29 PM
sbc100 added inline comments to D59237: [WebAssembly] Improve support for "needed" list in dylink section.
Wed, Mar 13, 11:17 AM · Restricted Project

Tue, Mar 12

sbc100 added a reviewer for D59278: [WebAssembly] Apply data relocations at runtime in shared objects: ruiu.
Tue, Mar 12, 4:46 PM · Restricted Project
sbc100 retitled D59278: [WebAssembly] Apply data relocations at runtime in shared objects from [WebAssembly] Create runtime relocations in shared objects to [WebAssembly] Apply data relocations at runtime in shared objects.
Tue, Mar 12, 4:46 PM · Restricted Project
sbc100 updated the diff for D59278: [WebAssembly] Apply data relocations at runtime in shared objects.
  • clang-format
  • comments
  • cleanup
Tue, Mar 12, 4:43 PM · Restricted Project
sbc100 updated the diff for D59278: [WebAssembly] Apply data relocations at runtime in shared objects.
  • comments
Tue, Mar 12, 4:43 PM · Restricted Project
sbc100 created D59278: [WebAssembly] Apply data relocations at runtime in shared objects.
Tue, Mar 12, 4:07 PM · Restricted Project
sbc100 added a reviewer for D59237: [WebAssembly] Improve support for "needed" list in dylink section: ruiu.
Tue, Mar 12, 4:06 PM · Restricted Project
sbc100 committed rGd425d6b08b9b: [WebAssembly] Handle undefined data symbols in shared libraries (authored by sbc100).
[WebAssembly] Handle undefined data symbols in shared libraries
Tue, Mar 12, 2:55 PM
sbc100 added a reviewer for D59270: [WebAssembly] Handle undefined data symbols in shared libraries: ruiu.
Tue, Mar 12, 12:40 PM · Restricted Project
sbc100 created D59270: [WebAssembly] Handle undefined data symbols in shared libraries.
Tue, Mar 12, 12:36 PM · Restricted Project

Mon, Mar 11

sbc100 added a comment to D59237: [WebAssembly] Improve support for "needed" list in dylink section.

This change is now ready for review. Please note that this is only the most simple support for .so file. All it does is add each library to the "needed" section, it doesn't do any symbol resolution against the shared libraries yet.

Mon, Mar 11, 11:46 PM · Restricted Project
sbc100 updated the diff for D59237: [WebAssembly] Improve support for "needed" list in dylink section.
  • clang-format
Mon, Mar 11, 11:40 PM · Restricted Project
sbc100 updated the diff for D59237: [WebAssembly] Improve support for "needed" list in dylink section.
  • remove assert
Mon, Mar 11, 11:39 PM · Restricted Project
sbc100 updated the diff for D59237: [WebAssembly] Improve support for "needed" list in dylink section.
  • add test
Mon, Mar 11, 11:37 PM · Restricted Project
sbc100 updated the summary of D59237: [WebAssembly] Improve support for "needed" list in dylink section.
Mon, Mar 11, 5:07 PM · Restricted Project
sbc100 updated the diff for D59237: [WebAssembly] Improve support for "needed" list in dylink section.
  • move to mono-repo
Mon, Mar 11, 5:07 PM · Restricted Project
sbc100 created D59237: [WebAssembly] Improve support for "needed" list in dylink section.
Mon, Mar 11, 5:05 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.
  • move to monorepo
Mon, Mar 11, 4:05 PM · Restricted Project
sbc100 updated the diff for D54647: [WebAssembly] Initial implementation of PIC code generation.

rebase

Mon, Mar 11, 4:02 PM · Restricted Project
sbc100 updated the diff for D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..
  • move to mono-repo
Mon, Mar 11, 4:01 PM · Restricted Project
sbc100 updated the diff for D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC..
  • rebase
Mon, Mar 11, 3:59 PM · Restricted Project
sbc100 added inline comments to D59173: [WebAssembly] Target features section.
Mon, Mar 11, 2:54 PM · Restricted Project
sbc100 added inline comments to D59173: [WebAssembly] Target features section.
Mon, Mar 11, 2:15 PM · Restricted Project

Fri, Mar 8

sbc100 committed rGd15a4154a8b7: [WebAssembly] Don't mark lazy symbols as `IsUsedInRegularObj` (authored by sbc100).
[WebAssembly] Don't mark lazy symbols as `IsUsedInRegularObj`
Fri, Mar 8, 1:11 PM
sbc100 added a comment to D59075: [WebAssembly] Don't mark lazy symbols as `IsUsedInRegularObj`.

ping..

Fri, Mar 8, 11:22 AM · Restricted Project

Thu, Mar 7

sbc100 added a comment to D58956: [WebAssembly] Remove tabs in tests (NFC).

It would be awesome if we could somehow force tabs to be errors, frankly. Or is there some other automatic way to detect them? Or show them in code review?

I know this changes is abandoned, but I am in favor of it.

Thu, Mar 7, 11:23 AM · Restricted Project

Wed, Mar 6

sbc100 updated the diff for D59075: [WebAssembly] Don't mark lazy symbols as `IsUsedInRegularObj`.
  • revert
Wed, Mar 6, 9:03 PM · Restricted Project
sbc100 added reviewers for D59075: [WebAssembly] Don't mark lazy symbols as `IsUsedInRegularObj`: pcc, ruiu.
Wed, Mar 6, 9:02 PM · Restricted Project
sbc100 created D59075: [WebAssembly] Don't mark lazy symbols as `IsUsedInRegularObj`.
Wed, Mar 6, 9:02 PM · Restricted Project
sbc100 added a comment to D59074: [WebAssembly] Fix build after rL355577.
In D59074#1421058, @pcc wrote:

Turns own that IsUsedInRegularObject is set for lazy (archive) symbols.

Should we fix that, then?

It correct according to the comment in ELF/Symbols.h:

// True if the symbol was used for linking and thus need to be added to the    
// output file's symbol table. This is true for all symbols except for         
// unreferenced DSO symbols and bitcode symbols that are unreferenced except   
// by other bitcode objects.                                                   
unsigned IsUsedInRegularObj : 1;

I guess objects in archives are still regular objects.

Wed, Mar 6, 9:02 PM · Restricted Project
sbc100 added a comment to D59074: [WebAssembly] Fix build after rL355577.
In D59074#1421058, @pcc wrote:

Turns own that IsUsedInRegularObject is set for lazy (archive) symbols.

Should we fix that, then?

Wed, Mar 6, 8:43 PM · Restricted Project
sbc100 committed rG9361217ea2d6: [WebAssembly] Fix build after rL355577 (authored by sbc100).
[WebAssembly] Fix build after rL355577
Wed, Mar 6, 8:20 PM
sbc100 added a reviewer for D59074: [WebAssembly] Fix build after rL355577: pcc.
Wed, Mar 6, 8:18 PM · Restricted Project
sbc100 created D59074: [WebAssembly] Fix build after rL355577.
Wed, Mar 6, 8:17 PM · Restricted Project
sbc100 committed rG815a05ca6ba8: [WebAssembly] LTO: Don't include bitcode-only symbols in the symtab (authored by sbc100).
[WebAssembly] LTO: Don't include bitcode-only symbols in the symtab
Wed, Mar 6, 6:43 PM