sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (56 w, 5 d)

Recent Activity

Today

sbc100 abandoned D38297: [WebAssembly] Support for new per-segment linking metadata.
Wed, Oct 18, 12:38 PM
sbc100 added inline comments to D38777: [wasm] readSection: Avoid reading past eof (fixes oss-fuzz #3219).
Wed, Oct 18, 12:36 PM
sbc100 added a comment to D39022: Don't set static-libs test feature when using LLVM_LINK_LLVM_DYLIB.

ping

Wed, Oct 18, 10:29 AM

Yesterday

sbc100 retitled D39022: Don't set static-libs test feature when using LLVM_LINK_LLVM_DYLIB from Don't set static-libs test feature when using LLVM_LINK_LLVM_DYLIB This was causing execname-options.ll to fail on the wasm waterfall. to Don't set static-libs test feature when using LLVM_LINK_LLVM_DYLIB.
Tue, Oct 17, 4:11 PM
sbc100 created D39022: Don't set static-libs test feature when using LLVM_LINK_LLVM_DYLIB.
Tue, Oct 17, 4:11 PM

Tue, Oct 3

sbc100 updated the summary of D37757: [WebAssembly] MC: Support for static init and fini sections.
Tue, Oct 3, 3:42 AM

Wed, Sep 27

sbc100 added a comment to D38296: [WebAssembly] Allow each data segment to specify its own alignment.

@dschuff ptal

Wed, Sep 27, 12:36 PM

Tue, Sep 26

sbc100 added a comment to D38296: [WebAssembly] Allow each data segment to specify its own alignment.

corresponding lld change is here: https://reviews.llvm.org/D38297

Tue, Sep 26, 3:30 PM
sbc100 created D38297: [WebAssembly] Support for new per-segment linking metadata.
Tue, Sep 26, 3:30 PM
sbc100 added a reviewer for D38296: [WebAssembly] Allow each data segment to specify its own alignment: dschuff.
Tue, Sep 26, 3:30 PM
sbc100 created D38296: [WebAssembly] Allow each data segment to specify its own alignment.
Tue, Sep 26, 3:30 PM
sbc100 added inline comments to D38246: [WebAssembly] Model weak aliases as wasm exports.
Tue, Sep 26, 3:30 PM
sbc100 updated the summary of D38189: [WebAssembly] Use function/global index space in WasmSymbol.
Tue, Sep 26, 3:30 PM

Mon, Sep 25

sbc100 retitled D38246: [WebAssembly] Model weak aliases as wasm exports from [WebAssembly] Model weakly defined symbols as wasm exports to [WebAssembly] Model weak aliases as wasm exports.
Mon, Sep 25, 2:59 PM
sbc100 added a comment to D38189: [WebAssembly] Use function/global index space in WasmSymbol.

@dschuff PTAL

Mon, Sep 25, 2:49 PM
sbc100 added a reviewer for D38246: [WebAssembly] Model weak aliases as wasm exports: dschuff.
Mon, Sep 25, 12:25 PM
sbc100 created D38246: [WebAssembly] Model weak aliases as wasm exports.
Mon, Sep 25, 12:22 PM
sbc100 added a reviewer for D38189: [WebAssembly] Use function/global index space in WasmSymbol: dschuff.
Mon, Sep 25, 5:02 AM
sbc100 created D38189: [WebAssembly] Use function/global index space in WasmSymbol.
Mon, Sep 25, 5:02 AM

Thu, Sep 21

sbc100 added inline comments to D34851: [WebAssembly] Initial wasm linker implementation.
Thu, Sep 21, 3:21 PM
sbc100 updated the diff for D34851: [WebAssembly] Initial wasm linker implementation.
  • [WebAssembly] Update test output to match llvm changes
  • [WebAssembly] only run wasm tests when wasm is enabled
  • [WebAssembly] Review feedback
Thu, Sep 21, 3:20 PM
sbc100 added a comment to D34851: [WebAssembly] Initial wasm linker implementation.

Thank you for all the feedback @ruiu. It not surprise to me that a patch of this size takes a long time to review. I'm currently working on a fairly large change to allow data sections with the same name to be combined into a single section.. in order to allow things like init_array/fini_array. My aim is to get that done before the initial version of this patch lands.

Thu, Sep 21, 1:59 PM

Wed, Sep 20

sbc100 added a reviewer for D38111: [WebAssembly] Weak symbols should be defined in SF_Global: dschuff.
Wed, Sep 20, 4:40 PM
sbc100 created D38111: [WebAssembly] Weak symbols should be defined in SF_Global.
Wed, Sep 20, 4:39 PM
sbc100 added a reviewer for D38096: [WebAssembly] Add support for local symbol bindings: dschuff.
Wed, Sep 20, 1:14 PM
sbc100 updated the diff for D38096: [WebAssembly] Add support for local symbol bindings.

Remove unrelated change

Wed, Sep 20, 1:13 PM
sbc100 created D38096: [WebAssembly] Add support for local symbol bindings.
Wed, Sep 20, 1:10 PM
sbc100 added inline comments to D38089: Introduce the llvm-cfi-verify tool (resubmission of D37937)..
Wed, Sep 20, 12:35 PM

Tue, Sep 19

sbc100 updated the diff for D34851: [WebAssembly] Initial wasm linker implementation.
  • [WebAssembly] Fix index for R_WEBASSEMBLY_MEMORY_ADDR_* relocations
  • Merge remote-tracking branch 'origin/master' into wasm
  • [WebAssembly] Don't re-export entry point as 'main'
  • [WebAssembly] Allow mulitple wasm data segments
  • [WebAssembly] Update tests to match changes in llvm
  • [WebAssembly] Update LEB to match changes to LEB128.h
  • [WebAssembly] don't test data-layout with -r
  • [WebAssembly] Refactor code to create OutputSections.cpp
Tue, Sep 19, 12:42 PM

Sep 18 2017

sbc100 updated the diff for D37886: [WebAssembly] Add support for naming wasm data segments.
  • add bss test case
Sep 18 2017, 11:37 AM

Sep 15 2017

sbc100 added a reviewer for D37757: [WebAssembly] MC: Support for static init and fini sections: dschuff.
Sep 15 2017, 4:13 PM
sbc100 updated the diff for D37757: [WebAssembly] MC: Support for static init and fini sections.
  • add test
Sep 15 2017, 4:12 PM
sbc100 added a comment to D37886: [WebAssembly] Add support for naming wasm data segments.

Yes, there is the potential that we might need more metadata down the road (type, flags, etc) but right now I think name is enough for to get init_array and fini_array working.

Sep 15 2017, 4:05 PM
sbc100 updated the diff for D37886: [WebAssembly] Add support for naming wasm data segments.
  • cleanup tests
Sep 15 2017, 2:13 PM
sbc100 updated the diff for D37886: [WebAssembly] Add support for naming wasm data segments.
  • don't use const ArrayRef
  • fix test
Sep 15 2017, 2:10 PM
sbc100 added a reviewer for D37886: [WebAssembly] Add support for naming wasm data segments: dschuff.
Sep 15 2017, 2:04 PM
sbc100 updated the diff for D37876: [WebAssembly] MC: Create wasm data segments based on MCSections.
  • rename test
Sep 15 2017, 12:46 PM
sbc100 added a comment to D37876: [WebAssembly] MC: Create wasm data segments based on MCSections.

Added support for explicit custom section names, and added new test

Sep 15 2017, 12:45 PM
sbc100 updated the diff for D37876: [WebAssembly] MC: Create wasm data segments based on MCSections.
  • support custom data sections
Sep 15 2017, 12:44 PM
sbc100 retitled D37876: [WebAssembly] MC: Create wasm data segments based on MCSections from [WebAssembly] MC: Create data sections based on MCSections to [WebAssembly] MC: Create wasm data segments based on MCSections.
Sep 15 2017, 12:11 PM
sbc100 added a reviewer for D37916: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references: jgravelle-google.
Sep 15 2017, 12:10 PM
sbc100 updated the diff for D37916: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references.

fix test

Sep 15 2017, 12:09 PM
sbc100 created D37916: [WebAssembly] MC: Fix crash in getProvitionalValue on weak references.
Sep 15 2017, 12:08 PM

Sep 14 2017

sbc100 updated the diff for D37886: [WebAssembly] Add support for naming wasm data segments.

fix test

Sep 14 2017, 7:29 PM
sbc100 added a dependency for D37886: [WebAssembly] Add support for naming wasm data segments: D37876: [WebAssembly] MC: Create wasm data segments based on MCSections.
Sep 14 2017, 7:25 PM
sbc100 added a dependent revision for D37876: [WebAssembly] MC: Create wasm data segments based on MCSections: D37886: [WebAssembly] Add support for naming wasm data segments.
Sep 14 2017, 7:25 PM
sbc100 updated the diff for D37886: [WebAssembly] Add support for naming wasm data segments.
  • fix
Sep 14 2017, 7:25 PM
sbc100 created D37886: [WebAssembly] Add support for naming wasm data segments.
Sep 14 2017, 7:23 PM
sbc100 updated the diff for D37876: [WebAssembly] MC: Create wasm data segments based on MCSections.

More section types

Sep 14 2017, 7:22 PM
sbc100 added a reviewer for D37876: [WebAssembly] MC: Create wasm data segments based on MCSections: dschuff.
Sep 14 2017, 5:00 PM
sbc100 abandoned D37869: [WebAssembly] Remove default -fdata-sections.
Sep 14 2017, 5:00 PM
sbc100 added a comment to D37869: [WebAssembly] Remove default -fdata-sections.

I created a more minimal version of this change https://reviews.llvm.org/D37876. Abandoning this one.

Sep 14 2017, 5:00 PM
sbc100 updated the summary of D37876: [WebAssembly] MC: Create wasm data segments based on MCSections.
Sep 14 2017, 4:58 PM
sbc100 added a comment to D37834: [WebAssembly] Use a separate wasm data segment for each global symbol.
Sep 14 2017, 4:57 PM
sbc100 created D37876: [WebAssembly] MC: Create wasm data segments based on MCSections.
Sep 14 2017, 4:56 PM
sbc100 retitled D37875: [WebAssembly] MC: Pass ArrayRefs rather than SmallVectors from [WebAssembly] Pass ArrayRef rather than SmallVector to [WebAssembly] MC: Pass ArrayRefs rather than SmallVectors.
Sep 14 2017, 4:48 PM
sbc100 created D37875: [WebAssembly] MC: Pass ArrayRefs rather than SmallVectors.
Sep 14 2017, 4:47 PM
sbc100 added a comment to D37869: [WebAssembly] Remove default -fdata-sections.

I guess I was just trying to match the other native toolchains. One can still pass -fdata-sections, but why make it the default?

Sep 14 2017, 4:18 PM
sbc100 retitled D37834: [WebAssembly] Use a separate wasm data segment for each global symbol from [WebAssembly] Use a seperate wasm data segment for each global symbol to [WebAssembly] Use a separate wasm data segment for each global symbol.
Sep 14 2017, 4:03 PM
sbc100 updated the diff for D37869: [WebAssembly] Remove default -fdata-sections.

Rebase

Sep 14 2017, 4:00 PM
sbc100 added a reviewer for D37873: [WebAssembly] Fix wasm-toolchain.c tests: dschuff.
Sep 14 2017, 3:37 PM
sbc100 created D37873: [WebAssembly] Fix wasm-toolchain.c tests.
Sep 14 2017, 3:37 PM
sbc100 added inline comments to D37834: [WebAssembly] Use a separate wasm data segment for each global symbol.
Sep 14 2017, 3:27 PM
sbc100 added a comment to D37869: [WebAssembly] Remove default -fdata-sections.

Yes, this change is a WIP that depends on D37834.

Sep 14 2017, 3:27 PM
sbc100 updated the diff for D37834: [WebAssembly] Use a separate wasm data segment for each global symbol.
  • review feedback
  • Merge remote-tracking branch 'origin/master' into data_sections
Sep 14 2017, 2:52 PM
sbc100 added a comment to D37831: [WebAssembly] Don't pass -ffunction-section/-fdata-sections by default.

Yes, I was refering to the waterfall tests.

Sep 14 2017, 2:34 PM
sbc100 added a reviewer for D37869: [WebAssembly] Remove default -fdata-sections: dschuff.
Sep 14 2017, 2:28 PM
sbc100 created D37869: [WebAssembly] Remove default -fdata-sections.
Sep 14 2017, 2:27 PM

Sep 13 2017

sbc100 added a comment to D37831: [WebAssembly] Don't pass -ffunction-section/-fdata-sections by default.

Making the change here first means that I can test the new default and land it in llvm. If clang is continues to set its own default then anyone using clang (i.e. a lot of the tests) won't see the effect of the change.

Sep 13 2017, 4:42 PM
sbc100 updated the diff for D37834: [WebAssembly] Use a separate wasm data segment for each global symbol.
  • restore debugging
Sep 13 2017, 4:34 PM
sbc100 updated the summary of D37834: [WebAssembly] Use a separate wasm data segment for each global symbol.
Sep 13 2017, 4:32 PM
sbc100 updated the diff for D37834: [WebAssembly] Use a separate wasm data segment for each global symbol.

remove debugging

Sep 13 2017, 4:31 PM
sbc100 created D37834: [WebAssembly] Use a separate wasm data segment for each global symbol.
Sep 13 2017, 4:30 PM
sbc100 added a reviewer for D37831: [WebAssembly] Don't pass -ffunction-section/-fdata-sections by default: dschuff.
Sep 13 2017, 3:47 PM
sbc100 updated the diff for D37831: [WebAssembly] Don't pass -ffunction-section/-fdata-sections by default.
  • .
Sep 13 2017, 3:46 PM
sbc100 created D37831: [WebAssembly] Don't pass -ffunction-section/-fdata-sections by default.
Sep 13 2017, 3:43 PM

Sep 12 2017

sbc100 updated the summary of D37757: [WebAssembly] MC: Support for static init and fini sections.
Sep 12 2017, 12:30 PM
sbc100 created D37757: [WebAssembly] MC: Support for static init and fini sections.
Sep 12 2017, 12:29 PM

Sep 8 2017

sbc100 updated the diff for D37633: [WebAssembly] Remove flags from MCSectionWasm.

remove debugging

Sep 8 2017, 11:34 AM
sbc100 added reviewers for D37633: [WebAssembly] Remove flags from MCSectionWasm: dschuff, sunfish.
Sep 8 2017, 11:33 AM
sbc100 created D37633: [WebAssembly] Remove flags from MCSectionWasm.
Sep 8 2017, 11:33 AM

Sep 7 2017

sbc100 added inline comments to D34851: [WebAssembly] Initial wasm linker implementation.
Sep 7 2017, 4:58 PM
sbc100 updated the diff for D34851: [WebAssembly] Initial wasm linker implementation.
  • Merge branch 'master' into wasm
  • [WebAssembly] Update expectations now that SymbolInfo not a required YAML field.
  • [WebAssembly] Don't try to export main if its undefined
  • [WebAssembly] Review feedback
Sep 7 2017, 4:57 PM

Sep 6 2017

sbc100 added a comment to D37494: Change encodeU/SLEB128 to pad to certain number of bytes.

@sunfish could you take a look?

Sep 6 2017, 3:16 PM
sbc100 updated the diff for D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
  • feedback
Sep 6 2017, 3:05 PM
sbc100 added a comment to D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.

Could you take another look derek? This is currently causing test failures for big endian architectures. If this change is too big I can lang a more targeted one line change in the interim.

Sep 6 2017, 12:43 PM
sbc100 added a comment to D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.

OK makes sense. We now only create symbols from imports/exports when the 'linking' section is present.

Sep 6 2017, 12:19 PM
sbc100 updated the diff for D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
  • .
Sep 6 2017, 12:19 PM
sbc100 retitled D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files from [WebAssembly] Fix getSymbolValue() for globals that are not 32-bit const values. to [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
Sep 6 2017, 12:16 PM
sbc100 updated the diff for D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
  • Don't treat imports/exports as symbols table unless linking
Sep 6 2017, 12:11 PM

Sep 5 2017

sbc100 added inline comments to D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
Sep 5 2017, 6:12 PM
sbc100 added inline comments to D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
Sep 5 2017, 5:46 PM
sbc100 retitled D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files from [WebAssembly] Ensure that Wasm global that represent memory addresses are 32-bit const values to [WebAssembly] Fix getSymbolValue() for globals that are not 32-bit const values..
Sep 5 2017, 5:45 PM
sbc100 updated the diff for D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
  • handle 64bit global exports
Sep 5 2017, 5:44 PM
sbc100 added a reviewer for D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files: dschuff.
Sep 5 2017, 4:55 PM
sbc100 created D37497: [WebAssembly] Only treat imports/exports as symbols when reading relocatable object files.
Sep 5 2017, 4:54 PM
sbc100 added a comment to D37494: Change encodeU/SLEB128 to pad to certain number of bytes.

My understanding is that with LEB one can pad to any number of bytes. We use 5 when we write 32-bit values in wasm because 5 is the number of bytes required to encode any 32-bit number as an LEB. We likewise use 10 bytes when writing padded 64-values. One might conceivably use 2 and 3 when writing 8-bit and 16-bit values as well.

Sep 5 2017, 4:36 PM
sbc100 added reviewers for D37494: Change encodeU/SLEB128 to pad to certain number of bytes: sunfish, ruiu.
Sep 5 2017, 4:04 PM
sbc100 created D37494: Change encodeU/SLEB128 to pad to certain number of bytes.
Sep 5 2017, 4:01 PM

Sep 1 2017

sbc100 added inline comments to D34851: [WebAssembly] Initial wasm linker implementation.
Sep 1 2017, 2:51 PM