sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (87 w, 6 d)

Recent Activity

Tue, May 22

sbc100 updated the summary of D47238: [WebAssembly] Fix crash when relocation synbol is not live.
Tue, May 22, 5:55 PM
sbc100 added a reviewer for D47238: [WebAssembly] Fix crash when relocation synbol is not live: yurydelendik.
Tue, May 22, 5:54 PM
sbc100 created D47238: [WebAssembly] Fix crash when relocation synbol is not live.
Tue, May 22, 5:53 PM
sbc100 added a comment to D47204: [WebAssembly] Properly calculate function body offset, and write I32 values..

In term of the uninitialized memory issue, let me see if I can restate so that we can come to the same understanding.

Tue, May 22, 1:55 PM
sbc100 added reviewers for D47226: [WebAssembly] Remove dead code from LEB compression pass. NFC.: ruiu, yurydelendik.
Tue, May 22, 1:48 PM
sbc100 retitled D47226: [WebAssembly] Remove dead code from LEB compression pass. NFC. from [WebAssembly] Remove dead code from LEB compression pass. to [WebAssembly] Remove dead code from LEB compression pass. NFC..
Tue, May 22, 1:48 PM
sbc100 added a comment to D47204: [WebAssembly] Properly calculate function body offset, and write I32 values..

Dead code removal: https://reviews.llvm.org/D47226

Tue, May 22, 1:48 PM
sbc100 created D47226: [WebAssembly] Remove dead code from LEB compression pass. NFC..
Tue, May 22, 1:47 PM
sbc100 added inline comments to D47162: [WebAssembly] Initial support for LTO.
Tue, May 22, 1:23 PM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • use flags
Tue, May 22, 1:22 PM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • handle bitcode symbol flags
Tue, May 22, 1:22 PM
sbc100 added inline comments to D47206: Code cleanup in preparation for adding LTO for wasm. NFC..
Tue, May 22, 1:15 PM
sbc100 updated the diff for D47206: Code cleanup in preparation for adding LTO for wasm. NFC..
  • feedback
Tue, May 22, 1:14 PM
sbc100 added a comment to D47204: [WebAssembly] Properly calculate function body offset, and write I32 values..

Was the test in that change was failing on your machine? If it passed (if it happened to work), you still need to change the test, so that it fails without this patch and passes with this patch.

Tue, May 22, 11:54 AM
sbc100 accepted D47204: [WebAssembly] Properly calculate function body offset, and write I32 values..

Does these fix the issues you had with you large binary?

Tue, May 22, 10:07 AM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • addUndefined
Tue, May 22, 10:06 AM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • revert ProgName
Tue, May 22, 10:06 AM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • revert
Tue, May 22, 10:03 AM
sbc100 added inline comments to D47162: [WebAssembly] Initial support for LTO.
Tue, May 22, 10:01 AM
sbc100 updated the summary of D47162: [WebAssembly] Initial support for LTO.
Tue, May 22, 10:01 AM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • feedback and rebase onto separate change
Tue, May 22, 10:01 AM
sbc100 updated the diff for D47206: Code cleanup in preparation for adding LTO for wasm. NFC..
  • Buff -> Buf
Tue, May 22, 9:57 AM
sbc100 updated the diff for D47206: Code cleanup in preparation for adding LTO for wasm. NFC..
  • config names
Tue, May 22, 9:54 AM
sbc100 added a dependent revision for D47206: Code cleanup in preparation for adding LTO for wasm. NFC.: D47162: [WebAssembly] Initial support for LTO.
Tue, May 22, 9:54 AM
sbc100 added a dependency for D47162: [WebAssembly] Initial support for LTO: D47206: Code cleanup in preparation for adding LTO for wasm. NFC..
Tue, May 22, 9:54 AM
sbc100 updated the summary of D47206: Code cleanup in preparation for adding LTO for wasm. NFC..
Tue, May 22, 9:54 AM
sbc100 retitled D47206: Code cleanup in preparation for adding LTO for wasm. NFC. from Code cleanup in preparation for adding LTO for wasm to Code cleanup in preparation for adding LTO for wasm. NFC..
Tue, May 22, 9:47 AM
sbc100 created D47206: Code cleanup in preparation for adding LTO for wasm. NFC..
Tue, May 22, 9:46 AM

Mon, May 21

sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • feedback
Mon, May 21, 5:28 PM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • feedback
Mon, May 21, 5:14 PM
sbc100 added inline comments to D47162: [WebAssembly] Initial support for LTO.
Mon, May 21, 5:14 PM
sbc100 added a reviewer for D47086: [WebAssembly] Add more error checking to object file parsing: dschuff.
Mon, May 21, 3:46 PM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • feedback
Mon, May 21, 3:46 PM
sbc100 edited reviewers for D47162: [WebAssembly] Initial support for LTO, added: ruiu; removed: espindola.
Mon, May 21, 2:18 PM
sbc100 updated the diff for D47162: [WebAssembly] Initial support for LTO.
  • cleanup
Mon, May 21, 2:17 PM
sbc100 created D47162: [WebAssembly] Initial support for LTO.
Mon, May 21, 2:12 PM

Fri, May 18

sbc100 updated the diff for D46416: [WebAssembly] Optionally compress relocation sites in the code section.
  • feedback
Fri, May 18, 4:17 PM
sbc100 added a comment to D46416: [WebAssembly] Optionally compress relocation sites in the code section.

Planning on landing this today unless there are any more comments.

Fri, May 18, 3:06 PM
sbc100 updated the diff for D47086: [WebAssembly] Add more error checking to object file parsing.
  • rename test
Fri, May 18, 2:51 PM
sbc100 updated the diff for D47086: [WebAssembly] Add more error checking to object file parsing.
  • Add test
Fri, May 18, 2:51 PM
sbc100 updated the diff for D47086: [WebAssembly] Add more error checking to object file parsing.
  • catch leb errors
Fri, May 18, 2:35 PM
sbc100 added a reviewer for D47086: [WebAssembly] Add more error checking to object file parsing: jfb.
Fri, May 18, 2:28 PM
sbc100 updated the diff for D47086: [WebAssembly] Add more error checking to object file parsing.
  • clang-format
Fri, May 18, 2:28 PM
sbc100 created D47086: [WebAssembly] Add more error checking to object file parsing.
Fri, May 18, 2:26 PM
sbc100 added inline comments to D47046: [WebAssembly] Object: Add more error checking for object file reading.
Fri, May 18, 10:14 AM

Thu, May 17

sbc100 added a reviewer for D47047: MC: Remove redundant substr() call: dschuff.
Thu, May 17, 6:35 PM
sbc100 created D47047: MC: Remove redundant substr() call.
Thu, May 17, 6:33 PM
sbc100 added a reviewer for D47046: [WebAssembly] Object: Add more error checking for object file reading: jfb.
Thu, May 17, 6:30 PM
sbc100 created D47046: [WebAssembly] Object: Add more error checking for object file reading.
Thu, May 17, 6:29 PM
sbc100 added inline comments to D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
Thu, May 17, 10:19 AM

Wed, May 16

sbc100 added a comment to D46985: [NFC] WebAssembly build break #2.

Why does this work? Doesn't LLVM_DUMP_METHOD force this method into the link regardless? I though that was the point of it.. so it would never be eliminated.

Wed, May 16, 3:37 PM
sbc100 added a comment to D46977: [NFC] WebAssembly build fix.

Thanks. Makes sense.

Wed, May 16, 3:20 PM
sbc100 added a comment to D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC..
In D46847#1101983, @vsk wrote:

I can't reproduce those failures locally. I also build with BUILD_SHARED_LIBS=ON so I would expect to see the same errors as you.

I don't use that option, but I do use LLVM_ENABLE_MODULES=On.

Can you see how RandomAccessVisitorTest.cpp makes use of BinaryFormat/Wasm.h?

In the .o, I see:

__ZNSt3__110unique_ptrIN12_GLOBAL__N_123RandomAccessVisitorTest15GlobalTestStateENS_14default_deleteIS3_EEED1Ev:
...
000000000000032a        movq    __ZNK4llvm6object10WasmSymbol4dumpEv(%rdi), %r14 ## llvm::object::WasmSymbol::dump() const

For some reason, the unit test's GlobalTestState deleter needs to store a function pointer to WasmSymbol::dump? If I remove "LLVM_DUMP_METHOD" from the definition, it no longer appears in the .o. I think something strange with attribute((used)) is happening, and I don't understand why. The only use of this symbol in the IR is in the magic @llvm.used global.

Your fix looks find to me though.  Is it just those two targets that fail?

These are the only two targets which fail to build as a part of 'check-llvm'. Do you want to dig any deeper into this, or should I just land the build fix?

Wed, May 16, 3:15 PM
sbc100 added a comment to D46443: Add missing cstdalign header.

ping

Wed, May 16, 12:15 PM
sbc100 updated the summary of D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
Wed, May 16, 12:10 PM
sbc100 updated the summary of D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
Wed, May 16, 12:07 PM
sbc100 updated the summary of D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
Wed, May 16, 12:06 PM
sbc100 updated the diff for D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
  • revert
Wed, May 16, 12:05 PM
sbc100 updated the diff for D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
  • revert
Wed, May 16, 12:03 PM
sbc100 created D46970: [WebAssembly] MC: Ensure that FUNCTION_OFFSET relocations are always against function symbols..
Wed, May 16, 11:51 AM
sbc100 added a reviewer for D46969: [WebAssembly] Remove unused headers in MCWasmObjectWriter: dschuff.
Wed, May 16, 11:48 AM
sbc100 created D46969: [WebAssembly] Remove unused headers in MCWasmObjectWriter.
Wed, May 16, 11:48 AM
sbc100 added a comment to D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC..

I can't reproduce those failures locally. I also build with BUILD_SHARED_LIBS=ON so I would expect to see the same errors as you.

Wed, May 16, 11:40 AM
sbc100 added a comment to D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC..
In D46847#1101688, @vsk wrote:

Hi,

I'm seeing a few link failures due to this commit (I think):

Undefined symbols for architecture x86_64:
  "llvm::wasm::toString(llvm::wasm::WasmSymbolType)", referenced from:
      llvm::object::WasmSymbol::print(llvm::raw_ostream&) const in RandomAccessVisitorTest.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This affects the llvm-rc binary and some unit tests. I'm not sure why others aren't seeing the same build break -- possibly this is due to my building with modules. Here's a candidate fix:

diff --git a/tools/llvm-rc/CMakeLists.txt b/tools/llvm-rc/CMakeLists.txt
index 4cadc176691..175de768bf7 100644
--- a/tools/llvm-rc/CMakeLists.txt
+++ b/tools/llvm-rc/CMakeLists.txt
@@ -1,6 +1,7 @@
 set(LLVM_LINK_COMPONENTS
   Option
   Support
+  BinaryFormat
   )
 
 set(LLVM_TARGET_DEFINITIONS Opts.td)
diff --git a/unittests/DebugInfo/CodeView/CMakeLists.txt b/unittests/DebugInfo/CodeView/CMakeLists.txt
index 70a7b8af144..ea3adc6f2ea 100644
--- a/unittests/DebugInfo/CodeView/CMakeLists.txt
+++ b/unittests/DebugInfo/CodeView/CMakeLists.txt
@@ -1,5 +1,6 @@
 set(LLVM_LINK_COMPONENTS
   DebugInfoCodeView
+  BinaryFormat
   )
 
 add_llvm_unittest(DebugInfoCodeViewTests

Could you please take a look?

Wed, May 16, 11:33 AM

Tue, May 15

sbc100 removed a dependency for D46765: [WebAssembly] Fix R_WEBASSEMBLY_FUNCTION_OFFSET_I32 relocation entries: D46763: [WebAssembly] Provide WasmFunction content offset informatin..
Tue, May 15, 2:58 PM
sbc100 removed a dependent revision for D46763: [WebAssembly] Provide WasmFunction content offset informatin.: D46765: [WebAssembly] Fix R_WEBASSEMBLY_FUNCTION_OFFSET_I32 relocation entries.
Tue, May 15, 2:58 PM
sbc100 added a comment to D46556: [MC] Move MCAssembler::dump into the correct cpp file. NFC.

Yes. I work on linux.

Tue, May 15, 2:51 PM
sbc100 accepted D46765: [WebAssembly] Fix R_WEBASSEMBLY_FUNCTION_OFFSET_I32 relocation entries.
Tue, May 15, 12:34 PM
sbc100 added a comment to D46763: [WebAssembly] Provide WasmFunction content offset informatin..

Should I land this now?

Tue, May 15, 12:34 PM
sbc100 added a comment to D46416: [WebAssembly] Optionally compress relocation sites in the code section.

OK to land now @ruiu ?

Tue, May 15, 10:24 AM

Mon, May 14

sbc100 added a comment to rL332305: [WebAssembly] Move toString helpers to BinaryFormat.

I think I broke the debug shared library build with this change. Fix is in https://reviews.llvm.org/D46859

Mon, May 14, 5:48 PM
sbc100 added a reviewer for D46859: Fix debug build by adding missing dependencies on libBinaryFormat: aheejin.
Mon, May 14, 5:47 PM
sbc100 created D46859: Fix debug build by adding missing dependencies on libBinaryFormat.
Mon, May 14, 5:47 PM
sbc100 updated the diff for D45796: [WebAssembly] Support imports from custom module names.
  • update test
Mon, May 14, 4:13 PM
sbc100 updated the diff for D45796: [WebAssembly] Support imports from custom module names.
  • rebase
Mon, May 14, 4:12 PM
sbc100 added a comment to D46594: [WebAssembly] Allow signature of entry function to be flexible.

Ping.

Mon, May 14, 3:54 PM
sbc100 updated the summary of D46849: [WebAssembly] Update to match llvm changes.
Mon, May 14, 1:48 PM
sbc100 created D46849: [WebAssembly] Update to match llvm changes.
Mon, May 14, 1:47 PM
sbc100 retitled D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC. from [WebAssembly] Move toString helpers to BinaryFormat. to [WebAssembly] Move toString helpers to BinaryFormat. NFC..
Mon, May 14, 1:47 PM
sbc100 added a reviewer for D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC.: ncw.
Mon, May 14, 1:46 PM
sbc100 retitled D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC. from [WebAssembly] Move toString helpers to BinaryFormat. NFC. to [WebAssembly] Move toString helpers to BinaryFormat..
Mon, May 14, 1:46 PM
sbc100 updated the diff for D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC..

-typo

Mon, May 14, 1:46 PM
sbc100 retitled D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC. from [WebAssembly] Move toString helpers to BinaryFormat to [WebAssembly] Move toString helpers to BinaryFormat. NFC..
Mon, May 14, 1:45 PM
sbc100 created D46847: [WebAssembly] Move toString helpers to BinaryFormat. NFC..
Mon, May 14, 1:44 PM
sbc100 added a comment to D46765: [WebAssembly] Fix R_WEBASSEMBLY_FUNCTION_OFFSET_I32 relocation entries.

I think you can remove getFunctionBody()?

Mon, May 14, 11:49 AM
sbc100 accepted D46765: [WebAssembly] Fix R_WEBASSEMBLY_FUNCTION_OFFSET_I32 relocation entries.
Mon, May 14, 11:11 AM
sbc100 accepted D46763: [WebAssembly] Provide WasmFunction content offset informatin..
Mon, May 14, 11:09 AM

Thu, May 10

sbc100 added inline comments to D45848: [WebAssembly] Initial Disassembler..
Thu, May 10, 2:33 PM
sbc100 updated the diff for D44348: [WebAssembly] Generate imports for undefined data as well as functions.
  • rebase
Thu, May 10, 11:40 AM
sbc100 updated the diff for D43963: [WebAssembly] Simplify writing of exports section. NFC..
  • rebase
Thu, May 10, 11:12 AM
sbc100 reclaimed D43963: [WebAssembly] Simplify writing of exports section. NFC..
Thu, May 10, 11:12 AM
sbc100 closed D45118: [WebAssembly] Linking debug (DWARF) sections from WebAssembly object files.

Fixed in rLLD331566

Thu, May 10, 10:52 AM
sbc100 added a reviewer for D46561: [WebAssembly] Create section start symbols automatically for all sections: dschuff.
Thu, May 10, 9:56 AM
sbc100 updated the diff for D46561: [WebAssembly] Create section start symbols automatically for all sections.
  • rebase
Thu, May 10, 9:56 AM
sbc100 added a comment to D46342: [WebAsembly] Update default triple in test files to wasm32-unknown-unkown..

ping

Thu, May 10, 9:40 AM
sbc100 added a reviewer for D46342: [WebAsembly] Update default triple in test files to wasm32-unknown-unkown.: dschuff.
Thu, May 10, 9:40 AM

Tue, May 8

sbc100 accepted D46417: wasm: Add a flag to control merging data segments.

Nice! Much cleaner now.

Tue, May 8, 4:39 PM
sbc100 added reviewers for D46594: [WebAssembly] Allow signature of entry function to be flexible: ruiu, jgravelle-google.
Tue, May 8, 1:43 PM
sbc100 updated the diff for D46594: [WebAssembly] Allow signature of entry function to be flexible.
  • cleanup
Tue, May 8, 1:43 PM
sbc100 updated the summary of D46594: [WebAssembly] Allow signature of entry function to be flexible.
Tue, May 8, 1:39 PM