Page MenuHomePhabricator

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (340 w, 6 d)

Recent Activity

Today

sbc100 committed rG2ea8a3a56a51: [lld][WebAssembly] Process stub libraries before performing LTO (authored by sbc100).
[lld][WebAssembly] Process stub libraries before performing LTO
Thu, Mar 30, 2:28 PM · Restricted Project
sbc100 closed D147190: [lld][WebAssembly] Process stub libraries before and after LTO.
Thu, Mar 30, 2:27 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D147190: [lld][WebAssembly] Process stub libraries before and after LTO.
  • a test
Thu, Mar 30, 11:43 AM · Restricted Project, Restricted Project
sbc100 added a comment to D147190: [lld][WebAssembly] Process stub libraries before and after LTO.

I guess the new test covers the stub->bitcode lib dependence case. Is there a test that covers the codgen->libcall->stub case?

Thu, Mar 30, 11:15 AM · Restricted Project, Restricted Project
sbc100 updated the diff for D147190: [lld][WebAssembly] Process stub libraries before and after LTO.
  • feedback
Thu, Mar 30, 11:13 AM · Restricted Project, Restricted Project
sbc100 added a comment to D147190: [lld][WebAssembly] Process stub libraries before and after LTO.

i.e. it seems like it would be simpler to just support processing the stubs once. or maybe more specifically, to handle them the same as other archive libraries (i.e. participate in the iterate-to-convergence phase of symbol resolution but not get special treatment for LTO?)

Thu, Mar 30, 11:03 AM · Restricted Project, Restricted Project
sbc100 added a comment to D147190: [lld][WebAssembly] Process stub libraries before and after LTO.

Do we really need to support stub libcalls (i.e. the kind that can be generated at codegen time)? These should just be compiler-rt and maybe a few core libc functions, right? Do we expect those to be implemented in JS and/or the environment?

Thu, Mar 30, 11:01 AM · Restricted Project, Restricted Project

Yesterday

sbc100 retitled D147190: [lld][WebAssembly] Process stub libraries before and after LTO from [lld][WebAssembly] Process stub libraries before performing LTO to [lld][WebAssembly] Process stub libraries before and after LTO.
Wed, Mar 29, 5:15 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D147190: [lld][WebAssembly] Process stub libraries before and after LTO: dschuff.
Wed, Mar 29, 5:14 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D147190: [lld][WebAssembly] Process stub libraries before and after LTO.
  • comments
Wed, Mar 29, 5:14 PM · Restricted Project, Restricted Project
sbc100 requested review of D147190: [lld][WebAssembly] Process stub libraries before and after LTO.
Wed, Mar 29, 5:12 PM · Restricted Project, Restricted Project
sbc100 abandoned D76547: [WebAssembly] Add `wasm-exported` function attribute.

The reason __attribute__((export_name("foo"))) doesn't work in all use cases is that we have a lot of existing code that uses the EMSCRIPTEN_KEEPALIVE macro. We also have run into other folks who want to include this is some kind of FOO_API, or EXPORT_API type macros. Its not possible to have such a macro map to the existing export_name since they don't include the symbol name: e.g:

EMSCRIPTEN_KEEPALIVE int foo();`

JNI_EXPORT int myfunct();

In these cases we need something that uses the llvm symbol name for the export.

I think there's two ways we could address this without adding a new attribute (maybe you've thought of this and have reasons for this to be a bad suggestion):

  • It seems that export_name doesn't care if you put in an empty string for the argument, so we could treat that case as meaning "export with the name of the symbol this attribute is attached to"
  • We could allow export_name to take zero or one argument. The one-argument form is the same as it is today, but the zero argument form exports with the name of the symbol the attribute is attached to.

Do you think either of those could work?

Yes, I think the second one would be ideal. The first one is slightly less idea because it prevents something being exported with the empty string as its name (wasm allows such things).

Ah, yeah, that's a good reason to avoid the first one.

Can an attribute take an optional argument? That would be great solution. For my initial version of this change I did look into making export_name(DEFAULT) work (note the lack of quotes around the word DEFAULT here), but I could not find way to make a single attribute take both a string *or* a constant.

Yup, it takes only a little bit of extra work to do right. Have the attribute's argument list take a VariadicStringArgument instead of StringArgument so you can pass zero or more arguments, then have the attribute handler in SemaDeclAttr.cpp diagnose if the attribute is given > 1 argument. The rest should be things like documentation or fall out somewhat naturally (there will be accessors added to the WebAssemblyExportNameAttr class that let you access the arguments with iterators, and a size accessor as well, so you can tell if the semantic attribute does/does not have an argument).

Wed, Mar 29, 11:52 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 added a comment to D76547: [WebAssembly] Add `wasm-exported` function attribute.

The reason __attribute__((export_name("foo"))) doesn't work in all use cases is that we have a lot of existing code that uses the EMSCRIPTEN_KEEPALIVE macro. We also have run into other folks who want to include this is some kind of FOO_API, or EXPORT_API type macros. Its not possible to have such a macro map to the existing export_name since they don't include the symbol name: e.g:

EMSCRIPTEN_KEEPALIVE int foo();`

JNI_EXPORT int myfunct();

In these cases we need something that uses the llvm symbol name for the export.

I think there's two ways we could address this without adding a new attribute (maybe you've thought of this and have reasons for this to be a bad suggestion):

  • It seems that export_name doesn't care if you put in an empty string for the argument, so we could treat that case as meaning "export with the name of the symbol this attribute is attached to"
  • We could allow export_name to take zero or one argument. The one-argument form is the same as it is today, but the zero argument form exports with the name of the symbol the attribute is attached to.

Do you think either of those could work?

Wed, Mar 29, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 added a comment to D76547: [WebAssembly] Add `wasm-exported` function attribute.

The reason __attribute__((export_name("foo"))) doesn't work in all use cases is that we have a lot of existing code that uses the EMSCRIPTEN_KEEPALIVE macro. We also have run into other folks who want to include this is some kind of FOO_API, or EXPORT_API type macros. Its not possible to have such a macro map to the existing export_name since they don't include the symbol name: e.g:

Wed, Mar 29, 10:46 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 23

sbc100 committed rG3111784ff7d3: [lld][WebAssembly] Initial support for stub libraries (authored by sbc100).
[lld][WebAssembly] Initial support for stub libraries
Thu, Mar 23, 2:27 PM · Restricted Project
sbc100 closed D145308: [lld][WebAssembly] Initial support for stub libraries.
Thu, Mar 23, 2:26 PM · Restricted Project, Restricted Project
sbc100 added a comment to D76547: [WebAssembly] Add `wasm-exported` function attribute.

I just figured out that this cannot replace the current use of __attribute__((used)) in emscripten because function attributes only work for functions and we need this mechanism to work for global data addresses too. There is simply no way to do something like Fn->addFnAttr("wasm-exported"); for a GlobalValue that isn't a function (as far as I can tell).

Thu, Mar 23, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 updated the diff for D76547: [WebAssembly] Add `wasm-exported` function attribute.
  • limit to emscripten
Thu, Mar 23, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 added a comment to D76547: [WebAssembly] Add `wasm-exported` function attribute.

I've limited to new attribute to only the emcripten triple.

Thu, Mar 23, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 updated the summary of D76547: [WebAssembly] Add `wasm-exported` function attribute.
Thu, Mar 23, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 updated the diff for D76547: [WebAssembly] Add `wasm-exported` function attribute.
  • update test
Thu, Mar 23, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 retitled D76547: [WebAssembly] Add `wasm-exported` function attribute from [WebAssembly] Add `exported` function attribute to [WebAssembly] Add `wasm-exported` function attribute.
Thu, Mar 23, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 retitled D76547: [WebAssembly] Add `wasm-exported` function attribute from [WebAssembly] Add wasm-exported function attribute to [WebAssembly] Add `exported` function attribute.
Thu, Mar 23, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 updated the summary of D76547: [WebAssembly] Add `wasm-exported` function attribute.
Thu, Mar 23, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 updated the summary of D76547: [WebAssembly] Add `wasm-exported` function attribute.
Thu, Mar 23, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 updated the summary of D76547: [WebAssembly] Add `wasm-exported` function attribute.
Thu, Mar 23, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 added a comment to D76547: [WebAssembly] Add `wasm-exported` function attribute.

What about your idea of using the default keyword rather than adding a new clang attr? I quite liked that approach.

Thu, Mar 23, 10:38 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 updated the diff for D76547: [WebAssembly] Add `wasm-exported` function attribute.
  • rebase
Thu, Mar 23, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
sbc100 added a comment to D145308: [lld][WebAssembly] Initial support for stub libraries.

Any objections to landing this?

Thu, Mar 23, 10:04 AM · Restricted Project, Restricted Project

Tue, Mar 21

sbc100 added inline comments to D146568: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll.
Tue, Mar 21, 2:45 PM · Restricted Project, Restricted Project

Tue, Mar 14

sbc100 added inline comments to D145966: [WebAssembly] Replace Bugzilla links with Github issues.
Tue, Mar 14, 6:03 PM · Restricted Project, Restricted Project

Mon, Mar 13

sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • feedback
Mon, Mar 13, 4:28 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • remove unused method
Mon, Mar 13, 3:42 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • error -> assert
Mon, Mar 13, 3:39 PM · Restricted Project, Restricted Project
sbc100 added a comment to D145308: [lld][WebAssembly] Initial support for stub libraries.

WDYT Dan? My guess is that wasi-sdk doesn't currently need to express these reverse dependencies, so its not currently relevant.

Mon, Mar 13, 3:27 PM · Restricted Project, Restricted Project
sbc100 retitled D145308: [lld][WebAssembly] Initial support for stub libraries from [lld][WebAssembly] Initial support for stub objects to [lld][WebAssembly] Initial support for stub libraries.
Mon, Mar 13, 3:12 PM · Restricted Project, Restricted Project

Thu, Mar 9

sbc100 committed rGd32f71a91a43: [lld][WebAssembly] Use C++17 nested namespace syntax in most places. NFC (authored by sbc100).
[lld][WebAssembly] Use C++17 nested namespace syntax in most places. NFC
Thu, Mar 9, 6:38 PM · Restricted Project
sbc100 closed D145399: [lld][WebAssembly] Use C++17 nested namespace syntax in most places. NFC.
Thu, Mar 9, 6:38 PM · Restricted Project, Restricted Project
sbc100 added a comment to D145308: [lld][WebAssembly] Initial support for stub libraries.

I think this feature could also be useful in non-emscripten environments, e.g. you could have a stub library for each WASI API provided by the embedder. Does wasi-sdk just use --allow-undefined for this now? Stub libraries seem nicer than that.
@sunfish WDYT, does this look useful?

Thu, Mar 9, 9:51 AM · Restricted Project, Restricted Project

Wed, Mar 8

sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • stub libraries
Wed, Mar 8, 7:04 PM · Restricted Project, Restricted Project
sbc100 added a comment to D145626: [WebAssembly] Support debug info for TLS + global in PIC mode.

What you say ", TLS + dynamic linking will not work at the moment." do you mean just the debug info won't work? Or it won't work at all?

Wed, Mar 8, 4:30 PM · Restricted Project, Restricted Project

Tue, Mar 7

sbc100 added inline comments to D145308: [lld][WebAssembly] Initial support for stub libraries.
Tue, Mar 7, 1:38 PM · Restricted Project, Restricted Project

Mon, Mar 6

sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • rebase
Mon, Mar 6, 5:57 PM · Restricted Project, Restricted Project
sbc100 committed rG8aef04fa69a2: [lld][WebAssembly] Implement --why-extract flag from the ELF backend (authored by sbc100).
[lld][WebAssembly] Implement --why-extract flag from the ELF backend
Mon, Mar 6, 5:56 PM · Restricted Project
sbc100 closed D145431: [lld][WebAssembly] Implement --why-extract flag from the ELF backend.
Mon, Mar 6, 5:56 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145431: [lld][WebAssembly] Implement --why-extract flag from the ELF backend.
  • feedback
Mon, Mar 6, 5:52 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D145308: [lld][WebAssembly] Initial support for stub libraries.
Mon, Mar 6, 5:16 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.

Feedback

Mon, Mar 6, 5:15 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D145308: [lld][WebAssembly] Initial support for stub libraries.
Mon, Mar 6, 4:44 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • feedback
Mon, Mar 6, 4:44 PM · Restricted Project, Restricted Project
sbc100 committed rG088d1f100ebd: [lld][ELF] Remove unused enum value. NFC (authored by sbc100).
[lld][ELF] Remove unused enum value. NFC
Mon, Mar 6, 4:07 PM · Restricted Project
sbc100 closed D145434: [lld][ELF] Remove unused enum value. NFC.
Mon, Mar 6, 4:07 PM · Restricted Project, Restricted Project
sbc100 retitled D145434: [lld][ELF] Remove unused enum value. NFC from [lld][ELF] Remove unused enum value to [lld][ELF] Remove unused enum value. NFC.
Mon, Mar 6, 4:06 PM · Restricted Project, Restricted Project
sbc100 requested review of D145434: [lld][ELF] Remove unused enum value. NFC.
Mon, Mar 6, 2:45 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145431: [lld][WebAssembly] Implement --why-extract flag from the ELF backend.
  • Revert part
Mon, Mar 6, 2:42 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D145431: [lld][WebAssembly] Implement --why-extract flag from the ELF backend: dschuff.
Mon, Mar 6, 2:39 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145431: [lld][WebAssembly] Implement --why-extract flag from the ELF backend.
  • revert ELF
Mon, Mar 6, 2:39 PM · Restricted Project, Restricted Project
sbc100 requested review of D145431: [lld][WebAssembly] Implement --why-extract flag from the ELF backend.
Mon, Mar 6, 2:38 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D145399: [lld][WebAssembly] Use C++17 nested namespace syntax in most places. NFC: thakis.
Mon, Mar 6, 9:57 AM · Restricted Project, Restricted Project
sbc100 requested review of D145399: [lld][WebAssembly] Use C++17 nested namespace syntax in most places. NFC.
Mon, Mar 6, 9:56 AM · Restricted Project, Restricted Project
sbc100 added a comment to D131405: [lld/win] Use C++17 nested namespace syntax in most places.

In general, when making these kind of generic changes, would it be possible to also include wasm-ld (lld/wasm) so that we keep things as in-sync as possible?

Mon, Mar 6, 9:41 AM · Restricted Project, Restricted Project

Sat, Mar 4

sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.

Fixes

Sat, Mar 4, 3:43 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • dead code
Sat, Mar 4, 10:44 AM · Restricted Project, Restricted Project
sbc100 updated the diff for D145308: [lld][WebAssembly] Initial support for stub libraries.
  • typos
Sat, Mar 4, 10:42 AM · Restricted Project, Restricted Project
sbc100 added a reviewer for D145308: [lld][WebAssembly] Initial support for stub libraries: dschuff.
Sat, Mar 4, 10:41 AM · Restricted Project, Restricted Project
sbc100 requested review of D145308: [lld][WebAssembly] Initial support for stub libraries.
Sat, Mar 4, 10:40 AM · Restricted Project, Restricted Project

Wed, Mar 1

sbc100 accepted D107662: [WebAssembly] Implement build-id feature.
Wed, Mar 1, 5:05 PM · Restricted Project, Restricted Project
sbc100 accepted D107662: [WebAssembly] Implement build-id feature.

lgtm % some minor nits

Wed, Mar 1, 1:39 PM · Restricted Project, Restricted Project

Feb 27 2023

sbc100 committed rGd65ed8cde0a2: [lld][WebAssembly] Fix handling of mixed strong and weak references (authored by sbc100).
[lld][WebAssembly] Fix handling of mixed strong and weak references
Feb 27 2023, 2:22 PM · Restricted Project, Restricted Project
sbc100 closed D144747: [lld][WebAssembly] Fix handling of mixed strong and weak references.
Feb 27 2023, 2:22 PM · Restricted Project, Restricted Project
sbc100 updated the diff for D144747: [lld][WebAssembly] Fix handling of mixed strong and weak references.
  • feedback
Feb 27 2023, 12:34 PM · Restricted Project, Restricted Project
sbc100 added a comment to D144747: [lld][WebAssembly] Fix handling of mixed strong and weak references.

ptal

Feb 27 2023, 8:51 AM · Restricted Project, Restricted Project

Feb 24 2023

sbc100 added a reviewer for D144747: [lld][WebAssembly] Fix handling of mixed strong and weak references: dschuff.
Feb 24 2023, 10:13 AM · Restricted Project, Restricted Project
sbc100 requested review of D144747: [lld][WebAssembly] Fix handling of mixed strong and weak references.
Feb 24 2023, 10:12 AM · Restricted Project, Restricted Project

Feb 13 2023

sbc100 committed rG9369b7d307be: [lld][WebAssembly] Limit size of shared 64-bit memories of 2^^34 (authored by sbc100).
[lld][WebAssembly] Limit size of shared 64-bit memories of 2^^34
Feb 13 2023, 12:23 PM · Restricted Project
sbc100 closed D143783: [lld][WebAssembly] Limit size of shared 64-bit memories of 2^^34.
Feb 13 2023, 12:22 PM · Restricted Project, Restricted Project

Feb 10 2023

sbc100 added a comment to D143783: [lld][WebAssembly] Limit size of shared 64-bit memories of 2^^34.

Working on adding a test now. This is needed to run wasm64 + pthread + dynamic linking tests on the emscripten side.

Feb 10 2023, 3:16 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D143783: [lld][WebAssembly] Limit size of shared 64-bit memories of 2^^34: dschuff.
Feb 10 2023, 3:16 PM · Restricted Project, Restricted Project
sbc100 requested review of D143783: [lld][WebAssembly] Limit size of shared 64-bit memories of 2^^34.
Feb 10 2023, 3:00 PM · Restricted Project, Restricted Project

Jan 31 2023

sbc100 committed rGa0495e6b008c: [lld][WebAssembly] Apply relocations to TLS data (authored by sbc100).
[lld][WebAssembly] Apply relocations to TLS data
Jan 31 2023, 3:52 PM · Restricted Project
sbc100 closed D143020: [lld][WebAssembly] Apply relocations to TLS data.
Jan 31 2023, 3:51 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D143020: [lld][WebAssembly] Apply relocations to TLS data.
Jan 31 2023, 3:47 PM · Restricted Project, Restricted Project
sbc100 updated the summary of D143020: [lld][WebAssembly] Apply relocations to TLS data.
Jan 31 2023, 2:54 PM · Restricted Project, Restricted Project
sbc100 requested review of D143020: [lld][WebAssembly] Apply relocations to TLS data.
Jan 31 2023, 2:53 PM · Restricted Project, Restricted Project
sbc100 committed rG3cd96a7309f6: [lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC (authored by sbc100).
[lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC
Jan 31 2023, 1:32 PM · Restricted Project
sbc100 closed D143009: [lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC.
Jan 31 2023, 1:32 PM · Restricted Project, Restricted Project
sbc100 retitled D143009: [lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC from [lld][WebAssembly] Renamed a few tests to confirm to naming convention. NFC to [lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC.
Jan 31 2023, 12:19 PM · Restricted Project, Restricted Project
sbc100 retitled D143009: [lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC from [lld][WebAssembly] Renamed a few test to confirm to naming convention. NFC to [lld][WebAssembly] Renamed a few tests to confirm to naming convention. NFC.
Jan 31 2023, 12:19 PM · Restricted Project, Restricted Project
sbc100 added a reviewer for D143009: [lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC: dschuff.
Jan 31 2023, 12:18 PM · Restricted Project, Restricted Project
sbc100 requested review of D143009: [lld][WebAssembly] Renamed a few tests to conform to naming convention. NFC.
Jan 31 2023, 12:18 PM · Restricted Project, Restricted Project

Jan 27 2023

sbc100 requested review of D142740: [WIP] [WebAssembly] Enable MemorySanitizer for emscripten.
Jan 27 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2023

sbc100 added inline comments to D141926: [WebAssembly] Add passes for GEP lowering.
Jan 17 2023, 7:49 AM · Restricted Project, Restricted Project

Jan 10 2023

sbc100 committed rGff8e0ed9308c: [lld][WebAssembly] Fix memory.fill argument in 64-bit mode (authored by sbc100).
[lld][WebAssembly] Fix memory.fill argument in 64-bit mode
Jan 10 2023, 3:11 AM · Restricted Project
sbc100 closed D141005: [lld][WebAssembly] Fix memory.fill argument in 64-bit mode.
Jan 10 2023, 3:11 AM · Restricted Project, Restricted Project

Jan 9 2023

sbc100 added a comment to D141103: [WebAssembly] Ensure 'end_function' in functions.

I think this change is find to land as is. If we decided to simplify that .s format we can possibly simplify the parser code later.

Jan 9 2023, 11:09 AM · Restricted Project, Restricted Project
sbc100 added a comment to D141103: [WebAssembly] Ensure 'end_function' in functions.

I wonder if its too late to change the requirement such that .functype should always come before the label? This would make the code simpler and the assembly format more consistent maybe?

Jan 9 2023, 3:26 AM · Restricted Project, Restricted Project
sbc100 accepted D141103: [WebAssembly] Ensure 'end_function' in functions.
Jan 9 2023, 3:24 AM · Restricted Project, Restricted Project

Jan 6 2023

sbc100 added inline comments to D141103: [WebAssembly] Ensure 'end_function' in functions.
Jan 6 2023, 2:23 AM · Restricted Project, Restricted Project

Jan 4 2023

sbc100 added a reviewer for D141005: [lld][WebAssembly] Fix memory.fill argument in 64-bit mode: dschuff.
Jan 4 2023, 11:31 AM · Restricted Project, Restricted Project
sbc100 requested review of D141005: [lld][WebAssembly] Fix memory.fill argument in 64-bit mode.
Jan 4 2023, 11:30 AM · Restricted Project, Restricted Project