Page MenuHomePhabricator
People sbc100

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (157 w, 2 d)

Recent Activity
View All

Thu, Sep 19

sbc100 updated the diff for D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output.
  • feedback
Thu, Sep 19, 9:41 PM · Restricted Project
sbc100 added a comment to D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output.

ping..

Thu, Sep 19, 5:21 PM · Restricted Project

Wed, Sep 18

sbc100 accepted D67736: [WebAssembly] Sort output data sections to place .bss last.
Wed, Sep 18, 6:05 PM · Restricted Project
sbc100 added a comment to D67736: [WebAssembly] Sort output data sections to place .bss last.

Nice!

Wed, Sep 18, 4:45 PM · Restricted Project
sbc100 committed rGe40ef12bfad0: [lld][WebAssembly] Fix use after free of archive path (authored by sbc100).
[lld][WebAssembly] Fix use after free of archive path
Wed, Sep 18, 3:01 PM
sbc100 added reviewers for D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output: ruiu, jgravelle-google.
Wed, Sep 18, 12:50 PM · Restricted Project
sbc100 updated the diff for D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output.

add test

Wed, Sep 18, 12:50 PM · Restricted Project
sbc100 updated the summary of D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output.
Wed, Sep 18, 12:41 PM · Restricted Project
sbc100 created D67729: [lld][WebAssembly] Preserve symbol flags in --relocatable output.
Wed, Sep 18, 12:34 PM · Restricted Project

Tue, Sep 17

sbc100 updated the diff for D67676: [lld][WebAssembly] Fix use after free of archive path.
  • revert
Tue, Sep 17, 2:44 PM · Restricted Project
sbc100 added a reviewer for D67676: [lld][WebAssembly] Fix use after free of archive path: ruiu.
Tue, Sep 17, 1:02 PM · Restricted Project
sbc100 created D67676: [lld][WebAssembly] Fix use after free of archive path.
Tue, Sep 17, 1:02 PM · Restricted Project

Thu, Sep 12

sbc100 accepted D67488: [lib/ObjectYAML] - Change interface to return `bool` instead of `int`. NFCI..
Thu, Sep 12, 10:11 AM · Restricted Project
sbc100 added inline comments to D67445: [yaml2obj/ObjectYAML] - Cleanup the error reporting API, add custom errors handlers..
Thu, Sep 12, 10:03 AM · Restricted Project

Wed, Sep 11

sbc100 accepted D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH.
Wed, Sep 11, 2:48 PM · Restricted Project, Restricted Project
sbc100 added inline comments to D67301: [LLD] Use the unified llvm demangle frontend function. NFC..
Wed, Sep 11, 10:04 AM · Restricted Project
sbc100 added inline comments to D67445: [yaml2obj/ObjectYAML] - Cleanup the error reporting API, add custom errors handlers..
Wed, Sep 11, 8:16 AM · Restricted Project
sbc100 added inline comments to D67445: [yaml2obj/ObjectYAML] - Cleanup the error reporting API, add custom errors handlers..
Wed, Sep 11, 7:34 AM · Restricted Project

Thu, Sep 5

sbc100 added a comment to D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH.

Derek, are you saying that -mexception-handling is somehow related to -fno-exceptions. What is the relationship? I wasn't aware this change was related to -fno-exceptions.

Thu, Sep 5, 4:43 PM · Restricted Project, Restricted Project
sbc100 added a comment to D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH.

But why not make -mexception-handling be the option that enabled everything? I mean -mexception-handling is a flag we have today.. if you add -fwasm-exceptions what does -mexception-handling meaning? Is it still useful?

Thu, Sep 5, 3:35 PM · Restricted Project, Restricted Project
sbc100 added a comment to D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH.

Is there some reason why clang can't pass the -exception-model=wasm flag programatically to llc when -mmexception-handling is set?

Thu, Sep 5, 2:52 PM · Restricted Project, Restricted Project
sbc100 added a comment to D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH.

I don't really see why we can't just have the existing -mexception-handling take on this new meaning?

Thu, Sep 5, 2:48 PM · Restricted Project, Restricted Project

Tue, Sep 3

sbc100 added a comment to D65783: [WebAssembly] Initialize memory in start function.

Can you verify that you can pass all the "wasm2" tests in emscripten with this change?

Tue, Sep 3, 6:27 PM · Restricted Project
sbc100 accepted D67129: [WebAssembly] Compare functions by names in Emscripten Sjlj.
Tue, Sep 3, 3:14 PM · Restricted Project

Fri, Aug 30

sbc100 resigned from D42233: [WebAssembly] Better support for WASM Object format.

I think this can be closed?

Fri, Aug 30, 4:48 PM
sbc100 resigned from D43720: [WebAssembly] Do not use default argument..
Fri, Aug 30, 4:47 PM · Restricted Project
sbc100 committed rGfecfc5920aeb: [lld][WebAssembly] Fix spurious signature mismatch warnings (authored by sbc100).
[lld][WebAssembly] Fix spurious signature mismatch warnings
Fri, Aug 30, 12:51 PM
sbc100 added a reviewer for D67015: [lld][WebAssembly] Fix spurious signature mismatch warnings: dschuff.
Fri, Aug 30, 11:34 AM · Restricted Project
sbc100 created D67015: [lld][WebAssembly] Fix spurious signature mismatch warnings.
Fri, Aug 30, 11:34 AM · Restricted Project

Thu, Aug 29

sbc100 accepted D66968: [WebAssembly] Implement NO_STRIP.
Thu, Aug 29, 2:15 PM · Restricted Project
sbc100 added a comment to D66968: [WebAssembly] Implement NO_STRIP.

I'm curious why a user would want to use WASM_SYMBOL_NO_STRIP if it doesn't export the symbol? Maybe for post-linker to do stuff perhaps?

Thu, Aug 29, 12:04 PM · Restricted Project

Mon, Aug 26

sbc100 created D66784: [lld][WebAssembly] Fix static linking of -fPIC code.
Mon, Aug 26, 10:42 PM · Restricted Project
sbc100 committed rG040ef1091d11: [lld][WebAssembly] Create optional symbols after handling --export/--undefined (authored by sbc100).
[lld][WebAssembly] Create optional symbols after handling --export/--undefined
Mon, Aug 26, 9:43 PM
sbc100 committed rG1a1df72a435a: [lld][WebAssembly] Store table base in config rather than passing it around. (authored by sbc100).
[lld][WebAssembly] Store table base in config rather than passing it around.
Mon, Aug 26, 9:25 PM
sbc100 added a reviewer for D66777: [lld][WebAssembly] Store table base in config rather than passing it around. NFC.: ruiu.
Mon, Aug 26, 5:17 PM · Restricted Project
sbc100 created D66777: [lld][WebAssembly] Store table base in config rather than passing it around. NFC..
Mon, Aug 26, 5:17 PM · Restricted Project
sbc100 created D66768: [lld][WebAssembly] Create optional symbols after handling --export/--undefined.
Mon, Aug 26, 2:42 PM · Restricted Project
sbc100 added a reviewer for D66768: [lld][WebAssembly] Create optional symbols after handling --export/--undefined: ruiu.
Mon, Aug 26, 2:42 PM · Restricted Project

Aug 22 2019

sbc100 committed rG90b6bb75e8cc: [MC] Minor cleanup to MCFixup::Kind handling. NFC. (authored by sbc100).
[MC] Minor cleanup to MCFixup::Kind handling. NFC.
Aug 22 2019, 6:07 PM
sbc100 closed D59890: [MC] Minor cleanup to MCFixup::Kind handling. NFC..
Aug 22 2019, 6:07 PM · Restricted Project

Aug 21 2019

sbc100 edited reviewers for D59890: [MC] Minor cleanup to MCFixup::Kind handling. NFC., added: dschuff; removed: grosbach.
Aug 21 2019, 2:44 PM · Restricted Project
sbc100 updated the diff for D59890: [MC] Minor cleanup to MCFixup::Kind handling. NFC..
  • rebase
Aug 21 2019, 2:44 PM · Restricted Project
sbc100 committed rGdde8a25a4bd0: [WebAssembly] Handle aliases in WebAssemblyFixFunctionBitcasts (authored by sbc100).
[WebAssembly] Handle aliases in WebAssemblyFixFunctionBitcasts
Aug 21 2019, 12:59 PM
sbc100 added inline comments to D66545: [WebAssembly] Add Emscripten support for UBSan, LSan and ASan.
Aug 21 2019, 11:38 AM · Restricted Project, Restricted Project
sbc100 added inline comments to D66545: [WebAssembly] Add Emscripten support for UBSan, LSan and ASan.
Aug 21 2019, 11:38 AM · Restricted Project, Restricted Project

Aug 20 2019

sbc100 added reviewers for D66508: [WebAssembly] Handle aliases in WebAssemblyFixFunctionBitcasts: jgravelle-google, kripken.
Aug 20 2019, 5:25 PM · Restricted Project
sbc100 created D66508: [WebAssembly] Handle aliases in WebAssemblyFixFunctionBitcasts.
Aug 20 2019, 5:25 PM · Restricted Project
sbc100 updated the summary of D66508: [WebAssembly] Handle aliases in WebAssemblyFixFunctionBitcasts.
Aug 20 2019, 5:25 PM · Restricted Project
sbc100 closed D66455: [WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC..

This landed as rL369317

Aug 20 2019, 2:31 PM · Restricted Project
sbc100 committed rGcf2b8722d4e3: [WebAssembly][lld] Fix crash when applying relocations to debug sections (authored by sbc100).
[WebAssembly][lld] Fix crash when applying relocations to debug sections
Aug 20 2019, 11:41 AM
sbc100 added a comment to D66455: [WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC..
In D66455#1637385, @dschuff wrote:

So it looks like this change is just that we now report an error where it asserted before?

Aug 20 2019, 8:56 AM · Restricted Project

Aug 19 2019

sbc100 committed rGecc5e8084f50: [WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC. (authored by sbc100).
[WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC.
Aug 19 2019, 5:34 PM
sbc100 added a comment to D66455: [WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC..

I mistakenly landed this change already, so this is post-commit review. Happy to revert if needed.

Aug 19 2019, 5:34 PM · Restricted Project
sbc100 added reviewers for D66455: [WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC.: sunfish, dschuff.
Aug 19 2019, 5:34 PM · Restricted Project
sbc100 created D66455: [WebAssembly][MC] Simplify WasmObjectWriter::recordRelocation. NFC..
Aug 19 2019, 5:33 PM · Restricted Project
sbc100 added a reviewer for D66435: [WebAssembly][lld] Fix crash when applying relocations to debug sections: dschuff.
Aug 19 2019, 4:43 PM · Restricted Project
sbc100 added a reviewer for D66435: [WebAssembly][lld] Fix crash when applying relocations to debug sections: ruiu.
Aug 19 2019, 12:28 PM · Restricted Project
sbc100 retitled D66435: [WebAssembly][lld] Fix crash when applying relocations to debug sections from [WebAssembly][lld] Fix crash when appling relocations to debug sections to [WebAssembly][lld] Fix crash when applying relocations to debug sections.
Aug 19 2019, 12:28 PM · Restricted Project
sbc100 created D66435: [WebAssembly][lld] Fix crash when applying relocations to debug sections.
Aug 19 2019, 12:25 PM · Restricted Project
sbc100 committed rG19bf637eb12c: [WebAssembly][MC] Allow empty assembly functions (authored by sbc100).
[WebAssembly][MC] Allow empty assembly functions
Aug 19 2019, 12:11 PM
sbc100 updated the diff for D66434: [WebAssembly][MC] Allow empty assembly functions.
  • feedback
Aug 19 2019, 12:10 PM · Restricted Project
sbc100 added a reviewer for D66434: [WebAssembly][MC] Allow empty assembly functions: aardappel.
Aug 19 2019, 11:52 AM · Restricted Project
sbc100 created D66434: [WebAssembly][MC] Allow empty assembly functions.
Aug 19 2019, 11:51 AM · Restricted Project
sbc100 committed rGe8e914e6404b: [lld][WebAssembly] Honor --no-export-dynamic even with -shared (authored by sbc100).
[lld][WebAssembly] Honor --no-export-dynamic even with -shared
Aug 19 2019, 9:37 AM
sbc100 closed D66359: [lld][WebAssembly] Honor --no-export-dynamic even with -shared.
Aug 19 2019, 9:37 AM · Restricted Project
sbc100 updated the diff for D66359: [lld][WebAssembly] Honor --no-export-dynamic even with -shared.
  • feedback
Aug 19 2019, 9:28 AM · Restricted Project

Aug 16 2019

sbc100 added a reviewer for D66359: [lld][WebAssembly] Honor --no-export-dynamic even with -shared: ruiu.
Aug 16 2019, 12:08 PM · Restricted Project
sbc100 updated the diff for D66359: [lld][WebAssembly] Honor --no-export-dynamic even with -shared.
  • add test
Aug 16 2019, 12:08 PM · Restricted Project
sbc100 created D66359: [lld][WebAssembly] Honor --no-export-dynamic even with -shared.
Aug 16 2019, 12:08 PM · Restricted Project
sbc100 added inline comments to D66356: [WebAssembly] Forbid use of EM_ASM with setjmp/longjmp.
Aug 16 2019, 11:33 AM · Restricted Project

Aug 13 2019

sbc100 committed rGcee41ce223c7: [libcxxabi] Define _LIBCXXABI_GUARD_ABI_ARM on WebAssembly (authored by sbc100).
[libcxxabi] Define _LIBCXXABI_GUARD_ABI_ARM on WebAssembly
Aug 13 2019, 6:33 PM
sbc100 updated the diff for D64961: [libcxxabi] Define _LIBCXXABI_GUARD_ABI_ARM on WebAssembly.
  • add comment
Aug 13 2019, 10:42 AM · Restricted Project, Restricted Project
sbc100 added a comment to D64961: [libcxxabi] Define _LIBCXXABI_GUARD_ABI_ARM on WebAssembly.

What do you think @sunfish, @EricWF? I have a slight preference for land this change but I want land one or the other.

Aug 13 2019, 10:36 AM · Restricted Project, Restricted Project
sbc100 committed rG7185a7301e86: [lld][WebAssembly] Allow linking of pic code into static binaries (authored by sbc100).
[lld][WebAssembly] Allow linking of pic code into static binaries
Aug 13 2019, 10:02 AM

Aug 12 2019

sbc100 added a comment to D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries.

@dschuff ptal

Aug 12 2019, 3:19 PM · Restricted Project
sbc100 accepted D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.
Aug 12 2019, 2:12 PM · Restricted Project

Aug 9 2019

sbc100 edited reviewers for D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries, added: dschuff; removed: kripken.
Aug 9 2019, 2:14 PM · Restricted Project
sbc100 added a reviewer for D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries: ruiu.
Aug 9 2019, 2:13 PM · Restricted Project

Aug 8 2019

sbc100 committed rGdbfea28219b6: [lld][WebAssembly] Don't create optional symbols when outputing an object file (authored by sbc100).
[lld][WebAssembly] Don't create optional symbols when outputing an object file
Aug 8 2019, 4:57 PM
sbc100 added a reviewer for D65985: [lld][WebAssembly] Don't create optional symbols when outputing an object file: quantum.
Aug 8 2019, 4:42 PM · Restricted Project
sbc100 created D65985: [lld][WebAssembly] Don't create optional symbols when outputing an object file.
Aug 8 2019, 4:42 PM · Restricted Project
sbc100 committed rGb865f88dc55d: Fix -DBUILD_SHARED_LIBS=ON build after rL368358 (authored by sbc100).
Fix -DBUILD_SHARED_LIBS=ON build after rL368358
Aug 8 2019, 4:05 PM
sbc100 added a reviewer for D65982: Fix -DBUILD_SHARED_LIBS=ON build after rL368358: diegotf.
Aug 8 2019, 3:56 PM · Restricted Project
sbc100 added a comment to D63672: Added Delta IR Reduction Tool.

I think they may have broken the -DBUILD_SHARED_LIBS=ON build: Proposed fix: https://reviews.llvm.org/D65982

Aug 8 2019, 3:56 PM · Restricted Project
sbc100 created D65982: Fix -DBUILD_SHARED_LIBS=ON build after rL368358.
Aug 8 2019, 3:56 PM · Restricted Project
sbc100 accepted D65980: [WebAssembly][lld] control __data_end export with config->shared.
Great thanks.  Sorry I overlooked that in my last change.   Ideally we shouldn't be making this available in `-pie` either but for restoring the previous behaviour seems reasonable.
Aug 8 2019, 3:35 PM · Restricted Project
sbc100 added inline comments to D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries.
Aug 8 2019, 12:10 PM · Restricted Project
sbc100 updated the diff for D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries.
  • clang-format
Aug 8 2019, 12:10 PM · Restricted Project
sbc100 committed rGad1cc145e8bb: [lld][WebAssembly] Use createGlobalVariable helper function. NFC. (authored by sbc100).
[lld][WebAssembly] Use createGlobalVariable helper function. NFC.
Aug 8 2019, 11:25 AM
sbc100 committed rGcaa0db13181e: [lld][WebAssembly] Add optional symbols after input file handling (authored by sbc100).
[lld][WebAssembly] Add optional symbols after input file handling
Aug 8 2019, 10:03 AM

Aug 7 2019

sbc100 retitled D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries from [lld][WebAssembly] Allow linking of pic code into static binaries to [lld][WebAssembly] Allow linking of PIC code into static binaries.
Aug 7 2019, 8:08 PM · Restricted Project
sbc100 updated the diff for D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries.

add __table_base

Aug 7 2019, 8:08 PM · Restricted Project
sbc100 created D65922: [lld][WebAssembly] Allow linking of PIC code into static binaries.
Aug 7 2019, 7:53 PM · Restricted Project
sbc100 accepted D65916: [lld][WebAssembly] Support for growable tables.
Aug 7 2019, 7:32 PM · Restricted Project
sbc100 added reviewers for D65920: [lld][WebAssembly] Add optional symbols after input file handling: ruiu, tlively.
Aug 7 2019, 6:56 PM · Restricted Project
sbc100 added a reviewer for D65911: [lld][WebAssembly] Use createGlobalVariable helper function. NFC.: tlively.
Aug 7 2019, 6:56 PM · Restricted Project
sbc100 updated the summary of D65920: [lld][WebAssembly] Add optional symbols after input file handling.
Aug 7 2019, 6:56 PM · Restricted Project
sbc100 created D65920: [lld][WebAssembly] Add optional symbols after input file handling.
Aug 7 2019, 6:52 PM · Restricted Project
sbc100 added a reviewer for D65911: [lld][WebAssembly] Use createGlobalVariable helper function. NFC.: ruiu.
Aug 7 2019, 4:26 PM · Restricted Project
sbc100 created D65911: [lld][WebAssembly] Use createGlobalVariable helper function. NFC..
Aug 7 2019, 4:26 PM · Restricted Project