Page MenuHomePhabricator

sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (139 w, 3 d)

Recent Activity

Today

sbc100 committed rG7804dbddccba: [WebAssembly] Add __start_/_stop_ symbols for data sections (authored by sbc100).
[WebAssembly] Add __start_/_stop_ symbols for data sections
Tue, May 21, 3:06 AM
sbc100 added a comment to D61929: [lld] Trace all references with lld --trace-symbol.

rebased. PTAL

Tue, May 21, 3:03 AM · Restricted Project
sbc100 updated the diff for D61929: [lld] Trace all references with lld --trace-symbol.
  • rebase
Tue, May 21, 3:03 AM · Restricted Project
sbc100 added a reviewer for D61876: [WebAssembly] Add __start_/_stop_ symbols for data sections: ruiu.
Tue, May 21, 2:30 AM · Restricted Project
sbc100 updated the diff for D61876: [WebAssembly] Add __start_/_stop_ symbols for data sections.
  • rebase
Tue, May 21, 2:26 AM · Restricted Project
sbc100 committed rG8fcf012693ae: [WebAssembly] Refactor synthetic sections and relocation processing. NFC. (authored by sbc100).
[WebAssembly] Refactor synthetic sections and relocation processing. NFC.
Tue, May 21, 2:11 AM
sbc100 added a comment to D62170: Add --reproduce to lld/wasm..

The convention I've been using is to prefex the commit subject with [WebAssembly]

Tue, May 21, 2:08 AM · Restricted Project
sbc100 accepted D62170: Add --reproduce to lld/wasm..
Tue, May 21, 2:04 AM · Restricted Project

Yesterday

sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • cleanup
Mon, May 20, 4:12 PM · Restricted Project
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • feedback
Mon, May 20, 4:12 PM · Restricted Project
sbc100 updated the diff for D62153: [WebAssembly] Relax signature checking for undefined functions that are not called directly.

reserve -> resize

Mon, May 20, 10:17 AM · Restricted Project
sbc100 added reviewers for D62153: [WebAssembly] Relax signature checking for undefined functions that are not called directly: ruiu, sunfish.
Mon, May 20, 10:05 AM · Restricted Project
sbc100 updated the diff for D62153: [WebAssembly] Relax signature checking for undefined functions that are not called directly.
  • comments
Mon, May 20, 10:04 AM · Restricted Project
sbc100 created D62153: [WebAssembly] Relax signature checking for undefined functions that are not called directly.
Mon, May 20, 9:59 AM · Restricted Project
sbc100 added inline comments to D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
Mon, May 20, 4:01 AM · Restricted Project
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • rename InStruct
Mon, May 20, 4:01 AM · Restricted Project

Fri, May 17

sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • clang-format
  • feedback
Fri, May 17, 4:27 PM · Restricted Project
sbc100 updated the diff for D59890: [MC] Minor cleanup to MCFixup::Kind handling. NFC..

rebase

Fri, May 17, 1:05 PM · Restricted Project
sbc100 committed rG13717bd54bb1: [WebAssembly] Remove expected failure of builtin-location.C test (authored by sbc100).
[WebAssembly] Remove expected failure of builtin-location.C test
Fri, May 17, 12:53 PM
sbc100 added a reviewer for D62075: [WebAssembly] Remove expected failure of builtin-location.C test: dschuff.
Fri, May 17, 12:52 PM · Restricted Project
sbc100 created D62075: [WebAssembly] Remove expected failure of builtin-location.C test.
Fri, May 17, 12:52 PM · Restricted Project

Thu, May 16

sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • rebase
Thu, May 16, 5:42 PM · Restricted Project
sbc100 added a comment to D62047: [WebAssembly] Add multivalue and tail-call target features.

Does it make sense to support the flags before we support the feature?

Thu, May 16, 5:22 PM · Restricted Project, Restricted Project
sbc100 committed rGd029bf0f8c45: [WebAssembly] Move code and data section generation to finalizeContent. NFC. (authored by sbc100).
[WebAssembly] Move code and data section generation to finalizeContent. NFC.
Thu, May 16, 2:34 PM
sbc100 committed rG1a53ff2a13fd: [WebAssembly] Don't generate empty type sections. (authored by sbc100).
[WebAssembly] Don't generate empty type sections.
Thu, May 16, 2:21 PM
sbc100 added a reviewer for D61971: [WebAssembly] Move code and data sectiion generation to finalizeContent. NFC.: dschuff.
Thu, May 16, 11:49 AM · Restricted Project
sbc100 updated the diff for D61971: [WebAssembly] Move code and data sectiion generation to finalizeContent. NFC..
  • whitespace
Thu, May 16, 11:49 AM · Restricted Project
sbc100 updated the diff for D61971: [WebAssembly] Move code and data sectiion generation to finalizeContent. NFC..
  • reduce diff
Thu, May 16, 11:46 AM · Restricted Project
sbc100 added a reviewer for D61991: [WebAssembly] Don't generate empty type section.: dschuff.
Thu, May 16, 11:33 AM · Restricted Project

Wed, May 15

sbc100 added a reviewer for D61991: [WebAssembly] Don't generate empty type section.: ruiu.
Wed, May 15, 10:35 PM · Restricted Project
sbc100 created D61991: [WebAssembly] Don't generate empty type section..
Wed, May 15, 10:35 PM · Restricted Project
sbc100 committed rGe7ab59eda980: [ELF] Fix typo in header guard. NFC. (authored by sbc100).
[ELF] Fix typo in header guard. NFC.
Wed, May 15, 5:44 PM
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • rebase
Wed, May 15, 5:42 PM · Restricted Project
sbc100 added a reviewer for D61971: [WebAssembly] Move code and data sectiion generation to finalizeContent. NFC.: ruiu.
Wed, May 15, 5:39 PM · Restricted Project
sbc100 updated the diff for D61971: [WebAssembly] Move code and data sectiion generation to finalizeContent. NFC..
  • remove isNeeded
Wed, May 15, 5:36 PM · Restricted Project
sbc100 added a comment to D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..

Split out part of this change into a smaller CL: https://reviews.llvm.org/D61971

Wed, May 15, 5:33 PM · Restricted Project
sbc100 created D61971: [WebAssembly] Move code and data sectiion generation to finalizeContent. NFC..
Wed, May 15, 5:33 PM · Restricted Project
sbc100 added a comment to D59890: [MC] Minor cleanup to MCFixup::Kind handling. NFC..

@grosbach do you have time to take quick look? Should be fairly straight forward.

Wed, May 15, 3:58 PM · Restricted Project
sbc100 updated the diff for D59890: [MC] Minor cleanup to MCFixup::Kind handling. NFC..
  • rebase
Wed, May 15, 3:55 PM · Restricted Project
sbc100 committed rG5e6ea2449779: [lld] Remove 2>&1 from --trace-symbol tests (authored by sbc100).
[lld] Remove 2>&1 from --trace-symbol tests
Wed, May 15, 12:02 PM
sbc100 committed rG697f2149f1c5: [WebAssembly] LTO: Honor comdat groups when loading bitcode files (authored by sbc100).
[WebAssembly] LTO: Honor comdat groups when loading bitcode files
Wed, May 15, 9:01 AM

Tue, May 14

sbc100 added a comment to D61924: [WebAssembly] LTO: Honor comdat groups when loading bitcode files.

Even though what this code does is the same as what we do for the ELF linker, the code looks different. In ELF, we pass ComdatGroups (which is a set of comdat signature strings we've seen so far) around. I don't remember if there was a reason to do it differently for Wasm. Do you remmeber?

Tue, May 14, 11:25 PM · Restricted Project
sbc100 added a comment to D61929: [lld] Trace all references with lld --trace-symbol.

Undefined symbols are indeed not currently displayed by --trace-symbol under the condition you mentioned, but that's also true for other types of symbols such as shared symbols.

A large refactoring is going on, and https://reviews.llvm.org/D61898, and once it's landed, I think we can fix the issue for all symbol types. Do you think you can wait until then?

Tue, May 14, 11:16 PM · Restricted Project
sbc100 updated the diff for D61928: [lld] Remove 2>&1 from --trace-symbol tests.
  • Fix special symbol crash
Tue, May 14, 8:16 PM · Restricted Project
sbc100 updated the summary of D61928: [lld] Remove 2>&1 from --trace-symbol tests.
Tue, May 14, 8:13 PM · Restricted Project
sbc100 added a reviewer for D61929: [lld] Trace all references with lld --trace-symbol: ruiu.
Tue, May 14, 8:09 PM · Restricted Project
sbc100 created D61929: [lld] Trace all references with lld --trace-symbol.
Tue, May 14, 8:09 PM · Restricted Project
sbc100 created D61928: [lld] Remove 2>&1 from --trace-symbol tests.
Tue, May 14, 7:46 PM · Restricted Project
sbc100 retitled D61928: [lld] Remove 2>&1 from --trace-symbol tests from [LLD] Remove 2>&1 from --trace-symbol tests to [lld] Remove 2>&1 from --trace-symbol tests.
Tue, May 14, 7:46 PM · Restricted Project
sbc100 added a reviewer for D61928: [lld] Remove 2>&1 from --trace-symbol tests: ruiu.
Tue, May 14, 7:46 PM · Restricted Project
sbc100 updated the diff for D61924: [WebAssembly] LTO: Honor comdat groups when loading bitcode files.
  • comment
Tue, May 14, 4:51 PM · Restricted Project
sbc100 added a reviewer for D61924: [WebAssembly] LTO: Honor comdat groups when loading bitcode files: ruiu.
Tue, May 14, 4:49 PM · Restricted Project
sbc100 created D61924: [WebAssembly] LTO: Honor comdat groups when loading bitcode files.
Tue, May 14, 4:48 PM · Restricted Project

Mon, May 13

sbc100 added a comment to D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..

Let me know if this is too much to review. I could try to break it down, but it is mostly a pure refactor.

Mon, May 13, 4:23 PM · Restricted Project
sbc100 added inline comments to D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
Mon, May 13, 4:23 PM · Restricted Project
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • refactor all the things
Mon, May 13, 4:20 PM · Restricted Project
sbc100 created D61876: [WebAssembly] Add __start_/_stop_ symbols for data sections.
Mon, May 13, 4:05 PM · Restricted Project
sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • move work from OutputSection constructors to finalizeContent
Mon, May 13, 2:41 PM · Restricted Project
sbc100 committed rG0b13ca2f5efd: [WebAssembly] Refactor relocation processing. NFC. (authored by sbc100).
[WebAssembly] Refactor relocation processing. NFC.
Mon, May 13, 9:43 AM

Fri, May 10

sbc100 updated the diff for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
  • remove comments
Fri, May 10, 5:01 PM · Restricted Project
sbc100 updated the summary of D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
Fri, May 10, 4:46 PM · Restricted Project
sbc100 added a reviewer for D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC.: ruiu.
Fri, May 10, 4:46 PM · Restricted Project
sbc100 created D61811: [WebAssembly] Refactor synthetic sections and relocation processing. NFC..
Fri, May 10, 4:43 PM · Restricted Project
sbc100 updated the summary of D61800: [WebAssembly] Refactor relocation processing. NFC..
Fri, May 10, 12:51 PM · Restricted Project
sbc100 created D61800: [WebAssembly] Refactor relocation processing. NFC..
Fri, May 10, 12:47 PM · Restricted Project
sbc100 added a comment to D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.

This may have broken CI, as it shows as one of the commits in the first broken roll here:

https://chromium-review.googlesource.com/c/emscripten-releases/+/1604139

other.test_binaryen_metadce_hello is broken there. Maybe we just need to update expectations? Looks like they rose though, which is odd?

Waterfall CI also shows wasm2.test_dylink_raii_exceptions is broken on Module.dynCall_ifdi is not a function which is maybe also related to this, but just a guess.

Fri, May 10, 10:21 AM · Restricted Project
sbc100 accepted D61781: [Object] Change ObjectFile::getSectionContents to use Expected.
Fri, May 10, 7:50 AM · Restricted Project

Thu, May 9

sbc100 committed rGea38ac5ba314: [WebAssembly] Don't assume that strongly defined symbols are DSO-local (authored by sbc100).
[WebAssembly] Don't assume that strongly defined symbols are DSO-local
Thu, May 9, 6:50 PM
sbc100 committed rG2147365484f1: [WebAssembly] Remove friend18.C from list of known gcc torture test failures. (authored by sbc100).
[WebAssembly] Remove friend18.C from list of known gcc torture test failures.
Thu, May 9, 6:45 PM
sbc100 added reviewers for D61775: [WebAssembly] Remove friend18.C from list of known gcc torture test failures.: dschuff, aheejin.
Thu, May 9, 6:44 PM · Restricted Project
sbc100 created D61775: [WebAssembly] Remove friend18.C from list of known gcc torture test failures..
Thu, May 9, 6:44 PM · Restricted Project
sbc100 updated the summary of D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.
Thu, May 9, 6:10 PM · Restricted Project
sbc100 updated the diff for D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.

Remove newline

Thu, May 9, 6:08 PM · Restricted Project
sbc100 updated the summary of D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.
Thu, May 9, 6:08 PM · Restricted Project
sbc100 updated the diff for D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.

Update tests

Thu, May 9, 6:05 PM · Restricted Project
sbc100 retitled D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local from [WebAssembly] Don't assume that strongly defined functions are DSO-local to [WebAssembly] Don't assume that strongly defined symbol are DSO-local.
Thu, May 9, 5:54 PM · Restricted Project
sbc100 updated the summary of D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.
Thu, May 9, 5:54 PM · Restricted Project
sbc100 added a reviewer for D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local: dschuff.
Thu, May 9, 5:54 PM · Restricted Project
sbc100 updated the diff for D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.

cleanup

Thu, May 9, 5:47 PM · Restricted Project
sbc100 created D61772: [WebAssembly] Don't assume that strongly defined symbol are DSO-local.
Thu, May 9, 5:47 PM · Restricted Project
sbc100 committed rG08fa01a9b7bc: Revert "[WebAssembly] Don't generate unused table entries." (authored by sbc100).
Revert "[WebAssembly] Don't generate unused table entries."
Thu, May 9, 12:36 PM
sbc100 added a reverting change for rGb33fdb7768e5: [WebAssembly] Don't generate unused table entries.: rG08fa01a9b7bc: Revert "[WebAssembly] Don't generate unused table entries.".
Thu, May 9, 12:35 PM
sbc100 added a comment to D61539: [WebAssembly] Don't generate unused table entries..

OK, I'll revert this for now while I investigate.

Thu, May 9, 10:26 AM · Restricted Project

Wed, May 8

sbc100 committed rGa1282a39bade: [WebAssembly] Handle command line options consistently with the ELF backend. (authored by sbc100).
[WebAssembly] Handle command line options consistently with the ELF backend.
Wed, May 8, 9:20 AM

Tue, May 7

sbc100 updated the diff for D61645: [WebAssembly] Handle command line options consistently with the ELF backend. NFC..
  • revert
Tue, May 7, 10:21 AM · Restricted Project
sbc100 retitled D61645: [WebAssembly] Handle command line options consistently with the ELF backend. NFC. from [WebAssembly] Handle command line options consistently with the ELF backend. to [WebAssembly] Handle command line options consistently with the ELF backend. NFC..
Tue, May 7, 10:21 AM · Restricted Project
sbc100 created D61645: [WebAssembly] Handle command line options consistently with the ELF backend. NFC..
Tue, May 7, 10:21 AM · Restricted Project
sbc100 added a comment to D42233: [WebAssembly] Better support for WASM Object format.

Are you able to generate and consume the __clangast now? It should show up as a custom section

Tue, May 7, 10:21 AM
sbc100 committed rGb33fdb7768e5: [WebAssembly] Don't generate unused table entries. (authored by sbc100).
[WebAssembly] Don't generate unused table entries.
Tue, May 7, 8:46 AM
sbc100 updated the diff for D61539: [WebAssembly] Don't generate unused table entries..
  • feedback
Tue, May 7, 8:45 AM · Restricted Project

Mon, May 6

sbc100 committed rG5f8c2edef355: [WebAssembly] Add more test coverage for reloctions against section symbols (authored by sbc100).
[WebAssembly] Add more test coverage for reloctions against section symbols
Mon, May 6, 8:52 PM
sbc100 updated the diff for D61623: [WebAssembly] Add more test coverage for reloctions against section symbols.
  • remove restriction
Mon, May 6, 5:12 PM · Restricted Project
sbc100 added reviewers for D61623: [WebAssembly] Add more test coverage for reloctions against section symbols: ruiu, yurydelendik.
Mon, May 6, 5:05 PM · Restricted Project
sbc100 created D61623: [WebAssembly] Add more test coverage for reloctions against section symbols.
Mon, May 6, 5:04 PM · Restricted Project

Fri, May 3

sbc100 added a reviewer for D61539: [WebAssembly] Don't generate unused table entries.: ruiu.
Fri, May 3, 2:38 PM · Restricted Project
sbc100 updated the diff for D61539: [WebAssembly] Don't generate unused table entries..
  • remove comment
Fri, May 3, 2:37 PM · Restricted Project
sbc100 created D61539: [WebAssembly] Don't generate unused table entries..
Fri, May 3, 2:29 PM · Restricted Project

Thu, May 2

sbc100 added a comment to D61452: [WebAssembly] Always include <sysroot>/lib in library path.

Even in the case of wasm64 it might well be that somebody wants to build two different sysroots (as they would be arm and arm64 on linux). Even if we don't choose to ship a single arch sysroot for wasi somebody else might.

Thu, May 2, 1:35 PM · Restricted Project
sbc100 added a comment to D61452: [WebAssembly] Always include <sysroot>/lib in library path.

If libraries don't correctly install into multi-arch directories, can we fix the libraries? We do this in the wasi-sdk repo to fix up the libc++ and libc++abi libraries, for example.

Thu, May 2, 11:33 AM · Restricted Project
sbc100 updated the diff for D61452: [WebAssembly] Always include <sysroot>/lib in library path.
  • update comment
Thu, May 2, 10:33 AM · Restricted Project