User Details
- User Since
- Sep 16 2016, 10:22 AM (238 w, 5 d)
Wed, Apr 7
Tue, Apr 6
typo
Mon, Apr 5
I dont love the name of this option.. but I failed to come up with any thing nicer.
rebase
cleanup
Sun, Apr 4
Tue, Mar 30
Man, these kind of bug are so common, and so hard to test and occur across so many different tools.. I wonder if we would have made a different choice if we have known how many issues LEB128 would cause.
Wed, Mar 24
Nice!
Tue, Mar 23
Great!
Mar 10 2021
Mar 8 2021
Mar 6 2021
Mar 5 2021
feedback
feedback
add tests
feedback
Rebase against mono-repo
Mar 4 2021
lgtm!
Mar 3 2021
lgtm % comments / nits
Mar 2 2021
Mar 1 2021
I don't have any more objections myself. @sunfish , WDYT of this addition? My feeling is that if it helps swift then its probably worth adding.
Feb 28 2021
cleanup
cleanup
Feb 26 2021
Feb 23 2021
Mostly lgtm. Just a few nits at this point.
Feb 18 2021
Feb 17 2021
lgtm with a test for the new error(s).
Emscripten test suite passes. lgtm.
I'm trying to think how this could effect either wasi-sdk or emscripten and I can't think of any ways.. but I will run the emscripten test suite with this change just in case.
Assuming all the tests pass this lgtm!
No thats fine. I was just making sure we wouldn't break an existing test..
Is there no test that includes this encoding?
Feb 16 2021
Does this mean the --relocatable always produces output with an entry in the symbol table for __indirect_function_table? i.e. does the linker always produce non-MVP object files?
Feb 14 2021
Is the "pc-rel" in the title a little misleading? How about just "relative" or "location relative"?
Feb 12 2021
Nice! I like this much better now. Thanks for making all those changes.
Feb 11 2021
we when we comes to assigning indexes we do something like this:
Ok so we can see this as an interim thing. I think I'm OK with that. Could you add a comment about that, or at least say why we want to support both the old crt1 and the new crt1-command at the same time (i.e. so that wasi-libc can easily suppot both old and new llvm right?)
Feb 10 2021
Why not just use crt1.o in both cases? If you are going to prefer crt1-command.o in all cases then a toolchain would have no reason to ever ship crt1.o would it? (since it would always be ignored?)
rebase