sbc100 (Sam Clegg)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 10:22 AM (40 w, 2 d)

Recent Activity

Wed, Jun 21

sbc100 retitled D34477: [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC from [WebAssemly] Cleanup WasmObjectWriter.cpp. NFC to [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC.
Wed, Jun 21, 4:45 PM
sbc100 retitled D34486: MC: Fix dumping of MCFragment values from Fix dumping of fill fragment values to MC: Fix dumping of MCFragment values.
Wed, Jun 21, 4:42 PM
sbc100 updated subscribers of D34486: MC: Fix dumping of MCFragment values.
Wed, Jun 21, 4:40 PM
sbc100 updated the summary of D34486: MC: Fix dumping of MCFragment values.
Wed, Jun 21, 4:38 PM
sbc100 updated the diff for D34486: MC: Fix dumping of MCFragment values.

use cast

Wed, Jun 21, 4:37 PM
sbc100 created D34486: MC: Fix dumping of MCFragment values.
Wed, Jun 21, 4:35 PM
sbc100 abandoned D34483: Fix build of SystemZ target after r305963.

Looks like this got fixed in r305967 9

Wed, Jun 21, 4:05 PM
sbc100 added a reviewer for D34483: Fix build of SystemZ target after r305963: dschuff.
Wed, Jun 21, 4:03 PM
sbc100 created D34483: Fix build of SystemZ target after r305963.
Wed, Jun 21, 4:02 PM
sbc100 updated subscribers of D33565: [WebAssembly] Add default -allow-undefined-file to linker args.
Wed, Jun 21, 3:18 PM
sbc100 updated subscribers of D33565: [WebAssembly] Add default -allow-undefined-file to linker args.
Wed, Jun 21, 3:16 PM
sbc100 updated subscribers of D34477: [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC.
Wed, Jun 21, 3:16 PM
sbc100 updated subscribers of D33906: Remove `inline` keyword from inline `classof` methods.
Wed, Jun 21, 3:15 PM
sbc100 added a reviewer for D34481: Mark dump() methods as const. NFC: dschuff.
Wed, Jun 21, 3:11 PM
sbc100 created D34481: Mark dump() methods as const. NFC.
Wed, Jun 21, 3:10 PM
sbc100 updated the summary of D34477: [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC.
Wed, Jun 21, 2:27 PM
sbc100 created D34477: [WebAssembly] Cleanup WasmObjectWriter.cpp. NFC.
Wed, Jun 21, 2:25 PM
sbc100 added a reviewer for D34466: Rename WinCOFFStreamer.cpp -> MCWinCOFFStreamer.cpp: rafael.
Wed, Jun 21, 11:45 AM
sbc100 created D34466: Rename WinCOFFStreamer.cpp -> MCWinCOFFStreamer.cpp.
Wed, Jun 21, 11:42 AM

Tue, Jun 20

sbc100 added a reviewer for D34413: Fix argument numbering in OPTION macro: ruiu.
Tue, Jun 20, 12:15 PM
sbc100 retitled D34413: Fix argument numbering in OPTION macro from Fix argument numbersing in OPTION macro to Fix argument numbering in OPTION macro.
Tue, Jun 20, 12:15 PM
sbc100 created D34413: Fix argument numbering in OPTION macro.
Tue, Jun 20, 12:14 PM
sbc100 added a comment to D33906: Remove `inline` keyword from inline `classof` methods.

ping. This is a mechanical change so should be an easy review.

Tue, Jun 20, 9:21 AM

Mon, Jun 19

sbc100 added a reviewer for D34384: Fix lld build error: sunfish.
Mon, Jun 19, 10:04 PM
sbc100 created D34384: Fix lld build error.
Mon, Jun 19, 10:04 PM
sbc100 added a reviewer for D34382: [WebAssembly] Fix build failures introduced in r305769: sunfish.
Mon, Jun 19, 9:35 PM
sbc100 created D34382: [WebAssembly] Fix build failures introduced in r305769.
Mon, Jun 19, 9:34 PM
sbc100 updated the diff for D34019: [WebAssembly] Add support for weak symbols in the binary format.
  • Explicit constructors
Mon, Jun 19, 9:03 PM
sbc100 added a comment to D33565: [WebAssembly] Add default -allow-undefined-file to linker args.

ptal

Mon, Jun 19, 6:11 PM
sbc100 updated the diff for D33565: [WebAssembly] Add default -allow-undefined-file to linker args.

rebase

Mon, Jun 19, 6:09 PM
sbc100 updated the diff for D34019: [WebAssembly] Add support for weak symbols in the binary format.
  • Reference symbols by name in linking section
Mon, Jun 19, 5:55 PM

Thu, Jun 15

sbc100 added a comment to D33906: Remove `inline` keyword from inline `classof` methods.

ping?

Thu, Jun 15, 10:30 AM

Wed, Jun 14

sbc100 updated the summary of D34019: [WebAssembly] Add support for weak symbols in the binary format.
Wed, Jun 14, 10:25 AM

Tue, Jun 13

sbc100 updated the summary of D33565: [WebAssembly] Add default -allow-undefined-file to linker args.
Tue, Jun 13, 6:14 PM
sbc100 updated the summary of D33565: [WebAssembly] Add default -allow-undefined-file to linker args.
Tue, Jun 13, 6:14 PM
sbc100 updated the diff for D33565: [WebAssembly] Add default -allow-undefined-file to linker args.

don't add syms file with -nostdlib

Tue, Jun 13, 6:13 PM
sbc100 updated the diff for D33565: [WebAssembly] Add default -allow-undefined-file to linker args.

rebase

Tue, Jun 13, 6:10 PM
sbc100 updated the summary of D34172: [WebAssembly] Use __stack_pointer global when writing wasm binary.
Tue, Jun 13, 3:57 PM
sbc100 updated the diff for D34172: [WebAssembly] Use __stack_pointer global when writing wasm binary.
  • add a explict test in test/MC/WebAssembly
Tue, Jun 13, 3:02 PM
sbc100 updated the diff for D34172: [WebAssembly] Use __stack_pointer global when writing wasm binary.

revert part

Tue, Jun 13, 2:44 PM
sbc100 added inline comments to D34044: [WebAssembly] WebAssemblyFastISel getelementptr variable index support.
Tue, Jun 13, 2:36 PM
sbc100 added a comment to D34172: [WebAssembly] Use __stack_pointer global when writing wasm binary.

If you like I could probably split out the part of this change that is generally adding support for R_WEBASSEMBLY_GLOBAL_INDEX_LEB.

Tue, Jun 13, 2:27 PM
sbc100 added a reviewer for D34172: [WebAssembly] Use __stack_pointer global when writing wasm binary: sunfish.
Tue, Jun 13, 2:25 PM
sbc100 updated the diff for D34019: [WebAssembly] Add support for weak symbols in the binary format.

Rebase

Tue, Jun 13, 2:13 PM
sbc100 created D34172: [WebAssembly] Use __stack_pointer global when writing wasm binary.
Tue, Jun 13, 2:11 PM

Mon, Jun 12

sbc100 added reviewers for D34131: [WebAssembly] Cleanup WebAssemblyWasmObjectWriter: jgravelle-google, sunfish.
Mon, Jun 12, 7:01 PM
sbc100 updated the diff for D34131: [WebAssembly] Cleanup WebAssemblyWasmObjectWriter.

Add assert

Mon, Jun 12, 6:56 PM
sbc100 created D34131: [WebAssembly] Cleanup WebAssemblyWasmObjectWriter.
Mon, Jun 12, 6:53 PM
sbc100 added a comment to D34128: Add llvm-pdbutil tool_patterns in lit.cfg.

I noticed this when debugging the recent pdb-none.test test failures.

Mon, Jun 12, 6:12 PM
sbc100 added a reviewer for D34128: Add llvm-pdbutil tool_patterns in lit.cfg: zturner.
Mon, Jun 12, 6:09 PM
sbc100 updated the diff for D34128: Add llvm-pdbutil tool_patterns in lit.cfg.

sort

Mon, Jun 12, 6:09 PM
sbc100 created D34128: Add llvm-pdbutil tool_patterns in lit.cfg.
Mon, Jun 12, 6:08 PM
sbc100 abandoned D34125: Fix pdb-none.test expectaions for output of pdbutil.

sgtm

Mon, Jun 12, 5:58 PM
sbc100 added a comment to D34125: Fix pdb-none.test expectaions for output of pdbutil.

I see you already fixed the failure in r305260 but thought maybe this fix might still be desirable?

Mon, Jun 12, 5:48 PM
sbc100 added a reviewer for D34125: Fix pdb-none.test expectaions for output of pdbutil: zturner.
Mon, Jun 12, 5:48 PM
sbc100 created D34125: Fix pdb-none.test expectaions for output of pdbutil.
Mon, Jun 12, 5:47 PM
sbc100 added a comment to D34008: obj2yaml: Improve error reporting.

Yes, I think there is lager change to made here. For example ELFObjectFile from libObject still doesn't report Error's. However I think this change stands alone as a useful fix and we can follewup with others.

Mon, Jun 12, 4:59 PM
sbc100 updated the diff for D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
  • revert change to symbol printing
Mon, Jun 12, 4:26 PM
sbc100 added inline comments to D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
Mon, Jun 12, 4:21 PM

Fri, Jun 9

sbc100 added a reviewer for D34068: [WebAssembly] Fix symbol type for addresses of external functions: jgravelle-google.
Fri, Jun 9, 3:53 PM
sbc100 added a reviewer for D34068: [WebAssembly] Fix symbol type for addresses of external functions: sunfish.
Fri, Jun 9, 3:51 PM
sbc100 created D34068: [WebAssembly] Fix symbol type for addresses of external functions.
Fri, Jun 9, 3:51 PM
sbc100 added a comment to D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.

@sunfish, could you that a look? I think this should be fairly non-controversial.

Fri, Jun 9, 11:00 AM
sbc100 updated the diff for D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
  • remove extra newline
Fri, Jun 9, 10:59 AM
sbc100 updated the diff for D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
  • Merge remote-tracking branch 'origin/master' into fix_table_index_reloc
  • Merge remote-tracking branch 'origin/master' into fix_table_index_reloc
  • Merge remote-tracking branch 'origin/master' into fix_table_index_reloc
  • Merge remote-tracking branch 'origin/master' into fix_table_index_reloc
  • update comments
Fri, Jun 9, 10:57 AM

Wed, Jun 7

sbc100 created D34019: [WebAssembly] Add support for weak symbols in the binary format.
Wed, Jun 7, 5:19 PM
sbc100 updated the diff for D34008: obj2yaml: Improve error reporting.
  • update tests
Wed, Jun 7, 3:00 PM
sbc100 updated the summary of D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
Wed, Jun 7, 2:40 PM
sbc100 added a comment to D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.

ping?

Wed, Jun 7, 2:40 PM
sbc100 added a reviewer for D34008: obj2yaml: Improve error reporting: davide.
Wed, Jun 7, 12:38 PM
sbc100 created D34008: obj2yaml: Improve error reporting.
Wed, Jun 7, 12:37 PM
sbc100 added a comment to D34004: Add BinaryFormat to library list for lldCore.

I'm not sure why this didn't break any of the LLD bots. Is it because they don't build with BUILD_SHARED_LIBS perhaps?

Wed, Jun 7, 11:05 AM
sbc100 updated the diff for D34004: Add BinaryFormat to library list for lldCore.

add to other libs too

Wed, Jun 7, 11:04 AM
sbc100 updated the diff for D34004: Add BinaryFormat to library list for lldCore.

sort

Wed, Jun 7, 11:00 AM
sbc100 added a reviewer for D34004: Add BinaryFormat to library list for lldCore: zturner.
Wed, Jun 7, 10:59 AM
sbc100 created D34004: Add BinaryFormat to library list for lldCore.
Wed, Jun 7, 10:59 AM

Tue, Jun 6

sbc100 updated the diff for D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
  • check for elem section
Tue, Jun 6, 3:04 PM
sbc100 updated the diff for D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
  • spelling fix
Tue, Jun 6, 3:00 PM
sbc100 updated the summary of D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
Tue, Jun 6, 2:59 PM
sbc100 updated the diff for D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
  • revert part
Tue, Jun 6, 2:59 PM
sbc100 updated the diff for D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.

Add comments

Tue, Jun 6, 2:55 PM
sbc100 created D33962: [WebAssembly] MC: Fix value of R_WEBASSEMBLY_TABLE_INDEX relocations.
Tue, Jun 6, 2:52 PM
sbc100 added a comment to D33918: [WebAssembly] MC: Refactor relocation handling.

@sunfish could you take a quick look?

Tue, Jun 6, 9:46 AM

Mon, Jun 5

sbc100 updated the summary of D33905: [WebAssembly] Remove unused methods from MCWasmObjectTargetWriter.
Mon, Jun 5, 5:43 PM
sbc100 updated the diff for D33905: [WebAssembly] Remove unused methods from MCWasmObjectTargetWriter.
  • move relocation entry decl
Mon, Jun 5, 5:42 PM
sbc100 updated the diff for D33905: [WebAssembly] Remove unused methods from MCWasmObjectTargetWriter.

revert move

Mon, Jun 5, 5:41 PM
sbc100 updated the diff for D33905: [WebAssembly] Remove unused methods from MCWasmObjectTargetWriter.
  • Merge remote-tracking branch 'origin/master' into remove_used_methods
  • move relocation entry decl
Mon, Jun 5, 5:40 PM
sbc100 added inline comments to D33918: [WebAssembly] MC: Refactor relocation handling.
Mon, Jun 5, 5:35 PM
sbc100 updated the diff for D33918: [WebAssembly] MC: Refactor relocation handling.
  • create hasAddend
Mon, Jun 5, 5:35 PM
sbc100 updated the diff for D33918: [WebAssembly] MC: Refactor relocation handling.
  • remove newline
Mon, Jun 5, 4:29 PM
sbc100 updated the diff for D33918: [WebAssembly] MC: Refactor relocation handling.

Add reset method

Mon, Jun 5, 4:26 PM
sbc100 updated the summary of D33918: [WebAssembly] MC: Refactor relocation handling.
Mon, Jun 5, 4:21 PM
sbc100 created D33918: [WebAssembly] MC: Refactor relocation handling.
Mon, Jun 5, 4:19 PM
sbc100 added a reviewer for D33906: Remove `inline` keyword from inline `classof` methods: davide.
Mon, Jun 5, 12:08 PM
sbc100 created D33906: Remove `inline` keyword from inline `classof` methods.
Mon, Jun 5, 12:07 PM
sbc100 added a reviewer for D33905: [WebAssembly] Remove unused methods from MCWasmObjectTargetWriter: sunfish.
Mon, Jun 5, 11:55 AM
sbc100 updated the summary of D33905: [WebAssembly] Remove unused methods from MCWasmObjectTargetWriter.
Mon, Jun 5, 11:55 AM
sbc100 created D33905: [WebAssembly] Remove unused methods from MCWasmObjectTargetWriter.
Mon, Jun 5, 11:53 AM

Thu, Jun 1

sbc100 accepted D33811: Revert r304117 - WebAssembly object format isn't ready to be the default.
Thu, Jun 1, 5:16 PM
sbc100 added a comment to D33811: Revert r304117 - WebAssembly object format isn't ready to be the default.

lgtm.

Thu, Jun 1, 5:15 PM