- User Since
- Sep 16 2016, 10:22 AM (74 w, 6 d)
Sorry I didn't see this earlier. Looks good but will need rebase since the symtab change langed.
I fixed the DefinedData constructor args. The rest we can follow up with. Thanks for all the reviewing!
- remove default args
- Simplify address calculations for data symbols
wabt change is ready to go: https://github.com/WebAssembly/wabt/pull/769
Wed, Feb 21
- fix typos in comment
Is my rational correct here? Based on your feedback from my other change it seems like this should be preferred?
- add Symbol::isLive()
Tue, Feb 20
Hmm.. actually this is probably going to break the waterfall pretty badly. But maybe we can fix it by re-disabling this explicitly when we build the gcc tests.
Might want to line wrap your change description.
- revert parts
- Don't use InputChunk to model globals
This is going to conflict pretty badly with https://reviews.llvm.org/D43496... which are we going to land first? :)
Mon, Feb 19
- make static
This is much better. Thank you. I particularly like the elimination of that random struct.
This doesn't seem strictly better to me. Seems like it only increases the complexity and the indentations of the code, and while decreasing re-usability. Is there a specific benefit? Shouldn't we prefer shorter and less nested functions?
I was considering doing that myself, and managed to persuade myself it was more readable with the lamda since it makes the loop itself self-documenting and really easy to read. But I can see that single use lambda are probably not a good pattern and that a commit is probably just as good. BTW, do you now if there is any runtime different between these two (given a decent compiler)?
Can you put [WebAssembly] at the start of the change title?
Fri, Feb 16
Why not change wasm at the same time?
I noticed we don't have a test for this case.. would you mind adding one ?
It also didn't feel right to have InputGlobal to inherit from InputChunk. For me the Chunks are really for the non-synthetic sections. That is the ones construct using memory copied from the input files + relocations.