- User Since
- Sep 16 2016, 10:22 AM (117 w, 4 d)
Fri, Dec 14
Wed, Dec 12
- update test
Mon, Dec 10
Fri, Dec 7
Reopening as the alternative solution had issues.
Thu, Dec 6
This change is looking nice!
Attempted fix in https://reviews.llvm.org/D55381
We are seeing a failure of YAMLWritesNoTBESyms on the WebAssembly waterfall due to this change:
lgtm % comment
Since event types can't have return values (they are always no_return right?) should we split out "parseParamList" and have them look like this?
There is a presensent for the "emit" functions in the streamer modifying symbols. For example:
Wed, Dec 5
Tue, Dec 4
IIUC this change is NFC so you can mark it as such in the title?
Mon, Dec 3
Should the first word of the description be WasmSymbol
Fri, Nov 30
Wed, Nov 28
Tue, Nov 27
lgtm % nits and the question of whether we leave SigIndex as part of the EventType in wasm.h.
For reference there was a previous CL that tries to do something similar: https://reviews.llvm.org/D44024.
Mon, Nov 26
Tue, Nov 20
I general I think this is good change. I think there will always be point in the abstraction where we start prefering "spec" terms over "llvm" terms.
Mon, Nov 19
Yes, this should have no effect unless we are compiling with -fPIC and have non-DSO-local symbols.
Hmm, I guess at some point in the past InputFunctions and InputGlobals were not empty at the start of this function.
I'm not sure how you created this change, but I think using statements are like IWYU in that you don't want remove any line that can be removed and have the file still compile. i.e. you don't want to rely on recursively included using statements.
Nov 17 2018
Nov 16 2018
get parts of address-offsets.ll passing
Nice! I wish we could do with without the lexer change and with a more asm-linux syntax.. but I guess that time for bikeshedding that is over.
@dschuff can you take a look at the WebAssemblyFastISel.cpp part? I want to make sure I'm on the right track.
Nov 15 2018
Nov 14 2018
The diff algorithms seem to make a right mess of this, but this change basically splits out setConfigs and checkOptions and nothing more