- User Since
- Feb 2 2020, 12:55 PM (66 w, 4 d)
Thu, Apr 22
Wed, Apr 21
We should use the original source form of the string literal when pretty-printing a StringLiteral or CharacterLiteral; there are a bunch of UTF-8 assumptions baked into StmtPrinter that will need revisiting. And we'll need to modify the handful of places that put the contents of StringLiterals into diagnostics (#warning, #error, static_assert) and make them use a different ConversionState, since our assumption is that diagnostic output should be in UTF-8.
Yes, these are some of the complications we will need to visit in later patches. We may need to somehow save the original string or reverse the translation.
Apr 6 2021
Treating a namespace-std function template as a builtin isn't entirely novel; we already do this for MSVC's std::_GetExceptionInfo (though we don't actually handle that properly: we're missing the "namespace std" check, at least). Treating the builtin definition as overriding an inline library definition might be novel, though that doesn't seem like a huge problem.