Page MenuHomePhabricator

cor3ntin (Corentin Jabot)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2020, 12:55 PM (66 w, 4 d)

Recent Activity

Thu, Apr 22

cor3ntin added a comment to D93031: Enable fexec-charset option .

"Keeping the original spelling around" would assume that the input is not using a stateful encoding. That seems worse as assumption than giving the canonical output in UTF-8 and shifting the problem to the user's editor?

Thu, Apr 22, 12:22 AM · Restricted Project, Restricted Project

Wed, Apr 21

cor3ntin added a comment to D93031: Enable fexec-charset option .

We should use the original source form of the string literal when pretty-printing a StringLiteral or CharacterLiteral; there are a bunch of UTF-8 assumptions baked into StmtPrinter that will need revisiting. And we'll need to modify the handful of places that put the contents of StringLiterals into diagnostics (#warning, #error, static_assert) and make them use a different ConversionState, since our assumption is that diagnostic output should be in UTF-8.

Yes, these are some of the complications we will need to visit in later patches. We may need to somehow save the original string or reverse the translation.

Wed, Apr 21, 3:00 PM · Restricted Project, Restricted Project

Apr 6 2021

cor3ntin added a comment to D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema.

Our builtin logic is capable of recognizing user declarations as builtins without any sort of explicit annotation in source. That's how we recognize C library builtins, for example. As Richard points out, that logic isn't really set up to do the right thing for namespaced declarations (or template ones, for that matter), but that seems fixable.

The namespace issue might be annoying because of the inline namespaces that some standard libraries used for ABI versioning.

Apr 6 2021, 2:40 PM · Restricted Project
cor3ntin added a comment to D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema.

Treating a namespace-std function template as a builtin isn't entirely novel; we already do this for MSVC's std::_GetExceptionInfo (though we don't actually handle that properly: we're missing the "namespace std" check, at least). Treating the builtin definition as overriding an inline library definition might be novel, though that doesn't seem like a huge problem.

Apr 6 2021, 1:58 AM · Restricted Project

Apr 5 2021

cor3ntin accepted D99895: [libc++] Implement D2351R0 "Mark all library static cast wrappers as [[nodiscard]]".
Apr 5 2021, 12:52 PM · Restricted Project
cor3ntin retitled D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema from [WIP] Replace std::forward & std::move by cast expression to [WIP] Replace std::forward & std::move by cast expressions during Sema.
Apr 5 2021, 11:59 AM · Restricted Project
cor3ntin requested review of D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema.
Apr 5 2021, 11:27 AM · Restricted Project

Feb 2 2020

cor3ntin created D73855: Protect <span> against mim/max macro.
Feb 2 2020, 1:25 PM · Restricted Project