Page MenuHomePhabricator

djtodoro (Djordje Todorovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2017, 6:53 AM (70 w, 23 h)

Recent Activity

Yesterday

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase
-Update tests

Thu, Apr 18, 6:24 AM · debug-info
djtodoro added a child revision for D58042: [LiveDebugValues] Emit parameter's entry value: D58043: Add experimental options for call site related dbg info.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro added a parent revision for D58043: Add experimental options for call site related dbg info: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro added a parent revision for D58042: [LiveDebugValues] Emit parameter's entry value: D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro added a child revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:23 AM · debug-info
djtodoro removed a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:21 AM · debug-info
djtodoro removed a child revision for D58042: [LiveDebugValues] Emit parameter's entry value: D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, Apr 18, 6:21 AM · debug-info
djtodoro edited child revisions for D60715: [ISEL] Collect argument's forwarding regs when lowering calls, added: 1; removed: 1.
Thu, Apr 18, 6:20 AM · debug-info
djtodoro removed a parent revision for D58042: [LiveDebugValues] Emit parameter's entry value: D60715: [ISEL] Collect argument's forwarding regs when lowering calls.
Thu, Apr 18, 6:20 AM · debug-info
djtodoro added a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D60715: [ISEL] Collect argument's forwarding regs when lowering calls.
Thu, Apr 18, 6:20 AM · debug-info
djtodoro edited child revisions for D58042: [LiveDebugValues] Emit parameter's entry value, added: 1; removed: 1.
Thu, Apr 18, 6:16 AM · debug-info
djtodoro added a parent revision for D60866: [DWARF] Handle DW_OP_entry_value operand: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:16 AM · debug-info
djtodoro removed a parent revision for D58043: Add experimental options for call site related dbg info: D58042: [LiveDebugValues] Emit parameter's entry value.
Thu, Apr 18, 6:16 AM · debug-info
djtodoro created D60866: [DWARF] Handle DW_OP_entry_value operand.
Thu, Apr 18, 6:15 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Use DW_OP_entry_value from DWARF 5
-Split up introduction and production of entry values

Thu, Apr 18, 6:15 AM · debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.
Thu, Apr 18, 2:15 AM · debug-info

Wed, Apr 17

djtodoro updated the diff for D58043: Add experimental options for call site related dbg info.

-Rebase

Wed, Apr 17, 8:02 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Fix comments

Wed, Apr 17, 7:55 AM · debug-info
djtodoro updated the diff for D58043: Add experimental options for call site related dbg info.

-Rebase

Wed, Apr 17, 7:42 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Refactor
-Remove CC1 def

Wed, Apr 17, 7:35 AM · debug-info
djtodoro added a comment to D58033: Add option for emitting dbg info for call site parameters.

@probinson @aprantl Thanks a lot for your comments!

Wed, Apr 17, 7:32 AM · debug-info
djtodoro added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
Wed, Apr 17, 3:33 AM · debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Format
-Support DWARF 5 as well

Wed, Apr 17, 3:13 AM
djtodoro added inline comments to D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Wed, Apr 17, 3:10 AM

Tue, Apr 16

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Minor refactor

Tue, Apr 16, 5:49 AM · debug-info
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Run clang-format
-Use cast instead of 'dyn_cast'

Tue, Apr 16, 5:49 AM · debug-info
djtodoro added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Tue, Apr 16, 5:42 AM · debug-info
djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Tue, Apr 16, 12:04 AM · debug-info

Mon, Apr 15

djtodoro added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 15, 11:44 PM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

Thanks!

Mon, Apr 15, 11:44 PM · debug-info
djtodoro added a reviewer for D60716: [DwarfDebug] Dump call site debug info into DWARF: qcolombet.
Mon, Apr 15, 9:01 AM · debug-info
djtodoro added reviewers for D60715: [ISEL] Collect argument's forwarding regs when lowering calls: llvm-commits, probinson, vsk, qcolombet.
Mon, Apr 15, 9:00 AM · debug-info
djtodoro added reviewers for D60713: [IR] Add DISuprogram and DIE for func decl of an external: llvm-commits, aprantl, probinson, vsk.
Mon, Apr 15, 9:00 AM · debug-info
djtodoro added reviewers for D60712: [DWARF] Add GNU extensions for call site info DWARF symbols: llvm-commits, aprantl, probinson, vsk.
Mon, Apr 15, 9:00 AM · debug-info
djtodoro removed a parent revision for D58044: [DwarfDebug] Dump call site debug info into DWARF: D58043: Add experimental options for call site related dbg info.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro created D60716: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro edited child revisions for D58043: Add experimental options for call site related dbg info, added: 1; removed: 1.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro added a parent revision for D60716: [DwarfDebug] Dump call site debug info into DWARF: D58043: Add experimental options for call site related dbg info.
Mon, Apr 15, 8:58 AM · debug-info
djtodoro updated the diff for D58043: Add experimental options for call site related dbg info.
Mon, Apr 15, 8:53 AM · debug-info
djtodoro edited parent revisions for D58042: [LiveDebugValues] Emit parameter's entry value, added: 1; removed: 1.
Mon, Apr 15, 8:50 AM · debug-info
djtodoro added a child revision for D60715: [ISEL] Collect argument's forwarding regs when lowering calls: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Apr 15, 8:50 AM · debug-info
djtodoro removed a child revision for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Apr 15, 8:50 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase
-Follow-up with the new approach

Mon, Apr 15, 8:50 AM · debug-info
djtodoro added a child revision for D60714: [clang] Add DISuprogram and DIE for func decl of an external : D60715: [ISEL] Collect argument's forwarding regs when lowering calls.
Mon, Apr 15, 8:49 AM
djtodoro added a parent revision for D60715: [ISEL] Collect argument's forwarding regs when lowering calls: D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Mon, Apr 15, 8:49 AM · debug-info
djtodoro created D60715: [ISEL] Collect argument's forwarding regs when lowering calls.
Mon, Apr 15, 8:49 AM · debug-info
djtodoro added a child revision for D60713: [IR] Add DISuprogram and DIE for func decl of an external: D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Mon, Apr 15, 8:43 AM · debug-info
djtodoro added a parent revision for D60714: [clang] Add DISuprogram and DIE for func decl of an external : D60713: [IR] Add DISuprogram and DIE for func decl of an external.
Mon, Apr 15, 8:43 AM
djtodoro created D60714: [clang] Add DISuprogram and DIE for func decl of an external .
Mon, Apr 15, 8:43 AM
djtodoro edited child revisions for D58035: [clang/DIVar] Emit flag for params that have unchanged values, added: 1; removed: 1.
Mon, Apr 15, 8:36 AM · debug-info
djtodoro added a parent revision for D60713: [IR] Add DISuprogram and DIE for func decl of an external: D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, Apr 15, 8:36 AM · debug-info
djtodoro removed a parent revision for D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata: D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, Apr 15, 8:36 AM · debug-info
djtodoro created D60713: [IR] Add DISuprogram and DIE for func decl of an external.
Mon, Apr 15, 8:35 AM · debug-info
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Rebase
-Use ExprMutationAnalyzer for parameter's modification check

Mon, Apr 15, 8:31 AM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.

-Rebase
-Add setIsNotModified()

Mon, Apr 15, 8:31 AM · debug-info
djtodoro edited parent revisions for D58033: Add option for emitting dbg info for call site parameters, added: 1; removed: 1.
Mon, Apr 15, 8:29 AM · debug-info
djtodoro added a child revision for D60712: [DWARF] Add GNU extensions for call site info DWARF symbols: D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 15, 8:29 AM · debug-info
djtodoro removed a child revision for D58032: [Metadata] Introduce call site dbg info metadata: D58033: Add option for emitting dbg info for call site parameters.
Mon, Apr 15, 8:29 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Rebase
-Add all_call_sites flag in the case of GNU extensions

Mon, Apr 15, 8:26 AM · debug-info
djtodoro created D60712: [DWARF] Add GNU extensions for call site info DWARF symbols.
Mon, Apr 15, 8:20 AM · debug-info
djtodoro abandoned D58046: [VirtRegMap] Salvage DBG_CALLSITEPARAM identities.
Mon, Apr 15, 8:15 AM · debug-info
djtodoro abandoned D58044: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Apr 15, 8:15 AM · debug-info
djtodoro abandoned D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs.
Mon, Apr 15, 8:15 AM · debug-info
djtodoro abandoned D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Mon, Apr 15, 8:15 AM · debug-info
djtodoro abandoned D58039: [IR] Handle dbg call site through the middle-end pipeline.
Mon, Apr 15, 8:15 AM
djtodoro abandoned D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata.
Mon, Apr 15, 8:15 AM · debug-info
djtodoro abandoned D58038: Emit DICallSite and DICallSiteParam metadata.
Mon, Apr 15, 8:15 AM · debug-info
djtodoro abandoned D58032: [Metadata] Introduce call site dbg info metadata.
Mon, Apr 15, 8:06 AM · debug-info

Mar 19 2019

djtodoro updated the diff for D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

-Rebase

Mar 19 2019, 4:02 AM · Restricted Project

Mar 18 2019

djtodoro updated the diff for D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

-Refactor upgrade metadata functionality

Mar 18 2019, 2:53 AM · Restricted Project

Mar 15 2019

djtodoro added a comment to D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

IIUC this upgrade is sweeping the variant of DISubprograms that have SPflags and do not yet have this patch under the rug? The way the Swift compiler branches work out I can live with that but other downstream users may have a problem with that as it could break LTO builds that include object files versions of clang between 347239 and this patch.

Mar 15 2019, 10:47 AM · Restricted Project
djtodoro updated the diff for D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.
  • Add support in Metadataloader for older metadata
  • Add bitcode upgrade test
Mar 15 2019, 8:59 AM · Restricted Project
djtodoro added a comment to D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

Thanks for the comment! I understand.

Mar 15 2019, 8:59 AM · Restricted Project

Mar 14 2019

djtodoro added a comment to D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

Yes. Can you please add upgrade functionality into MetadataLoader and add a bitcode upgrade test into test/Bitcode?
You can look at llvm/test/Bitcode/DISubprogram-v4.ll and llvm/test/Bitcode/DISubprogram-v4.ll.bc as an example.

@aprantl In addition to this, I guess we want support for this in LLParser as well?

Mar 14 2019, 8:24 AM · Restricted Project
djtodoro added a comment to D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.

Thank you all for comments!

Mar 14 2019, 12:39 AM · Restricted Project

Mar 13 2019

djtodoro added a reviewer for D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags: vsk.
Mar 13 2019, 9:04 AM · Restricted Project
djtodoro created D59288: [DebugInfoMetadata] Move main subprogram DIFlag into DISPFlags.
Mar 13 2019, 2:19 AM · Restricted Project

Mar 7 2019

djtodoro updated the diff for D58894: [analyzer] Handle modification of vars inside an expr with comma operator.

-add support for the rest of direct mutation cases

Mar 7 2019, 1:01 AM · Restricted Project
djtodoro added a comment to D58894: [analyzer] Handle modification of vars inside an expr with comma operator.

Anyways, this looks good in this state.
Thank you for working on this!

Mar 7 2019, 12:58 AM · Restricted Project

Mar 6 2019

djtodoro added inline comments to D58894: [analyzer] Handle modification of vars inside an expr with comma operator.
Mar 6 2019, 4:06 AM · Restricted Project
djtodoro added a comment to D58894: [analyzer] Handle modification of vars inside an expr with comma operator.

Nice, i like this!
I think the test coverage is good.

@lebedev.ri Thanks!

Mar 6 2019, 2:40 AM · Restricted Project
djtodoro added a comment to D58894: [analyzer] Handle modification of vars inside an expr with comma operator.

@lebedev.ri I agree, thank you! I needed to be more precise in my previous reply, sorry for that. I thought it will be (somehow) overhead if I change existing, very basic, matchers.

I indeed don't think the existing matchers should be changed to ignore these , ops (or implicit casts, like some issue reports propose).

I already implemented a static function that skips comma operands, and extended this to support member calls, functions, etc.
But, implementing it as a new matcher sounds like better idea.

Mar 6 2019, 2:12 AM · Restricted Project
djtodoro updated the diff for D58894: [analyzer] Handle modification of vars inside an expr with comma operator.

-add AST matcher that skips operands in comma expression
-add unit tests for extended support

Mar 6 2019, 2:10 AM · Restricted Project

Mar 5 2019

djtodoro added a comment to D58894: [analyzer] Handle modification of vars inside an expr with comma operator.

@lebedev.ri I agree, thank you! I needed to be more precise in my previous reply, sorry for that. I thought it will be (somehow) overhead if I change existing, very basic, matchers.

Mar 5 2019, 4:44 AM · Restricted Project

Mar 4 2019

djtodoro updated subscribers of D58894: [analyzer] Handle modification of vars inside an expr with comma operator.
Mar 4 2019, 1:06 AM · Restricted Project
djtodoro added a comment to D58894: [analyzer] Handle modification of vars inside an expr with comma operator.

@lebedev.ri Thanks for your comment!

Mar 4 2019, 1:05 AM · Restricted Project

Mar 3 2019

djtodoro created D58894: [analyzer] Handle modification of vars inside an expr with comma operator.
Mar 3 2019, 11:43 PM · Restricted Project

Feb 26 2019

djtodoro added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Feb 26 2019, 7:12 AM · debug-info

Feb 25 2019

djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.
  • Handle all kinds of expressions when mark a param's modification
Feb 25 2019, 2:40 AM · debug-info
djtodoro added a comment to D58035: [clang/DIVar] Emit flag for params that have unchanged values.

I'm not quite sure what this differential is about, but i feel like mentioning ExprMutationAnalyzer lib in clang-tidy / clang-tools-extra.

Feb 25 2019, 2:24 AM · debug-info

Feb 22 2019

djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.
  • Add a field in ParmVarDecl instead of VarDecl
  • Use a bit in ParmVarDeclBitfields to indicate parameter modification
  • Add support for the bit in ASTReaderDecl.cpp / ASTWriterDecl.cpp
  • Add test case for templates
Feb 22 2019, 6:31 AM · debug-info
djtodoro added a comment to D58035: [clang/DIVar] Emit flag for params that have unchanged values.

@riccibruno Thanks for your comments!

Feb 22 2019, 6:27 AM · debug-info
djtodoro added a comment to D58035: [clang/DIVar] Emit flag for params that have unchanged values.

I was under the impression that space inside VarDecl was quite constrained. Pardon the likely naive question, but: is there any way to make the representation more compact (maybe sneak a bit into ParmVarDeclBitfields)?

@vsk Thanks for the comment! Sure, it is better idea. Initially, we thought this could be used even for local variables, but since we are using it only for parameters it makes more sense.

Feb 22 2019, 6:22 AM · debug-info
djtodoro added inline comments to D58044: [DwarfDebug] Dump call site debug info into DWARF.
Feb 22 2019, 1:07 AM · debug-info

Feb 19 2019

djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Feb 19 2019, 12:15 AM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.
  • Adjust documentation
Feb 19 2019, 12:05 AM · debug-info

Feb 17 2019

djtodoro updated the diff for D58044: [DwarfDebug] Dump call site debug info into DWARF.
  • Change a comment for isDescribedByReg()
  • Remove a dead code
Feb 17 2019, 10:45 PM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.
  • Use isEntryValue() from DIExpression
Feb 17 2019, 10:45 PM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

@aprantl I just updated the diff with documentation. Please let me know what do you think.

Feb 17 2019, 10:40 PM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.
  • Add documentation for the flag
Feb 17 2019, 10:36 PM · debug-info