Page MenuHomePhabricator

djtodoro (Djordje Todorovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2017, 6:53 AM (62 w, 1 d)

Recent Activity

Yesterday

djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.
  • Add a field in ParmVarDecl instead of VarDecl
  • Use a bit in ParmVarDeclBitfields to indicate parameter modification
  • Add support for the bit in ASTReaderDecl.cpp / ASTWriterDecl.cpp
  • Add test case for templates
Fri, Feb 22, 6:31 AM · debug-info
djtodoro added a comment to D58035: [clang/DIVar] Emit flag for params that have unchanged values.

@riccibruno Thanks for your comments!

Fri, Feb 22, 6:27 AM · debug-info
djtodoro added a comment to D58035: [clang/DIVar] Emit flag for params that have unchanged values.

I was under the impression that space inside VarDecl was quite constrained. Pardon the likely naive question, but: is there any way to make the representation more compact (maybe sneak a bit into ParmVarDeclBitfields)?

@vsk Thanks for the comment! Sure, it is better idea. Initially, we thought this could be used even for local variables, but since we are using it only for parameters it makes more sense.

Fri, Feb 22, 6:22 AM · debug-info
djtodoro added inline comments to D58044: [DwarfDebug] Dump call site debug info into DWARF.
Fri, Feb 22, 1:07 AM · debug-info

Tue, Feb 19

djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Tue, Feb 19, 12:15 AM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.
  • Adjust documentation
Tue, Feb 19, 12:05 AM · debug-info

Sun, Feb 17

djtodoro updated the diff for D58044: [DwarfDebug] Dump call site debug info into DWARF.
  • Change a comment for isDescribedByReg()
  • Remove a dead code
Sun, Feb 17, 10:45 PM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.
  • Use isEntryValue() from DIExpression
Sun, Feb 17, 10:45 PM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

@aprantl I just updated the diff with documentation. Please let me know what do you think.

Sun, Feb 17, 10:40 PM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.
  • Add documentation for the flag
Sun, Feb 17, 10:36 PM · debug-info

Thu, Feb 14

djtodoro added inline comments to D58044: [DwarfDebug] Dump call site debug info into DWARF.
Thu, Feb 14, 3:42 AM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

LGTM. One last request: Could you please add (either to >the doxygen comment of isArgNotModified or to >LangRef.rst or SourceLevelDebugging.rst) an >explanation of the semantics of the flag. Ie.: What it is >used for and under what conditions a frontend should >generate it?

Thu, Feb 14, 2:50 AM · debug-info

Wed, Feb 13

djtodoro updated the diff for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
  • Use MBB.instrs()
Wed, Feb 13, 4:55 AM · debug-info
djtodoro added a comment to D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.

@dstenb Thanks for comments!

Wed, Feb 13, 4:55 AM · debug-info
djtodoro updated the diff for D58046: [VirtRegMap] Salvage DBG_CALLSITEPARAM identities.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor test cases
Wed, Feb 13, 2:51 AM · debug-info
djtodoro added a comment to D58044: [DwarfDebug] Dump call site debug info into DWARF.

If we wanted to support the DWARF 5 variants are there any semantic differences, or do we just need to rename the attributes?

@aprantl Yes, it will take only DWARF symbols (tag, attributes, operand) renaming.

Wed, Feb 13, 2:51 AM · debug-info
djtodoro updated the diff for D58044: [DwarfDebug] Dump call site debug info into DWARF.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor test cases
Wed, Feb 13, 2:51 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor a test case
Wed, Feb 13, 2:45 AM · debug-info
djtodoro updated the diff for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor test cases
Wed, Feb 13, 2:44 AM · debug-info
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Refactor a test case
Wed, Feb 13, 2:42 AM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.
  • Rename: VariableNotChanged ===> ArgumentNotModified
  • Add test case in test/Assembler/debug-info.ll
Wed, Feb 13, 2:40 AM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

@aprantl I agree. Thanks for the comment!

Wed, Feb 13, 2:36 AM · debug-info

Tue, Feb 12

djtodoro updated the diff for D58044: [DwarfDebug] Dump call site debug info into DWARF.
Tue, Feb 12, 6:42 AM · debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.
Tue, Feb 12, 6:40 AM · debug-info
djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@wolfgangp Thanks a lot for your comments! It has been addressed.

Tue, Feb 12, 6:38 AM · debug-info
djtodoro added a comment to D58034: [IR/DIVar] Add flag for params that have unchanged values.

@aprantl Thanks for your comments!

Tue, Feb 12, 3:00 AM · debug-info

Mon, Feb 11

djtodoro updated the summary of D58032: [Metadata] Introduce call site dbg info metadata.
Mon, Feb 11, 6:05 AM · debug-info
djtodoro updated the summary of D58033: Add option for emitting dbg info for call sites.
Mon, Feb 11, 4:49 AM · debug-info
djtodoro updated the summary of D58038: Emit DICallSite and DICallSiteParam metadata.
Mon, Feb 11, 4:47 AM · debug-info
djtodoro added reviewers for D58046: [VirtRegMap] Salvage DBG_CALLSITEPARAM identities: llvm-commits, aprantl, probinson, vsk.
Mon, Feb 11, 4:27 AM · debug-info
djtodoro added reviewers for D58044: [DwarfDebug] Dump call site debug info into DWARF: llvm-commits, aprantl, vsk, probinson.
Mon, Feb 11, 4:27 AM · debug-info
djtodoro added reviewers for D58043: Add option for emitting DW_OP_entry_values: aprantl, cfe-commits, probinson, vsk.
Mon, Feb 11, 4:26 AM · debug-info
djtodoro added reviewers for D58042: [LiveDebugValues] Emit parameter's entry value: llvm-commits, aprantl, probinson, vsk, wolfgangp.
Mon, Feb 11, 4:25 AM · debug-info
djtodoro added reviewers for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling: llvm-commits, aprantl, probinson, vsk.
Mon, Feb 11, 4:24 AM · debug-info
djtodoro updated subscribers of D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs.
Mon, Feb 11, 4:24 AM · debug-info
djtodoro added reviewers for D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs: llvm-commits, aprantl, probinson, vsk.
Mon, Feb 11, 4:24 AM · debug-info
djtodoro added reviewers for D58038: Emit DICallSite and DICallSiteParam metadata: cfe-commits, aprantl, probinson, vsk.
Mon, Feb 11, 4:24 AM · debug-info
djtodoro edited reviewers for D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata, added: llvm-commits, aprantl, probinson, vsk; removed: deadalnix.
Mon, Feb 11, 4:22 AM · debug-info
djtodoro added reviewers for D58035: [clang/DIVar] Emit flag for params that have unchanged values: cfe-commits, aprantl, probinson, vsk.
Mon, Feb 11, 4:22 AM · debug-info
djtodoro edited reviewers for D58033: Add option for emitting dbg info for call sites, added: cfe-commits; removed: llvm-commits.
Mon, Feb 11, 4:22 AM · debug-info
djtodoro added reviewers for D58034: [IR/DIVar] Add flag for params that have unchanged values: llvm-commits, aprantl, vsk, probinson.
Mon, Feb 11, 4:18 AM · debug-info
djtodoro added reviewers for D58033: Add option for emitting dbg info for call sites: llvm-commits, aprantl, vsk, probinson.
Mon, Feb 11, 4:18 AM · debug-info
djtodoro updated subscribers of D58032: [Metadata] Introduce call site dbg info metadata.
Mon, Feb 11, 4:18 AM · debug-info
djtodoro edited reviewers for D58032: [Metadata] Introduce call site dbg info metadata, added: llvm-commits, aprantl, vsk, probinson; removed: deadalnix.
Mon, Feb 11, 4:16 AM · debug-info
djtodoro updated the summary of D58044: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Feb 11, 4:15 AM · debug-info
djtodoro added a parent revision for D58046: [VirtRegMap] Salvage DBG_CALLSITEPARAM identities: D58044: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Feb 11, 4:15 AM · debug-info
djtodoro added a child revision for D58044: [DwarfDebug] Dump call site debug info into DWARF: D58046: [VirtRegMap] Salvage DBG_CALLSITEPARAM identities.
Mon, Feb 11, 4:15 AM · debug-info
djtodoro created D58046: [VirtRegMap] Salvage DBG_CALLSITEPARAM identities.
Mon, Feb 11, 4:15 AM · debug-info
djtodoro created D58044: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Feb 11, 4:01 AM · debug-info
djtodoro added a child revision for D58043: Add option for emitting DW_OP_entry_values: D58044: [DwarfDebug] Dump call site debug info into DWARF.
Mon, Feb 11, 4:01 AM · debug-info
djtodoro added a parent revision for D58044: [DwarfDebug] Dump call site debug info into DWARF: D58043: Add option for emitting DW_OP_entry_values.
Mon, Feb 11, 4:01 AM · debug-info
djtodoro added a parent revision for D58043: Add option for emitting DW_OP_entry_values: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Feb 11, 3:57 AM · debug-info
djtodoro added a child revision for D58042: [LiveDebugValues] Emit parameter's entry value: D58043: Add option for emitting DW_OP_entry_values.
Mon, Feb 11, 3:57 AM · debug-info
djtodoro created D58043: Add option for emitting DW_OP_entry_values.
Mon, Feb 11, 3:57 AM · debug-info
djtodoro updated the summary of D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs.
Mon, Feb 11, 3:52 AM · debug-info
djtodoro added a parent revision for D58042: [LiveDebugValues] Emit parameter's entry value: D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Mon, Feb 11, 3:51 AM · debug-info
djtodoro added a child revision for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling: D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Feb 11, 3:51 AM · debug-info
djtodoro created D58042: [LiveDebugValues] Emit parameter's entry value.
Mon, Feb 11, 3:50 AM · debug-info
djtodoro created D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Mon, Feb 11, 3:47 AM · debug-info
djtodoro added a parent revision for D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling: D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs.
Mon, Feb 11, 3:47 AM · debug-info
djtodoro added a child revision for D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs: D58041: [Backend] DBG_CALLSITE & DBG_CALLSITEPARAM instr handling.
Mon, Feb 11, 3:47 AM · debug-info
djtodoro added a child revision for D58039: [IR] Handle dbg call site through the middle-end pipeline: D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs.
Mon, Feb 11, 3:41 AM
djtodoro added a parent revision for D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs: D58039: [IR] Handle dbg call site through the middle-end pipeline.
Mon, Feb 11, 3:41 AM · debug-info
djtodoro created D58040: [ISel] Emit DBG CALLSITE/CALLSITEPARAM instrs.
Mon, Feb 11, 3:41 AM · debug-info
djtodoro added a child revision for D58038: Emit DICallSite and DICallSiteParam metadata: D58039: [IR] Handle dbg call site through the middle-end pipeline.
Mon, Feb 11, 3:34 AM · debug-info
djtodoro added a parent revision for D58039: [IR] Handle dbg call site through the middle-end pipeline: D58038: Emit DICallSite and DICallSiteParam metadata.
Mon, Feb 11, 3:34 AM
djtodoro created D58039: [IR] Handle dbg call site through the middle-end pipeline.
Mon, Feb 11, 3:33 AM
djtodoro added a child revision for D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata: D58038: Emit DICallSite and DICallSiteParam metadata.
Mon, Feb 11, 3:29 AM · debug-info
djtodoro created D58038: Emit DICallSite and DICallSiteParam metadata.
Mon, Feb 11, 3:29 AM · debug-info
djtodoro added a parent revision for D58038: Emit DICallSite and DICallSiteParam metadata: D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata.
Mon, Feb 11, 3:29 AM · debug-info
djtodoro added a child revision for D58035: [clang/DIVar] Emit flag for params that have unchanged values: D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata.
Mon, Feb 11, 3:24 AM · debug-info
djtodoro added a parent revision for D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata: D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, Feb 11, 3:24 AM · debug-info
djtodoro created D58036: [IR] Add emitters for DICallSite and DICallSiteParam metadata.
Mon, Feb 11, 3:24 AM · debug-info
djtodoro added a child revision for D58034: [IR/DIVar] Add flag for params that have unchanged values: D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, Feb 11, 3:23 AM · debug-info
djtodoro added a parent revision for D58035: [clang/DIVar] Emit flag for params that have unchanged values: D58034: [IR/DIVar] Add flag for params that have unchanged values.
Mon, Feb 11, 3:23 AM · debug-info
djtodoro created D58035: [clang/DIVar] Emit flag for params that have unchanged values.
Mon, Feb 11, 3:23 AM · debug-info
djtodoro created D58034: [IR/DIVar] Add flag for params that have unchanged values.
Mon, Feb 11, 3:20 AM · debug-info
djtodoro added a parent revision for D58034: [IR/DIVar] Add flag for params that have unchanged values: D58033: Add option for emitting dbg info for call sites.
Mon, Feb 11, 3:20 AM · debug-info
djtodoro added a child revision for D58033: Add option for emitting dbg info for call sites: D58034: [IR/DIVar] Add flag for params that have unchanged values.
Mon, Feb 11, 3:20 AM · debug-info
djtodoro updated the summary of D58032: [Metadata] Introduce call site dbg info metadata.
Mon, Feb 11, 3:14 AM · debug-info
djtodoro updated the summary of D58033: Add option for emitting dbg info for call sites.
Mon, Feb 11, 3:14 AM · debug-info
djtodoro added a parent revision for D58033: Add option for emitting dbg info for call sites: D58032: [Metadata] Introduce call site dbg info metadata.
Mon, Feb 11, 3:12 AM · debug-info
djtodoro retitled D58033: Add option for emitting dbg info for call sites from [clang] Add option for emitting dbg info for call sites to Add option for emitting dbg info for call sites.
Mon, Feb 11, 3:12 AM · debug-info
djtodoro created D58033: Add option for emitting dbg info for call sites.
Mon, Feb 11, 3:12 AM · debug-info
djtodoro added a child revision for D58032: [Metadata] Introduce call site dbg info metadata: D58033: Add option for emitting dbg info for call sites.
Mon, Feb 11, 3:12 AM · debug-info
djtodoro created D58032: [Metadata] Introduce call site dbg info metadata.
Mon, Feb 11, 3:05 AM · debug-info

Dec 10 2018

djtodoro added a comment to D55513: [DeadArgElim] Fixes for dbg.values using dead arg/return values.

LGTM as well! Thanks!

Dec 10 2018, 11:48 PM · debug-info

Sep 14 2018

djtodoro updated the diff for D51968: [deadargelim] Update dbg.value of 'unused' parameters.
Sep 14 2018, 1:11 AM · debug-info

Sep 13 2018

djtodoro added a comment to D51968: [deadargelim] Update dbg.value of 'unused' parameters.

@vsk Thanks for the review!

Sep 13 2018, 4:39 AM · debug-info
djtodoro added a comment to D51968: [deadargelim] Update dbg.value of 'unused' parameters.

@aprantl Thanks for the review! @vsk already answered all questions.

Sep 13 2018, 4:37 AM · debug-info
djtodoro updated the diff for D51968: [deadargelim] Update dbg.value of 'unused' parameters.
Sep 13 2018, 4:32 AM · debug-info

Sep 12 2018

djtodoro updated the summary of D51968: [deadargelim] Update dbg.value of 'unused' parameters.
Sep 12 2018, 1:56 AM · debug-info
djtodoro added a comment to D51968: [deadargelim] Update dbg.value of 'unused' parameters.

Please see the following lldb session:

Sep 12 2018, 1:47 AM · debug-info
djtodoro created D51968: [deadargelim] Update dbg.value of 'unused' parameters.
Sep 12 2018, 1:42 AM · debug-info

Feb 13 2018

djtodoro updated the diff for D43163: [Utils] Salvage the debug info of DCE'ed ‘and’ instructions.
Feb 13 2018, 2:23 AM · debug-info
djtodoro added a comment to D43163: [Utils] Salvage the debug info of DCE'ed ‘and’ instructions.

@vsk Thanks for your comments and review! D43207 LGTM. I'll do that way.

Feb 13 2018, 12:54 AM · debug-info

Feb 10 2018

djtodoro created D43163: [Utils] Salvage the debug info of DCE'ed ‘and’ instructions.
Feb 10 2018, 11:27 AM · debug-info

Feb 6 2018

djtodoro retitled D42794: [DeadArgumentElim] Set pointer to DISubprogram before calling RAUW. NFC from [DeadArgumentElimination] Update pointer to the DISubprogram before calling RAUW. NFC to [DeadArgumentElim] Set pointer to DISubprogram before calling RAUW. NFC.
Feb 6 2018, 3:12 AM · debug-info

Feb 5 2018

djtodoro updated the diff for D42794: [DeadArgumentElim] Set pointer to DISubprogram before calling RAUW. NFC.
Feb 5 2018, 7:58 AM · debug-info

Feb 2 2018

djtodoro added a comment to D42794: [DeadArgumentElim] Set pointer to DISubprogram before calling RAUW. NFC.

@mattd Thanks! I don't see any obstacle to do that, it sounds good to me to set it even earlier.
@aprantl what do you think?

Feb 2 2018, 1:11 AM · debug-info