Page MenuHomePhabricator

djtodoro (Djordje Todorovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2017, 6:53 AM (95 w, 4 d)

Recent Activity

Fri, Oct 11

djtodoro added a comment to D68869: [DebugInfo] Fix truncation of call site immediates.

Looks reasonable, thanks for fixing this!

Fri, Oct 11, 7:36 AM · Restricted Project, debug-info

Mon, Oct 7

djtodoro committed rG0c56f425a0d2: [llvm-locstats] Fix a typo in the documentation; NFC (authored by djtodoro).
[llvm-locstats] Fix a typo in the documentation; NFC
Mon, Oct 7, 12:31 AM
djtodoro committed rL373880: [llvm-locstats] Fix a typo in the documentation; NFC.
[llvm-locstats] Fix a typo in the documentation; NFC
Mon, Oct 7, 12:29 AM

Fri, Oct 4

djtodoro added a comment to D68209: WIP: [LiveDebugValues] Introduce entry values of unmodified/modified params.

@aprantl

So we've come full circle :-)

Unfortunately, yes. :)

Fri, Oct 4, 5:04 AM · Restricted Project, debug-info
djtodoro added a comment to D68207: WIP: [IR] Remove the DIFlagArgumentNotModified debug info flag.

That sounds good. Thanks!

Fri, Oct 4, 4:19 AM · Restricted Project, debug-info

Thu, Oct 3

djtodoro committed rGde6b59cd2089: [llvm-locstats] Copy the script only when needed; NFC (authored by djtodoro).
[llvm-locstats] Copy the script only when needed; NFC
Thu, Oct 3, 6:20 AM
djtodoro committed rL373596: [llvm-locstats] Copy the script only when needed; NFC.
[llvm-locstats] Copy the script only when needed; NFC
Thu, Oct 3, 6:16 AM

Wed, Oct 2

djtodoro committed rG45297645aaba: [llvm-dwarfdump] Fix dumping of wrong locstats map (authored by djtodoro).
[llvm-dwarfdump] Fix dumping of wrong locstats map
Wed, Oct 2, 6:24 AM
djtodoro committed rL373469: [llvm-dwarfdump] Fix dumping of wrong locstats map.
[llvm-dwarfdump] Fix dumping of wrong locstats map
Wed, Oct 2, 6:22 AM
djtodoro committed rG2ef18fb41aeb: Reland "[utils] Implement the llvm-locstats tool" (authored by djtodoro).
Reland "[utils] Implement the llvm-locstats tool"
Wed, Oct 2, 12:00 AM
djtodoro committed rL373427: Reland "[utils] Implement the llvm-locstats tool".
Reland "[utils] Implement the llvm-locstats tool"
Wed, Oct 2, 12:00 AM

Tue, Oct 1

djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Tue, Oct 1, 11:00 PM · Restricted Project, debug-info
djtodoro committed rG372048e90851: Revert "Reland "[utils] Implement the llvm-locstats tool"" (authored by djtodoro).
Revert "Reland "[utils] Implement the llvm-locstats tool""
Tue, Oct 1, 6:20 AM
djtodoro added a reverting change for rL373317: Reland "[utils] Implement the llvm-locstats tool": rL373336: Revert "Reland "[utils] Implement the llvm-locstats tool"".
Tue, Oct 1, 6:19 AM
djtodoro committed rL373336: Revert "Reland "[utils] Implement the llvm-locstats tool"".
Revert "Reland "[utils] Implement the llvm-locstats tool""
Tue, Oct 1, 6:19 AM
djtodoro committed rG6d7f7e6792bb: Reland "[utils] Implement the llvm-locstats tool" (authored by djtodoro).
Reland "[utils] Implement the llvm-locstats tool"
Tue, Oct 1, 2:59 AM
djtodoro committed rL373317: Reland "[utils] Implement the llvm-locstats tool".
Reland "[utils] Implement the llvm-locstats tool"
Tue, Oct 1, 2:58 AM

Mon, Sep 30

djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Mon, Sep 30, 11:40 PM · Restricted Project, debug-info
djtodoro added a child revision for D68207: WIP: [IR] Remove the DIFlagArgumentNotModified debug info flag: D68209: WIP: [LiveDebugValues] Introduce entry values of unmodified/modified params.
Mon, Sep 30, 5:39 AM · Restricted Project, debug-info
djtodoro added a parent revision for D68209: WIP: [LiveDebugValues] Introduce entry values of unmodified/modified params: D68207: WIP: [IR] Remove the DIFlagArgumentNotModified debug info flag.
Mon, Sep 30, 5:39 AM · Restricted Project, debug-info
djtodoro added a child revision for D68206: WIP: [clang] Remove the DIFlagArgumentNotModified debug info flag: D68207: WIP: [IR] Remove the DIFlagArgumentNotModified debug info flag.
Mon, Sep 30, 5:39 AM · debug-info
djtodoro added a parent revision for D68207: WIP: [IR] Remove the DIFlagArgumentNotModified debug info flag: D68206: WIP: [clang] Remove the DIFlagArgumentNotModified debug info flag.
Mon, Sep 30, 5:38 AM · Restricted Project, debug-info
djtodoro added a comment to D68209: WIP: [LiveDebugValues] Introduce entry values of unmodified/modified params.

This is very first (kind of a template) patch and it should be tested and improved more, but the main point is that this will remove the performance regression and improve the debug info quality. :)

Mon, Sep 30, 5:35 AM · Restricted Project, debug-info
djtodoro created D68209: WIP: [LiveDebugValues] Introduce entry values of unmodified/modified params.
Mon, Sep 30, 5:33 AM · Restricted Project, debug-info
djtodoro added a comment to D68207: WIP: [IR] Remove the DIFlagArgumentNotModified debug info flag.

This was controlled by the experimental entry values option, so I guess we don't need to support for metadata upgrade.

Mon, Sep 30, 5:14 AM · Restricted Project, debug-info
djtodoro created D68207: WIP: [IR] Remove the DIFlagArgumentNotModified debug info flag.
Mon, Sep 30, 5:14 AM · Restricted Project, debug-info
djtodoro created D68206: WIP: [clang] Remove the DIFlagArgumentNotModified debug info flag.
Mon, Sep 30, 5:09 AM · debug-info
djtodoro committed rG8180f3b1cc3f: Revert "Reland "[utils] Implement the llvm-locstats tool"" (authored by djtodoro).
Revert "Reland "[utils] Implement the llvm-locstats tool""
Mon, Sep 30, 4:20 AM
djtodoro added a reverting change for rL373183: Reland "[utils] Implement the llvm-locstats tool": rL373200: Revert "Reland "[utils] Implement the llvm-locstats tool"".
Mon, Sep 30, 4:20 AM
djtodoro committed rL373200: Revert "Reland "[utils] Implement the llvm-locstats tool"".
Revert "Reland "[utils] Implement the llvm-locstats tool""
Mon, Sep 30, 4:20 AM
djtodoro committed rG180f1feba9f3: [llvm-locstats] Fix the test for the Hexagon target (authored by djtodoro).
[llvm-locstats] Fix the test for the Hexagon target
Mon, Sep 30, 1:43 AM
djtodoro committed rL373189: [llvm-locstats] Fix the test for the Hexagon target.
[llvm-locstats] Fix the test for the Hexagon target
Mon, Sep 30, 1:43 AM
djtodoro committed rG0f30960619f9: Reland "[utils] Implement the llvm-locstats tool" (authored by djtodoro).
Reland "[utils] Implement the llvm-locstats tool"
Mon, Sep 30, 12:36 AM
djtodoro committed rL373183: Reland "[utils] Implement the llvm-locstats tool".
Reland "[utils] Implement the llvm-locstats tool"
Mon, Sep 30, 12:36 AM
djtodoro closed D66526: [utils] Add the llvm-locstats tool.
Mon, Sep 30, 12:36 AM · Restricted Project, debug-info

Sun, Sep 29

djtodoro accepted D66526: [utils] Add the llvm-locstats tool.

This is checking for the existence of llvm-locstats before running the test?

Yes.

Sun, Sep 29, 11:34 PM · Restricted Project, debug-info

Fri, Sep 27

djtodoro committed rGeb4c98ca3d25: [DebugInfo] Exclude memory location values as parameter entry values (authored by djtodoro).
[DebugInfo] Exclude memory location values as parameter entry values
Fri, Sep 27, 6:59 AM
djtodoro committed rL373089: [DebugInfo] Exclude memory location values as parameter entry values.
[DebugInfo] Exclude memory location values as parameter entry values
Fri, Sep 27, 6:51 AM
djtodoro closed D67717: [DebugInfo] Exclude memory location values as parameter entry values.
Fri, Sep 27, 6:51 AM · Restricted Project, debug-info
djtodoro added a comment to D67717: [DebugInfo] Exclude memory location values as parameter entry values.

I will commit this for Nikola.

Fri, Sep 27, 5:19 AM · Restricted Project, debug-info
djtodoro committed rG06bc9d579cac: [lldb] Disable testing entry values as memory location (authored by djtodoro).
[lldb] Disable testing entry values as memory location
Fri, Sep 27, 5:17 AM
djtodoro committed rL373074: [lldb] Disable testing entry values as memory location.
[lldb] Disable testing entry values as memory location
Fri, Sep 27, 5:14 AM
djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.

-Make the testcase unsupported when needed

Fri, Sep 27, 2:03 AM · Restricted Project, debug-info

Thu, Sep 26

djtodoro added a comment to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.

This looks good to me, thanks!

Thu, Sep 26, 3:30 AM · Restricted Project, debug-info

Wed, Sep 25

djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Wed, Sep 25, 6:19 AM · Restricted Project, debug-info

Tue, Sep 24

djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Tue, Sep 24, 11:31 PM · Restricted Project, debug-info
djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Tue, Sep 24, 6:20 AM · Restricted Project, debug-info

Mon, Sep 23

djtodoro reopened D66526: [utils] Add the llvm-locstats tool.

This is reverted with the rL372580 while investigating.

Mon, Sep 23, 4:11 AM · Restricted Project, debug-info
djtodoro committed rGead96d73ac14: Revert "Reland "[utils] Implement the llvm-locstats tool"" (authored by djtodoro).
Revert "Reland "[utils] Implement the llvm-locstats tool""
Mon, Sep 23, 4:04 AM
djtodoro committed rL372580: Revert "Reland "[utils] Implement the llvm-locstats tool"".
Revert "Reland "[utils] Implement the llvm-locstats tool""
Mon, Sep 23, 4:04 AM
djtodoro added a reverting change for rL372554: Reland "[utils] Implement the llvm-locstats tool": rL372580: Revert "Reland "[utils] Implement the llvm-locstats tool"".
Mon, Sep 23, 4:04 AM
djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

I found a build failure on the sanitizer-x86_64-linux-fast. I will investigate that..

Mon, Sep 23, 2:57 AM · Restricted Project, debug-info
djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

@gchatelet No problem :) I am happy if that is the case!

Mon, Sep 23, 2:35 AM · Restricted Project, debug-info
djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

@gchatelet What build is this about? Since I can not see the failure on the http://lab.llvm.org:8011/console.

Mon, Sep 23, 2:29 AM · Restricted Project, debug-info
djtodoro committed rG0e490ae0a93c: Reland "[utils] Implement the llvm-locstats tool" (authored by djtodoro).
Reland "[utils] Implement the llvm-locstats tool"
Mon, Sep 23, 12:57 AM
djtodoro committed rL372554: Reland "[utils] Implement the llvm-locstats tool".
Reland "[utils] Implement the llvm-locstats tool"
Mon, Sep 23, 12:56 AM
djtodoro closed D66526: [utils] Add the llvm-locstats tool.
Mon, Sep 23, 12:56 AM · Restricted Project, debug-info
djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

@vsk Thanks! :)

Mon, Sep 23, 12:56 AM · Restricted Project, debug-info

Fri, Sep 20

djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

@vsk I believe this can go again, according to the comment from D67699?

Fri, Sep 20, 2:31 AM · Restricted Project, debug-info
djtodoro committed rG9120829063de: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON (authored by djtodoro).
[llvm-dwarfdump] Adjust Windows path to be acceptable by JSON
Fri, Sep 20, 2:26 AM
djtodoro committed rL372378: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON.
[llvm-dwarfdump] Adjust Windows path to be acceptable by JSON
Fri, Sep 20, 2:26 AM
djtodoro closed D67699: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON.
Fri, Sep 20, 2:25 AM · Restricted Project, debug-info
djtodoro added a comment to D67699: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON.

@vsk Thanks!

Fri, Sep 20, 2:25 AM · Restricted Project, debug-info

Thu, Sep 19

djtodoro added a comment to D67674: [WIP][DebugInfo] Allow multi-byte register entry values.

No problem, no inconvenience at all. :) I agree with that way.

Thu, Sep 19, 9:11 AM · Restricted Project
djtodoro updated the diff for D67699: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON.

-Use JSON::Value to get the right json when printing the stats

Thu, Sep 19, 6:21 AM · Restricted Project, debug-info
djtodoro added inline comments to D67699: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON.
Thu, Sep 19, 6:13 AM · Restricted Project, debug-info

Wed, Sep 18

djtodoro added a child revision for D67699: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON: D66526: [utils] Add the llvm-locstats tool.
Wed, Sep 18, 2:30 AM · Restricted Project, debug-info
djtodoro added a parent revision for D66526: [utils] Add the llvm-locstats tool: D67699: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON.
Wed, Sep 18, 2:30 AM · Restricted Project, debug-info
djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.

-Rebase

Wed, Sep 18, 2:30 AM · Restricted Project, debug-info
djtodoro created D67699: [llvm-dwarfdump] Adjust Windows path to be acceptable by JSON.
Wed, Sep 18, 2:30 AM · Restricted Project, debug-info
djtodoro added a comment to D67674: [WIP][DebugInfo] Allow multi-byte register entry values.

Just briefly taking a look, it seems good to me.

Wed, Sep 18, 1:15 AM · Restricted Project

Tue, Sep 17

djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Tue, Sep 17, 11:31 PM · Restricted Project, debug-info
djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Tue, Sep 17, 11:19 PM · Restricted Project, debug-info
djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Tue, Sep 17, 6:42 AM · Restricted Project, debug-info
djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Tue, Sep 17, 2:10 AM · Restricted Project, debug-info

Mon, Sep 16

djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Mon, Sep 16, 8:00 AM · Restricted Project, debug-info

Sep 12 2019

djtodoro added inline comments to D66526: [utils] Add the llvm-locstats tool.
Sep 12 2019, 11:55 PM · Restricted Project, debug-info
djtodoro added inline comments to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.
Sep 12 2019, 11:25 PM · Restricted Project, debug-info
djtodoro requested review of D66526: [utils] Add the llvm-locstats tool.
Sep 12 2019, 9:16 AM · Restricted Project, debug-info
djtodoro updated the diff for D66526: [utils] Add the llvm-locstats tool.

-Adjust the CMake
-Adjust the tool to work on Windows (skip the backslash character from JSON string)
-Adjust the test case to work on Windows

Sep 12 2019, 9:16 AM · Restricted Project, debug-info
djtodoro reopened D66526: [utils] Add the llvm-locstats tool.

This was reverted with the rL371527 due to test failure on Windows platform.

Sep 12 2019, 8:55 AM · Restricted Project, debug-info
djtodoro added inline comments to D67398: [DebugInfo] LiveDebugValues: Move DBG_VALUE creation into VarLoc class.
Sep 12 2019, 4:39 AM · Restricted Project
djtodoro added a comment to D67492: [DebugInfo] Add a DW_OP_LLVM_entry_value operation.

@dstenb Thanks for this! This makes sense.

Sep 12 2019, 4:39 AM · Restricted Project, debug-info

Sep 11 2019

djtodoro added a comment to D67398: [DebugInfo] LiveDebugValues: Move DBG_VALUE creation into VarLoc class.

I think that the problem described within the D67393 imposes a solution with introducing something like DBG_LOC, as @aprantl already suggested.

Sep 11 2019, 3:01 AM · Restricted Project
djtodoro added a project to D67410: [DWARF] Emit call site parameter info when tuning for lldb: debug-info.
Sep 11 2019, 12:13 AM · debug-info, Restricted Project
djtodoro added a comment to D67410: [DWARF] Emit call site parameter info when tuning for lldb.

An idea: After this got implemented, we can add a new sub-directory inside the debuginfo-tests project called DOC (Debugging Optimized Code) and start testing (and tracking) improvements in that area. WDYT?

Sep 11 2019, 12:11 AM · debug-info, Restricted Project
djtodoro added a comment to D67410: [DWARF] Emit call site parameter info when tuning for lldb.

Thanks for this! I am so exciting to see this implemented. :)

Sep 11 2019, 12:01 AM · debug-info, Restricted Project

Sep 10 2019

djtodoro committed rGb21cc626c9a7: Revert "[utils] Implement the llvm-locstats tool" (authored by djtodoro).
Revert "[utils] Implement the llvm-locstats tool"
Sep 10 2019, 7:51 AM
djtodoro committed rL371527: Revert "[utils] Implement the llvm-locstats tool".
Revert "[utils] Implement the llvm-locstats tool"
Sep 10 2019, 7:51 AM
djtodoro added a reverting change for rL371520: [utils] Implement the llvm-locstats tool: rL371527: Revert "[utils] Implement the llvm-locstats tool".
Sep 10 2019, 7:51 AM
djtodoro committed rG54008972d17b: [utils] Implement the llvm-locstats tool (authored by djtodoro).
[utils] Implement the llvm-locstats tool
Sep 10 2019, 6:47 AM
djtodoro committed rL371520: [utils] Implement the llvm-locstats tool.
[utils] Implement the llvm-locstats tool
Sep 10 2019, 6:47 AM
djtodoro closed D66526: [utils] Add the llvm-locstats tool.
Sep 10 2019, 6:46 AM · Restricted Project, debug-info
djtodoro committed rGc714a88a4dc4: [llvm-dwarfdump] Add additional stats fields (authored by djtodoro).
[llvm-dwarfdump] Add additional stats fields
Sep 10 2019, 3:37 AM
djtodoro committed rL371506: [llvm-dwarfdump] Add additional stats fields.
[llvm-dwarfdump] Add additional stats fields
Sep 10 2019, 3:36 AM
djtodoro closed D66525: [llvm-dwarfdump] Add additional stats fields.
Sep 10 2019, 3:36 AM · Restricted Project, debug-info

Sep 6 2019

djtodoro added a comment to D66526: [utils] Add the llvm-locstats tool.

Is this OK to go?

Sep 6 2019, 5:32 AM · Restricted Project, debug-info
djtodoro added a comment to D66525: [llvm-dwarfdump] Add additional stats fields.

@vsk Thanks a lot for the review!

Sep 6 2019, 5:31 AM · Restricted Project, debug-info
djtodoro committed rGd409408e3172: [test] Update the name of the debug entry values option. NFC (authored by djtodoro).
[test] Update the name of the debug entry values option. NFC
Sep 6 2019, 5:23 AM
djtodoro committed rL371199: [test] Update the name of the debug entry values option. NFC.
[test] Update the name of the debug entry values option. NFC
Sep 6 2019, 5:23 AM