Page MenuHomePhabricator

djtodoro (Djordje Todorovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2017, 6:53 AM (232 w, 1 d)

Recent Activity

Today

djtodoro added a comment to D126525: [SSAUpdaterImpl] Do not generate phi node with all the same incoming values.

This is interesting! Can you please make a simple/dedicated LLVM IR case for this only, so we can go over the example to get the whole picture?

Fri, May 27, 7:22 AM · Restricted Project, Restricted Project
djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

Thanks a lot for the comments! Can someone please sum the things up that need to be done for this?

Fri, May 27, 7:19 AM · Restricted Project, Restricted Project

Yesterday

djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

as for the second I'm not sure when it would be profitable to transform back and emit the table

You really just have to weigh it against the current default expansion on targets where ctlz/cttz aren't legal, which is popcount(v & -v). It should be a straightforward comparison, generally. If you have popcount, use it. If multiply is legal, use a table lookup. Otherwise... maybe stick with the popcount expansion? Probably any approach is expensive at that point.

Compare the generated code for arm-eabi.

Thu, May 26, 7:46 AM · Restricted Project, Restricted Project
djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

Hello - We were having a discussion about a very similar patch in D125755. I think the outcome for this patch is that either:

  • We need to do this later (maybe in CodeGenPrepare).
Thu, May 26, 7:43 AM · Restricted Project, Restricted Project

Wed, May 18

djtodoro added inline comments to D125784: [llvm-dva] 09 - CodeView Reader.
Wed, May 18, 5:26 AM · Restricted Project, Restricted Project, debug-info

Tue, May 17

djtodoro added inline comments to D125784: [llvm-dva] 09 - CodeView Reader.
Tue, May 17, 7:59 AM · Restricted Project, Restricted Project, debug-info

Thu, May 12

djtodoro added a comment to D125322: [llvm][json] Fix UINT64 json parsing.

sounds reasonable to me

Thu, May 12, 6:13 AM · Restricted Project, Restricted Project

Fri, May 6

djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

But I think that x86 support doesn’t block this.

Fri, May 6, 1:51 AM · Restricted Project, Restricted Project
djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

OK, great! it will be on my TODO list!

Fri, May 6, 12:20 AM · Restricted Project, Restricted Project
djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

Thanks!

How hard is to add x86 support?

Fri, May 6, 12:15 AM · Restricted Project, Restricted Project

Thu, May 5

Herald added a project to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3: Restricted Project.

@xbolva00 ping :)

Thu, May 5, 1:58 AM · Restricted Project, Restricted Project

Fri, Apr 29

djtodoro accepted D124651: [MIPS] Address instruction selection failure for abs.[sd].

Thanks!

Fri, Apr 29, 12:34 AM · Restricted Project, Restricted Project

Apr 21 2022

djtodoro committed rGc5600aef888b: [Debugify] Limit number of processed functions for original mode (authored by ntesic).
[Debugify] Limit number of processed functions for original mode
Apr 21 2022, 5:00 AM · Restricted Project, Restricted Project
djtodoro closed D115714: [Debugify] Limit number of processed functions for original mode.
Apr 21 2022, 5:00 AM · Restricted Project, Restricted Project, debug-info

Apr 19 2022

djtodoro added inline comments to D123782: [AArch64] Generate AND in place of CSEL for Table Based CTTZ lowering in -O3.
Apr 19 2022, 12:24 AM · Restricted Project, Restricted Project

Apr 14 2022

djtodoro added a comment to D123782: [AArch64] Generate AND in place of CSEL for Table Based CTTZ lowering in -O3.

Thanks for this! Please add test.

Apr 14 2022, 5:26 AM · Restricted Project, Restricted Project

Apr 8 2022

djtodoro accepted D115714: [Debugify] Limit number of processed functions for original mode.
Apr 8 2022, 5:56 AM · Restricted Project, Restricted Project, debug-info
djtodoro added a comment to D115714: [Debugify] Limit number of processed functions for original mode.

Please update https://llvm.org/docs/HowToUpdateDebugInfo.html#test-original-debug-info-preservation-in-optimizations with this. Other than that, looks good to me.

Apr 8 2022, 4:28 AM · Restricted Project, Restricted Project, debug-info

Mar 25 2022

djtodoro added a comment to D122427: [MIPS] Initial support for MIPS-I load delay slots.

Hi @impiaaa, thanks for working on this!
Since this is an initial support, I was wondering is there a clear set of TODOs that need to be done?

Mar 25 2022, 4:26 AM · Restricted Project, Restricted Project

Mar 24 2022

djtodoro committed rG9dbc687a5ec9: NFC: [LICM] Update some stale comments (authored by djtodoro).
NFC: [LICM] Update some stale comments
Mar 24 2022, 6:38 AM · Restricted Project
djtodoro closed D122319: NFC: [LICM] Update some stale comments.
Mar 24 2022, 6:38 AM · Restricted Project, Restricted Project

Mar 23 2022

djtodoro requested review of D122319: NFC: [LICM] Update some stale comments.
Mar 23 2022, 8:03 AM · Restricted Project, Restricted Project

Mar 22 2022

djtodoro committed rG91ea247039db: [Debugify] Use DebugifyLevel in Debugify original mode (authored by djtodoro).
[Debugify] Use DebugifyLevel in Debugify original mode
Mar 22 2022, 6:05 AM · Restricted Project
djtodoro closed D115623: [Debugify] Use DebugifyLevel in Debugify original mode.
Mar 22 2022, 6:05 AM · Restricted Project, Restricted Project, debug-info
djtodoro committed rG73777b4c35a3: [Debugify] Optimize debugify original mode (authored by djtodoro).
[Debugify] Optimize debugify original mode
Mar 22 2022, 4:14 AM · Restricted Project
djtodoro closed D115622: [Debugify] Optimize debugify original mode.
Mar 22 2022, 4:14 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
djtodoro added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Mar 22 2022, 2:45 AM · Restricted Project, Restricted Project
djtodoro added inline comments to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.
Mar 22 2022, 2:29 AM · Restricted Project, debug-info, Restricted Project

Mar 18 2022

djtodoro updated the diff for D115622: [Debugify] Optimize debugify original mode.
  • Move the skipping into the for-loop since we want to collect metadata for the functions that are not observed in the previous Pass (for example the function wasn't of interest due to having an attribute attached that wasn't relevant for the previous Pass) -- the improvement is still ~2x
Mar 18 2022, 3:17 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
djtodoro updated the diff for D115623: [Debugify] Use DebugifyLevel in Debugify original mode.

Sorry for delay here...

Mar 18 2022, 3:08 AM · Restricted Project, Restricted Project, debug-info

Mar 16 2022

djtodoro added a project to D107048: [dwarf][bugfix] Recompute the size of block before getting it's BestForm: debug-info.
Mar 16 2022, 1:48 AM · debug-info, Restricted Project, Restricted Project
djtodoro added a comment to D107048: [dwarf][bugfix] Recompute the size of block before getting it's BestForm.

unit test?

Mar 16 2022, 1:42 AM · debug-info, Restricted Project, Restricted Project

Mar 10 2022

djtodoro added a reviewer for D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name: dblaikie.
Mar 10 2022, 1:06 AM · Restricted Project, Restricted Project, debug-info
djtodoro added a comment to D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name.

Hmmm... if this should be done within compiler side, I am wondering whether this should be resolved in AsmPrinter/DwarfDebug instead.
@aprantl please let me know wyt?

Mar 10 2022, 1:05 AM · Restricted Project, Restricted Project, debug-info

Mar 9 2022

djtodoro accepted D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.

lgtm

Mar 9 2022, 5:57 AM · Restricted Project, Restricted Project
djtodoro added inline comments to D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.
Mar 9 2022, 4:50 AM · Restricted Project, Restricted Project
djtodoro accepted D121284: [llvm-dwarfdump] Avoid possible div-by-zero in debug output.

Thanks.

Mar 9 2022, 4:49 AM · Restricted Project, Restricted Project
djtodoro added inline comments to D121107: [DebugInfo][SROA] Correct debug info for global variables in case of SROA.
Mar 9 2022, 2:13 AM · Restricted Project, Restricted Project, debug-info
djtodoro added inline comments to D121107: [DebugInfo][SROA] Correct debug info for global variables in case of SROA.
Mar 9 2022, 1:07 AM · Restricted Project, Restricted Project, debug-info

Mar 7 2022

djtodoro added a comment to D121107: [DebugInfo][SROA] Correct debug info for global variables in case of SROA.

@alok Thanks for doing this! Can you please add a more descriptive summary of the change?

Mar 7 2022, 4:40 AM · Restricted Project, Restricted Project, debug-info

Mar 3 2022

djtodoro accepted D113520: [SROA] Maintain shadow/backing alloca when some slices are noncapturnig read-only calls to allow alloca partitioning/promotion.
Mar 3 2022, 7:00 AM · Restricted Project, Restricted Project
djtodoro added a comment to D113520: [SROA] Maintain shadow/backing alloca when some slices are noncapturnig read-only calls to allow alloca partitioning/promotion.

LGTM for my side, but please wait a few days to see if someone has some additional comments (although it looks like all the comments are already addressed).

Mar 3 2022, 6:45 AM · Restricted Project, Restricted Project
djtodoro added a comment to D113520: [SROA] Maintain shadow/backing alloca when some slices are noncapturnig read-only calls to allow alloca partitioning/promotion.

The idea behind this seems very interesting/valuable, thanks for this!

Mar 3 2022, 2:58 AM · Restricted Project, Restricted Project

Feb 28 2022

djtodoro added a comment to D119010: [AggressiveInstCombine] Recognize table-based ctz implementation and enable it for AARCH64 at -O3.

Thanks for this.

This should be implemented as a patch on top of the https://reviews.llvm.org/D113291 (as a child of the D113291).

Hello @djtodoro

What is the process to submit my patch based on https://reviews.llvm.org/D113291 ?
While submitting current patch, I could not find a option to make my patch as child patch of yours.

Can you please point to the process of doing it?

Edit Related Revisions (Bellow "Download Raw DIff") -> Edit Child Revisions

Feb 28 2022, 12:17 AM · Restricted Project

Feb 19 2022

djtodoro added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Feb 19 2022, 1:22 AM · Restricted Project, Restricted Project

Feb 7 2022

djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

Can you please provide compile time data with @nikic's compile time tracker? This should be *very cheap* to be acceptable.

.

Feb 7 2022, 7:53 AM · Restricted Project, Restricted Project
djtodoro committed rGafd54e1ed1da: [SLPVectorizer] Fix "unused variable" build warning (authored by djtodoro).
[SLPVectorizer] Fix "unused variable" build warning
Feb 7 2022, 1:38 AM
djtodoro committed rGdef10a2895ad: [GlobalIsel] Fix another "unused variable" warning (authored by djtodoro).
[GlobalIsel] Fix another "unused variable" warning
Feb 7 2022, 12:33 AM
djtodoro added a comment to rGeab395fa4074: Fix the warning after D118805.

Actually, the D118655 caused the build warning.

Feb 7 2022, 12:29 AM
djtodoro committed rGeab395fa4074: Fix the warning after D118805 (authored by djtodoro).
Fix the warning after D118805
Feb 7 2022, 12:26 AM

Feb 6 2022

djtodoro requested changes to D119010: [AggressiveInstCombine] Recognize table-based ctz implementation and enable it for AARCH64 at -O3.
Feb 6 2022, 11:23 PM · Restricted Project

Feb 4 2022

djtodoro added a comment to D119010: [AggressiveInstCombine] Recognize table-based ctz implementation and enable it for AARCH64 at -O3.

Thanks for this.

Feb 4 2022, 11:25 AM · Restricted Project

Feb 1 2022

djtodoro added inline comments to D116305: [CSInfo][clang][ISEL][RISCV] Support for recovering optimized debug function parameters.
Feb 1 2022, 6:01 AM · Restricted Project, debug-info, Restricted Project, Restricted Project
djtodoro added inline comments to D116305: [CSInfo][clang][ISEL][RISCV] Support for recovering optimized debug function parameters.
Feb 1 2022, 2:13 AM · Restricted Project, debug-info, Restricted Project, Restricted Project
djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

@craig.topper @spatel Do you think this can go as is?

Feb 1 2022, 2:00 AM · Restricted Project, Restricted Project

Jan 28 2022

djtodoro committed rG402f91bcbb51: [llvm-mca] Plot as result of comparing multiple files (authored by mmatic05).
[llvm-mca] Plot as result of comparing multiple files
Jan 28 2022, 4:06 AM
djtodoro closed D115718: [llvm-mca] Plot as result of comparing multiple files .
Jan 28 2022, 4:05 AM · Restricted Project

Jan 27 2022

djtodoro accepted D118369: [NewPM] Add debugify and check-debugify to the PassRegistry.

Looks reasonable to me. Thanks.

Jan 27 2022, 9:49 AM · Restricted Project
djtodoro added a reviewer for D118338: [Debugify] Override printPipeline for NewPM debugify passes: MaskRay.
Jan 27 2022, 2:54 AM · Restricted Project
djtodoro added a comment to D118338: [Debugify] Override printPipeline for NewPM debugify passes.

Thanks for this @bjope.

Jan 27 2022, 2:54 AM · Restricted Project
djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

I have a small query regarding this patch. The patch emits following llvm assembly for ctz table -

-----Patch assembly-------
// %bb.0:

rbit w8, w0
cmp w0, #0
clz w8, w8
csel w0, wzr, w8, eq
ret

but in gcc, we have the following assembly being emitted -

------------GCC---------------------
f(unsigned int):

rbit    w0, w0
clz     w0, w0
and     w0, w0, 31
ret

That sounds like a backend optimization that could happen given we know the semantics of the AArch64 instruction.

Jan 27 2022, 1:35 AM · Restricted Project, Restricted Project
djtodoro abandoned D77799: [WIP] [DebugInfoMetadata] Introduce the "lambda" DISubprogram field.
Jan 27 2022, 1:17 AM · Restricted Project, debug-info
djtodoro abandoned D77800: [WIP][DebugInfo][AsmPrinter] Emit the DW_AT_LLVM_lambda_name.
Jan 27 2022, 1:17 AM · Restricted Project, debug-info
djtodoro abandoned D77801: [WIP][LLDB] Parse the DW_AT_LLVM_lambda_name.
Jan 27 2022, 1:16 AM · Unknown Object (Project), debug-info
djtodoro added a comment to D113291: [AggressiveInstCombine] Lower Table Based CTTZ and enable it for AARCH64 in -O3.

Hello,

I have a small query regarding this patch. The patch emits following llvm assembly for ctz table -

-----Patch assembly-------
// %bb.0:

rbit w8, w0
cmp w0, #0
clz w8, w8
csel w0, wzr, w8, eq
ret

but in gcc, we have the following assembly being emitted -

------------GCC---------------------
f(unsigned int):

rbit    w0, w0
clz     w0, w0
and     w0, w0, 31
ret

Reference - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90838

[1] My question is - To solve the bug, do I have to generate assembly similar to GCC?

Please give me suggestions on moving forward in solving this bug.

Jan 27 2022, 1:11 AM · Restricted Project, Restricted Project

Jan 18 2022

djtodoro added a comment to D116305: [CSInfo][clang][ISEL][RISCV] Support for recovering optimized debug function parameters.

This whole scheme seems like a pretty bad idea, is that really how the debug infrastructure works, scavenging generated code to figure out what arguments were passed rather than just remembering from the input? This all seems pretty fragile. I mean, if that's what we need to do to make it work then I guess we have to, but I really do not like this code...

I am not sure If I understood this, can you please elaborate what exactly is bad idea?

Jan 18 2022, 11:54 PM · Restricted Project, debug-info, Restricted Project, Restricted Project

Dec 27 2021

djtodoro added a comment to D116305: [CSInfo][clang][ISEL][RISCV] Support for recovering optimized debug function parameters.

Can we put all the dbg-call-site-param-* tests in one MIR file?

Dec 27 2021, 5:29 AM · Restricted Project, debug-info, Restricted Project, Restricted Project
djtodoro added a comment to D116305: [CSInfo][clang][ISEL][RISCV] Support for recovering optimized debug function parameters.

Thanks for this. Some initial comments inline.

Dec 27 2021, 5:24 AM · Restricted Project, debug-info, Restricted Project, Restricted Project
djtodoro accepted D115718: [llvm-mca] Plot as result of comparing multiple files .

lgtm, thanks!

Dec 27 2021, 4:39 AM · Restricted Project
djtodoro added a comment to D116302: [utils][compare.py] Add a plotting option.

The motivation seems reasonable behind this. Thanks.

Dec 27 2021, 4:13 AM
djtodoro added a reviewer for D116302: [utils][compare.py] Add a plotting option: amyk.
Dec 27 2021, 4:11 AM
djtodoro added a reviewer for D115444: [test-suite][cmake] Add caches for -O1 and -O2 builds: amyk.
Dec 27 2021, 4:10 AM

Dec 21 2021

djtodoro committed rG93615b88f5aa: [Debugify] Use WeakWH map collected before Pass when checking loc drop (authored by djtodoro).
[Debugify] Use WeakWH map collected before Pass when checking loc drop
Dec 21 2021, 6:55 AM
djtodoro closed D115621: [Debugify] Use WeakWH map collected before Pass when checking loc drop.
Dec 21 2021, 6:54 AM · Restricted Project
djtodoro added inline comments to D115718: [llvm-mca] Plot as result of comparing multiple files .
Dec 21 2021, 4:49 AM · Restricted Project
djtodoro committed rG0e343479a7ea: [llvm-mca] Compare multiple files (authored by djtodoro).
[llvm-mca] Compare multiple files
Dec 21 2021, 2:57 AM
djtodoro closed D115138: [llvm-mca] Compare multiple files.
Dec 21 2021, 2:57 AM · Restricted Project
djtodoro accepted D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct.
Dec 21 2021, 1:51 AM · Restricted Project, debug-info

Dec 16 2021

djtodoro added a reviewer for D115444: [test-suite][cmake] Add caches for -O1 and -O2 builds: mgorny.
Dec 16 2021, 2:08 AM

Dec 15 2021

djtodoro accepted D115138: [llvm-mca] Compare multiple files.

lgtm, thanks!

Dec 15 2021, 4:06 AM · Restricted Project
djtodoro added inline comments to D115138: [llvm-mca] Compare multiple files.
Dec 15 2021, 12:50 AM · Restricted Project

Dec 13 2021

djtodoro requested review of D115623: [Debugify] Use DebugifyLevel in Debugify original mode.
Dec 13 2021, 3:42 AM · Restricted Project, Restricted Project, debug-info
djtodoro requested review of D115622: [Debugify] Optimize debugify original mode.
Dec 13 2021, 3:38 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
djtodoro requested review of D115621: [Debugify] Use WeakWH map collected before Pass when checking loc drop.
Dec 13 2021, 3:27 AM · Restricted Project

Dec 9 2021

djtodoro requested review of D115444: [test-suite][cmake] Add caches for -O1 and -O2 builds.
Dec 9 2021, 6:23 AM
djtodoro added a comment to D115138: [llvm-mca] Compare multiple files.

Thanks a lot, @mmatic05!

Dec 9 2021, 5:33 AM · Restricted Project

Dec 8 2021

djtodoro added inline comments to D115138: [llvm-mca] Compare multiple files.
Dec 8 2021, 3:41 AM · Restricted Project

Dec 7 2021

djtodoro added inline comments to D115138: [llvm-mca] Compare multiple files.
Dec 7 2021, 7:50 AM · Restricted Project
djtodoro added inline comments to D115138: [llvm-mca] Compare multiple files.
Dec 7 2021, 7:48 AM · Restricted Project
djtodoro added a comment to D115138: [llvm-mca] Compare multiple files.

Thanks for the update. Can you please update the summary?

Dec 7 2021, 7:45 AM · Restricted Project
djtodoro added a comment to D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.

Yes please, I don’t have commit access. Can you commit as Marko Mijalkovic <marko.mijalkovic97@gmail.com>?

We usually add "Patch by " at the end of the commit message.

That's not the official way to do it since we migrated to Git; see https://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes which says to set the author field to the actual author.

Dec 7 2021, 6:25 AM · Restricted Project
djtodoro added a reviewer for D115244: [LICM] Promote conditional, loop-invariant memory accesses to scalars: efriedma.
Dec 7 2021, 5:50 AM · Restricted Project, Restricted Project
djtodoro added a comment to D115244: [LICM] Promote conditional, loop-invariant memory accesses to scalars.

Thanks for working on this! This looks like an addition to https://reviews.llvm.org/D113289.

Dec 7 2021, 5:50 AM · Restricted Project, Restricted Project
djtodoro added a reviewer for D115244: [LICM] Promote conditional, loop-invariant memory accesses to scalars: reames.
Dec 7 2021, 5:40 AM · Restricted Project, Restricted Project
djtodoro committed rGf0f6bba5b285: [MIPS] Add FPU Delay Slot for MIPS1/2/3 (authored by djtodoro).
[MIPS] Add FPU Delay Slot for MIPS1/2/3
Dec 7 2021, 5:03 AM
djtodoro closed D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.
Dec 7 2021, 5:03 AM · Restricted Project
djtodoro added a comment to D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.

Yes please, I don’t have commit access. Can you commit as Marko Mijalkovic <marko.mijalkovic97@gmail.com>?

Dec 7 2021, 4:26 AM · Restricted Project
djtodoro added a comment to D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.

Please let me know if you need help with committing this (If you don't have the permission, I can do it for you).

Dec 7 2021, 1:23 AM · Restricted Project
djtodoro accepted D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3.

lgtm, thanks

Dec 7 2021, 1:18 AM · Restricted Project

Dec 6 2021

djtodoro added a comment to D115138: [llvm-mca] Compare multiple files.

+1, we can keep it within llvm-project/llvm/utils

Dec 6 2021, 7:00 AM · Restricted Project