- User Since
- Dec 14 2017, 6:53 AM (232 w, 1 d)
This is interesting! Can you please make a simple/dedicated LLVM IR case for this only, so we can go over the example to get the whole picture?
Thanks a lot for the comments! Can someone please sum the things up that need to be done for this?
Wed, May 18
Tue, May 17
Thu, May 12
sounds reasonable to me
Fri, May 6
But I think that x86 support doesn’t block this.
OK, great! it will be on my TODO list!
Thu, May 5
@xbolva00 ping :)
Fri, Apr 29
Apr 21 2022
Apr 19 2022
Apr 14 2022
Thanks for this! Please add test.
Apr 8 2022
Please update https://llvm.org/docs/HowToUpdateDebugInfo.html#test-original-debug-info-preservation-in-optimizations with this. Other than that, looks good to me.
Mar 25 2022
Hi @impiaaa, thanks for working on this!
Since this is an initial support, I was wondering is there a clear set of TODOs that need to be done?
Mar 24 2022
Mar 23 2022
Mar 22 2022
Mar 18 2022
- Move the skipping into the for-loop since we want to collect metadata for the functions that are not observed in the previous Pass (for example the function wasn't of interest due to having an attribute attached that wasn't relevant for the previous Pass) -- the improvement is still ~2x
Sorry for delay here...
Mar 16 2022
Mar 10 2022
Hmmm... if this should be done within compiler side, I am wondering whether this should be resolved in AsmPrinter/DwarfDebug instead.
@aprantl please let me know wyt?
Mar 9 2022
Mar 7 2022
@alok Thanks for doing this! Can you please add a more descriptive summary of the change?
Mar 3 2022
LGTM for my side, but please wait a few days to see if someone has some additional comments (although it looks like all the comments are already addressed).
The idea behind this seems very interesting/valuable, thanks for this!
Feb 28 2022
Edit Related Revisions (Bellow "Download Raw DIff") -> Edit Child Revisions
Feb 19 2022
Feb 7 2022
Actually, the D118655 caused the build warning.
Feb 6 2022
Feb 4 2022
Thanks for this.
Feb 1 2022
Jan 28 2022
Jan 27 2022
Looks reasonable to me. Thanks.
Thanks for this @bjope.
Jan 18 2022
I am not sure If I understood this, can you please elaborate what exactly is bad idea?
Dec 27 2021
Can we put all the dbg-call-site-param-* tests in one MIR file?
Thanks for this. Some initial comments inline.
The motivation seems reasonable behind this. Thanks.
Dec 21 2021
Dec 16 2021
Dec 15 2021
Dec 13 2021
Dec 9 2021
Thanks a lot, @mmatic05!
Dec 8 2021
Dec 7 2021
Thanks for the update. Can you please update the summary?
Thanks for working on this! This looks like an addition to https://reviews.llvm.org/D113289.
Please let me know if you need help with committing this (If you don't have the permission, I can do it for you).