Page MenuHomePhabricator

djtodoro (Djordje Todorovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2017, 6:53 AM (79 w, 5 d)

Recent Activity

Thu, Jun 20

djtodoro added a comment to D61062: Keep call site info valid through the backend.

@aprantl The comment looks OK? :)

Thu, Jun 20, 11:14 PM · Restricted Project, debug-info
djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@aprantl This still looks OK after the rebasing? :)

Thu, Jun 20, 11:14 PM · Restricted Project, debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase

Thu, Jun 20, 6:38 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase

Thu, Jun 20, 6:37 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Rebase

Thu, Jun 20, 6:35 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Rebase
-Add the comment explaining the assertion when deleting instructions

Thu, Jun 20, 6:35 AM · Restricted Project, debug-info

Mon, Jun 17

djtodoro added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Mon, Jun 17, 11:22 PM · debug-info

Mon, Jun 10

djtodoro updated the diff for D61061: [MachineFunction] Base support for call site info tracking.

-Remove an unwanted code refactor change

Mon, Jun 10, 4:30 AM · debug-info

Thu, Jun 6

djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Handle a deletion in the LiveRangeEdit

Thu, Jun 6, 6:04 AM · Restricted Project, debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Handle the TargetDecl in more secure way (the same as the other code in the function)

Thu, Jun 6, 6:01 AM
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Explicitly enable the option only in the case of X86

Thu, Jun 6, 5:58 AM · debug-info

Wed, Jun 5

djtodoro added a comment to D58042: [LiveDebugValues] Emit parameter's entry value.

@dstenb Thanks for the comment!

Wed, Jun 5, 6:13 AM · Restricted Project, debug-info

Tue, Jun 4

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

Oh.. and could you please document this either in LangRef.rst or SourceLevelDebugging.rst?

Sure. Please find it in the latest patch.
Thanks for your comments!

Tue, Jun 4, 3:35 AM · debug-info
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Address suggestions
-Document this

Tue, Jun 4, 3:35 AM · debug-info

Fri, May 31

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

(2) function declarations may have a unique DISubprogram attached (new)

In addition, this will address only this.

Fri, May 31, 5:38 AM · debug-info
djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

@aprantl , @dexonsmith Thanks for your comments!

Fri, May 31, 5:37 AM · debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Rebase tests

Fri, May 31, 5:12 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Rebase tests

Fri, May 31, 5:12 AM · Restricted Project, debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Rebase

Fri, May 31, 5:12 AM
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Remove the SP flag
-Attach a unique sp to a declaration for the purpose of call site dbg info

Fri, May 31, 5:12 AM · debug-info

Thu, May 30

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

I'm sorry if the answer to that question is already in your reply and I just failed to parse it: Why do we need the DISPFlagDeclForCallSite *flag* to differentiate the a DISubprogram. Isn't the fact that it is attached to a forward-declaration enough?

Thu, May 30, 6:41 AM · debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Rebase

Thu, May 30, 6:34 AM
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Refactor the code
-Change the test case

Thu, May 30, 6:31 AM · debug-info

Wed, May 29

djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
Wed, May 29, 5:52 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Addressing suggestions

Wed, May 29, 5:52 AM · Restricted Project, debug-info
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Follow the new order of fields inside the ArgRegPair struct (the struct is now better packed))

Wed, May 29, 5:52 AM · debug-info
djtodoro updated the diff for D61061: [MachineFunction] Base support for call site info tracking.

-Addressing suggestions

Wed, May 29, 5:49 AM · debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Addressing suggestions

Wed, May 29, 5:47 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Addressing suggestions

Wed, May 29, 5:47 AM · Restricted Project, debug-info

Tue, May 28

djtodoro added a comment to D60713: [IR] Add DISuprogram and DIE for func decl of an external.

@aprantl Thanks again for your comments!

Tue, May 28, 11:58 PM · debug-info

Mon, May 27

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Addressing comments

Mon, May 27, 6:47 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@dstenb Thanks a lot for your comments!

Mon, May 27, 6:47 AM · Restricted Project, debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Refactor the code a bit
-Rebase

Mon, May 27, 5:22 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Refactor test cases a bit
-Rebase

Mon, May 27, 5:22 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Refactor the code a bit
-Rebase

Mon, May 27, 5:18 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Rebase

Mon, May 27, 5:17 AM · Restricted Project, debug-info
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Rebase

Mon, May 27, 5:17 AM · debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Rebase

Mon, May 27, 5:17 AM
djtodoro updated the diff for D61061: [MachineFunction] Base support for call site info tracking.

-Rebase

Mon, May 27, 5:17 AM · debug-info
djtodoro updated the diff for D60713: [IR] Add DISuprogram and DIE for func decl of an external.

-Rebase
-Improve the verifier
-Add a test
-Document the spFlag
-Refactor the code

Mon, May 27, 5:13 AM · debug-info
djtodoro updated the diff for D58034: [IR/DIVar] Add flag for params that have unchanged values.

-Rebase

Mon, May 27, 5:12 AM · debug-info
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Rebase
-Add a test

Mon, May 27, 5:12 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Rebase

Mon, May 27, 5:11 AM · debug-info
djtodoro updated the diff for D60961: [TargetOption] Add option for enabling param entry val tracking dbg info.

-Rebase

Mon, May 27, 5:11 AM · debug-info
djtodoro committed rG1d28030f9979: [test commit] Add my name to the CREDITS.TXT (authored by djtodoro).
[test commit] Add my name to the CREDITS.TXT
Mon, May 27, 12:47 AM
djtodoro committed rL361748: [test commit] Add my name to the CREDITS.TXT.
[test commit] Add my name to the CREDITS.TXT
Mon, May 27, 12:47 AM

May 23 2019

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Add check for a frame reg when describing a parameter value

May 23 2019, 6:30 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Addressing comments
-Avoid indirect dbg_values (in addition to SP and FP locations) in order to avoid memory locations as entry values locations

May 23 2019, 6:30 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Addressing comments
-Add llvm-dwarfdump tests for DW_OP_entry_value

May 23 2019, 6:22 AM · Restricted Project, debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Address suggestions
-Use the right FnType needed for production of the subroutine type

May 23 2019, 6:19 AM
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Add SPDefCache to speed up the process
-Add additional assertions that will improve quality of the code

May 23 2019, 6:15 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Add a negative test for -O0

May 23 2019, 6:04 AM · debug-info
djtodoro added a comment to D62295: [LiveDebugValues] Rename 'DMI' into 'DebugInstr'; NFC;.

As discussed on D58042, there is no need for the official review for this.

May 23 2019, 2:33 AM · Restricted Project, debug-info
djtodoro created D62295: [LiveDebugValues] Rename 'DMI' into 'DebugInstr'; NFC;.
May 23 2019, 2:33 AM · Restricted Project, debug-info

May 21 2019

djtodoro added a comment to D62002: [DwarfExpression] Refactor dwarf expression (NFC).

@aprantl Thanks a lot for the review!

May 21 2019, 11:25 PM · Restricted Project, debug-info
djtodoro updated the diff for D62002: [DwarfExpression] Refactor dwarf expression (NFC).

-Add an assertion when emitting pieces info about a subregister

May 21 2019, 11:25 PM · Restricted Project, debug-info
djtodoro added inline comments to D60714: [clang] Add DISuprogram and DIE for func decl of an external .
May 21 2019, 6:49 AM
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Use map instead of vector for storing debug entry values
-TODO: Land a separate patch with renaming DMI-->DebugInstr

May 21 2019, 6:44 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Improve the verifier for entry values
-Add test for the verifier

May 21 2019, 6:40 AM · Restricted Project, debug-info
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Use SPCache instead of DeclCache
-Refactor the code by addressing suggestions

May 21 2019, 6:39 AM · debug-info
djtodoro updated the diff for D58033: Add option for emitting dbg info for call site parameters.

-Set EnableDebugEntryValues only for a higher level of optimizations (-O1 and higher)

May 21 2019, 6:33 AM · debug-info

May 20 2019

djtodoro updated the diff for D62002: [DwarfExpression] Refactor dwarf expression (NFC).

-Cut off some bits from the other class fields
-Rename the title
-Change the summary

May 20 2019, 11:50 PM · Restricted Project, debug-info
djtodoro added inline comments to D62002: [DwarfExpression] Refactor dwarf expression (NFC).
May 20 2019, 11:27 AM · Restricted Project, debug-info
djtodoro updated the diff for D62002: [DwarfExpression] Refactor dwarf expression (NFC).

-Keep the DwarfVersion as unsigned

May 20 2019, 7:01 AM · Restricted Project, debug-info
djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
May 20 2019, 6:59 AM · Restricted Project, debug-info
djtodoro added inline comments to D62002: [DwarfExpression] Refactor dwarf expression (NFC).
May 20 2019, 6:37 AM · Restricted Project, debug-info
djtodoro updated the diff for D62002: [DwarfExpression] Refactor dwarf expression (NFC).

-Introduce the LokcationKind and the LokcationFlags
-Cut off bits from the DwarfVersion

May 20 2019, 6:11 AM · Restricted Project, debug-info
djtodoro added inline comments to D62002: [DwarfExpression] Refactor dwarf expression (NFC).
May 20 2019, 6:07 AM · Restricted Project, debug-info

May 17 2019

djtodoro added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
May 17 2019, 7:19 AM · debug-info
djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Address suggestions

May 17 2019, 6:55 AM · Restricted Project, debug-info
djtodoro added inline comments to D60716: [DwarfDebug] Dump call site debug info into DWARF.
May 17 2019, 6:54 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Address suggestions

May 17 2019, 6:38 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Address suggestions

May 17 2019, 6:38 AM · Restricted Project, debug-info
djtodoro added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
May 17 2019, 6:38 AM · Restricted Project, debug-info
djtodoro added inline comments to D62002: [DwarfExpression] Refactor dwarf expression (NFC).
May 17 2019, 4:43 AM · Restricted Project, debug-info
djtodoro updated the diff for D62002: [DwarfExpression] Refactor dwarf expression (NFC).

-For now, all expression kinds are mutually exclusive, therefore handle it properly.

May 17 2019, 4:38 AM · Restricted Project, debug-info
djtodoro added a comment to D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).

@aprantl

Thanks! One bonus cleanup inline :-)

Sure. This is done. Thanks!

May 17 2019, 2:41 AM · Restricted Project, debug-info
djtodoro updated the diff for D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).

-Bounus refactor of replaceDbgDeclare()

May 17 2019, 2:41 AM · Restricted Project, debug-info

May 16 2019

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Address suggestions

May 16 2019, 5:16 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@aprantl Thanks!

May 16 2019, 5:16 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Address suggestions
-Rename ParamEntryVals into DebugEntryVals
-Avoid entry values on a frame reg and fragments (found those cases with better verifier)

May 16 2019, 5:15 AM · Restricted Project, debug-info
djtodoro added inline comments to D58042: [LiveDebugValues] Emit parameter's entry value.
May 16 2019, 5:15 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Address suggestions
-Improve the documentation
-Improve the verifier

May 16 2019, 5:09 AM · Restricted Project, debug-info
djtodoro added a comment to D60866: [DWARF] Handle DW_OP_entry_value operand.

@aprantl As soon as NFC patches (D61943 and D62002) got accepted we will update this.

May 16 2019, 5:09 AM · Restricted Project, debug-info
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Verify that call site info is the same after loading and running a pass over it.

May 16 2019, 5:06 AM · debug-info
djtodoro updated the diff for D61061: [MachineFunction] Base support for call site info tracking.

-Add a helper function for initialization of call site info
-Add tests for error checking of call site initialization

May 16 2019, 5:03 AM · debug-info
djtodoro updated the diff for D60714: [clang] Add DISuprogram and DIE for func decl of an external .

-Address suggestions

May 16 2019, 5:00 AM
djtodoro updated the diff for D58035: [clang/DIVar] Emit flag for params that have unchanged values.

-Careful use of dyn_cast
-Fill the ParamCache only in the case of EnableDebugEntryValues option

May 16 2019, 5:00 AM · debug-info
djtodoro added inline comments to D58035: [clang/DIVar] Emit flag for params that have unchanged values.
May 16 2019, 4:54 AM · debug-info
djtodoro created D62002: [DwarfExpression] Refactor dwarf expression (NFC).
May 16 2019, 4:21 AM · Restricted Project, debug-info
djtodoro updated the diff for D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).

-Address suggestions
-Refactor the code a bit

May 16 2019, 2:38 AM · Restricted Project, debug-info
djtodoro added a comment to D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).

@aprantl Thanks for your comments!

May 16 2019, 2:38 AM · Restricted Project, debug-info

May 15 2019

djtodoro created D61943: [DebugInfoMetadata] Refactor DIExpression::prepend constants (NFC).
May 15 2019, 6:36 AM · Restricted Project, debug-info

May 13 2019

djtodoro updated the diff for D60716: [DwarfDebug] Dump call site debug info into DWARF.

-Refactor the code
-Trim existing tests
-Improve production of call site info
-Rebase

May 13 2019, 2:48 AM · Restricted Project, debug-info
djtodoro added a comment to D60716: [DwarfDebug] Dump call site debug info into DWARF.

@aprantl, @vsk and @dstenb. Thanks for your comments!

May 13 2019, 2:45 AM · Restricted Project, debug-info
djtodoro updated the diff for D58042: [LiveDebugValues] Emit parameter's entry value.

-Handle more cases within LiveDebugValues::ExtendRanges()
-Add one more test
-Rebase

May 13 2019, 1:50 AM · Restricted Project, debug-info
djtodoro updated the diff for D60866: [DWARF] Handle DW_OP_entry_value operand.

-Refactor the code a bit
-Improve the documentation

May 13 2019, 1:48 AM · Restricted Project, debug-info
djtodoro added inline comments to D60866: [DWARF] Handle DW_OP_entry_value operand.
May 13 2019, 1:45 AM · Restricted Project, debug-info
djtodoro updated the diff for D61062: Keep call site info valid through the backend.

-Add a lookup in call site info
-Rebase

May 13 2019, 1:42 AM · Restricted Project, debug-info
djtodoro updated the diff for D60715: [ISEL][X86] Tracking of registers that forward call arguments.

-Rebase

May 13 2019, 1:40 AM · debug-info