Page MenuHomePhabricator

raghavendhra (Raghu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2020, 6:58 AM (114 w, 17 h)

Recent Activity

Mon, Aug 8

raghavendhra added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

@abidmalikwaterloo Can you please check your last patch pushed for review? https://buildkite.com/llvm-project/diff-checks/builds/117796 states it can not apply your patch something to do with the usage of diff --update <patch>? Can you please check?

@raghavendhra I tried to correct it but could not figure out the solution. Do you have any? I am not experienced with the phabricator framework. One solution is to submit another patch with all changes till today and abandon this one.

Mon, Aug 8, 11:34 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

@abidmalikwaterloo Can you please check your last patch pushed for review? https://buildkite.com/llvm-project/diff-checks/builds/117796 states it can not apply your patch something to do with usage of diff --update <patch>? Can you please check?

Mon, Aug 8, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jul 15

raghavendhra added a comment to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

@clementval I started a discourse thread https://discourse.llvm.org/t/rfc-for-refactoring-common-code-for-openacc-and-openmp/63833 regarding the same discussion which happened in bi-weekly OpenMP in flang technical call. Please let me know your thoughts. Thanks!

Fri, Jul 15, 2:02 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

raghavendhra added inline comments to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..
Jul 12 2022, 7:03 AM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2022

raghavendhra added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

@abidmalikwaterloo ninja check-mlir is failing with your most upto date patch. Can you please double check?

Jul 10 2022, 10:38 PM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2022

raghavendhra added a comment to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

Can you please review this change?

Jul 8 2022, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 8 2022, 11:29 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 6 2022

raghavendhra retitled D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP. from [OpenMP][IRBuilder] 'omp target enter data' support. to [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..
Jul 6 2022, 3:01 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra updated the diff for D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP.

Jul 6 2022, 2:58 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added a comment to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

Still working on a unittest for createTargetEnterData?

Jul 6 2022, 2:47 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra updated the diff for D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

Moved common code for OpenMP and OpenACC to CommonOpenMPOpenACCUtils.

Jul 6 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added inline comments to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..
Jul 6 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2022

raghavendhra updated the diff for D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

Moving common OpenACC and OpenMP code to common place in Utils.

Jun 30 2022, 11:50 AM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

raghavendhra accepted D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang.

LGTM

Jun 27 2022, 8:49 AM · Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra added a reviewer for D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang: raghavendhra.

LGTM

Jun 27 2022, 8:49 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jun 6 2022

raghavendhra added a comment to D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

Please add testcase in llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp

Jun 6 2022, 7:01 AM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

raghavendhra added reviewers for D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP.: shraiysh, kiranchandramohan, abidmalikwaterloo, clementval, NimishMishra.
Jun 3 2022, 5:17 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra requested review of D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..
Jun 3 2022, 5:12 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

raghavendhra updated subscribers of D126441: [flang][OpenMP] Parser support for Target directive and Device clause.
May 31 2022, 6:19 AM · Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

May 26 2022

raghavendhra updated subscribers of D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
May 26 2022, 5:04 PM · Restricted Project, Restricted Project, Restricted Project

May 2 2022

raghavendhra added a comment to rG4d34c4e0e67d: [OpenMP] Fix -Wswitch (due to new OMPC_cancellation_construct_type) after….

Sorry about the build breakage. Thanks for fixing this. :)

May 2 2022, 1:09 PM · Restricted Project, Restricted Project
raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Rebasing to main before landing.

May 2 2022, 6:25 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Apr 30 2022

raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Rebasing it to main to land the patch.

Apr 30 2022, 3:00 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Apr 28 2022

raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Rebasing with main

Apr 28 2022, 8:30 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Fixed git-clang-format

Apr 28 2022, 8:15 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Updating D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

Apr 28 2022, 9:46 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Updating D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

Apr 28 2022, 2:31 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Apr 26 2022

raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Addressed comments

Apr 26 2022, 5:25 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra planned changes to D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..
Apr 26 2022, 5:21 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Apr 21 2022

raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Updating D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

Apr 21 2022, 11:15 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Apr 20 2022

raghavendhra planned changes to D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

@raghavendhra Apologies for not being clear. The change request was to add a verifier to the operation to issue errors where the closely nested construct restrictions do not hold.

As per the standard, for example, the following usages are not allowed.

!$omp master
!$omp cancel parallel
!$omp end master
!$omp cancel parallel

Could you go through the restrictions of cancel and cancellation point (the restriction on nesting of constructs) and implement these in the verifier? You could use the Reduction Op's verifier for reference. We probably have to check the parent Op and ensure it meets the restrictions specified in the standard.
https://github.com/llvm/llvm-project/blob/76410040b9f391185c7df48c14519860e1cf75e5/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td#L1074
https://github.com/llvm/llvm-project/blob/76410040b9f391185c7df48c14519860e1cf75e5/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp#L713

Apr 20 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Updating D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

Apr 20 2022, 2:18 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Apr 15 2022

raghavendhra updated the diff for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..

Updating D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

Apr 15 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra requested review of D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..
Apr 15 2022, 12:16 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Apr 14 2022

raghavendhra updated subscribers of D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..
Apr 14 2022, 7:49 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra added reviewers for D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.: kiranchandramohan, kiranktp, clementval, peixin, dpalermo, MatsPetersson, shraiysh.
Apr 14 2022, 6:50 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)
raghavendhra requested review of D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..
Apr 14 2022, 6:46 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project)

Sep 8 2020

raghavendhra accepted D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

LGTM

Sep 8 2020, 10:15 AM · Restricted Project, Unknown Object (Project), Restricted Project