Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People raghavendhra

raghavendhra (Raghu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2020, 6:58 AM (172 w, 3 d)

Recent Activity
View All

Thu, Sep 7

raghavendhra added a comment to D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..
In D158807#4641353, @clementval wrote:

Looks like this patch triggers a new failure https://lab.llvm.org/buildbot/#/builders/175/builds/35729

Thu, Sep 7, 9:03 PM · Restricted Project, Restricted Project
raghavendhra committed rG6d1c183c6f8b: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause. (authored by raghavendhra).
[Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause.
Thu, Sep 7, 1:43 PM · Restricted Project, Restricted Project
raghavendhra closed D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..
Thu, Sep 7, 1:42 PM · Restricted Project, Restricted Project

Wed, Aug 30

raghavendhra updated the diff for D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..

Rebasing patch

Wed, Aug 30, 9:47 AM · Restricted Project, Restricted Project

Tue, Aug 29

raghavendhra updated the diff for D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..

Addressed review comments. Changed MAP clause semantic check to run through permutation and
combination of different MAP types and data sharing attribute clauses on
checkExclusiveLists(). Rebased the patch.

Tue, Aug 29, 10:44 PM · Restricted Project, Restricted Project

Mon, Aug 28

raghavendhra added a comment to D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..

Thanks for your review comments Nimish!

Mon, Aug 28, 7:29 AM · Restricted Project, Restricted Project

Aug 24 2023

raghavendhra updated the diff for D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..

Rebasing the patch

Aug 24 2023, 9:29 PM · Restricted Project, Restricted Project
raghavendhra added a reviewer for D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause.: clementval.
Aug 24 2023, 8:19 PM · Restricted Project, Restricted Project
raghavendhra updated the summary of D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..
Aug 24 2023, 8:18 PM · Restricted Project, Restricted Project
raghavendhra requested review of D158807: [Flang] [OpenMP] [Semantics] Add missing semantic check for MAP clause..
Aug 24 2023, 8:11 PM · Restricted Project, Restricted Project

Aug 11 2023

raghavendhra abandoned D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..

setPropertyExecutionMode function is no longer present / used in clang because of a change in https://reviews.llvm.org/D142569 So abandoning this patch to migrate that function into OMPIRBuilder.

Aug 11 2023, 11:55 AM · Restricted Project, Restricted Project, Restricted Project

Aug 9 2023

raghavendhra committed rG9c2d54e96da4: [OpenMP] [Flang] [Semantics] Add a missing semantic check for OMP DISTRIBUTE… (authored by raghavendhra).
[OpenMP] [Flang] [Semantics] Add a missing semantic check for OMP DISTRIBUTE…
Aug 9 2023, 11:04 AM · Restricted Project, Restricted Project
raghavendhra closed D157465: [OpenMP] [Flang] [Semantics] Add a missing semantic check for OMP DISTRIBUTE directive..
Aug 9 2023, 11:03 AM · Restricted Project, Restricted Project

Aug 8 2023

raghavendhra updated the summary of D157465: [OpenMP] [Flang] [Semantics] Add a missing semantic check for OMP DISTRIBUTE directive..
Aug 8 2023, 6:09 PM · Restricted Project, Restricted Project
raghavendhra requested review of D157465: [OpenMP] [Flang] [Semantics] Add a missing semantic check for OMP DISTRIBUTE directive..
Aug 8 2023, 6:04 PM · Restricted Project, Restricted Project

Aug 4 2023

raghavendhra committed rG4068a96b7c78: [OpenMP] [Semantics] [Flang] Fix build error caused by unused variable. (authored by raghavendhra).
[OpenMP] [Semantics] [Flang] Fix build error caused by unused variable.
Aug 4 2023, 1:17 PM · Restricted Project, Restricted Project
raghavendhra closed D157126: [OpenMP] [Semantics] [Flang] Fix build error caused by unused variable..
Aug 4 2023, 1:17 PM · Restricted Project, Restricted Project
raghavendhra added a reviewer for D157126: [OpenMP] [Semantics] [Flang] Fix build error caused by unused variable.: clementval.
Aug 4 2023, 12:02 PM · Restricted Project, Restricted Project
raghavendhra added a comment to D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Addressed this unused variable build error by submitting a new patch https://reviews.llvm.org/D157126

Aug 4 2023, 12:00 PM · Restricted Project, Restricted Project
raghavendhra requested review of D157126: [OpenMP] [Semantics] [Flang] Fix build error caused by unused variable..
Aug 4 2023, 11:56 AM · Restricted Project, Restricted Project
raghavendhra added a comment to D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Sorry! Let me try to fix that ASAP!

Aug 4 2023, 11:08 AM · Restricted Project, Restricted Project

Aug 3 2023

raghavendhra committed rG71d763b88d61: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and… (authored by raghavendhra).
[OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and…
Aug 3 2023, 10:20 PM · Restricted Project, Restricted Project
raghavendhra closed D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..
Aug 3 2023, 10:19 PM · Restricted Project, Restricted Project
raghavendhra updated the diff for D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Final rebase before commit.

Aug 3 2023, 5:44 PM · Restricted Project, Restricted Project
raghavendhra accepted D146648: [MLIR][OpenMP] Added MLIR translation support for use_device clauses.

LGTM

Aug 3 2023, 7:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 27 2023

raghavendhra updated the diff for D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Addressed review comments by moving CheckMultipleOccurences() from lambda to function. Rebased the patch.

Jul 27 2023, 12:53 PM · Restricted Project, Restricted Project

Jul 25 2023

raghavendhra updated the diff for D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..

Remove llvm:: from function setPropertyExecutionMode(). Rebasing the patch.

Jul 25 2023, 11:16 PM · Restricted Project, Restricted Project, Restricted Project

Jul 24 2023

raghavendhra updated the diff for D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..

Addressed review comments by making setPropertyExecutionMode() to return a Global Value instead of void. Rebased patch.

Jul 24 2023, 2:17 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added inline comments to D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..
Jul 24 2023, 12:27 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra accepted D127620: [flang][OpenMP] Added semantic checks for atomic capture, write, and update statements.

LGTM

Jul 24 2023, 7:52 AM · Restricted Project, Restricted Project

Jul 21 2023

raghavendhra updated the diff for D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..

Addressed JP's review comments and rebased.

Jul 21 2023, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added inline comments to D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..
Jul 21 2023, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra updated the diff for D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..

Rebased patch.

Jul 21 2023, 12:48 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra updated the diff for D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..

Addressed review comments.

Jul 21 2023, 12:47 AM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2023

raghavendhra added reviewers for D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.: dpalermo, jsjodin, jplehr, agozillon, skatrak, TIFitis, domada.
Jul 20 2023, 12:57 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra requested review of D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder..
Jul 20 2023, 12:54 AM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2023

raghavendhra abandoned D127037: [OpenMP][IRBuilder][OpenACC] Move common code from OpenACCToLLVMIRTranslation to Utils/DirectiveToLLVMIRTranslation so that it can be used between OpenACC and OpenMP..

This is old and no longer needed as this is taken care by latest revision https://reviews.llvm.org/D142914

Jul 14 2023, 3:26 PM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2023

raghavendhra updated the diff for D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Fixed formatting and rebasing.

Jul 13 2023, 2:15 PM · Restricted Project, Restricted Project

Jul 12 2023

raghavendhra updated the diff for D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Rebase

Jul 12 2023, 4:21 PM · Restricted Project, Restricted Project
raghavendhra updated the diff for D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Rebasing

Jul 12 2023, 4:19 PM · Restricted Project, Restricted Project
raghavendhra updated the diff for D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..

Rebasing and fixed formatting.

Jul 12 2023, 4:15 PM · Restricted Project, Restricted Project
raghavendhra updated the summary of D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..
Jul 12 2023, 3:59 PM · Restricted Project, Restricted Project
raghavendhra requested review of D155133: [OpenMP] [Semantics] [Flang] Adding more semantic checks for USE_DEVICE_PTR and USE_DEVICE_ADDR clauses..
Jul 12 2023, 3:52 PM · Restricted Project, Restricted Project

Jun 29 2023

raghavendhra committed rGf36a25479b5e: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a… (authored by raghavendhra).
[Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a…
Jun 29 2023, 3:25 PM · Restricted Project, Restricted Project
raghavendhra closed D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.
Jun 29 2023, 3:25 PM · Restricted Project, Restricted Project
raghavendhra updated the diff for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Final rebase before commit.

Jun 29 2023, 3:24 PM · Restricted Project, Restricted Project
raghavendhra updated the summary of D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.
Jun 29 2023, 3:24 PM · Restricted Project, Restricted Project

Jun 28 2023

raghavendhra updated the diff for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Removed unused variable and rebased the patch.

Jun 28 2023, 3:28 PM · Restricted Project, Restricted Project
raghavendhra added a comment to D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Thanks for catching that Dominik. :)

Jun 28 2023, 3:28 PM · Restricted Project, Restricted Project

Jun 23 2023

raghavendhra updated the diff for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Addressed https://github.com/llvm/llvm-project/issues/61161 and Rebased the patch

Jun 23 2023, 8:23 PM · Restricted Project, Restricted Project
raghavendhra added a comment to D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.
In D152637#4434384, @domada wrote:

Hi @raghavendhra
could you also address this issue: https://github.com/llvm/llvm-project/issues/61161 ?

Jun 23 2023, 8:22 PM · Restricted Project, Restricted Project
raghavendhra added a comment to D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.
In D152637#4445295, @clementval wrote:

Please update the title. std::list<Name> is not a namelist in the Fortran sense.

Jun 23 2023, 8:21 PM · Restricted Project, Restricted Project
raghavendhra retitled D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist from [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a namelist to Objectlist to [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.
Jun 23 2023, 8:21 PM · Restricted Project, Restricted Project

Jun 22 2023

raghavendhra accepted D152822: [MLIR][OpenMP] Minor change to assembly format for Target Data op.
Jun 22 2023, 7:43 AM · Restricted Project, Restricted Project
raghavendhra accepted D152824: [MLIR][OpenMP]Add Flang lowering support for device_ptr and device_addr clauses.

LGTM

Jun 22 2023, 7:33 AM · Restricted Project, Restricted Project, Restricted Project

Jun 18 2023

raghavendhra updated the diff for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Rebase and addressed review comment to add a test case for not allowing common block name in an ALIGNED clause.

Jun 18 2023, 11:16 PM · Restricted Project, Restricted Project
raghavendhra added a comment to D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.
In D152637#4426952, @NimishMishra wrote:

Thank you for the patch. Should we add tests for this?

Jun 18 2023, 11:14 PM · Restricted Project, Restricted Project

Jun 15 2023

raghavendhra updated the diff for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Rebase

Jun 15 2023, 6:27 AM · Restricted Project, Restricted Project

Jun 13 2023

raghavendhra added a comment to D152822: [MLIR][OpenMP] Minor change to assembly format for Target Data op.

LGTM

Jun 13 2023, 10:45 AM · Restricted Project, Restricted Project

Jun 12 2023

raghavendhra updated the diff for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Rebase

Jun 12 2023, 1:50 AM · Restricted Project, Restricted Project

Jun 10 2023

raghavendhra added reviewers for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist: domada, kiranktp, NimishMishra, kavitha-natarajan, skatrak, clementval, agozillon, jsjodin.
Jun 10 2023, 3:34 PM · Restricted Project, Restricted Project
raghavendhra updated the diff for D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.

Rebasing

Jun 10 2023, 3:30 PM · Restricted Project, Restricted Project
raghavendhra requested review of D152637: [Flang] [OpenMP] [Semantics] Change SIMD ALIGNED clause support from parsing a std::list<Name> to OmpObjectlist.
Jun 10 2023, 3:30 PM · Restricted Project, Restricted Project

May 16 2023

raghavendhra committed rG608fe0b032d9: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr… (authored by raghavendhra).
[Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr…
May 16 2023, 10:42 AM · Restricted Project, Restricted Project
raghavendhra closed D150626: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr test..
May 16 2023, 10:42 AM · Restricted Project, Restricted Project
raghavendhra accepted D150626: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr test..
May 16 2023, 9:21 AM · Restricted Project, Restricted Project

May 15 2023

raghavendhra updated the diff for D150626: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr test..

Rebasing

May 15 2023, 5:09 PM · Restricted Project, Restricted Project
raghavendhra added reviewers for D150626: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr test.: TIFitis, kiranchandramohan, kiranktp.
May 15 2023, 4:52 PM · Restricted Project, Restricted Project
raghavendhra requested review of D150626: [Flang][OpenMP][Semantics] Added missing HostAssoc check for use_device_ptr test..
May 15 2023, 4:50 PM · Restricted Project, Restricted Project

May 10 2023

raghavendhra committed rGf85a8456f114: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on… (authored by raghavendhra).
[OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on…
May 10 2023, 5:18 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra closed D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..
May 10 2023, 5:17 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra updated the diff for D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..

Rebase before commit.

May 10 2023, 1:25 PM · Restricted Project, Restricted Project, Restricted Project

May 8 2023

raghavendhra updated the diff for D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..

Removed changes to use_device_ptr.f90 test and will submit that as separate patch

May 8 2023, 9:55 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added inline comments to D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..
May 8 2023, 9:54 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added inline comments to D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..
May 8 2023, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra updated the diff for D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..

Rebase

May 8 2023, 8:13 AM · Restricted Project, Restricted Project, Restricted Project

May 4 2023

raghavendhra updated the diff for D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..

Rebasing the patch.

May 4 2023, 3:39 PM · Restricted Project, Restricted Project, Restricted Project

May 3 2023

raghavendhra added reviewers for D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive.: kiranktp, TIFitis, clementval, NimishMishra, skatrak.
May 3 2023, 10:23 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra requested review of D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive..
May 3 2023, 10:16 PM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2023

raghavendhra committed rGd6ef90f64c48: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on… (authored by raghavendhra).
[OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on…
Apr 26 2023, 6:17 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra closed D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..
Apr 26 2023, 6:17 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra updated the diff for D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..

Rebased and now ready to land.

Apr 26 2023, 6:16 PM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2023

raghavendhra updated the diff for D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..

Addressed review comments and rebased

Apr 25 2023, 4:44 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added a comment to D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..
In D148254#4290092, @kiranchandramohan wrote:

Also include the reason.

Apr 25 2023, 4:14 PM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2023

raghavendhra updated the diff for D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..

Addressed review comments and rebased

Apr 21 2023, 4:07 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra added a comment to D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..

Addressed review comments and rebased patch

Apr 21 2023, 3:34 PM · Restricted Project, Restricted Project, Restricted Project

Apr 20 2023

raghavendhra added a comment to D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..
In D148254#4284179, @clementval wrote:

Are you planning to implement this check:

A list item that specifies a given variable may not appear in more than one use_device_ptr clause.

Apr 20 2023, 12:47 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2023

raghavendhra added reviewers for D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive.: kiranktp, TIFitis, NimishMishra, clementval.
Apr 13 2023, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra requested review of D148254: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_PTR clause on OMP TARGET DATA directive..
Apr 13 2023, 10:14 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2023

raghavendhra added a comment to D147247: [MLIR][OpenMP] Added map clause support for Target.

LGTM

Mar 30 2023, 10:58 AM · Restricted Project, Restricted Project

Feb 16 2023

raghavendhra accepted D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives..

LGTM

Feb 16 2023, 10:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 15 2023

raghavendhra added inline comments to D144110: [Flang][OpenMP] Fix a corner case where target region is empty.
Feb 15 2023, 2:09 PM · Restricted Project, Restricted Project
raghavendhra accepted D143671: [Flang][OpenMP] Added parser support for device_type clause.

LGTM

Feb 15 2023, 2:04 PM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2023

raghavendhra added inline comments to D143671: [Flang][OpenMP] Added parser support for device_type clause.
Feb 10 2023, 7:11 AM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2023

raghavendhra committed rGb2fb93d6818e: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses. (authored by raghavendhra).
[Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses.
Jan 17 2023, 6:43 AM · Restricted Project, Restricted Project, Restricted Project
raghavendhra closed D141567: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses..
Jan 17 2023, 6:43 AM · Restricted Project, Restricted Project, Restricted Project

Jan 16 2023

raghavendhra updated the diff for D141567: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses..

Rebasing the patch.

Jan 16 2023, 11:39 AM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

raghavendhra added reviewers for D141567: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses.: kiranchandramohan, kiranktp, TIFitis, peixin, NimishMishra, clementval, abidmalikwaterloo.
Jan 11 2023, 10:51 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra requested review of D141567: [Flang] [OpenMP] Refine parser restrictions for OMP TARGET UPDATE clauses..
Jan 11 2023, 10:44 PM · Restricted Project, Restricted Project, Restricted Project
raghavendhra committed rG02023bca7f7d: [Flang] [OpenMP] Add parser support for THREAD_LIMIT clause on OMP TARGET… (authored by raghavendhra).
[Flang] [OpenMP] Add parser support for THREAD_LIMIT clause on OMP TARGET…
Jan 11 2023, 9:07 PM · Restricted Project, Restricted Project, Restricted Project