- User Since
- Mar 10 2016, 1:50 PM (376 w, 2 d)
Either way is fine
Not a strong request, but I assume D151552 has high chance of being reverted. To avoid conflicts, would be nice to land them with a couple of days of delay.
Thu, May 25
If this requires review, the original patch is better to be reverted
bots are broken
Switch to sysconf
After revert we reopen previous review
In the previous snapshot initialization was not thread safe.
and we don't want to inline initialization all over the program
and rename is unnececary
LGTM if it does not break bots
Some more complex alternatives:
- add compiler flag to emit only inline initialization
compiler can emit, but there are passes that replace some common patterns with memset. Probably suppressible with some attributes.
For sanitizer instrumentation we insert tsan_memset, asan_memset... etc
also, isn't D135716 was NOOP as it has a typo?
Please let me know it if this is deserve investigation.
Oh, I rerun msan bot locally and it looked like issue dissipated, but I probably checked wrong logs.
So I enabled -Oz on the bot, to catch more bugs, but the issue is still there https://lab.llvm.org/buildbot/#/builders/5/builds/33926
Wed, May 24
Looking through my unfinished patches, and noticed this one.
I am curious if LocalAddressSpaceView stuff is in use, maybe it's abandoned and can be removed?
@delcypher @thetruestblue @rsundahl
Thanks, LGTM. Could you please update also compiler-rt/test/sanitizer_common/TestCases/allocator_interface.cpp?
This one is more than XFAIL, we have failed test in LSAN which query this stats
Is this by this one D144552 https://lab.llvm.org/buildbot/#/builders/238/builds/3575 ?