In D76919#1947069, @iii wrote:

internal_uname() is available only on Linux right now. I thought it's ok to postpone adding macOS/*BSD/etc implementations until that is really necessary.

Fri, Mar 27, 3:59 PM · Restricted Project

vitalybuka accepted D76919: [compiler-rt] Fall back to internal_uname() when called early.

Fri, Mar 27, 3:59 PM · Restricted Project

vitalybuka added inline comments to D76919: [compiler-rt] Fall back to internal_uname() when called early.

Fri, Mar 27, 1:43 PM · Restricted Project

Wed, Mar 25

vitalybuka accepted D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..

Wed, Mar 25, 10:11 PM · Restricted Project

vitalybuka added inline comments to D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..

Wed, Mar 25, 8:35 PM · Restricted Project

vitalybuka accepted D71687: Fix full loop unrolling initialization in new pass manager.

Can this be landed?

Wed, Mar 25, 1:32 PM · Restricted Project, Restricted Project

GitHub <noreply@github.com> committed rZORG857d592f5e81: Move all builders from gribozavr5 to gribozavr4 (authored by vitalybuka).

Move all builders from gribozavr5 to gribozavr4

Wed, Mar 25, 12:59 PM

Tue, Mar 24

vitalybuka added inline comments to D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue..

Tue, Mar 24, 10:24 PM · Restricted Project

vitalybuka accepted D76666: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary..

Tue, Mar 24, 1:28 PM · Restricted Project

vitalybuka accepted D76666: Add a `Symbolizer::GetEnvP()` method that allows symbolizer implementations to customise the environment of the symbolizer binary..

Tue, Mar 24, 2:07 AM · Restricted Project

Mon, Mar 23

vitalybuka resigned from D76624: [MSan] Add instrumentation for SystemZ.

LGTM

Mon, Mar 23, 1:38 PM · Restricted Project

vitalybuka accepted D76358: [MSan] Enable for SystemZ.

Mon, Mar 23, 1:38 PM · Restricted Project

vitalybuka committed rG5f5fb56c68e4: [compiler-rt] Intercept the uname() function (authored by iii).

[compiler-rt] Intercept the uname() function

Mon, Mar 23, 1:07 PM

vitalybuka committed rGcfaa84e1a679: Fix "previously declared as a struct" warning (authored by vitalybuka).

Fix "previously declared as a struct" warning

Mon, Mar 23, 1:07 PM

vitalybuka closed D76578: [compiler-rt] Intercept the uname() function.

Mon, Mar 23, 1:07 PM · Restricted Project

vitalybuka updated the summary of D76578: [compiler-rt] Intercept the uname() function.

Mon, Mar 23, 1:06 PM · Restricted Project

Sun, Mar 22

vitalybuka accepted D76578: [compiler-rt] Intercept the uname() function.

Sun, Mar 22, 7:20 PM · Restricted Project

Fri, Mar 20

vitalybuka added inline comments to D73776: Entropic: Boosting LibFuzzer Performance.

Fri, Mar 20, 1:03 AM · Restricted Project

Thu, Mar 19

vitalybuka added inline comments to D76358: [MSan] Enable for SystemZ.

Thu, Mar 19, 10:26 PM · Restricted Project

vitalybuka added inline comments to D76358: [MSan] Enable for SystemZ.

Thu, Mar 19, 2:15 PM · Restricted Project

Wed, Mar 18

vitalybuka added a comment to D74128: AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize.

Why?
I do that to help you to notice that is was reverted. It's trivial to close them whenever you want.

Wed, Mar 18, 11:57 AM · Restricted Project

Tue, Mar 17

vitalybuka committed rG9bca8fc4cf5d: Revert "AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize" (authored by vitalybuka).

Revert "AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize"

Tue, Mar 17, 10:09 PM

vitalybuka added a reverting change for rGd0fe13ecf9a4: AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize: rG9bca8fc4cf5d: Revert "AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize".

Tue, Mar 17, 10:09 PM

vitalybuka added a comment to D74128: AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize.

reverted 9bca8fc4cf5d290b576618d14a105fafe80cf5ae

Tue, Mar 17, 10:08 PM · Restricted Project

vitalybuka added inline comments to D74128: AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize.

Tue, Mar 17, 9:36 PM · Restricted Project

vitalybuka reopened D74128: AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize.

==60948==ERROR: AddressSanitizer: use-after-poison on address 0x6210004a8ce8 at pc 0x00000720aed7 bp 0x7ffc3bd86520 sp 0x7ffc3bd86518
READ of size 8 at 0x6210004a8ce8 thread T0
    #0 0x720aed6 in getOpcode /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/CodeGen/MachineInstr.h:430:39
    #1 0x720aed6 in createdOrChangedInstr /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:103:35
    #2 0x720aed6 in (anonymous namespace)::LegalizerWorkListManager::changedInstr(llvm::MachineInstr&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:139:5
    #3 0x18b2d2e in changedInstr /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h:97:10
    #4 0x18b2d2e in non-virtual thunk to llvm::GISelObserverWrapper::changedInstr(llvm::MachineInstr&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h
    #5 0x18a7562 in operator() /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:3483:54
    #6 0x18a7562 in ~scope_exit /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/ADT/ScopeExit.h:45:7
    #7 0x18a7562 in llvm::AMDGPULegalizerInfo::legalizeImageIntrinsic(llvm::MachineInstr&, llvm::MachineIRBuilder&, llvm::GISelChangeObserver&, llvm::AMDGPU::ImageDimIntrinsicInfo const*) const /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:3759:1
    #8 0x18ab5a8 in llvm::AMDGPULegalizerInfo::legalizeIntrinsic(llvm::MachineInstr&, llvm::MachineIRBuilder&, llvm::GISelChangeObserver&) const /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4048:14
    #9 0x721506c in llvm::LegalizerHelper::legalizeInstrStep(llvm::MachineInstr&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:107:15
    #10 0x720358e in llvm::Legalizer::legalizeMachineFunction(llvm::MachineFunction&, llvm::LegalizerInfo const&, llvm::ArrayRef<llvm::GISelChangeObserver*>, llvm::MachineIRBuilder&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:207:25
    #11 0x7209280 in llvm::Legalizer::runOnMachineFunction(llvm::MachineFunction&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:312:21
    #12 0x45e42ad in llvm::MachineFunctionPass::runOnFunction(llvm::Function&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:73:13
    #13 0x5165330 in llvm::FPPassManager::runOnFunction(llvm::Function&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1482:27
    #14 0x3ae6386 in RunPassOnSCC /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Analysis/CallGraphSCCPass.cpp:176:25
    #15 0x3ae6386 in RunAllPassesOnSCC /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Analysis/CallGraphSCCPass.cpp:441:16
    #16 0x3ae6386 in (anonymous namespace)::CGPassManager::runOnModule(llvm::Module&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Analysis/CallGraphSCCPass.cpp:497:18

Tue, Mar 17, 9:36 PM · Restricted Project

vitalybuka reopened D75712: Avoid emitting unreachable SP adjustments after `throw`.

This patch breaks windows bot http://lab.llvm.org:8011/builders/sanitizer-windows/builds/59930

FAIL: AddressSanitizer-x86_64-windows :: TestCases/intercept-rethrow-exception.cpp (585 of 651)
******************** TEST 'AddressSanitizer-x86_64-windows :: TestCases/intercept-rethrow-exception.cpp' FAILED ********************
Script:
--
: 'RUN: at line 4';      C:/b/slave/sanitizer-windows/build/stage1/./bin/clang.exe  -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -gcodeview -gcolumn-info    -fexceptions -O0 C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\intercept-rethrow-exception.cpp -o C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output\intercept-rethrow-exception.cpp.tmp
: 'RUN: at line 5';    C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output\intercept-rethrow-exception.cpp.tmp
--
Exit Code: 255

Tue, Mar 17, 3:07 PM · Restricted Project

Mon, Mar 16

GitHub <noreply@github.com> committed rZORGe885287f6dea: [sanitizer, android] Mark arch as tested before testing (authored by vitalybuka).

[sanitizer, android] Mark arch as tested before testing

Mon, Mar 16, 11:26 PM

vitalybuka committed rG8620bb953434: [lld] Fix "loop variable creates a copy" warning (authored by vitalybuka).

[lld] Fix "loop variable creates a copy" warning

Mon, Mar 16, 11:26 PM

vitalybuka committed rGf20dcc31e31f: Fix unused function warning (authored by vitalybuka).

Fix unused function warning

Mon, Mar 16, 8:13 PM

vitalybuka committed rGf0714cbb6a91: [sanitizer] Fix warning on windows (authored by vitalybuka).

[sanitizer] Fix warning on windows

Mon, Mar 16, 7:40 PM

Feb 28 2020

vitalybuka accepted D75363: [DFSan] Add __dfsan_load_callback..

Feb 28 2020, 10:51 AM · Restricted Project, Restricted Project

Feb 27 2020

vitalybuka accepted D75312: [DFSan] Add flag to insert event callbacks..

Feb 27 2020, 4:29 PM · Restricted Project, Restricted Project

vitalybuka added inline comments to D73776: Entropic: Boosting LibFuzzer Performance.

Feb 27 2020, 2:15 PM · Restricted Project

Feb 25 2020

vitalybuka accepted D32175: Add the llvm asan support.

Feb 25 2020, 12:01 PM · Restricted Project

vitalybuka added a comment to D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support.

Looks like several independent patches, could you spit them, with descriptions explaining why existing values are not good enough?
Could you also add into description test names which switch from FAIL to PASS with your changes. I assume code as-is fails some tests on the platform. If not we need new tests.

Feb 25 2020, 12:01 PM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2020

vitalybuka accepted D74828: tsan: fix pthread_detach with called_from_lib suppressions.

Feb 24 2020, 11:07 AM · Restricted Project

Feb 19 2020

vitalybuka added a comment to D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue.

This patch is likely the reason for http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/38846

Feb 19 2020, 2:09 PM · Restricted Project

Feb 10 2020

vitalybuka added a reviewer for D74361: [Clang] Undef attribute for global variables: jfb.

Feb 10 2020, 5:09 PM · Restricted Project

vitalybuka accepted D73329: [libFuzzer] communicate through pipe to subprocess for MinimizeCrashInput.

Feb 10 2020, 1:30 PM · Restricted Project, Restricted Project

Feb 6 2020

vitalybuka accepted D74137: [compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp..

Feb 6 2020, 3:04 PM · Restricted Project, Restricted Project

Feb 4 2020

vitalybuka added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

Feb 4 2020, 1:18 PM · Restricted Project, Restricted Project

Feb 3 2020

vitalybuka accepted D73513: [memtag] Plug in stack safety analysis..

Feb 3 2020, 6:22 PM · Restricted Project, Restricted Project

vitalybuka accepted D73707: [TSAN] Parameterize the hard-coded threshold of deflake in tsan test.

LGTM

Feb 3 2020, 6:13 PM · Restricted Project, Restricted Project

vitalybuka accepted D73823: hwasan_symbolize: allow 0x in the address field.

Feb 3 2020, 6:04 PM · Restricted Project, Restricted Project

vitalybuka accepted D73822: hwasan_symbolize: warn about missing symbols at most once per library.

Feb 3 2020, 6:04 PM · Restricted Project, Restricted Project

vitalybuka added a reviewer for D73776: Entropic: Boosting LibFuzzer Performance: vitalybuka.

Feb 3 2020, 5:54 PM · Restricted Project

Jan 27 2020

vitalybuka accepted D73394: Fix StackSafetyAnalysis crash with scalable vector types..

Jan 27 2020, 3:04 PM · Restricted Project

vitalybuka accepted D73395: Support zero size types in StackSafetyAnalysis..

Jan 27 2020, 3:02 PM · Restricted Project

vitalybuka accepted D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Jan 27 2020, 12:35 PM · Restricted Project, Restricted Project

Jan 24 2020

vitalybuka accepted D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code.

Jan 24 2020, 1:41 AM · Restricted Project, Restricted Project

Jan 21 2020

vitalybuka added inline comments to D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Jan 21 2020, 6:46 PM · Restricted Project, Restricted Project

vitalybuka accepted D72988: [lsan] Expose Frontier object to OS-specific LockStuffAndStopTheWorld callback.

Jan 21 2020, 6:11 PM · Restricted Project, Restricted Project

vitalybuka accepted D72886: [sanitizer_common] Implement MemoryMappingLayout for Fuchsia.

Jan 21 2020, 6:11 PM · Restricted Project, Restricted Project

Jan 16 2020

vitalybuka added inline comments to D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.

Jan 16 2020, 5:37 PM · Restricted Project, Restricted Project

vitalybuka added a reviewer for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia: vitalybuka.

Jan 16 2020, 5:37 PM · Restricted Project, Restricted Project

Jan 14 2020

vitalybuka added a comment to D68115: Zero initialize padding in unions.

In D68115#1820579, @aaron.ballman wrote:

In D68115#1820462, @vitalybuka wrote:

I would be happy to finish this patch if we agree on something.

So if I understand this the proposal is to have something like -fzero-union-padding which is off by default.
When it's OFF compiler will continue to do whatever it does now.
When it's ON it will set zeroes into padding with or without -ftrivial-auto-var-init.
Is this correct?

In general, I believe so, yes. To be clear, it only sets zeros into union padding, not *all* padding. I do not have an opinion on whether we want it to be -fzero-union-padding as opposed to -finit-union-padding that honors the pattern from -ftrivial-auto-init=pattern and defaults to zero if no pattern is specified.

Jan 14 2020, 1:56 PM · Restricted Project

vitalybuka added a comment to D68115: Zero initialize padding in unions.

In D68115#1819418, @aaron.ballman wrote:

In D68115#1811091, @lebedev.ri wrote:

In D68115#1811089, @hubert.reinterpretcast wrote:

In D68115#1810891, @lebedev.ri wrote:

Does this have to be an unilateral change,
likely penalizing non--ftrivial-auto-var-init= cases,
i.e. [why] can't it be only done for when -ftrivial-auto-var-init= is enabled?

We left off near that conclusion (https://reviews.llvm.org/D68115#1686887);

Would be great if @rsmith / @aaron.ballman could comment on that

I don't have super strong opinions on it, but I think a separate feature for zeroing union padding is what gives users the most flexibility.

In D68115#1811089, @hubert.reinterpretcast wrote:

A separate option to control zeroing for union padding would help in cases where the zeroing does not happen for reasons other than -ftrivial-auto-var-init.

Agreed.

Jan 14 2020, 12:59 PM · Restricted Project

Jan 8 2020

vitalybuka added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

This patch is causing problems on Window bot: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/56324

Jan 8 2020, 11:45 AM · Restricted Project

Jan 7 2020

vitalybuka added a reviewer for D72367: Summary: update macro for OFF_T so that sanitizer works on AARCH64.: eugenis.

Sanitizers should work for aarch64, we have build bot for that
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android

Jan 7 2020, 4:09 PM · Restricted Project, Restricted Project

Jan 6 2020

vitalybuka accepted D71780: [msan] Check qsort input..

what is about clang-format?

Jan 6 2020, 2:07 PM · Restricted Project, Restricted Project

Dec 26 2019

vitalybuka accepted D71780: [msan] Check qsort input..

Dec 26 2019, 1:10 PM · Restricted Project, Restricted Project

Dec 20 2019

vitalybuka accepted D71780: [msan] Check qsort input..

nice

Dec 20 2019, 12:34 PM · Restricted Project, Restricted Project

vitalybuka accepted D71740: [msan] Intercept qsort, qsort_r..

Dec 20 2019, 12:23 PM · Restricted Project, Restricted Project

vitalybuka added inline comments to D71740: [msan] Intercept qsort, qsort_r..

Dec 20 2019, 11:11 AM · Restricted Project, Restricted Project

vitalybuka added inline comments to D71740: [msan] Intercept qsort, qsort_r..

Dec 20 2019, 11:11 AM · Restricted Project, Restricted Project

Dec 19 2019

vitalybuka added inline comments to D71740: [msan] Intercept qsort, qsort_r..

Dec 19 2019, 6:08 PM · Restricted Project, Restricted Project

Dec 17 2019

vitalybuka added inline comments to D71368: [ MC ] Match labels to existing fragments even when switching sections..

Dec 17 2019, 2:08 PM · Restricted Project

Dec 10 2019

vitalybuka accepted D71275: [SanitizerCommon] Reduce wasting memory in LowLevelAllocator..

Dec 10 2019, 12:37 PM · Restricted Project, Restricted Project

Dec 6 2019

vitalybuka added a comment to D70738: [libFuzzer] Add custom output function.

You can consider just to link needed code into small binary which will printout serialized inputs from the drive. And call that e.g. in the following way: