Page MenuHomePhabricator
People vitalybuka

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (237 w, 1 d)

Recent Activity
View All

Yesterday

vitalybuka committed rG152ff3772c2b: [msan] Skip memcpy interceptor called by gethostname (authored by vitalybuka).
[msan] Skip memcpy interceptor called by gethostname
Fri, Sep 25, 3:26 PM
vitalybuka closed D88284: [msan] Skip memcpy interceptor called by gethostname.
Fri, Sep 25, 3:26 PM · Restricted Project
vitalybuka added inline comments to D88284: [msan] Skip memcpy interceptor called by gethostname.
Fri, Sep 25, 3:25 PM · Restricted Project
vitalybuka updated the diff for D88284: [msan] Skip memcpy interceptor called by gethostname.

undo unrelated changes for real

Fri, Sep 25, 3:13 PM · Restricted Project
vitalybuka updated the diff for D88284: [msan] Skip memcpy interceptor called by gethostname.

undo unrelated changes

Fri, Sep 25, 3:11 PM · Restricted Project
vitalybuka updated the diff for D88284: [msan] Skip memcpy interceptor called by gethostname.

corrected fix

Fri, Sep 25, 3:10 PM · Restricted Project
vitalybuka committed rG7af12015ad44: [msan] Remove redundant test (authored by vitalybuka).
[msan] Remove redundant test
Fri, Sep 25, 2:40 AM
vitalybuka committed rG3a98f4dca7ad: [msan] Fix gethostent tests (authored by vitalybuka).
[msan] Fix gethostent tests
Fri, Sep 25, 2:40 AM
vitalybuka requested review of D88284: [msan] Skip memcpy interceptor called by gethostname.
Fri, Sep 25, 1:40 AM · Restricted Project

Thu, Sep 24

vitalybuka added inline comments to D88184: [lsan] Add interceptor for pthread_detach..
Thu, Sep 24, 8:10 PM · Restricted Project
vitalybuka accepted D88184: [lsan] Add interceptor for pthread_detach..

LGTM with simplified test

Thu, Sep 24, 8:08 PM · Restricted Project
vitalybuka added a comment to D88184: [lsan] Add interceptor for pthread_detach..

I tested and it's now the slowest lsan test.
Looks like this is enough and make the test faster.

Thu, Sep 24, 8:08 PM · Restricted Project
vitalybuka added inline comments to D88184: [lsan] Add interceptor for pthread_detach..
Thu, Sep 24, 7:33 PM · Restricted Project
vitalybuka accepted D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Thu, Sep 24, 1:59 AM · Restricted Project
vitalybuka added a comment to D88184: [lsan] Add interceptor for pthread_detach..

lsan patch is LGTM but I am not sure how this test verity that it's actually reused

Thu, Sep 24, 1:54 AM · Restricted Project
vitalybuka added a comment to D87795: [lsan] Share platform allocator settings between ASan and LSan.

it's LGTM as-is

Thu, Sep 24, 1:41 AM · Restricted Project
vitalybuka resigned from D87997: [RISCV][crt] support building without init_array.

Actually I not appropriate reviewer for this one

Thu, Sep 24, 1:30 AM · Restricted Project

Tue, Sep 22

vitalybuka committed rG809a42e3d535: [RISCV][ASAN] implementation of ThreadSelf for riscv64 (authored by EccoTheDolphin).
[RISCV][ASAN] implementation of ThreadSelf for riscv64
Tue, Sep 22, 11:52 PM
vitalybuka committed rGd721a2bc335a: [NFC] Reformat preprocessor directives (authored by vitalybuka).
[NFC] Reformat preprocessor directives
Tue, Sep 22, 11:52 PM
vitalybuka added a reverting change for rG00f6ebef6e34: [RISCV][ASAN] implementation of ThreadSelf for riscv64: rG1fbb59694244: Revert "[RISCV][ASAN] implementation of ThreadSelf for riscv64".
Tue, Sep 22, 11:51 PM
vitalybuka committed rG1fbb59694244: Revert "[RISCV][ASAN] implementation of ThreadSelf for riscv64" (authored by vitalybuka).
Revert "[RISCV][ASAN] implementation of ThreadSelf for riscv64"
Tue, Sep 22, 11:51 PM
vitalybuka added a reverting change for D87575: [RISCV][ASAN] implementation of ThreadSelf for riscv64: rG1fbb59694244: Revert "[RISCV][ASAN] implementation of ThreadSelf for riscv64".
Tue, Sep 22, 11:51 PM · Restricted Project
vitalybuka added inline comments to D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.
Tue, Sep 22, 11:07 PM · Restricted Project
vitalybuka committed rG00f6ebef6e34: [RISCV][ASAN] implementation of ThreadSelf for riscv64 (authored by EccoTheDolphin).
[RISCV][ASAN] implementation of ThreadSelf for riscv64
Tue, Sep 22, 10:32 PM
vitalybuka closed D87575: [RISCV][ASAN] implementation of ThreadSelf for riscv64.
Tue, Sep 22, 10:32 PM · Restricted Project
vitalybuka committed rGaa1b1d35cbf6: [RISCV][ASAN] implementation for vfork interceptor for riscv64 (authored by smd).
[RISCV][ASAN] implementation for vfork interceptor for riscv64
Tue, Sep 22, 10:23 PM
vitalybuka closed D87574: [RISCV][ASAN] implementation for vfork interceptor for riscv64.
Tue, Sep 22, 10:23 PM · Restricted Project
vitalybuka committed rG96034cb3d1d6: [RISCV][ASAN] implementation of clone interceptor for riscv64 (authored by EccoTheDolphin).
[RISCV][ASAN] implementation of clone interceptor for riscv64
Tue, Sep 22, 10:11 PM
vitalybuka closed D87573: [RISCV][ASAN] implementation of clone interceptor for riscv64.
Tue, Sep 22, 10:11 PM · Restricted Project
vitalybuka committed rG6c22d00d7896: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64 (authored by EccoTheDolphin).
[RISCV][ASAN] implementation of internal syscalls wrappers for riscv64
Tue, Sep 22, 9:59 PM
vitalybuka closed D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64.
Tue, Sep 22, 9:58 PM · Restricted Project
vitalybuka committed rGdfd295431a50: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform (authored by EccoTheDolphin).
[RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform
Tue, Sep 22, 9:44 PM
vitalybuka closed D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.
Tue, Sep 22, 9:44 PM · Restricted Project
vitalybuka accepted D87998: [RISCV][ASAN] updated platform macros to simplify detection of RISCV64 platform.
Tue, Sep 22, 9:22 PM · Restricted Project
vitalybuka added a comment to D87795: [lsan] Share platform allocator settings between ASan and LSan.
In D87795#2289139, @filcab wrote:

Please don’t do this. You’re adding a dependency between asan and lsan, and

This dependency already exists in asan_allocator.cpp

Tue, Sep 22, 8:00 PM · Restricted Project
vitalybuka accepted D87582: [RISCV][ASAN] mark asan as supported for RISCV64 and enable tests.
Tue, Sep 22, 6:02 PM · Restricted Project

Mon, Sep 21

vitalybuka added a comment to D88056: [gn build] Allow option to build with asan/tsan/ubsan.
In D88056#2286473, @vitalybuka wrote:
In D88056#2286450, @aeubanks wrote:

I got asan to fire on some out of bounds stuff with this change, but couldn't get ubsan to trigger on integer overflow for some reason. -fsanitize=undefined is in the ninja files, so maybe I just didn't trip it in the right way.

Mon, Sep 21, 4:44 PM · Restricted Project
vitalybuka added a comment to D88056: [gn build] Allow option to build with asan/tsan/ubsan.
In D88056#2286450, @aeubanks wrote:

I got asan to fire on some out of bounds stuff with this change, but couldn't get ubsan to trigger on integer overflow for some reason. -fsanitize=undefined is in the ninja files, so maybe I just didn't trip it in the right way.

Mon, Sep 21, 4:40 PM · Restricted Project
vitalybuka accepted D87573: [RISCV][ASAN] implementation of clone interceptor for riscv64.
Mon, Sep 21, 1:49 AM · Restricted Project
vitalybuka added a comment to D87572: [RISCV][ASAN] implementation of internal syscalls wrappers for riscv64.

LGTM

Mon, Sep 21, 1:49 AM · Restricted Project
vitalybuka accepted D87997: [RISCV][crt] support building without init_array.
Mon, Sep 21, 1:39 AM · Restricted Project

Fri, Sep 18

vitalybuka added a comment to D87754: [Lsan] Use fp registers to search for pointers.

Thanks! Should be fixed now 034781f7f33634918025206427e6ee912ef3985b

Fri, Sep 18, 5:25 PM · Restricted Project
vitalybuka committed rG034781f7f336: [NFC][LSan] Add REQUIRES: linux (authored by vitalybuka).
[NFC][LSan] Add REQUIRES: linux
Fri, Sep 18, 5:24 PM
vitalybuka added inline comments to rG798eb71c3a5a: [NFC][StackSafety] Dedup callees.
Fri, Sep 18, 5:11 PM
vitalybuka committed rG97bfac076a06: [NFC][StackSafety] Replace auto with type (authored by vitalybuka).
[NFC][StackSafety] Replace auto with type
Fri, Sep 18, 5:11 PM
vitalybuka committed rG3ab118a57d38: [NFC][Asan] Fix test broken by RegAllocFast (authored by vitalybuka).
[NFC][Asan] Fix test broken by RegAllocFast
Fri, Sep 18, 4:50 PM
vitalybuka added inline comments to D87792: [sanitizer] Add facility to print the full StackDepot.
Fri, Sep 18, 3:32 PM · Restricted Project
vitalybuka added a comment to D87792: [sanitizer] Add facility to print the full StackDepot.
In D87792#2281863, @tejohnson wrote:
In D87792#2281271, @vitalybuka wrote:

I lost connection to my Win box in the office. I will need Windows build
next week anyway. I will try to figure out why stderr is not captured there.
For now I relanded your patch and disabled the test on Windows.

Thanks @vitalybuka. [For my records: I see that you recommitted the patch in rGa90229d6cee8 and then disabled the test for windows in e259f7b88266572aaf00cfc1ff7fe88a9fdb1c7a]

Question on your recommit - I see you changed it to use testing::internal::CaptureStderr() and testing::internal::GetCapturedStderr() instead of EXPECT_EXIT. I had originally written the test using those interfaces in fact, but then read that they are internal testing APIs only for internal gtest testing and shouldn't be used outside of it. e.g. https://groups.google.com/g/googletestframework/c/7OTybZo-jp8. Should we change it back to the EXPECT_EXIT approach?

Fri, Sep 18, 3:30 PM · Restricted Project
vitalybuka committed rG82827244e9bb: [NFC][sanitizer] Don't use ::testing::internal (authored by vitalybuka).
[NFC][sanitizer] Don't use ::testing::internal
Fri, Sep 18, 3:26 PM
vitalybuka committed rG516d75743205: [msan][asan] Add runtime flag intercept_strcmp (authored by vitalybuka).
[msan][asan] Add runtime flag intercept_strcmp
Fri, Sep 18, 1:46 PM
vitalybuka closed D87897: [msan][asan] Add runtime flag intercept_strcmp.
Fri, Sep 18, 1:46 PM · Restricted Project
vitalybuka requested review of D87897: [msan][asan] Add runtime flag intercept_strcmp.
Fri, Sep 18, 3:04 AM · Restricted Project
vitalybuka added a comment to D87792: [sanitizer] Add facility to print the full StackDepot.

I lost connection to my Win box in the office. I will need Windows build
next week anyway. I will try to figure out why stderr is not captured there.
For now I relanded your patch and disabled the test on Windows.

Fri, Sep 18, 1:47 AM · Restricted Project
vitalybuka committed rGc0e7f6468578: [NFC][gotsan] Fix 'format' error (authored by vitalybuka).
[NFC][gotsan] Fix 'format' error
Fri, Sep 18, 1:19 AM
vitalybuka committed rGe259f7b88266: [NFC][sanitizer] Disable a test on Windows (authored by vitalybuka).
[NFC][sanitizer] Disable a test on Windows
Fri, Sep 18, 1:10 AM
vitalybuka committed rGa90229d6cee8: [sanitizer] Add facility to print the full StackDepot (authored by tejohnson).
[sanitizer] Add facility to print the full StackDepot
Fri, Sep 18, 12:51 AM
vitalybuka committed rGf16c4a3704f2: [NFC][fuzzer] Simplify StrcmpTest.cpp (authored by vitalybuka).
[NFC][fuzzer] Simplify StrcmpTest.cpp
Fri, Sep 18, 12:37 AM

Thu, Sep 17

vitalybuka updated subscribers of D87792: [sanitizer] Add facility to print the full StackDepot.

I have a windows box, I'll take a look.
fuzzer looks like a flake, I started rebuild on the same revision
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/39189

Thu, Sep 17, 10:10 PM · Restricted Project
vitalybuka committed rG55edf7039e22: [NFC] clang-format one line (authored by vitalybuka).
[NFC] clang-format one line
Thu, Sep 17, 6:05 PM
vitalybuka committed rG03358becbf22: [NFC][Lsan] Fix zero-sized array compilation error (authored by vitalybuka).
[NFC][Lsan] Fix zero-sized array compilation error
Thu, Sep 17, 6:00 PM
vitalybuka accepted D87792: [sanitizer] Add facility to print the full StackDepot.
Thu, Sep 17, 5:40 PM · Restricted Project
vitalybuka accepted D87849: [DFSan] Add strpbrk wrapper..
Thu, Sep 17, 3:52 PM · Restricted Project
vitalybuka added inline comments to D87792: [sanitizer] Add facility to print the full StackDepot.
Thu, Sep 17, 3:42 PM · Restricted Project
vitalybuka added inline comments to D87792: [sanitizer] Add facility to print the full StackDepot.
Thu, Sep 17, 3:39 PM · Restricted Project
vitalybuka committed rG5813fca10760: [Lsan] Use fp registers to search for pointers (authored by vitalybuka).
[Lsan] Use fp registers to search for pointers
Thu, Sep 17, 12:16 PM
vitalybuka closed D87754: [Lsan] Use fp registers to search for pointers.
Thu, Sep 17, 12:16 PM · Restricted Project

Wed, Sep 16

vitalybuka added a comment to D87754: [Lsan] Use fp registers to search for pointers.
In D87754#2278416, @oontvoo wrote:
In D87754#2278243, @vitalybuka wrote:

FYI @eugenis @oontvoo
Maybe we need this for Android as well

Do you mean we'll need to handle the aarch64 case?

Yes.

Wed, Sep 16, 9:00 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

simplify asm

Wed, Sep 16, 6:46 PM · Restricted Project
vitalybuka added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 6:40 PM · Restricted Project
vitalybuka added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 6:39 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

comments

Wed, Sep 16, 6:38 PM · Restricted Project
vitalybuka added a comment to D87795: [lsan] Share platform allocator settings between ASan and LSan.
In D87795#2278297, @mcgrathr wrote:
In D87795#2278286, @vitalybuka wrote:

can you please clang format this?

I had avoided it because I was moving existing code verbatim. But I'll do it now.

Wed, Sep 16, 6:29 PM · Restricted Project
vitalybuka added inline comments to D87795: [lsan] Share platform allocator settings between ASan and LSan.
Wed, Sep 16, 6:28 PM · Restricted Project
vitalybuka added a comment to D87795: [lsan] Share platform allocator settings between ASan and LSan.

can you please clang format this?

Wed, Sep 16, 6:18 PM · Restricted Project
vitalybuka accepted D87792: [sanitizer] Add facility to print the full StackDepot.

LGTM

Wed, Sep 16, 6:17 PM · Restricted Project
vitalybuka accepted D87801: [DFSan] Add bcmp wrapper..
Wed, Sep 16, 6:15 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

convert into lambda to avoid guarding unused function with ARCH_IOVEC_FOR_GETREGSET

Wed, Sep 16, 6:11 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

restore VReport for PTRACE_GETREGS

Wed, Sep 16, 6:04 PM · Restricted Project
vitalybuka updated subscribers of D87754: [Lsan] Use fp registers to search for pointers.

FYI @eugenis @oontvoo
Maybe we need this for Android as well

Wed, Sep 16, 5:53 PM · Restricted Project
vitalybuka updated the summary of D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 5:52 PM · Restricted Project
vitalybuka added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 5:46 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

restore sched_yield()

Wed, Sep 16, 5:46 PM · Restricted Project
vitalybuka updated the summary of D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 5:42 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

test

Wed, Sep 16, 5:41 PM · Restricted Project
vitalybuka accepted D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
Wed, Sep 16, 2:15 PM · Restricted Project
vitalybuka added a comment to D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
In D87568#2269792, @krytarowski wrote:

std::atomic_is_lock_free or an reimplementation of it (without pulling C++ runtime), testing a type and asserting that in runtime or build time that it is lockfree.

https://en.cppreference.com/w/cpp/atomic/atomic_is_lock_free

Wed, Sep 16, 2:14 PM · Restricted Project
vitalybuka accepted D87602: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT.

LGTM if it works

Wed, Sep 16, 2:08 PM · Restricted Project
vitalybuka accepted D87562: [compiler-rt] Replace INLINE with inline.

Can you please clang format it as well

Wed, Sep 16, 2:05 PM · Restricted Project
vitalybuka committed rGcd13476ab57b: [NFC][LSAN] Change SuspendedThreadsList interface (authored by vitalybuka).
[NFC][LSAN] Change SuspendedThreadsList interface
Wed, Sep 16, 2:01 PM
vitalybuka closed D87747: [NFC][LSAN] Change SuspendedThreadsList interface.
Wed, Sep 16, 2:01 PM · Restricted Project
vitalybuka added inline comments to D87105: [sanitizers][Windows] Better debug output and continuable option for interception failures on Windows.
Wed, Sep 16, 1:53 PM · Restricted Project
vitalybuka accepted D87715: [sanitizers][windows] Clang-Format asan_malloc_win.
Wed, Sep 16, 1:30 PM
vitalybuka accepted D86171: [lsan] On Fuchsia, don't use atexit hook for leak checks.
Wed, Sep 16, 1:30 PM · Restricted Project
vitalybuka added a comment to D87747: [NFC][LSAN] Change SuspendedThreadsList interface.
In D87747#2277088, @morehouse wrote:

LGTM. Was this causing any issues, or is this just a refactor?

Wed, Sep 16, 12:46 PM · Restricted Project
vitalybuka requested review of D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 3:30 AM · Restricted Project
vitalybuka updated the diff for D87747: [NFC][LSAN] Change SuspendedThreadsList interface.
RoundUpTo
Wed, Sep 16, 1:38 AM · Restricted Project
vitalybuka updated the diff for D87747: [NFC][LSAN] Change SuspendedThreadsList interface.

fix ProcessThreads

Wed, Sep 16, 1:25 AM · Restricted Project
vitalybuka requested review of D87747: [NFC][LSAN] Change SuspendedThreadsList interface.
Wed, Sep 16, 1:16 AM · Restricted Project
vitalybuka added a reverting change for rG1d70984fa220: [Asan] Accept __lsan_ignore_object for redzone pointer: rGa8a85166d81f: Revert "[Asan] Accept __lsan_ignore_object for redzone pointer".
Wed, Sep 16, 12:37 AM
vitalybuka committed rGa8a85166d81f: Revert "[Asan] Accept __lsan_ignore_object for redzone pointer" (authored by vitalybuka).
Revert "[Asan] Accept __lsan_ignore_object for redzone pointer"
Wed, Sep 16, 12:37 AM