vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (96 w, 5 d)

Recent Activity

Today

vitalybuka added a comment to D42064: Add new NetBSD interceptors: getgrouplist(3) & getgroupmembership(3).

Tests?

Tue, Jan 16, 5:16 PM · Restricted Project
vitalybuka added a comment to D42066: Add new interceptor: acct(2).

Could you please don't copy man into the summary?

Tue, Jan 16, 5:14 PM · Restricted Project
vitalybuka added a comment to D42064: Add new NetBSD interceptors: getgrouplist(3) & getgroupmembership(3).

Could you please remove copied man page from the summary? Not sure about licences there.

Tue, Jan 16, 5:13 PM · Restricted Project
vitalybuka added a comment to D42066: Add new interceptor: acct(2).

Oh, maybe test?

Tue, Jan 16, 5:11 PM · Restricted Project
vitalybuka accepted D42066: Add new interceptor: acct(2).
Tue, Jan 16, 5:01 PM · Restricted Project
vitalybuka accepted D37631: [libFuzzer] Support using libc++.

Vitaly, does this test clean on your end now?

Tue, Jan 16, 1:41 PM

Fri, Jan 12

vitalybuka accepted D41502: Correct the setitimer interceptor on NetBSD.
Fri, Jan 12, 11:32 AM · Restricted Project

Wed, Jan 10

vitalybuka added a comment to D37631: [libFuzzer] Support using libc++.

It was configured with:

cmake -GNinja -DCMAKE_C_COMPILER=/usr/local/google/home/vitalybuka/src/llvm.git/out/build/bin//clang -DCMAKE_CXX_COMPILER=/usr/local/google/home/vitalybuka/src/llvm.git/out/build/bin//clang++ -DLLVM_ENABLE_LLD=ON -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_WERROR=OFF -DLLVM_INCLUDE_GO_TESTS=OFF -DLLVM_CCACHE_BUILD=ON -DLLVM_BINUTILS_INCDIR=/usr/include '-DLLVM_ENABLE_PROJECTS=clang;lld;compiler-rt;libcxx;libcxxabi' /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/llvm
Wed, Jan 10, 12:55 PM
vitalybuka added a comment to D37631: [libFuzzer] Support using libc++.

I see a lot of these on "ninja check-fuzzer"

Wed, Jan 10, 12:51 PM
vitalybuka accepted D37860: [MSan] Enable use-after-dtor instrumentation by default..
Wed, Jan 10, 12:23 PM

Wed, Jan 3

vitalybuka accepted D41620: [msan] Intercept sendmmsg, recvmmsg..
Wed, Jan 3, 3:20 PM
vitalybuka accepted D41637: Add MSan interceptor for fstat(2).
Wed, Jan 3, 1:10 PM · Restricted Project

Tue, Jan 2

vitalybuka added inline comments to D41620: [msan] Intercept sendmmsg, recvmmsg..
Tue, Jan 2, 6:33 PM
vitalybuka accepted D41679: [asan] Restore asan_device_setup compatibility with older libraries..
Tue, Jan 2, 1:34 PM

Fri, Dec 29

vitalybuka added a comment to D41637: Add MSan interceptor for fstat(2).

Could you please add a test?

Fri, Dec 29, 5:22 PM · Restricted Project

Fri, Dec 22

vitalybuka added inline comments to D41340: [LTO] Remove temporary files corresponding to stream which LTO skips.
Fri, Dec 22, 2:32 PM
vitalybuka accepted D41346: [Sanitizers, Darwin] Disable SANITIZER_SUPPORTS_WEAK_HOOKS before Mac OS X 10.9.
Fri, Dec 22, 11:18 AM · Restricted Project

Wed, Dec 20

vitalybuka accepted D41103: [CMake] Allow passing extra CMake arguments to custom libc++.
Wed, Dec 20, 9:38 PM
vitalybuka accepted D41475: [sanitizer] Make function declarations C-compatible.
Wed, Dec 20, 7:03 PM · Restricted Project

Tue, Dec 19

vitalybuka added inline comments to D41243: [ASan] Add interceptros for fortified strcat, strncat, strcpy, strncpy..
Tue, Dec 19, 10:56 AM · Restricted Project

Dec 17 2017

vitalybuka added a comment to D41340: [LTO] Remove temporary files corresponding to stream which LTO skips.

Not sure if this patch is needed, or we can just ignore the issue

Dec 17 2017, 7:04 PM
vitalybuka added inline comments to D41340: [LTO] Remove temporary files corresponding to stream which LTO skips.
Dec 17 2017, 6:43 PM
vitalybuka created D41340: [LTO] Remove temporary files corresponding to stream which LTO skips.
Dec 17 2017, 6:40 PM

Dec 15 2017

vitalybuka added a comment to D41267: [LTO] Make processing of combined module more consistent.

However small changes in input, could trigger combined module and shuffle outputs making life of llvm::LTO harder.

Sorry but this is still loaded in assumption about the client, which seems dubious in general to me.

At this point I am trying to solve problem is the gold plugin, however I'd expect this could be helpful for other clients as well.
Anyway why benefit of particular client without regressing behavior for the rest is a problem? Especially considering that the patch simplify implementation.

That a problem because it is a terrible way in general to design complex system: this is a sign of over-coupling components and leaking abstractions through implicit API contract.

Dec 15 2017, 7:21 PM
vitalybuka committed rL320909: [LTO] Update tests for r320905.
[LTO] Update tests for r320905
Dec 15 2017, 6:41 PM
vitalybuka committed rL320907: Remove trailing whitespace.
Remove trailing whitespace
Dec 15 2017, 6:13 PM
vitalybuka committed rL320905: [LTO] Make processing of combined module more consistent.
[LTO] Make processing of combined module more consistent
Dec 15 2017, 6:11 PM
vitalybuka committed rLLD320905: [LTO] Make processing of combined module more consistent.
[LTO] Make processing of combined module more consistent
Dec 15 2017, 6:10 PM
vitalybuka closed D41267: [LTO] Make processing of combined module more consistent.
Dec 15 2017, 6:10 PM
vitalybuka updated the diff for D41267: [LTO] Make processing of combined module more consistent.

Remove unneeded line

Dec 15 2017, 5:57 PM
vitalybuka updated the diff for D41267: [LTO] Make processing of combined module more consistent.

use count 0

Dec 15 2017, 5:45 PM
vitalybuka updated the diff for D41267: [LTO] Make processing of combined module more consistent.

updated comment

Dec 15 2017, 5:36 PM
vitalybuka updated the diff for D41267: [LTO] Make processing of combined module more consistent.

tests

Dec 15 2017, 5:33 PM
vitalybuka updated the summary of D41267: [LTO] Make processing of combined module more consistent.
Dec 15 2017, 1:45 PM
vitalybuka added a comment to D41267: [LTO] Make processing of combined module more consistent.

However small changes in input, could trigger combined module and shuffle outputs making life of llvm::LTO harder.

Sorry but this is still loaded in assumption about the client, which seems dubious in general to me.

Dec 15 2017, 1:43 PM
vitalybuka planned changes to D41267: [LTO] Make processing of combined module more consistent.

Adding promised but forgotten test

Dec 15 2017, 1:16 PM
vitalybuka updated the diff for D41267: [LTO] Make processing of combined module more consistent.

Remove unchanged file

Dec 15 2017, 1:13 PM
vitalybuka updated the summary of D41267: [LTO] Make processing of combined module more consistent.
Dec 15 2017, 1:10 PM
vitalybuka updated the summary of D41267: [LTO] Make processing of combined module more consistent.
Dec 15 2017, 1:10 PM
vitalybuka retitled D41267: [LTO] Make processing of combined module more consistent from [LTO] Write LTO output for empty RegularLTO.ModsWithSummaries to [LTO] Make processing of combined module more consistent.
Dec 15 2017, 1:09 PM
vitalybuka added a comment to D41267: [LTO] Make processing of combined module more consistent.

The commit message does not make much sense to me in the context of this C++ API: there is a non-negligible layer between the build and the build system rules and the LTO implementation, i.e. the linker.
Implementing a contract that makes it convenient for your build system in the implementation of the LTO "engine" behind this API looks like leaking abstractions to me.

Dec 15 2017, 1:09 PM
vitalybuka updated the diff for D41267: [LTO] Make processing of combined module more consistent.

Addressed review comments

Dec 15 2017, 1:05 PM
vitalybuka committed rL320859: [LTO] Remove unused RegularLTOState::HasModule.
[LTO] Remove unused RegularLTOState::HasModule
Dec 15 2017, 12:51 PM
vitalybuka added a comment to D41274: [LTO] NFC: remove unique_ptr from some LTO::RegularLTOState members.

This patch doesn't seem motivated, the only effect I can see is that a ThinLTO link that don't include any LTO module would create a module while it was lazily created only if needed before.

Dec 15 2017, 11:21 AM
vitalybuka abandoned D41274: [LTO] NFC: remove unique_ptr from some LTO::RegularLTOState members.
Dec 15 2017, 11:15 AM

Dec 14 2017

vitalybuka created D41274: [LTO] NFC: remove unique_ptr from some LTO::RegularLTOState members.
Dec 14 2017, 11:44 PM
vitalybuka updated the diff for D41267: [LTO] Make processing of combined module more consistent.

comment

Dec 14 2017, 5:45 PM
vitalybuka added a comment to D41267: [LTO] Make processing of combined module more consistent.

Peter, please take a look at general approach.
I will add a test.

Dec 14 2017, 5:41 PM
vitalybuka added a reviewer for D41267: [LTO] Make processing of combined module more consistent: pcc.
Dec 14 2017, 5:40 PM
vitalybuka created D41267: [LTO] Make processing of combined module more consistent.
Dec 14 2017, 5:38 PM
vitalybuka accepted D41159: [asan] LIT: Add lld testing config..
Dec 14 2017, 11:45 AM · lld, Restricted Project
vitalybuka added inline comments to D41159: [asan] LIT: Add lld testing config..
Dec 14 2017, 11:17 AM · lld, Restricted Project
vitalybuka added inline comments to D41222: Handle previously ASAN-instrumented IR gracefully when ASAN re-invoked.
Dec 14 2017, 10:53 AM
vitalybuka added inline comments to D41159: [asan] LIT: Add lld testing config..
Dec 14 2017, 10:32 AM · lld, Restricted Project
vitalybuka added a comment to D41103: [CMake] Allow passing extra CMake arguments to custom libc++.

Can you please add some details about why someone wants to customize LIBXX here?
Or even better attach a patch which uses this.

Dec 14 2017, 10:08 AM
vitalybuka added inline comments to D41159: [asan] LIT: Add lld testing config..
Dec 14 2017, 10:03 AM · lld, Restricted Project
vitalybuka accepted D41222: Handle previously ASAN-instrumented IR gracefully when ASAN re-invoked.

Could you please clang-format the patch for consistency?

Dec 14 2017, 10:00 AM

Dec 13 2017

vitalybuka accepted D41053: Set of corrections for MSan/NetBSD.
Dec 13 2017, 5:06 PM · Restricted Project

Dec 8 2017

vitalybuka accepted D40159: Correct handling of the TLS/NetBSD block of the main program.
Dec 8 2017, 6:19 PM · Restricted Project
vitalybuka added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/1187
Dec 8 2017, 4:01 PM · Restricted Project
vitalybuka resigned from D40349: [LSan] New experimental flag for background leak checking before exit..
Dec 8 2017, 3:57 PM
vitalybuka resigned from D40686: [MS] Fix __movs intrinsics.
Dec 8 2017, 3:56 PM
vitalybuka accepted D40951: [ASan] Add interceptor for printf_chk.
Dec 8 2017, 3:55 PM · Restricted Project
vitalybuka accepted D41011: Disable test/msan/tsearch.cc on NetBSD.
Dec 8 2017, 3:53 PM · Restricted Project
vitalybuka accepted D41013: Fix test/msan/textdomain.cc on NetBSD.
Dec 8 2017, 3:53 PM · Restricted Project
vitalybuka accepted D41014: Disable test/msan/pvalloc.cc on NetBSD.
Dec 8 2017, 3:53 PM · Restricted Project
vitalybuka accepted D41015: Fix test/msan/ifaddrs.cc for NetBSD.
Dec 8 2017, 3:52 PM · Restricted Project
vitalybuka accepted D41017: Fix test/msan/iconv.cc on NetBSD.
Dec 8 2017, 3:52 PM · Restricted Project
vitalybuka accepted D41018: Disable test/msan/ftime.cc on NetBSD.
Dec 8 2017, 3:51 PM · Restricted Project
vitalybuka accepted D41019: NetBSD ships with POSIX strerror_r(3).
Dec 8 2017, 3:50 PM · Restricted Project
vitalybuka accepted D41021: Don't link NetBSD programs with -ldl in linkXRayRuntimeDeps.
Dec 8 2017, 3:50 PM · Restricted Project
vitalybuka accepted D41022: Register NetBSD/x86_64 in MemorySanitizer.cpp.
Dec 8 2017, 3:49 PM · Restricted Project
vitalybuka accepted D41023: Add NetBSD/x86_64 mapping in MSan.
Dec 8 2017, 3:48 PM · Restricted Project
vitalybuka added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

I'm not reproducing the issues on NetBSD, so for now I will move this to background and keep patches locally.

Dec 8 2017, 3:47 PM · Restricted Project

Dec 7 2017

vitalybuka added inline comments to D40951: [ASan] Add interceptor for printf_chk.
Dec 7 2017, 2:33 PM · Restricted Project
vitalybuka added a comment to D37631: [libFuzzer] Support using libc++.

Yes, I'm still debugging the test failures. I see the same error, but only when using GCC as a host compiler. There's another issue when using Clang with libc++ as the host C++ library.

Dec 7 2017, 12:01 PM
vitalybuka added a comment to D37631: [libFuzzer] Support using libc++.

Turned out the problem was an incompatibility between libc++abi (which libc++ assumes as the default C++ ABI) and libstdc++ (which is what is being used when linking against libstdc++). Setting -DLIBCXX_CXX_ABI=none seems to be the solution. I'm still trying to figure what's the best way to tests against libc++, simply linking them isn't enough because libc++.so.1 is not in the default dynamic linker search path.

I assume because of this the patch is not finished yet?

Dec 7 2017, 12:21 AM

Dec 6 2017

vitalybuka accepted D40714: Correct atexit(3) support in MSan/NetBSD.
Dec 6 2017, 1:51 PM · Restricted Project
vitalybuka accepted D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Dec 6 2017, 1:17 PM · Restricted Project
vitalybuka added a comment to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.

lgtm

Dec 6 2017, 1:17 PM · Restricted Project
vitalybuka added inline comments to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Dec 6 2017, 11:47 AM · Restricted Project

Dec 5 2017

vitalybuka accepted D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Dec 5 2017, 6:48 PM · Restricted Project
vitalybuka added inline comments to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Dec 5 2017, 6:10 PM · Restricted Project
vitalybuka added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

lgtm if redundant comments removed
does anyone else have anything to add?

Dec 5 2017, 5:20 PM · Restricted Project
vitalybuka added inline comments to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Dec 5 2017, 5:11 PM · Restricted Project
vitalybuka accepted D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Dec 5 2017, 4:59 PM · Restricted Project
vitalybuka added inline comments to D40714: Correct atexit(3) support in MSan/NetBSD.
Dec 5 2017, 4:57 PM · Restricted Project
vitalybuka added inline comments to D40714: Correct atexit(3) support in MSan/NetBSD.
Dec 5 2017, 4:55 PM · Restricted Project
vitalybuka accepted D40764: Disable absent functions in MSan/NetBSD interceptors.
Dec 5 2017, 4:44 PM · Restricted Project
vitalybuka added inline comments to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Dec 5 2017, 4:38 PM · Restricted Project
vitalybuka added inline comments to D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Dec 5 2017, 4:34 PM · Restricted Project
vitalybuka resigned from D40032: [compiler-rt] Replace forkpty with posix_spawn.
Dec 5 2017, 4:14 PM · Restricted Project
vitalybuka accepted D39798: [Sanitizers] Use SANITIZER_* macros in lib/interception.
Dec 5 2017, 4:13 PM · Restricted Project
vitalybuka added inline comments to D37631: [libFuzzer] Support using libc++.
Dec 5 2017, 4:05 PM
vitalybuka committed rL319844: [msan] Fix formatting.
[msan] Fix formatting
Dec 5 2017, 2:10 PM
vitalybuka committed rCRT319844: [msan] Fix formatting.
[msan] Fix formatting
Dec 5 2017, 2:10 PM
vitalybuka committed rL319843: [msan] add strtouq msan interceptor.
[msan] add strtouq msan interceptor
Dec 5 2017, 2:08 PM
vitalybuka committed rCRT319843: [msan] add strtouq msan interceptor.
[msan] add strtouq msan interceptor
Dec 5 2017, 2:08 PM
vitalybuka closed D40853: [msan] add strtouq msan interceptor by committing rCRT319843: [msan] add strtouq msan interceptor.
Dec 5 2017, 2:08 PM
vitalybuka updated the diff for D40853: [msan] add strtouq msan interceptor.

u64

Dec 5 2017, 2:07 PM