In D48254#1134845, @Lekensteyn wrote:

Superseded by https://reviews.llvm.org/D48265

clang-format

In D48250#1134404, @MaskRay wrote:

Added test. BTW, is my testing correct?

% ninja -C ~/Dev/llvm/release TSanitizer-i386-Test TSanitizer-x86_64-Test TSanitizer-x86_64-Test-Nolibc && ~/Dev/llvm/release/projects/
compiler-rt/lib/sanitizer_common/tests/Sanitizer-i386-Test && ~/Dev/llvm/release/projects/compiler-rt/lib/sanitizer_common/tests/Sanitiz
er-x86_64-Test
# passed

Could you please add corresponding check into "TEST(SanitizerCommon, FileOps)" and make sure that all platforms have the same behavior.

In D48186#1132961, @Lekensteyn wrote:

Wait, what happened to compiler-rt/test/asan/TestCases/log-path_test.cc? It should not be removed.

works for me any way

In D47292#1131936, @george.karpenkov wrote:

@vitalybuka What do you think? I guess a more generalized framework could be developed to reduce code duplication, but I'm really not sure whether it's worth it.

In D47292#1130377, @george.karpenkov wrote:

@vitalybuka Turns out the simple trick I was using for Darwin did not work for the Linux linker, and more invasive changes were required.
What do you think? I don't see a way to do this without introducing extra substitutions, even though they are ugly.
I don't really mind the ugliness in testing configuration scripts here.

Is this stale?

Does it have to be a single patch?

git clang-format -f --style=file HEAD^

In D46618#1124051, @morehouse wrote:

Just found https://github.com/google/sanitizers/issues/435 and https://chromiumcodereview.appspot.com/18661009.

Maybe it would make sense to write a separate function for reading procmaps.

comments

warning

test cleanup

typo

In D47666#1119821, @vitalybuka wrote:

Good practice is to avoid merging changes into a single one.
Here one patch should be "refactoring" and the second for "loop-proto-fuzzer."

Good practice is to avoid merging changes into a single one.
Here one patch should be "refactoring" and the second for "loop-proto-fuzzer."