Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (170 w, 3 d)

Recent Activity

Today

vitalybuka accepted D63450: Stop counting pops in tsan/check_analyze.sh..
Mon, Jun 17, 12:53 PM · Restricted Project, Restricted Project

Fri, Jun 14

vitalybuka committed rG0b1ea8cb2825: Improve error message when '=' is missing in {ASAN,...}_OPTIONS. (authored by vitalybuka).
Improve error message when '=' is missing in {ASAN,...}_OPTIONS.
Fri, Jun 14, 6:35 PM
vitalybuka committed rL363480: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Improve error message when '=' is missing in {ASAN,...}_OPTIONS.
Fri, Jun 14, 6:34 PM
vitalybuka closed D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Fri, Jun 14, 6:34 PM · Restricted Project
vitalybuka updated the summary of D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Fri, Jun 14, 6:19 PM · Restricted Project
vitalybuka added a comment to D63334: [libFuzzer] Disable len_control by default if LLVMFuzzerCustomMutator is used..

maybe test?

Fri, Jun 14, 11:14 AM · Restricted Project, Restricted Project

Thu, Jun 13

vitalybuka added a comment to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

Thank you for review. Can you please install the commit?

Thu, Jun 13, 11:11 AM · Restricted Project

Wed, Jun 12

vitalybuka accepted D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..

LGTM

Wed, Jun 12, 1:57 PM · Restricted Project

Tue, Jun 11

vitalybuka added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Tue, Jun 11, 11:23 AM · Restricted Project

Mon, Jun 10

vitalybuka added inline comments to D59876: Improve error message when '=' is missing in {ASAN,...}_OPTIONS..
Mon, Jun 10, 12:32 PM · Restricted Project

Fri, Jun 7

vitalybuka accepted D63019: [GWP-ASan] Removed unittests from Android build..
Fri, Jun 7, 12:26 PM · Restricted Project, Restricted Project

Tue, May 21

vitalybuka committed rL361324: Fix build step name.
Fix build step name
Tue, May 21, 3:42 PM
vitalybuka committed rL361323: [zorg] Build and test LLVM with GN.
[zorg] Build and test LLVM with GN
Tue, May 21, 3:20 PM
vitalybuka closed D62020: [zorg] Build and test LLVM with GN.
Tue, May 21, 3:20 PM · Restricted Project
vitalybuka added inline comments to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .
Tue, May 21, 1:28 PM · Restricted Project
vitalybuka committed rCRT361305: [asan] clang-format parent patch.
[asan] clang-format parent patch
Tue, May 21, 1:28 PM
vitalybuka committed rG9bd4fe80f0cd: [asan] clang-format parent patch (authored by vitalybuka).
[asan] clang-format parent patch
Tue, May 21, 1:23 PM
vitalybuka committed rL361305: [asan] clang-format parent patch.
[asan] clang-format parent patch
Tue, May 21, 1:22 PM
vitalybuka committed rCRT361304: [asan] Replace assignments with internal_memcpy ErrorDescription.
[asan] Replace assignments with internal_memcpy ErrorDescription
Tue, May 21, 1:21 PM
vitalybuka committed rGe756730c23ef: [asan] Replace assignments with internal_memcpy ErrorDescription (authored by vitalybuka).
[asan] Replace assignments with internal_memcpy ErrorDescription
Tue, May 21, 1:21 PM
vitalybuka committed rL361304: [asan] Replace assignments with internal_memcpy ErrorDescription.
[asan] Replace assignments with internal_memcpy ErrorDescription
Tue, May 21, 1:21 PM
vitalybuka accepted D62189: [Sanitizer] Add interceptor for wcsdup.
Tue, May 21, 11:53 AM · Restricted Project, Restricted Project

Mon, May 20

vitalybuka added a comment to D62050: [Analysis] Only run plugins tests if plugins are actually enabled.

This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory)

I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right approach long-term.

Mon, May 20, 6:47 PM · Restricted Project, Restricted Project
vitalybuka committed rL361211: Fix cfi-and-supported.
Fix cfi-and-supported
Mon, May 20, 6:46 PM
vitalybuka added a comment to D62050: [Analysis] Only run plugins tests if plugins are actually enabled.

This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory)

Mon, May 20, 6:29 PM · Restricted Project, Restricted Project

May 17 2019

vitalybuka committed rGa9c7b2583f2f: [sanitizer] Update symbolizer/scripts/global_symbols.txt (authored by vitalybuka).
[sanitizer] Update symbolizer/scripts/global_symbols.txt
May 17 2019, 2:36 PM
vitalybuka committed rL361077: [sanitizer] Update symbolizer/scripts/global_symbols.txt.
[sanitizer] Update symbolizer/scripts/global_symbols.txt
May 17 2019, 2:35 PM
vitalybuka committed rCRT361077: [sanitizer] Update symbolizer/scripts/global_symbols.txt.
[sanitizer] Update symbolizer/scripts/global_symbols.txt
May 17 2019, 2:35 PM

May 16 2019

vitalybuka committed rG627e383ce559: [sanitizer] Don't generate "failed to intercept" constants for each function (authored by vitalybuka).
[sanitizer] Don't generate "failed to intercept" constants for each function
May 16 2019, 4:44 PM
vitalybuka committed rCRT360958: [sanitizer] Don't generate "failed to intercept" constants for each function.
[sanitizer] Don't generate "failed to intercept" constants for each function
May 16 2019, 4:44 PM
vitalybuka committed rL360958: [sanitizer] Don't generate "failed to intercept" constants for each function.
[sanitizer] Don't generate "failed to intercept" constants for each function
May 16 2019, 4:43 PM
vitalybuka added inline comments to D62020: [zorg] Build and test LLVM with GN.
May 16 2019, 2:01 PM · Restricted Project
vitalybuka updated the diff for D62020: [zorg] Build and test LLVM with GN.

Don't hardcode default GN options

May 16 2019, 2:01 PM · Restricted Project
vitalybuka added a comment to D62020: [zorg] Build and test LLVM with GN.

Cool!

Having a bot for this is great, under these conditions:

  • It doesn't send email to regular contributors when it goes red (it can email you and me and others who'd like to opt in)

already done in D61965, but you need to opt-in. I can do it for you if you don'e have zorg checkout.

May 16 2019, 1:36 PM · Restricted Project
vitalybuka updated the diff for D62020: [zorg] Build and test LLVM with GN.

remove unused depot_tools

May 16 2019, 11:33 AM · Restricted Project
vitalybuka created D62020: [zorg] Build and test LLVM with GN.
May 16 2019, 11:32 AM · Restricted Project
vitalybuka committed rL360926: [zorg][sanitizers] Update stage1_clang_at_revison to r360832 and build lld.
[zorg][sanitizers] Update stage1_clang_at_revison to r360832 and build lld
May 16 2019, 11:28 AM

May 15 2019

vitalybuka committed rL360847: [zorg] Add empty GN buildbot.
[zorg] Add empty GN buildbot
May 15 2019, 8:56 PM
vitalybuka closed D61965: [zorg] Add empty GN buildbot.
May 15 2019, 8:56 PM · Restricted Project
vitalybuka committed rG8b27e9c6d4e3: Fix GN build (authored by vitalybuka).
Fix GN build
May 15 2019, 5:19 PM
vitalybuka committed rL360829: Fix GN build.
Fix GN build
May 15 2019, 5:19 PM
vitalybuka added a comment to D61965: [zorg] Add empty GN buildbot.
In D61965#1503718, @pcc wrote:

I think this would need to be clearly labeled as an experimental builder so that it's clear that developers aren't on the hook for fixing it. It also means that the bot will need to be configured not to send mail to the blamelist.

May 15 2019, 4:28 PM · Restricted Project
vitalybuka updated the diff for D61965: [zorg] Add empty GN buildbot.

disabled emails to the blame list

May 15 2019, 4:28 PM · Restricted Project
vitalybuka created D61965: [zorg] Add empty GN buildbot.
May 15 2019, 2:58 PM · Restricted Project
vitalybuka committed rL360821: [zorg] Switch between from BUILDBOT_MONO_REPO_PATH to BUILDBOT_REVISION.
[zorg] Switch between from BUILDBOT_MONO_REPO_PATH to BUILDBOT_REVISION
May 15 2019, 2:47 PM
vitalybuka committed rL360820: Enabled 3 builds on sanitizer-buildbot1,2.
Enabled 3 builds on sanitizer-buildbot1,2
May 15 2019, 2:47 PM
vitalybuka accepted D61871: [asan] Fix debug asan build link error.
May 15 2019, 12:29 PM · Restricted Project, Restricted Project

May 13 2019

vitalybuka created D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.
May 13 2019, 7:30 PM · Restricted Project, Restricted Project
vitalybuka planned changes to D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.
May 13 2019, 7:30 PM · Restricted Project, Restricted Project
vitalybuka committed rG5f245bfca839: [gn] Fix build (authored by vitalybuka).
[gn] Fix build
May 13 2019, 3:29 PM
vitalybuka committed rL360629: [gn] Fix build.
[gn] Fix build
May 13 2019, 3:29 PM
vitalybuka added inline comments to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .
May 13 2019, 11:02 AM · Restricted Project
vitalybuka added a comment to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

LGTM. The number of if defined() and duplicated code regions is minimal. I'm curious to know what @vitalybuka and @kcc think of this iteration of the patch.

May 13 2019, 10:37 AM · Restricted Project

May 10 2019

vitalybuka added inline comments to D61766: WIP: Speed-up leak and address sanitizers lsan prototype.
May 10 2019, 11:28 AM · Restricted Project, Restricted Project

May 8 2019

vitalybuka accepted D61654: [scudo][standalone] Introduce the chunk header.
May 8 2019, 11:03 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

Hello @vitalybuka , thank you for the example in D61401. Do you have a suggestion what file and namespace the DoubleAllocator template class definition should reside? The most recent diff for D60243 was authored April 3 and no longer cleanly applies (the file lsan_allocator.h has changed considerably since then). This is complicated by @sebpop changing jobs and requiring legal approval before he can help work on this again. In order to make progress I'm essentially re-writing this patch based on the new Allocator layout in lsan_allocator.h.

May 8 2019, 10:39 AM · Restricted Project

May 7 2019

vitalybuka accepted D61654: [scudo][standalone] Introduce the chunk header.
May 7 2019, 3:53 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D61654: [scudo][standalone] Introduce the chunk header.
May 7 2019, 3:46 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D61654: [scudo][standalone] Introduce the chunk header.
May 7 2019, 2:29 PM · Restricted Project, Restricted Project

May 1 2019

vitalybuka committed rGfbcec6cad039: [tsan] Fix and re-enable user_malloc.cc test (authored by vitalybuka).
[tsan] Fix and re-enable user_malloc.cc test
May 1 2019, 2:53 PM
vitalybuka committed rCRT359731: [tsan] Fix and re-enable user_malloc.cc test.
[tsan] Fix and re-enable user_malloc.cc test
May 1 2019, 2:53 PM
vitalybuka committed rL359731: [tsan] Fix and re-enable user_malloc.cc test.
[tsan] Fix and re-enable user_malloc.cc test
May 1 2019, 2:53 PM
vitalybuka closed D61393: [tsan] Fix and re-enable user_malloc.cc test.
May 1 2019, 2:53 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D61393: [tsan] Fix and re-enable user_malloc.cc test.

typo

May 1 2019, 2:53 PM · Restricted Project, Restricted Project
vitalybuka committed rG9ef838761e4a: [sanitizer][NFC] Remove unneeded SizeClassAllocatorLocalCache (authored by vitalybuka).
[sanitizer][NFC] Remove unneeded SizeClassAllocatorLocalCache
May 1 2019, 2:22 PM
vitalybuka committed rG59bcb788ecc8: [sanitizer][NFC] Add const/static into a couple of methods (authored by vitalybuka).
[sanitizer][NFC] Add const/static into a couple of methods
May 1 2019, 2:22 PM
vitalybuka committed rCRT359729: [sanitizer][NFC] Remove unneeded SizeClassAllocatorLocalCache.
[sanitizer][NFC] Remove unneeded SizeClassAllocatorLocalCache
May 1 2019, 2:21 PM
vitalybuka committed rL359729: [sanitizer][NFC] Remove unneeded SizeClassAllocatorLocalCache.
[sanitizer][NFC] Remove unneeded SizeClassAllocatorLocalCache
May 1 2019, 2:20 PM
vitalybuka committed rL359728: [sanitizer][NFC] Add const/static into a couple of methods.
[sanitizer][NFC] Add const/static into a couple of methods
May 1 2019, 2:20 PM
vitalybuka committed rCRT359728: [sanitizer][NFC] Add const/static into a couple of methods.
[sanitizer][NFC] Add const/static into a couple of methods
May 1 2019, 2:20 PM
vitalybuka added a comment to D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 48-bit VMA .

I've started some refactoring there. So maybe it would be easier after that.

Hello @vitalybuka I plan on looking at your suggestions this week. Please let me know when you think you have the refactored code in a state you perfer and I will start working from that as the new base.

May 1 2019, 2:15 PM · Restricted Project
vitalybuka created D61401: D60243 Test.
May 1 2019, 2:14 PM · Restricted Project, Restricted Project
vitalybuka committed rG20c5676416d3: [sanitizer][NFC] Set LargeMmapAllocator type from PrimaryAllocator (authored by vitalybuka).
[sanitizer][NFC] Set LargeMmapAllocator type from PrimaryAllocator
May 1 2019, 12:41 PM
vitalybuka committed rCRT359719: [sanitizer][NFC] Set LargeMmapAllocator type from PrimaryAllocator.
[sanitizer][NFC] Set LargeMmapAllocator type from PrimaryAllocator
May 1 2019, 12:40 PM
vitalybuka committed rL359719: [sanitizer][NFC] Set LargeMmapAllocator type from PrimaryAllocator.
[sanitizer][NFC] Set LargeMmapAllocator type from PrimaryAllocator
May 1 2019, 12:40 PM
vitalybuka closed D61168: [sanitizer] NFC:Get type of LargeMmapAllocator from PrimaryAllocator.
May 1 2019, 12:40 PM · Restricted Project, Restricted Project
vitalybuka added reviewers for D57786: [sanitizer] Enabled getpw_getgr.cc on iOS: delcypher, yln.

@delcypher, @yln maybe you can check if this works on iOS

May 1 2019, 12:38 PM · Restricted Project, Restricted Project
vitalybuka committed rG7780f516142c: [scudo][NFC] Remove unneeded template from scudo::CombinedAllocator (authored by vitalybuka).
[scudo][NFC] Remove unneeded template from scudo::CombinedAllocator
May 1 2019, 12:35 PM
vitalybuka committed rCRT359718: [scudo][NFC] Remove unneeded template from scudo::CombinedAllocator.
[scudo][NFC] Remove unneeded template from scudo::CombinedAllocator
May 1 2019, 12:35 PM
vitalybuka committed rL359718: [scudo][NFC] Remove unneeded template from scudo::CombinedAllocator.
[scudo][NFC] Remove unneeded template from scudo::CombinedAllocator
May 1 2019, 12:34 PM
vitalybuka closed D61162: [scudo][NFC] Remove unneeded template from scudo::CombinedAllocator.
May 1 2019, 12:34 PM · Restricted Project, Restricted Project
vitalybuka retitled D61162: [scudo][NFC] Remove unneeded template from scudo::CombinedAllocator from [scudo] NFC: Remove unneeded template from scudo::CombinedAllocator to [scudo][NFC] Remove unneeded template from scudo::CombinedAllocator.
May 1 2019, 12:32 PM · Restricted Project, Restricted Project
vitalybuka added reviewers for D61393: [tsan] Fix and re-enable user_malloc.cc test: morehouse, hctim.
May 1 2019, 12:30 PM · Restricted Project, Restricted Project
vitalybuka committed rG76931df40f0b: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator (authored by vitalybuka).
[sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator
May 1 2019, 12:29 PM
vitalybuka committed rCRT359715: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator.
[sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator
May 1 2019, 12:29 PM
vitalybuka committed rL359715: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator.
[sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator
May 1 2019, 12:28 PM
vitalybuka closed D61155: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator.
May 1 2019, 12:28 PM · Restricted Project, Restricted Project
vitalybuka retitled D61155: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator from [NFC][sanitizer] Get type of AllocatorCache from CombinedAllocator to [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator.
May 1 2019, 12:27 PM · Restricted Project, Restricted Project
vitalybuka retitled D61155: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator from [NFC] Get type of AllocatorCache from CombinedAllocator to [NFC][sanitizer] Get type of AllocatorCache from CombinedAllocator.
May 1 2019, 12:27 PM · Restricted Project, Restricted Project
vitalybuka created D61393: [tsan] Fix and re-enable user_malloc.cc test.
May 1 2019, 11:30 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro".

Please don't submit without my review even if @rnk accept this.
I've noticed report that original patch breaks compiler-rt/test/tsan/Linux/user_malloc.cc on our internal llvm build.
I don't yet understand why it's there and not on our public bots or my local checkout. May be a problem with the patch or our miss-configuration. I'll debug this morning.

May 1 2019, 10:29 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D61358: [Sanitizer] Reland "Cleanup INTERCEPT_FUNCTION macro".

Please don't submit without my review even if @rnk accept this.
I've noticed report that original patch breaks compiler-rt/test/tsan/Linux/user_malloc.cc on our internal llvm build.
I don't yet understand why it's there and not on our public bots or my local checkout. May be a problem with the patch or our miss-configuration. I'll debug this morning.

May 1 2019, 12:26 AM · Restricted Project, Restricted Project

Apr 30 2019

vitalybuka accepted D61342: [sanitizer_common] Added 64-bit signed flag parser..
Apr 30 2019, 3:45 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

you should try to extract obvious parts into smaller patches

Apr 30 2019, 3:41 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D61342: [sanitizer_common] Added 64-bit signed flag parser..

Test?

Apr 30 2019, 2:39 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void.
Apr 30 2019, 1:27 PM · Restricted Project, Restricted Project
vitalybuka committed rL359607: [sanitizer][zorg] Print URL with local reproducer info.
[sanitizer][zorg] Print URL with local reproducer info
Apr 30 2019, 1:08 PM
vitalybuka added a reviewer for D61155: [sanitizer][NFC] Get type of AllocatorCache from CombinedAllocator: kcc.

@kcc sanitizer_allocator_combined.h is the main part of the patch

Apr 30 2019, 10:17 AM · Restricted Project, Restricted Project
vitalybuka added a reviewer for D61168: [sanitizer] NFC:Get type of LargeMmapAllocator from PrimaryAllocator: kcc.

@kcc sanitizer_allocator_combined.h is the main part of the patch

Apr 30 2019, 10:17 AM · Restricted Project, Restricted Project

Apr 29 2019

vitalybuka committed rGd1e87d41cb0d: [clangd] Fix GN build (authored by vitalybuka).
[clangd] Fix GN build
Apr 29 2019, 6:35 PM