Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (329 w, 18 h)

Recent Activity

Yesterday

vitalybuka added a comment to D126907: Deferred Concept Instantiation Implementation Take 2.

Yikes! Thanks for the revert. I didn't see the email from the bot until just about 2 minutes before you reverted. I'll see if I can reproduce.

Thu, Jun 30, 1:10 PM · Restricted Project, Restricted Project

Wed, Jun 29

vitalybuka committed rZORGcb9141e3459c: [msan] Don't run origins for stage3 after stage2 error (authored by vitalybuka).
[msan] Don't run origins for stage3 after stage2 error
Wed, Jun 29, 8:09 PM · Restricted Project
vitalybuka committed rG72cd6b6c8356: Revert "[Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef." (authored by vitalybuka).
Revert "[Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef."
Wed, Jun 29, 5:54 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rG77df3be0dee4: [Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef.: rG72cd6b6c8356: Revert "[Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef.".
Wed, Jun 29, 5:54 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for D126883: [Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef.: rG72cd6b6c8356: Revert "[Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef.".
Wed, Jun 29, 5:53 PM · Restricted Project, Restricted Project
vitalybuka reopened D126883: [Debuginfo][DWARF][NFC] Refactor DwarfStringPoolEntryRef..

Msan complains about this patch https://lab.llvm.org/buildbot/#/builders/74/builds/11664/steps/17/logs/stdio

Wed, Jun 29, 5:52 PM · Restricted Project, Restricted Project
vitalybuka committed rZORG5701736529a5: [NFC][sanitizer] Print reproducer on error (authored by vitalybuka).
[NFC][sanitizer] Print reproducer on error
Wed, Jun 29, 5:33 PM · Restricted Project
vitalybuka committed rZORGa314e207940a: [NFC][sanitizer] Use error helper functions (authored by vitalybuka).
[NFC][sanitizer] Use error helper functions
Wed, Jun 29, 5:32 PM · Restricted Project
vitalybuka added a reverting change for D128810: [Sanitizer] Switch the LAM repository to another repo: rZORG5948f9e9cd9b: Revert "[Sanitizer] Switch the LAM repository to another repo".
Wed, Jun 29, 4:24 PM · Restricted Project
vitalybuka committed rZORG5948f9e9cd9b: Revert "[Sanitizer] Switch the LAM repository to another repo" (authored by vitalybuka).
Revert "[Sanitizer] Switch the LAM repository to another repo"
Wed, Jun 29, 4:24 PM · Restricted Project
vitalybuka added a reverting change for rZORG5369cce4358c: [Sanitizer] Switch the LAM repository to another repo: rZORG5948f9e9cd9b: Revert "[Sanitizer] Switch the LAM repository to another repo".
Wed, Jun 29, 4:24 PM · Restricted Project
vitalybuka reopened D128810: [Sanitizer] Switch the LAM repository to another repo.

It fails as is https://lab.llvm.org/buildbot/#/builders/169/builds/8994/steps/30/logs/stdio

Wed, Jun 29, 4:23 PM · Restricted Project
vitalybuka committed rZORG5369cce4358c: [Sanitizer] Switch the LAM repository to another repo (authored by glider).
[Sanitizer] Switch the LAM repository to another repo
Wed, Jun 29, 3:36 PM · Restricted Project
vitalybuka closed D128810: [Sanitizer] Switch the LAM repository to another repo.
Wed, Jun 29, 3:36 PM · Restricted Project
vitalybuka committed rZORG4b4280b522cc: [NFC][sanitizer] Remove unnececary 'r' prefix (authored by vitalybuka).
[NFC][sanitizer] Remove unnececary 'r' prefix
Wed, Jun 29, 2:46 PM · Restricted Project
vitalybuka accepted D128810: [Sanitizer] Switch the LAM repository to another repo.

I will commit/revert it myself.

Wed, Jun 29, 2:41 PM · Restricted Project
vitalybuka committed rZORG5483acdc9972: [sanitizer] Reshuffle builders/workers mapping (authored by vitalybuka).
[sanitizer] Reshuffle builders/workers mapping
Wed, Jun 29, 2:28 PM · Restricted Project
vitalybuka committed rZORGc98c97c5193d: [sanitizer] Switch from Chromium to releases/latest (authored by vitalybuka).
[sanitizer] Switch from Chromium to releases/latest
Wed, Jun 29, 2:28 PM · Restricted Project
vitalybuka committed rZORG691ef868148f: [sanitizer] Enabled asserts after stage1 (authored by vitalybuka).
[sanitizer] Enabled asserts after stage1
Wed, Jun 29, 2:28 PM · Restricted Project
vitalybuka committed rZORG7bd4688efa5a: [NFC][sanitizer] Simplity build_stage1_clang_impl (authored by vitalybuka).
[NFC][sanitizer] Simplity build_stage1_clang_impl
Wed, Jun 29, 2:28 PM · Restricted Project
vitalybuka committed rZORG4d6bcff0ec4d: [NFC][sanitizer] Remove noop lines of script (authored by vitalybuka).
[NFC][sanitizer] Remove noop lines of script
Wed, Jun 29, 2:28 PM · Restricted Project

Tue, Jun 28

vitalybuka accepted D128729: Avoid ar_to_bc.sh script in symbolizer build; add -ignore-non-bitcode flag to llvm-link.

Do we need a test for llvm-link?

I guess. So much trouble to keep these strange build scripts working...

Tue, Jun 28, 9:56 AM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D128729: Avoid ar_to_bc.sh script in symbolizer build; add -ignore-non-bitcode flag to llvm-link.

Do we need a test for llvm-link?

Tue, Jun 28, 9:11 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 27

vitalybuka committed rG6824eee94203: [asan] Add missing dependency on Demangle (authored by vitalybuka).
[asan] Add missing dependency on Demangle
Mon, Jun 27, 3:11 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127911: Delete 'llvm.asan.globals' for global metadata..
Mon, Jun 27, 2:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

restore blank line

Mon, Jun 27, 2:23 PM · Restricted Project, Restricted Project
vitalybuka committed rGdf18167ac56d: [docs] Restore missing blank line (authored by vitalybuka).
[docs] Restore missing blank line
Mon, Jun 27, 2:21 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

exactly as reverted revision
886715af962de2c92fac4bd37104450345711e4a + 572b08790a69f955ae0cbb1b4a7d4a215f15dad9

Mon, Jun 27, 2:09 PM · Restricted Project, Restricted Project
vitalybuka reopened D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

Reverted with cdfa15da94f06289dcf86173d18b6627f92ac403 (inlcuding 572b08790a69f955ae0cbb1b4a7d4a215f15dad9)

Mon, Jun 27, 2:04 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rG886715af962d: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible…: rGcdfa15da94f0: Revert "[clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of….
Mon, Jun 27, 2:03 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rG572b08790a69: [clang] Add back -fsanitize=array-bounds workaround for size-1 array after…: rGcdfa15da94f0: Revert "[clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of….
Mon, Jun 27, 2:03 PM · Restricted Project, Restricted Project
vitalybuka committed rGcdfa15da94f0: Revert "[clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of… (authored by vitalybuka).
Revert "[clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of…
Mon, Jun 27, 2:03 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays: rGcdfa15da94f0: Revert "[clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of….
Mon, Jun 27, 2:03 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

This bot is broken by this patch
https://lab.llvm.org/buildbot/#/builders/85/builds/8881

Mon, Jun 27, 1:55 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rGf5d781d6273c: [X86] Support `_Float16` on SSE2 and up: rG8f7cca90af6e: Revert "[X86] Support `_Float16` on SSE2 and up".
Mon, Jun 27, 12:44 PM · Restricted Project, Restricted Project
vitalybuka committed rG8f7cca90af6e: Revert "[X86] Support `_Float16` on SSE2 and up" (authored by vitalybuka).
Revert "[X86] Support `_Float16` on SSE2 and up"
Mon, Jun 27, 12:44 PM · Restricted Project, Restricted Project
vitalybuka reopened D128571: [X86] Support `_Float16` on SSE2 and up.
Mon, Jun 27, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a reverting change for D128571: [X86] Support `_Float16` on SSE2 and up: rG8f7cca90af6e: Revert "[X86] Support `_Float16` on SSE2 and up".
Mon, Jun 27, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka committed rG11b414463dc2: [test] Add workaround for flaky error we see on Windows bots (authored by vitalybuka).
[test] Add workaround for flaky error we see on Windows bots
Mon, Jun 27, 12:38 PM · Restricted Project, Restricted Project

Fri, Jun 24

vitalybuka added inline comments to D127911: Delete 'llvm.asan.globals' for global metadata..
Fri, Jun 24, 4:47 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D127911: Delete 'llvm.asan.globals' for global metadata..
Fri, Jun 24, 4:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D128559: [Sanitizers] Fix malloc_usable_size interceptions signatures for FreeBSD.

Maybe then just keep as is to avoid new preprocessor branches?

Fri, Jun 24, 4:24 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127911: Delete 'llvm.asan.globals' for global metadata..

The rest is LGTM

Fri, Jun 24, 3:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D128559: [Sanitizers] Fix malloc_usable_size interceptions signatures for FreeBSD.
Fri, Jun 24, 3:07 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127911: Delete 'llvm.asan.globals' for global metadata..
Fri, Jun 24, 2:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D128551: [NFC][HWASan] Refactor hwasan pass.
Fri, Jun 24, 1:55 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

vitalybuka added a comment to D128387: [hwasan] Add __hwasan_record_frame_record to the hwasan interface.

Could you please move refactoring (like extraction emitPrologue) into a separate CL?

Wed, Jun 22, 3:33 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

vitalybuka added a comment to D114487: [LAA] Support runtime checks for select GEP base pointers..

@fhahn
This is reduced reproducer:

Thanks! I think I was able to isolate the bits that caused problems:

  1. Unecessarily looking through selects outside the loop
  2. Introducing branches on undef/poison when looking through selects.

I recommitted the change in e9cced27390ba38eac1144aa1240281a1edadec0. I couldn't test with msan though, as it's not available on macOS. Please let me know if you see further issues.

Tue, Jun 21, 1:19 PM · Restricted Project, Restricted Project

Fri, Jun 17

vitalybuka committed rGf0ca0a324fd5: [CodeGen] Init EmptyExpr before the first use (authored by vitalybuka).
[CodeGen] Init EmptyExpr before the first use
Fri, Jun 17, 5:40 PM · Restricted Project, Restricted Project

Wed, Jun 15

vitalybuka accepted D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval.
Wed, Jun 15, 3:29 PM · Restricted Project, Restricted Project

Fri, Jun 10

vitalybuka committed rG665617182c45: [Bitcode] Don't use UINT_MAX for missing SanitizerMetadata (authored by vitalybuka).
[Bitcode] Don't use UINT_MAX for missing SanitizerMetadata
Fri, Jun 10, 6:23 PM · Restricted Project, Restricted Project
vitalybuka accepted D126929: Add sanitizer metadata attributes to clang IR gen..
Fri, Jun 10, 5:56 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D126929: Add sanitizer metadata attributes to clang IR gen..
Fri, Jun 10, 5:56 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 8

vitalybuka accepted D127326: [Sanitizers] prctl interception update for the PR_SET_VMA option case.
Wed, Jun 8, 10:03 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127368: [msan][test] Use a large cpusetsize for pthread_getaffinity_np.

Thanks for the fix!

Wed, Jun 8, 6:50 PM · Restricted Project, Restricted Project
vitalybuka accepted D127368: [msan][test] Use a large cpusetsize for pthread_getaffinity_np.
Wed, Jun 8, 6:50 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127364: [MSAN] mark test as unsupported for powerpc..

https://lab.llvm.org/buildbot/#/builders/105/builds/26496
and
https://lab.llvm.org/buildbot/#/builders/19/builds/11181

Wed, Jun 8, 6:00 PM · Restricted Project, Restricted Project
vitalybuka accepted D127364: [MSAN] mark test as unsupported for powerpc..
Wed, Jun 8, 5:25 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127364: [MSAN] mark test as unsupported for powerpc..
Wed, Jun 8, 5:25 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127326: [Sanitizers] prctl interception update for the PR_SET_VMA option case.
Wed, Jun 8, 5:05 PM · Restricted Project, Restricted Project
vitalybuka accepted D127343: [Sanitizers] Cleanup handling of stat64/statfs64.
Wed, Jun 8, 4:56 PM · Restricted Project, Restricted Project
vitalybuka accepted D127359: [MSAN] print out the only possible invalid parameter (EINVAL is returned).

maybe #define _GNU_SOURCE as in documentation?

Wed, Jun 8, 4:04 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127327: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on Android..

I believe "Depends on" should be in the summary, no in the title

Wed, Jun 8, 2:03 PM · Restricted Project, Restricted Project
vitalybuka accepted D127327: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on Android..
Wed, Jun 8, 1:51 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126929: Add sanitizer metadata attributes to clang IR gen..
Wed, Jun 8, 1:44 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D126929: Add sanitizer metadata attributes to clang IR gen..

No need to recover my snapshot, I'll just comment here.

Wed, Jun 8, 1:41 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D126100: Add sanitizer-specific GlobalValue attributes..
Wed, Jun 8, 1:26 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D126929: Add sanitizer metadata attributes to clang IR gen..

Update.

Wed, Jun 8, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D127320: [MSAN] Add result printing for failed call in pthread_getaffinity_np. Will be reverted when test failure is diagnosed. Depends on: https://reviews.llvm.org/D127185.
Wed, Jun 8, 10:51 AM · Restricted Project, Restricted Project

Tue, Jun 7

vitalybuka accepted D126825: [compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64.
Tue, Jun 7, 5:03 PM · Restricted Project, Restricted Project
vitalybuka accepted D125756: [sanitizer] Add the common FreeBSD AArch64 support.
Tue, Jun 7, 4:59 PM · Restricted Project, Restricted Project
vitalybuka accepted D127069: [Sanitizers] intercept FreeBSD procctl.
Tue, Jun 7, 4:53 PM · Restricted Project, Restricted Project
vitalybuka accepted D126927: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings.
Tue, Jun 7, 4:50 PM · Restricted Project, Restricted Project
vitalybuka accepted D127185: [MSAN] Add interceptor for pthread_getaffinity_np..
Tue, Jun 7, 4:24 PM · Restricted Project, Restricted Project
vitalybuka accepted D127177: Add checks for -lresolv to sanitizer-ld test. These were missed in https://reviews.llvm.org/D127145..
Tue, Jun 7, 4:00 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127185: [MSAN] Add interceptor for pthread_getaffinity_np..
Tue, Jun 7, 3:59 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127163: [clang] Add -fsanitize=memtag-globals (no-op)..

We already have -fsanitize=memtag that implies -fsanitize=memtag-heap and -fsanitize=memtag-stack.

It makes the most sense IMHO in the world where we want heap MTE. -fsanitize=memtag-heap is the most reasonable instead of -fsanitize-memtag-heap, as "do i need -fsanitize=memtag as well, like MSan?" is never a question.

Tue, Jun 7, 3:40 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format.

Up to you if you, if you want to wait for Peter. Feel free to remove and land it if you think it's done.
I added blocker only to make sure that review is shown to @phosek on Phabricator main page.

Tue, Jun 7, 2:59 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127163: [clang] Add -fsanitize=memtag-globals (no-op)..

Why do we want this as a separate -fsanitize=
Maybe better to have some modifier flag like -fsanitize-memtag-globals=1 ?

Tue, Jun 7, 2:52 PM · Restricted Project, Restricted Project
vitalybuka accepted D126580: [compiler-rt] Avoid truncating Symbolizer output.
Tue, Jun 7, 2:47 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D126929: Add sanitizer metadata attributes to clang IR gen..

I simplified this a little bit, but I guess this is effectively the same.

Tue, Jun 7, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D126929: Add sanitizer metadata attributes to clang IR gen..

rebase

Tue, Jun 7, 2:23 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D126100: Add sanitizer-specific GlobalValue attributes..

fix rebase

Tue, Jun 7, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D126100: Add sanitizer-specific GlobalValue attributes..

rebase

Tue, Jun 7, 2:12 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka committed rGd7df3f0a4b8d: [NFC] Exctract getNoSanitizeMask lambda (authored by vitalybuka).
[NFC] Exctract getNoSanitizeMask lambda
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project
vitalybuka committed rGf32ad5703e83: [NFC] Move part of SanitizerMetadata into private method (authored by vitalybuka).
[NFC] Move part of SanitizerMetadata into private method
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project
vitalybuka committed rG5d9de5f44660: [NFC] Clang-format parts of D126929 and D126100 (authored by hctim).
[NFC] Clang-format parts of D126929 and D126100
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka committed rGf49a5844b6c8: [NFC][CodeGen] Rename method (authored by hctim).
[NFC][CodeGen] Rename method
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126100: Add sanitizer-specific GlobalValue attributes..
Tue, Jun 7, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 6

vitalybuka added inline comments to D126100: Add sanitizer-specific GlobalValue attributes..
Mon, Jun 6, 7:17 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a reviewer for D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format: phosek.
Mon, Jun 6, 6:41 PM · Restricted Project, Restricted Project
vitalybuka accepted D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format.
Mon, Jun 6, 6:40 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126580: [compiler-rt] Avoid truncating Symbolizer output.
Mon, Jun 6, 5:09 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127145: [Driver] add -lresolv for all but Android..

yes, however I have no idea if we need !TC.getTriple().isOSFreeBSD() !TC.getTriple().isOSNetBSD() !TC.getTriple().isOSOpenBSD()) etc.
I guess if make mistake it will be noticed and fixed.

Mon, Jun 6, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

If you're seeing a miscompile, something is probably wrong with the caller. getUnderlyingObjects() is, in general, not guaranteed to produce an identifiable object. If the caller cares, it should check; for example, GlobalsAAResult::getModRefInfoForArgument checks all_of(Objects, isIdentifiedObject).

I am not sure why do don't want to make it guaranty with a patch like this?

How could we possibly guarantee that? In general, we're going to find some opaque thing that both getUnderlyingObjects() and its caller can't understand.

I mean, I guess we could define an API that narrowly guarantees it looks though all bitcast, addrspacecast, gep, phi, and select operations. But that would be expensive in general, and it's not obvious to me it solves anything.

Mon, Jun 6, 12:19 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

If you're seeing a miscompile, something is probably wrong with the caller. getUnderlyingObjects() is, in general, not guaranteed to produce an identifiable object. If the caller cares, it should check; for example, GlobalsAAResult::getModRefInfoForArgument checks all_of(Objects, isIdentifiedObject).

Mon, Jun 6, 11:48 AM · Restricted Project, Restricted Project
vitalybuka accepted D126269: [ASan] Skip any instruction inserted by another instrumentation..
Mon, Jun 6, 11:29 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D126580: [compiler-rt] Avoid truncating Symbolizer output.

Thanks.
LGTM with few nits

Mon, Jun 6, 11:08 AM · Restricted Project, Restricted Project

Fri, Jun 3

vitalybuka added a comment to D126100: Add sanitizer-specific GlobalValue attributes..

LGTM, with Asm test and bitcode stuff moved as explained.

Fri, Jun 3, 7:24 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D126100: Add sanitizer-specific GlobalValue attributes..
Fri, Jun 3, 7:19 PM · Restricted Project, Restricted Project, Restricted Project