People vitalybuka

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (132 w, 21 h)

Recent Activity
View All

Yesterday

vitalybuka accepted D52330: SafeStack: Fix flaky test (PR39001).
Thu, Sep 20, 5:20 PM

Wed, Sep 19

vitalybuka committed rL342574: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
[ThinLTO] Write TYPE_IDs for types used in functions imported by aliases
Wed, Sep 19, 11:53 AM
vitalybuka closed D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
Wed, Sep 19, 11:53 AM
vitalybuka committed rL342573: [ThinLTO] Extract getReferencedTypeIds from [NFC].
[ThinLTO] Extract getReferencedTypeIds from [NFC]
Wed, Sep 19, 11:53 AM
vitalybuka closed D52203: [ThinLTO] Extract getReferencedTypeIds from [NFC].
Wed, Sep 19, 11:52 AM
vitalybuka added a comment to D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
In D52201#1239405, @tejohnson wrote:

Can you update description to point out that this is an issue because we will import the alias as a copy of aliasee?

Out of curiosity, what is the failure mode with this bug?

False CFI errrors. I've just added that into description.

Wed, Sep 19, 11:27 AM
vitalybuka updated the diff for D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.

Addressed comments from @tejohnson

Wed, Sep 19, 11:26 AM
vitalybuka added inline comments to D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
Wed, Sep 19, 11:26 AM
vitalybuka updated the summary of D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
Wed, Sep 19, 11:08 AM

Tue, Sep 18

vitalybuka added a dependency for D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases: D52203: [ThinLTO] Extract getReferencedTypeIds from [NFC].
Tue, Sep 18, 4:03 PM
vitalybuka added a dependent revision for D52203: [ThinLTO] Extract getReferencedTypeIds from [NFC]: D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
Tue, Sep 18, 4:03 PM
vitalybuka added inline comments to D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks.
Tue, Sep 18, 1:40 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
Tue, Sep 18, 11:31 AM

Mon, Sep 17

vitalybuka added reviewers for D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases: tejohnson, eugenis.
Mon, Sep 17, 6:13 PM
vitalybuka updated the diff for D52203: [ThinLTO] Extract getReferencedTypeIds from [NFC].

Remove unused var

Mon, Sep 17, 6:09 PM
vitalybuka added reviewers for D52203: [ThinLTO] Extract getReferencedTypeIds from [NFC]: eugenis, tejohnson.
Mon, Sep 17, 6:06 PM
vitalybuka created D52203: [ThinLTO] Extract getReferencedTypeIds from [NFC].
Mon, Sep 17, 6:06 PM
vitalybuka created D52201: [ThinLTO] Write TYPE_IDs for types used in functions imported by aliases.
Mon, Sep 17, 6:00 PM
vitalybuka accepted D51556: [LTO] Make detection of WPD remark enablement more robust.
Mon, Sep 17, 10:36 AM

Tue, Sep 4

vitalybuka accepted D51538: Add glibc_prereq to platform limits mmsghdr.
Tue, Sep 4, 4:27 PM
vitalybuka added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

Now SANITIZER_NETBSD shares almost nothing with the rest
May I ask you to create sanitizer_netbsd.cc and move code there?

Tue, Sep 4, 4:01 PM · Restricted Project

Fri, Aug 31

vitalybuka added inline comments to D51538: Add glibc_prereq to platform limits mmsghdr.
Fri, Aug 31, 3:14 PM
vitalybuka added inline comments to D51538: Add glibc_prereq to platform limits mmsghdr.
Fri, Aug 31, 11:11 AM

Thu, Aug 30

vitalybuka accepted D51425: Add internal_sysctl() used by FreeBSD, NetBSD, OpenBSD and MacOSX.
Thu, Aug 30, 3:23 PM · Restricted Project

Tue, Aug 28

vitalybuka added a comment to D51106: Introduce new type for inteceptors UINTMAX_T.

yes

Tue, Aug 28, 1:37 PM · Restricted Project
vitalybuka accepted D51106: Introduce new type for inteceptors UINTMAX_T.

May I ask you to create trivial positive test for this function in sanitizer_common?

Tue, Aug 28, 1:23 PM · Restricted Project

Mon, Aug 27

vitalybuka committed rL340769: [lsan] Check that leak sanitizer works in the forked process.
[lsan] Check that leak sanitizer works in the forked process
Mon, Aug 27, 12:16 PM
vitalybuka committed rCRT340769: [lsan] Check that leak sanitizer works in the forked process.
[lsan] Check that leak sanitizer works in the forked process
Mon, Aug 27, 12:16 PM
vitalybuka committed rCRT340758: Revert "[lsan] Do not check for leaks in the forked process".
Revert "[lsan] Do not check for leaks in the forked process"
Mon, Aug 27, 10:31 AM
vitalybuka reopened D47751: [lsan] Do not check for leaks in the forked process.
Mon, Aug 27, 10:31 AM
vitalybuka planned changes to D47751: [lsan] Do not check for leaks in the forked process.
Mon, Aug 27, 10:31 AM
vitalybuka committed rL340758: Revert "[lsan] Do not check for leaks in the forked process".
Revert "[lsan] Do not check for leaks in the forked process"
Mon, Aug 27, 10:27 AM

Fri, Aug 24

vitalybuka added a comment to D51230: Use unique_ptr.

Also https://reviews.llvm.org/rL340654

Fri, Aug 24, 2:04 PM
vitalybuka committed rL340654: Use unique_ptr to hold MCInstrInfo.
Use unique_ptr to hold MCInstrInfo
Fri, Aug 24, 2:04 PM
vitalybuka accepted D51230: Use unique_ptr.
Fri, Aug 24, 12:40 PM
vitalybuka added a comment to D50204: [llvm-objdump] Label calls to the PLT.

This is broken by the patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/22760/steps/check-lld%20asan/logs/stdio

Fri, Aug 24, 12:33 PM

Thu, Aug 23

vitalybuka added a comment to D51049: Driver: Enable address-significance tables by default when targeting COFF..

This breaks Windows bot
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/33846/steps/run%20check-asan/logs/stdio

Thu, Aug 23, 2:15 PM
vitalybuka committed rL340517: Fix comparison of char and int64 in TestWriteFixNegativeInt.
Fix comparison of char and int64 in TestWriteFixNegativeInt
Thu, Aug 23, 12:13 AM

Wed, Aug 22

vitalybuka added inline comments to D44429: [BinaryFormat] MessagePack reader/writer.
Wed, Aug 22, 5:49 PM
vitalybuka accepted D51119: [sanitizer] Don't call task_for_pid(mach_task_self). NFC..
Wed, Aug 22, 5:32 PM · Restricted Project

Aug 20 2018

vitalybuka committed rL340202: Revert "AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit addr space".
Revert "AMDGPU: bump AS.MAX_COMMON_ADDRESS to 6 since 32-bit addr space"
Aug 20 2018, 12:32 PM

Aug 16 2018

vitalybuka committed rCXX339971: Revert "Establish the <bit> header. NFC yet. Reviewed as https://reviews.llvm..
Revert "Establish the <bit> header. NFC yet. Reviewed as https://reviews.llvm.
Aug 16 2018, 4:58 PM
vitalybuka reopened D50815: Establish the <bit> header.

Reverted r339971 as it breaks sanitizer bots

Aug 16 2018, 4:58 PM
vitalybuka committed rL339971: Revert "Establish the <bit> header. NFC yet. Reviewed as https://reviews.llvm..
Revert "Establish the <bit> header. NFC yet. Reviewed as https://reviews.llvm.
Aug 16 2018, 4:58 PM
vitalybuka accepted D50865: [hwasan] Enable Android logging..
Aug 16 2018, 2:55 PM
vitalybuka accepted D50752: [hwasan] Add __hwasan_handle_longjmp..
Aug 16 2018, 1:41 PM
vitalybuka accepted D50753: [hwasan] Add malloc_fill_byte and free_fill_byte flags..
Aug 16 2018, 1:04 PM

Aug 15 2018

vitalybuka added a comment to D50067: [ARM] Handle signed icmps in ARMCodeGenPrepare.

Reverted with r339806

Aug 15 2018, 1:10 PM
vitalybuka committed rL339806: Revert "[ARM] Allow signed icmps in ARMCodeGenPrepare".
Revert "[ARM] Allow signed icmps in ARMCodeGenPrepare"
Aug 15 2018, 1:10 PM
vitalybuka reopened D50067: [ARM] Handle signed icmps in ARMCodeGenPrepare.

I don't see obvious problem here.
If no one is looking into this, I am going to revert?

Aug 15 2018, 11:35 AM
vitalybuka added a comment to D50067: [ARM] Handle signed icmps in ARMCodeGenPrepare.
Command Output (stderr):
--
=================================================================
==40218==ERROR: AddressSanitizer: use-after-poison on address 0x621000003dc8 at pc 0x00000168d853 bp 0x7fff0ab4e990 sp 0x7fff0ab4e988
READ of size 8 at 0x621000003dc8 thread T0
    #0 0x168d852 in getParamType /b/sanitizer-x86_64-linux-fast/build/llvm/include/llvm/IR/DerivedTypes.h:135:49
    #1 0x168d852 in Mutate /b/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/ARM/ARMCodeGenPrepare.cpp:463
    #2 0x168d852 in TryToPromote /b/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/ARM/ARMCodeGenPrepare.cpp:658
    #3 0x168d852 in (anonymous namespace)::ARMCodeGenPrepare::runOnFunction(llvm::Function&) /b/sanitizer-x86_64-linux-fast/build/llvm/lib/Target/ARM/ARMCodeGenPrepare.cpp:697
    #4 0x476458d in llvm::FPPassManager::runOnFunction(llvm::Function&) /b/sanitizer-x86_64-linux-fast/build/llvm/lib/IR/LegacyPassManager.cpp:1586:27
    #5 0x4764ba2 in llvm::FPPassManager::runOnModule(llvm::Module&) /b/sanitizer-x86_64-linux-fast/build/llvm/lib/IR/LegacyPassManager.cpp:1609:16
    #6 0x4765918 in runOnModule /b/sanitizer-x86_64-linux-fast/build/llvm/lib/IR/LegacyPassManager.cpp:1669:27
    #7 0x4765918 in llvm::legacy::PassManagerImpl::run(llvm::Module&) /b/sanitizer-x86_64-linux-fast/build/llvm/lib/IR/LegacyPassManager.cpp:1774
    #8 0x9f6d5f in compileModule(char**, llvm::LLVMContext&) /b/sanitizer-x86_64-linux-fast/build/llvm/tools/llc/llc.cpp:597:8
    #9 0x9f02d0 in main /b/sanitizer-x86_64-linux-fast/build/llvm/tools/llc/llc.cpp:351:22
    #10 0x7fdfb54d92e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
    #11 0x8fa609 in _start (/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan/bin/llc+0x8fa609)
Aug 15 2018, 11:28 AM

Aug 14 2018

vitalybuka accepted D50746: [hwasan] Add a basic API..
Aug 14 2018, 4:51 PM

Aug 13 2018

vitalybuka accepted D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.
Aug 13 2018, 2:05 PM

Aug 10 2018

vitalybuka accepted D50581: [hwasan] Allow optional early shadow setup..
Aug 10 2018, 4:41 PM
vitalybuka accepted D50574: [hwasan] Handle missing /proc/self/maps..
Aug 10 2018, 11:07 AM
vitalybuka accepted D50570: [hwasan] Provide __sanitizer_* aliases to allocator functions..
Aug 10 2018, 10:54 AM
vitalybuka accepted D50562: [sanitizer] Remove st(X) from the clobber list in 32-bit x86 atomics.
Aug 10 2018, 8:40 AM
vitalybuka accepted D50544: [hwasan] Add -hwasan-with-ifunc flag..
Aug 10 2018, 8:36 AM

Aug 8 2018

vitalybuka requested changes to D49397: Pass CMAKE_C_FLAGS to the custom libc++ build too.

waiting for promised update

Aug 8 2018, 2:02 PM

Jun 28 2018

vitalybuka added inline comments to D48553: [scudo] Add some runtime tests for the minimal runtime.
Jun 28 2018, 10:52 AM
vitalybuka accepted D48553: [scudo] Add some runtime tests for the minimal runtime.
Jun 28 2018, 10:52 AM

Jun 25 2018

vitalybuka requested changes to D48566: UBSan blacklist workaround for bot timeouts.

+1 for no_sanitize attribute

Jun 25 2018, 1:55 PM
vitalybuka accepted D48566: UBSan blacklist workaround for bot timeouts.
Jun 25 2018, 1:53 PM
vitalybuka accepted D48525: Handle NetBSD specific path in findDebugBinary().

lgtm in any case

Jun 25 2018, 11:16 AM
vitalybuka added inline comments to D48525: Handle NetBSD specific path in findDebugBinary().
Jun 25 2018, 11:15 AM
vitalybuka added inline comments to D48525: Handle NetBSD specific path in findDebugBinary().
Jun 25 2018, 11:07 AM

Jun 21 2018

vitalybuka accepted D48446: [ubsan] Add support for reporting diagnostics to a monitor process.
Jun 21 2018, 6:19 PM
vitalybuka added inline comments to D48446: [ubsan] Add support for reporting diagnostics to a monitor process.
Jun 21 2018, 6:16 PM
vitalybuka added inline comments to D48446: [ubsan] Add support for reporting diagnostics to a monitor process.
Jun 21 2018, 6:12 PM
vitalybuka added inline comments to D48446: [ubsan] Add support for reporting diagnostics to a monitor process.
Jun 21 2018, 5:58 PM
vitalybuka added inline comments to D48446: [ubsan] Add support for reporting diagnostics to a monitor process.
Jun 21 2018, 5:31 PM
vitalybuka added inline comments to D48446: [ubsan] Add support for reporting diagnostics to a monitor process.
Jun 21 2018, 1:03 PM
vitalybuka added inline comments to D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+.
Jun 21 2018, 11:25 AM · Restricted Project
vitalybuka added a comment to D48449: [libfuzzer] Re-enable libFuzzer tests in "check-all".

Could please you put into description short explanation or submitted patch to explain why we can re-enable this now?

Jun 21 2018, 11:15 AM
vitalybuka added a comment to D48446: [ubsan] Add support for reporting diagnostics to a monitor process.

Does check-asan work?

Jun 21 2018, 11:12 AM

Jun 18 2018

vitalybuka accepted D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Jun 18 2018, 11:10 AM
vitalybuka committed rCXXA334924: Fix libcxx tests after clang r334677..
Fix libcxx tests after clang r334677.
Jun 18 2018, 1:18 AM
vitalybuka committed rCXXA334926: Fix libcxxabi tests after clang r334924.
Fix libcxxabi tests after clang r334924
Jun 18 2018, 1:18 AM

Jun 17 2018

vitalybuka committed rL334926: Fix libcxxabi tests after clang r334924.
Fix libcxxabi tests after clang r334924
Jun 17 2018, 11:48 PM
vitalybuka accepted D48261: [Fuzzer] Set an explicit libc++ dependency when needed.
Jun 17 2018, 11:33 PM
vitalybuka committed rL334924: Fix libcxx tests after clang r334677..
Fix libcxx tests after clang r334677.
Jun 17 2018, 11:29 PM
vitalybuka added a comment to D48254: [sanitizer] Refactor GNU libc version retrieval.
In D48254#1134845, @Lekensteyn wrote:

Superseded by https://reviews.llvm.org/D48265

Jun 17 2018, 11:13 PM · Restricted Project
vitalybuka committed rCRT334923: [sanitizer] Suppress unused function warning.
[sanitizer] Suppress unused function warning
Jun 17 2018, 11:00 PM
vitalybuka committed rL334923: [sanitizer] Suppress unused function warning.
[sanitizer] Suppress unused function warning
Jun 17 2018, 11:00 PM
vitalybuka committed rCRT334914: [sanitizer] Fix tsan GO build.
[sanitizer] Fix tsan GO build
Jun 17 2018, 11:02 AM
vitalybuka committed rL334914: [sanitizer] Fix tsan GO build.
[sanitizer] Fix tsan GO build
Jun 17 2018, 11:02 AM
vitalybuka committed rCRT334913: [sanitizer] Fix s390 build after r334900.
[sanitizer] Fix s390 build after r334900
Jun 17 2018, 10:45 AM
vitalybuka committed rL334913: [sanitizer] Fix s390 build after r334900.
[sanitizer] Fix s390 build after r334900
Jun 17 2018, 10:45 AM
vitalybuka committed rCRT334912: [sanitizer] Use confstr to check libc version in InitTlsSize.
[sanitizer] Use confstr to check libc version in InitTlsSize
Jun 17 2018, 10:36 AM
vitalybuka committed rL334912: [sanitizer] Use confstr to check libc version in InitTlsSize.
[sanitizer] Use confstr to check libc version in InitTlsSize
Jun 17 2018, 10:36 AM
vitalybuka closed D48265: [sanitizer] Use confstr to check libc version in InitTlsSize.
Jun 17 2018, 10:35 AM
vitalybuka updated the diff for D48265: [sanitizer] Use confstr to check libc version in InitTlsSize.

clang-format

Jun 17 2018, 10:29 AM
vitalybuka committed rL334902: [fuzzer] Python 3 print fixes.
[fuzzer] Python 3 print fixes
Jun 17 2018, 2:16 AM
vitalybuka committed rCRT334902: [fuzzer] Python 3 print fixes.
[fuzzer] Python 3 print fixes
Jun 17 2018, 2:16 AM
vitalybuka added inline comments to D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.
Jun 17 2018, 1:59 AM · Restricted Project
vitalybuka created D48265: [sanitizer] Use confstr to check libc version in InitTlsSize.
Jun 17 2018, 1:57 AM
vitalybuka committed rCRT334901: [fuzzer] Fix collect_data_flow.py for python 3.
[fuzzer] Fix collect_data_flow.py for python 3
Jun 17 2018, 1:47 AM
vitalybuka committed rCRT334900: [sanitizer] Use const char* in internal_simple_strtoll.
[sanitizer] Use const char* in internal_simple_strtoll
Jun 17 2018, 1:47 AM
vitalybuka committed rL334901: [fuzzer] Fix collect_data_flow.py for python 3.
[fuzzer] Fix collect_data_flow.py for python 3
Jun 17 2018, 1:46 AM
vitalybuka committed rL334900: [sanitizer] Use const char* in internal_simple_strtoll.
[sanitizer] Use const char* in internal_simple_strtoll
Jun 17 2018, 1:46 AM