Page MenuHomePhabricator
People vitalybuka

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (376 w, 2 d)

Recent Activity
View All

Yesterday

vitalybuka accepted D151593: [MemProf] Clean up MemProf instrumentation pass invocation.

Either way is fine

Fri, May 26, 3:29 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D151593: [MemProf] Clean up MemProf instrumentation pass invocation.
Fri, May 26, 3:25 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D151593: [MemProf] Clean up MemProf instrumentation pass invocation.
Fri, May 26, 3:15 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D151551: [compiler-rt] Mark some performance critical buffers uninitialized.
Fri, May 26, 2:52 PM · Restricted Project, Restricted Project
vitalybuka updated subscribers of D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.

FYI @sivachandra

Fri, May 26, 1:13 PM · Restricted Project, Restricted Project
vitalybuka accepted D151552: [compiler-rt] Refactor memintrinsic interceptors.

FYI @thurston

Fri, May 26, 11:04 AM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.

Not a strong request, but I assume D151552 has high chance of being reverted. To avoid conflicts, would be nice to land them with a couple of days of delay.

Fri, May 26, 11:03 AM · Restricted Project, Restricted Project
vitalybuka committed rZORG79c59229b4cf: [msan] Temporarily disable -Oz iteration (authored by vitalybuka).
[msan] Temporarily disable -Oz iteration
Fri, May 26, 9:53 AM · Restricted Project
vitalybuka committed rZORG0e27846774e5: [sanitizer] Run asan+ubsan config on fast bot (authored by vitalybuka).
[sanitizer] Run asan+ubsan config on fast bot
Fri, May 26, 12:15 AM · Restricted Project

Thu, May 25

vitalybuka committed rZORG4efb4de3948d: [msan] Remove stage3 from fast bot (authored by vitalybuka).
[msan] Remove stage3 from fast bot
Thu, May 25, 9:12 PM · Restricted Project
vitalybuka committed rGfacf22b8b07b: [fuzzer] Platfom specific version of PageSize (authored by vitalybuka).
[fuzzer] Platfom specific version of PageSize
Thu, May 25, 9:00 PM · Restricted Project, Restricted Project
vitalybuka committed rGbaa1488c1693: [fuzzer] Don't hard-code page size in FuzzerUtil.h (authored by Ami-zhang).
[fuzzer] Don't hard-code page size in FuzzerUtil.h
Thu, May 25, 8:25 PM · Restricted Project, Restricted Project
vitalybuka closed D140607: [fuzzer] Don't hard-code page size in FuzzerUtil.h.
Thu, May 25, 8:24 PM · Restricted Project, Restricted Project
vitalybuka accepted D151508: [libc++] Fix C++26 transitive includes list.

If this requires review, the original patch is better to be reverted
bots are broken

Thu, May 25, 8:21 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D140607: [fuzzer] Don't hard-code page size in FuzzerUtil.h.

Switch to sysconf

Thu, May 25, 8:03 PM · Restricted Project, Restricted Project
vitalybuka reopened D140607: [fuzzer] Don't hard-code page size in FuzzerUtil.h.
Thu, May 25, 7:58 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D151530: [fuzzer] Don't hard-code page size in FuzzerUtil.h.

After revert we reopen previous review

Thu, May 25, 7:58 PM · Restricted Project, Restricted Project
vitalybuka committed rGa2b677e81537: [fuzzer] Don't hard-code page size in FuzzerUtil.h (authored by Ami-zhang).
[fuzzer] Don't hard-code page size in FuzzerUtil.h
Thu, May 25, 4:35 PM · Restricted Project, Restricted Project
vitalybuka closed D140607: [fuzzer] Don't hard-code page size in FuzzerUtil.h.
Thu, May 25, 4:35 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D140607: [fuzzer] Don't hard-code page size in FuzzerUtil.h.

In the previous snapshot initialization was not thread safe.
and we don't want to inline initialization all over the program
and rename is unnececary

Thu, May 25, 4:30 PM · Restricted Project, Restricted Project
vitalybuka accepted D151262: hwasan: enable mmap interception (no tagging used).
Thu, May 25, 4:29 PM · Restricted Project, Restricted Project
vitalybuka accepted D140607: [fuzzer] Don't hard-code page size in FuzzerUtil.h.
Thu, May 25, 4:25 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D140607: [fuzzer] Don't hard-code page size in FuzzerUtil.h.

simplify

Thu, May 25, 4:25 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D151262: hwasan: enable mmap interception (no tagging used).
Thu, May 25, 2:45 PM · Restricted Project, Restricted Project
vitalybuka accepted D151262: hwasan: enable mmap interception (no tagging used).
Thu, May 25, 2:29 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.
Thu, May 25, 2:20 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D142184: [libcxx] Add new line after assert message.

ping

Thu, May 25, 2:16 PM · Restricted Project, Restricted Project
vitalybuka resigned from D151057: [compiler-rt] Honor CMAKE_SYSROOT in tests.

LGTM if it does not break bots

Thu, May 25, 2:15 PM · Restricted Project
vitalybuka added inline comments to D151262: hwasan: enable mmap interception (no tagging used).
Thu, May 25, 2:14 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.
Thu, May 25, 1:51 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.

Some more complex alternatives:

  • add compiler flag to emit only inline initialization

compiler can emit, but there are passes that replace some common patterns with memset. Probably suppressible with some attributes.
For sanitizer instrumentation we insert tsan_memset, asan_memset... etc

Thu, May 25, 1:49 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.
Thu, May 25, 1:44 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.

also, isn't D135716 was NOOP as it has a typo?

Thu, May 25, 1:28 PM · Restricted Project, Restricted Project
vitalybuka requested changes to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.
Thu, May 25, 1:20 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.
Thu, May 25, 1:19 PM · Restricted Project, Restricted Project
vitalybuka accepted D151484: [sanitizer] Add new symbolizer symbol.
Thu, May 25, 12:22 PM · Restricted Project, Restricted Project
vitalybuka added 2 auditor(s) for rG4498663f3de0: [AST] Initialized data after TypeSourceInfo: rjmccall, rsmith.

Please let me know it if this is deserve investigation.

Thu, May 25, 9:56 AM · Restricted Project, Restricted Project
vitalybuka committed rG4498663f3de0: [AST] Initialized data after TypeSourceInfo (authored by vitalybuka).
[AST] Initialized data after TypeSourceInfo
Thu, May 25, 9:54 AM · Restricted Project, Restricted Project
vitalybuka closed D150499: [AST] Initialized data after TypeSourceInfo.
Thu, May 25, 9:53 AM · Restricted Project, Restricted Project
vitalybuka added reviewers for D150499: [AST] Initialized data after TypeSourceInfo: kstoimenov, thurston.

Oh, I rerun msan bot locally and it looked like issue dissipated, but I probably checked wrong logs.
So I enabled -Oz on the bot, to catch more bugs, but the issue is still there https://lab.llvm.org/buildbot/#/builders/5/builds/33926

Thu, May 25, 9:30 AM · Restricted Project, Restricted Project

Wed, May 24

vitalybuka committed rZORG246c027d589d: [sanitizer] Run msan -Oz -fno-inline (authored by vitalybuka).
[sanitizer] Run msan -Oz -fno-inline
Wed, May 24, 8:45 PM · Restricted Project
vitalybuka committed rZORG06db9d06af7f: [sanitizer] Don't default BUILDBOT_BISECT_MODE (authored by vitalybuka).
[sanitizer] Don't default BUILDBOT_BISECT_MODE
Wed, May 24, 7:04 PM · Restricted Project
vitalybuka committed rZORG36fe752843a4: [sanitizer] Remove CCACHE options (authored by vitalybuka).
[sanitizer] Remove CCACHE options
Wed, May 24, 6:47 PM · Restricted Project
vitalybuka committed rZORG314c88e4b84e: [sanitizer] Fix typo in script (authored by vitalybuka).
[sanitizer] Fix typo in script
Wed, May 24, 6:36 PM · Restricted Project
vitalybuka committed rG07edc1c16faa: [NFC][sanitizer] Rename *ThreadRegistry functions (authored by vitalybuka).
[NFC][sanitizer] Rename *ThreadRegistry functions
Wed, May 24, 6:34 PM · Restricted Project, Restricted Project
vitalybuka closed D150407: [NFC][sanitizer] Rename *ThreadRegistry functions.
Wed, May 24, 6:34 PM · Restricted Project, Restricted Project
vitalybuka accepted D151085: [compiler-rt] Allow 3 simultaneous interceptors on Linux.
Wed, May 24, 6:28 PM · Restricted Project, Restricted Project
vitalybuka accepted D151343: [msan] Strip __interceptor_ from reports.
Wed, May 24, 6:23 PM · Restricted Project, Restricted Project
vitalybuka accepted D151319: [sanitizer_common] Support stripping interceptor prefixes in RenderFrame().
Wed, May 24, 6:14 PM · Restricted Project, Restricted Project
vitalybuka accepted D151318: [compiler-rt] Unify Linux and *BSD interceptors more.
Wed, May 24, 6:13 PM · Restricted Project, Restricted Project
vitalybuka accepted D151317: [compiler-rt] Introduce asm macros for interceptor trampolines.
Wed, May 24, 6:08 PM · Restricted Project, Restricted Project
vitalybuka accepted D151316: [compiler-rt] Introduce the notion of an interceptor trampoline.
Wed, May 24, 6:07 PM · Restricted Project, Restricted Project
vitalybuka committed rGd9b574c312c3: [hwasan] Fix allocator_interface implementation (authored by vitalybuka).
[hwasan] Fix allocator_interface implementation
Wed, May 24, 6:06 PM · Restricted Project, Restricted Project
vitalybuka closed D151389: [hwasan] Fix allocator_interface implementation.
Wed, May 24, 6:05 PM · Restricted Project, Restricted Project
vitalybuka committed rZORGcae0839f02cf: [sanitizer] Improve bisect script (authored by vitalybuka).
[sanitizer] Improve bisect script
Wed, May 24, 5:59 PM · Restricted Project
vitalybuka planned changes to D77373: Add more -fsanitize=array-bounds tests.
Wed, May 24, 5:38 PM · Restricted Project, Restricted Project
vitalybuka planned changes to D77374: Fix -fsanitize=array-bounds with comma operator.
Wed, May 24, 5:37 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D144335: [SCEV] Optimize FoldID.

ping

Wed, May 24, 5:36 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D144335: [SCEV] Optimize FoldID.

rebase

Wed, May 24, 5:36 PM · Restricted Project, Restricted Project
Herald added a project to D57279: NFC: Reduce presence of "template <typename AddressSpaceView>": Restricted Project.

Looking through my unfinished patches, and noticed this one.
I am curious if LocalAddressSpaceView stuff is in use, maybe it's abandoned and can be removed?
@delcypher @thetruestblue @rsundahl

Wed, May 24, 5:35 PM · Restricted Project
vitalybuka abandoned D110639: [sanitizer] Atomic access to StackDepot stats.
Wed, May 24, 5:27 PM · Restricted Project, Restricted Project
vitalybuka planned changes to D110880: [msan] Remove StackTrace::tag.
Wed, May 24, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka planned changes to D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.
Wed, May 24, 5:25 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D142184: [libcxx] Add new line after assert message.

rebase

Wed, May 24, 5:21 PM · Restricted Project, Restricted Project
vitalybuka planned changes to D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Wed, May 24, 5:18 PM · Restricted Project, Restricted Project
vitalybuka reclaimed D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Wed, May 24, 5:18 PM · Restricted Project, Restricted Project
vitalybuka abandoned D64111: Add getMostFrequentByte and use for isBytewiseValue implementation.
Wed, May 24, 5:18 PM · Restricted Project, Restricted Project
vitalybuka planned changes to D64382: Use getMostFrequentByte to decide if should used memset+stores.
Wed, May 24, 5:17 PM · Restricted Project, Restricted Project
vitalybuka planned changes to D64392: CodeGen: Use memset for bytewise values with any size.
Wed, May 24, 5:15 PM · Restricted Project, Restricted Project
vitalybuka planned changes to D61401: D60243 Test.
Wed, May 24, 5:11 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D150499: [AST] Initialized data after TypeSourceInfo.

ping

Wed, May 24, 5:10 PM · Restricted Project, Restricted Project
vitalybuka committed rG8826cd57825d: [AST] Construct Capture objects before use (authored by vitalybuka).
[AST] Construct Capture objects before use
Wed, May 24, 5:10 PM · Restricted Project, Restricted Project
vitalybuka closed D150504: [AST] Construct Capture objects before use.
Wed, May 24, 5:10 PM · Restricted Project, Restricted Project
vitalybuka accepted D151360: [sanitizer] Implement __sanitizer_get_allocated_size_fast.

Thanks, LGTM. Could you please update also compiler-rt/test/sanitizer_common/TestCases/allocator_interface.cpp?

Wed, May 24, 5:08 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D151371: hwasan: refactor order of macros in hwasan_platform_interceptors.h [NFC].
Wed, May 24, 5:03 PM · Restricted Project, Restricted Project
vitalybuka accepted D151371: hwasan: refactor order of macros in hwasan_platform_interceptors.h [NFC].
Wed, May 24, 5:03 PM · Restricted Project, Restricted Project
vitalybuka added reviewers for D151389: [hwasan] Fix allocator_interface implementation: thurston, kstoimenov.
Wed, May 24, 4:53 PM · Restricted Project, Restricted Project
vitalybuka requested review of D151389: [hwasan] Fix allocator_interface implementation.
Wed, May 24, 4:52 PM · Restricted Project, Restricted Project
vitalybuka committed rG3afd1b2c357f: [sanitizer] Deflake test (authored by vitalybuka).
[sanitizer] Deflake test
Wed, May 24, 4:49 PM · Restricted Project, Restricted Project
vitalybuka committed rGf5808fc19711: [sanitizer] Use atomic_fetch_add instead of load/store (authored by vitalybuka).
[sanitizer] Use atomic_fetch_add instead of load/store
Wed, May 24, 4:23 PM · Restricted Project, Restricted Project
vitalybuka committed rGae072da552c1: [NFC][sanitizer] Remove unused method (authored by vitalybuka).
[NFC][sanitizer] Remove unused method
Wed, May 24, 4:23 PM · Restricted Project, Restricted Project
vitalybuka committed rG096348b17987: [sanitizer] Lazy initialize AllocatorGlobalStats (authored by vitalybuka).
[sanitizer] Lazy initialize AllocatorGlobalStats
Wed, May 24, 4:11 PM · Restricted Project, Restricted Project
vitalybuka committed rGfa58f32754d2: [NFC][HWASAN] Rename AllocatorSwallowThreadLocalCache (authored by vitalybuka).
[NFC][HWASAN] Rename AllocatorSwallowThreadLocalCache
Wed, May 24, 1:28 PM · Restricted Project, Restricted Project
vitalybuka committed rGc46bc0d3e732: [lsan] Fix allocator_interface implementation (authored by vitalybuka).
[lsan] Fix allocator_interface implementation
Wed, May 24, 1:27 PM · Restricted Project, Restricted Project
vitalybuka closed D151355: [lsan] Fix allocator_interface implementation.
Wed, May 24, 1:27 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D151355: [lsan] Fix allocator_interface implementation.

This one is more than XFAIL, we have failed test in LSAN which query this stats

Wed, May 24, 1:13 PM · Restricted Project, Restricted Project
vitalybuka added reviewers for D151355: [lsan] Fix allocator_interface implementation: thurston, kstoimenov.
Wed, May 24, 1:12 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D151355: [lsan] Fix allocator_interface implementation.

update

Wed, May 24, 1:11 PM · Restricted Project, Restricted Project
vitalybuka requested review of D151355: [lsan] Fix allocator_interface implementation.
Wed, May 24, 10:57 AM · Restricted Project, Restricted Project
vitalybuka committed rGd39d93288ed9: [NFC] New line in test (authored by vitalybuka).
[NFC] New line in test
Wed, May 24, 10:56 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D151207: [mlir][Transforms][NFC] GreedyPatternRewriteDriver: Reformat debug logic.
In D151207#4369212, @vitalybuka wrote:

Is this by this one D144552 https://lab.llvm.org/buildbot/#/builders/238/builds/3575 ?

Wed, May 24, 10:54 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D151207: [mlir][Transforms][NFC] GreedyPatternRewriteDriver: Reformat debug logic.

Is this by this one D144552 https://lab.llvm.org/buildbot/#/builders/238/builds/3575 ?

Wed, May 24, 10:52 AM · Restricted Project, Restricted Project
vitalybuka committed rG4305f640f0e5: [msan] Implement __sanitizer_get_current_allocated_bytes (authored by vitalybuka).
[msan] Implement __sanitizer_get_current_allocated_bytes
Wed, May 24, 10:51 AM · Restricted Project, Restricted Project
vitalybuka closed D151352: [msan] Implement __sanitizer_get_current_allocated_bytes.
Wed, May 24, 10:50 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D151352: [msan] Implement __sanitizer_get_current_allocated_bytes.
In D151352#4369155, @kstoimenov wrote:

Could you please provide a little bit more context around the bug that this is fixing?

Wed, May 24, 10:46 AM · Restricted Project, Restricted Project
vitalybuka added reviewers for D151352: [msan] Implement __sanitizer_get_current_allocated_bytes: thurston, kstoimenov.
Wed, May 24, 10:42 AM · Restricted Project, Restricted Project
vitalybuka updated the diff for D151352: [msan] Implement __sanitizer_get_current_allocated_bytes.

update

Wed, May 24, 10:41 AM · Restricted Project, Restricted Project
vitalybuka requested review of D151352: [msan] Implement __sanitizer_get_current_allocated_bytes.
Wed, May 24, 10:40 AM · Restricted Project, Restricted Project
vitalybuka committed rG747704e34f3a: [tsan] Implement __sanitizer_purge_allocator (authored by vitalybuka).
[tsan] Implement __sanitizer_purge_allocator
Wed, May 24, 10:21 AM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rG8064caf83fb1: [PowerPC] Simplify fp-to-int store optimization: rGe7c5ced0b9f0: Revert "[PowerPC] Simplify fp-to-int store optimization".
Wed, May 24, 10:06 AM · Restricted Project, Restricted Project