Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (276 w, 5 h)

Recent Activity

Today

vitalybuka added a reverting change for rG7e3f8b8affd0: [hwasan] print exact mismatch offset for short granules.: rGa9f3ac9e3dbb: Revert "[hwasan] print exact mismatch offset for short granules.".
Thu, Jun 24, 5:33 PM
vitalybuka committed rGa9f3ac9e3dbb: Revert "[hwasan] print exact mismatch offset for short granules." (authored by vitalybuka).
Revert "[hwasan] print exact mismatch offset for short granules."
Thu, Jun 24, 5:33 PM
vitalybuka reopened D104463: [hwasan] print exact mismatch offset for short granules..
Thu, Jun 24, 5:33 PM · Restricted Project
vitalybuka committed rGa4357411107e: [scudo] Clang-format tests (authored by vitalybuka).
[scudo] Clang-format tests
Thu, Jun 24, 5:33 PM
vitalybuka added a reverting change for D104463: [hwasan] print exact mismatch offset for short granules.: rGa9f3ac9e3dbb: Revert "[hwasan] print exact mismatch offset for short granules.".
Thu, Jun 24, 5:33 PM · Restricted Project
vitalybuka added a comment to D104875: [sanitizers] Remove unset variables.

Galina, please take a look. I believe it's sanitizers only, but maybe I am missing something.

Thu, Jun 24, 2:59 PM
vitalybuka requested review of D104875: [sanitizers] Remove unset variables.
Thu, Jun 24, 2:56 PM
vitalybuka added a comment to D104463: [hwasan] print exact mismatch offset for short granules..

Probably caused by this patch https://lab.llvm.org/buildbot/#/builders/77/builds/7379

Thu, Jun 24, 12:09 PM · Restricted Project
vitalybuka committed rG35e1dbd18920: [scudo] Fix test on arch without MTE (authored by vitalybuka).
[scudo] Fix test on arch without MTE
Thu, Jun 24, 12:08 AM
vitalybuka committed rG6fd963ab64e7: [scudo] Avoid ifdef in test (authored by vitalybuka).
[scudo] Avoid ifdef in test
Thu, Jun 24, 12:01 AM

Yesterday

vitalybuka committed rG99ec78c0fede: [scudo] Fix use of ScopedDisableMemoryTagChecks in test (authored by vitalybuka).
[scudo] Fix use of ScopedDisableMemoryTagChecks in test
Wed, Jun 23, 11:57 PM
vitalybuka committed rG533abb7ecf1c: [scudo] Enabled MTE before the first allocator (authored by vitalybuka).
[scudo] Enabled MTE before the first allocator
Wed, Jun 23, 11:01 PM
vitalybuka closed D103726: [scudo] Enabled MTE before the first allocator.
Wed, Jun 23, 11:01 PM · Restricted Project
vitalybuka accepted D104824: [NFC][compiler-rt][hwasan] Move GetCurrentThread to hwasan.cpp.
Wed, Jun 23, 7:34 PM · Restricted Project
vitalybuka added a comment to D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

getUnderlyingObjects already traverse large set on instructions so
there is no reason to limit some sequences by MaxLookup.

I am not sure I completely follow this reasoning. Even if it already traverses a large number of instructions, without the depth limit it will visit even more? Do you have any estimate on the impact in terms of extra work?

Wed, Jun 23, 12:26 PM · Restricted Project

Tue, Jun 22

vitalybuka committed rZORG46790e1470ca: [NFC][sanitizer] Add newline at the end (authored by vitalybuka).
[NFC][sanitizer] Add newline at the end
Tue, Jun 22, 7:58 PM
vitalybuka committed rZORG7da0066329d9: [sanitizer] Add QEMU cleanup (authored by vitalybuka).
[sanitizer] Add QEMU cleanup
Tue, Jun 22, 7:44 PM
vitalybuka updated the diff for D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

rebase

Tue, Jun 22, 6:34 PM · Restricted Project
vitalybuka accepted D104592: tsan: re-enable mmap_stress.cpp test.
Tue, Jun 22, 6:15 PM · Restricted Project
vitalybuka accepted D104593: tsan: fix mmap atomicity.
Tue, Jun 22, 6:15 PM · Restricted Project
vitalybuka committed rZORG49ae918ba18a: [sanitizer] Fix compiler_rt_build cleanup (authored by vitalybuka).
[sanitizer] Fix compiler_rt_build cleanup
Tue, Jun 22, 5:13 PM
vitalybuka committed rZORG9c785bda6b3f: [sanitizer] Simplify clobbering (authored by vitalybuka).
[sanitizer] Simplify clobbering
Tue, Jun 22, 4:06 PM
vitalybuka committed rZORGa297226388d5: [sanitizer] Cleanup after build (authored by vitalybuka).
[sanitizer] Cleanup after build
Tue, Jun 22, 4:06 PM
vitalybuka committed rZORG536b364f914d: Less builds for sanitizer-buildbot{2,8} (authored by vitalybuka).
Less builds for sanitizer-buildbot{2,8}
Tue, Jun 22, 11:32 AM
vitalybuka committed rZORG5d0847ab1e6c: Reassign sanitizer builders/workers (authored by vitalybuka).
Reassign sanitizer builders/workers
Tue, Jun 22, 11:30 AM
vitalybuka committed rZORGa07e9a35bda5: [NFC] Reformat sanitizer workers (authored by vitalybuka).
[NFC] Reformat sanitizer workers
Tue, Jun 22, 11:30 AM

Mon, Jun 21

vitalybuka committed rGac15a128d875: [NFC] Add getUnderlyingObjects test (authored by vitalybuka).
[NFC] Add getUnderlyingObjects test
Mon, Jun 21, 4:37 PM
vitalybuka closed D104585: [NFC] Add getUnderlyingObjects test.
Mon, Jun 21, 4:37 PM · Restricted Project
vitalybuka updated the diff for D103726: [scudo] Enabled MTE before the first allocator.

typo

Mon, Jun 21, 2:02 PM · Restricted Project
vitalybuka updated the diff for D103726: [scudo] Enabled MTE before the first allocator.

typo

Mon, Jun 21, 2:01 PM · Restricted Project
vitalybuka updated the diff for D103726: [scudo] Enabled MTE before the first allocator.

comments and use DefaultConfig

Mon, Jun 21, 2:00 PM · Restricted Project

Fri, Jun 18

vitalybuka added a comment to D104568: [libfuzzer] Disable failing DFSan-related tests.

Thanks, LGTM

Fri, Jun 18, 7:12 PM · Restricted Project, Restricted Project
vitalybuka added a reviewer for D104585: [NFC] Add getUnderlyingObjects test: lebedev.ri.
Fri, Jun 18, 6:45 PM · Restricted Project
vitalybuka updated the diff for D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

rebase

Fri, Jun 18, 6:43 PM · Restricted Project
vitalybuka updated the diff for D104585: [NFC] Add getUnderlyingObjects test.

update

Fri, Jun 18, 6:42 PM · Restricted Project
vitalybuka requested review of D104585: [NFC] Add getUnderlyingObjects test.
Fri, Jun 18, 6:35 PM · Restricted Project
vitalybuka added inline comments to D104568: [libfuzzer] Disable failing DFSan-related tests.
Fri, Jun 18, 3:33 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D104568: [libfuzzer] Disable failing DFSan-related tests.
Fri, Jun 18, 3:32 PM · Restricted Project, Restricted Project
vitalybuka accepted D104561: [NFC][compiler-rt][hwasan] Move hwasanThreadList().CreateCurrentThread() into InitThreads.
Fri, Jun 18, 12:34 PM · Restricted Project
vitalybuka added inline comments to D104155: Add documentation for -fsanitize-address-use-after-return..
Fri, Jun 18, 12:32 PM · Restricted Project
vitalybuka accepted D104155: Add documentation for -fsanitize-address-use-after-return..
Fri, Jun 18, 12:30 PM · Restricted Project
vitalybuka added a comment to D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix.

https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this patch

Fri, Jun 18, 11:05 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 17

vitalybuka added a comment to D104469: Revert "Remove obsolete call to AsyncSignalSafeLazyInitiFakeStack.".

Reason for revert: it introduced unexplained memory leak.

Thu, Jun 17, 11:37 AM · Restricted Project
vitalybuka closed D104469: Revert "Remove obsolete call to AsyncSignalSafeLazyInitiFakeStack.".
Thu, Jun 17, 11:36 AM · Restricted Project
vitalybuka accepted D104469: Revert "Remove obsolete call to AsyncSignalSafeLazyInitiFakeStack.".
Thu, Jun 17, 11:36 AM · Restricted Project
vitalybuka reopened D104469: Revert "Remove obsolete call to AsyncSignalSafeLazyInitiFakeStack.".
Thu, Jun 17, 11:36 AM · Restricted Project

Wed, Jun 16

vitalybuka abandoned D64387: CodeGen: Do not memset if following stores will overwrite entire variable.
Wed, Jun 16, 3:21 PM · Restricted Project
vitalybuka abandoned D64386: CodeGen: Use memset in initializers for non-zeros.
Wed, Jun 16, 3:18 PM · Restricted Project
vitalybuka abandoned D64675: WIP: Disable optimization in emitStoresForConstant.
Wed, Jun 16, 3:12 PM · Restricted Project
vitalybuka abandoned D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init.
Wed, Jun 16, 2:43 PM · Restricted Project, Restricted Project
vitalybuka added a reviewer for D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects: lebedev.ri.
Wed, Jun 16, 2:41 PM · Restricted Project
vitalybuka updated the diff for D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

rebase

Wed, Jun 16, 2:40 PM · Restricted Project
vitalybuka accepted D104402: [scudo] Ensure proper allocator alignment in TSD test.
Wed, Jun 16, 2:12 PM · Restricted Project
vitalybuka updated the summary of D104419: Remove obsolete call to AsyncSignalSafeLazyInitiFakeStack..
Wed, Jun 16, 2:06 PM · Restricted Project
vitalybuka accepted D104419: Remove obsolete call to AsyncSignalSafeLazyInitiFakeStack..

I've updated summary.
Could you "arc amend" to include it into your git commit.

Wed, Jun 16, 2:05 PM · Restricted Project
vitalybuka updated the summary of D104419: Remove obsolete call to AsyncSignalSafeLazyInitiFakeStack..
Wed, Jun 16, 2:04 PM · Restricted Project
vitalybuka accepted D104248: [compiler-rt][hwasan] Refactor Thread::Init.
Wed, Jun 16, 12:05 PM · Restricted Project
vitalybuka added inline comments to D104402: [scudo] Ensure proper allocator alignment in TSD test.
Wed, Jun 16, 11:50 AM · Restricted Project
vitalybuka added inline comments to D104402: [scudo] Ensure proper allocator alignment in TSD test.
Wed, Jun 16, 11:47 AM · Restricted Project
vitalybuka added inline comments to D104402: [scudo] Ensure proper allocator alignment in TSD test.
Wed, Jun 16, 11:41 AM · Restricted Project
vitalybuka added inline comments to D104275: [compiler-rt][hwasan] Add GetShadowOffset function.
Wed, Jun 16, 1:28 AM · Restricted Project

Tue, Jun 15

vitalybuka added a comment to D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=.

I think @vitalybuka has concrete suggestion on the naming.

If ignorelist is used, I can delete -fsanitize-coverage-blocklist=

Tue, Jun 15, 7:27 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D104275: [compiler-rt][hwasan] Add GetShadowOffset function.
Tue, Jun 15, 7:24 PM · Restricted Project
vitalybuka added a comment to rGc4992bf593a4: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.

@kda I don't mind if we try to remove __asan_get_current_fake_stack in a separate patch

Tue, Jun 15, 6:54 PM
vitalybuka committed rGc4992bf593a4: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack (authored by kda).
[NFC][sanitizer] Remove calls to __asan_get_current_fake_stack
Tue, Jun 15, 6:52 PM
vitalybuka closed D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.
Tue, Jun 15, 6:52 PM · Restricted Project
vitalybuka accepted D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.
Tue, Jun 15, 6:49 PM · Restricted Project
vitalybuka added a comment to D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.

I've updated the summary, usually shorter title of the git commit looks nicer.

Tue, Jun 15, 6:48 PM · Restricted Project
vitalybuka retitled D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack from [sanitizer] Replace calls to __asan_get_current_fake_stack with -fsanitize-address-use-after-return=never in tests. (NFC) to [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.
Tue, Jun 15, 6:47 PM · Restricted Project
vitalybuka updated the diff for D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.

use __builtin_frame_address

Tue, Jun 15, 6:46 PM · Restricted Project
vitalybuka added inline comments to D104155: Add documentation for -fsanitize-address-use-after-return..
Tue, Jun 15, 6:23 PM · Restricted Project
vitalybuka added inline comments to D104248: [compiler-rt][hwasan] Refactor Thread::Init.
Tue, Jun 15, 3:21 PM · Restricted Project
vitalybuka updated subscribers of D104155: Add documentation for -fsanitize-address-use-after-return..
Tue, Jun 15, 2:48 PM · Restricted Project
vitalybuka committed rG6478ef61b1a4: [asan] Remove Asan, Ubsan support of RTEMS and Myriad (authored by vitalybuka).
[asan] Remove Asan, Ubsan support of RTEMS and Myriad
Tue, Jun 15, 12:59 PM
vitalybuka committed rGa99f6d307119: [NFC] Fix "unused variable" warning (authored by vitalybuka).
[NFC] Fix "unused variable" warning
Tue, Jun 15, 12:59 PM
vitalybuka closed D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad.
Tue, Jun 15, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad.

remove unrelated fix

Tue, Jun 15, 12:58 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad.

restore few lines

Tue, Jun 15, 12:30 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 14

vitalybuka committed rG51ed1c6ccc7b: [NFC][hwasan] Fix "implicitly declaring library function" (authored by vitalybuka).
[NFC][hwasan] Fix "implicitly declaring library function"
Mon, Jun 14, 10:00 PM
vitalybuka accepted D104275: [compiler-rt][hwasan] Add GetShadowOffset function.
Mon, Jun 14, 9:37 PM · Restricted Project
vitalybuka added inline comments to D104275: [compiler-rt][hwasan] Add GetShadowOffset function.
Mon, Jun 14, 9:35 PM · Restricted Project
vitalybuka accepted D104242: Alters a lit test to simplify and avoid a buildbot error.
Mon, Jun 14, 9:24 PM · Restricted Project
vitalybuka committed rGb01bfdfda64b: [lld][MachO] Fix UB after D103006 (authored by vitalybuka).
[lld][MachO] Fix UB after D103006
Mon, Jun 14, 9:22 PM
vitalybuka added a reviewer for D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad: morehouse.
Mon, Jun 14, 8:58 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka requested review of D104279: [asan] Remove Asan, Ubsan support of RTEMS and Myriad.
Mon, Jun 14, 8:55 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D101868: [clang-format] Adds a formatter for aligning arrays of structs.
Mon, Jun 14, 6:28 PM · Restricted Project, Restricted Project
vitalybuka committed rGb8919fb0eac1: [NFC][sanitizer] clang-format some code (authored by vitalybuka).
[NFC][sanitizer] clang-format some code
Mon, Jun 14, 6:05 PM
vitalybuka added inline comments to D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.
Mon, Jun 14, 2:18 PM · Restricted Project
vitalybuka added inline comments to D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.
Mon, Jun 14, 2:17 PM · Restricted Project
vitalybuka added inline comments to D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.
Mon, Jun 14, 2:15 PM · Restricted Project
vitalybuka accepted D104265: [HWASan] Enable globals support for LAM..
Mon, Jun 14, 2:06 PM · Restricted Project, Restricted Project
vitalybuka committed rGd650ccf6390b: [NFC] Remove unused variable (authored by vitalybuka).
[NFC] Remove unused variable
Mon, Jun 14, 10:58 AM

Fri, Jun 11

vitalybuka added inline comments to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
Fri, Jun 11, 6:58 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.

why __sanitizer_print_stack_trace is not enough?

We wanted to record stack traces to some databases for post-process. This is similar to the request of printing dfsan origin traces to a buffer.

Fri, Jun 11, 6:56 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.

why __sanitizer_print_stack_trace is not enough?

Fri, Jun 11, 6:21 PM · Restricted Project, Restricted Project
vitalybuka abandoned D102980: [scudo] Always MAP_NORESERVE in to release pages.
Fri, Jun 11, 3:12 PM · Restricted Project
vitalybuka abandoned D102979: [scudo] Use MAP_NORESERVE to release pages.
Fri, Jun 11, 3:12 PM · Restricted Project
vitalybuka added a comment to D103726: [scudo] Enabled MTE before the first allocator.

ping

Fri, Jun 11, 3:12 PM · Restricted Project
vitalybuka accepted D104146: [sanitizer] Replace -mllvm -asan-use-after-return in compile-rt tests with -fsanitize-address-use-after-return (NFC).
Fri, Jun 11, 3:11 PM · Restricted Project
vitalybuka added a comment to D104154: [NFC][sanitizer] Remove calls to __asan_get_current_fake_stack.

I'd prefer we just update __asan_get_current_fake_stack()

Fri, Jun 11, 3:10 PM · Restricted Project