Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (328 w, 3 d)

Recent Activity

Fri, Jun 24

vitalybuka added inline comments to D127911: Delete 'llvm.asan.globals' for global metadata..
Fri, Jun 24, 4:47 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D127911: Delete 'llvm.asan.globals' for global metadata..
Fri, Jun 24, 4:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D128559: [Sanitizers] Fix malloc_usable_size interceptions signatures for FreeBSD.

Maybe then just keep as is to avoid new preprocessor branches?

Fri, Jun 24, 4:24 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127911: Delete 'llvm.asan.globals' for global metadata..

The rest is LGTM

Fri, Jun 24, 3:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D128559: [Sanitizers] Fix malloc_usable_size interceptions signatures for FreeBSD.
Fri, Jun 24, 3:07 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127911: Delete 'llvm.asan.globals' for global metadata..
Fri, Jun 24, 2:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D128551: [NFC][HWASan] Refactor hwasan pass.
Fri, Jun 24, 1:55 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

vitalybuka added a comment to D128387: [hwasan] Add __hwasan_record_frame_record to the hwasan interface.

Could you please move refactoring (like extraction emitPrologue) into a separate CL?

Wed, Jun 22, 3:33 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

vitalybuka added a comment to D114487: [LAA] Support runtime checks for select GEP base pointers..

@fhahn
This is reduced reproducer:

Thanks! I think I was able to isolate the bits that caused problems:

  1. Unecessarily looking through selects outside the loop
  2. Introducing branches on undef/poison when looking through selects.

I recommitted the change in e9cced27390ba38eac1144aa1240281a1edadec0. I couldn't test with msan though, as it's not available on macOS. Please let me know if you see further issues.

Tue, Jun 21, 1:19 PM · Restricted Project, Restricted Project

Fri, Jun 17

vitalybuka committed rGf0ca0a324fd5: [CodeGen] Init EmptyExpr before the first use (authored by vitalybuka).
[CodeGen] Init EmptyExpr before the first use
Fri, Jun 17, 5:40 PM · Restricted Project, Restricted Project

Wed, Jun 15

vitalybuka accepted D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval.
Wed, Jun 15, 3:29 PM · Restricted Project, Restricted Project

Fri, Jun 10

vitalybuka committed rG665617182c45: [Bitcode] Don't use UINT_MAX for missing SanitizerMetadata (authored by vitalybuka).
[Bitcode] Don't use UINT_MAX for missing SanitizerMetadata
Fri, Jun 10, 6:23 PM · Restricted Project, Restricted Project
vitalybuka accepted D126929: Add sanitizer metadata attributes to clang IR gen..
Fri, Jun 10, 5:56 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D126929: Add sanitizer metadata attributes to clang IR gen..
Fri, Jun 10, 5:56 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 8

vitalybuka accepted D127326: [Sanitizers] prctl interception update for the PR_SET_VMA option case.
Wed, Jun 8, 10:03 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127368: [msan][test] Use a large cpusetsize for pthread_getaffinity_np.

Thanks for the fix!

Wed, Jun 8, 6:50 PM · Restricted Project, Restricted Project
vitalybuka accepted D127368: [msan][test] Use a large cpusetsize for pthread_getaffinity_np.
Wed, Jun 8, 6:50 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127364: [MSAN] mark test as unsupported for powerpc..

https://lab.llvm.org/buildbot/#/builders/105/builds/26496
and
https://lab.llvm.org/buildbot/#/builders/19/builds/11181

Wed, Jun 8, 6:00 PM · Restricted Project, Restricted Project
vitalybuka accepted D127364: [MSAN] mark test as unsupported for powerpc..
Wed, Jun 8, 5:25 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127364: [MSAN] mark test as unsupported for powerpc..
Wed, Jun 8, 5:25 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127326: [Sanitizers] prctl interception update for the PR_SET_VMA option case.
Wed, Jun 8, 5:05 PM · Restricted Project, Restricted Project
vitalybuka accepted D127343: [Sanitizers] Cleanup handling of stat64/statfs64.
Wed, Jun 8, 4:56 PM · Restricted Project, Restricted Project
vitalybuka accepted D127359: [MSAN] print out the only possible invalid parameter (EINVAL is returned).

maybe #define _GNU_SOURCE as in documentation?

Wed, Jun 8, 4:04 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127327: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on Android..

I believe "Depends on" should be in the summary, no in the title

Wed, Jun 8, 2:03 PM · Restricted Project, Restricted Project
vitalybuka accepted D127327: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on Android..
Wed, Jun 8, 1:51 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126929: Add sanitizer metadata attributes to clang IR gen..
Wed, Jun 8, 1:44 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D126929: Add sanitizer metadata attributes to clang IR gen..

No need to recover my snapshot, I'll just comment here.

Wed, Jun 8, 1:41 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D126100: Add sanitizer-specific GlobalValue attributes..
Wed, Jun 8, 1:26 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D126929: Add sanitizer metadata attributes to clang IR gen..

Update.

Wed, Jun 8, 1:13 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D127320: [MSAN] Add result printing for failed call in pthread_getaffinity_np. Will be reverted when test failure is diagnosed. Depends on: https://reviews.llvm.org/D127185.
Wed, Jun 8, 10:51 AM · Restricted Project, Restricted Project

Tue, Jun 7

vitalybuka accepted D126825: [compiler-rt][lsan] Choose lsan allocator via SANITIZER_CAN_USE_ALLOCATOR64.
Tue, Jun 7, 5:03 PM · Restricted Project, Restricted Project
vitalybuka accepted D125756: [sanitizer] Add the common FreeBSD AArch64 support.
Tue, Jun 7, 4:59 PM · Restricted Project, Restricted Project
vitalybuka accepted D127069: [Sanitizers] intercept FreeBSD procctl.
Tue, Jun 7, 4:53 PM · Restricted Project, Restricted Project
vitalybuka accepted D126927: [NFC][compiler-rt][asan] Unify asan and lsan allocator settings.
Tue, Jun 7, 4:50 PM · Restricted Project, Restricted Project
vitalybuka accepted D127185: [MSAN] Add interceptor for pthread_getaffinity_np..
Tue, Jun 7, 4:24 PM · Restricted Project, Restricted Project
vitalybuka accepted D127177: Add checks for -lresolv to sanitizer-ld test. These were missed in https://reviews.llvm.org/D127145..
Tue, Jun 7, 4:00 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D127185: [MSAN] Add interceptor for pthread_getaffinity_np..
Tue, Jun 7, 3:59 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127163: [clang] Add -fsanitize=memtag-globals (no-op)..

We already have -fsanitize=memtag that implies -fsanitize=memtag-heap and -fsanitize=memtag-stack.

It makes the most sense IMHO in the world where we want heap MTE. -fsanitize=memtag-heap is the most reasonable instead of -fsanitize-memtag-heap, as "do i need -fsanitize=memtag as well, like MSan?" is never a question.

Tue, Jun 7, 3:40 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format.

Up to you if you, if you want to wait for Peter. Feel free to remove and land it if you think it's done.
I added blocker only to make sure that review is shown to @phosek on Phabricator main page.

Tue, Jun 7, 2:59 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127163: [clang] Add -fsanitize=memtag-globals (no-op)..

Why do we want this as a separate -fsanitize=
Maybe better to have some modifier flag like -fsanitize-memtag-globals=1 ?

Tue, Jun 7, 2:52 PM · Restricted Project, Restricted Project
vitalybuka accepted D126580: [compiler-rt] Avoid truncating Symbolizer output.
Tue, Jun 7, 2:47 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D126929: Add sanitizer metadata attributes to clang IR gen..

I simplified this a little bit, but I guess this is effectively the same.

Tue, Jun 7, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D126929: Add sanitizer metadata attributes to clang IR gen..

rebase

Tue, Jun 7, 2:23 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D126100: Add sanitizer-specific GlobalValue attributes..

fix rebase

Tue, Jun 7, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka updated the diff for D126100: Add sanitizer-specific GlobalValue attributes..

rebase

Tue, Jun 7, 2:12 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka committed rGd7df3f0a4b8d: [NFC] Exctract getNoSanitizeMask lambda (authored by vitalybuka).
[NFC] Exctract getNoSanitizeMask lambda
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project
vitalybuka committed rGf32ad5703e83: [NFC] Move part of SanitizerMetadata into private method (authored by vitalybuka).
[NFC] Move part of SanitizerMetadata into private method
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project
vitalybuka committed rG5d9de5f44660: [NFC] Clang-format parts of D126929 and D126100 (authored by hctim).
[NFC] Clang-format parts of D126929 and D126100
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka committed rGf49a5844b6c8: [NFC][CodeGen] Rename method (authored by hctim).
[NFC][CodeGen] Rename method
Tue, Jun 7, 2:09 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126100: Add sanitizer-specific GlobalValue attributes..
Tue, Jun 7, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 6

vitalybuka added inline comments to D126100: Add sanitizer-specific GlobalValue attributes..
Mon, Jun 6, 7:17 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a reviewer for D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format: phosek.
Mon, Jun 6, 6:41 PM · Restricted Project, Restricted Project
vitalybuka accepted D127161: [compiler-rt][sanitizer] Have all OOM-related error messages start with the same format.
Mon, Jun 6, 6:40 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126580: [compiler-rt] Avoid truncating Symbolizer output.
Mon, Jun 6, 5:09 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D127145: [Driver] add -lresolv for all but Android..

yes, however I have no idea if we need !TC.getTriple().isOSFreeBSD() !TC.getTriple().isOSNetBSD() !TC.getTriple().isOSOpenBSD()) etc.
I guess if make mistake it will be noticed and fixed.

Mon, Jun 6, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

If you're seeing a miscompile, something is probably wrong with the caller. getUnderlyingObjects() is, in general, not guaranteed to produce an identifiable object. If the caller cares, it should check; for example, GlobalsAAResult::getModRefInfoForArgument checks all_of(Objects, isIdentifiedObject).

I am not sure why do don't want to make it guaranty with a patch like this?

How could we possibly guarantee that? In general, we're going to find some opaque thing that both getUnderlyingObjects() and its caller can't understand.

I mean, I guess we could define an API that narrowly guarantees it looks though all bitcast, addrspacecast, gep, phi, and select operations. But that would be expensive in general, and it's not obvious to me it solves anything.

Mon, Jun 6, 12:19 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D86669: [ValueTracking] Remove MaxLookup from getUnderlyingObjects.

If you're seeing a miscompile, something is probably wrong with the caller. getUnderlyingObjects() is, in general, not guaranteed to produce an identifiable object. If the caller cares, it should check; for example, GlobalsAAResult::getModRefInfoForArgument checks all_of(Objects, isIdentifiedObject).

Mon, Jun 6, 11:48 AM · Restricted Project, Restricted Project
vitalybuka accepted D126269: [ASan] Skip any instruction inserted by another instrumentation..
Mon, Jun 6, 11:29 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D126580: [compiler-rt] Avoid truncating Symbolizer output.

Thanks.
LGTM with few nits

Mon, Jun 6, 11:08 AM · Restricted Project, Restricted Project

Fri, Jun 3

vitalybuka added a comment to D126100: Add sanitizer-specific GlobalValue attributes..

LGTM, with Asm test and bitcode stuff moved as explained.

Fri, Jun 3, 7:24 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D126100: Add sanitizer-specific GlobalValue attributes..
Fri, Jun 3, 7:19 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka requested changes to D126929: Add sanitizer metadata attributes to clang IR gen..

Can you please rebase this patch onto others two?

Fri, Jun 3, 3:21 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D126100: Add sanitizer-specific GlobalValue attributes..
Fri, Jun 3, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a reviewer for D126100: Add sanitizer-specific GlobalValue attributes.: pcc.
Fri, Jun 3, 3:18 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka accepted D126922: Add documentation of new sanitizer-specific GV attributes..
Fri, Jun 3, 2:37 PM · Restricted Project, Restricted Project

Thu, Jun 2

vitalybuka added a comment to D114487: [LAA] Support runtime checks for select GEP base pointers..

@fhahn
This is reduced reproducer:

Thu, Jun 2, 6:15 PM · Restricted Project, Restricted Project
vitalybuka accepted D126851: [MSAN] add dn_expand intercept..
Thu, Jun 2, 4:05 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126851: [MSAN] add dn_expand intercept..
Thu, Jun 2, 10:25 AM · Restricted Project, Restricted Project

Wed, Jun 1

vitalybuka updated subscribers of D120201: [Clang] Extend -gen-reproducer flag.

This patch breaks msan bots: https://lab.llvm.org/buildbot/#/builders/5/builds/24307 and https://lab.llvm.org/buildbot/#/builders/74

Wed, Jun 1, 1:22 AM · Restricted Project, Restricted Project

Tue, May 31

vitalybuka added a comment to D124699: [DeadArgElim] Set unused arguments for internal functions.

This change is breaking memory sanitizer in some cases. We observed that when the argument is not actually removed the pass is dropping the noundef attribute. See the diff snippet below. Is that an intended behavior?

We would like to revert this as it is breaking MSan tests.

Thanks,
Kirill

< define internal %struct._object* @coro_wrapper_close(%struct.PyCoroWrapper* noundef %cw, %struct._object* noundef %args) #0 !dbg !1065 {
---
> define internal %struct._object* @coro_wrapper_close(%struct.PyCoroWrapper* noundef %cw, %struct._object* %args) #0 !dbg !1065 {
Tue, May 31, 9:16 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D114487: [LAA] Support runtime checks for select GEP base pointers..

I will continue to minimize the reproducer.
Should we revert the patch, because it breaks Msan and maybe there is a chance the bounds are calculated incorrectly?

Thanks for the report, I'll take a look. I already have suspicion of what's going wrong.

Tue, May 31, 4:57 PM · Restricted Project, Restricted Project
vitalybuka accepted D126429: [DFSan] Remove deprecated flag from build-libc-list.py.
Tue, May 31, 12:55 PM · Restricted Project, Restricted Project
vitalybuka accepted D126696: sanitizers: Do not include crypt.h if SANITIZER_INTERCEPT_CRYPT_R is undef.
Tue, May 31, 10:14 AM · Restricted Project, Restricted Project
vitalybuka accepted D126703: [LSAN] Fix up LSAN weak symbols for Windows.
Tue, May 31, 10:12 AM · Restricted Project, Restricted Project
vitalybuka accepted D126430: [DFSan] build-libc-list.py no longer provides a list of default files..
Tue, May 31, 10:12 AM · Restricted Project, Restricted Project

Mon, May 30

vitalybuka added a comment to D114487: [LAA] Support runtime checks for select GEP base pointers..

This patch is causing false reports with msan. I am trying to creduce the code. It's with TensorFlow, so far it's quite complicated.

Mon, May 30, 9:51 PM · Restricted Project, Restricted Project

May 27 2022

vitalybuka requested changes to D126100: Add sanitizer-specific GlobalValue attributes..

all stuff under llvm/... here needs testing, Bitcode and AsmParser have many tests usable as examples

May 27 2022, 5:10 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D126385: [msan] Implement -msan-pass-caller-to-runtime..

Do you have estimate of how often this happend? How many different instrumented functions which can be called from uninstrumented code?

May 27 2022, 11:08 AM · Restricted Project, Restricted Project

May 25 2022

vitalybuka accepted D126102: [compiler-rt][test] Fix flake in symbolize_stack test.
May 25 2022, 10:51 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

@vitalybuka what if we just changed the implementation to return whatever it had read so far?

so in https://github.com/llvm/llvm-project/blob/06fee478d217a9fbd2ba31f92bc595ed327635a5/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp#L535, we just break instead of setting the read_len = 0, and allow the filled buffer to be output?

May 25 2022, 10:51 AM · Restricted Project, Restricted Project

May 24 2022

vitalybuka added a comment to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

I would prefer you just disable the test for your platform.

The failures we see are for AArch64 and x86_64 Linux... so are you saying we should disable the test for Linux?

Yes, even "// UNSUPPORTED: *" with FIXME is fine

May 24 2022, 8:31 PM · Restricted Project, Restricted Project
vitalybuka accepted D126294: Add !nosanitize to FixedMetadataKinds.
May 24 2022, 8:25 PM · Restricted Project, Restricted Project, Restricted Project
vitalybuka added a comment to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.

@vitalybuka I'm hoping to just address the flaky test for now. There's some value in ensuring that long output doesn't crash symbolization w/in sanitizer runtimes, so I've opted to keep the test, and try to make it less prone to flake. For now, I'm happy just to remove the flake so we can update our Toolchain.

May 24 2022, 6:48 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D126102: [compiler-rt][test] Fix flake in symbolize_stack test.
May 24 2022, 4:49 PM · Restricted Project, Restricted Project
vitalybuka accepted D126336: [DFSan] Add option to specify individual library files, and an option to exit with an error code if any library file was not found..
May 24 2022, 3:25 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D123822: [compiler-rt][lsan] Share platform allocator settings between ASan and LSan.

*ping* any more comments?

May 24 2022, 10:48 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D126270: [InstCombine] Preserve !nosanitize for newly created instructions..

Please also link patches related to #1508 into review "Stack" (see "Edit Related Revisions" on the menu)

May 24 2022, 9:25 AM · Restricted Project, Restricted Project

May 23 2022

vitalybuka added a comment to D126269: [ASan] Skip any instruction inserted by another instrumentation..

We need a test here as well

May 23 2022, 10:45 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D126270: [InstCombine] Preserve !nosanitize for newly created instructions..

We need a test for that

May 23 2022, 10:40 PM · Restricted Project, Restricted Project
vitalybuka committed rG4f89ff3fc71b: [test][clang] Move -O3 in command line (authored by vitalybuka).
[test][clang] Move -O3 in command line
May 23 2022, 3:57 PM · Restricted Project, Restricted Project

May 19 2022

vitalybuka committed rGd33c36235df1: [lit] Fix setup of sanitizer environment (authored by vitalybuka).
[lit] Fix setup of sanitizer environment
May 19 2022, 7:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka closed D122869: [lit] Fix setup of sanitizer environment.
May 19 2022, 7:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vitalybuka added inline comments to D115319: [lsan] Move out suppression of invalid PCs from StopTheWorld.
May 19 2022, 7:18 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D125756: [sanitizer] Add the common FreeBSD AArch64 support.
May 19 2022, 6:25 PM · Restricted Project, Restricted Project
vitalybuka accepted D125901: [safestack] Fix Mmap on FreeBSD AArch64.
May 19 2022, 6:20 PM · Restricted Project, Restricted Project
vitalybuka accepted D125902: [fuzzer] Fix TableLookupTest on FreeBSD.
May 19 2022, 6:19 PM · Restricted Project, Restricted Project
vitalybuka accepted D126037: [ASan] Add sleep_before_init flag.
May 19 2022, 6:18 PM · Restricted Project, Restricted Project
vitalybuka committed rGc153c61fadf9: Handle instrumentation of scalar single-precision (_ss) intrinsics (authored by capn).
Handle instrumentation of scalar single-precision (_ss) intrinsics
May 19 2022, 1:57 PM · Restricted Project, Restricted Project
vitalybuka closed D124871: Handle instrumentation of scalar single-precision (_ss) intrinsics.
May 19 2022, 1:57 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D124871: Handle instrumentation of scalar single-precision (_ss) intrinsics.
May 19 2022, 1:56 PM · Restricted Project, Restricted Project