♟ vitalybuka

Revert 374629 "[sancov] Accommodate sancov and coverage report server for use…

[sancov] Accommodate sancov and coverage report server for use under Windows

[sancov] Use LLVM Support library JSON writer in favor of individual…

[sancov] Accommodate sancov and coverage report server for use under Windows

[sancov] Use LLVM Support library JSON writer in favor of individual…

[asan] Return true from instrumentModule

Insert module constructors in a module pass

[tsan,msan] Insert module constructors in a module pass

[msan, NFC] Move option parsing into constructor

[tsan,msan] Insert module constructors in a module pass

[msan, NFC] Move option parsing into constructor

In D51018#1702476, @dgg5503 wrote:

In D51018#1702330, @vitalybuka wrote:

In D51018#1700811, @dgg5503 wrote:

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

I like the change.

Could you move JSONWriter -> JSON refactoring into separate patch and rebase win stuff ontop?
If you don't have commiter access, someone will need to commit it for you
So I don't mind to split the patch and commit myself.

Sure thing! Would I be creating a separate diff for review or would this be taken from the history? Also, I do not have commiter access so I will need someone to commit it for me.

In D51018#1700811, @dgg5503 wrote:

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

[sanitizer, NFC] Fix grammar in comment

[System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI

[System Model] [TTI] Fix virtual destructor warning

[sanitizer] Disable signal_trap_handler on s390

[System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI

[System Model] [TTI] Fix virtual destructor warning

[sanitizer] Disable signal_trap_handler on s390

[sanitizer] Make signal_name a C test

[sanitizer] Use raise() in test and cover more signals

[sanitizer] Fix crypt.cpp on Android again

[sanitizer] Fix crypt.cpp test on Darwin

[clang] enable_trivial_var_init_zero should not be Joined<>

[clang] Add llvm-ifs in test deps

[sanitizer] Disable crypt*.cpp tests on Android

[sanitizer] Fix signal_trap_handler.cpp on android

[clang] Accept -ftrivial-auto-var-init in clang-cl

[tsan, go] fix Go windows build

[tsan, go] break commands into multiple lines

[tsan] Don't delay SIGTRAP handler

[sanitizer] Print SIGTRAP for corresponding signal

[tsan] Don't delay SIGTRAP handler

remove SIG prefix from the string

fix handle_sigtrap value

remove unneeded final trap

It was reverted. But I am not planing to work on this soon.

vitalybuka (Vitaly Buka)
User

Projects

User Details

Recent Activity
View All

Fri, Oct 11

Thu, Oct 10

Wed, Oct 9

Tue, Oct 8

Mon, Oct 7

vitalybuka (Vitaly Buka)User