vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (118 w, 4 d)

Recent Activity

Today

vitalybuka accepted D48087: [TSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Mon, Jun 18, 11:10 AM
vitalybuka committed rCXXA334924: Fix libcxx tests after clang r334677..
Fix libcxx tests after clang r334677.
Mon, Jun 18, 1:18 AM
vitalybuka committed rCXXA334926: Fix libcxxabi tests after clang r334924.
Fix libcxxabi tests after clang r334924
Mon, Jun 18, 1:18 AM

Yesterday

vitalybuka committed rL334926: Fix libcxxabi tests after clang r334924.
Fix libcxxabi tests after clang r334924
Sun, Jun 17, 11:48 PM
vitalybuka accepted D48261: [Fuzzer] Set an explicit libc++ dependency when needed.
Sun, Jun 17, 11:33 PM
vitalybuka committed rL334924: Fix libcxx tests after clang r334677..
Fix libcxx tests after clang r334677.
Sun, Jun 17, 11:29 PM
vitalybuka added a comment to D48254: [sanitizer] Refactor GNU libc version retrieval.
Sun, Jun 17, 11:13 PM · Restricted Project
vitalybuka committed rCRT334923: [sanitizer] Suppress unused function warning.
[sanitizer] Suppress unused function warning
Sun, Jun 17, 11:00 PM
vitalybuka committed rL334923: [sanitizer] Suppress unused function warning.
[sanitizer] Suppress unused function warning
Sun, Jun 17, 11:00 PM
vitalybuka committed rCRT334914: [sanitizer] Fix tsan GO build.
[sanitizer] Fix tsan GO build
Sun, Jun 17, 11:02 AM
vitalybuka committed rL334914: [sanitizer] Fix tsan GO build.
[sanitizer] Fix tsan GO build
Sun, Jun 17, 11:02 AM
vitalybuka committed rCRT334913: [sanitizer] Fix s390 build after r334900.
[sanitizer] Fix s390 build after r334900
Sun, Jun 17, 10:45 AM
vitalybuka committed rL334913: [sanitizer] Fix s390 build after r334900.
[sanitizer] Fix s390 build after r334900
Sun, Jun 17, 10:45 AM
vitalybuka committed rCRT334912: [sanitizer] Use confstr to check libc version in InitTlsSize.
[sanitizer] Use confstr to check libc version in InitTlsSize
Sun, Jun 17, 10:36 AM
vitalybuka committed rL334912: [sanitizer] Use confstr to check libc version in InitTlsSize.
[sanitizer] Use confstr to check libc version in InitTlsSize
Sun, Jun 17, 10:36 AM
vitalybuka closed D48265: [sanitizer] Use confstr to check libc version in InitTlsSize.
Sun, Jun 17, 10:35 AM
vitalybuka updated the diff for D48265: [sanitizer] Use confstr to check libc version in InitTlsSize.

clang-format

Sun, Jun 17, 10:29 AM
vitalybuka committed rL334902: [fuzzer] Python 3 print fixes.
[fuzzer] Python 3 print fixes
Sun, Jun 17, 2:16 AM
vitalybuka committed rCRT334902: [fuzzer] Python 3 print fixes.
[fuzzer] Python 3 print fixes
Sun, Jun 17, 2:16 AM
vitalybuka added inline comments to D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.
Sun, Jun 17, 1:59 AM · Restricted Project
vitalybuka created D48265: [sanitizer] Use confstr to check libc version in InitTlsSize.
Sun, Jun 17, 1:57 AM
vitalybuka committed rCRT334901: [fuzzer] Fix collect_data_flow.py for python 3.
[fuzzer] Fix collect_data_flow.py for python 3
Sun, Jun 17, 1:47 AM
vitalybuka committed rCRT334900: [sanitizer] Use const char* in internal_simple_strtoll.
[sanitizer] Use const char* in internal_simple_strtoll
Sun, Jun 17, 1:47 AM
vitalybuka committed rL334901: [fuzzer] Fix collect_data_flow.py for python 3.
[fuzzer] Fix collect_data_flow.py for python 3
Sun, Jun 17, 1:46 AM
vitalybuka committed rL334900: [sanitizer] Use const char* in internal_simple_strtoll.
[sanitizer] Use const char* in internal_simple_strtoll
Sun, Jun 17, 1:46 AM

Sat, Jun 16

vitalybuka added inline comments to D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.
Sat, Jun 16, 3:29 PM · Restricted Project
vitalybuka added inline comments to D44623: [ASAN] Fix crash on i?86-linux (32-bit) against glibc 2.27 and later.
Sat, Jun 16, 12:45 AM · Restricted Project

Fri, Jun 15

vitalybuka committed rL334883: [asan] Enable fgets_fputs test on Android.
[asan] Enable fgets_fputs test on Android
Fri, Jun 15, 9:05 PM
vitalybuka committed rCRT334883: [asan] Enable fgets_fputs test on Android.
[asan] Enable fgets_fputs test on Android
Fri, Jun 15, 9:05 PM
vitalybuka accepted D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode..
Fri, Jun 15, 8:34 PM
vitalybuka updated subscribers of D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode..
Fri, Jun 15, 8:01 PM
vitalybuka added inline comments to D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode..
Fri, Jun 15, 6:32 PM
vitalybuka added a comment to D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode..

Added test. BTW, is my testing correct?

% ninja -C ~/Dev/llvm/release TSanitizer-i386-Test TSanitizer-x86_64-Test TSanitizer-x86_64-Test-Nolibc && ~/Dev/llvm/release/projects/
compiler-rt/lib/sanitizer_common/tests/Sanitizer-i386-Test && ~/Dev/llvm/release/projects/compiler-rt/lib/sanitizer_common/tests/Sanitiz
er-x86_64-Test
# passed
Fri, Jun 15, 6:27 PM
vitalybuka added a reviewer for D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode.: vitalybuka.
Fri, Jun 15, 5:35 PM
vitalybuka added a comment to D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode..

Could you please add corresponding check into "TEST(SanitizerCommon, FileOps)" and make sure that all platforms have the same behavior.

Fri, Jun 15, 5:35 PM
vitalybuka committed rL334866: [asan] Move long-object-path.cc test to Linux.
[asan] Move long-object-path.cc test to Linux
Fri, Jun 15, 2:30 PM
vitalybuka committed rCRT334866: [asan] Move long-object-path.cc test to Linux.
[asan] Move long-object-path.cc test to Linux
Fri, Jun 15, 2:30 PM
vitalybuka closed D48186: [asan] Move long-object-path.cc test to Linux.
Fri, Jun 15, 2:30 PM
vitalybuka added a comment to D48186: [asan] Move long-object-path.cc test to Linux.

Wait, what happened to compiler-rt/test/asan/TestCases/log-path_test.cc? It should not be removed.

Fri, Jun 15, 2:29 PM
vitalybuka accepted D48207: [Fuzzer] Don't hardcode target architecture for Fuzzer tests.
Fri, Jun 15, 11:23 AM

Thu, Jun 14

vitalybuka created D48186: [asan] Move long-object-path.cc test to Linux.
Thu, Jun 14, 12:20 PM
vitalybuka accepted D48052: [sanitizer] Don't treat colon before slash as a flag separator.

works for me any way

Thu, Jun 14, 12:04 PM
vitalybuka accepted D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..
Thu, Jun 14, 12:59 AM
vitalybuka accepted D48156: [NFC] Generalize flags for linking in shared objects in compiler-rt tests to support using multiple shared objects at once.
Thu, Jun 14, 12:59 AM

Wed, Jun 13

vitalybuka added a comment to D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..

@vitalybuka What do you think? I guess a more generalized framework could be developed to reduce code duplication, but I'm really not sure whether it's worth it.

Wed, Jun 13, 7:16 PM
vitalybuka accepted D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, Jun 13, 6:05 PM
vitalybuka added a comment to D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..

@vitalybuka Turns out the simple trick I was using for Darwin did not work for the Linux linker, and more invasive changes were required.
What do you think? I don't see a way to do this without introducing extra substitutions, even though they are ugly.
I don't really mind the ugliness in testing configuration scripts here.

Wed, Jun 13, 6:02 PM
vitalybuka added inline comments to D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.
Wed, Jun 13, 4:53 PM · Restricted Project
vitalybuka accepted D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27.
Wed, Jun 13, 4:49 PM · Restricted Project
vitalybuka added inline comments to D48052: [sanitizer] Don't treat colon before slash as a flag separator.
Wed, Jun 13, 4:39 PM
vitalybuka added a comment to D42043: c-index: CXString: fix MSAN read-past-end bug.

Is this stale?

Wed, Jun 13, 2:40 PM

Mon, Jun 11

vitalybuka accepted D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.
Mon, Jun 11, 2:01 PM · Restricted Project
vitalybuka added inline comments to D47960: [asan, myriad] Support environment variables.
Mon, Jun 11, 11:34 AM
vitalybuka added a comment to D45604: Support for multiarch runtimes layout.

Does it have to be a single patch?

Mon, Jun 11, 11:09 AM
vitalybuka closed D47970: [Sanitizers] Move pvalloc overflow tests to common..
Mon, Jun 11, 11:08 AM
vitalybuka reopened D47970: [Sanitizers] Move pvalloc overflow tests to common..
Mon, Jun 11, 11:08 AM
vitalybuka accepted D47970: [Sanitizers] Move pvalloc overflow tests to common..
Mon, Jun 11, 11:08 AM

Fri, Jun 8

vitalybuka accepted D47971: [Sanitizers] Move allocator_returns_null.cc test to common..
Fri, Jun 8, 6:41 PM
vitalybuka accepted D47968: [MSan] Switch to common aligned allocs tests..
Fri, Jun 8, 5:38 PM
vitalybuka committed rCRT334319: [asan] Re-enable no_asan_gen_globals for 32-bit.
[asan] Re-enable no_asan_gen_globals for 32-bit
Fri, Jun 8, 2:09 PM
vitalybuka committed rL334319: [asan] Re-enable no_asan_gen_globals for 32-bit.
[asan] Re-enable no_asan_gen_globals for 32-bit
Fri, Jun 8, 2:09 PM
vitalybuka accepted D47924: [Sanitizers] Check alignment != 0 for aligned_alloc and posix_memalign.
Fri, Jun 8, 10:52 AM

Thu, Jun 7

vitalybuka accepted D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Thu, Jun 7, 5:28 PM
vitalybuka added inline comments to D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Thu, Jun 7, 4:50 PM
vitalybuka added inline comments to D47793: [MSan] Report proper error on allocator failures instead of CHECK(0)-ing.
Thu, Jun 7, 2:20 PM
vitalybuka committed rC334216: Introducing single for loop into clang_proto_fuzzer.
Introducing single for loop into clang_proto_fuzzer
Thu, Jun 7, 12:22 PM
vitalybuka committed rL334216: Introducing single for loop into clang_proto_fuzzer.
Introducing single for loop into clang_proto_fuzzer
Thu, Jun 7, 12:22 PM
vitalybuka closed D47843: Introducing single for loop into clang_proto_fuzzer.
Thu, Jun 7, 12:22 PM
vitalybuka accepted D47843: Introducing single for loop into clang_proto_fuzzer.
Thu, Jun 7, 12:13 PM
vitalybuka updated the diff for D47843: Introducing single for loop into clang_proto_fuzzer.

git clang-format -f --style=file HEAD^

Thu, Jun 7, 12:12 PM
vitalybuka updated the summary of D47843: Introducing single for loop into clang_proto_fuzzer.
Thu, Jun 7, 12:00 PM
vitalybuka accepted D47843: Introducing single for loop into clang_proto_fuzzer.
Thu, Jun 7, 11:59 AM

Wed, Jun 6

vitalybuka committed rCRT334152: [sanitizer] Don't use internal_unlink on Windows.
[sanitizer] Don't use internal_unlink on Windows
Wed, Jun 6, 5:31 PM
vitalybuka committed rL334152: [sanitizer] Don't use internal_unlink on Windows.
[sanitizer] Don't use internal_unlink on Windows
Wed, Jun 6, 5:31 PM
vitalybuka committed rL334138: [sanitizer] Replace deprecated mktemp with mkstemp.
[sanitizer] Replace deprecated mktemp with mkstemp
Wed, Jun 6, 3:10 PM
vitalybuka committed rCRT334138: [sanitizer] Replace deprecated mktemp with mkstemp.
[sanitizer] Replace deprecated mktemp with mkstemp
Wed, Jun 6, 3:10 PM
vitalybuka committed rCRT334130: [sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer.
[sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer
Wed, Jun 6, 1:58 PM
vitalybuka committed rL334130: [sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer.
[sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer
Wed, Jun 6, 1:58 PM
vitalybuka closed D46618: [sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer.
Wed, Jun 6, 1:58 PM
vitalybuka accepted D47650: Disable recursive interceptors in signal(3)/MSan.
Wed, Jun 6, 1:53 PM · Restricted Project
vitalybuka accepted D47835: [Fuzzer] Use private libc++ even for Fuchsia.
Wed, Jun 6, 1:51 PM
vitalybuka requested changes to D47843: Introducing single for loop into clang_proto_fuzzer.
Wed, Jun 6, 1:44 PM
vitalybuka added a comment to D46618: [sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer.

Just found https://github.com/google/sanitizers/issues/435 and https://chromiumcodereview.appspot.com/18661009.

Maybe it would make sense to write a separate function for reading procmaps.

Wed, Jun 6, 1:26 PM

Tue, Jun 5

vitalybuka updated the diff for D46618: [sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer.

comments

Tue, Jun 5, 11:33 AM
vitalybuka added inline comments to D46618: [sanitizer] Cleanup ReadFileToVector and ReadFileToBuffer.
Tue, Jun 5, 11:31 AM
vitalybuka committed rL334036: [lsan] Do not check for leaks in the forked process.
[lsan] Do not check for leaks in the forked process
Tue, Jun 5, 11:20 AM
vitalybuka committed rCRT334036: [lsan] Do not check for leaks in the forked process.
[lsan] Do not check for leaks in the forked process
Tue, Jun 5, 11:20 AM
vitalybuka closed D47751: [lsan] Do not check for leaks in the forked process.
Tue, Jun 5, 11:20 AM
vitalybuka updated the diff for D47751: [lsan] Do not check for leaks in the forked process.

warning

Tue, Jun 5, 11:19 AM
vitalybuka added a reviewer for D47751: [lsan] Do not check for leaks in the forked process: eugenis.
Tue, Jun 5, 10:17 AM

Mon, Jun 4

vitalybuka updated the diff for D47751: [lsan] Do not check for leaks in the forked process.

test cleanup

Mon, Jun 4, 6:16 PM
vitalybuka updated the diff for D47751: [lsan] Do not check for leaks in the forked process.

typo

Mon, Jun 4, 6:14 PM
vitalybuka created D47751: [lsan] Do not check for leaks in the forked process.
Mon, Jun 4, 6:13 PM
vitalybuka accepted D47666: Refactored clang-fuzzer and added new (copy) files.
Mon, Jun 4, 4:10 PM
vitalybuka accepted D47442: Introduce CheckASLR() in sanitizers.
Mon, Jun 4, 1:19 PM · Restricted Project
vitalybuka requested changes to D47666: Refactored clang-fuzzer and added new (copy) files.
Mon, Jun 4, 1:10 PM

Fri, Jun 1

vitalybuka added a comment to D47666: Refactored clang-fuzzer and added new (copy) files.

Good practice is to avoid merging changes into a single one.
Here one patch should be "refactoring" and the second for "loop-proto-fuzzer."

Fri, Jun 1, 5:10 PM
vitalybuka added a comment to D47666: Refactored clang-fuzzer and added new (copy) files.

Good practice is to avoid merging changes into a single one.
Here one patch should be "refactoring" and the second for "loop-proto-fuzzer."

Fri, Jun 1, 5:06 PM
vitalybuka added inline comments to D47665: Refactored clang-fuzzer in preparation for adding new loop-proto-fuzzer.
Fri, Jun 1, 3:31 PM

Wed, May 30

vitalybuka resigned from D47561: [CMake] Unify handling of libxml2 with other libraries.
Wed, May 30, 6:01 PM