Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (187 w, 3 d)

Recent Activity

Fri, Oct 11

vitalybuka committed rGec6bfa81b7b5: Revert 374629 "[sancov] Accommodate sancov and coverage report server for use… (authored by vitalybuka).
Revert 374629 "[sancov] Accommodate sancov and coverage report server for use…
Fri, Oct 11, 10:28 PM
vitalybuka reopened D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Reverted https://reviews.llvm.org/rL374636

Fri, Oct 11, 10:28 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rL374629: [sancov] Accommodate sancov and coverage report server for use under Windows: rL374636: Revert 374629 "[sancov] Accommodate sancov and coverage report server for use….
Fri, Oct 11, 10:21 PM
vitalybuka committed rL374636: Revert 374629 "[sancov] Accommodate sancov and coverage report server for use….
Revert 374629 "[sancov] Accommodate sancov and coverage report server for use…
Fri, Oct 11, 10:21 PM
vitalybuka committed rG23aa2aec7818: [sancov] Accommodate sancov and coverage report server for use under Windows (authored by vitalybuka).
[sancov] Accommodate sancov and coverage report server for use under Windows
Fri, Oct 11, 7:36 PM
vitalybuka committed rGe8a462a01923: [sancov] Use LLVM Support library JSON writer in favor of individual… (authored by vitalybuka).
[sancov] Use LLVM Support library JSON writer in favor of individual…
Fri, Oct 11, 7:36 PM
vitalybuka closed D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Fri, Oct 11, 7:36 PM · Restricted Project, Restricted Project
vitalybuka closed D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Fri, Oct 11, 7:36 PM · Restricted Project, Restricted Project
vitalybuka committed rL374629: [sancov] Accommodate sancov and coverage report server for use under Windows.
[sancov] Accommodate sancov and coverage report server for use under Windows
Fri, Oct 11, 7:27 PM
vitalybuka committed rL374628: [sancov] Use LLVM Support library JSON writer in favor of individual….
[sancov] Use LLVM Support library JSON writer in favor of individual…
Fri, Oct 11, 7:27 PM
vitalybuka committed rG4cdd8287b836: [asan] Return true from instrumentModule (authored by vitalybuka).
[asan] Return true from instrumentModule
Fri, Oct 11, 6:50 PM
vitalybuka committed rL374623: [asan] Return true from instrumentModule.
[asan] Return true from instrumentModule
Fri, Oct 11, 6:50 PM
vitalybuka committed rGb46dd6e92af7: Insert module constructors in a module pass (authored by vitalybuka).
Insert module constructors in a module pass
Fri, Oct 11, 1:46 AM
vitalybuka committed rL374527: Insert module constructors in a module pass.
Insert module constructors in a module pass
Fri, Oct 11, 1:46 AM

Thu, Oct 10

vitalybuka updated the summary of D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Thu, Oct 10, 6:26 PM · Restricted Project, Restricted Project
vitalybuka accepted D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Thu, Oct 10, 6:18 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Thu, Oct 10, 6:17 PM · Restricted Project, Restricted Project
vitalybuka accepted D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Thu, Oct 10, 6:17 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Thu, Oct 10, 5:58 PM · Restricted Project, Restricted Project
vitalybuka committed rL374489: new line at the end.
new line at the end
Thu, Oct 10, 5:49 PM
vitalybuka committed rL374485: Add vitalybuka.
Add vitalybuka
Thu, Oct 10, 5:31 PM
vitalybuka committed rG5c72aa232e74: [tsan,msan] Insert module constructors in a module pass (authored by vitalybuka).
[tsan,msan] Insert module constructors in a module pass
Thu, Oct 10, 4:54 PM
vitalybuka committed rGc2b7737b3423: [msan, NFC] Move option parsing into constructor (authored by vitalybuka).
[msan, NFC] Move option parsing into constructor
Thu, Oct 10, 4:54 PM
vitalybuka closed D68832: [tsan,msan] Insert module constructors in a module pass.
Thu, Oct 10, 4:54 PM · Restricted Project, Restricted Project
vitalybuka committed rL374481: [tsan,msan] Insert module constructors in a module pass.
[tsan,msan] Insert module constructors in a module pass
Thu, Oct 10, 4:54 PM
vitalybuka committed rL374480: [msan, NFC] Move option parsing into constructor.
[msan, NFC] Move option parsing into constructor
Thu, Oct 10, 4:54 PM
vitalybuka updated the diff for D68832: [tsan,msan] Insert module constructors in a module pass.

nfc

Thu, Oct 10, 4:44 PM · Restricted Project, Restricted Project
vitalybuka created D68832: [tsan,msan] Insert module constructors in a module pass.
Thu, Oct 10, 1:46 PM · Restricted Project, Restricted Project

Wed, Oct 9

vitalybuka accepted D68676: [ASan] Do not misrepresent high value address dereferences as null dereferences.
Wed, Oct 9, 3:54 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

I like the change.

Could you move JSONWriter -> JSON refactoring into separate patch and rebase win stuff ontop?
If you don't have commiter access, someone will need to commit it for you
So I don't mind to split the patch and commit myself.

Sure thing! Would I be creating a separate diff for review or would this be taken from the history? Also, I do not have commiter access so I will need someone to commit it for me.

Wed, Oct 9, 3:34 PM · Restricted Project, Restricted Project
vitalybuka resigned from D68292: [CMake] Disable building all Darwin libraries (except builtins) for macOS i386 when the SDK is >= 10.15..
Wed, Oct 9, 2:41 PM · Restricted Project, Restricted Project
vitalybuka accepted D68621: [sanitizer_common] Remove OnPrint from Go build..
Wed, Oct 9, 2:25 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

Wed, Oct 9, 2:22 PM · Restricted Project, Restricted Project
vitalybuka committed rGff5a7c4ca6ea: [sanitizer, NFC] Fix grammar in comment (authored by vitalybuka).
[sanitizer, NFC] Fix grammar in comment
Wed, Oct 9, 1:52 PM
vitalybuka committed rL374223: [sanitizer, NFC] Fix grammar in comment.
[sanitizer, NFC] Fix grammar in comment
Wed, Oct 9, 1:52 PM
vitalybuka committed rGc001144b10b7: [System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI (authored by vitalybuka).
[System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI
Wed, Oct 9, 1:48 PM
vitalybuka committed rG2d85fd942a76: [System Model] [TTI] Fix virtual destructor warning (authored by vitalybuka).
[System Model] [TTI] Fix virtual destructor warning
Wed, Oct 9, 1:48 PM
vitalybuka committed rG3afc77dbbca9: [sanitizer] Disable signal_trap_handler on s390 (authored by vitalybuka).
[sanitizer] Disable signal_trap_handler on s390
Wed, Oct 9, 1:48 PM
vitalybuka committed rL374222: [System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI.
[System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI
Wed, Oct 9, 1:48 PM
vitalybuka committed rL374221: [System Model] [TTI] Fix virtual destructor warning.
[System Model] [TTI] Fix virtual destructor warning
Wed, Oct 9, 1:47 PM
vitalybuka committed rL374220: [sanitizer] Disable signal_trap_handler on s390.
[sanitizer] Disable signal_trap_handler on s390
Wed, Oct 9, 1:47 PM
vitalybuka committed rG39f759189d51: [sanitizer] Make signal_name a C test (authored by vitalybuka).
[sanitizer] Make signal_name a C test
Wed, Oct 9, 1:22 PM
vitalybuka committed rL374213: [sanitizer] Make signal_name a C test.
[sanitizer] Make signal_name a C test
Wed, Oct 9, 1:20 PM
vitalybuka committed rGc3317658cf26: [sanitizer] Use raise() in test and cover more signals (authored by vitalybuka).
[sanitizer] Use raise() in test and cover more signals
Wed, Oct 9, 1:20 PM
vitalybuka committed rL374211: [sanitizer] Use raise() in test and cover more signals.
[sanitizer] Use raise() in test and cover more signals
Wed, Oct 9, 1:19 PM
vitalybuka added inline comments to D68676: [ASan] Do not misrepresent high value address dereferences as null dereferences.
Wed, Oct 9, 1:33 AM · Restricted Project, Restricted Project

Tue, Oct 8

vitalybuka added inline comments to D68343: [libc++] Move the linker script generation step to CMake.
Tue, Oct 8, 3:28 PM · Restricted Project
vitalybuka added inline comments to D68343: [libc++] Move the linker script generation step to CMake.
Tue, Oct 8, 3:28 PM · Restricted Project
vitalybuka committed rGd5f92e345cb6: [sanitizer] Fix crypt.cpp on Android again (authored by vitalybuka).
[sanitizer] Fix crypt.cpp on Android again
Tue, Oct 8, 3:12 PM
vitalybuka committed rL374125: [sanitizer] Fix crypt.cpp on Android again.
[sanitizer] Fix crypt.cpp on Android again
Tue, Oct 8, 3:12 PM
vitalybuka committed rGf3ae951c09ef: [sanitizer] Fix crypt.cpp test on Darwin (authored by vitalybuka).
[sanitizer] Fix crypt.cpp test on Darwin
Tue, Oct 8, 1:56 PM
vitalybuka committed rL374115: [sanitizer] Fix crypt.cpp test on Darwin.
[sanitizer] Fix crypt.cpp test on Darwin
Tue, Oct 8, 1:56 PM
vitalybuka committed rGc831ce8c0619: [clang] enable_trivial_var_init_zero should not be Joined<> (authored by vitalybuka).
[clang] enable_trivial_var_init_zero should not be Joined<>
Tue, Oct 8, 1:37 PM
vitalybuka closed D68610: [clang] enable_trivial_var_init_zero should not be Joined<>.
Tue, Oct 8, 1:37 PM · Restricted Project
vitalybuka committed rL374113: [clang] enable_trivial_var_init_zero should not be Joined<>.
[clang] enable_trivial_var_init_zero should not be Joined<>
Tue, Oct 8, 1:37 PM
vitalybuka committed rG49b398f0e958: [clang] Add llvm-ifs in test deps (authored by vitalybuka).
[clang] Add llvm-ifs in test deps
Tue, Oct 8, 1:25 PM
vitalybuka committed rL374110: [clang] Add llvm-ifs in test deps.
[clang] Add llvm-ifs in test deps
Tue, Oct 8, 1:25 PM
vitalybuka committed rGd8245e7a36d5: [sanitizer] Disable crypt*.cpp tests on Android (authored by vitalybuka).
[sanitizer] Disable crypt*.cpp tests on Android
Tue, Oct 8, 10:08 AM
vitalybuka committed rL374088: [sanitizer] Disable crypt*.cpp tests on Android.
[sanitizer] Disable crypt*.cpp tests on Android
Tue, Oct 8, 10:07 AM
vitalybuka added a reviewer for D68610: [clang] enable_trivial_var_init_zero should not be Joined<>: jfb.
Tue, Oct 8, 10:06 AM · Restricted Project

Mon, Oct 7

vitalybuka committed rG54d767f508bb: [sanitizer] Fix signal_trap_handler.cpp on android (authored by vitalybuka).
[sanitizer] Fix signal_trap_handler.cpp on android
Mon, Oct 7, 10:26 PM
vitalybuka committed rL374010: [sanitizer] Fix signal_trap_handler.cpp on android.
[sanitizer] Fix signal_trap_handler.cpp on android
Mon, Oct 7, 10:26 PM
vitalybuka committed rG4fde20f4e412: [clang] Accept -ftrivial-auto-var-init in clang-cl (authored by vitalybuka).
[clang] Accept -ftrivial-auto-var-init in clang-cl
Mon, Oct 7, 10:24 PM
vitalybuka committed rL373992: [clang] Accept -ftrivial-auto-var-init in clang-cl.
[clang] Accept -ftrivial-auto-var-init in clang-cl
Mon, Oct 7, 10:24 PM
vitalybuka closed D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl.
Mon, Oct 7, 10:24 PM · Restricted Project, Restricted Project
vitalybuka committed rG2fdec42a167c: [tsan, go] fix Go windows build (authored by vitalybuka).
[tsan, go] fix Go windows build
Mon, Oct 7, 10:23 PM
vitalybuka committed rL373984: [tsan, go] fix Go windows build.
[tsan, go] fix Go windows build
Mon, Oct 7, 10:23 PM
vitalybuka committed rG205910563786: [tsan, go] break commands into multiple lines (authored by vitalybuka).
[tsan, go] break commands into multiple lines
Mon, Oct 7, 10:23 PM
vitalybuka closed D68599: [tsan, go] fix Go windows build.
Mon, Oct 7, 10:23 PM · Restricted Project, Restricted Project
vitalybuka committed rL373983: [tsan, go] break commands into multiple lines.
[tsan, go] break commands into multiple lines
Mon, Oct 7, 10:22 PM
vitalybuka closed D68596: [tsan, go] break commands into multiple lines.
Mon, Oct 7, 10:22 PM · Restricted Project, Restricted Project
vitalybuka committed rG87dd9688493a: [tsan] Don't delay SIGTRAP handler (authored by vitalybuka).
[tsan] Don't delay SIGTRAP handler
Mon, Oct 7, 10:22 PM
vitalybuka committed rG9917c76107f8: [sanitizer] Print SIGTRAP for corresponding signal (authored by vitalybuka).
[sanitizer] Print SIGTRAP for corresponding signal
Mon, Oct 7, 10:22 PM
vitalybuka committed rL373979: [sanitizer] Print SIGTRAP for corresponding signal.
[sanitizer] Print SIGTRAP for corresponding signal
Mon, Oct 7, 10:22 PM
vitalybuka committed rL373978: [tsan] Don't delay SIGTRAP handler.
[tsan] Don't delay SIGTRAP handler
Mon, Oct 7, 10:22 PM
vitalybuka closed D68603: [sanitizer] Print SIGTRAP for corresponding signal.
Mon, Oct 7, 10:22 PM · Restricted Project, Restricted Project
vitalybuka closed D68604: [tsan] Don't delay SIGTRAP handler.
Mon, Oct 7, 10:22 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl.
Mon, Oct 7, 4:55 PM · Restricted Project, Restricted Project
vitalybuka accepted D68431: [msan] Add interceptors: crypt, crypt_r..
Mon, Oct 7, 4:52 PM · Restricted Project, Restricted Project
vitalybuka created D68610: [clang] enable_trivial_var_init_zero should not be Joined<>.
Mon, Oct 7, 4:49 PM · Restricted Project
vitalybuka created D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl.
Mon, Oct 7, 4:40 PM · Restricted Project, Restricted Project
vitalybuka requested changes to D68602: Split two defines into two lines.

already committed

Mon, Oct 7, 4:10 PM · Restricted Project, Restricted Project
vitalybuka retitled D68599: [tsan, go] fix Go windows build from fix Go windows build to [tsan, go] fix Go windows build.
Mon, Oct 7, 4:07 PM · Restricted Project, Restricted Project
vitalybuka accepted D68596: [tsan, go] break commands into multiple lines.
Mon, Oct 7, 4:00 PM · Restricted Project, Restricted Project
vitalybuka retitled D68596: [tsan, go] break commands into multiple lines from break commands into multiple lines to [tsan, go] break commands into multiple lines.
Mon, Oct 7, 3:56 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D68596: [tsan, go] break commands into multiple lines.
Mon, Oct 7, 3:52 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D68602: Split two defines into two lines.
Mon, Oct 7, 3:51 PM · Restricted Project, Restricted Project
vitalybuka added a parent revision for D68599: [tsan, go] fix Go windows build: D68596: [tsan, go] break commands into multiple lines.
Mon, Oct 7, 3:51 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D68599: [tsan, go] fix Go windows build.
Mon, Oct 7, 3:40 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D68599: [tsan, go] fix Go windows build.
Mon, Oct 7, 3:37 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D68603: [sanitizer] Print SIGTRAP for corresponding signal.

remove SIG prefix from the string

Mon, Oct 7, 3:33 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D68602: Split two defines into two lines.
Mon, Oct 7, 3:26 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D68604: [tsan] Don't delay SIGTRAP handler.

fix handle_sigtrap value

Mon, Oct 7, 3:22 PM · Restricted Project, Restricted Project
vitalybuka updated the diff for D68604: [tsan] Don't delay SIGTRAP handler.

remove unneeded final trap

Mon, Oct 7, 3:20 PM · Restricted Project, Restricted Project
vitalybuka created D68604: [tsan] Don't delay SIGTRAP handler.
Mon, Oct 7, 3:18 PM · Restricted Project, Restricted Project
vitalybuka created D68603: [sanitizer] Print SIGTRAP for corresponding signal.
Mon, Oct 7, 3:17 PM · Restricted Project, Restricted Project
vitalybuka accepted D68599: [tsan, go] fix Go windows build.
Mon, Oct 7, 3:11 PM · Restricted Project, Restricted Project
vitalybuka abandoned D47751: [lsan] Do not check for leaks in the forked process.

It was reverted. But I am not planing to work on this soon.

Mon, Oct 7, 11:20 AM · Restricted Project, Restricted Project
vitalybuka reopened D47751: [lsan] Do not check for leaks in the forked process.
Mon, Oct 7, 11:19 AM · Restricted Project, Restricted Project
vitalybuka closed D47751: [lsan] Do not check for leaks in the forked process.
Mon, Oct 7, 4:17 AM · Restricted Project, Restricted Project