maybe test?

In D59876#1541080, @marxin wrote:

Thank you for review. Can you please install the commit?

LGTM

In D62050#1509384, @vitalybuka wrote:

This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory)

I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right approach long-term.

This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory)

Don't hardcode default GN options

In D62020#1505233, @thakis wrote:

Cool!

Having a bot for this is great, under these conditions:

• It doesn't send email to regular contributors when it goes red (it can email you and me and others who'd like to opt in)

already done in D61965, but you need to opt-in. I can do it for you if you don'e have zorg checkout.

remove unused depot_tools

In D61965#1503718, @pcc wrote:

I think this would need to be clearly labeled as an experimental builder so that it's clear that developers aren't on the hook for fixing it. It also means that the bot will need to be configured not to send mail to the blamelist.

disabled emails to the blame list

In D60243#1500007, @brzycki wrote:

LGTM. The number of if defined() and duplicated code regions is minimal. I'm curious to know what @vitalybuka and @kcc think of this iteration of the patch.

In D60243#1495410, @brzycki wrote:

Hello @vitalybuka , thank you for the example in D61401. Do you have a suggestion what file and namespace the DoubleAllocator template class definition should reside? The most recent diff for D60243 was authored April 3 and no longer cleanly applies (the file lsan_allocator.h has changed considerably since then). This is complicated by @sebpop changing jobs and requiring legal approval before he can help work on this again. In order to make progress I'm essentially re-writing this patch based on the new Allocator layout in lsan_allocator.h.

typo

In D60243#1482562, @brzycki wrote:

In D60243#1480602, @vitalybuka wrote:

I've started some refactoring there. So maybe it would be easier after that.

Hello @vitalybuka I plan on looking at your suggestions this week. Please let me know when you think you have the refactored code in a state you perfer and I will start working from that as the new base.

@delcypher, @yln maybe you can check if this works on iOS

In D61358#1485771, @vitalybuka wrote:

Please don't submit without my review even if @rnk accept this.
I've noticed report that original patch breaks compiler-rt/test/tsan/Linux/user_malloc.cc on our internal llvm build.
I don't yet understand why it's there and not on our public bots or my local checkout. May be a problem with the patch or our miss-configuration. I'll debug this morning.

Please don't submit without my review even if @rnk accept this.
I've noticed report that original patch breaks compiler-rt/test/tsan/Linux/user_malloc.cc on our internal llvm build.
I don't yet understand why it's there and not on our public bots or my local checkout. May be a problem with the patch or our miss-configuration. I'll debug this morning.

you should try to extract obvious parts into smaller patches

Test?

@kcc sanitizer_allocator_combined.h is the main part of the patch

@kcc sanitizer_allocator_combined.h is the main part of the patch