- User Since
- Mar 10 2016, 1:50 PM (237 w, 1 d)
undo unrelated changes for real
undo unrelated changes
Thu, Sep 24
LGTM with simplified test
I tested and it's now the slowest lsan test.
Looks like this is enough and make the test faster.
lsan patch is LGTM but I am not sure how this test verity that it's actually reused
it's LGTM as-is
Actually I not appropriate reviewer for this one
Tue, Sep 22
This dependency already exists in asan_allocator.cpp
Mon, Sep 21
Fri, Sep 18
Thanks! Should be fixed now 034781f7f33634918025206427e6ee912ef3985b
I lost connection to my Win box in the office. I will need Windows build
next week anyway. I will try to figure out why stderr is not captured there.
For now I relanded your patch and disabled the test on Windows.
Thu, Sep 17
I have a windows box, I'll take a look.
fuzzer looks like a flake, I started rebuild on the same revision
Wed, Sep 16
can you please clang format this?
convert into lambda to avoid guarding unused function with ARCH_IOVEC_FOR_GETREGSET
restore VReport for PTRACE_GETREGS
LGTM if it works
Can you please clang format it as well