Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (144 w, 5 d)

Recent Activity

Today

vitalybuka accepted D55832: [clang] [Driver] Add .hasAnySanitizer() to SanitizerArgs.
Wed, Dec 19, 12:57 AM
vitalybuka added inline comments to D55596: Reimplement Thread Static Data ASan routines with TLS.
Wed, Dec 19, 12:55 AM · Restricted Project
vitalybuka added inline comments to D55874: [asan] Support running without /proc..
Wed, Dec 19, 12:03 AM

Yesterday

vitalybuka added a comment to D55616: Emit ASM input in a constant context.

Looks like it's broken by this patch

clang: /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm/tools/clang/lib/AST/ExprConstant.cpp:11055: llvm::APSInt clang::Expr::EvaluateKnownConstInt(const clang::ASTContext &, SmallVectorImpl<clang::PartialDiagnosticAt> *) const: Assertion `Result && "Could not evaluate expression"' failed.
Tue, Dec 18, 4:58 PM
vitalybuka committed rL349585: [asan] Disable ODR test on Android.
[asan] Disable ODR test on Android
Tue, Dec 18, 4:10 PM
vitalybuka committed rCRT349585: [asan] Disable ODR test on Android.
[asan] Disable ODR test on Android
Tue, Dec 18, 4:10 PM
vitalybuka created D55857: [asan] Prevent folding of globals with redzones.
Tue, Dec 18, 3:06 PM
vitalybuka committed rCRT349555: [asan] Restore ODR-violation detection on vtables.
[asan] Restore ODR-violation detection on vtables
Tue, Dec 18, 2:26 PM
vitalybuka committed rL349555: [asan] Restore ODR-violation detection on vtables.
[asan] Restore ODR-violation detection on vtables
Tue, Dec 18, 2:26 PM
vitalybuka closed D55799: [asan] Restore ODR-violation detection on vtables.
Tue, Dec 18, 2:26 PM
vitalybuka added a comment to D55799: [asan] Restore ODR-violation detection on vtables.

Done

Tue, Dec 18, 2:18 PM
vitalybuka updated the summary of D55799: [asan] Restore ODR-violation detection on vtables.
Tue, Dec 18, 2:18 PM

Mon, Dec 17

vitalybuka updated the summary of D55799: [asan] Restore ODR-violation detection on vtables.
Mon, Dec 17, 5:41 PM
vitalybuka updated the summary of D55799: [asan] Restore ODR-violation detection on vtables.
Mon, Dec 17, 5:41 PM
vitalybuka updated the diff for D55799: [asan] Restore ODR-violation detection on vtables.

renamed classes

Mon, Dec 17, 5:38 PM
vitalybuka created D55799: [asan] Restore ODR-violation detection on vtables.
Mon, Dec 17, 5:30 PM
vitalybuka accepted D55711: Don't trigger sanitizer initialization from `sysctlbyname` interceptor..
Mon, Dec 17, 1:39 PM

Fri, Dec 14

vitalybuka added a comment to D55711: Don't trigger sanitizer initialization from `sysctlbyname` interceptor..

If we are going to support this use-case we need a test.

Fri, Dec 14, 11:25 AM
vitalybuka added inline comments to D55605: [NewPM] Port Msan: Alternative approach using a module to create the global constructor.
Fri, Dec 14, 12:15 AM
vitalybuka accepted D55692: [sanitizer] Fix nolibc internal_sleep.
Fri, Dec 14, 12:09 AM

Thu, Dec 13

vitalybuka added inline comments to D54879: Introduce `LocalAddressSpaceView::LoadWritable(...)` and make the `Load(...)` method return a const pointer..
Thu, Dec 13, 5:39 PM
vitalybuka added inline comments to D55647: [NewPM] Port Msan: Second alternative approach without any module level initalization.
Thu, Dec 13, 4:44 PM
vitalybuka accepted D55684: Windows ASan: Instrument _msize_base().

LGTM

Thu, Dec 13, 4:21 PM
vitalybuka accepted rL349077: Implement a small subset of the C++ `type_traits` header inside….

LGTM

Thu, Dec 13, 3:51 PM
vitalybuka accepted D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`..

LGTM

Thu, Dec 13, 3:48 PM
vitalybuka accepted D54594: Add new interceptors for vis(3) API in NetBSD.

lgtm

Thu, Dec 13, 2:08 AM · Restricted Project
vitalybuka accepted D55167: Add a new interceptors for cdbr(3) and cdbw(3) API from NetBSD.

LGTM

Thu, Dec 13, 2:07 AM · Restricted Project
vitalybuka committed rCRT349015: [asan] Don't check ODR violations for particular types of globals.
[asan] Don't check ODR violations for particular types of globals
Thu, Dec 13, 1:51 AM
vitalybuka committed rL349015: [asan] Don't check ODR violations for particular types of globals.
[asan] Don't check ODR violations for particular types of globals
Thu, Dec 13, 1:51 AM
vitalybuka committed rC349015: [asan] Don't check ODR violations for particular types of globals.
[asan] Don't check ODR violations for particular types of globals
Thu, Dec 13, 1:51 AM
vitalybuka closed D55621: [asan] Don't check ODR violations for particular types of globals.
Thu, Dec 13, 1:51 AM

Wed, Dec 12

vitalybuka updated the diff for D55621: [asan] Don't check ODR violations for particular types of globals.

typo

Wed, Dec 12, 3:02 PM
vitalybuka added a comment to D55589: [hwasan] Link ubsan_cxx to shared runtime library..

LGTM

Wed, Dec 12, 2:57 PM
vitalybuka accepted D55589: [hwasan] Link ubsan_cxx to shared runtime library..
Wed, Dec 12, 2:57 PM
vitalybuka created D55621: [asan] Don't check ODR violations for particular types of globals.
Wed, Dec 12, 2:29 PM

Mon, Dec 10

vitalybuka added a comment to D54951: Implement a small subset of the C++ `type_traits` header inside sanitizer_common so we can avoid depending on system C++ headers..

@cryptoad
I'd like to still land it if possible. I intend to use this in future patches. I removed it from https://reviews.llvm.org/D54904 to simply have less code to review. My intention is to land this and then add the static_assert(...) that I wanted to write original in a future patch.

Then we can review it with dependent patch?
There is probability that dependent patch will be changed during review or other reasons and we stuck with small but unused piece of code.

Okay. I'll merge this patch back into https://reviews.llvm.org/D54904?id=175500

Mon, Dec 10, 1:58 PM
vitalybuka added inline comments to D54879: Introduce `LocalAddressSpaceView::LoadWritable(...)` and make the `Load(...)` method return a const pointer..
Mon, Dec 10, 1:50 PM
vitalybuka added a comment to D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`..

LGTM
but PrimaryAllocatorASVT is unused here, should we expect patches with PrimaryAllocatorASVT?

@vitalybuka
Yes there will be patches that will use PrimaryAllocatorASVT. However I should note that we actually only need to support the AddressSpaceView template parameter not being LocalAddressSpaceView for ASan and LSan. For the other sanitizer allocators (e.g. TSan) would could have slightly simpler code that just hard codes using LocalAddressSpaceView rather than making it possible at compile time to change this. I didn't do this because I wanted to make the change uniformly to all the sanitizers. If you'd prefer that I make the changes to all the other sanitizers (i.e. not ASan and LSan) in a different way (i.e. hardcode LocalAddressSpaceView) then please let me know and I'll redo this patch.

Mon, Dec 10, 1:39 PM
vitalybuka added a comment to D55167: Add a new interceptors for cdbr(3) and cdbw(3) API from NetBSD.

I don't see why this interceptor needs to know about the internals of struct cdbr or struct cdbw at all. They are fully opaque. All memory accessed by users is explicitly sized as argument to the functions or returned with the size.

Mon, Dec 10, 1:26 PM · Restricted Project
vitalybuka added a comment to D54951: Implement a small subset of the C++ `type_traits` header inside sanitizer_common so we can avoid depending on system C++ headers..

@cryptoad
I'd like to still land it if possible. I intend to use this in future patches. I removed it from https://reviews.llvm.org/D54904 to simply have less code to review. My intention is to land this and then add the static_assert(...) that I wanted to write original in a future patch.

Mon, Dec 10, 10:56 AM
vitalybuka accepted D55504: Fix bug where we'd try symbolize a second time with the same arguments..
Mon, Dec 10, 1:32 AM
vitalybuka added a reviewer for D54879: Introduce `LocalAddressSpaceView::LoadWritable(...)` and make the `Load(...)` method return a const pointer.: vitalybuka.
Mon, Dec 10, 1:20 AM
vitalybuka added inline comments to D54879: Introduce `LocalAddressSpaceView::LoadWritable(...)` and make the `Load(...)` method return a const pointer..
Mon, Dec 10, 1:20 AM
vitalybuka added a comment to D54951: Implement a small subset of the C++ `type_traits` header inside sanitizer_common so we can avoid depending on system C++ headers..

I don't see it in D54904

Mon, Dec 10, 1:00 AM
vitalybuka added a comment to D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`..

LGTM
but PrimaryAllocatorASVT is unused here, should we expect patches with PrimaryAllocatorASVT?

Mon, Dec 10, 1:00 AM
vitalybuka accepted D55469: Add interceptors for md2(3) from NetBSD.
Mon, Dec 10, 12:29 AM · Restricted Project
vitalybuka accepted D54987: Add interceptors for the sha2(3) from NetBSD.
Mon, Dec 10, 12:20 AM · Restricted Project
vitalybuka accepted D55471: Add new interceptors for FILE repositioning stream.
Mon, Dec 10, 12:13 AM · Restricted Project

Fri, Dec 7

vitalybuka committed rL348674: [sanitizer] Add lit.local.cfg for FreeBSD.
[sanitizer] Add lit.local.cfg for FreeBSD
Fri, Dec 7, 5:05 PM
vitalybuka committed rL348673: [sanitizer] Suppress lint warning conflicting with clang-format.
[sanitizer] Suppress lint warning conflicting with clang-format
Fri, Dec 7, 5:05 PM
vitalybuka committed rCRT348673: [sanitizer] Suppress lint warning conflicting with clang-format.
[sanitizer] Suppress lint warning conflicting with clang-format
Fri, Dec 7, 5:05 PM
vitalybuka committed rCRT348674: [sanitizer] Add lit.local.cfg for FreeBSD.
[sanitizer] Add lit.local.cfg for FreeBSD
Fri, Dec 7, 5:05 PM
vitalybuka accepted D54991: Add interceptors for the rmd160(3) from NetBSD.

LGTM

Fri, Dec 7, 4:16 PM · Restricted Project
vitalybuka added inline comments to D54991: Add interceptors for the rmd160(3) from NetBSD.
Fri, Dec 7, 4:02 PM · Restricted Project
vitalybuka accepted D54927: Add interceptors for the sha1(3) from NetBSD.
Fri, Dec 7, 4:00 PM · Restricted Project
vitalybuka requested changes to D55167: Add a new interceptors for cdbr(3) and cdbw(3) API from NetBSD.

Assume WIP

Fri, Dec 7, 3:41 PM · Restricted Project
vitalybuka accepted D54990: Add interceptors for the md4(3) from NetBSD.
Fri, Dec 7, 3:40 PM · Restricted Project
vitalybuka requested changes to D54594: Add new interceptors for vis(3) API in NetBSD.

Assume WIP

Fri, Dec 7, 3:40 PM · Restricted Project
vitalybuka accepted D54993: Add interceptors for md5(3) from NetBSD.
Fri, Dec 7, 3:26 PM · Restricted Project
vitalybuka added inline comments to D55031: Add a new interceptors for statvfs1(2) and fstatvfs1(2) from NetBSD.
Fri, Dec 7, 2:10 PM · Restricted Project
vitalybuka added inline comments to D54527: Add new interceptor for strtonum(3).
Fri, Dec 7, 1:49 PM · Restricted Project
vitalybuka accepted D55019: Add a new interceptor for fparseln(3) from NetBSD.
Fri, Dec 7, 1:44 PM · Restricted Project
vitalybuka accepted D55031: Add a new interceptors for statvfs1(2) and fstatvfs1(2) from NetBSD.
Fri, Dec 7, 1:39 PM · Restricted Project
vitalybuka added inline comments to D54702: Add interceptors for the strtoi(3)/strtou(3) from NetBSD.
Fri, Dec 7, 1:21 PM · Restricted Project
vitalybuka accepted D54702: Add interceptors for the strtoi(3)/strtou(3) from NetBSD.
Fri, Dec 7, 1:20 PM · Restricted Project
vitalybuka accepted D54527: Add new interceptor for strtonum(3).
Fri, Dec 7, 1:15 PM · Restricted Project

Thu, Dec 6

vitalybuka added a reviewer for D54394: [WIP][NewPM] Port msan: vitalybuka.
Thu, Dec 6, 2:28 PM
vitalybuka added inline comments to D54527: Add new interceptor for strtonum(3).
Thu, Dec 6, 12:58 PM · Restricted Project
vitalybuka added inline comments to D54527: Add new interceptor for strtonum(3).
Thu, Dec 6, 12:46 PM · Restricted Project
vitalybuka added inline comments to D54527: Add new interceptor for strtonum(3).
Thu, Dec 6, 12:45 PM · Restricted Project
vitalybuka added inline comments to D54527: Add new interceptor for strtonum(3).
Thu, Dec 6, 12:29 PM · Restricted Project
vitalybuka accepted D55378: [compiler-rt] [test] Add missing cmake include for building libFuzzer alone.
Thu, Dec 6, 11:18 AM

Wed, Dec 5

vitalybuka added inline comments to D55019: Add a new interceptor for fparseln(3) from NetBSD.
Wed, Dec 5, 1:50 AM · Restricted Project
vitalybuka accepted D55015: Add a new interceptor for nl_langinfo(3) from NetBSD.

LGTM

Wed, Dec 5, 1:45 AM · Restricted Project
vitalybuka requested changes to D54993: Add interceptors for md5(3) from NetBSD.
Wed, Dec 5, 1:44 AM · Restricted Project
vitalybuka requested changes to D54991: Add interceptors for the rmd160(3) from NetBSD.
Wed, Dec 5, 1:42 AM · Restricted Project
vitalybuka requested changes to D54990: Add interceptors for the md4(3) from NetBSD.
Wed, Dec 5, 1:35 AM · Restricted Project
vitalybuka requested changes to D54927: Add interceptors for the sha1(3) from NetBSD.
Wed, Dec 5, 1:29 AM · Restricted Project
vitalybuka accepted D55025: Add a new interceptor for modctl(2) from NetBSD.
Wed, Dec 5, 1:06 AM · Restricted Project

Tue, Dec 4

vitalybuka committed rC348327: [asan] Add clang flag -fsanitize-address-use-odr-indicator.
[asan] Add clang flag -fsanitize-address-use-odr-indicator
Tue, Dec 4, 5:47 PM
vitalybuka committed rL348327: [asan] Add clang flag -fsanitize-address-use-odr-indicator.
[asan] Add clang flag -fsanitize-address-use-odr-indicator
Tue, Dec 4, 5:47 PM
vitalybuka committed rCRT348327: [asan] Add clang flag -fsanitize-address-use-odr-indicator.
[asan] Add clang flag -fsanitize-address-use-odr-indicator
Tue, Dec 4, 5:47 PM
vitalybuka closed D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.
Tue, Dec 4, 5:47 PM
vitalybuka updated the diff for D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.

docs

Tue, Dec 4, 5:44 PM
vitalybuka added inline comments to D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.
Tue, Dec 4, 4:28 PM
vitalybuka updated the diff for D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.

more doc strings

Tue, Dec 4, 4:25 PM
vitalybuka updated the diff for D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.

changed doc string

Tue, Dec 4, 4:21 PM
vitalybuka committed rCRT348316: [asan] Split -asan-use-private-alias to -asan-use-odr-indicator.
[asan] Split -asan-use-private-alias to -asan-use-odr-indicator
Tue, Dec 4, 3:21 PM
vitalybuka committed rL348316: [asan] Split -asan-use-private-alias to -asan-use-odr-indicator.
[asan] Split -asan-use-private-alias to -asan-use-odr-indicator
Tue, Dec 4, 3:21 PM
vitalybuka closed D55156: [asan] Split -asan-use-private-alias to -asan-use-odr-indicator.
Tue, Dec 4, 3:21 PM
vitalybuka committed rL348315: [asan] Remove use_odr_indicator runtime flag.
[asan] Remove use_odr_indicator runtime flag
Tue, Dec 4, 3:21 PM
vitalybuka committed rCRT348315: [asan] Remove use_odr_indicator runtime flag.
[asan] Remove use_odr_indicator runtime flag
Tue, Dec 4, 3:20 PM
vitalybuka closed D55254: [asan] Remove use_odr_indicator runtime flag.
Tue, Dec 4, 3:20 PM
vitalybuka updated the diff for D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.

"use" everywhere for consistency

Tue, Dec 4, 2:53 PM
vitalybuka updated the diff for D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.

update

Tue, Dec 4, 2:46 PM
vitalybuka updated the diff for D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.

update

Tue, Dec 4, 2:43 PM
vitalybuka updated the diff for D55157: [asan] Add clang flag -fsanitize-address-use-odr-indicator.

Rebase

Tue, Dec 4, 2:40 PM
vitalybuka added inline comments to D54594: Add new interceptors for vis(3) API in NetBSD.
Tue, Dec 4, 12:42 AM · Restricted Project
vitalybuka added inline comments to D55167: Add a new interceptors for cdbr(3) and cdbw(3) API from NetBSD.
Tue, Dec 4, 12:27 AM · Restricted Project
vitalybuka created D55254: [asan] Remove use_odr_indicator runtime flag.
Tue, Dec 4, 12:08 AM