User Details
- User Since
- Mar 10 2016, 1:50 PM (328 w, 3 d)
Fri, Jun 24
Maybe then just keep as is to avoid new preprocessor branches?
The rest is LGTM
Wed, Jun 22
Could you please move refactoring (like extraction emitPrologue) into a separate CL?
Tue, Jun 21
Fri, Jun 17
Wed, Jun 15
Fri, Jun 10
Wed, Jun 8
Thanks for the fix!
maybe #define _GNU_SOURCE as in documentation?
I believe "Depends on" should be in the summary, no in the title
No need to recover my snapshot, I'll just comment here.
Tue, Jun 7
Up to you if you, if you want to wait for Peter. Feel free to remove and land it if you think it's done.
I added blocker only to make sure that review is shown to @phosek on Phabricator main page.
Why do we want this as a separate -fsanitize=
Maybe better to have some modifier flag like -fsanitize-memtag-globals=1 ?
I simplified this a little bit, but I guess this is effectively the same.
rebase
fix rebase
rebase
Mon, Jun 6
yes, however I have no idea if we need !TC.getTriple().isOSFreeBSD() !TC.getTriple().isOSNetBSD() !TC.getTriple().isOSOpenBSD()) etc.
I guess if make mistake it will be noticed and fixed.
Thanks.
LGTM with few nits
Fri, Jun 3
LGTM, with Asm test and bitcode stuff moved as explained.
Can you please rebase this patch onto others two?
Thu, Jun 2
@fhahn
This is reduced reproducer:
Wed, Jun 1
This patch breaks msan bots: https://lab.llvm.org/buildbot/#/builders/5/builds/24307 and https://lab.llvm.org/buildbot/#/builders/74
Tue, May 31
Mon, May 30
This patch is causing false reports with msan. I am trying to creduce the code. It's with TensorFlow, so far it's quite complicated.
May 27 2022
all stuff under llvm/... here needs testing, Bitcode and AsmParser have many tests usable as examples
Do you have estimate of how often this happend? How many different instrumented functions which can be called from uninstrumented code?
May 25 2022
May 24 2022
Yes, even "// UNSUPPORTED: *" with FIXME is fine
Please also link patches related to #1508 into review "Stack" (see "Edit Related Revisions" on the menu)
May 23 2022
We need a test here as well
We need a test for that