Page MenuHomePhabricator

vitalybuka (Vitaly Buka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2016, 1:50 PM (201 w, 4 d)

Recent Activity

Thu, Jan 16

vitalybuka added inline comments to D72887: [lsan] Support LeakSanitizer runtime on Fuchsia.
Thu, Jan 16, 5:37 PM · Restricted Project, Restricted Project
vitalybuka added a reviewer for D72887: [lsan] Support LeakSanitizer runtime on Fuchsia: vitalybuka.
Thu, Jan 16, 5:37 PM · Restricted Project, Restricted Project

Tue, Jan 14

vitalybuka added a comment to D68115: Zero initialize padding in unions.

I would be happy to finish this patch if we agree on something.

So if I understand this the proposal is to have something like -fzero-union-padding which is off by default.
When it's OFF compiler will continue to do whatever it does now.
When it's ON it will set zeroes into padding with or without -ftrivial-auto-var-init.
Is this correct?

In general, I believe so, yes. To be clear, it only sets zeros into union padding, not *all* padding. I do not have an opinion on whether we want it to be -fzero-union-padding as opposed to -finit-union-padding that honors the pattern from -ftrivial-auto-init=pattern and defaults to zero if no pattern is specified.

Tue, Jan 14, 1:56 PM · Restricted Project
vitalybuka added a comment to D68115: Zero initialize padding in unions.

Does this have to be an unilateral change,
likely penalizing non--ftrivial-auto-var-init= cases,
i.e. [why] can't it be only done for when -ftrivial-auto-var-init= is enabled?

We left off near that conclusion (https://reviews.llvm.org/D68115#1686887);

Would be great if @rsmith / @aaron.ballman could comment on that

I don't have super strong opinions on it, but I think a separate feature for zeroing union padding is what gives users the most flexibility.

A separate option to control zeroing for union padding would help in cases where the zeroing does not happen for reasons other than -ftrivial-auto-var-init.

Agreed.

Tue, Jan 14, 12:59 PM · Restricted Project

Wed, Jan 8

vitalybuka added a comment to D70247: [JumpThreading] Thread jumps through two basic blocks.

This patch is causing problems on Window bot: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/56324

Wed, Jan 8, 11:45 AM · Restricted Project

Tue, Jan 7

vitalybuka added a reviewer for D72367: Summary: update macro for OFF_T so that sanitizer works on AARCH64.: eugenis.

Sanitizers should work for aarch64, we have build bot for that
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android

Tue, Jan 7, 4:09 PM · Restricted Project, Restricted Project

Mon, Jan 6

vitalybuka accepted D71780: [msan] Check qsort input..

what is about clang-format?

Mon, Jan 6, 2:07 PM · Restricted Project, Restricted Project

Thu, Dec 26

vitalybuka accepted D71780: [msan] Check qsort input..
Thu, Dec 26, 1:10 PM · Restricted Project, Restricted Project

Dec 20 2019

vitalybuka accepted D71780: [msan] Check qsort input..

nice

Dec 20 2019, 12:34 PM · Restricted Project, Restricted Project
vitalybuka accepted D71740: [msan] Intercept qsort, qsort_r..
Dec 20 2019, 12:23 PM · Restricted Project, Restricted Project
vitalybuka added inline comments to D71740: [msan] Intercept qsort, qsort_r..
Dec 20 2019, 11:11 AM · Restricted Project, Restricted Project
vitalybuka added inline comments to D71740: [msan] Intercept qsort, qsort_r..
Dec 20 2019, 11:11 AM · Restricted Project, Restricted Project

Dec 19 2019

vitalybuka added inline comments to D71740: [msan] Intercept qsort, qsort_r..
Dec 19 2019, 6:08 PM · Restricted Project, Restricted Project

Dec 17 2019

vitalybuka added inline comments to D71368: [ MC ] Match labels to existing fragments even when switching sections..
Dec 17 2019, 2:08 PM · Restricted Project

Dec 10 2019

vitalybuka accepted D71275: [SanitizerCommon] Reduce wasting memory in LowLevelAllocator..
Dec 10 2019, 12:37 PM · Restricted Project, Restricted Project

Dec 6 2019

vitalybuka added a comment to D70738: [libFuzzer] Add custom output function.

You can consider just to link needed code into small binary which will printout serialized inputs from the drive. And call that e.g. in the following way:

my_fuzzer  |& my_printer

Then my_printer will match "Test unit written" and printout content of corresponding file.

Dec 6 2019, 11:27 AM · Restricted Project, Restricted Project

Nov 27 2019

vitalybuka committed rZORGf5aaa196d2d4: [zorg, sanitizer] Use clang from chromium for stage1 (authored by vitalybuka).
[zorg, sanitizer] Use clang from chromium for stage1
Nov 27 2019, 5:56 PM
vitalybuka committed rZORG1645d5631920: [zorg, sanitizer] Remove dead code (authored by vitalybuka).
[zorg, sanitizer] Remove dead code
Nov 27 2019, 5:21 PM
vitalybuka committed rZORG9842ef24c22a: [zorg, sanitizer] Remove checkout by svn revision (authored by vitalybuka).
[zorg, sanitizer] Remove checkout by svn revision
Nov 27 2019, 5:03 PM
vitalybuka committed rZORGb1d4470f36f6: [zorg, sanitizer] Remove svn related code (authored by vitalybuka).
[zorg, sanitizer] Remove svn related code
Nov 27 2019, 4:08 PM
vitalybuka committed rZORG8101761cb3c2: [zorg, sanitizer] Remove USE_GIT option (authored by vitalybuka).
[zorg, sanitizer] Remove USE_GIT option
Nov 27 2019, 3:50 PM

Nov 26 2019

vitalybuka committed rG5e40f2cf0fec: [CodeMoverUtils] clang-format the test (authored by vitalybuka).
[CodeMoverUtils] clang-format the test
Nov 26 2019, 4:25 PM
vitalybuka committed rGad58d1a9d117: [CodeMoverUtils] Don't dereference nullptr in test (authored by vitalybuka).
[CodeMoverUtils] Don't dereference nullptr in test
Nov 26 2019, 4:24 PM
vitalybuka added inline comments to D70049: [CodeMoverUtils] Added an API to check if an instruction can be safely moved before another instruction..
Nov 26 2019, 4:24 PM · Restricted Project
vitalybuka added a comment to D70707: [hwasan] Make memory dump same as the one in asan..

LGTM

Nov 26 2019, 1:30 PM · Restricted Project, Restricted Project
vitalybuka added reviewers for D70707: [hwasan] Make memory dump same as the one in asan.: eugenis, pcc.
Nov 26 2019, 1:27 PM · Restricted Project, Restricted Project

Nov 22 2019

vitalybuka accepted D70611: Reinstate MSan suppression of PR24578..
Nov 22 2019, 11:22 AM · Restricted Project
vitalybuka committed rG97e0fd27eb9b: Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version (authored by vitalybuka).
Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version
Nov 22 2019, 11:20 AM
vitalybuka closed D70581: Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version.
Nov 22 2019, 11:20 AM · Restricted Project, Restricted Project
vitalybuka added a comment to D70611: Reinstate MSan suppression of PR24578..

Isn't this going to break our msan bots?

Nov 22 2019, 11:20 AM · Restricted Project

Nov 21 2019

vitalybuka updated the summary of D70581: Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version.
Nov 21 2019, 6:35 PM · Restricted Project, Restricted Project
vitalybuka created D70581: Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version.
Nov 21 2019, 6:35 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D70581: Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version.
Nov 21 2019, 6:35 PM · Restricted Project, Restricted Project

Nov 19 2019

vitalybuka accepted D70471: scudo: Switch from std::random_shuffle to std::shuffle in a test..
Nov 19 2019, 4:13 PM · Restricted Project, Restricted Project

Oct 31 2019

vitalybuka accepted D69655: Add llvm-libc builders..
Oct 31 2019, 12:00 PM

Oct 29 2019

vitalybuka accepted D69587: [msan] Blacklist __gxx_personality_v0..
Oct 29 2019, 3:15 PM · Restricted Project, Restricted Project
vitalybuka added a reviewer for D68790: [AddressSanitizer] Only instrument globals of default address space: eugenis.

the rest is LGTM

Oct 29 2019, 1:24 PM · Restricted Project, Restricted Project
vitalybuka committed rZORG5046021737a5: [sanitizer] Remove bogus exception on git checkout (authored by vitalybuka).
[sanitizer] Remove bogus exception on git checkout
Oct 29 2019, 6:16 AM
vitalybuka committed rZORGd0781f7d9e1a: [sanitizer] Fix another bug in git check code (authored by vitalybuka).
[sanitizer] Fix another bug in git check code
Oct 29 2019, 6:16 AM
vitalybuka committed rZORGe3895cb0f67b: [sanitizer] Do git fetch always before git checkout (authored by vitalybuka).
[sanitizer] Do git fetch always before git checkout
Oct 29 2019, 6:16 AM

Oct 28 2019

vitalybuka accepted D69541: [msan] Remove more attributes from sanitized functions..
Oct 28 2019, 5:55 PM · Restricted Project

Oct 18 2019

vitalybuka committed rL375291: [sanitizers] Increase default "git clone --depth" to 100.
[sanitizers] Increase default "git clone --depth" to 100
Oct 18 2019, 2:41 PM

Oct 16 2019

vitalybuka requested changes to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vitalybuka I plan to debug this failure as soon as I can. I imagine I'd have to use QEmu to emulate ppc64/s390x since I don't have such a machine on hand. Thanks for committing my other diff though!

Oct 16 2019, 5:24 PM · Restricted Project, Restricted Project
vitalybuka requested changes to D63179: [sanitizer-common] Reduce ANSI color sequences that have no effect..
Oct 16 2019, 2:26 PM · Restricted Project, Restricted Project

Oct 11 2019

vitalybuka committed rGec6bfa81b7b5: Revert 374629 "[sancov] Accommodate sancov and coverage report server for use… (authored by vitalybuka).
Revert 374629 "[sancov] Accommodate sancov and coverage report server for use…
Oct 11 2019, 10:28 PM
vitalybuka reopened D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

Reverted https://reviews.llvm.org/rL374636

Oct 11 2019, 10:28 PM · Restricted Project, Restricted Project
vitalybuka added a reverting change for rL374629: [sancov] Accommodate sancov and coverage report server for use under Windows: rL374636: Revert 374629 "[sancov] Accommodate sancov and coverage report server for use….
Oct 11 2019, 10:21 PM
vitalybuka committed rL374636: Revert 374629 "[sancov] Accommodate sancov and coverage report server for use….
Revert 374629 "[sancov] Accommodate sancov and coverage report server for use…
Oct 11 2019, 10:21 PM
vitalybuka committed rG23aa2aec7818: [sancov] Accommodate sancov and coverage report server for use under Windows (authored by vitalybuka).
[sancov] Accommodate sancov and coverage report server for use under Windows
Oct 11 2019, 7:36 PM
vitalybuka committed rGe8a462a01923: [sancov] Use LLVM Support library JSON writer in favor of individual… (authored by vitalybuka).
[sancov] Use LLVM Support library JSON writer in favor of individual…
Oct 11 2019, 7:36 PM
vitalybuka closed D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Oct 11 2019, 7:36 PM · Restricted Project, Restricted Project
vitalybuka closed D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Oct 11 2019, 7:36 PM · Restricted Project, Restricted Project
vitalybuka committed rL374629: [sancov] Accommodate sancov and coverage report server for use under Windows.
[sancov] Accommodate sancov and coverage report server for use under Windows
Oct 11 2019, 7:27 PM
vitalybuka committed rL374628: [sancov] Use LLVM Support library JSON writer in favor of individual….
[sancov] Use LLVM Support library JSON writer in favor of individual…
Oct 11 2019, 7:27 PM
vitalybuka committed rG4cdd8287b836: [asan] Return true from instrumentModule (authored by vitalybuka).
[asan] Return true from instrumentModule
Oct 11 2019, 6:50 PM
vitalybuka committed rL374623: [asan] Return true from instrumentModule.
[asan] Return true from instrumentModule
Oct 11 2019, 6:50 PM
vitalybuka committed rGb46dd6e92af7: Insert module constructors in a module pass (authored by vitalybuka).
Insert module constructors in a module pass
Oct 11 2019, 1:46 AM
vitalybuka committed rL374527: Insert module constructors in a module pass.
Insert module constructors in a module pass
Oct 11 2019, 1:46 AM

Oct 10 2019

vitalybuka updated the summary of D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Oct 10 2019, 6:26 PM · Restricted Project, Restricted Project
vitalybuka accepted D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Oct 10 2019, 6:18 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.
Oct 10 2019, 6:17 PM · Restricted Project, Restricted Project
vitalybuka accepted D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Oct 10 2019, 6:17 PM · Restricted Project, Restricted Project
vitalybuka updated the summary of D68752: [sancov] Use LLVM Support library JSON writer in favor of individual implementation.
Oct 10 2019, 5:58 PM · Restricted Project, Restricted Project
vitalybuka committed rL374489: new line at the end.
new line at the end
Oct 10 2019, 5:49 PM
vitalybuka committed rL374485: Add vitalybuka.
Add vitalybuka
Oct 10 2019, 5:31 PM
vitalybuka committed rG5c72aa232e74: [tsan,msan] Insert module constructors in a module pass (authored by vitalybuka).
[tsan,msan] Insert module constructors in a module pass
Oct 10 2019, 4:54 PM
vitalybuka committed rGc2b7737b3423: [msan, NFC] Move option parsing into constructor (authored by vitalybuka).
[msan, NFC] Move option parsing into constructor
Oct 10 2019, 4:54 PM
vitalybuka closed D68832: [tsan,msan] Insert module constructors in a module pass.
Oct 10 2019, 4:54 PM · Restricted Project, Restricted Project
vitalybuka committed rL374481: [tsan,msan] Insert module constructors in a module pass.
[tsan,msan] Insert module constructors in a module pass
Oct 10 2019, 4:54 PM
vitalybuka committed rL374480: [msan, NFC] Move option parsing into constructor.
[msan, NFC] Move option parsing into constructor
Oct 10 2019, 4:54 PM
vitalybuka updated the diff for D68832: [tsan,msan] Insert module constructors in a module pass.

nfc

Oct 10 2019, 4:44 PM · Restricted Project, Restricted Project
vitalybuka created D68832: [tsan,msan] Insert module constructors in a module pass.
Oct 10 2019, 1:46 PM · Restricted Project, Restricted Project

Oct 9 2019

vitalybuka accepted D68676: [ASan] Do not misrepresent high value address dereferences as null dereferences.
Oct 9 2019, 3:54 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

I like the change.

Could you move JSONWriter -> JSON refactoring into separate patch and rebase win stuff ontop?
If you don't have commiter access, someone will need to commit it for you
So I don't mind to split the patch and commit myself.

Sure thing! Would I be creating a separate diff for review or would this be taken from the history? Also, I do not have commiter access so I will need someone to commit it for me.

Oct 9 2019, 3:34 PM · Restricted Project, Restricted Project
vitalybuka resigned from D68292: [CMake] Disable building all Darwin libraries (except builtins) for macOS i386 when the SDK is >= 10.15..
Oct 9 2019, 2:41 PM · Restricted Project, Restricted Project
vitalybuka accepted D68621: [sanitizer_common] Remove OnPrint from Go build..
Oct 9 2019, 2:25 PM · Restricted Project, Restricted Project
vitalybuka added a comment to D51018: [sancov] Accommodate sancov and coverage report server for use under Windows.

@vsk thanks for the review! It looks like the JSON support library implements what JSONWriter does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.

EDIT:
I've also updated the title and description to better describe the changes in this diff.

Oct 9 2019, 2:22 PM · Restricted Project, Restricted Project
vitalybuka committed rGff5a7c4ca6ea: [sanitizer, NFC] Fix grammar in comment (authored by vitalybuka).
[sanitizer, NFC] Fix grammar in comment
Oct 9 2019, 1:52 PM
vitalybuka committed rL374223: [sanitizer, NFC] Fix grammar in comment.
[sanitizer, NFC] Fix grammar in comment
Oct 9 2019, 1:52 PM
vitalybuka committed rGc001144b10b7: [System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI (authored by vitalybuka).
[System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI
Oct 9 2019, 1:48 PM
vitalybuka committed rG2d85fd942a76: [System Model] [TTI] Fix virtual destructor warning (authored by vitalybuka).
[System Model] [TTI] Fix virtual destructor warning
Oct 9 2019, 1:48 PM
vitalybuka committed rG3afc77dbbca9: [sanitizer] Disable signal_trap_handler on s390 (authored by vitalybuka).
[sanitizer] Disable signal_trap_handler on s390
Oct 9 2019, 1:48 PM
vitalybuka committed rL374222: [System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI.
[System Model] [TTI] Define AMDGPUTTIImpl::getST and AMDGPUTTIImpl::getTLI
Oct 9 2019, 1:48 PM
vitalybuka committed rL374221: [System Model] [TTI] Fix virtual destructor warning.
[System Model] [TTI] Fix virtual destructor warning
Oct 9 2019, 1:47 PM
vitalybuka committed rL374220: [sanitizer] Disable signal_trap_handler on s390.
[sanitizer] Disable signal_trap_handler on s390
Oct 9 2019, 1:47 PM
vitalybuka committed rG39f759189d51: [sanitizer] Make signal_name a C test (authored by vitalybuka).
[sanitizer] Make signal_name a C test
Oct 9 2019, 1:22 PM
vitalybuka committed rL374213: [sanitizer] Make signal_name a C test.
[sanitizer] Make signal_name a C test
Oct 9 2019, 1:20 PM
vitalybuka committed rGc3317658cf26: [sanitizer] Use raise() in test and cover more signals (authored by vitalybuka).
[sanitizer] Use raise() in test and cover more signals
Oct 9 2019, 1:20 PM
vitalybuka committed rL374211: [sanitizer] Use raise() in test and cover more signals.
[sanitizer] Use raise() in test and cover more signals
Oct 9 2019, 1:19 PM
vitalybuka added inline comments to D68676: [ASan] Do not misrepresent high value address dereferences as null dereferences.
Oct 9 2019, 1:33 AM · Restricted Project, Restricted Project

Oct 8 2019

vitalybuka added inline comments to D68343: [libc++] Move the linker script generation step to CMake.
Oct 8 2019, 3:28 PM · Restricted Project
vitalybuka added inline comments to D68343: [libc++] Move the linker script generation step to CMake.
Oct 8 2019, 3:28 PM · Restricted Project
vitalybuka committed rGd5f92e345cb6: [sanitizer] Fix crypt.cpp on Android again (authored by vitalybuka).
[sanitizer] Fix crypt.cpp on Android again
Oct 8 2019, 3:12 PM
vitalybuka committed rL374125: [sanitizer] Fix crypt.cpp on Android again.
[sanitizer] Fix crypt.cpp on Android again
Oct 8 2019, 3:12 PM
vitalybuka committed rGf3ae951c09ef: [sanitizer] Fix crypt.cpp test on Darwin (authored by vitalybuka).
[sanitizer] Fix crypt.cpp test on Darwin
Oct 8 2019, 1:56 PM
vitalybuka committed rL374115: [sanitizer] Fix crypt.cpp test on Darwin.
[sanitizer] Fix crypt.cpp test on Darwin
Oct 8 2019, 1:56 PM
vitalybuka committed rGc831ce8c0619: [clang] enable_trivial_var_init_zero should not be Joined<> (authored by vitalybuka).
[clang] enable_trivial_var_init_zero should not be Joined<>
Oct 8 2019, 1:37 PM
vitalybuka closed D68610: [clang] enable_trivial_var_init_zero should not be Joined<>.
Oct 8 2019, 1:37 PM · Restricted Project
vitalybuka committed rL374113: [clang] enable_trivial_var_init_zero should not be Joined<>.
[clang] enable_trivial_var_init_zero should not be Joined<>
Oct 8 2019, 1:37 PM
vitalybuka committed rG49b398f0e958: [clang] Add llvm-ifs in test deps (authored by vitalybuka).
[clang] Add llvm-ifs in test deps
Oct 8 2019, 1:25 PM