Page MenuHomePhabricator
People yronglin

yronglin (Yurong)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2022, 6:09 AM (22 w, 3 d)

Recent Activity
View All

Wed, Feb 1

yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

ping~

Wed, Feb 1, 7:02 AM · Unknown Object (Project), Restricted Project

Thu, Jan 26

yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

rebase

Thu, Jan 26, 3:50 AM · Unknown Object (Project), Restricted Project

Tue, Jan 24

yronglin committed rG002b190d3798: [NFC][libc++] Remove __unexpected namespace (authored by yronglin).
[NFC][libc++] Remove __unexpected namespace
Tue, Jan 24, 5:13 PM · Unknown Object (Project), Restricted Project
yronglin closed D141947: [NFC][libc++] Remove __unexpected namespace.
Tue, Jan 24, 5:13 PM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141947: [NFC][libc++] Remove __unexpected namespace.

Thanks for your review @ldionne !

Tue, Jan 24, 4:52 PM · Unknown Object (Project), Restricted Project

Wed, Jan 18

yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Wed, Jan 18, 9:56 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D141947: [NFC][libc++] Remove __unexpected namespace.

Format

Wed, Jan 18, 12:42 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D141947: [NFC][libc++] Remove __unexpected namespace.

Format

Wed, Jan 18, 12:40 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141947: [NFC][libc++] Remove __unexpected namespace.

Thanks for your review @philnik @huixie90 !

Wed, Jan 18, 12:12 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D141947: [NFC][libc++] Remove __unexpected namespace.

Update

Wed, Jan 18, 12:09 AM · Unknown Object (Project), Restricted Project

Tue, Jan 17

yronglin published D141947: [NFC][libc++] Remove __unexpected namespace for review.
Tue, Jan 17, 11:57 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Rebase

Tue, Jan 17, 8:20 AM · Unknown Object (Project), Restricted Project

Mon, Jan 16

yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Mon, Jan 16, 7:35 PM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Remove __expected namespace

Mon, Jan 16, 7:34 PM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

CI

Mon, Jan 16, 8:19 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

CI

Mon, Jan 16, 7:27 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Mon, Jan 16, 7:17 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Update

Mon, Jan 16, 6:35 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Mon, Jan 16, 5:54 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Many thanks for your comments @philnik !

Mon, Jan 16, 5:53 AM · Unknown Object (Project), Restricted Project

Sun, Jan 15

yronglin added a comment to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..
In D141699#4054747, @yronglin wrote:

Seems related to https://github.com/llvm/llvm-project/issues/49620

Sun, Jan 15, 10:05 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..

Tests still in progress, I'll add other test later!

Sun, Jan 15, 10:04 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..
Sun, Jan 15, 10:03 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..

Update #if _LIBCPP_STD_VER > 17 to #if _LIBCPP_STD_VER >= 23

Sun, Jan 15, 9:56 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..

Update implementation.
Tests still in proress now.

Sun, Jan 15, 9:51 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..

Seems related to https://github.com/llvm/llvm-project/issues/49620

Sun, Jan 15, 8:17 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

ping~

Sun, Jan 15, 7:56 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..

Hi, @Mordante , can you please help me confirm that it this a bug in clang? https://godbolt.org/z/Pcefr19Yh

Sun, Jan 15, 7:55 AM · Unknown Object (Project), Restricted Project

Sat, Jan 14

yronglin added a comment to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..
In D141699#4053611, @Mordante wrote:
In D141699#4051898, @yronglin wrote:
In D141699#4051825, @Mordante wrote:

Thanks for your contribution! Can you add tests too and update libcxx/docs/Status/RangesViews.csv too?

Thank you for your reminder, I will remove [In Progress] in title once it's ready to review.

Thanks!
FYI when you use arc and create a new diff using arc diff --draft it will be "hidden" until you publish it. The CI will still be executed.

Sat, Jan 14, 5:09 AM · Unknown Object (Project), Restricted Project

Fri, Jan 13

yronglin added a comment to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..
In D141699#4051825, @Mordante wrote:

Thanks for your contribution! Can you add tests too and update libcxx/docs/Status/RangesViews.csv too?

Fri, Jan 13, 9:01 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..
In D141699#4051825, @Mordante wrote:

Thanks for your contribution! Can you add tests too and update libcxx/docs/Status/RangesViews.csv too?

Fri, Jan 13, 8:58 AM · Unknown Object (Project), Restricted Project
yronglin retitled D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`). from [In Progress][libc++][ranges] Implement `views::repeat`. to [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..
Fri, Jan 13, 8:29 AM · Unknown Object (Project), Restricted Project
yronglin requested review of D141699: [In Progress][libc++][ranges] Implement P2474R2(`views::repeat`)..
Fri, Jan 13, 8:28 AM · Unknown Object (Project), Restricted Project

Thu, Jan 12

yronglin added a reviewer for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected): var-const.
Thu, Jan 12, 8:02 PM · Unknown Object (Project), Restricted Project

Tue, Jan 10

yronglin added a reviewer for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected): Mordante.
Tue, Jan 10, 6:21 PM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Update libcxx/docs/Status/Cxx2bPapers.csv

Tue, Jan 10, 6:21 PM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Rebase

Tue, Jan 10, 4:35 PM · Unknown Object (Project), Restricted Project
yronglin committed rG4cb5c640db4b: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY… (authored by yronglin).
[libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY…
Tue, Jan 10, 4:32 PM · Unknown Object (Project), Restricted Project
yronglin closed D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function.
Tue, Jan 10, 4:32 PM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Tue, Jan 10, 9:12 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function.
In D141388#4040127, @ldionne wrote:

LGTM once CI is green.

Tue, Jan 10, 9:04 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Keep clang-format in test

Tue, Jan 10, 9:04 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Tue, Jan 10, 9:01 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Update ReleaseNotes
Remove clang-format comments in test

Tue, Jan 10, 8:56 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
In D140911#4040099, @Mordante wrote:

Thanks for working on this! I didn't do a real review, mainly glanced over it and I have a few remarks.

Tue, Jan 10, 8:47 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function.

Seems another failure in clang_query.sh.cpp, but not the same problem as current. https://reviews.llvm.org/harbormaster/unit/view/5710580/

Tue, Jan 10, 8:43 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function.
Tue, Jan 10, 8:40 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function.

Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function

Tue, Jan 10, 8:37 AM · Unknown Object (Project), Restricted Project
yronglin added a reviewer for D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function: philnik.
Tue, Jan 10, 7:45 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function.

This patch try to fix CI failure https://buildkite.com/llvm-project/libcxx-ci/builds/17029#_

Tue, Jan 10, 7:39 AM · Unknown Object (Project), Restricted Project
yronglin requested review of D141388: [libc++] Use _LIBCPP_HIDE_FROM_ABI_VIRTUAL instead of _LIBCPP_INLINE_VISIBILITY attribute on virtual function.
Tue, Jan 10, 7:39 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

try fix test

Tue, Jan 10, 5:07 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

try fix test

Tue, Jan 10, 4:03 AM · Unknown Object (Project), Restricted Project

Mon, Jan 9

yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Rebase

Mon, Jan 9, 9:30 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
In D140911#4036871, @philnik wrote:
In D140911#4036801, @yronglin wrote:

Can someone tell me how to fix this clang_query.sh.cpp failure? Should I need to update any other files, I'm very confused, many thanks!

This failure wasn't your fault. I've committed a fix, so it should be fixed with a rebase.

Mon, Jan 9, 9:28 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Can someone tell me how to fix this clang_query.sh.cpp failure? Should I need to update any other files, I'm very confused, many thanks!

Mon, Jan 9, 9:11 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Thanks for your comments @huixie90 !

Mon, Jan 9, 7:43 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Add test for error_or default arguments
Add test to check and_then exists or not
Update [expected.object.general] changes
Add missing _LIBCPP_HIDE_FROM_ABI
Rename _Up to _Gp in error_or and transform_error

Mon, Jan 9, 7:32 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Mon, Jan 9, 7:24 AM · Unknown Object (Project), Restricted Project

Sun, Jan 8

yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix test

Sun, Jan 8, 9:42 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

The failure of CI is confusing me, I think I should have not changed these places

Sun, Jan 8, 9:26 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix test

Sun, Jan 8, 8:57 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix test

Sun, Jan 8, 8:08 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Sun, Jan 8, 7:53 AM · Unknown Object (Project), Restricted Project
yronglin retitled D140911: [libc++] Implement P2505R5(Monadic operations for std::expected) from [In Progress][libc++] Implement P2505R5(Monadic operations for std::expected) to [libc++] Implement P2505R5(Monadic operations for std::expected).
Sun, Jan 8, 7:46 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Add comments for disable gcc test

Sun, Jan 8, 7:42 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Sun, Jan 8, 7:35 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Add mandates verify
Apply review comments

Sun, Jan 8, 7:30 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Sun, Jan 8, 7:26 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Sun, Jan 8, 4:53 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Sun, Jan 8, 4:19 AM · Unknown Object (Project), Restricted Project

Sat, Jan 7

yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Reported a bug for gcc https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108333

Sat, Jan 7, 9:51 PM · Unknown Object (Project), Restricted Project

Jan 7 2023

yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Thank you for your comment @philnik . For GCC's bug, I have applied for an gcc bugzilla account and am waiting for their reply.

Jan 7 2023, 3:28 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix test

Jan 7 2023, 1:05 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Disable gcc test

Jan 7 2023, 12:28 AM · Unknown Object (Project), Restricted Project

Jan 6 2023

yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
In D140911#4032020, @philnik wrote:
In D140911#4031805, @yronglin wrote:

Is this a bug in GCC? https://godbolt.org/z/jGaGT8K8T

Looks like a bug to me. Here is a minimal reproducer: https://godbolt.org/z/K6edrdTG5. Please submit a bug report to GCC and disable the test for GCC.

Jan 6 2023, 8:48 PM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Is this a bug in GCC? https://godbolt.org/z/jGaGT8K8T

Jan 6 2023, 8:50 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix CI

Jan 6 2023, 8:12 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix test

Jan 6 2023, 7:26 AM · Unknown Object (Project), Restricted Project

Jan 5 2023

yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix CI

Jan 5 2023, 10:05 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
In D140911#4029173, @philnik wrote:

Jonathan probably isn't interested in reviewing libc++ code. He's not working on this project actively.

Jan 5 2023, 9:48 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 5 2023, 9:47 AM · Unknown Object (Project), Restricted Project
yronglin retitled D140911: [libc++] Implement P2505R5(Monadic operations for std::expected) from [libc++] Implement P2505R5(Monadic operations for std::expected) to [In Progress][libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 5 2023, 9:31 AM · Unknown Object (Project), Restricted Project
yronglin added a reviewer for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected): jwakely.
Jan 5 2023, 9:17 AM · Unknown Object (Project), Restricted Project
yronglin retitled D140911: [libc++] Implement P2505R5(Monadic operations for std::expected) from [In Progress][libc++] Implement P2505R5(Monadic operations for std::expected) to [libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 5 2023, 9:16 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Undo unnecessary change.

Jan 5 2023, 9:16 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 5 2023, 8:04 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 5 2023, 8:02 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Oh, I'll try to fix CI failed, the code format seems not correct

Jan 5 2023, 7:52 AM · Unknown Object (Project), Restricted Project
yronglin added inline comments to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 5 2023, 7:47 AM · Unknown Object (Project), Restricted Project
yronglin retitled D140911: [libc++] Implement P2505R5(Monadic operations for std::expected) from [libc++] Implement P2505R5(Monadic operations for std::expected) to [In Progress][libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 5 2023, 6:05 AM · Unknown Object (Project), Restricted Project
yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Fix format

Jan 5 2023, 3:13 AM · Unknown Object (Project), Restricted Project

Jan 4 2023

yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Undo change std:: to _VSTD::
Fix format

Jan 4 2023, 9:16 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Thanks for your reply!

Jan 4 2023, 8:37 AM · Unknown Object (Project), Restricted Project
yronglin added reviewers for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected): philnik, ldionne.
Jan 4 2023, 6:50 AM · Unknown Object (Project), Restricted Project
yronglin added a comment to D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).

Thanks you for review @philnik @huixie90 , It is an great honor to contribute to libcxx, and I'm a newbie in libcxx. I don't know how to use direct-non-list-initialized to initialize named union member in expected and [[no_unique_address]] attribute cannot be used on anonymous union, so, I change to use anonymous in expected. You are all experts in libcxx, if you have any good ideas, please help me, many thanks!

Jan 4 2023, 6:48 AM · Unknown Object (Project), Restricted Project

Jan 3 2023

yronglin updated the diff for D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 3 2023, 10:44 AM · Unknown Object (Project), Restricted Project
yronglin requested review of D140911: [libc++] Implement P2505R5(Monadic operations for std::expected).
Jan 3 2023, 10:40 AM · Unknown Object (Project), Restricted Project

Dec 20 2022

yronglin added a comment to D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg.

commit in ebe530ef7a49988a531a8928eac3ce0925f1c199

Dec 20 2022, 6:07 AM · Restricted Project, Restricted Project
yronglin committed rGebe530ef7a49: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record… (authored by yronglin).
[CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record…
Dec 20 2022, 6:06 AM · Restricted Project, Restricted Project