User Details
- User Since
- Sep 2 2022, 6:09 AM (56 w, 5 d)
Mon, Sep 11
ping~
Wed, Sep 6
Rebase
Thanks for the review! @ldionne
Sep 4 2023
ping~
Sep 1 2023
Thank you for your review @aaron.ballman @rsmith , I will be happy to continue cook this patch once we reach a consensus.
Address Aaron's comments.
Aug 30 2023
Addres the comments that we talked in D154784.
Aug 29 2023
Thanks for your review @ldionne
Address comments
friendly ping~
Aug 26 2023
I have reverted this patch and reopen.
Many thanks for your review! @Mordante
Address comments.
Aug 25 2023
Addres comments.
Aug 24 2023
I'm so sorry that I have no idea how to test stream size overflow in this change now.
Address comments
Aug 22 2023
Aug 21 2023
Address comments
@cor3ntin Thanks for your review!
Aug 20 2023
Do not spass MaterializePRValueInDiscardStatement in PushExpressionEvaluationContext.
Fix ci
Fix ci failure, and introduce an variable in ExpressionEvaluationContextRecord to rewrite default argument.
Aug 19 2023
Thanks a lot for your review! @Mordante
Addres comment.
Aug 18 2023
Aug 16 2023
ping~
friendly ping~
Aug 14 2023
@cor3ntin I have reused EnsureImmediateInvocationInDefaultArgs to rewrite CXXDefaultArgExpr, does this is a correct approach?
Add test to check generated LLVM IR, and fix crash.
Aug 13 2023
Should we dump the real default argument AST but not only CXXDefaultArgExpr if CXXDefaultArgExpr has been rewritted?
FIXME: Need add test in clang/test/CXX/special/class.temporary/p6.cpp to check generated LLVM IR.
Handle default argument and dependent context.
Aug 11 2023
Only create addational metarialized temporary in for-range-init.
FIXME: Need to handle function default argument, and add more test to make sure the generated LLVM IR is correct.
Aug 10 2023
Aug 8 2023
Aug 7 2023
Address comments.
Aug 6 2023
Sorry for the late reply. I tried to investigate the memory impact of creating these additional materializations by build the whole llvm-project and compare the number of MaterializedTemporaryExpr created during parsing.
Aug 5 2023
Address comment, use _If to get closer to the standard wording.
@Mordante ping~
Thanks a lot for your review! @Mordante
Address comments.
Jul 29 2023
Fix CI
Address comments.
Jul 26 2023
This is a very early implement, please give me some time to add and fix tests.
Thanks for your review and sorry for the very late reply!
Thanks for your comments and sorry for the very late reply, I have been investigating how to achieve it these days.
Try implement
Jul 20 2023
Jul 19 2023
Rebase
Seems std::optional does not have this issue https://godbolt.org/z/96T5MT695
Address comments
Jul 18 2023
NFC, fix ci, use _LIBCPP_ENABLE_DEBUG_MODE instead of _LIBCPP_ENABLE_ASSERTIONS
Waiting for CI green
NFC, Use + instead of std::ranges::next in tests.