Page MenuHomePhabricator

Prabhuk (Prabhu Karthikeyan Rajasekaran)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 26 2022, 9:53 AM (9 w, 1 d)

Recent Activity

Aug 17 2022

Prabhuk added a comment to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Looks good to me.

Aug 17 2022, 9:52 AM · Restricted Project, Restricted Project
Prabhuk committed rGa36de097faf7: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when… (authored by Prabhuk).
[llvm-readelf] Render messages similar to that of `GNU binutils readelf` when…
Aug 17 2022, 9:51 AM · Restricted Project, Restricted Project
Prabhuk closed D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Aug 17 2022, 9:51 AM · Restricted Project, Restricted Project

Aug 16 2022

Prabhuk added inline comments to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Aug 16 2022, 9:43 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Including clang-format fixes.

Aug 16 2022, 9:42 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Removing braces for If block with single line code.

Aug 16 2022, 9:40 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Addressed review comments (var name, comment removal, code style, alignment).

Aug 16 2022, 9:38 AM · Restricted Project, Restricted Project

Aug 15 2022

Prabhuk added a comment to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Updated the printProgramHeaders section to address the review comment and to fix logic flaws. Updated corresponding tests. Please take a look.

Aug 15 2022, 6:16 PM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Ran clang-format to fix formatting mismatches.

Aug 15 2022, 6:15 PM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Program header rendering cleanup.

Aug 15 2022, 5:58 PM · Restricted Project, Restricted Project

Aug 10 2022

Prabhuk requested review of D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple.
Aug 10 2022, 9:48 AM · Restricted Project, Restricted Project, Restricted Project

Jul 29 2022

Prabhuk added inline comments to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Jul 29 2022, 10:08 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Added tests that will cover the printSectionDetails() function no section header use cases.
Rendering the warning e_shstrndx == SHN_XINDEX, but the section header table is empty along with the There is no sections in the file. message.

Jul 29 2022, 10:05 AM · Restricted Project, Restricted Project

Jul 27 2022

Prabhuk updated subscribers of D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Jul 27 2022, 4:18 PM · Restricted Project, Restricted Project
Prabhuk requested review of D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Jul 27 2022, 4:14 PM · Restricted Project, Restricted Project