Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Prabhuk (Prabhu Karthikeyan Rajasekaran)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 26 2022, 9:53 AM (60 w, 5 d)

Recent Activity

Fri, Sep 22

Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Updated the test name and added comment.

Fri, Sep 22, 3:26 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Add DataLayoutTest for UEFI target.

Fri, Sep 22, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D159541: [UEFI] X86_64 UEFI Clang Driver.

Addressed review comments about the inline comments.

Fri, Sep 22, 12:39 AM · Restricted Project, Restricted Project
Prabhuk added a comment to D152206: [Basic] Support 64-bit x86 target for UEFI.

@phosek -- Regarding the abandoning commit. I had messed up the commit splitting process earlier. Uploaded the correct set of files for this change now. Please take a look.

Fri, Sep 22, 12:30 AM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Update patch.

Fri, Sep 22, 12:28 AM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Datalayout update.

Fri, Sep 22, 12:21 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 21

Prabhuk updated the diff for D159540: [Basic] X86 backend changes for UEFI.

Handle UEFI64 in X86RegisterInfo for all Win64 equivalent cases except for Swift and OCL.

Thu, Sep 21, 6:42 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk added a reviewer for D159541: [UEFI] X86_64 UEFI Clang Driver: brad.
Thu, Sep 21, 1:59 PM · Restricted Project, Restricted Project
Prabhuk updated the diff for D159540: [Basic] X86 backend changes for UEFI.

Uploading the backend changes correctly.

Thu, Sep 21, 1:57 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk added a comment to D152206: [Basic] Support 64-bit x86 target for UEFI.

Clang Driver Changes - https://reviews.llvm.org/D159541
Current - https://reviews.llvm.org/D152206
X86 Backend changes - https://reviews.llvm.org/D159540

Thu, Sep 21, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Splitting commit into 3 commits.

Thu, Sep 21, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk requested review of D159541: [UEFI] X86_64 UEFI Clang Driver.
Thu, Sep 21, 1:42 PM · Restricted Project, Restricted Project
Prabhuk updated the diff for D159540: [Basic] X86 backend changes for UEFI.

Clang Driver changes for UEFI X86_64

Thu, Sep 21, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk requested review of D159540: [Basic] X86 backend changes for UEFI.
Thu, Sep 21, 1:35 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 20

Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Minor cleanup.

Wed, Sep 20, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Update X86 backend to use Microsoft ABI for UEFI target.

Wed, Sep 20, 5:05 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 14

Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Addressed review comments.
Added "-dll" and "-tsaware:no" linker flags for UEFI.

Thu, Sep 14, 3:03 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Aug 28

Prabhuk abandoned D159012: Runtime build failure fix..

Thank you. Abandoning this.

Mon, Aug 28, 1:00 PM · Restricted Project, Restricted Project
Prabhuk requested review of D159012: Runtime build failure fix..
Mon, Aug 28, 12:27 PM · Restricted Project, Restricted Project
Prabhuk added a comment to D156317: [Fuzzer] SetThreadName implementation for Windows.

Compilation failures on name.data and name.size invocations without paranthesis is breaking the builds.
Can you please fix this ASAP or revert? Thank you.

Mon, Aug 28, 9:20 AM · Restricted Project, Restricted Project

Jul 13 2023

Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Minor formatting changes.

Jul 13 2023, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Added subsystem and entry args. Improved driver test.

Jul 13 2023, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2023

Prabhuk added a comment to D152382: [libc++] Expand the contents of LIBCXX_ENABLE_FILESYSTEM.

Hi! This patch seems to break some of the Fuchsia builders. Please find the URL for the failed build below:

Jun 27 2023, 10:21 AM · Restricted Project, Restricted Project

Jun 22 2023

Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Clean up lit test.

Jun 22 2023, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Improve lit test for uefi.

Jun 22 2023, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Set the Objectformat in the appropriate place to fix the triple string for UEFI.
Simplify the lit test for UEFI toolchain to C.

Jun 22 2023, 2:18 PM · Restricted Project, Restricted Project, Restricted Project

Jun 13 2023

Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Adding a simple lit test.

Jun 13 2023, 8:19 AM · Restricted Project, Restricted Project, Restricted Project

Jun 12 2023

Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Addressed comments from last reviews except for adding lit tests.

Jun 12 2023, 11:25 AM · Restricted Project, Restricted Project, Restricted Project

Jun 6 2023

Prabhuk updated the summary of D131594: [Triple] Add triple for UEFI.
Jun 6 2023, 8:12 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2023

Prabhuk retitled D131594: [Triple] Add triple for UEFI from Add Clang UEFI target to support "x86_64-unknown-uefi" triple to [Triple] Add triple for UEFI.
Jun 5 2023, 3:40 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Updated commit message.

Jun 5 2023, 3:40 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D152206: [Basic] Support 64-bit x86 target for UEFI.

Update commit message.

Jun 5 2023, 3:39 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk requested review of D152206: [Basic] Support 64-bit x86 target for UEFI.
Jun 5 2023, 3:37 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Update the test. Remove unnecessary items in UEFI toolchain.

Jun 5 2023, 3:23 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk retitled D131594: [Triple] Add triple for UEFI from WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple to Add Clang UEFI target to support "x86_64-unknown-uefi" triple.
Jun 5 2023, 2:30 PM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2023

Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Simplifying the patch to include just the scaffolding for X86_64 platform.
Removing the predefines to be added as a separate patch.

Jun 2 2023, 6:46 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2023

Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Addressing Petr's comments. Adding buildLinker initial draft for UEFI.

May 16 2023, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Use make_unique instead of new for UEFI TargetInfo.

May 16 2023, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Not ready for review yet. Updating build files and tests.
Fixed a compile time error.

May 16 2023, 9:13 AM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Added UEFI toolchain. Constructing linker and started a WIP UEFI toolchain to break away from MSVC toolchain.

May 16 2023, 8:37 AM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2022

Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Added tests to the new UEFI target.

Nov 23 2022, 3:37 PM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Introducing a new toolchain for UEFI COFF.

Nov 23 2022, 3:09 PM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Add UEFI macro.

Oct 18 2022, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Introducing UEFIX86_64TargetInfo.

Oct 18 2022, 9:45 AM · Restricted Project, Restricted Project, Restricted Project

Oct 17 2022

Prabhuk updated the diff for D131594: [Triple] Add triple for UEFI.

Added changes to the Driver.cpp.
This version uses underlying MSVC toolchain to compile UEFI target introduced here.

Oct 17 2022, 4:53 PM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2022

Prabhuk added a comment to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Looks good to me.

Aug 17 2022, 9:52 AM · Restricted Project, Restricted Project
Prabhuk committed rGa36de097faf7: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when… (authored by Prabhuk).
[llvm-readelf] Render messages similar to that of `GNU binutils readelf` when…
Aug 17 2022, 9:51 AM · Restricted Project, Restricted Project
Prabhuk closed D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Aug 17 2022, 9:51 AM · Restricted Project, Restricted Project

Aug 16 2022

Prabhuk added inline comments to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Aug 16 2022, 9:43 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Including clang-format fixes.

Aug 16 2022, 9:42 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Removing braces for If block with single line code.

Aug 16 2022, 9:40 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Addressed review comments (var name, comment removal, code style, alignment).

Aug 16 2022, 9:38 AM · Restricted Project, Restricted Project

Aug 15 2022

Prabhuk added a comment to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Updated the printProgramHeaders section to address the review comment and to fix logic flaws. Updated corresponding tests. Please take a look.

Aug 15 2022, 6:16 PM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Ran clang-format to fix formatting mismatches.

Aug 15 2022, 6:15 PM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Program header rendering cleanup.

Aug 15 2022, 5:58 PM · Restricted Project, Restricted Project

Aug 10 2022

Prabhuk requested review of D131594: [Triple] Add triple for UEFI.
Aug 10 2022, 9:48 AM · Restricted Project, Restricted Project, Restricted Project

Jul 29 2022

Prabhuk added inline comments to D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Jul 29 2022, 10:08 AM · Restricted Project, Restricted Project
Prabhuk updated the diff for D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..

Added tests that will cover the printSectionDetails() function no section header use cases.
Rendering the warning e_shstrndx == SHN_XINDEX, but the section header table is empty along with the There is no sections in the file. message.

Jul 29 2022, 10:05 AM · Restricted Project, Restricted Project

Jul 27 2022

Prabhuk updated subscribers of D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Jul 27 2022, 4:18 PM · Restricted Project, Restricted Project
Prabhuk requested review of D130670: [llvm-readelf] Render messages similar to that of `GNU binutils readelf` when no sections and/or no headers..
Jul 27 2022, 4:14 PM · Restricted Project, Restricted Project