Page MenuHomePhabricator

domada (Dominik Adamski)
User

Projects

User does not belong to any projects.

User Details

User Since
May 11 2019, 5:23 PM (185 w, 4 d)

Recent Activity

Yesterday

domada added inline comments to D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class.
Tue, Nov 29, 3:46 AM · Restricted Project, Restricted Project
domada updated the diff for D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class.
  1. Refactored OMPIRBuilder method which calculates SIMD alignment. Added optional parameter Type *AlignedValueTy which can be used to define optimal alignment. If this parameter is not specified then, we return the maximal SIMD alignment for given target.
  2. Clang still uses suboptimal value because there is no link between clang TargetInfo and LLVM-Type. More information about this decision can be found in previous review which introduced original getSimdDefaultAlign function: https://reviews.llvm.org/D10597?id=28205#inline-85925
  3. TargetInfo class contains method: getMaxVectorAlign . This method returns maximal vector alignment for given target. The only difference between original: getMaxVectorAlign and getSimdDefaultAlign is that getSimdDefaultAlign returns 0 alignment for ARM target. I don't know if it is ok, that we assume 0 alignment for ARM targets.
  4. Removed getSimdDefaultAlign function.
Tue, Nov 29, 3:42 AM · Restricted Project, Restricted Project

Tue, Nov 22

domada added a comment to D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class.

Yes, we can extend calculations of the default alignment. My primary goal was to move code from clang into llvm without modification of the code logic.

Tue, Nov 22, 8:54 AM · Restricted Project, Restricted Project
domada requested review of D138496: [OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class.
Tue, Nov 22, 6:26 AM · Restricted Project, Restricted Project

Fri, Nov 18

domada closed D136350: [mlir][OpenMP] Add order clause definition to simd construct.

Patch is committed. Link to the commit: https://github.com/llvm/llvm-project/commit/163dbfe869f550bd2d22520fda109876a1122eda . I forgot to add review link in commit message.

Fri, Nov 18, 4:17 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
domada committed rG163dbfe869f5: [mlir][OpenMP] Add order clause definition to simd construct (authored by domada).
[mlir][OpenMP] Add order clause definition to simd construct
Fri, Nov 18, 4:11 AM · Restricted Project, Unknown Object (Project), Restricted Project
domada updated the diff for D136350: [mlir][OpenMP] Add order clause definition to simd construct.

Patch rebased

Fri, Nov 18, 3:32 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project

Tue, Nov 1

domada committed rG25243d717dc9: [mlir][OpenMP] Add aligned clause definition to simd construct (authored by domada).
[mlir][OpenMP] Add aligned clause definition to simd construct
Tue, Nov 1, 9:10 AM · Restricted Project, Unknown Object (Project), Restricted Project
domada closed D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Tue, Nov 1, 9:10 AM · Unknown Object (Project), Restricted Project, Restricted Project

Oct 31 2022

domada added inline comments to D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 31 2022, 5:34 AM · Unknown Object (Project), Restricted Project, Restricted Project
domada updated the diff for D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.

Applied remarks. Added more tests.

Oct 31 2022, 5:01 AM · Unknown Object (Project), Restricted Project, Restricted Project

Oct 20 2022

domada requested review of D136350: [mlir][OpenMP] Add order clause definition to simd construct.
Oct 20 2022, 6:44 AM · Restricted Project, Unknown Object (Project), Restricted Project, Restricted Project
domada retitled D135865: [mlir][OpenMP] Add aligned clause definition to simd construct from [mlir][OpenMP] Add aligned clause defintion to simd construct to [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 20 2022, 6:38 AM · Unknown Object (Project), Restricted Project, Restricted Project
domada added inline comments to D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 20 2022, 5:24 AM · Unknown Object (Project), Restricted Project, Restricted Project
domada updated the diff for D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.

Addressed review comments:

  1. Modified the way how aligned clause is represented. Use I64ArrayAttr instead of Variadic to represent alignment values
  2. Added verifier which checks if aligned clause was properly mapped
  3. Added more tests MLIR tests
Oct 20 2022, 5:11 AM · Unknown Object (Project), Restricted Project, Restricted Project

Oct 18 2022

domada committed rGccd314d3209a: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder (authored by domada).
[OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder
Oct 18 2022, 12:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada closed D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 18 2022, 12:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 17 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 17 2022, 3:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
  1. Changed DenseMap to MapVector. MapVector provides that the iteration order is the same as insertion order
Oct 17 2022, 1:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

domada added a reviewer for D135865: [mlir][OpenMP] Add aligned clause definition to simd construct: kiranchandramohan.
Oct 13 2022, 4:26 AM · Unknown Object (Project), Restricted Project, Restricted Project
domada requested review of D135865: [mlir][OpenMP] Add aligned clause definition to simd construct.
Oct 13 2022, 3:38 AM · Unknown Object (Project), Restricted Project, Restricted Project
domada added inline comments to D135695: [OMPIRBuilder] Support depend clause for task construct.
Oct 13 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 11 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 11 2022, 5:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
  1. Update description of AlignedVars argument
Oct 11 2022, 5:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 11 2022, 4:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
  1. Modified generation of align assumptions. OMPIRBuilder generates now only assumptions calls. The arguments of the assumption calls are generated by Clang.
  2. Added integration test to prove that Clang and OMPIRBuilder support aligned clause
  3. Simplification of unit tests -> applying review remarks
Oct 11 2022, 4:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 5 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 5 2022, 4:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Patch rebased.

Oct 5 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 4 2022

domada committed rG6842d3501266: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for… (authored by domada).
[OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for…
Oct 4 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada closed D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.
Oct 4 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.

Remove custom enum for mapping order(concurrent)

Oct 4 2022, 4:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Add assert to ensure that alignment value is always specified.

Oct 4 2022, 2:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 3 2022

domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Oct 3 2022, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.

Patch rebased

Oct 3 2022, 3:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Patch rebased.

Oct 3 2022, 2:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 19 2022

domada added a comment to D128596: [flang][OpenMP] Support privatization for single construct.

For me the patch is ok, but I think it would be better, if somebody else will also review it.

Sep 19 2022, 6:08 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada added inline comments to D128596: [flang][OpenMP] Support privatization for single construct.
Sep 19 2022, 1:37 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 16 2022

domada requested review of D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive.
Sep 16 2022, 7:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

domada added a comment to D128596: [flang][OpenMP] Support privatization for single construct.

@peixin What is status of this patch? Are you planning to modify this patch or is it ready for the review?

Sep 13 2022, 4:02 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada added inline comments to D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Sep 13 2022, 3:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada updated the diff for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.

Applied review remarks. Scope of changes:

Sep 13 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 9 2022

domada added reviewers for D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder: peixin, arnamoy10.
Sep 9 2022, 7:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada requested review of D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder.
Sep 9 2022, 7:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 19 2022

domada committed rGb736179e3449: [NFC][OpenMP] Add test for simd directive with nested loop (authored by domada).
[NFC][OpenMP] Add test for simd directive with nested loop
Aug 19 2022, 3:46 AM · Restricted Project, Restricted Project
domada closed D132215: [NFC][OpenMP] Add test for simd directive with nested loop.
Aug 19 2022, 3:46 AM · Restricted Project, Restricted Project
domada added a reviewer for D132215: [NFC][OpenMP] Add test for simd directive with nested loop: kiranchandramohan.
Aug 19 2022, 3:15 AM · Restricted Project, Restricted Project
domada requested review of D132215: [NFC][OpenMP] Add test for simd directive with nested loop.
Aug 19 2022, 3:14 AM · Restricted Project, Restricted Project

Aug 17 2022

domada committed rGcc8c746f8df5: [NFC][Flang] Add simd collapse test case (authored by domada).
[NFC][Flang] Add simd collapse test case
Aug 17 2022, 5:48 AM · Unknown Object (Project), Restricted Project
domada closed D132023: [NFC][Flang] Add simd collapse test case.
Aug 17 2022, 5:48 AM · Restricted Project, Unknown Object (Project)
domada added a comment to D131674: [NFC][OpenMP] Update simd loop collapse support description.

Follow up review: https://reviews.llvm.org/D132023 . This review contains Fortran test with simd clause.

Aug 17 2022, 4:26 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada requested review of D132023: [NFC][Flang] Add simd collapse test case.
Aug 17 2022, 4:18 AM · Restricted Project, Unknown Object (Project)
domada committed rG19bd4789b9d6: [NFC][OpenMP] Update simd loop collapse support description (authored by domada).
[NFC][OpenMP] Update simd loop collapse support description
Aug 17 2022, 1:58 AM · Restricted Project, Restricted Project
domada closed D131674: [NFC][OpenMP] Update simd loop collapse support description.
Aug 17 2022, 1:58 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada updated the diff for D131674: [NFC][OpenMP] Update simd loop collapse support description.

Updated test: Do not rely on hardcoded labels. Check if collapsed loop bound is calculated.

Aug 17 2022, 1:18 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 16 2022

domada added a comment to D131674: [NFC][OpenMP] Update simd loop collapse support description.

@peixin
Thank you for your review. I will apply your remarks in the separate patch which will be Flang specific.

Aug 16 2022, 4:18 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada added a comment to D131674: [NFC][OpenMP] Update simd loop collapse support description.

As far as possible we should try to have Flang and MLIR OpenMP dialect changes in separate patches.

I would recommend splitting this into two simple patches.

  1. Testing the lowering of OpenMP dialect simdloop collapse to LLVM IR. There is an existing test case, simdloop_multi in the translation tests. You need to strengthen it minimally to check the occurrence of collapse. And adding the collapse information to the OpenMP dialect op description.

The relevant code for this came in the patch https://reviews.llvm.org/D118065.

Done. I modified this review so that it contains only OpenMP specific changes.

Aug 16 2022, 4:16 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada updated the diff for D131674: [NFC][OpenMP] Update simd loop collapse support description.

Add only OpenMP specific changes. Update simd loop MLIR description and strengthen translation test.

Aug 16 2022, 4:13 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 11 2022

domada requested review of D131674: [NFC][OpenMP] Update simd loop collapse support description.
Aug 11 2022, 5:47 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 10 2022

domada committed rG98ed6e106972: [Flang][OpenMP] Fix conversion of nested loops for SIMD directive (authored by domada).
[Flang][OpenMP] Fix conversion of nested loops for SIMD directive
Aug 10 2022, 2:02 AM · Restricted Project, Unknown Object (Project), Restricted Project
domada closed D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.
Aug 10 2022, 2:01 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 10 2022, 1:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

domada added reviewers for D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop: Meinersbur, kiranchandramohan.
Aug 9 2022, 2:42 PM · Restricted Project, Restricted Project, Unknown Object (Project)
domada added inline comments to D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.
Aug 9 2022, 4:20 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada updated the diff for D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.

Scope of changes:

Aug 9 2022, 4:19 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 8 2022

domada requested review of D131402: [Flang][OpenMP] Fix conversion to LLVM IR for Fortran code with OpenMP SIMD directive and nested loop.
Aug 8 2022, 8:19 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 1 2022

domada committed rGd90b7bf2c53d: Add support for lowering simd if clause to LLVM IR (authored by domada).
Add support for lowering simd if clause to LLVM IR
Aug 1 2022, 2:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
domada closed D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Aug 1 2022, 2:50 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project
domada added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Aug 1 2022, 1:23 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 29 2022

domada updated the diff for D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.

Applied remarks:
Do not collapse loops inside function responsible for applying SIMD metadirectives
Added special function for loop versioning

Jul 29 2022, 9:55 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 28 2022

domada added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 28 2022, 5:53 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project
domada updated the diff for D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.

Implemented simd if clause- applying review remarks:

  1. Use simplified cloning mechanism (without cloneLoopWithPreheader).
  2. Removed addLoopMetadata(Loop *L, Metadata) function.
  3. Added more tests.
Jul 28 2022, 5:41 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 26 2022

domada added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 26 2022, 12:22 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 25 2022

domada updated the diff for D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.

Fix build failures

Jul 25 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project
domada updated the diff for D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.

Applied remarks. Moved generation of if clause to OMPIRBuilder.

Jul 25 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 14 2022

domada added a comment to D129344: [libomptarget] compile DeviceRTL bc files with -O3.

@jhuber6 Your accepting comment sounds that there is a risk connected with -O3 optimization. That's why I wanted to know if it is worth to turn on O3 optimization. Thanks for explanation.
@ye-luo Thanks for your response.

Jul 14 2022, 6:34 AM · Restricted Project, Restricted Project

Jul 13 2022

domada added a comment to D129344: [libomptarget] compile DeviceRTL bc files with -O3.

@ye-luo Hi,
Could you describe/share with us some benchmarks results which prove that it is worth to turn on -O3 optimization?

Jul 13 2022, 11:07 AM · Restricted Project, Restricted Project

Jul 11 2022

domada added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 11 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 8 2022

domada requested review of D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 8 2022, 6:00 AM · Restricted Project, Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

Jul 6 2022

domada committed rG2c915e3b2627: [mlir][OpenMP] Add if clause to OpenMP simd construct (authored by domada).
[mlir][OpenMP] Add if clause to OpenMP simd construct
Jul 6 2022, 5:37 AM · Restricted Project, Unknown Object (Project), Restricted Project
domada closed D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Jul 6 2022, 5:37 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada updated the diff for D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.

Added check for unsupported lowering if clause to LLVM IR.
Refactor Flang-MLIR lowering. Extracted function for handling if clause.

Jul 6 2022, 4:30 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 6 2022, 12:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 5 2022

domada added inline comments to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Jul 5 2022, 5:01 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada updated the diff for D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.

Fixed layout of simd description

Jul 5 2022, 4:03 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada added inline comments to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Jul 5 2022, 2:55 AM · Restricted Project, Restricted Project, Unknown Object (Project)
domada updated the diff for D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.

Addressed review remarks

Jul 5 2022, 2:52 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jul 4 2022

domada updated the diff for D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.

Added test case for simd directive with if clause in file: flang/test/Lower/OpenMP/simd.f90

Jul 4 2022, 1:27 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Jul 3 2022

domada added a reviewer for D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct: psoni2628.
Jul 3 2022, 11:12 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Jun 30 2022

domada requested review of D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Jun 30 2022, 1:05 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Jan 23 2020

domada committed rG71544135673e: [NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder (authored by domada).
[NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder
Jan 23 2020, 3:11 PM
domada closed D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Jan 23 2020, 3:11 PM · Restricted Project, Restricted Project

Dec 18 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Dec 18 2019, 3:26 PM · Restricted Project, Restricted Project
domada updated the diff for D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..

This patch implements individual version of SCEVVisitor. Taylored version of SCEVVisitor is required to pass pointer to RecordedAssumptions to visit_type_scev functions.

Dec 18 2019, 3:16 PM · Restricted Project, Restricted Project

Dec 17 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Dec 17 2019, 3:06 PM · Restricted Project, Restricted Project
domada updated the diff for D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..

Uploaded the same changes with the more context: git format-patch -U999999 HEAD~1

Dec 17 2019, 2:31 PM · Restricted Project, Restricted Project

Dec 9 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Dec 9 2019, 2:17 PM · Restricted Project, Restricted Project
domada updated the diff for D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
  1. Reworked mechanism of collecting assumptions. All assumptions are now taken inside ScopBuilder.
  2. Internal functions of Scop class do not record any assumption. They use cached isl::pw_aff objects which are created by ScopBuilder.
Dec 9 2019, 1:58 PM · Restricted Project, Restricted Project

Sep 26 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Sep 26 2019, 12:59 PM · Restricted Project, Restricted Project
domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Sep 26 2019, 12:50 PM · Restricted Project, Restricted Project

Sep 25 2019

domada created D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Sep 25 2019, 3:21 PM · Restricted Project, Restricted Project