Page MenuHomePhabricator

domada (Dominik Adamski)
User

Projects

User does not belong to any projects.

User Details

User Since
May 11 2019, 5:23 PM (37 w, 1 d)

Recent Activity

Thu, Jan 23

domada committed rG71544135673e: [NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder (authored by domada).
[NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder
Thu, Jan 23, 3:11 PM
domada closed D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Thu, Jan 23, 3:11 PM · Restricted Project, Restricted Project

Dec 18 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Dec 18 2019, 3:26 PM · Restricted Project, Restricted Project
domada updated the diff for D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..

This patch implements individual version of SCEVVisitor. Taylored version of SCEVVisitor is required to pass pointer to RecordedAssumptions to visit_type_scev functions.

Dec 18 2019, 3:16 PM · Restricted Project, Restricted Project

Dec 17 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Dec 17 2019, 3:06 PM · Restricted Project, Restricted Project
domada updated the diff for D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..

Uploaded the same changes with the more context: git format-patch -U999999 HEAD~1

Dec 17 2019, 2:31 PM · Restricted Project, Restricted Project

Dec 9 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Dec 9 2019, 2:17 PM · Restricted Project, Restricted Project
domada updated the diff for D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
  1. Reworked mechanism of collecting assumptions. All assumptions are now taken inside ScopBuilder.
  2. Internal functions of Scop class do not record any assumption. They use cached isl::pw_aff objects which are created by ScopBuilder.
Dec 9 2019, 1:58 PM · Restricted Project, Restricted Project

Sep 26 2019

domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Sep 26 2019, 12:59 PM · Restricted Project, Restricted Project
domada added inline comments to D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Sep 26 2019, 12:50 PM · Restricted Project, Restricted Project

Sep 25 2019

domada created D68056: [Polly][NFC][ScopBuilder] Move RecordedAssumptions vector to ScopBuilder..
Sep 25 2019, 3:21 PM · Restricted Project, Restricted Project

Aug 6 2019

domada committed rGa0438305d043: [NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder. (authored by domada).
[NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder.
Aug 6 2019, 2:52 PM
domada committed rL368100: [NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder..
[NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder.
Aug 6 2019, 2:51 PM
domada closed D65729: [Polly][NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder..
Aug 6 2019, 2:51 PM · Restricted Project
domada committed rGb169e58b3146: [NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder (authored by domada).
[NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder
Aug 6 2019, 2:28 PM
domada committed rL368089: [NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.
[NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder
Aug 6 2019, 2:25 PM
domada closed D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.
Aug 6 2019, 2:25 PM · Restricted Project

Aug 5 2019

domada updated the summary of D65729: [Polly][NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder..
Aug 5 2019, 3:38 PM · Restricted Project
domada updated the diff for D65729: [Polly][NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder..

Applied @Meinersbur remarks.

Aug 5 2019, 3:29 PM · Restricted Project

Aug 4 2019

domada added a comment to D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.

https://reviews.llvm.org/D65729 -> this patch moves buildConditionSets functions to ScopBuilder class. It is not possible to move them enterily in patch 65241 because some Scop functions use these functions.

Aug 4 2019, 2:30 PM · Restricted Project
domada added a child revision for D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder: D65729: [Polly][NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder..
Aug 4 2019, 2:20 PM · Restricted Project
domada added a parent revision for D65729: [Polly][NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder.: D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.
Aug 4 2019, 2:20 PM · Restricted Project
domada created D65729: [Polly][NFC][ScopBuilder] Move buildDomains and its callees to ScopBuilder..
Aug 4 2019, 2:20 PM · Restricted Project

Aug 3 2019

domada updated the diff for D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.

Remove duplicated buildConditionSets declaration.

Aug 3 2019, 3:34 PM · Restricted Project

Jul 25 2019

domada added a comment to D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.

[remark] Summary: getRepresentingInvariantLoadSCEV is already in the Scop class. Did you want to say changing its visibility to public?

Indeed. I want to make it public, because I think that it can be hellpful in the future if we want to remove friendship between ScopBuilder and Scop class. I have fixed summary.

Jul 25 2019, 1:50 PM · Restricted Project
domada updated the summary of D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.
Jul 25 2019, 1:50 PM · Restricted Project

Jul 24 2019

domada created D65241: [Polly][NFC][ScopBuilder] Move addUserAssumptions to ScopBuilder.
Jul 24 2019, 1:25 PM · Restricted Project

Jul 17 2019

domada committed rGd0ac007f9a93: [NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or… (authored by domada).
[NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or…
Jul 17 2019, 2:45 PM
domada committed rL366377: [NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or….
[NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or…
Jul 17 2019, 2:42 PM
domada closed D64223: [Polly][NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or ScopHelper.
Jul 17 2019, 2:42 PM · Restricted Project
domada committed rGeece5a9d3184: [NFC][ScopBuilder]Move finalizeAccesses and its callees to ScopBuilder (authored by domada).
[NFC][ScopBuilder]Move finalizeAccesses and its callees to ScopBuilder
Jul 17 2019, 2:26 PM
domada committed rL366374: [NFC][ScopBuilder]Move finalizeAccesses and its callees to ScopBuilder.
[NFC][ScopBuilder]Move finalizeAccesses and its callees to ScopBuilder
Jul 17 2019, 2:26 PM
domada closed D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Jul 17 2019, 2:26 PM · Restricted Project

Jul 16 2019

domada committed rGfdc61bce9470: [NFC][ScopBuilder] Move addUserContext to ScopBuilder (authored by domada).
[NFC][ScopBuilder] Move addUserContext to ScopBuilder
Jul 16 2019, 2:30 PM
domada committed rL366266: [NFC][ScopBuilder] Move addUserContext to ScopBuilder.
[NFC][ScopBuilder] Move addUserContext to ScopBuilder
Jul 16 2019, 2:29 PM
domada closed D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.
Jul 16 2019, 2:28 PM · Restricted Project
domada committed rG588fc9e756d3: [NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to… (authored by domada).
[NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to…
Jul 16 2019, 2:12 PM
domada committed rL366262: [NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to….
[NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to…
Jul 16 2019, 2:12 PM
domada closed D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.
Jul 16 2019, 2:12 PM · Restricted Project
domada committed rGddbb83732afc: [NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder (authored by domada).
[NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder
Jul 16 2019, 1:52 PM
domada committed rL366260: [NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
[NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder
Jul 16 2019, 1:51 PM
domada closed D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
Jul 16 2019, 1:50 PM · Restricted Project

Jul 15 2019

domada committed rG46b84fa231c7: [ScopInfo][NFC] Add dot at the end of comment statement. (authored by domada).
[ScopInfo][NFC] Add dot at the end of comment statement.
Jul 15 2019, 3:05 PM
domada updated the diff for D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.

Applied @Meinersbur remarks.

Jul 15 2019, 3:04 PM · Restricted Project
domada committed rL366134: [ScopInfo][NFC] Add dot at the end of comment statement..
[ScopInfo][NFC] Add dot at the end of comment statement.
Jul 15 2019, 3:01 PM

Jul 10 2019

domada added inline comments to D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
Jul 10 2019, 3:33 PM · Restricted Project

Jul 4 2019

domada added a parent revision for D64223: [Polly][NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or ScopHelper: D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Jul 4 2019, 3:21 PM · Restricted Project
domada added a child revision for D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder: D64223: [Polly][NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or ScopHelper.
Jul 4 2019, 3:21 PM · Restricted Project
domada created D64223: [Polly][NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or ScopHelper.
Jul 4 2019, 3:21 PM · Restricted Project

Jul 2 2019

domada added inline comments to D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Jul 2 2019, 3:26 PM · Restricted Project
domada updated the diff for D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.

Applied review remarks:

  1. Changed iterator name for AccessFunctions vector.
  2. Reverted change for Scop desctructor.
Jul 2 2019, 3:22 PM · Restricted Project

Jul 1 2019

domada updated the diff for D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.

Applied cod review remarks:

  1. Leave lookupBasePtrAccess in Scop class.
  2. Leave hasFeasibleRuntimeContext in Scop class.
  3. Added Optimization Remark Emitter to ScopBuilder class,
  4. Make types AliasGroupTy and AliasGroupVectorTy private.
Jul 1 2019, 2:59 PM · Restricted Project

Jun 26 2019

domada added a comment to D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.

I think we need to wait with this patch until older patches are merged into repository. I was not able to apply this patch directly on master branch.

Jun 26 2019, 2:30 PM · Restricted Project
domada added a comment to D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.

Ok, I will move entirely RecordedAssumptions to ScopBuilder in a future patch.

Jun 26 2019, 2:21 PM · Restricted Project
domada updated the diff for D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
  1. Removed commented code
  2. Renamed iterator range to RecordedAssumptions to recorded_assumptions
Jun 26 2019, 2:18 PM · Restricted Project

Jun 25 2019

domada added a parent revision for D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder: D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.
Jun 25 2019, 3:03 PM · Restricted Project
domada added a child revision for D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder: D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Jun 25 2019, 3:03 PM · Restricted Project
domada created D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Jun 25 2019, 3:03 PM · Restricted Project

Jun 24 2019

domada added a parent revision for D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder: D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.
Jun 24 2019, 2:43 PM · Restricted Project
domada added a child revision for D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder: D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.
Jun 24 2019, 2:43 PM · Restricted Project
domada created D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.
Jun 24 2019, 2:43 PM · Restricted Project

Jun 23 2019

domada added a comment to D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.

Please let me know if such big patch is acceptable. I have moved all functions referenced only by buildAliasChecks function to ScopBuilder class.

Jun 23 2019, 2:50 PM · Restricted Project
domada added a child revision for D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder: D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.
Jun 23 2019, 2:46 PM · Restricted Project
domada added a parent revision for D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder: D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
Jun 23 2019, 2:46 PM · Restricted Project
domada created D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.
Jun 23 2019, 2:46 PM · Restricted Project

Jun 19 2019

domada updated the diff for D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
  1. Remove unused function.
Jun 19 2019, 3:35 PM · Restricted Project
domada created D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
Jun 19 2019, 2:22 PM · Restricted Project

Jun 12 2019

domada added a comment to D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.

Yes, please do a commit.

Jun 12 2019, 1:29 PM · Restricted Project
domada updated the diff for D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.

Applied remarks.

Jun 12 2019, 1:29 PM · Restricted Project
domada added a comment to D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.

Updated new patch with applied remarks.

Jun 12 2019, 1:29 PM · Restricted Project
domada added a comment to D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.

If there are no more remarks, I think the patch is ready for submission.

Jun 12 2019, 1:29 PM · Restricted Project

Jun 11 2019

domada added inline comments to D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada added a parent revision for D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder: D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada added a child revision for D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder: D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada created D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada added a comment to D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

Yes, please do a review.
I have updated patch for moving getNonHoistableCtx to ScopBuilder.

Jun 11 2019, 3:27 PM · Restricted Project
domada updated the diff for D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.

Moved MaxDimensionsInAccessRange constant to ScopBuilder.

Jun 11 2019, 3:24 PM · Restricted Project

Jun 9 2019

domada updated the summary of D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 9 2019, 3:55 PM · Restricted Project
domada updated the summary of D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.
Jun 9 2019, 3:55 PM · Restricted Project
domada added a comment to D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

https://reviews.llvm.org/D63066 -> this child review implements moving of getNonHoistableCtx to ScopBuilder.

Jun 9 2019, 3:55 PM · Restricted Project
domada added a parent revision for D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder: D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.
Jun 9 2019, 3:50 PM · Restricted Project
domada created D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 9 2019, 3:50 PM · Restricted Project
domada added a child revision for D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder: D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 9 2019, 3:50 PM · Restricted Project

Jun 8 2019

domada added a comment to D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

Ok, I can do it.

Jun 8 2019, 2:29 AM · Restricted Project

Jun 5 2019

domada created D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.
Jun 5 2019, 12:25 PM · Restricted Project

Jun 4 2019

domada added a comment to D62781: [Polly][NFC][ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo.

Yes, please do a commit.

Jun 4 2019, 12:48 PM · Restricted Project

Jun 1 2019

domada created D62781: [Polly][NFC][ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo.
Jun 1 2019, 10:47 AM · Restricted Project

May 30 2019

domada added a comment to D62628: [Polly][NFC][ScopBuilder] Move verifyInvariantLoads function from ScopInfo.

Yes, please do a commit.

May 30 2019, 3:06 PM · Restricted Project

May 29 2019

domada created D62628: [Polly][NFC][ScopBuilder] Move verifyInvariantLoads function from ScopInfo.
May 29 2019, 2:00 PM · Restricted Project

May 28 2019

domada added a comment to D62351: [Polly][NFC][ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo.

Yes, please commit for me.

May 28 2019, 1:11 PM · Restricted Project

May 23 2019

domada created D62351: [Polly][NFC][ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo.
May 23 2019, 3:14 PM · Restricted Project

May 22 2019

domada created D62265: [ScopBuilder] Move buildContext function from ScopInfo.
May 22 2019, 11:37 AM · Restricted Project