Page MenuHomePhabricator

domada (Dominik Adamski)
User

Projects

User does not belong to any projects.

User Details

User Since
May 11 2019, 5:23 PM (9 w, 1 d)

Recent Activity

Wed, Jul 10

domada added inline comments to D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
Wed, Jul 10, 3:33 PM · Restricted Project

Thu, Jul 4

domada added a parent revision for D64223: [Polly][NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or ScopHelper: D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Thu, Jul 4, 3:21 PM · Restricted Project
domada added a child revision for D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder: D64223: [Polly][NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or ScopHelper.
Thu, Jul 4, 3:21 PM · Restricted Project
domada created D64223: [Polly][NFC][ScopBuilder] Move buildSchedule and its callees to ScopBuilder or ScopHelper.
Thu, Jul 4, 3:21 PM · Restricted Project

Tue, Jul 2

domada added inline comments to D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Tue, Jul 2, 3:26 PM · Restricted Project
domada updated the diff for D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.

Applied review remarks:

  1. Changed iterator name for AccessFunctions vector.
  2. Reverted change for Scop desctructor.
Tue, Jul 2, 3:22 PM · Restricted Project

Mon, Jul 1

domada updated the diff for D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.

Applied cod review remarks:

  1. Leave lookupBasePtrAccess in Scop class.
  2. Leave hasFeasibleRuntimeContext in Scop class.
  3. Added Optimization Remark Emitter to ScopBuilder class,
  4. Make types AliasGroupTy and AliasGroupVectorTy private.
Mon, Jul 1, 2:59 PM · Restricted Project

Wed, Jun 26

domada added a comment to D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.

I think we need to wait with this patch until older patches are merged into repository. I was not able to apply this patch directly on master branch.

Wed, Jun 26, 2:30 PM · Restricted Project
domada added a comment to D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.

Ok, I will move entirely RecordedAssumptions to ScopBuilder in a future patch.

Wed, Jun 26, 2:21 PM · Restricted Project
domada updated the diff for D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
  1. Removed commented code
  2. Renamed iterator range to RecordedAssumptions to recorded_assumptions
Wed, Jun 26, 2:18 PM · Restricted Project

Tue, Jun 25

domada added a parent revision for D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder: D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.
Tue, Jun 25, 3:03 PM · Restricted Project
domada added a child revision for D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder: D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Tue, Jun 25, 3:03 PM · Restricted Project
domada created D63794: [Polly][NFC][ScopBuilder] Move finalizeAccesses and its callees to ScopBuilder.
Tue, Jun 25, 3:03 PM · Restricted Project

Mon, Jun 24

domada added a parent revision for D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder: D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.
Mon, Jun 24, 2:43 PM · Restricted Project
domada added a child revision for D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder: D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.
Mon, Jun 24, 2:43 PM · Restricted Project
domada created D63740: [Polly][NFC][ScopBuilder] Move addUserContext to ScopBuilder.
Mon, Jun 24, 2:43 PM · Restricted Project

Sun, Jun 23

domada added a comment to D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.

Please let me know if such big patch is acceptable. I have moved all functions referenced only by buildAliasChecks function to ScopBuilder class.

Sun, Jun 23, 2:50 PM · Restricted Project
domada added a child revision for D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder: D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.
Sun, Jun 23, 2:46 PM · Restricted Project
domada added a parent revision for D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder: D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
Sun, Jun 23, 2:46 PM · Restricted Project
domada created D63693: [Polly][NFC][ScopBuilder] Move buildAliasChecks and its implementing methods to ScopBuilder.
Sun, Jun 23, 2:46 PM · Restricted Project

Wed, Jun 19

domada updated the diff for D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
  1. Remove unused function.
Wed, Jun 19, 3:35 PM · Restricted Project
domada created D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder.
Wed, Jun 19, 2:22 PM · Restricted Project

Jun 12 2019

domada added a comment to D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.

Yes, please do a commit.

Jun 12 2019, 1:29 PM · Restricted Project
domada updated the diff for D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.

Applied remarks.

Jun 12 2019, 1:29 PM · Restricted Project
domada added a comment to D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.

Updated new patch with applied remarks.

Jun 12 2019, 1:29 PM · Restricted Project
domada added a comment to D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.

If there are no more remarks, I think the patch is ready for submission.

Jun 12 2019, 1:29 PM · Restricted Project

Jun 11 2019

domada added inline comments to D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada added a parent revision for D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder: D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada added a child revision for D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder: D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada created D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder.
Jun 11 2019, 3:47 PM · Restricted Project
domada added a comment to D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

Yes, please do a review.
I have updated patch for moving getNonHoistableCtx to ScopBuilder.

Jun 11 2019, 3:27 PM · Restricted Project
domada updated the diff for D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.

Moved MaxDimensionsInAccessRange constant to ScopBuilder.

Jun 11 2019, 3:24 PM · Restricted Project

Jun 9 2019

domada updated the summary of D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 9 2019, 3:55 PM · Restricted Project
domada updated the summary of D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.
Jun 9 2019, 3:55 PM · Restricted Project
domada added a comment to D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

https://reviews.llvm.org/D63066 -> this child review implements moving of getNonHoistableCtx to ScopBuilder.

Jun 9 2019, 3:55 PM · Restricted Project
domada added a parent revision for D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder: D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.
Jun 9 2019, 3:50 PM · Restricted Project
domada created D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 9 2019, 3:50 PM · Restricted Project
domada added a child revision for D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder: D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 9 2019, 3:50 PM · Restricted Project

Jun 8 2019

domada added a comment to D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

Ok, I can do it.

Jun 8 2019, 2:29 AM · Restricted Project

Jun 5 2019

domada created D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.
Jun 5 2019, 12:25 PM · Restricted Project

Jun 4 2019

domada added a comment to D62781: [Polly][NFC][ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo.

Yes, please do a commit.

Jun 4 2019, 12:48 PM · Restricted Project

Jun 1 2019

domada created D62781: [Polly][NFC][ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo.
Jun 1 2019, 10:47 AM · Restricted Project

May 30 2019

domada added a comment to D62628: [Polly][NFC][ScopBuilder] Move verifyInvariantLoads function from ScopInfo.

Yes, please do a commit.

May 30 2019, 3:06 PM · Restricted Project

May 29 2019

domada created D62628: [Polly][NFC][ScopBuilder] Move verifyInvariantLoads function from ScopInfo.
May 29 2019, 2:00 PM · Restricted Project

May 28 2019

domada added a comment to D62351: [Polly][NFC][ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo.

Yes, please commit for me.

May 28 2019, 1:11 PM · Restricted Project

May 23 2019

domada created D62351: [Polly][NFC][ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo.
May 23 2019, 3:14 PM · Restricted Project

May 22 2019

domada created D62265: [ScopBuilder] Move buildContext function from ScopInfo.
May 22 2019, 11:37 AM · Restricted Project