Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (260 w, 1 d)

Recent Activity

Today

hubert.reinterpretcast added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

That doesn't need to happen now. But I want to see these changed to be global statics not function local. At least that way we omit the guards entirely. and accessing the variable becomes a single instruction.

Fri, Aug 23, 12:01 PM · Restricted Project
hubert.reinterpretcast added a comment to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .

Looking through this latest version still (this is a largish patch).

Fri, Aug 23, 10:01 AM · Restricted Project
hubert.reinterpretcast added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

Sorry for being late to the party, I've looked at the codege of this and other approachs. what we want is a single global than initializes all of objects we need. Right now we have function local static then may may not have make guards and that's less than ideal.

Fri, Aug 23, 8:51 AM · Restricted Project

Yesterday

hubert.reinterpretcast accepted D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.

A few small changes, but otherwise LGTM.

Thu, Aug 22, 3:48 PM · Restricted Project
hubert.reinterpretcast accepted D65667: [libcxx] Avoid destructor call for error_category singletons.

I'm not seeing unresolved comments. This patch LGTM.

Thu, Aug 22, 2:51 PM · Restricted Project

Wed, Aug 21

hubert.reinterpretcast added inline comments to D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Wed, Aug 21, 9:29 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66097: Handle local commons for XCOFF object file writing.
Wed, Aug 21, 4:44 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Wed, Aug 21, 4:35 PM · Restricted Project
hubert.reinterpretcast requested changes to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Wed, Aug 21, 4:16 PM · Restricted Project
hubert.reinterpretcast accepted D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.

LGTM.

Wed, Aug 21, 9:11 AM · Restricted Project
hubert.reinterpretcast added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Wed, Aug 21, 8:30 AM · Restricted Project

Tue, Aug 20

hubert.reinterpretcast added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Which version of RHEL is this patch meant for? Since the jump to C++14, on RHEL <= 7, you will need to compile llvm with the devtoolset toolchain, which has a newer version of binutils. This fix is probably only needed on the release/9.x branch (which can still be built by the system toolchain on RHEL7) and not trunk.

It is possible to build with Clang and libc++ and not use a newer version of binutils for trunk.

Is this the use case this patch is intended to fix?

Tue, Aug 20, 4:56 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Tue, Aug 20, 4:47 PM · Restricted Project
hubert.reinterpretcast added a comment to D64817: [CMake] Fix LLVM build non-determinism on RHEL.

Which version of RHEL is this patch meant for? Since the jump to C++14, on RHEL <= 7, you will need to compile llvm with the devtoolset toolchain, which has a newer version of binutils. This fix is probably only needed on the release/9.x branch (which can still be built by the system toolchain on RHEL7) and not trunk.

Tue, Aug 20, 2:57 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65667: [libcxx] Avoid destructor call for error_category singletons.
Tue, Aug 20, 11:53 AM · Restricted Project
hubert.reinterpretcast accepted D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

Related to the 32-bit vs 64-bit naming and assertions: I can appreciate being defensive about this, but I think trying to disable being able to create the various types and having an assertion (or error) in every function is overkill.

Tue, Aug 20, 10:16 AM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Tue, Aug 20, 9:54 AM · Restricted Project
hubert.reinterpretcast accepted D64817: [CMake] Fix LLVM build non-determinism on RHEL.

This patch LGTM.

Tue, Aug 20, 7:21 AM · Restricted Project

Mon, Aug 19

hubert.reinterpretcast added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Mon, Aug 19, 9:45 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Mon, Aug 19, 9:09 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Mon, Aug 19, 8:29 PM · Restricted Project
hubert.reinterpretcast committed rG71974b517550: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC (authored by hubert.reinterpretcast).
[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
Mon, Aug 19, 4:13 PM
hubert.reinterpretcast committed rL369310: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC.
[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC
Mon, Aug 19, 4:11 PM
hubert.reinterpretcast closed D66441: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC.
Mon, Aug 19, 4:11 PM · Restricted Project
hubert.reinterpretcast created D66441: [cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC.
Mon, Aug 19, 2:21 PM · Restricted Project

Sun, Aug 18

hubert.reinterpretcast requested changes to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Sun, Aug 18, 10:16 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Sun, Aug 18, 9:03 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66256: [AIX] For XL, pick GCC-compatible std & default warning options.
Sun, Aug 18, 3:29 PM · Restricted Project
hubert.reinterpretcast committed rGc313944da629: [cmake] Move blocks out of redundant else( MSVC ); NFC (authored by hubert.reinterpretcast).
[cmake] Move blocks out of redundant else( MSVC ); NFC
Sun, Aug 18, 3:03 PM
hubert.reinterpretcast committed rL369221: [cmake] Move blocks out of redundant else( MSVC ); NFC.
[cmake] Move blocks out of redundant else( MSVC ); NFC
Sun, Aug 18, 3:03 PM

Sat, Aug 17

hubert.reinterpretcast requested changes to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Sat, Aug 17, 9:39 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Sat, Aug 17, 8:28 PM · Restricted Project

Fri, Aug 16

hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Fri, Aug 16, 4:22 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65667: [libcxx] Avoid destructor call for error_category singletons.
Fri, Aug 16, 3:04 PM · Restricted Project
hubert.reinterpretcast retitled D65667: [libcxx] Avoid destructor call for error_category singletons from [libcxx] Early-initialize error_category singletons to [libcxx] Avoid destructor call for error_category singletons.
Fri, Aug 16, 2:50 PM · Restricted Project
hubert.reinterpretcast updated the summary of D65667: [libcxx] Avoid destructor call for error_category singletons.
Fri, Aug 16, 2:49 PM · Restricted Project
hubert.reinterpretcast added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

To chime in from the sidelines: We strive to have zero code that runs before main in Chromium, so we're not excited about a patch that adds more such code to libc++. (In fact, we're hoping to contribute a build mode that removes the existing static initializer for cin/cout/cerr as well.)

Fri, Aug 16, 2:31 PM · Restricted Project

Thu, Aug 15

hubert.reinterpretcast committed rG67af3fa7caa2: [AIX] For XL, pick GCC-compatible std & default warning options (authored by hubert.reinterpretcast).
[AIX] For XL, pick GCC-compatible std & default warning options
Thu, Aug 15, 3:25 PM
hubert.reinterpretcast committed rL369058: [AIX] For XL, pick GCC-compatible std & default warning options.
[AIX] For XL, pick GCC-compatible std & default warning options
Thu, Aug 15, 3:25 PM
hubert.reinterpretcast closed D66256: [AIX] For XL, pick GCC-compatible std & default warning options.
Thu, Aug 15, 3:25 PM · Restricted Project

Wed, Aug 14

hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Wed, Aug 14, 8:30 PM · Restricted Project
hubert.reinterpretcast updated the diff for D66256: [AIX] For XL, pick GCC-compatible std & default warning options.

Fix spelling error

Wed, Aug 14, 7:39 PM · Restricted Project
hubert.reinterpretcast retitled D66256: [AIX] For XL, pick GCC-compatible std & default warning options from [AIX] Use GCC-style -std and warning options for XL to [AIX] For XL, pick GCC-compatible std & default warning options.
Wed, Aug 14, 7:35 PM · Restricted Project
hubert.reinterpretcast updated the diff for D66256: [AIX] For XL, pick GCC-compatible std & default warning options.

Address comments: Split large GCC-compatible options block

Wed, Aug 14, 7:35 PM · Restricted Project
hubert.reinterpretcast added a comment to D66256: [AIX] For XL, pick GCC-compatible std & default warning options.
In D66256#1630348, @jfb wrote:

I'm worried because this entire section is for "GCC compatible command line stuff". If someone added something new in there, would it inadvertently break XL? Maybe it's better to factor out the bits you want to enable and leave the rest separate from XL?

Wed, Aug 14, 3:54 PM · Restricted Project
hubert.reinterpretcast added a comment to D66256: [AIX] For XL, pick GCC-compatible std & default warning options.
In D66256#1630326, @jfb wrote:

Can XL enable all the same flags which GCC can?

Wed, Aug 14, 2:43 PM · Restricted Project
hubert.reinterpretcast created D66256: [AIX] For XL, pick GCC-compatible std & default warning options.
Wed, Aug 14, 2:21 PM · Restricted Project

Tue, Aug 13

hubert.reinterpretcast requested changes to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

I am still working through this version, but I think this might need another pass on an updated copy.

Tue, Aug 13, 9:29 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Tue, Aug 13, 7:24 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66097: Handle local commons for XCOFF object file writing.
Tue, Aug 13, 6:20 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Tue, Aug 13, 2:38 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Tue, Aug 13, 2:33 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Tue, Aug 13, 1:50 PM · Restricted Project
hubert.reinterpretcast committed rG09967050098e: Reland r368691: "[AIX] Implement LR prolog/epilog save/restore" (authored by hubert.reinterpretcast).
Reland r368691: "[AIX] Implement LR prolog/epilog save/restore"
Tue, Aug 13, 10:06 AM
hubert.reinterpretcast committed rL368721: Reland r368691: "[AIX] Implement LR prolog/epilog save/restore".
Reland r368691: "[AIX] Implement LR prolog/epilog save/restore"
Tue, Aug 13, 10:04 AM
hubert.reinterpretcast added inline comments to D66032: [AIX][MC][NFC] Explicitly set containing csects on XCOFF Symbols.
Tue, Aug 13, 9:19 AM · Restricted Project
hubert.reinterpretcast added a comment to D64424: [AIX] Implement LR prolog/epilog save/restore .

My attempt to commit this only committed the test. I'll try again once the bots clear.

Tue, Aug 13, 7:44 AM · Restricted Project
hubert.reinterpretcast committed rG07e66137561f: Revert r368691; test checked in without changes by accident (authored by hubert.reinterpretcast).
Revert r368691; test checked in without changes by accident
Tue, Aug 13, 7:44 AM
hubert.reinterpretcast committed rL368699: Revert r368691; test checked in without changes by accident.
Revert r368691; test checked in without changes by accident
Tue, Aug 13, 7:42 AM
hubert.reinterpretcast committed rGf635e28df8d0: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX (authored by hubert.reinterpretcast).
[AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX
Tue, Aug 13, 6:39 AM
hubert.reinterpretcast committed rG8f1db0cd08d0: [AIX] Implement LR prolog/epilog save/restore (authored by hubert.reinterpretcast).
[AIX] Implement LR prolog/epilog save/restore
Tue, Aug 13, 6:39 AM
hubert.reinterpretcast committed rL368691: [AIX] Implement LR prolog/epilog save/restore.
[AIX] Implement LR prolog/epilog save/restore
Tue, Aug 13, 6:39 AM
hubert.reinterpretcast committed rL368690: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX.
[AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX
Tue, Aug 13, 6:39 AM
hubert.reinterpretcast closed D64424: [AIX] Implement LR prolog/epilog save/restore .
Tue, Aug 13, 6:39 AM · Restricted Project
hubert.reinterpretcast closed D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX.
Tue, Aug 13, 6:39 AM · Restricted Project, Restricted Project

Mon, Aug 12

hubert.reinterpretcast accepted D63547: [AIX]Global Address Lowering.

LGTM with a minor issue that can be fixed on check-in.

Mon, Aug 12, 3:25 PM · Restricted Project
hubert.reinterpretcast added a comment to D63547: [AIX]Global Address Lowering.

@Xiangling_L, I'd be happy to work with you on this off-list to move this along.

Mon, Aug 12, 10:24 AM · Restricted Project
hubert.reinterpretcast accepted D64424: [AIX] Implement LR prolog/epilog save/restore .

LGTM.

Mon, Aug 12, 8:54 AM · Restricted Project

Fri, Aug 9

hubert.reinterpretcast added inline comments to D64825: Enable assembly output of local commons for AIX.
Fri, Aug 9, 12:52 PM · Restricted Project

Wed, Aug 7

hubert.reinterpretcast added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

Thanks for the clarification.

So the situation is:

  • You register an atexit handler.
  • During program termination, your handler is called, and you do something that creates an error_code object.
  • You try to use the error_category of that error code, and discover that it has been destroyed?

    Is that correct?
Wed, Aug 7, 2:27 PM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Wed, Aug 7, 9:42 AM · Restricted Project
hubert.reinterpretcast added inline comments to D64825: Enable assembly output of local commons for AIX.
Wed, Aug 7, 9:42 AM · Restricted Project
hubert.reinterpretcast added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Wed, Aug 7, 6:46 AM · Restricted Project

Tue, Aug 6

hubert.reinterpretcast added inline comments to D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj .
Tue, Aug 6, 10:09 PM · Restricted Project
hubert.reinterpretcast added a comment to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

This patch needs a rebase. It no longer applies cleanly.

Tue, Aug 6, 9:35 PM · Restricted Project
hubert.reinterpretcast added inline comments to D64825: Enable assembly output of local commons for AIX.
Tue, Aug 6, 9:35 PM · Restricted Project
hubert.reinterpretcast added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

Hubert - I'm not following what you're saying.
Where did error_code come from? As far as I can tell, your comment is the first mention of error_code in this conversation.

Tue, Aug 6, 3:09 PM · Restricted Project
hubert.reinterpretcast committed rG51b0032ff701: [CMake] Add mapping for IBM XL -qnoeh and -qnortti (authored by hubert.reinterpretcast).
[CMake] Add mapping for IBM XL -qnoeh and -qnortti
Tue, Aug 6, 8:08 AM
hubert.reinterpretcast committed rL368050: [CMake] Add mapping for IBM XL -qnoeh and -qnortti.
[CMake] Add mapping for IBM XL -qnoeh and -qnortti
Tue, Aug 6, 8:08 AM
hubert.reinterpretcast closed D65669: [CMake] Add mapping for IBM XL -qnoeh and -qnortti.
Tue, Aug 6, 8:08 AM · Restricted Project
hubert.reinterpretcast committed rGfc34a536d04a: [XCOFF][MC] report_fatal_error before dereferencing NULL (authored by hubert.reinterpretcast).
[XCOFF][MC] report_fatal_error before dereferencing NULL
Tue, Aug 6, 8:06 AM
hubert.reinterpretcast committed rL368048: [XCOFF][MC] report_fatal_error before dereferencing NULL.
[XCOFF][MC] report_fatal_error before dereferencing NULL
Tue, Aug 6, 8:05 AM

Mon, Aug 5

hubert.reinterpretcast added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

The good news is that the constructor of the singleton object in libc++ is under your control. It can be constructed whenever you choose, just by calling generic_category().

Mon, Aug 5, 5:34 PM · Restricted Project
hubert.reinterpretcast added inline comments to D64424: [AIX] Implement LR prolog/epilog save/restore .
Mon, Aug 5, 10:19 AM · Restricted Project
hubert.reinterpretcast added inline comments to D64424: [AIX] Implement LR prolog/epilog save/restore .
Mon, Aug 5, 10:01 AM · Restricted Project
hubert.reinterpretcast committed rG6ca6e91615da: [yaml2obj][tests] Fix overly restrictive od output check (authored by hubert.reinterpretcast).
[yaml2obj][tests] Fix overly restrictive od output check
Mon, Aug 5, 6:58 AM
hubert.reinterpretcast committed rL367862: [yaml2obj][tests] Fix overly restrictive od output check.
[yaml2obj][tests] Fix overly restrictive od output check
Mon, Aug 5, 6:56 AM
hubert.reinterpretcast closed D65680: [yaml2obj][tests] Fix overly restrictive od output check.
Mon, Aug 5, 6:56 AM · Restricted Project
hubert.reinterpretcast updated the summary of D65680: [yaml2obj][tests] Fix overly restrictive od output check.
Mon, Aug 5, 6:53 AM · Restricted Project

Sun, Aug 4

hubert.reinterpretcast updated the diff for D65680: [yaml2obj][tests] Fix overly restrictive od output check.

Addrew review comments: Output and check the byte values only

Sun, Aug 4, 5:53 AM · Restricted Project

Sat, Aug 3

hubert.reinterpretcast committed rG43e60ba8c328: [yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion (authored by hubert.reinterpretcast).
[yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion
Sat, Aug 3, 11:53 AM
hubert.reinterpretcast committed rL367760: [yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion.
[yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion
Sat, Aug 3, 11:52 AM
hubert.reinterpretcast closed D65671: [yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion.
Sat, Aug 3, 11:52 AM · Restricted Project
hubert.reinterpretcast added inline comments to D65680: [yaml2obj][tests] Fix overly restrictive od output check.
Sat, Aug 3, 10:28 AM · Restricted Project
hubert.reinterpretcast added a comment to D65667: [libcxx] Avoid destructor call for error_category singletons.

@EricWF pointed out to me that it is UB to access standard library objects of static storage duration from an atexit handler: http://eel.is/c++draft/basic.start.term#6

Sat, Aug 3, 9:40 AM · Restricted Project
hubert.reinterpretcast added a comment to D65680: [yaml2obj][tests] Fix overly restrictive od output check.

Can you just dump the output of od -t x1 -v -j 0x3a -N 1 %t3 on AIX? That would be more descriptive I think. It also helps us decide how to test.

Sat, Aug 3, 8:32 AM · Restricted Project
hubert.reinterpretcast added a comment to D65671: [yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion.

Is there a plan that AIX od will implement x8?

I've requested the change, but I cannot make any promises on delivery vehicle.

Sat, Aug 3, 7:57 AM · Restricted Project
hubert.reinterpretcast added a comment to rL363829: [NFC][llvm-objcopy] Fix overly restrictive od output check.

I think the description should ideally give an output example of AIX od. Many developers are not familiar with its output format.

Sat, Aug 3, 7:49 AM
hubert.reinterpretcast added a comment to D65680: [yaml2obj][tests] Fix overly restrictive od output check.

rL364517 introduced further instances of od output checking of the kind previously corrected by rL363829.

I leaved a comment for rL363829, it seems broke at least one of the tests.

I've answered the question asked in rL363829.

Sat, Aug 3, 7:48 AM · Restricted Project
hubert.reinterpretcast added inline comments to rL363829: [NFC][llvm-objcopy] Fix overly restrictive od output check.
Sat, Aug 3, 7:40 AM