User Details
- User Since
- Aug 27 2014, 8:34 PM (447 w, 5 d)
Today
Yesterday
Wed, Mar 22
Wed, Mar 15
Patch LGTM. Thanks for looking into the concerns.
Tue, Mar 14
Wed, Mar 8
This LGTM; thanks!
Tue, Mar 7
Sun, Mar 5
Fri, Mar 3
Thu, Mar 2
@philnik, can you update this to always have the key function on AIX and remove it for other platforms?
Wed, Mar 1
Feb 24 2023
Feb 23 2023
Feb 21 2023
Feb 16 2023
Feb 15 2023
Feb 9 2023
I think it may be an option to use the gnu++* modes to do deliberately non-conforming things, but I believe there should be an RFC for that first.
Feb 2 2023
LGTM; thanks!
Feb 1 2023
Waiting on changes to fix the visitation to locate the appropriate temporaries.
I made changes to the patch description (which I expect we will be using for the commit message).
Jan 23 2023
Since this is a change only for AIX and z/OS, and considering that this is a patch to prevent ABI changes compared to the current ABI baselines for those platforms, I will land this ahead of the LLVM 16 branching.
Thanks @nicolerabjohn; this LGTM!
Jan 5 2023
@francii, from offline discussion, a change is pending to use a different approach (the current one here breaks load ABI). If the change is going to take time, please mark this as having changes planned (i.e., not ready for review).
Jan 3 2023
Dec 15 2022
At least on the surface, it looks like there will be a lot of trouble to deal with default arguments:
struct A { A(); ~A(); int x[3]; }; int (&f(const A & = A()))[3]; void bar(int); void foo() { for (auto e : f()) { bar(e); } }
Nov 23 2022
LGTM; thanks!
Nov 22 2022
LGTM; thanks!
Nov 16 2022
LGTM; thanks!
LGTM; no objection if we're planning to move ahead without checking the calculated size field in the traceback table.
Nov 15 2022
Nov 14 2022
I am a bit torn over not actually checking that the calculated function sizes are correct, but I guess that we can infer from there being no relocations generated for it that we are going through the right MCExpr processing.
Nov 12 2022
Nov 4 2022
Nov 3 2022
Nov 2 2022
LGTM with comment.
Nov 1 2022
Oct 31 2022
Oct 30 2022
Oct 28 2022
Oct 27 2022
Oct 25 2022
@w2yehia, this can be closed now (the other patch that also covers what this one is solving has landed)?
Oct 24 2022
Confirming LGTM from the AIX side.
Oct 20 2022
This LGTM. Size of Registration changes from 1 byte to (likely) 4 bytes on non-AIX platforms and now incurs an extra memory write, but that should be insignificant.
Oct 19 2022
LGTM from the AIX perspective.