Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (346 w, 5 d)

Recent Activity

Sun, Apr 18

hubert.reinterpretcast added inline comments to D98859: [lit] Handle plain negations directly in the internal shell.
Sun, Apr 18, 4:38 PM · Restricted Project
hubert.reinterpretcast added inline comments to D98859: [lit] Handle plain negations directly in the internal shell.
Sun, Apr 18, 2:05 PM · Restricted Project

Fri, Apr 16

hubert.reinterpretcast retitled D100651: [AIX] Support of Big archive (read) from Support of Big archive (read) to [AIX] Support of Big archive (read).
Fri, Apr 16, 9:59 AM · Restricted Project

Thu, Apr 8

hubert.reinterpretcast accepted D99767: [libc++][AIX] Fix abs and div overload issue for compilers on AIX.

Double checked re: scope of __ABS_LONG__. Confirming LGTM re: AIX context.

Thu, Apr 8, 2:20 PM · Restricted Project

Tue, Apr 6

hubert.reinterpretcast added a comment to D99785: [XCOFF] make .file directive have directory info.

From what I understand, this is meant to fix a situation where dbx is unhappy when the file is not simply compiled in the directory where it resides (using its basename). However, this unhappiness extends even to the compiled-using-basename case when the filename contains "special characters".

Tue, Apr 6, 6:40 AM · Restricted Project

Mon, Apr 5

hubert.reinterpretcast accepted D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.

LGTM; thanks!

Mon, Apr 5, 6:57 PM · Restricted Project

Tue, Mar 30

hubert.reinterpretcast added inline comments to D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above.
Tue, Mar 30, 9:14 AM · Restricted Project

Fri, Mar 26

hubert.reinterpretcast added inline comments to D99305: [docs] Document our norms around reverts.
Fri, Mar 26, 11:27 AM · Restricted Project
hubert.reinterpretcast resigned from D99305: [docs] Document our norms around reverts.

I have just some typo/phrasing fixes to suggest. I think my other concerns have been addressed.

Fri, Mar 26, 10:59 AM · Restricted Project

Thu, Mar 25

hubert.reinterpretcast added inline comments to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.
Thu, Mar 25, 6:57 PM · Restricted Project
hubert.reinterpretcast added inline comments to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.
Thu, Mar 25, 6:53 PM · Restricted Project
hubert.reinterpretcast added inline comments to D99305: [docs] Document our norms around reverts.
Thu, Mar 25, 3:08 PM · Restricted Project
hubert.reinterpretcast added inline comments to D99305: [docs] Document our norms around reverts.
Thu, Mar 25, 3:02 PM · Restricted Project
hubert.reinterpretcast added inline comments to D99305: [docs] Document our norms around reverts.
Thu, Mar 25, 2:59 PM · Restricted Project
hubert.reinterpretcast added inline comments to D99305: [docs] Document our norms around reverts.
Thu, Mar 25, 2:49 PM · Restricted Project
hubert.reinterpretcast requested changes to D99305: [docs] Document our norms around reverts.
Thu, Mar 25, 2:44 PM · Restricted Project

Wed, Mar 24

hubert.reinterpretcast added inline comments to D98946: [AIX][TLS] Add support for TLS variables to XCOFF object writer.
Wed, Mar 24, 3:28 PM · Restricted Project
hubert.reinterpretcast accepted D98554: Save strings for CC_PRINT env vars.

LGTM; thanks.

Wed, Mar 24, 3:05 PM · Restricted Project
hubert.reinterpretcast accepted D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

@hubert.reinterpretcast Does the freelocale approach look good to you?

Wed, Mar 24, 2:53 PM · Restricted Project, Restricted Project

Tue, Mar 23

hubert.reinterpretcast accepted D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.

LGTM with small suggested changes.

Tue, Mar 23, 3:42 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Tue, Mar 23, 2:54 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Tue, Mar 23, 2:48 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Tue, Mar 23, 12:28 PM · Restricted Project, Restricted Project

Mon, Mar 22

hubert.reinterpretcast added inline comments to D97558: [libc++][AIX] Initial patch to unblock the libc++ build on AIX.
Mon, Mar 22, 3:32 PM · Restricted Project, Restricted Project

Mar 19 2021

hubert.reinterpretcast accepted D98901: [AIX] Update rpath for BUILD_SHARED_LIBS.

LGTM; thanks!

Mar 19 2021, 6:44 PM · Restricted Project
hubert.reinterpretcast added inline comments to D98901: [AIX] Update rpath for BUILD_SHARED_LIBS.
Mar 19 2021, 1:39 PM · Restricted Project
hubert.reinterpretcast added inline comments to D98901: [AIX] Update rpath for BUILD_SHARED_LIBS.
Mar 19 2021, 12:45 PM · Restricted Project

Mar 18 2021

hubert.reinterpretcast accepted D98793: [SystemZ][z/OS] fix lit test related to alignment .

LGTM; thanks.

Mar 18 2021, 3:23 PM · Restricted Project
hubert.reinterpretcast added inline comments to D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 18 2021, 9:46 AM · Restricted Project

Mar 17 2021

hubert.reinterpretcast added a comment to D98793: [SystemZ][z/OS] fix lit test related to alignment .

@NancyWang2222, the patch description doesn't seem to say much about the bit-field case. Can you expand it?

Mar 17 2021, 9:02 PM · Restricted Project

Mar 16 2021

hubert.reinterpretcast accepted D98620: [NFC] [XCOFF] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex.

LGTM; thanks!

Mar 16 2021, 8:12 PM · Restricted Project
hubert.reinterpretcast added a comment to D98620: [NFC] [XCOFF] Update PowerPC readobj test case with expression for Index and ContainingCsectSymbolIndex.

@edwin, the patch needs to be updated with additional diff context.

Mar 16 2021, 2:42 PM · Restricted Project

Mar 15 2021

hubert.reinterpretcast accepted D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default..

LGTM (with the equal sign form as @daltenty requested if it works).

Mar 15 2021, 2:01 PM · Restricted Project
hubert.reinterpretcast accepted D97846: Allow __ieee128 as an alias to __float128 on ppc.

LGTM; thanks.

Mar 15 2021, 9:39 AM · Restricted Project

Mar 14 2021

hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Mar 14 2021, 8:13 AM · Restricted Project

Mar 13 2021

hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Mar 13 2021, 12:24 PM · Restricted Project
hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Mar 13 2021, 10:54 AM · Restricted Project

Mar 12 2021

hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Mar 12 2021, 8:29 PM · Restricted Project
hubert.reinterpretcast added inline comments to D98554: Save strings for CC_PRINT env vars.
Mar 12 2021, 8:03 PM · Restricted Project
hubert.reinterpretcast accepted D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

Retained using declarations look fine. LGTM.

Mar 12 2021, 7:35 PM · Restricted Project
hubert.reinterpretcast added a comment to D97846: Allow __ieee128 as an alias to __float128 on ppc.

GCC doesn't seem to implement this as a keyword?

namespace Q { int __ieee128; } // compiles
Mar 12 2021, 4:45 PM · Restricted Project
hubert.reinterpretcast accepted D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

Thanks @Xiangling_L and also to the other reviewers for the great comments. This LGTM.

Mar 12 2021, 2:24 PM · Restricted Project
hubert.reinterpretcast closed D98543: [AsmParser][SystemZ][z/OS] Revert - "Introducing HLASM Comment Syntax".

Committed: https://github.com/llvm/llvm-project/commit/4f9cc15

Mar 12 2021, 11:50 AM · Restricted Project
hubert.reinterpretcast committed rG4f9cc1512d51: Revert "[AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax" (authored by hubert.reinterpretcast).
Revert "[AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax"
Mar 12 2021, 11:49 AM
hubert.reinterpretcast added a reverting change for rGbcdd40f802a5: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax: rG4f9cc1512d51: Revert "[AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax".
Mar 12 2021, 11:49 AM
hubert.reinterpretcast added a reverting change for D97703: [AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax: rG4f9cc1512d51: Revert "[AsmParser][SystemZ][z/OS] Introducing HLASM Comment Syntax".
Mar 12 2021, 11:49 AM · Restricted Project
hubert.reinterpretcast added a comment to D98543: [AsmParser][SystemZ][z/OS] Revert - "Introducing HLASM Comment Syntax".

Will commit a revert.

Mar 12 2021, 11:46 AM · Restricted Project

Mar 10 2021

hubert.reinterpretcast added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 10 2021, 9:17 PM · Restricted Project
hubert.reinterpretcast added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 10 2021, 2:54 PM · Restricted Project

Mar 9 2021

hubert.reinterpretcast added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 9 2021, 1:27 PM · Restricted Project
hubert.reinterpretcast accepted D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX.

LGTM; thanks.

Mar 9 2021, 9:41 AM · Restricted Project

Mar 6 2021

hubert.reinterpretcast added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 6 2021, 7:08 PM · Restricted Project

Mar 5 2021

hubert.reinterpretcast added inline comments to D46443: [libc++] Add missing cstdalign header.
Mar 5 2021, 7:57 PM · Restricted Project
hubert.reinterpretcast added a comment to D97748: [SystemZ][z/OS] Add support to validate a HLASM Label..
In D97748#2607182, @Kai wrote:

there are some implications with char/string literals inside an inline asm string

Mar 5 2021, 12:24 PM · Restricted Project
hubert.reinterpretcast added a comment to D97748: [SystemZ][z/OS] Add support to validate a HLASM Label..

And the current implementation here expects UTF-8 (or that's what the internal character encoding is assumed to be anyway). There's a patch for -fexec-charset and the string being parsed here went into the IR in what form?

Currently, the asm string goes into the IR in ASCII, irrespective of the -fexec-charset option.

Mar 5 2021, 12:08 PM · Restricted Project

Mar 4 2021

hubert.reinterpretcast added a comment to D97748: [SystemZ][z/OS] Add support to validate a HLASM Label..

For now, We don’t have a firm decision on whether we will implement/support pragma convert. I understand that if it is supported, it will be a problem since the character values for the national characters will be different based on the encoding. At a future point, when we have more information, we can come back and review whether certain applicable functions would need to take the encoding into account, or, whether it can be designed in a way such that for example, everything is encoded in UTF-8 and the emission/translation is handled elsewhere (preferably much earlier than the respective backend). For now, I'm assuming the current implementation is fine.

Mar 4 2021, 9:17 AM · Restricted Project

Mar 2 2021

hubert.reinterpretcast added a comment to D97748: [SystemZ][z/OS] Add support to validate a HLASM Label..

An additional point:
I checked the V1R6 Reference manual again and I seem to have forgotten to include a check for "National Characters" ($,@ and #). I would like to remedy this by adding two private inline functions isHLASMAlpha and isHLASMAlnum which encapsulates the checks for what is an "HLASM" alphabet, and use them in the overridden isLabel routine. Is this acceptable?

Mar 2 2021, 2:34 PM · Restricted Project

Mar 1 2021

hubert.reinterpretcast added inline comments to D97748: [SystemZ][z/OS] Add support to validate a HLASM Label..
Mar 1 2021, 8:03 PM · Restricted Project
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 1 2021, 10:33 AM · debug-info, Restricted Project
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Mar 1 2021, 10:03 AM · debug-info, Restricted Project

Feb 27 2021

hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Feb 27 2021, 4:34 PM · debug-info, Restricted Project
hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Feb 27 2021, 12:51 PM · debug-info, Restricted Project
hubert.reinterpretcast updated subscribers of D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Feb 27 2021, 10:38 AM · debug-info, Restricted Project

Feb 26 2021

hubert.reinterpretcast added inline comments to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.
Feb 26 2021, 9:37 AM · debug-info, Restricted Project

Feb 24 2021

hubert.reinterpretcast added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 24 2021, 10:00 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 24 2021, 9:21 AM · Restricted Project, Restricted Project

Feb 23 2021

hubert.reinterpretcast added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 23 2021, 8:07 PM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D97117: [XCOFF] add C_FILE symbol at index 0.

LGTM with an additional comment wording change.

Feb 23 2021, 8:12 AM · Restricted Project

Feb 22 2021

hubert.reinterpretcast added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 22 2021, 3:18 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D97039: [PowerPC] Enable redundant TOC save removal on AIX.
Feb 22 2021, 11:06 AM · Restricted Project
hubert.reinterpretcast added inline comments to D97117: [XCOFF] add C_FILE symbol at index 0.
Feb 22 2021, 7:06 AM · Restricted Project

Feb 20 2021

hubert.reinterpretcast added inline comments to D97117: [XCOFF] add C_FILE symbol at index 0.
Feb 20 2021, 8:38 AM · Restricted Project

Feb 18 2021

hubert.reinterpretcast added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Feb 18 2021, 1:40 PM · Restricted Project
hubert.reinterpretcast added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 18 2021, 1:38 PM · Restricted Project, Restricted Project

Feb 17 2021

hubert.reinterpretcast added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 17 2021, 1:09 PM · Restricted Project, Restricted Project

Feb 16 2021

hubert.reinterpretcast added a comment to D46443: [libc++] Add missing cstdalign header.

The resolution of LWG 2828 means that <cstdalign> exists in C++11 and C++14. The rationale from https://reviews.llvm.org/D96786#2566110 can be taken as saying that adding this header for C++11 conformance is reasonable.

Feb 16 2021, 11:38 AM · Restricted Project

Feb 13 2021

hubert.reinterpretcast accepted D96641: [XCOFF] [NFC] make StorageMappingClass/SymbolType member optional in MCSectionXCOFF class.

LGTM with minor comments.

Feb 13 2021, 8:53 PM · Restricted Project
hubert.reinterpretcast added inline comments to D96641: [XCOFF] [NFC] make StorageMappingClass/SymbolType member optional in MCSectionXCOFF class.
Feb 13 2021, 8:16 PM · Restricted Project
hubert.reinterpretcast added inline comments to D96641: [XCOFF] [NFC] make StorageMappingClass/SymbolType member optional in MCSectionXCOFF class.
Feb 13 2021, 2:25 PM · Restricted Project
hubert.reinterpretcast accepted D95931: [XCOFF] [NFC] make csect properties optional for function getXCOFFSection.

LGTM with minor comment.

Feb 13 2021, 2:21 PM · Restricted Project
hubert.reinterpretcast added inline comments to D96641: [XCOFF] [NFC] make StorageMappingClass/SymbolType member optional in MCSectionXCOFF class.
Feb 13 2021, 2:12 PM · Restricted Project

Feb 11 2021

hubert.reinterpretcast added inline comments to D95931: [XCOFF] [NFC] make csect properties optional for function getXCOFFSection.
Feb 11 2021, 2:19 PM · Restricted Project
hubert.reinterpretcast added inline comments to D95931: [XCOFF] [NFC] make csect properties optional for function getXCOFFSection.
Feb 11 2021, 2:13 PM · Restricted Project
hubert.reinterpretcast added a comment to D95518: [Debug-Info][XCOFF] support dwarf for XCOFF for assembly output.

Drive by comment,

Object output will be handled in followup patches.

[...]

Since I can not get the assembly file been assembled, I verify the debug info by checking the assembly files.

Feb 11 2021, 11:10 AM · debug-info, Restricted Project

Feb 9 2021

hubert.reinterpretcast added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 9 2021, 11:03 AM · Restricted Project
hubert.reinterpretcast added inline comments to D95444: Allow GNU inline asm using target-specific dialect variant.
Feb 9 2021, 8:47 AM · Restricted Project
hubert.reinterpretcast added inline comments to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Feb 9 2021, 8:37 AM · Restricted Project
hubert.reinterpretcast accepted D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 9 2021, 7:58 AM · Restricted Project
hubert.reinterpretcast added a comment to D95966: [AIX][llvm][support] Implement getHostCPUName.

LGTM with minor comments on the test.

Feb 9 2021, 7:58 AM · Restricted Project
hubert.reinterpretcast added inline comments to D95444: Allow GNU inline asm using target-specific dialect variant.
Feb 9 2021, 5:51 AM · Restricted Project

Feb 8 2021

hubert.reinterpretcast added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Feb 8 2021, 9:20 PM · Restricted Project
hubert.reinterpretcast added inline comments to D95444: Allow GNU inline asm using target-specific dialect variant.
Feb 8 2021, 5:09 PM · Restricted Project
hubert.reinterpretcast updated the summary of D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Feb 8 2021, 3:06 PM · Restricted Project

Feb 5 2021

hubert.reinterpretcast added a comment to D95444: Allow GNU inline asm using target-specific dialect variant.
In D95444#2542739, @rnk wrote:

Clang actually supports mixing GCC and MSVC inline asm in the same translation unit, and it uses the dialect flag in the IR to control this (I think). This is important if you want to support LTO between two TUs that use GCC and HLASM. Maybe there is exactly zero inline asm that uses GCC-style asm for SystemZ, so maybe this isn't a concern, but I thought I'd ask.

Feb 5 2021, 10:37 AM · Restricted Project
hubert.reinterpretcast accepted D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.

From my end, LGTM.

Feb 5 2021, 10:27 AM · Restricted Project
hubert.reinterpretcast added inline comments to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.
Feb 5 2021, 9:16 AM · Restricted Project
hubert.reinterpretcast added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 5 2021, 8:53 AM · Restricted Project

Feb 4 2021

hubert.reinterpretcast added inline comments to D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative.
Feb 4 2021, 9:03 PM · Restricted Project
hubert.reinterpretcast added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 4 2021, 4:56 PM · Restricted Project
hubert.reinterpretcast added inline comments to D95444: Allow GNU inline asm using target-specific dialect variant.
Feb 4 2021, 9:43 AM · Restricted Project