Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (267 w, 6 d)

Recent Activity

Today

hubert.reinterpretcast accepted D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

LGTM. Thanks.

Wed, Oct 16, 1:54 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Wed, Oct 16, 11:15 AM · Restricted Project
hubert.reinterpretcast added a comment to D69048: [LNT] Python 3 support: run tests with UTF-8 encoding.

I don't think that this is a clear "win". Users may have UTF-8 capable locales not ending in ".UTF-8" and also not have a usable en_US.UTF-8 locale. It might be nice for some people, but this can actually break others. I don't see an issue with asking users to specify an appropriate value of LANG for their environment.

Wed, Oct 16, 9:22 AM

Yesterday

hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Tue, Oct 15, 12:51 PM · Restricted Project

Sat, Oct 12

hubert.reinterpretcast closed D68903: [LNT] NFC: Fix order of globals and locals on exec.

Committed: https://github.com/llvm/llvm-lnt/commit/f805c3e1eece29e502a88a095c710f32473ca3c5

Sat, Oct 12, 1:30 PM
hubert.reinterpretcast committed rL374685: [LNT] NFC: Fix order of globals and locals on exec.
[LNT] NFC: Fix order of globals and locals on exec
Sat, Oct 12, 1:21 PM
hubert.reinterpretcast updated the summary of D68903: [LNT] NFC: Fix order of globals and locals on exec.
Sat, Oct 12, 1:21 PM
hubert.reinterpretcast accepted D67822: [LNT] Python 3 support: adapt to removal of execfile.

LGTM.

Sat, Oct 12, 11:13 AM
hubert.reinterpretcast added inline comments to D68340: Add AIX toolchain and basic linker functionality.
Sat, Oct 12, 9:50 AM · Restricted Project

Fri, Oct 11

hubert.reinterpretcast created D68903: [LNT] NFC: Fix order of globals and locals on exec.
Fri, Oct 11, 10:01 PM
hubert.reinterpretcast committed rGfce11c6904c8: NFC: clang-format rL374420 and adjust comment wording (authored by hubert.reinterpretcast).
NFC: clang-format rL374420 and adjust comment wording
Fri, Oct 11, 9:08 PM
hubert.reinterpretcast committed rL374635: NFC: clang-format rL374420 and adjust comment wording.
NFC: clang-format rL374420 and adjust comment wording
Fri, Oct 11, 9:07 PM
hubert.reinterpretcast accepted D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.

LGTM with minor changes.

Fri, Oct 11, 8:31 PM · Restricted Project
hubert.reinterpretcast accepted D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.

LGTM. Thanks.

Fri, Oct 11, 2:22 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Fri, Oct 11, 1:35 PM · Restricted Project
hubert.reinterpretcast added a comment to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.

Thanks @DiggerLin. I think this is almost ready.

Fri, Oct 11, 1:24 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Fri, Oct 11, 11:49 AM · Restricted Project
hubert.reinterpretcast added a comment to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.

I've marked comments (all minor) that have not yet been addressed.

Fri, Oct 11, 10:33 AM · Restricted Project
hubert.reinterpretcast accepted D66969: Output XCOFF object text section header and symbol entry for program code.

LGTM with minor changes that can be made on the check-in.

Fri, Oct 11, 10:15 AM · Restricted Project
hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Fri, Oct 11, 9:01 AM · Restricted Project

Thu, Oct 10

hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Thu, Oct 10, 10:05 PM · Restricted Project
hubert.reinterpretcast added inline comments to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.
Thu, Oct 10, 1:46 PM · Restricted Project
hubert.reinterpretcast added a comment to D66969: Output XCOFF object text section header and symbol entry for program code.

Just some minor comments. I think this is almost ready.

Thu, Oct 10, 1:46 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Thu, Oct 10, 9:01 AM · Restricted Project
hubert.reinterpretcast accepted D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.

LGTM with some straightforward changes (can be fixed on the commit).

Thu, Oct 10, 8:59 AM · Restricted Project
hubert.reinterpretcast added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Thu, Oct 10, 8:03 AM · Restricted Project

Wed, Oct 9

hubert.reinterpretcast accepted D68104: [LNT] Python 3 support: adapt secret computation.

LGTM.

Wed, Oct 9, 6:22 PM
hubert.reinterpretcast accepted D67882: [LNT] Python 3 support: remove useless var-setting getter.

LGTM.

Wed, Oct 9, 6:22 PM
hubert.reinterpretcast accepted D68105: [LNT] Python 3 support: fix report version literal.

LGTM.

Wed, Oct 9, 6:22 PM
hubert.reinterpretcast added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Wed, Oct 9, 3:54 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68721: [NFC][PowerPC]Clean up PPCAsmPrinter for TOC related pseudo opcode.
Wed, Oct 9, 3:35 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Wed, Oct 9, 2:31 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Wed, Oct 9, 2:22 PM · Restricted Project
hubert.reinterpretcast added a comment to D68575: [llvm-readobj][xcoff] implement parsing overflow section header..

LGTM to land as-is. Not sure if other people have an opinion about the const.
@DiggerLin, I believe you have had a number of patches committed into the project. I think you can request commit access and land this yourself. Thanks.

Wed, Oct 9, 11:54 AM · Restricted Project
hubert.reinterpretcast accepted D68575: [llvm-readobj][xcoff] implement parsing overflow section header..
Wed, Oct 9, 11:54 AM · Restricted Project

Tue, Oct 8

hubert.reinterpretcast added inline comments to D68575: [llvm-readobj][xcoff] implement parsing overflow section header..
Tue, Oct 8, 10:21 PM · Restricted Project
hubert.reinterpretcast added inline comments to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.
Tue, Oct 8, 9:59 PM · Restricted Project
hubert.reinterpretcast accepted D68650: [AIX][XCOFF][NFC] Change the SectionLen field name of CSect Auxiliary entry to SectionOrLength..

LGTM. Thanks again.

Tue, Oct 8, 2:52 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Tue, Oct 8, 10:26 AM · Restricted Project
hubert.reinterpretcast added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Tue, Oct 8, 9:34 AM · Restricted Project
hubert.reinterpretcast added a comment to D68650: [AIX][XCOFF][NFC] Change the SectionLen field name of CSect Auxiliary entry to SectionOrLength..

Thanks @DiggerLin. Just minor comments.

Tue, Oct 8, 9:13 AM · Restricted Project
hubert.reinterpretcast added inline comments to D68575: [llvm-readobj][xcoff] implement parsing overflow section header..
Tue, Oct 8, 8:35 AM · Restricted Project

Mon, Oct 7

hubert.reinterpretcast added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Mon, Oct 7, 7:25 PM · Restricted Project
hubert.reinterpretcast added inline comments to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.
Mon, Oct 7, 7:15 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Mon, Oct 7, 4:22 PM · Restricted Project
hubert.reinterpretcast added a comment to D67882: [LNT] Python 3 support: remove useless var-setting getter.

I think we should make LNT Python 3 only as soon as it can work in that mode, so the less compability code we can add the better. Do you agree with that approach?

Mon, Oct 7, 8:21 AM
hubert.reinterpretcast added a comment to D68472: [test] Use system locale for mri-utf8.test.

Thanks for adding the BOM. With the BOM, would it make sense to leave mri-utf8.test as the name of the file?

Mon, Oct 7, 8:13 AM · Restricted Project
hubert.reinterpretcast added a comment to D67879: [LNT] Python 3 support: import object when inheriting from it.

My understanding is that this patch has no effect for Python 3. In Python 2, object from builtins (as provided by the future package) is used to enable use of some Python 3 coding patterns. Absent further changes that make use of such enablement, I am not sure that this patch is necessary. If this patch is needed to support later patches, then I suggest applying the fixer at that point. Applying the fixer before applying D67882 seems odd anyway.

Mon, Oct 7, 7:55 AM
hubert.reinterpretcast added inline comments to D68472: [test] Use system locale for mri-utf8.test.
Mon, Oct 7, 6:47 AM · Restricted Project
hubert.reinterpretcast added a comment to D67882: [LNT] Python 3 support: remove useless var-setting getter.

Perhaps others are more well-versed in this than I am, but I think that having a link in the commit message and using the terminology used by the documentation ("new-style" and "classic") would be useful here: https://docs.python.org/2/reference/datamodel.html#newstyle. Also, I am not sure that switching these to be new-style classes in Python 2 is necessary. I believe the commit message should give additional rationale, e.g., using new-style classes helps make the Python 2 and Python 3 behaviour of the code more similar.

Mon, Oct 7, 6:09 AM

Sun, Oct 6

hubert.reinterpretcast added inline comments to D68104: [LNT] Python 3 support: adapt secret computation.
Sun, Oct 6, 2:54 PM

Sat, Oct 5

hubert.reinterpretcast accepted D68126: [LNT] Python 3 support: update dependencies.

LGTM.

Sat, Oct 5, 2:24 PM · Restricted Project
hubert.reinterpretcast accepted D68224: [LNT] Python 3 support: fix text/binary confusion in importreport.

LGTM.

Sat, Oct 5, 1:48 PM · Restricted Project
hubert.reinterpretcast accepted D68221: [LNT] Python 3 support: stable profile getFunctions output.

LGTM.

Sat, Oct 5, 1:48 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68472: [test] Use system locale for mri-utf8.test.
Sat, Oct 5, 7:58 AM · Restricted Project

Fri, Oct 4

hubert.reinterpretcast added a comment to D68472: [test] Use system locale for mri-utf8.test.

I believe that's because it is a builtin locale (much like the C locale). There wasn't one in /usr/share/locale on the Ubuntu docker image I've tested this but it did work while trying with en_US.UTF-8 did not.

Fri, Oct 4, 3:28 PM · Restricted Project
hubert.reinterpretcast added a comment to D68472: [test] Use system locale for mri-utf8.test.

There's an en_US.UTF-8 on "my" AIX box and an en_US.utf8 on "my" RHEL 7 box. There's no "C" UTF-8 locale anywhere in sight.

Fri, Oct 4, 12:00 PM · Restricted Project

Thu, Oct 3

hubert.reinterpretcast accepted D68222: [LNT] Python 3 support: fix text/binary confusion in profile support.

LGTM.

Thu, Oct 3, 8:22 AM · Restricted Project
hubert.reinterpretcast accepted D68223: [LNT] Python 3 support: fix convert to JSON.

LGTM.

Thu, Oct 3, 8:03 AM · Restricted Project
hubert.reinterpretcast committed rL373608: [LNT] NFC: Remove comment made outdated by rL373218.
[LNT] NFC: Remove comment made outdated by rL373218
Thu, Oct 3, 7:54 AM

Wed, Oct 2

hubert.reinterpretcast accepted D68336: [NFC] Replace 'isDarwin' with 'IsDarwin' based on LLVM naming convention.

LGTM. New declarations of IsDarwin in this patch are in contexts where there is no existing reference to any IsDarwin that might have been in scope.

Wed, Oct 2, 8:20 AM · Restricted Project

Mon, Sep 30

hubert.reinterpretcast added inline comments to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.
Mon, Sep 30, 3:35 PM · Restricted Project
hubert.reinterpretcast accepted D68225: [LNT] Python 3 support: encode LNT report format in UTF-8.

LGTM.

Mon, Sep 30, 7:53 AM · Restricted Project
hubert.reinterpretcast added a comment to D68220: [LNT] Python 3 support: stable showtests output.

My general impression is that this is harmless. As it is, there is no other key available to sort on. @cmatthews, can you confirm?

Mon, Sep 30, 7:53 AM

Sun, Sep 29

hubert.reinterpretcast added inline comments to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.
Sun, Sep 29, 8:33 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Sun, Sep 29, 6:00 AM · Restricted Project

Sat, Sep 28

hubert.reinterpretcast accepted D68097: [LNT] Remove dead code.

LGTM.

Sat, Sep 28, 3:43 PM · Restricted Project
hubert.reinterpretcast added a comment to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Just following up on my previous comments on this patch based on developments in D66969.

Sat, Sep 28, 1:46 PM · Restricted Project
hubert.reinterpretcast added a comment to D66969: Output XCOFF object text section header and symbol entry for program code.

we can not generate a raw data of the '.text" XCOFF section.
there are upcoming patch which deal with the DS csect , I think we will add the test in that patch @jasonliu.

Sat, Sep 28, 1:37 PM · Restricted Project

Fri, Sep 27

hubert.reinterpretcast added a comment to D68115: Zero initialize padding in unions.

I would be happy to update the patch to enable it only for -ftrivial-auto-var-init=pattern, if we want "bumper" version.

It seems to be a separable feature (although it does interact with -ftrivial-auto-init=pattern). That option also provides guardrails for non-unions, and "bumper guardrails" for unions can be a useful feature without the non-union guardrails.

Fri, Sep 27, 8:55 PM · Restricted Project
hubert.reinterpretcast added a comment to D68115: Zero initialize padding in unions.
In D68115#1686837, @jfb wrote:

The entire point of this feature is to add guardrails to the language.

I agree, and guardrails have a tendency to scratch paint if one drives against them.

Fri, Sep 27, 8:01 PM · Restricted Project
hubert.reinterpretcast accepted D67820: [LNT] Python 3 support: get rid of calls to cmp builtin.

LGTM.

Fri, Sep 27, 7:21 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68115: Zero initialize padding in unions.
Fri, Sep 27, 6:20 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68115: Zero initialize padding in unions.
Fri, Sep 27, 4:42 PM · Restricted Project
hubert.reinterpretcast committed rL373129: [LNT] Sort machines by ID as expected by test case.
[LNT] Sort machines by ID as expected by test case
Fri, Sep 27, 2:55 PM
hubert.reinterpretcast closed D67884: [LNT] Sort machines by ID as expected by test case.
Fri, Sep 27, 2:55 PM · Restricted Project
hubert.reinterpretcast added a comment to D67884: [LNT] Sort machines by ID as expected by test case.

Alternatively the test could use -DAG directives. But I do think sorting is nicer as it's easier to find a machine in a long list and doing it on the server side sounds sensible to me. I'll let Chris have the last word though.

Fri, Sep 27, 11:13 AM · Restricted Project

Thu, Sep 26

hubert.reinterpretcast added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Thu, Sep 26, 10:03 PM · Restricted Project
hubert.reinterpretcast added inline comments to D68115: Zero initialize padding in unions.
Thu, Sep 26, 8:39 PM · Restricted Project
hubert.reinterpretcast added a comment to D67853: [PowerPC][XCOFF] Fix expansion of LWZtoc Pseudo for AIX..

Thanks for the explanation Hubert. I've updated the comments and committed.

Thu, Sep 26, 9:39 AM · Restricted Project
hubert.reinterpretcast accepted D66724: [AIX]Emit function descriptor csect in assembly.

LGTM. Thanks.

Thu, Sep 26, 8:48 AM · Restricted Project

Wed, Sep 25

hubert.reinterpretcast added inline comments to D66724: [AIX]Emit function descriptor csect in assembly.
Wed, Sep 25, 7:43 PM · Restricted Project
hubert.reinterpretcast added inline comments to D67853: [PowerPC][XCOFF] Fix expansion of LWZtoc Pseudo for AIX..
Wed, Sep 25, 10:37 AM · Restricted Project
hubert.reinterpretcast added a comment to D66969: Output XCOFF object text section header and symbol entry for program code.

I might have more comments later, but I'm posting what I have currently.

Wed, Sep 25, 9:31 AM · Restricted Project

Tue, Sep 24

hubert.reinterpretcast accepted D67820: [LNT] Python 3 support: get rid of calls to cmp builtin.

LGTM with suggestion for a minor drive-by typo correction.

Tue, Sep 24, 8:49 PM · Restricted Project
hubert.reinterpretcast accepted D67819: [LNT] Python 3 support: adapt to zip returning an iterator.

LGTM with suggestion to update commit message.

Tue, Sep 24, 8:49 PM
hubert.reinterpretcast accepted D67817: [LNT] Python 3 support: adapt to map returning an iterator.

LGTM with comments on further changes that could be made.

Tue, Sep 24, 8:49 PM · Restricted Project
hubert.reinterpretcast accepted D67967: [LNT] rename object variables.

LGTM.

Tue, Sep 24, 8:49 PM · Restricted Project
hubert.reinterpretcast accepted D67814: [LNT] Python 3 support: adapt to dict method returning views.

LGTM.

Tue, Sep 24, 8:49 PM · Restricted Project
hubert.reinterpretcast accepted D67959: [LNT] Simplify population of alldata in lF_oneway.

LGTM.

Tue, Sep 24, 7:07 PM
hubert.reinterpretcast added inline comments to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.
Tue, Sep 24, 6:58 PM · Restricted Project
hubert.reinterpretcast added inline comments to D66724: [AIX]Emit function descriptor csect in assembly.
Tue, Sep 24, 3:40 PM · Restricted Project
hubert.reinterpretcast added inline comments to D67853: [PowerPC][XCOFF] Fix expansion of LWZtoc Pseudo for AIX..
Tue, Sep 24, 2:14 PM · Restricted Project

Mon, Sep 23

hubert.reinterpretcast added inline comments to D67814: [LNT] Python 3 support: adapt to dict method returning views.
Mon, Sep 23, 8:38 AM · Restricted Project
hubert.reinterpretcast added inline comments to D67817: [LNT] Python 3 support: adapt to map returning an iterator.
Mon, Sep 23, 7:46 AM · Restricted Project
hubert.reinterpretcast added inline comments to D67817: [LNT] Python 3 support: adapt to map returning an iterator.
Mon, Sep 23, 7:28 AM · Restricted Project
hubert.reinterpretcast accepted D67818: [LNT] Python 3 support: adapt to renaming of raw_input to input.

LGTM.

Mon, Sep 23, 6:34 AM

Sat, Sep 21

hubert.reinterpretcast accepted D67811: [LNT] Python 3 support: Use absolute import by default.

LGTM.

Sat, Sep 21, 9:15 PM · Restricted Project
hubert.reinterpretcast accepted D67878: [LNT] Python 3 support: use Python 3 urllib.

LGTM.

Sat, Sep 21, 3:50 PM
hubert.reinterpretcast added inline comments to D67818: [LNT] Python 3 support: adapt to renaming of raw_input to input.
Sat, Sep 21, 3:47 PM