- User Since
- Aug 27 2014, 8:34 PM (260 w, 1 d)
Looking through this latest version still (this is a largish patch).
A few small changes, but otherwise LGTM.
I'm not seeing unresolved comments. This patch LGTM.
Wed, Aug 21
Tue, Aug 20
It is possible to build with Clang and libc++ and not use a newer version of binutils for trunk.
Is this the use case this patch is intended to fix?
Related to the 32-bit vs 64-bit naming and assertions: I can appreciate being defensive about this, but I think trying to disable being able to create the various types and having an assertion (or error) in every function is overkill.
This patch LGTM.
Mon, Aug 19
Sun, Aug 18
Sat, Aug 17
Fri, Aug 16
Thu, Aug 15
Wed, Aug 14
Fix spelling error
Address comments: Split large GCC-compatible options block
Tue, Aug 13
I am still working through this version, but I think this might need another pass on an updated copy.
My attempt to commit this only committed the test. I'll try again once the bots clear.
Mon, Aug 12
LGTM with a minor issue that can be fixed on check-in.
@Xiangling_L, I'd be happy to work with you on this off-list to move this along.
Fri, Aug 9
Wed, Aug 7
Tue, Aug 6
This patch needs a rebase. It no longer applies cleanly.
Mon, Aug 5
Sun, Aug 4
Addrew review comments: Output and check the byte values only
Sat, Aug 3
I've requested the change, but I cannot make any promises on delivery vehicle.
I've answered the question asked in rL363829.