Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (230 w, 8 h)

Recent Activity

Thu, Jan 17

hubert.reinterpretcast added inline comments to D56819: Document toolchain update policy.
Thu, Jan 17, 8:08 PM
hubert.reinterpretcast added inline comments to D56819: Document toolchain update policy.
Thu, Jan 17, 7:58 PM
hubert.reinterpretcast added inline comments to D56819: Document toolchain update policy.
Thu, Jan 17, 3:34 PM
hubert.reinterpretcast added inline comments to D56819: Document toolchain update policy.
Thu, Jan 17, 2:01 PM

Wed, Jan 9

hubert.reinterpretcast committed rL350735: [unittests][Support] AIX: Skip sticky bit file tests.
[unittests][Support] AIX: Skip sticky bit file tests
Wed, Jan 9, 8:04 AM

Dec 12 2018

hubert.reinterpretcast committed rC348938: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element….
[ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element…
Dec 12 2018, 8:58 AM
hubert.reinterpretcast committed rL348938: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element….
[ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element…
Dec 12 2018, 8:58 AM
hubert.reinterpretcast closed D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.
Dec 12 2018, 8:57 AM
hubert.reinterpretcast updated the summary of D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.
Dec 12 2018, 8:49 AM

Dec 11 2018

hubert.reinterpretcast added inline comments to D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.
Dec 11 2018, 6:07 PM
hubert.reinterpretcast updated the diff for D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.

Recast representation-sensitive tests as SemaCXX tests using array bounds

Dec 11 2018, 3:47 PM

Dec 10 2018

hubert.reinterpretcast added a comment to D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.

I'll update the tests to be in terms of constant/variable array length tomorrow. I think I've gotten through the rest of the comments.

Dec 10 2018, 9:05 PM
hubert.reinterpretcast updated the diff for D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.

Address remaining ExprConstant.cpp review comments

Dec 10 2018, 8:57 PM
hubert.reinterpretcast added inline comments to D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.
Dec 10 2018, 4:39 PM
hubert.reinterpretcast updated the diff for D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.

Use lvalue designator, add assertions for type matching

Dec 10 2018, 4:38 PM
hubert.reinterpretcast added inline comments to D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.
Dec 10 2018, 2:45 PM
hubert.reinterpretcast updated the diff for D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.

Make an initial pass at addressing the review comments

Dec 10 2018, 2:45 PM
hubert.reinterpretcast created D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types.
Dec 10 2018, 6:29 AM

Nov 14 2018

hubert.reinterpretcast accepted D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.

LGTM.

Nov 14 2018, 7:17 PM

Nov 13 2018

hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Nov 13 2018, 7:49 AM

Nov 12 2018

hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Nov 12 2018, 7:51 PM

Nov 8 2018

hubert.reinterpretcast added a comment to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.

some test points check the error report for ambiguous call because of too many implicit cast choices from ext_vector_type to vector type.

It appears the answer is to update these tests and remove the restriction on the type class.

Nov 8 2018, 9:01 PM
hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Nov 8 2018, 11:38 AM

Nov 4 2018

hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Nov 4 2018, 9:44 AM

Nov 1 2018

hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Nov 1 2018, 6:15 AM

Oct 26 2018

hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 26 2018, 10:37 AM
hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 26 2018, 10:21 AM

Oct 25 2018

hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 25 2018, 10:22 PM
hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 25 2018, 7:55 PM
hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 25 2018, 8:26 AM

Oct 19 2018

hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 19 2018, 7:47 PM
hubert.reinterpretcast requested changes to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 19 2018, 7:04 PM
hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 19 2018, 2:00 PM
hubert.reinterpretcast added inline comments to D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error.
Oct 19 2018, 6:51 AM

Aug 16 2018

hubert.reinterpretcast committed rL339969: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.
[libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback
Aug 16 2018, 4:57 PM
hubert.reinterpretcast committed rCXX339969: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.
[libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback
Aug 16 2018, 4:57 PM
hubert.reinterpretcast closed D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.
Aug 16 2018, 4:57 PM
hubert.reinterpretcast updated subscribers of D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.

I can commit sometime today; thanks.

Aug 16 2018, 10:32 AM

Aug 15 2018

hubert.reinterpretcast updated the diff for D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.

Address review comments by Marshall

Aug 15 2018, 3:01 PM
hubert.reinterpretcast added a comment to D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.

Is this test that's being added libc++ specific, or would it apply to other implementations as well?

The test can apply to other implementations as well (although I am not sure how the initializer_list include behaves under C++03 on other implementations). Is there some other place to put such tests?

It seems that test/std/numerics/rand/rand.eng/rand.eng.mers/ may be the place to add the test. I am looking into it.

Aug 15 2018, 2:40 PM
hubert.reinterpretcast added a comment to D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.

Is this test that's being added libc++ specific, or would it apply to other implementations as well?

The test can apply to other implementations as well (although I am not sure how the initializer_list include behaves under C++03 on other implementations). Is there some other place to put such tests?

Aug 15 2018, 9:11 AM

Aug 14 2018

hubert.reinterpretcast created D50736: [libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback.
Aug 14 2018, 1:53 PM

Aug 1 2018

hubert.reinterpretcast added inline comments to D50055: Update the coding standard about NFC changes and whitespace.
Aug 1 2018, 2:29 PM

Mar 21 2018

hubert.reinterpretcast added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Mar 21 2018, 3:51 PM

Mar 16 2018

hubert.reinterpretcast added inline comments to D41217: [Concepts] Concept Specialization Expressions.
Mar 16 2018, 7:35 PM

Jan 9 2018

hubert.reinterpretcast committed rL322114: Profiling tests: Endianess XFAIL for powerpc- (32-bit).
Profiling tests: Endianess XFAIL for powerpc- (32-bit)
Jan 9 2018, 12:10 PM

Jan 4 2018

hubert.reinterpretcast committed rC321830: Use POSIX argument syntax in test rewrite-includes-messages.c.
Use POSIX argument syntax in test rewrite-includes-messages.c
Jan 4 2018, 3:05 PM
hubert.reinterpretcast committed rL321830: Use POSIX argument syntax in test rewrite-includes-messages.c.
Use POSIX argument syntax in test rewrite-includes-messages.c
Jan 4 2018, 3:05 PM
hubert.reinterpretcast committed rL321828: Use backslash escape, replacing xargs -0 in test macro-multiline.c.
Use backslash escape, replacing xargs -0 in test macro-multiline.c
Jan 4 2018, 2:59 PM
hubert.reinterpretcast committed rC321828: Use backslash escape, replacing xargs -0 in test macro-multiline.c.
Use backslash escape, replacing xargs -0 in test macro-multiline.c
Jan 4 2018, 2:59 PM
hubert.reinterpretcast closed D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c.
Jan 4 2018, 2:59 PM

Jan 3 2018

hubert.reinterpretcast committed rC321778: Replace cp -a in various Clang tests.
Replace cp -a in various Clang tests
Jan 3 2018, 5:17 PM
hubert.reinterpretcast committed rL321778: Replace cp -a in various Clang tests.
Replace cp -a in various Clang tests
Jan 3 2018, 5:17 PM
hubert.reinterpretcast closed D41545: Replace cp -a in various Clang tests.
Jan 3 2018, 5:16 PM
hubert.reinterpretcast updated the summary of D41545: Replace cp -a in various Clang tests.
Jan 3 2018, 5:12 PM
hubert.reinterpretcast updated the diff for D41545: Replace cp -a in various Clang tests.

Use cp -R, which is sufficient instead of cp -RPp

Jan 3 2018, 5:10 PM

Jan 2 2018

hubert.reinterpretcast added a comment to D41545: Replace cp -a in various Clang tests.

I'll commit with cp -R tomorrow then; thanks.

Jan 2 2018, 6:45 PM

Dec 29 2017

hubert.reinterpretcast added a comment to D41545: Replace cp -a in various Clang tests.

Maybe cp -R is sufficient? cp -RPp was the just-to-be-safe "minimal change".

Dec 29 2017, 10:43 AM
hubert.reinterpretcast added a comment to D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c.

Ping

Dec 29 2017, 10:41 AM

Dec 22 2017

hubert.reinterpretcast created D41545: Replace cp -a in various Clang tests.
Dec 22 2017, 9:21 AM
hubert.reinterpretcast created D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c.
Dec 22 2017, 9:03 AM

Dec 6 2017

hubert.reinterpretcast committed rL319992: Remove old concepts parsing code.
Remove old concepts parsing code
Dec 6 2017, 4:35 PM
hubert.reinterpretcast committed rC319992: Remove old concepts parsing code.
Remove old concepts parsing code
Dec 6 2017, 4:35 PM
hubert.reinterpretcast closed D40380: Remove old concepts parsing code by committing rC319992: Remove old concepts parsing code.
Dec 6 2017, 4:34 PM

Dec 4 2017

hubert.reinterpretcast accepted D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26.

Looks good to me.

Dec 4 2017, 1:04 PM · Restricted Project

Dec 1 2017

hubert.reinterpretcast added inline comments to D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26.
Dec 1 2017, 2:41 PM · Restricted Project

Nov 30 2017

hubert.reinterpretcast added inline comments to D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26.
Nov 30 2017, 2:26 PM · Restricted Project

Nov 25 2017

hubert.reinterpretcast added inline comments to D40381: Parse concept definition.
Nov 25 2017, 9:18 PM

Nov 24 2017

hubert.reinterpretcast added inline comments to D40381: Parse concept definition.
Nov 24 2017, 8:00 AM
hubert.reinterpretcast added inline comments to D40381: Parse concept definition.
Nov 24 2017, 6:33 AM

Jun 30 2017

hubert.reinterpretcast committed rL306905: Fix PR 33189: Clang assertion on template destructor declaration.
Fix PR 33189: Clang assertion on template destructor declaration
Jun 30 2017, 3:44 PM
hubert.reinterpretcast closed D33833: Fix PR 33189: Clang assertion on template destructor declaration.
Jun 30 2017, 3:44 PM
hubert.reinterpretcast updated the summary of D33833: Fix PR 33189: Clang assertion on template destructor declaration.
Jun 30 2017, 3:33 PM

Jun 23 2017

hubert.reinterpretcast added a comment to D33833: Fix PR 33189: Clang assertion on template destructor declaration.

Can we get this patch reviewed by any chance?

@kuang_he; it is customary to "ping". In this case, "Ping 2".

Jun 23 2017, 3:38 PM

Jun 2 2017

hubert.reinterpretcast added inline comments to D33833: Fix PR 33189: Clang assertion on template destructor declaration.
Jun 2 2017, 4:24 PM
hubert.reinterpretcast retitled D33833: Fix PR 33189: Clang assertion on template destructor declaration from Fix Clang assertion on template destructor declaration to Fix PR 33189: Clang assertion on template destructor declaration.
Jun 2 2017, 4:21 PM

May 19 2017

hubert.reinterpretcast committed rL303472: Fix valid-for-expr ellipses eaten as invalid decl.
Fix valid-for-expr ellipses eaten as invalid decl
May 19 2017, 5:35 PM
hubert.reinterpretcast closed D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 19 2017, 5:35 PM
hubert.reinterpretcast updated the summary of D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 19 2017, 3:17 PM
hubert.reinterpretcast updated the diff for D33339: Fix valid-for-expr ellipses eaten as invalid decl.

Remove stray ellipsis treatment entirely

May 19 2017, 3:14 PM
hubert.reinterpretcast added a comment to D33339: Fix valid-for-expr ellipses eaten as invalid decl.

The check-all target passes even if the ellipsis-after-declarator-id disambiguation as a declarator is removed entirely.

[...]

So, on the whole, the stray ellipsis treatment is both too complicated and not complicated enough.

I think if we want to keep it, the way to do that would be to carry on through the disambiguation process and treat it as a tiebreaker (that's what we do, for instance, if we see an undeclared identifier in a position where we're looking for a type). I'm not convinced that's worthwhile, especially since our existing testcases do not need this disambiguation rule, but perhaps we could remove the stray ellipsis treatment entirely for now and reconsider adding it back if we find poor diagnostics result from it later?

May 19 2017, 1:21 PM

May 18 2017

hubert.reinterpretcast added a comment to D33339: Fix valid-for-expr ellipses eaten as invalid decl.

Should I assume our "misplaced ellipsis" diagnostic requires that we disambiguate the ill-formed ellipsis-after-declarator-id as a declarator in some cases? If so, do we have tests for that somewhere?

Tests for the diagnostics are in clang/test/FixIt/fixit-cxx0x.cpp and clang/test/Parser/cxx11-templates.cpp.
The check-all target passes even if the ellipsis-after-declarator-id disambiguation as a declarator is removed entirely. The disambiguation process is not needed in many cases, and—when it is—can choose the declarative interpretation for other reasons.

May 18 2017, 9:01 PM
hubert.reinterpretcast added inline comments to D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 18 2017, 2:59 PM
hubert.reinterpretcast created D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 18 2017, 2:28 PM

Apr 30 2017

hubert.reinterpretcast added a comment to D32378: Insert invariant.group.barrier for pointers comparisons.

Has it been discussed whether this is something to be addressed in the optimizer as opposed to the front-end?

Apr 30 2017, 8:38 PM

Feb 9 2017

hubert.reinterpretcast added inline comments to D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas..
Feb 9 2017, 7:25 PM · Restricted Project
hubert.reinterpretcast committed rL294697: [Concepts] Class template associated constraints.
[Concepts] Class template associated constraints
Feb 9 2017, 6:57 PM
hubert.reinterpretcast closed D25674: [Concepts] Class template associated constraints.
Feb 9 2017, 6:57 PM
hubert.reinterpretcast updated the diff for D25674: [Concepts] Class template associated constraints.

Address review comments; update to revision 294580

Feb 9 2017, 12:04 PM

Feb 8 2017

hubert.reinterpretcast added inline comments to D25674: [Concepts] Class template associated constraints.
Feb 8 2017, 4:34 PM
hubert.reinterpretcast added a comment to D25674: [Concepts] Class template associated constraints.

Ping 2?

Feb 8 2017, 2:47 PM

Feb 1 2017

hubert.reinterpretcast added a comment to D25674: [Concepts] Class template associated constraints.

Ping!

Feb 1 2017, 11:23 AM

Jan 25 2017

hubert.reinterpretcast added inline comments to D25674: [Concepts] Class template associated constraints.
Jan 25 2017, 7:25 AM
hubert.reinterpretcast updated the diff for D25674: [Concepts] Class template associated constraints.

Address review comments; update to revision 292996

Jan 25 2017, 7:10 AM

Dec 1 2016

hubert.reinterpretcast added inline comments to D26817: [APFloat] Implement PPCDoubleDouble add and subtract..
Dec 1 2016, 10:29 AM

Nov 21 2016

hubert.reinterpretcast committed rL287583: reassociate-deadinst.ll: avoid accidental match on path.
reassociate-deadinst.ll: avoid accidental match on path
Nov 21 2016, 2:02 PM

Nov 20 2016

hubert.reinterpretcast added inline comments to D26882: Refactor how FunctionDecl handles constexpr:.
Nov 20 2016, 5:13 PM

Oct 24 2016

hubert.reinterpretcast added a comment to D25674: [Concepts] Class template associated constraints.

Friendly ping...

Oct 24 2016, 11:26 AM

Oct 22 2016

hubert.reinterpretcast added inline comments to D25674: [Concepts] Class template associated constraints.
Oct 22 2016, 7:33 PM

Oct 17 2016

hubert.reinterpretcast retitled D25674: [Concepts] Class template associated constraints from to [Concepts] Class template associated constraints.
Oct 17 2016, 6:34 AM