Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (242 w, 1 d)

Recent Activity

Wed, Apr 17

hubert.reinterpretcast added inline comments to D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
Wed, Apr 17, 9:30 PM · Restricted Project

Mon, Apr 15

hubert.reinterpretcast added a comment to D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected .

Part of me thinks this is bad -- if the version of glibc is old, then the host toolchain should just upgrade it. glibc 2.23 was released in 2016-02-19, so I think using something older than that is on the border of being called "not a modern c++ toolchain".

We talk of needing a "modern C++ toolchain" for building the project; however, in the case of compiler_rt_logb_test, we are talking not of the build environment, but rather the supporting libraries on a system where compiler-rt may be deployed. Perhaps the tests are currently set up to run in the build environment, but is not a stretch to imagine that the tests can be run as part of an installer for deploying the build.

Mon, Apr 15, 8:46 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected .

In terms of qdiv_test and divsc3_test, do you think checking perhaps checking the version of GCC is a more suitable fix?

The current pattern being used in the patch reports tests as passing when failures are being suppressed. An approach using XFAIL (based on the GCC version used to build compiler-rt) would be more suitable. The failure should also be filed as a bug (and the bug mentioned when adding the XFAIL) since the affected version of GCC is still currently supported as a build compiler (albeit deprecated). I am not sure if there is any motivation to really fix said bug; but, if there is no such motivation, then I also question the motivation behind building with the affected version of GCC and the motivation for suppressing the failures when such a build is done. In other words, if your goal is to build with a compiler that causes these test failures, then what needs to be done in the end is to implement a workaround in the compiler-rt source (and not the tests) for the build compiler problem. If people are happy to just avoid building with the affected version of GCC, then I think it makes sense to just leave these two tests alone.

Mon, Apr 15, 8:32 PM · Restricted Project, Restricted Project

Sat, Apr 13

hubert.reinterpretcast requested changes to D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected .

There may be different levels of failures in play:

  • Correct compiler-rt behaviour with:
    • Bad build environment for the test: Building the test against a compatible newer toolchain and the same compiler-rt would result in passing behaviour.
    • Bad run environment for the test: In this case, deploying the test executable to a system with sufficiently new runtime libraries would result in passing behaviour.
  • Incorrect compiler-rt behaviour due to a bad build environment: In this case, the test executable will intrinsically fail.
Sat, Apr 13, 6:37 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected .

@amyk; the patch as posted is missing context lines. Please refer to http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.

Sat, Apr 13, 2:42 PM · Restricted Project, Restricted Project

Wed, Apr 10

hubert.reinterpretcast created D60553: [lit][tests][AIX] Update expected form of diagnostic messages; use `not` to normalize non-zero exit values.
Wed, Apr 10, 7:38 PM · Restricted Project
hubert.reinterpretcast created D60551: [tests] Add host-byteorder-*-endian; update XFAILs of big-endian triples.
Wed, Apr 10, 6:53 PM · Restricted Project

Fri, Apr 5

hubert.reinterpretcast added a comment to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

@pjeeva01, please post the delta assuming a base that has D60211 incorporated.

Fri, Apr 5, 2:25 PM · Restricted Project
hubert.reinterpretcast added a comment to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

As I understand it compiler-rt is built by make/ninja from CMake derived files so CMake only features such as CMAKE_C(XX)_EXTERNAL_TOOLCHAIN and CMAKE_SYSROOT will affect the make/ninja build files. The tests are run by llvm-lit so we wouldn't expect CMake only features to affect the output unless we convert them to something llvm-lit understands. We've also got a situation where cross-compiling and native tests have different options available to them:

  • Cross compiled test runs can use COMPILER_RT_TEST_COMPILER_CFLAGS to pass in --gcc-toolchain=... --sysroot=... duplicating any use of CMAKE_C(XX)_EXTERNAL_TOOLCHAIN and CMAKE_SYSROOT, but at least it is possible.

That is also my understanding. I also believe that it is working sufficiently today for people using such configurations, or at least sufficiently so that improving the situation was not seen as being urgent.

Fri, Apr 5, 2:11 PM · Restricted Project, Restricted Project

Thu, Apr 4

hubert.reinterpretcast added inline comments to D60291: [llvm] Add isa_and_nonnull.
Thu, Apr 4, 4:27 PM · Restricted Project

Wed, Apr 3

hubert.reinterpretcast updated the summary of D60143: [compiler-rt][tests] Propagate COMPILER_RT_UNITTEST_LINK_FLAGS.
Wed, Apr 3, 7:34 PM · Restricted Project, Restricted Project
hubert.reinterpretcast committed rGab2eb2bfacb4: [XCOFF] Add functionality for parsing AIX XCOFF object file headers (authored by hubert.reinterpretcast).
[XCOFF] Add functionality for parsing AIX XCOFF object file headers
Wed, Apr 3, 5:54 PM
hubert.reinterpretcast committed rL357663: [XCOFF] Add functionality for parsing AIX XCOFF object file headers.
[XCOFF] Add functionality for parsing AIX XCOFF object file headers
Wed, Apr 3, 5:54 PM
hubert.reinterpretcast closed D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .
Wed, Apr 3, 5:54 PM · Restricted Project
hubert.reinterpretcast committed rG7f8b3bf24756: [Support] On AIX, Check ENOTSUP on posix_fallocate instead of EOPNOTSUPP (authored by hubert.reinterpretcast).
[Support] On AIX, Check ENOTSUP on posix_fallocate instead of EOPNOTSUPP
Wed, Apr 3, 5:41 PM
hubert.reinterpretcast committed rL357662: [Support] On AIX, Check ENOTSUP on posix_fallocate instead of EOPNOTSUPP.
[Support] On AIX, Check ENOTSUP on posix_fallocate instead of EOPNOTSUPP
Wed, Apr 3, 5:40 PM
hubert.reinterpretcast closed D60175: [Support] On AIX, Check ENOTSUP on posix_fallocate instead of EOPNOTSUPP.
Wed, Apr 3, 5:40 PM · Restricted Project
hubert.reinterpretcast committed rG844a02e509a4: [AIX] SelectionDAGNodes.h: Pack bit-fields that are meant to be packed (authored by hubert.reinterpretcast).
[AIX] SelectionDAGNodes.h: Pack bit-fields that are meant to be packed
Wed, Apr 3, 5:33 PM
hubert.reinterpretcast committed rL357661: [AIX] SelectionDAGNodes.h: Pack bit-fields that are meant to be packed.
[AIX] SelectionDAGNodes.h: Pack bit-fields that are meant to be packed
Wed, Apr 3, 5:33 PM
hubert.reinterpretcast closed D60164: [AIX] SelectionDAGNodes.h: Pack bit-fields that are meant to be packed.
Wed, Apr 3, 5:33 PM · Restricted Project
hubert.reinterpretcast accepted D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .

@DiggerLin; as discussed off-list, I'll commit this for you with the additional change to include <string.h>.

Wed, Apr 3, 10:45 AM · Restricted Project

Tue, Apr 2

hubert.reinterpretcast created D60175: [Support] On AIX, Check ENOTSUP on posix_fallocate instead of EOPNOTSUPP.
Tue, Apr 2, 8:27 PM · Restricted Project
hubert.reinterpretcast created D60164: [AIX] SelectionDAGNodes.h: Pack bit-fields that are meant to be packed.
Tue, Apr 2, 4:20 PM · Restricted Project
hubert.reinterpretcast added inline comments to D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .
Tue, Apr 2, 12:06 PM · Restricted Project
hubert.reinterpretcast added a parent revision for D58951: [compiler-rt][tests] Improve handling with non-default toolchains: D60143: [compiler-rt][tests] Propagate COMPILER_RT_UNITTEST_LINK_FLAGS.
Tue, Apr 2, 11:37 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added a child revision for D60143: [compiler-rt][tests] Propagate COMPILER_RT_UNITTEST_LINK_FLAGS: D58951: [compiler-rt][tests] Improve handling with non-default toolchains.
Tue, Apr 2, 11:37 AM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the summary of D58951: [compiler-rt][tests] Improve handling with non-default toolchains.
Tue, Apr 2, 11:37 AM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the diff for D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

Split changes for COMPILER_RT_UNITTEST_LINK_FLAGS out to D60143

Tue, Apr 2, 11:23 AM · Restricted Project, Restricted Project
hubert.reinterpretcast created D60143: [compiler-rt][tests] Propagate COMPILER_RT_UNITTEST_LINK_FLAGS.
Tue, Apr 2, 11:18 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

If I've understood this correctly the patch introduces COMPILER_RT_TOOLCHAIN_CFLAGS which we don't expect users to set directly, but instead set -gcc-toolchain if the compiler is clang and CMAKE_CXX_COMPILER_EXTERNAL_TOOLCHAIN is set?

Yes.

Tue, Apr 2, 10:29 AM · Restricted Project, Restricted Project

Mon, Apr 1

hubert.reinterpretcast added inline comments to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.
Mon, Apr 1, 6:17 PM · Restricted Project, Restricted Project

Fri, Mar 29

hubert.reinterpretcast committed rG5dc6a732e6eb: [lit] Set shlibpath_var on AIX (authored by hubert.reinterpretcast).
[lit] Set shlibpath_var on AIX
Fri, Mar 29, 4:32 PM
hubert.reinterpretcast committed rG24168852e8b5: [Support] Implement is_local_impl with AIX mntctl (authored by hubert.reinterpretcast).
[Support] Implement is_local_impl with AIX mntctl
Fri, Mar 29, 4:32 PM
hubert.reinterpretcast committed rL357334: [lit] Set shlibpath_var on AIX.
[lit] Set shlibpath_var on AIX
Fri, Mar 29, 4:32 PM
hubert.reinterpretcast committed rC357334: [lit] Set shlibpath_var on AIX.
[lit] Set shlibpath_var on AIX
Fri, Mar 29, 4:32 PM
hubert.reinterpretcast closed D59741: [lit] Set shlibpath_var on AIX.
Fri, Mar 29, 4:32 PM · Restricted Project
hubert.reinterpretcast committed rL357333: [Support] Implement is_local_impl with AIX mntctl.
[Support] Implement is_local_impl with AIX mntctl
Fri, Mar 29, 4:32 PM
hubert.reinterpretcast closed D58801: [Support] Implement is_local_impl with AIX mntctl.
Fri, Mar 29, 4:32 PM · Restricted Project
hubert.reinterpretcast accepted D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .

LGTM with minor changes.

Fri, Mar 29, 7:32 AM · Restricted Project

Mon, Mar 25

hubert.reinterpretcast added a comment to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

Ping 3. We've been using this locally to support our build environments with non-default native toolchains. I believe this patch is generally applicable for such a use case.

Mon, Mar 25, 3:38 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D58801: [Support] Implement is_local_impl with AIX mntctl.

@xingxue, thanks for the review. I've updated the patch; please let me know if you have concerns with the updates. I'll probably commit this later this week.

Mon, Mar 25, 3:26 PM · Restricted Project

Sat, Mar 23

hubert.reinterpretcast created D59741: [lit] Set shlibpath_var on AIX.
Sat, Mar 23, 12:59 PM · Restricted Project
hubert.reinterpretcast committed rCRT356844: Fix typos in compiler-rt/lib/builtins/atomic.c.
Fix typos in compiler-rt/lib/builtins/atomic.c
Sat, Mar 23, 11:41 AM
hubert.reinterpretcast committed rG4e7a218abf9b: Fix typos in compiler-rt/lib/builtins/atomic.c (authored by hubert.reinterpretcast).
Fix typos in compiler-rt/lib/builtins/atomic.c
Sat, Mar 23, 11:39 AM
hubert.reinterpretcast committed rL356844: Fix typos in compiler-rt/lib/builtins/atomic.c.
Fix typos in compiler-rt/lib/builtins/atomic.c
Sat, Mar 23, 11:39 AM
hubert.reinterpretcast closed D59228: Fix typos in compiler-rt/lib/builtins/atomic.c.
Sat, Mar 23, 11:39 AM · Restricted Project, Restricted Project
hubert.reinterpretcast committed rGa7510baf8477: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library (authored by hubert.reinterpretcast).
libclang/CIndexer.cpp: Use loadquery() on AIX for path to library
Sat, Mar 23, 11:10 AM
hubert.reinterpretcast committed rL356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.
libclang/CIndexer.cpp: Use loadquery() on AIX for path to library
Sat, Mar 23, 11:09 AM
hubert.reinterpretcast committed rC356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.
libclang/CIndexer.cpp: Use loadquery() on AIX for path to library
Sat, Mar 23, 11:09 AM
hubert.reinterpretcast closed D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.
Sat, Mar 23, 11:09 AM · Restricted Project

Fri, Mar 22

hubert.reinterpretcast added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Fri, Mar 22, 3:23 PM · Restricted Project
hubert.reinterpretcast updated the diff for D58801: [Support] Implement is_local_impl with AIX mntctl.

Address review comments, add test, and apply style changes

Fri, Mar 22, 3:23 PM · Restricted Project
hubert.reinterpretcast added a comment to D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.

Thanks @xingxue for the review. I will update for the error handling before committing.

Fri, Mar 22, 9:35 AM · Restricted Project

Mar 18 2019

hubert.reinterpretcast added a comment to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

A second ping.

Mar 18 2019, 2:02 PM · Restricted Project, Restricted Project

Mar 17 2019

hubert.reinterpretcast added inline comments to D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .
Mar 17 2019, 9:28 PM · Restricted Project

Mar 15 2019

hubert.reinterpretcast added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 15 2019, 3:53 PM · Restricted Project
hubert.reinterpretcast updated subscribers of D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.

@asb @lhames @majnemer, based on D36826, I believe that your guidance would be helpful here regarding the use of llvm_unreachable, report_fatal_error, and assert.

Mar 15 2019, 3:28 PM · Restricted Project
hubert.reinterpretcast added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 15 2019, 1:40 PM · Restricted Project
hubert.reinterpretcast added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 15 2019, 1:11 PM · Restricted Project

Mar 13 2019

hubert.reinterpretcast added inline comments to D59048: Add AIX Target Info.
Mar 13 2019, 12:43 PM · Restricted Project
hubert.reinterpretcast added inline comments to D59048: Add AIX Target Info.
Mar 13 2019, 12:09 PM · Restricted Project
hubert.reinterpretcast added inline comments to D59228: Fix typos in compiler-rt/lib/builtins/atomic.c.
Mar 13 2019, 8:44 AM · Restricted Project, Restricted Project

Mar 12 2019

hubert.reinterpretcast committed rG72db2abcc794: Use AIX version detection at LLVM run-time (authored by hubert.reinterpretcast).
Use AIX version detection at LLVM run-time
Mar 12 2019, 5:12 PM
hubert.reinterpretcast committed rL355995: Use AIX version detection at LLVM run-time.
Use AIX version detection at LLVM run-time
Mar 12 2019, 5:11 PM
hubert.reinterpretcast closed D58798: Use AIX version detection at LLVM run-time.
Mar 12 2019, 5:11 PM · Restricted Project

Mar 11 2019

hubert.reinterpretcast added a comment to D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.

I believe that the conditions being checked for with llvm_unreachable in this patch are of the debug-only variety; however, some input would be appreciated regarding the choice of using llvm_unreachable instead of report_fatal_error or assert.

Mar 11 2019, 4:16 PM · Restricted Project
hubert.reinterpretcast created D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library.
Mar 11 2019, 3:44 PM · Restricted Project
hubert.reinterpretcast accepted D59048: Add AIX Target Info.

I think all comments have been addressed or otherwise responded to.
@jasonliu: Since this patch is dependent on D58930, I would suggest that you commit it after D58930. A friendly reminder to include the patch attribution for @andusy. @apaprocki, and @WuZhao. Thanks.

Mar 11 2019, 3:24 PM · Restricted Project
hubert.reinterpretcast added a comment to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

A friendly ping?

Mar 11 2019, 2:54 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.

Why do you exclude clang? I would expect LLVM at this point to not support visibility attributes on XCOFF either?

Mar 11 2019, 2:34 PM · Restricted Project
hubert.reinterpretcast added a comment to D59228: Fix typos in compiler-rt/lib/builtins/atomic.c.

This leaves me wondering where the tests for this file are.

Mar 11 2019, 1:51 PM · Restricted Project, Restricted Project

Mar 8 2019

hubert.reinterpretcast added inline comments to D59048: Add AIX Target Info.
Mar 8 2019, 3:12 PM · Restricted Project
hubert.reinterpretcast committed rG57b38a8593bd: [msan] Properly guard tests added by r355348; NFC (authored by hubert.reinterpretcast).
[msan] Properly guard tests added by r355348; NFC
Mar 8 2019, 12:00 PM
hubert.reinterpretcast committed rL355718: [msan] Properly guard tests added by r355348; NFC.
[msan] Properly guard tests added by r355348; NFC
Mar 8 2019, 12:00 PM
hubert.reinterpretcast committed rCRT355718: [msan] Properly guard tests added by r355348; NFC.
[msan] Properly guard tests added by r355348; NFC
Mar 8 2019, 12:00 PM
hubert.reinterpretcast added a comment to D58930: Add XCOFF triple object format type for AIX.

@jasonliu, you have had a number of patches committed into the project already (D22698, D22702, D34649). Please go ahead with requesting commit access, and commit this patch with the additional fix when you are ready.

Mar 8 2019, 11:46 AM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2019

hubert.reinterpretcast added inline comments to D59048: Add AIX Target Info.
Mar 7 2019, 2:44 PM · Restricted Project
hubert.reinterpretcast committed rG51dcfdbba334: Add secondary libstdc++ 4.8 and 5.1 detection mechanisms (authored by hubert.reinterpretcast).
Add secondary libstdc++ 4.8 and 5.1 detection mechanisms
Mar 7 2019, 1:32 PM
hubert.reinterpretcast committed rL355638: Add secondary libstdc++ 4.8 and 5.1 detection mechanisms.
Add secondary libstdc++ 4.8 and 5.1 detection mechanisms
Mar 7 2019, 1:31 PM
hubert.reinterpretcast closed D58682: Add secondary libstdc++ 4.8 and 5.1 detection mechanisms.
Mar 7 2019, 1:31 PM · Restricted Project

Mar 6 2019

hubert.reinterpretcast added inline comments to D59048: Add AIX Target Info.
Mar 6 2019, 10:13 PM · Restricted Project
hubert.reinterpretcast added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 6 2019, 9:40 PM · Restricted Project
hubert.reinterpretcast added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 6 2019, 7:27 PM · Restricted Project
hubert.reinterpretcast added a comment to D18360: Add AIX Target/ToolChain to Clang Driver.

D59048 has been posted with some initial OSTargetInfo changes. Noticeable differences include not defining _ALL_SOURCE and focus on 64-bit long double. This is consistent with the invocation provided with the recent v16.1 release of the IBM XL C/C++ compiler for AIX that incorporates Clang-based technology.

Mar 6 2019, 3:37 PM
hubert.reinterpretcast added a parent revision for D59048: Add AIX Target Info: D58930: Add XCOFF triple object format type for AIX.
Mar 6 2019, 3:24 PM · Restricted Project
hubert.reinterpretcast added a child revision for D58930: Add XCOFF triple object format type for AIX: D59048: Add AIX Target Info.
Mar 6 2019, 3:24 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast updated subscribers of D59048: Add AIX Target Info.
Mar 6 2019, 3:20 PM · Restricted Project
hubert.reinterpretcast added a comment to D58798: Use AIX version detection at LLVM run-time.

I'd be happy to commit this patch later this week, but I would appreciate suggestions on alternative methods to suppress the "unused" warning for the internal-linkage helper function.

Mar 6 2019, 2:32 PM · Restricted Project
hubert.reinterpretcast added a comment to D58801: [Support] Implement is_local_impl with AIX mntctl.

Ping. I am looking for some input on whether we want to pursue additional testing.

Mar 6 2019, 11:24 AM · Restricted Project
hubert.reinterpretcast added inline comments to D58930: Add XCOFF triple object format type for AIX.
Mar 6 2019, 8:58 AM · Restricted Project, Restricted Project, Restricted Project

Mar 5 2019

hubert.reinterpretcast added inline comments to rGf726e4454c55: [WebAssembly] Add codegen support for the import_field attribute.
Mar 5 2019, 8:52 PM
hubert.reinterpretcast updated the diff for D58682: Add secondary libstdc++ 4.8 and 5.1 detection mechanisms.

Address review comment: Add note re: _GLIBCXX_RELEASE

Mar 5 2019, 7:32 PM · Restricted Project
hubert.reinterpretcast added inline comments to D58930: Add XCOFF triple object format type for AIX.
Mar 5 2019, 5:31 PM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2019

hubert.reinterpretcast created D58951: [compiler-rt][tests] Improve handling with non-default toolchains.
Mar 4 2019, 8:32 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D58930: Add XCOFF triple object format type for AIX.
Mar 4 2019, 3:48 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.
Mar 4 2019, 1:34 PM · Restricted Project
hubert.reinterpretcast added a comment to D58682: Add secondary libstdc++ 4.8 and 5.1 detection mechanisms.

A friendly ping?

Mar 4 2019, 11:13 AM · Restricted Project

Mar 1 2019

hubert.reinterpretcast accepted D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.

I believe all comments on this have been addressed. This LGTM. I'll probably commit this on Monday.

Mar 1 2019, 4:32 PM · Restricted Project
hubert.reinterpretcast updated subscribers of D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 1 2019, 12:34 PM · Restricted Project
hubert.reinterpretcast added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 1 2019, 12:23 PM · Restricted Project