Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (320 w, 5 d)

Recent Activity

Yesterday

hubert.reinterpretcast updated subscribers of D89758: Unconditionally #include <future>.

We've been building with LLVM_ENABLE_THREADS=0 to avoid dependencies on the TLS support in the build environment. We may require assistance to restore our builds if these patches introduce a TLS dependency. @daltenty, fyi.

Mon, Oct 19, 8:04 PM · Restricted Project
hubert.reinterpretcast added a comment to D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs. .

There's frontend changes anyway, so there should be changes for the predefined macros?

Mon, Oct 19, 9:15 AM · Restricted Project, Restricted Project

Sun, Oct 18

hubert.reinterpretcast committed rG126094485ab9: [PowerPC][AIX] Make `__vector [un]signed long` an error (authored by hubert.reinterpretcast).
[PowerPC][AIX] Make `__vector [un]signed long` an error
Sun, Oct 18, 9:47 AM
hubert.reinterpretcast committed rG2980ce98be11: Fix various format specifier mismatches (authored by hubert.reinterpretcast).
Fix various format specifier mismatches
Sun, Oct 18, 9:47 AM
hubert.reinterpretcast committed rGf4d8e86dbed5: [test][NFC] Do ptrdiff_t comparison with signed instead of unsigned constants (authored by hubert.reinterpretcast).
[test][NFC] Do ptrdiff_t comparison with signed instead of unsigned constants
Sun, Oct 18, 9:47 AM
hubert.reinterpretcast closed D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error.
Sun, Oct 18, 9:47 AM · Restricted Project
hubert.reinterpretcast closed D89637: Fix various format specifier mismatches.
Sun, Oct 18, 9:47 AM · Restricted Project

Sat, Oct 17

hubert.reinterpretcast requested review of D89637: Fix various format specifier mismatches.
Sat, Oct 17, 8:19 PM · Restricted Project

Fri, Oct 16

hubert.reinterpretcast requested review of D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds.
Fri, Oct 16, 8:29 PM · Restricted Project, Restricted Project

Thu, Oct 15

hubert.reinterpretcast added inline comments to D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.
Thu, Oct 15, 7:10 PM · Restricted Project
hubert.reinterpretcast added inline comments to D70744: [compiler-rt] Split the builtins CMake build to a separate file.
Thu, Oct 15, 4:58 PM · Restricted Project, Restricted Project

Wed, Oct 14

hubert.reinterpretcast requested review of D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error.
Wed, Oct 14, 8:08 PM · Restricted Project

Tue, Oct 13

hubert.reinterpretcast accepted D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.

LGTM with suggestion.

Tue, Oct 13, 6:57 AM · Restricted Project

Sat, Oct 10

hubert.reinterpretcast added a comment to D88659: [FE]Split SuitableAlign into two parts.

ISTM that comment may be incorrect. At least, the precedent set by GCC appears to be that BIGGEST_ALIGNMENT and alloca _both_ should follow vector alignment requirements of the selected ISA even when that is greater than any fundamental alignment requirement, and greater than malloc's alignment.

Sat, Oct 10, 2:27 PM · Restricted Project
hubert.reinterpretcast added a comment to D88773: Reland "[WebAssembly] Emulate v128.const efficiently"".

Thanks. This matches what I tested with a big endian host system. I'm not sure if @dweber agrees that their comments have been addressed though.

Sat, Oct 10, 7:40 AM · Restricted Project

Fri, Oct 9

hubert.reinterpretcast added a comment to D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.

Can we use a regex to make this also work in AIX?

Sure we can also do that. May I ask is that because we prefer letting AIX support as many LIT testcases as possible?

Fri, Oct 9, 2:24 PM · Restricted Project

Thu, Oct 8

hubert.reinterpretcast added a comment to D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.

Can we use a regex to make this also work in AIX?

Thu, Oct 8, 1:41 PM · Restricted Project
hubert.reinterpretcast added a comment to D88659: [FE]Split SuitableAlign into two parts.

It seems like on AIX, __BIGGEST_ALIGNMENT__ should just be set to 16, then. I'm not sure why you want it to be 8?

Thu, Oct 8, 9:24 AM · Restricted Project

Wed, Oct 7

hubert.reinterpretcast committed rGdd2f79ed4422: [test][MC] Use %python in llvm/test/MC/COFF/bigobj.py (authored by edd).
[test][MC] Use %python in llvm/test/MC/COFF/bigobj.py
Wed, Oct 7, 11:03 AM
hubert.reinterpretcast closed D88986: [test][MC] Use %python in llvm/test/MC/COFF/bigobj.py.
Wed, Oct 7, 11:03 AM · Restricted Project
hubert.reinterpretcast accepted D88986: [test][MC] Use %python in llvm/test/MC/COFF/bigobj.py.

LGTM; thanks.

Wed, Oct 7, 10:38 AM · Restricted Project
hubert.reinterpretcast accepted D88963: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary.

LGTM; thanks.

Wed, Oct 7, 7:47 AM · Restricted Project
hubert.reinterpretcast added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Wed, Oct 7, 7:05 AM · Restricted Project, Restricted Project

Tue, Oct 6

hubert.reinterpretcast added inline comments to D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front.
Tue, Oct 6, 4:12 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target.
Tue, Oct 6, 10:20 AM · Restricted Project

Mon, Oct 5

hubert.reinterpretcast added a comment to D88773: Reland "[WebAssembly] Emulate v128.const efficiently"".

I think the description still applies. Were you thinking of mentioning the specific error message? "C2100: illegal indirection" doesn't seem to give any more information than is already in the description.

Mon, Oct 5, 6:42 PM · Restricted Project

Fri, Oct 2

hubert.reinterpretcast added a comment to D88773: Reland "[WebAssembly] Emulate v128.const efficiently"".
  • Make initializations even more MSVC-friendly
Fri, Oct 2, 10:16 PM · Restricted Project
hubert.reinterpretcast added a comment to D88773: Reland "[WebAssembly] Emulate v128.const efficiently"".

I can confirm that at least llvm/test/CodeGen/WebAssembly/simd-build-vector.ll is good on AIX (big-endian Power) with this patch (at least with the maskTrailingOnes<uint64_t>(LaneBits)) change.

Fri, Oct 2, 10:14 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88773: Reland "[WebAssembly] Emulate v128.const efficiently"".
Fri, Oct 2, 9:39 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88773: Reland "[WebAssembly] Emulate v128.const efficiently"".
Fri, Oct 2, 9:25 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88773: Reland "[WebAssembly] Emulate v128.const efficiently"".
Fri, Oct 2, 9:08 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88591: [WebAssembly] Emulate v128.const efficiently.
Fri, Oct 2, 8:47 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88591: [WebAssembly] Emulate v128.const efficiently.
Fri, Oct 2, 8:42 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88591: [WebAssembly] Emulate v128.const efficiently.
Fri, Oct 2, 7:41 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88591: [WebAssembly] Emulate v128.const efficiently.
Fri, Oct 2, 7:37 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88591: [WebAssembly] Emulate v128.const efficiently.
Fri, Oct 2, 7:24 PM · Restricted Project
hubert.reinterpretcast added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Fri, Oct 2, 12:46 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88591: [WebAssembly] Emulate v128.const efficiently.
Fri, Oct 2, 9:31 AM · Restricted Project
hubert.reinterpretcast updated subscribers of D88591: [WebAssembly] Emulate v128.const efficiently.

@uweigand, fyi re: clang-s390x-linux bot: https://reviews.llvm.org/D88591#2308590.

Fri, Oct 2, 7:15 AM · Restricted Project
hubert.reinterpretcast added a comment to D88591: [WebAssembly] Emulate v128.const efficiently.

This patch appears to be the likely cause of big endian hosts failing with a timeout: http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/35450

Fri, Oct 2, 7:07 AM · Restricted Project

Thu, Oct 1

hubert.reinterpretcast accepted D88339: [XCOFF] Enable -fdata-sections on AIX.
Thu, Oct 1, 2:58 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Thu, Oct 1, 2:58 PM · Restricted Project
hubert.reinterpretcast committed rG35ecc7fe49ba: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast (authored by hubert.reinterpretcast).
[clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast
Thu, Oct 1, 12:57 PM
hubert.reinterpretcast closed D88526: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast.
Thu, Oct 1, 12:57 PM · Restricted Project
hubert.reinterpretcast added a comment to D88627: [runtimes] Remove TOOLCHAIN_TOOLS specialization.

This sounds right. @daltenty, can you confirm that this works on the AIX builds?

Thu, Oct 1, 6:50 AM · Restricted Project
hubert.reinterpretcast added inline comments to D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS.
Thu, Oct 1, 6:45 AM · Restricted Project

Wed, Sep 30

hubert.reinterpretcast added inline comments to D88339: [XCOFF] Enable -fdata-sections on AIX.
Wed, Sep 30, 6:14 PM · Restricted Project
hubert.reinterpretcast accepted D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.

LGTM; thanks!

Wed, Sep 30, 2:12 PM · Restricted Project
hubert.reinterpretcast accepted D88608: [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake.

LGTM.

Wed, Sep 30, 2:04 PM · Restricted Project
hubert.reinterpretcast committed rGae4c400e02fc: [NFC] Fix spacing in clang/test/Driver/aix-ld.c (authored by hubert.reinterpretcast).
[NFC] Fix spacing in clang/test/Driver/aix-ld.c
Wed, Sep 30, 2:01 PM
hubert.reinterpretcast added a comment to D88493: [XCOFF] Use -data-sections=true as default for llc on AIX.

@jasonliu: There's a lot of test adjustments to explicitly use the non-default, but I am not sure there is testing here to validate that the llc default when producing XCOFF assembly/object output is with unique data sections.

Wed, Sep 30, 1:04 PM · Restricted Project

Tue, Sep 29

hubert.reinterpretcast requested review of D88526: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast.
Tue, Sep 29, 9:53 PM · Restricted Project
hubert.reinterpretcast added a comment to rG674f57870f4c: [gardening] Replace some uses of setDebugLoc(DebugLoc()) with dropLocation()….

@vsk, there are bot failures with backtraces that mention dropLocation, e.g., http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/6257/steps/ninja%20check%201/logs/stdio:

Stack dump:
0.	Program arguments: /home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/./bin/clang -Wno-suggest-override -DGTEST_NO_LLVM_SUPPORT=1 -DGTEST_HAS_RTTI=0 -I/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/llvm/llvm/utils/unittest/googletest/include -I/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/llvm/llvm/utils/unittest/googletest -I/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/llvm/compiler-rt/include -I/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/llvm/compiler-rt/lib -I/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/llvm/compiler-rt/lib/sanitizer_common -fno-rtti -O2 -Werror=sign-compare -Wno-non-virtual-dtor -Wno-gnu-zero-variadic-macro-arguments -gline-tables-only -m64 -c -o SANITIZER_TEST_OBJECTS.sanitizer_allocator_test.cpp.x86_64.o /home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/llvm/compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp 
1.	<eof> parser at end of file
2.	Per-module optimization passes
3.	Running pass 'Function Pass Manager' on module '/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/llvm/compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp'.
4.	Running pass 'Simplify the CFG' on function '@_ZN11__sanitizer12SizeClassMapILm3ELm4ELm8ELm17ELm128ELm16EE5PrintEv'
 #0 0x00007f68219df64c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMSupport.so.12git+0x1a764c)
 #1 0x00007f68219dd324 llvm::sys::RunSignalHandlers() (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMSupport.so.12git+0x1a5324)
 #2 0x00007f68219dd5b5 llvm::sys::CleanupOnSignal(unsigned long) (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMSupport.so.12git+0x1a55b5)
 #3 0x00007f68218ed228 CrashRecoverySignalHandler(int) (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMSupport.so.12git+0xb5228)
 #4 0x00007f68210fcf20 (/lib/x86_64-linux-gnu/libc.so.6+0x3ef20)
 #5 0x00007f682214aa74 llvm::Instruction::getFunction() const (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMCore.so.12git+0x1b8a74)
 #6 0x00007f68220d8a8a llvm::Instruction::dropLocation() (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMCore.so.12git+0x146a8a)
 #7 0x00007f6823b16c81 llvm::FoldBranchToCommonDest(llvm::BranchInst*, llvm::MemorySSAUpdater*, llvm::TargetTransformInfo const*, unsigned int) (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMTransformUtils.so.12git+0x1d8c81)
 #8 0x00007f6823b205fc llvm::simplifyCFG(llvm::BasicBlock*, llvm::TargetTransformInfo const&, llvm::SimplifyCFGOptions const&, llvm::SmallPtrSetImpl<llvm::BasicBlock*>*) (/home/buildbot-worker/llvm-avr-linux/llvm-avr-linux/stage1/bin/../lib/libLLVMTransformUtils.so.12git+0x1e25fc)
Tue, Sep 29, 6:52 PM
hubert.reinterpretcast committed rG0a146a9d0bdd: [AIX] asm output: use character literals in byte lists for strings (authored by hubert.reinterpretcast).
[AIX] asm output: use character literals in byte lists for strings
Tue, Sep 29, 6:15 PM
hubert.reinterpretcast closed D80953: [AIX] asm output: use character literals in byte lists for strings.
Tue, Sep 29, 6:14 PM · Restricted Project
hubert.reinterpretcast accepted D88500: [AIX][Clang][Driver] Link libm in c++ mode.

LGTM with minor comments.

Tue, Sep 29, 3:32 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88500: [AIX][Clang][Driver] Link libm in c++ mode.
Tue, Sep 29, 11:51 AM · Restricted Project

Mon, Sep 28

hubert.reinterpretcast added inline comments to D80953: [AIX] asm output: use character literals in byte lists for strings.
Mon, Sep 28, 9:13 PM · Restricted Project
hubert.reinterpretcast updated the diff for D80953: [AIX] asm output: use character literals in byte lists for strings.
  • Update to avoid stored format string by using switch on a enum value
Mon, Sep 28, 9:13 PM · Restricted Project
hubert.reinterpretcast added a comment to D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS.

@ldionne, does this patch look okay to you? In terms of changes being made for z/OS, it's mainly going to be:

Mon, Sep 28, 4:20 PM · Restricted Project
hubert.reinterpretcast accepted D88310: [CMake][AIX] Limit tools in external project build.

LGTM; thanks.

Mon, Sep 28, 1:35 PM · Restricted Project

Sun, Sep 27

hubert.reinterpretcast added inline comments to D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS.
Sun, Sep 27, 11:18 AM · Restricted Project

Sat, Sep 26

hubert.reinterpretcast requested changes to D88310: [CMake][AIX] Limit tools in external project build.
Sat, Sep 26, 8:34 PM · Restricted Project

Fri, Sep 25

hubert.reinterpretcast added a comment to D88301: [libc++] Clean up logic around aligned/sized allocation and deallocation.

I think it does. The issue is that we're not detecting _LIBCPP_HAS_NO_ALIGNED_ALLOCATION properly.

Fri, Sep 25, 11:11 AM · Restricted Project
hubert.reinterpretcast updated subscribers of D88301: [libc++] Clean up logic around aligned/sized allocation and deallocation.

I don't think this patch makes sense given D87611. @Kai, @fanbo-meng, @abhina.sreeskantharajan, @zibi, fya.

Fri, Sep 25, 10:46 AM · Restricted Project
hubert.reinterpretcast added a comment to D88309: [LTO][Legacy] Add API to set result type to assembly.

I am fine with adding such a C API but I want to make sure you think through all the options, not just adding a new stable C API that is going to be thrown away.

Fri, Sep 25, 10:02 AM · Restricted Project
hubert.reinterpretcast added a comment to D88309: [LTO][Legacy] Add API to set result type to assembly.
  • If this is just a temporary workaround, I would resist make this change to bake in this API that will not be used in the future.
Fri, Sep 25, 9:33 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS.
Fri, Sep 25, 9:24 AM · Restricted Project

Thu, Sep 24

hubert.reinterpretcast added a comment to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.

Off-list discussion seems to indicate that only the NFC portion of the patch was intended to be approved.
That is, the scope of this patch is supposed to be https://reviews.llvm.org/D88105?id=293625 plus formatting changes.

Thu, Sep 24, 3:34 PM · Restricted Project
hubert.reinterpretcast accepted D88169: [CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX.

LGTM; thanks.

Thu, Sep 24, 12:39 PM · Restricted Project
hubert.reinterpretcast added a comment to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.

Looks to me that this (since it is approved) completely replaces D88130. The patch description needs to be changed of course.
Not sure if the committer wants to try splitting out the non-AIX test as an NFC patch.

Thu, Sep 24, 8:36 AM · Restricted Project
hubert.reinterpretcast accepted D88182: [clang][driver][AIX] Set compiler-rt as default rtlib.

LGTM; thanks.

Thu, Sep 24, 8:30 AM · Restricted Project

Wed, Sep 23

hubert.reinterpretcast added inline comments to D88182: [clang][driver][AIX] Set compiler-rt as default rtlib.
Wed, Sep 23, 3:39 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88169: [CMake][AIX] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR appropriately for AIX.
Wed, Sep 23, 3:11 PM · Restricted Project
hubert.reinterpretcast accepted D88157: [CMake] Make sure _cmake_system_name has a default.

LGTM; thanks.

Wed, Sep 23, 2:40 PM · Restricted Project
hubert.reinterpretcast updated the summary of D88157: [CMake] Make sure _cmake_system_name has a default.
Wed, Sep 23, 2:39 PM · Restricted Project
hubert.reinterpretcast added inline comments to D88157: [CMake] Make sure _cmake_system_name has a default.
Wed, Sep 23, 9:42 AM · Restricted Project

Tue, Sep 22

hubert.reinterpretcast added a comment to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.

I haven't been following this closely, but is there some reason we can't transform powf(x, 0.5) to sqrt(x == -infinity ? qnan : x)?

Tue, Sep 22, 6:20 PM · Restricted Project
hubert.reinterpretcast committed rGa60852e9d692: [InstCombine][NFC][tests] Add ninf base value case to pow-sqrt.ll (authored by hubert.reinterpretcast).
[InstCombine][NFC][tests] Add ninf base value case to pow-sqrt.ll
Tue, Sep 22, 4:00 PM
hubert.reinterpretcast committed rG32c9991dab5c: [InstCombine] Fix errno bug in pow expansion to sqrt (authored by hubert.reinterpretcast).
[InstCombine] Fix errno bug in pow expansion to sqrt
Tue, Sep 22, 4:00 PM
hubert.reinterpretcast closed D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Tue, Sep 22, 4:00 PM · Restricted Project
hubert.reinterpretcast committed rG6801950192ff: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case (authored by hubert.reinterpretcast).
[InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case
Tue, Sep 22, 11:24 AM
hubert.reinterpretcast committed rGb0f58aa116a1: [NFC] Replace tabs with spaces in PPCInstrPrefix.td (authored by hubert.reinterpretcast).
[NFC] Replace tabs with spaces in PPCInstrPrefix.td
Tue, Sep 22, 11:24 AM
hubert.reinterpretcast committed rGa6f8aeb51c73: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py (authored by hubert.reinterpretcast).
[test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py
Tue, Sep 22, 11:23 AM
hubert.reinterpretcast closed D88066: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case.
Tue, Sep 22, 11:23 AM · Restricted Project
hubert.reinterpretcast closed D87122: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py.
Tue, Sep 22, 11:23 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Tue, Sep 22, 9:17 AM · Restricted Project
hubert.reinterpretcast updated the diff for D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
  • Rebase on top of D88066; add isKnownNeverInfinity condition
  • Adjust comment for afn case
Tue, Sep 22, 8:56 AM · Restricted Project
hubert.reinterpretcast added inline comments to D88066: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case.
Tue, Sep 22, 6:42 AM · Restricted Project

Mon, Sep 21

hubert.reinterpretcast requested review of D88066: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case.
Mon, Sep 21, 9:06 PM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 8:55 PM · Restricted Project
hubert.reinterpretcast accepted D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.

Compiler-rt supports generating multiple targets from a single configuration. By default the compiler-rt build process will figure out the supported arches and generate different targets for the powerpc and powerpc64 objects, so there is only one real run.

Mon, Sep 21, 4:54 PM · Restricted Project
hubert.reinterpretcast added a comment to D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.

General comment: CMake is not the only mechanism for making the conditions common; a header file is capable of the same.

Mon, Sep 21, 4:02 PM · Restricted Project
hubert.reinterpretcast accepted D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.

LGTM; thanks.

Mon, Sep 21, 3:34 PM · Restricted Project
hubert.reinterpretcast retitled D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode from [AIX][clang][driver] Make sure ctri.o is linked in C++ mode to [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.
Mon, Sep 21, 2:00 PM · Restricted Project
hubert.reinterpretcast added inline comments to D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.
Mon, Sep 21, 1:59 PM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 10:20 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 8:35 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 8:15 AM · Restricted Project

Sep 18 2020

hubert.reinterpretcast updated the summary of D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Sep 18 2020, 11:01 AM · Restricted Project