Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (403 w, 4 d)

Recent Activity

Thu, May 19

hubert.reinterpretcast added inline comments to D125496: [libc++] Simplify the string structures a bit more.
Thu, May 19, 10:07 PM · Restricted Project, Restricted Project

Wed, May 4

hubert.reinterpretcast accepted D124855: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with -ffunction-sections.

LGTM; however, might want to wait a bit to see if other reviewers have comments.

Wed, May 4, 8:35 AM · Restricted Project, Restricted Project

Tue, May 3

hubert.reinterpretcast added inline comments to D124855: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with -ffunction-sections.
Tue, May 3, 8:57 AM · Restricted Project, Restricted Project

Mon, May 2

hubert.reinterpretcast added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
Mon, May 2, 5:22 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Apr 29

hubert.reinterpretcast added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

Thank you!

Fri, Apr 29, 6:39 AM · Restricted Project, Restricted Project

Thu, Apr 28

hubert.reinterpretcast committed rG52ce95a1a554: [NFC] Prevent shadowing a variable declared in `if` (authored by ken-matsui).
[NFC] Prevent shadowing a variable declared in `if`
Thu, Apr 28, 7:22 PM · Restricted Project, Restricted Project
hubert.reinterpretcast closed D124556: [NFC] Prevent shadowing a variable declared in `if`.
Thu, Apr 28, 7:22 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

@hubert.reinterpretcast

Sorry, I'm a newbie here, but is there anything I should do after getting approved?

Thu, Apr 28, 9:30 AM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D124556: [NFC] Prevent shadowing a variable declared in `if`.

LGTM; thanks for the patch!

Thu, Apr 28, 8:17 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

@hubert.reinterpretcast,

Sorry to have missed providing a summary.

Thu, Apr 28, 7:30 AM · Restricted Project, Restricted Project

Wed, Apr 27

hubert.reinterpretcast added a comment to D124556: [NFC] Prevent shadowing a variable declared in `if`.

@ken-matsui, can you provide some rationale for the change (got compiler warning/error)?

Wed, Apr 27, 9:08 PM · Restricted Project, Restricted Project
hubert.reinterpretcast retitled D124556: [NFC] Prevent shadowing a variable declared in `if` from Prevent shadowing a variable declared in `if` to [NFC] Prevent shadowing a variable declared in `if`.
Wed, Apr 27, 9:07 PM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the summary of D124555: [libcxx][AIX][z/OS] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.
Wed, Apr 27, 2:14 PM · Restricted Project, Restricted Project

Sat, Apr 23

hubert.reinterpretcast accepted D122937: Provide the complete response and reporting Code of Conduct documentation. Remove the word draft from all documents, add information about the CoC committee expectations and add a place for transparency reports..

There were some minor issues still left. LGTM whether they get fixed or not though.

Sat, Apr 23, 3:16 PM · Restricted Project, Restricted Project

Apr 20 2022

hubert.reinterpretcast added a comment to D122937: Provide the complete response and reporting Code of Conduct documentation. Remove the word draft from all documents, add information about the CoC committee expectations and add a place for transparency reports..

Some more editorial comments and a comment regarding some text that does not seem to convey whatever meaning was intended well.

Apr 20 2022, 2:09 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D122937: Provide the complete response and reporting Code of Conduct documentation. Remove the word draft from all documents, add information about the CoC committee expectations and add a place for transparency reports..

Got halfway through so far. Some editorial comments.

Apr 20 2022, 9:30 AM · Restricted Project, Restricted Project

Apr 7 2022

hubert.reinterpretcast accepted D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.

LGTM with minor comments.

Apr 7 2022, 10:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

hubert.reinterpretcast added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Apr 6 2022, 8:09 PM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

hubert.reinterpretcast added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Morally, yes, that's reasonable in CodeGen because you're ensuring you get no diagnostics. Practically, that's a convoluted, more expensive, less maintainable way to spell -Werror for the test. When diagnostics are introduced, this pattern encourages people to remove the // expected-no-diagnostics comment and start adding // expected-warning {{}} comments. Running the diagnostic verifier also slows down test execution because of the extra verification step (which adds up over thousands of tests).

Apr 5 2022, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 4 2022

hubert.reinterpretcast added a comment to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.

I am not sure that the choice of isOSBinFormatELF to (afaik) primarily scope this change from affecting AIX (where we know the library calls are not implemented to be lock-free yet) is better than alternative where the condition is for little-endian mode or specifically for not AIX.

Apr 4 2022, 10:16 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Apr 4 2022, 8:59 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Apr 4 2022, 8:44 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Apr 4 2022, 8:38 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122937: Provide the complete response and reporting Code of Conduct documentation. Remove the word draft from all documents, add information about the CoC committee expectations and add a place for transparency reports..
Apr 4 2022, 7:59 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122937: Provide the complete response and reporting Code of Conduct documentation. Remove the word draft from all documents, add information about the CoC committee expectations and add a place for transparency reports..
Apr 4 2022, 6:08 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

We typically avoid doing -verify in CodeGen (unless the diagnostic is ACTUALLY in CodeGen) as a matter of business.

Apr 4 2022, 2:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

The tests verify a set of builtins do not exist when the associated feature flag is not present. They sit within CodeGen because the tests were plentiful and it did not seem worth duplicating them.

Apr 4 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D122983: [C11/C2x] Change the behavior of the implicit function declaration warning.

Yeah, those tests seem to be overly-constraining. There's no reason to be validating whether there's an implicit function declaration warning in a *codegen* test. I will change all of those AAarch64 tests to require -std=c99 explicitly whenever possible, remove the -verify flag because there's no reason for a codegen test to verify diagnostic behavior that isn't generated by the CodeGen library, and remove the // expected-warning comments. I plan to do that as an NFC change that I'll land outside of this patch, unless any of the AArch64 folks speak up pretty quickly.

Apr 4 2022, 8:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 31 2022

hubert.reinterpretcast added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Mar 31 2022, 7:13 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Mar 31 2022, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D121992: [Clang] [Driver] Add option to set alternative toolchain path.

If you intend to overlay ld.so, you'll necessarily overlay libc, then --sysroot seems just unneeded at all.

Mar 31 2022, 7:22 AM · Restricted Project, Restricted Project

Mar 30 2022

hubert.reinterpretcast added inline comments to D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up.
Mar 30 2022, 4:13 PM · Restricted Project, Restricted Project, Restricted Project
hubert.reinterpretcast accepted D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr..

This LGTM (with minor comment). Please wait for Aaron to respond re: the handling of template instantiations.

Mar 30 2022, 7:10 AM · Restricted Project, Restricted Project

Mar 24 2022

hubert.reinterpretcast committed rGce21c926f8ef: [Clang] Work with multiple pragmas weak before definition (authored by hubert.reinterpretcast).
[Clang] Work with multiple pragmas weak before definition
Mar 24 2022, 5:20 PM · Restricted Project, Restricted Project
hubert.reinterpretcast closed D121927: [Clang] Work with multiple pragmas weak before definition.
Mar 24 2022, 5:20 PM · Restricted Project, Restricted Project

Mar 23 2022

hubert.reinterpretcast updated the diff for D121927: [Clang] Work with multiple pragmas weak before definition.
  • Adjust per observation: Use DenseMapInfo for the alias pointer value
Mar 23 2022, 2:53 PM · Restricted Project, Restricted Project
hubert.reinterpretcast updated subscribers of D122335: [clang] Emit crash reproduction as a single tar file.
Mar 23 2022, 11:28 AM · Restricted Project
hubert.reinterpretcast added a comment to D122335: [clang] Emit crash reproduction as a single tar file.

For users on Windows, would this cause extra trouble if they wanted to see what was included?

Mar 23 2022, 11:27 AM · Restricted Project
hubert.reinterpretcast added inline comments to D121927: [Clang] Work with multiple pragmas weak before definition.
Mar 23 2022, 11:11 AM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D121992: [Clang] [Driver] Add option to set alternative toolchain path.
Mar 23 2022, 10:42 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D121992: [Clang] [Driver] Add option to set alternative toolchain path.

LGTM; thank you.

Mar 23 2022, 10:42 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D121927: [Clang] Work with multiple pragmas weak before definition.

@aaron.ballman, I believe I have responded to all of the comments.

Mar 23 2022, 9:43 AM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the diff for D121927: [Clang] Work with multiple pragmas weak before definition.
  • Address review comments: Return const from getAlias()
Mar 23 2022, 9:42 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr..
Mar 23 2022, 8:54 AM · Restricted Project, Restricted Project
hubert.reinterpretcast committed rGda167a53c87f: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName` (authored by hubert.reinterpretcast).
[Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`
Mar 23 2022, 8:10 AM · Restricted Project
hubert.reinterpretcast closed D122261: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`.
Mar 23 2022, 8:09 AM · Restricted Project, Restricted Project

Mar 22 2022

hubert.reinterpretcast added inline comments to D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr..
Mar 22 2022, 11:06 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr..
Mar 22 2022, 11:05 PM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the diff for D121927: [Clang] Work with multiple pragmas weak before definition.
  • Address review comments: Add release notes, expand comments
Mar 22 2022, 5:02 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D121927: [Clang] Work with multiple pragmas weak before definition.
Mar 22 2022, 2:01 PM · Restricted Project, Restricted Project
hubert.reinterpretcast requested review of D122261: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`.
Mar 22 2022, 1:59 PM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the diff for D121927: [Clang] Work with multiple pragmas weak before definition.
  • Address review comments: Use default member init in WeakInfo
Mar 22 2022, 1:31 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D121927: [Clang] Work with multiple pragmas weak before definition.
Mar 22 2022, 1:10 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D121927: [Clang] Work with multiple pragmas weak before definition.
Mar 22 2022, 12:38 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.

Confirming LGTM with minor comments.

Mar 22 2022, 10:36 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 22 2022, 8:52 AM · Restricted Project, Restricted Project

Mar 21 2022

hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 21 2022, 3:48 PM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.

LGTM with minor nit. Thank you.

Mar 21 2022, 1:13 PM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the diff for D121927: [Clang] Work with multiple pragmas weak before definition.
  • Address review comments: Remove deleted non-operator member functions; add extra line to test
Mar 21 2022, 11:50 AM · Restricted Project, Restricted Project

Mar 20 2022

hubert.reinterpretcast added inline comments to D121992: [Clang] [Driver] Add option to set alternative toolchain path.
Mar 20 2022, 7:42 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 20 2022, 5:36 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 20 2022, 5:08 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 20 2022, 8:34 AM · Restricted Project, Restricted Project

Mar 19 2022

hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 19 2022, 10:31 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 19 2022, 10:19 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.

I think labels can be left as is.

Mar 19 2022, 8:07 PM · Restricted Project, Restricted Project

Mar 18 2022

hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 18 2022, 5:20 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D121927: [Clang] Work with multiple pragmas weak before definition.
Mar 18 2022, 1:02 PM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the summary of D121992: [Clang] [Driver] Add option to set alternative toolchain path.
Mar 18 2022, 8:37 AM · Restricted Project, Restricted Project

Mar 17 2022

hubert.reinterpretcast added inline comments to D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc.
Mar 17 2022, 10:55 PM · Restricted Project, Restricted Project
hubert.reinterpretcast retitled D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr from [Clang] Implement P2242R3 to [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 17 2022, 4:54 PM · Restricted Project, Restricted Project
hubert.reinterpretcast requested review of D121927: [Clang] Work with multiple pragmas weak before definition.
Mar 17 2022, 10:22 AM · Restricted Project, Restricted Project

Mar 16 2022

hubert.reinterpretcast accepted D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc.

LGTM with comment (not blocking).

Mar 16 2022, 3:38 PM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D121799: [VE] Remove output to /dev/stdout.

LGTM by the way. The use of /dev/stdout would cause grief for Windows too?

Mar 16 2022, 7:20 AM · Restricted Project, Restricted Project

Mar 15 2022

hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 15 2022, 8:58 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc.
Mar 15 2022, 4:45 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc.
Mar 15 2022, 4:30 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.

@aaron.ballman @cor3ntin, are we confident that testing the non-lambda cases is sufficient to cover the lambda cases as well?

Mar 15 2022, 9:55 AM · Restricted Project, Restricted Project

Mar 13 2022

hubert.reinterpretcast added inline comments to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.
Mar 13 2022, 4:24 PM · Restricted Project, Restricted Project

Mar 12 2022

hubert.reinterpretcast added a comment to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.

Noting for myself:
Clang's status quo already has behaviours that are similar to P2242R3 in its C++20 mode despite those behaviours being non-conforming and contributing to binary compat breakage with GCC.
This patch is not responsible for those behaviours, and fixing that status quo is not within the scope of this patch.

Mar 12 2022, 6:49 PM · Restricted Project, Restricted Project

Mar 11 2022

Herald added a project to D119441: [libc++] Fix locale name construction: Restricted Project.

For info: getlocalename_l is the proposed/new interface to get (per category) locale names in a thread-safe manner.

Mar 11 2022, 1:57 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.

In C++2b, the -Wc++20-compat warning is produced for the places where we warn above and is not produced for the places where we don't warn above.

Mar 11 2022, 1:46 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr.

@aaron.ballman, I haven't had a chance to look at the code in detail yet, but I would like to get on the same page about the error/warning behaviour.

Mar 11 2022, 1:36 PM · Restricted Project, Restricted Project

Mar 4 2022

hubert.reinterpretcast added inline comments to D121009: [libc++] Simplify how __format_spec::_Flags is packed on AIX.
Mar 4 2022, 3:31 PM · Restricted Project, Restricted Project

Mar 1 2022

hubert.reinterpretcast added inline comments to D65667: [libcxx] Avoid destructor call for error_category singletons.
Mar 1 2022, 7:15 AM · Restricted Project, Restricted Project

Feb 18 2022

hubert.reinterpretcast accepted D119567: [libcxx] String format class marked as packed.

I think this version addresses all of the comments made. The parameterized form of the macro can be added when needed. Confirming LGTM.

Feb 18 2022, 3:15 PM · Restricted Project, Restricted Project

Feb 17 2022

hubert.reinterpretcast added inline comments to D119567: [libcxx] String format class marked as packed.
Feb 17 2022, 6:26 PM · Restricted Project, Restricted Project

Feb 14 2022

hubert.reinterpretcast accepted D119765: [libc++][AIX] Remove "pragma priority" from locale.cpp.

@ldionne, can you approve? The change only affects AIX.

Feb 14 2022, 2:28 PM · Restricted Project
hubert.reinterpretcast accepted D119770: [libcxx] Fix the type in __estimate_column_width.

__utf32_character guards against usage of 16-bit wchar_t. The usage that gets broken by using wchar_t in the implementation is the char32_t case. There's no reason to tie the char32_t case to a UTF-32 wchar_t that I know of. The change LGTM.

Feb 14 2022, 1:13 PM · Restricted Project
hubert.reinterpretcast accepted D119567: [libcxx] String format class marked as packed.

LGTM from the AIX viewpoint. The resulting layout is similar to what would happen (even without the attribute) on Linux.
Please wait for the libc++ group approval.

Feb 14 2022, 1:01 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D119765: [libc++][AIX] Remove "pragma priority" from locale.cpp.
Feb 14 2022, 12:52 PM · Restricted Project

Feb 13 2022

hubert.reinterpretcast added inline comments to D119441: [libc++] Fix locale name construction.
Feb 13 2022, 10:24 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D119441: [libc++] Fix locale name construction.
Feb 13 2022, 8:49 PM · Restricted Project, Restricted Project

Feb 12 2022

hubert.reinterpretcast added inline comments to D119441: [libc++] Fix locale name construction.
Feb 12 2022, 9:56 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D119441: [libc++] Fix locale name construction.

If the implementation wants to give named locales that are formed differently the same name (*), then it is required to report that they are equal. It seems an interesting experiment in conforming but unhelpful implementation methods to retain the * and correct the equality comparison for conformance, thus we did not propose that direction for this patch.

Feb 12 2022, 4:05 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D119567: [libcxx] String format class marked as packed.
Feb 12 2022, 11:16 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D119441: [libc++] Fix locale name construction.
Feb 12 2022, 8:49 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D119441: [libc++] Fix locale name construction.
Feb 12 2022, 8:22 AM · Restricted Project, Restricted Project

Feb 11 2022

hubert.reinterpretcast added a comment to D119441: [libc++] Fix locale name construction.

Thanks for the patch! locales are not my strength, so I left some comment but TBH I don't fully grok why we'd want to make this change. Are we non-conforming at the moment?

Feb 11 2022, 11:55 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D119567: [libcxx] String format class marked as packed.
Feb 11 2022, 3:05 PM · Restricted Project, Restricted Project