- User Since
- Aug 27 2014, 8:34 PM (403 w, 4 d)
Thu, May 19
Wed, May 4
LGTM; however, might want to wait a bit to see if other reviewers have comments.
Tue, May 3
Mon, May 2
Fri, Apr 29
Thu, Apr 28
LGTM; thanks for the patch!
Wed, Apr 27
@ken-matsui, can you provide some rationale for the change (got compiler warning/error)?
Sat, Apr 23
There were some minor issues still left. LGTM whether they get fixed or not though.
Apr 20 2022
Some more editorial comments and a comment regarding some text that does not seem to convey whatever meaning was intended well.
Got halfway through so far. Some editorial comments.
Apr 7 2022
LGTM with minor comments.
Apr 6 2022
Apr 5 2022
Apr 4 2022
I am not sure that the choice of isOSBinFormatELF to (afaik) primarily scope this change from affecting AIX (where we know the library calls are not implemented to be lock-free yet) is better than alternative where the condition is for little-endian mode or specifically for not AIX.
Mar 31 2022
Mar 30 2022
This LGTM (with minor comment). Please wait for Aaron to respond re: the handling of template instantiations.
Mar 24 2022
Mar 23 2022
- Adjust per observation: Use DenseMapInfo for the alias pointer value
For users on Windows, would this cause extra trouble if they wanted to see what was included?
LGTM; thank you.
@aaron.ballman, I believe I have responded to all of the comments.
- Address review comments: Return const from getAlias()
Mar 22 2022
- Address review comments: Add release notes, expand comments
- Address review comments: Use default member init in WeakInfo
Confirming LGTM with minor comments.
Mar 21 2022
LGTM with minor nit. Thank you.
- Address review comments: Remove deleted non-operator member functions; add extra line to test
Mar 20 2022
Mar 19 2022
I think labels can be left as is.
Mar 18 2022
Mar 17 2022
Mar 16 2022
LGTM with comment (not blocking).
LGTM by the way. The use of /dev/stdout would cause grief for Windows too?
Mar 15 2022
Mar 13 2022
Mar 12 2022
Noting for myself:
Clang's status quo already has behaviours that are similar to P2242R3 in its C++20 mode despite those behaviours being non-conforming and contributing to binary compat breakage with GCC.
This patch is not responsible for those behaviours, and fixing that status quo is not within the scope of this patch.
Mar 11 2022
For info: getlocalename_l is the proposed/new interface to get (per category) locale names in a thread-safe manner.
@aaron.ballman, I haven't had a chance to look at the code in detail yet, but I would like to get on the same page about the error/warning behaviour.
Mar 4 2022
Mar 1 2022
Feb 18 2022
I think this version addresses all of the comments made. The parameterized form of the macro can be added when needed. Confirming LGTM.
Feb 17 2022
Feb 14 2022
@ldionne, can you approve? The change only affects AIX.
__utf32_character guards against usage of 16-bit wchar_t. The usage that gets broken by using wchar_t in the implementation is the char32_t case. There's no reason to tie the char32_t case to a UTF-32 wchar_t that I know of. The change LGTM.
LGTM from the AIX viewpoint. The resulting layout is similar to what would happen (even without the attribute) on Linux.
Please wait for the libc++ group approval.