hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (168 w, 5 d)

Recent Activity

Jun 30 2017

hubert.reinterpretcast committed rL306905: Fix PR 33189: Clang assertion on template destructor declaration.
Fix PR 33189: Clang assertion on template destructor declaration
Jun 30 2017, 3:44 PM
hubert.reinterpretcast closed D33833: Fix PR 33189: Clang assertion on template destructor declaration.
Jun 30 2017, 3:44 PM
hubert.reinterpretcast updated the summary of D33833: Fix PR 33189: Clang assertion on template destructor declaration.
Jun 30 2017, 3:33 PM

Jun 23 2017

hubert.reinterpretcast added a comment to D33833: Fix PR 33189: Clang assertion on template destructor declaration.

Can we get this patch reviewed by any chance?

@kuang_he; it is customary to "ping". In this case, "Ping 2".

Jun 23 2017, 3:38 PM

Jun 2 2017

hubert.reinterpretcast added inline comments to D33833: Fix PR 33189: Clang assertion on template destructor declaration.
Jun 2 2017, 4:24 PM
hubert.reinterpretcast retitled D33833: Fix PR 33189: Clang assertion on template destructor declaration from Fix Clang assertion on template destructor declaration to Fix PR 33189: Clang assertion on template destructor declaration.
Jun 2 2017, 4:21 PM

May 19 2017

hubert.reinterpretcast committed rL303472: Fix valid-for-expr ellipses eaten as invalid decl.
Fix valid-for-expr ellipses eaten as invalid decl
May 19 2017, 5:35 PM
hubert.reinterpretcast closed D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 19 2017, 5:35 PM
hubert.reinterpretcast updated the summary of D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 19 2017, 3:17 PM
hubert.reinterpretcast updated the diff for D33339: Fix valid-for-expr ellipses eaten as invalid decl.

Remove stray ellipsis treatment entirely

May 19 2017, 3:14 PM
hubert.reinterpretcast added a comment to D33339: Fix valid-for-expr ellipses eaten as invalid decl.

The check-all target passes even if the ellipsis-after-declarator-id disambiguation as a declarator is removed entirely.

[...]

So, on the whole, the stray ellipsis treatment is both too complicated and not complicated enough.

I think if we want to keep it, the way to do that would be to carry on through the disambiguation process and treat it as a tiebreaker (that's what we do, for instance, if we see an undeclared identifier in a position where we're looking for a type). I'm not convinced that's worthwhile, especially since our existing testcases do not need this disambiguation rule, but perhaps we could remove the stray ellipsis treatment entirely for now and reconsider adding it back if we find poor diagnostics result from it later?

May 19 2017, 1:21 PM

May 18 2017

hubert.reinterpretcast added a comment to D33339: Fix valid-for-expr ellipses eaten as invalid decl.

Should I assume our "misplaced ellipsis" diagnostic requires that we disambiguate the ill-formed ellipsis-after-declarator-id as a declarator in some cases? If so, do we have tests for that somewhere?

Tests for the diagnostics are in clang/test/FixIt/fixit-cxx0x.cpp and clang/test/Parser/cxx11-templates.cpp.
The check-all target passes even if the ellipsis-after-declarator-id disambiguation as a declarator is removed entirely. The disambiguation process is not needed in many cases, and—when it is—can choose the declarative interpretation for other reasons.

May 18 2017, 9:01 PM
hubert.reinterpretcast added inline comments to D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 18 2017, 2:59 PM
hubert.reinterpretcast created D33339: Fix valid-for-expr ellipses eaten as invalid decl.
May 18 2017, 2:28 PM

Apr 30 2017

hubert.reinterpretcast added a comment to D32378: Insert invariant.group.barrier for pointers comparisons.

Has it been discussed whether this is something to be addressed in the optimizer as opposed to the front-end?

Apr 30 2017, 8:38 PM

Feb 9 2017

hubert.reinterpretcast added inline comments to D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas..
Feb 9 2017, 7:25 PM · Restricted Project
hubert.reinterpretcast committed rL294697: [Concepts] Class template associated constraints.
[Concepts] Class template associated constraints
Feb 9 2017, 6:57 PM
hubert.reinterpretcast closed D25674: [Concepts] Class template associated constraints.
Feb 9 2017, 6:57 PM
hubert.reinterpretcast updated the diff for D25674: [Concepts] Class template associated constraints.

Address review comments; update to revision 294580

Feb 9 2017, 12:04 PM

Feb 8 2017

hubert.reinterpretcast added inline comments to D25674: [Concepts] Class template associated constraints.
Feb 8 2017, 4:34 PM
hubert.reinterpretcast added a comment to D25674: [Concepts] Class template associated constraints.

Ping 2?

Feb 8 2017, 2:47 PM

Feb 1 2017

hubert.reinterpretcast added a comment to D25674: [Concepts] Class template associated constraints.

Ping!

Feb 1 2017, 11:23 AM

Jan 25 2017

hubert.reinterpretcast added inline comments to D25674: [Concepts] Class template associated constraints.
Jan 25 2017, 7:25 AM
hubert.reinterpretcast updated the diff for D25674: [Concepts] Class template associated constraints.

Address review comments; update to revision 292996

Jan 25 2017, 7:10 AM

Dec 1 2016

hubert.reinterpretcast added inline comments to D26817: [APFloat] Implement PPCDoubleDouble add and subtract..
Dec 1 2016, 10:29 AM

Nov 21 2016

hubert.reinterpretcast committed rL287583: reassociate-deadinst.ll: avoid accidental match on path.
reassociate-deadinst.ll: avoid accidental match on path
Nov 21 2016, 2:02 PM

Nov 20 2016

hubert.reinterpretcast added inline comments to D26882: Refactor how FunctionDecl handles constexpr:.
Nov 20 2016, 5:13 PM

Oct 24 2016

hubert.reinterpretcast added a comment to D25674: [Concepts] Class template associated constraints.

Friendly ping...

Oct 24 2016, 11:26 AM

Oct 22 2016

hubert.reinterpretcast added inline comments to D25674: [Concepts] Class template associated constraints.
Oct 22 2016, 7:33 PM

Oct 17 2016

hubert.reinterpretcast retitled D25674: [Concepts] Class template associated constraints from to [Concepts] Class template associated constraints.
Oct 17 2016, 6:34 AM

Oct 11 2016

hubert.reinterpretcast added a comment to D25480: __builtin_fpclassify missing one int parameter.

__builtin_fpclassify takes five int arguments followed by one last argument that is of floating point type. Do you know if there is a way to specify the last one argument is a floating point rather than using '.'?

There is already code in clang/lib/Sema/SemaChecking.cpp to generate diag::err_typecheck_call_invalid_unary_fp.

Oct 11 2016, 12:21 PM
hubert.reinterpretcast added a comment to D25480: __builtin_fpclassify missing one int parameter.

A test should probably be added as well.

Oct 11 2016, 10:50 AM

Sep 28 2016

hubert.reinterpretcast added inline comments to D22745: Added -ftemplate-auto option to enable the template auto feature (P0127). I am the author of the proposal; I believe this to be a complete implementation. Currently, the feature is enabled through the use of the -ftemplate-auto option and is not....
Sep 28 2016, 7:18 PM

Aug 30 2016

hubert.reinterpretcast added a comment to D24011: [ConstantFold] Add a flag for ppc_fp128 constant folding, since APFloat doesn't support double-double semantic.

If there seems to be few applications are depending on this optimization, I wonder if we can turn off the constant folding for now, and fix APFloat later if someone really cares about it?

Just wanted to note that the front-end would still encounter the issue with APFloat, and I would be concerned if the (front-end) constant expression evaluation for ppc_fp128 is disabled entirely.

Aug 30 2016, 2:04 PM

Aug 7 2016

hubert.reinterpretcast added inline comments to D22996: [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions..
Aug 7 2016, 3:43 PM · Restricted Project
hubert.reinterpretcast committed rL277968: [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor.
[libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor
Aug 7 2016, 3:34 PM
hubert.reinterpretcast committed rL277967: Revert r277966. Forgot patch attribution..
Revert r277966. Forgot patch attribution.
Aug 7 2016, 3:31 PM
hubert.reinterpretcast committed rL277966: [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor.
[libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor
Aug 7 2016, 3:26 PM
hubert.reinterpretcast closed D22702: [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor.
Aug 7 2016, 3:26 PM
hubert.reinterpretcast retitled D22702: [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor from [libcxx]Missing default argument for flag_type parameter in one of std::basic_regex constructors to [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor.
Aug 7 2016, 2:46 PM
hubert.reinterpretcast accepted D22702: [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor.

LGTM.

Aug 7 2016, 8:29 AM

Aug 3 2016

hubert.reinterpretcast committed rL277658: [Concepts] remove default argument for RequiresClause; NFC.
[Concepts] remove default argument for RequiresClause; NFC
Aug 3 2016, 3:15 PM

Aug 2 2016

hubert.reinterpretcast committed rL277526: [libcxx] basic_regex: add traits_type, string_type.
[libcxx] basic_regex: add traits_type, string_type
Aug 2 2016, 2:42 PM
hubert.reinterpretcast closed D22698: [libcxx] basic_regex: add traits_type, string_type .
Aug 2 2016, 2:42 PM
hubert.reinterpretcast retitled D22698: [libcxx] basic_regex: add traits_type, string_type from [libcxx] Missing member types 'traits_type' and 'string_type' in class basic_regex to [libcxx] basic_regex: add traits_type, string_type .
Aug 2 2016, 1:50 PM
hubert.reinterpretcast committed rL277495: [Concepts] Add TODO and requires-clause placeholder; NFC.
[Concepts] Add TODO and requires-clause placeholder; NFC
Aug 2 2016, 11:44 AM
hubert.reinterpretcast accepted D22698: [libcxx] basic_regex: add traits_type, string_type .

LGTM.

Aug 2 2016, 9:20 AM

Jul 30 2016

hubert.reinterpretcast committed rL277286: Reapply r276069 with workaround for MSVC 2013.
Reapply r276069 with workaround for MSVC 2013
Jul 30 2016, 3:41 PM
hubert.reinterpretcast committed rL277270: TrailingObjects::FixedSizeStorage constexpr fixes + tests.
TrailingObjects::FixedSizeStorage constexpr fixes + tests
Jul 30 2016, 7:08 AM
hubert.reinterpretcast closed D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests.
Jul 30 2016, 7:08 AM
hubert.reinterpretcast committed rL277269: MathExtras.h: add LLVM_CONSTEXPR where simple.
MathExtras.h: add LLVM_CONSTEXPR where simple
Jul 30 2016, 6:46 AM
hubert.reinterpretcast closed D22824: MathExtras.h: add LLVM_CONSTEXPR where simple.
Jul 30 2016, 6:46 AM

Jul 29 2016

hubert.reinterpretcast retitled D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests from TrailingObjects::FixedSizeStorage constexpr fixes to TrailingObjects::FixedSizeStorage constexpr fixes + tests.
Jul 29 2016, 4:55 PM
hubert.reinterpretcast updated the diff for D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests.

Make FixedSizeStorage accessible to test code

Jul 29 2016, 4:11 PM
hubert.reinterpretcast updated the diff for D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests.

Make FixedSizeStorageOwner accessible to test code

Jul 29 2016, 3:45 PM
hubert.reinterpretcast updated the diff for D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests.

Replace call to LLVM_CONSTEXPR function in constant expression context

Jul 29 2016, 3:29 PM
hubert.reinterpretcast updated the diff for D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests.

Avoid MSVC C4099: replace 'struct' with 'class'

Jul 29 2016, 3:19 PM
hubert.reinterpretcast updated the diff for D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests.

Address review comments: add tests, access control, Doxygen

Jul 29 2016, 2:54 PM

Jul 28 2016

hubert.reinterpretcast added a comment to D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests.

I don't suppose there's a way to test these changes, is there?

It's a utility class (which is not even used yet). I am not aware of testing for the ADTs, etc. aside from using them internally. Perhaps I should mark the change as NFC?

Jul 28 2016, 9:04 PM
hubert.reinterpretcast added inline comments to D22824: MathExtras.h: add LLVM_CONSTEXPR where simple.
Jul 28 2016, 8:40 PM

Jul 26 2016

hubert.reinterpretcast retitled D22824: MathExtras.h: add LLVM_CONSTEXPR where simple from to MathExtras.h: add LLVM_CONSTEXPR where simple.
Jul 26 2016, 10:57 AM

Jul 25 2016

hubert.reinterpretcast added a comment to D22698: [libcxx] basic_regex: add traits_type, string_type .

This looks straightforward. @mclow.lists, are you okay with me committing this for Jason?

Jul 25 2016, 9:49 AM
hubert.reinterpretcast added a comment to D22702: [libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor.

Minor concerns noted. I'd be okay with this patch, but would like someone else to give the okay (or indicate what issues need to be addressed).

Jul 25 2016, 9:42 AM
hubert.reinterpretcast added a comment to D22745: Added -ftemplate-auto option to enable the template auto feature (P0127). I am the author of the proposal; I believe this to be a complete implementation. Currently, the feature is enabled through the use of the -ftemplate-auto option and is not....

I believe tests are necessary.

Jul 25 2016, 1:54 AM

Jul 22 2016

hubert.reinterpretcast retitled D22668: TrailingObjects::FixedSizeStorage constexpr fixes + tests from to TrailingObjects::FixedSizeStorage constexpr fixes.
Jul 22 2016, 2:57 AM

Jul 19 2016

hubert.reinterpretcast committed rL276074: Revert r276069: MSVC bots not happy.
Revert r276069: MSVC bots not happy
Jul 19 2016, 6:13 PM
hubert.reinterpretcast committed rL276073: Fix r276069: add default argument for new parameter.
Fix r276069: add default argument for new parameter
Jul 19 2016, 6:05 PM
hubert.reinterpretcast committed rL276071: Fix r276069: use LLVM_CONSTEXPR.
Fix r276069: use LLVM_CONSTEXPR
Jul 19 2016, 5:48 PM
hubert.reinterpretcast committed rL276069: Concepts: Create space for requires-clause in TemplateParameterList; NFC.
Concepts: Create space for requires-clause in TemplateParameterList; NFC
Jul 19 2016, 5:37 PM
hubert.reinterpretcast closed D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.
Jul 19 2016, 5:37 PM
hubert.reinterpretcast updated D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.
Jul 19 2016, 3:37 PM
hubert.reinterpretcast updated D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.
Jul 19 2016, 2:39 PM

Jul 15 2016

hubert.reinterpretcast abandoned D19771: Rework FixedSizeTemplateParameterListStorage.

This is superseded by D19322.

Jul 15 2016, 7:50 AM

Jun 25 2016

hubert.reinterpretcast committed rL273781: Reapply r273664 with workaround for MSVC.
Reapply r273664 with workaround for MSVC
Jun 25 2016, 4:31 AM
hubert.reinterpretcast closed D19770: Add FixedSizeStorage to TrailingObjects; NFC.
Jun 25 2016, 4:30 AM

Jun 24 2016

hubert.reinterpretcast added inline comments to D19770: Add FixedSizeStorage to TrailingObjects; NFC.
Jun 24 2016, 2:38 PM
hubert.reinterpretcast updated the diff for D19770: Add FixedSizeStorage to TrailingObjects; NFC.

Reapply r273664 with workaround for MSVC

Jun 24 2016, 2:35 PM
hubert.reinterpretcast reopened D19770: Add FixedSizeStorage to TrailingObjects; NFC.
Jun 24 2016, 2:35 PM
hubert.reinterpretcast added a comment to D19770: Add FixedSizeStorage to TrailingObjects; NFC.
Jun 24 2016, 2:31 PM
hubert.reinterpretcast committed rL273670: Revert r273664.
Revert r273664
Jun 24 2016, 5:32 AM
hubert.reinterpretcast committed rL273664: Add FixedSizeStorage to TrailingObjects; NFC.
Add FixedSizeStorage to TrailingObjects; NFC
Jun 24 2016, 4:41 AM
hubert.reinterpretcast closed D19770: Add FixedSizeStorage to TrailingObjects; NFC.
Jun 24 2016, 4:41 AM
hubert.reinterpretcast updated the diff for D19770: Add FixedSizeStorage to TrailingObjects; NFC.

Update to r273650 with the requested const accessor

Jun 24 2016, 1:59 AM

Jun 22 2016

hubert.reinterpretcast added inline comments to D19770: Add FixedSizeStorage to TrailingObjects; NFC.
Jun 22 2016, 6:59 AM

Jun 21 2016

hubert.reinterpretcast added a comment to D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.

Ping.

Jun 21 2016, 2:22 PM
hubert.reinterpretcast added a comment to D19770: Add FixedSizeStorage to TrailingObjects; NFC.

Ping.

Jun 21 2016, 11:36 AM

May 16 2016

hubert.reinterpretcast added a comment to D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.

Ping (#2).

May 16 2016, 2:11 PM

May 13 2016

hubert.reinterpretcast updated the diff for D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.

Set requires-clause when creating TemplateParameterLists; NFC

May 13 2016, 10:38 AM

May 9 2016

hubert.reinterpretcast added a comment to D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.

Ping.

May 9 2016, 6:51 AM

May 2 2016

hubert.reinterpretcast added a comment to D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.

@rsmith; I've addressed Faisal's comment. Please let me know if this patch (and D19770) is good to go. If it isn't ready yet, I'd like your opinion on D19770+D19771.

May 2 2016, 11:09 AM
hubert.reinterpretcast added a dependency for D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC: D19770: Add FixedSizeStorage to TrailingObjects; NFC.
May 2 2016, 11:00 AM
hubert.reinterpretcast added a dependent revision for D19770: Add FixedSizeStorage to TrailingObjects; NFC: D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.
May 2 2016, 11:00 AM
hubert.reinterpretcast updated the diff for D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC.

Address Faisal's comment; supercedes D19771

May 2 2016, 10:58 AM
hubert.reinterpretcast updated the diff for D19771: Rework FixedSizeTemplateParameterListStorage.

Adjust for changes to D19770

May 2 2016, 8:30 AM
hubert.reinterpretcast added a comment to D19770: Add FixedSizeStorage to TrailingObjects; NFC.

Responded to all comments.

May 2 2016, 8:11 AM
hubert.reinterpretcast updated the diff for D19770: Add FixedSizeStorage to TrailingObjects; NFC.

Replace alias template with struct and typedef member; add usage example

May 2 2016, 8:08 AM

May 1 2016

hubert.reinterpretcast planned changes to D19770: Add FixedSizeStorage to TrailingObjects; NFC.

The alias template hit a build-compiler bug: the substitution of the pack expansion of Counts does not work properly. I am investigating a replacement with a templated struct with a typedef member.

May 1 2016, 10:33 AM

Apr 30 2016

hubert.reinterpretcast updated the diff for D19770: Add FixedSizeStorage to TrailingObjects; NFC.

Use AlignOf<BaseTy> instead of AlignmentCalcHelper

Apr 30 2016, 4:33 PM
hubert.reinterpretcast added a dependent revision for D19770: Add FixedSizeStorage to TrailingObjects; NFC: D19771: Rework FixedSizeTemplateParameterListStorage.
Apr 30 2016, 3:23 PM
hubert.reinterpretcast added a dependency for D19771: Rework FixedSizeTemplateParameterListStorage: D19770: Add FixedSizeStorage to TrailingObjects; NFC.
Apr 30 2016, 3:23 PM