Page MenuHomePhabricator

shafik (Shafik Yaghmour)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2018, 2:31 PM (153 w, 4 d)

Recent Activity

Today

shafik added inline comments to D104488: Create synthetic symbol names on demand to improve memory consumption and startup times..
Mon, Jun 21, 4:06 PM · Restricted Project
shafik added inline comments to D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime..
Mon, Jun 21, 3:13 PM · Restricted Project
shafik added inline comments to D104404: Change PathMappingList::RemapPath to return an optional result (NFC).
Mon, Jun 21, 11:51 AM

Mon, Jun 14

shafik added a comment to D104041: [lldb] Replace default bodies of special member functions with = default;.

I am sure I could find a bunch of other ends and odds but perhaps you have other checks that will cover these coming up.

Mon, Jun 14, 9:19 AM

Fri, Jun 11

shafik added inline comments to D104067: [lldb] Decouple ObjCLanguage from Symtab.
Fri, Jun 11, 11:29 AM · Restricted Project

Tue, Jun 8

shafik committed rGae1a699554cf: [LLDB][NFC] Remove parameter names from forward declarations from hand written… (authored by shafik).
[LLDB][NFC] Remove parameter names from forward declarations from hand written…
Tue, Jun 8, 2:27 PM

Mon, Jun 7

shafik added inline comments to D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params..
Mon, Jun 7, 7:00 PM · Restricted Project

Wed, Jun 2

shafik added a comment to D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.

Thank you for doing this! This will be a big improvement.

Wed, Jun 2, 2:45 PM · Restricted Project
shafik accepted D103532: [lldb] Preserve type sugar when using SBValue::Dereference on C++ references.

Nice fix!

Wed, Jun 2, 9:57 AM · Restricted Project
shafik added inline comments to D103504: Improve performance when parsing symbol tables in mach-o files..
Wed, Jun 2, 9:47 AM · Restricted Project

Tue, Jun 1

shafik added inline comments to D103349: [lldb] Don't print script output twice in HandleCommand.
Tue, Jun 1, 11:43 AM · Restricted Project
shafik added inline comments to D103454: [lldb][docs] Document SBType.
Tue, Jun 1, 10:41 AM · Restricted Project
shafik added a comment to D103158: [lldb][NFC] Use Language plugins in Mangled::GuessLanguage.
Tue, Jun 1, 10:18 AM · Restricted Project

Thu, May 27

shafik accepted D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().

LGTM

Thu, May 27, 1:19 PM · Restricted Project
shafik added inline comments to D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo().
Thu, May 27, 9:31 AM · Restricted Project

Wed, May 26

shafik added inline comments to D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children.
Wed, May 26, 1:30 PM · Restricted Project

Tue, May 25

shafik accepted D103107: [lldb] Remove cache in get_demangled_name_without_arguments.

was there a bug that inspired this?

Tue, May 25, 3:33 PM · Restricted Project
shafik accepted D103084: [lldb][NFC] Use C++ versions of the deprecated C standard library headers.

Thank you for taking care of this, it was on my list of things to do.

Tue, May 25, 9:57 AM · Restricted Project

Mon, May 24

shafik accepted D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls.

LGTM

Mon, May 24, 2:05 PM · Restricted Project

May 21 2021

shafik added a comment to D102845: [lldb] Fix that LLDB doesn't print NaN's sign on Darwin.

LGTM besides my minor comment on headers. Thanks for fixing this!

May 21 2021, 2:13 PM · Restricted Project
shafik added a comment to D102845: [lldb] Fix that LLDB doesn't print NaN's sign on Darwin.

LGTM besides my minor comment on headers. Thanks for fixing this!

May 21 2021, 2:08 PM · Restricted Project
shafik added a reviewer for D102846: [lldb] Reimplement half2float: scanon.
May 21 2021, 11:08 AM · Restricted Project

May 18 2021

shafik added inline comments to D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.
May 18 2021, 1:31 PM · Restricted Project, Restricted Project
shafik added inline comments to D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.
May 18 2021, 9:49 AM · Restricted Project, Restricted Project

May 17 2021

shafik accepted D102640: [ASTimporter] Remove decl from lookup only if it has decl context.

This is a good catch, thank you for fixing this!

May 17 2021, 4:16 PM · Restricted Project
shafik added a comment to D102513: [lldb] Don't try to synthesize a result variable when doing code completion.

It took me a few minutes to see how the ASTResultSynthesizer was involved here and that is via the ASTTransformer(...) call. Maybe it makes sense to add a comment that helps to document this better so folks reading this later on understand the impact of skipping that call?

May 17 2021, 1:45 PM · Restricted Project
shafik committed rG2182eda30624: [LLDB] Switch from using member_clang_type.GetByteSize() to member_type… (authored by shafik).
[LLDB] Switch from using member_clang_type.GetByteSize() to member_type…
May 17 2021, 10:37 AM
shafik closed D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember.
May 17 2021, 10:36 AM · Restricted Project
shafik added inline comments to D102492: [clang][AST] Add support for BindingDecl to ASTImporter..
May 17 2021, 10:26 AM · Restricted Project

May 13 2021

shafik requested review of D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember.
May 13 2021, 2:41 PM · Restricted Project

May 10 2021

shafik added inline comments to D102085: Add an "interrupt timeout" to Process, fix a bug in handling interrupt timeouts in .
May 10 2021, 10:38 AM · Restricted Project

Apr 30 2021

shafik added a comment to D101627: [lldb] More tests for DumpDataExtractor.

I would resist this change. It's unnecessarily disruptive, would again break git archeology, and really have no significant benefit. I also think the lldb conventions for naming things are much clearer than the llvm ones. Knowing that something is a ivar by looking at the name is a real timesaver, especially for people new to the code. Being able to tell local variables from other entities by looking also makes reading code much easier. Etc...

I would be willing to discuss reformatting the llvm codebase to follow the lldb conventions, however...

Jim

Apr 30 2021, 11:39 AM · Restricted Project

Apr 29 2021

shafik added a comment to D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

LGTM, it seems like there a few places where we are not consistently checking m_impl_up is valid and other places we are using the conditional operator to check if it is set or not.

Apr 29 2021, 4:39 PM · Restricted Project
shafik added inline comments to D101462: [MC] Untangle MCContext and MCObjectFileInfo.
Apr 29 2021, 2:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
shafik added inline comments to D101462: [MC] Untangle MCContext and MCObjectFileInfo.
Apr 29 2021, 1:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
shafik added a comment to D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion.

Seems reasonable to me, I wonder why it was done that way originally?

Apr 29 2021, 9:50 AM · Restricted Project
shafik accepted D101153: [lldb][NFC] Specify guidelines for API tests.

I don't have any other feedback, LGTM.

Apr 29 2021, 9:32 AM · Restricted Project
shafik added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 29 2021, 9:30 AM · Restricted Project

Apr 28 2021

shafik added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 28 2021, 5:14 PM · Restricted Project
shafik added inline comments to D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.
Apr 28 2021, 1:28 PM · Restricted Project
shafik added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 28 2021, 11:35 AM · Restricted Project

Apr 26 2021

shafik added a comment to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

I think @dblaikie original idea of adding a DWARF attribute for this case is the right way to go here. AFAICT this will change the answer to basic questions such as what size a struct is and this will likely lead to confusion from our users who will expect the answers in expression parsing to match what they are seeing elsewhere e.g.:

Apr 26 2021, 6:33 PM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2021

shafik added inline comments to D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).
Apr 23 2021, 10:28 AM · Restricted Project
shafik added a comment to D101153: [lldb][NFC] Specify guidelines for API tests.

Thank you, this is awesome.

Apr 23 2021, 9:47 AM · Restricted Project

Apr 22 2021

shafik added inline comments to D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication().
Apr 22 2021, 1:41 PM · Restricted Project

Apr 20 2021

shafik added a comment to D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.

Thank you for reforactoring into ResetCxxMethodParser.

Apr 20 2021, 6:58 PM · Restricted Project

Apr 19 2021

shafik added inline comments to D100800: [lldb] Fix demangler leaks in the DWARF AST parser.
Apr 19 2021, 4:27 PM · Restricted Project
shafik added inline comments to D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
Apr 19 2021, 4:03 PM · Restricted Project

Apr 14 2021

shafik committed rGebee45713190: [LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash… (authored by shafik).
[LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash…
Apr 14 2021, 4:29 PM

Apr 9 2021

shafik committed rGd9c9c0b2db0d: [LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic (authored by shafik).
[LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic
Apr 9 2021, 12:07 PM
shafik added a comment to D100212: [lldb] Delete dead StackFrameList::Merge.

I think it is pretty safe to remove it after 10+ years is not being used.

Apr 9 2021, 11:15 AM · Restricted Project
shafik accepted D100180: [lldb] Don't recursively load types of static member variables in the DWARF AST parser.

LGTM

Apr 9 2021, 10:54 AM · Restricted Project

Apr 7 2021

shafik committed rG79ac5bbb96c4: [LLDB] Clarifying the documentation for variable formatting wrt to qualifiers… (authored by shafik).
[LLDB] Clarifying the documentation for variable formatting wrt to qualifiers…
Apr 7 2021, 2:31 PM
shafik closed D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this.
Apr 7 2021, 2:31 PM · Restricted Project
shafik updated the diff for D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this.

Updating test to use frame var test.

Apr 7 2021, 2:26 PM · Restricted Project

Apr 2 2021

shafik requested review of D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this.
Apr 2 2021, 6:25 PM · Restricted Project

Apr 1 2021

shafik added inline comments to D99694: Add support for getting signed ObjC tagged pointer values.
Apr 1 2021, 11:19 AM · Restricted Project

Mar 30 2021

shafik accepted D99576: [ASTImporter][NFC] Improve test coverage.

Thank you for adding these tests! LGTM

Mar 30 2021, 10:03 AM · Restricted Project
shafik added inline comments to D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses.
Mar 30 2021, 9:53 AM · Restricted Project
shafik added inline comments to D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses.
Mar 30 2021, 9:53 AM · Restricted Project

Mar 29 2021

shafik added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

If LLDB actually does _not_ have behavior change based on dialect, then we might as well control language codes based on DWARF version, and the patch should proceed.

@shafik Can you think of situations where LLDB is sensitive to the C++ version number as encoded in DWARF?

Mar 29 2021, 7:02 PM · debug-info, Restricted Project
shafik accepted D99421: [ASTImporter] Import member specialization/instantiation of enum decls.

LGTM

Mar 29 2021, 1:36 PM · Restricted Project

Mar 25 2021

shafik added inline comments to D99315: [lldb] Support lazily named classes in the Objective-C classes.
Mar 25 2021, 11:15 AM · Restricted Project

Mar 23 2021

shafik committed rGec00502b9f40: [NFC][LLDB] Removing extra semicolons to silence -Wc++98-compat-extra-semi… (authored by shafik).
[NFC][LLDB] Removing extra semicolons to silence -Wc++98-compat-extra-semi…
Mar 23 2021, 2:33 PM
shafik accepted D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType..

LGTM

Mar 23 2021, 10:08 AM · Restricted Project

Mar 22 2021

shafik added a comment to D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC)..

Thank you for adding the test!

Mar 22 2021, 10:29 AM · Restricted Project
shafik accepted D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl..

LGTM

Mar 22 2021, 10:25 AM · Restricted Project
shafik accepted D99077: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name.

LGTM

Mar 22 2021, 9:50 AM · Restricted Project

Mar 19 2021

shafik accepted D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC)..

Can we add a test for the getCapturedVLAType case?

Mar 19 2021, 9:44 AM · Restricted Project

Mar 18 2021

shafik added a comment to D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY.

Thank you for adding the commentary on what RTLD_LAZY

Mar 18 2021, 1:44 PM · Restricted Project
shafik added a reviewer for D98876: [clang][ASTImporter] Add import support for SourceLocExpr.: teemperor.
Mar 18 2021, 1:27 PM · Restricted Project

Mar 15 2021

shafik added inline comments to D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mar 15 2021, 2:33 PM · Restricted Project

Mar 1 2021

shafik added inline comments to D97739: Add a progress class that can track and report long running operations that happen in LLDB..
Mar 1 2021, 3:45 PM · Restricted Project

Feb 28 2021

shafik added a comment to D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb.

lldb change LGTM

Feb 28 2021, 6:31 PM · Restricted Project, Restricted Project

Feb 25 2021

shafik added reviewers for D50299: Migrate to llvm::unique_function instead of static member functions for callbacks: aprantl, teemperor, JDevlieghere.
Feb 25 2021, 5:10 PM · Restricted Project

Feb 24 2021

shafik added inline comments to D97239: [profile] Fix buffer overrun when parsing %c in filename string.
Feb 24 2021, 3:04 PM · Restricted Project

Feb 23 2021

shafik accepted D97300: [lldb] Add asserts that prevent construction of cycles in the decl origin tracking.

LGTM

Feb 23 2021, 3:18 PM · Restricted Project
shafik added inline comments to D97249: [lldb] Support debugging utility functions.
Feb 23 2021, 9:48 AM · Restricted Project

Feb 22 2021

shafik added inline comments to D97205: [lldb][NFC] Don't inherit from UserID in ValueObject.
Feb 22 2021, 2:54 PM · Restricted Project
shafik committed rG50542d504dd8: Modify TypePrinter to differentiate between anonymous struct and unnamed struct (authored by shafik).
Modify TypePrinter to differentiate between anonymous struct and unnamed struct
Feb 22 2021, 2:17 PM

Feb 19 2021

shafik updated the diff for D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct.

Fixing tests that I missed before.

Feb 19 2021, 3:24 PM · Restricted Project, Restricted Project

Feb 18 2021

shafik added a comment to D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct.

Reverted the changes because I missed the clangd test suite and don't know how long it will take to fix.

Feb 18 2021, 6:18 PM · Restricted Project, Restricted Project
shafik added a reverting change for rGecb90b55454e: Modify TypePrinter to differentiate between anonymous struct and unnamed struct: rG9068dab1fdde: Revert "Modify TypePrinter to differentiate between anonymous struct and….
Feb 18 2021, 6:18 PM
shafik committed rG9068dab1fdde: Revert "Modify TypePrinter to differentiate between anonymous struct and… (authored by shafik).
Revert "Modify TypePrinter to differentiate between anonymous struct and…
Feb 18 2021, 6:18 PM
shafik added a reverting change for rG1e0819395657: Fix for Modify TypePrinter to differentiate between anonymous struct and…: rG080ba851c616: Revert "Fix for Modify TypePrinter to differentiate between anonymous struct….
Feb 18 2021, 6:17 PM
shafik committed rG080ba851c616: Revert "Fix for Modify TypePrinter to differentiate between anonymous struct… (authored by shafik).
Revert "Fix for Modify TypePrinter to differentiate between anonymous struct…
Feb 18 2021, 6:17 PM
shafik added a reverting change for D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct: rG9068dab1fdde: Revert "Modify TypePrinter to differentiate between anonymous struct and….
Feb 18 2021, 6:17 PM · Restricted Project, Restricted Project
shafik committed rG1e0819395657: Fix for Modify TypePrinter to differentiate between anonymous struct and… (authored by shafik).
Fix for Modify TypePrinter to differentiate between anonymous struct and…
Feb 18 2021, 5:58 PM
shafik committed rGecb90b55454e: Modify TypePrinter to differentiate between anonymous struct and unnamed struct (authored by shafik).
Modify TypePrinter to differentiate between anonymous struct and unnamed struct
Feb 18 2021, 5:45 PM
shafik closed D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct.
Feb 18 2021, 5:45 PM · Restricted Project, Restricted Project

Feb 17 2021

shafik added inline comments to D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct.
Feb 17 2021, 2:33 PM · Restricted Project, Restricted Project
shafik updated the diff for D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct.
  • Went with unnamed enums Vs anonymous enums
Feb 17 2021, 2:32 PM · Restricted Project, Restricted Project
shafik added a comment to D96861: [lldb][NFC] Delete deleted const char* overloads of SetValueFromString.

Nice catch!

Feb 17 2021, 10:37 AM · Restricted Project

Feb 16 2021

shafik added a comment to D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct.

Note: I am not fixing how we treat anonymous and unnamed enums, I could not find a way to figure out if an enum was anonymous or not.

Feb 16 2021, 11:52 AM · Restricted Project, Restricted Project
shafik requested review of D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct.
Feb 16 2021, 11:50 AM · Restricted Project, Restricted Project

Feb 12 2021

shafik added inline comments to D96537: Make the error condition in Value::ValueType explicit (NFC).
Feb 12 2021, 10:23 PM
shafik accepted D96537: Make the error condition in Value::ValueType explicit (NFC).

LGTM

Feb 12 2021, 2:23 PM
shafik committed rG9f175998debc: [LLDB] Fix LLDB_LOG calls to use correct formatting (authored by shafik).
[LLDB] Fix LLDB_LOG calls to use correct formatting
Feb 12 2021, 11:10 AM
shafik closed D96550: Fix LLDB_LOG calls to use correct formatting.
Feb 12 2021, 11:09 AM · Restricted Project
shafik accepted D96334: Correctly recognize bitfields when emitting dwarf.
Feb 12 2021, 9:42 AM · Restricted Project