- User Since
- Jul 12 2018, 2:31 PM (206 w, 6 d)
and run the test case, the first added line prints 1 and the second one 0. Result is being mutated when doing the in-place evaluation.
Tue, Jun 28
Thank for looking at this bug, just a small comment on the test.
I think I need to do another sweep of this PR but mostly minor comments.
Mon, Jun 27
Are you sure it is failing on the line you indicated? After looking at the code, a little before that line we have:
May 11 2022
Any update/further details here?
May 4 2022
- Expanded test
- applied clang-format
Apr 27 2022
You might want to try fun cases like operator< and operator()() from a lambda. They should work but might be worth throwing them in.
Apr 26 2022
Apr 25 2022
This mostly makes sense, the purpose of the || alternate_defn was not clear to me either.
Apr 22 2022
Apr 21 2022
-Replacing CHECK-NEXT with CHECK
Apr 20 2022
Thank you, the names make a lot more sense to me but I am not sure why this was originally used either.
Apr 19 2022
-Removed override RemoteAwarePlatformTest.cpp and added NOLINT
Apr 18 2022
- Making test more robust
- Adding comments
Apr 11 2022
Adding test case
Apr 7 2022
I did some experiments where I did not restrict this to lambdas case and I could not come up with a test case where we emit debug info and do not have the deduced type.
Apr 4 2022
Apr 1 2022
Mar 31 2022
- Applied clang-format
- Address Pavel's comment
Mar 30 2022
I believe that NSIndexPathSyntheticFrontEnd::Update() also needs a fix in order to properly set the active member but I will do that as a separate fix since.
Mar 29 2022
Mar 24 2022
Mar 21 2022
Do we have any tests for these?
Mar 17 2022
Mar 16 2022
We sure do have a lot of CommandOptions classes out there.
Note, we have a few tests that cover LoadImage:
Mar 15 2022
Fixing up diff
I think this PR broke green dragon incremental build: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/42185/
Removing dead code.
Mar 14 2022
Can you add a test to ASTImpoterTest.cpp that checks that we import the LambdaDependencyKind correctly?
Mar 11 2022
Mar 10 2022
This is just prep work for another change then?
There can probably be some more refactoring wrt to the Value class which also does a lot of the same work but there are enough differences that I think any attempt at that should be left for a separate PR.
Mar 8 2022
Mar 7 2022
This make sense to me at a first pass, please make sure you run check-lldb as well.
Mar 4 2022
Mar 3 2022
As a side note, I noticed that we don't prefix typedefs from cstdint with std:: e.g. size_t. These typedefs are not guaranteed to be in the global namespace.
Looks like it also broke lldb green dragon incremental as well: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41865/consoleFull#-27141295349ba4694-19c4-4d7e-bec5-911270d8a58c
Moved to using namespace lldb_private::dwarf everywhere since the consensus is that being verbose is preferred.
Mar 2 2022
Updating diff based on comments
I used using namespace in a few functions but I am not committed to this approach. So I am happy to hear feedback on whether we want to just use fully qualified names everywhere instead or nail down a criteria as to when it is acceptable.
Mar 1 2022
Feb 27 2022
Looks like this PR broke the green dragon bot, see: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41771/consoleFull#10309019849ba4694-19c4-4d7e-bec5-911270d8a58c
Feb 21 2022
Feb 17 2022
Feb 16 2022
Looks like the scripted_crashlog_json.test is broken on green dragon: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41454/testReport/junit/lldb-shell/ScriptInterpreter_Python_Crashlog/scripted_crashlog_json_test/
Used shorter options for renaming based on feedback.
Feb 15 2022
Do we have a test that covers this edge case?
Addressed comments on SmallVector size and fixed test.