- User Since
- Jul 12 2018, 2:31 PM (44 w, 4 d)
Wed, May 15
I ran check-lldb and I hit one regression in TestFormatters.py, part of what I am seeing is as follows:
@friss we have several bugs, once of which I can reproduce but I have not been able to reduce it to a minimal case yet and the nullptr check is obviously the right to do.
Simplified the checking of symbol being a nullptr
Tue, May 14
Done with first round.
Mon, May 13
Fri, May 10
Thu, May 9
Fri, May 3
Updating after https://reviews.llvm.org/D46551 landed
Thu, May 2
Thank you! LGTM, in general we avoid "large" refactoring changes to avoid polluting the blame list but the changes are relatively local and they are good changes that can catch real bugs in the future. I would like a second set of eyes though.
Wed, May 1
Modifying copy contructor to be act more intuitively.
Testing both passing as and argument and returning
@friss added second test
@teemperor good call, that is indeed simpler and yes I did not intend that delete.
- Simplifying test
- Fixing unintended deleted test
Tue, Apr 30
This is a good change!
Changed to reflect comments.
- Added comments to test to explain what it is doing.
- Formatting and other minor fixes.
@friss makes sense, updated comment.
Updated comment to be more precise.
Mon, Apr 29
Fred is correct, I mistakenly thought the parts of the test that were working were being covered elsewhere but that is not the case. So I have reworked this change to instead of skipping the whole test to comment out the inline expressions that are specifically broken.
@friss updated the change to only effect those specifically broken.
Fri, Apr 26
Thu, Apr 25
@rsmith I tagged you in this change in case we are missing any implications in using DW_CC_pass_by_reference to do setArgPassingRestrictions(clang::RecordDecl::APK_CannotPassInRegs);
Wed, Apr 24
Apr 15 2019
Small updated to test, remove use of printf and associated include.
Apr 11 2019
Apr 10 2019
@friss I had to rework the tests a little but they now cover Objective-C static and non-static methods as well as C and C++.
-Adjusting tests to ensure coverage of Objecive-C static and non-static methods and C and C++
Apr 9 2019
@friss I believe I have addressed your comments
- Now applies to all languages not just C++
- When adding locals be more selective on filtering i.e. only filter self and _cmd for Objective C etc...
Apr 8 2019
Mar 28 2019
@stella.stamenova I committed a fix, please let me know if this does not address the regression:
Mar 27 2019
Fixes based on comments.
Mar 26 2019
LLDB regression test that goes with this fix: https://reviews.llvm.org/D59847
It looks like this breaks the lldb build bots, more specifically it looks like all modules builds are broken, see the following log:
Mar 25 2019
@martong your idea does not work b/c default construction DeclarationName() treats it the same as being empty. So if (!Name) is still true.