It took me a few minutes to see how the ASTResultSynthesizer was involved here and that is via the ASTTransformer(...) call. Maybe it makes sense to add a comment that helps to document this better so folks reading this later on understand the impact of skipping that call?

May 17 2021, 1:45 PM · Restricted Project

shafik committed rG2182eda30624: [LLDB] Switch from using member_clang_type.GetByteSize() to member_type… (authored by shafik).

[LLDB] Switch from using member_clang_type.GetByteSize() to member_type…

May 17 2021, 10:37 AM

shafik closed D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember.

May 17 2021, 10:36 AM · Restricted Project

shafik added inline comments to D102492: [clang][AST] Add support for BindingDecl to ASTImporter..

May 17 2021, 10:26 AM · Restricted Project

May 13 2021

shafik requested review of D102445: Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember.

May 13 2021, 2:41 PM · Restricted Project

May 10 2021

shafik added inline comments to D102085: Add an "interrupt timeout" to Process, fix a bug in handling interrupt timeouts in .

May 10 2021, 10:38 AM · Restricted Project

Apr 30 2021

shafik added a comment to D101627: [lldb] More tests for DumpDataExtractor.

In D101627#2729594, @jingham wrote:

I would resist this change. It's unnecessarily disruptive, would again break git archeology, and really have no significant benefit. I also think the lldb conventions for naming things are much clearer than the llvm ones. Knowing that something is a ivar by looking at the name is a real timesaver, especially for people new to the code. Being able to tell local variables from other entities by looking also makes reading code much easier. Etc...

I would be willing to discuss reformatting the llvm codebase to follow the lldb conventions, however...

Jim

Apr 30 2021, 11:39 AM · Restricted Project

Apr 29 2021

shafik added a comment to D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

LGTM, it seems like there a few places where we are not consistently checking m_impl_up is valid and other places we are using the conditional operator to check if it is set or not.

Apr 29 2021, 4:39 PM · Restricted Project

shafik added inline comments to D101462: [MC] Untangle MCContext and MCObjectFileInfo.

Apr 29 2021, 2:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

shafik added inline comments to D101462: [MC] Untangle MCContext and MCObjectFileInfo.

Apr 29 2021, 1:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

shafik added a comment to D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion.

Seems reasonable to me, I wonder why it was done that way originally?

Apr 29 2021, 9:50 AM · Restricted Project

shafik accepted D101153: [lldb][NFC] Specify guidelines for API tests.

I don't have any other feedback, LGTM.

Apr 29 2021, 9:32 AM · Restricted Project

shafik added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

Apr 29 2021, 9:30 AM · Restricted Project

Apr 28 2021

shafik added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

Apr 28 2021, 5:14 PM · Restricted Project

shafik added inline comments to D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely.

Apr 28 2021, 1:28 PM · Restricted Project

shafik added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

Apr 28 2021, 11:35 AM · Restricted Project

Apr 26 2021

shafik added a comment to D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr.

I think @dblaikie original idea of adding a DWARF attribute for this case is the right way to go here. AFAICT this will change the answer to basic questions such as what size a struct is and this will likely lead to confusion from our users who will expect the answers in expression parsing to match what they are seeing elsewhere e.g.:

Apr 26 2021, 6:33 PM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2021

shafik added inline comments to D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI).

Apr 23 2021, 10:28 AM · Restricted Project

shafik added a comment to D101153: [lldb][NFC] Specify guidelines for API tests.

Thank you, this is awesome.

Apr 23 2021, 9:47 AM · Restricted Project

Apr 22 2021

shafik added inline comments to D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication().

Apr 22 2021, 1:41 PM · Restricted Project

Apr 20 2021

shafik added a comment to D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.

Thank you for reforactoring into ResetCxxMethodParser.

Apr 20 2021, 6:58 PM · Restricted Project

Apr 19 2021

shafik added inline comments to D100800: [lldb] Fix demangler leaks in the DWARF AST parser.

Apr 19 2021, 4:27 PM · Restricted Project

shafik added inline comments to D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.

Apr 19 2021, 4:03 PM · Restricted Project

Apr 14 2021

shafik committed rGebee45713190: [LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash… (authored by shafik).

[LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash…

Apr 14 2021, 4:29 PM

Apr 9 2021

shafik committed rGd9c9c0b2db0d: [LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic (authored by shafik).

[LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic

Apr 9 2021, 12:07 PM

shafik added a comment to D100212: [lldb] Delete dead StackFrameList::Merge.

I think it is pretty safe to remove it after 10+ years is not being used.

Apr 9 2021, 11:15 AM · Restricted Project

shafik accepted D100180: [lldb] Don't recursively load types of static member variables in the DWARF AST parser.

LGTM

Apr 9 2021, 10:54 AM · Restricted Project

Apr 7 2021

shafik committed rG79ac5bbb96c4: [LLDB] Clarifying the documentation for variable formatting wrt to qualifiers… (authored by shafik).

[LLDB] Clarifying the documentation for variable formatting wrt to qualifiers…

Apr 7 2021, 2:31 PM

shafik closed D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this.

Apr 7 2021, 2:31 PM · Restricted Project

shafik updated the diff for D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this.

Updating test to use frame var test.

Apr 7 2021, 2:26 PM · Restricted Project

Apr 2 2021

shafik requested review of D99827: Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this.

Apr 2 2021, 6:25 PM · Restricted Project

Apr 1 2021

shafik added inline comments to D99694: Add support for getting signed ObjC tagged pointer values.

Apr 1 2021, 11:19 AM · Restricted Project

Mar 30 2021

shafik accepted D99576: [ASTImporter][NFC] Improve test coverage.

Thank you for adding these tests! LGTM

Mar 30 2021, 10:03 AM · Restricted Project

shafik added inline comments to D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses.

Mar 30 2021, 9:53 AM · Restricted Project

shafik added inline comments to D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses.

Mar 30 2021, 9:53 AM · Restricted Project

Mar 29 2021

shafik added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

In D99250#2657390, @aprantl wrote:

If LLDB actually does _not_ have behavior change based on dialect, then we might as well control language codes based on DWARF version, and the patch should proceed.

@shafik Can you think of situations where LLDB is sensitive to the C++ version number as encoded in DWARF?

Mar 29 2021, 7:02 PM · debug-info, Restricted Project

shafik accepted D99421: [ASTImporter] Import member specialization/instantiation of enum decls.

LGTM

Mar 29 2021, 1:36 PM · Restricted Project