Page MenuHomePhabricator

shafik (Shafik Yaghmour)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2018, 2:31 PM (132 w, 23 h)

Recent Activity

Today

shafik committed rGdc057e87f6c1: [LLDB] Fix how ObjCBOOLSummaryProvider deals with BOOL (authored by shafik).
[LLDB] Fix how ObjCBOOLSummaryProvider deals with BOOL
Fri, Jan 22, 10:06 AM

Wed, Jan 20

shafik added a comment to D95096: [lldb][import-std-module] Do some basic file checks before trying to import a module.

LGTM, I will let Jonas approve since he has some issues that need addressing.

Wed, Jan 20, 4:14 PM · Restricted Project
shafik accepted D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr..

LGTM, thank you for expanding the test!

Wed, Jan 20, 9:43 AM · Restricted Project

Fri, Jan 15

shafik added inline comments to D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr..
Fri, Jan 15, 1:58 PM · Restricted Project

Wed, Jan 6

shafik accepted D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'..
Wed, Jan 6, 9:32 AM · Restricted Project
shafik added inline comments to D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'..
Wed, Jan 6, 9:32 AM · Restricted Project

Tue, Jan 5

shafik added inline comments to D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'..
Tue, Jan 5, 3:49 PM · Restricted Project
shafik added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

We can have unscoped enums in namespace and class scope and the enumerators won't leak out from those scopes. Thus we can have shadowing going on e.g.:

Tue, Jan 5, 10:30 AM · Restricted Project

Dec 18 2020

shafik added inline comments to D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe..
Dec 18 2020, 6:53 PM · Restricted Project
shafik updated the diff for D93421: Fix how ValueObject deals with getting unsigned values.
  • Fixed formatters::ObjCBOOLSummaryProvider to use int8_t and fixed the Printf
  • Updated tests
Dec 18 2020, 4:55 PM
shafik added inline comments to D93421: Fix how ValueObject deals with getting unsigned values.
Dec 18 2020, 4:54 PM

Dec 17 2020

shafik updated the diff for D93421: Fix how ValueObject deals with getting unsigned values.

Updating diff to reflect comments.

Dec 17 2020, 4:05 PM
shafik added a comment to D93421: Fix how ValueObject deals with getting unsigned values.

After chatting with Raphael offline, we realize that BOOL will indeed always be signed. I was under the impression for some reason that it was actually unsigned. So the fix is simpler is that we just need to make the formatter use GetValueAsSigned(...)

Dec 17 2020, 4:05 PM

Dec 16 2020

shafik added a comment to D93421: Fix how ValueObject deals with getting unsigned values.

I am not sure if I need to worry about ValueObject::IsLogicalTrue(...) as well.

Dec 16 2020, 2:59 PM
shafik updated subscribers of D93421: Fix how ValueObject deals with getting unsigned values.
Dec 16 2020, 2:57 PM
shafik requested review of D93421: Fix how ValueObject deals with getting unsigned values.
Dec 16 2020, 2:57 PM

Dec 10 2020

shafik accepted D92962: [ASTImporter] Fix import of a typedef that has an attribute.
Dec 10 2020, 9:06 AM · Restricted Project

Dec 9 2020

shafik added a comment to D92962: [ASTImporter] Fix import of a typedef that has an attribute.

LGTM

Dec 9 2020, 3:18 PM · Restricted Project
shafik accepted D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module.
Dec 9 2020, 2:03 PM · Restricted Project

Dec 8 2020

shafik accepted D92772: [lldb] Fix that symbols.clang-modules-cache-path is never initialized.

LGTM

Dec 8 2020, 11:20 AM · Restricted Project
shafik added a comment to D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules..

Should the test also include types that don't come from modules, just to make sure there are no odd interactions with this change.

Dec 8 2020, 10:50 AM · Restricted Project
shafik added a comment to D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module.

LGTM but I have one questions and I am also curious about Adrian's question about returning by reference.

Dec 8 2020, 9:54 AM · Restricted Project

Dec 4 2020

shafik committed rG6333871f8540: Add diagnostic for for-range-declaration being specificed with thread_local (authored by shafik).
Add diagnostic for for-range-declaration being specificed with thread_local
Dec 4 2020, 3:07 PM
shafik closed D92671: Add diagnostic for for-range-declaration being specificed with thread_local.
Dec 4 2020, 3:06 PM · Restricted Project
shafik added a comment to D92671: Add diagnostic for for-range-declaration being specificed with thread_local.

The problem with this approach is given:

Dec 4 2020, 10:24 AM · Restricted Project
shafik requested review of D92671: Add diagnostic for for-range-declaration being specificed with thread_local.
Dec 4 2020, 10:23 AM · Restricted Project

Dec 3 2020

shafik added a comment to D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..

ASTImporter changes looks good to me.

Dec 3 2020, 1:52 PM · Restricted Project

Dec 2 2020

shafik accepted D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC.
Dec 2 2020, 6:35 PM · Restricted Project
shafik added a comment to D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC.

LGTM

Dec 2 2020, 6:35 PM · Restricted Project
shafik added inline comments to D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.
Dec 2 2020, 5:08 PM · Restricted Project
shafik added inline comments to D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC.
Dec 2 2020, 3:34 PM · Restricted Project, Restricted Project
shafik added a comment to D92510: [lldb] set created function decl to public access in TypeSystemClang.

+1 to what @teemperor said

Dec 2 2020, 2:49 PM · Restricted Project
shafik added a comment to D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.

Should we add a test for the regular function template case as well?

I think this issue is specific for a CXXDeductionGuideDecl which is a FunctionDecl. I am not sure if I can follow what kind of test do you suggest, could you please be more specific?

Dec 2 2020, 2:21 PM · Restricted Project

Dec 1 2020

shafik accepted D92425: [lldb] Don't reject empty or unnamed template parameter packs.

LGTM

Dec 1 2020, 3:33 PM · Restricted Project
shafik added a comment to D92425: [lldb] Don't reject empty or unnamed template parameter packs.

There is also alias templates:

Dec 1 2020, 3:33 PM · Restricted Project

Nov 30 2020

shafik added a comment to D92016: [ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls.

Great catch!

Nov 30 2020, 9:20 PM · Restricted Project
shafik added inline comments to D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl.
Nov 30 2020, 2:54 PM · Restricted Project, Restricted Project
shafik added inline comments to D92106: [ASTImporter] Import the default argument of NonTypeTemplateParmDecl.
Nov 30 2020, 2:13 PM · Restricted Project
shafik added inline comments to D92223: [lldb] Add support for looking up static const members.
Nov 30 2020, 2:04 PM · Restricted Project
shafik added a comment to D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.

Should we add a test for the regular function template case as well?

Nov 30 2020, 11:54 AM · Restricted Project

Nov 19 2020

shafik added inline comments to D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64.
Nov 19 2020, 4:33 PM · Restricted Project
shafik committed rG0fd04337a171: [LLDB] Fixing lldb/test/Shell/Register/x86-fp-write.test (authored by shafik).
[LLDB] Fixing lldb/test/Shell/Register/x86-fp-write.test
Nov 19 2020, 4:32 PM
shafik added a comment to D91574: [libc++] Simplify how we pick the typeinfo comparison.
Nov 19 2020, 10:00 AM · Restricted Project
shafik accepted D91801: [lldb] Fix incorrect error handling in GDBRemoteCommunicationClient::SendGetSupportedTraceType.

LGTM, there are no tests currently?

Nov 19 2020, 9:54 AM · Restricted Project
shafik accepted D91723: [lldb] Fix that running a top level expression without a process fails with a cryptic error.

LGTM

Nov 19 2020, 9:51 AM

Nov 18 2020

shafik added a comment to D91574: [libc++] Simplify how we pick the typeinfo comparison.

I think your CMakeLists.txt broke the green dragon build: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/24893/consoleFull#349140555e9a0fee5-ebcc-4238-a641-c5aa112c323e

Nov 18 2020, 2:34 PM · Restricted Project
shafik added a comment to D91723: [lldb] Fix that running a top level expression without a process fails with a cryptic error.

Interesting so we always had the error Top-level code needs to be inserted into a runnable target but we just were not triggering it before?

Nov 18 2020, 2:30 PM

Nov 12 2020

shafik committed rGbae9aedb341c: [LLDB] Fix handling of bit-fields in a union (authored by shafik).
[LLDB] Fix handling of bit-fields in a union
Nov 12 2020, 2:09 PM
shafik closed D91118: Fix handling of bit-fields in a union.
Nov 12 2020, 2:09 PM · Restricted Project

Nov 10 2020

shafik accepted D81550: [lldb] Add support for evaluating expressions in static member functions.

LGTM besides the minor comments.

Nov 10 2020, 7:03 PM
shafik updated the diff for D91118: Fix handling of bit-fields in a union.

Add a check to make sure the bit offset is zero for fields in a union.

Nov 10 2020, 4:22 PM · Restricted Project
shafik added a comment to D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr.

So this work for primitive types like int* etc?

Nov 10 2020, 12:07 PM · Restricted Project

Nov 9 2020

shafik requested review of D91118: Fix handling of bit-fields in a union.
Nov 9 2020, 8:54 PM · Restricted Project

Nov 2 2020

shafik added inline comments to D90568: [clang] Add [is|set]Nested methods to NamespaceDecl.
Nov 2 2020, 4:13 PM · Restricted Project
shafik accepted D90553: Rename CXXUnresolvedConstructExpr::arg_size for consistency.
Nov 2 2020, 9:56 AM · Restricted Project

Oct 26 2020

shafik accepted D82770: [lldb] Add support for using variables with C++ keywords names in non-C++ expressions.

LGTM

Oct 26 2020, 4:15 PM · Restricted Project

Oct 22 2020

shafik accepted D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC.

LGTM

Oct 22 2020, 10:44 PM · Restricted Project

Oct 21 2020

shafik accepted D89914: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC.

LGTM, this feels cleaner.

Oct 21 2020, 8:32 PM · Restricted Project
shafik added inline comments to D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC.
Oct 21 2020, 9:26 AM · Restricted Project

Oct 16 2020

shafik added a comment to D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName().

test?

Oct 16 2020, 3:59 PM · Restricted Project

Oct 13 2020

shafik added inline comments to D89351: Move initialization of Variable::m_loc_is_const_data into constructor (NFC).
Oct 13 2020, 5:05 PM
shafik accepted D89310: [lldb] Reject redefinitions of persistent variables.

makes sense, LGTM.

Oct 13 2020, 10:17 AM · Restricted Project
shafik accepted D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex.

LGTM

Oct 13 2020, 10:05 AM · Restricted Project
shafik accepted D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr.

LGTM

Oct 13 2020, 8:11 AM · Restricted Project

Oct 8 2020

shafik added a comment to D88780: Allow interfaces to operate on in-memory buffers with no source location info..

This looks reasonable, I am guessing we can't test this b/c it would only come up in a cling use case?

Oct 8 2020, 9:52 AM · Restricted Project
shafik added a reviewer for D88780: Allow interfaces to operate on in-memory buffers with no source location info.: teemperor.
Oct 8 2020, 9:36 AM · Restricted Project

Oct 7 2020

shafik accepted D88992: [lldb] Fix "frame var" for large bitfields.

LGTM I notice that we are using m_byte_offset directly a little above the line you fixed instead of GetByteOffset().

Oct 7 2020, 2:39 PM · Restricted Project

Oct 6 2020

shafik added a comment to D66782: SourceManager: Prefer Optional<MemoryBufferRef> over MemoryBuffer*.

ASTImporter changes looks good.

Oct 6 2020, 5:18 PM · Restricted Project
shafik added a comment to D88792: [lldb/test] Catch invalid calls to expect().

I am happy this was not hiding any regressions.

Oct 6 2020, 11:06 AM · Restricted Project
shafik accepted D88889: [lldb] Allow limiting the number of error diagnostics when parsing an expression.

LGTM

Oct 6 2020, 9:31 AM · Restricted Project

Oct 2 2020

shafik added a comment to D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl.

So was the bug we were saying there were falsely equivalent or falsely not equivalent?

I think the bug is the crash :)

Yes. More specifically, the call of getBitWidthValue() caused a segfault with release builds and with assertions enabled it caused the mentioned assert on the given test code.

Oct 2 2020, 11:11 AM · Restricted Project

Oct 1 2020

shafik added a comment to D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl.

So was the bug we were saying there were falsely equivalent or falsely not equivalent?

Oct 1 2020, 5:04 PM · Restricted Project

Sep 24 2020

shafik accepted D88270: Add a verifier check that rejects non-distinct DISubprogram function attachments..

LGTM

Sep 24 2020, 5:54 PM · Restricted Project
shafik committed rGa079f619b5a1: [LLDB] Add a defensive check for member__f_ (authored by shafik).
[LLDB] Add a defensive check for member__f_
Sep 24 2020, 2:48 PM

Sep 21 2020

shafik committed rG6807f244fa67: [ASTImporter] Modifying ImportDeclContext(...) to ensure that we also handle… (authored by shafik).
[ASTImporter] Modifying ImportDeclContext(...) to ensure that we also handle…
Sep 21 2020, 2:57 PM
shafik closed D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl.
Sep 21 2020, 2:57 PM · Restricted Project, Restricted Project
shafik added a reviewer for D87868: [RFC] When calling the process mmap try to call all found instead of just the first one: vsk.
Sep 21 2020, 2:34 PM · Restricted Project
shafik added a reviewer for D87868: [RFC] When calling the process mmap try to call all found instead of just the first one: teemperor.
Sep 21 2020, 2:32 PM · Restricted Project

Sep 17 2020

shafik updated the diff for D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl.

Fix handling of multi-dimensional arrays.

Sep 17 2020, 1:35 PM · Restricted Project, Restricted Project

Sep 16 2020

Herald added a reviewer for D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl: JDevlieghere.

We are going to move forward with this approach (after dealing with the multi-dimensional array case) temporarily. We are seeing crash bugs from this from users and we want to fix it while we explore the solution space more.

Sep 16 2020, 3:19 PM · Restricted Project, Restricted Project

Sep 13 2020

shafik added inline comments to D87441: Speedup collecting DWARF attribute values.
Sep 13 2020, 9:43 PM · Restricted Project

Sep 8 2020

shafik accepted D87289: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when trying to complete a forward decl.

LGTM

Sep 8 2020, 1:46 PM · Restricted Project

Sep 3 2020

shafik updated subscribers of D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl.

@martong I have been experimenting w/ how we pass around ImportDefinitionKind and pushing it through to more places does not help. I also tried defaulting most locations to IDK_Everything to experiment to see if maybe I was missing some crucial point and no luck. So while it seemed like a good direction it has not worked out, unless I missed something in your idea.

Sep 3 2020, 1:41 PM · Restricted Project, Restricted Project

Aug 27 2020

shafik added inline comments to D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl.
Aug 27 2020, 2:19 PM · Restricted Project, Restricted Project

Aug 26 2020

shafik accepted D86615: [lldb/DWARF] Fix handling of variables with both location and const_value attributes.

LGTM with minor comments. Thank you for these fixes, they are awesome!

Aug 26 2020, 3:12 PM · Restricted Project
shafik requested review of D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl.
Aug 26 2020, 1:53 PM · Restricted Project, Restricted Project

Aug 24 2020

shafik committed rG93b255142bb7: [LLDB] Fix how ValueObjectVariable handles DW_AT_const_value when the… (authored by shafik).
[LLDB] Fix how ValueObjectVariable handles DW_AT_const_value when the…
Aug 24 2020, 3:17 PM
shafik closed D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value.
Aug 24 2020, 3:17 PM · Restricted Project
shafik added inline comments to D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value.
Aug 24 2020, 2:14 PM · Restricted Project
shafik updated the diff for D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value.

-Add REQUIRES x86

  • Fix-up the comments in the test
Aug 24 2020, 1:42 PM · Restricted Project
shafik added inline comments to D86436: [lldb] Fix Type::GetByteSize for pointer types.
Aug 24 2020, 10:18 AM · Restricted Project
shafik added inline comments to D86436: [lldb] Fix Type::GetByteSize for pointer types.
Aug 24 2020, 10:06 AM · Restricted Project

Aug 21 2020

shafik added inline comments to D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value.
Aug 21 2020, 6:47 AM · Restricted Project
shafik added a comment to D86348: [lldb/DWARF] More DW_AT_const_value fixes.

Thank you finding these additional fixed, it looks good but I don't know some of the details as well as Adrian so I would prefer he gives the LGTM.

Aug 21 2020, 6:43 AM · Restricted Project

Aug 20 2020

shafik requested review of D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value.
Aug 20 2020, 11:22 AM · Restricted Project

Aug 18 2020

shafik accepted D86140: [lldb] Add typedefs to the DeclContext they are created in.

This is nice catch! LGTM

Aug 18 2020, 10:11 AM · Restricted Project

Aug 13 2020

shafik accepted D85904: [lldb] Check Decl kind when completing -flimit-debug-info types.

Minor comment but LGTM, nice fix!

Aug 13 2020, 2:07 PM · Restricted Project
shafik committed rG25bbceb047a3: [LLDB] Fix how ValueObjectChild handles bit-fields stored in a Scalar in… (authored by shafik).
[LLDB] Fix how ValueObjectChild handles bit-fields stored in a Scalar in…
Aug 13 2020, 11:53 AM
shafik closed D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue() .
Aug 13 2020, 11:53 AM · Restricted Project
shafik accepted D85648: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl.

LGTM, it is sad we lose the deterministic ordering though. Would it be efficient enough to use a vector but keep the set to prevent duplicates?

Aug 13 2020, 11:42 AM · Restricted Project