Page MenuHomePhabricator

shafik (Shafik Yaghmour)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2018, 2:31 PM (53 w, 3 d)

Recent Activity

Wed, Jul 17

shafik committed rGa0858e2f20c8: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack… (authored by shafik).
Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack…
Wed, Jul 17, 1:22 PM
shafik committed rL366365: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack….
Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack…
Wed, Jul 17, 1:22 PM
shafik closed D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory.
Wed, Jul 17, 1:22 PM · Restricted Project
shafik added a comment to D64858: [lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose.

Is it worth it to write a test that verifies the output? Otherwise LGTM.

Wed, Jul 17, 9:28 AM · Restricted Project, Restricted Project

Tue, Jul 16

shafik updated the diff for D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory.

Applying clang-format to test

Tue, Jul 16, 3:45 PM · Restricted Project
shafik added inline comments to D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory.
Tue, Jul 16, 9:42 AM · Restricted Project

Mon, Jul 15

shafik created D64777: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory.
Mon, Jul 15, 3:34 PM · Restricted Project
shafik added a comment to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

This LGTM now but I will wait for @teemperor to take a look at it.

Mon, Jul 15, 1:45 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 8

shafik added inline comments to D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration.
Mon, Jul 8, 2:31 PM · Restricted Project, Restricted Project

Jun 10 2019

shafik accepted D63087: [Path] Set FD to -1 in moved-from TempFile.

Thanks for fixing this! LGTM

Jun 10 2019, 1:47 PM · Restricted Project

May 30 2019

shafik requested changes to D60499: [ASTImporter] Various source location and range import fixes..

Actually I was mistaken, we can see the difference for EnumDecl and ClassTemplateSpecializationDecl as well.

May 30 2019, 11:48 AM · Restricted Project

May 29 2019

shafik added a comment to D60499: [ASTImporter] Various source location and range import fixes..

I think the AST dump for EnumDecl and ClassTemplateSpecializationDecl should be dumping the missing SourceLocations but I am having trouble tracking down where that should be done.

May 29 2019, 4:44 PM · Restricted Project
shafik added a comment to D60499: [ASTImporter] Various source location and range import fixes..

So an alternative to testing could be matching the AST output from a clang-import-test like we did here:

May 29 2019, 4:26 PM · Restricted Project

May 28 2019

shafik added a comment to D60499: [ASTImporter] Various source location and range import fixes..

I don't see any regressions but I am a little uncomfortable since there are no tests. So I would feel better if this was split into three parts: Namespaces, Enums and Templates.

May 28 2019, 4:49 PM · Restricted Project

May 24 2019

shafik committed rG468724eed291: [ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using… (authored by shafik).
[ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using…
May 24 2019, 9:52 AM
shafik committed rC361650: [ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using….
[ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using…
May 24 2019, 9:52 AM
shafik committed rL361650: [ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using….
[ASTImporter] Call to HandleNameConflict in VisitRecordDecl mistakeningly using…
May 24 2019, 9:51 AM
shafik closed D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName.
May 24 2019, 9:51 AM · Restricted Project
shafik added a comment to D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName.

@davide We have a reproducer but so far it has proven difficult to narrow it down to a test case. This is serious regression b/c this leads to fields being dropped in records during expression evaluation leading to results that looks like a bug but are actually expression parsing issues.

May 24 2019, 9:24 AM · Restricted Project

May 23 2019

shafik created D62352: Call to HandleNameConflict in VisitRecordDecl mistakeningly using Name instead of SearchName.
May 23 2019, 4:19 PM · Restricted Project
shafik accepted D62312: [ASTImporter] Added visibility context check for CXXRecordDecl..

LGTM

May 23 2019, 10:14 AM · Restricted Project, Restricted Project
shafik added a comment to D62312: [ASTImporter] Added visibility context check for CXXRecordDecl..

Minor comments, I am going to run check-lldb now.

May 23 2019, 9:37 AM · Restricted Project, Restricted Project

May 21 2019

shafik accepted D62061: Add AST logging.

LGTM outside of Jonas's comments.

May 21 2019, 1:35 PM · Restricted Project

May 15 2019

shafik added a comment to D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src.

I ran check-lldb and I hit one regression in TestFormatters.py, part of what I am seeing is as follows:

May 15 2019, 2:00 PM · Restricted Project, Restricted Project, Restricted Project
shafik added a comment to D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo().

@friss we have several bugs, once of which I can reproduce but I have not been able to reduce it to a minimal case yet and the nullptr check is obviously the right to do.

May 15 2019, 12:01 PM
shafik updated the diff for D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo().

Simplified the checking of symbol being a nullptr

May 15 2019, 11:36 AM

May 14 2019

shafik added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

Done with first round.

May 14 2019, 10:17 AM · Restricted Project

May 13 2019

shafik committed rG9acacebf83d3: [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses… (authored by shafik).
[DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses…
May 13 2019, 9:46 AM
shafik committed rLLDB360599: [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses….
[DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses…
May 13 2019, 9:46 AM
shafik committed rL360599: [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses….
[DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses…
May 13 2019, 9:46 AM
shafik closed D61759: Switch to FindSymbolsMatchingRegExAndType() from FindFunctions() in FindLibCppStdFunctionCallableInfo().
May 13 2019, 9:46 AM · Restricted Project

May 10 2019

shafik edited reviewers for D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo(), added: aprantl; removed: aam.
May 10 2019, 2:32 PM
shafik created D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo().
May 10 2019, 2:29 PM

May 9 2019

shafik created D61759: Switch to FindSymbolsMatchingRegExAndType() from FindFunctions() in FindLibCppStdFunctionCallableInfo().
May 9 2019, 1:53 PM · Restricted Project

May 3 2019

shafik committed rGe5cbe78259c9: Fix for ambiguous lookup in expressions between local variable and namespace (authored by shafik).
Fix for ambiguous lookup in expressions between local variable and namespace
May 3 2019, 12:59 PM
shafik committed rLLDB359921: Fix for ambiguous lookup in expressions between local variable and namespace.
Fix for ambiguous lookup in expressions between local variable and namespace
May 3 2019, 12:58 PM
shafik committed rL359921: Fix for ambiguous lookup in expressions between local variable and namespace.
Fix for ambiguous lookup in expressions between local variable and namespace
May 3 2019, 12:58 PM
shafik closed D59960: Fix for ambiguous lookup in expressions between local variable and namespace.
May 3 2019, 12:58 PM · Restricted Project
shafik updated the diff for D59960: Fix for ambiguous lookup in expressions between local variable and namespace.

Updating after https://reviews.llvm.org/D46551 landed

May 3 2019, 12:29 PM · Restricted Project

May 2 2019

shafik added a comment to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.

@teemperor @jingham @clayborg I believe now that https://reviews.llvm.org/D46551 is landed the performance concerns should be addressed.

May 2 2019, 3:09 PM · Restricted Project
shafik added a comment to D61440: C.128 override, virtual keyword handling.

Thank you! LGTM, in general we avoid "large" refactoring changes to avoid polluting the blame list but the changes are relatively local and they are good changes that can catch real bugs in the future. I would like a second set of eyes though.

May 2 2019, 10:15 AM · Restricted Project, Restricted Project
shafik added reviewers for D61440: C.128 override, virtual keyword handling: teemperor, JDevlieghere, davide, shafik.
May 2 2019, 9:24 AM · Restricted Project, Restricted Project

May 1 2019

shafik committed rG2097b1f84d47: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference… (authored by shafik).
Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference…
May 1 2019, 3:22 PM
shafik committed rLLDB359732: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference….
Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference…
May 1 2019, 3:22 PM
shafik committed rL359732: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference….
Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference…
May 1 2019, 3:22 PM
shafik closed D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
May 1 2019, 3:22 PM · Restricted Project
shafik added inline comments to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
May 1 2019, 2:05 PM · Restricted Project
shafik updated the diff for D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

Modifying copy contructor to be act more intuitively.

May 1 2019, 2:05 PM · Restricted Project
shafik updated the diff for D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

Testing both passing as and argument and returning

May 1 2019, 1:31 PM · Restricted Project
shafik added a comment to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

@friss added second test

May 1 2019, 1:31 PM · Restricted Project
shafik added a comment to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

@teemperor good call, that is indeed simpler and yes I did not intend that delete.

May 1 2019, 12:53 PM · Restricted Project
shafik updated the diff for D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
  • Simplifying test
  • Fixing unintended deleted test
May 1 2019, 12:53 PM · Restricted Project
shafik committed rGc3dd67204c92: Disabling test in TestClassTemplateParameterPack.py until we do template lookup… (authored by shafik).
Disabling test in TestClassTemplateParameterPack.py until we do template lookup…
May 1 2019, 9:39 AM
shafik committed rLLDB359699: Disabling test in TestClassTemplateParameterPack.py until we do template lookup….
Disabling test in TestClassTemplateParameterPack.py until we do template lookup…
May 1 2019, 9:39 AM
shafik committed rL359699: Disabling test in TestClassTemplateParameterPack.py until we do template lookup….
Disabling test in TestClassTemplateParameterPack.py until we do template lookup…
May 1 2019, 9:39 AM
shafik added a comment to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

@aprantl @teemperor I believe I addressed your comments.

May 1 2019, 8:58 AM · Restricted Project

Apr 30 2019

shafik accepted D61299: Rename Minion to ASTImporterDelegate.

This is a good change!

Apr 30 2019, 2:45 PM · Restricted Project, Restricted Project
shafik updated the diff for D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

Changed to reflect comments.

  • Added comments to test to explain what it is doing.
  • Formatting and other minor fixes.
Apr 30 2019, 1:24 PM · Restricted Project
shafik added inline comments to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
Apr 30 2019, 1:24 PM · Restricted Project
shafik accepted D61305: Add std::stack and std::queue support to CxxModuleHandler.

LGTM

Apr 30 2019, 10:01 AM · Restricted Project, Restricted Project, Restricted Project
shafik added a comment to D61266: Skip TestClassTemplateParameterPack.py on all platforms.

@friss makes sense, updated comment.

Apr 30 2019, 9:47 AM
shafik updated the diff for D61266: Skip TestClassTemplateParameterPack.py on all platforms.

Updated comment to be more precise.

Apr 30 2019, 9:47 AM

Apr 29 2019

shafik updated the diff for D61266: Skip TestClassTemplateParameterPack.py on all platforms.

Fred is correct, I mistakenly thought the parts of the test that were working were being covered elsewhere but that is not the case. So I have reworked this change to instead of skipping the whole test to comment out the inline expressions that are specifically broken.

Apr 29 2019, 2:03 PM
shafik added a comment to D61266: Skip TestClassTemplateParameterPack.py on all platforms.

@friss updated the change to only effect those specifically broken.

Apr 29 2019, 2:03 PM
shafik created D61266: Skip TestClassTemplateParameterPack.py on all platforms.
Apr 29 2019, 9:27 AM

Apr 26 2019

shafik committed rG16b90733c751: [ASTImporter] Copy Argument Passing Restrictions setting when importing a… (authored by shafik).
[ASTImporter] Copy Argument Passing Restrictions setting when importing a…
Apr 26 2019, 11:51 AM
shafik committed rL359338: [ASTImporter] Copy Argument Passing Restrictions setting when importing a….
[ASTImporter] Copy Argument Passing Restrictions setting when importing a…
Apr 26 2019, 11:49 AM
shafik committed rC359338: [ASTImporter] Copy Argument Passing Restrictions setting when importing a….
[ASTImporter] Copy Argument Passing Restrictions setting when importing a…
Apr 26 2019, 11:49 AM

Apr 25 2019

shafik updated the diff for D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition.

Added test

Apr 25 2019, 4:41 PM
shafik added a comment to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

@rsmith I tagged you in this change in case we are missing any implications in using DW_CC_pass_by_reference to do setArgPassingRestrictions(clang::RecordDecl::APK_CannotPassInRegs);

Apr 25 2019, 1:46 PM · Restricted Project
shafik updated the summary of D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition.
Apr 25 2019, 1:42 PM
shafik updated the summary of D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
Apr 25 2019, 1:42 PM · Restricted Project
shafik created D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
Apr 25 2019, 1:41 PM · Restricted Project
shafik created D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition.
Apr 25 2019, 11:02 AM

Apr 24 2019

shafik committed rGabdb816b776c: [DataFormatters] Adjusting libc++ std::list formatter to act better with… (authored by shafik).
[DataFormatters] Adjusting libc++ std::list formatter to act better with…
Apr 24 2019, 10:37 AM
shafik committed rLLDB359118: [DataFormatters] Adjusting libc++ std::list formatter to act better with….
[DataFormatters] Adjusting libc++ std::list formatter to act better with…
Apr 24 2019, 10:37 AM
shafik committed rL359118: [DataFormatters] Adjusting libc++ std::list formatter to act better with….
[DataFormatters] Adjusting libc++ std::list formatter to act better with…
Apr 24 2019, 10:37 AM
shafik closed D60588: Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix.
Apr 24 2019, 10:36 AM · Restricted Project
shafik added inline comments to D61046: Fix compilation warnings when compiling with GCC 7.3.
Apr 24 2019, 9:58 AM · lld, Restricted Project, Restricted Project

Apr 15 2019

shafik committed rLLDB358462: [ASTImporter] Regression test to ensure that we handling importing of anonymous….
[ASTImporter] Regression test to ensure that we handling importing of anonymous…
Apr 15 2019, 4:06 PM
shafik committed rGe4b19c9c2868: [ASTImporter] Regression test to ensure that we handling importing of anonymous… (authored by shafik).
[ASTImporter] Regression test to ensure that we handling importing of anonymous…
Apr 15 2019, 4:05 PM
shafik committed rL358462: [ASTImporter] Regression test to ensure that we handling importing of anonymous….
[ASTImporter] Regression test to ensure that we handling importing of anonymous…
Apr 15 2019, 4:03 PM
shafik closed D59667: Regression test to ensure that we handling importing of anonymous enums correctly.
Apr 15 2019, 4:03 PM · Restricted Project
shafik added inline comments to D59667: Regression test to ensure that we handling importing of anonymous enums correctly.
Apr 15 2019, 3:05 PM · Restricted Project
shafik updated the diff for D59667: Regression test to ensure that we handling importing of anonymous enums correctly.

Small updated to test, remove use of printf and associated include.

Apr 15 2019, 3:05 PM · Restricted Project

Apr 11 2019

shafik added inline comments to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.
Apr 11 2019, 2:55 PM · Restricted Project
shafik created D60588: Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix.
Apr 11 2019, 2:55 PM · Restricted Project

Apr 10 2019

shafik added a comment to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.

@friss I had to rework the tests a little but they now cover Objective-C static and non-static methods as well as C and C++.

Apr 10 2019, 3:42 PM · Restricted Project
shafik updated the diff for D59960: Fix for ambiguous lookup in expressions between local variable and namespace.

-Adjusting tests to ensure coverage of Objecive-C static and non-static methods and C and C++

Apr 10 2019, 3:37 PM · Restricted Project

Apr 9 2019

shafik added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Apr 9 2019, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
shafik added inline comments to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.
Apr 9 2019, 12:13 PM · Restricted Project
shafik added a comment to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.

@friss I believe I have addressed your comments

Apr 9 2019, 12:12 PM · Restricted Project
shafik updated the diff for D59960: Fix for ambiguous lookup in expressions between local variable and namespace.

Addressing comments:

  • Now applies to all languages not just C++
  • When adding locals be more selective on filtering i.e. only filter self and _cmd for Objective C etc...
Apr 9 2019, 12:12 PM · Restricted Project

Apr 8 2019

shafik committed rGd4263123abfc: [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using… (authored by shafik).
[ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using…
Apr 8 2019, 1:49 PM
shafik committed rL357940: [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using….
[ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using…
Apr 8 2019, 1:48 PM
shafik committed rC357940: [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using….
[ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using…
Apr 8 2019, 1:48 PM
shafik closed D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName.
Apr 8 2019, 1:48 PM · Restricted Project

Mar 28 2019

shafik accepted D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation.

LGTM

Mar 28 2019, 5:23 PM · Restricted Project, Restricted Project
shafik created D59960: Fix for ambiguous lookup in expressions between local variable and namespace.
Mar 28 2019, 2:06 PM · Restricted Project
shafik added a comment to D59847: Regression test to ensure that we handling importing of std::vector of enums correctly.

@stella.stamenova I committed a fix, please let me know if this does not address the regression:

Mar 28 2019, 1:26 PM · Restricted Project