Page MenuHomePhabricator

morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (255 w, 4 d)

Recent Activity

Feb 7 2022

morehouse committed rG4fb7c120fed5: [HWASan] Use hwasan_memalign for aligned new. (authored by morehouse).
[HWASan] Use hwasan_memalign for aligned new.
Feb 7 2022, 1:10 PM
morehouse closed D119161: [HWASan] Use hwasan_memalign for aligned new..
Feb 7 2022, 1:10 PM · Restricted Project
morehouse requested review of D119161: [HWASan] Use hwasan_memalign for aligned new..
Feb 7 2022, 10:13 AM · Restricted Project

Feb 3 2022

morehouse committed rG95d609b549bb: [HWASan] Add __hwasan_init to .preinit_array. (authored by morehouse).
[HWASan] Add __hwasan_init to .preinit_array.
Feb 3 2022, 1:09 PM
morehouse closed D118171: [HWASan] Add __hwasan_init to .preinit_array..
Feb 3 2022, 1:08 PM · Restricted Project, Restricted Project
morehouse accepted D118856: [hwasan] add musttail IR test..

LGTM

Feb 3 2022, 5:51 AM · Restricted Project

Feb 2 2022

morehouse added inline comments to D118171: [HWASan] Add __hwasan_init to .preinit_array..
Feb 2 2022, 1:59 PM · Restricted Project, Restricted Project
morehouse updated the diff for D118171: [HWASan] Add __hwasan_init to .preinit_array..
  • Make __local_hwasan_preinit static.
  • Use HelperStaticRuntimes.
Feb 2 2022, 1:59 PM · Restricted Project, Restricted Project
morehouse accepted D118813: [ASan] Added intermediate functions between assembly and __asan_report.* to avoid link errors..

LGTM

Feb 2 2022, 11:54 AM · Restricted Project
morehouse updated the diff for D118171: [HWASan] Add __hwasan_init to .preinit_array..
  • In shared library mode, link preinit stub with every DSO.
Feb 2 2022, 7:59 AM · Restricted Project, Restricted Project

Feb 1 2022

morehouse added a comment to D118171: [HWASan] Add __hwasan_init to .preinit_array..

This change does not handle the -shared-libsan case, and does not have any effect on Android other than in static executables. It also makes the comment in hwasan_preinit.cpp incorrect - that code is NOT linked into the main executable. I think we should replicate the "asan-preinit" driver logic for hwasan.

Note that ASan does not link the static preinit bit on Android. I believe that's a bug in the initial implementation of -shared-libsan - the code comment says "Do not link static runtime to DSOs or if compiling for Android", but that is clearly meant to refer to the full runtime library (because Android historically used shared runtime only) and not the preinit stub. See https://reviews.llvm.org/D3043.

Feb 1 2022, 2:59 PM · Restricted Project, Restricted Project
morehouse committed rGde4e8bc3ace3: [HWASan] Properly handle musttail calls. (authored by morehouse).
[HWASan] Properly handle musttail calls.
Feb 1 2022, 11:24 AM
morehouse closed D118712: [HWASan] Properly handle musttail calls..
Feb 1 2022, 11:24 AM · Restricted Project, Restricted Project
morehouse updated the diff for D118712: [HWASan] Properly handle musttail calls..
  • Use a single isa<Type0, Type1>.
Feb 1 2022, 11:17 AM · Restricted Project, Restricted Project
morehouse requested review of D118712: [HWASan] Properly handle musttail calls..
Feb 1 2022, 9:08 AM · Restricted Project, Restricted Project

Jan 28 2022

morehouse committed rGf7c28332de71: [HWASan] Leave pointer tagged when calling memmove. (authored by morehouse).
[HWASan] Leave pointer tagged when calling memmove.
Jan 28 2022, 6:16 AM
morehouse closed D118180: [HWASan] Leave pointer tagged when calling memmove..
Jan 28 2022, 6:16 AM · Restricted Project

Jan 27 2022

morehouse raised a concern with rGc6d5efb5d980: clang-format: [JS] sort import aliases..

This commit is causing an MSan failure on the buildbots: https://lab.llvm.org/buildbot/#/builders/5/builds/18051/steps/10/logs/stdio

Jan 27 2022, 2:08 PM

Jan 26 2022

morehouse added inline comments to D117809: [clang] Add an extract-api driver option.
Jan 26 2022, 1:38 PM · Restricted Project

Jan 25 2022

morehouse requested review of D118180: [HWASan] Leave pointer tagged when calling memmove..
Jan 25 2022, 12:46 PM · Restricted Project
morehouse requested review of D118171: [HWASan] Add __hwasan_init to .preinit_array..
Jan 25 2022, 11:51 AM · Restricted Project, Restricted Project

Jan 13 2022

morehouse accepted D117177: [NFC][DFSan] Update DataFlowSanitizer user docs for -dfsan-conditional-callbacks, added in https://reviews.llvm.org/D116207.

LGTM

Jan 13 2022, 6:29 AM · Restricted Project

Jan 6 2022

morehouse accepted D116761: [NFC][DFSan] Cleanup code to use align functions..

LGTM

Jan 6 2022, 11:00 AM · Restricted Project
morehouse accepted D116704: [DFSan] Refactor dfsan_mem_shadow_transfer..
Jan 6 2022, 8:17 AM · Restricted Project

Jan 5 2022

morehouse accepted D116207: [DFSan] Add option for conditional callbacks..

LGTM

Jan 5 2022, 3:01 PM · Restricted Project, Restricted Project
morehouse added inline comments to D116207: [DFSan] Add option for conditional callbacks..
Jan 5 2022, 9:10 AM · Restricted Project, Restricted Project

Dec 10 2021

morehouse accepted D115396: [ASan] Replace IR based callbacks with shared assembly code callbacks..
Dec 10 2021, 7:32 AM · Restricted Project

Dec 9 2021

morehouse committed rG2d6dfce4aa07: [libFuzzer] Remove entropic-scale-per-exec-time.test. (authored by morehouse).
[libFuzzer] Remove entropic-scale-per-exec-time.test.
Dec 9 2021, 12:20 PM
morehouse closed D115453: [libFuzzer] Remove entropic-scale-per-exec-time.test..
Dec 9 2021, 12:20 PM · Restricted Project
morehouse accepted D115319: [lsan] Move out suppression of invalid PCs from StopTheWorld.
Dec 9 2021, 12:04 PM · Restricted Project, Restricted Project
morehouse requested review of D115453: [libFuzzer] Remove entropic-scale-per-exec-time.test..
Dec 9 2021, 9:15 AM · Restricted Project
morehouse added inline comments to D115396: [ASan] Replace IR based callbacks with shared assembly code callbacks..
Dec 9 2021, 9:03 AM · Restricted Project
morehouse accepted D115319: [lsan] Move out suppression of invalid PCs from StopTheWorld.
Dec 9 2021, 8:06 AM · Restricted Project, Restricted Project
morehouse added inline comments to D115319: [lsan] Move out suppression of invalid PCs from StopTheWorld.
Dec 9 2021, 8:02 AM · Restricted Project, Restricted Project
morehouse added inline comments to D115318: [NFC][lsan] Change LeakSuppressionContext interface.
Dec 9 2021, 7:50 AM · Restricted Project
morehouse added inline comments to D115318: [NFC][lsan] Change LeakSuppressionContext interface.
Dec 9 2021, 7:47 AM · Restricted Project
morehouse accepted D115284: [lsan] Reduce StopTheWorld access to StackDepot.
Dec 9 2021, 7:39 AM · Restricted Project
morehouse accepted D115318: [NFC][lsan] Change LeakSuppressionContext interface.

LGTM

Dec 9 2021, 7:29 AM · Restricted Project

Dec 6 2021

morehouse added inline comments to D114558: [ASan] Shared optimized callbacks implementation..
Dec 6 2021, 11:10 AM · Restricted Project, Restricted Project

Dec 3 2021

morehouse added inline comments to D115002: [ASan] Changed intrisic implemenation to use PLT safe registers..
Dec 3 2021, 6:40 AM · Restricted Project

Dec 2 2021

morehouse accepted D114918: [sanitizer] Add Lempel–Ziv–Welch encoder/decoder.
Dec 2 2021, 3:15 PM · Restricted Project
morehouse accepted D114980: [NFC][sanitizer] Iterator adaptors for Leb128 encoding.
Dec 2 2021, 2:44 PM · Restricted Project
morehouse accepted D114991: [NFC][sanitizer] Remove SetSoftRssLimitExceededCallback.

LGTM

Dec 2 2021, 2:36 PM · Restricted Project
morehouse accepted D114924: [sanitizer] Hook up LZW into stack store.

LGTM

Dec 2 2021, 2:26 PM · Restricted Project
morehouse accepted D114918: [sanitizer] Add Lempel–Ziv–Welch encoder/decoder.
Dec 2 2021, 2:09 PM · Restricted Project
morehouse accepted D114933: [sanitizer] Start background thread once.

LGTM

Dec 2 2021, 11:35 AM · Restricted Project
morehouse accepted D114495: [sanitizer] Add compress_stack_depot flag.

LGTM

Dec 2 2021, 6:30 AM · Restricted Project

Dec 1 2021

morehouse added inline comments to D114495: [sanitizer] Add compress_stack_depot flag.
Dec 1 2021, 7:39 AM · Restricted Project
morehouse accepted D114835: [ASan] Fixed include order..

LGTM

Dec 1 2021, 7:35 AM · Restricted Project

Nov 30 2021

morehouse added inline comments to D114558: [ASan] Shared optimized callbacks implementation..
Nov 30 2021, 2:01 PM · Restricted Project, Restricted Project
morehouse added inline comments to D114558: [ASan] Shared optimized callbacks implementation..
Nov 30 2021, 1:48 PM · Restricted Project, Restricted Project

Nov 29 2021

morehouse accepted D114503: [sanitizer] Add delta compression stack depot.
Nov 29 2021, 12:47 PM · Restricted Project
morehouse accepted D114495: [sanitizer] Add compress_stack_depot flag.
Nov 29 2021, 11:02 AM · Restricted Project
morehouse added inline comments to D114494: [NFC][sanitizer] Add entry point for compression.
Nov 29 2021, 10:54 AM · Restricted Project
morehouse accepted D114493: [NFC][sanitizer] Track progress of populating the block.
Nov 29 2021, 10:14 AM · Restricted Project
morehouse committed rG2022e2fcd05c: [HWASan] Disable LTO test on aarch64. (authored by morehouse).
[HWASan] Disable LTO test on aarch64.
Nov 29 2021, 8:08 AM

Nov 24 2021

morehouse accepted D114493: [NFC][sanitizer] Track progress of populating the block.
Nov 24 2021, 12:56 PM · Restricted Project
morehouse added a comment to D114531: tsan: lock internal allocator around fork.

TSan tests on the buildbot are timing out after this change and https://reviews.llvm.org/D114532. Not sure if there's a deadlock or if it just slowed things down too much.

Nov 24 2021, 12:11 PM · Restricted Project
morehouse accepted D114490: [sanitizer] Remove storeIds and use padding of StackDepotNode.

LGTM

Nov 24 2021, 12:01 PM · Restricted Project
morehouse accepted D114489: [sanitizer] Switch StackStore from pointers to 32bit IDs.

LGTM

Nov 24 2021, 11:52 AM · Restricted Project
morehouse accepted D114488: [sanitizer] Switch StackStore to 8 MiB blocks.
Nov 24 2021, 11:35 AM · Restricted Project
morehouse added a comment to D114464: [sanitizer] Add Leb128 encoding/decoding.

I understand the ULEB128 for compression. What will we need SLEB128 for?

Nov 24 2021, 10:05 AM · Restricted Project

Nov 23 2021

morehouse accepted D114463: [NFC][sanitizer] Add StackStoreTest.

LGTM

Nov 23 2021, 12:54 PM · Restricted Project

Nov 22 2021

morehouse committed rG615ecd8afc43: [HWASan] Move LTO test to separate file. (authored by morehouse).
[HWASan] Move LTO test to separate file.
Nov 22 2021, 1:20 PM
morehouse committed rG5684a614dd1c: [HWASan] Remove -Wa,-mrelax-relocations=no flag. (authored by morehouse).
[HWASan] Remove -Wa,-mrelax-relocations=no flag.
Nov 22 2021, 11:22 AM
morehouse closed D113221: [HWASan] Remove -Wa,-mrelax-relocations=no flag..
Nov 22 2021, 11:21 AM · Restricted Project
morehouse added a comment to D113221: [HWASan] Remove -Wa,-mrelax-relocations=no flag..

Ping. Parent patch landed last week.

Nov 22 2021, 10:16 AM · Restricted Project
morehouse accepted D114312: libfuzzer: Disable broken tests for arm.

LGTM

Nov 22 2021, 5:58 AM · Restricted Project

Nov 19 2021

morehouse committed rG671f0930fe29: [X86] Selective relocation relaxation for +tagged-globals (authored by morehouse).
[X86] Selective relocation relaxation for +tagged-globals
Nov 19 2021, 7:20 AM
morehouse closed D113220: [X86] Selective relocation relaxation for +tagged-globals.
Nov 19 2021, 7:19 AM · Restricted Project

Nov 18 2021

morehouse accepted D112091: libfuzzer: All building libfuzzer for ARM32.

LGTM

Nov 18 2021, 6:48 AM · Restricted Project

Nov 11 2021

morehouse accepted D112588: [sanitizer] Switch dlsym hack to internal_allocator.
Nov 11 2021, 3:27 PM · Restricted Project
morehouse updated the diff for D113220: [X86] Selective relocation relaxation for +tagged-globals.
  • Add @GOTPCREL_NORELAX as an assembly extension.
Nov 11 2021, 2:13 PM · Restricted Project

Nov 10 2021

morehouse added a comment to D113220: [X86] Selective relocation relaxation for +tagged-globals.

I think it ought to be possible to write these non-relaxable relocations from assembly, so that the behavior with -c is equivalent to the behavior with -S and then assembling the output. For example, you should be able to assemble

mov foo@gotpcrel_norelax(%rip), %rax

and the -S output from the compiler should look like that as well.

Nov 10 2021, 2:42 PM · Restricted Project
morehouse added a reviewer for D113220: [X86] Selective relocation relaxation for +tagged-globals: MaskRay.
Nov 10 2021, 1:39 PM · Restricted Project
morehouse committed rG614b8bac01f6: [libFuzzer] Deflake entropic exec-time test. (authored by dokyungs).
[libFuzzer] Deflake entropic exec-time test.
Nov 10 2021, 7:43 AM
morehouse closed D113544: [libFuzzer] Deflake entropic exec-time test..
Nov 10 2021, 7:43 AM · Restricted Project
morehouse accepted D113544: [libFuzzer] Deflake entropic exec-time test..

Thanks DK

Nov 10 2021, 7:18 AM · Restricted Project

Nov 9 2021

morehouse accepted D113447: [sancov] add tracing for loads and store.

LGTM

Nov 9 2021, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
morehouse accepted D113447: [sancov] add tracing for loads and store.
Nov 9 2021, 8:04 AM · Restricted Project, Restricted Project, Restricted Project
morehouse committed rG846ec2c3ccbc: [HWASan] Ensure RNG is initialized in GenerateRandomTag (authored by morehouse).
[HWASan] Ensure RNG is initialized in GenerateRandomTag
Nov 9 2021, 7:02 AM
morehouse added a reverting change for rG7a3fb71c3cbd: [hwasan] Fix TestCases/thread-uaf.c.: rG846ec2c3ccbc: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 9 2021, 7:02 AM
morehouse added a reverting change for D111841: [hwasan] Fix TestCases/thread-uaf.c.: rG846ec2c3ccbc: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 9 2021, 7:02 AM · Restricted Project
morehouse closed D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 9 2021, 7:02 AM · Restricted Project

Nov 8 2021

morehouse added inline comments to D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 8 2021, 7:28 AM · Restricted Project
morehouse updated the diff for D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
  • Reintroduce random_state_inited_ flag
Nov 8 2021, 7:28 AM · Restricted Project

Nov 5 2021

morehouse added inline comments to D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 5 2021, 1:56 PM · Restricted Project
morehouse updated the diff for D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
  • Fix potential issue on random_state_ overflow.
Nov 5 2021, 1:56 PM · Restricted Project
morehouse added inline comments to D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 5 2021, 11:40 AM · Restricted Project
morehouse added inline comments to D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 5 2021, 9:29 AM · Restricted Project
morehouse updated the diff for D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
  • Remove random_state_inited_.
  • Make unique_id atomic.
  • Move initialization check to cold path.
Nov 5 2021, 9:28 AM · Restricted Project

Nov 4 2021

morehouse updated the diff for D113221: [HWASan] Remove -Wa,-mrelax-relocations=no flag..
  • Fix FileCheck args.
Nov 4 2021, 4:13 PM · Restricted Project
morehouse requested review of D113221: [HWASan] Remove -Wa,-mrelax-relocations=no flag..
Nov 4 2021, 3:45 PM · Restricted Project
morehouse requested review of D113220: [X86] Selective relocation relaxation for +tagged-globals.
Nov 4 2021, 3:41 PM · Restricted Project
morehouse retitled D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag from [HWASan] Disable tagging until RNG is initialized. to [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 4 2021, 11:34 AM · Restricted Project
morehouse added a comment to D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.

Seems like it's workaround for case protected by CHECK(random_buffer_), why not just remove the CHECK?
another case which this CHECK helps against a bug in xorshift which must not return zero for non-zero input. I don't think this check is important but it can be handled like:

static u32 xorshift(u32 state) {
  u32 old_state = state;
  state ^= state << 13;
  state ^= state >> 17;
  state ^= state << 5;
  CHECK(!old_state || state);
  return state;
}
Nov 4 2021, 10:38 AM · Restricted Project
morehouse updated the diff for D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
  • Use lazy init instead.
Nov 4 2021, 10:38 AM · Restricted Project

Nov 2 2021

morehouse added a reverting change for rG7a3fb71c3cbd: [hwasan] Fix TestCases/thread-uaf.c.: D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 2 2021, 1:16 PM
morehouse added a reverting change for D111841: [hwasan] Fix TestCases/thread-uaf.c.: D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 2 2021, 1:16 PM · Restricted Project
morehouse updated the summary of D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 2 2021, 1:16 PM · Restricted Project