Page MenuHomePhabricator

morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (168 w, 4 d)

Recent Activity

Fri, Sep 18

morehouse committed rG23bab1eb43d3: [DFSan] Add strpbrk wrapper. (authored by morehouse).
[DFSan] Add strpbrk wrapper.
Fri, Sep 18, 8:54 AM
morehouse closed D87849: [DFSan] Add strpbrk wrapper..
Fri, Sep 18, 8:54 AM · Restricted Project
morehouse updated the diff for D87849: [DFSan] Add strpbrk wrapper..
  • Simplify ternary.
Fri, Sep 18, 8:43 AM · Restricted Project
morehouse accepted D87897: [msan][asan] Add runtime flag intercept_strcmp.

LGTM

Fri, Sep 18, 8:23 AM · Restricted Project

Thu, Sep 17

morehouse requested review of D87849: [DFSan] Add strpbrk wrapper..
Thu, Sep 17, 12:22 PM · Restricted Project
morehouse committed rG50dd545b00ed: [DFSan] Add bcmp wrapper. (authored by morehouse).
[DFSan] Add bcmp wrapper.
Thu, Sep 17, 9:24 AM
morehouse closed D87801: [DFSan] Add bcmp wrapper..
Thu, Sep 17, 9:24 AM · Restricted Project
morehouse accepted D87754: [Lsan] Use fp registers to search for pointers.

LGTM

Thu, Sep 17, 9:10 AM · Restricted Project
morehouse updated the diff for D87801: [DFSan] Add bcmp wrapper..
  • Restructure bcmp and memcmp wrapper to please check_custom_wrappers.sh
Thu, Sep 17, 9:04 AM · Restricted Project
morehouse reopened D87801: [DFSan] Add bcmp wrapper..
Thu, Sep 17, 9:03 AM · Restricted Project
morehouse added a reverting change for rG559f91981253: [DFSan] Add bcmp wrapper.: rGdf017fd906bb: Revert "[DFSan] Add bcmp wrapper.".
Thu, Sep 17, 8:44 AM
morehouse committed rGdf017fd906bb: Revert "[DFSan] Add bcmp wrapper." (authored by morehouse).
Revert "[DFSan] Add bcmp wrapper."
Thu, Sep 17, 8:44 AM
morehouse added a reverting change for D87801: [DFSan] Add bcmp wrapper.: rGdf017fd906bb: Revert "[DFSan] Add bcmp wrapper.".
Thu, Sep 17, 8:44 AM · Restricted Project
morehouse committed rG559f91981253: [DFSan] Add bcmp wrapper. (authored by morehouse).
[DFSan] Add bcmp wrapper.
Thu, Sep 17, 8:23 AM
morehouse closed D87801: [DFSan] Add bcmp wrapper..
Thu, Sep 17, 8:23 AM · Restricted Project

Wed, Sep 16

morehouse added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 6:13 PM · Restricted Project
morehouse requested review of D87801: [DFSan] Add bcmp wrapper..
Wed, Sep 16, 3:38 PM · Restricted Project
morehouse committed rGf3c2e0bcee64: [libFuzzer] Enable entropic by default. (authored by morehouse).
[libFuzzer] Enable entropic by default.
Wed, Sep 16, 10:45 AM
morehouse closed D87476: [libFuzzer] Enable entropic by default..
Wed, Sep 16, 10:45 AM · Restricted Project
morehouse added a comment to D87754: [Lsan] Use fp registers to search for pointers.

LGTM once we have a test.

Wed, Sep 16, 10:23 AM · Restricted Project
morehouse accepted D87747: [NFC][LSAN] Change SuspendedThreadsList interface.

LGTM. Was this causing any issues, or is this just a refactor?

Wed, Sep 16, 9:39 AM · Restricted Project
morehouse committed rG66df98945e08: [libfuzzer] Reduce default verbosity when printing large mutation sequences (authored by mhlakhani).
[libfuzzer] Reduce default verbosity when printing large mutation sequences
Wed, Sep 16, 9:24 AM
morehouse closed D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.
Wed, Sep 16, 9:24 AM · Restricted Project
morehouse accepted D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

Test looks good, thanks for figuring out the regex stuff.

Wed, Sep 16, 9:19 AM · Restricted Project

Tue, Sep 15

morehouse added inline comments to D87552: [Asan] Fix false leak report.
Tue, Sep 15, 5:12 PM · Restricted Project
morehouse added inline comments to D87552: [Asan] Fix false leak report.
Tue, Sep 15, 4:19 PM · Restricted Project
morehouse added inline comments to D87552: [Asan] Fix false leak report.
Tue, Sep 15, 3:23 PM · Restricted Project
morehouse added inline comments to D87552: [Asan] Fix false leak report.
Tue, Sep 15, 3:14 PM · Restricted Project
morehouse added inline comments to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.
Tue, Sep 15, 9:48 AM · Restricted Project

Mon, Sep 14

morehouse added inline comments to D85928: [libFuzzer] Added -print_full_coverage flag..
Mon, Sep 14, 6:11 PM · Restricted Project, Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

I'd like to keep the test, but we can separate it into its own file and use UNSUPPORTED or REQUIRES to avoid running on systems that don't have the tools we need.

Mon, Sep 14, 5:46 PM · Restricted Project
morehouse accepted D87647: [NFC][Asan] Remove chunk pointer from metadata.

LGTM

Mon, Sep 14, 5:37 PM · Restricted Project
morehouse accepted D87646: [Asan] Cleanup kAllocBegMagic setup.
Mon, Sep 14, 5:31 PM · Restricted Project
morehouse accepted D87645: [NFC][Asan] Reorder bitfields.

LGTM

Mon, Sep 14, 4:57 PM · Restricted Project
morehouse accepted D87644: [NFC][Asan] Remove from_memalign and rz_log.

LGTM

Mon, Sep 14, 4:55 PM · Restricted Project
morehouse accepted D87643: [NFC][Asan] Don't use MetaData for size.
Mon, Sep 14, 4:47 PM · Restricted Project
morehouse accepted D87642: [Asan] Accept __lsan_ignore_object for redzone pointer.

LGTM

Mon, Sep 14, 4:23 PM · Restricted Project
morehouse accepted D87552: [Asan] Fix false leak report.
Mon, Sep 14, 9:32 AM · Restricted Project

Fri, Sep 11

morehouse committed rG2df6efedef5c: [DFSan] Re-enable event_callbacks test. (authored by morehouse).
[DFSan] Re-enable event_callbacks test.
Fri, Sep 11, 9:15 AM
morehouse updated the diff for D87476: [libFuzzer] Enable entropic by default..
  • Update focus_function doc string.
  • Increase runs for keep-seed and uniform crossover tests.
Fri, Sep 11, 8:40 AM · Restricted Project

Thu, Sep 10

morehouse added a comment to D87476: [libFuzzer] Enable entropic by default..

@dokyungs Any idea why enabling entropic causes the KeepSeed tests to fail?

Thu, Sep 10, 12:29 PM · Restricted Project
morehouse added inline comments to D87476: [libFuzzer] Enable entropic by default..
Thu, Sep 10, 12:02 PM · Restricted Project
morehouse requested review of D87476: [libFuzzer] Enable entropic by default..
Thu, Sep 10, 11:44 AM · Restricted Project
morehouse accepted D87217: [Asan] Fix __asan_update_allocation_context.

LGTM

Thu, Sep 10, 8:16 AM · Restricted Project

Wed, Sep 9

morehouse added inline comments to D87217: [Asan] Fix __asan_update_allocation_context.
Wed, Sep 9, 4:47 PM · Restricted Project
morehouse resigned from D87359: [Asan] Don't use allocator Metadata.
Wed, Sep 9, 4:24 PM · Restricted Project
morehouse accepted D87135: [Asan] Return nullptr for invalid chunks.

LGTM

Wed, Sep 9, 2:03 PM · Restricted Project

Tue, Sep 8

morehouse accepted D86560: [libFuzzer] Add a command-line option for tracing mutation of corpus inputs in the dot graph format..

This is a great patch, thank you DK!

Tue, Sep 8, 5:18 PM · Restricted Project
morehouse added inline comments to D87135: [Asan] Return nullptr for invalid chunks.
Tue, Sep 8, 4:53 PM · Restricted Project
morehouse accepted D86931: [Asan] Don't crash if metadata is not initialized.

Please update the commit message.

Tue, Sep 8, 1:11 PM · Restricted Project
morehouse accepted D86933: [NFC][Asan] Remove Debug code.

LGTM

Tue, Sep 8, 8:50 AM · Restricted Project

Thu, Sep 3

morehouse committed rG711b9806547b: [fuzzer] Create user provided fuzzer writeable directories when requested if… (authored by morehouse).
[fuzzer] Create user provided fuzzer writeable directories when requested if…
Thu, Sep 3, 8:33 AM
morehouse closed D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.
Thu, Sep 3, 8:32 AM · Restricted Project
morehouse accepted D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.

LGTM

Thu, Sep 3, 7:56 AM · Restricted Project

Wed, Sep 2

morehouse accepted D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..

LGTM

Wed, Sep 2, 5:54 PM · Restricted Project
morehouse added a comment to D85928: [libFuzzer] Added -print_full_coverage flag..

I'll take a look once the diff is fixed and Max's current comments are addressed.

Wed, Sep 2, 5:33 PM · Restricted Project, Restricted Project
morehouse accepted D86954: [libFuzzer] Evenly select inputs to cross over with from the corpus regardless of the input's coverage..

Please make sure the harbormaster test passes before landing.

Wed, Sep 2, 5:28 PM · Restricted Project
morehouse added inline comments to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..
Wed, Sep 2, 5:25 PM · Restricted Project
morehouse accepted D86577: [libFuzzer] Add an option to keep initial seed inputs around..

LGTM

Wed, Sep 2, 5:20 PM · Restricted Project
morehouse added inline comments to D86931: [Asan] Don't crash if metadata is not initialized.
Wed, Sep 2, 5:16 PM · Restricted Project
morehouse added a comment to D86922: [Asan] Don't use MetaData for size.

This patch changes how the allocator works, so I don't think it qualifies as NFC.

Wed, Sep 2, 4:53 PM · Restricted Project
morehouse accepted D86919: [NFC][Asan] Set AP32::kMetadataSize to 0.

LGTM

Wed, Sep 2, 4:02 PM · Restricted Project
morehouse accepted D86917: [Asan] Cleanup atomic usage in allocator.
Wed, Sep 2, 3:58 PM · Restricted Project
morehouse added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Wed, Sep 2, 2:40 PM · Restricted Project
morehouse added inline comments to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..
Wed, Sep 2, 1:12 PM · Restricted Project

Tue, Sep 1

morehouse committed rG49dda4e58aeb: [libFuzzer] Break dependency on common_interface_defs.h (authored by morehouse).
[libFuzzer] Break dependency on common_interface_defs.h
Tue, Sep 1, 3:35 PM
morehouse closed D86981: [libFuzzer] Break dependency on common_interface_defs.h.
Tue, Sep 1, 3:35 PM · Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

The libFuzzer tests automatically run on harbormaster when you update the patch, but that's often a different environment than the bots.

Tue, Sep 1, 3:33 PM · Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

I do have access to that bot, but the log is gone already. Sorry.

Tue, Sep 1, 3:28 PM · Restricted Project
morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

The log from the darwin bot has:

+ : 'RUN: at line 18'
+ grep NEW /Users/buildslave/jenkins/workspace/clang-stage1-RA/clang-build/tools/clang/runtime/compiler-rt-bins/test/fuzzer/X86_64DefaultDarwinConfig/Output/fuzzer-custommutator.test.tmp-mutate-verbose-log
+ grep '.\{1024\}'
grep: invalid repetition count(s)

So at least one issue seems to be from different grep feature support on different machines.

Tue, Sep 1, 2:54 PM · Restricted Project
morehouse requested review of D86981: [libFuzzer] Break dependency on common_interface_defs.h.
Tue, Sep 1, 2:42 PM · Restricted Project
morehouse reopened D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

Had to revert due to multiple buildbot failures:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/38581/steps/check-fuzzer/logs/stdio
http://green.lab.llvm.org/green//job/clang-stage1-RA/14180/consoleFull#-1417328700a1ca8a51-895e-46c6-af87-ce24fa4cd561

Tue, Sep 1, 12:51 PM · Restricted Project
morehouse added a reverting change for rG2665425908e0: [libfuzzer] Reduce default verbosity when printing large mutation sequences: rG7139736261e0: Revert "[libfuzzer] Reduce default verbosity when printing large mutation….
Tue, Sep 1, 12:50 PM
morehouse committed rG7139736261e0: Revert "[libfuzzer] Reduce default verbosity when printing large mutation… (authored by morehouse).
Revert "[libfuzzer] Reduce default verbosity when printing large mutation…
Tue, Sep 1, 12:50 PM
morehouse added a reverting change for D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences: rG7139736261e0: Revert "[libfuzzer] Reduce default verbosity when printing large mutation….
Tue, Sep 1, 12:50 PM · Restricted Project
morehouse reopened D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.
Tue, Sep 1, 12:07 PM · Restricted Project
morehouse added a comment to D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.

Had to revert because the Windows bot doesn't have chmod at all: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/68987/steps/stage%201%20check/logs/stdio

Tue, Sep 1, 12:07 PM · Restricted Project
morehouse added a reverting change for rGcb8912799d43: [fuzzer] Create user provided fuzzer writeable directories when requested if…: rG10670bdf5451: Revert "[fuzzer] Create user provided fuzzer writeable directories when….
Tue, Sep 1, 12:06 PM
morehouse committed rG10670bdf5451: Revert "[fuzzer] Create user provided fuzzer writeable directories when… (authored by morehouse).
Revert "[fuzzer] Create user provided fuzzer writeable directories when…
Tue, Sep 1, 12:06 PM
morehouse added a reverting change for D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist: rG10670bdf5451: Revert "[fuzzer] Create user provided fuzzer writeable directories when….
Tue, Sep 1, 12:06 PM · Restricted Project
morehouse committed rGcb8912799d43: [fuzzer] Create user provided fuzzer writeable directories when requested if… (authored by morehouse).
[fuzzer] Create user provided fuzzer writeable directories when requested if…
Tue, Sep 1, 11:51 AM
morehouse closed D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.
Tue, Sep 1, 11:51 AM · Restricted Project
morehouse added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Tue, Sep 1, 11:31 AM · Restricted Project
morehouse accepted D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.

LGTM

Tue, Sep 1, 11:18 AM · Restricted Project
morehouse committed rG2665425908e0: [libfuzzer] Reduce default verbosity when printing large mutation sequences (authored by mhlakhani).
[libfuzzer] Reduce default verbosity when printing large mutation sequences
Tue, Sep 1, 11:15 AM
morehouse closed D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.
Tue, Sep 1, 11:14 AM · Restricted Project
morehouse added a comment to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..

Please add a test.

Tue, Sep 1, 11:01 AM · Restricted Project
morehouse added inline comments to D86954: [libFuzzer] Evenly select inputs to cross over with from the corpus regardless of the input's coverage..
Tue, Sep 1, 10:48 AM · Restricted Project
morehouse added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Tue, Sep 1, 10:37 AM · Restricted Project
morehouse added inline comments to D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.
Tue, Sep 1, 8:34 AM · Restricted Project
morehouse accepted D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.
Tue, Sep 1, 8:09 AM · Restricted Project

Mon, Aug 31

morehouse added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Mon, Aug 31, 5:13 PM · Restricted Project
morehouse added inline comments to D86733: [fuzzer] Create user provided fuzzer writeable directories when requested if they dont exist.
Mon, Aug 31, 10:07 AM · Restricted Project

Fri, Aug 28

morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

A test would be nice, but maybe tricky.

Fri, Aug 28, 1:40 PM · Restricted Project

Thu, Aug 27

morehouse added a comment to D86658: [libfuzzer] Reduce default verbosity when printing large mutation sequences.

Seems like a reasonable patch to me. Please address @plotfi's comments, then I'll take a closer look.

Thu, Aug 27, 3:33 PM · Restricted Project

Wed, Aug 26

morehouse added a comment to D86358: [libFuzzer] Extend ChangeBinaryInteger mutator to support overwriting selected input with predefined integers..

LGTM for an experiment.

Wed, Aug 26, 4:57 PM · Restricted Project
morehouse added inline comments to D86358: [libFuzzer] Extend ChangeBinaryInteger mutator to support overwriting selected input with predefined integers..
Wed, Aug 26, 4:20 PM · Restricted Project
morehouse added inline comments to D86358: [libFuzzer] Extend ChangeBinaryInteger mutator to support overwriting selected input with predefined integers..
Wed, Aug 26, 3:22 PM · Restricted Project
morehouse added inline comments to D86358: [libFuzzer] Extend ChangeBinaryInteger mutator to support overwriting selected input with predefined integers..
Wed, Aug 26, 9:49 AM · Restricted Project
morehouse committed rG2392ff093af1: [libFuzzer] Error and exit if user supplied fuzzer writeable directories don't… (authored by morehouse).
[libFuzzer] Error and exit if user supplied fuzzer writeable directories don't…
Wed, Aug 26, 9:28 AM