morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (64 w, 5 d)

Recent Activity

Wed, Sep 19

morehouse committed rL342582: [InstCombine] Disable strcmp->memcmp transform for MSan..
[InstCombine] Disable strcmp->memcmp transform for MSan.
Wed, Sep 19, 12:39 PM
morehouse closed D52272: [InstCombine] Disable strcmp->memcmp transform for MSan..
Wed, Sep 19, 12:38 PM
morehouse created D52272: [InstCombine] Disable strcmp->memcmp transform for MSan..
Wed, Sep 19, 12:00 PM

Mon, Sep 17

morehouse committed rCRT342423: [libFuzzer] Avoid fuzzer symbols being hidden..
[libFuzzer] Avoid fuzzer symbols being hidden.
Mon, Sep 17, 4:12 PM
morehouse committed rL342423: [libFuzzer] Avoid fuzzer symbols being hidden..
[libFuzzer] Avoid fuzzer symbols being hidden.
Mon, Sep 17, 4:09 PM
morehouse accepted D52119: [SanitizerCoverage] Don't make sancov module constructor comdat.

Change is fine with me since Linux behavior is unchanged. @rnk can comment on whether this is the best approach for Windows or not.

Mon, Sep 17, 9:56 AM
morehouse accepted D51700: [fuzzer] Replace FuzzerExtFunctionsDlsymWin.cpp with FuzzerExtFunctionsWeakAlias.cpp.

LGTM

Mon, Sep 17, 9:37 AM

Fri, Sep 14

morehouse committed rCRT342255: [libFuzzer] Disable value-profile-strncmp.test on aarch64..
[libFuzzer] Disable value-profile-strncmp.test on aarch64.
Fri, Sep 14, 11:25 AM
morehouse committed rL342255: [libFuzzer] Disable value-profile-strncmp.test on aarch64..
[libFuzzer] Disable value-profile-strncmp.test on aarch64.
Fri, Sep 14, 11:25 AM

Thu, Sep 13

morehouse committed rL342186: [SanitizerCoverage] Create comdat for global arrays..
[SanitizerCoverage] Create comdat for global arrays.
Thu, Sep 13, 2:47 PM
morehouse closed D51902: [SanitizerCoverage] Create comdat for global arrays..
Thu, Sep 13, 2:47 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Call getUniqueModuleId once per module.
Thu, Sep 13, 2:29 PM

Tue, Sep 11

morehouse added a comment to D51902: [SanitizerCoverage] Create comdat for global arrays..

The error was actually caused by setting associated metadata for some arrays and not others. By always setting the metadata, we can avoid the issue.

Tue, Sep 11, 5:20 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Do not set comdat for local-linkage functions without a unique module ID
Tue, Sep 11, 5:16 PM
morehouse reopened D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 5:16 PM
morehouse added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 4:49 PM
morehouse added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 3:40 PM
morehouse committed rL341995: Revert "[SanitizerCoverage] Create comdat for global arrays.".
Revert "[SanitizerCoverage] Create comdat for global arrays."
Tue, Sep 11, 2:18 PM
morehouse added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 2:12 PM
morehouse committed rL341987: [SanitizerCoverage] Create comdat for global arrays..
[SanitizerCoverage] Create comdat for global arrays.
Tue, Sep 11, 1:12 PM
morehouse closed D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 1:12 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Rebase properly.
Tue, Sep 11, 12:56 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Rebase
Tue, Sep 11, 12:50 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Only set comdats for ELF.
  • Fallback to using module ID when getUniqueModuleId fails.
Tue, Sep 11, 12:44 PM
morehouse reopened D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 12:44 PM
morehouse committed rL341965: Revert "[SanitizerCoverage] Create comdat for global arrays.".
Revert "[SanitizerCoverage] Create comdat for global arrays."
Tue, Sep 11, 10:21 AM
morehouse committed rL341951: [SanitizerCoverage] Create comdat for global arrays..
[SanitizerCoverage] Create comdat for global arrays.
Tue, Sep 11, 8:24 AM
morehouse closed D51902: [SanitizerCoverage] Create comdat for global arrays..
Tue, Sep 11, 8:24 AM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Add refactoring TODO.
Tue, Sep 11, 8:24 AM

Mon, Sep 10

morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Fallback to counter suffix if getUniqueModuleId fails.
Mon, Sep 10, 7:02 PM
morehouse created D51902: [SanitizerCoverage] Create comdat for global arrays..
Mon, Sep 10, 5:58 PM

Thu, Sep 6

morehouse accepted D51757: [libfuzzer] Use cl driver mode for tests and enable another test on Windows.
Thu, Sep 6, 5:58 PM
morehouse added inline comments to D51757: [libfuzzer] Use cl driver mode for tests and enable another test on Windows.
Thu, Sep 6, 5:27 PM

Wed, Sep 5

morehouse committed rCRT341495: [libfuzzer] Replace memmem with strstr..
[libfuzzer] Replace memmem with strstr.
Wed, Sep 5, 2:05 PM
morehouse committed rL341495: [libfuzzer] Replace memmem with strstr..
[libfuzzer] Replace memmem with strstr.
Wed, Sep 5, 2:04 PM
morehouse closed D51692: [libfuzzer] Replace memmem with strstr..
Wed, Sep 5, 2:04 PM
morehouse accepted D51692: [libfuzzer] Replace memmem with strstr..
Wed, Sep 5, 1:57 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

It seems reasonable to just check that argv is set, since this test is intended to check for LLVMFuzzerInitialize being called. There's plenty of other tests where libFuzzer must find a string.

Wed, Sep 5, 1:38 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

Maybe I'm misunderstanding something, but I'm pretty sure memmem returns non-null on a match while strncmp returns 0 on match. Which would mean the ! should have been removed.

Wed, Sep 5, 12:56 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

That patch broke the behavior of this test. Looks like we used to print "BINGO" when the input matched the binary name. Now we print "BINGO" when the input size matches but the names do not.

Wed, Sep 5, 12:42 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

Maybe memcmp would be cleaner here.

Wed, Sep 5, 11:58 AM

Tue, Sep 4

morehouse committed rL341385: [libFuzzer] Enable tests on Windows.
[libFuzzer] Enable tests on Windows
Tue, Sep 4, 10:11 AM
morehouse committed rCRT341385: [libFuzzer] Enable tests on Windows.
[libFuzzer] Enable tests on Windows
Tue, Sep 4, 10:11 AM
morehouse closed D51549: [libFuzzer] Enable tests on Windows.
Tue, Sep 4, 10:11 AM
morehouse committed rCRT341384: [TSan] Update assembly test again..
[TSan] Update assembly test again.
Tue, Sep 4, 10:05 AM
morehouse committed rL341384: [TSan] Update assembly test again..
[TSan] Update assembly test again.
Tue, Sep 4, 10:05 AM
morehouse committed rCRT341381: [TSan] Update assembly code check..
[TSan] Update assembly code check.
Tue, Sep 4, 9:37 AM
morehouse accepted D51549: [libFuzzer] Enable tests on Windows.
Tue, Sep 4, 9:36 AM
morehouse committed rL341381: [TSan] Update assembly code check..
[TSan] Update assembly code check.
Tue, Sep 4, 9:35 AM

Thu, Aug 30

morehouse committed rCRT341082: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Thu, Aug 30, 8:56 AM
morehouse committed rL341082: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Thu, Aug 30, 8:56 AM
morehouse committed rC341082: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Thu, Aug 30, 8:55 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Thu, Aug 30, 8:55 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Thu, Aug 30, 8:55 AM

Wed, Aug 29

morehouse accepted D51455: [libFuzzer] Remove mutation stats and weighted mutation selection..

LGTM

Wed, Aug 29, 2:31 PM
morehouse committed rC340954: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Wed, Aug 29, 11:43 AM
morehouse committed rL340954: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Wed, Aug 29, 11:43 AM
morehouse committed rCRT340954: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Wed, Aug 29, 11:43 AM
morehouse committed rCRT340949: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Wed, Aug 29, 11:10 AM
morehouse committed rL340949: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Wed, Aug 29, 11:09 AM
morehouse committed rC340949: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Wed, Aug 29, 11:09 AM

Tue, Aug 28

morehouse committed rC340867: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Tue, Aug 28, 12:08 PM
morehouse committed rCRT340867: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Tue, Aug 28, 12:08 PM
morehouse committed rL340867: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Tue, Aug 28, 12:08 PM
morehouse committed rC340860: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Tue, Aug 28, 11:35 AM
morehouse committed rCRT340860: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Tue, Aug 28, 11:35 AM
morehouse committed rL340860: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Tue, Aug 28, 11:35 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Tue, Aug 28, 11:35 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Tue, Aug 28, 11:35 AM

Mon, Aug 27

morehouse added a comment to D51022: [libFuzzer] Port to Windows.

We will need to disable failing tests for Windows. libFuzzer does run as part of check-all now.

Mon, Aug 27, 5:41 PM

Aug 23 2018

morehouse added inline comments to D51022: [libFuzzer] Port to Windows.
Aug 23 2018, 9:07 AM

Aug 22 2018

morehouse accepted D51022: [libFuzzer] Port to Windows.
Aug 22 2018, 3:10 PM
morehouse added inline comments to D51022: [libFuzzer] Port to Windows.
Aug 22 2018, 10:44 AM
morehouse resigned from D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges.
Aug 22 2018, 9:13 AM

Aug 21 2018

morehouse added inline comments to D51022: [libFuzzer] Port to Windows.
Aug 21 2018, 6:12 PM
morehouse added inline comments to D51022: [libFuzzer] Port to Windows.
Aug 21 2018, 2:12 PM

Aug 20 2018

morehouse added a comment to D51008: Enable -fsanitize=fuzzer and -fsanitize=fuzzer-no-link on Windows..

LGTM

Aug 20 2018, 5:12 PM

Aug 16 2018

morehouse committed rL339976: Revert "[libFuzzer] Use std::discrete_distribution for input selection.".
Revert "[libFuzzer] Use std::discrete_distribution for input selection."
Aug 16 2018, 6:31 PM
morehouse committed rCRT339976: Revert "[libFuzzer] Use std::discrete_distribution for input selection.".
Revert "[libFuzzer] Use std::discrete_distribution for input selection."
Aug 16 2018, 6:31 PM
morehouse committed rL339973: [libFuzzer] Use std::discrete_distribution for input selection..
[libFuzzer] Use std::discrete_distribution for input selection.
Aug 16 2018, 5:14 PM
morehouse committed rCRT339973: [libFuzzer] Use std::discrete_distribution for input selection..
[libFuzzer] Use std::discrete_distribution for input selection.
Aug 16 2018, 5:14 PM
morehouse closed D50356: [libFuzzer] Use std::discrete_distribution for input selection..
Aug 16 2018, 5:14 PM
morehouse accepted D50829: Update README and Dockerfile to include llvm-proto-fuzzer.
Aug 16 2018, 11:50 AM

Aug 15 2018

morehouse added inline comments to D50829: Update README and Dockerfile to include llvm-proto-fuzzer.
Aug 15 2018, 5:50 PM
morehouse accepted D50670: Implementation of nested loops in cxx_loop_proto.
Aug 15 2018, 3:56 PM
morehouse added inline comments to D50670: Implementation of nested loops in cxx_loop_proto.
Aug 15 2018, 3:15 PM
morehouse added inline comments to D50670: Implementation of nested loops in cxx_loop_proto.
Aug 15 2018, 1:40 PM
morehouse added inline comments to D50670: Implementation of nested loops in cxx_loop_proto.
Aug 15 2018, 11:35 AM
morehouse added a comment to D50670: Implementation of nested loops in cxx_loop_proto.

Does this hit new coverage in the vectorizer?

Aug 15 2018, 9:15 AM

Aug 14 2018

morehouse committed rL339733: [SanitizerCoverage] Add associated metadata to PC guards..
[SanitizerCoverage] Add associated metadata to PC guards.
Aug 14 2018, 3:05 PM
morehouse committed rCRT339733: [SanitizerCoverage] Add associated metadata to PC guards..
[SanitizerCoverage] Add associated metadata to PC guards.
Aug 14 2018, 3:05 PM
morehouse closed D50483: [SanitizerCoverage] Add associated metadata to PC guards..
Aug 14 2018, 3:05 PM
morehouse updated the summary of D50483: [SanitizerCoverage] Add associated metadata to PC guards..
Aug 14 2018, 3:02 PM
morehouse added a comment to D50483: [SanitizerCoverage] Add associated metadata to PC guards..

Ping. Can we submit this patch at least for consistency with PC tables and inline counters?

Aug 14 2018, 2:34 PM
morehouse added a comment to D50670: Implementation of nested loops in cxx_loop_proto.

Another option would be to allow simple control flow within the loop itself.

Aug 14 2018, 12:47 PM
morehouse added a comment to D50670: Implementation of nested loops in cxx_loop_proto.

Should I switch my focus to nested loops instead? I think nested loops will increase coverage.

Aug 14 2018, 12:43 PM
morehouse accepted D50548: [CMake] Don't parse target triple except for arch.
Aug 14 2018, 9:14 AM

Aug 13 2018

morehouse added a comment to D50670: Implementation of nested loops in cxx_loop_proto.

Does having multiple loops one after another change any coverage in the vectorizer?

Aug 13 2018, 3:46 PM
morehouse added inline comments to D50548: [CMake] Don't parse target triple except for arch.
Aug 13 2018, 9:30 AM

Aug 10 2018

morehouse updated subscribers of D50483: [SanitizerCoverage] Add associated metadata to PC guards..

As I understood, the runtime library relies on the fact that when the linker constructs sections for pcguards and for counters, it does that in the same order. This is not guaranteed.

Aug 10 2018, 10:09 AM