Page MenuHomePhabricator

morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (143 w, 6 d)

Recent Activity

Mon, Mar 9

morehouse committed rGd93303b783be: [ASan] Enable set_shadow_test.c on Windows. (authored by morehouse).
[ASan] Enable set_shadow_test.c on Windows.
Mon, Mar 9, 4:13 PM

Thu, Mar 5

morehouse accepted D75693: [GWP-ASan] Fix thread ID..

LGTM

Thu, Mar 5, 10:22 AM · Restricted Project, Restricted Project

Feb 28 2020

morehouse committed rG30bb737a757e: [DFSan] Add __dfsan_cmp_callback. (authored by morehouse).
[DFSan] Add __dfsan_cmp_callback.
Feb 28 2020, 3:58 PM
morehouse closed D75389: [DFSan] Add __dfsan_cmp_callback..
Feb 28 2020, 3:57 PM · Restricted Project, Restricted Project
morehouse committed rGf668baa45926: [DFSan] Add __dfsan_mem_transfer_callback. (authored by morehouse).
[DFSan] Add __dfsan_mem_transfer_callback.
Feb 28 2020, 3:49 PM
morehouse closed D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 3:49 PM · Restricted Project, Restricted Project
morehouse created D75389: [DFSan] Add __dfsan_cmp_callback..
Feb 28 2020, 3:30 PM · Restricted Project, Restricted Project
morehouse added a parent revision for D75389: [DFSan] Add __dfsan_cmp_callback.: D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 3:30 PM · Restricted Project, Restricted Project
morehouse added a child revision for D75386: [DFSan] Add __dfsan_mem_transfer_callback.: D75389: [DFSan] Add __dfsan_cmp_callback..
Feb 28 2020, 3:30 PM · Restricted Project, Restricted Project
morehouse committed rG52f889abecc7: [DFSan] Add __dfsan_load_callback. (authored by morehouse).
[DFSan] Add __dfsan_load_callback.
Feb 28 2020, 2:27 PM
morehouse closed D75363: [DFSan] Add __dfsan_load_callback..
Feb 28 2020, 2:27 PM · Restricted Project, Restricted Project
morehouse added reviewers for D75386: [DFSan] Add __dfsan_mem_transfer_callback.: vitalybuka, kcc, pcc.
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse added a child revision for D75363: [DFSan] Add __dfsan_load_callback.: D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse added a parent revision for D75386: [DFSan] Add __dfsan_mem_transfer_callback.: D75363: [DFSan] Add __dfsan_load_callback..
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse created D75386: [DFSan] Add __dfsan_mem_transfer_callback..
Feb 28 2020, 2:09 PM · Restricted Project, Restricted Project
morehouse created D75363: [DFSan] Add __dfsan_load_callback..
Feb 28 2020, 9:19 AM · Restricted Project, Restricted Project

Feb 27 2020

morehouse committed rG470db54cbdf1: [DFSan] Add flag to insert event callbacks. (authored by morehouse).
[DFSan] Add flag to insert event callbacks.
Feb 27 2020, 5:15 PM
morehouse closed D75312: [DFSan] Add flag to insert event callbacks..
Feb 27 2020, 5:14 PM · Restricted Project, Restricted Project
morehouse updated the diff for D75312: [DFSan] Add flag to insert event callbacks..
  • Fix diffbase.
Feb 27 2020, 5:14 PM · Restricted Project, Restricted Project
morehouse updated the diff for D75312: [DFSan] Add flag to insert event callbacks..
  • Add comment explaining the new flag.
Feb 27 2020, 5:14 PM · Restricted Project, Restricted Project
morehouse abandoned D75321: Add comment explaining the new flag..
Feb 27 2020, 5:14 PM · Restricted Project
morehouse added a comment to D75312: [DFSan] Add flag to insert event callbacks..

Do you want to also pass the store address to the callback?

Feb 27 2020, 5:05 PM · Restricted Project, Restricted Project
morehouse created D75321: Add comment explaining the new flag..
Feb 27 2020, 5:05 PM · Restricted Project
morehouse updated subscribers of D75312: [DFSan] Add flag to insert event callbacks..
Feb 27 2020, 4:38 PM · Restricted Project, Restricted Project
morehouse committed rG2a29617b9d15: [DFSan] Remove unused IRBuilder. NFC (authored by morehouse).
[DFSan] Remove unused IRBuilder. NFC
Feb 27 2020, 4:29 PM
morehouse closed D75190: [DFSan] Remove unused IRBuilder. NFC.
Feb 27 2020, 4:29 PM · Restricted Project
morehouse created D75312: [DFSan] Add flag to insert event callbacks..
Feb 27 2020, 4:20 PM · Restricted Project, Restricted Project

Feb 26 2020

morehouse created D75190: [DFSan] Remove unused IRBuilder. NFC.
Feb 26 2020, 8:51 AM · Restricted Project

Feb 12 2020

morehouse accepted D74364: [GWP-ASan] Update alignment on Android..
Feb 12 2020, 3:18 PM · Restricted Project, Restricted Project
morehouse added inline comments to D74364: [GWP-ASan] Update alignment on Android..
Feb 12 2020, 11:10 AM · Restricted Project, Restricted Project
morehouse added inline comments to D74364: [GWP-ASan] Update alignment on Android..
Feb 12 2020, 11:01 AM · Restricted Project, Restricted Project

Feb 10 2020

morehouse added a comment to D74364: [GWP-ASan] Update alignment on Android..

Does Bionic's malloc have the required alignment information available at the call to gwp_asan::allocate? If so, we could get tighter right alignment by adding an alignment parameter (instead of conservative 16-byte rounding). This is the approach used in both Chrome and TCMalloc.

Feb 10 2020, 5:54 PM · Restricted Project, Restricted Project

Oct 31 2019

morehouse accepted D69675: [scudo][standalone] Fix Secondary bug w/ freelist.
Oct 31 2019, 11:56 AM · Restricted Project, Restricted Project
morehouse added inline comments to D69675: [scudo][standalone] Fix Secondary bug w/ freelist.
Oct 31 2019, 11:38 AM · Restricted Project, Restricted Project

Oct 30 2019

morehouse committed rG7904bd9409b8: [sanitizer_common] Create max_allocation_size_mb flag. (authored by morehouse).
[sanitizer_common] Create max_allocation_size_mb flag.
Oct 30 2019, 11:32 AM
morehouse closed D69576: [sanitizer_common] Create max_allocation_size_mb flag..
Oct 30 2019, 11:31 AM · Restricted Project, Restricted Project

Oct 29 2019

morehouse accepted D69570: [scudo][standalone] Add a free list to the Secondary.
Oct 29 2019, 6:29 PM · Restricted Project, Restricted Project
morehouse added inline comments to D69576: [sanitizer_common] Create max_allocation_size_mb flag..
Oct 29 2019, 12:49 PM · Restricted Project, Restricted Project
morehouse created D69576: [sanitizer_common] Create max_allocation_size_mb flag..
Oct 29 2019, 11:23 AM · Restricted Project, Restricted Project

Oct 25 2019

morehouse committed rGa88591cff466: [libFuzzer] Enable extra counters for Fuchsia. (authored by morehouse).
[libFuzzer] Enable extra counters for Fuchsia.
Oct 25 2019, 4:20 PM

Oct 22 2019

morehouse added a comment to D69196: Fix lld detection in standalone compiler-rt..

This appears to have broken the standalone compiler-rt build: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/23986

Oct 22 2019, 11:43 AM · Restricted Project, Restricted Project

Oct 21 2019

morehouse accepted D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.

LGTM

Oct 21 2019, 10:27 AM · Restricted Project

Oct 18 2019

morehouse added inline comments to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.
Oct 18 2019, 4:32 PM · Restricted Project

Oct 10 2019

morehouse committed rL374493: Add morehouse..
Add morehouse.
Oct 10 2019, 6:08 PM

Oct 9 2019

morehouse committed rGda6cb7ba4c73: [sanitizer_common] Remove OnPrint from Go build. (authored by morehouse).
[sanitizer_common] Remove OnPrint from Go build.
Oct 9 2019, 4:03 PM
morehouse committed rL374258: [sanitizer_common] Remove OnPrint from Go build..
[sanitizer_common] Remove OnPrint from Go build.
Oct 9 2019, 4:03 PM
morehouse closed D68621: [sanitizer_common] Remove OnPrint from Go build..
Oct 9 2019, 4:03 PM · Restricted Project, Restricted Project

Oct 8 2019

morehouse accepted D68653: [scudo][standalone] Get statistics in a char buffer.
Oct 8 2019, 6:37 PM · Restricted Project, Restricted Project

Oct 7 2019

morehouse created D68621: [sanitizer_common] Remove OnPrint from Go build..
Oct 7 2019, 6:28 PM · Restricted Project, Restricted Project

Oct 4 2019

morehouse accepted D68471: [scudo][standalone] Correct releaseToOS behavior.
Oct 4 2019, 4:28 PM · Restricted Project, Restricted Project
morehouse added inline comments to D68471: [scudo][standalone] Correct releaseToOS behavior.
Oct 4 2019, 3:28 PM · Restricted Project, Restricted Project

Oct 3 2019

morehouse accepted D68427: [scudo][standalone] Make malloc_info return a minimal XML.
Oct 3 2019, 3:24 PM · Restricted Project, Restricted Project

Oct 2 2019

morehouse committed rG629cad1266bd: Move SanitizerInitializeUnwinder outside anonymous namespace. (authored by morehouse).
Move SanitizerInitializeUnwinder outside anonymous namespace.
Oct 2 2019, 3:57 PM
morehouse committed rL373539: Move SanitizerInitializeUnwinder outside anonymous namespace..
Move SanitizerInitializeUnwinder outside anonymous namespace.
Oct 2 2019, 3:55 PM
morehouse committed rG4d39410b1e08: [sanitizer_common] Declare __sanitizer_on_print in Windows interception. (authored by morehouse).
[sanitizer_common] Declare __sanitizer_on_print in Windows interception.
Oct 2 2019, 3:00 PM
morehouse committed rL373532: [sanitizer_common] Declare __sanitizer_on_print in Windows interception..
[sanitizer_common] Declare __sanitizer_on_print in Windows interception.
Oct 2 2019, 2:58 PM
morehouse committed rG38ac6bdb83a9: [sanitizer_common] Disable onprint.cpp on Android. (authored by morehouse).
[sanitizer_common] Disable onprint.cpp on Android.
Oct 2 2019, 2:43 PM
morehouse committed rL373531: [sanitizer_common] Disable onprint.cpp on Android..
[sanitizer_common] Disable onprint.cpp on Android.
Oct 2 2019, 2:43 PM
morehouse committed rG62f190ce9a86: [sanitizer_common] Add __sanitizer_on_print to interface list. (authored by morehouse).
[sanitizer_common] Add __sanitizer_on_print to interface list.
Oct 2 2019, 2:25 PM
morehouse committed rL373530: [sanitizer_common] Add __sanitizer_on_print to interface list..
[sanitizer_common] Add __sanitizer_on_print to interface list.
Oct 2 2019, 2:24 PM
morehouse committed rGe55c442b1b65: [sanitizer_common] Rename OnPrint to __sanitizer_on_print. (authored by morehouse).
[sanitizer_common] Rename OnPrint to __sanitizer_on_print.
Oct 2 2019, 1:13 PM
morehouse committed rL373518: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
[sanitizer_common] Rename OnPrint to __sanitizer_on_print.
Oct 2 2019, 1:11 PM
morehouse closed D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
Oct 2 2019, 1:11 PM · Restricted Project

Oct 1 2019

morehouse committed rG1c8e05110c01: [libFuzzer] Remove lazy counters. (authored by morehouse).
[libFuzzer] Remove lazy counters.
Oct 1 2019, 3:49 PM
morehouse committed rL373403: [libFuzzer] Remove lazy counters..
[libFuzzer] Remove lazy counters.
Oct 1 2019, 3:48 PM
morehouse closed D67476: [libFuzzer] Remove lazy counters..
Oct 1 2019, 3:48 PM · Restricted Project
morehouse added a comment to D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..

For the Go version we have a non-weak declaration without definition. How are we going to roll out the change? We would need to update llvm and the hook implementation atomically. But then I am confused how it works today. We have a non-extern "C" hook definition, so build should be broken for the last year...

Oct 1 2019, 1:12 PM · Restricted Project
morehouse updated the diff for D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
  • Keep Go's OnPrint declaration for now.
Oct 1 2019, 1:07 PM · Restricted Project

Sep 27 2019

morehouse accepted D68067: [libFuzzer] Dump trace and provide correct msg for overwritten input..

LGTM

Sep 27 2019, 2:45 PM · Restricted Project, Restricted Project

Sep 26 2019

morehouse added a comment to D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..

Hmm.. Actually it is defined. I'll have to look into it more...

Sep 26 2019, 11:04 AM · Restricted Project
morehouse added a comment to D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..

I don't see TSAN_EXTERNAL_HOOKS defined anywhere internally. So presumably the non-weak definition was never used.

Sep 26 2019, 10:39 AM · Restricted Project

Sep 25 2019

morehouse added inline comments to D68067: [libFuzzer] Dump trace and provide correct msg for overwritten input..
Sep 25 2019, 6:20 PM · Restricted Project, Restricted Project

Sep 24 2019

morehouse added a comment to D28596: [compiler-rt] General definition for weak functions..
In D28596#1680946, @rnk wrote:

I see. I audited the other instances of SANITIZER_INTERFACE_WEAK_DEF, and they all seem to be properly namespaced into __asan_, __sanitizer_, etc.

Do you (or someone else from dynamic-tools) mind driving the fix for this, since you control the internal integration for this and would know where to add the missing test? Again, sorry for the breakage.

Sep 24 2019, 2:36 PM · Restricted Project
morehouse created D67987: [sanitizer_common] Rename OnPrint to __sanitizer_on_print..
Sep 24 2019, 2:31 PM · Restricted Project

Sep 20 2019

morehouse committed rG949a126438b9: [docs] Update structure-aware-fuzzing link. (authored by morehouse).
[docs] Update structure-aware-fuzzing link.
Sep 20 2019, 12:42 PM
morehouse committed rL372423: [docs] Update structure-aware-fuzzing link..
[docs] Update structure-aware-fuzzing link.
Sep 20 2019, 12:42 PM

Sep 11 2019

morehouse created D67476: [libFuzzer] Remove lazy counters..
Sep 11 2019, 5:40 PM · Restricted Project

Sep 10 2019

morehouse accepted D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file..
Sep 10 2019, 3:15 PM · Restricted Project, Restricted Project
morehouse accepted D67293: [scudo][standalone] Android related improvements.

LGTM

Sep 10 2019, 2:24 PM · Restricted Project, Restricted Project

Aug 27 2019

morehouse added a comment to D65672: [compiler-rt] Expose fuzzer coverage bitmaps to the target.

My opinion is that this exposes too much implementation detail and seems too hacky/niche to be merged into libFuzzer. But I defer the ultimate decision to @kcc (who is unlikely to respond until next week when he is back in the office).

Aug 27 2019, 10:11 AM · Restricted Project, Restricted Project

Aug 20 2019

morehouse added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 20 2019, 6:11 PM · Restricted Project, Restricted Project

Aug 19 2019

morehouse accepted D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 19 2019, 4:57 PM · Restricted Project, Restricted Project
morehouse added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 19 2019, 9:09 AM · Restricted Project, Restricted Project

Aug 13 2019

morehouse added a reviewer for D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file.: kcc.

A few high-level thoughts/questions:

Aug 13 2019, 3:47 PM · Restricted Project, Restricted Project
morehouse accepted D66112: [scudo][standalone] Add more stats to mallinfo.

LGTM

Aug 13 2019, 9:46 AM · Restricted Project, Restricted Project

Aug 12 2019

morehouse accepted D66030: [libFuzzer] Merge: print feature coverage number as well..
Aug 12 2019, 10:22 AM · Restricted Project, Restricted Project
morehouse added inline comments to D66030: [libFuzzer] Merge: print feature coverage number as well..
Aug 12 2019, 10:19 AM · Restricted Project, Restricted Project

Aug 8 2019

morehouse accepted D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Aug 8 2019, 12:45 PM · Restricted Project, Restricted Project

Aug 7 2019

morehouse accepted D65905: [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP..
Aug 7 2019, 4:14 PM · Restricted Project, Restricted Project

Aug 5 2019

morehouse accepted D65661: [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use..

Yep, i failed to convey the problem.
Any code that uses that header will get locked into compiler that provides said header,
unless they resort to bundling said header in the first place, which will be frowned upon.

Aug 5 2019, 11:29 AM · Restricted Project, Restricted Project

Aug 2 2019

morehouse accepted D65660: [scudo][standalone] Minor corrections.

LGTM

Aug 2 2019, 10:10 AM · Restricted Project, Restricted Project

Jul 23 2019

morehouse accepted D62875: [GWP-ASan] Add public-facing documentation [6]..
Jul 23 2019, 9:26 AM · Restricted Project, Restricted Project

Jul 22 2019

morehouse added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Jul 22 2019, 5:34 PM · Restricted Project, Restricted Project

Jul 19 2019

morehouse accepted D65029: [Driver] Support for disabling sanitizer runtime linking.

LGTM

Jul 19 2019, 5:00 PM · Restricted Project, Restricted Project
morehouse committed rG2272be94f220: [RISCV] Disable tests failing on buildbots. (authored by morehouse).
[RISCV] Disable tests failing on buildbots.
Jul 19 2019, 11:06 AM
morehouse committed rL366599: [RISCV] Disable tests failing on buildbots..
[RISCV] Disable tests failing on buildbots.
Jul 19 2019, 11:06 AM

Jul 16 2019

morehouse added a comment to D63733: [IndVars] Use exit count reasoning to discharge obviously untaken exits.

The assertion assert(!ExitCount->isZero() && "Should have been folded above"); is failing during the unittest build on the UBSan bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/13940

Jul 16 2019, 9:57 AM · Restricted Project

Jul 15 2019

morehouse committed rG8528b1951cc6: [ASan] Fix >80 character line. (authored by morehouse).
[ASan] Fix >80 character line.
Jul 15 2019, 3:10 PM
morehouse committed rL366136: [ASan] Fix >80 character line..
[ASan] Fix >80 character line.
Jul 15 2019, 3:07 PM

Jul 11 2019

morehouse accepted D64587: Use clang driver for libfuzzer tests on Windows.

LGTM

Jul 11 2019, 1:51 PM · Restricted Project, Restricted Project