morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (29 w, 3 d)

Recent Activity

Tue, Jan 16

morehouse added a comment to D37631: [libFuzzer] Support using libc++.

Vitaly, does this test clean on your end now?

Tue, Jan 16, 10:21 AM
morehouse added a comment to D42093: [llvm-cov] Improvements for summary report generated in HTML format..

Changes look nice visually. I think standard practice is to right-align numerical entries, but that might require a bit more work to pad properly.

Tue, Jan 16, 10:00 AM

Fri, Jan 12

morehouse committed rL322409: [libFuzzer] Fix bug introduced in r322380 that always links -lc++..
[libFuzzer] Fix bug introduced in r322380 that always links -lc++.
Fri, Jan 12, 2:12 PM
morehouse committed rCRT322409: [libFuzzer] Fix bug introduced in r322380 that always links -lc++..
[libFuzzer] Fix bug introduced in r322380 that always links -lc++.
Fri, Jan 12, 2:12 PM
morehouse added a comment to D37631: [libFuzzer] Support using libc++.

check-fuzzer tests clean for me now with both clang and gcc.

Fri, Jan 12, 9:18 AM
morehouse accepted D41642: lib Fuzzer FreeBSD support.

LGTM

Fri, Jan 12, 9:09 AM

Wed, Jan 10

morehouse added a comment to D41916: SmallVector: fix use-after-poison MSAN error in destructor.

Steve, you need commit access. See https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. I've pushed this patch for you.

Wed, Jan 10, 3:56 PM
morehouse committed rL322241: SmallVector: fix use-after-poison MSAN error in destructor.
SmallVector: fix use-after-poison MSAN error in destructor
Wed, Jan 10, 3:54 PM
morehouse closed D41916: SmallVector: fix use-after-poison MSAN error in destructor.
Wed, Jan 10, 3:54 PM
morehouse added inline comments to D41642: lib Fuzzer FreeBSD support.
Wed, Jan 10, 3:44 PM
morehouse added a comment to D41916: SmallVector: fix use-after-poison MSAN error in destructor.

LGTM for fixing the use-after-dtor. I'll let @dblaikie comment since he brought up template bloat issues on https://reviews.llvm.org/D12970.

Wed, Jan 10, 2:52 PM
morehouse added a reviewer for D41916: SmallVector: fix use-after-poison MSAN error in destructor: dblaikie.
Wed, Jan 10, 2:47 PM
morehouse added inline comments to D37631: [libFuzzer] Support using libc++.
Wed, Jan 10, 2:08 PM
morehouse committed rL322221: [MSan] Enable use-after-dtor instrumentation by default..
[MSan] Enable use-after-dtor instrumentation by default.
Wed, Jan 10, 12:29 PM
morehouse committed rCRT322221: [MSan] Enable use-after-dtor instrumentation by default..
[MSan] Enable use-after-dtor instrumentation by default.
Wed, Jan 10, 12:29 PM
morehouse committed rC322221: [MSan] Enable use-after-dtor instrumentation by default..
[MSan] Enable use-after-dtor instrumentation by default.
Wed, Jan 10, 12:29 PM
morehouse closed D37860: [MSan] Enable use-after-dtor instrumentation by default..
Wed, Jan 10, 12:29 PM
morehouse added a comment to D37860: [MSan] Enable use-after-dtor instrumentation by default..

PTAL. Patch has been updated.

Wed, Jan 10, 11:52 AM
morehouse updated the diff for D37860: [MSan] Enable use-after-dtor instrumentation by default..
  • Enable use-after-dtor instrumentation by default.
  • Make sanitize-no-dtor-callback.cpp test fail with UAD instrumentation.
  • Update test cases to reflect new default.
Wed, Jan 10, 11:50 AM

Fri, Jan 5

morehouse added inline comments to D41776: [lit] Implement "-r" option for builtin "diff" command + a test using that..
Fri, Jan 5, 10:57 AM

Wed, Jan 3

morehouse added a comment to D41206: [llvm-cov] Multi-threaded implementation of prepareFileReports method..

LGTM, but let Vedant comment since he's more familiar with this code.

Wed, Jan 3, 3:43 PM

Dec 20 2017

morehouse committed rCTE321226: [clangd-fuzzer] Update ClangdLSPServer constructor call..
[clangd-fuzzer] Update ClangdLSPServer constructor call.
Dec 20 2017, 2:30 PM
morehouse committed rL321226: [clangd-fuzzer] Update ClangdLSPServer constructor call..
[clangd-fuzzer] Update ClangdLSPServer constructor call.
Dec 20 2017, 2:30 PM

Dec 13 2017

morehouse committed rL320643: [libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver..
[libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver.
Dec 13 2017, 2:03 PM
morehouse committed rCRT320643: [libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver..
[libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver.
Dec 13 2017, 2:03 PM
morehouse closed D41193: [libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver..
Dec 13 2017, 2:03 PM

Dec 8 2017

morehouse committed rL320210: [libFuzzer] Add support for Fuchsia OS..
[libFuzzer] Add support for Fuchsia OS.
Dec 8 2017, 2:55 PM
morehouse committed rCRT320210: [libFuzzer] Add support for Fuchsia OS..
[libFuzzer] Add support for Fuchsia OS.
Dec 8 2017, 2:55 PM
morehouse closed D40974: [libFuzzer] Add support for Fuchsia OS by committing rCRT320210: [libFuzzer] Add support for Fuchsia OS..
Dec 8 2017, 2:55 PM

Dec 7 2017

morehouse committed rCTE320074: [clangd-fuzzer] Update contruction of LSPServer..
[clangd-fuzzer] Update contruction of LSPServer.
Dec 7 2017, 11:05 AM
morehouse committed rL320074: [clangd-fuzzer] Update contruction of LSPServer..
[clangd-fuzzer] Update contruction of LSPServer.
Dec 7 2017, 11:05 AM

Dec 6 2017

morehouse committed rL319987: [CMake] Use PRIVATE when linking LLVM fuzzers..
[CMake] Use PRIVATE when linking LLVM fuzzers.
Dec 6 2017, 3:33 PM
morehouse committed rCTE319948: [CMake] Use PRIVATE in target_link_libraries for fuzzers..
[CMake] Use PRIVATE in target_link_libraries for fuzzers.
Dec 6 2017, 11:53 AM
morehouse committed rL319948: [CMake] Use PRIVATE in target_link_libraries for fuzzers..
[CMake] Use PRIVATE in target_link_libraries for fuzzers.
Dec 6 2017, 11:53 AM
morehouse committed rC319948: [CMake] Use PRIVATE in target_link_libraries for fuzzers..
[CMake] Use PRIVATE in target_link_libraries for fuzzers.
Dec 6 2017, 11:53 AM

Dec 5 2017

morehouse committed rCRT319792: [libFuzzer] Make redirects happen in proper sequence..
[libFuzzer] Make redirects happen in proper sequence.
Dec 5 2017, 9:14 AM
morehouse committed rL319792: [libFuzzer] Make redirects happen in proper sequence..
[libFuzzer] Make redirects happen in proper sequence.
Dec 5 2017, 9:14 AM

Dec 4 2017

morehouse committed rL319685: [libFuzzer] Remove const from ignoreRemainingArgs return value..
[libFuzzer] Remove const from ignoreRemainingArgs return value.
Dec 4 2017, 12:07 PM
morehouse committed rCRT319685: [libFuzzer] Remove const from ignoreRemainingArgs return value..
[libFuzzer] Remove const from ignoreRemainingArgs return value.
Dec 4 2017, 12:07 PM
morehouse committed rCRT319682: [libFuzzer] Remove FuzzerCommand.cpp from build sources..
[libFuzzer] Remove FuzzerCommand.cpp from build sources.
Dec 4 2017, 11:54 AM
morehouse committed rL319682: [libFuzzer] Remove FuzzerCommand.cpp from build sources..
[libFuzzer] Remove FuzzerCommand.cpp from build sources.
Dec 4 2017, 11:54 AM
morehouse committed rL319680: [libFuzzer] Encapsulate commands in a class..
[libFuzzer] Encapsulate commands in a class.
Dec 4 2017, 11:26 AM
morehouse committed rCRT319680: [libFuzzer] Encapsulate commands in a class..
[libFuzzer] Encapsulate commands in a class.
Dec 4 2017, 11:26 AM
morehouse closed D40103: [libFuzzer] Encapsulate commands in a class by committing rL319680: [libFuzzer] Encapsulate commands in a class..
Dec 4 2017, 11:26 AM
morehouse closed D40103: [libFuzzer] Encapsulate commands in a class by committing rCRT319680: [libFuzzer] Encapsulate commands in a class..
Dec 4 2017, 11:26 AM
morehouse accepted D40103: [libFuzzer] Encapsulate commands in a class.

LGTM. Do you have commit access, or should I land this for you?

Dec 4 2017, 10:05 AM

Dec 1 2017

morehouse committed rL319591: Revert "[X86] Improvement in CodeGen instruction selection for LEAs.".
Revert "[X86] Improvement in CodeGen instruction selection for LEAs."
Dec 1 2017, 2:21 PM

Nov 30 2017

morehouse added a comment to D37631: [libFuzzer] Support using libc++.

LGTM for recent clang. Not sure how long ago -stdlib=libc++ support was added. If it was long enough ago, maybe the lit config is OK? Otherwise might need to check clang version or something.

Nov 30 2017, 10:21 AM

Nov 27 2017

morehouse committed rL319114: [TSan] Do not run cond_cancel.c test on ppc64..
[TSan] Do not run cond_cancel.c test on ppc64.
Nov 27 2017, 3:21 PM

Nov 16 2017

morehouse committed rL318475: [libFuzzer] Fix flaky merge.test..
[libFuzzer] Fix flaky merge.test.
Nov 16 2017, 4:11 PM
morehouse committed rL318465: [libFuzzer] Make merge-sigusr.test work on Mac..
[libFuzzer] Make merge-sigusr.test work on Mac.
Nov 16 2017, 3:06 PM
morehouse added inline comments to D40103: [libFuzzer] Encapsulate commands in a class.
Nov 16 2017, 12:41 PM

Nov 15 2017

morehouse planned changes to D37860: [MSan] Enable use-after-dtor instrumentation by default..
Nov 15 2017, 5:11 PM
morehouse added a comment to D37860: [MSan] Enable use-after-dtor instrumentation by default..

Patch is out-of-date. But the flag has been enabled internally for over a month with no issues. I'll update this patch soon, so we can flip the default here.

Nov 15 2017, 4:01 PM

Nov 9 2017

morehouse committed rL317831: [libFuzzer] Don't add leaking inputs to corpus..
[libFuzzer] Don't add leaking inputs to corpus.
Nov 9 2017, 12:44 PM
morehouse closed D39850: [libFuzzer] Don't add leaking inputs to corpus. by committing rL317831: [libFuzzer] Don't add leaking inputs to corpus..
Nov 9 2017, 12:44 PM
morehouse updated the diff for D39850: [libFuzzer] Don't add leaking inputs to corpus..
  • Simplify test logic.
Nov 9 2017, 11:49 AM
morehouse updated the diff for D39850: [libFuzzer] Don't add leaking inputs to corpus..
  • Add test.
Nov 9 2017, 11:37 AM
morehouse created D39850: [libFuzzer] Don't add leaking inputs to corpus..
Nov 9 2017, 10:06 AM

Oct 31 2017

morehouse accepted D39445: [clang-fuzzer] Fix incremental builds of the fuzzer.

LGTM.

Oct 31 2017, 9:26 AM

Oct 18 2017

morehouse committed rL316103: [clang-proto-fuzzer] Use ToT protobuf-mutator..
[clang-proto-fuzzer] Use ToT protobuf-mutator.
Oct 18 2017, 11:38 AM

Oct 17 2017

morehouse closed D38981: Added SpecialCastList fuzzer..

Landed as r316014.

Oct 17 2017, 10:46 AM
morehouse committed rL316014: [llvm-special-case-list-fuzzer] Add fuzz target..
[llvm-special-case-list-fuzzer] Add fuzz target.
Oct 17 2017, 10:43 AM
morehouse accepted D38981: Added SpecialCastList fuzzer..

LGTM

Oct 17 2017, 8:56 AM

Oct 16 2017

morehouse added inline comments to D38981: Added SpecialCastList fuzzer..
Oct 16 2017, 5:11 PM

Oct 13 2017

morehouse committed rL315716: [llvm-demangle-fuzzer] Add a fuzz target for ItaniumDemangler..
[llvm-demangle-fuzzer] Add a fuzz target for ItaniumDemangler.
Oct 13 2017, 10:35 AM
morehouse closed D38855: Add a fuzz target for llvm's ItaniumDemangler. by committing rL315716: [llvm-demangle-fuzzer] Add a fuzz target for ItaniumDemangler..
Oct 13 2017, 10:35 AM

Oct 12 2017

morehouse committed rL315647: [llvm-isel-fuzzer] Use "--" as separator rather than '='..
[llvm-isel-fuzzer] Use "--" as separator rather than '='.
Oct 12 2017, 5:18 PM
morehouse closed D38866: [llvm-isel-fuzzer] Use "--" as separator rather than '='. by committing rL315647: [llvm-isel-fuzzer] Use "--" as separator rather than '='..
Oct 12 2017, 5:18 PM
morehouse added a comment to D38866: [llvm-isel-fuzzer] Use "--" as separator rather than '='..

I tested this manually and it seems to work, but doing ninja check-llvm doesn't seem to run these test cases for me. Maybe my config uses rpath?

Oct 12 2017, 5:06 PM
morehouse created D38866: [llvm-isel-fuzzer] Use "--" as separator rather than '='..
Oct 12 2017, 5:04 PM
morehouse committed rL315630: [cmake] Rename LIB_FUZZING_ENGINE to LLVM_LIB_FUZZING_ENGINE..
[cmake] Rename LIB_FUZZING_ENGINE to LLVM_LIB_FUZZING_ENGINE.
Oct 12 2017, 3:00 PM
morehouse committed rL315629: [cmake] Allow building fuzzers with OSS-Fuzz flags..
[cmake] Allow building fuzzers with OSS-Fuzz flags.
Oct 12 2017, 2:59 PM
morehouse closed D38858: [cmake] Allow building fuzzers with OSS-Fuzz flags. by committing rL315629: [cmake] Allow building fuzzers with OSS-Fuzz flags..
Oct 12 2017, 2:58 PM
morehouse added inline comments to D38858: [cmake] Allow building fuzzers with OSS-Fuzz flags..
Oct 12 2017, 1:55 PM
morehouse updated the diff for D38858: [cmake] Allow building fuzzers with OSS-Fuzz flags..
  • Add cache variable and rename to LLVM_LIB_FUZZING_ENGINE.
Oct 12 2017, 1:53 PM
morehouse added inline comments to D38858: [cmake] Allow building fuzzers with OSS-Fuzz flags..
Oct 12 2017, 12:59 PM
morehouse created D38858: [cmake] Allow building fuzzers with OSS-Fuzz flags..
Oct 12 2017, 12:15 PM
morehouse added a comment to D38855: Add a fuzz target for llvm's ItaniumDemangler..

To add this to OSS-Fuzz, you will need to link with LIB_FUZZING_ENGINE.

Oct 12 2017, 11:49 AM
morehouse committed rL315603: [clang-format] Allow building fuzzer with OSS-Fuzz flags..
[clang-format] Allow building fuzzer with OSS-Fuzz flags.
Oct 12 2017, 11:39 AM
morehouse closed D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags. by committing rL315603: [clang-format] Allow building fuzzer with OSS-Fuzz flags..
Oct 12 2017, 11:39 AM
morehouse added a comment to D38855: Add a fuzz target for llvm's ItaniumDemangler..

To add this to OSS-Fuzz, you will need to link with LIB_FUZZING_ENGINE.

Oct 12 2017, 11:15 AM
morehouse created D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags..
Oct 12 2017, 10:38 AM

Oct 11 2017

morehouse committed rL315506: [clang-fuzzer] Build with newer protobuf-mutator..
[clang-fuzzer] Build with newer protobuf-mutator.
Oct 11 2017, 1:45 PM
morehouse committed rL315486: [clang-fuzzer] Allow linking with any fuzzing engine..
[clang-fuzzer] Allow linking with any fuzzing engine.
Oct 11 2017, 11:29 AM
morehouse closed D38812: [clang-fuzzer] Allow linking with any fuzzing engine. by committing rL315486: [clang-fuzzer] Allow linking with any fuzzing engine..
Oct 11 2017, 11:29 AM
morehouse created D38812: [clang-fuzzer] Allow linking with any fuzzing engine..
Oct 11 2017, 11:21 AM
morehouse committed rL315465: Reland "[clang-fuzzer] Allow building without coverage instrumentation.".
Reland "[clang-fuzzer] Allow building without coverage instrumentation."
Oct 11 2017, 8:51 AM
morehouse committed rL315463: [clang-fuzzer] Fix shared library dependencies..
[clang-fuzzer] Fix shared library dependencies.
Oct 11 2017, 8:14 AM

Oct 10 2017

morehouse committed rL315355: Revert "[clang-fuzzer] Allow building without coverage instrumentation.".
Revert "[clang-fuzzer] Allow building without coverage instrumentation."
Oct 10 2017, 1:13 PM
morehouse committed rL315339: [clang-fuzzer] Build proto-to-cxx with fuzzer-no-link..
[clang-fuzzer] Build proto-to-cxx with fuzzer-no-link.
Oct 10 2017, 10:59 AM
morehouse committed rL315336: [clang-fuzzer] Allow building without coverage instrumentation..
[clang-fuzzer] Allow building without coverage instrumentation.
Oct 10 2017, 10:42 AM
morehouse closed D38642: [clang-fuzzer] Allow building without coverage instrumentation. by committing rL315336: [clang-fuzzer] Allow building without coverage instrumentation..
Oct 10 2017, 10:41 AM
morehouse updated the summary of D38642: [clang-fuzzer] Allow building without coverage instrumentation..
Oct 10 2017, 10:40 AM

Oct 6 2017

morehouse added a comment to D38642: [clang-fuzzer] Allow building without coverage instrumentation..
In D38642#891074, @kcc wrote:

If you can *easily* share main() with the one in LLVM -- do it, otherwise don't bother.

Oct 6 2017, 3:35 PM
morehouse updated the diff for D38642: [clang-fuzzer] Allow building without coverage instrumentation..
  • Revert "Remove dummy main and link with -fsantize=fuzzer."
Oct 6 2017, 3:32 PM
morehouse updated the summary of D38642: [clang-fuzzer] Allow building without coverage instrumentation..
Oct 6 2017, 2:55 PM
morehouse updated the diff for D38642: [clang-fuzzer] Allow building without coverage instrumentation..
  • Remove dummy main and link with -fsantize=fuzzer.
Oct 6 2017, 2:47 PM
morehouse added a comment to D38642: [clang-fuzzer] Allow building without coverage instrumentation..
In D38642#890969, @kcc wrote:

I'd like to know more.
At least simple cases work fine:

You're right. I was trying to add -fsanitize=fuzzer to CMAKE_CXX_FLAGS right before the link command, which was causing a later compilation to give the error. Setting CMAKE_EXE_LINKER_FLAGS seems to work though.

Oct 6 2017, 1:48 PM
morehouse added a comment to D38642: [clang-fuzzer] Allow building without coverage instrumentation..
In D38642#890963, @kcc wrote:

It's not about coverage instrumentation (not) being present, but about libFuzzer's main() being present, right?

Yes.

Will we be able to reuse some of Justin's code instead of creating one more main() function?

This reuses the code that Justin moved to FuzzMutate/FuzzerCLI. That's why the main is so short. But perhaps we could move the main itself into FuzzerCLI?

Or, why not link with libFuzzer (-fsanitize=fuzzer at link time) even if we don't us einstrumentation at compile time?

When I tried this, I got undefined references to all kinds of __sanitizer_cov_* symbols.

Oct 6 2017, 1:22 PM