LGTM

• Make __local_hwasan_preinit static.
• Use HelperStaticRuntimes.

LGTM

• In shared library mode, link preinit stub with every DSO.

In D118171#3288089, @eugenis wrote:

This change does not handle the -shared-libsan case, and does not have any effect on Android other than in static executables. It also makes the comment in hwasan_preinit.cpp incorrect - that code is NOT linked into the main executable. I think we should replicate the "asan-preinit" driver logic for hwasan.

Note that ASan does not link the static preinit bit on Android. I believe that's a bug in the initial implementation of -shared-libsan - the code comment says "Do not link static runtime to DSOs or if compiling for Android", but that is clearly meant to refer to the full runtime library (because Android historically used shared runtime only) and not the preinit stub. See https://reviews.llvm.org/D3043.

• Use a single isa<Type0, Type1>.

This commit is causing an MSan failure on the buildbots: https://lab.llvm.org/buildbot/#/builders/5/builds/18051/steps/10/logs/stdio

LGTM

LGTM

LGTM

LGTM

LGTM

LGTM

LGTM

LGTM

LGTM

TSan tests on the buildbot are timing out after this change and https://reviews.llvm.org/D114532. Not sure if there's a deadlock or if it just slowed things down too much.

LGTM

LGTM

I understand the ULEB128 for compression. What will we need SLEB128 for?

LGTM

Ping. Parent patch landed last week.

LGTM

LGTM

• Add @GOTPCREL_NORELAX as an assembly extension.

In D113220#3122771, @pcc wrote:

I think it ought to be possible to write these non-relaxable relocations from assembly, so that the behavior with -c is equivalent to the behavior with -S and then assembling the output. For example, you should be able to assemble

mov foo@gotpcrel_norelax(%rip), %rax

and the -S output from the compiler should look like that as well.

Thanks DK

LGTM

• Reintroduce random_state_inited_ flag

• Fix potential issue on random_state_ overflow.

• Remove random_state_inited_.
• Make unique_id atomic.
• Move initialization check to cold path.

• Fix FileCheck args.

In D113045#3107175, @vitalybuka wrote:

Seems like it's workaround for case protected by CHECK(random_buffer_), why not just remove the CHECK?
another case which this CHECK helps against a bug in xorshift which must not return zero for non-zero input. I don't think this check is important but it can be handled like:

static u32 xorshift(u32 state) {
  u32 old_state = state;
  state ^= state << 13;
  state ^= state >> 17;
  state ^= state << 5;
  CHECK(!old_state || state);
  return state;
}

• Use lazy init instead.