Page MenuHomePhabricator

morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (89 w, 5 d)

Recent Activity

Yesterday

morehouse added inline comments to D59262: [scudo][standalone] Add string utility functions.
Mon, Mar 18, 12:48 PM · Restricted Project, Restricted Project
morehouse added inline comments to D59262: [scudo][standalone] Add string utility functions.
Mon, Mar 18, 12:47 PM · Restricted Project, Restricted Project
morehouse accepted D59262: [scudo][standalone] Add string utility functions.

Still want to know if we need append with a va_list.

Mon, Mar 18, 12:15 PM · Restricted Project, Restricted Project

Thu, Mar 14

morehouse added inline comments to D59262: [scudo][standalone] Add string utility functions.
Thu, Mar 14, 10:12 AM · Restricted Project, Restricted Project

Tue, Mar 12

morehouse accepted D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.

LGTM

Tue, Mar 12, 11:21 AM · Restricted Project

Fri, Mar 8

morehouse accepted D59116: [scudo][standalone] Implement checksumming functions.

LGTM

Fri, Mar 8, 12:39 PM · Restricted Project, Restricted Project
morehouse added inline comments to D59116: [scudo][standalone] Implement checksumming functions.
Fri, Mar 8, 11:52 AM · Restricted Project, Restricted Project

Wed, Mar 6

morehouse accepted D59031: [scudo][standalone] Adding a stats class.
Wed, Mar 6, 4:33 PM · Restricted Project, Restricted Project

Tue, Mar 5

morehouse added inline comments to D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.
Tue, Mar 5, 2:35 PM · Restricted Project

Mon, Mar 4

morehouse accepted D58723: [scudo][standalone] Add bytemap classes.
Mon, Mar 4, 1:34 PM · Restricted Project, Restricted Project

Fri, Mar 1

morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Fri, Mar 1, 10:02 AM · Restricted Project, Restricted Project
morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Fri, Mar 1, 9:46 AM · Restricted Project, Restricted Project
morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Fri, Mar 1, 9:43 AM · Restricted Project, Restricted Project

Thu, Feb 28

morehouse accepted D58740: [sancov] Instrument reachable blocks that end in unreachable.

LGTM

Thu, Feb 28, 9:51 AM · Restricted Project

Wed, Feb 27

morehouse added inline comments to D58723: [scudo][standalone] Add bytemap classes.
Wed, Feb 27, 11:22 AM · Restricted Project, Restricted Project
morehouse added a comment to D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.

A block can end in unreachable, but still have reachable code at the beginning. If the block calls a function that is known not to return, the next instruction after the call will be UnreachableInst. For example https://godbolt.org/z/6AGtOf

Wed, Feb 27, 10:27 AM · Restricted Project
morehouse added a comment to D57982: [SanitizierCoverage] Avoid splitting critical edges when destination is a basic block containing unreachable.

I don't know all the details of when we might have an UnreachableInst, but I think in general instrumenting blocks that end in unreachable is unhelpful for fuzzing, since we are about to crash anyway (and will therefore be saving the current input whether we "count" the new coverage or not).

Wed, Feb 27, 9:58 AM · Restricted Project

Tue, Feb 26

morehouse accepted D58674: [libFuzzer] Remove extra semicolons.

LGTM, thanks!

Tue, Feb 26, 9:33 AM · Restricted Project, Restricted Project

Mon, Feb 25

morehouse accepted D58184: [scudo][standalone] Introduce platform specific code & mutexes.

Linux-specific and common code LGTM. Will let Fuschia people comment on that part.

Mon, Feb 25, 10:44 AM · Restricted Project, Restricted Project

Thu, Feb 21

morehouse added a reviewer for D58413: [sanitizers] Restore internal_readlink for x32: rnk.

@rnk: Could you help out here? I am clueless with Windows.

Thu, Feb 21, 9:49 AM · Restricted Project, Restricted Project
morehouse added inline comments to D58413: [sanitizers] Restore internal_readlink for x32.
Thu, Feb 21, 9:08 AM · Restricted Project, Restricted Project
morehouse committed rG9b900dc7deb2: Revert "[sanitizers] Restore internal_readlink for x32" (authored by morehouse).
Revert "[sanitizers] Restore internal_readlink for x32"
Thu, Feb 21, 9:07 AM
morehouse committed rCRT354601: Revert "[sanitizers] Restore internal_readlink for x32".
Revert "[sanitizers] Restore internal_readlink for x32"
Thu, Feb 21, 9:06 AM
morehouse committed rL354601: Revert "[sanitizers] Restore internal_readlink for x32".
Revert "[sanitizers] Restore internal_readlink for x32"
Thu, Feb 21, 9:06 AM

Wed, Feb 20

morehouse added inline comments to D58413: [sanitizers] Restore internal_readlink for x32.
Wed, Feb 20, 1:51 PM · Restricted Project, Restricted Project

Tue, Feb 19

morehouse added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Tue, Feb 19, 1:01 PM · Restricted Project, Restricted Project

Feb 15 2019

morehouse added inline comments to D58184: [scudo][standalone] Introduce platform specific code & mutexes.
Feb 15 2019, 4:33 PM · Restricted Project, Restricted Project

Feb 4 2019

morehouse accepted D57633: [SanitizerCoverage] Clang crashes if user declares `__sancov_lowest_stack` variable.

LGTM

Feb 4 2019, 9:03 AM · Restricted Project, Restricted Project

Feb 1 2019

morehouse accepted D57563: [libFuzzer][Windows] Reenable passing tests.

LGTM

Feb 1 2019, 9:46 AM · Restricted Project
morehouse accepted D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..

LGTM

Feb 1 2019, 9:04 AM · Restricted Project

Jan 31 2019

morehouse accepted D57551: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win.

LGTM

Jan 31 2019, 3:20 PM · Restricted Project, Restricted Project
morehouse accepted D57412: [scudo] Initial standalone skeleton check-in.
Jan 31 2019, 2:55 PM · Restricted Project, Restricted Project
morehouse added inline comments to D57412: [scudo] Initial standalone skeleton check-in.
Jan 31 2019, 2:08 PM · Restricted Project, Restricted Project
morehouse added inline comments to D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections..
Jan 31 2019, 10:29 AM · Restricted Project

Jan 28 2019

morehouse accepted D57305: [libFuzzer][Windows] Use dllexport for all declarations in FuzzerInterface.h.

LGTM

Jan 28 2019, 9:48 AM
morehouse accepted D57308: [fuzzer][afl] Remove AFL_DRIVER_EXTRA_STATS_FILENAME.

LGTM

Jan 28 2019, 9:10 AM
morehouse added a comment to D57308: [fuzzer][afl] Remove AFL_DRIVER_EXTRA_STATS_FILENAME.

What was the original motivation for adding the extra stats? Is it really unused now?

Jan 28 2019, 8:58 AM
morehouse added inline comments to D57305: [libFuzzer][Windows] Use dllexport for all declarations in FuzzerInterface.h.
Jan 28 2019, 8:50 AM

Jan 23 2019

morehouse accepted D57119: [libFuzzer][MSVC] Disable exceptions in MSVC headers.

libFuzzer doesn't disable exceptions itself, but the private libc++ it builds has exceptions disabled. So this should be fine for MSVC STL.

Jan 23 2019, 3:51 PM

Jan 18 2019

morehouse added a comment to D56866: [libFuzzer][MSVC] Make Sanitizer Coverage MSVC-compatible.

Code looks fine to me, but I don't have enough Windows knowledge to to evaluate the approach. I'll let @rnk comment on that.

Jan 18 2019, 9:56 AM

Jan 15 2019

morehouse committed rL351247: [SanitizerCoverage] Don't create comdat for interposable functions..
[SanitizerCoverage] Don't create comdat for interposable functions.
Jan 15 2019, 1:25 PM
morehouse closed D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
Jan 15 2019, 1:24 PM
morehouse retitled D56516: [SanitizerCoverage] Don't create comdat for interposable functions. from [SanitizerCoverage] Don't create comdat for weak functions. to [SanitizerCoverage] Don't create comdat for interposable functions..
Jan 15 2019, 1:23 PM
morehouse updated the diff for D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
  • Run test for both ELF and COFF.
Jan 15 2019, 1:20 PM
morehouse added a comment to D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
In D56516#1358281, @rnk wrote:

However, it looks like this code still creates sancov metadata for such a weak function, even though it might not be linked in. Is that a problem? Will it create relocations to discarded data? Is the !associated metadata enough to make it get discarded when the strong user symbol overrides the weak one?

Jan 15 2019, 1:08 PM
morehouse updated the diff for D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
  • Apply change to all interposable linkages.
Jan 15 2019, 1:08 PM
morehouse accepted D56730: [libFuzzer] Remove unstable edge handling.

LGTM

Jan 15 2019, 11:09 AM

Jan 14 2019

morehouse accepted D56514: [libFuzzer][MSVC] Use alternatename for ext functions.

LGTM

Jan 14 2019, 6:22 PM
morehouse added inline comments to D56514: [libFuzzer][MSVC] Use alternatename for ext functions.
Jan 14 2019, 2:58 PM
morehouse accepted D54590: [compiler-rt][UBSan] Sanitization for alignment assumptions..
Jan 14 2019, 9:51 AM · Restricted Project, Restricted Project

Jan 11 2019

morehouse committed rCRT350935: XFAIL getusershell.cc on Android..
XFAIL getusershell.cc on Android.
Jan 11 2019, 9:30 AM
morehouse committed rL350935: XFAIL getusershell.cc on Android..
XFAIL getusershell.cc on Android.
Jan 11 2019, 9:29 AM

Jan 10 2019

morehouse added inline comments to D56514: [libFuzzer][MSVC] Use alternatename for ext functions.
Jan 10 2019, 1:58 PM
morehouse added a reviewer for D56516: [SanitizerCoverage] Don't create comdat for interposable functions.: rnk.
  • For ELF targets, this fix is functionally correct, but it will have the effect of retaining the section content for the weak symbols in the output, potentially slowing the link and making the output larger (unless you use -gc-sections).
Jan 10 2019, 1:54 PM
morehouse added inline comments to D56514: [libFuzzer][MSVC] Use alternatename for ext functions.
Jan 10 2019, 1:12 PM
morehouse added a comment to D56516: [SanitizerCoverage] Don't create comdat for interposable functions..

@bd1976llvm: So do you still think this is a compiler bug? It sounds like ELF provides no guarantees about which COMDAT is kept. Which would mean we need to keep the weak symbols from going in a COMDAT.

Jan 10 2019, 12:44 PM
morehouse updated the diff for D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
  • Add test.
Jan 10 2019, 9:20 AM
morehouse added a comment to D56516: [SanitizerCoverage] Don't create comdat for interposable functions..

I wonder if it is the same problem as here: https://reviews.llvm.org/D53234 which is a case of the global referenced via !associated is being dropped.

Jan 10 2019, 8:56 AM

Jan 9 2019

morehouse updated the summary of D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
Jan 9 2019, 3:54 PM
morehouse added a comment to D56516: [SanitizerCoverage] Don't create comdat for interposable functions..

Minimal repro:

Jan 9 2019, 3:45 PM
morehouse created D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
Jan 9 2019, 3:08 PM

Jan 7 2019

morehouse committed rL350534: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..
[llvm-demangle-fuzzer] Also fuzz microsoftDemangle().
Jan 7 2019, 8:17 AM
morehouse closed D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..
Jan 7 2019, 8:17 AM

Jan 4 2019

morehouse updated the diff for D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..
  • Separate fuzz targets.
Jan 4 2019, 4:42 PM

Nov 30 2018

morehouse added a comment to D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..

@kcc Ping

Nov 30 2018, 10:55 AM

Nov 28 2018

morehouse committed rCRT347779: [gcov] Disable instrprof-gcov-fork.test..
[gcov] Disable instrprof-gcov-fork.test.
Nov 28 2018, 9:29 AM
morehouse committed rL347779: [gcov] Disable instrprof-gcov-fork.test..
[gcov] Disable instrprof-gcov-fork.test.
Nov 28 2018, 9:27 AM

Nov 21 2018

morehouse accepted D54805: [Driver] Use --push/pop-state with Sanitizer link deps.

LGTM

Nov 21 2018, 11:39 AM

Nov 20 2018

morehouse added a comment to D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..

microsoftDemangle crashes in 1 second with buffer overflows or ASSERT failures when I run locally.

Nov 20 2018, 7:01 PM
morehouse updated the diff for D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..
  • Formatting.
Nov 20 2018, 6:57 PM
morehouse created D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..
Nov 20 2018, 6:54 PM

Nov 7 2018

morehouse accepted D54232: [sancov] Put .SCOV* sections into the right comdat groups on COFF.

LGTM

Nov 7 2018, 4:42 PM
morehouse added inline comments to D54232: [sancov] Put .SCOV* sections into the right comdat groups on COFF.
Nov 7 2018, 4:06 PM
morehouse accepted D54198: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.

LGTM

Nov 7 2018, 9:26 AM

Nov 6 2018

morehouse accepted D54180: [fuzzer] Read files as binary.

LGTM

Nov 6 2018, 3:25 PM
morehouse added a comment to D54180: [fuzzer] Read files as binary.

Is there a test for this that fails on Windows?

Nov 6 2018, 1:56 PM
morehouse accepted D54165: [sanitizer] Add char **GetEnviron() on all other platforms.

LGTM

Nov 6 2018, 11:22 AM

Nov 2 2018

morehouse accepted D54058: [compiler-rt][Fuzzer] Fix the fuzzer test build.

LGTM

Nov 2 2018, 4:30 PM

Nov 1 2018

morehouse accepted D54004: [libFuzzer] Disable value-profile-cmp.test and fuzzer-oom.test on ARM64.

LGTM

Nov 1 2018, 3:23 PM

Oct 31 2018

morehouse accepted D53862: [compiler-rt] Pass CMake C and C++ flags to the custom libc++.

LGTM

Oct 31 2018, 12:28 PM

Oct 17 2018

morehouse added inline comments to D53227: [hwasan] add stack frame descriptions..
Oct 17 2018, 10:32 AM

Oct 16 2018

morehouse accepted D53211: [SanitizerCoverage] Don't duplicate code to get section pointers.

LGTM

Oct 16 2018, 2:44 PM

Oct 12 2018

morehouse accepted D53225: [libfuzzer][Windows] Silence linker warning in unittest.
Oct 12 2018, 4:24 PM
morehouse accepted D53218: move GetOrCreateFunctionComdat to Instrumentation.cpp/Instrumentation.h.
Oct 12 2018, 4:21 PM

Oct 10 2018

morehouse accepted D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Oct 10 2018, 3:52 PM
morehouse accepted D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Oct 10 2018, 3:47 PM

Oct 9 2018

morehouse accepted D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.
Oct 9 2018, 5:47 PM · Restricted Project
morehouse added inline comments to D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.
Oct 9 2018, 5:24 PM · Restricted Project
morehouse accepted D53039: [sancov] Generalize the code to get the previous instruction to multiple architectures.

LGTM

Oct 9 2018, 5:21 PM
morehouse accepted D53047: [libFuzzer] Disable value profiling tests on ARM.
Oct 9 2018, 5:18 PM
morehouse added a comment to D53047: [libFuzzer] Disable value profiling tests on ARM.

I've seen the flakiness on buildbots, but haven't been able to reproduce on our aarch64 machine.

Oct 9 2018, 5:18 PM

Oct 3 2018

morehouse committed rLLD343749: Use std::make_pair rather than brace initialization..
Use std::make_pair rather than brace initialization.
Oct 3 2018, 5:37 PM
morehouse committed rL343749: Use std::make_pair rather than brace initialization..
Use std::make_pair rather than brace initialization.
Oct 3 2018, 5:37 PM

Oct 2 2018

morehouse committed rL343616: Revert "X86, AArch64, ARM: Do not attach debug location to spill/reload….
Revert "X86, AArch64, ARM: Do not attach debug location to spill/reload…
Oct 2 2018, 11:38 AM
morehouse added a comment to D52125: X86, AArch64, ARM: Do not attach debug location to spill/reload instructions.

This change is breaking some symbolization tests on the Android bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/15630

Oct 2 2018, 11:06 AM

Sep 19 2018

morehouse committed rL342582: [InstCombine] Disable strcmp->memcmp transform for MSan..
[InstCombine] Disable strcmp->memcmp transform for MSan.
Sep 19 2018, 12:39 PM
morehouse closed D52272: [InstCombine] Disable strcmp->memcmp transform for MSan..
Sep 19 2018, 12:38 PM
morehouse created D52272: [InstCombine] Disable strcmp->memcmp transform for MSan..
Sep 19 2018, 12:00 PM

Sep 17 2018

morehouse committed rCRT342423: [libFuzzer] Avoid fuzzer symbols being hidden..
[libFuzzer] Avoid fuzzer symbols being hidden.
Sep 17 2018, 4:12 PM
morehouse committed rL342423: [libFuzzer] Avoid fuzzer symbols being hidden..
[libFuzzer] Avoid fuzzer symbols being hidden.
Sep 17 2018, 4:09 PM