morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (55 w, 1 d)

Recent Activity

Today

morehouse added inline comments to D49526: Updated llvm-proto-fuzzer to execute the compiled code.
Thu, Jul 19, 3:20 PM
morehouse committed rL337476: [libFuzzer] Update documentation regarding MSan..
[libFuzzer] Update documentation regarding MSan.
Thu, Jul 19, 11:04 AM
morehouse closed D49441: [libFuzzer] Update documentation regarding MSan..
Thu, Jul 19, 11:04 AM
morehouse accepted D49249: [libFuzzer] Use separate test directory for each config.

Please watch the bots after landing this.

Thu, Jul 19, 11:03 AM
morehouse updated the diff for D49441: [libFuzzer] Update documentation regarding MSan..
  • Support MSan experimentally.
Thu, Jul 19, 10:04 AM
morehouse added a comment to D49441: [libFuzzer] Update documentation regarding MSan..

Benchmarks easy to discern the crash cause:

Thu, Jul 19, 9:57 AM
morehouse added a comment to D49526: Updated llvm-proto-fuzzer to execute the compiled code.

You can probably get rid of the llvm-objcopy code and make this a lot simpler with something like:

Thu, Jul 19, 9:02 AM

Yesterday

morehouse accepted D49453: [libFuzzer] Create single template for visiting Inline8bitCounters.
Wed, Jul 18, 9:27 AM
morehouse added inline comments to D49453: [libFuzzer] Create single template for visiting Inline8bitCounters.
Wed, Jul 18, 9:15 AM

Tue, Jul 17

morehouse added inline comments to D49453: [libFuzzer] Create single template for visiting Inline8bitCounters.
Tue, Jul 17, 4:33 PM
morehouse added a comment to D49453: [libFuzzer] Create single template for visiting Inline8bitCounters.

Maybe change the callback signature to take i, j, and UnstableIdx instead. Then we can also use IterateInline8bitCounters from UpdateObservedPCs.

Tue, Jul 17, 3:50 PM
morehouse added a comment to D48054: [libFuzzer] Mutation tracking and logging implemented..

I think it's fine to land. Kostya approved the previous version, and he probably won't mind the extra 0's in the initialization lists.

Tue, Jul 17, 1:30 PM
morehouse added a comment to D49441: [libFuzzer] Update documentation regarding MSan..

Ran fuzzer-test-suite's test-everything.sh with -fsanitize=memory,fuzzer and all MSan reports came from the fuzz target, not libFuzzer. I think it's time to document the new capability.

Tue, Jul 17, 11:51 AM
morehouse created D49441: [libFuzzer] Update documentation regarding MSan..
Tue, Jul 17, 11:47 AM
morehouse accepted D48054: [libFuzzer] Mutation tracking and logging implemented..
Tue, Jul 17, 10:44 AM
morehouse committed rCRT337296: libFuzzer: prevent irrelevant strings from leaking into auto-dictionary.
libFuzzer: prevent irrelevant strings from leaking into auto-dictionary
Tue, Jul 17, 9:18 AM
morehouse committed rL337296: libFuzzer: prevent irrelevant strings from leaking into auto-dictionary.
libFuzzer: prevent irrelevant strings from leaking into auto-dictionary
Tue, Jul 17, 9:17 AM
morehouse closed D48800: libFuzzer: prevent irrelevant strings from leaking into auto-dictionary.
Tue, Jul 17, 9:17 AM

Mon, Jul 16

morehouse added a comment to D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..

Try again after syncing past r337224. Hopefully that fixes your issue.

Mon, Jul 16, 4:30 PM
morehouse committed rCRT337224: [libFuzzer] Avoid STL in MSan test..
[libFuzzer] Avoid STL in MSan test.
Mon, Jul 16, 4:28 PM
morehouse committed rL337224: [libFuzzer] Avoid STL in MSan test..
[libFuzzer] Avoid STL in MSan test.
Mon, Jul 16, 4:28 PM
morehouse closed D49404: [libFuzzer] Avoid STL in MSan test..
Mon, Jul 16, 4:28 PM
morehouse retitled D49404: [libFuzzer] Avoid STL in MSan test. from [libFuzzer] Avoid std::cout in SimpleTest. to [libFuzzer] Avoid STL in MSan test..
Mon, Jul 16, 4:03 PM
morehouse updated the diff for D49404: [libFuzzer] Avoid STL in MSan test..
  • Revert "[libFuzzer] Avoid std::cout in SimpleTest."
  • Create SimpleTestStdio.cpp without STL.
Mon, Jul 16, 4:02 PM
morehouse created D49404: [libFuzzer] Avoid STL in MSan test..
Mon, Jul 16, 3:43 PM
morehouse added a comment to D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..

After more thinking, the private libc++ probably isn't the issue here since only libFuzzer itself gets linked with that. The fuzz target is linked with whatever C++ standard library your system is configured to use.

Mon, Jul 16, 11:27 AM
morehouse added a comment to D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..

Make sure you have the libcxx sources checked out (I think under llvm/projects). I think that should fix it.

Mon, Jul 16, 10:55 AM
morehouse committed rCRT337193: [libFuzzer] Add msan and dfsan to test deps..
[libFuzzer] Add msan and dfsan to test deps.
Mon, Jul 16, 10:42 AM
morehouse committed rL337193: [libFuzzer] Add msan and dfsan to test deps..
[libFuzzer] Add msan and dfsan to test deps.
Mon, Jul 16, 10:42 AM
morehouse added a comment to D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..

Hmm... Seems to be crashing in std::cout <<, but nothing there should be uninitialized. Also the bots are all green.

Mon, Jul 16, 9:42 AM
morehouse accepted D49346: [CMake] Use cxx-headers as a depedency for C++ headers.
Mon, Jul 16, 9:31 AM
morehouse accepted D48800: libFuzzer: prevent irrelevant strings from leaking into auto-dictionary.

LGTM

Mon, Jul 16, 9:27 AM
morehouse accepted D49332: [CMake] Check -ffreestanding as C not C++ flag.
Mon, Jul 16, 9:17 AM

Fri, Jul 13

morehouse accepted D48054: [libFuzzer] Mutation tracking and logging implemented..

LGTM

Fri, Jul 13, 6:00 PM
morehouse accepted D49212: [libFuzzer] Implement stat::stability_rate based on the percentage of unstable edges..
Fri, Jul 13, 5:38 PM
morehouse accepted D49325: [CMake] Change the flag to use compiler-rt builtins to boolean.
Fri, Jul 13, 4:24 PM
morehouse added inline comments to D49212: [libFuzzer] Implement stat::stability_rate based on the percentage of unstable edges..
Fri, Jul 13, 4:08 PM
morehouse accepted D49324: [UBSan] Followup for silence_unsigned_overflow flag to handle negate overflows..

Nice catch!

Fri, Jul 13, 3:27 PM
morehouse added a comment to D48660: [UBSan] Add silence_unsigned_overflow flag..

Why not use the suppressions mechanism which is already there?

Fri, Jul 13, 2:16 PM
morehouse added a comment to D49249: [libFuzzer] Use separate test directory for each config.

The other test configs don't define config.test_exec_root at all. Do we need it?

Fri, Jul 13, 9:13 AM
morehouse accepted D49272: [CMake] Don't use CLANG_DEFAULT_* values.
Fri, Jul 13, 8:35 AM

Thu, Jul 12

morehouse committed rL336941: [SanitizerCoverage] Add associated metadata to 8-bit counters..
[SanitizerCoverage] Add associated metadata to 8-bit counters.
Thu, Jul 12, 1:30 PM
morehouse committed rCRT336941: [SanitizerCoverage] Add associated metadata to 8-bit counters..
[SanitizerCoverage] Add associated metadata to 8-bit counters.
Thu, Jul 12, 1:30 PM
morehouse closed D49264: [SanitizerCoverage] Add associated metadata to 8-bit counters..
Thu, Jul 12, 1:29 PM
morehouse created D49264: [SanitizerCoverage] Add associated metadata to 8-bit counters..
Thu, Jul 12, 12:31 PM
morehouse committed rL336932: [libFuzzer] If LLD available, require it to build first..
[libFuzzer] If LLD available, require it to build first.
Thu, Jul 12, 11:57 AM
morehouse committed rCRT336932: [libFuzzer] If LLD available, require it to build first..
[libFuzzer] If LLD available, require it to build first.
Thu, Jul 12, 11:57 AM
morehouse committed rCRT336926: [libFuzzer] Use lld-available for gc-sections.test..
[libFuzzer] Use lld-available for gc-sections.test.
Thu, Jul 12, 11:14 AM
morehouse committed rL336926: [libFuzzer] Use lld-available for gc-sections.test..
[libFuzzer] Use lld-available for gc-sections.test.
Thu, Jul 12, 11:14 AM

Wed, Jul 11

morehouse added inline comments to D48054: [libFuzzer] Mutation tracking and logging implemented..
Wed, Jul 11, 2:09 PM

Tue, Jul 10

morehouse committed rCRT336725: [libFuzzer] Disable dataflow.test on AArch64..
[libFuzzer] Disable dataflow.test on AArch64.
Tue, Jul 10, 1:50 PM
morehouse committed rL336725: [libFuzzer] Disable dataflow.test on AArch64..
[libFuzzer] Disable dataflow.test on AArch64.
Tue, Jul 10, 1:50 PM
morehouse closed D49150: [libFuzzer] Disable dataflow.test on AArch64..
Tue, Jul 10, 1:50 PM
morehouse committed rCRT336719: Revert "[Fuzzer] Afl driver changing iterations handling".
Revert "[Fuzzer] Afl driver changing iterations handling"
Tue, Jul 10, 1:03 PM
morehouse added a reverting commit for rL334510: [Fuzzer] Afl driver changing iterations handling: rL336719: Revert "[Fuzzer] Afl driver changing iterations handling".
Tue, Jul 10, 1:03 PM
morehouse committed rL336719: Revert "[Fuzzer] Afl driver changing iterations handling".
Revert "[Fuzzer] Afl driver changing iterations handling"
Tue, Jul 10, 1:03 PM
morehouse closed D49141: Revert "[Fuzzer] Afl driver changing iterations handling".
Tue, Jul 10, 1:03 PM
morehouse accepted D49141: Revert "[Fuzzer] Afl driver changing iterations handling".
Tue, Jul 10, 12:59 PM
morehouse added a comment to D49150: [libFuzzer] Disable dataflow.test on AArch64..

Note that I can reproduce this locally by compiling with -O0.

Tue, Jul 10, 12:58 PM
morehouse added a comment to D49150: [libFuzzer] Disable dataflow.test on AArch64..

@kcc: Do we want to just disable this test for AArch64, or should we change SetBytesForLabel to not be recursive?

Tue, Jul 10, 12:51 PM
morehouse created D49150: [libFuzzer] Disable dataflow.test on AArch64..
Tue, Jul 10, 12:49 PM
morehouse added a comment to D48054: [libFuzzer] Mutation tracking and logging implemented..

@morehouse I have been looking over the code and I cannot seem to find a reason why that single test is failing. PTAL.

Tue, Jul 10, 8:46 AM

Mon, Jul 9

morehouse committed rL336619: [libFuzzer] Make -fsanitize=memory,fuzzer work..
[libFuzzer] Make -fsanitize=memory,fuzzer work.
Mon, Jul 9, 4:56 PM
morehouse committed rCRT336619: [libFuzzer] Make -fsanitize=memory,fuzzer work..
[libFuzzer] Make -fsanitize=memory,fuzzer work.
Mon, Jul 9, 4:56 PM
morehouse closed D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
Mon, Jul 9, 4:56 PM
morehouse updated the diff for D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
  • Correct diffbase.
Mon, Jul 9, 4:50 PM
morehouse updated the diff for D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
  • Update test headers.
Mon, Jul 9, 4:48 PM
morehouse reopened D48054: [libFuzzer] Mutation tracking and logging implemented..

Reverted due to bot breakage in r336616.

Mon, Jul 9, 3:38 PM
morehouse committed rCRT336616: Revert "[libFuzzer] Mutation tracking and logging implemented".
Revert "[libFuzzer] Mutation tracking and logging implemented"
Mon, Jul 9, 3:36 PM
morehouse committed rL336616: Revert "[libFuzzer] Mutation tracking and logging implemented".
Revert "[libFuzzer] Mutation tracking and logging implemented"
Mon, Jul 9, 3:36 PM
morehouse closed D48054: [libFuzzer] Mutation tracking and logging implemented..

Landed in r336597.

Mon, Jul 9, 1:26 PM
morehouse committed rL336597: [libFuzzer] Mutation tracking and logging implemented.
[libFuzzer] Mutation tracking and logging implemented
Mon, Jul 9, 1:22 PM
morehouse committed rCRT336597: [libFuzzer] Mutation tracking and logging implemented.
[libFuzzer] Mutation tracking and logging implemented
Mon, Jul 9, 1:22 PM

Fri, Jul 6

morehouse committed rCRT336447: [MSan] Add functions to enable/disable interceptor checks..
[MSan] Add functions to enable/disable interceptor checks.
Fri, Jul 6, 10:16 AM
morehouse committed rL336447: [MSan] Add functions to enable/disable interceptor checks..
[MSan] Add functions to enable/disable interceptor checks.
Fri, Jul 6, 10:16 AM
morehouse closed D48890: [MSan] Add functions to enable/disable interceptor checks..
Fri, Jul 6, 10:15 AM
morehouse accepted D49011: [libFuzzer] Disable hanging tests on AArch64.

LGTM

Fri, Jul 6, 9:02 AM

Tue, Jul 3

morehouse updated the diff for D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
  • Remove global from FuzzerDriver.cpp.
  • Remove unnecessary scope.
  • Unpoison DataCopy.
  • Add strlen test.
Tue, Jul 3, 6:00 PM
morehouse added inline comments to D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
Tue, Jul 3, 5:11 PM
morehouse updated the diff for D48890: [MSan] Add functions to enable/disable interceptor checks..
  • Repeat puts().
Tue, Jul 3, 4:14 PM
morehouse updated the diff for D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
  • Merge branch 'memfuzz' into memfuzz2
  • Sync with parent patch.
  • Added use-after-dtor test.
  • Disable/enable MSan interceptors via scoped class.
Tue, Jul 3, 4:08 PM
morehouse added inline comments to D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
Tue, Jul 3, 2:43 PM
morehouse updated the diff for D48890: [MSan] Add functions to enable/disable interceptor checks..
  • Add _scoped_ to function names.
  • Add test.
Tue, Jul 3, 2:37 PM
morehouse added a dependent revision for D48890: [MSan] Add functions to enable/disable interceptor checks.: D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
Tue, Jul 3, 12:29 PM
morehouse added a dependency for D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work.: D48890: [MSan] Add functions to enable/disable interceptor checks..
Tue, Jul 3, 12:29 PM
morehouse created D48891: [libFuzzer] Make -fsanitize=memory,fuzzer work..
Tue, Jul 3, 12:27 PM
morehouse updated subscribers of D48890: [MSan] Add functions to enable/disable interceptor checks..
Tue, Jul 3, 12:23 PM
morehouse created D48890: [MSan] Add functions to enable/disable interceptor checks..
Tue, Jul 3, 12:21 PM

Fri, Jun 29

morehouse added a comment to D48150: [libFuzzer] Create Unstable Edge Check.

"ERROR: Coverage points in binary and .sancov file do not match." is what I am getting which I am assuming I am sending the wrong PC. But then which PC should be sent?

Fri, Jun 29, 3:07 PM
morehouse added a comment to D48660: [UBSan] Add silence_unsigned_overflow flag..

Would not suppression kill the fuzzing signal as well?

Fri, Jun 29, 10:08 AM
morehouse added a comment to D48660: [UBSan] Add silence_unsigned_overflow flag..

@kcc, @Dor1s: Did we previously consider using suppressions to silence UIO for OSS-Fuzz?

Fri, Jun 29, 9:50 AM

Thu, Jun 28

morehouse added a comment to D48686: [libFuzzer] [Tests] [NFC] Change seed for reduce_inputs.test.

Does the bot config also explain the SIGUSR test flakiness?

Thu, Jun 28, 9:25 AM

Wed, Jun 27

morehouse added a comment to D48695: [libFuzzer] [NFC] [Tests] Drop -O2 from configuration.

I think arcanist was just acting up... Actual committed changes: https://reviews.llvm.org/rCRT328384

Wed, Jun 27, 6:27 PM
morehouse added a comment to D48695: [libFuzzer] [NFC] [Tests] Drop -O2 from configuration.

We want to keep -O2.

Wed, Jun 27, 6:26 PM
morehouse added a comment to D48686: [libFuzzer] [Tests] [NFC] Change seed for reduce_inputs.test.

Does that machine build libFuzzer differently? Maybe the version of libc++ it uses is different.

Wed, Jun 27, 5:34 PM
morehouse added a comment to D48684: [libFuzzer] [Tests] [NFC] Write output to files first before comparing with FileCheck.

This makes the test more complex. What is the reason for this change?

Wed, Jun 27, 5:23 PM
morehouse accepted D48686: [libFuzzer] [Tests] [NFC] Change seed for reduce_inputs.test.
Wed, Jun 27, 5:20 PM
morehouse committed rL335762: [UBSan] Add silence_unsigned_overflow flag..
[UBSan] Add silence_unsigned_overflow flag.
Wed, Jun 27, 11:30 AM
morehouse committed rC335762: [UBSan] Add silence_unsigned_overflow flag..
[UBSan] Add silence_unsigned_overflow flag.
Wed, Jun 27, 11:29 AM
morehouse committed rCRT335762: [UBSan] Add silence_unsigned_overflow flag..
[UBSan] Add silence_unsigned_overflow flag.
Wed, Jun 27, 11:29 AM