Page MenuHomePhabricator

morehouse (Matt Morehouse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2017, 4:27 PM (76 w, 19 h)

Recent Activity

Fri, Nov 30

morehouse added a comment to D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..

@kcc Ping

Fri, Nov 30, 10:55 AM

Wed, Nov 28

morehouse committed rCRT347779: [gcov] Disable instrprof-gcov-fork.test..
[gcov] Disable instrprof-gcov-fork.test.
Wed, Nov 28, 9:29 AM
morehouse committed rL347779: [gcov] Disable instrprof-gcov-fork.test..
[gcov] Disable instrprof-gcov-fork.test.
Wed, Nov 28, 9:27 AM

Wed, Nov 21

morehouse accepted D54805: [Driver] Use --push/pop-state with Sanitizer link deps.

LGTM

Wed, Nov 21, 11:39 AM

Tue, Nov 20

morehouse added a comment to D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..

microsoftDemangle crashes in 1 second with buffer overflows or ASSERT failures when I run locally.

Tue, Nov 20, 7:01 PM
morehouse updated the diff for D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..
  • Formatting.
Tue, Nov 20, 6:57 PM
morehouse created D54780: [llvm-demangle-fuzzer] Also fuzz microsoftDemangle()..
Tue, Nov 20, 6:54 PM

Nov 7 2018

morehouse accepted D54232: [sancov] Put .SCOV* sections into the right comdat groups on COFF.

LGTM

Nov 7 2018, 4:42 PM
morehouse added inline comments to D54232: [sancov] Put .SCOV* sections into the right comdat groups on COFF.
Nov 7 2018, 4:06 PM
morehouse accepted D54198: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.

LGTM

Nov 7 2018, 9:26 AM

Nov 6 2018

morehouse accepted D54180: [fuzzer] Read files as binary.

LGTM

Nov 6 2018, 3:25 PM
morehouse added a comment to D54180: [fuzzer] Read files as binary.

Is there a test for this that fails on Windows?

Nov 6 2018, 1:56 PM
morehouse accepted D54165: [sanitizer] Add char **GetEnviron() on all other platforms.

LGTM

Nov 6 2018, 11:22 AM

Nov 2 2018

morehouse accepted D54058: [compiler-rt][Fuzzer] Fix the fuzzer test build.

LGTM

Nov 2 2018, 4:30 PM

Nov 1 2018

morehouse accepted D54004: [libFuzzer] Disable value-profile-cmp.test and fuzzer-oom.test on ARM64.

LGTM

Nov 1 2018, 3:23 PM

Oct 31 2018

morehouse accepted D53862: [compiler-rt] Pass CMake C and C++ flags to the custom libc++.

LGTM

Oct 31 2018, 12:28 PM

Oct 17 2018

morehouse added inline comments to D53227: [hwasan] add stack frame descriptions..
Oct 17 2018, 10:32 AM

Oct 16 2018

morehouse accepted D53211: [SanitizerCoverage] Don't duplicate code to get section pointers.

LGTM

Oct 16 2018, 2:44 PM

Oct 12 2018

morehouse accepted D53225: [libfuzzer][Windows] Silence linker warning in unittest.
Oct 12 2018, 4:24 PM
morehouse accepted D53218: move GetOrCreateFunctionComdat to Instrumentation.cpp/Instrumentation.h.
Oct 12 2018, 4:21 PM

Oct 10 2018

morehouse accepted D53114: [libFuzzer] Add test for SanitizerCoverage working on Mac even with -Wl,-dead_strip..
Oct 10 2018, 3:52 PM
morehouse accepted D53113: [SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant..
Oct 10 2018, 3:47 PM

Oct 9 2018

morehouse accepted D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.
Oct 9 2018, 5:47 PM · Restricted Project
morehouse added inline comments to D53040: [libFuzzer] Generalize the code for getting the previous offset for different architectures.
Oct 9 2018, 5:24 PM · Restricted Project
morehouse accepted D53039: [sancov] Generalize the code to get the previous instruction to multiple architectures.

LGTM

Oct 9 2018, 5:21 PM
morehouse accepted D53047: [libFuzzer] Disable value profiling tests on ARM.
Oct 9 2018, 5:18 PM
morehouse added a comment to D53047: [libFuzzer] Disable value profiling tests on ARM.

I've seen the flakiness on buildbots, but haven't been able to reproduce on our aarch64 machine.

Oct 9 2018, 5:18 PM

Oct 3 2018

morehouse committed rLLD343749: Use std::make_pair rather than brace initialization..
Use std::make_pair rather than brace initialization.
Oct 3 2018, 5:37 PM
morehouse committed rL343749: Use std::make_pair rather than brace initialization..
Use std::make_pair rather than brace initialization.
Oct 3 2018, 5:37 PM

Oct 2 2018

morehouse committed rL343616: Revert "X86, AArch64, ARM: Do not attach debug location to spill/reload….
Revert "X86, AArch64, ARM: Do not attach debug location to spill/reload…
Oct 2 2018, 11:38 AM
morehouse added a comment to D52125: X86, AArch64, ARM: Do not attach debug location to spill/reload instructions.

This change is breaking some symbolization tests on the Android bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/15630

Oct 2 2018, 11:06 AM

Sep 19 2018

morehouse committed rL342582: [InstCombine] Disable strcmp->memcmp transform for MSan..
[InstCombine] Disable strcmp->memcmp transform for MSan.
Sep 19 2018, 12:39 PM
morehouse closed D52272: [InstCombine] Disable strcmp->memcmp transform for MSan..
Sep 19 2018, 12:38 PM
morehouse created D52272: [InstCombine] Disable strcmp->memcmp transform for MSan..
Sep 19 2018, 12:00 PM

Sep 17 2018

morehouse committed rCRT342423: [libFuzzer] Avoid fuzzer symbols being hidden..
[libFuzzer] Avoid fuzzer symbols being hidden.
Sep 17 2018, 4:12 PM
morehouse committed rL342423: [libFuzzer] Avoid fuzzer symbols being hidden..
[libFuzzer] Avoid fuzzer symbols being hidden.
Sep 17 2018, 4:09 PM
morehouse accepted D52119: [SanitizerCoverage] Prevent /OPT:REF from stripping constructors.

Change is fine with me since Linux behavior is unchanged. @rnk can comment on whether this is the best approach for Windows or not.

Sep 17 2018, 9:56 AM
morehouse accepted D51700: [fuzzer] Replace FuzzerExtFunctionsDlsymWin.cpp with FuzzerExtFunctionsWeakAlias.cpp.

LGTM

Sep 17 2018, 9:37 AM

Sep 14 2018

morehouse committed rCRT342255: [libFuzzer] Disable value-profile-strncmp.test on aarch64..
[libFuzzer] Disable value-profile-strncmp.test on aarch64.
Sep 14 2018, 11:25 AM
morehouse committed rL342255: [libFuzzer] Disable value-profile-strncmp.test on aarch64..
[libFuzzer] Disable value-profile-strncmp.test on aarch64.
Sep 14 2018, 11:25 AM

Sep 13 2018

morehouse committed rL342186: [SanitizerCoverage] Create comdat for global arrays..
[SanitizerCoverage] Create comdat for global arrays.
Sep 13 2018, 2:47 PM
morehouse closed D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 13 2018, 2:47 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Call getUniqueModuleId once per module.
Sep 13 2018, 2:29 PM

Sep 11 2018

morehouse added a comment to D51902: [SanitizerCoverage] Create comdat for global arrays..

The error was actually caused by setting associated metadata for some arrays and not others. By always setting the metadata, we can avoid the issue.

Sep 11 2018, 5:20 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Do not set comdat for local-linkage functions without a unique module ID
Sep 11 2018, 5:16 PM
morehouse reopened D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 11 2018, 5:16 PM
morehouse added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 11 2018, 4:49 PM
morehouse added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 11 2018, 3:40 PM
morehouse committed rL341995: Revert "[SanitizerCoverage] Create comdat for global arrays.".
Revert "[SanitizerCoverage] Create comdat for global arrays."
Sep 11 2018, 2:18 PM
morehouse added inline comments to D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 11 2018, 2:12 PM
morehouse committed rL341987: [SanitizerCoverage] Create comdat for global arrays..
[SanitizerCoverage] Create comdat for global arrays.
Sep 11 2018, 1:12 PM
morehouse closed D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 11 2018, 1:12 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Rebase properly.
Sep 11 2018, 12:56 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Rebase
Sep 11 2018, 12:50 PM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Only set comdats for ELF.
  • Fallback to using module ID when getUniqueModuleId fails.
Sep 11 2018, 12:44 PM
morehouse reopened D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 11 2018, 12:44 PM
morehouse committed rL341965: Revert "[SanitizerCoverage] Create comdat for global arrays.".
Revert "[SanitizerCoverage] Create comdat for global arrays."
Sep 11 2018, 10:21 AM
morehouse committed rL341951: [SanitizerCoverage] Create comdat for global arrays..
[SanitizerCoverage] Create comdat for global arrays.
Sep 11 2018, 8:24 AM
morehouse closed D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 11 2018, 8:24 AM
morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Add refactoring TODO.
Sep 11 2018, 8:24 AM

Sep 10 2018

morehouse updated the diff for D51902: [SanitizerCoverage] Create comdat for global arrays..
  • Fallback to counter suffix if getUniqueModuleId fails.
Sep 10 2018, 7:02 PM
morehouse created D51902: [SanitizerCoverage] Create comdat for global arrays..
Sep 10 2018, 5:58 PM

Sep 6 2018

morehouse accepted D51757: [libfuzzer] Use cl driver mode for tests and enable another test on Windows.
Sep 6 2018, 5:58 PM
morehouse added inline comments to D51757: [libfuzzer] Use cl driver mode for tests and enable another test on Windows.
Sep 6 2018, 5:27 PM

Sep 5 2018

morehouse committed rCRT341495: [libfuzzer] Replace memmem with strstr..
[libfuzzer] Replace memmem with strstr.
Sep 5 2018, 2:05 PM
morehouse committed rL341495: [libfuzzer] Replace memmem with strstr..
[libfuzzer] Replace memmem with strstr.
Sep 5 2018, 2:04 PM
morehouse closed D51692: [libfuzzer] Replace memmem with strstr..
Sep 5 2018, 2:04 PM
morehouse accepted D51692: [libfuzzer] Replace memmem with strstr..
Sep 5 2018, 1:57 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

It seems reasonable to just check that argv is set, since this test is intended to check for LLVMFuzzerInitialize being called. There's plenty of other tests where libFuzzer must find a string.

Sep 5 2018, 1:38 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

Maybe I'm misunderstanding something, but I'm pretty sure memmem returns non-null on a match while strncmp returns 0 on match. Which would mean the ! should have been removed.

Sep 5 2018, 12:56 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

That patch broke the behavior of this test. Looks like we used to print "BINGO" when the input matched the binary name. Now we print "BINGO" when the input size matches but the names do not.

Sep 5 2018, 12:42 PM
morehouse added a comment to D51692: [libfuzzer] Replace memmem with strstr..

Maybe memcmp would be cleaner here.

Sep 5 2018, 11:58 AM

Sep 4 2018

morehouse committed rL341385: [libFuzzer] Enable tests on Windows.
[libFuzzer] Enable tests on Windows
Sep 4 2018, 10:11 AM
morehouse committed rCRT341385: [libFuzzer] Enable tests on Windows.
[libFuzzer] Enable tests on Windows
Sep 4 2018, 10:11 AM
morehouse closed D51549: [libFuzzer] Enable tests on Windows.
Sep 4 2018, 10:11 AM
morehouse committed rCRT341384: [TSan] Update assembly test again..
[TSan] Update assembly test again.
Sep 4 2018, 10:05 AM
morehouse committed rL341384: [TSan] Update assembly test again..
[TSan] Update assembly test again.
Sep 4 2018, 10:05 AM
morehouse committed rCRT341381: [TSan] Update assembly code check..
[TSan] Update assembly code check.
Sep 4 2018, 9:37 AM
morehouse accepted D51549: [libFuzzer] Enable tests on Windows.
Sep 4 2018, 9:36 AM
morehouse committed rL341381: [TSan] Update assembly code check..
[TSan] Update assembly code check.
Sep 4 2018, 9:35 AM

Aug 30 2018

morehouse committed rCRT341082: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 30 2018, 8:56 AM
morehouse committed rL341082: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 30 2018, 8:56 AM
morehouse committed rC341082: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 30 2018, 8:55 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Aug 30 2018, 8:55 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Aug 30 2018, 8:55 AM

Aug 29 2018

morehouse accepted D51455: [libFuzzer] Remove mutation stats and weighted mutation selection..

LGTM

Aug 29 2018, 2:31 PM
morehouse committed rC340954: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Aug 29 2018, 11:43 AM
morehouse committed rL340954: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Aug 29 2018, 11:43 AM
morehouse committed rCRT340954: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Aug 29 2018, 11:43 AM
morehouse committed rCRT340949: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 29 2018, 11:10 AM
morehouse committed rL340949: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 29 2018, 11:09 AM
morehouse committed rC340949: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 29 2018, 11:09 AM

Aug 28 2018

morehouse committed rC340867: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Aug 28 2018, 12:08 PM
morehouse committed rCRT340867: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Aug 28 2018, 12:08 PM
morehouse committed rL340867: Revert "[libFuzzer] Port to Windows".
Revert "[libFuzzer] Port to Windows"
Aug 28 2018, 12:08 PM
morehouse committed rC340860: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 28 2018, 11:35 AM
morehouse committed rCRT340860: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 28 2018, 11:35 AM
morehouse committed rL340860: [libFuzzer] Port to Windows.
[libFuzzer] Port to Windows
Aug 28 2018, 11:35 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Aug 28 2018, 11:35 AM
morehouse closed D51022: [libFuzzer] Port to Windows.
Aug 28 2018, 11:35 AM