- User Since
- Jun 28 2017, 4:27 PM (29 w, 3 d)
Tue, Jan 16
Vitaly, does this test clean on your end now?
Changes look nice visually. I think standard practice is to right-align numerical entries, but that might require a bit more work to pad properly.
Fri, Jan 12
check-fuzzer tests clean for me now with both clang and gcc.
Wed, Jan 10
Steve, you need commit access. See https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. I've pushed this patch for you.
PTAL. Patch has been updated.
- Enable use-after-dtor instrumentation by default.
- Make sanitize-no-dtor-callback.cpp test fail with UAD instrumentation.
- Update test cases to reflect new default.
Fri, Jan 5
Wed, Jan 3
LGTM, but let Vedant comment since he's more familiar with this code.
Dec 20 2017
Dec 13 2017
Dec 8 2017
Dec 7 2017
Dec 6 2017
Dec 5 2017
Dec 4 2017
LGTM. Do you have commit access, or should I land this for you?
Dec 1 2017
Nov 30 2017
LGTM for recent clang. Not sure how long ago -stdlib=libc++ support was added. If it was long enough ago, maybe the lit config is OK? Otherwise might need to check clang version or something.
Nov 27 2017
Nov 16 2017
Nov 15 2017
Patch is out-of-date. But the flag has been enabled internally for over a month with no issues. I'll update this patch soon, so we can flip the default here.
Nov 9 2017
- Simplify test logic.
- Add test.
Oct 31 2017
Oct 18 2017
Oct 17 2017
Oct 16 2017
Oct 13 2017
Oct 12 2017
I tested this manually and it seems to work, but doing ninja check-llvm doesn't seem to run these test cases for me. Maybe my config uses rpath?
- Add cache variable and rename to LLVM_LIB_FUZZING_ENGINE.
To add this to OSS-Fuzz, you will need to link with LIB_FUZZING_ENGINE.
Oct 11 2017
Oct 10 2017
Oct 6 2017
- Revert "Remove dummy main and link with -fsantize=fuzzer."
- Remove dummy main and link with -fsantize=fuzzer.
You're right. I was trying to add -fsanitize=fuzzer to CMAKE_CXX_FLAGS right before the link command, which was causing a later compilation to give the error. Setting CMAKE_EXE_LINKER_FLAGS seems to work though.
Will we be able to reuse some of Justin's code instead of creating one more main() function?
This reuses the code that Justin moved to FuzzMutate/FuzzerCLI. That's why the main is so short. But perhaps we could move the main itself into FuzzerCLI?
Or, why not link with libFuzzer (-fsanitize=fuzzer at link time) even if we don't us einstrumentation at compile time?
When I tried this, I got undefined references to all kinds of __sanitizer_cov_* symbols.