Page MenuHomePhabricator

klausler (Peter Klausler)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 11:45 AM (111 w, 1 d)

Recent Activity

Today

klausler committed rG0c190575ebfc: [flang] Make generic resolution conform to 15.5.5.2 w/r/t host association (authored by klausler).
[flang] Make generic resolution conform to 15.5.5.2 w/r/t host association
Sat, May 28, 10:06 AM · Restricted Project, Restricted Project
klausler closed D126587: [flang] Make generic resolution conform to 15.5.5.2 w/r/t host association.
Sat, May 28, 10:06 AM · Restricted Project, Restricted Project
klausler committed rG3142c761da97: [nfc][flang] Fix spelling errors and usage in an error message (authored by klausler).
[nfc][flang] Fix spelling errors and usage in an error message
Sat, May 28, 9:33 AM · Restricted Project, Restricted Project
klausler closed D126490: [nfc][flang] Fix spelling errors and usage in an error message.
Sat, May 28, 9:33 AM · Restricted Project, Restricted Project
klausler committed rG73506256bff6: [flang] Avoid spurious warnings from reading module files (authored by klausler).
[flang] Avoid spurious warnings from reading module files
Sat, May 28, 8:56 AM · Restricted Project, Restricted Project
klausler closed D126584: [flang] Avoid spurious warnings from reading module files.
Sat, May 28, 8:56 AM · Restricted Project, Restricted Project

Yesterday

klausler updated the diff for D126587: [flang] Make generic resolution conform to 15.5.5.2 w/r/t host association.

Add missing changes (a cherry-pick went awry).

Fri, May 27, 8:51 PM · Restricted Project, Restricted Project
klausler requested review of D126587: [flang] Make generic resolution conform to 15.5.5.2 w/r/t host association.
Fri, May 27, 8:23 PM · Restricted Project, Restricted Project
klausler requested review of D126584: [flang] Avoid spurious warnings from reading module files.
Fri, May 27, 8:18 PM · Restricted Project, Restricted Project

Thu, May 26

klausler accepted D126459: [flang] Make extension explicit: exponent-letter matching kind-param.
Thu, May 26, 11:25 AM · Restricted Project, Restricted Project
klausler requested review of D126490: [nfc][flang] Fix spelling errors and usage in an error message.
Thu, May 26, 11:03 AM · Restricted Project, Restricted Project
klausler requested changes to D126473: [flang] Fix semantic analysis for PDT component init.
Thu, May 26, 9:57 AM · Restricted Project, Restricted Project
klausler accepted D126301: [flang] Support correct continuations for compiler directives.
Thu, May 26, 9:23 AM · Restricted Project, Restricted Project

Wed, May 25

klausler committed rGddd692e9d572: [flang] Allow forward reference to ENTRY from generic interface (authored by klausler).
[flang] Allow forward reference to ENTRY from generic interface
Wed, May 25, 5:15 PM · Restricted Project, Restricted Project
klausler closed D126436: [flang] Allow forward reference to ENTRY from generic interface.
Wed, May 25, 5:15 PM · Restricted Project, Restricted Project
klausler requested review of D126436: [flang] Allow forward reference to ENTRY from generic interface.
Wed, May 25, 4:48 PM · Restricted Project, Restricted Project
klausler accepted D126433: [flang] Update intrinsic module source files.
Wed, May 25, 4:44 PM · Restricted Project, Restricted Project
klausler committed rG6b99dc29c6ef: [flang] Fix crash from a blank BIND(C,NAME="") on subprogram (authored by klausler).
[flang] Fix crash from a blank BIND(C,NAME="") on subprogram
Wed, May 25, 2:48 PM · Restricted Project, Restricted Project
klausler closed D126416: [flang] Fix crash from a blank BIND(C,NAME="") on subprogram.
Wed, May 25, 2:48 PM · Restricted Project, Restricted Project
klausler requested review of D126416: [flang] Fix crash from a blank BIND(C,NAME="") on subprogram.
Wed, May 25, 1:38 PM · Restricted Project, Restricted Project
klausler committed rGbbad981dab49: [flang] Address regression (calls to assumed-length character function dummy… (authored by klausler).
[flang] Address regression (calls to assumed-length character function dummy…
Wed, May 25, 12:00 PM · Restricted Project, Restricted Project
klausler closed D126390: [flang] Address regression (calls to assumed-length character function dummy procedures).
Wed, May 25, 12:00 PM · Restricted Project, Restricted Project
klausler accepted D126360: [Fortran] Forward NO_STOP_MESSAGE to FCVS tests.
Wed, May 25, 11:05 AM · Restricted Project, Restricted Project
klausler requested review of D126390: [flang] Address regression (calls to assumed-length character function dummy procedures).
Wed, May 25, 9:28 AM · Restricted Project, Restricted Project
klausler added a comment to D126279: [Fortran] Set QUIET = .TRUE. in STOP statements.

I can do that, but I don't like that solution. My understanding is that these warnings are platform-dependent, and also the 'Fortran STOP' seems to be printed by default by flang. This means pretty much anyone running the test-suite with flang will have to set this environment variable, or else face a ton of failures. Why make the test-suite harder to run? I think one of the goals of the test-suite is to be independent from both the hardware and the compiler, and all the better if it's possible to achieve that without compiler-specific hacks. In this case, setting the STOP statement to QUIET makes sense to me because its output is not strictly defined by the standard and will vary with both hardware and compiler. The test-suite is not a good place to test warnings, error messages or other fuzzy output - that should go in flang's own tests.

Wed, May 25, 6:35 AM · Restricted Project, Restricted Project

Tue, May 24

klausler committed rGcdd54cbdd937: [flang][runtime] Catch decimal integer input overflow (authored by klausler).
[flang][runtime] Catch decimal integer input overflow
Tue, May 24, 2:15 PM · Restricted Project, Restricted Project
klausler closed D126155: flang][runtime] Catch decimal integer input overflow.
Tue, May 24, 2:15 PM · Restricted Project, Restricted Project
klausler committed rG0a79113b9e06: [flang] Replace crash and improve a semantics TODO message (authored by klausler).
[flang] Replace crash and improve a semantics TODO message
Tue, May 24, 2:06 PM · Restricted Project, Restricted Project
klausler closed D126154: [flang] Replace crash and improve a semantics TODO message.
Tue, May 24, 2:06 PM · Restricted Project, Restricted Project
klausler committed rGd52a6e75b0c4: [flang] Process subprogram BIND(C,NAME=...) locally (authored by klausler).
[flang] Process subprogram BIND(C,NAME=...) locally
Tue, May 24, 2:00 PM · Restricted Project, Restricted Project
klausler closed D126153: [flang] Process subprogram BIND(C,NAME=...) locally.
Tue, May 24, 2:00 PM · Restricted Project, Restricted Project
klausler committed rGdcf9ba82d99c: [flang] Fix false error for multiple defined I/O subroutines (authored by klausler).
[flang] Fix false error for multiple defined I/O subroutines
Tue, May 24, 1:51 PM · Restricted Project, Restricted Project
klausler closed D126152: [flang] Fix false error for multiple defined I/O subroutines.
Tue, May 24, 1:51 PM · Restricted Project, Restricted Project
klausler committed rG48a8a3eb2f56: [flang] Accept defined assignment with CLASS(*) RHS (authored by klausler).
[flang] Accept defined assignment with CLASS(*) RHS
Tue, May 24, 1:46 PM · Restricted Project, Restricted Project
klausler closed D126151: [flang] Accept defined assignment with CLASS(*) RHS.
Tue, May 24, 1:46 PM · Restricted Project, Restricted Project
klausler committed rGbd92bca53517: [flang] Fix purity testing for generic calls (authored by klausler).
[flang] Fix purity testing for generic calls
Tue, May 24, 1:40 PM · Restricted Project, Restricted Project
klausler closed D126150: [flang] Fix purity testing for generic calls.
Tue, May 24, 1:40 PM · Restricted Project, Restricted Project
klausler committed rGcd2a8df89165: [flang] Don't prematurely resolve subprogram names (authored by klausler).
[flang] Don't prematurely resolve subprogram names
Tue, May 24, 1:35 PM · Restricted Project, Restricted Project
klausler closed D126149: [flang] Don't prematurely resolve subprogram names.
Tue, May 24, 1:35 PM · Restricted Project, Restricted Project
klausler updated the diff for D126148: [flang] Catch calls to assumed-length character functions.

Delete part of a new test that showed up during review and testing.

Tue, May 24, 12:55 PM · Restricted Project, Restricted Project
klausler committed rGc428620913ba: [flang] Catch calls to assumed-length character functions (authored by klausler).
[flang] Catch calls to assumed-length character functions
Tue, May 24, 12:54 PM · Restricted Project, Restricted Project
klausler closed D126148: [flang] Catch calls to assumed-length character functions.
Tue, May 24, 12:54 PM · Restricted Project, Restricted Project
klausler committed rG03095bd97b81: [flang] Fix crash in semantics after PDT instantiation (authored by klausler).
[flang] Fix crash in semantics after PDT instantiation
Tue, May 24, 11:06 AM · Restricted Project, Restricted Project
klausler closed D126147: [flang] Fix crash in semantics after PDT instantiation.
Tue, May 24, 11:06 AM · Restricted Project, Restricted Project
klausler added a comment to D126301: [flang] Support correct continuations for compiler directives.

I think that you need a test case with long CHARACTER literals and Hollerith literals that contain the comment marker ('!').

Tue, May 24, 10:38 AM · Restricted Project, Restricted Project
klausler committed rG8527f9e4437f: [flang][runtime] Handle BACKSPACE after reading past EOF (authored by klausler).
[flang][runtime] Handle BACKSPACE after reading past EOF
Tue, May 24, 10:28 AM · Restricted Project, Restricted Project
klausler closed D126146: [flang][runtime] Handle BACKSPACE after reading past EOF.
Tue, May 24, 10:28 AM · Restricted Project, Restricted Project
klausler committed rGd90e866a191f: [flang][runtime] INQUIRE(UNIT=666,NUMBER=n) must set n=666 (authored by klausler).
[flang][runtime] INQUIRE(UNIT=666,NUMBER=n) must set n=666
Tue, May 24, 9:48 AM · Restricted Project, Restricted Project
klausler closed D126145: [flang][runtime] INQUIRE(UNIT=666,NUMBER=n) must set n=666.
Tue, May 24, 9:48 AM · Restricted Project, Restricted Project
klausler committed rG574f9dfee86a: [flang] Extension: Accept Hollerith actual arguments as if they were BOZ (authored by klausler).
[flang] Extension: Accept Hollerith actual arguments as if they were BOZ
Tue, May 24, 9:05 AM · Restricted Project, Restricted Project
klausler closed D126144: [flang] Extension: Accept Hollerith actual arguments as if they were BOZ.
Tue, May 24, 9:04 AM · Restricted Project, Restricted Project
klausler added inline comments to D126301: [flang] Support correct continuations for compiler directives.
Tue, May 24, 9:01 AM · Restricted Project, Restricted Project
klausler added a comment to D126301: [flang] Support correct continuations for compiler directives.

Reviewers take note: this patch changes how some directive lines are *emitted* in the fake preprocessed output, *not* how they are processed in the prescanner.

Tue, May 24, 8:09 AM · Restricted Project, Restricted Project
klausler added a comment to D126279: [Fortran] Set QUIET = .TRUE. in STOP statements.

Run the tests with NO_STOP_MESSAGE=1 in the environment.

Tue, May 24, 8:02 AM · Restricted Project, Restricted Project
klausler committed rGdeb62f5ad649: [flang][runtime] Clean up asynchronous I/O APIs (authored by klausler).
[flang][runtime] Clean up asynchronous I/O APIs
Tue, May 24, 7:55 AM · Restricted Project, Restricted Project
klausler closed D126143: [flang][runtime] Clean up asynchronous I/O APIs.
Tue, May 24, 7:55 AM · Restricted Project, Restricted Project

Mon, May 23

klausler committed rG7f680b260ffe: [flang] Allow more forward references to ENTRY names (authored by klausler).
[flang] Allow more forward references to ENTRY names
Mon, May 23, 9:49 PM · Restricted Project, Restricted Project
klausler closed D126142: [flang] Allow more forward references to ENTRY names.
Mon, May 23, 9:48 PM · Restricted Project, Restricted Project
klausler committed rG037732289798: [flang] Ignore BIND(C) binding name conflicts of inner procedures (authored by klausler).
[flang] Ignore BIND(C) binding name conflicts of inner procedures
Mon, May 23, 6:27 PM · Restricted Project, Restricted Project
klausler closed D126141: [flang] Ignore BIND(C) binding name conflicts of inner procedures.
Mon, May 23, 6:27 PM · Restricted Project, Restricted Project
klausler committed rG9f33dd733ff5: [flang] Allow global scope names that clash with intrinsic modules (authored by klausler).
[flang] Allow global scope names that clash with intrinsic modules
Mon, May 23, 6:22 PM · Restricted Project, Restricted Project
klausler closed D126140: [flang] Allow global scope names that clash with intrinsic modules.
Mon, May 23, 6:21 PM · Restricted Project, Restricted Project
klausler committed rGe141e719e166: [flang] Fix character length calculation for Unicode component (authored by klausler).
[flang] Fix character length calculation for Unicode component
Mon, May 23, 5:48 PM · Restricted Project, Restricted Project
klausler closed D126139: [flang] Fix character length calculation for Unicode component.
Mon, May 23, 5:48 PM · Restricted Project, Restricted Project

Sun, May 22

klausler updated the diff for D126153: [flang] Process subprogram BIND(C,NAME=...) locally.

Tweak code to work in the absence of an earlier change on which this one used to depend.

Sun, May 22, 4:47 PM · Restricted Project, Restricted Project
klausler accepted D126163: [flang] Set red bold color for the keyword "fatal internal error".
Sun, May 22, 9:28 AM · Restricted Project, Restricted Project

Sat, May 21

klausler requested review of D126155: flang][runtime] Catch decimal integer input overflow.
Sat, May 21, 10:20 PM · Restricted Project, Restricted Project
klausler requested review of D126154: [flang] Replace crash and improve a semantics TODO message.
Sat, May 21, 10:19 PM · Restricted Project, Restricted Project
klausler requested review of D126153: [flang] Process subprogram BIND(C,NAME=...) locally.
Sat, May 21, 10:18 PM · Restricted Project, Restricted Project
klausler requested review of D126152: [flang] Fix false error for multiple defined I/O subroutines.
Sat, May 21, 10:17 PM · Restricted Project, Restricted Project
klausler requested review of D126151: [flang] Accept defined assignment with CLASS(*) RHS.
Sat, May 21, 10:17 PM · Restricted Project, Restricted Project
klausler requested review of D126150: [flang] Fix purity testing for generic calls.
Sat, May 21, 10:15 PM · Restricted Project, Restricted Project
klausler requested review of D126149: [flang] Don't prematurely resolve subprogram names.
Sat, May 21, 10:15 PM · Restricted Project, Restricted Project
klausler requested review of D126148: [flang] Catch calls to assumed-length character functions.
Sat, May 21, 10:14 PM · Restricted Project, Restricted Project
klausler requested review of D126147: [flang] Fix crash in semantics after PDT instantiation.
Sat, May 21, 10:13 PM · Restricted Project, Restricted Project
klausler requested review of D126146: [flang][runtime] Handle BACKSPACE after reading past EOF.
Sat, May 21, 10:12 PM · Restricted Project, Restricted Project
klausler requested review of D126145: [flang][runtime] INQUIRE(UNIT=666,NUMBER=n) must set n=666.
Sat, May 21, 10:11 PM · Restricted Project, Restricted Project
klausler requested review of D126144: [flang] Extension: Accept Hollerith actual arguments as if they were BOZ.
Sat, May 21, 10:10 PM · Restricted Project, Restricted Project
klausler requested review of D126143: [flang][runtime] Clean up asynchronous I/O APIs.
Sat, May 21, 10:09 PM · Restricted Project, Restricted Project
klausler requested review of D126142: [flang] Allow more forward references to ENTRY names.
Sat, May 21, 10:08 PM · Restricted Project, Restricted Project
klausler requested review of D126141: [flang] Ignore BIND(C) binding name conflicts of inner procedures.
Sat, May 21, 10:07 PM · Restricted Project, Restricted Project
klausler requested review of D126140: [flang] Allow global scope names that clash with intrinsic modules.
Sat, May 21, 10:06 PM · Restricted Project, Restricted Project
klausler requested review of D126139: [flang] Fix character length calculation for Unicode component.
Sat, May 21, 10:04 PM · Restricted Project, Restricted Project

Mon, May 16

klausler accepted D125685: [flang] Add one semantic check for elemental call arguments.
Mon, May 16, 8:47 AM · Restricted Project, Restricted Project

Sun, May 15

klausler requested changes to D125631: [flang] Change the fatal errors into warnings for overlapped initialization.

This case must remain an error. There are no unambiguous semantics that can be guaranteed.

Sun, May 15, 4:23 PM · Restricted Project, Restricted Project

Thu, May 12

klausler accepted D125371: [flang] Warn for the limit on name length.
Thu, May 12, 9:42 AM · Restricted Project, Restricted Project
klausler added inline comments to D125371: [flang] Warn for the limit on name length.
Thu, May 12, 8:48 AM · Restricted Project, Restricted Project

Wed, May 11

klausler committed rGd80d812df0c8: [flang] Fix check for assumed-size arguments to SHAPE() & al. (authored by klausler).
[flang] Fix check for assumed-size arguments to SHAPE() & al.
Wed, May 11, 10:33 AM · Restricted Project, Restricted Project
klausler closed D125342: [flang] Fix check for assumed-size arguments to SHAPE() & al..
Wed, May 11, 10:33 AM · Restricted Project, Restricted Project
klausler committed rG3a26596af361: [flang] Fold complex component references (authored by klausler).
[flang] Fold complex component references
Wed, May 11, 10:05 AM · Restricted Project, Restricted Project
klausler closed D125341: [flang] Fold complex component references.
Wed, May 11, 10:04 AM · Restricted Project, Restricted Project
klausler added inline comments to D125371: [flang] Warn for the limit on name length.
Wed, May 11, 8:30 AM · Restricted Project, Restricted Project

Tue, May 10

klausler committed rG2cd95504df57: [flang] Allow local variables and function result inquiries in specification… (authored by klausler).
[flang] Allow local variables and function result inquiries in specification…
Tue, May 10, 4:47 PM · Restricted Project, Restricted Project
klausler closed D125343: [flang] Allow local variables and function result inquiries in specification expressions.
Tue, May 10, 4:47 PM · Restricted Project, Restricted Project
klausler requested review of D125343: [flang] Allow local variables and function result inquiries in specification expressions.
Tue, May 10, 3:22 PM · Restricted Project, Restricted Project
klausler requested review of D125342: [flang] Fix check for assumed-size arguments to SHAPE() & al..
Tue, May 10, 3:20 PM · Restricted Project, Restricted Project
klausler requested review of D125341: [flang] Fold complex component references.
Tue, May 10, 3:17 PM · Restricted Project, Restricted Project
klausler committed rG940871dd289c: [flang] Enforce limit on rank + corank (authored by klausler).
[flang] Enforce limit on rank + corank
Tue, May 10, 9:12 AM · Restricted Project, Restricted Project
klausler closed D125153: [flang] Enforce limit on rank + corank.
Tue, May 10, 9:11 AM · Restricted Project, Restricted Project
klausler committed rG71728360ada3: [flang] Fold real-valued MODULO() and MOD() (authored by klausler).
[flang] Fold real-valued MODULO() and MOD()
Tue, May 10, 8:16 AM · Restricted Project, Restricted Project