Page MenuHomePhabricator

klausler (Peter Klausler)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 11:45 AM (32 w, 4 d)

Recent Activity

Wed, Nov 18

klausler committed rG5349f99114cf: [flang] Correct handling of null pointer initializers (authored by klausler).
[flang] Correct handling of null pointer initializers
Wed, Nov 18, 1:57 PM
klausler closed D91657: [flang] Correct handling of null pointer initializers.
Wed, Nov 18, 1:57 PM · Restricted Project, Restricted Project
klausler accepted D91736: [flang] Improve error message on bad LOGICAL compare operations.
Wed, Nov 18, 1:22 PM · Restricted Project, Restricted Project

Tue, Nov 17

klausler added a comment to D88793: [flang] Fix assumptions on std::forward_list iterator implementation..

Is this particular concern now resolved by the change to std::list<>?

Tue, Nov 17, 4:31 PM · Restricted Project, Restricted Project
klausler requested review of D91657: [flang] Correct handling of null pointer initializers.
Tue, Nov 17, 1:22 PM · Restricted Project, Restricted Project

Mon, Nov 16

klausler accepted D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 3:55 PM · Restricted Project, Restricted Project
klausler requested changes to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 2:42 PM · Restricted Project, Restricted Project
klausler accepted D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 1:53 PM · Restricted Project, Restricted Project
klausler added inline comments to D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 12:24 PM · Restricted Project, Restricted Project
klausler committed rGdf62afd559d4: [flang] Unsplit COMPLEX operations (authored by klausler).
[flang] Unsplit COMPLEX operations
Mon, Nov 16, 9:39 AM
klausler closed D91443: [flang] Unsplit COMPLEX operations.
Mon, Nov 16, 9:39 AM · Restricted Project, Restricted Project

Fri, Nov 13

klausler accepted D91440: [flang] Fix "EQ" comparison of arrays.
Fri, Nov 13, 10:00 AM · Restricted Project, Restricted Project
klausler requested review of D91443: [flang] Unsplit COMPLEX operations.
Fri, Nov 13, 9:49 AM · Restricted Project, Restricted Project

Thu, Nov 12

klausler committed rGc2bccd66f63d: [flang] Document DO CONCURRENT's problems (NFC) (authored by klausler).
[flang] Document DO CONCURRENT's problems (NFC)
Thu, Nov 12, 3:31 PM
klausler closed D86556: [flang] Document DO CONCURRENT's problems.
Thu, Nov 12, 3:30 PM · Restricted Project, Restricted Project
klausler updated the diff for D86556: [flang] Document DO CONCURRENT's problems.

Clean up English usage & conform with Markdown usage now in use in other documentation files.

Thu, Nov 12, 3:07 PM · Restricted Project, Restricted Project
klausler committed rG04a147987a6b: [flang] Include source information in an invalid file-unit-number message (authored by klausler).
[flang] Include source information in an invalid file-unit-number message
Thu, Nov 12, 1:12 PM
klausler closed D91375: [flang] Include source information in an invalid file-unit-number message.
Thu, Nov 12, 1:12 PM · Restricted Project, Restricted Project
klausler committed rG6c516cda3974: [flang] Recognize END FILE as ENDFILE in free form source (authored by klausler).
[flang] Recognize END FILE as ENDFILE in free form source
Thu, Nov 12, 12:53 PM
klausler closed D91377: [flang] Recognize END FILE as ENDFILE in free form source.
Thu, Nov 12, 12:53 PM · Restricted Project, Restricted Project
klausler requested review of D91377: [flang] Recognize END FILE as ENDFILE in free form source.
Thu, Nov 12, 12:03 PM · Restricted Project, Restricted Project
klausler requested review of D91375: [flang] Include source information in an invalid file-unit-number message.
Thu, Nov 12, 12:00 PM · Restricted Project, Restricted Project
klausler committed rG3ce5f957165d: fix clang build (authored by klausler).
fix clang build
Thu, Nov 12, 11:39 AM
klausler committed rG8df28f0aa3c0: [flang] Implement runtime support for basic ALLOCATE/DEALLOCATE (authored by klausler).
[flang] Implement runtime support for basic ALLOCATE/DEALLOCATE
Thu, Nov 12, 10:22 AM
klausler closed D91215: [flang] Implement runtime support for basic ALLOCATE/DEALLOCATE.
Thu, Nov 12, 10:22 AM · Restricted Project, Restricted Project
klausler updated the diff for D91215: [flang] Implement runtime support for basic ALLOCATE/DEALLOCATE.

Fix bug noticed by Jean.

Thu, Nov 12, 8:46 AM · Restricted Project, Restricted Project

Wed, Nov 11

klausler committed rGcc575dd2cefc: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages (authored by klausler).
[flang][MSVC] Use list<Message> rather than forward_list<> in Messages
Wed, Nov 11, 4:39 PM
klausler closed D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages.
Wed, Nov 11, 4:38 PM · Restricted Project, Restricted Project
klausler accepted D88797: [flang] Fix copy elision assumption..
Wed, Nov 11, 2:01 PM · Restricted Project, Restricted Project
klausler added a comment to D88793: [flang] Fix assumptions on std::forward_list iterator implementation..

Please see D91210 for a replacement implementation in terms of std::list<>.

Wed, Nov 11, 1:55 PM · Restricted Project, Restricted Project
klausler committed rG67b13e9785ed: [flang] Fix CheckSpecificationExpr handling of associated names (authored by klausler).
[flang] Fix CheckSpecificationExpr handling of associated names
Wed, Nov 11, 1:52 PM
klausler closed D91286: [flang] Fix CheckSpecificationExpr handling of associated names.
Wed, Nov 11, 1:52 PM · Restricted Project, Restricted Project
klausler committed rGb781a04f6aff: [flang] Allow labels on END statements. (authored by klausler).
[flang] Allow labels on END statements.
Wed, Nov 11, 1:06 PM
klausler closed D91217: [flang] Allow labels on END statements..
Wed, Nov 11, 1:06 PM · Restricted Project, Restricted Project
klausler committed rG2d5b85075178: [flang] Use IMPLICIT from scope of external function reference (authored by klausler).
[flang] Use IMPLICIT from scope of external function reference
Wed, Nov 11, 12:13 PM
klausler closed D91214: [flang] Use IMPLICIT from scope of external function reference.
Wed, Nov 11, 12:12 PM · Restricted Project, Restricted Project
klausler committed rG29fa4518703e: [flang] Add isnan() extension intrinsic function, with folding (authored by klausler).
[flang] Add isnan() extension intrinsic function, with folding
Wed, Nov 11, 11:41 AM
klausler closed D91213: [flang] Add isnan() extension intrinsic function, with folding.
Wed, Nov 11, 11:41 AM · Restricted Project, Restricted Project
klausler requested review of D91286: [flang] Fix CheckSpecificationExpr handling of associated names.
Wed, Nov 11, 11:10 AM · Restricted Project, Restricted Project
klausler updated the diff for D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages.

Remove needless <deque>

Wed, Nov 11, 10:43 AM · Restricted Project, Restricted Project
klausler added inline comments to D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages.
Wed, Nov 11, 10:38 AM · Restricted Project, Restricted Project
klausler added a comment to D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

I think that the root cause of the build failure is the circular dependency: FortranSemantics <-> FortranEvaluate <-> FortranSemantics. Adding inline to IsModule and IsSubmodule fixes this particular build issue, but not the circular dependency.

Wed, Nov 11, 10:18 AM · Restricted Project, Restricted Project
klausler added a comment to D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

Probably IsModule and IsSubmodule have to be made inline.

Wed, Nov 11, 10:06 AM · Restricted Project, Restricted Project

Tue, Nov 10

klausler committed rGb670189975f5: [flang] Fix CheckSpecificationExpr handling of associated names (authored by klausler).
[flang] Fix CheckSpecificationExpr handling of associated names
Tue, Nov 10, 4:19 PM
klausler closed D91209: [flang] Fix CheckSpecificationExpr handling of associated names.
Tue, Nov 10, 4:19 PM · Restricted Project, Restricted Project
klausler requested review of D91217: [flang] Allow labels on END statements..
Tue, Nov 10, 3:18 PM · Restricted Project, Restricted Project
klausler requested review of D91215: [flang] Implement runtime support for basic ALLOCATE/DEALLOCATE.
Tue, Nov 10, 3:15 PM · Restricted Project, Restricted Project
klausler requested review of D91214: [flang] Use IMPLICIT from scope of external function reference.
Tue, Nov 10, 3:12 PM · Restricted Project, Restricted Project
klausler requested review of D91213: [flang] Add isnan() extension intrinsic function, with folding.
Tue, Nov 10, 3:09 PM · Restricted Project, Restricted Project
klausler requested review of D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages.
Tue, Nov 10, 2:58 PM · Restricted Project, Restricted Project
klausler requested review of D91209: [flang] Fix CheckSpecificationExpr handling of associated names.
Tue, Nov 10, 2:55 PM · Restricted Project, Restricted Project
klausler added a comment to D88793: [flang] Fix assumptions on std::forward_list iterator implementation..

The point is to use std::forward_list::splice_after() for efficient combination of messages.

Unfortunately it also means that we have to search for the new last element since we cannot assume that iterators of the consumed list became iterators for the resulting list. This probably eats up any potations savings. There isn't a a guarantee that splice_after is O(1) anyway.

Tue, Nov 10, 9:10 AM · Restricted Project, Restricted Project

Tue, Nov 3

klausler committed rG7ba393efe5fe: [flang] Dodge gcc 8.2.0 build problem (NFC) (authored by klausler).
[flang] Dodge gcc 8.2.0 build problem (NFC)
Tue, Nov 3, 4:31 PM
klausler closed D90696: [flang] Dodge gcc 8.2.0 build problem (NFC).
Tue, Nov 3, 4:31 PM · Restricted Project, Restricted Project
klausler requested review of D90696: [flang] Dodge gcc 8.2.0 build problem (NFC).
Tue, Nov 3, 10:49 AM · Restricted Project, Restricted Project

Mon, Nov 2

klausler committed rG934b27a9daf6: [flang] Fix actual argument character length and length error reporting (authored by klausler).
[flang] Fix actual argument character length and length error reporting
Mon, Nov 2, 1:40 PM
klausler closed D90636: [flang] Fix actual argument character length and length error reporting.
Mon, Nov 2, 1:39 PM · Restricted Project, Restricted Project
klausler requested review of D90636: [flang] Fix actual argument character length and length error reporting.
Mon, Nov 2, 11:53 AM · Restricted Project, Restricted Project
klausler committed rGe8f96899e17b: [flang] Allow array constructor implied DO loop indices as constant expressions (authored by klausler).
[flang] Allow array constructor implied DO loop indices as constant expressions
Mon, Nov 2, 11:00 AM
klausler closed D90494: [flang] Allow array constructor implied DO loop indices as constant expressions.
Mon, Nov 2, 11:00 AM · Restricted Project, Restricted Project
klausler committed rG8fc07fed32b0: [flang] Design document for runtime derived type descriptions (NFC) (authored by klausler).
[flang] Design document for runtime derived type descriptions (NFC)
Mon, Nov 2, 9:24 AM
klausler closed D90500: [flang] Design document for runtime derived type descriptions (NFC).
Mon, Nov 2, 9:24 AM · Restricted Project, Restricted Project

Fri, Oct 30

klausler committed rG93d10919c8e3: [flang] Plug error recovery hole for erroneous subscripts (authored by klausler).
[flang] Plug error recovery hole for erroneous subscripts
Fri, Oct 30, 5:33 PM
klausler closed D90499: [flang] Plug error recovery hole for erroneous subscripts.
Fri, Oct 30, 5:32 PM · Restricted Project, Restricted Project
klausler committed rG882fa241f1d2: [flang] Better error messages & more cases caught for bad forward refs (authored by klausler).
[flang] Better error messages & more cases caught for bad forward refs
Fri, Oct 30, 5:12 PM
klausler closed D90492: [flang] Better error messages & more cases caught for bad forward refs.
Fri, Oct 30, 5:11 PM · Restricted Project, Restricted Project
klausler committed rGc1168676a0c2: [flang] Add warning for FINAL pitfall (authored by klausler).
[flang] Add warning for FINAL pitfall
Fri, Oct 30, 4:42 PM
klausler closed D90495: [flang] Add warning for FINAL pitfall.
Fri, Oct 30, 4:42 PM · Restricted Project, Restricted Project
klausler committed rG4acd8f7f0a7e: [flang] Detect and rewrite ambiguous READ(CVAR)[,item-list] (authored by klausler).
[flang] Detect and rewrite ambiguous READ(CVAR)[,item-list]
Fri, Oct 30, 3:48 PM
klausler closed D90493: [flang] Detect and rewrite ambiguous READ(CVAR)[,item-list].
Fri, Oct 30, 3:47 PM · Restricted Project, Restricted Project
klausler requested review of D90500: [flang] Design document for runtime derived type descriptions (NFC).
Fri, Oct 30, 2:23 PM · Restricted Project, Restricted Project
klausler requested review of D90499: [flang] Plug error recovery hole for erroneous subscripts.
Fri, Oct 30, 2:20 PM · Restricted Project, Restricted Project
klausler requested review of D90495: [flang] Add warning for FINAL pitfall.
Fri, Oct 30, 1:32 PM · Restricted Project, Restricted Project
klausler requested review of D90494: [flang] Allow array constructor implied DO loop indices as constant expressions.
Fri, Oct 30, 12:59 PM · Restricted Project, Restricted Project
klausler requested review of D90493: [flang] Detect and rewrite ambiguous READ(CVAR)[,item-list].
Fri, Oct 30, 12:55 PM · Restricted Project, Restricted Project
klausler requested review of D90492: [flang] Better error messages & more cases caught for bad forward refs.
Fri, Oct 30, 12:52 PM · Restricted Project, Restricted Project

Oct 23 2020

klausler accepted D90074: [flang] An erroneous type bound procedure was causing a call to CHECK().
Oct 23 2020, 1:30 PM · Restricted Project, Restricted Project
klausler accepted D90049: [flang] Tighten rules to resolve procedure as intrinsic procedure.

Looks great to me; thanks!

Oct 23 2020, 10:41 AM · Restricted Project, Restricted Project

Oct 21 2020

klausler accepted D89369: [flang][windows] Support platform-specific path separator..

There may be path separators with UNIX assumptions in the runtime I/O support library, too.

Oct 21 2020, 10:01 AM · Restricted Project, Restricted Project
klausler accepted D89367: [flang][msvc] Fix lambda capture ambiguity. NFC..
Oct 21 2020, 9:59 AM · Restricted Project, Restricted Project
klausler accepted D88794: [flang] Fix pimpl idiom for IntrinsicProcTable..
Oct 21 2020, 9:58 AM · Restricted Project, Restricted Project
klausler accepted D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects.
Oct 21 2020, 9:52 AM · Restricted Project, Restricted Project

Oct 19 2020

klausler added a comment to D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects.

Why is this a fatal error, rather than a warning? If the TARGET= argument lacks both POINTER and TARGET attributes, the result will always be false, and we can warn about that.

Oct 19 2020, 11:27 AM · Restricted Project, Restricted Project

Oct 16 2020

klausler accepted D89581: [flang] Disallow pointer constants.

Please add a comment that lays out our reasoning for the prohibition against combining PARAMETER and POINTER, since the standards do not explicitly preclude it. (The PARAMETER attribute requires a entity-decl to have an initialization that is a constant-expr, and the only form of initialization that allows a constant-expr is the one that's not a "=>" pointer initialization.) See C811, C807, & 8.5.13.

Oct 16 2020, 11:59 AM · Restricted Project, Restricted Project
klausler accepted D89473: [flang] Document and use intrinsic subroutine argument intents.
Oct 16 2020, 10:24 AM · Restricted Project, Restricted Project

Oct 15 2020

klausler accepted D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

LGTM and thanks!

Oct 15 2020, 1:19 PM · Restricted Project, Restricted Project
klausler added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Oct 15 2020, 10:56 AM · Restricted Project, Restricted Project
klausler committed rG2aad6a0884e3: [flang][msvc] Avoid a reinterpret_cast (authored by klausler).
[flang][msvc] Avoid a reinterpret_cast
Oct 15 2020, 10:39 AM
klausler closed D89435: [flang][msvc] Avoid a reinterpret_cast.
Oct 15 2020, 10:39 AM · Restricted Project, Restricted Project
klausler added inline comments to D89473: [flang] Document and use intrinsic subroutine argument intents.
Oct 15 2020, 9:27 AM · Restricted Project, Restricted Project

Oct 14 2020

klausler added a comment to D88798: [flang] Fix heap overflow in Real formatting..

Please see https://reviews.llvm.org/D89435 for a proposed alternative patch.

Oct 14 2020, 4:37 PM · Restricted Project, Restricted Project
klausler requested review of D89435: [flang][msvc] Avoid a reinterpret_cast.
Oct 14 2020, 4:37 PM · Restricted Project, Restricted Project
klausler added a comment to D88798: [flang] Fix heap overflow in Real formatting..

I think a better fix would be to generalize ToUInt64 as a template elsewhere. I'll prepare a patch and add you as the reviewer.

Oct 14 2020, 11:56 AM · Restricted Project, Restricted Project

Oct 8 2020

klausler committed rG3e86eda18c37: [flang] Allow "name: value" in compiler directives (authored by klausler).
[flang] Allow "name: value" in compiler directives
Oct 8 2020, 10:02 AM
klausler closed D89017: [flang] Allow "name: value" in compiler directives.
Oct 8 2020, 10:02 AM · Restricted Project, Restricted Project
klausler accepted D88981: [flang] Rework host runtime folding and enable REAL(2) folding with it..

There's a lot of work here and it's quite well done; thank you.

Oct 8 2020, 10:00 AM · Restricted Project, Restricted Project

Oct 7 2020

klausler requested review of D89017: [flang] Allow "name: value" in compiler directives.
Oct 7 2020, 4:09 PM · Restricted Project, Restricted Project
klausler committed rGd56fdc8e95df: [flang][msvc] Avoid dependence on long double (authored by klausler).
[flang][msvc] Avoid dependence on long double
Oct 7 2020, 3:13 PM
klausler closed D88752: [flang][msvc] Avoid dependence on long double.
Oct 7 2020, 3:12 PM · Restricted Project, Restricted Project
klausler committed rG88afb6e86774: [flang] Semantic checks for bad usage of whole assumed-size arrays (authored by klausler).
[flang] Semantic checks for bad usage of whole assumed-size arrays
Oct 7 2020, 2:43 PM