Page MenuHomePhabricator

klausler (Peter Klausler)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 11:45 AM (153 w, 4 d)

Recent Activity

Today

klausler added a comment to D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

Looks okay to me before lowering; please get @clementval to review that bit.

Mon, Mar 20, 8:07 AM · Restricted Project, Restricted Project

Thu, Mar 16

klausler added inline comments to D146224: [flang] Let double allocation error be catched by AllocatableAllocate.
Thu, Mar 16, 8:22 AM · Restricted Project, Restricted Project
klausler added inline comments to D146224: [flang] Let double allocation error be catched by AllocatableAllocate.
Thu, Mar 16, 8:15 AM · Restricted Project, Restricted Project

Wed, Mar 15

klausler accepted D146173: Flang cmake patch to handle LLVM_ENABLE_EH conflict (issue #59353).

LGTM and thanks!

Wed, Mar 15, 3:44 PM · Restricted Project, Restricted Project
klausler accepted D145960: [flang] add fused matmul-transpose to the runtime.
Wed, Mar 15, 12:17 PM · Restricted Project, Restricted Project
klausler added inline comments to D145960: [flang] add fused matmul-transpose to the runtime.
Wed, Mar 15, 12:17 PM · Restricted Project, Restricted Project
klausler added inline comments to D145960: [flang] add fused matmul-transpose to the runtime.
Wed, Mar 15, 12:03 PM · Restricted Project, Restricted Project

Tue, Mar 14

klausler added a comment to D145960: [flang] add fused matmul-transpose to the runtime.

Can the original MATMUL be extended in place as template(s) with one or two argument transposition flags, so that all the runtime APIs have a common implementation?

Tue, Mar 14, 12:46 PM · Restricted Project, Restricted Project

Mon, Mar 13

klausler committed rG7cc4e980e0f4: [flang] Accept non-interoperable LOGICAL scalar dummy arguments (authored by klausler).
[flang] Accept non-interoperable LOGICAL scalar dummy arguments
Mon, Mar 13, 5:59 PM · Restricted Project, Restricted Project
klausler closed D145968: [flang] Accept non-interoperable LOGICAL scalar dummy arguments.
Mon, Mar 13, 5:59 PM · Restricted Project, Restricted Project
klausler added a reviewer for D145968: [flang] Accept non-interoperable LOGICAL scalar dummy arguments: clementval.
Mon, Mar 13, 11:55 AM · Restricted Project, Restricted Project
klausler requested review of D145968: [flang] Accept non-interoperable LOGICAL scalar dummy arguments.
Mon, Mar 13, 11:06 AM · Restricted Project, Restricted Project

Fri, Mar 10

klausler committed rGa94083b511ee: [flang] Break shared library cyclic dependence (authored by klausler).
[flang] Break shared library cyclic dependence
Fri, Mar 10, 11:29 AM · Restricted Project, Restricted Project
klausler committed rG0a8a572c7ebc: [flang][runtime] EOF is recoverable only with END= or IOSTAT= (authored by klausler).
[flang][runtime] EOF is recoverable only with END= or IOSTAT=
Fri, Mar 10, 10:35 AM · Restricted Project, Restricted Project
klausler closed D145754: [flang][runtime] EOF is recoverable only with END= or IOSTAT=.
Fri, Mar 10, 10:35 AM · Restricted Project, Restricted Project
klausler committed rG9c3550f69a0d: [flang][runtime] Use Descriptor::Establish() in elemental derived type defined… (authored by klausler).
[flang][runtime] Use Descriptor::Establish() in elemental derived type defined…
Fri, Mar 10, 10:31 AM · Restricted Project, Restricted Project
klausler closed D145753: [flang][runtime] Use Descriptor::Establish() in elemental derived type defined assignment calls.
Fri, Mar 10, 10:30 AM · Restricted Project, Restricted Project
klausler committed rGf19c46d431f7: [flang][runtime] Iterate over array elements in user-defined derived type I/O (authored by klausler).
[flang][runtime] Iterate over array elements in user-defined derived type I/O
Fri, Mar 10, 10:26 AM · Restricted Project, Restricted Project
klausler closed D145752: [flang][runtime] Iterate over array elements in user-defined derived type I/O.
Fri, Mar 10, 10:25 AM · Restricted Project, Restricted Project
klausler committed rG79f6b8123568: [flang][runtime] Corrections to formatted child I/O (authored by klausler).
[flang][runtime] Corrections to formatted child I/O
Fri, Mar 10, 10:21 AM · Restricted Project, Restricted Project
klausler closed D145751: [flang][runtime] Corrections to formatted child I/O.
Fri, Mar 10, 10:21 AM · Restricted Project, Restricted Project
klausler committed rGfd4c958dc5b3: [flang] Correct handling of USE-associated generic override in nested scope (authored by klausler).
[flang] Correct handling of USE-associated generic override in nested scope
Fri, Mar 10, 10:09 AM · Restricted Project, Restricted Project
klausler closed D145750: [flang] Correct handling of USE-associated generic override in nested scope.
Fri, Mar 10, 10:09 AM · Restricted Project, Restricted Project
klausler committed rG17f32bdd3736: [flang] Fix checking of TBP bindings (authored by klausler).
[flang] Fix checking of TBP bindings
Fri, Mar 10, 9:59 AM · Restricted Project, Restricted Project
klausler closed D145749: [flang] Fix checking of TBP bindings.
Fri, Mar 10, 9:59 AM · Restricted Project, Restricted Project
klausler committed rGae426a054b0c: [flang] Detect obvious argument shape incompatibility when checking procedure… (authored by klausler).
[flang] Detect obvious argument shape incompatibility when checking procedure…
Fri, Mar 10, 9:49 AM · Restricted Project, Restricted Project
klausler closed D145748: [flang] Detect obvious argument shape incompatibility when checking procedure compatibility.
Fri, Mar 10, 9:49 AM · Restricted Project, Restricted Project
klausler committed rG085c1971ec58: [flang] Diagnose ridiculously large kind parameters (authored by klausler).
[flang] Diagnose ridiculously large kind parameters
Fri, Mar 10, 9:44 AM · Restricted Project, Restricted Project
klausler closed D145747: [flang] Diagnose ridiculously large kind parameters.
Fri, Mar 10, 9:44 AM · Restricted Project, Restricted Project
klausler committed rG199402c37863: [flang] Check dummy arguments of BIND(C) procedures (authored by klausler).
[flang] Check dummy arguments of BIND(C) procedures
Fri, Mar 10, 9:40 AM · Restricted Project, Restricted Project
klausler closed D145746: [flang] Check dummy arguments of BIND(C) procedures.
Fri, Mar 10, 9:40 AM · Restricted Project, Restricted Project
klausler committed rGa1db3e6274cf: [flang][runtime] Catch infinite unlimited format repetition better (authored by klausler).
[flang][runtime] Catch infinite unlimited format repetition better
Fri, Mar 10, 9:36 AM · Restricted Project, Restricted Project
klausler closed D145745: [flang][runtime] Catch infinite unlimited format repetition better.
Fri, Mar 10, 9:35 AM · Restricted Project, Restricted Project
klausler committed rGd38765604f93: [flang] Forward references to COMMON from specification expr under IMPLICIT NONE (authored by klausler).
[flang] Forward references to COMMON from specification expr under IMPLICIT NONE
Fri, Mar 10, 9:20 AM · Restricted Project, Restricted Project
klausler closed D145743: [flang] Forward references to COMMON from specification expr under IMPLICIT NONE.
Fri, Mar 10, 9:20 AM · Restricted Project, Restricted Project
klausler committed rG3c10eb4942d4: [flang] Check that a SELECT TYPE selector is not a procedure (authored by klausler).
[flang] Check that a SELECT TYPE selector is not a procedure
Fri, Mar 10, 9:09 AM · Restricted Project, Restricted Project
klausler closed D145742: [flang] Check that a SELECT TYPE selector is not a procedure.
Fri, Mar 10, 9:08 AM · Restricted Project, Restricted Project
klausler committed rGd84faa428ef0: [flang] Ignore FINAL subroutines with mismatching type parameters (authored by klausler).
[flang] Ignore FINAL subroutines with mismatching type parameters
Fri, Mar 10, 8:53 AM · Restricted Project, Restricted Project
klausler closed D145741: [flang] Ignore FINAL subroutines with mismatching type parameters.
Fri, Mar 10, 8:53 AM · Restricted Project, Restricted Project
klausler committed rGe6be8da14e92: [flang] Fix crash in folding TRANSFER() with MOLD=substring (authored by klausler).
[flang] Fix crash in folding TRANSFER() with MOLD=substring
Fri, Mar 10, 8:40 AM · Restricted Project, Restricted Project
klausler closed D145740: [flang] Fix crash in folding TRANSFER() with MOLD=substring.
Fri, Mar 10, 8:40 AM · Restricted Project, Restricted Project
klausler accepted D145768: [Flang] add space between number and character in print.
Fri, Mar 10, 8:11 AM · Restricted Project, Restricted Project

Thu, Mar 9

klausler requested review of D145754: [flang][runtime] EOF is recoverable only with END= or IOSTAT=.
Thu, Mar 9, 4:40 PM · Restricted Project, Restricted Project
klausler requested review of D145753: [flang][runtime] Use Descriptor::Establish() in elemental derived type defined assignment calls.
Thu, Mar 9, 4:39 PM · Restricted Project, Restricted Project
klausler requested review of D145752: [flang][runtime] Iterate over array elements in user-defined derived type I/O.
Thu, Mar 9, 4:39 PM · Restricted Project, Restricted Project
klausler requested review of D145751: [flang][runtime] Corrections to formatted child I/O.
Thu, Mar 9, 4:37 PM · Restricted Project, Restricted Project
klausler requested review of D145750: [flang] Correct handling of USE-associated generic override in nested scope.
Thu, Mar 9, 4:36 PM · Restricted Project, Restricted Project
klausler requested review of D145749: [flang] Fix checking of TBP bindings.
Thu, Mar 9, 4:35 PM · Restricted Project, Restricted Project
klausler requested review of D145748: [flang] Detect obvious argument shape incompatibility when checking procedure compatibility.
Thu, Mar 9, 4:34 PM · Restricted Project, Restricted Project
klausler requested review of D145747: [flang] Diagnose ridiculously large kind parameters.
Thu, Mar 9, 4:33 PM · Restricted Project, Restricted Project
klausler requested review of D145746: [flang] Check dummy arguments of BIND(C) procedures.
Thu, Mar 9, 4:32 PM · Restricted Project, Restricted Project
klausler requested review of D145745: [flang][runtime] Catch infinite unlimited format repetition better.
Thu, Mar 9, 4:31 PM · Restricted Project, Restricted Project
klausler requested review of D145743: [flang] Forward references to COMMON from specification expr under IMPLICIT NONE.
Thu, Mar 9, 4:30 PM · Restricted Project, Restricted Project
klausler requested review of D145742: [flang] Check that a SELECT TYPE selector is not a procedure.
Thu, Mar 9, 4:28 PM · Restricted Project, Restricted Project
klausler requested review of D145741: [flang] Ignore FINAL subroutines with mismatching type parameters.
Thu, Mar 9, 4:27 PM · Restricted Project, Restricted Project
klausler requested review of D145740: [flang] Fix crash in folding TRANSFER() with MOLD=substring.
Thu, Mar 9, 4:26 PM · Restricted Project, Restricted Project
klausler committed rG099a62e16ca3: [flang] Ensure "dtv" args passed by descriptor when polymorphic (authored by klausler).
[flang] Ensure "dtv" args passed by descriptor when polymorphic
Thu, Mar 9, 9:55 AM · Restricted Project, Restricted Project
klausler closed D145255: [flang] Ensure "dtv" args are passed by descriptor when polymorphic.
Thu, Mar 9, 9:55 AM · Restricted Project, Restricted Project
klausler committed rG392173da3d15: [flang] Ensure that CLASS(*) component descriptors have addenda (authored by klausler).
[flang] Ensure that CLASS(*) component descriptors have addenda
Thu, Mar 9, 9:52 AM · Restricted Project, Restricted Project
klausler closed D145248: [flang] Ensure that CLASS(*) component descriptors have addenda.
Thu, Mar 9, 9:51 AM · Restricted Project, Restricted Project

Wed, Mar 8

klausler accepted D145604: [flang] Adapt PointerIsAssociatedWith for empty derived-type.
Wed, Mar 8, 12:12 PM · Restricted Project, Restricted Project

Tue, Mar 7

klausler added a comment to D145481: [Flang] Combine `set_*Kind` functions with Macro.

The code is perfectly clear as is. The macro makes the header file messier without adding any real value.

Tue, Mar 7, 8:06 AM · Restricted Project, Restricted Project

Fri, Mar 3

klausler requested review of D145255: [flang] Ensure "dtv" args are passed by descriptor when polymorphic.
Fri, Mar 3, 9:56 AM · Restricted Project, Restricted Project
klausler requested review of D145248: [flang] Ensure that CLASS(*) component descriptors have addenda.
Fri, Mar 3, 8:29 AM · Restricted Project, Restricted Project

Thu, Mar 2

klausler committed rGbdbebef828da: [flang] Warn about inconsistent implicit interfaces (authored by klausler).
[flang] Warn about inconsistent implicit interfaces
Thu, Mar 2, 3:16 PM · Restricted Project, Restricted Project
klausler closed D145097: [flang] Warn about inconsistent implicit interfaces.
Thu, Mar 2, 3:16 PM · Restricted Project, Restricted Project
klausler committed rG057b6fb61f12: [flang] Fix CONTIGUOUS attribute for construct entities (authored by klausler).
[flang] Fix CONTIGUOUS attribute for construct entities
Thu, Mar 2, 2:07 PM · Restricted Project, Restricted Project
klausler closed D145114: [flang] Fix CONTIGUOUS attribute for construct entities.
Thu, Mar 2, 2:07 PM · Restricted Project, Restricted Project
klausler committed rGa183668ac6ce: [flang] Move check for statement function in BLOCK construct (authored by klausler).
[flang] Move check for statement function in BLOCK construct
Thu, Mar 2, 1:48 PM · Restricted Project, Restricted Project
klausler closed D145112: [flang] Move check for statement function in BLOCK construct.
Thu, Mar 2, 1:48 PM · Restricted Project, Restricted Project
klausler added a reviewer for D145097: [flang] Warn about inconsistent implicit interfaces: clementval.
Thu, Mar 2, 1:41 PM · Restricted Project, Restricted Project
klausler committed rG8489f1771383: [flang][runtime] Handle explicit-length character padding & truncation in… (authored by klausler).
[flang][runtime] Handle explicit-length character padding & truncation in…
Thu, Mar 2, 10:43 AM · Restricted Project, Restricted Project
klausler closed D145111: [flang][runtime] Handle explicit-length character padding & truncation in Assign().
Thu, Mar 2, 10:43 AM · Restricted Project, Restricted Project
klausler committed rGa3c6a7d53d21: [flang] Stricter interface compatibility checking for TBP overrides (authored by klausler).
[flang] Stricter interface compatibility checking for TBP overrides
Thu, Mar 2, 10:34 AM · Restricted Project, Restricted Project
klausler closed D145110: [flang] Stricter interface compatibility checking for TBP overrides.
Thu, Mar 2, 10:33 AM · Restricted Project, Restricted Project
klausler committed rG2216c4c6a4e2: [flang] Catch name conflict between generic TBP and inherited non-generic (authored by klausler).
[flang] Catch name conflict between generic TBP and inherited non-generic
Thu, Mar 2, 10:20 AM · Restricted Project, Restricted Project
klausler closed D145109: [flang] Catch name conflict between generic TBP and inherited non-generic.
Thu, Mar 2, 10:20 AM · Restricted Project, Restricted Project
klausler committed rG69e2665c8bcf: [flang] BIND(C,NAME=...) corrections (authored by klausler).
[flang] BIND(C,NAME=...) corrections
Thu, Mar 2, 10:10 AM · Restricted Project, Restricted Project
klausler closed D145107: [flang] BIND(C,NAME=...) corrections.
Thu, Mar 2, 10:10 AM · Restricted Project, Restricted Project
klausler committed rGbd87f2df4a97: [flang] Enforce prohibition against empty interoperable arrays (authored by klausler).
[flang] Enforce prohibition against empty interoperable arrays
Thu, Mar 2, 9:59 AM · Restricted Project, Restricted Project
klausler closed D145106: [flang] Enforce prohibition against empty interoperable arrays.
Thu, Mar 2, 9:58 AM · Restricted Project, Restricted Project
klausler committed rG702018022649: [flang] A TBP override may not make a public binding private (authored by klausler).
[flang] A TBP override may not make a public binding private
Thu, Mar 2, 9:55 AM · Restricted Project, Restricted Project
klausler closed D145104: [flang] A TBP override may not make a public binding private.
Thu, Mar 2, 9:55 AM · Restricted Project, Restricted Project
klausler committed rGe86bf46825d6: [flang] Disallow intrinsics and statement functions from generics (authored by klausler).
[flang] Disallow intrinsics and statement functions from generics
Thu, Mar 2, 9:51 AM · Restricted Project, Restricted Project
klausler closed D145103: [flang] Disallow intrinsics and statement functions from generics.
Thu, Mar 2, 9:51 AM · Restricted Project, Restricted Project
klausler committed rG5be7f8a666da: [flang] Catch attempt to misuse an abstract procedure in a generic interface (authored by klausler).
[flang] Catch attempt to misuse an abstract procedure in a generic interface
Thu, Mar 2, 9:46 AM · Restricted Project, Restricted Project
klausler closed D145102: [flang] Catch attempt to misuse an abstract procedure in a generic interface.
Thu, Mar 2, 9:46 AM · Restricted Project, Restricted Project
klausler committed rG41b5f3718550: [flang] Warn about violations of an obscure requirement (15.6.4 p2) (authored by klausler).
[flang] Warn about violations of an obscure requirement (15.6.4 p2)
Thu, Mar 2, 9:42 AM · Restricted Project, Restricted Project
klausler closed D145100: [flang] Warn about violations of an obscure requirement (15.6.4 p2).
Thu, Mar 2, 9:42 AM · Restricted Project, Restricted Project
klausler committed rGc6b9df0fbd7f: [flang] Refine procedure compatibility checking (authored by klausler).
[flang] Refine procedure compatibility checking
Thu, Mar 2, 9:32 AM · Restricted Project, Restricted Project
klausler closed D145094: [flang] Refine procedure compatibility checking.
Thu, Mar 2, 9:32 AM · Restricted Project, Restricted Project
klausler committed rGe0daa2ebd39c: [flang] Fix ISHFTC argument value check (authored by klausler).
[flang] Fix ISHFTC argument value check
Thu, Mar 2, 9:22 AM · Restricted Project, Restricted Project
klausler closed D145092: [flang] Fix ISHFTC argument value check.
Thu, Mar 2, 9:21 AM · Restricted Project, Restricted Project
klausler committed rGfee3f0bd4acb: [flang] Warn about dangerous actual argument association with TARGET dummy… (authored by klausler).
[flang] Warn about dangerous actual argument association with TARGET dummy…
Thu, Mar 2, 9:16 AM · Restricted Project, Restricted Project
klausler closed D145089: [flang] Warn about dangerous actual argument association with TARGET dummy arguments.
Thu, Mar 2, 9:16 AM · Restricted Project, Restricted Project

Wed, Mar 1

klausler updated the diff for D145100: [flang] Warn about violations of an obscure requirement (15.6.4 p2).

Fix a typo.

Wed, Mar 1, 2:05 PM · Restricted Project, Restricted Project
klausler updated the diff for D145106: [flang] Enforce prohibition against empty interoperable arrays.

Improve an error message per review comment.

Wed, Mar 1, 1:42 PM · Restricted Project, Restricted Project
klausler requested review of D145114: [flang] Fix CONTIGUOUS attribute for construct entities.
Wed, Mar 1, 1:06 PM · Restricted Project, Restricted Project
klausler added a reviewer for D145111: [flang][runtime] Handle explicit-length character padding & truncation in Assign(): clementval.
Wed, Mar 1, 12:59 PM · Restricted Project, Restricted Project
klausler requested review of D145112: [flang] Move check for statement function in BLOCK construct.
Wed, Mar 1, 12:58 PM · Restricted Project, Restricted Project