In D100897#2723303, @craig.rasmussen wrote:

I forgot to add that there is one test failing at the moment which makes no sense to me.

FAIL: flang-OldUnit :: Evaluate/folding.test (714 of 799)

Fix assignment to label.

Remove misleading DefaultCharacter typedef.

Remove debugging code

Would this option be used to extract debug/code-navigation info?

Yes, it's something related to mapping between symbols and source locations.

LGTM

In general, I don't think it's necessary to have tests specifically for the old driver. Testing the functionality they have in common is good enough. The two I pointed out are pretty trivial anyway.

-fget-symbols-sources is not a debug option, it's intended for integrating with IDEs like vscode. So I think the original name is better. Unlike the "dump" options it actually is an action and not something that is intended to produce debug output on the way to doing something else.

This is more a comment for D97207, but it's related to -module-dir: We probably don't need flang/test/Driver/write-module.f90 any more if it's tested in flang/test/Flang-Driver. In fact, I think we should get rid of all of the tests in flang/test/Driver and rename flang/test/Flang-Driver to flang/test/Driver.

In general, we've been using ALL_CAPS for template parameters and CamelCase for type names.

LGTM

Looks good to me.

It looks like there are other tests in Flang-Driver that can be run on f18 as well. That doesn't have to happen in this change if you prefer not to.

make sure that f18 is tested when FLANG_BUILD_NEW_DRIVER is set to Off

In D97164#2578602, @awarzynski wrote:

Thank you for submitting this Tim!

Would you mind adding the following in flang/test/Flang-Driver/write-module.f90 before merging? This way both -module-dir _and_ -J are tested.

! RUN: rm -rf %t && mkdir -p %t/dir-flang
! RUN: cd %t && %flang -fsyntax-only -J %t/dir-flang %s
! RUN: ls %t/dir-flang/testmodule.mod && not ls %t/testmodule.mod

Bring new driver test in sync with f18 driver test.

Remove f18 test from test/Flang-Driver/write-module.f90.
Clean up the rest of that test.

Please make sure the test works with f18 also.

LGTM