Page MenuHomePhabricator

tskeith (Tim Keith)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2019, 3:28 PM (23 w, 4 d)

Recent Activity

Yesterday

tskeith added a comment to D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable.

There was a recent discussion on when to use what mechanism, I will link here once I find it again. I want to paraphrase some comments ppl made on this in IRC:
"assert/llvm_unreachable if it can't happen. if it happens then either fix the code so it really doesn't happen or use report_runtime_error. if the error really can happen then use report_runtime_error"

Mon, Jun 1, 11:52 AM · Restricted Project

Sat, May 30

tskeith accepted D80794: [flang] Fix release build flags..
Sat, May 30, 10:03 AM · Restricted Project, Restricted Project

Fri, May 29

tskeith committed rG14f49599ccaf: [flang][NFC] Remove link-time dependency of Evaluate on Semantics (authored by tskeith).
[flang][NFC] Remove link-time dependency of Evaluate on Semantics
Fri, May 29, 4:58 PM
tskeith closed D80762: [flang][NFC] Remove link-time dependency of Evaluate on Semantics.
Fri, May 29, 4:58 PM · Restricted Project, Restricted Project
tskeith added a comment to D80794: [flang] Fix release build flags..

@tskeith Did you or perhaps @pmccormick report the original problem on mac?

Fri, May 29, 1:06 PM · Restricted Project, Restricted Project
tskeith added a comment to D80794: [flang] Fix release build flags..

This builds for me with clang 9 on macos and I'm seeing -O3 -DNDEBUG on the clang++ command line.

Fri, May 29, 7:34 AM · Restricted Project, Restricted Project
tskeith added a project to D80794: [flang] Fix release build flags.: Restricted Project.
Fri, May 29, 7:34 AM · Restricted Project, Restricted Project

Thu, May 28

tskeith created D80762: [flang][NFC] Remove link-time dependency of Evaluate on Semantics.
Thu, May 28, 2:52 PM · Restricted Project, Restricted Project

Tue, May 26

tskeith accepted D80593: [flang] Fixed crash on forward referenced `len` parameter.
Tue, May 26, 4:23 PM · Restricted Project, Restricted Project
tskeith added a project to D80593: [flang] Fixed crash on forward referenced `len` parameter: Restricted Project.
Tue, May 26, 4:23 PM · Restricted Project, Restricted Project
tskeith added a comment to D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable.

In release mode, where we do care about the performance of the Compiler's -fsyntax-only mode, these are compiled out allowing for more-aggressive optimization.

Tue, May 26, 11:25 AM · Restricted Project
tskeith accepted D80453: [flang] Fixes for problems with declaring procedure entities.
Tue, May 26, 10:17 AM · Restricted Project, Restricted Project
tskeith added a comment to D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable.

My understanding is that the behavior of llvm_unreachable is undefined in a Release build. If that's the case, this change makes things objectively worse for no benefit that I can see.

Tue, May 26, 9:12 AM · Restricted Project

Mon, May 25

tskeith added inline comments to D80453: [flang] Fixes for problems with declaring procedure entities.
Mon, May 25, 10:10 AM · Restricted Project, Restricted Project

Sat, May 23

tskeith added a comment to D80377: [flang] Google test infrastructure support for unittests.

Where is gtest_main found in your build?

It's in build/lib/libgtest_main.a

Sat, May 23, 12:43 PM · Restricted Project, Restricted Project
tskeith added a comment to D80377: [flang] Google test infrastructure support for unittests.

Where is it finding the gtest_main library? Is it built as part of llvm or coming from outside?

Googletest is built with LLVM, source should be in llvm-project/llvm/utils/unittest/googletest

Sat, May 23, 10:35 AM · Restricted Project, Restricted Project
tskeith added a comment to D80377: [flang] Google test infrastructure support for unittests.

When I try to build I get this error:

ld: library not found for -lgtest_main

Please update the README to indicate how to do the correct setup. A link to elsewhere in LLVM is fine.

I tried twice building the compiler in-tree on 2 different m/c. I couldn't reproduce the issue, here's how my cmake looks like:

cmake -G "Ninja"  -DCMAKE_INSTALL_PREFIX=../install/  -DCMAKE_BUILD_TYPE="Release"  -DLLVM_TARGETS_TO_BUILD=host -DLLVM_ENABLE_PROJECTS="mlir;flang" -DCMAKE_CXX_STANDARD=17 -DFLANG_INCLUDE_TESTS=ON ../llvm-project/llvm/
Sat, May 23, 7:55 AM · Restricted Project, Restricted Project

Fri, May 22

tskeith added a comment to D80377: [flang] Google test infrastructure support for unittests.

When I try to build I get this error:

ld: library not found for -lgtest_main
Fri, May 22, 7:28 AM · Restricted Project, Restricted Project

Thu, May 21

tskeith added a comment to D80377: [flang] Google test infrastructure support for unittests.

Would you pleave update the build and test instructions in flang/README.md?

Thu, May 21, 8:03 AM · Restricted Project, Restricted Project

Fri, May 15

tskeith accepted D79798: [flang] Constraint checks C751 to C760.
Fri, May 15, 2:42 PM · Restricted Project, Restricted Project
tskeith added inline comments to D79798: [flang] Constraint checks C751 to C760.
Fri, May 15, 1:37 PM · Restricted Project, Restricted Project
tskeith added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Fri, May 15, 7:34 AM · Restricted Project, Restricted Project

Tue, May 12

tskeith added inline comments to D79798: [flang] Constraint checks C751 to C760.
Tue, May 12, 4:42 PM · Restricted Project, Restricted Project
tskeith added inline comments to D79798: [flang] Constraint checks C751 to C760.
Tue, May 12, 3:37 PM · Restricted Project, Restricted Project

Mon, May 11

tskeith committed rG6f300105d21e: [flang] Fix bug with IMPORT of USE of USE (authored by tskeith).
[flang] Fix bug with IMPORT of USE of USE
Mon, May 11, 1:30 PM
tskeith closed D79737: [flang] Fix bug with IMPORT of USE of USE.
Mon, May 11, 1:30 PM · Restricted Project, Restricted Project
tskeith created D79737: [flang] Fix bug with IMPORT of USE of USE.
Mon, May 11, 12:22 PM · Restricted Project, Restricted Project
tskeith committed rG99aa87a5b537: [flang][NFC] Simplify semantics test scripts (authored by tskeith).
[flang][NFC] Simplify semantics test scripts
Mon, May 11, 11:51 AM
tskeith closed D79634: [flang][NFC] Simplify semantics test scripts.
Mon, May 11, 11:51 AM · Restricted Project, Restricted Project
tskeith accepted D79727: [flang] Fix for compilation problems caused by D79578.

Looks great

Mon, May 11, 10:45 AM · Restricted Project, Restricted Project

Sat, May 9

tskeith committed rGb05c8c5756e4: [flang] Make implicit conversion explicit in assignment (authored by tskeith).
[flang] Make implicit conversion explicit in assignment
Sat, May 9, 9:33 AM
tskeith closed D79637: [flang] Make implicit conversion explicit in assignment.
Sat, May 9, 9:33 AM · Restricted Project, Restricted Project

Fri, May 8

tskeith created D79637: [flang] Make implicit conversion explicit in assignment.
Fri, May 8, 11:14 AM · Restricted Project, Restricted Project
Herald added a reviewer for D79634: [flang][NFC] Simplify semantics test scripts: jdoerfert.
Fri, May 8, 9:37 AM · Restricted Project, Restricted Project

Thu, May 7

tskeith committed rG7ccc7e567249: [flang] Fix to IsDescriptor (authored by tskeith).
[flang] Fix to IsDescriptor
Thu, May 7, 7:55 AM
tskeith closed D79349: [flang] Fix to IsDescriptor.
Thu, May 7, 7:55 AM · Restricted Project, Restricted Project

Wed, May 6

tskeith accepted D78623: [flang] Semantic checks for SELECT RANK .
Wed, May 6, 7:53 PM · Restricted Project, Restricted Project
tskeith committed rG54b35c066417: [flang][NFC] Replace "align" with "alignment" (authored by tskeith).
[flang][NFC] Replace "align" with "alignment"
Wed, May 6, 3:20 PM
tskeith closed D79520: [flang][NFC] Replace "align" with "alignment".
Wed, May 6, 3:20 PM · Restricted Project, Restricted Project
tskeith created D79520: [flang][NFC] Replace "align" with "alignment".
Wed, May 6, 2:44 PM · Restricted Project, Restricted Project
tskeith committed rGd5c05ced82ff: [flang][NFC] Add accessors to equivalence and common blocks (authored by tskeith).
[flang][NFC] Add accessors to equivalence and common blocks
Wed, May 6, 12:27 PM
tskeith closed D79346: [flang][NFC] Add accessors to equivalence and common blocks.
Wed, May 6, 12:27 PM · Restricted Project, Restricted Project
tskeith committed rG237d0e3c0416: [flang] Handle EQUIVALENCE and COMMON in size and offset computations (authored by tskeith).
[flang] Handle EQUIVALENCE and COMMON in size and offset computations
Wed, May 6, 11:53 AM
tskeith closed D79347: [flang] Handle EQUIVALENCE and COMMON in size and offset computations.
Wed, May 6, 11:53 AM · Restricted Project, Restricted Project
tskeith added inline comments to D79347: [flang] Handle EQUIVALENCE and COMMON in size and offset computations.
Wed, May 6, 11:52 AM · Restricted Project, Restricted Project
tskeith requested changes to D78623: [flang] Semantic checks for SELECT RANK .
Wed, May 6, 8:02 AM · Restricted Project, Restricted Project
tskeith added a comment to D78623: [flang] Semantic checks for SELECT RANK .

Please mark comments as done when you have done something in response, and indicate what you did if it's not obvious.

Wed, May 6, 8:02 AM · Restricted Project, Restricted Project

Tue, May 5

tskeith committed rG0195b3a9098e: [flang] Fix bug in tests for standalone build (authored by tskeith).
[flang] Fix bug in tests for standalone build
Tue, May 5, 11:21 AM
tskeith closed D79327: [flang] Fix bug in tests for standalone build.
Tue, May 5, 11:21 AM · Restricted Project, Restricted Project
tskeith added inline comments to D79347: [flang] Handle EQUIVALENCE and COMMON in size and offset computations.
Tue, May 5, 9:41 AM · Restricted Project, Restricted Project

Mon, May 4

tskeith abandoned D79342: [flang] Fix cmake circular dependency error.

@stephenneuendorffer, thanks for taking care of this.

Mon, May 4, 4:09 PM · Restricted Project, Restricted Project
tskeith added a comment to D78306: [flang] Use LLVM's flags.

With this change is it possible to enable -Werror for flang (in an in-tree build) without enabling it for all of LLVM? Also, -pedantic?

Could you let us know why you think this is necessary when LLVM_ENABLE_WERROR and LLVM_ENABLE_PEDANTIC exist?

It's perfectly acceptable to stand up build bots that enable these two flags and enforce that those build bots always pass in master; I just really don't think we want these flags by default when new compiler releases after our own releases (and therefore completely out of our control) can cause build failures with these flags.

Mon, May 4, 1:26 PM · Restricted Project, Restricted Project
tskeith added a comment to D79342: [flang] Fix cmake circular dependency error.

@tskeith If I removed it I see these kind of error:

../../../../lib/libFortranEvaluate.a(characteristics.cpp.o):characteristics.cpp:function Fortran::evaluate::characteristics::TypeAndShape::AcquireShape(Fortran::semantics::ObjectEntityDetails const&) [clone .localalias.62]: error: undefined reference to 'Fortran::semantics::ArraySpec::IsDeferredShape() const'
../../../../lib/libFortranEvaluate.a(characteristics.cpp.o):characteristics.cpp:function Fortran::evaluate::characteristics::TypeAndShape::AcquireShape(Fortran::semantics::ObjectEntityDetails const&) [clone .localalias.62]: error: undefined reference to 'Fortran::semantics::ArraySpec::IsAssumedRank() const'
../../../../lib/libFortranEvaluate.a(characteristics.cpp.o):characteristics.cpp:function Fortran::evaluate::characteristics::TypeAndShape::AcquireShape(Fortran::semantics::ObjectEntityDetails const&) [clone .localalias.62]: error: undefined reference to 'Fortran::semantics::ArraySpec::IsAssumedShape() const'
../../../../lib/libFortranEvaluate.a(characteristics.cpp.o):characteristics.cpp:function Fortran::evaluate::characteristics::TypeAndShape::AcquireShape(Fortran::semantics::ObjectEntityDetails const&) [clone .localalias.62]: error: undefined reference to 'Fortran::semantics::ArraySpec::IsAssumedSize() const'
Mon, May 4, 1:26 PM · Restricted Project, Restricted Project
tskeith accepted D79345: [flang] Fix x87 binary->decimal.
Mon, May 4, 12:21 PM · Restricted Project, Restricted Project
tskeith added a comment to D78306: [flang] Use LLVM's flags.

With this change is it possible to enable -Werror for flang (in an in-tree build) without enabling it for all of LLVM? Also, -pedantic?

Mon, May 4, 11:48 AM · Restricted Project, Restricted Project
tskeith added a comment to D79342: [flang] Fix cmake circular dependency error.

@clementval, you added this dependency to fix a linking problem. If this change makes it come back, can you provide details? FortranEvaluate should not depend on FortranSemantics at link time.

Mon, May 4, 11:15 AM · Restricted Project, Restricted Project
tskeith added reviewers for D79342: [flang] Fix cmake circular dependency error: clementval, stephenneuendorffer.
Mon, May 4, 11:15 AM · Restricted Project, Restricted Project
tskeith created D79342: [flang] Fix cmake circular dependency error.
Mon, May 4, 11:15 AM · Restricted Project, Restricted Project
tskeith created D79327: [flang] Fix bug in tests for standalone build.
Mon, May 4, 7:59 AM · Restricted Project, Restricted Project
tskeith accepted D79263: [flang] New implementation for checks for constraints C741 through C750.
Mon, May 4, 7:27 AM · Restricted Project, Restricted Project
tskeith added a reviewer for D79263: [flang] New implementation for checks for constraints C741 through C750: klausler.
Mon, May 4, 7:27 AM · Restricted Project, Restricted Project
tskeith added a comment to D79092: [Flang][Driver]Add new flang driver main() entrypoint.

I like the idea of a cmake option as a temporary way to disable building the driver until the clang part can be properly extracted out. One shouldn't be forced to build all of clang just to build flang.

Mon, May 4, 7:27 AM · Restricted Project, Restricted Project

May 2 2020

tskeith accepted D79282: [flang] Fixed a crash.
May 2 2020, 1:14 PM · Restricted Project, Restricted Project

Apr 30 2020

tskeith added inline comments to D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added..
Apr 30 2020, 10:40 AM · Restricted Project, Restricted Project

Apr 29 2020

tskeith accepted D78160: [flang] Checks for constraints C741 through C750.
Apr 29 2020, 10:11 AM · Restricted Project, Restricted Project

Apr 28 2020

tskeith updated the summary of D78160: [flang] Checks for constraints C741 through C750.
Apr 28 2020, 11:17 AM · Restricted Project, Restricted Project

Apr 27 2020

tskeith added inline comments to D78160: [flang] Checks for constraints C741 through C750.
Apr 27 2020, 3:07 PM · Restricted Project, Restricted Project
tskeith requested changes to D78623: [flang] Semantic checks for SELECT RANK .
Apr 27 2020, 2:01 PM · Restricted Project, Restricted Project

Apr 24 2020

tskeith accepted D78834: Rework DATA statement semantics to use typed expressions.
Apr 24 2020, 3:44 PM · Restricted Project, Restricted Project
tskeith accepted D78826: [flang] More CHARACTER runtime support + unit test.
Apr 24 2020, 2:05 PM · Restricted Project, Restricted Project
tskeith added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 24 2020, 8:04 AM · Restricted Project, Restricted Project

Apr 23 2020

tskeith committed rGc353ebbfa4cb: [flang] Compute sizes and offsets for symbols (authored by tskeith).
[flang] Compute sizes and offsets for symbols
Apr 23 2020, 3:15 PM
tskeith closed D78680: [flang] Compute sizes and offsets for symbols.
Apr 23 2020, 3:15 PM · Restricted Project, Restricted Project
tskeith added inline comments to D78680: [flang] Compute sizes and offsets for symbols.
Apr 23 2020, 1:33 PM · Restricted Project, Restricted Project
tskeith updated the diff for D78680: [flang] Compute sizes and offsets for symbols.

Add Scope::GetSymbols to get symbols in canonical order.
compute-offsets.cpp and mod-file.cpp both need to process symbols in the
order in which they are declared. Move the collecting of those symbols
into Scope so that it can be shared.

Apr 23 2020, 1:33 PM · Restricted Project, Restricted Project
tskeith updated the diff for D78680: [flang] Compute sizes and offsets for symbols.

[flang] Compute sizes and offsets for symbols

Apr 23 2020, 1:03 PM · Restricted Project, Restricted Project
tskeith updated the diff for D78680: [flang] Compute sizes and offsets for symbols.

Add Scope::GetSymbols to get symbols in canonical order

Apr 23 2020, 12:28 PM · Restricted Project, Restricted Project
tskeith committed rG4ced7a48e68a: [flang] Remove unused variable (authored by tskeith).
[flang] Remove unused variable
Apr 23 2020, 9:44 AM
tskeith closed D78725: [flang] Remove unused variable.
Apr 23 2020, 9:44 AM · Restricted Project, Restricted Project
tskeith created D78725: [flang] Remove unused variable.
Apr 23 2020, 9:43 AM · Restricted Project, Restricted Project
tskeith committed rG9623003e9380: [flang][NFC] Refactor derived type instantiation (authored by tskeith).
[flang][NFC] Refactor derived type instantiation
Apr 23 2020, 8:38 AM
tskeith closed D78678: [flang][NFC] Refactor derived type instantiation.
Apr 23 2020, 8:38 AM · Restricted Project, Restricted Project
tskeith committed rG026d8807f439: [flang] Add missing check for unresolved name (authored by tskeith).
[flang] Add missing check for unresolved name
Apr 23 2020, 7:32 AM
tskeith closed D78685: [flang] Add missing check for unresolved name.
Apr 23 2020, 7:32 AM · Restricted Project, Restricted Project

Apr 22 2020

tskeith added a project to D78685: [flang] Add missing check for unresolved name: Restricted Project.
Apr 22 2020, 4:21 PM · Restricted Project, Restricted Project
tskeith created D78685: [flang] Add missing check for unresolved name.
Apr 22 2020, 4:21 PM · Restricted Project, Restricted Project
tskeith created D78680: [flang] Compute sizes and offsets for symbols.
Apr 22 2020, 3:48 PM · Restricted Project, Restricted Project
tskeith retitled D78680: [flang] Compute sizes and offsets for symbols from Compute sizes and offsets for symbols to [flang] Compute sizes and offsets for symbols.
Apr 22 2020, 3:48 PM · Restricted Project, Restricted Project
tskeith added reviewers for D78678: [flang][NFC] Refactor derived type instantiation: klausler, PeteSteinfeld.
Apr 22 2020, 3:48 PM · Restricted Project, Restricted Project
tskeith created D78678: [flang][NFC] Refactor derived type instantiation.
Apr 22 2020, 3:48 PM · Restricted Project, Restricted Project

Apr 21 2020

tskeith accepted D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 21 2020, 7:31 AM · Restricted Project, Restricted Project

Apr 20 2020

tskeith requested changes to D78160: [flang] Checks for constraints C741 through C750.
Apr 20 2020, 2:05 PM · Restricted Project, Restricted Project
tskeith added a comment to D78306: [flang] Use LLVM's flags.

I reverted back. After this is accepted I will make a new differential to change the default where it can be discussed.
This change allows MSVC builds to proceed further and I don't want this to be held back by a decision on the default for werror.

Apr 20 2020, 1:33 PM · Restricted Project, Restricted Project

Apr 19 2020

tskeith added a comment to D78215: [flang] Use the Flang cmake-functions to add targets..

It's a known issue, there is a circular dependency between FortranEvaluate and FortranParser.

Apr 19 2020, 7:12 PM · Restricted Project, Restricted Project

Apr 18 2020

tskeith requested changes to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 18 2020, 11:49 AM · Restricted Project, Restricted Project

Apr 16 2020

tskeith added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 4:10 PM · Restricted Project, Restricted Project
tskeith added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 11:41 AM · Restricted Project, Restricted Project
tskeith added inline comments to D78306: [flang] Use LLVM's flags.
Apr 16 2020, 10:35 AM · Restricted Project, Restricted Project

Apr 15 2020

tskeith added inline comments to D78215: [flang] Use the Flang cmake-functions to add targets..
Apr 15 2020, 8:33 PM · Restricted Project, Restricted Project
tskeith added inline comments to D78215: [flang] Use the Flang cmake-functions to add targets..
Apr 15 2020, 9:50 AM · Restricted Project, Restricted Project