Page MenuHomePhabricator

tskeith (Tim Keith)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2019, 3:28 PM (77 w, 3 d)

Recent Activity

Apr 28 2021

tskeith added a comment to D100897: [flang] Make 'team_number()' an intrinsic function.

I forgot to add that there is one test failing at the moment which makes no sense to me.

FAIL: flang-OldUnit :: Evaluate/folding.test (714 of 799)

Apr 28 2021, 11:15 AM · Restricted Project

Apr 23 2021

tskeith accepted D101126: [flang] Check for attributes specific to dummy arguments.
Apr 23 2021, 7:19 AM · Restricted Project, Restricted Project

Apr 22 2021

tskeith accepted D101111: [flang] (NFC) Break up flang/runtime/reduction.cpp.
Apr 22 2021, 3:15 PM · Restricted Project, Restricted Project
tskeith added inline comments to D101081: [flang] (NFC) Document Fortran feature history.
Apr 22 2021, 11:17 AM · Restricted Project, Restricted Project
tskeith added inline comments to D101081: [flang] (NFC) Document Fortran feature history.
Apr 22 2021, 11:16 AM · Restricted Project, Restricted Project

Apr 15 2021

tskeith added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 15 2021, 1:34 PM · Restricted Project, Restricted Project

Apr 14 2021

tskeith accepted D100494: [flang] Correct the interpretation of BIND(C,NAME='').
Apr 14 2021, 11:24 AM · Restricted Project, Restricted Project
tskeith added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Apr 14 2021, 7:19 AM · Restricted Project, Restricted Project

Apr 12 2021

tskeith committed rG50386fe1db3c: [flang] Fix narrowing warning on macos (authored by tskeith).
[flang] Fix narrowing warning on macos
Apr 12 2021, 9:41 AM
tskeith closed D100320: [flang] Fix narrowing warning on macos.
Apr 12 2021, 9:41 AM · Restricted Project, Restricted Project
tskeith requested review of D100320: [flang] Fix narrowing warning on macos.
Apr 12 2021, 9:31 AM · Restricted Project, Restricted Project

Apr 9 2021

tskeith accepted D100066: [flang] Accept & fold IEEE_SELECTED_REAL_KIND.
Apr 9 2021, 5:28 PM · Restricted Project, Restricted Project

Apr 7 2021

tskeith added inline comments to D100066: [flang] Accept & fold IEEE_SELECTED_REAL_KIND.
Apr 7 2021, 4:55 PM · Restricted Project, Restricted Project

Apr 2 2021

tskeith accepted D99799: [flang] TRANSFER() intrinsic function.
Apr 2 2021, 10:04 AM · Restricted Project, Restricted Project

Mar 29 2021

tskeith accepted D99342: [flang] Fix CHECK() calls on erroneous procedure declarations.
Mar 29 2021, 9:56 AM · Restricted Project, Restricted Project
tskeith added inline comments to D99292: [flang][driver] Add support for `-cpp/-nocpp`.
Mar 29 2021, 7:38 AM · Restricted Project, Restricted Project

Mar 26 2021

tskeith updated tskeith.
Mar 26 2021, 7:43 AM

Mar 25 2021

tskeith added inline comments to D99342: [flang] Fix CHECK() calls on erroneous procedure declarations.
Mar 25 2021, 4:39 PM · Restricted Project, Restricted Project
tskeith added inline comments to D99342: [flang] Fix CHECK() calls on erroneous procedure declarations.
Mar 25 2021, 11:28 AM · Restricted Project, Restricted Project
tskeith committed rG61a55c8812e7: [flang] Fix error compiling std::min on macos (authored by tskeith).
[flang] Fix error compiling std::min on macos
Mar 25 2021, 11:19 AM
tskeith closed D99340: [flang] Fix error compiling std::min on macos.
Mar 25 2021, 11:19 AM · Restricted Project, Restricted Project
tskeith requested review of D99340: [flang] Fix error compiling std::min on macos.
Mar 25 2021, 7:29 AM · Restricted Project, Restricted Project

Mar 24 2021

tskeith committed rG5d3249e9af90: [flang] Save binding labels as strings (authored by tskeith).
[flang] Save binding labels as strings
Mar 24 2021, 11:26 AM
tskeith closed D99208: [flang] Save binding labels as strings.
Mar 24 2021, 11:25 AM · Restricted Project, Restricted Project
tskeith updated the diff for D99208: [flang] Save binding labels as strings.

Fix assignment to label.

Mar 24 2021, 10:55 AM · Restricted Project, Restricted Project
tskeith reopened D99208: [flang] Save binding labels as strings.
Mar 24 2021, 10:55 AM · Restricted Project, Restricted Project
tskeith added a reverting change for rGeb4ad0e3e363: [flang] Save binding labels as strings: rGa76d0207d5f9: Revert "[flang] Save binding labels as strings".
Mar 24 2021, 9:49 AM
tskeith committed rGa76d0207d5f9: Revert "[flang] Save binding labels as strings" (authored by tskeith).
Revert "[flang] Save binding labels as strings"
Mar 24 2021, 9:49 AM
tskeith added a reverting change for D99208: [flang] Save binding labels as strings: rGa76d0207d5f9: Revert "[flang] Save binding labels as strings".
Mar 24 2021, 9:49 AM · Restricted Project, Restricted Project
tskeith committed rGeb4ad0e3e363: [flang] Save binding labels as strings (authored by tskeith).
[flang] Save binding labels as strings
Mar 24 2021, 8:53 AM
tskeith closed D99208: [flang] Save binding labels as strings.
Mar 24 2021, 8:52 AM · Restricted Project, Restricted Project

Mar 23 2021

tskeith added inline comments to D99208: [flang] Save binding labels as strings.
Mar 23 2021, 4:00 PM · Restricted Project, Restricted Project
tskeith updated the diff for D99208: [flang] Save binding labels as strings.

Remove misleading DefaultCharacter typedef.

Mar 23 2021, 3:59 PM · Restricted Project, Restricted Project
tskeith updated the diff for D99208: [flang] Save binding labels as strings.

Remove debugging code

Mar 23 2021, 1:22 PM · Restricted Project, Restricted Project
tskeith requested review of D99208: [flang] Save binding labels as strings.
Mar 23 2021, 12:49 PM · Restricted Project, Restricted Project

Mar 18 2021

tskeith accepted D98878: [flang] Refine symbol sorting.
Mar 18 2021, 11:12 AM · Restricted Project, Restricted Project

Mar 16 2021

tskeith accepted D98752: [flang] Fix build error (unused data member warning).
Mar 16 2021, 5:14 PM · Restricted Project, Restricted Project
tskeith added a comment to D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`.

Would this option be used to extract debug/code-navigation info?

Yes, it's something related to mapping between symbols and source locations.

Mar 16 2021, 9:14 AM · Restricted Project, Restricted Project

Mar 15 2021

tskeith committed rGbcf95cbb2ce4: [flang] Create intrinsics modules directory (contd.) (authored by tskeith).
[flang] Create intrinsics modules directory (contd.)
Mar 15 2021, 3:38 PM
tskeith committed rG566a2c18bf1f: [flang] Create intrinsics modules directory (authored by tskeith).
[flang] Create intrinsics modules directory
Mar 15 2021, 3:20 PM
tskeith added inline comments to D97119: [flang][driver] Add options for -std=f2018.
Mar 15 2021, 1:59 PM · Restricted Project, Restricted Project
tskeith committed rG8e1c09ee5f80: [flang] Build intrinsic .mod files in include/flang (authored by tskeith).
[flang] Build intrinsic .mod files in include/flang
Mar 15 2021, 8:04 AM
tskeith closed D98522: [flang] Build intrinsic .mod files in include/flang.
Mar 15 2021, 8:03 AM · Restricted Project, Restricted Project

Mar 12 2021

tskeith accepted D98568: [flang] Fix static build of flang.
Mar 12 2021, 5:33 PM · Restricted Project, Restricted Project
tskeith added inline comments to D97080: [flang][driver] Add -fintrinsic-modules-path option.
Mar 12 2021, 9:36 AM · Restricted Project, Restricted Project
tskeith added a reviewer for D98522: [flang] Build intrinsic .mod files in include/flang: arnamoy10.
Mar 12 2021, 9:33 AM · Restricted Project, Restricted Project
tskeith requested review of D98522: [flang] Build intrinsic .mod files in include/flang.
Mar 12 2021, 9:32 AM · Restricted Project, Restricted Project
tskeith added inline comments to D97080: [flang][driver] Add -fintrinsic-modules-path option.
Mar 12 2021, 6:25 AM · Restricted Project, Restricted Project

Mar 11 2021

tskeith added inline comments to D97080: [flang][driver] Add -fintrinsic-modules-path option.
Mar 11 2021, 3:09 PM · Restricted Project, Restricted Project
tskeith accepted D98430: [flang] Handle type-bound procedures with alternate returns.
Mar 11 2021, 9:08 AM · Restricted Project, Restricted Project

Mar 10 2021

tskeith accepted D98355: [flang] Fix call to CHECK() on overriding an erroneous type-bound procedure.
Mar 10 2021, 9:05 AM · Restricted Project, Restricted Project

Mar 9 2021

tskeith accepted D98225: [flang] Sort symbols by creation order.
Mar 9 2021, 10:36 AM · Restricted Project, Restricted Project
tskeith accepted D98257: [flang][driver] Merge test/Driver and test/Flang-Driver directories.

LGTM

Mar 9 2021, 9:57 AM · Restricted Project, Restricted Project
tskeith accepted D98256: [flang] Save AllocateObject and PointerObject analyzed expression.
Mar 9 2021, 9:45 AM · Restricted Project, Restricted Project
tskeith added a comment to D98257: [flang][driver] Merge test/Driver and test/Flang-Driver directories.

In general, I don't think it's necessary to have tests specifically for the old driver. Testing the functionality they have in common is good enough. The two I pointed out are pretty trivial anyway.

Mar 9 2021, 6:59 AM · Restricted Project, Restricted Project
tskeith added inline comments to D98225: [flang] Sort symbols by creation order.
Mar 9 2021, 6:49 AM · Restricted Project, Restricted Project

Mar 8 2021

tskeith added a comment to D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`.

-fget-symbols-sources is not a debug option, it's intended for integrating with IDEs like vscode. So I think the original name is better. Unlike the "dump" options it actually is an action and not something that is intended to produce debug output on the way to doing something else.

Mar 8 2021, 10:13 AM · Restricted Project, Restricted Project
tskeith accepted D97197: [flang][driver] Refine tests for module search directories.

This is more a comment for D97207, but it's related to -module-dir: We probably don't need flang/test/Driver/write-module.f90 any more if it's tested in flang/test/Flang-Driver. In fact, I think we should get rid of all of the tests in flang/test/Driver and rename flang/test/Flang-Driver to flang/test/Driver.

Mar 8 2021, 9:55 AM · Restricted Project, Restricted Project
tskeith accepted D98184: [flang] Fix bad dereference of NULLIFY pointer object.
Mar 8 2021, 9:02 AM · Restricted Project, Restricted Project

Mar 7 2021

tskeith added a comment to D97403: [flang] update character tests to use gtest.

In general, we've been using ALL_CAPS for template parameters and CamelCase for type names.

Mar 7 2021, 2:52 PM · Restricted Project, Restricted Project

Mar 6 2021

tskeith added inline comments to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Mar 6 2021, 3:08 PM · Restricted Project

Mar 5 2021

tskeith accepted D96875: [flang][driver] Add -fdebug-module-writer option.

LGTM

Mar 5 2021, 2:18 PM · Restricted Project

Mar 3 2021

tskeith added inline comments to D97774: [flang] Detect circularly defined interfaces of procedures.
Mar 3 2021, 3:24 PM · Restricted Project, Restricted Project

Feb 24 2021

tskeith accepted D97201: [flang] Detect circularly defined interfaces of procedures.

Looks good to me.

Feb 24 2021, 5:12 PM · Restricted Project, Restricted Project

Feb 23 2021

tskeith added inline comments to D97197: [flang][driver] Refine tests for module search directories.
Feb 23 2021, 9:07 AM · Restricted Project, Restricted Project
tskeith accepted D97207: [flang][test] Share all driver test dirs between `f18` and `flang-new`.
Feb 23 2021, 9:05 AM · Restricted Project, Restricted Project

Feb 22 2021

tskeith added inline comments to D97201: [flang] Detect circularly defined interfaces of procedures.
Feb 22 2021, 12:21 PM · Restricted Project, Restricted Project
tskeith added a comment to D97207: [flang][test] Share all driver test dirs between `f18` and `flang-new`.

It looks like there are other tests in Flang-Driver that can be run on f18 as well. That doesn't have to happen in this change if you prefer not to.

Feb 22 2021, 11:30 AM · Restricted Project, Restricted Project
tskeith added a comment to D97197: [flang][driver] Refine tests for module search directories.

make sure that f18 is tested when FLANG_BUILD_NEW_DRIVER is set to Off

Feb 22 2021, 9:16 AM · Restricted Project, Restricted Project
tskeith committed rG8720ec6b9a28: [flang] Add -J and -module-dir to f18 driver (authored by tskeith).
[flang] Add -J and -module-dir to f18 driver
Feb 22 2021, 9:04 AM
tskeith closed D97164: [flang] Add -J and -module-dir to f18 driver.
Feb 22 2021, 9:04 AM · Restricted Project, Restricted Project
tskeith added a comment to D97164: [flang] Add -J and -module-dir to f18 driver.

Thank you for submitting this Tim!

Would you mind adding the following in flang/test/Flang-Driver/write-module.f90 before merging? This way both -module-dir _and_ -J are tested.

! RUN: rm -rf %t && mkdir -p %t/dir-flang
! RUN: cd %t && %flang -fsyntax-only -J %t/dir-flang %s
! RUN: ls %t/dir-flang/testmodule.mod && not ls %t/testmodule.mod
Feb 22 2021, 9:02 AM · Restricted Project, Restricted Project
tskeith updated the diff for D97164: [flang] Add -J and -module-dir to f18 driver.

Bring new driver test in sync with f18 driver test.

Feb 22 2021, 9:00 AM · Restricted Project, Restricted Project

Feb 21 2021

tskeith updated the diff for D97164: [flang] Add -J and -module-dir to f18 driver.

Remove f18 test from test/Flang-Driver/write-module.f90.
Clean up the rest of that test.

Feb 21 2021, 8:47 PM · Restricted Project, Restricted Project
tskeith requested review of D97164: [flang] Add -J and -module-dir to f18 driver.
Feb 21 2021, 2:40 PM · Restricted Project, Restricted Project

Feb 20 2021

tskeith added a project to D97080: [flang][driver] Add -fintrinsic-modules-path option: Restricted Project.
Feb 20 2021, 2:55 PM · Restricted Project, Restricted Project
tskeith added a comment to D97119: [flang][driver] Add options for -std=f2018.

Please make sure the test works with f18 also.

Feb 20 2021, 10:35 AM · Restricted Project, Restricted Project

Feb 19 2021

tskeith retitled D97093: [flang] Making Scope::FindCommonBlock a const member from Making Scope::FindCommonBlock a const member to [flang] Making Scope::FindCommonBlock a const member.
Feb 19 2021, 2:50 PM · Restricted Project
tskeith added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Feb 19 2021, 7:21 AM · Restricted Project

Feb 18 2021

tskeith accepted D96982: [flang] Extension: forward refs to dummy args under IMPLICIT NONE.
Feb 18 2021, 12:04 PM · Restricted Project, Restricted Project
tskeith added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Feb 18 2021, 12:03 PM · Restricted Project
tskeith added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Feb 18 2021, 10:55 AM · Restricted Project

Feb 17 2021

tskeith accepted D96879: [flang] Warn about useless explicit typing of intrinsics.
Feb 17 2021, 12:35 PM · Restricted Project, Restricted Project
tskeith added inline comments to D96879: [flang] Warn about useless explicit typing of intrinsics.
Feb 17 2021, 11:14 AM · Restricted Project, Restricted Project
tskeith added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Feb 17 2021, 10:11 AM · Restricted Project
tskeith added inline comments to D96875: [flang][driver] Add -fdebug-module-writer option.
Feb 17 2021, 9:58 AM · Restricted Project

Feb 16 2021

tskeith accepted D96631: [flang] Detect circularly defined procedures.

LGTM

Feb 16 2021, 12:33 PM · Restricted Project, Restricted Project

Feb 15 2021

tskeith added inline comments to D96631: [flang] Detect circularly defined procedures.
Feb 15 2021, 11:03 AM · Restricted Project, Restricted Project
tskeith added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Feb 15 2021, 8:23 AM · Restricted Project

Feb 14 2021

tskeith added inline comments to D96631: [flang] Detect circularly defined procedures.
Feb 14 2021, 8:23 PM · Restricted Project, Restricted Project

Feb 11 2021

tskeith added inline comments to D96483: [flang][driver] Add options for unparsing.
Feb 11 2021, 8:09 AM · Restricted Project, Restricted Project

Feb 10 2021

tskeith retitled D96467: [flang] Cope with specific procedures with same name as generic from flang] Cope with specific procedures with same name as generic to [flang] Cope with specific procedures with same name as generic.
Feb 10 2021, 5:18 PM · Restricted Project, Restricted Project
tskeith accepted D96467: [flang] Cope with specific procedures with same name as generic.
Feb 10 2021, 5:17 PM · Restricted Project, Restricted Project
tskeith accepted D96466: [flang] Manage per-specification-part state better.
Feb 10 2021, 5:12 PM · Restricted Project, Restricted Project
tskeith accepted D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 10 2021, 9:13 AM · Restricted Project, Restricted Project
tskeith added inline comments to D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 10 2021, 8:53 AM · Restricted Project, Restricted Project

Feb 3 2021

tskeith accepted D95894: [flang] Fix calls to LBOUND() intrinsic for arrays with lower bounds not 1.
Feb 3 2021, 8:55 AM · Restricted Project, Restricted Project

Feb 2 2021

tskeith added inline comments to D95894: [flang] Fix calls to LBOUND() intrinsic for arrays with lower bounds not 1.
Feb 2 2021, 6:57 PM · Restricted Project, Restricted Project
tskeith accepted D95887: [flang] Add -fsyntax-only to f18; retain -fparse-only synonym.
Feb 2 2021, 12:49 PM · Restricted Project, Restricted Project

Feb 1 2021

tskeith added inline comments to D95448: [flang][driver] Add support for `-J/-module-dir`.
Feb 1 2021, 8:12 AM · Restricted Project, Restricted Project