Page MenuHomePhabricator

tskeith (Tim Keith)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2019, 3:28 PM (49 w, 6 d)

Recent Activity

Yesterday

tskeith committed rG86f59de13b80: [flang] Fix bugs related to merging generics during USE (authored by tskeith).
[flang] Fix bugs related to merging generics during USE
Wed, Dec 2, 3:14 PM
tskeith closed D92492: [flang] Fix bugs related to merging generics during USE.
Wed, Dec 2, 3:14 PM · Restricted Project, Restricted Project
tskeith added inline comments to D92492: [flang] Fix bugs related to merging generics during USE.
Wed, Dec 2, 3:13 PM · Restricted Project, Restricted Project
tskeith updated the diff for D92492: [flang] Fix bugs related to merging generics during USE.

Address review comments

Wed, Dec 2, 3:12 PM · Restricted Project, Restricted Project
tskeith committed rG1f525ece4abf: [flang][NFC] Add GetTopLevelUnitContaining functions (authored by tskeith).
[flang][NFC] Add GetTopLevelUnitContaining functions
Wed, Dec 2, 10:29 AM
tskeith closed D92491: [flang][NFC] Add GetTopLevelUnitContaining functions.
Wed, Dec 2, 10:29 AM · Restricted Project, Restricted Project
tskeith added inline comments to D92491: [flang][NFC] Add GetTopLevelUnitContaining functions.
Wed, Dec 2, 10:28 AM · Restricted Project, Restricted Project
tskeith added inline comments to D92492: [flang] Fix bugs related to merging generics during USE.
Wed, Dec 2, 10:28 AM · Restricted Project, Restricted Project
tskeith added a comment to D92492: [flang] Fix bugs related to merging generics during USE.

Note that this change depends on https://reviews.llvm.org/D92491

Wed, Dec 2, 9:19 AM · Restricted Project, Restricted Project
tskeith added reviewers for D92492: [flang] Fix bugs related to merging generics during USE: klausler, PeteSteinfeld.
Wed, Dec 2, 9:18 AM · Restricted Project, Restricted Project
tskeith added reviewers for D92491: [flang][NFC] Add GetTopLevelUnitContaining functions: klausler, PeteSteinfeld.
Wed, Dec 2, 9:18 AM · Restricted Project, Restricted Project
tskeith requested review of D92492: [flang] Fix bugs related to merging generics during USE.
Wed, Dec 2, 9:16 AM · Restricted Project, Restricted Project
tskeith requested review of D92491: [flang][NFC] Add GetTopLevelUnitContaining functions.
Wed, Dec 2, 9:15 AM · Restricted Project, Restricted Project

Wed, Nov 25

tskeith added inline comments to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Wed, Nov 25, 4:36 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Nov 21

tskeith removed a reviewer for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause: tskeith.
Sat, Nov 21, 6:09 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Nov 16

tskeith accepted D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Mon, Nov 16, 12:25 PM · Restricted Project, Restricted Project
tskeith accepted D91537: [flang][f18] Remove "-fdebug-resolve-names".
Mon, Nov 16, 7:38 AM · Restricted Project, Restricted Project

Fri, Nov 13

tskeith accepted D91440: [flang] Fix "EQ" comparison of arrays.
Fri, Nov 13, 2:31 PM · Restricted Project, Restricted Project
tskeith requested changes to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Fri, Nov 13, 1:31 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 12

tskeith accepted D91375: [flang] Include source information in an invalid file-unit-number message.
Thu, Nov 12, 1:07 PM · Restricted Project, Restricted Project

Wed, Nov 11

tskeith added a comment to D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

Probably IsModule and IsSubmodule have to be made inline.

Wed, Nov 11, 7:50 AM · Restricted Project, Restricted Project

Tue, Nov 10

tskeith accepted D91214: [flang] Use IMPLICIT from scope of external function reference.
Tue, Nov 10, 4:26 PM · Restricted Project, Restricted Project
tskeith added inline comments to D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages.
Tue, Nov 10, 4:25 PM · Restricted Project, Restricted Project

Oct 30 2020

tskeith accepted D90499: [flang] Plug error recovery hole for erroneous subscripts.
Oct 30 2020, 4:33 PM · Restricted Project, Restricted Project
tskeith accepted D90492: [flang] Better error messages & more cases caught for bad forward refs.
Oct 30 2020, 4:23 PM · Restricted Project, Restricted Project

Oct 23 2020

tskeith accepted D90049: [flang] Tighten rules to resolve procedure as intrinsic procedure.
Oct 23 2020, 9:21 AM · Restricted Project, Restricted Project

Oct 20 2020

tskeith accepted D89829: [flang] Fix call to CHECK() on erroneous subroutine declaration.
Oct 20 2020, 3:41 PM · Restricted Project, Restricted Project

Oct 19 2020

tskeith accepted D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 19 2020, 7:29 AM · Restricted Project, Restricted Project
tskeith accepted D89611: [flang] Add name match checks for interface procedures.
Oct 19 2020, 7:08 AM · Restricted Project, Restricted Project

Oct 17 2020

tskeith added inline comments to D89611: [flang] Add name match checks for interface procedures.
Oct 17 2020, 8:31 AM · Restricted Project, Restricted Project

Oct 16 2020

tskeith added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.
  1. Does the EnumToString function in the parser work for this enum value?
Oct 16 2020, 8:50 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2020

tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 15 2020, 7:32 AM · Restricted Project, Restricted Project

Oct 14 2020

tskeith added inline comments to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.
Oct 14 2020, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Oct 9 2020

tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 9 2020, 9:19 AM · Restricted Project, Restricted Project

Oct 5 2020

tskeith accepted D88688: [flang] Make binary->decimal conversion buffer sizes accurate.
Oct 5 2020, 11:38 AM · Restricted Project, Restricted Project
tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 5 2020, 9:19 AM · Restricted Project, Restricted Project

Oct 2 2020

tskeith added a comment to D88723: [flang] Fix build errors for clang-10.

FYI, the io-stmt.h warning is fixed in https://reviews.llvm.org/D88711 (with them all declared as class). The other change is still needed.

Oct 2 2020, 1:12 PM · Restricted Project, Restricted Project
tskeith committed rG11622d0fed8c: [flang][NFC] Fix mis-matched struct/class declarations (authored by tskeith).
[flang][NFC] Fix mis-matched struct/class declarations
Oct 2 2020, 1:09 PM
tskeith closed D88711: [flang][NFC] Fix mis-matched struct/class declarations.
Oct 2 2020, 1:09 PM · Restricted Project, Restricted Project
tskeith updated the diff for D88711: [flang][NFC] Fix mis-matched struct/class declarations.

Make them all class rather than struct.

Oct 2 2020, 1:08 PM · Restricted Project, Restricted Project
tskeith accepted D88723: [flang] Fix build errors for clang-10.
Oct 2 2020, 6:50 AM · Restricted Project, Restricted Project
tskeith added a project to D88723: [flang] Fix build errors for clang-10: Restricted Project.
Oct 2 2020, 6:50 AM · Restricted Project, Restricted Project

Oct 1 2020

tskeith added a comment to D88711: [flang][NFC] Fix mis-matched struct/class declarations.

The other specialization of this template is a class, though, so maybe the best fix is to change the earlier template struct to a class so that they all are so. I've got a fix on the way that does that, I think.

Oct 1 2020, 5:37 PM · Restricted Project, Restricted Project
tskeith retitled D88711: [flang][NFC] Fix mis-matched struct/class declarations from [flang] Fix mis-matched struct/class declarations to [flang][NFC] Fix mis-matched struct/class declarations.
Oct 1 2020, 4:53 PM · Restricted Project, Restricted Project
tskeith requested review of D88711: [flang][NFC] Fix mis-matched struct/class declarations.
Oct 1 2020, 4:51 PM · Restricted Project, Restricted Project
tskeith accepted D88695: [flang][msvc] Rework a MSVC work-around to avoid clang warning.
Oct 1 2020, 3:27 PM · Restricted Project, Restricted Project
tskeith accepted D88675: [flang] Fix WRITE after BACKSPACE.
Oct 1 2020, 10:10 AM · Restricted Project, Restricted Project

Sep 30 2020

tskeith accepted D88613: [flang] Semantic analysis for FINAL subroutines.
Sep 30 2020, 3:35 PM · Restricted Project, Restricted Project
tskeith added inline comments to D88613: [flang] Semantic analysis for FINAL subroutines.
Sep 30 2020, 1:50 PM · Restricted Project, Restricted Project
tskeith accepted D88606: [flang] Fix descriptor-based array data item I/O for list-directed CHARACTER & LOGICAL.
Sep 30 2020, 1:28 PM · Restricted Project, Restricted Project

Sep 28 2020

tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Sep 28 2020, 10:57 AM · Restricted Project, Restricted Project
tskeith added a project to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct.: Restricted Project.
Sep 28 2020, 9:27 AM · Restricted Project, Restricted Project

Sep 26 2020

tskeith committed rGc2921d148e7b: [flang] SAVE statement should not apply to nested scoping units (authored by rikigigi).
[flang] SAVE statement should not apply to nested scoping units
Sep 26 2020, 12:43 PM
tskeith closed D88279: SAVE statement should not apply to nested scoping units.
Sep 26 2020, 12:42 PM · Restricted Project, Restricted Project
tskeith added a comment to D88279: SAVE statement should not apply to nested scoping units.

Only a question: I don't have push access to the git repo (and it is my first patch), are you going to push it for me? Thanks

Sep 26 2020, 11:39 AM · Restricted Project, Restricted Project

Sep 25 2020

tskeith accepted D88279: SAVE statement should not apply to nested scoping units.
Sep 25 2020, 4:34 PM · Restricted Project, Restricted Project
tskeith updated subscribers of D88279: SAVE statement should not apply to nested scoping units.
Sep 25 2020, 7:53 AM · Restricted Project, Restricted Project

Sep 23 2020

tskeith added a project to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: Restricted Project.
Sep 23 2020, 9:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 18 2020

tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Sep 18 2020, 9:25 AM · Restricted Project, Restricted Project
tskeith requested changes to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Sep 18 2020, 9:11 AM · Restricted Project, Restricted Project

Sep 14 2020

tskeith accepted D87653: [flang] Respect BZ mode in exponent parts, too.
Sep 14 2020, 4:25 PM · Restricted Project, Restricted Project
tskeith accepted D87635: [flang] More clean-up of CookedSource API.
Sep 14 2020, 2:37 PM · Restricted Project, Restricted Project
tskeith accepted D87535: [flang] Fix bug for forward referenced type.

Looks good.

Sep 14 2020, 2:36 PM · Restricted Project, Restricted Project
tskeith committed rGce6dd973ac55: [flang] Fix analyzed form of type-bound assignment (authored by tskeith).
[flang] Fix analyzed form of type-bound assignment
Sep 14 2020, 10:00 AM
tskeith closed D87541: [flang] Fix analyzed form of type-bound assignment.
Sep 14 2020, 10:00 AM · Restricted Project, Restricted Project
tskeith committed rGed0abc8ad3f3: [flang] Correctly detect overlapping integer cases (authored by tskeith).
[flang] Correctly detect overlapping integer cases
Sep 14 2020, 9:11 AM
tskeith closed D87595: [flang] Correctly detect overlapping integer cases.
Sep 14 2020, 9:11 AM · Restricted Project, Restricted Project

Sep 13 2020

tskeith requested review of D87595: [flang] Correctly detect overlapping integer cases.
Sep 13 2020, 9:42 PM · Restricted Project, Restricted Project

Sep 11 2020

tskeith added inline comments to D87535: [flang] Fix bug for forward referenced type.
Sep 11 2020, 2:42 PM · Restricted Project, Restricted Project
tskeith requested review of D87541: [flang] Fix analyzed form of type-bound assignment.
Sep 11 2020, 12:33 PM · Restricted Project, Restricted Project
tskeith accepted D87505: [flang] Fix build issue with BUILD_SHARED_LIBS=ON.

Thanks for catching this.

Sep 11 2020, 7:18 AM · Restricted Project

Sep 10 2020

tskeith committed rG82edd428f185: [flang] Fix check for distinguishable operators/assignments (authored by tskeith).
[flang] Fix check for distinguishable operators/assignments
Sep 10 2020, 7:40 AM
tskeith closed D87341: [flang] Fix check for distinguishable operators/assignments.
Sep 10 2020, 7:40 AM · Restricted Project, Restricted Project
tskeith updated the diff for D87341: [flang] Fix check for distinguishable operators/assignments.
  • Use resolve96 for new test name
Sep 10 2020, 7:21 AM · Restricted Project, Restricted Project
tskeith abandoned D87411: [flang] Fix analyzed form of type-bound assignment.
Sep 10 2020, 7:10 AM · Restricted Project, Restricted Project
tskeith added a comment to D87411: [flang] Fix analyzed form of type-bound assignment.

Should you check that compilation-time resolution applies to monomorphic objects and NON_OVERRIDABLE bindings, but *not* to overridable bindings of polymorphic objects?

Sep 10 2020, 7:09 AM · Restricted Project, Restricted Project

Sep 9 2020

tskeith requested review of D87411: [flang] Fix analyzed form of type-bound assignment.
Sep 9 2020, 12:54 PM · Restricted Project, Restricted Project
tskeith updated the summary of D87341: [flang] Fix check for distinguishable operators/assignments.
Sep 9 2020, 9:48 AM · Restricted Project, Restricted Project
tskeith updated the diff for D87341: [flang] Fix check for distinguishable operators/assignments.
  • Improve error message
Sep 9 2020, 9:46 AM · Restricted Project, Restricted Project

Sep 8 2020

tskeith requested review of D87341: [flang] Fix check for distinguishable operators/assignments.
Sep 8 2020, 6:01 PM · Restricted Project, Restricted Project
tskeith added inline comments to D86425: [flang][msvc] Avoid range-based for over initializer_list. NFC..
Sep 8 2020, 8:11 AM · Restricted Project, Restricted Project
tskeith accepted D86556: [flang] Document DO CONCURRENT's problems.
Sep 8 2020, 8:06 AM · Restricted Project, Restricted Project
tskeith added a comment to D87083: [cmake] Use absolute paths for modules search.

This worked fine for me.

Sep 8 2020, 8:05 AM · Restricted Project, Restricted Project

Aug 28 2020

tskeith removed a reviewer for D86089: [flang][driver]Add experimental flang driver and frontend with help screen: tskeith.
Aug 28 2020, 3:17 PM · Restricted Project, Restricted Project, Restricted Project
tskeith committed rG627e9007eaba: [flang][NFC] Change how error symbols are recorded (authored by tskeith).
[flang][NFC] Change how error symbols are recorded
Aug 28 2020, 10:31 AM
tskeith closed D86740: [flang][NFC] Change how error symbols are recorded.
Aug 28 2020, 10:31 AM · Restricted Project, Restricted Project

Aug 27 2020

tskeith requested review of D86740: [flang][NFC] Change how error symbols are recorded.
Aug 27 2020, 2:46 PM · Restricted Project, Restricted Project

Aug 25 2020

tskeith accepted D86555: [flang] Parse global compiler directives.
Aug 25 2020, 10:50 AM · Restricted Project, Restricted Project

Aug 24 2020

tskeith committed rG044a71d828ca: [flang] Don't attempt to compute element size if no DynamicType (authored by tskeith).
[flang] Don't attempt to compute element size if no DynamicType
Aug 24 2020, 6:24 PM
tskeith closed D86484: [flang] Don't attempt to compute element size if no DynamicType.
Aug 24 2020, 6:23 PM · Restricted Project, Restricted Project
tskeith committed rGb8bfe3586eb8: [flang] Fix bug accessing implicit variable in specification expression (authored by tskeith).
[flang] Fix bug accessing implicit variable in specification expression
Aug 24 2020, 12:54 PM
tskeith closed D86322: [flang] Fix bug accessing implicit variable in specification expression.
Aug 24 2020, 12:54 PM · Restricted Project, Restricted Project
tskeith requested review of D86484: [flang] Don't attempt to compute element size if no DynamicType.
Aug 24 2020, 12:31 PM · Restricted Project, Restricted Project

Aug 22 2020

tskeith committed rGc0c3cafa2bda: [flang] Fix assert on bad character kind (authored by tskeith).
[flang] Fix assert on bad character kind
Aug 22 2020, 10:12 AM
tskeith closed D86357: [flang] Fix assert on bad character kind.
Aug 22 2020, 10:12 AM · Restricted Project, Restricted Project
tskeith added inline comments to D86322: [flang] Fix bug accessing implicit variable in specification expression.
Aug 22 2020, 10:10 AM · Restricted Project, Restricted Project
tskeith updated the summary of D86322: [flang] Fix bug accessing implicit variable in specification expression.
Aug 22 2020, 10:10 AM · Restricted Project, Restricted Project
tskeith updated the diff for D86322: [flang] Fix bug accessing implicit variable in specification expression.
  • Handle IMPLICIT NONE in host procedure
Aug 22 2020, 10:03 AM · Restricted Project, Restricted Project

Aug 21 2020

tskeith updated the diff for D86322: [flang] Fix bug accessing implicit variable in specification expression.

Address review comments

Aug 21 2020, 7:31 PM · Restricted Project, Restricted Project
tskeith requested review of D86357: [flang] Fix assert on bad character kind.
Aug 21 2020, 10:00 AM · Restricted Project, Restricted Project