This is an archive of the discontinued LLVM Phabricator instance.

[Alignment][NFC] Remove unneeded llvm:: scoping on Align types
ClosedPublic

Authored by gchatelet on Sep 27 2019, 1:43 AM.

Event Timeline

gchatelet created this revision.Sep 27 2019, 1:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2019, 1:43 AM
courbet added inline comments.Sep 27 2019, 1:50 AM
llvm/include/llvm/CodeGen/AsmPrinter.h
353

This works but is not ideal.

gchatelet updated this revision to Diff 222106.Sep 27 2019, 2:27 AM
  • Fix Align Align
  • Also fix llvm::Align(<literal>)
courbet added inline comments.Sep 27 2019, 2:47 AM
llvm/include/llvm/CodeGen/CallingConvLower.h
427–428

Given that this is a public API it would be better to have a meaningful name - maybe use Alignment in the API and rename to CheckedAlignment in the implementation ?

llvm/include/llvm/Support/OnDiskHashTable.h
211

remve llvm::

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
509

Alignment ?

2936–2937

ditto

gchatelet updated this revision to Diff 222139.Sep 27 2019, 5:22 AM
gchatelet marked 5 inline comments as done.
  • Address comments
courbet accepted this revision.Sep 27 2019, 5:43 AM
This revision is now accepted and ready to land.Sep 27 2019, 5:43 AM
gchatelet closed this revision.Sep 30 2019, 7:23 AM

Submitted as rL373081