Page MenuHomePhabricator

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (375 w, 2 d)

Recent Activity

Wed, May 31

courbet added inline comments to D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class.
Wed, May 31, 12:01 AM · Restricted Project, Restricted Project

Tue, May 30

courbet added inline comments to D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class.
Tue, May 30, 11:50 PM · Restricted Project, Restricted Project
courbet added inline comments to D151023: [llvm-exegesis] Add Target Memory Utility Functions.
Tue, May 30, 2:59 AM · Restricted Project, Restricted Project
courbet added inline comments to D151025: [llvm-exegesis] Add support for using memory annotations.
Tue, May 30, 2:59 AM · Restricted Project, Restricted Project
courbet added inline comments to D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class.
Tue, May 30, 2:45 AM · Restricted Project, Restricted Project

Wed, May 24

courbet committed rG32ffc55551fe: [clang-tidy] Really fix rG9182c679dde7 (authored by courbet).
[clang-tidy] Really fix rG9182c679dde7
Wed, May 24, 6:23 AM · Restricted Project, Restricted Project
courbet added a comment to D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors..

The release note references documentation that doesn't exist, so Sphinx is failing: https://lab.llvm.org/buildbot/#/builders/115/builds/46942

Wed, May 24, 6:20 AM · Restricted Project, Restricted Project
courbet committed rG62dc3ba8442f: [clang-tidy]Fix rG9182c679dde7cb6480e66b9231a53d43ad03908b (authored by courbet).
[clang-tidy]Fix rG9182c679dde7cb6480e66b9231a53d43ad03908b
Wed, May 24, 6:19 AM · Restricted Project, Restricted Project
courbet committed rG9182c679dde7: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&`… (authored by courbet).
[clang-tidy]performance-no-automatic-move: fix false negative on `const T&&`…
Wed, May 24, 6:06 AM · Restricted Project, Restricted Project
courbet closed D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors..
Wed, May 24, 6:05 AM · Restricted Project, Restricted Project
courbet accepted D151021: [llvm-exegesis] Introduce Subprocess Executor Mode.
Wed, May 24, 1:31 AM · Restricted Project, Restricted Project
courbet added inline comments to D151021: [llvm-exegesis] Introduce Subprocess Executor Mode.
Wed, May 24, 12:41 AM · Restricted Project, Restricted Project
courbet accepted D151020: [llvm-exegesis] Add ability to assign perf counters to specific PID.
Wed, May 24, 12:27 AM · Restricted Project, Restricted Project
courbet accepted D151019: [llvm-exegesis] Refactor FunctionExecutorImpl and create factory.
Wed, May 24, 12:25 AM · Restricted Project, Restricted Project

Mon, May 22

courbet updated the diff for D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors..

address review comments

Mon, May 22, 7:01 AM · Restricted Project, Restricted Project
courbet updated the diff for D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors..

fix release note placemenfix release note placement

Mon, May 22, 6:26 AM · Restricted Project, Restricted Project
courbet requested review of D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors..
Mon, May 22, 6:24 AM · Restricted Project, Restricted Project
courbet added inline comments to D151019: [llvm-exegesis] Refactor FunctionExecutorImpl and create factory.
Mon, May 22, 12:03 AM · Restricted Project, Restricted Project

Tue, May 16

courbet added inline comments to D150678: [libc][test] Improve memory check reporting.
Tue, May 16, 11:52 PM · Restricted Project, Restricted Project

Sun, May 14

courbet accepted D150536: [Docs][llvm-exegesis] Specify platform support for different modes.
Sun, May 14, 11:21 PM · Restricted Project, Restricted Project
courbet accepted D150453: [NFC] Refactor GlobalVariable Ctor.
Sun, May 14, 11:15 PM · Restricted Project, Restricted Project
courbet added inline comments to D150536: [Docs][llvm-exegesis] Specify platform support for different modes.
Sun, May 14, 11:02 PM · Restricted Project, Restricted Project
courbet accepted D149207: [llvm-exegesis] Create a proper LLVM IR Function for MachineFunctions.
Sun, May 14, 10:43 PM · Restricted Project, Restricted Project

Wed, May 10

courbet accepted D148516: [TableGen] Emit separate computeRequiredFeatures() function.
Wed, May 10, 1:02 AM · Restricted Project, Restricted Project
courbet accepted D148921: [llvm-exegesis] Use MCJIT only for execution.
Wed, May 10, 1:01 AM · Restricted Project, Restricted Project
courbet updated subscribers of D148921: [llvm-exegesis] Use MCJIT only for execution.
Wed, May 10, 12:55 AM · Restricted Project, Restricted Project
courbet updated subscribers of D148516: [TableGen] Emit separate computeRequiredFeatures() function.
Wed, May 10, 12:55 AM · Restricted Project, Restricted Project
courbet updated subscribers of D146304: [llvm-exegesis] Skip codegen of known-invalid snippets.
Wed, May 10, 12:54 AM · Restricted Project, Restricted Project
courbet updated subscribers of D149329: [llvm-exegesis] Dump generated snippets in assembler form.
Wed, May 10, 12:54 AM · Restricted Project, Restricted Project
courbet updated subscribers of D149327: [llvm-exegesis] Create snippet object files with predictable names.
Wed, May 10, 12:53 AM · Restricted Project, Restricted Project
courbet added inline comments to D149327: [llvm-exegesis] Create snippet object files with predictable names.
Wed, May 10, 12:53 AM · Restricted Project, Restricted Project
courbet accepted D146304: [llvm-exegesis] Skip codegen of known-invalid snippets.
Wed, May 10, 12:37 AM · Restricted Project, Restricted Project
courbet accepted D149819: [llvm-exegesis] Remove Assembler Tests.
Wed, May 10, 12:24 AM · Restricted Project, Restricted Project

Apr 21 2023

courbet added inline comments to D148921: [llvm-exegesis] Use MCJIT only for execution.
Apr 21 2023, 6:51 AM · Restricted Project, Restricted Project
courbet accepted D148807: [llvm-exegesis][AArch64] Only run tests on aarch64 hosts.

Let's submit this quick fix first and we can re-enable it after your other patch.

Apr 21 2023, 6:34 AM · Restricted Project, Restricted Project
courbet added a comment to D147776: [llvm-exegesis][AArch64] Handle OPERAND_UNKNOWN.

I wanted gchatelet@ to have a look at this, because he wrote the Instruction/Operand code. In particular, I'm wondering why we're not using the info on the actual Operand value rather than relying on the MCOperandInfo for the operand. Specifically, we do know that this is a register since we return true for isReg, so we could just bake this knowledge into getExplicitOperandInfo in a target-independant way.

Apr 21 2023, 4:25 AM · Restricted Project, Restricted Project

Apr 18 2023

courbet accepted D146303: [llvm-exegesis] Prevent llvm-exegesis from using unsupported opcodes.
Apr 18 2023, 7:53 AM · Restricted Project, Restricted Project
courbet added inline comments to D148516: [TableGen] Emit separate computeRequiredFeatures() function.
Apr 18 2023, 7:38 AM · Restricted Project, Restricted Project
courbet accepted D147700: [llvm-exegesis] Allow setting dump file name.
Apr 18 2023, 6:23 AM · Restricted Project, Restricted Project
courbet accepted D147926: [llvm-exegesis] Fix ifdefs in X86/Target.cpp.
Apr 18 2023, 6:22 AM · Restricted Project, Restricted Project

Apr 13 2023

courbet added inline comments to D147700: [llvm-exegesis] Allow setting dump file name.
Apr 13 2023, 4:25 AM · Restricted Project, Restricted Project

Apr 7 2023

courbet added inline comments to D137782: [clang-tidy]bugprone-fold-init-type.
Apr 7 2023, 7:12 AM · Restricted Project, Restricted Project
courbet committed rGd880d4e7c228: [doc][clang-tidy] Sort release notes by check name. (authored by courbet).
[doc][clang-tidy] Sort release notes by check name.
Apr 7 2023, 7:12 AM · Restricted Project, Restricted Project
courbet committed rG1012677284b8: [clang-tidy]bugprone-fold-init-type (authored by courbet).
[clang-tidy]bugprone-fold-init-type
Apr 7 2023, 5:17 AM · Restricted Project, Restricted Project
courbet closed D137782: [clang-tidy]bugprone-fold-init-type.
Apr 7 2023, 5:17 AM · Restricted Project, Restricted Project
courbet added a comment to D137782: [clang-tidy]bugprone-fold-init-type.

Thanks for the review.

Apr 7 2023, 5:16 AM · Restricted Project, Restricted Project
courbet added a reviewer for D147776: [llvm-exegesis][AArch64] Handle OPERAND_UNKNOWN: gchatelet.
Apr 7 2023, 4:35 AM · Restricted Project, Restricted Project
courbet added a comment to D146303: [llvm-exegesis] Prevent llvm-exegesis from using unsupported opcodes.

Thanks for the data. Can you get someone to approve that the size change is OK ? Otherwise LGTM for the exegesis part.

Apr 7 2023, 4:34 AM · Restricted Project, Restricted Project
courbet updated the diff for D137782: [clang-tidy]bugprone-fold-init-type.

Fix release note placement and phrase it more consistenly with other notes in that section.

Apr 7 2023, 12:58 AM · Restricted Project, Restricted Project

Apr 6 2023

courbet updated the diff for D137782: [clang-tidy]bugprone-fold-init-type.
  • Address review comments
  • Add release notes.
Apr 6 2023, 8:22 AM · Restricted Project, Restricted Project
courbet added inline comments to D147700: [llvm-exegesis] Allow setting dump file name.
Apr 6 2023, 5:01 AM · Restricted Project, Restricted Project
courbet added inline comments to D147700: [llvm-exegesis] Allow setting dump file name.
Apr 6 2023, 4:43 AM · Restricted Project, Restricted Project
courbet accepted D147699: [llvm-exegesis][AArch64] Add return statement at the end of the snippet correctly.
Apr 6 2023, 4:40 AM · Restricted Project, Restricted Project
courbet added a comment to D137782: [clang-tidy]bugprone-fold-init-type.

ping

Apr 6 2023, 1:41 AM · Restricted Project, Restricted Project

Apr 2 2023

courbet accepted D147156: [llvm-exegesis] Factor out DisassemblerHelper from the Analysis class.

No strong opinion on this, if you feel that's better that's fine with me.

Apr 2 2023, 11:17 PM · Restricted Project, Restricted Project
courbet accepted D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move..

Thanks for the patch.

Apr 2 2023, 11:09 PM · Restricted Project, Restricted Project

Mar 27 2023

courbet accepted D146964: [llvm-exegesis] if lit can't find llvm-exegesis, fail gracefully.
Mar 27 2023, 7:48 AM · Restricted Project, Restricted Project
courbet accepted D146890: [Docs][llvm-exegesis] Refactor snippet annotations in documentation.
Mar 27 2023, 12:49 AM · Restricted Project, Restricted Project
courbet accepted D146884: [llvm-exegesis] Refactor InstructionBenchmark to Benchmark.
Mar 27 2023, 12:47 AM · Restricted Project, Restricted Project
courbet added a comment to D146303: [llvm-exegesis] Prevent llvm-exegesis from using unsupported opcodes.

In principle I like that, however this has implications on the size of the various llvm binaries. Can you please measure the increase in binary size for e.g. clang ?

Mar 27 2023, 12:46 AM · Restricted Project, Restricted Project
courbet accepted D146302: [llvm-exegesis] Improve test flexibility by using available_features.

This is great, thanks for the patch.

Mar 27 2023, 12:43 AM · Restricted Project, Restricted Project

Mar 20 2023

courbet accepted D146301: [llvm-exegesis] Make possible to execute snippets without perf counters.
Mar 20 2023, 10:07 AM · Restricted Project, Restricted Project

Mar 19 2023

courbet added a comment to D146301: [llvm-exegesis] Make possible to execute snippets without perf counters.

Thanks. In principle that sounds goods, my only real remark is about what flags we use to communicate that intent to the tool.

Mar 19 2023, 11:50 PM · Restricted Project, Restricted Project

Mar 10 2023

courbet accepted D145763: llvm-exegesis: Only run X86 tests on X86 hosts.

I don't think JIT'ing X86 modules on SystemZ is supported.

Mar 10 2023, 1:24 AM · Restricted Project, Restricted Project

Mar 2 2023

courbet committed rG28eef3bd5bc7: [MCA] Fix crash in `EntryStage::cycleEnd` when there are no instructions. (authored by courbet).
[MCA] Fix crash in `EntryStage::cycleEnd` when there are no instructions.
Mar 2 2023, 4:43 AM · Restricted Project, Restricted Project

Feb 3 2023

courbet accepted D143271: [NFC] Simplify logic in ConstantFold.
Feb 3 2023, 7:24 AM · Restricted Project, Restricted Project

Jan 27 2023

courbet accepted D142708: [NFC] Transition GlobalObject alignment from MaybeAlign to Align.

This one is NFC, tag it as such ?

Jan 27 2023, 5:06 AM · Restricted Project, Restricted Project

Jan 24 2023

courbet added inline comments to D142459: [clang] Deprecate uses of GlobalObject::getAlignment.
Jan 24 2023, 5:56 AM · Restricted Project, Restricted Project, Restricted Project

Jan 23 2023

courbet abandoned D141925: [ASTMatchers] Add `isDirectInit` matcher..
Jan 23 2023, 6:45 AM · Restricted Project, Restricted Project
courbet updated the diff for D141925: [ASTMatchers] Add `isDirectInit` matcher..

add matcher to registry and add release note

Jan 23 2023, 6:41 AM · Restricted Project, Restricted Project
courbet added a comment to D141925: [ASTMatchers] Add `isDirectInit` matcher..

You also need to add the new matcher to Registry.cpp so it's usable from the dynamic matchers, and you should add a release note for the new matcher.

Jan 23 2023, 6:35 AM · Restricted Project, Restricted Project
courbet added a comment to D141925: [ASTMatchers] Add `isDirectInit` matcher..

ping

Jan 23 2023, 5:58 AM · Restricted Project, Restricted Project

Jan 17 2023

courbet updated the diff for D141925: [ASTMatchers] Add `isDirectInit` matcher..

Regenerate doc

Jan 17 2023, 6:10 AM · Restricted Project, Restricted Project
courbet updated the diff for D141925: [ASTMatchers] Add `isDirectInit` matcher..

fix doc

Jan 17 2023, 6:06 AM · Restricted Project, Restricted Project
courbet updated the diff for D141925: [ASTMatchers] Add `isDirectInit` matcher..

fix ddoc

Jan 17 2023, 5:56 AM · Restricted Project, Restricted Project
courbet requested review of D141925: [ASTMatchers] Add `isDirectInit` matcher..
Jan 17 2023, 5:55 AM · Restricted Project, Restricted Project

Jan 16 2023

courbet added a comment to D140271: [NFCI][llvm-exegesis] Benchmark: parallelize codegen (5x ... 8x less wallclock).

Are you seriously saying that 10x wallclock improvement is negligible?

10x speed improvement is not negligible. I'm simply questioning whether speed matters in this case.

If the speed improvement came at no cost, that would be a no-brainer. But there is a speed/readability tradeoff, which we need to evaluate.

All the changes here are to a single function,
that isn't really going to change further anyway.
It's not like this requires changes to many places.

Jan 16 2023, 7:30 AM · Restricted Project, Restricted Project
courbet added a comment to D140271: [NFCI][llvm-exegesis] Benchmark: parallelize codegen (5x ... 8x less wallclock).

Are you seriously saying that 10x wallclock improvement is negligible?

Jan 16 2023, 5:58 AM · Restricted Project, Restricted Project
courbet accepted D141840: Deprecate MemIntrinsicBase::getDestAlignment() and MemTransferBase::getSourceAlignment().
Jan 16 2023, 5:12 AM · Restricted Project, Restricted Project

Jan 13 2023

courbet accepted D141696: [NFC] Remove Function::getParamAlignment.
Jan 13 2023, 8:06 AM · Restricted Project, Restricted Project

Jan 11 2023

courbet accepted D141188: [MergeICmps] Adapt to non-eq comparisons.
Jan 11 2023, 7:45 AM · Restricted Project, Restricted Project
courbet added a comment to D140271: [NFCI][llvm-exegesis] Benchmark: parallelize codegen (5x ... 8x less wallclock).

Do we really need the speed boost ? My worry is that we are making the code more complex for a negligible advantage. I personally have never felt that waiting for a couple of minutes was really an issue, but you might have other use cases in mind ?

Jan 11 2023, 7:43 AM · Restricted Project, Restricted Project

Jan 9 2023

courbet added inline comments to D141188: [MergeICmps] Adapt to non-eq comparisons.
Jan 9 2023, 3:57 AM · Restricted Project, Restricted Project
courbet added inline comments to D141188: [MergeICmps] Adapt to non-eq comparisons.
Jan 9 2023, 3:43 AM · Restricted Project, Restricted Project

Jan 6 2023

courbet added a comment to D141134: [NFC] Only expose getXXXSize functions in TypeSize.

I think we should keep a single one, but just to bikeshed, a TypeSize has a Value, not a Size, so I would keep getFixedValue.

Jan 6 2023, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

Jan 4 2023

courbet accepted D140734: [exegesis] Analysis: filtering for benchmark results.

Nice, thanks.

Jan 4 2023, 9:18 AM · Restricted Project, Restricted Project
courbet accepted D140898: [llvm-exegesis] Remove functional test from unit tests.
Jan 4 2023, 2:33 AM · Restricted Project, Restricted Project
courbet added a comment to D140702: [exegesis] "Skip codegen" dry-run mode.

To be noted, i feel like it's a moot point to argue over the namings. It's mostly irrelevant in the long run.
What do @courbet @RKSimon think? I can change it any way that is agreed.

Jan 4 2023, 2:32 AM · Restricted Project, Restricted Project

Jan 3 2023

courbet added a comment to D140263: [NFC] Vastly simplifies TypeSize.

The code in this patch looks good to me, and I think it turned easier to read than the LinearPoly* abstractions. So unless there is a good reason to keep them, LGTM.

Jan 3 2023, 7:55 AM · Restricted Project, Restricted Project

Dec 19 2022

courbet added inline comments to D140263: [NFC] Vastly simplifies TypeSize.
Dec 19 2022, 4:55 AM · Restricted Project, Restricted Project

Dec 16 2022

courbet accepted D139110: [Alignment] Use Align in SectionRef::getAlignment().
Dec 16 2022, 4:05 AM · Restricted Project, Restricted Project

Dec 15 2022

courbet accepted D140098: [NFC] Use std::optional over llvm::Optional to implement MaybeAlign.
Dec 15 2022, 5:58 AM · Restricted Project, Restricted Project

Dec 13 2022

courbet accepted D139797: [exegesis] Benchmark: provide optional progress meter / ETA.
Dec 13 2022, 12:09 AM · Restricted Project, Restricted Project

Dec 12 2022

courbet accepted D139836: [Alignment][NFC] Remove deprecated GlobalObject::getAlignment.
Dec 12 2022, 5:42 AM · Restricted Project, Restricted Project
courbet accepted D139819: [Alignment][NFC] Use Align in MCSymbol::setCommon.
Dec 12 2022, 4:04 AM · Restricted Project, Restricted Project
courbet accepted D139826: [Alignment][NFC] MCSymbol::getCommonAlignment returns MaybeAlign, improve documentation..
Dec 12 2022, 4:03 AM · Restricted Project, Restricted Project
courbet added inline comments to D139797: [exegesis] Benchmark: provide optional progress meter / ETA.
Dec 12 2022, 4:02 AM · Restricted Project, Restricted Project
courbet added inline comments to D139797: [exegesis] Benchmark: provide optional progress meter / ETA.
Dec 12 2022, 3:54 AM · Restricted Project, Restricted Project
courbet added inline comments to D139797: [exegesis] Benchmark: provide optional progress meter / ETA.
Dec 12 2022, 3:52 AM · Restricted Project, Restricted Project

Dec 9 2022

courbet accepted D139614: [Alignment] Use Align in MCStreamer::emitCommonSymbol.
Dec 9 2022, 2:06 AM · Restricted Project, Restricted Project