Page MenuHomePhabricator
People courbet

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (156 w, 10 h)

Recent Activity
View All

Yesterday

courbet committed rG1cb643022892: Fix sanitizer failures for 356550. (authored by courbet).
Fix sanitizer failures for 356550.
Wed, Mar 20, 9:17 AM
courbet committed rL356568: Fix sanitizer failures for 356550..
Fix sanitizer failures for 356550.
Wed, Mar 20, 9:16 AM
courbet added a comment to rG238af52ded43: [ExpandMemCmp] Trigger on bcmp too..

Yes, definitely. I was doing a pass of where LibFunc_memcmp was used, and that looks like another place.
(note that most comparison chains to only have a few comparisons, so they will be expanded in ExpandMemCmp())

Wed, Mar 20, 6:46 AM
courbet added a comment to D59539: [llvm-exegesis] Option to lobotomize dbscan (PR40880).

This may or may not be a correct implementation of dbscan clustering algorithm.

Wed, Mar 20, 5:08 AM · Restricted Project
courbet committed rG238af52ded43: [ExpandMemCmp] Trigger on bcmp too. (authored by courbet).
[ExpandMemCmp] Trigger on bcmp too.
Wed, Mar 20, 4:53 AM
courbet committed rL356550: [ExpandMemCmp] Trigger on bcmp too..
[ExpandMemCmp] Trigger on bcmp too.
Wed, Mar 20, 4:53 AM
courbet closed D59593: [ExpandMemCmp] Trigger on bcmp too..
Wed, Mar 20, 4:53 AM · Restricted Project
courbet created D59593: [ExpandMemCmp] Trigger on bcmp too..
Wed, Mar 20, 3:11 AM · Restricted Project

Thu, Mar 14

courbet updated the diff for D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.

Address review comments.

Thu, Mar 14, 6:31 AM · Restricted Project
courbet added inline comments to D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.
Thu, Mar 14, 6:31 AM · Restricted Project
courbet created D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment.
Thu, Mar 14, 5:47 AM · Restricted Project

Wed, Mar 13

courbet accepted D59260: [DAGCombiner] If a TokenFactor would be merged into its user, consider the user later..

X86/constant-combiners.ll -- Optimizes out overlap between stores.

Wed, Mar 13, 8:41 AM · Restricted Project
courbet committed rG3bb5d0bb9b31: Re-land r354244 "[DAGCombiner] Eliminate dead stores to stack." (authored by courbet).
Re-land r354244 "[DAGCombiner] Eliminate dead stores to stack."
Wed, Mar 13, 6:56 AM
courbet committed rL356050: Re-land r354244 "[DAGCombiner] Eliminate dead stores to stack.".
Re-land r354244 "[DAGCombiner] Eliminate dead stores to stack."
Wed, Mar 13, 6:55 AM

Tue, Mar 12

courbet abandoned D56313: [SelectionDAG][RFC] Allow the user to specify a memeq function (v3)..
Tue, Mar 12, 12:29 AM · Restricted Project
courbet abandoned D56311: [SelectionDAG][RFC] Allow the user to specify a memeq function (v2)..
Tue, Mar 12, 12:29 AM · Restricted Project
courbet abandoned D56248: [SelectionDAG][RFC] Allow the user to specify a memeq function..
Tue, Mar 12, 12:29 AM · Restricted Project
courbet abandoned D56436: [SelectionDAG][RFC] Allow the user to specify a memeq function (v4)..
Tue, Mar 12, 12:29 AM · Restricted Project

Fri, Mar 8

courbet committed rGa3c43cfd63b3: [sanitizer] Update global_symbols.txt (authored by courbet).
[sanitizer] Update global_symbols.txt
Fri, Mar 8, 4:42 AM
courbet committed rCRT355692: [sanitizer] Update global_symbols.txt.
[sanitizer] Update global_symbols.txt
Fri, Mar 8, 4:41 AM
courbet committed rL355692: [sanitizer] Update global_symbols.txt.
[sanitizer] Update global_symbols.txt
Fri, Mar 8, 4:41 AM
courbet committed rG8e16d73346f8: [SelectionDAG] Allow the user to specify a memeq function. (authored by courbet).
[SelectionDAG] Allow the user to specify a memeq function.
Fri, Mar 8, 1:07 AM
courbet committed rL355672: [SelectionDAG] Allow the user to specify a memeq function..
[SelectionDAG] Allow the user to specify a memeq function.
Fri, Mar 8, 1:07 AM
courbet closed D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..
Fri, Mar 8, 1:07 AM · Restricted Project

Fri, Mar 1

courbet committed rGdd885eaf5f36: Reland "[compiler-rt] Intercept the bcmp() function." (authored by courbet).
Reland "[compiler-rt] Intercept the bcmp() function."
Fri, Mar 1, 8:44 AM
courbet committed rCRT355204: Reland "[compiler-rt] Intercept the bcmp() function.".
Reland "[compiler-rt] Intercept the bcmp() function."
Fri, Mar 1, 8:44 AM
courbet committed rL355204: Reland "[compiler-rt] Intercept the bcmp() function.".
Reland "[compiler-rt] Intercept the bcmp() function."
Fri, Mar 1, 8:44 AM
courbet added a comment to D57541: [DAGCombiner] Eliminate dead stores to stack..

I finally had time to track this down.

Fri, Mar 1, 7:21 AM · Restricted Project

Thu, Feb 28

courbet committed rG58724a61acf5: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives. (authored by courbet).
[clang-tidy] bugprone-string-integer-assignment: Reduce false positives.
Thu, Feb 28, 5:39 AM
courbet committed rL355089: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
[clang-tidy] bugprone-string-integer-assignment: Reduce false positives.
Thu, Feb 28, 5:39 AM
courbet committed rCTE355089: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
[clang-tidy] bugprone-string-integer-assignment: Reduce false positives.
Thu, Feb 28, 5:39 AM
courbet closed D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
Thu, Feb 28, 5:39 AM · Restricted Project, Restricted Project
courbet added a comment to D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..

Thanks.

Thu, Feb 28, 5:39 AM · Restricted Project, Restricted Project
courbet updated the diff for D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
  • rebase
  • -more cosmetics
Thu, Feb 28, 2:35 AM · Restricted Project, Restricted Project
courbet committed rGff5e4bcad0bb: [clang-tidy] misc-string-integer-assignment: fix false positive (authored by courbet).
[clang-tidy] misc-string-integer-assignment: fix false positive
Thu, Feb 28, 2:34 AM
courbet committed rCTE355076: [clang-tidy] misc-string-integer-assignment: fix false positive.
[clang-tidy] misc-string-integer-assignment: fix false positive
Thu, Feb 28, 2:34 AM
courbet committed rL355076: [clang-tidy] misc-string-integer-assignment: fix false positive.
[clang-tidy] misc-string-integer-assignment: fix false positive
Thu, Feb 28, 2:34 AM
courbet closed D58606: [clang-tidy] misc-string-integer-assignment: fix false positive.
Thu, Feb 28, 2:34 AM · Restricted Project, Restricted Project, Restricted Project
courbet added a comment to D58606: [clang-tidy] misc-string-integer-assignment: fix false positive.

is there a bug or similar? If yes please mention it somewhere in the summary or so and close it :)

Thu, Feb 28, 12:23 AM · Restricted Project, Restricted Project, Restricted Project
courbet updated the summary of D58606: [clang-tidy] misc-string-integer-assignment: fix false positive.
Thu, Feb 28, 12:22 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Feb 26

courbet committed rGea7bd2f0169e: [compiler-rt] Disable failing test on darwin during investigation. (authored by courbet).
[compiler-rt] Disable failing test on darwin during investigation.
Tue, Feb 26, 7:25 AM
courbet committed rCRT354888: [compiler-rt] Disable failing test on darwin during investigation..
[compiler-rt] Disable failing test on darwin during investigation.
Tue, Feb 26, 7:24 AM
courbet committed rL354888: [compiler-rt] Disable failing test on darwin during investigation..
[compiler-rt] Disable failing test on darwin during investigation.
Tue, Feb 26, 7:24 AM
courbet updated the diff for D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..
  • update realease notes
Tue, Feb 26, 6:59 AM · Restricted Project
courbet added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

Done, thanks for the review !

Tue, Feb 26, 6:59 AM · Restricted Project
courbet updated the diff for D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
  • cosmetics
Tue, Feb 26, 6:52 AM · Restricted Project, Restricted Project
courbet committed rG0ddf81c43d6f: [llvm-exegesis] Teach llvm-exegesis to handle instructions with multiple tied… (authored by courbet).
[llvm-exegesis] Teach llvm-exegesis to handle instructions with multiple tied…
Tue, Feb 26, 2:55 AM
courbet committed rL354862: [llvm-exegesis] Teach llvm-exegesis to handle instructions with multiple tied….
[llvm-exegesis] Teach llvm-exegesis to handle instructions with multiple tied…
Tue, Feb 26, 2:54 AM
courbet closed D58285: [llvm-exegesis] Teach llvm-exegesis to handle instructions with multiple tied variables..
Tue, Feb 26, 2:54 AM · Restricted Project
courbet added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

D58379 Is now submitted.

Tue, Feb 26, 2:43 AM · Restricted Project
courbet committed rGe6f22596e5de: [compiler-rt] disable asan bcmp tests on android. (authored by courbet).
[compiler-rt] disable asan bcmp tests on android.
Tue, Feb 26, 1:20 AM
courbet committed rL354853: [compiler-rt] disable asan bcmp tests on android..
[compiler-rt] disable asan bcmp tests on android.
Tue, Feb 26, 1:20 AM
courbet committed rCRT354853: [compiler-rt] disable asan bcmp tests on android..
[compiler-rt] disable asan bcmp tests on android.
Tue, Feb 26, 1:20 AM
courbet committed rGcb6b499fe6a7: [compiler-rt] Fix test broken by r354851. (authored by courbet).
[compiler-rt] Fix test broken by r354851.
Tue, Feb 26, 12:20 AM
courbet committed rCRT354852: [compiler-rt] Fix test broken by r354851..
[compiler-rt] Fix test broken by r354851.
Tue, Feb 26, 12:20 AM
courbet committed rL354852: [compiler-rt] Fix test broken by r354851..
[compiler-rt] Fix test broken by r354851.
Tue, Feb 26, 12:20 AM
courbet updated the diff for D58606: [clang-tidy] misc-string-integer-assignment: fix false positive.
  • add more tests
  • Traverse using decls.
Tue, Feb 26, 12:04 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Feb 25

courbet updated the diff for D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
  • more tests
Mon, Feb 25, 11:54 PM · Restricted Project, Restricted Project
courbet accepted D58626: [DAG] Fix constant store folding to handle non-byte sizes..
Mon, Feb 25, 11:51 PM · Restricted Project
courbet committed rG02b9b4e18dfb: [compiler-rt] Intercept the bcmp() function. (authored by courbet).
[compiler-rt] Intercept the bcmp() function.
Mon, Feb 25, 11:43 PM
courbet committed rCRT354851: [compiler-rt] Intercept the bcmp() function..
[compiler-rt] Intercept the bcmp() function.
Mon, Feb 25, 11:42 PM
courbet committed rL354851: [compiler-rt] Intercept the bcmp() function..
[compiler-rt] Intercept the bcmp() function.
Mon, Feb 25, 11:42 PM
courbet closed D58379: [compiler-rt] Intercept the bcmp() function..
Mon, Feb 25, 11:42 PM · Restricted Project, Restricted Project
courbet added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

Thanks for the review.

Mon, Feb 25, 11:41 PM · Restricted Project, Restricted Project
courbet added inline comments to D58626: [DAG] Fix constant store folding to handle non-byte sizes..
Mon, Feb 25, 8:04 AM · Restricted Project
courbet added a comment to D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..

Thanks.

Mon, Feb 25, 7:04 AM · Restricted Project, Restricted Project
courbet updated the diff for D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
  • address review comments
Mon, Feb 25, 7:04 AM · Restricted Project, Restricted Project
courbet committed rG4bfa716f7c52: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower (authored by courbet).
[clang-tidy] misc-string-integer-assignment: ignore toupper/tolower
Mon, Feb 25, 5:09 AM
courbet committed rCTE354780: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower.
[clang-tidy] misc-string-integer-assignment: ignore toupper/tolower
Mon, Feb 25, 5:08 AM
courbet committed rL354780: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower.
[clang-tidy] misc-string-integer-assignment: ignore toupper/tolower
Mon, Feb 25, 5:08 AM
courbet closed D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower.
Mon, Feb 25, 5:08 AM · Restricted Project, Restricted Project, Restricted Project
courbet added a comment to D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower.

Thanks.

Mon, Feb 25, 5:08 AM · Restricted Project, Restricted Project, Restricted Project
courbet created D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives..
Mon, Feb 25, 5:07 AM · Restricted Project, Restricted Project
courbet created D58606: [clang-tidy] misc-string-integer-assignment: fix false positive.
Mon, Feb 25, 4:27 AM · Restricted Project, Restricted Project, Restricted Project
courbet created D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower.
Mon, Feb 25, 3:58 AM · Restricted Project, Restricted Project, Restricted Project
courbet added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Mon, Feb 25, 1:59 AM · Restricted Project, Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • Refactor common code for memcmp and bcmp.
Mon, Feb 25, 1:56 AM · Restricted Project, Restricted Project
courbet accepted D58476: [llvm-exegesis] Split Epsilon param into two (PR40787).

This is nearly-free performance-wise.

Mon, Feb 25, 1:25 AM · Restricted Project
courbet added a comment to D58285: [llvm-exegesis] Teach llvm-exegesis to handle instructions with multiple tied variables..

ping

Mon, Feb 25, 12:12 AM · Restricted Project

Fri, Feb 22

courbet accepted D58468: [DAGCombine] Fold overlapping constant stores.
Fri, Feb 22, 7:22 AM · Restricted Project
courbet added a comment to D58468: [DAGCombine] Fold overlapping constant stores.

LGTM

Fri, Feb 22, 12:56 AM · Restricted Project

Thu, Feb 21

courbet committed rGa0321c23e82c: Re-land part of r354244 "[DAGCombiner] Eliminate dead stores to stack." (authored by courbet).
Re-land part of r354244 "[DAGCombiner] Eliminate dead stores to stack."
Thu, Feb 21, 5:00 AM
courbet committed rL354578: Re-land part of r354244 "[DAGCombiner] Eliminate dead stores to stack.".
Re-land part of r354244 "[DAGCombiner] Eliminate dead stores to stack."
Thu, Feb 21, 4:59 AM
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • Address review comments
  • clang-format
Thu, Feb 21, 12:20 AM · Restricted Project, Restricted Project
courbet added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

Thanks

Thu, Feb 21, 12:20 AM · Restricted Project, Restricted Project

Wed, Feb 20

courbet committed rG62b3b91ab2f6: Re-land the refactoring part of r354244 "[DAGCombiner] Eliminate dead stores to… (authored by courbet).
Re-land the refactoring part of r354244 "[DAGCombiner] Eliminate dead stores to…
Wed, Feb 20, 7:47 AM
courbet committed rL354476: Re-land the refactoring part of r354244 "[DAGCombiner] Eliminate dead stores to….
Re-land the refactoring part of r354244 "[DAGCombiner] Eliminate dead stores to…
Wed, Feb 20, 7:45 AM
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • Address review comments.
Wed, Feb 20, 2:21 AM · Restricted Project, Restricted Project
courbet added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Wed, Feb 20, 2:21 AM · Restricted Project, Restricted Project
courbet accepted D58355: [llvm-exegesis] Opcode stabilization / reclusterization (PR40715).
Wed, Feb 20, 12:44 AM · Restricted Project

Feb 19 2019

courbet added inline comments to D58355: [llvm-exegesis] Opcode stabilization / reclusterization (PR40715).
Feb 19 2019, 7:10 AM · Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • Add FreeBSD and OpenBSD.
Feb 19 2019, 5:02 AM · Restricted Project, Restricted Project
courbet added inline comments to D58355: [llvm-exegesis] Opcode stabilization / reclusterization (PR40715).
Feb 19 2019, 4:50 AM · Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • ifdef A || defined(B) -> if defined(A) || defined(B)
Feb 19 2019, 4:20 AM · Restricted Project, Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • guard with NetBSD
Feb 19 2019, 1:52 AM · Restricted Project, Restricted Project
courbet added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Feb 19 2019, 1:45 AM · Restricted Project, Restricted Project
courbet added a comment to D58379: [compiler-rt] Intercept the bcmp() function..
In D58379#1401986, @krytarowski wrote:

Please enable the tests for NetBSD as well.

<strings.h> should be included unconditionally.

Feb 19 2019, 1:39 AM · Restricted Project, Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • Unconditionally test bcmp() in weak_hook_test
Feb 19 2019, 1:38 AM · Restricted Project, Restricted Project
courbet updated the diff for D58379: [compiler-rt] Intercept the bcmp() function..
  • Enable bcmp interception on NetBSD.
Feb 19 2019, 1:21 AM · Restricted Project, Restricted Project
courbet added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

Please enable it for NetBSD.

Feb 19 2019, 1:21 AM · Restricted Project, Restricted Project