- User Since
- Mar 24 2016, 3:59 AM (199 w, 2 d)
Thu, Jan 2
Tue, Dec 31
Thanks. I'll wait for the other patch to be submitted and then change the binding.
Thu, Dec 19
Dec 18 2019
That is weird. If I understand the intel doc correctly, both these names refer to the same event (EventSel=A1H, UMask=01H). I have a haswell machine and dispatched worked (but I patched your change and I get the exact same results, which is to be expected given that the event is the same). What version of libpfm do you have ? I've seen both work on`4.10.1+git14-g815ff28-1`.
Dec 17 2019
Dec 16 2019
This makes the code easier to read indeed, but this comes at the expense of allocations and less locality, so I would refrain from doing this unless we have a good reason.
Or: gather some data in the codebase as to whether a template-parametric SmallBitVector would find other usages, implement it, and use it here as a 3rd parameter to PackedBitVector.
LGMT from the exegesis side. Disclaimer: I know nothing about MIPS.
Please also change the title of the patch, to avoid panic :)
Dec 12 2019
Dec 11 2019
Dec 10 2019
Dec 4 2019
Dec 2 2019
And add unit test.
Nov 25 2019
Nov 22 2019
Nov 21 2019
Thanks for the review.
Use LLVM style
Thanks for the review.
Use the right triple for big-endian thumb.
Rebase on thumb tests.
When zero-extending, check the legality of the zero-extended load.
Be conservative on ARM and do not introduce illegal BSWAPs when zero-extending.
rebase on NFC change
Nov 20 2019
Rebase to show test diffs.
Remove && warnings.
I'm going to remove the && warning from the check and keep only the const one, as I think these is a consensus on that.
Nov 19 2019
IMHO these two should just not overlap. It makes sense, to have controversial or configurable stuff in clang-tidy. It should just be consistent with the warnings, as those are "always right" and clang-tidy can be opinionated/specialized.
Adding @Quuxplusone (warning author) for opinions.
Actually, thinking more about this, adding this to the existing warning might not be a very consensual change. In the case of the warning:
Nov 18 2019
Fix markdown in doc.
Thanks for the comments
Nov 5 2019
No, we only have SSE2 and above.
Oct 31 2019
I don't remember cases where we had very large constant compares (though we do have quite a lot of small ones). I'll run our internal benchmarks with this change.