Can you please explain why the switch from MaybeAlign to Align is fine ? ARMTargetLowering::getABIAlignmentForCallingConv can switch from non-zero to 0 it seems.

Thanks.

Can you point to the tests that have anything interesting to look at ?

• Move mem passes after sanitizer passes.
• Move codegen test llvm/test/CodeGen/AArch64/bcmp-inline-small.ll to Transforms/ now that AArch64 expands memcmps.
• Rebase on r371397.

Thanks.

rebase

I rolled back due to some bot breakages that I was not able to see were related or not. I have not come back to it yet, will do.

Please change the name to [Alignment][NFC]

LGTM. Maybe let's way a couple days to see if @reames has blocking issues ?

Thanks!

FYI there are some benchmarks in https://reviews.llvm.org/D64082 that are not submitted but could be used as basis for making decisions for this patch.

Clarify top comment.

Add comment for buffer size.

Name magical constant.

Be evel less permissive as to what we allow the compiler to see.

In D64082#1566955, @spatel wrote:

Thanks for working on this! I'm not familiar with how the benchmarking framework works, so someone else should definitely have a look.

Does the framework automatically account for and filter out noisy results? I'm guessing that tiny memcmp() will have a lot of run-to-run variation.

Address review comments.

Thanks Roman.

test-suite benchmarks: https://reviews.llvm.org/D64082

For information, I had to roll this back at it breaks sanitizers. Sanitizer passes insert some nobuiltin attributes on all memcmp calls to prevent expansion and still be able to intercept them (maybeMarkSanitizerLibraryCallNoBuiltin), and these passes are added last in opt:

clang-format

I encourage adding small memcmp tests to test-suite as a follow-up, so we know that things won't break going forward.

Rebase on r364384.

Thanks.

Remove asm testing.

Split off options refactoring to r364281, rebase.

Ping. Any other concerns ?

Amazing work Roman ! A few nits on the form, I'll let others more knowledgeable about AMD architectures comment on the model itself.

Thanks for the review.