Page MenuHomePhabricator
People courbet

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (164 w, 5 d)

Recent Activity
View All

Today

courbet committed rG8361a10493c5: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only." (authored by courbet).
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
Tue, May 21, 7:24 AM
courbet committed rL361263: Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only.".
Revert r361257 "[MergeICmps][NFC] Make BCEAtom move-only."
Tue, May 21, 7:24 AM
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
In D60318#1509938, @RKSimon wrote:

@courbet Please can you ensure you have EXPENSIVE_CHECKS enabled in all your builds before going any further - you've been breaking the buildbots for well over a week now and you still haven't fixed the underlying issue.

Tue, May 21, 7:11 AM · Restricted Project
courbet created D62193: [MergeICmps] Make sorting strongly stable on the rhs..
Tue, May 21, 6:45 AM · Restricted Project
courbet committed rG8fa970c2d871: [MergeICmps][NFC] Make BCEAtom move-only. (authored by courbet).
[MergeICmps][NFC] Make BCEAtom move-only.
Tue, May 21, 6:33 AM
courbet committed rL361257: [MergeICmps][NFC] Make BCEAtom move-only..
[MergeICmps][NFC] Make BCEAtom move-only.
Tue, May 21, 6:31 AM
courbet committed rGa95d95d3922e: [MergeICmps] Preserve the dominator tree. (authored by courbet).
[MergeICmps] Preserve the dominator tree.
Tue, May 21, 4:02 AM
courbet committed rL361239: [MergeICmps] Preserve the dominator tree..
[MergeICmps] Preserve the dominator tree.
Tue, May 21, 4:01 AM
courbet closed D62068: [MergeICmps] Preserve the dominator tree..
Tue, May 21, 4:01 AM · Restricted Project
courbet added a comment to D62068: [MergeICmps] Preserve the dominator tree..

Thanks.

Tue, May 21, 2:25 AM · Restricted Project
courbet updated the diff for D62068: [MergeICmps] Preserve the dominator tree..

Address comments.

Tue, May 21, 2:25 AM · Restricted Project

Fri, May 17

courbet updated the diff for D62068: [MergeICmps] Preserve the dominator tree..

remove debug

Fri, May 17, 8:29 AM · Restricted Project
courbet created D62068: [MergeICmps] Preserve the dominator tree..
Fri, May 17, 8:27 AM · Restricted Project
courbet committed rG90900fbc9fdf: [MergeICmps][NFC] Add more debug. (authored by courbet).
[MergeICmps][NFC] Add more debug.
Fri, May 17, 5:06 AM
courbet committed rL361024: [MergeICmps][NFC] Add more debug..
[MergeICmps][NFC] Add more debug.
Fri, May 17, 5:05 AM
courbet committed rG632dfdda16bb: Re-land r360859: "[MergeICmps] Simplify the code." (authored by courbet).
Re-land r360859: "[MergeICmps] Simplify the code."
Fri, May 17, 2:42 AM
courbet committed rL361009: Re-land r360859: "[MergeICmps] Simplify the code.".
Re-land r360859: "[MergeICmps] Simplify the code."
Fri, May 17, 2:41 AM
courbet committed rG580ff1e72a14: [MergeICmps] Add test from PR41917. (authored by courbet).
[MergeICmps] Add test from PR41917.
Fri, May 17, 1:54 AM
courbet committed rL361001: [MergeICmps] Add test from PR41917..
[MergeICmps] Add test from PR41917.
Fri, May 17, 1:49 AM

Thu, May 16

courbet committed rG3a0e6e1c6c96: [DominatorTree] Print roots unconditionally in `print()`. (authored by courbet).
[DominatorTree] Print roots unconditionally in `print()`.
Thu, May 16, 5:48 AM
courbet committed rL360886: [DominatorTree] Print roots unconditionally in `print()`..
[DominatorTree] Print roots unconditionally in `print()`.
Thu, May 16, 5:47 AM
courbet closed D61999: [DominatorTree] Print roots unconditionally in `print()`..
Thu, May 16, 5:47 AM · Restricted Project
courbet added a comment to D61999: [DominatorTree] Print roots unconditionally in `print()`..

Thanks.

Thu, May 16, 5:47 AM · Restricted Project
courbet added a comment to D61999: [DominatorTree] Print roots unconditionally in `print()`..

Do we have a test for this? I don't think it is a problem but if we do we could update it. Otherwise, LGTM.

Thu, May 16, 5:47 AM · Restricted Project
courbet created D61999: [DominatorTree] Print roots unconditionally in `print()`..
Thu, May 16, 3:43 AM · Restricted Project

Wed, May 15

courbet committed rGc4fdd717efa4: Reland r360771 "[MergeICmps] Simplify the code." (authored by courbet).
Reland r360771 "[MergeICmps] Simplify the code."
Wed, May 15, 11:16 PM
courbet committed rL360859: Reland r360771 "[MergeICmps] Simplify the code.".
Reland r360771 "[MergeICmps] Simplify the code."
Wed, May 15, 11:16 PM
courbet committed rGeaf4413d2d9d: Revert r360771 "[MergeICmps] Simplify the code." (authored by courbet).
Revert r360771 "[MergeICmps] Simplify the code."
Wed, May 15, 7:21 AM
courbet committed rL360776: Revert r360771 "[MergeICmps] Simplify the code.".
Revert r360771 "[MergeICmps] Simplify the code."
Wed, May 15, 7:21 AM
courbet committed rG0d071be47486: [MergeICmps] Fix r360771. (authored by courbet).
[MergeICmps] Fix r360771.
Wed, May 15, 6:59 AM
courbet committed rL360775: [MergeICmps] Fix r360771..
[MergeICmps] Fix r360771.
Wed, May 15, 6:59 AM
courbet committed rG157ae639fa64: [MergeICmps] Simplify the code. (authored by courbet).
[MergeICmps] Simplify the code.
Wed, May 15, 6:05 AM
courbet committed rL360771: [MergeICmps] Simplify the code..
[MergeICmps] Simplify the code.
Wed, May 15, 6:04 AM
courbet closed D61736: [MergeICmps] Simplify the code..
Wed, May 15, 6:04 AM · Restricted Project
courbet added a comment to D61736: [MergeICmps] Simplify the code..

Thanks.

Wed, May 15, 5:58 AM · Restricted Project
courbet updated the diff for D61736: [MergeICmps] Simplify the code..

Cosmetics.

Wed, May 15, 5:58 AM · Restricted Project
courbet updated the diff for D61736: [MergeICmps] Simplify the code..
  • address comments
  • update tests with named blocks.
Wed, May 15, 5:16 AM · Restricted Project
courbet added a comment to D61736: [MergeICmps] Simplify the code..

Thanks, PTAL.

Wed, May 15, 5:16 AM · Restricted Project
courbet closed D58379: [compiler-rt] Intercept the bcmp() function..
Wed, May 15, 1:40 AM · Restricted Project, Restricted Project
courbet committed rGd9d0665d1c6b: [[DAGCombiner][NFC] Add a comment. (authored by courbet).
[[DAGCombiner][NFC] Add a comment.
Wed, May 15, 1:19 AM
courbet committed rL360755: [[DAGCombiner][NFC] Add a comment..
[[DAGCombiner][NFC] Add a comment.
Wed, May 15, 1:19 AM
courbet added inline comments to D61846: [DAGCombiner] Fix invalid alias analysis..
Wed, May 15, 1:19 AM · Restricted Project

Mon, May 13

courbet committed rG9afc4764dd24: [DAGCombiner] Fix invalid alias analysis. (authored by courbet).
[DAGCombiner] Fix invalid alias analysis.
Mon, May 13, 2:09 AM
courbet committed rL360566: [DAGCombiner] Fix invalid alias analysis..
[DAGCombiner] Fix invalid alias analysis.
Mon, May 13, 2:09 AM
courbet closed D61846: [DAGCombiner] Fix invalid alias analysis..
Mon, May 13, 2:09 AM · Restricted Project
courbet added a comment to D61846: [DAGCombiner] Fix invalid alias analysis..

Thanks.

Mon, May 13, 2:04 AM · Restricted Project
courbet added inline comments to D61846: [DAGCombiner] Fix invalid alias analysis..
Mon, May 13, 1:54 AM · Restricted Project
courbet updated the diff for D61846: [DAGCombiner] Fix invalid alias analysis..

Rebase.

Mon, May 13, 1:52 AM · Restricted Project
courbet committed rGc4e37fd9b298: [DAGCombiner][NFC] Commit test to show fix in D61846. (authored by courbet).
[DAGCombiner][NFC] Commit test to show fix in D61846.
Mon, May 13, 1:14 AM
courbet committed rL360561: [DAGCombiner][NFC] Commit test to show fix in D61846..
[DAGCombiner][NFC] Commit test to show fix in D61846.
Mon, May 13, 1:13 AM
courbet created D61846: [DAGCombiner] Fix invalid alias analysis..
Mon, May 13, 1:10 AM · Restricted Project

Thu, May 9

courbet updated the diff for D61736: [MergeICmps] Simplify the code..

Forgot two test files.

Thu, May 9, 8:42 AM · Restricted Project
courbet created D61736: [MergeICmps] Simplify the code..
Thu, May 9, 8:39 AM · Restricted Project
courbet retitled D61736: [MergeICmps] Simplify the code. from [MergeICmps][NFC] Re-generate tests with update_test_checks. to [MergeICmps][NFCI] Simplify the code..
Thu, May 9, 8:39 AM · Restricted Project
courbet retitled D61736: [MergeICmps] Simplify the code. from [MergeICmps][NFCI] Simplify the code. to [MergeICmps] Simplify the code..
Thu, May 9, 8:39 AM · Restricted Project
courbet committed rGfa18e6b080b8: [MergeICmps][NFC] Re-generate tests with update_test_checks. (authored by courbet).
[MergeICmps][NFC] Re-generate tests with update_test_checks.
Thu, May 9, 1:36 AM
courbet committed rL360319: [MergeICmps][NFC] Re-generate tests with update_test_checks..
[MergeICmps][NFC] Re-generate tests with update_test_checks.
Thu, May 9, 1:35 AM
courbet committed rGfb0f66ddb33d: [NFC] Fix typo. (authored by courbet).
[NFC] Fix typo.
Thu, May 9, 12:11 AM
courbet committed rL360314: [NFC] Fix typo..
[NFC] Fix typo.
Thu, May 9, 12:10 AM

Mon, May 6

courbet planned changes to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Thanks Eli.

Mon, May 6, 11:38 PM · Restricted Project
courbet added inline comments to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Mon, May 6, 8:09 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Fixing RUN lines for PowerPC opt tests.

Mon, May 6, 8:04 AM · Restricted Project
courbet accepted D61593: [NFC] Modernize repmovsb implementation of x86 memcpy..

Only nits.

Mon, May 6, 7:44 AM · Restricted Project
courbet added inline comments to D61593: [NFC] Modernize repmovsb implementation of x86 memcpy..
Mon, May 6, 7:16 AM · Restricted Project
courbet committed rG9e1f2a7fe758: [SimplifyLibCalls] Simplify bcmp too. (authored by courbet).
[SimplifyLibCalls] Simplify bcmp too.
Mon, May 6, 2:14 AM
courbet committed rL360021: [SimplifyLibCalls] Simplify bcmp too..
[SimplifyLibCalls] Simplify bcmp too.
Mon, May 6, 2:14 AM
courbet closed D61585: [SimplifyLibCalls] Simplify bcmp too..
Mon, May 6, 2:14 AM · Restricted Project
courbet updated the diff for D61585: [SimplifyLibCalls] Simplify bcmp too..

refactor

Mon, May 6, 1:50 AM · Restricted Project
courbet created D61585: [SimplifyLibCalls] Simplify bcmp too..
Mon, May 6, 12:52 AM · Restricted Project

Sun, May 5

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

ping

Sun, May 5, 11:34 PM · Restricted Project

Tue, Apr 30

courbet added inline comments to D61306: [NFC] Refactor visitIntrinsicCall so it doesn't return a const char*.
Tue, Apr 30, 6:32 AM · Restricted Project

Thu, Apr 25

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

@efriedma, @chandlerc, @hfinkel, @echristo: opinions ?

Thu, Apr 25, 12:57 AM · Restricted Project
courbet added inline comments to D60851: [llvm-exegesis] Insert IACA markers.
Thu, Apr 25, 12:49 AM · Restricted Project

Tue, Apr 23

courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
  • Move all tests out of CodeGen.
  • Update PowerPC tests.
  • Add EarlyCSE to addMemcmpPasses().
Tue, Apr 23, 8:25 AM · Restricted Project

Apr 17 2019

courbet added a comment to D60719: Demonstrate how to fix freestanding for memcpy.

As discussed offline, I think this should go through an RFC process.

Apr 17 2019, 1:37 AM · Restricted Project, Restricted Project

Apr 11 2019

courbet retitled D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline. from [ExpandMemCmp] Improve generated code for simple non-equality compares. to [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Apr 11 2019, 8:38 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Benchmark fixture:

Apr 11 2019, 8:31 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Benchmark results:

Apr 11 2019, 8:29 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

There is still some test fixing to do for Power, but before I do that I'd like to get your opinion on the approach, in particular regarding the pass placement (I pretty much placed it randomly here).

Apr 11 2019, 8:29 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

[ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.

Apr 11 2019, 8:20 AM · Restricted Project

Apr 10 2019

courbet accepted D60517: [llvm-exegesis] Fix serialization/deserialization of special NoRegister register (PR41448).

Thanks Roman.

Apr 10 2019, 11:56 PM · Restricted Project
courbet committed rG48e2eb0b2718: [NFC] Fix unused variable warning. (authored by courbet).
[NFC] Fix unused variable warning.
Apr 10 2019, 6:17 AM
courbet committed rL358080: [NFC] Fix unused variable warning..
[NFC] Fix unused variable warning.
Apr 10 2019, 6:16 AM
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Alternatively, what do you think about making ExpandMemCmp a late IR optimization pass like the vectorizer passes?

Apr 10 2019, 1:43 AM · Restricted Project

Apr 5 2019

courbet updated the summary of D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Apr 5 2019, 8:08 AM · Restricted Project
courbet created D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Apr 5 2019, 8:07 AM · Restricted Project
courbet committed rG1d8c9dfe03d4: [ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case. (authored by courbet).
[ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case.
Apr 5 2019, 8:02 AM
courbet committed rL357767: [ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case..
[ExpandMemCmp][NFC] Add tests for `memcmp(p, q, n) < 0` case.
Apr 5 2019, 8:02 AM
courbet accepted D60317: Add an option do not dump the generated object on disk.
Apr 5 2019, 8:01 AM · Restricted Project

Apr 3 2019

courbet added a comment to D60185: [X86] Make the post machine scheduler macrofusion-aware..

Are you sure ?

Apr 3 2019, 4:14 AM · Restricted Project
courbet updated subscribers of D60041: [X86] Merge the different CMOV instructions for each condition code into single instructions that store the condition code as an immediate..
In D60041#1452858, @RKSimon wrote:

@lebedev.ri and @courbet Are you happy with this and D60138?

Apr 3 2019, 2:51 AM · Restricted Project
courbet committed rG26a8ed3ac98a: [X86] Make the post machine scheduler macrofusion-aware. (authored by courbet).
[X86] Make the post machine scheduler macrofusion-aware.
Apr 3 2019, 2:38 AM
courbet committed rL357568: [X86] Make the post machine scheduler macrofusion-aware..
[X86] Make the post machine scheduler macrofusion-aware.
Apr 3 2019, 2:38 AM
courbet closed D60185: [X86] Make the post machine scheduler macrofusion-aware..
Apr 3 2019, 2:37 AM · Restricted Project
courbet added a comment to D60185: [X86] Make the post machine scheduler macrofusion-aware..

Thanks Andrea.

Apr 3 2019, 2:37 AM · Restricted Project
courbet created D60185: [X86] Make the post machine scheduler macrofusion-aware..
Apr 3 2019, 1:42 AM · Restricted Project
courbet committed rG5bfa946d6940: [X86][NFC] Add tests for misched macro-fusion. (authored by courbet).
[X86][NFC] Add tests for misched macro-fusion.
Apr 3 2019, 1:21 AM
courbet committed rL357565: [X86][NFC] Add tests for misched macro-fusion..
[X86][NFC] Add tests for misched macro-fusion.
Apr 3 2019, 1:21 AM

Apr 1 2019

courbet committed rG7e062c9b1f9a: [X86] Make post-ra scheduling macrofusion-aware. (authored by courbet).
[X86] Make post-ra scheduling macrofusion-aware.
Apr 1 2019, 6:48 AM
courbet committed rL357384: [X86] Make post-ra scheduling macrofusion-aware..
[X86] Make post-ra scheduling macrofusion-aware.
Apr 1 2019, 6:47 AM