Page MenuHomePhabricator

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (182 w, 4 d)

Recent Activity

Today

courbet accepted D67852: [Alignment] Get DataLayout::StackAlignment as Align.
Mon, Sep 23, 2:57 AM · Restricted Project

Yesterday

courbet added a comment to D67852: [Alignment] Get DataLayout::StackAlignment as Align.

Can you please explain why the switch from MaybeAlign to Align is fine ? ARMTargetLowering::getABIAlignmentForCallingConv can switch from non-zero to 0 it seems.

Sun, Sep 22, 11:55 PM · Restricted Project

Fri, Sep 20

courbet accepted D67836: [Alignment][NFC] Switch DataLayout private members to llvm::Align.
Fri, Sep 20, 8:14 AM · Restricted Project
courbet accepted D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.
Fri, Sep 20, 6:29 AM · Restricted Project

Wed, Sep 18

courbet accepted D67715: [Alignment][NFC] Align(1) to Align::None() conversions.
Wed, Sep 18, 9:17 AM · Restricted Project
courbet accepted D67620: [Alignment][NFC] Remove LogAlignment functions.
Wed, Sep 18, 8:39 AM · Restricted Project
courbet accepted D67704: [Alignment][NFC] Use Align::None instead of 1.
Wed, Sep 18, 6:26 AM · Restricted Project
courbet accepted D67697: [Alignment] Add a None() member function.
Wed, Sep 18, 1:48 AM · Restricted Project

Tue, Sep 17

courbet requested changes to D67620: [Alignment][NFC] Remove LogAlignment functions.
Tue, Sep 17, 2:19 AM · Restricted Project

Mon, Sep 16

courbet committed rG44bfbcc28e71: [X86][NFC] Add a `use-aa` feature. (authored by courbet).
[X86][NFC] Add a `use-aa` feature.
Mon, Sep 16, 7:07 AM
courbet committed rL371989: [X86][NFC] Add a `use-aa` feature..
[X86][NFC] Add a `use-aa` feature.
Mon, Sep 16, 7:04 AM
courbet closed D67266: [X86][NFC] Add a `use-aa` feature..
Mon, Sep 16, 7:04 AM · Restricted Project
courbet accepted D67616: [NFC] remove unused functions.
Mon, Sep 16, 6:45 AM · Restricted Project

Sun, Sep 15

courbet added a comment to D67266: [X86][NFC] Add a `use-aa` feature..

Thanks.

Sun, Sep 15, 11:23 PM · Restricted Project

Fri, Sep 13

courbet accepted D67486: [Alignment] Introduce llvm::Align to MCSection.
Fri, Sep 13, 2:25 AM · Restricted Project

Thu, Sep 12

courbet accepted D67499: [Alignment] Move OffsetToAlignment to Alignment.h.
Thu, Sep 12, 8:10 AM · Restricted Project, Restricted Project
courbet added inline comments to D67486: [Alignment] Introduce llvm::Align to MCSection.
Thu, Sep 12, 8:02 AM · Restricted Project
courbet added inline comments to D67499: [Alignment] Move OffsetToAlignment to Alignment.h.
Thu, Sep 12, 7:57 AM · Restricted Project, Restricted Project
courbet requested changes to D67486: [Alignment] Introduce llvm::Align to MCSection.
Thu, Sep 12, 7:43 AM · Restricted Project
courbet added inline comments to D67486: [Alignment] Introduce llvm::Align to MCSection.
Thu, Sep 12, 7:42 AM · Restricted Project

Wed, Sep 11

courbet accepted D67443: [Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment.
Wed, Sep 11, 6:24 AM · Restricted Project
courbet accepted D67433: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir parsing.
Wed, Sep 11, 3:56 AM · Restricted Project
courbet added a comment to D67433: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir parsing.

Can you point to the tests that have anything interesting to look at ?

Wed, Sep 11, 3:01 AM · Restricted Project

Tue, Sep 10

courbet added inline comments to D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.
Tue, Sep 10, 8:01 AM · Restricted Project
courbet committed rG30b5331df880: [clang][codegen][NFC] Make test patterns more permissive. (authored by courbet).
[clang][codegen][NFC] Make test patterns more permissive.
Tue, Sep 10, 7:20 AM
courbet committed rL371522: [clang][codegen][NFC] Make test patterns more permissive..
[clang][codegen][NFC] Make test patterns more permissive.
Tue, Sep 10, 7:18 AM
courbet committed rG664d9d2da27d: [ExpandMemCmp] Add lit.local.cfg (authored by courbet).
[ExpandMemCmp] Add lit.local.cfg
Tue, Sep 10, 3:00 AM
courbet committed rL371503: [ExpandMemCmp] Add lit.local.cfg.
[ExpandMemCmp] Add lit.local.cfg
Tue, Sep 10, 2:59 AM
courbet committed rG612c260ec3fe: Reland "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt… (authored by courbet).
Reland "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt…
Tue, Sep 10, 2:19 AM
courbet committed rL371502: Reland "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt….
Reland "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt…
Tue, Sep 10, 2:19 AM
courbet accepted D67386: [Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment.
Tue, Sep 10, 1:57 AM · Restricted Project
courbet accepted D67288: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment.
Tue, Sep 10, 1:54 AM · Restricted Project

Mon, Sep 9

courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
  • Move mem passes after sanitizer passes.
  • Move codegen test llvm/test/CodeGen/AArch64/bcmp-inline-small.ll to Transforms/ now that AArch64 expands memcmps.
  • Rebase on r371397.
Mon, Sep 9, 6:15 AM · Restricted Project
courbet committed rG388b9794b619: [Inliner][NFC] Make test less brittle. (authored by courbet).
[Inliner][NFC] Make test less brittle.
Mon, Sep 9, 6:08 AM
courbet committed rL371397: [Inliner][NFC] Make test less brittle..
[Inliner][NFC] Make test less brittle.
Mon, Sep 9, 6:08 AM
courbet closed D67349: [Inliner][NFC] Make test less brittle..
Mon, Sep 9, 6:07 AM · Restricted Project
courbet added a comment to D67349: [Inliner][NFC] Make test less brittle..

Thanks.

Mon, Sep 9, 6:06 AM · Restricted Project
courbet created D67349: [Inliner][NFC] Make test less brittle..
Mon, Sep 9, 5:40 AM · Restricted Project
courbet added inline comments to D67288: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment.
Mon, Sep 9, 2:41 AM · Restricted Project

Fri, Sep 6

courbet accepted D67267: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment.
Fri, Sep 6, 7:52 AM · Restricted Project
courbet accepted D67278: [Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment.
Fri, Sep 6, 7:46 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

rebase

Fri, Sep 6, 7:19 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

I rolled back due to some bot breakages that I was not able to see were related or not. I have not come back to it yet, will do.

Fri, Sep 6, 7:16 AM · Restricted Project
courbet created D67266: [X86][NFC] Add a `use-aa` feature..
Fri, Sep 6, 5:41 AM · Restricted Project
courbet accepted D67229: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment.
Fri, Sep 6, 5:14 AM · Restricted Project

Thu, Sep 5

courbet accepted D67226: [Alignment][NFC] Change internal representation of TargetLowering.h.

Please change the name to [Alignment][NFC]

Thu, Sep 5, 7:53 AM · Restricted Project
courbet accepted D67223: [LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align.
Thu, Sep 5, 6:01 AM · Restricted Project
courbet added inline comments to D67223: [LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align.
Thu, Sep 5, 5:43 AM · Restricted Project

Mon, Aug 26

courbet committed rL369888: [MemFunctions] Add c++11 flag..
[MemFunctions] Add c++11 flag.
Mon, Aug 26, 3:00 AM

Aug 23 2019

courbet accepted D66691: [LLVM][NFC] Removing unused functions.
Aug 23 2019, 4:14 PM · Restricted Project
courbet accepted D66683: [LLVM][NFC] remove unused fields.
Aug 23 2019, 1:46 PM · Restricted Project
courbet accepted D61144: [LoopIdiomRecognize] BCmp loop idiom recognition.

LGTM. Maybe let's way a couple days to see if @reames has blocking issues ?

Aug 23 2019, 10:16 AM · Restricted Project

Aug 22 2019

courbet committed rL369707: [MemFunctions] Add microbenchmarks for memory functions..
[MemFunctions] Add microbenchmarks for memory functions.
Aug 22 2019, 2:24 PM
courbet closed D64082: [MemFunctions] Add microbenchmarks for memory functions..
Aug 22 2019, 2:24 PM · Restricted Project
courbet added a comment to D64082: [MemFunctions] Add microbenchmarks for memory functions..

Thanks!

Aug 22 2019, 2:24 PM · Restricted Project
courbet added inline comments to D61144: [LoopIdiomRecognize] BCmp loop idiom recognition.
Aug 22 2019, 2:24 PM · Restricted Project
courbet added inline comments to D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Aug 22 2019, 2:24 PM · Restricted Project

Jul 18 2019

courbet added a comment to D64805: [AArch64] Expand bcmp() for small comparisons.

FYI there are some benchmarks in https://reviews.llvm.org/D64082 that are not submitted but could be used as basis for making decisions for this patch.

Jul 18 2019, 6:19 AM · Restricted Project

Jul 3 2019

courbet added inline comments to D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 3 2019, 5:29 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Clarify top comment.

Jul 3 2019, 5:29 AM · Restricted Project
courbet added inline comments to D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 3 2019, 5:15 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Add comment for buffer size.

Jul 3 2019, 5:12 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Name magical constant.

Jul 3 2019, 5:10 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Be evel less permissive as to what we allow the compiler to see.

Jul 3 2019, 3:50 AM · Restricted Project
courbet added inline comments to D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 3 2019, 3:50 AM · Restricted Project
courbet added a reviewer for D64082: [MemFunctions] Add microbenchmarks for memory functions.: lebedev.ri.
Jul 3 2019, 2:36 AM · Restricted Project
courbet added a comment to D64082: [MemFunctions] Add microbenchmarks for memory functions..

Thanks for working on this! I'm not familiar with how the benchmarking framework works, so someone else should definitely have a look.

Does the framework automatically account for and filter out noisy results? I'm guessing that tiny memcmp() will have a lot of run-to-run variation.

Jul 3 2019, 2:36 AM · Restricted Project
courbet updated the diff for D64082: [MemFunctions] Add microbenchmarks for memory functions..

Address review comments.

Jul 3 2019, 2:36 AM · Restricted Project
courbet added a comment to D64082: [MemFunctions] Add microbenchmarks for memory functions..

Thanks Roman.

Jul 3 2019, 2:36 AM · Restricted Project

Jul 2 2019

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

test-suite benchmarks: https://reviews.llvm.org/D64082

Jul 2 2019, 9:05 AM · Restricted Project
courbet created D64082: [MemFunctions] Add microbenchmarks for memory functions..
Jul 2 2019, 8:53 AM · Restricted Project

Jun 27 2019

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

For information, I had to roll this back at it breaks sanitizers. Sanitizer passes insert some nobuiltin attributes on all memcmp calls to prevent expansion and still be able to intercept them (maybeMarkSanitizerLibraryCallNoBuiltin), and these passes are added last in opt:

Jun 27 2019, 5:39 AM · Restricted Project

Jun 26 2019

courbet committed rG2851248fa141: Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt… (authored by courbet).
Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt…
Jun 26 2019, 5:14 AM
courbet committed rL364416: Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt….
Revert "r364412 [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt…
Jun 26 2019, 5:14 AM
courbet committed rL364412: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
[ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.
Jun 26 2019, 4:52 AM
courbet committed rG7b3a5f0e6da8: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline. (authored by courbet).
[ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline.
Jun 26 2019, 4:52 AM
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

clang-format

Jun 26 2019, 4:45 AM · Restricted Project
courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

I encourage adding small memcmp tests to test-suite as a follow-up, so we know that things won't break going forward.

Jun 26 2019, 2:20 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Rebase on r364384.

Jun 26 2019, 2:14 AM · Restricted Project
courbet committed rGbe98e0ab7895: [ExpandMemCmp] Honor prefer-vector-width. (authored by courbet).
[ExpandMemCmp] Honor prefer-vector-width.
Jun 26 2019, 12:10 AM
courbet committed rL364384: [ExpandMemCmp] Honor prefer-vector-width..
[ExpandMemCmp] Honor prefer-vector-width.
Jun 26 2019, 12:09 AM
courbet closed D63769: [ExpandMemCmp] Honor prefer-vector-width..
Jun 26 2019, 12:09 AM · Restricted Project
courbet added a comment to D63769: [ExpandMemCmp] Honor prefer-vector-width..

Thanks.

Jun 26 2019, 12:09 AM · Restricted Project

Jun 25 2019

courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Remove asm testing.

Jun 25 2019, 7:48 AM · Restricted Project
courbet added inline comments to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..
Jun 25 2019, 7:21 AM · Restricted Project
courbet created D63769: [ExpandMemCmp] Honor prefer-vector-width..
Jun 25 2019, 7:21 AM · Restricted Project
courbet updated the diff for D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Split off options refactoring to r364281, rebase.

Jun 25 2019, 1:51 AM · Restricted Project
courbet committed rL364281: [ExpandMemCmp] Move all options to TargetTransformInfo..
[ExpandMemCmp] Move all options to TargetTransformInfo.
Jun 25 2019, 1:10 AM
courbet committed rG3bc5ad551a4f: [ExpandMemCmp] Move all options to TargetTransformInfo. (authored by courbet).
[ExpandMemCmp] Move all options to TargetTransformInfo.
Jun 25 2019, 1:08 AM

Jun 21 2019

courbet added a comment to D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

Ping. Any other concerns ?

Jun 21 2019, 6:18 AM · Restricted Project
courbet added a comment to D63628: AMD K10 (Barcelona) Initial Scheduler model.

Amazing work Roman ! A few nits on the form, I'll let others more knowledgeable about AMD architectures comment on the model itself.

Jun 21 2019, 1:25 AM · Restricted Project

Jun 19 2019

courbet committed rGf7a6fb9f2c1d: Fix r363773: Update Barcelona MCA tests. (authored by courbet).
Fix r363773: Update Barcelona MCA tests.
Jun 19 2019, 3:00 AM
courbet committed rL363781: Fix r363773: Update Barcelona MCA tests..
Fix r363773: Update Barcelona MCA tests.
Jun 19 2019, 2:57 AM
courbet committed rG4ef7c2868a58: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr (authored by courbet).
[X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr
Jun 19 2019, 1:42 AM
courbet committed rL363773: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
[X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr
Jun 19 2019, 1:42 AM
courbet closed D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.
Jun 19 2019, 1:42 AM · Restricted Project
courbet added a comment to D62896: [X86] Add missing properties on llvm.x86.sse.{st,ld}mxcsr.

Thanks for the review.

Jun 19 2019, 12:46 AM · Restricted Project

Jun 17 2019

courbet added inline comments to D63243: [WIP] Adjust the users of dereferenceable wrt. dereferenceable_globally.
Jun 17 2019, 2:19 AM · Restricted Project

Jun 11 2019

courbet committed rGf63feaf3c2ff: [clang-tidy] Fix typo in bugprone-string-constructor. (authored by courbet).
[clang-tidy] Fix typo in bugprone-string-constructor.
Jun 11 2019, 5:09 AM
courbet committed rL363053: [clang-tidy] Fix typo in bugprone-string-constructor..
[clang-tidy] Fix typo in bugprone-string-constructor.
Jun 11 2019, 5:09 AM