Page MenuHomePhabricator

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (147 w, 3 d)

Recent Activity

Today

courbet updated the diff for D57000: [llvm-exegesis] Add throughput mode..

fix typo

Mon, Jan 21, 12:36 AM
courbet created D57000: [llvm-exegesis] Add throughput mode..
Mon, Jan 21, 12:36 AM
courbet added a comment to D54318: [WIP][llvm-exegesis] Add support for memory instructions in latency mode..

Is something like this still planned?
Looks like this 'kinda' stalled.

Mon, Jan 21, 12:12 AM

Fri, Jan 18

courbet committed rL351556: Revert r351529 "[llvm-objdump][NFC] Improve readability.".
Revert r351529 "[llvm-objdump][NFC] Improve readability."
Fri, Jan 18, 7:30 AM
courbet committed rL351553: Reland r351529 "[llvm-objdump][NFC] Improve readability.".
Reland r351529 "[llvm-objdump][NFC] Improve readability."
Fri, Jan 18, 6:24 AM
courbet committed rL351534: Revert r351529 "[llvm-objdump][NFC] Improve readability.".
Revert r351529 "[llvm-objdump][NFC] Improve readability."
Fri, Jan 18, 1:46 AM
courbet committed rL351529: [llvm-objdump][NFC] Improve readability..
[llvm-objdump][NFC] Improve readability.
Fri, Jan 18, 1:08 AM
courbet closed D56858: [llvm-objdump][NFC] Improve readability..
Fri, Jan 18, 1:08 AM
courbet updated the diff for D56858: [llvm-objdump][NFC] Improve readability..

Rebase

Fri, Jan 18, 12:26 AM
courbet updated the diff for D56858: [llvm-objdump][NFC] Improve readability..

Address comments

Fri, Jan 18, 12:19 AM
courbet added a comment to D56858: [llvm-objdump][NFC] Improve readability..

Thanks.

Fri, Jan 18, 12:19 AM

Thu, Jan 17

courbet created D56858: [llvm-objdump][NFC] Improve readability..
Thu, Jan 17, 8:27 AM

Wed, Jan 16

courbet committed rL351308: [clang-tidy] bugprone-string-constructor: Catch string from nullptr..
[clang-tidy] bugprone-string-constructor: Catch string from nullptr.
Wed, Jan 16, 12:40 AM
courbet committed rCTE351308: [clang-tidy] bugprone-string-constructor: Catch string from nullptr..
[clang-tidy] bugprone-string-constructor: Catch string from nullptr.
Wed, Jan 16, 12:40 AM
courbet closed D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr..
Wed, Jan 16, 12:40 AM · Restricted Project
courbet added a comment to D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr..

Thanks.

Wed, Jan 16, 12:39 AM · Restricted Project
courbet updated the diff for D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr..

clang-format + add test

Wed, Jan 16, 12:39 AM · Restricted Project

Mon, Jan 14

courbet updated the diff for D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr..

Remove commented code.

Mon, Jan 14, 2:36 AM · Restricted Project
courbet added a reviewer for D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.: etienneb.
Mon, Jan 14, 2:33 AM · Restricted Project
courbet created D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr..
Mon, Jan 14, 2:31 AM · Restricted Project

Fri, Jan 11

courbet created D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..
Fri, Jan 11, 4:45 AM

Tue, Jan 8

courbet created D56436: [SelectionDAG][RFC] Allow the user to specify a memeq function (v4)..
Tue, Jan 8, 6:23 AM

Fri, Jan 4

courbet updated the diff for D56313: [SelectionDAG][RFC] Allow the user to specify a memeq function (v3)..

Fix comment.

Fri, Jan 4, 4:48 AM
courbet created D56313: [SelectionDAG][RFC] Allow the user to specify a memeq function (v3)..
Fri, Jan 4, 4:47 AM
courbet added inline comments to D55933: [Sema] Do not print default template parameters..
Fri, Jan 4, 4:14 AM
courbet updated the diff for D55933: [Sema] Do not print default template parameters..

Handle {L,R}Value references.

Fri, Jan 4, 4:14 AM
courbet updated the diff for D56311: [SelectionDAG][RFC] Allow the user to specify a memeq function (v2)..

update tests

Fri, Jan 4, 2:31 AM
courbet created D56311: [SelectionDAG][RFC] Allow the user to specify a memeq function (v2)..
Fri, Jan 4, 2:24 AM

Thu, Jan 3

courbet updated the diff for D55933: [Sema] Do not print default template parameters..

Add more tests as suggested in the comments.

Thu, Jan 3, 4:12 AM
courbet added inline comments to D55933: [Sema] Do not print default template parameters..
Thu, Jan 3, 4:12 AM
courbet added inline comments to D55932: [Sema] Simplfy static_assert diagnostic code..
Thu, Jan 3, 3:53 AM
courbet added a comment to D56248: [SelectionDAG][RFC] Allow the user to specify a memeq function..

How is this supposed to be exposed to the middle-end, front-end?
Might be better off as a RFC..

Thu, Jan 3, 1:20 AM
courbet updated the diff for D56248: [SelectionDAG][RFC] Allow the user to specify a memeq function..

remove useless decl

Thu, Jan 3, 1:09 AM
courbet created D56248: [SelectionDAG][RFC] Allow the user to specify a memeq function..
Thu, Jan 3, 1:07 AM

Wed, Jan 2

courbet added inline comments to D55932: [Sema] Simplfy static_assert diagnostic code..
Wed, Jan 2, 8:26 AM
courbet added inline comments to D55932: [Sema] Simplfy static_assert diagnostic code..
Wed, Jan 2, 1:33 AM
courbet added a reverting change for rL350035: [llvm-exegesis] Clustering: don't enqueue a point multiple times: rL350207: Revert rL350035 "[llvm-exegesis] Clustering: don't enqueue a point multiple….
Wed, Jan 2, 1:25 AM
courbet committed rL350207: Revert rL350035 "[llvm-exegesis] Clustering: don't enqueue a point multiple….
Revert rL350035 "[llvm-exegesis] Clustering: don't enqueue a point multiple…
Wed, Jan 2, 1:25 AM
courbet added a comment to D54442: [llvm-exegesis] Optimize ToProcess in dbScan.

@MaskRay, can you help me understand why you decided to submit this when there are still disagreements in the review thread ?

Wed, Jan 2, 1:20 AM

Dec 21 2018

courbet added inline comments to D55933: [Sema] Do not print default template parameters..
Dec 21 2018, 1:43 AM

Dec 20 2018

courbet added a parent revision for D55933: [Sema] Do not print default template parameters.: D55932: [Sema] Simplfy static_assert diagnostic code..
Dec 20 2018, 7:42 AM
courbet added a child revision for D55932: [Sema] Simplfy static_assert diagnostic code.: D55933: [Sema] Do not print default template parameters..
Dec 20 2018, 7:42 AM
courbet created D55933: [Sema] Do not print default template parameters..
Dec 20 2018, 7:40 AM
courbet created D55932: [Sema] Simplfy static_assert diagnostic code..
Dec 20 2018, 7:38 AM
courbet committed rC349755: [Sema][NFC] Add test for static_assert diagnistics with constexpr template….
[Sema][NFC] Add test for static_assert diagnistics with constexpr template…
Dec 20 2018, 5:33 AM
courbet committed rL349755: [Sema][NFC] Add test for static_assert diagnistics with constexpr template….
[Sema][NFC] Add test for static_assert diagnistics with constexpr template…
Dec 20 2018, 5:33 AM
courbet committed rL349747: Re-land r349731 "[CodeGen][ExpandMemcmp] Add an option for allowing overlapping….
Re-land r349731 "[CodeGen][ExpandMemcmp] Add an option for allowing overlapping…
Dec 20 2018, 5:04 AM
courbet committed rL349733: Revert r349731 "[CodeGen][ExpandMemcmp] Add an option for allowing overlapping….
Revert r349731 "[CodeGen][ExpandMemcmp] Add an option for allowing overlapping…
Dec 20 2018, 2:01 AM
courbet committed rL349732: [NFC] Fix trailing comma after function..
[NFC] Fix trailing comma after function.
Dec 20 2018, 1:23 AM
courbet committed rL349731: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..
[CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads.
Dec 20 2018, 1:17 AM
courbet closed D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..
Dec 20 2018, 1:17 AM
courbet added a comment to D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..

Thank you all for the comments.

Dec 20 2018, 1:09 AM
courbet committed rC349729: [Sema] Better static assert diagnostics for expressions involving….
[Sema] Better static assert diagnostics for expressions involving…
Dec 20 2018, 1:08 AM
courbet committed rL349729: [Sema] Better static assert diagnostics for expressions involving….
[Sema] Better static assert diagnostics for expressions involving…
Dec 20 2018, 1:08 AM
courbet closed D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..
Dec 20 2018, 1:08 AM
courbet added a comment to D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

Thanks for the comments !

Dec 20 2018, 1:08 AM

Dec 19 2018

courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

address review comments

Dec 19 2018, 11:49 PM
courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

clang-format diff

Dec 19 2018, 7:45 AM
courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

address review comments

Dec 19 2018, 7:45 AM
courbet added inline comments to D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..
Dec 19 2018, 7:45 AM
courbet added inline comments to D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..
Dec 19 2018, 6:50 AM
courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

move PrintQualifiedTypes to PrintingPolicy

Dec 19 2018, 6:50 AM
courbet added a comment to D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..

Sorry for the delay.

Dec 19 2018, 1:01 AM
courbet updated the diff for D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..

address review comments

Dec 19 2018, 1:01 AM

Dec 18 2018

courbet added a comment to D54442: [llvm-exegesis] Optimize ToProcess in dbScan.

It looks I missed the unittest, sorry for that.

Dec 18 2018, 8:08 AM
courbet added a comment to D54442: [llvm-exegesis] Optimize ToProcess in dbScan.

It looks I missed the unittest, sorry for that. And I somehow messed ToProcess[Tail++] = Q;.

Dec 18 2018, 8:07 AM

Dec 17 2018

courbet committed rL349332: [llvm-mca] Move llvm-mca library to llvm/lib/MCA..
[llvm-mca] Move llvm-mca library to llvm/lib/MCA.
Dec 17 2018, 12:13 AM
courbet closed D55557: [llvm-mca] Move llvm-mca library to llvm/lib/MCA..
Dec 17 2018, 12:12 AM

Dec 14 2018

courbet updated the diff for D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..

address Simon's comments.

Dec 14 2018, 2:10 AM
courbet added a comment to D54442: [llvm-exegesis] Optimize ToProcess in dbScan.

I don't think we've reached a consensus here. Sorry for missing the ping.

Dec 14 2018, 2:00 AM

Dec 13 2018

courbet added a comment to D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..

Unrelated diffs got uploaded?

Dec 13 2018, 11:24 PM
courbet updated the diff for D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..

rebase

Dec 13 2018, 11:23 PM
courbet updated the diff for D55263: [CodeGen][ExpandMemcmp] Add an option for allowing overlapping loads..

address comments

Dec 13 2018, 7:56 AM
courbet committed rL349016: [CodeGen] Allow mempcy/memset to generate small overlapping stores..
[CodeGen] Allow mempcy/memset to generate small overlapping stores.
Dec 13 2018, 1:59 AM
courbet closed D55365: [CodeGen] Allow mempcy/memset to generate small overlapping stores..
Dec 13 2018, 1:59 AM
courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

revert now unneeded changes.

Dec 13 2018, 12:46 AM
courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

clang-format patch

Dec 13 2018, 12:44 AM
courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

Handle remaining static_assert categories inside the prettyprinter.

Dec 13 2018, 12:41 AM

Dec 12 2018

courbet planned changes to D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..
Dec 12 2018, 9:14 AM
courbet added a comment to D55270: [Sema] Further improvements to to static_assert diagnostics..

I agree. I'll have a look at it.

Dec 12 2018, 8:11 AM
courbet updated the diff for D55365: [CodeGen] Allow mempcy/memset to generate small overlapping stores..
  • update ARM tests.
Dec 12 2018, 7:53 AM
courbet updated the diff for D55557: [llvm-mca] Move llvm-mca library to llvm/lib/MCA..

update OWNERS

Dec 12 2018, 6:25 AM
courbet added a comment to D55365: [CodeGen] Allow mempcy/memset to generate small overlapping stores..

Reopening - this patch was reverted at rL348844 because it broke an ARM test.

Dec 12 2018, 2:43 AM

Dec 11 2018

courbet created D55557: [llvm-mca] Move llvm-mca library to llvm/lib/MCA..
Dec 11 2018, 6:38 AM
courbet committed rL348844: Revert r348843 "[CodeGen] Allow mempcy/memset to generate small overlapping….
Revert r348843 "[CodeGen] Allow mempcy/memset to generate small overlapping…
Dec 11 2018, 5:42 AM
courbet committed rL348843: [CodeGen] Allow mempcy/memset to generate small overlapping stores..
[CodeGen] Allow mempcy/memset to generate small overlapping stores.
Dec 11 2018, 5:19 AM
courbet closed D55365: [CodeGen] Allow mempcy/memset to generate small overlapping stores..
Dec 11 2018, 5:19 AM
courbet updated the diff for D55365: [CodeGen] Allow mempcy/memset to generate small overlapping stores..

add test

Dec 11 2018, 5:00 AM
courbet added a comment to D55365: [CodeGen] Allow mempcy/memset to generate small overlapping stores..

Thanks for the comments !

Dec 11 2018, 4:56 AM
courbet updated the diff for D55365: [CodeGen] Allow mempcy/memset to generate small overlapping stores..

clang-format patch

Dec 11 2018, 4:13 AM
courbet updated the diff for D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

cosmetics

Dec 11 2018, 4:09 AM
courbet created D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..
Dec 11 2018, 4:06 AM
courbet committed rC348834: Reland r348741 "[Sema] Further improvements to to static_assert diagnostics.".
Reland r348741 "[Sema] Further improvements to to static_assert diagnostics."
Dec 11 2018, 12:43 AM
courbet committed rL348834: Reland r348741 "[Sema] Further improvements to to static_assert diagnostics.".
Reland r348741 "[Sema] Further improvements to to static_assert diagnostics."
Dec 11 2018, 12:43 AM

Dec 10 2018

courbet committed rC348831: Revert r348830 "[Sema]improve static_assert(!expr)".
Revert r348830 "[Sema]improve static_assert(!expr)"
Dec 10 2018, 11:32 PM
courbet committed rL348831: Revert r348830 "[Sema]improve static_assert(!expr)".
Revert r348830 "[Sema]improve static_assert(!expr)"
Dec 10 2018, 11:32 PM
courbet committed rC348830: [Sema]improve static_assert(!expr).
[Sema]improve static_assert(!expr)
Dec 10 2018, 11:09 PM
courbet committed rL348830: [Sema]improve static_assert(!expr).
[Sema]improve static_assert(!expr)
Dec 10 2018, 11:09 PM
courbet committed rC348742: Revert r348741 "[Sema] Further improvements to to static_assert diagnostics.".
Revert r348741 "[Sema] Further improvements to to static_assert diagnostics."
Dec 10 2018, 12:56 AM
courbet committed rL348742: Revert r348741 "[Sema] Further improvements to to static_assert diagnostics.".
Revert r348741 "[Sema] Further improvements to to static_assert diagnostics."
Dec 10 2018, 12:56 AM