Page MenuHomePhabricator

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (210 w, 5 d)

Recent Activity

Yesterday

courbet accepted D77599: [AArch64] Don't expand memcmp in strict align mode..
Mon, Apr 6, 11:25 PM · Restricted Project
courbet accepted D77538: [Alignment][NFC] Assume AlignmentFromAssumptions::getNewAlignment is always set..
Mon, Apr 6, 8:06 AM · Restricted Project
courbet added inline comments to D77538: [Alignment][NFC] Assume AlignmentFromAssumptions::getNewAlignment is always set..
Mon, Apr 6, 6:27 AM · Restricted Project
courbet added a comment to D77538: [Alignment][NFC] Assume AlignmentFromAssumptions::getNewAlignment is always set..

why not change the single return 0 in getNewAlignment() with return Align(1), and modify that type ?

Mon, Apr 6, 4:50 AM · Restricted Project
courbet added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

And thanks for the contribution.

Mon, Apr 6, 4:50 AM · Restricted Project
courbet added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

This isn't a new mode, it's still for measuring latency.

Mon, Apr 6, 4:50 AM · Restricted Project
courbet accepted D77537: [Alignment][NFC] Add DebugStr and operator*.
Mon, Apr 6, 4:17 AM · Restricted Project
courbet accepted D77409: [Alignment][NFC] Remove deprecated functions introduced in 10.0.0.
Mon, Apr 6, 4:17 AM · Restricted Project
courbet added inline comments to D77454: [WIP] LoadInst should store Align, not MaybeAlign..
Mon, Apr 6, 12:30 AM · Restricted Project

Sun, Apr 5

courbet accepted D77394: [Alignment][NFC] Add DebugStr and operator*.
Sun, Apr 5, 11:57 PM · Restricted Project

Fri, Apr 3

courbet added inline comments to D77394: [Alignment][NFC] Add DebugStr and operator*.
Fri, Apr 3, 7:29 AM · Restricted Project
courbet added inline comments to D77394: [Alignment][NFC] Add DebugStr and operator*.
Fri, Apr 3, 7:29 AM · Restricted Project
courbet added a comment to D77386: [Alignment][NFC] Allow to print alignment to raw_ostream.

I'd rather have every user forced to think whether they want to use the value or its internal (log) representation, e.g. .p2align vs MIR format. If only for debug, then:

Fri, Apr 3, 6:24 AM · Restricted Project
courbet accepted D77312: [Alignment][NFC] Deprecate InstrTypes getRetAlignment/getParamAlignment.
Fri, Apr 3, 2:39 AM · Restricted Project
courbet accepted D77297: [Alignment][NFC] Remove unused private functions.
Fri, Apr 3, 2:08 AM · Restricted Project
courbet accepted D77292: [Alignment][NFC] Convert MachineIRBuilder::buildDynStackAlloc to Align.
Fri, Apr 3, 2:07 AM · Restricted Project
courbet requested changes to D77292: [Alignment][NFC] Convert MachineIRBuilder::buildDynStackAlloc to Align.
Fri, Apr 3, 2:07 AM · Restricted Project
courbet accepted D77372: [NFC] G_DYN_STACKALLOC realign iff align > 1, update documentation.
Fri, Apr 3, 1:34 AM · Restricted Project

Thu, Apr 2

courbet added inline comments to D77292: [Alignment][NFC] Convert MachineIRBuilder::buildDynStackAlloc to Align.
Thu, Apr 2, 4:18 AM · Restricted Project
courbet committed rGfb4aa30f272b: [ExpandMemCmp] Allow overlaping loads in the zero-relational case. (authored by courbet).
[ExpandMemCmp] Allow overlaping loads in the zero-relational case.
Thu, Apr 2, 2:41 AM
courbet closed D76133: [ExpandMemCmp] Allow overlaping loads in the zero-relational case..
Thu, Apr 2, 2:41 AM · Restricted Project
courbet accepted D77291: [Alignment][NFC] Use more Align versions of various functions.
Thu, Apr 2, 2:08 AM · Restricted Project
courbet added a comment to D77291: [Alignment][NFC] Use more Align versions of various functions.

Please rephrase the commit header to something more informative.

Thu, Apr 2, 2:08 AM · Restricted Project
courbet added a comment to D76133: [ExpandMemCmp] Allow overlaping loads in the zero-relational case..

Thanks.

Thu, Apr 2, 12:30 AM · Restricted Project

Wed, Apr 1

courbet accepted D76921: [llvm-exegesis] 'Min' repetition mode.
Wed, Apr 1, 11:23 PM · Restricted Project
courbet accepted D77218: [Alignment][NFC] Mark IRTranslator::getMemOpAlignment deprecated.
Wed, Apr 1, 7:41 AM · Restricted Project
courbet accepted D77217: [Alignment][NFC] Remove remaining uses of MachineFrameInfo::setObjectAlignment.
Wed, Apr 1, 7:40 AM · Restricted Project
courbet accepted D77215: [Alignment][NFC] Transition to MachineFrameInfo::getObjectAlign().
Wed, Apr 1, 7:07 AM · Restricted Project
courbet accepted D77212: [Alignment][NFC] Convert SelectionDAG::InferPtrAlignment to MaybeAlign.
Wed, Apr 1, 6:35 AM · Restricted Project
courbet accepted D77203: [Alignment][NFC] Convert MIR Yaml to MaybeAlign.
Wed, Apr 1, 4:58 AM · Restricted Project
courbet accepted D77149: [Alignment][NFC] Use Align in SelectionDAG::getMemIntrinsicNode.
Wed, Apr 1, 1:36 AM · Restricted Project

Tue, Mar 31

courbet accepted D77138: [Alignment][NFC] Deprecate MachineMemOperand::getMachineMemOperand version that takes an untyped alignement..
Tue, Mar 31, 6:37 AM · Restricted Project
courbet accepted D77127: [Alignment][NFC] Transitionning more getMachineMemOperand call sites.
Tue, Mar 31, 4:23 AM · Restricted Project
courbet accepted D77121: [Alignment][NFC] Transitionning more getMachineMemOperand call sites.
Tue, Mar 31, 1:37 AM · Restricted Project
courbet accepted D77120: [Alignment][NFC] Transition to inferAlignFromPtrInfo.
Tue, Mar 31, 1:04 AM · Restricted Project

Mon, Mar 30

courbet accepted D77078: [Alignment][NFC] Simplify IRTranslator::getMemOpAlignment.
Mon, Mar 30, 11:58 PM · Restricted Project
courbet added inline comments to D76921: [llvm-exegesis] 'Min' repetition mode.
Mon, Mar 30, 11:58 PM · Restricted Project
courbet accepted D77079: [Alignment][NFC] GlobalIsel Utils inferAlignFromPtrInfo.
Mon, Mar 30, 11:58 PM · Restricted Project
courbet accepted D77059: [Alignment][NFC] Use Align version of getMachineMemOperand.
Mon, Mar 30, 8:03 AM · Restricted Project
courbet accepted D77046: [Alignment][NFC] Provide tightened up functions in SelectionDAG, MachineFunction and MachineMemOperand.
Mon, Mar 30, 3:44 AM · Restricted Project

Sun, Mar 29

courbet accepted D76933: [Alignment][NFC] Return Align for SelectionDAGNodes::getOriginalAlignment/getAlignment.
Sun, Mar 29, 11:57 PM · Restricted Project

Fri, Mar 27

courbet accepted D76925: [Alignment][NFC] MachineMemOperand::getAlign/getBaseAlign.

Thanks for the explanation.

Fri, Mar 27, 8:30 AM · Restricted Project
courbet requested changes to D76925: [Alignment][NFC] MachineMemOperand::getAlign/getBaseAlign.
Fri, Mar 27, 7:37 AM · Restricted Project
courbet accepted D76914: [Alignment] Fix overaligning bug.
Fri, Mar 27, 4:50 AM · Restricted Project
courbet accepted D76914: [Alignment] Fix overaligning bug.
Fri, Mar 27, 3:44 AM · Restricted Project
courbet added a comment to D76625: [Alignment][NFC] Update MachineMemOperand implementation to use Align.
  • BaseAlign is never None
Fri, Mar 27, 1:01 AM · Restricted Project

Thu, Mar 26

courbet accepted D76613: [Alignment][NFC] Use llvmTargetFrameLowering::getStackAlign.
Thu, Mar 26, 3:44 AM · Restricted Project

Tue, Mar 24

courbet accepted D76625: [Alignment][NFC] Update MachineMemOperand implementation to use Align.
Tue, Mar 24, 1:03 AM · Restricted Project

Mon, Mar 23

courbet accepted D76542: [Alignment][NFC] Deprecate VectorUtils::getAlignment.
Mon, Mar 23, 5:58 AM · Restricted Project
courbet accepted D76368: [Alignment][NFC] Deprecate ensureMaxAlignment.
Mon, Mar 23, 3:48 AM · Restricted Project
courbet accepted D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign().
Mon, Mar 23, 3:48 AM · Restricted Project
courbet added inline comments to D76551: [Alignment][NFC] Use TargetFrameLowering::getStackAlign().
Mon, Mar 23, 2:10 AM · Restricted Project
courbet added a comment to D76550: [Attributor] Improve the alignment of the loads.

@courbet To be honest

explicit MaybeAlign(uint64_t Value) {
  assert((Value == 0 || llvm::isPowerOf2_64(Value)) &&
         "Alignment is neither 0 nor a power of 2");
  if (Value)
    emplace(Value);
}

that if-check looks like a major rake.

Mon, Mar 23, 1:38 AM · Restricted Project

Fri, Mar 20

courbet added inline comments to D76504: [clang] Fix crash during template sema checking.
Fri, Mar 20, 9:10 AM · Restricted Project

Wed, Mar 18

courbet accepted D76348: [Alignment][NFC] Deprecate getMaxAlignment.
Wed, Mar 18, 7:02 AM · Restricted Project
courbet added inline comments to D76348: [Alignment][NFC] Deprecate getMaxAlignment.
Wed, Mar 18, 5:56 AM · Restricted Project
courbet accepted D76301: [Alignment][NFC] Deprecate getTransientStackAlignment.
Wed, Mar 18, 1:04 AM · Restricted Project

Tue, Mar 17

courbet accepted D76274: [Alignment] Add alignTo with skew parameter.
Tue, Mar 17, 3:44 AM · Restricted Project

Mon, Mar 16

courbet accepted D76113: [ExpandMemCmp] Correctly set alignment of generated loads.

LGTM when the comments are addressed.

Mon, Mar 16, 2:26 AM · Restricted Project
courbet added inline comments to D76113: [ExpandMemCmp] Correctly set alignment of generated loads.
Mon, Mar 16, 2:10 AM · Restricted Project
courbet updated subscribers of D76113: [ExpandMemCmp] Correctly set alignment of generated loads.
Mon, Mar 16, 1:05 AM · Restricted Project
courbet added inline comments to D76113: [ExpandMemCmp] Correctly set alignment of generated loads.
Mon, Mar 16, 12:49 AM · Restricted Project
courbet added a comment to D76113: [ExpandMemCmp] Correctly set alignment of generated loads.

Can you please add a test with an explicit parameter alignment ?

Mon, Mar 16, 12:49 AM · Restricted Project

Fri, Mar 13

courbet created D76133: [ExpandMemCmp] Allow overlaping loads in the zero-relational case..
Fri, Mar 13, 7:29 AM · Restricted Project
courbet committed rGffe3515aa774: [ExpandMemCmp][NFC] Add more tests. (authored by courbet).
[ExpandMemCmp][NFC] Add more tests.
Fri, Mar 13, 7:28 AM
courbet planned changes to D75840: [ExpandMemCmp] Improve non-equality comparisons with zero..

Actually I'm actually now convinced that the whole approach is incorrect when there are several blocks. I'm going to take some time to rethink this.

Fri, Mar 13, 5:46 AM · Restricted Project

Thu, Mar 12

courbet added a comment to D76056: [MemFunctions] Add validity check..

Thanks, PTAL.

Thu, Mar 12, 5:53 AM · Restricted Project
courbet updated the diff for D76056: [MemFunctions] Add validity check..

address comments

Thu, Mar 12, 5:53 AM · Restricted Project
courbet updated the diff for D76056: [MemFunctions] Add validity check..

clang-format

Thu, Mar 12, 4:29 AM · Restricted Project
courbet created D76056: [MemFunctions] Add validity check..
Thu, Mar 12, 4:29 AM · Restricted Project
courbet added inline comments to D75840: [ExpandMemCmp] Improve non-equality comparisons with zero..
Thu, Mar 12, 3:03 AM · Restricted Project
courbet updated the diff for D75840: [ExpandMemCmp] Improve non-equality comparisons with zero..

Use the right unsigned equivalent for comparing loads instead of the signed predicate from the zero relational compare.

Thu, Mar 12, 3:03 AM · Restricted Project
courbet committed rG4edd050c7e97: [ExpandMemCmp][NFC] Add more tests. (authored by courbet).
[ExpandMemCmp][NFC] Add more tests.
Thu, Mar 12, 1:37 AM

Wed, Mar 11

courbet added inline comments to D75840: [ExpandMemCmp] Improve non-equality comparisons with zero..
Wed, Mar 11, 9:36 AM · Restricted Project

Tue, Mar 10

courbet added a comment to D75840: [ExpandMemCmp] Improve non-equality comparisons with zero..

Benchmark results from test-suite. TBH I'm not exactly sure why only the "greater" case gets better, but overall the results are promising.

Tue, Mar 10, 7:32 AM · Restricted Project
courbet committed rG30477197b37f: [ExpandMemCmp][NFC] Add more tests. (authored by courbet).
[ExpandMemCmp][NFC] Add more tests.
Tue, Mar 10, 3:48 AM
courbet updated the diff for D75840: [ExpandMemCmp] Improve non-equality comparisons with zero..

clang-format

Tue, Mar 10, 12:52 AM · Restricted Project

Mon, Mar 9

courbet created D75840: [ExpandMemCmp] Improve non-equality comparisons with zero..
Mon, Mar 9, 4:16 AM · Restricted Project
courbet committed rG6518b72f93f5: [ExpandMemCmp] Properly constant-fold all compares. (authored by courbet).
[ExpandMemCmp] Properly constant-fold all compares.
Mon, Mar 9, 3:12 AM
courbet committed rGf7e6f5f8e304: [ExpandMemCmp] Properly constant-fold all compares. (authored by courbet).
[ExpandMemCmp] Properly constant-fold all compares.
Mon, Mar 9, 1:35 AM
courbet closed D75519: [ExpandMemCmp] Properly constant-fold all compares..
Mon, Mar 9, 1:34 AM · Restricted Project
courbet added a comment to D75519: [ExpandMemCmp] Properly constant-fold all compares..

Simplify instructions after expandmemcmp.

LGTM, but as a matter of risk reduction, please make that an independent commit.

Mon, Mar 9, 1:02 AM · Restricted Project

Mar 6 2020

courbet updated the diff for D75519: [ExpandMemCmp] Properly constant-fold all compares..

Simplify instructions after expandmemcmp.

Mar 6 2020, 6:04 AM · Restricted Project

Mar 5 2020

courbet updated the diff for D75519: [ExpandMemCmp] Properly constant-fold all compares..

Revert scheduling changes.

Mar 5 2020, 3:52 AM · Restricted Project

Mar 4 2020

courbet added a comment to D75519: [ExpandMemCmp] Properly constant-fold all compares..

Given memcmp expansion is running late in the pipeline, do you think we're possibly missing other relevant optimizations on the loads? LICM, maybe?

Mar 4 2020, 12:06 AM · Restricted Project
courbet added a reviewer for D75519: [ExpandMemCmp] Properly constant-fold all compares.: efriedma.
Mar 4 2020, 12:06 AM · Restricted Project

Mar 3 2020

courbet added reviewers for D75519: [ExpandMemCmp] Properly constant-fold all compares.: spatel, nemanjai, gchatelet.
Mar 3 2020, 7:25 AM · Restricted Project
courbet added inline comments to D75519: [ExpandMemCmp] Properly constant-fold all compares..
Mar 3 2020, 7:23 AM · Restricted Project
courbet updated the diff for D75519: [ExpandMemCmp] Properly constant-fold all compares..

Update powerpc tests

Mar 3 2020, 7:23 AM · Restricted Project
courbet committed rG075c281859de: [ExpandMemCmp][NFC] Regenerate tests. (authored by courbet).
[ExpandMemCmp][NFC] Regenerate tests.
Mar 3 2020, 6:22 AM
courbet added a comment to D75519: [ExpandMemCmp] Properly constant-fold all compares..

Note that most test changes are NFC (just interleaving computations). I've highlighted the actual changes.

Mar 3 2020, 6:21 AM · Restricted Project
courbet updated the diff for D75519: [ExpandMemCmp] Properly constant-fold all compares..

regenerate pgso tests

Mar 3 2020, 6:21 AM · Restricted Project
courbet created D75519: [ExpandMemCmp] Properly constant-fold all compares..
Mar 3 2020, 6:21 AM · Restricted Project
courbet committed rGc68d35d78c8b: [ExpandMemCmp] Add more tests to show missing constant folding. (authored by courbet).
[ExpandMemCmp] Add more tests to show missing constant folding.
Mar 3 2020, 6:03 AM
courbet committed rGb0ae20d92e48: [ExpandMemCmp][NFC] Fix typo in comment. (authored by courbet).
[ExpandMemCmp][NFC] Fix typo in comment.
Mar 3 2020, 2:12 AM

Feb 19 2020

courbet committed rGbe45a5a4092d: [CodeGen][Tests] Fix b3cf70427eb1e97d9b89ba6e9298c280c8a32c74 (authored by courbet).
[CodeGen][Tests] Fix b3cf70427eb1e97d9b89ba6e9298c280c8a32c74
Feb 19 2020, 4:35 AM

Feb 12 2020

courbet committed rG15488ff24b4a: [CodeGen] Fix the computation of the alignment of split stores. (authored by courbet).
[CodeGen] Fix the computation of the alignment of split stores.
Feb 12 2020, 1:39 AM
courbet closed D74311: [CodeGen] Fix the computation of the alignment of split stores..
Feb 12 2020, 1:38 AM · Restricted Project
courbet committed rG24856002e066: [CodeGenPrepare] Add more store splitting tests for PR44877. (authored by courbet).
[CodeGenPrepare] Add more store splitting tests for PR44877.
Feb 12 2020, 12:53 AM
courbet added a comment to D74311: [CodeGen] Fix the computation of the alignment of split stores..

Thanks for the review !

Feb 12 2020, 12:53 AM · Restricted Project