Page MenuHomePhabricator

courbet (Clement Courbet)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 24 2016, 3:59 AM (199 w, 2 d)

Recent Activity

Yesterday

courbet added inline comments to D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners.
Fri, Jan 17, 8:40 AM · Restricted Project
courbet accepted D72858: [llvm-exegesis][mips] Add support for memory instructions.
Fri, Jan 17, 1:33 AM · Restricted Project

Thu, Jan 2

courbet added a comment to D72032: [llvm-exegesis] Add pfm counters for Zen2 (znver2)..

I take it there's no way to write a portable test for this patch? (one that doesn't have to run on the specific hardware, but still demonstrates the presence of this newly added support?)

Thu, Jan 2, 2:25 AM · Restricted Project

Tue, Dec 31

courbet added a comment to D72032: [llvm-exegesis] Add pfm counters for Zen2 (znver2)..

Thanks. I'll wait for the other patch to be submitted and then change the binding.

Tue, Dec 31, 4:18 AM · Restricted Project
courbet accepted D71927: [llvm-exegesis] Check counters before running.
Tue, Dec 31, 4:04 AM · Restricted Project
courbet created D72032: [llvm-exegesis] Add pfm counters for Zen2 (znver2)..
Tue, Dec 31, 2:36 AM · Restricted Project
courbet added inline comments to D71927: [llvm-exegesis] Check counters before running.
Tue, Dec 31, 12:07 AM · Restricted Project

Thu, Dec 19

courbet accepted D71703: [Alignment][NFC] Align compatible methods for CreateElementUnorderedAtomicMemSet.
Thu, Dec 19, 6:53 AM · Restricted Project
courbet accepted D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.

OK great.

Thu, Dec 19, 3:43 AM · Restricted Project

Dec 18 2019

courbet added a comment to D71665: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.

That is weird. If I understand the intel doc correctly, both these names refer to the same event (EventSel=A1H, UMask=01H). I have a haswell machine and dispatched worked (but I patched your change and I get the exact same results, which is to be expected given that the event is the same). What version of libpfm do you have ? I've seen both work on`4.10.1+git14-g815ff28-1`.

Dec 18 2019, 11:51 PM · Restricted Project
courbet accepted D71653: [llvm-exegesis][NFC] internal changes.
Dec 18 2019, 6:08 AM · Restricted Project
courbet added inline comments to D71653: [llvm-exegesis][NFC] internal changes.
Dec 18 2019, 4:02 AM · Restricted Project

Dec 17 2019

courbet accepted D71605: [llvm-exegesis][mips] Add lit test.
Dec 17 2019, 11:03 PM · Restricted Project

Dec 16 2019

courbet added a comment to D71523: [NFC] Simplify TargetLibraryInfo implementation.

This makes the code easier to read indeed, but this comes at the expense of allocations and less locality, so I would refrain from doing this unless we have a good reason.
Or: gather some data in the codebase as to whether a template-parametric SmallBitVector would find other usages, implement it, and use it here as a 3rd parameter to PackedBitVector.

Dec 16 2019, 4:28 AM · Restricted Project
courbet added a comment to D71471: [llvm-exegesis][mips] Add SnippetGeneratorTest unit test.

LGMT from the exegesis side. Disclaimer: I know nothing about MIPS.

Dec 16 2019, 1:18 AM · Restricted Project
courbet added inline comments to D71468: [llvm-exegesis] Set up AsmTargetStreamer in readSnippets.
Dec 16 2019, 1:00 AM · Restricted Project
courbet accepted D71473: [Alignment][NFC] Deprecate untyped variants of CreateMemCpy/CreateMemMove.

Please also change the title of the patch, to avoid panic :)

Dec 16 2019, 12:23 AM · Restricted Project

Dec 12 2019

courbet accepted D71420: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder.
Dec 12 2019, 6:45 AM · Restricted Project, Restricted Project
courbet added a reviewer for D71420: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder: foad.
Dec 12 2019, 6:44 AM · Restricted Project, Restricted Project

Dec 11 2019

courbet accepted D71343: [Alignment][NFC] Introduce Align in IRBuilder.
Dec 11 2019, 4:18 AM · Restricted Project
courbet accepted D71332: Rollback assumeAligned in MemorySanitizer.
Dec 11 2019, 2:16 AM · Restricted Project

Dec 10 2019

courbet accepted D71277: [Alignment][NFC] Introduce Align in SROA.
Dec 10 2019, 8:19 AM · Restricted Project
courbet accepted D71213: [Alignment][NFC] CreateMemSet use MaybeAlign.
Dec 10 2019, 5:07 AM · Restricted Project, Restricted Project
courbet added inline comments to D71213: [Alignment][NFC] CreateMemSet use MaybeAlign.
Dec 10 2019, 1:56 AM · Restricted Project, Restricted Project

Dec 4 2019

courbet added inline comments to D70999: Fix the macro fusion table for X86 according to Intel optimization manual.
Dec 4 2019, 8:37 AM · Restricted Project
courbet accepted D70999: Fix the macro fusion table for X86 according to Intel optimization manual.
Dec 4 2019, 6:53 AM · Restricted Project

Dec 2 2019

courbet committed rG3540b80fe445: [llvm-exegesis] Fix 44b9942898c7. (authored by courbet).
[llvm-exegesis] Fix 44b9942898c7.
Dec 2 2019, 7:18 AM
courbet closed D70903: [llvm-exegesis] Fix 44b9942898c7..
Dec 2 2019, 7:18 AM · Restricted Project
courbet updated the diff for D70903: [llvm-exegesis] Fix 44b9942898c7..

More comments.

Dec 2 2019, 7:13 AM · Restricted Project
courbet added a reviewer for D70903: [llvm-exegesis] Fix 44b9942898c7.: kadircet.
Dec 2 2019, 6:55 AM · Restricted Project
courbet updated the diff for D70903: [llvm-exegesis] Fix 44b9942898c7..

And add unit test.

Dec 2 2019, 6:49 AM · Restricted Project
courbet created D70903: [llvm-exegesis] Fix 44b9942898c7..
Dec 2 2019, 6:37 AM · Restricted Project
courbet accepted D70891: [X86] Add initialization of FPCW in llvm-exegesis.
Dec 2 2019, 4:03 AM · Restricted Project
courbet accepted D70874: [X86] Add initialization of MXCSR in llvm-exegesis.

I'm not sure I understand why this needs to be initialized. Why don't we need to do it for FPCW?

Dec 2 2019, 12:15 AM · Restricted Project

Nov 25 2019

courbet added a comment to rG95fe54931fdd: [clang-tidy] new performance-no-automatic-move check..

Does it make sense of extending the unit test with auto, auto & and auto && examples for the variables?

Nov 25 2019, 8:24 AM

Nov 22 2019

courbet committed rGcb15ba84fe7c: Reland "[DAGCombiner] Allow zextended load combines." (authored by courbet).
Reland "[DAGCombiner] Allow zextended load combines."
Nov 22 2019, 5:56 AM
courbet abandoned D60318: [ExpandMemCmp][MergeICmps] Move passes out of CodeGen into opt pipeline..

@courbet what's happening with this patch?

Nov 22 2019, 2:46 AM · Restricted Project
courbet committed rG88e205525ca3: Revert "[DAGCombiner] Allow zextended load combines." (authored by courbet).
Revert "[DAGCombiner] Allow zextended load combines."
Nov 22 2019, 12:05 AM

Nov 21 2019

courbet committed rG95fe54931fdd: [clang-tidy] new performance-no-automatic-move check. (authored by courbet).
[clang-tidy] new performance-no-automatic-move check.
Nov 21 2019, 11:55 PM
courbet closed D70390: [clang-tidy] new performance-no-automatic-move check..
Nov 21 2019, 11:55 PM · Restricted Project, Restricted Project
courbet committed rG036790f98899: [DAGCombiner] Allow zextended load combines. (authored by courbet).
[DAGCombiner] Allow zextended load combines.
Nov 21 2019, 11:46 PM
courbet closed D70487: [DAGCombiner] Allow zextended load combines..
Nov 21 2019, 11:46 PM · Restricted Project
courbet added a comment to D70390: [clang-tidy] new performance-no-automatic-move check..

Thanks for the review.

Nov 21 2019, 11:46 PM · Restricted Project, Restricted Project
courbet updated the diff for D70390: [clang-tidy] new performance-no-automatic-move check..

Use LLVM style

Nov 21 2019, 11:46 PM · Restricted Project, Restricted Project
courbet added a comment to D70487: [DAGCombiner] Allow zextended load combines..

Thanks for the review.

Nov 21 2019, 6:54 AM · Restricted Project
courbet updated the diff for D70487: [DAGCombiner] Allow zextended load combines..

Use the right triple for big-endian thumb.

Nov 21 2019, 6:17 AM · Restricted Project
courbet added inline comments to D70487: [DAGCombiner] Allow zextended load combines..
Nov 21 2019, 6:10 AM · Restricted Project
courbet committed rGb25f98584876: [DAGCombiner] Use the right thumbv7meb triple for ARM big-endian test. (authored by courbet).
[DAGCombiner] Use the right thumbv7meb triple for ARM big-endian test.
Nov 21 2019, 6:08 AM
courbet updated the diff for D70390: [clang-tidy] new performance-no-automatic-move check..

Address comments.

Nov 21 2019, 4:52 AM · Restricted Project, Restricted Project
courbet committed rG12a88f0128ea: [DAGCombiner] Add tests for thumb load-combine. (authored by courbet).
[DAGCombiner] Add tests for thumb load-combine.
Nov 21 2019, 4:22 AM
courbet updated the diff for D70487: [DAGCombiner] Allow zextended load combines..

Rebase on thumb tests.

Nov 21 2019, 4:22 AM · Restricted Project
courbet added inline comments to D70487: [DAGCombiner] Allow zextended load combines..
Nov 21 2019, 4:22 AM · Restricted Project
courbet updated the diff for D70487: [DAGCombiner] Allow zextended load combines..

Address comments.

Nov 21 2019, 1:39 AM · Restricted Project
courbet retitled D70487: [DAGCombiner] Allow zextended load combines. from Summary: [DAGCombiner] Allow zextended load combines. to [DAGCombiner] Allow zextended load combines..
Nov 21 2019, 1:39 AM · Restricted Project
courbet updated the diff for D70487: [DAGCombiner] Allow zextended load combines..

When zero-extending, check the legality of the zero-extended load.

Nov 21 2019, 1:19 AM · Restricted Project
courbet updated the diff for D70487: [DAGCombiner] Allow zextended load combines..

Be conservative on ARM and do not introduce illegal BSWAPs when zero-extending.

Nov 21 2019, 1:18 AM · Restricted Project
courbet added inline comments to D70487: [DAGCombiner] Allow zextended load combines..
Nov 21 2019, 1:18 AM · Restricted Project
courbet updated the diff for D70487: [DAGCombiner] Allow zextended load combines..

rebase on NFC change

Nov 21 2019, 12:36 AM · Restricted Project

Nov 20 2019

courbet committed rG252567377c5e: [DAGCombine][NFC] Use ArrayRef and correctly size SmallVectors. (authored by courbet).
[DAGCombine][NFC] Use ArrayRef and correctly size SmallVectors.
Nov 20 2019, 11:56 PM
courbet added inline comments to D70487: [DAGCombiner] Allow zextended load combines..
Nov 20 2019, 9:36 AM · Restricted Project
courbet committed rG23c76792081e: [CodeGen][NFC] Regenerate load-combine test with update_llc_test. (authored by courbet).
[CodeGen][NFC] Regenerate load-combine test with update_llc_test.
Nov 20 2019, 4:37 AM
courbet updated the diff for D70487: [DAGCombiner] Allow zextended load combines..

Rebase to show test diffs.

Nov 20 2019, 4:37 AM · Restricted Project
courbet created D70487: [DAGCombiner] Allow zextended load combines..
Nov 20 2019, 4:14 AM · Restricted Project
courbet updated the diff for D70390: [clang-tidy] new performance-no-automatic-move check..

Remove && warnings.

Nov 20 2019, 12:33 AM · Restricted Project, Restricted Project
courbet added a comment to D70390: [clang-tidy] new performance-no-automatic-move check..

that sounds like a big non-local change whose correctness would be very difficult to verify.

Nov 20 2019, 12:09 AM · Restricted Project, Restricted Project
courbet planned changes to D70390: [clang-tidy] new performance-no-automatic-move check..

I'm going to remove the && warning from the check and keep only the const one, as I think these is a consensus on that.

Nov 20 2019, 12:09 AM · Restricted Project, Restricted Project

Nov 19 2019

courbet added a comment to D70390: [clang-tidy] new performance-no-automatic-move check..

IMHO these two should just not overlap. It makes sense, to have controversial or configurable stuff in clang-tidy. It should just be consistent with the warnings, as those are "always right" and clang-tidy can be opinionated/specialized.

Nov 19 2019, 1:43 AM · Restricted Project, Restricted Project
courbet updated subscribers of D70390: [clang-tidy] new performance-no-automatic-move check..
Nov 19 2019, 12:22 AM · Restricted Project, Restricted Project
courbet added a comment to D70390: [clang-tidy] new performance-no-automatic-move check..

Adding @Quuxplusone (warning author) for opinions.

Nov 19 2019, 12:22 AM · Restricted Project, Restricted Project
courbet reclaimed D70390: [clang-tidy] new performance-no-automatic-move check..

Actually, thinking more about this, adding this to the existing warning might not be a very consensual change. In the case of the warning:

Nov 19 2019, 12:22 AM · Restricted Project, Restricted Project

Nov 18 2019

courbet abandoned D70390: [clang-tidy] new performance-no-automatic-move check..
Nov 18 2019, 11:47 PM · Restricted Project, Restricted Project
courbet updated the diff for D70390: [clang-tidy] new performance-no-automatic-move check..

Address comments.

Nov 18 2019, 7:16 AM · Restricted Project, Restricted Project
courbet added a comment to D70390: [clang-tidy] new performance-no-automatic-move check..

Thanks.

Nov 18 2019, 7:16 AM · Restricted Project, Restricted Project
courbet updated the diff for D70390: [clang-tidy] new performance-no-automatic-move check..

Fix markdown in doc.

Nov 18 2019, 6:48 AM · Restricted Project, Restricted Project
courbet added a comment to D70390: [clang-tidy] new performance-no-automatic-move check..

Thanks for the comments

Nov 18 2019, 6:48 AM · Restricted Project, Restricted Project
courbet added a reviewer for D70390: [clang-tidy] new performance-no-automatic-move check.: JonasToth.
Nov 18 2019, 6:48 AM · Restricted Project, Restricted Project
courbet created D70390: [clang-tidy] new performance-no-automatic-move check..
Nov 18 2019, 5:18 AM · Restricted Project, Restricted Project

Nov 5 2019

courbet added a comment to D69044: [X86] Allow up to 4 loads per inline memcmp().

No, we only have SSE2 and above.

Nov 5 2019, 7:42 AM · Restricted Project
courbet added a comment to D69044: [X86] Allow up to 4 loads per inline memcmp().

I don't remember cases where we had very large constant compares (though we do have quite a lot of small ones). I'll run our internal benchmarks with this change.

Nov 5 2019, 7:23 AM · Restricted Project

Oct 31 2019

courbet added a comment to D69044: [X86] Allow up to 4 loads per inline memcmp().

I don't remember cases where we had very large constant compares (though we do have quite a lot of small ones). I'll run our internal benchmarks with this change.

Oct 31 2019, 5:37 AM · Restricted Project

Oct 24 2019

courbet accepted D69307: [Alignment][NFC] getMemoryOpCost uses MaybeAlign.
Oct 24 2019, 2:32 AM · Restricted Project

Oct 23 2019

courbet accepted D69301: [Alignment][NFC] Convert AllocaInst to MaybeAlign.
Oct 23 2019, 2:27 AM · Restricted Project
courbet accepted D69307: [Alignment][NFC] getMemoryOpCost uses MaybeAlign.
Oct 23 2019, 2:27 AM · Restricted Project

Oct 22 2019

courbet accepted D69303: [Alignment][NFC] Convert StoreInst to MaybeAlign.
Oct 22 2019, 5:43 AM · Restricted Project
courbet accepted D69302: [Alignment][NFC] Convert LoadInst to MaybeAlign.
Oct 22 2019, 5:24 AM · Restricted Project
courbet added inline comments to D69301: [Alignment][NFC] Convert AllocaInst to MaybeAlign.
Oct 22 2019, 5:15 AM · Restricted Project
courbet accepted D69300: [Alignment][NFC] Use MaybeAlign in AttrBuilder.
Oct 22 2019, 4:39 AM · Restricted Project
courbet accepted D69278: [Alignment][NFC] Attributes use Align/MaybeAlign.
Oct 22 2019, 2:49 AM · Restricted Project
courbet added inline comments to D69278: [Alignment][NFC] Attributes use Align/MaybeAlign.
Oct 22 2019, 12:21 AM · Restricted Project

Oct 21 2019

courbet accepted D69253: [Alignment][NFC] Finish transition for `Loads`.
Oct 21 2019, 7:53 AM · Restricted Project
courbet accepted D69256: [Alignment][NFC] Instructions::getLoadStoreAlignment.
Oct 21 2019, 7:43 AM · Restricted Project
courbet accepted D69258: [Alignment][NFC] Add a helper function to DataLayout.
Oct 21 2019, 6:52 AM · Restricted Project
courbet added inline comments to D69253: [Alignment][NFC] Finish transition for `Loads`.
Oct 21 2019, 6:08 AM · Restricted Project
courbet accepted D69248: [Alignment][NFC] TargetCallingConv::setByValAlign.
Oct 21 2019, 4:26 AM · Restricted Project
courbet accepted D69243: [Alignment][NFC] TargetCallingConv::setOrigAlign and TargetLowering::getABIAlignmentForCallingConv.
Oct 21 2019, 2:42 AM · Restricted Project
courbet accepted D69216: Use Align for TFL::TransientStackAlignment.
Oct 21 2019, 12:11 AM · Restricted Project

Oct 17 2019

courbet accepted D68993: [Alignment][NFC] Use Align for TargetFrameLowering/Subtarget.
Oct 17 2019, 12:30 AM · Restricted Project

Oct 16 2019

courbet requested changes to D69034: [Alignment] Use Align for TFI.getStackAlignment() in X86ISelLowering.
Oct 16 2019, 7:01 AM · Restricted Project
courbet accepted D69023: [Alignment][NFC] Optimize alignTo.
Oct 16 2019, 2:35 AM · Restricted Project
courbet added inline comments to D69023: [Alignment][NFC] Optimize alignTo.
Oct 16 2019, 2:08 AM · Restricted Project