Page MenuHomePhabricator

seiya (Seiya Nuta)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2019, 8:08 PM (20 w, 1 d)

Recent Activity

Today

seiya planned changes to D66407: [llvm-objcopy][MachO] Implement -Ibinary.

I'll add another patch to isolate changes to CopyConfig.

Mon, Aug 19, 3:04 AM · Restricted Project
seiya added a parent revision for D66409: [llvm-objcopy][MachO] Implement -Obinary: D66408: [llvm-objcopy][MachO] Implement --dump-section.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a child revision for D66407: [llvm-objcopy][MachO] Implement -Ibinary: D66408: [llvm-objcopy][MachO] Implement --dump-section.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a child revision for D66408: [llvm-objcopy][MachO] Implement --dump-section: D66409: [llvm-objcopy][MachO] Implement -Obinary.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a parent revision for D66408: [llvm-objcopy][MachO] Implement --dump-section: D66407: [llvm-objcopy][MachO] Implement -Ibinary.
Mon, Aug 19, 1:58 AM · Restricted Project
seiya added a child revision for D66283: [llvm-objcopy][MachO] Implement --add-section: D66407: [llvm-objcopy][MachO] Implement -Ibinary.
Mon, Aug 19, 1:57 AM · Restricted Project
seiya added a parent revision for D66407: [llvm-objcopy][MachO] Implement -Ibinary: D66283: [llvm-objcopy][MachO] Implement --add-section.
Mon, Aug 19, 1:57 AM · Restricted Project
Herald added a reviewer for D66409: [llvm-objcopy][MachO] Implement -Obinary: rupprecht.
Mon, Aug 19, 1:57 AM · Restricted Project
Herald added a reviewer for D66408: [llvm-objcopy][MachO] Implement --dump-section: rupprecht.
Mon, Aug 19, 1:57 AM · Restricted Project
Herald added a reviewer for D66407: [llvm-objcopy][MachO] Implement -Ibinary: rupprecht.
Mon, Aug 19, 1:57 AM · Restricted Project
seiya added inline comments to D66281: [llvm-objcopy][MachO] Implement --strip-all.
Mon, Aug 19, 1:47 AM · Restricted Project
seiya updated the diff for D66281: [llvm-objcopy][MachO] Implement --strip-all.

Addressed review comments.

Mon, Aug 19, 1:47 AM · Restricted Project
seiya added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

Ah, it looks this broke because it adds a new file to CMakeLists.txt. Just confirm, can I ignore such breakage? It will be resolved by a "gn build: Merge ..." commit.

Mon, Aug 19, 12:24 AM · Restricted Project
seiya added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

I've reverted this patch due to the CI build breakage on sanitizer-x86_64-linux-gn.

Mon, Aug 19, 12:06 AM · Restricted Project

Yesterday

seiya committed rG1e335611adc8: Revert r369230 and r369231 (authored by seiya).
Revert r369230 and r369231
Sun, Aug 18, 11:48 PM
seiya committed rL369234: Revert r369230 and r369231.
Revert r369230 and r369231
Sun, Aug 18, 11:48 PM
seiya committed rGdee9546b8f83: [llvm-objcopy][MachO] Implement a layout algorithm for executables (authored by seiya).
[llvm-objcopy][MachO] Implement a layout algorithm for executables
Sun, Aug 18, 10:44 PM
seiya committed rG4a198a7f9908: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries (authored by seiya).
[llvm-objcopy][MachO] Support load commands used in executables/shared libraries
Sun, Aug 18, 10:44 PM
seiya committed rL369231: [llvm-objcopy][MachO] Implement a layout algorithm for executables.
[llvm-objcopy][MachO] Implement a layout algorithm for executables
Sun, Aug 18, 10:44 PM
seiya closed D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.
Sun, Aug 18, 10:43 PM · Restricted Project
seiya committed rL369230: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
[llvm-objcopy][MachO] Support load commands used in executables/shared libraries
Sun, Aug 18, 10:36 PM
seiya closed D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Sun, Aug 18, 10:36 PM · Restricted Project
seiya updated the diff for D65540: [llvm-objcopy][MachO] Fix method names. NFC..

Rebase for the sake of arc patch.

Sun, Aug 18, 10:35 PM · Restricted Project
seiya updated the diff for D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.

Rebase for the sake of arc patch.

Sun, Aug 18, 10:35 PM · Restricted Project
seiya updated the diff for D65540: [llvm-objcopy][MachO] Fix method names. NFC..

Rebase for the sake of arc patch.

Sun, Aug 18, 10:35 PM · Restricted Project
seiya updated the diff for D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.

Rebase for the sake of arc patch.

Sun, Aug 18, 10:35 PM · Restricted Project
seiya updated the diff for D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

Rebase for the sake of arc patch.

Sun, Aug 18, 10:35 PM · Restricted Project
seiya updated the diff for D66280: [llvm-objcopy][MachO] Support indirect symbol table.
  • Updated the test.
Sun, Aug 18, 10:08 PM · Restricted Project
seiya updated the diff for D66280: [llvm-objcopy][MachO] Support indirect symbol table.
  • Addressed a review comment.
  • Added a test.
Sun, Aug 18, 10:08 PM · Restricted Project
seiya updated the diff for D66283: [llvm-objcopy][MachO] Implement --add-section.
  • Added a newline at the end of file.
Sun, Aug 18, 9:17 PM · Restricted Project
seiya updated the diff for D66283: [llvm-objcopy][MachO] Implement --add-section.

Refactored a bit.

Sun, Aug 18, 9:17 PM · Restricted Project
seiya updated the diff for D66282: [llvm-objcopy][MachO] Implement --remove-section.
  • Added a comment in the test.
Sun, Aug 18, 9:13 PM · Restricted Project
seiya updated the diff for D65541: [llvm-objcopy][MachO] Implement --only-section.

Refactored a bit.

Sun, Aug 18, 9:13 PM · Restricted Project

Fri, Aug 16

seiya added inline comments to D65191: [llvm-objdump] Implement highlighting.
Fri, Aug 16, 2:56 AM · Restricted Project
seiya added a comment to D65540: [llvm-objcopy][MachO] Fix method names. NFC..

@seiya i think this diff is safe to commit (if it has not been committed yet)

Fri, Aug 16, 2:49 AM · Restricted Project
seiya added inline comments to D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Fri, Aug 16, 2:29 AM · Restricted Project

Thu, Aug 15

seiya updated the diff for D66283: [llvm-objcopy][MachO] Implement --add-section.
  • Addressed review comments.
Thu, Aug 15, 8:05 PM · Restricted Project
seiya added inline comments to D66283: [llvm-objcopy][MachO] Implement --add-section.
Thu, Aug 15, 8:05 PM · Restricted Project
seiya updated the diff for D66282: [llvm-objcopy][MachO] Implement --remove-section.
  • Addressed review comments.
Thu, Aug 15, 7:09 PM · Restricted Project
seiya added inline comments to D65541: [llvm-objcopy][MachO] Implement --only-section.
Thu, Aug 15, 6:48 PM · Restricted Project
seiya updated the diff for D65541: [llvm-objcopy][MachO] Implement --only-section.
  • Updated CommandGuide.
  • Addressed a review comment.
Thu, Aug 15, 6:48 PM · Restricted Project
seiya planned changes to D66280: [llvm-objcopy][MachO] Support indirect symbol table.

I'll upload a test for this later.

Thu, Aug 15, 3:08 AM · Restricted Project
seiya added inline comments to D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Thu, Aug 15, 3:08 AM · Restricted Project
seiya added a parent revision for D66282: [llvm-objcopy][MachO] Implement --remove-section: D66281: [llvm-objcopy][MachO] Implement --strip-all.
Thu, Aug 15, 2:43 AM · Restricted Project
seiya added a parent revision for D66283: [llvm-objcopy][MachO] Implement --add-section: D66282: [llvm-objcopy][MachO] Implement --remove-section.
Thu, Aug 15, 2:43 AM · Restricted Project
seiya added a child revision for D66282: [llvm-objcopy][MachO] Implement --remove-section: D66283: [llvm-objcopy][MachO] Implement --add-section.
Thu, Aug 15, 2:43 AM · Restricted Project
seiya added a parent revision for D66281: [llvm-objcopy][MachO] Implement --strip-all: D66280: [llvm-objcopy][MachO] Support indirect symbol table.
Thu, Aug 15, 2:43 AM · Restricted Project
seiya added a child revision for D66280: [llvm-objcopy][MachO] Support indirect symbol table: D66281: [llvm-objcopy][MachO] Implement --strip-all.
Thu, Aug 15, 2:43 AM · Restricted Project
seiya added a child revision for D66281: [llvm-objcopy][MachO] Implement --strip-all: D66282: [llvm-objcopy][MachO] Implement --remove-section.
Thu, Aug 15, 2:43 AM · Restricted Project
seiya added a parent revision for D66280: [llvm-objcopy][MachO] Support indirect symbol table: D65541: [llvm-objcopy][MachO] Implement --only-section.
Thu, Aug 15, 2:40 AM · Restricted Project
seiya added a child revision for D65541: [llvm-objcopy][MachO] Implement --only-section: D66280: [llvm-objcopy][MachO] Support indirect symbol table.
Thu, Aug 15, 2:40 AM · Restricted Project
seiya updated the diff for D66283: [llvm-objcopy][MachO] Implement --add-section.
  • Removed trailing whitespaces.
Thu, Aug 15, 2:40 AM · Restricted Project
Herald added a reviewer for D66282: [llvm-objcopy][MachO] Implement --remove-section: rupprecht.
Thu, Aug 15, 2:40 AM · Restricted Project
Herald added a reviewer for D66283: [llvm-objcopy][MachO] Implement --add-section: rupprecht.
Thu, Aug 15, 2:40 AM · Restricted Project
seiya created D66281: [llvm-objcopy][MachO] Implement --strip-all.
Thu, Aug 15, 2:40 AM · Restricted Project
Herald added a reviewer for D66280: [llvm-objcopy][MachO] Support indirect symbol table: rupprecht.
Thu, Aug 15, 2:40 AM · Restricted Project
seiya updated the diff for D65189: [MC] Support returning marked up ranges in the disassembly.
  • Removed redundant whitespaces.
Thu, Aug 15, 2:31 AM · Restricted Project
seiya updated the diff for D65541: [llvm-objcopy][MachO] Implement --only-section.
  • Added some newlines for readability.
Thu, Aug 15, 1:39 AM · Restricted Project
seiya updated the diff for D65541: [llvm-objcopy][MachO] Implement --only-section.
  • Improved the test cases.
Thu, Aug 15, 1:39 AM · Restricted Project
seiya updated the diff for D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.
  • Added const.
Thu, Aug 15, 1:32 AM · Restricted Project
seiya added inline comments to D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.
Thu, Aug 15, 1:32 AM · Restricted Project
seiya committed rG0a3b1b26287a: [llvm-readobj][MachO] Fix section type printing (authored by seiya).
[llvm-readobj][MachO] Fix section type printing
Thu, Aug 15, 12:23 AM
seiya committed rL368974: [llvm-readobj][MachO] Fix section type printing.
[llvm-readobj][MachO] Fix section type printing
Thu, Aug 15, 12:22 AM
seiya closed D66075: [llvm-readobj][MachO] Fix section type printing.
Thu, Aug 15, 12:22 AM · Restricted Project

Tue, Aug 13

seiya added a comment to D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.

Friendly ping.

Tue, Aug 13, 7:28 PM · Restricted Project
seiya updated the diff for D65189: [MC] Support returning marked up ranges in the disassembly.
  • Improved comments for WithMarkup a bit.
Tue, Aug 13, 7:28 PM · Restricted Project
seiya updated the diff for D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
  • Removed an unused declaration.
Tue, Aug 13, 7:24 PM · Restricted Project
seiya added inline comments to D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Tue, Aug 13, 7:21 PM · Restricted Project
seiya updated the diff for D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
  • Use withMarkup().
  • Remove printMarkedUpRegName (start/end/withMarkup are made const by changes in D65189).
Tue, Aug 13, 7:21 PM · Restricted Project
seiya updated the diff for D65189: [MC] Support returning marked up ranges in the disassembly.
Tue, Aug 13, 7:16 PM · Restricted Project
seiya added inline comments to D66075: [llvm-readobj][MachO] Fix section type printing.
Tue, Aug 13, 6:24 PM · Restricted Project
seiya updated the diff for D66075: [llvm-readobj][MachO] Fix section type printing.
  • Addressed review comments.
    • Replaced magic numbers with enum MachO::SectionType.
    • Renamed some section types.
Tue, Aug 13, 6:16 PM · Restricted Project
seiya added a comment to D65189: [MC] Support returning marked up ranges in the disassembly.

Updated the title and description. Thanks @jhenderson!

Tue, Aug 13, 6:04 PM · Restricted Project
seiya updated the summary of D65189: [MC] Support returning marked up ranges in the disassembly.
Tue, Aug 13, 6:03 PM · Restricted Project
seiya retitled D65189: [MC] Support returning marked up ranges in the disassembly from [MC] Support returning a structured rich disassembly output to [MC] Support returning marked up ranges in the disassembly.
Tue, Aug 13, 6:02 PM · Restricted Project

Mon, Aug 12

seiya added a comment to D65189: [MC] Support returning marked up ranges in the disassembly.

You should update your patch title and description too.

Mon, Aug 12, 11:26 PM · Restricted Project
seiya updated the diff for D65189: [MC] Support returning marked up ranges in the disassembly.
  • Updated comments.
Mon, Aug 12, 11:20 PM · Restricted Project
seiya updated the summary of D65189: [MC] Support returning marked up ranges in the disassembly.
Mon, Aug 12, 10:53 PM · Restricted Project
seiya updated the diff for D66075: [llvm-readobj][MachO] Fix section type printing.

Add llvm/test/tools/llvm-readobj/macho-sections.test, which exhaustively tests all section types.

Mon, Aug 12, 10:25 PM · Restricted Project
seiya added a comment to D66075: [llvm-readobj][MachO] Fix section type printing.

Thank you for pointing out the related commits, @rupprecht!

Mon, Aug 12, 8:30 PM · Restricted Project
seiya added inline comments to D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Mon, Aug 12, 3:30 AM · Restricted Project
seiya added reviewers for D66075: [llvm-readobj][MachO] Fix section type printing: jhenderson, rupprecht, alexshap.
Mon, Aug 12, 2:01 AM · Restricted Project
seiya updated the summary of D66075: [llvm-readobj][MachO] Fix section type printing.
Mon, Aug 12, 2:01 AM · Restricted Project
seiya created D66075: [llvm-readobj][MachO] Fix section type printing.
Mon, Aug 12, 2:01 AM · Restricted Project
seiya added inline comments to D65191: [llvm-objdump] Implement highlighting.
Mon, Aug 12, 2:00 AM · Restricted Project
seiya added inline comments to D65191: [llvm-objdump] Implement highlighting.
Mon, Aug 12, 1:58 AM · Restricted Project
seiya added inline comments to D65189: [MC] Support returning marked up ranges in the disassembly.
Mon, Aug 12, 12:07 AM · Restricted Project
seiya updated the diff for D65189: [MC] Support returning marked up ranges in the disassembly.
  • Added WithMarkup.
  • Added class-level comments for MarkupStart and MarkupEnd.
Mon, Aug 12, 12:07 AM · Restricted Project

Fri, Aug 9

seiya added inline comments to D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.
Fri, Aug 9, 12:29 AM · Restricted Project
seiya updated the diff for D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.

Addressed review comments.

Fri, Aug 9, 12:27 AM · Restricted Project

Wed, Aug 7

seiya added inline comments to D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.
Wed, Aug 7, 10:32 PM · Restricted Project
seiya updated the diff for D65799: [yaml2obj/obj2yaml][MachO] Allow setting custom section data.

Addressed review comments.

Wed, Aug 7, 10:10 PM · Restricted Project
seiya added inline comments to D65191: [llvm-objdump] Implement highlighting.
Wed, Aug 7, 9:04 PM · Restricted Project
seiya updated the diff for D65191: [llvm-objdump] Implement highlighting.
  • Enable syntax highlighting by default.
  • Added WithColor::colorsAvailable
    • I'll submit this as a separate patch if it's a good approach.
  • Replaced the lengthy YAML with a hand-assembled shorter one.
Wed, Aug 7, 8:53 PM · Restricted Project
seiya planned changes to D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.

I'll try out the destructor approach suggested by @rupprecht in D65189.

Wed, Aug 7, 7:45 PM · Restricted Project
seiya planned changes to D65189: [MC] Support returning marked up ranges in the disassembly.

I'll try out the destructor approach suggested by @rupprecht.

Wed, Aug 7, 7:45 PM · Restricted Project
seiya added inline comments to D65191: [llvm-objdump] Implement highlighting.
Wed, Aug 7, 4:18 AM · Restricted Project
seiya updated the diff for D65191: [llvm-objdump] Implement highlighting.
  • Addressed review comments.
Wed, Aug 7, 4:15 AM · Restricted Project

Tue, Aug 6

seiya updated the diff for D65539: [llvm-objcopy][MachO] Implement a layout algorithm for executables.
  • Fixed review comments.
Tue, Aug 6, 3:45 PM · Restricted Project
seiya updated the diff for D65541: [llvm-objcopy][MachO] Implement --only-section.

Re-upload the diff: the previous update was mistake.

Tue, Aug 6, 3:45 PM · Restricted Project