Page MenuHomePhabricator

seiya (Seiya Nuta)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2019, 8:08 PM (12 w, 3 d)

Recent Activity

Yesterday

seiya committed rG81eb82840524: [llvm-objcopy][NFCI] Fix build failure with GCC (authored by seiya).
[llvm-objcopy][NFCI] Fix build failure with GCC
Mon, Jun 24, 6:09 PM
seiya committed rL364263: [llvm-objcopy][NFCI] Fix build failure with GCC.
[llvm-objcopy][NFCI] Fix build failure with GCC
Mon, Jun 24, 6:08 PM
seiya committed rG545f001d1b9a: [llvm-objcopy][NFC] Refactor output target parsing (authored by seiya).
[llvm-objcopy][NFC] Refactor output target parsing
Mon, Jun 24, 5:04 PM
seiya committed rL364254: [llvm-objcopy][NFC] Refactor output target parsing.
[llvm-objcopy][NFC] Refactor output target parsing
Mon, Jun 24, 5:03 PM
seiya closed D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Mon, Jun 24, 5:03 PM · Restricted Project
seiya committed rG323b89f101bc: [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI (authored by seiya).
[llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI
Mon, Jun 24, 4:41 PM
seiya committed rL364252: [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI.
[llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI
Mon, Jun 24, 4:40 PM
seiya closed D63699: [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI.
Mon, Jun 24, 4:40 PM · Restricted Project

Sun, Jun 23

Herald added a reviewer for D63699: [llvm-objcopy][MachO] Fix strict-aliasing warning. NFCI: rupprecht.
Sun, Jun 23, 7:28 PM · Restricted Project

Thu, Jun 20

seiya added a comment to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

Ah, should MachOLayoutBuilder be a separate NFC patch?

Thu, Jun 20, 6:23 PM · Restricted Project
seiya updated the diff for D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
  • Isolate the logic which modifies the object (e.g. updating file offsets) into MachOLayoutBuilder.cpp
Thu, Jun 20, 6:17 PM · Restricted Project
seiya committed rGf923d9b53f22: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer (authored by seiya).
[llvm-objcopy][MachO] Rebuild the symbol/string table in the writer
Thu, Jun 20, 5:22 PM
seiya committed rL364000: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
[llvm-objcopy][MachO] Rebuild the symbol/string table in the writer
Thu, Jun 20, 5:18 PM
seiya closed D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
Thu, Jun 20, 5:18 PM · Restricted Project
seiya planned changes to D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.

I'll separate the layout logic into a new class: MachOLayoutBuilder

Thu, Jun 20, 2:35 AM · Restricted Project

Wed, Jun 19

seiya added a comment to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.

Just to double check - do the existing tests pass with this patch ? If so - LGTM

Wed, Jun 19, 10:21 PM · Restricted Project
seiya added inline comments to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
Wed, Jun 19, 7:21 PM · Restricted Project
seiya updated the diff for D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
  • Move StrTableBuilder into MachOWriter.
Wed, Jun 19, 7:21 PM · Restricted Project
seiya added inline comments to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
Wed, Jun 19, 7:15 PM · Restricted Project
seiya updated the diff for D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
  • Addressed review comments.
Wed, Jun 19, 7:06 PM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • We -> we
Wed, Jun 19, 6:53 PM · Restricted Project

Tue, Jun 18

seiya added inline comments to D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
Tue, Jun 18, 7:22 PM · Restricted Project
seiya updated the diff for D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.

Addressed review comments.

Tue, Jun 18, 7:21 PM · Restricted Project
seiya updated the diff for D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
  • Fix a comment.
  • Use arrayRefFromStringRef.
  • Use emplace_back.
Tue, Jun 18, 6:35 PM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • Updated a comment.
Tue, Jun 18, 6:20 PM · Restricted Project

Mon, Jun 17

seiya added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Mon, Jun 17, 7:26 PM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • Refactored a bit.
Mon, Jun 17, 7:25 PM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • Addressed some review comments.
Mon, Jun 17, 7:09 PM · Restricted Project
seiya added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Mon, Jun 17, 6:15 PM · Restricted Project
seiya retitled D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries from [llvm-objcopy][MachO] Copy load commands used in executables and shared libraries to [llvm-objcopy][MachO] Support load commands used in executables/shared libraries.
Mon, Jun 17, 5:48 PM · Restricted Project

Sun, Jun 16

Herald added a reviewer for D63395: [llvm-objcopy][MachO] Support load commands used in executables/shared libraries: rupprecht.
Sun, Jun 16, 8:48 PM · Restricted Project
seiya committed rG4f1573206760: [yaml2obj][MachO] Don't fill dummy data for virtual sections (authored by seiya).
[yaml2obj][MachO] Don't fill dummy data for virtual sections
Sun, Jun 16, 7:07 PM
seiya committed rL363525: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
[yaml2obj][MachO] Don't fill dummy data for virtual sections
Sun, Jun 16, 7:06 PM
seiya closed D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Sun, Jun 16, 7:06 PM · Restricted Project
seiya committed rG13de174b4c48: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target (authored by seiya).
[llvm-objcopy] Add elf32-sparc and elf32-sparcel target
Sun, Jun 16, 7:01 PM
seiya committed rL363524: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
[llvm-objcopy] Add elf32-sparc and elf32-sparcel target
Sun, Jun 16, 7:01 PM
seiya closed D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
Sun, Jun 16, 7:01 PM · Restricted Project
seiya added a comment to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

Thank you I'll commit this.

Sun, Jun 16, 6:53 PM · Restricted Project

Fri, Jun 14

seiya retitled D63239: [llvm-objcopy][NFC] Refactor output target parsing from [llvm-objcopy] Refactor output target parsing to [llvm-objcopy][NFC] Refactor output target parsing.
Fri, Jun 14, 3:25 AM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • Explicate the type instead of auto.
Fri, Jun 14, 3:25 AM · Restricted Project
seiya added a comment to D63239: [llvm-objcopy][NFC] Refactor output target parsing.

LGTM, with one nit. Also, if I understand it correctly, this change should have no functional change, right? In that case, please tag the summary with [NFC] (i.e. [llvm-objcopy][NFC] Refactor output target parsing) when you commit.

Fri, Jun 14, 3:25 AM · Restricted Project

Thu, Jun 13

seiya updated the summary of D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer.
Thu, Jun 13, 5:28 PM · Restricted Project
Herald added a reviewer for D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer: rupprecht.
Thu, Jun 13, 5:25 PM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • Removed a temprary file accidentally included in the patch.
Thu, Jun 13, 5:00 PM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • Addressed review comments.
  • Resolved conflicts with origin/master.
Thu, Jun 13, 5:00 PM · Restricted Project
seiya updated the summary of D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
Thu, Jun 13, 4:39 PM · Restricted Project
seiya retitled D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target from [llvm-objcopy] Add elf32-sparc target to [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
Thu, Jun 13, 4:34 PM · Restricted Project
seiya updated the diff for D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
Thu, Jun 13, 4:34 PM · Restricted Project
seiya committed rGb1027a480ac3: [llvm-objcopy] Fix sparc target endianness (authored by seiya).
[llvm-objcopy] Fix sparc target endianness
Thu, Jun 13, 4:22 PM
seiya committed rL363336: [llvm-objcopy] Fix sparc target endianness.
[llvm-objcopy] Fix sparc target endianness
Thu, Jun 13, 4:21 PM
seiya closed D63251: [llvm-objcopy] Fix sparc target endianness.
Thu, Jun 13, 4:21 PM · Restricted Project
seiya updated the diff for D63251: [llvm-objcopy] Fix sparc target endianness.

Address a review comment.

Thu, Jun 13, 5:04 AM · Restricted Project
seiya created D63251: [llvm-objcopy] Fix sparc target endianness.
Thu, Jun 13, 4:18 AM · Restricted Project
seiya added a comment to D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.

Looks good, I think, but does GNU objcopy have sparc as -I/-O type? Is the syntax the same as you have used?

Yes, it has the same target name. I'm not familiar with SPARC at all, but now I noticed that 32-bit SPARC is big endian and gnu-objcopy -Oelf32-sparc certainly emits a big endian ELF file. I think I should fix the SPARC entry in ArchMap before committing this patch. What do you think on this?

I'm not familiar with SPARC either. Are you confident about it being big endian? If so, fixing the map seems fine and relevant. I have no problem with you adding the sparcel target if you want.

Thu, Jun 13, 4:05 AM · Restricted Project
seiya added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Thu, Jun 13, 3:43 AM · Restricted Project
seiya updated the diff for D63239: [llvm-objcopy][NFC] Refactor output target parsing.
  • Replaced std::pair with a struct.
  • Refer -> See
Thu, Jun 13, 3:43 AM · Restricted Project
seiya added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Thu, Jun 13, 3:31 AM · Restricted Project
seiya added a comment to D63239: [llvm-objcopy][NFC] Refactor output target parsing.

Could you explain a bit more the motivation behind this change, please? If I'm not mistaken, it's to allow using input and output format with non-ELF (e.g. COFF and Mach-O) targets?

Thu, Jun 13, 3:30 AM · Restricted Project
seiya added a comment to D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.

In LLVM, there's a target named SPARCV8el, the 32-bit little-endian SPARC target so adding sparc/ sparcel into ArchMap and elf32-sparc/elf32-sparcel into OutputFormatMap would be better I think.

Thu, Jun 13, 3:19 AM · Restricted Project
seiya added a comment to D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.

Looks good, I think, but does GNU objcopy have sparc as -I/-O type? Is the syntax the same as you have used?

Thu, Jun 13, 3:13 AM · Restricted Project

Wed, Jun 12

seiya added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Wed, Jun 12, 8:47 PM · Restricted Project
seiya abandoned D63184: [llvm-objcopy] Recognize the output file format other than ELF.

Splitted into separate patches:

Wed, Jun 12, 5:44 PM · Restricted Project
seiya created D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Wed, Jun 12, 5:43 PM · Restricted Project
seiya created D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
Wed, Jun 12, 5:11 PM · Restricted Project
seiya added a comment to D63184: [llvm-objcopy] Recognize the output file format other than ELF.

@seiya, it looks like what you've observed in the tests is https://bugs.llvm.org/show_bug.cgi?id=42171. Can you confirm, and if so update the bug accordingly?

I feel like there might be three different patches here, rather than one big one. The first one is the bug fix (with corresponding test changes), the second is the sparc format issue, and the third is the work your title suggests this patch should be doing (i.e. changing the types). Please could you split it up, as it will make it easier to review each change separately.

Wed, Jun 12, 4:14 AM · Restricted Project
seiya updated the summary of D63184: [llvm-objcopy] Recognize the output file format other than ELF.
Wed, Jun 12, 12:31 AM · Restricted Project
seiya created D63184: [llvm-objcopy] Recognize the output file format other than ELF.
Wed, Jun 12, 12:25 AM · Restricted Project

Mon, Jun 10

seiya added inline comments to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Mon, Jun 10, 7:27 PM · Restricted Project
seiya updated the diff for D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
  • Added a TLS section.
  • Removed irrelevant sections such as __TEXT,__eh_frame.
Mon, Jun 10, 7:19 PM · Restricted Project
seiya added inline comments to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Mon, Jun 10, 6:27 PM · Restricted Project

Fri, Jun 7

seiya committed rGb728e53b957f: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer (authored by seiya).
[llvm-objcopy][MachO] Recompute and update offset/size fields in the writer
Fri, Jun 7, 6:22 PM
seiya committed rL362863: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
[llvm-objcopy][MachO] Recompute and update offset/size fields in the writer
Fri, Jun 7, 6:22 PM
seiya closed D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
Fri, Jun 7, 6:22 PM · Restricted Project
seiya added a comment to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

khm, could you please explain the rationale for this change ? If yaml2obj completely ignores virtual sections we won't be able to create a MachO binary containing them, moreover, even in some simple cases the round trip conversion yaml -> obj -> yaml will create a completely different binary. Having ability to create binaries with virtual sections overall seems to be useful for testing various tools etc.

Fri, Jun 7, 4:24 AM · Restricted Project
seiya retitled D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections from [yaml2obj][MachO] Support virtual sections to [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Fri, Jun 7, 4:13 AM · Restricted Project

Thu, Jun 6

seiya added a comment to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.

Added reviewers who may be relevant to part and my GSoC mentors.

Thu, Jun 6, 6:38 PM · Restricted Project
seiya created D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Thu, Jun 6, 6:32 PM · Restricted Project
seiya added reviewers for D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections: beanz, jhenderson, rupprecht.
Thu, Jun 6, 6:32 PM · Restricted Project
seiya added a comment to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

Thank you all. I'll commit this later.

Thu, Jun 6, 4:23 PM · Restricted Project

Wed, Jun 5

seiya added a comment to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

so in general this looks very promising to me,
however test coverage needs improvements imo, though given that at the moment we don't expose any non-trivial options here, we can add more tests incrementally. Btw - for DYSYMTAB, SYMTAB - is it possible to add YAML-based tests ? or yaml2obj's support is not sufficient for this ?

I'd also wait for @jhenderson and/or @rupprecht to take a look at this code as well.

Wed, Jun 5, 5:43 PM · Restricted Project

Mon, Jun 3

seiya updated the diff for D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

Address remaining review comments.

Mon, Jun 3, 7:43 PM · Restricted Project
seiya updated the diff for D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.

Address review comments.

Mon, Jun 3, 7:39 PM · Restricted Project

Fri, May 31

seiya updated the diff for D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
  • add some consts
Fri, May 31, 2:19 AM · Restricted Project

Thu, May 30

seiya added inline comments to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
Thu, May 30, 6:36 PM · Restricted Project
seiya added inline comments to D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
Thu, May 30, 6:31 PM · Restricted Project
seiya updated the diff for D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer.
  • Simplified various-symbols.s.
  • Replaced strlenOrMaxLen (introduced by this patch) with strnlen.
  • Replaced the hard-coded lengths of segment/section name with sizeof().
  • Renamed updateDysymtab to updateDySymTab .
  • Replaced copyStringWithPadding (introduced by this patch) with memset-ing by zero and memcpy.
  • Add const to a variable.
Thu, May 30, 6:12 PM · Restricted Project
Herald added a reviewer for D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer: rupprecht.
Thu, May 30, 5:05 AM · Restricted Project

Wed, May 29

seiya committed rG4bc710166fbd: [llvm-objcopy][MachO] Print an error message on use of unsupported options (authored by seiya).
[llvm-objcopy][MachO] Print an error message on use of unsupported options
Wed, May 29, 3:22 PM
seiya committed rL362040: [llvm-objcopy][MachO] Print an error message on use of unsupported options.
[llvm-objcopy][MachO] Print an error message on use of unsupported options
Wed, May 29, 3:22 PM
seiya closed D62578: [llvm-objcopy][MachO] Print an error message on use of unsupported options.
Wed, May 29, 3:22 PM · Restricted Project
seiya added inline comments to D62578: [llvm-objcopy][MachO] Print an error message on use of unsupported options.
Wed, May 29, 3:06 PM · Restricted Project
seiya updated the summary of D62578: [llvm-objcopy][MachO] Print an error message on use of unsupported options.
Wed, May 29, 3:53 AM · Restricted Project
seiya set the repository for D62578: [llvm-objcopy][MachO] Print an error message on use of unsupported options to rG LLVM Github Monorepo.
Wed, May 29, 3:37 AM · Restricted Project
Herald added a reviewer for D62578: [llvm-objcopy][MachO] Print an error message on use of unsupported options: rupprecht.
Wed, May 29, 3:37 AM · Restricted Project

May 22 2019

seiya committed rGada9d2d88464: [llvm-objcopy] Add file names to error messages (authored by seiya).
[llvm-objcopy] Add file names to error messages
May 22 2019, 5:41 PM
seiya committed rL361450: [llvm-objcopy] Add file names to error messages.
[llvm-objcopy] Add file names to error messages
May 22 2019, 5:40 PM
seiya closed D61993: [llvm-objcopy] Add file names to error messages.
May 22 2019, 5:40 PM · Restricted Project
seiya added a comment to D61993: [llvm-objcopy] Add file names to error messages.

Changes in 5316a0d200f8 conflicts with this patch. Should I upload this patch again here for review or should I simply resolve conflicts and push to the repository?

Use your own judgement. If the changes require significant effort to fix, then feel free to provide an updated diff, but if not, you don't need to.

May 22 2019, 6:51 AM · Restricted Project
seiya added a comment to D61993: [llvm-objcopy] Add file names to error messages.

Changes in 5316a0d200f8 conflicts with this patch. Should I upload this patch again here for review or should I simply resolve conflicts and push to the repository?

May 22 2019, 6:40 AM · Restricted Project

May 21 2019

seiya added a comment to D61993: [llvm-objcopy] Add file names to error messages.

Now I have a commit access. I'll commit this by myself. @jhenderson

May 21 2019, 9:51 PM · Restricted Project