Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (64 w, 3 d)

Recent Activity

Mon, Sep 9

rupprecht added a comment to D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour.

There's definitely a lot of new findings this creates, but it's hard to say exactly how many root causes there are due to the way test failures are (not) grouped well in the way I'm testing. So far they all seem like true positives, so this would be good to submit. However a few are positive yet benign, like this interesting one (simplified):

Mon, Sep 9, 4:20 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 6

rupprecht added a comment to D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour.

But TLDR, either the fix in https://github.com/google/filament/pull/1566
is incorrect and the actually-bad code is elsewhere,
or you have some other unsanitized UB elsewhere. Could be both :S

Fri, Sep 6, 4:29 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 5

rupprecht added a comment to D62228: Make `vector` unconditionally move elements when exceptions are disabled..

It looks like this breaks uses of std::vector with classes that are copy only (moves disabled): https://godbolt.org/z/ct2GIe
gcc/libstdc++ or clang/libc++ w/ exceptions enabled both support it.

Is this breakage intentional?

I don't think this was intentional, and I think your example should be valid. I added the test you provided to the test suite in https://reviews.llvm.org/rCXX371067, and I temporarily reverted this commit in https://reviews.llvm.org/rCXX371068. We can take a look once @EricWF is back from vacation.

Thu, Sep 5, 3:18 PM · Restricted Project, Restricted Project
rupprecht added a comment to D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour.

Still think this looks good. Have you tried running this on the llvm test suite, or some other interesting corpus? Would be curious to see any pre/post patch numbers.

Thu, Sep 5, 2:56 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 4

rupprecht added a comment to D62228: Make `vector` unconditionally move elements when exceptions are disabled..

It looks like this breaks uses of std::vector with classes that are copy only (moves disabled): https://godbolt.org/z/ct2GIe
gcc/libstdc++ or clang/libc++ w/ exceptions enabled both support it.

Wed, Sep 4, 5:09 PM · Restricted Project, Restricted Project

Tue, Sep 3

rupprecht committed rL370782: Request commit access for rupprecht.
Request commit access for rupprecht
Tue, Sep 3, 9:51 AM

Thu, Aug 29

rupprecht committed rGf9f81289e686: Revert [MBP] Disable aggressive loop rotate in plain mode (authored by rupprecht).
Revert [MBP] Disable aggressive loop rotate in plain mode
Thu, Aug 29, 12:05 PM
rupprecht committed rL370398: Revert [MBP] Disable aggressive loop rotate in plain mode.
Revert [MBP] Disable aggressive loop rotate in plain mode
Thu, Aug 29, 12:04 PM

Mon, Aug 26

rupprecht added inline comments to D66734: [llvm-readobj/llvm-readelf] - Report a proper warning when dumping a broken dynamic relocation..
Mon, Aug 26, 7:23 AM · Restricted Project

Aug 23 2019

rupprecht added a comment to D66613: [support][llvm-objcopy] Add support for shell wildcards.

Here are a couple other places using it in the wild:

Aug 23 2019, 5:14 PM · Restricted Project
rupprecht updated the diff for D66613: [support][llvm-objcopy] Add support for shell wildcards.
  • Split out separate methods for parsing brackets instead of allowing arbitrary nesting.
Aug 23 2019, 5:11 PM · Restricted Project
rupprecht added a comment to D66613: [support][llvm-objcopy] Add support for shell wildcards.

(Will get to the code comments later, just wanted to justify the patch)

Aug 23 2019, 7:43 AM · Restricted Project
rupprecht committed rG0f323439d897: [llvm-objcopy] Strip debug sections when running with --strip-unneeded. (authored by rupprecht).
[llvm-objcopy] Strip debug sections when running with --strip-unneeded.
Aug 23 2019, 7:29 AM
rupprecht committed rL369761: [llvm-objcopy] Strip debug sections when running with --strip-unneeded..
[llvm-objcopy] Strip debug sections when running with --strip-unneeded.
Aug 23 2019, 7:29 AM
rupprecht closed D66623: [llvm-objcopy] Strip debug sections when running with --strip-unneeded..
Aug 23 2019, 7:29 AM · Restricted Project

Aug 22 2019

rupprecht created D66623: [llvm-objcopy] Strip debug sections when running with --strip-unneeded..
Aug 22 2019, 3:56 PM · Restricted Project
rupprecht added inline comments to D66409: [llvm-objcopy][MachO] Implement -Obinary.
Aug 22 2019, 1:57 PM · Restricted Project
rupprecht created D66613: [support][llvm-objcopy] Add support for shell wildcards.
Aug 22 2019, 12:22 PM · Restricted Project
rupprecht committed rG6c6dd6acf9e4: [llvm-objcopy][NFC] Refactor symbol/section matching (authored by rupprecht).
[llvm-objcopy][NFC] Refactor symbol/section matching
Aug 22 2019, 12:18 PM
rupprecht committed rL369689: [llvm-objcopy][NFC] Refactor symbol/section matching.
[llvm-objcopy][NFC] Refactor symbol/section matching
Aug 22 2019, 12:17 PM
rupprecht closed D66432: [llvm-objcopy][NFC] Refactor symbol/section matching.
Aug 22 2019, 12:17 PM · Restricted Project

Aug 21 2019

rupprecht added a comment to D66407: [llvm-objcopy][MachO] Implement -Ibinary.

LGTM

Aug 21 2019, 1:28 PM · Restricted Project
rupprecht added inline comments to D66449: [llvm-objcopy] Accept MachO formats in commad-line parsing.
Aug 21 2019, 1:22 PM · Restricted Project
rupprecht added a comment to D65541: [llvm-objcopy][MachO] Implement --only-section.

LGTM, once a MachO reviewer signs off. No action needed for my two comments.

Aug 21 2019, 1:09 PM · Restricted Project
rupprecht added a comment to D66283: [llvm-objcopy][MachO] Implement --add-section.

Don't think I have any comments besides these two, so LGTM once they're addressed & you get a MachO reviewer to be happy w/ this.

Aug 21 2019, 12:58 PM · Restricted Project
rupprecht added a comment to D66063: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 5].
  1. Using private inheritance or making the ELFObjectFile a private member of MutableELFObject instead of a base class. This would require MutableELFObject to opt in into functions that we know to be safe to use, and wouldn't allow usage of other functions. This is safer, but could result in a fair amount of extra code. This might need to be combined with 1) too to fix the specific issues this patch addresses.
Aug 21 2019, 12:40 PM · Restricted Project
rupprecht added a comment to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.

I think this patch is causing BB errors:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/13605/steps/build%20stage1%20clang/logs/stdio

Aug 21 2019, 11:45 AM · Restricted Project
rupprecht accepted D66062: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 4].
Aug 21 2019, 11:32 AM · Restricted Project
rupprecht added inline comments to D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3].
Aug 21 2019, 11:32 AM · Restricted Project
rupprecht committed rGe4876c9d71ee: [docs] Fix GwpAsan.rst (authored by rupprecht).
[docs] Fix GwpAsan.rst
Aug 21 2019, 11:15 AM
rupprecht committed rL369556: [docs] Fix GwpAsan.rst.
[docs] Fix GwpAsan.rst
Aug 21 2019, 11:14 AM
rupprecht added a comment to D62875: [GWP-ASan] Add public-facing documentation [6]..

The docs don't build and rL369554 doesn't fully fix it

Aug 21 2019, 11:13 AM · Restricted Project, Restricted Project
rupprecht committed rGa28b8d78e426: [docs] Convert remaining command guide entries from md to rst. (authored by rupprecht).
[docs] Convert remaining command guide entries from md to rst.
Aug 21 2019, 11:05 AM
rupprecht committed rL369553: [docs] Convert remaining command guide entries from md to rst..
[docs] Convert remaining command guide entries from md to rst.
Aug 21 2019, 11:05 AM
rupprecht closed D66305: [docs] Convert remaining command guide entries from md to rst..
Aug 21 2019, 11:05 AM · Restricted Project
rupprecht accepted D66521: [llvm-readobj] - Remove `reportError(std::error_code EC, StringRef Input)` helper..
Aug 21 2019, 11:05 AM · Restricted Project
rupprecht added a comment to D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section.

Whether or not this change is justified to be made into LLD, I think you'll need a llvm-readobj change to dump the note.

Namely, please add another case here: https://github.com/llvm/llvm-project/blob/master/llvm/tools/llvm-readobj/ELFDumper.cpp#L4495 (and similarly for LLVMStyle::printNotes). I imagine you can repurpose the getGNUBuildId method.

Aug 21 2019, 10:44 AM · Restricted Project

Aug 20 2019

rupprecht added inline comments to D66449: [llvm-objcopy] Accept MachO formats in commad-line parsing.
Aug 20 2019, 5:16 PM · Restricted Project
rupprecht accepted D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3].
Aug 20 2019, 3:24 PM · Restricted Project
rupprecht added a comment to D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1].

FYI, you'll have to rebase this whole patch series after rL368826 due to Section::getName() changing signature

Aug 20 2019, 2:21 PM · Restricted Project
rupprecht added a comment to D66490: [NewPM] Enable the New Pass Manager by Default in Clang.

We already know that we don't want this enabled for tsan builds due to https://bugs.llvm.org/show_bug.cgi?id=42877, but I don't even know if anyone else will hit it (it's only when building one particular library).

Aug 20 2019, 2:03 PM · Restricted Project
rupprecht added inline comments to D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1].
Aug 20 2019, 12:54 PM · Restricted Project
rupprecht accepted D66408: [llvm-objcopy][MachO] Implement --dump-section.
Aug 20 2019, 12:45 PM · Restricted Project
rupprecht added a comment to D66418: [llvm-objdump] - Cleanup the error reporting..

+1 to changing report_error->reportError, same for reportWarning. I suppose it can be a followup NFC patch since it's technically consistent with the existing code. LGTM to the rest.

Aug 20 2019, 12:45 PM · Restricted Project
rupprecht added inline comments to D66305: [docs] Convert remaining command guide entries from md to rst..
Aug 20 2019, 12:05 PM · Restricted Project
rupprecht updated the diff for D66305: [docs] Convert remaining command guide entries from md to rst..
  • Use :program: syntax everywhere
  • Use `` instead of ** for llvm-ar usage
Aug 20 2019, 12:02 PM · Restricted Project
rupprecht updated the diff for D66432: [llvm-objcopy][NFC] Refactor symbol/section matching.
  • Fix method casing
  • Change class name to NameMatcher
Aug 20 2019, 11:53 AM · Restricted Project

Aug 19 2019

rupprecht created D66432: [llvm-objcopy][NFC] Refactor symbol/section matching.
Aug 19 2019, 11:06 AM · Restricted Project
rupprecht updated the diff for D66305: [docs] Convert remaining command guide entries from md to rst..
  • Use :program: rst syntax
  • Correct some mistakes about tool uses
  • Use :manpage: formatted link instead of :doc:
Aug 19 2019, 10:51 AM · Restricted Project
rupprecht requested changes to D66414: [llvm-objdump] Delete argv[0] from error messages.

I feel a little more strongly that we need to have the toolname printed as part of the error message.

Aug 19 2019, 10:36 AM · Restricted Project
rupprecht accepted D66425: [llvm-readobj] Prepend argv[0] to error messages.
Aug 19 2019, 10:29 AM · Restricted Project
rupprecht added inline comments to D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3].
Aug 19 2019, 10:00 AM · Restricted Project

Aug 16 2019

rupprecht added a comment to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….

Reverted in r369167

Aug 16 2019, 4:31 PM
rupprecht committed rGd0797ece4641: Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle… (authored by rupprecht).
Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle…
Aug 16 2019, 4:13 PM
rupprecht committed rL369167: Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle….
Revert [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle…
Aug 16 2019, 4:13 PM
rupprecht accepted D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
Aug 16 2019, 4:13 PM · Restricted Project
rupprecht added inline comments to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….
Aug 16 2019, 3:54 PM
rupprecht added inline comments to D65633: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 3].
Aug 16 2019, 1:56 PM · Restricted Project
rupprecht added a reviewer for D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections: MaskRay.

I can't reproduce the test case -- it seems llvm-readelf already prints the NT_GNU_BUILD_ID when I follow the test steps.

Aug 16 2019, 12:20 PM · Restricted Project
rupprecht accepted D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
Aug 16 2019, 11:25 AM · Restricted Project
rupprecht added inline comments to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….
Aug 16 2019, 10:32 AM
rupprecht added a comment to rL368307: [X86] SimplifyDemandedVectorElts - attempt to recombine target shuffle using….

We're seeing some compilation timeouts that bisect to the patch (5-10s -> >900s). I'm working on a repro.

Aug 16 2019, 7:29 AM

Aug 15 2019

rupprecht added inline comments to D65191: [llvm-objdump] Implement highlighting.
Aug 15 2019, 4:09 PM · Restricted Project
rupprecht added inline comments to D66283: [llvm-objcopy][MachO] Implement --add-section.
Aug 15 2019, 2:55 PM · Restricted Project
rupprecht added a comment to D66282: [llvm-objcopy][MachO] Implement --remove-section.

LGTM, no concerns from me once the test is updated

Aug 15 2019, 2:33 PM · Restricted Project
rupprecht added inline comments to D66281: [llvm-objcopy][MachO] Implement --strip-all.
Aug 15 2019, 2:28 PM · Restricted Project
rupprecht added inline comments to D66280: [llvm-objcopy][MachO] Support indirect symbol table.
Aug 15 2019, 2:05 PM · Restricted Project
rupprecht added a comment to D66310: Fix nm on GCC 5.1 after the C++14 move.

Sounds like you get to claim this as a fix for https://bugs.llvm.org/show_bug.cgi?id=24115 too :)

Aug 15 2019, 1:56 PM · Restricted Project
rupprecht added inline comments to D65541: [llvm-objcopy][MachO] Implement --only-section.
Aug 15 2019, 12:33 PM · Restricted Project
rupprecht accepted D65367: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 2].

I don't see anything major left, but please wait for James to take another look

Aug 15 2019, 11:48 AM · Restricted Project
rupprecht accepted D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1].
Aug 15 2019, 11:19 AM · Restricted Project
rupprecht added inline comments to D66286: [llvm-readobj/llvm-readelf] - Improve/cleanup the error reporting API..
Aug 15 2019, 11:13 AM · Restricted Project
rupprecht accepted D66307: Add LLVMLibC proposal to docs/index.rst..

lg, thanks!

Aug 15 2019, 11:05 AM · Restricted Project
rupprecht accepted D65189: [MC] Support returning marked up ranges in the disassembly.
Aug 15 2019, 10:54 AM · Restricted Project
rupprecht accepted D65190: [X86] X86ATTInstPrinter: replace markup with startMarkup/endMarkup.
Aug 15 2019, 10:54 AM · Restricted Project
rupprecht added inline comments to D66307: Add LLVMLibC proposal to docs/index.rst..
Aug 15 2019, 10:48 AM · Restricted Project
rupprecht added a comment to D66305: [docs] Convert remaining command guide entries from md to rst..

Note that despite being a plain translation from md to rst, git doesn't think these are close enough and shows them as deletion+addition instead of moves.

Aug 15 2019, 10:19 AM · Restricted Project
rupprecht created D66305: [docs] Convert remaining command guide entries from md to rst..
Aug 15 2019, 10:18 AM · Restricted Project
rupprecht added a comment to D64939: Add a proposal for a libc project under the LLVM umbrella..

Did you build these docs locally? (Honestly asking -- I'm wondering if there's something about my local setup that's overly strict, I see doc errors too frequently). I'm getting errors running ninja docs-llvm-html:

Aug 15 2019, 10:12 AM · Restricted Project

Aug 14 2019

rupprecht committed rG1737f71322e3: [docs] Fix sphinx doc generation errors (authored by rupprecht).
[docs] Fix sphinx doc generation errors
Aug 14 2019, 3:18 PM
rupprecht committed rL368932: [docs] Fix sphinx doc generation errors.
[docs] Fix sphinx doc generation errors
Aug 14 2019, 3:17 PM
rupprecht closed D66183: [docs] Fix sphinx doc generation errors.
Aug 14 2019, 3:17 PM · Restricted Project
rupprecht added inline comments to D66120: [Attributor] Use liveness during the creation of AAReturnedValues.
Aug 14 2019, 3:17 PM · Restricted Project
rupprecht committed rG4ee1376dc626: [lldb][NFC] Remove unused function (authored by rupprecht).
[lldb][NFC] Remove unused function
Aug 14 2019, 12:34 PM
rupprecht committed rL368904: [lldb][NFC] Remove unused function.
[lldb][NFC] Remove unused function
Aug 14 2019, 12:34 PM

Aug 13 2019

rupprecht created D66183: [docs] Fix sphinx doc generation errors.
Aug 13 2019, 3:52 PM · Restricted Project
rupprecht added a comment to D65438: [docs] Add cmake to Software requirements.

Did you run ninja docs-llvm-html (or equivalent if not using ninja) when submitting? I'm still seeing this error in trunk.

Aug 13 2019, 2:59 PM · Restricted Project
rupprecht committed rG39bce250d25b: [util] Allow callsigns when running git llvm revert (authored by rupprecht).
[util] Allow callsigns when running git llvm revert
Aug 13 2019, 10:22 AM
rupprecht committed rL368726: [util] Allow callsigns when running git llvm revert.
[util] Allow callsigns when running git llvm revert
Aug 13 2019, 10:19 AM
rupprecht committed rG7859641626f8: [lld][test] Update test to print ELF note description data (authored by rupprecht).
[lld][test] Update test to print ELF note description data
Aug 13 2019, 9:11 AM
rupprecht committed rL368710: [lld][test] Update test to print ELF note description data.
[lld][test] Update test to print ELF note description data
Aug 13 2019, 9:10 AM
rupprecht committed rG63ac3e5cbe03: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors (authored by rupprecht).
[llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors
Aug 13 2019, 7:40 AM
rupprecht committed rL368698: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
[llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors
Aug 13 2019, 7:38 AM
rupprecht closed D65832: [llvm-readelf] Implement note parsing for NT_FILE and unknown descriptors.
Aug 13 2019, 7:37 AM · Restricted Project

Aug 12 2019

rupprecht accepted D66075: [llvm-readobj][MachO] Fix section type printing.
Aug 12 2019, 10:35 PM · Restricted Project
rupprecht added inline comments to D65189: [MC] Support returning marked up ranges in the disassembly.
Aug 12 2019, 4:42 PM · Restricted Project
rupprecht added inline comments to D65367: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 2].
Aug 12 2019, 3:03 PM · Restricted Project
rupprecht added inline comments to D64281: [Object] Create MutableELFObject Class for Doing Mutations on ELFObjectFiles [Part 1].
Aug 12 2019, 2:27 PM · Restricted Project
rupprecht added inline comments to D65372: [llvm-objcopy] Add support for response files in llvm-strip and llvm-objcopy.
Aug 12 2019, 12:49 PM · Restricted Project
rupprecht accepted D65991: [llvm-objcopy] Move duplicate tablegen from objcopy and strip into one file.
Aug 12 2019, 12:13 PM · Restricted Project