- User Since
- Jun 28 2018, 11:39 AM (55 w, 3 d)
Fri, Jul 19
Everything looks good for the tests that were broken before, thanks for waiting!
Sorry, I wanted to patch this in first and rerun tests to make sure the internal build step this broke doesn't have other issues -- I'll reply today
Thu, Jul 18
Tue, Jul 16
Thu, Jul 11
Wed, Jul 10
Temporarily reverted in r365712 due to the noted issue -- I don't think the fix should be too hard, but didn't seem trivial enough to just fix forward
This is an issue for fully linked executables that still have relocation sections, e.g. because it was linked with the --emit-relocs flag:
I'm seeing an error pulling this into our toolchain when trying to copy some files:
Wed, Jul 3
Tue, Jul 2
Thanks for the explanation. Temporarily reverted in r365000.
Mon, Jul 1
We're seeing several compilation timeouts as well. Temporarily reverted in r364846 since this review is ongoing.
Jun 21 2019
(ditto that Ray should take another look, but looks mostly fine to me)
Switching these docs to rst seems (unfortunately) better, abandoning this attempt.
Jun 20 2019
Sounds good, changed to use variable matching instead. This passes w/ either -fno-discard-value-names or -fdiscard-value-names used.
- Use filecheck variable matching instead of an explicit -fno-discard-value-names option
Jun 19 2019
Jun 18 2019
Jun 17 2019
LGTM just with the naming nit from James (header_t&->const HeaderType&)
(just the one comment, then lgtm)
Jun 14 2019
Jun 13 2019
Jun 12 2019
Sure, committed as r363198
Looks like I'm on 1.7.5, from last year (http://www.sphinx-doc.org/en/master/changes.html#release-1-7-5-released-may-29-2018). Not sure how to check the bot version.
I intentionally added .html because I noticed the link on llvm.org is broken: http://llvm.org/docs/CommandGuide/llvm-addr2line.html links to http://llvm.org/docs/CommandGuide/llvm-symbolizer, which does not exist (http://llvm.org/docs/CommandGuide/llvm-symbolizer.html does).
Jun 11 2019
Jun 10 2019
Thanks for splitting up the patch! I should have requested that earlier.
- Clarify llvm-readelf compatibility
Jun 7 2019
Can you upload this patch with context? Either use arc or upload w/ -U99999
SGTM. There's a definitive list of that here: https://www.gnu.org/software/binutils/
Are you saying LLVM developers aren't people? :p