Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (247 w, 9 h)

Recent Activity

Yesterday

rupprecht accepted D146668: [lldb-server] Use Platform plugin corresponding to the host.

Thanks! This indeed fixes the issue I'm seeing.

Wed, Mar 22, 6:57 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D146263: [lldb] Move UnixSignals creation into Platform plugins.
Wed, Mar 22, 2:41 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D146263: [lldb] Move UnixSignals creation into Platform plugins.
Wed, Mar 22, 2:18 PM · Restricted Project, Restricted Project
rupprecht added a comment to D146263: [lldb] Move UnixSignals creation into Platform plugins.

This seems to cause a regression on Linux where we no longer get the signal details.

Wed, Mar 22, 1:38 PM · Restricted Project, Restricted Project

Tue, Mar 21

rupprecht added a comment to D146590: [lldb] Update some uses of Python2 API in typemaps..

lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"

Just tried this, didn't crash LLDB but it does give me the OverflowError you mentioned.

Tue, Mar 21, 7:12 PM · Restricted Project, Restricted Project
rupprecht added reviewers for D146590: [lldb] Update some uses of Python2 API in typemaps.: bulbazord, mib.

Can you add a regression test that invokes lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"? Just a simple shell test should suffice.

Tue, Mar 21, 5:21 PM · Restricted Project, Restricted Project
rupprecht accepted D145940: [lldb] Add test for unavailable registers.
Tue, Mar 21, 12:17 PM · Restricted Project, Restricted Project
rupprecht added a comment to D145940: [lldb] Add test for unavailable registers.

Seems like most xml-based tests like this are in lldb/test/API/functionalities/gdb_remote_client, is there a reason this is not in that package too?

Tue, Mar 21, 9:09 AM · Restricted Project, Restricted Project

Mon, Mar 20

rupprecht added a comment to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..

a more succinct version: https://godbolt.org/z/7YTqP89Mv shows that slp-vectorizer introduces loads from poison

Must be fixed in 59ff9d3777701ebbe6a59ab2edb8792ef3d2873f

Mon, Mar 20, 12:23 PM · Restricted Project, Restricted Project

Fri, Mar 17

rupprecht added a comment to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..

We're still seeing issues with this at trunk, even after the followup assertion fix in 874c49f55454cb285282e6d184f809945c0beca1.

Fri, Mar 17, 3:55 PM · Restricted Project, Restricted Project

Tue, Mar 7

rupprecht added a comment to D144285: [Clang] Implement CWG2518 - static_assert(false).

If however we find this change to disruptive, we should inform WG21.

Tue, Mar 7, 8:43 PM · Restricted Project, Restricted Project
rupprecht added a comment to D145533: [lldb] Fix after __SVCount_t added for AArch64.

5195e14bc1222e1b3f1b7b43c04e1c1ac3504cb1 just landed the same thing as this, although it didn't put it in the sorted order. Feel free to land this if you remove the other entry.

Tue, Mar 7, 5:21 PM · Restricted Project, Restricted Project
rupprecht accepted D145533: [lldb] Fix after __SVCount_t added for AArch64.
Tue, Mar 7, 5:19 PM · Restricted Project, Restricted Project

Fri, Mar 3

rupprecht committed rGebb94ecb9525: [bazel] Fix errno dep location: libc_function_deps -> deps (authored by rupprecht).
[bazel] Fix errno dep location: libc_function_deps -> deps
Fri, Mar 3, 1:00 PM · Restricted Project
rupprecht committed rGfc840808e6cd: [bazel] Add errno dep to stdlib tests (authored by rupprecht).
[bazel] Add errno dep to stdlib tests
Fri, Mar 3, 12:55 PM · Restricted Project

Thu, Mar 2

rupprecht committed rG6db44e52ce47: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach. (authored by rupprecht).
[Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.
Thu, Mar 2, 1:52 PM · Restricted Project
rupprecht closed D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach..
Thu, Mar 2, 1:51 PM · Restricted Project, Restricted Project

Wed, Mar 1

rupprecht accepted D145129: Recommit "[X86] Add `TuningPreferShiftShuffle` for when Shifts are preferable to shuffles." (2nd Try).

Thanks! This seems to fix all the errors I was seeing before.

Wed, Mar 1, 5:42 PM · Restricted Project, Restricted Project
rupprecht added a comment to D143786: [X86] Add `TuningPreferShiftShuffle` for when Shifts are preferable to shuffles..

see: D145129

Thanks!

Wed, Mar 1, 5:07 PM · Restricted Project, Restricted Project
rupprecht added a comment to D143786: [X86] Add `TuningPreferShiftShuffle` for when Shifts are preferable to shuffles..

I think the issue is:

+      // Byte shifts can be slower so only match them on second attempt.
+      if (Order == 0 &&
+          (Shuffle == X86ISD::VSHLDQ || Shuffle == X86ISD::VSRLDQ))
+        continue;

It comes before the check of

+      if (0 < ShiftAmt && (!ShuffleVT.is512BitVector() || Subtarget.hasBWI() ||
+                           32 <= ShuffleVT.getScalarSizeInBits())) {
+        PermuteImm = (unsigned)ShiftAmt;
+        return true;
+      }

and the 0 < ShiftAmt check if basically a check if actually found/set Shuffle.
Don't think the bug actually can change behavior but is bug none the less.

Will post patch to fix.

Wed, Mar 1, 5:03 PM · Restricted Project, Restricted Project
rupprecht added a comment to D143786: [X86] Add `TuningPreferShiftShuffle` for when Shifts are preferable to shuffles..

After this patch, I see an msan issue running this test internally; strangely I don't see a failure on any sanitizer buildbot yet.

Wed, Mar 1, 4:28 PM · Restricted Project, Restricted Project
rupprecht added a comment to D144285: [Clang] Implement CWG2518 - static_assert(false).

Here's one change this patch causes on "real" code (invalid code, but something a user might try to compile): we see is a static_assert in gmock that now fails to report a useful error message: https://godbolt.org/z/sPr1PYT9d

Wed, Mar 1, 1:16 PM · Restricted Project, Restricted Project

Tue, Feb 28

rupprecht added inline comments to D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach..
Tue, Feb 28, 8:20 PM · Restricted Project, Restricted Project
rupprecht updated the diff for D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach..
  • Fix comment typo
Tue, Feb 28, 8:19 PM · Restricted Project, Restricted Project

Mon, Feb 27

rupprecht requested review of D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach..
Mon, Feb 27, 12:07 PM · Restricted Project, Restricted Project

Thu, Feb 23

rupprecht added a comment to D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process.

This has already been reverted, but I found a breakage (not a crash) caused by this:

#include <type_traits>
Thu, Feb 23, 6:26 PM · Restricted Project, Restricted Project
rupprecht accepted D124351: [Clang] Implement Change scope of lambda trailing-return-type.

All the things that were broken before are no longer broken, so LGTM

Thu, Feb 23, 5:02 PM · Restricted Project, Restricted Project

Wed, Feb 22

rupprecht added a comment to D143914: [libc++] Clean up pair's constructors and assignment operators.

The total impact for us is ~400 files, but very trivial in most cases, and usually only a couple impacted lines per file.

Wed, Feb 22, 5:02 PM · Restricted Project, Restricted Project

Feb 14 2023

rupprecht added a comment to D143914: [libc++] Clean up pair's constructors and assignment operators.

The only other breakage I found so far that might be worthy of mention is that constructing containers requires begin/end iterators of pairs, not tuples, but frameworks for doing functional-style programming often tuples to be fully generic, so this breaks. This seems like an intended effect of this patch, but makes things a little less ergonomic. Is there an idiomatic way to do that w/o having to write your own tuple->pair boilerplate?

Switching to -std=c++2b would fix that -- IMO that sounds reasonable but I am interested to know if you disagree.

It isn't an option for us, but I don't think it's worth it to keep a non-conformant extension + complexity in libc++ just so we can avoid a little boilerplate to do tuple->pair manually in a couple places.

Feb 14 2023, 4:28 PM · Restricted Project, Restricted Project

Feb 13 2023

rupprecht added a comment to D143914: [libc++] Clean up pair's constructors and assignment operators.

The only other breakage I found so far that might be worthy of mention is that constructing containers requires begin/end iterators of pairs, not tuples, but frameworks for doing functional-style programming often tuples to be fully generic, so this breaks. This seems like an intended effect of this patch, but makes things a little less ergonomic. Is there an idiomatic way to do that w/o having to write your own tuple->pair boilerplate?

Feb 13 2023, 9:21 PM · Restricted Project, Restricted Project
rupprecht added a comment to D143914: [libc++] Clean up pair's constructors and assignment operators.

Still chugging away, looks like this is going to be at least 50 breakages. Most of them are trivial to fix (e.g. return std::make_tuple() in a method returning std::pair should be return std::make_pair()). There are a few that are a little surprising, such as this one which doesn't seem related to tuple compatibility:

Feb 13 2023, 7:51 PM · Restricted Project, Restricted Project
rupprecht added a comment to D143914: [libc++] Clean up pair's constructors and assignment operators.

Pinging vendors since this is technically a source break. I'll also take this for a run internally to see how much breakage this causes, if any.

This one is a bit bigger of a breakage for us. Do you have a target date for landing this patch?

I'd like to do it before the LLVM 17 release, and ideally not too late in the cycle to allow everyone to see this breakage well in advance. How bad is it?

Feb 13 2023, 11:37 AM · Restricted Project, Restricted Project
rupprecht added a comment to D143914: [libc++] Clean up pair's constructors and assignment operators.

Pinging vendors since this is technically a source break. I'll also take this for a run internally to see how much breakage this causes, if any.

Feb 13 2023, 9:14 AM · Restricted Project, Restricted Project

Feb 9 2023

rupprecht added a comment to D143346: [libc++] fix `shared_ptr`'s incorrect constraints.

Thanks for fixing this! Only nits.

Let's land this and cherry-pick it onto LLVM 16. Please add a release note on the LLVM 16 release branch to explain that this constrains std::shared_ptr more than it used to, which could lead to a bit of source break. I don't think this should be too big of a deal, especially since the code this would break is arguably brittle.

Pinging vendors for awareness.

Feb 9 2023, 7:20 PM · Restricted Project, Restricted Project
rupprecht added a comment to D143678: [bazel] Add layering-check.

I just looked at the premerge checks and I can see how this will be hard to fix globally (if at all possible).
I'll use the package feature instead.

Feb 9 2023, 7:13 PM · Restricted Project, Restricted Project

Feb 3 2023

rupprecht added a comment to D124351: [Clang] Implement Change scope of lambda trailing-return-type.

Looks like we fail to enter the appropriate context somewhere (my guess is that it might be specific to the attribute but it's hard to say without picking around), definitely a bug

I'll be away the next 2 weeks, I'll look at it when I get back. Maybe we should track it in an issue though.

Should we revert this then?

Yes, I think we should. We should also file an issue so @cor3ntin doesn't lose track of the issue. Anyone want to volunteer to do that? (I can do it early next week otherwise.)

Feb 3 2023, 8:51 AM · Restricted Project, Restricted Project
rupprecht added a reverting change for rGd708a186b6a9: [Clang] Implement Change scope of lambda trailing-return-type: rG74ce297045ba: Revert "[Clang] Implement Change scope of lambda trailing-return-type".
Feb 3 2023, 8:50 AM · Restricted Project, Restricted Project
rupprecht committed rG74ce297045ba: Revert "[Clang] Implement Change scope of lambda trailing-return-type" (authored by rupprecht).
Revert "[Clang] Implement Change scope of lambda trailing-return-type"
Feb 3 2023, 8:50 AM · Restricted Project, Restricted Project
rupprecht added a reverting change for D124351: [Clang] Implement Change scope of lambda trailing-return-type: rG74ce297045ba: Revert "[Clang] Implement Change scope of lambda trailing-return-type".
Feb 3 2023, 8:49 AM · Restricted Project, Restricted Project

Feb 2 2023

rupprecht added a comment to D124351: [Clang] Implement Change scope of lambda trailing-return-type.

Hi, me again :)

Feb 2 2023, 8:38 PM · Restricted Project, Restricted Project

Feb 1 2023

rupprecht added inline comments to D143071: [libc++] Avoid ODR violations in __exception_guard.
Feb 1 2023, 7:49 AM · Restricted Project, Restricted Project
rupprecht added a comment to D133661: [libc++] Improve binary size when using __transaction.

@philnik could you commit one of the proposed abi_tag fixes?

Actually, I went ahead and committed it as 561105fb9d3a16f7fb8c718cc5da71b11f17a144 to unblock us. Hopefully, that's small and obvious enough to not violate the code review policies.

Feb 1 2023, 6:58 AM · Restricted Project, Restricted Project

Jan 31 2023

rupprecht added a comment to D133661: [libc++] Improve binary size when using __transaction.

The ABI tag approach fixes the ODR issue I was looking at

Jan 31 2023, 4:14 PM · Restricted Project, Restricted Project

Jan 26 2023

rupprecht committed rGdd9b31e2c2a2: [test] Remove unused `unittest2` import from concurrent_base.py (authored by rupprecht).
[test] Remove unused `unittest2` import from concurrent_base.py
Jan 26 2023, 6:23 PM · Restricted Project
rupprecht committed rGd5c0b1f73b05: [test] Remove unused `unittest2` import (authored by rupprecht).
[test] Remove unused `unittest2` import
Jan 26 2023, 6:02 PM · Restricted Project
rupprecht committed rGdc682ed590f7: [test][lldb-vscode] Fix unclean shutdown in test_terminate_commands (authored by rupprecht).
[test][lldb-vscode] Fix unclean shutdown in test_terminate_commands
Jan 26 2023, 2:30 PM · Restricted Project

Jan 25 2023

rupprecht added a comment to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Not a breakage report, but just a comment in case it wasn't expected/intended: it looks like this increases the conformance requirement for custom iterators passed to std::copy and friends. From a couple tests, it seems like gcc/libstdc++ already has stricter requirements than libc++, so the conformance requirement is being matched between libc++ and libstdc++ now. As an example:

Jan 25 2023, 11:35 AM · Restricted Project, Restricted Project

Jan 24 2023

rupprecht committed rG5ed6d99a8311: [lldb] Remove legacy six module for py2->py3 (authored by rupprecht).
[lldb] Remove legacy six module for py2->py3
Jan 24 2023, 7:47 PM · Restricted Project
rupprecht closed D142140: [lldb] Remove legacy six module for py2->py3.
Jan 24 2023, 7:46 PM · Restricted Project, Restricted Project
rupprecht accepted D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build.

Thanks!

Jan 24 2023, 3:41 AM · Restricted Project, Restricted Project

Jan 19 2023

rupprecht accepted D142158: [Bazel] Fix layering issues.

I think I see why we don't see this failure internally (maybe), but I'm clueless as to why the buildkite builder or local builds don't complain. Anyway, thanks!

Jan 19 2023, 2:06 PM · Restricted Project, Restricted Project
rupprecht added reviewers for D142140: [lldb] Remove legacy six module for py2->py3: JDevlieghere, DavidSpickett, kastiglione.
Jan 19 2023, 10:20 AM · Restricted Project, Restricted Project
rupprecht requested review of D142140: [lldb] Remove legacy six module for py2->py3.
Jan 19 2023, 10:18 AM · Restricted Project, Restricted Project
rupprecht committed rGafca08a567e3: [NFC][bazel] Move _tensor_ops_ext.py to the correct filegroup (authored by rupprecht).
[NFC][bazel] Move _tensor_ops_ext.py to the correct filegroup
Jan 19 2023, 8:43 AM · Restricted Project
rupprecht committed rGac0938709c6d: [NFC][bazel] Add _tensor_ops_ext.py to SparseTensorOpsPyFiles (authored by rupprecht).
[NFC][bazel] Add _tensor_ops_ext.py to SparseTensorOpsPyFiles
Jan 19 2023, 8:39 AM · Restricted Project
rupprecht committed rG658bf08f67d5: [NFC][bazel] Enable layering_check for mlir/unittests (authored by rupprecht).
[NFC][bazel] Enable layering_check for mlir/unittests
Jan 19 2023, 3:41 AM · Restricted Project

Jan 17 2023

rupprecht committed rGe32971520990: [NFC][bazel] Add export_files for utils/textmate/mlir.json (authored by rupprecht).
[NFC][bazel] Add export_files for utils/textmate/mlir.json
Jan 17 2023, 5:17 PM · Restricted Project

Jan 13 2023

rupprecht accepted D136392: [Bazel] Use `LLVM_VERSION` from `llvm/CMakeLists.txt`.

LGTM

Jan 13 2023, 10:58 AM · Restricted Project, Restricted Project

Jan 12 2023

rupprecht committed rG3432f4bf86e7: [test] Split out Annotations from `TestingSupport` (authored by rupprecht).
[test] Split out Annotations from `TestingSupport`
Jan 12 2023, 1:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rupprecht closed D141175: [test] Split out Annotations from `TestingSupport`.
Jan 12 2023, 1:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

rupprecht added a comment to D136392: [Bazel] Use `LLVM_VERSION` from `llvm/CMakeLists.txt`.

This looks like a nice improvement! Just one thing I noticed.

Jan 11 2023, 8:03 PM · Restricted Project, Restricted Project
rupprecht accepted D141553: [bazel] Enable layering_check for llvm and clang.
Jan 11 2023, 4:31 PM · Restricted Project, Restricted Project
rupprecht added reviewers for D141175: [test] Split out Annotations from `TestingSupport`: ilya-biryukov, gribozavr, sammccall.
Jan 11 2023, 2:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rupprecht updated the diff for D141175: [test] Split out Annotations from `TestingSupport`.
  • Remove redundant comment
Jan 11 2023, 2:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rupprecht retitled D141175: [test] Split out Annotations from `TestingSupport` from [bazel] Split out Annotations from `TestingSupport` to [test] Split out Annotations from `TestingSupport`.
Jan 11 2023, 1:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rupprecht added a comment to D141175: [test] Split out Annotations from `TestingSupport`.

It seems like the same logic would extend to the CMake build. Could we make the same change there?

Jan 11 2023, 1:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rupprecht updated the diff for D141175: [test] Split out Annotations from `TestingSupport`.
  • Move annotations to a separate package entirely
Jan 11 2023, 1:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 6 2023

rupprecht requested review of D141175: [test] Split out Annotations from `TestingSupport`.
Jan 6 2023, 7:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rupprecht requested review of D141174: [test] Add more tests for _regexp-break, the 'b' shortcut..
Jan 6 2023, 6:47 PM · Restricted Project, Restricted Project

Jan 3 2023

rupprecht added a comment to D136554: Implement CWG2631.

I still see one behavior change (actually it was there before, but I missed it in the test results), but as far as I can tell, it's a good one? If I reduce it too much, I get the warning with the baseline toolchain, so it's not erroneous AFAICT. Although I won't pretend I know all the intricacies of static and inline.

Jan 3 2023, 6:27 PM · Restricted Project, Restricted Project
rupprecht accepted D136554: Implement CWG2631.

I still see one behavior change (actually it was there before, but I missed it in the test results), but as far as I can tell, it's a good one? If I reduce it too much, I get the warning with the baseline toolchain, so it's not erroneous AFAICT. Although I won't pretend I know all the intricacies of static and inline.

// a.h
static const std::pair<double, double>& GetFakePair() {
  static constexpr std::pair<double, double> kFakePair = {123.0, 456.0};
  return kFakePair;
}
Jan 3 2023, 5:38 PM · Restricted Project, Restricted Project
rupprecht added a comment to D140898: [llvm-exegesis] Remove functional test from unit tests.

If you want to keep this test but just not run it by default, can you put it in a separate target that the build bot doesn't run? I guess it's up to you.

Jan 3 2023, 10:02 AM · Restricted Project, Restricted Project

Dec 29 2022

rupprecht added a comment to D136554: Implement CWG2631.

I threw this at the "test everything" test (some millions of targets) and it found only one breakage, so this is very very close. Without further ado, here is this silly looking thing:

Dec 29 2022, 8:22 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D138470: [bazel] Restore libpfm as a conditional dependency for exegesis..
Dec 29 2022, 6:23 PM · Restricted Project, Restricted Project

Dec 28 2022

rupprecht added a comment to D136554: Implement CWG2631.

I'm not sure what to make of the new failure when I try it out this time. Given a source like this:

#include <functional>
Dec 28 2022, 8:27 PM · Restricted Project, Restricted Project
rupprecht added a comment to D136554: Implement CWG2631.

All good now! The latest revision of this patch doesn't seem to break anything, unless I ran our tests wrong. From my perspective this is OK to reland now.

Dec 28 2022, 5:04 PM · Restricted Project, Restricted Project
rupprecht added a comment to D136554: Implement CWG2631.

All good now! The latest revision of this patch doesn't seem to break anything, unless I ran our tests wrong. From my perspective this is OK to reland now.

Dec 28 2022, 1:32 PM · Restricted Project, Restricted Project
rupprecht committed rGf92ae6dd3007: [test] Exclude //llvm/unittests:llvm_exegesis_tests due to buildkite… (authored by rupprecht).
[test] Exclude //llvm/unittests:llvm_exegesis_tests due to buildkite…
Dec 28 2022, 8:43 AM · Restricted Project
rupprecht committed rG4aa77690b98e: [bazel] Restore libpfm as a conditional dependency for exegesis. (authored by rupprecht).
[bazel] Restore libpfm as a conditional dependency for exegesis.
Dec 28 2022, 8:13 AM · Restricted Project
rupprecht closed D138470: [bazel] Restore libpfm as a conditional dependency for exegesis..
Dec 28 2022, 8:13 AM · Restricted Project, Restricted Project

Dec 22 2022

rupprecht added a comment to D136554: Implement CWG2631.

Glad the test case made sense to you, it was convoluted to me :)

Still seeing one more error, and it's not modules-related so I might be able to get it reduced today. Generally, it looks like this:

struct Inner {
  Foo& foo;
  const std::unique_ptr<...> x = blah(blah(
      &foo.bar()));
};

class Outer {
 private:
  Foo foo_;
  Inner inner{foo_};
}

With the error being:

error: 'Inner::foo' is not a member of class 'Outer'
      &foo.bar()));

I think this build failure is wrong? foo should be referring to the definition inside Inner, but clang seems to be expecting it to refer to something in Outer.

Is it expected that this patch will cause some previously "working" code to no longer build? At some point I expect to hand you a reduction that's actually a bug in the user code.

Dec 22 2022, 4:52 PM · Restricted Project, Restricted Project
rupprecht added a comment to D136554: Implement CWG2631.

Glad the test case made sense to you, it was convoluted to me :)

Dec 22 2022, 10:05 AM · Restricted Project, Restricted Project
rupprecht committed rG3afe296c81b9: [test][lldb-vscode] Relax assertion to allow multiple compile units returned. (authored by rupprecht).
[test][lldb-vscode] Relax assertion to allow multiple compile units returned.
Dec 22 2022, 5:20 AM · Restricted Project
rupprecht closed D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned..
Dec 22 2022, 5:19 AM · Restricted Project, Restricted Project

Dec 21 2022

rupprecht added a comment to D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned..

ping :)

Dec 21 2022, 4:22 PM · Restricted Project, Restricted Project
rupprecht added a reviewer for D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.: labath.
Dec 21 2022, 4:22 PM · Restricted Project, Restricted Project

Dec 20 2022

rupprecht added a comment to D136554: Implement CWG2631.

Sorry for the delay, I was out on vacation for a bit. I have a repro for this new issue now:

Dec 20 2022, 5:52 PM · Restricted Project, Restricted Project

Dec 15 2022

rupprecht added a comment to D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields.

I'm not sure what the libcxx failure was that caused you to revert this, but we also saw a clang crasher as a result of this. clang/lib/AST/Decl.cpp:4300 in unsigned int clang::FieldDecl::getBitWidthValue(const ASTContext &) const: isBitField() && "not a bitfield". I'll try to reduce it.

Dec 15 2022, 11:45 PM · Restricted Project, Restricted Project
rupprecht added a comment to D136554: Implement CWG2631.

I applied this version of the patch and the crash is now gone 🎉

Dec 15 2022, 9:09 PM · Restricted Project, Restricted Project
rupprecht added a comment to D140058: [clang-format][NFC] Turn on some code-changing options one by one.

This is causing a test failure: https://buildkite.com/llvm-project/upstream-bazel/builds/48607#0185190c-43f8-43ff-b8bd-fa8ce0b6e2f5
(and likewise running ninja check-clang-unit locally, but I don't have a buildbot link to that)

Dec 15 2022, 8:39 PM · Restricted Project, Restricted Project, Restricted Project
rupprecht committed rG5a06334c51aa: [Format] Capture `FormatStyle` by value to avoid use-after-free. (authored by rupprecht).
[Format] Capture `FormatStyle` by value to avoid use-after-free.
Dec 15 2022, 8:39 PM · Restricted Project, Restricted Project
rupprecht added a comment to D140058: [clang-format][NFC] Turn on some code-changing options one by one.

This is causing a test failure: https://buildkite.com/llvm-project/upstream-bazel/builds/48607#0185190c-43f8-43ff-b8bd-fa8ce0b6e2f5
(and likewise running ninja check-clang-unit locally, but I don't have a buildbot link to that)

Dec 15 2022, 8:15 PM · Restricted Project, Restricted Project, Restricted Project
rupprecht added a comment to D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields.

I'm not sure what the libcxx failure was that caused you to revert this, but we also saw a clang crasher as a result of this. clang/lib/AST/Decl.cpp:4300 in unsigned int clang::FieldDecl::getBitWidthValue(const ASTContext &) const: isBitField() && "not a bitfield". I'll try to reduce it.

Dec 15 2022, 6:33 PM · Restricted Project, Restricted Project
rupprecht committed rG58c38e4536eb: [NFC][bazel] Update comment in llvm-config.h.cmake so headers match (authored by rupprecht).
[NFC][bazel] Update comment in llvm-config.h.cmake so headers match
Dec 15 2022, 5:42 PM · Restricted Project

Dec 14 2022

rupprecht added a comment to D136554: Implement CWG2631.

Here's a well-formed reproducer:

Dec 14 2022, 4:47 PM · Restricted Project, Restricted Project
rupprecht added a comment to D136554: Implement CWG2631.

Actually, that assertion failure is pre-existing. However, this is newly failing in a no-asserts clang, so I wonder if something about this patch is just surfacing an existing bug in clang. Anyway, I hope to have a better repro by EOD.

Dec 14 2022, 10:54 AM · Restricted Project, Restricted Project
rupprecht added a comment to D136554: Implement CWG2631.

Ugh, I left cvise running overnight and forgot to include the validity check by building with a previous clang, so my reduction is invalid. I'm going to run it again, but here's the invalid crasher in the meantime:

Dec 14 2022, 10:29 AM · Restricted Project, Restricted Project

Dec 13 2022

rupprecht added a comment to D136554: Implement CWG2631.

Looks like the latest reland still has some issue remaining. With asserts enabled, I get: assert.h assertion failed at clang/include/clang/AST/Type.h:752 in const ExtQualsTypeCommonBase *clang::QualType::getCommonPtr() const: !isNull() && "Cannot retrieve a NULL type pointer". I'm going to work on reducing it now.

Dec 13 2022, 6:29 PM · Restricted Project, Restricted Project
rupprecht committed rG9144ee6edf41: [bazel] Add __support_compiler_features dep in more places (authored by rupprecht).
[bazel] Add __support_compiler_features dep in more places
Dec 13 2022, 12:20 PM · Restricted Project
rupprecht committed rGcaee219320b8: [bazel] Add extract_api after 7a85192166b551929d413e8a38549375503371db (authored by rupprecht).
[bazel] Add extract_api after 7a85192166b551929d413e8a38549375503371db
Dec 13 2022, 10:57 AM · Restricted Project