Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (81 w, 1 d)

Recent Activity

Mon, Jan 13

rupprecht added a comment to D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols.

I it seems that the printing of this error message only occurs with GNU nm if the object doesn't have a symbols table at all. Have no symbols in the table does not print the error message.

$ touch foo.c
$ gcc -c foo.c
$ nm foo.o  <- no error output here.
$ strip foo.o
$ nm foo.o
nm: foo.o: no symbols

Interesting (subtle) behavior...

@rupprecht Do we know what projects parse "no symbols" from llvm-nm output?

Mon, Jan 13, 2:39 PM · Restricted Project

Tue, Jan 7

rupprecht added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Tue, Jan 7, 2:06 PM · Restricted Project
rupprecht added a comment to D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`.

I left similar comments on D72357 too

Tue, Jan 7, 1:46 PM · Restricted Project
rupprecht added a comment to D72358: [llvm-objcopy][test] Fix tests when path contains "bar".

I left comments on D72357 instead

Tue, Jan 7, 1:46 PM · Restricted Project
rupprecht added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Tue, Jan 7, 12:49 PM · Restricted Project

Thu, Jan 2

rupprecht added a comment to D71554: [llvm-ranlib] Handle -D and -U command line flag.

Also handle -h/-v as short options. Does the adjusted test look okay?

Thu, Jan 2, 11:43 AM · Restricted Project, Restricted Project

Fri, Dec 20

rupprecht committed rG02a6b0bc3b54: Temporarily revert "Reapply [LVI] Normalize pointer behavior" and "[LVI]… (authored by rupprecht).
Temporarily revert "Reapply [LVI] Normalize pointer behavior" and "[LVI]…
Fri, Dec 20, 10:40 AM
rupprecht added a reverting change for rG7e18aeba5062: [LVI] Restructure caching: rG02a6b0bc3b54: Temporarily revert "Reapply [LVI] Normalize pointer behavior" and "[LVI]….
Fri, Dec 20, 10:40 AM
rupprecht added a comment to D70376: [LVI] Restructure caching.

Thanks -- the code in question seems to be heavily templated, so it may be a corner case with how those are handled. I'll revert shortly and follow up with some kind of repro, but may be delayed due to holidays.

Fri, Dec 20, 10:29 AM · Restricted Project

Thu, Dec 19

rupprecht added a comment to D70376: [LVI] Restructure caching.

We're seeing a large memory increase in compilations as a result of this patch: 4.7G -> 6.0G (25%)

Thu, Dec 19, 4:24 PM · Restricted Project

Dec 18 2019

rupprecht abandoned D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg..

Before:

% clang -frounding-math -fsyntax-only -x c /dev/null
clang-10: warning: Support for floating point control option frounding-math is incomplete and experimental [-Wexperimental-float-control]

CC1 will do rounding math things.

After

% clang -frounding-math -fsyntax-only -x c /dev/null
clang-10: warning: optimization flag '-frounding-math' is not supported [-Wignored-optimization-argument]

CC1 will not do rounding math things. -fexperimental-rounding-math if the user really wants to use the feature.

Is my understanding correct? If yes, this patch seems pretty reasonable to me, because -frounding-math is currently incomplete/unsafe.

You may consider not changing CC1 options as they are not user facing.

Dec 18 2019, 5:40 PM · Restricted Project
rupprecht committed rG553a727f5f64: [clang] Remove -Wexperimental-float-control. (authored by rupprecht).
[clang] Remove -Wexperimental-float-control.
Dec 18 2019, 5:03 PM
rupprecht closed D71671: [clang] Remove -Wexperimental-float-control..
Dec 18 2019, 5:02 PM · Restricted Project
rupprecht added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename -frounding-math to -fexperimental-rounding-math.

Alternatively we could remove the warning. I still don't see a good argument for the middle ground of having it called -frounding-math but also generate a warning.

It's definitely incomplete but the results will not be any worse than you get when -frounding-math is ignored.

My preference would be to change the text of the warning that is issued but allow -frounding-math to be enabled by this commit without requiring an additional option.

If other reviewers agree, then let's just remove the warning. I can send a patch tomorrow unless someone else wants to do that.

Dec 18 2019, 12:24 PM · Restricted Project, Restricted Project
rupprecht created D71671: [clang] Remove -Wexperimental-float-control..
Dec 18 2019, 12:14 PM · Restricted Project

Dec 17 2019

rupprecht closed D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename -frounding-math to -fexperimental-rounding-math.

Alternatively we could remove the warning. I still don't see a good argument for the middle ground of having it called -frounding-math but also generate a warning.

It's definitely incomplete but the results will not be any worse than you get when -frounding-math is ignored.

My preference would be to change the text of the warning that is issued but allow -frounding-math to be enabled by this commit without requiring an additional option.

If other reviewers agree, then let's just remove the warning. I can send a patch tomorrow unless someone else wants to do that.

Dec 17 2019, 7:42 PM · Restricted Project, Restricted Project
rupprecht added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename -frounding-math to -fexperimental-rounding-math.

Dec 17 2019, 3:58 PM · Restricted Project, Restricted Project
rupprecht created D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg..
Dec 17 2019, 3:58 PM · Restricted Project
rupprecht accepted D71554: [llvm-ranlib] Handle -D and -U command line flag.

Looks good for D/U, but looks like --help and --version options are also supported as combined short args; do you mind adding those too while you're here?

Dec 17 2019, 10:44 AM · Restricted Project, Restricted Project

Dec 13 2019

rupprecht added a reviewer for D71035: [llvm-objcopy][ELF] -O binary: use LMA instead of sh_offset to decide where to write section contents: evgeny777.

Is it ok for me to commit if there is still no other people interested in this patch for, say, 10 hours? 😂

I tested it on an internal objcopy -I ihex -O binary use case that motivated me to send the patch. With this patch, the section content layout is now the same.

Let's give it until after the weekend. We've been stung on a few occasions by issues with binary output, so I want to give people ample opportunity to point out anything else we've missed!

Dec 13 2019, 11:10 AM · Restricted Project

Dec 12 2019

rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 12 2019, 4:19 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 12 2019, 12:51 PM · Restricted Project, Restricted Project

Dec 11 2019

rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 11 2019, 4:57 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 11 2019, 4:55 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D71319: [lldb][dotest] Improve libc++ detection.
Dec 11 2019, 2:29 PM · Restricted Project
rupprecht committed rG786b6db8e6fd: [lldb][dotest] Add `#include <algorithm>` to libc++ detection (authored by rupprecht).
[lldb][dotest] Add `#include <algorithm>` to libc++ detection
Dec 11 2019, 2:10 PM
rupprecht closed D71376: [lldb][dotest] Add `#include <algorithm>` to libc++ detection.
Dec 11 2019, 2:10 PM · Restricted Project
rupprecht created D71376: [lldb][dotest] Add `#include <algorithm>` to libc++ detection.
Dec 11 2019, 2:10 PM · Restricted Project
rupprecht committed rG34ef51b5f979: [lldb][dotest] Improve libc++ detection (authored by rupprecht).
[lldb][dotest] Improve libc++ detection
Dec 11 2019, 1:51 PM
rupprecht closed D71319: [lldb][dotest] Improve libc++ detection.
Dec 11 2019, 1:51 PM · Restricted Project

Dec 10 2019

rupprecht created D71319: [lldb][dotest] Improve libc++ detection.
Dec 10 2019, 4:55 PM · Restricted Project
rupprecht accepted D71302: [llvm-ar] Improve tool selection logic.

Looks good. Thanks for adding the tests!

Dec 10 2019, 4:08 PM · Restricted Project
rupprecht added a comment to D71302: [llvm-ar] Improve tool selection logic.

Update the heuristic to make all the following work as intended:

llvm-ar-9
llvm-ranlib.exe
arm-pokymllib32-linux-gnueabi-llvm-ar
arm-pokymllib32-linux-gnueabi-llvm-ar-9

This was manually verified, but can you add a test for it?
You could probably write a lit test like:

# RUN: mkdir -p bin
# RUN: cp llvm-ar bin/llvm-ar-9
# RUN: bin/llvm-ar-9 --help | FileCheck %s --check-prefix=AR
# RUN: cp llvm-ar bin/llvm-ranlib.exe
# RUN: bin/llvm-ranlib.exe --help | FileCheck %s --check-prefix=RANLIB
...

The path of llvm-ar is not known.

lit substitutes llvm-ar with the full path; see llvm/test/tools/llvm-ar/case-detection.test

Dec 10 2019, 3:19 PM · Restricted Project
rupprecht added a comment to D71151: [lldb][test] Remove symlink for API tests..

While I'm not opposed to moving "lldbsuite" to some place closer to the tests, one thing I'd like to get out of this is to have the actual tests stand out more prominently.

Ditto; my direct goal is just to be able to run something more fine grained than ninja check-lldb-api, but splitting tests & test framework is a nice side benefit. (Actually it might be simpler if I didn't split it, but now I've already done the work).

Dec 10 2019, 2:50 PM · Restricted Project
rupprecht added a comment to D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests..

Hmm... given the lua thread on lldb-dev, maybe we should slow down here, and consider the potential relationship of these tests and the hypothetical lua tests that come to be. One of the reasons the current tests are so deeply nested was that Zach was trying to future-proof ourselves for addition of new scripting languages (at that time, Java was being floated around, but the idea never took off the ground). I'd hate to move these tests now, only to have to move them around again in a couple of weeks to make room for lua...

Dec 10 2019, 2:37 PM · Restricted Project
rupprecht requested changes to D71302: [llvm-ar] Improve tool selection logic.

Update the heuristic to make all the following work as intended:

llvm-ar-9
llvm-ranlib.exe
arm-pokymllib32-linux-gnueabi-llvm-ar
arm-pokymllib32-linux-gnueabi-llvm-ar-9

This was manually verified, but can you add a test for it?
You could probably write a lit test like:

Dec 10 2019, 2:09 PM · Restricted Project
rupprecht added a comment to D71030: Tighten the check for Tool name ( ar,nm,dlltool, lib).

Oh, I think this may break llvm-dlltool.exe and llvm-ar.exe on Windows. We probably need a more sophisticated heuristic.

Dec 10 2019, 12:28 PM · Restricted Project

Dec 6 2019

rupprecht added a child revision for D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.: D71151: [lldb][test] Remove symlink for API tests..
Dec 6 2019, 3:11 PM · Restricted Project
rupprecht added a parent revision for D71151: [lldb][test] Remove symlink for API tests.: D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests..
Dec 6 2019, 3:11 PM · Restricted Project
rupprecht added a comment to D71151: [lldb][test] Remove symlink for API tests..

Since the diff is large, I'll paste the only non-mechanical part here:

Dec 6 2019, 3:11 PM · Restricted Project
Herald added a reviewer for D71151: [lldb][test] Remove symlink for API tests.: jfb.
Dec 6 2019, 3:11 PM · Restricted Project
rupprecht created D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests..
Dec 6 2019, 3:02 PM · Restricted Project
rupprecht accepted D71116: [test][tools] Add missing/Improve testing.
Dec 6 2019, 10:31 AM · Restricted Project
rupprecht abandoned D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests..

Officially abandoning this

Dec 6 2019, 9:35 AM · Restricted Project, Restricted Project
rupprecht committed rG03a242bd41ee: [lldb][test] Handle .categories lookup for inline tests. (authored by rupprecht).
[lldb][test] Handle .categories lookup for inline tests.
Dec 6 2019, 8:48 AM
rupprecht closed D71099: [lldb][test] Handle .categories lookup for inline tests..
Dec 6 2019, 8:48 AM · Restricted Project

Dec 5 2019

rupprecht created D71099: [lldb][test] Handle .categories lookup for inline tests..
Dec 5 2019, 4:35 PM · Restricted Project
rupprecht committed rG0d236d8b4f8a: [lldb] Update hardcoded Makefile.rules inclusions. (authored by rupprecht).
[lldb] Update hardcoded Makefile.rules inclusions.
Dec 5 2019, 3:55 PM
rupprecht added a comment to D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests..

No objections to moving the test. Jordan, let me know if you're up for it, otherwise I'm happy to take care of it.

I tried moving it today. The rabbit hole goes deep :D
The test framework seems pretty tied to the directory layout (because python), e.g. those must be in a directory called "lldbsuite" to be able to "import lldbsuite"
The test infrastructure also seems to assume tests + test framework are in the same tree (e.g. the LLDB_TEST env var is used for both), so moving the individual test directories and leaving just the framework classes in lldbsuite breaks a few things.

I agree it's probably cleaner to move the tests, so I'll keep poking. Suggestions welcome though.

Dec 5 2019, 2:57 PM · Restricted Project, Restricted Project
rupprecht added a comment to D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests..

No objections to moving the test. Jordan, let me know if you're up for it, otherwise I'm happy to take care of it.

Dec 5 2019, 12:47 PM · Restricted Project, Restricted Project

Nov 22 2019

rupprecht created D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests..
Nov 22 2019, 3:01 PM · Restricted Project, Restricted Project
rupprecht committed rG506144da04b9: [lldb][DataFormatters] Support pretty printing std::string when built with… (authored by rupprecht).
[lldb][DataFormatters] Support pretty printing std::string when built with…
Nov 22 2019, 10:53 AM
rupprecht closed D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char..
Nov 22 2019, 10:53 AM · Restricted Project
rupprecht added a comment to D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper..

[This is probably not the right patch, as the last run on that bot still doesn't have this commit.]

-> D70137 is the correct patch that actually adds this test -- this is testonly cleanup

Nov 22 2019, 10:16 AM · Restricted Project

Nov 20 2019

rupprecht created D70517: [lldb][DataFormatters] Support pretty printing std::string when built with -funsigned-char..
Nov 20 2019, 4:07 PM · Restricted Project

Nov 19 2019

rupprecht committed rG327a18ca0a00: [lldb][test] Prevent \n in calls to lldb's expect() test helper. (authored by rupprecht).
[lldb][test] Prevent \n in calls to lldb's expect() test helper.
Nov 19 2019, 3:19 PM
rupprecht closed D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper..
Nov 19 2019, 3:19 PM · Restricted Project

Nov 15 2019

rupprecht added inline comments to D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..
Nov 15 2019, 10:50 AM · Restricted Project
rupprecht created D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper..
Nov 15 2019, 10:41 AM · Restricted Project

Nov 14 2019

rupprecht committed rGf2e65447b3cb: [lldb][Editline] Support ctrl+left/right arrow word navigation. (authored by rupprecht).
[lldb][Editline] Support ctrl+left/right arrow word navigation.
Nov 14 2019, 11:48 AM
rupprecht closed D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..
Nov 14 2019, 11:48 AM · Restricted Project
rupprecht added inline comments to D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..
Nov 14 2019, 10:43 AM · Restricted Project
rupprecht updated the diff for D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..
  • Fix test comment
  • Use expect helper from lldbpexpect
Nov 14 2019, 10:34 AM · Restricted Project

Nov 12 2019

rupprecht added a comment to D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..

This is very nice, thanks!

Any chance we could test this with a pexpect test?

Nov 12 2019, 3:10 PM · Restricted Project
rupprecht updated the diff for D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..
  • Add a pexpect test
Nov 12 2019, 3:10 PM · Restricted Project
rupprecht created D70137: [lldb][Editline] Support ctrl+left/right arrow word navigation..
Nov 12 2019, 11:51 AM · Restricted Project

Oct 31 2019

rupprecht added a comment to D61144: [LoopIdiomRecognize] BCmp loop idiom recognition.

I found a strange sanitizer error as a result of this revision, could you take a quick look at https://bugs.llvm.org/show_bug.cgi?id=43870?

Oct 31 2019, 6:25 PM · Restricted Project
rupprecht added a comment to D68620: DebugInfo: Use base address selection entries for debug_loc.

It looks like this caused a very large increase in binary size (627M->686M). Is that expected/has anyone else observed this?

Oct 31 2019, 1:25 PM · Restricted Project

Oct 25 2019

rupprecht accepted D65541: [llvm-objcopy][MachO] Implement --only-section.

LGTM with the wildcard changes, thanks!

Oct 25 2019, 2:20 PM · Restricted Project
rupprecht added inline comments to D68983: [yaml2obj, obj2yaml] - Add support for SHT_NOTE sections..
Oct 25 2019, 2:20 PM · Restricted Project
rupprecht accepted D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

LGTM to the change, though I want to resolve this thread before committing:

Oct 25 2019, 11:40 AM · Restricted Project
rupprecht added a comment to D69418: [llvm-ar] Add output option for extract operation.

Not really opposed to this patch, but I think ruiu's comment makes sense to think about:

Oct 25 2019, 9:48 AM · Restricted Project

Oct 24 2019

rupprecht added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

@rupprecht thanks for the review - happy to address your comments and change the commit message and inline comment to reflect my findings above if you guys decide to accept this approach. I think this needs to be documented if nothing else considering how confusing the error on device actually is.

I'm good with the approach in this patch -- once the test/docs changes are done, I'll accept it. I also ran into Jake yesterday at the llvm devmtg and came to the same conclusion. (Also, sorry for the delay, which was also because of the devmtg). --strip-all should generally be more aggressive, but not so much that it totally doesn't work as a default mode on common platforms.

Oct 24 2019, 5:11 PM · Restricted Project
rupprecht committed rG6d424a161bf3: Revert "Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"" (authored by rupprecht).
Revert "Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)""
Oct 24 2019, 4:47 PM
rupprecht added a reverting change for rG80371c74ae63: Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)": rG6d424a161bf3: Revert "Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"".
Oct 24 2019, 4:47 PM

Oct 21 2019

rupprecht added inline comments to D69093: [llvm-objcopy] --add-symbol: fix crash if SHT_SYMTAB does not exist.
Oct 21 2019, 11:05 AM · Restricted Project
rupprecht added inline comments to D69093: [llvm-objcopy] --add-symbol: fix crash if SHT_SYMTAB does not exist.
Oct 21 2019, 10:46 AM · Restricted Project
rupprecht added inline comments to D69093: [llvm-objcopy] --add-symbol: fix crash if SHT_SYMTAB does not exist.
Oct 21 2019, 10:36 AM · Restricted Project

Oct 18 2019

rupprecht accepted D69160: [obj2yaml] - Stop triggering UB when dumping corrupted strings..
Oct 18 2019, 2:50 PM · Restricted Project
rupprecht accepted D69167: [llvm/Object] - Make ELFObjectFile::getRelocatedSection return Expected<section_iterator>..
Oct 18 2019, 2:41 PM · Restricted Project
rupprecht added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Also, a couple docs that should be updated (where we mention .gnu.warning):

Oct 18 2019, 2:32 PM · Restricted Project
rupprecht added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Seems like a hack, no? What about using --keep-section when you need it? You say its not strictly needed on modern systems and the problem is with the dlopen implementation of these older libcs, and not llvm-objcopy, so I would be hesitant to add something like this especially given we have a solution with --keep-section

Keep-sections totally works. But since this produces unusable binaries on systems that require this section and lld already makes this consession I think it's worth adding this very low maintenance hack.

I agree, we generally want --strip-all to be the aggressive option and --strip-all-gnu to be the option when more compatibility is needed (and --keep-section when things seriously go wrong), but I think we should probably not have --strip-all be completely unusable for default modes.

Oct 18 2019, 2:23 PM · Restricted Project
rupprecht added a reviewer for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files: jakehehrlich.
Oct 18 2019, 2:04 PM · Restricted Project
rupprecht added inline comments to D69093: [llvm-objcopy] --add-symbol: fix crash if SHT_SYMTAB does not exist.
Oct 18 2019, 8:38 AM · Restricted Project

Oct 17 2019

rupprecht committed rG98a2ae7dadf8: Reland [llvm-objdump] Use a counter for llvm-objdump -h instead of the section… (authored by rupprecht).
Reland [llvm-objdump] Use a counter for llvm-objdump -h instead of the section…
Oct 17 2019, 2:57 PM
rupprecht committed rL375178: Reland [llvm-objdump] Use a counter for llvm-objdump -h instead of the section….
Reland [llvm-objdump] Use a counter for llvm-objdump -h instead of the section…
Oct 17 2019, 2:57 PM
rupprecht committed rGedeebad77157: [llvm-objcopy] Add support for shell wildcards (authored by rupprecht).
[llvm-objcopy] Add support for shell wildcards
Oct 17 2019, 1:50 PM
rupprecht committed rL375169: [llvm-objcopy] Add support for shell wildcards.
[llvm-objcopy] Add support for shell wildcards
Oct 17 2019, 1:50 PM
rupprecht added a comment to D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library..

Damn looks like something is broken for linux powerpc

http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/21208/steps/ninja%20check%201/logs/stdio

llvm-lit: /home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/llvm/projects/compiler-rt/test/builtins/Unit/lit.cfg.py:116: fatal: builtins_source_features contains duplicates: ['librt_has_divtc3']

I'm going to turn this into a warning to unbreak the bot for now.

@joerg @rupprecht Any idea what's going on here? My CMake code jsut reads the source files used to built the builtin library. My guess is that both lib/builtins/ppc/divtc3.c and lib/builtins/divtc3.c are used to build the builtin library for powerpc. That sounds like a bug. I'd expect that to cause a linker error with multiple symbols of the same name being defined.

Oct 17 2019, 1:41 PM · Restricted Project, Restricted Project
rupprecht committed rG48993d5ab941: Reapply r375051: [support] GlobPattern: add support for `\` and `[!...]`, and… (authored by rupprecht).
Reapply r375051: [support] GlobPattern: add support for `\` and `[!...]`, and…
Oct 17 2019, 11:11 AM
rupprecht closed D66613: [support][llvm-objcopy] Add support for shell wildcards.
Oct 17 2019, 11:11 AM · Restricted Project
rupprecht committed rL375149: Reapply r375051: [support] GlobPattern: add support for `\` and `[!...]`, and….
Reapply r375051: [support] GlobPattern: add support for `\` and `[!...]`, and…
Oct 17 2019, 11:11 AM
rupprecht accepted D66613: [support][llvm-objcopy] Add support for shell wildcards.
Oct 17 2019, 11:11 AM · Restricted Project
rupprecht added a comment to D69041: [yaml2obj][obj2yaml] - Do not create a symbol table by default..

Generally LGTM, although I think Ray is a much better person to approve this.

Oct 17 2019, 10:52 AM · Restricted Project
rupprecht added inline comments to D69093: [llvm-objcopy] --add-symbol: fix crash if SHT_SYMTAB does not exist.
Oct 17 2019, 10:33 AM · Restricted Project
rupprecht added a comment to D69087: [llvm-ar] Implement the O modifier: display member offsets inside the archive.

Cool!

Oct 17 2019, 10:23 AM · Restricted Project
rupprecht added a comment to D69074: [lld][test] Fix use of escape character in an lld test on Windows.

This breaks the test on Windows: http://45.33.8.238/win/709/step_9.txt

Oct 17 2019, 9:37 AM · Restricted Project
rupprecht added a comment to D69074: [lld][test] Fix use of escape character in an lld test on Windows.
Oct 17 2019, 9:37 AM · Restricted Project
rupprecht committed rGce88cdf0964d: [lld][test] Speculative fix for lld+windows failures (authored by rupprecht).
[lld][test] Speculative fix for lld+windows failures
Oct 17 2019, 9:28 AM
rupprecht committed rL375131: [lld][test] Speculative fix for lld+windows failures.
[lld][test] Speculative fix for lld+windows failures
Oct 17 2019, 9:27 AM