Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (133 w, 3 d)

Recent Activity

Wed, Jan 13

rupprecht added a comment to D93779: ADT: Fix reference invalidation in SmallVector::push_back and single-element insert.

This patch seems to have found a bug: in AArch64InstrInfo.cpp, there is a -Wsometimes-uninitialized warning that now triggers, and adding an assertion to make sure the value is eventually set causes a few tests to fail. The usage is DelInstrs.push_back(MUL), which I guess is how it ties in to this patch.

Wed, Jan 13, 8:38 PM · Restricted Project
rupprecht committed rG752fafda3dbf: [NFC] Fix -Wsometimes-uninitialized (authored by rupprecht).
[NFC] Fix -Wsometimes-uninitialized
Wed, Jan 13, 8:34 PM

Mon, Jan 11

rupprecht abandoned D94468: [test] Demonstrate bad error message.
Mon, Jan 11, 9:41 PM · Restricted Project
rupprecht added a comment to D84673: [clang][cli] Port DiagnosticOpts to new option parsing system.

I ran into this commit when integrating commits today (specifically, 97100646d1b4526de1eac3aacdb0b098739c6ec9) -- there's nothing wrong with this patch AFAICT, but I'm wondering if the error messaging/handling could be improved somehow.

Mon, Jan 11, 9:41 PM · Restricted Project, Restricted Project
rupprecht requested review of D94468: [test] Demonstrate bad error message.
Mon, Jan 11, 9:30 PM · Restricted Project

Wed, Jan 6

rupprecht added a comment to D93881: [llvm-objcopy] preserve file ownership when overwritten.

From a user standpoint, I agree that "objcopy foo.o" should not be changing the ownership of a file, regardless of the implementation (which, in the case of llvm-objcopy, is getting it "wrong" compared to GNU objcopy, because we use temporary file and rename it at the end, without fixing ownership). Sounds like there's agreement there.

Wed, Jan 6, 9:22 PM · Restricted Project
rupprecht added a comment to D93967: [SLP]Need shrink the load vector after reordering..

I can confirm this fixes the non-reduced test case we're seeing internally, thanks!

Wed, Jan 6, 8:52 PM · Restricted Project

Wed, Dec 30

rupprecht added a comment to D92668: [SLP]Merge reorder and reuse shuffles..

Finally got a reasonably sized reduction. It's probably so long because I'm just using clang to build, and if it gets smaller than clang optimizes too much of it away; if I used opt to control the passes I could probably get it smaller. Anyway, hope this is good enough to demonstrate the issue:

Wed, Dec 30, 4:27 PM · Restricted Project

Mon, Dec 28

rupprecht added a comment to D92668: [SLP]Merge reorder and reuse shuffles..

I think I'm seeing a miscompile as a result of the patch. The issue is not the transformation itself, but a dependent instruction is reading the wrong value.

Mon, Dec 28, 3:20 PM · Restricted Project

Wed, Dec 23

rupprecht added a comment to D93274: [DAGCombiner] Don't create sexts of deleted xors when they were in-visit replaced.

Thanks for the review! Could you please commit this for me? Layton Kifer <laytonkifer@gmail.com>

Wed, Dec 23, 4:28 PM · Restricted Project
rupprecht committed rGd29f93bda511: [DAGCombiner] Don't create sexts of deleted xors when they were in-visit… (authored by laytonio).
[DAGCombiner] Don't create sexts of deleted xors when they were in-visit…
Wed, Dec 23, 4:22 PM
rupprecht closed D93274: [DAGCombiner] Don't create sexts of deleted xors when they were in-visit replaced.
Wed, Dec 23, 4:21 PM · Restricted Project
rupprecht added inline comments to D93491: [lld/mac] Add --version flag.
Wed, Dec 23, 2:42 PM · Restricted Project
rupprecht committed rGbe89d7460b63: [lld][test] Relax test assertion of cmake defaults appearing in --version… (authored by rupprecht).
[lld][test] Relax test assertion of cmake defaults appearing in --version…
Wed, Dec 23, 2:39 PM

Dec 17 2020

rupprecht added a comment to D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.

This now "fixes" the dwarf 5 crash I originally went down this rabbit hole for, but I'd like feedback on if it's actually the correct fix (e.g. I'm not generating bogus debug info here :) )

Dec 17 2020, 7:47 PM · debug-info, Restricted Project
rupprecht updated the diff for D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.
  • Fix the dwarf 5 crash
Dec 17 2020, 7:33 PM · debug-info, Restricted Project
rupprecht added inline comments to D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.
Dec 17 2020, 4:24 PM · debug-info, Restricted Project
rupprecht updated the diff for D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.
  • Fix the other crash
Dec 17 2020, 4:19 PM · debug-info, Restricted Project
rupprecht added a comment to D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.

Yeah - would you be able to see if rather than making changes to support debug-info-for-profiling further in split-dwarf-inlining, we could go the other way and support it less/not at all? (it's going to be a bit annoying, now splitting hairs of having gmlt-without-profiling and gmlt-with-profiling, but hopefully not too drastic *fingers crossed*)

Do you mean clang -fsplit-dwarf-inlining -fdebug-info-for-profiling should fail during command line parsing? Or something else?

Dec 17 2020, 2:17 PM · debug-info, Restricted Project
rupprecht added a comment to D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.

Any idea if this was a recent regression or the like? Worth noting what patch might've caused it, etc.

Dec 17 2020, 11:54 AM · debug-info, Restricted Project
rupprecht updated the diff for D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.
  • Update test case to check dwarfdump structure
Dec 17 2020, 11:52 AM · debug-info, Restricted Project

Dec 16 2020

rupprecht added a project to D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf: debug-info.
Dec 16 2020, 8:18 PM · debug-info, Restricted Project
rupprecht requested review of D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf.
Dec 16 2020, 8:15 PM · debug-info, Restricted Project
rupprecht committed rG869f8363c424: [lldb][NFC] Apply performance-faster-string-find (`str.find("X")` -> `str.find… (authored by rupprecht).
[lldb][NFC] Apply performance-faster-string-find (`str.find("X")` -> `str.find…
Dec 16 2020, 10:58 AM

Dec 4 2020

rupprecht added a comment to D92636: [llvm-readelf/obj] - Improve diagnostics when printing NT_FILE notes..

Thanks!

Dec 4 2020, 2:08 PM · Restricted Project

Nov 25 2020

rupprecht added a comment to rG02fdbc356724: Revert "[NFC][SCEV] Generalize monotonicity check for full and limited….

FYI, this patch (unintentionally?) fixed a miscompile for us, as I noted in the review thread for D90648. Reposting here for visibility:

Nov 25 2020, 4:00 PM
rupprecht added a comment to D90648: [SCEV] Fix nsw flags for GEP expressions.

Turns out this isn't failing at trunk anymore. It looks like this was fixed by 02fdbc3567249471349474c70828cb5a5d4881c8. For posterity, here's my reduction:

Nov 25 2020, 3:55 PM · Restricted Project
rupprecht added a comment to D90648: [SCEV] Fix nsw flags for GEP expressions.

This patch does not have a new test case added to demonstrate what this patch is trying to fix or reference the bug number showing the bug end-to-end.

This does not fix a specific end-to-end miscompile. It fixes incorrect analysis results that may result in a miscompile. See also D90708 for a clarification of GEP inbounds semantics in LangRef.

Nov 25 2020, 1:39 PM · Restricted Project

Nov 24 2020

rupprecht added a comment to D91841: [builtins] Define fmax and scalbn inline.

LGTM, though it'd be good to have another set of eyes on this to approve it.

Nov 24 2020, 7:48 PM · Restricted Project
rupprecht added a comment to D91841: [builtins] Define fmax and scalbn inline.

I don't think that we can use llvm-libc, but I suppose that lifting the functionality from there is possible. What does that gain over this though?

Nov 24 2020, 10:56 AM · Restricted Project

Nov 23 2020

rupprecht committed rG5b8e4a11029f: [lldb/test] Remove flaky `process connect` test. (authored by rupprecht).
[lldb/test] Remove flaky `process connect` test.
Nov 23 2020, 12:50 PM

Nov 20 2020

rupprecht added a reviewer for D91841: [builtins] Define fmax and scalbn inline: sivachandra.

I wrote D49514 a long time ago, and since then, llvm-libc was created -- and it looks like it implements fmax, though not scalbn. Anyway, I wonder if it would be possible to use the llvm-libc implementation of fmax instead of adding one here? And similarly, for scalbn, maybe it would be easier/better long term to add one to libc instead of here.

Nov 20 2020, 3:09 PM · Restricted Project

Nov 19 2020

rupprecht added a comment to D91835: [lldb] Add Python bindings to print stack traces on crashes..

I ran manual tests for this, but I did so by introducing an intentional crash in a place that obviously can't be checked in. Does LLDB have any kind of intentional-crash-for-test mechanism that could be used for a test?

Nov 19 2020, 5:53 PM · Restricted Project
rupprecht requested review of D91835: [lldb] Add Python bindings to print stack traces on crashes..
Nov 19 2020, 5:49 PM · Restricted Project

Nov 16 2020

rupprecht added a comment to D87637: [lldb/test] Enable faulthandler in dotest.

Yeah I don't think this revision is to blame as just disabling the code here doesn't bring back the backtraces. Doesn't explain what happened to them, but that's probably on me to figure out. Really sorry for the noise, closing this again.

Nov 16 2020, 10:44 AM · Restricted Project

Nov 13 2020

rupprecht added a comment to D87637: [lldb/test] Enable faulthandler in dotest.

My cmake config appears to be correct. I tried adding this to CommandInterpreter::HandleCommand:

Nov 13 2020, 5:26 PM · Restricted Project
rupprecht added a comment to D87637: [lldb/test] Enable faulthandler in dotest.

At head:

Nov 13 2020, 5:06 PM · Restricted Project
rupprecht added a comment to D87637: [lldb/test] Enable faulthandler in dotest.

Thanks, I'll take a look at that.

Nov 13 2020, 4:21 PM · Restricted Project
rupprecht added a comment to D87637: [lldb/test] Enable faulthandler in dotest.

I'm late to the party, but I actually don't think this is a good change as it disables the normal LLDB backtraces. The current test errors we see on Green Dragon look now like this:

Assertion failed: (size() >= N && "Dropping more elements than exist"), function drop_front, file /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/StringRef.h, line 655.
Fatal Python error: Aborted

Current thread 0x000000010e0f9dc0 (most recent call first):
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/python3.7/site-packages/lldb/__init__.py", line 2717 in HandleCommand
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2129 in runCmd
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/commands/apropos/with-process/TestAproposWithProcess.py", line 43 in test_apropos_with_process
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 413 in runMethod
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 383 in run
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/case.py", line 458 in __call__
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 117 in _wrapped_run
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 115 in _wrapped_run
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 85 in run
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/suite.py", line 66 in __call__
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/third_party/Python/module/unittest2/unittest2/runner.py", line 165 in run
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 1017 in run_suite
  File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/dotest.py", line 7 in <module>

It's practically impossible to say from the backtrace which commit is to blame for the crash as I only know we run the command apropos env and then we crash in StringRef.

Do we have a way of getting both the LLVM and the Python backtrace?

I'm not really sure what you mean by the LLDB backtrace or how this is inhibiting it.

Nov 13 2020, 3:58 PM · Restricted Project

Nov 3 2020

rupprecht committed rG33945cdd62c4: [NFC] Fix call to lldb RegisterValue constructor (authored by rupprecht).
[NFC] Fix call to lldb RegisterValue constructor
Nov 3 2020, 1:25 PM
rupprecht committed rG980bf1d5d1f0: [NFC] Inline wasm assertion-only variable (authored by rupprecht).
[NFC] Inline wasm assertion-only variable
Nov 3 2020, 1:07 PM

Nov 2 2020

rupprecht added a comment to D87194: Thread safety analysis: Use access specifiers to decide about scope.

@rupprecht, maybe you can try it again?

Nov 2 2020, 3:20 PM · Restricted Project

Oct 30 2020

rupprecht added a comment to D84604: Thread safety analysis: Consider global variables in scope.

I applied D87194 locally and rebuilt the original source, and not only am I seeing the original issue (also firing on DoThings() when it should only be on DoStuff()), I'm also seeing: error: acquiring mutex 'lock' requires negative capability '!lock' [-Werror,-Wthread-safety-negative], where lock is a local variable, defined as MutexLock lock(mutex_).

Oh yes, I need to rebase this, sorry if I wasted your time. This is still on top of the bug that @lebedev.ri pointed out in D84604#2262745 and on top of the bug that you pointed out.

No worries, it was only a minute to patch, and then a few more minutes to take a snack break while it rebuilt :)

Oct 30 2020, 12:24 PM · Restricted Project

Oct 29 2020

rupprecht added a comment to D84604: Thread safety analysis: Consider global variables in scope.

Pushed a fix in rGbbed8cfe80cd27d3a47d877c7608d9be4e487d97. For now we just consider all static members as inaccessible, so we'll treat them as we did before this change.

I can confirm this fixes the breakage -- thanks!

Oct 29 2020, 10:29 PM · Restricted Project
rupprecht added a comment to D90438: [llvm-objcopy] Make --set-section-flags work with --add-section.

LGTM. I'll wait for a second person to stamp it.

Oct 29 2020, 6:33 PM · Restricted Project
rupprecht committed rG29f9db7125af: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests (authored by keith).
[llvm-readobj][NFC] Remove unused prefix from FileCheck tests
Oct 29 2020, 5:54 PM
rupprecht closed D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.
Oct 29 2020, 5:54 PM · Restricted Project
rupprecht added a comment to D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.

Sure, running tests now. You can get commit access via http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for future patches :)

Oct 29 2020, 5:50 PM · Restricted Project
rupprecht accepted D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.

Looks like it was D89384 that got rid of this, fwiw

Oct 29 2020, 4:46 PM · Restricted Project
rupprecht added a comment to D84604: Thread safety analysis: Consider global variables in scope.

I'm seeing failures which I think are due to this patch -- I don't have a nice godbolt repro yet, but it's something like:

Oct 29 2020, 2:21 PM · Restricted Project

Oct 19 2020

rupprecht committed rG8a377f1e3cf4: [NFC] Inline assertion-only variable (authored by rupprecht).
[NFC] Inline assertion-only variable
Oct 19 2020, 3:13 PM
rupprecht added a comment to D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file..

It looks like this fix caused a different regression in not accepting name.<x>.h as the main header for name.<x>.cc, e.g.:

Oct 19 2020, 10:46 AM · Restricted Project

Oct 12 2020

rupprecht accepted D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

Sorry for the delay -- yep, going this route (for now, at least) is fine with me too.

Oct 12 2020, 1:22 PM · Restricted Project

Oct 9 2020

rupprecht added a reverting change for rG6537004913f3: [ThinLTO] Re-order modules for optimal multi-threaded processing: rG9b5b3050237d: Temporarily revert "[ThinLTO] Re-order modules for optimal multi-threaded….
Oct 9 2020, 2:44 PM
rupprecht committed rG9b5b3050237d: Temporarily revert "[ThinLTO] Re-order modules for optimal multi-threaded… (authored by rupprecht).
Temporarily revert "[ThinLTO] Re-order modules for optimal multi-threaded…
Oct 9 2020, 2:44 PM
rupprecht added a reverting change for D87966: [ThinLTO] Re-order modules for optimal multi-threaded processing: rG9b5b3050237d: Temporarily revert "[ThinLTO] Re-order modules for optimal multi-threaded….
Oct 9 2020, 2:44 PM · Restricted Project

Oct 7 2020

rupprecht added a comment to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

+1 to being okay to extend the tools with other useful options. Before we rush headlong into this option, I wonder whether we should instead allow the existing delete option to take a wildcard/glob pattern/regex thing. That way you could just delete e.g. "*" to remove all rpaths, or "*.foo" to delete all ending in ".foo" etc. From a compatibility concern, it might mean we need to add an option similar to e.g. --regex in llvm-objcopy which enables the pattern matching.

What do others think?

If people think this is being overly general, the proposed option in this patch is fine by me too.

Same here -- that seems like it would be a better patch.

Oct 7 2020, 4:31 PM · Restricted Project

Oct 6 2020

rupprecht added a comment to D88840: [dotest] Simplify logic to find the Python path.

About -P, the man page for lldb and the driver's Options.td say it:

Prints out the path to the lldb.py file for this version of lldb.

Should it do just that? If so this can be simplified further.

Oct 6 2020, 8:37 AM · Restricted Project

Oct 5 2020

rupprecht accepted D88840: [dotest] Simplify logic to find the Python path.
Oct 5 2020, 4:30 PM · Restricted Project

Oct 2 2020

rupprecht added inline comments to D88715: [llvm-objdump] --source: drop the warning when there is no debug info.
Oct 2 2020, 11:07 AM · Restricted Project
rupprecht added a comment to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

Can you also update install-name-tool-delete-rpath.test with a test case for this?

Oct 2 2020, 10:59 AM · Restricted Project
rupprecht added inline comments to D88715: [llvm-objdump] --source: drop the warning when there is no debug info.
Oct 2 2020, 10:15 AM · Restricted Project

Oct 1 2020

rupprecht accepted D87987: [llvm-objcopy][NFC] refactor error handling. part 3..

LGTM, thanks again!

Oct 1 2020, 2:22 PM · Restricted Project
rupprecht added a comment to D88693: [llvm-ar] Reject bitcode which can't be parsed..

D88288 landed this morning. Does that work for you?

Oct 1 2020, 12:29 PM · Restricted Project

Sep 30 2020

rupprecht added a comment to D87987: [llvm-objcopy][NFC] refactor error handling. part 3..

I'm really happy to see this. I tried removing the error() methods from llvm-objcopy.h a year or two ago and didn't have the patience to work through all the plumbing seen here.

Sep 30 2020, 1:23 PM · Restricted Project
rupprecht accepted D88288: [Archive] Don't throw away errors for malformed archive members.

Thanks!

Sep 30 2020, 12:21 PM · Restricted Project
rupprecht committed rGad865d9d10b8: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints. (authored by rupprecht).
[lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.
Sep 30 2020, 11:33 AM
rupprecht closed D88513: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints..
Sep 30 2020, 11:33 AM · Restricted Project
rupprecht committed rGc3193e464cbd: [lldb/ipv6] Support running lldb tests in an ipv6-only environment. (authored by rupprecht).
[lldb/ipv6] Support running lldb tests in an ipv6-only environment.
Sep 30 2020, 11:11 AM
rupprecht closed D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
Sep 30 2020, 11:11 AM · Restricted Project

Sep 29 2020

rupprecht requested review of D88513: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints..
Sep 29 2020, 2:39 PM · Restricted Project

Sep 28 2020

rupprecht requested changes to D88288: [Archive] Don't throw away errors for malformed archive members.

Requesting changes mostly because this is marked as accepted but I still see build errors; overall this looks fine though.

Sep 28 2020, 1:18 PM · Restricted Project

Sep 25 2020

rupprecht added inline comments to D88288: [Archive] Don't throw away errors for malformed archive members.
Sep 25 2020, 11:17 AM · Restricted Project
rupprecht accepted D88320: [Object][MachO] Refine interface of Slice.
Sep 25 2020, 11:14 AM · Restricted Project
rupprecht accepted D88288: [Archive] Don't throw away errors for malformed archive members.

There's a build warning that needs to be fixed, but otherwise LG.

Sep 25 2020, 11:02 AM · Restricted Project

Sep 23 2020

rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

(Sorry about the delay.) Given the current requirements, I think this patch is fine (excellent even).

That said, I'm not sure whether the original motivation for this requirement (avoiding dns lookups) is still relevant. These days, we communicate with the local debug server via socketpair(2) sockets (which wasn't the case back then), which does not require any dns lookups and is immune to a misconfigured hosts file.

The initial dns lookup may still fail, I think? e.g. my initial version of this patch had:

if (llvm::Error error =
        listen_socket.Listen("localhost:0", backlog).ToError())

If the hosts file has a bad value for localhost, that will create a bad socket. That said, I don't know how to reproduce the original issue -- maybe it isn't an issue for some other reason.

Given that none of the things touched by this patch is extremely critical (GDBRemoteCommunication::ConnectLocally is used for reproducers and the rest is test code), maybe we could use this to test the water and see whether we can start using the network stack the way it's supposed to be used ?

Many non-reproducers tests fail w/o the change to GDBRemoteCommunication::ConnectLocally, so it's at least used outside of that.

I can go either way with using localhost or using hard-coded localhost IPs. Whichever way we go, I have a slight preference for keeping the tests and code consistent, e.g. if we use hard-coded IPs in code linked into lldb to allow people with a bad hosts file to use lldb, we should use hard-coded IPs in the tests to allow those same users to develop on lldb.

Sep 23 2020, 4:12 PM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • Switch back to using localhost for non-socket uses
Sep 23 2020, 4:06 PM · Restricted Project

Sep 22 2020

rupprecht added a comment to rG8fdac7cb7abb: Revert D71539 "Recommit "[SCEV] Look through single value PHIs."".

The issue is with the new pass manager.

Sep 22 2020, 11:04 AM

Sep 21 2020

rupprecht committed rG307b7a1d6658: [lldb/test] Clean up version checking. (authored by rupprecht).
[lldb/test] Clean up version checking.
Sep 21 2020, 4:20 PM
rupprecht closed D88051: [lldb/test] Clean up version checking..
Sep 21 2020, 4:20 PM · Restricted Project
rupprecht requested review of D88051: [lldb/test] Clean up version checking..
Sep 21 2020, 3:22 PM · Restricted Project

Sep 17 2020

rupprecht accepted D87855: [llvm-install-name-tool] Validate -id value early.

Looks like llvm/test/tools/llvm-objcopy/MachO/install-name-tool-id.test covers this, so LGTM

Sep 17 2020, 4:12 PM · Restricted Project

Sep 16 2020

rupprecht committed rGdd67581407c1: [lldb/test] Enable faulthandler in dotest (authored by rupprecht).
[lldb/test] Enable faulthandler in dotest
Sep 16 2020, 2:31 PM
rupprecht closed D87637: [lldb/test] Enable faulthandler in dotest.
Sep 16 2020, 2:31 PM · Restricted Project
rupprecht added inline comments to D87755: Silence GCC's `-Wclass-memaccess` warnings.
Sep 16 2020, 9:45 AM · Restricted Project

Sep 15 2020

rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

(Sorry about the delay.) Given the current requirements, I think this patch is fine (excellent even).

That said, I'm not sure whether the original motivation for this requirement (avoiding dns lookups) is still relevant. These days, we communicate with the local debug server via socketpair(2) sockets (which wasn't the case back then), which does not require any dns lookups and is immune to a misconfigured hosts file.

The initial dns lookup may still fail, I think? e.g. my initial version of this patch had:

Sep 15 2020, 9:30 AM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • Compare directly against the error code instead of hopping through std::make_error_code()
Sep 15 2020, 9:19 AM · Restricted Project

Sep 14 2020

rupprecht requested review of D87637: [lldb/test] Enable faulthandler in dotest.
Sep 14 2020, 2:41 PM · Restricted Project

Sep 10 2020

rupprecht committed rG6040d525507b: [NFC] Fix whitespace in lldb-vscode --help (authored by rupprecht).
[NFC] Fix whitespace in lldb-vscode --help
Sep 10 2020, 11:00 AM

Sep 9 2020

rupprecht committed rG52f0837778b6: [NFC] Move definition of variable now only used in debug builds (authored by rupprecht).
[NFC] Move definition of variable now only used in debug builds
Sep 9 2020, 8:28 PM
rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

This is ready for review now after scrubbing out the "localhost" changes I had earlier.

Sep 9 2020, 12:44 PM · Restricted Project
rupprecht updated the summary of D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
Sep 9 2020, 12:43 PM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • clang-format
Sep 9 2020, 12:41 PM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • Don't use "localhost" to avoid dns latency. Instead, prefer either 127.0.0.1 or ::1 directly.
Sep 9 2020, 12:40 PM · Restricted Project

Sep 8 2020

rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.

I assume you mean people *not* having a "localhost" entry?

I believe the issue was with people having a modified version that replaces localhost with some other IP address.

I didn't even realize that was an option. Yes, this patch would break that. I'll have to take another approach, then.

You might check the "git log" on any files that have "127.0.0.1" in them for details.

Do you happen to have any references (bugs etc.) for those kinds of issues?

Sep 8 2020, 4:44 PM · Restricted Project
rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.

Sep 8 2020, 4:21 PM · Restricted Project
rupprecht requested review of D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
Sep 8 2020, 3:31 PM · Restricted Project

Sep 3 2020

rupprecht added inline comments to D86360: Add new hidden option -print-changed which only reports changes to IR.
Sep 3 2020, 10:20 AM · Restricted Project

Sep 2 2020

rupprecht committed rGf7e04b710d2d: [lldb/Gui] zero-initialize children_stop_id (authored by rupprecht).
[lldb/Gui] zero-initialize children_stop_id
Sep 2 2020, 8:06 PM
rupprecht closed D86825: [lldb/Gui] zero-initialize children_stop_id.
Sep 2 2020, 8:06 PM · Restricted Project