Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (55 w, 3 d)

Recent Activity

Fri, Jul 19

rupprecht accepted D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

Everything looks good for the tests that were broken before, thanks for waiting!

Fri, Jul 19, 11:51 AM · Restricted Project
rupprecht added a comment to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

Sorry, I wanted to patch this in first and rerun tests to make sure the internal build step this broke doesn't have other issues -- I'll reply today

Fri, Jul 19, 8:33 AM · Restricted Project

Thu, Jul 18

rupprecht committed rG301c65a8e072: [lldb][swig] Fix autodocs flag parsing (authored by rupprecht).
[lldb][swig] Fix autodocs flag parsing
Thu, Jul 18, 11:25 AM
rupprecht added inline comments to rL366471: [swig] Enable autodoc feature.
Thu, Jul 18, 11:23 AM
rupprecht committed rL366478: [lldb][swig] Fix autodocs flag parsing.
[lldb][swig] Fix autodocs flag parsing
Thu, Jul 18, 11:23 AM

Tue, Jul 16

rupprecht accepted D64803: [llvm-ar][test] Add coverage for replace and update key letters.
Tue, Jul 16, 4:15 PM · Restricted Project
rupprecht added a comment to D64797: [tools] [llvm-nm] Revert rL365889.

I got it to work. The revert is here rL366219. I think it didn't work because I always clone with --depth 1? So I just created a fresh clone.

Tue, Jul 16, 3:43 PM · Restricted Project
rupprecht accepted rL366219: Revert [tools] [llvm-nm] Default to reading from stdin not a.out.
Tue, Jul 16, 3:32 PM
rupprecht removed 1 auditor(s) for rL366219: Revert [tools] [llvm-nm] Default to reading from stdin not a.out: Bigcheese.
Tue, Jul 16, 3:32 PM

Thu, Jul 11

rupprecht committed rGbabe09ed9bc2: Re-Revert Devirtualize destructor of final class. (authored by rupprecht).
Re-Revert Devirtualize destructor of final class.
Thu, Jul 11, 5:33 PM
rupprecht committed rL365850: Re-Revert Devirtualize destructor of final class..
Re-Revert Devirtualize destructor of final class.
Thu, Jul 11, 5:31 PM

Wed, Jul 10

rupprecht committed rG77d3590a87ba: Revert [llvm-objcopy] Allow strip symtab from executables and DSOs (authored by rupprecht).
Revert [llvm-objcopy] Allow strip symtab from executables and DSOs
Wed, Jul 10, 4:34 PM
rupprecht added a comment to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

Temporarily reverted in r365712 due to the noted issue -- I don't think the fix should be too hard, but didn't seem trivial enough to just fix forward

Wed, Jul 10, 4:34 PM · Restricted Project
rupprecht committed rL365712: Revert [llvm-objcopy] Allow strip symtab from executables and DSOs.
Revert [llvm-objcopy] Allow strip symtab from executables and DSOs
Wed, Jul 10, 4:34 PM
rupprecht added a comment to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

This is an issue for fully linked executables that still have relocation sections, e.g. because it was linked with the --emit-relocs flag:

Wed, Jul 10, 4:18 PM · Restricted Project
rupprecht added a comment to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.

I'm seeing an error pulling this into our toolchain when trying to copy some files:

Wed, Jul 10, 3:03 PM · Restricted Project

Wed, Jul 3

rupprecht accepted D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.
Wed, Jul 3, 3:17 PM · Restricted Project

Tue, Jul 2

rupprecht committed rG02647f73d4a3: Revert [InlineCost] cleanup calculations of Cost and Threshold (authored by rupprecht).
Revert [InlineCost] cleanup calculations of Cost and Threshold
Tue, Jul 2, 9:03 PM
rupprecht committed rL365000: Revert [InlineCost] cleanup calculations of Cost and Threshold.
Revert [InlineCost] cleanup calculations of Cost and Threshold
Tue, Jul 2, 9:03 PM
rupprecht added a comment to D60740: [InlineCost] cleanup calculations of Cost and Threshold.

Thanks for the explanation. Temporarily reverted in r365000.

Tue, Jul 2, 9:03 PM · Restricted Project

Mon, Jul 1

rupprecht committed rG351b7e7b241c: Revert Recommit [PowerPC] Update P9 vector costs for insert/extract element (authored by rupprecht).
Revert Recommit [PowerPC] Update P9 vector costs for insert/extract element
Mon, Jul 1, 4:37 PM
rupprecht committed rL364876: Revert Recommit [PowerPC] Update P9 vector costs for insert/extract element.
Revert Recommit [PowerPC] Update P9 vector costs for insert/extract element
Mon, Jul 1, 4:35 PM
rupprecht committed rGa7972dc04a7e: Revert [SLP] Look-ahead operand reordering heuristic. (authored by rupprecht).
Revert [SLP] Look-ahead operand reordering heuristic.
Mon, Jul 1, 2:13 PM
rupprecht added a comment to D63948: [SLP] Limit compilation time of look-ahead operand reordering heuristic..

We're seeing several compilation timeouts as well. Temporarily reverted in r364846 since this review is ongoing.

Mon, Jul 1, 2:13 PM · Restricted Project
rupprecht committed rL364846: Revert [SLP] Look-ahead operand reordering heuristic..
Revert [SLP] Look-ahead operand reordering heuristic.
Mon, Jul 1, 2:10 PM

Jun 21 2019

rupprecht accepted D63327: [docs][llvm-nm] Improve symbol code documentation.
Jun 21 2019, 5:50 PM · Restricted Project
rupprecht accepted D62718: [llvm-objcopy] Change handling of output file permissions.

(ditto that Ray should take another look, but looks mostly fine to me)

Jun 21 2019, 5:47 PM · Restricted Project
rupprecht accepted D63583: [Support] Add fs::getUmask() function and change fs::setPermissions.
Jun 21 2019, 5:37 PM · Restricted Project
rupprecht abandoned D63292: [docs] Workaround old recommonmark version on buildbots.

Switching these docs to rst seems (unfortunately) better, abandoning this attempt.

Jun 21 2019, 4:42 PM · Restricted Project

Jun 20 2019

rupprecht committed rG73986707bd57: [CodeGen][test] Use FileCheck variable matchers for better test support (authored by rupprecht).
[CodeGen][test] Use FileCheck variable matchers for better test support
Jun 20 2019, 3:34 PM
rupprecht committed rL363996: [CodeGen][test] Use FileCheck variable matchers for better test support.
[CodeGen][test] Use FileCheck variable matchers for better test support
Jun 20 2019, 3:34 PM
rupprecht closed D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.
Jun 20 2019, 3:34 PM · Restricted Project
rupprecht added a comment to D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.

Sounds good, changed to use variable matching instead. This passes w/ either -fno-discard-value-names or -fdiscard-value-names used.

Jun 20 2019, 3:14 PM · Restricted Project
rupprecht updated the diff for D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.
  • Use filecheck variable matching instead of an explicit -fno-discard-value-names option
Jun 20 2019, 3:11 PM · Restricted Project
rupprecht created D63625: [CodeGen][test] Use -fno-discard-value-names for better test support.
Jun 20 2019, 2:29 PM · Restricted Project
rupprecht committed rG02508decf4ad: [DAGCombiner][NFC] Remove unused var (authored by rupprecht).
[DAGCombiner][NFC] Remove unused var
Jun 20 2019, 10:30 AM
rupprecht committed rL363954: [DAGCombiner][NFC] Remove unused var.
[DAGCombiner][NFC] Remove unused var
Jun 20 2019, 10:30 AM

Jun 19 2019

rupprecht committed rGf5d0d2d0410f: [test] Fix TargetParserTest runtime. (authored by rupprecht).
[test] Fix TargetParserTest runtime.
Jun 19 2019, 11:02 AM
rupprecht committed rL363851: [test] Fix TargetParserTest runtime..
[test] Fix TargetParserTest runtime.
Jun 19 2019, 11:02 AM
rupprecht committed rGff384a2d1c07: [clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart (authored by rupprecht).
[clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart
Jun 19 2019, 10:41 AM
rupprecht committed rL363848: [clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart.
[clang][test] Add missing LambdaTemplateParams test and migrate from getLocStart
Jun 19 2019, 10:40 AM

Jun 18 2019

rupprecht committed rG4053d95cd853: Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same… (authored by rupprecht).
Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same…
Jun 18 2019, 3:19 PM
rupprecht committed rL363747: Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same….
Revert [tblgen][disasm] Allow multiple encodings to disassemble to the same…
Jun 18 2019, 3:18 PM
rupprecht committed rG33e85ad95679: Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas (authored by rupprecht).
Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas
Jun 18 2019, 11:39 AM
rupprecht committed rL363718: Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas.
Revert [SROA] Enhance SROA to handle `addrspacecast`ed allocas
Jun 18 2019, 11:38 AM
rupprecht accepted D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Jun 18 2019, 11:23 AM · Restricted Project

Jun 17 2019

rupprecht accepted D62838: [Object] add isExecutableObject member function.

LGTM just with the naming nit from James (header_t&->const HeaderType&)

Jun 17 2019, 11:51 AM · Restricted Project
rupprecht accepted D63122: [llvm-strip] Error when using stdin twice .
Jun 17 2019, 11:41 AM · Restricted Project
rupprecht added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Jun 17 2019, 11:05 AM · Restricted Project
rupprecht added inline comments to D63327: [docs][llvm-nm] Improve symbol code documentation.
Jun 17 2019, 10:44 AM · Restricted Project
rupprecht added a comment to D62838: [Object] add isExecutableObject member function.

(just the one comment, then lgtm)

Jun 17 2019, 10:33 AM · Restricted Project
rupprecht added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Jun 17 2019, 10:29 AM · Restricted Project
rupprecht added a comment to D63394: [yaml2obj][ELF] Suport STT_LOOS, STT_HIOS, STT_LOPROC and STT_HIPROC..

I'm totally fine with not commit this. But it seems just a small convenience from a tooling perspective (no need for the semantics of the symbol type) when you need the value but not in an OS or processor specific way and STT_LOOS looks better than "10"?

I may have been a bit hasty rejecting this. My concern is that I have already seen instances in LLVM where people possibly not well-versed in ELF try to use these as actual types in testing and in tools consuming these values, which can lead to confusion or worse, bogus output (e.g. llvm-readelf claiming that a symbol's type is STT_LOOS). @grimar, do you have any thoughts?

Jun 17 2019, 9:56 AM · Restricted Project

Jun 14 2019

rupprecht added inline comments to D62838: [Object] add isExecutableObject member function.
Jun 14 2019, 11:45 AM · Restricted Project

Jun 13 2019

rupprecht added a comment to D63211: [docs] Fix local docs build.

I replied to your llvm-dev thread. I think we should apply something like D63292, upgrade the buildbots, and then apply this change when reverting D63292.

Jun 13 2019, 1:53 PM · Restricted Project
rupprecht created D63292: [docs] Workaround old recommonmark version on buildbots.
Jun 13 2019, 11:44 AM · Restricted Project
rupprecht committed rG4244dd5e3f9e: [docs] Fix TableGen/LangRef typos (authored by rupprecht).
[docs] Fix TableGen/LangRef typos
Jun 13 2019, 11:40 AM
rupprecht committed rL363294: [docs] Fix TableGen/LangRef typos.
[docs] Fix TableGen/LangRef typos
Jun 13 2019, 11:40 AM

Jun 12 2019

rupprecht accepted D62583: [llvm-objcopy] Implement IHEX reader.
Jun 12 2019, 3:27 PM · Restricted Project
rupprecht added inline comments to D61672: [llvm-objcopy] Allow strip symtab in executables and DSOs.
Jun 12 2019, 3:13 PM · Restricted Project
rupprecht added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Jun 12 2019, 2:09 PM · Restricted Project
rupprecht added a comment to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..

Sure, committed as r363198

Jun 12 2019, 1:16 PM · Restricted Project
rupprecht committed rG565f1e2298ce: [llvm-readobj] Fix output interleaving issue caused by using multiple streams… (authored by rupprecht).
[llvm-readobj] Fix output interleaving issue caused by using multiple streams…
Jun 12 2019, 1:15 PM
rupprecht committed rL363198: [llvm-readobj] Fix output interleaving issue caused by using multiple streams….
[llvm-readobj] Fix output interleaving issue caused by using multiple streams…
Jun 12 2019, 1:14 PM
rupprecht closed D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Jun 12 2019, 1:14 PM · Restricted Project
rupprecht added inline comments to D62838: [Object] add isExecutableObject member function.
Jun 12 2019, 1:00 PM · Restricted Project
rupprecht accepted D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Jun 12 2019, 12:01 PM · Restricted Project
rupprecht accepted D63195: [docs][llvm-symbolizer] Fix --functions syntax highlighting.
Jun 12 2019, 11:54 AM · Restricted Project
rupprecht accepted D63197: [llvm-ar][test] Add to MRI test coverage .
Jun 12 2019, 11:52 AM · Restricted Project
rupprecht committed rG146a154e610b: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test (authored by rupprecht).
[llvm-ar][test] Relax lit directory assumptions in thin-archive.test
Jun 12 2019, 11:39 AM
rupprecht committed rL363189: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test.
[llvm-ar][test] Relax lit directory assumptions in thin-archive.test
Jun 12 2019, 11:39 AM
rupprecht closed D62930: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test.
Jun 12 2019, 11:38 AM · Restricted Project
rupprecht added a comment to D63211: [docs] Fix local docs build.

Looks like I'm on 1.7.5, from last year (http://www.sphinx-doc.org/en/master/changes.html#release-1-7-5-released-may-29-2018). Not sure how to check the bot version.

Jun 12 2019, 9:24 AM · Restricted Project
rupprecht added a comment to D63211: [docs] Fix local docs build.

I intentionally added .html because I noticed the link on llvm.org is broken: http://llvm.org/docs/CommandGuide/llvm-addr2line.html links to http://llvm.org/docs/CommandGuide/llvm-symbolizer, which does not exist (http://llvm.org/docs/CommandGuide/llvm-symbolizer.html does).

Jun 12 2019, 8:33 AM · Restricted Project

Jun 11 2019

rupprecht added inline comments to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Jun 11 2019, 5:25 PM · Restricted Project
rupprecht added inline comments to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Jun 11 2019, 3:35 PM · Restricted Project
rupprecht committed rG4c3722aea81a: [docs] Add "GNU binutils Replacements" section to command guide (authored by rupprecht).
[docs] Add "GNU binutils Replacements" section to command guide
Jun 11 2019, 2:13 PM
rupprecht committed rL363100: [docs] Add "GNU binutils Replacements" section to command guide.
[docs] Add "GNU binutils Replacements" section to command guide
Jun 11 2019, 2:12 PM
rupprecht closed D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Jun 11 2019, 2:12 PM · Restricted Project
rupprecht added inline comments to D63122: [llvm-strip] Error when using stdin twice .
Jun 11 2019, 2:06 PM · Restricted Project
rupprecht added inline comments to D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time..
Jun 11 2019, 12:18 PM · Restricted Project

Jun 10 2019

rupprecht accepted D62973: [llvm-objcopy] Changed command line parsing errors.

Thanks for splitting up the patch! I should have requested that earlier.

Jun 10 2019, 1:41 PM · Restricted Project
rupprecht added inline comments to D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Jun 10 2019, 1:05 PM · Restricted Project
rupprecht updated the diff for D63014: [docs] Add "GNU binutils Replacements" section to command guide.
  • Clarify llvm-readelf compatibility
Jun 10 2019, 1:04 PM · Restricted Project
rupprecht accepted D63090: [objcopy] Error when --preserve-dates is specified with standard streams.
Jun 10 2019, 12:58 PM · Restricted Project
rupprecht retitled D63014: [docs] Add "GNU binutils Replacements" section to command guide from [docs] Add "GNU Replacements" section to command guide to [docs] Add "GNU binutils Replacements" section to command guide.
Jun 10 2019, 11:43 AM · Restricted Project
rupprecht committed rGf8f9d65f85b6: [llvm-objcopy] Fix SHT_GROUP ordering. (authored by rupprecht).
[llvm-objcopy] Fix SHT_GROUP ordering.
Jun 10 2019, 11:33 AM
rupprecht committed rL362973: [llvm-objcopy] Fix SHT_GROUP ordering..
[llvm-objcopy] Fix SHT_GROUP ordering.
Jun 10 2019, 11:33 AM
rupprecht closed D62620: [llvm-objcopy] Fix SHT_GROUP ordering..
Jun 10 2019, 11:33 AM · Restricted Project
rupprecht committed rG13d16b94c6b7: [docs] Add 'git llvm revert' to getting started guide (authored by rupprecht).
[docs] Add 'git llvm revert' to getting started guide
Jun 10 2019, 9:59 AM
rupprecht committed rL362966: [docs] Add 'git llvm revert' to getting started guide.
[docs] Add 'git llvm revert' to getting started guide
Jun 10 2019, 9:59 AM
rupprecht closed D63023: [docs] Add 'git llvm revert' to getting started guide.
Jun 10 2019, 9:59 AM · Restricted Project

Jun 7 2019

rupprecht committed rG7dd813fea1d4: [llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of… (authored by rupprecht).
[llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of…
Jun 7 2019, 2:49 PM
rupprecht committed rL362847: [llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of….
[llvm-objdump] Fix Bugzilla ID 41862 to support checking addresses of…
Jun 7 2019, 2:49 PM
rupprecht closed D61969: llvm-objdump:Fix Bugzilla ID 41862 to support checking addresses of disassembled object.
Jun 7 2019, 2:48 PM · Restricted Project
rupprecht added a reviewer for D60974: Clang IFSO driver action.: rupprecht.

Can you upload this patch with context? Either use arc or upload w/ -U99999

Jun 7 2019, 1:28 PM · Restricted Project, Restricted Project
rupprecht created D63023: [docs] Add 'git llvm revert' to getting started guide.
Jun 7 2019, 12:59 PM · Restricted Project
rupprecht created D63014: [docs] Add "GNU binutils Replacements" section to command guide.
Jun 7 2019, 10:59 AM · Restricted Project
rupprecht added a comment to D63011: [docs]Move llvm-readobj from "Developer Tools" to "Basic Commands".

I actually wonder if we should split out all the binary utilities to a separate section. We should try to advertise the replacement-ness of all the tools we have.

That's probably not a bad shout, though we'd have to figure out exactly what we mean by "binary utilities" as I suspect everybody has a slightly different interpretation of this. Maybe a section labelled "GNU replacements"

SGTM. There's a definitive list of that here: https://www.gnu.org/software/binutils/

Jun 7 2019, 10:08 AM · Restricted Project
rupprecht added a comment to D63011: [docs]Move llvm-readobj from "Developer Tools" to "Basic Commands".

Thanks @MaskRay.

Since llvm-objdump and llvm-nm are in the "Basic Commands" list, and llvm-readobj is used in various test directories: CodeGen/DebugInfo/MC/LTO/..., I think it qualifies as a Basic Command :)

I think the distinction is "tools in LLVM used by people" versus "tools used by LLVM developers (mostly for testing/debugging)".

Are you saying LLVM developers aren't people? :p

Jun 7 2019, 9:46 AM · Restricted Project