Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (33 w, 6 d)

Recent Activity

Yesterday

rupprecht added inline comments to D58234: [llvm-objcopy] Add --add-symbol.
Tue, Feb 19, 3:52 PM
rupprecht updated the diff for D58316: [llvm-objcopy][NFC] More error cleanup.
  • Fix error message punctuation
Tue, Feb 19, 3:30 PM · Restricted Project
rupprecht added a comment to D58316: [llvm-objcopy][NFC] More error cleanup.

I guess this is okay, but I'm wondering if it's gone too far? The majority of cases you've changed here are in the driver layer, so wouldn't likely ever be librarified. What's the motivation for this round?

Tue, Feb 19, 3:30 PM · Restricted Project
rupprecht added a comment to D58296: [llvm-objcopy] Make removeSectionReferences batched.

The approach looks good to me, but is anyone concerned about the 3MB compressed file?

FWIW, this would be the 11th largest file:

Tue, Feb 19, 3:05 PM · Restricted Project
rupprecht updated the diff for D58296: [llvm-objcopy] Make removeSectionReferences batched.
  • vector->ArrayRef
  • Pluralize Sections arg
Tue, Feb 19, 3:03 PM · Restricted Project
rupprecht committed rGd138b1266a6a: [libObject][NFC] Use sys::path::convert_to_slash. (authored by rupprecht).
[libObject][NFC] Use sys::path::convert_to_slash.
Tue, Feb 19, 10:14 AM
rupprecht committed rL354364: [libObject][NFC] Use sys::path::convert_to_slash..
[libObject][NFC] Use sys::path::convert_to_slash.
Tue, Feb 19, 10:14 AM
rupprecht closed D58298: [libObject][NFC] Use sys::path::convert_to_slash..
Tue, Feb 19, 10:14 AM · Restricted Project

Fri, Feb 15

rupprecht created D58316: [llvm-objcopy][NFC] More error cleanup.
Fri, Feb 15, 5:15 PM · Restricted Project
rupprecht added a reviewer for D58307: [Clang Driver] Add support for "-static-pie" argument to the Clang driver.: saugustine.
Fri, Feb 15, 3:00 PM · Restricted Project, Restricted Project
rupprecht accepted D57904: [llvm-objdump] Allow short options to be grouped.

Just a couple comments, but feel free to commit once those are fixed. Thanks!

Fri, Feb 15, 12:59 PM · Restricted Project
rupprecht created D58298: [libObject][NFC] Use sys::path::convert_to_slash..
Fri, Feb 15, 11:54 AM · Restricted Project
rupprecht created D58296: [llvm-objcopy] Make removeSectionReferences batched.
Fri, Feb 15, 11:28 AM · Restricted Project

Thu, Feb 14

rupprecht accepted D58146: [symbolizer] Avoid collecting symbols belonging to invalid sections..
Thu, Feb 14, 2:42 PM · Restricted Project
rupprecht added inline comments to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
Thu, Feb 14, 2:30 PM
rupprecht added a comment to D57904: [llvm-objdump] Allow short options to be grouped.

I think you can still add tests for the other options, e.g. test/tools/llvm-objdump/X86/macho-disassembly-g-dsym.test tests -d -g, so you could add another run statement to that test with -dg and use cmp to verify it produces the same thing

Thu, Feb 14, 2:24 PM · Restricted Project
rupprecht added inline comments to D58234: [llvm-objcopy] Add --add-symbol.
Thu, Feb 14, 11:11 AM
rupprecht committed rGb7ae7297b94c: [llvm-ar] Implement the P modifier. (authored by rupprecht).
[llvm-ar] Implement the P modifier.
Thu, Feb 14, 10:35 AM
rupprecht committed rL354044: [llvm-ar] Implement the P modifier..
[llvm-ar] Implement the P modifier.
Thu, Feb 14, 10:35 AM
rupprecht closed D57927: [llvm-ar] Implement the P modifier..
Thu, Feb 14, 10:34 AM · Restricted Project

Wed, Feb 13

rupprecht accepted D57904: [llvm-objdump] Allow short options to be grouped.

Thanks!

Wed, Feb 13, 4:08 PM · Restricted Project
rupprecht committed rG451c2ef199e9: [llvm-ar][libObject] Fix relative paths when nesting thin archives. (authored by rupprecht).
[llvm-ar][libObject] Fix relative paths when nesting thin archives.
Wed, Feb 13, 3:40 PM
rupprecht committed rL353995: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
[llvm-ar][libObject] Fix relative paths when nesting thin archives.
Wed, Feb 13, 3:39 PM
rupprecht closed D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
Wed, Feb 13, 3:39 PM · Restricted Project
rupprecht added a comment to D56508: [llvm-ar] Flatten thin archives..

This fails if the archives are nested. E.g.:

$ mkdir -p foo/bar
$ cat > foo/bar/a.c <<EOF
int bar() { return 42; }
EOF
$ rm -f built-in.o foo/built-in.o foo/bar/built-in.o ; llvm-ar rcSTD foo/bar/built-in.o foo/bar/a.o ; llvm-ar rcSTD foo/built-in.o foo/bar/built-in.o ; llvm-ar rcSTD built-in.o foo/built-in.o
./llvm.opt.install/bin/llvm-ar: error: 'a.o': No such file or directory.

What's happening is that it's trying to find a.o in foo/ when it's really in foo/bar/.

Wed, Feb 13, 2:18 PM · Restricted Project
rupprecht accepted D58175: [llvm-readobj] Dump GNU_PROPERTY_X86_ISA_1_{NEEDED,USED} notes in .note.gnu.property.

I cross-referenced the values from https://github.com/hjl-tools/x86-psABI/wiki/x86-64-psABI-draft.pdf

Wed, Feb 13, 9:53 AM · Restricted Project

Tue, Feb 12

rupprecht committed rG08c3841b21cf: [llvm-dwp] Use color-formatted error reporting (authored by rupprecht).
[llvm-dwp] Use color-formatted error reporting
Tue, Feb 12, 12:38 PM
rupprecht committed rL353876: [llvm-dwp] Use color-formatted error reporting.
[llvm-dwp] Use color-formatted error reporting
Tue, Feb 12, 12:38 PM
rupprecht committed rG706a96529561: [llvm-dwp] Avoid writing the output dwp file when there is an error (authored by rupprecht).
[llvm-dwp] Avoid writing the output dwp file when there is an error
Tue, Feb 12, 12:01 PM
rupprecht committed rL353873: [llvm-dwp] Avoid writing the output dwp file when there is an error.
[llvm-dwp] Avoid writing the output dwp file when there is an error
Tue, Feb 12, 12:01 PM
rupprecht closed D58130: [llvm-dwp] Avoid writing the output dwp file when there is an error.
Tue, Feb 12, 12:01 PM · Restricted Project
rupprecht created D58130: [llvm-dwp] Avoid writing the output dwp file when there is an error.
Tue, Feb 12, 8:33 AM · Restricted Project
rupprecht accepted D58112: [llvm-readobj] Dump GNU_PROPERTY_X86_FEATURE_2_{NEEDED,USED} notes in .note.gnu.property.
Tue, Feb 12, 7:09 AM · Restricted Project
rupprecht committed rG4b78d4f3470d: [llvm-dwp] Abort when dwo_id is unset (authored by rupprecht).
[llvm-dwp] Abort when dwo_id is unset
Tue, Feb 12, 7:01 AM
rupprecht committed rL353846: [llvm-dwp] Abort when dwo_id is unset.
[llvm-dwp] Abort when dwo_id is unset
Tue, Feb 12, 7:01 AM
rupprecht closed D58085: [llvm-dwp] Abort when dwo_id is unset.
Tue, Feb 12, 7:00 AM · Restricted Project

Mon, Feb 11

rupprecht updated the diff for D58085: [llvm-dwp] Abort when dwo_id is unset.
  • Use optional
  • Fix error message casing
Mon, Feb 11, 7:59 PM · Restricted Project
rupprecht created D58085: [llvm-dwp] Abort when dwo_id is unset.
Mon, Feb 11, 4:14 PM · Restricted Project
rupprecht added inline comments to D57916: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths.
Mon, Feb 11, 1:39 PM · Restricted Project
rupprecht added a comment to D57896: Variable names rule.

Is this actually any better? Whereas before we can’t differentiate type names and variable names, under this proposal we can’t differentiate type names and function names. So it seems a bit of “6 of 1, half dozen of another”

Perhaps you mistyped? The proposal does not change the status quo of either type names nor function names. If you mean that we can't differentiate variable names and function names, then it seems worthwhile to point out that the actual letters (not just the case of said letters) matter too. Whereas the guidelines state that types and variables should have names that are nouns, the guidelines state that functions should have names that are verb phrases.

Mon, Feb 11, 1:31 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D57904: [llvm-objdump] Allow short options to be grouped.
Mon, Feb 11, 11:41 AM · Restricted Project
rupprecht accepted D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).
Mon, Feb 11, 11:34 AM · Restricted Project
rupprecht committed rG5b7ad4272946: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths (authored by rupprecht).
[DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths
Mon, Feb 11, 10:06 AM
rupprecht committed rL353730: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths.
[DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths
Mon, Feb 11, 10:05 AM
rupprecht closed D57916: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths.
Mon, Feb 11, 10:05 AM · Restricted Project
rupprecht added inline comments to D57916: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths.
Mon, Feb 11, 10:02 AM · Restricted Project

Fri, Feb 8

rupprecht updated the summary of D57916: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths.
Fri, Feb 8, 6:18 PM · Restricted Project
rupprecht updated the diff for D57916: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths.
  • Add --fallback-debug-path flag for testing /usr/lib/debug fallback
Fri, Feb 8, 6:17 PM · Restricted Project
rupprecht updated subscribers of D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
Fri, Feb 8, 5:21 PM · Restricted Project
rupprecht added a comment to D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..

Reopened + updated patch with LibDriver fixes. I believe this should fix the chromium build, but haven't verified it. The new test case (llvm/test/tools/llvm-lib/thin-relative.test) should capture the issue, and was failing with the old patch but is now fixed.

Fri, Feb 8, 5:19 PM · Restricted Project
rupprecht added a reviewer for D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives.: inglorion.
Fri, Feb 8, 5:15 PM · Restricted Project
rupprecht updated the diff for D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..

Add regression test for chromium linking issue, and update LibDriver call site to correctly compute relative paths.

Fri, Feb 8, 5:15 PM · Restricted Project
rupprecht reopened D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
Fri, Feb 8, 5:15 PM · Restricted Project
rupprecht added inline comments to D57945: Small refactoring of FileError. NFC.
Fri, Feb 8, 10:11 AM · Restricted Project
rupprecht added a comment to D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..

I reverted this in r353507 as it broke the Chromium build; see https://crbug.com/930058

Fri, Feb 8, 7:52 AM · Restricted Project

Thu, Feb 7

rupprecht created D57937: [llvm-ar] Rewrite the symbol table when it is invalid..
Thu, Feb 7, 7:28 PM · Restricted Project
rupprecht added a comment to D57927: [llvm-ar] Implement the P modifier..

I played with ar and found that the following behavior is pretty odd.

  1. Create an archive $ mkdir x $ echo 123 > x/foo.txt $ ar rcS archive.a x/foo.txt
  2. Directory name is not stored to archive.a $ cat archive.a !<arch> foo.txt/ 0 0 0 644 4 ` 123
  3. But you can extract foo.txt with any directory name $ ar x archive.a bar/foo.txt $ cat foo.txt 123

    If I understand correctly, ar by default ignores directory names in many situations like the above, and "P" flag is to make it to not ignore directory names in a pathname. It looks like the default behavior is broken. Is that important for compatibility? I wonder if there's a chance to make "P" the default behavior.
Thu, Feb 7, 3:00 PM · Restricted Project
rupprecht created D57927: [llvm-ar] Implement the P modifier..
Thu, Feb 7, 2:20 PM · Restricted Project
rupprecht added a comment to D57609: [DebugInfo] Don't use realpath when looking up debug binary locations..

Ugh, too bad the original commit didn't provide any rationale, but here's my guess based on reading the source code:

Note that llvm-symbolizer (or another tool that uses this library) can be invoked with the relative path (e.g. cd /tmp/dir; llvm-symbolizer foo).

Then, if you can't find the .debuglink file at following locations: foo.debuglink (absolute path /tmp/dir/foo.debuglink), or .debug/foo.debuglink (absolute path /tmp/dir/.debuglink/foo.debuglink),
which can often happen if you're symbolizing the code from standard library, you have to look for this file in /usr/lib/... or /usr/libdata/... for NetBSD. That's when you need the realpath for the file in question,
so that you try to open:

/usr/lib/debug/tmp/dir/foo.debuglink

instead of

/usr/lib/debug/foo.debuglink

I think the absolute path (not realpath) would suffice, then.

Also, using the full path can be delayed to when checking in /usr/lib/debug.

I'll restore this patch with those modifications. No idea how I'll create a test for it though -- writing to /usr/lib/debug probably doesn't work on buildbots.

Thu, Feb 7, 11:09 AM · Restricted Project
rupprecht created D57916: [DebugInfo] Fix /usr/lib/debug llvm-symbolizer lookup with relative paths.
Thu, Feb 7, 11:09 AM · Restricted Project
rupprecht added a comment to D57609: [DebugInfo] Don't use realpath when looking up debug binary locations..

Ugh, too bad the original commit didn't provide any rationale, but here's my guess based on reading the source code:

Note that llvm-symbolizer (or another tool that uses this library) can be invoked with the relative path (e.g. cd /tmp/dir; llvm-symbolizer foo).

Then, if you can't find the .debuglink file at following locations: foo.debuglink (absolute path /tmp/dir/foo.debuglink), or .debug/foo.debuglink (absolute path /tmp/dir/.debuglink/foo.debuglink),
which can often happen if you're symbolizing the code from standard library, you have to look for this file in /usr/lib/... or /usr/libdata/... for NetBSD. That's when you need the realpath for the file in question,
so that you try to open:

/usr/lib/debug/tmp/dir/foo.debuglink

instead of

/usr/lib/debug/foo.debuglink

Thu, Feb 7, 10:39 AM · Restricted Project
rupprecht added a reviewer for D57904: [llvm-objdump] Allow short options to be grouped: rupprecht.
Thu, Feb 7, 10:18 AM · Restricted Project
rupprecht added a comment to D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language.

The patch itself looks sound. However given that you have a specific use case in mind (TableGen files) could you provide supplementary coverage for that specific use case (unit tests for formatting td syntax using format::getLLVMStyle(format::FormatStyle::LK_TableGen)? I'm not entirely sure how useful this particular change is given that there's no linked patches related to your use case, I think adding those would help as well (possibly as a separate dependent patchset).

The use case is a pre-refactoring for D55964, which is in the patch description -- is that what you mean by "linked patches"?
I'll update that patch to use this approach, and make it a dependent patch.

Thu, Feb 7, 8:59 AM · Restricted Project
rupprecht added a parent revision for D55964: [clang-format][TableGen] Don't add spaces around items in square braces.: D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language.
Thu, Feb 7, 8:55 AM · Restricted Project
rupprecht added a child revision for D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language: D55964: [clang-format][TableGen] Don't add spaces around items in square braces..
Thu, Feb 7, 8:55 AM · Restricted Project
rupprecht updated the diff for D55964: [clang-format][TableGen] Don't add spaces around items in square braces..
  • Rebased w/ D56943 patched in so we can override just TableGen in getLLVMStyle()
Thu, Feb 7, 8:55 AM · Restricted Project
rupprecht committed rGbf990ab5aab0: [llvm-ar][libObject] Fix relative paths when nesting thin archives. (authored by rupprecht).
[llvm-ar][libObject] Fix relative paths when nesting thin archives.
Thu, Feb 7, 8:41 AM
rupprecht committed rL353424: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
[llvm-ar][libObject] Fix relative paths when nesting thin archives.
Thu, Feb 7, 8:41 AM
rupprecht closed D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
Thu, Feb 7, 8:40 AM · Restricted Project
rupprecht added a comment to D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language.

The patch itself looks sound. However given that you have a specific use case in mind (TableGen files) could you provide supplementary coverage for that specific use case (unit tests for formatting td syntax using format::getLLVMStyle(format::FormatStyle::LK_TableGen)? I'm not entirely sure how useful this particular change is given that there's no linked patches related to your use case, I think adding those would help as well (possibly as a separate dependent patchset).

Thu, Feb 7, 8:38 AM · Restricted Project

Wed, Feb 6

rupprecht accepted D57861: [WebAssembly] Expand symbols shown by llvm-objdump --symbols.
Wed, Feb 6, 4:56 PM · Restricted Project
rupprecht added inline comments to D57861: [WebAssembly] Expand symbols shown by llvm-objdump --symbols.
Wed, Feb 6, 4:19 PM · Restricted Project
Herald added a project to D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language: Restricted Project.

ping

Wed, Feb 6, 3:36 PM · Restricted Project
rupprecht updated the diff for D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
  • Fix related test to always delete the archive first
  • Inline addToStringTable
  • Remove redundant assignment
Wed, Feb 6, 3:02 PM · Restricted Project
rupprecht added inline comments to D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
Wed, Feb 6, 2:27 PM · Restricted Project
rupprecht updated the diff for D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
  • Move computeRelativePath special case from libObject to llvm-ar
  • Remove obsolete test fixme
Wed, Feb 6, 2:26 PM · Restricted Project
rupprecht committed rGdb5036504ec5: [llvm-ar] Remove leading slash when printing thin archive members (authored by rupprecht).
[llvm-ar] Remove leading slash when printing thin archive members
Wed, Feb 6, 1:52 PM
rupprecht committed rL353347: [llvm-ar] Remove leading slash when printing thin archive members.
[llvm-ar] Remove leading slash when printing thin archive members
Wed, Feb 6, 1:52 PM
rupprecht closed D57845: [llvm-ar] Remove leading slash when printing thin archive members.
Wed, Feb 6, 1:52 PM · Restricted Project
rupprecht added inline comments to D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
Wed, Feb 6, 1:33 PM · Restricted Project
rupprecht created D57845: [llvm-ar] Remove leading slash when printing thin archive members.
Wed, Feb 6, 1:31 PM · Restricted Project
rupprecht created D57842: [llvm-ar][libObject] Fix relative paths when nesting thin archives..
Wed, Feb 6, 1:11 PM · Restricted Project
rupprecht committed rGd3a7e9d153f5: [libObject][NFC] Include filename in error message (authored by rupprecht).
[libObject][NFC] Include filename in error message
Wed, Feb 6, 12:51 PM
rupprecht committed rL353341: [libObject][NFC] Include filename in error message.
[libObject][NFC] Include filename in error message
Wed, Feb 6, 12:51 PM

Tue, Feb 5

rupprecht accepted D57618: [ADT] Add a fallible_iterator wrapper..
Tue, Feb 5, 1:48 PM · Restricted Project
rupprecht accepted D57700: [llvm-readobj] Display sections that do not belong to a segment in the section-mapping.

Hello Davide,
The present format is good enough to convey the information. It is however not sufficient or sometimes difficult for present users of GNU tools (which are quite ubiquitous) to make a
switch as it is complete redesign of the post processing tools they may have based on.

-Hemant

It's not immediately clear from the original introduction of GNU style whether complete output identity was the original goal, or just similarity. Similarly, it's not clear from my previously attempt to gather information as to users expectations. I've subscribed @khemant in case he's got any further comments, since he made the original change. My reading of rL260430 which commits it is that it is intended to be like GNU readelf, but doesn't necessarily have to be identical. I'm open to further discussion on this (and I actually have a BoF on this subject at the next Euro LLVM, but that's still a couple of months away).

@jhenderson Thanks for tracking down that comment. I interpreted that comment as you described. Personally, I think a one line addition to the existing GNU style output is a reasonable change that will not detract users who might be expecting GNU-styled output. The change provides the user with the familiar GNU style, and provides a one line bonus (it provides a complete table (all of the sections are accounted for)). The main "issue" I see is that anyone diffing llvm-readelf output against the equivalent GNU output will see a line difference (llvm-readelf has the Notes, GNU readelf does not). If users diff output between llvm-readelf and GNU readelf, they would see other differences as well, primarily the number of digits used to represent some of the values in the --program-headers output.

Tue, Feb 5, 11:52 AM · Restricted Project
rupprecht added inline comments to D57738: [llvm-objcopy] Add --redefine-syms.
Tue, Feb 5, 11:08 AM · Restricted Project
rupprecht added a reviewer for D57738: [llvm-objcopy] Add --redefine-syms: jakehehrlich.
Tue, Feb 5, 11:08 AM · Restricted Project
rupprecht requested changes to D57618: [ADT] Add a fallible_iterator wrapper..
Tue, Feb 5, 10:53 AM · Restricted Project
rupprecht added inline comments to D57738: [llvm-objcopy] Add --redefine-syms.
Tue, Feb 5, 10:30 AM · Restricted Project
rupprecht accepted D57517: [llvm-objcopy] Allow using regex in name comparison.
Tue, Feb 5, 9:38 AM · Restricted Project

Mon, Feb 4

rupprecht committed rG2e862c7555e3: [llvm-objcopy][NFC] simplify an error return (authored by rupprecht).
[llvm-objcopy][NFC] simplify an error return
Mon, Feb 4, 11:10 AM
rupprecht committed rL353074: [llvm-objcopy][NFC] simplify an error return.
[llvm-objcopy][NFC] simplify an error return
Mon, Feb 4, 11:09 AM
rupprecht committed rG5745c5f54f45: [llvm-objcopy][NFC] Use StringSaver for --keep-global-symbols (authored by rupprecht).
[llvm-objcopy][NFC] Use StringSaver for --keep-global-symbols
Mon, Feb 4, 10:39 AM
rupprecht committed rL353068: [llvm-objcopy][NFC] Use StringSaver for --keep-global-symbols.
[llvm-objcopy][NFC] Use StringSaver for --keep-global-symbols
Mon, Feb 4, 10:39 AM
rupprecht closed D57617: [llvm-objcopy][NFC] Use StringSaver for --keep-global-symbols.
Mon, Feb 4, 10:39 AM · Restricted Project

Fri, Feb 1

rupprecht created D57617: [llvm-objcopy][NFC] Use StringSaver for --keep-global-symbols.
Fri, Feb 1, 2:04 PM · Restricted Project
rupprecht committed rL352918: [DebugInfo] Fix mkdir use in test.
[DebugInfo] Fix mkdir use in test
Fri, Feb 1, 1:14 PM
rupprecht committed rL352916: [DebugInfo] Don't use realpath when looking up debug binary locations..
[DebugInfo] Don't use realpath when looking up debug binary locations.
Fri, Feb 1, 1:04 PM
rupprecht closed D57609: [DebugInfo] Don't use realpath when looking up debug binary locations..
Fri, Feb 1, 1:04 PM · Restricted Project