rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (15 w, 5 d)

Recent Activity

Today

rupprecht added inline comments to D53163: [llvm-strip] Support -s alias for --strip-all. Make both strip and objcopy case sensitive to support both -s (--strip-all) and -S (--strip-debug)..
Tue, Oct 16, 4:10 PM
rupprecht updated the diff for D53163: [llvm-strip] Support -s alias for --strip-all. Make both strip and objcopy case sensitive to support both -s (--strip-all) and -S (--strip-debug)..
  • Reorder test cases for smaller diffs
Tue, Oct 16, 4:10 PM

Yesterday

rupprecht committed rL344550: [llvm-objcopy] NFC: update TODO test comment.
[llvm-objcopy] NFC: update TODO test comment
Mon, Oct 15, 1:17 PM
rupprecht added inline comments to D53029: [llvm-objcopy] Add -F|--target compatibility.
Mon, Oct 15, 1:09 PM

Thu, Oct 11

rupprecht committed rL344321: [llvm-objcopy] Add -F|--target compatibility.
[llvm-objcopy] Add -F|--target compatibility
Thu, Oct 11, 5:37 PM
rupprecht closed D53029: [llvm-objcopy] Add -F|--target compatibility.
Thu, Oct 11, 5:37 PM
rupprecht updated the diff for D53163: [llvm-strip] Support -s alias for --strip-all. Make both strip and objcopy case sensitive to support both -s (--strip-all) and -S (--strip-debug)..

Rebase past rL344307

Thu, Oct 11, 4:29 PM
rupprecht updated the diff for D53029: [llvm-objcopy] Add -F|--target compatibility.

Rebase past rL344307

Thu, Oct 11, 4:25 PM
rupprecht updated the summary of D53163: [llvm-strip] Support -s alias for --strip-all. Make both strip and objcopy case sensitive to support both -s (--strip-all) and -S (--strip-debug)..
Thu, Oct 11, 1:02 PM
rupprecht created D53163: [llvm-strip] Support -s alias for --strip-all. Make both strip and objcopy case sensitive to support both -s (--strip-all) and -S (--strip-debug)..
Thu, Oct 11, 1:00 PM
rupprecht committed rL344268: [llvm-nm] Fix crash when running with --print-armap on corrupt archives..
[llvm-nm] Fix crash when running with --print-armap on corrupt archives.
Thu, Oct 11, 10:57 AM

Wed, Oct 10

rupprecht accepted D53064: [llvm-nm] Include the text "@FILE" in the output of --help.

lgtm, thanks for the test!

Wed, Oct 10, 2:10 PM
rupprecht added a comment to D53064: [llvm-nm] Include the text "@FILE" in the output of --help.

I'm not sure @FILE syntax is actually supported by llvm-nm. At least, I can't find any unit tests that test it, and @ is not present in llvm-nm.cpp. I think that change should come first?

It does support it just fine right now (even if there's no explicit unit test for it). llvm-nm.cpp calls ParseCommandLineOptions, which internally calls ExpandResponseFiles, so this is implicit in more or less every llvm tool.

Wed, Oct 10, 1:33 PM
rupprecht added a comment to D53064: [llvm-nm] Include the text "@FILE" in the output of --help.

I'm not sure @FILE syntax is actually supported by llvm-nm. At least, I can't find any unit tests that test it, and @ is not present in llvm-nm.cpp. I think that change should come first?

Wed, Oct 10, 11:55 AM

Tue, Oct 9

rupprecht accepted D51109: [Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file...".
Tue, Oct 9, 5:15 PM
rupprecht accepted D51009: [opt] Change the parameter of OptTable::PrintHelp from Name to Usage and don't append "[options] <inputs>".
Tue, Oct 9, 5:15 PM
rupprecht accepted D53054: Adapt OptTable::PrintHelp change in D51009.
Tue, Oct 9, 5:15 PM
rupprecht created D53029: [llvm-objcopy] Add -F|--target compatibility.
Tue, Oct 9, 10:24 AM

Fri, Oct 5

rupprecht added a comment to D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr.

I patched the proposed fix-forward and it seems to have things building again. Is there an ETA on landing that? If it's going to take a bit, is there any chance we could revert this patch until then?

The fix was just committed (rC343902). Generally I'm for reverting if there are functional deficiencies, but here it's more that an unrelated issue was accidentally uncovered by this patch.

Fri, Oct 5, 6:57 PM
rupprecht committed rL343901: [llvm-ar] Use POSIX-specified timestamps for 'tv'..
[llvm-ar] Use POSIX-specified timestamps for 'tv'.
Fri, Oct 5, 4:27 PM
rupprecht closed D52940: [llvm-ar] Use POSIX-specified timestamps for 'tv'..
Fri, Oct 5, 4:27 PM
rupprecht added a comment to D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr.

@hokein Please have a look at D52888, maybe you can try it out already. The problem was that ?: expressions are considered a branch point and when merging both branches the warning was emitted. Before this change, we couldn't look into __builtin_expect and so we didn't see that the result of TryLock is used to branch.

Fri, Oct 5, 4:05 PM
rupprecht accepted D52943: [llvm-nm] Write "no symbol" output to stderr.

Thanks Petr, I completely missed that it was going to stderr!
There are two tests in lld and clang to update as well, see rL343743 and rL343744.

Fri, Oct 5, 1:36 PM
rupprecht created D52940: [llvm-ar] Use POSIX-specified timestamps for 'tv'..
Fri, Oct 5, 12:24 PM

Wed, Oct 3

rupprecht committed rL343744: [llvm-nm] Update clang tests based on changed llvm-nm output.
[llvm-nm] Update clang tests based on changed llvm-nm output
Wed, Oct 3, 4:41 PM
rupprecht committed rC343744: [llvm-nm] Update clang tests based on changed llvm-nm output.
[llvm-nm] Update clang tests based on changed llvm-nm output
Wed, Oct 3, 4:41 PM
rupprecht committed rL343742: [llvm-nm] Print an explicit "no symbols" message when an object file has no….
[llvm-nm] Print an explicit "no symbols" message when an object file has no…
Wed, Oct 3, 4:41 PM
rupprecht committed rL343743: [llvm-nm] Update lld tests based on changed llvm-nm output.
[llvm-nm] Update lld tests based on changed llvm-nm output
Wed, Oct 3, 4:41 PM
rupprecht closed D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols.
Wed, Oct 3, 4:41 PM
rupprecht committed rLLD343743: [llvm-nm] Update lld tests based on changed llvm-nm output.
[llvm-nm] Update lld tests based on changed llvm-nm output
Wed, Oct 3, 4:41 PM
rupprecht added a comment to D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols.

Looks good, GNU and some BSD nm use: nm: /bin/cat: no symbols but the repeated command name and filename do not seem useful.

In POSIX.1-2017 specification of nm, "If no symbolic information is available for a valid input file, the nm utility shall report that fact, but not consider it an error condition."

Wed, Oct 3, 2:00 PM
rupprecht added a reviewer for D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols: MaskRay.
Wed, Oct 3, 11:10 AM

Tue, Oct 2

rupprecht created D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols.
Tue, Oct 2, 4:28 PM

Mon, Oct 1

rupprecht added a comment to D52316: [TargetRegisterInfo] Remove temporary hook enableMultipleCopyHints().

This probably needs to wait until the compile time regressions have been addressed: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180924/590785.html

Mon, Oct 1, 1:17 PM

Thu, Sep 27

rupprecht committed rCRT343245: [compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on….
[compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on…
Thu, Sep 27, 11:15 AM
rupprecht committed rL343245: [compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on….
[compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on…
Thu, Sep 27, 11:14 AM
rupprecht closed D52563: [compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows..
Thu, Sep 27, 11:14 AM

Wed, Sep 26

rupprecht created D52563: [compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows..
Wed, Sep 26, 10:55 AM
rupprecht updated the summary of D52563: [compiler-rt] [builtins] Restore tests from r342917 (disabled in r343095) on Windows..
Wed, Sep 26, 10:55 AM

Mon, Sep 24

rupprecht committed rCRT342917: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid….
[compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid…
Mon, Sep 24, 1:44 PM
rupprecht committed rL342917: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid….
[compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid…
Mon, Sep 24, 1:44 PM
rupprecht closed D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..
Mon, Sep 24, 1:44 PM

Fri, Sep 21

rupprecht committed rL342791: [llvm-size] Berkeley formatting: use tabs instead of spaces as field delimeters..
[llvm-size] Berkeley formatting: use tabs instead of spaces as field delimeters.
Fri, Sep 21, 4:49 PM
rupprecht updated the diff for D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..
  • Elaborate libm dependency in comment
Fri, Sep 21, 2:50 PM
rupprecht added inline comments to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..
Fri, Sep 21, 2:47 PM

Thu, Sep 20

rupprecht committed rL342702: [llvm-objcopy/llvm-strip]: handle --version.
[llvm-objcopy/llvm-strip]: handle --version
Thu, Sep 20, 5:50 PM
rupprecht closed D52328: [llvm-objcopy/llvm-strip]: handle --version.
Thu, Sep 20, 5:50 PM
rupprecht created D52328: [llvm-objcopy/llvm-strip]: handle --version.
Thu, Sep 20, 3:36 PM

Tue, Sep 18

rupprecht added a comment to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..

@compnerd, can you take a look? Or add another reviewer comfortable approving if you can't review?

Tue, Sep 18, 4:21 PM
rupprecht updated the summary of D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..
Tue, Sep 18, 4:20 PM
rupprecht removed a reviewer for D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible.: howard.hinnant.
Tue, Sep 18, 4:20 PM
rupprecht added a comment to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..

Another ping for @howard.hinnant or @compnerd

Tue, Sep 18, 9:49 AM

Mon, Sep 17

rupprecht requested changes to D52180: [llvm-objcopy] Change --only-keep to --only-sections.

The GNU objcopy name is only-section, not only-sections (note singular vs plural)
But otherwise LGTM :)

Mon, Sep 17, 12:48 PM

Sep 11 2018

rupprecht added a comment to D51961: [objcopy] make objcopy follow program header standards.

Thanks for fixing this!

Sep 11 2018, 5:51 PM

Sep 6 2018

rupprecht added a comment to D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections..

Reverted temporarily in r341360 to unbreak my build and the aarch64 build bot. Let me know if I can help with the investigation in any way.

@jakehehrlich @chandlerc I need help reproing this. I finally got an aarch64 setup up and running and the tests pass. I don't understand why this would fail.

Sep 6 2018, 5:52 PM
rupprecht committed rL341614: [llvm-strip] -p test fix for windows buildbots.
[llvm-strip] -p test fix for windows buildbots
Sep 6 2018, 5:32 PM
rupprecht committed rL341595: [llvm-strip] Fix -p test to check for explicit spaces around dates, to avoid….
[llvm-strip] Fix -p test to check for explicit spaces around dates, to avoid…
Sep 6 2018, 3:36 PM

Sep 5 2018

rupprecht committed rL341464: [llvm-strip] Support stripping multiple input files.
[llvm-strip] Support stripping multiple input files
Sep 5 2018, 6:12 AM
rupprecht closed D51660: [llvm-strip] Support stripping multiple input files.
Sep 5 2018, 6:12 AM

Sep 4 2018

rupprecht updated the diff for D51660: [llvm-strip] Support stripping multiple input files.
  • Simplify test
Sep 4 2018, 5:15 PM
rupprecht added inline comments to D51660: [llvm-strip] Support stripping multiple input files.
Sep 4 2018, 5:15 PM
rupprecht updated the diff for D51660: [llvm-strip] Support stripping multiple input files.
  • Use SmallVector for CopyConfigs
Sep 4 2018, 4:19 PM
rupprecht committed rL341419: [llvm-strip] Allow copying relocation sections without symbol tables..
[llvm-strip] Allow copying relocation sections without symbol tables.
Sep 4 2018, 3:30 PM
rupprecht closed D51493: [llvm-strip] Allow copying relocation sections without symbol tables..
Sep 4 2018, 3:30 PM
rupprecht added a reviewer for D51660: [llvm-strip] Support stripping multiple input files: jakehehrlich.
Sep 4 2018, 3:29 PM
rupprecht updated the diff for D51660: [llvm-strip] Support stripping multiple input files.
  • Add test case for -o flag error
Sep 4 2018, 3:29 PM
rupprecht created D51660: [llvm-strip] Support stripping multiple input files.
Sep 4 2018, 3:24 PM
rupprecht added a comment to D51493: [llvm-strip] Allow copying relocation sections without symbol tables..

When I run that yaml2obj test I actually get the following error rather than a silent failure.

error: Unknown section referenced: '0' at YAML section '.rela.plt'.

You might need to modify yaml2obj to test this or just convince me that this doesn't need testing. Alternatively you can upload a binary to the repo in Inputs that reproduces the issue.

I'm using yaml2obj from head -- maybe there's a recent change that fixed this?

Looks like r339873 changed/fixed this.

Sep 4 2018, 2:42 PM
rupprecht added a comment to D51493: [llvm-strip] Allow copying relocation sections without symbol tables..

When I run that yaml2obj test I actually get the following error rather than a silent failure.

error: Unknown section referenced: '0' at YAML section '.rela.plt'.

You might need to modify yaml2obj to test this or just convince me that this doesn't need testing. Alternatively you can upload a binary to the repo in Inputs that reproduces the issue.

Sep 4 2018, 2:17 PM
rupprecht added a comment to D51493: [llvm-strip] Allow copying relocation sections without symbol tables..

Did you confirm that yaml2obj respects the explicit Link field?

Sep 4 2018, 2:09 PM
rupprecht updated the diff for D51493: [llvm-strip] Allow copying relocation sections without symbol tables..
  • Explicitly set Link = 0 when there's no symbol, and update test case to check Link = 0 in the input file as well.
Sep 4 2018, 1:31 PM
rupprecht added inline comments to D51493: [llvm-strip] Allow copying relocation sections without symbol tables..
Sep 4 2018, 1:31 PM
rupprecht committed rL341397: [Codegen] Fix test added in rL341380: AArch64SelectionDAGTest needs to link….
[Codegen] Fix test added in rL341380: AArch64SelectionDAGTest needs to link…
Sep 4 2018, 1:20 PM

Aug 30 2018

rupprecht added a comment to D51009: [opt] Change the parameter of OptTable::PrintHelp from Name to Usage and don't append "[options] <inputs>".

I'm still against having a space in the string as the basis for interpreting it as a usage parameter. It's way too surprising.

Aug 30 2018, 11:10 AM
rupprecht created D51493: [llvm-strip] Allow copying relocation sections without symbol tables..
Aug 30 2018, 9:58 AM

Aug 29 2018

rupprecht added a comment to rL341002: [AttrDocs] Fix build bots: add missing GNUInline pragma to test..

Wait, what? Adding documentation for this attribute caused #pragma clang attribute to start supporting it?!

Aug 29 2018, 5:35 PM
rupprecht added a comment to rL341002: [AttrDocs] Fix build bots: add missing GNUInline pragma to test..

Thanks for cleaning this up, sorry I missed it. What's the command to run this test to verify?

Aug 29 2018, 5:15 PM
rupprecht added a comment to D51190: [AttrDocs]: document gnu_inline function attribute.

BTW, seems like these docs have tests that weren't updated. Fixed with rL341002, but please take a look if that's not the right fix.

Aug 29 2018, 5:08 PM
rupprecht added a comment to rL341002: [AttrDocs] Fix build bots: add missing GNUInline pragma to test..

Left out of the commit message: this fixes the test after rL340987

Aug 29 2018, 5:07 PM
rupprecht committed rL341002: [AttrDocs] Fix build bots: add missing GNUInline pragma to test..
[AttrDocs] Fix build bots: add missing GNUInline pragma to test.
Aug 29 2018, 5:06 PM
rupprecht committed rC341002: [AttrDocs] Fix build bots: add missing GNUInline pragma to test..
[AttrDocs] Fix build bots: add missing GNUInline pragma to test.
Aug 29 2018, 5:06 PM
rupprecht committed rL340996: [llvm-strip] Fix -p|--preserve-dates to not truncate output when used in-place..
[llvm-strip] Fix -p|--preserve-dates to not truncate output when used in-place.
Aug 29 2018, 4:23 PM

Aug 21 2018

rupprecht requested changes to D51009: [opt] Change the parameter of OptTable::PrintHelp from Name to Usage and don't append "[options] <inputs>".

Some uses of this already use a space and probably don't want this behavior -- e.g. tools/clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp invokes this w/ "clang -cc1". (There are a few others).

Aug 21 2018, 10:38 PM

Aug 20 2018

rupprecht added a comment to D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible..

Ping for @howard.hinnant @compnerd -- mind taking a quick look for a second LGTM?

Aug 20 2018, 10:14 AM

Aug 17 2018

rupprecht committed rL340105: [llvm-objcopy] Implement -G/--keep-global-symbol(s)..
[llvm-objcopy] Implement -G/--keep-global-symbol(s).
Aug 17 2018, 3:35 PM
rupprecht closed D50589: [llvm-objcopy] Implement -G/--keep-global-symbol(s)..
Aug 17 2018, 3:35 PM
rupprecht committed rL340071: Fix windows buildbots by removing : from filenames.
Fix windows buildbots by removing : from filenames
Aug 17 2018, 12:19 PM
rupprecht committed rL340070: [llvm-objcopy] Add support for -I binary -B <arch>..
[llvm-objcopy] Add support for -I binary -B <arch>.
Aug 17 2018, 11:52 AM
rupprecht closed D50343: [llvm-objcopy] Add support for -I binary -B <arch>..
Aug 17 2018, 11:52 AM

Aug 16 2018

rupprecht updated the diff for D50343: [llvm-objcopy] Add support for -I binary -B <arch>..

rebase/fix stale filename in a test case

Aug 16 2018, 11:51 AM
rupprecht committed rL339921: [llvm-strip] Add support for -p/--preserve-dates.
[llvm-strip] Add support for -p/--preserve-dates
Aug 16 2018, 11:30 AM
rupprecht closed D50744: [llvm-strip] Add support for -p/--preserve-dates.
Aug 16 2018, 11:30 AM
rupprecht updated the diff for D50744: [llvm-strip] Add support for -p/--preserve-dates.
  • crs->cr
Aug 16 2018, 10:57 AM
rupprecht added inline comments to D50744: [llvm-strip] Add support for -p/--preserve-dates.
Aug 16 2018, 10:56 AM
rupprecht updated the diff for D50744: [llvm-strip] Add support for -p/--preserve-dates.
  • Fix tests for windows compatibility
Aug 16 2018, 10:49 AM
rupprecht committed rUNW339899: NFC: Test commit access.
NFC: Test commit access
Aug 16 2018, 9:56 AM
rupprecht committed rL339899: NFC: Test commit access.
NFC: Test commit access
Aug 16 2018, 9:55 AM

Aug 15 2018

rupprecht updated the diff for D50343: [llvm-objcopy] Add support for -I binary -B <arch>..
  • Reorganize CopyConfig sections
Aug 15 2018, 11:23 AM
rupprecht added a comment to D50343: [llvm-objcopy] Add support for -I binary -B <arch>..

LGTM, but there is one thing still outstanding, I think, which @jakehehrlich mentioned in a comment regarding the CopyConfig options:

A pattern of grouping by type does seem to have formed organically however. Let's stick with it.

I don't have a strong preference either way, but you should get @jakehehrlich to confirm he is happy before committing this change.

Aug 15 2018, 11:22 AM
rupprecht updated the diff for D50589: [llvm-objcopy] Implement -G/--keep-global-symbol(s)..
  • Make test case simpler by using -elf-output-style=GNU
Aug 15 2018, 10:54 AM