- User Since
- Jun 28 2018, 11:39 AM (91 w, 5 d)
Tue, Mar 10
Thu, Mar 5
- Annotate SecName param
- Use <?> for unknown section names
Wed, Mar 4
Upload correct patch
- Update test comments
Tue, Mar 3
Is there a particular use case for this feature?
Mon, Mar 2
Feb 28 2020
Feb 21 2020
- Simplify test case
Feb 20 2020
Feb 19 2020
- Add demangling to match updated GNU objdump behavior
Feb 18 2020
- Fix printing the same line info when only the function name changes (from something to <invalid>)
- Add back blank line accidentally removed
- Add source of IR
Sure, here's an example you can play around with:
Feb 14 2020
- Revert back to UseSymbolTable = true to allow printing the name in binaries without debug info
- Use early return
- Add name mangling test coverage
Feb 13 2020
I second grimar's request for an associated test that covers this behavior, but are you saying that the issue is your modified version of sys::path::widenPath breaks some llvm-ar tests, and switching to sys::windows::UTF8ToUTF16 will keep them passing? (If so, submitting w/o an additional test sounds fine to me)
Feb 12 2020
Oh, I missed that James already posted to llvm-dev: http://lists.llvm.org/pipermail/llvm-dev/2020-February/139115.html. Please reply there instead.
Feb 11 2020
- Use StringRef::lower()
Feb 10 2020
Feb 7 2020
Feb 6 2020
It's also dependent on the build mode: https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/Support/ErrorHandling.h#L134
FYI - reverted this too since I had conflicts when also reverting D74070.
FYI, temporarily reverted this in fafddbd956dbe439787f6d717c247e648bb07ff5 since it was causing failures in Clang :: Driver/crash-report.c. I didn't see the failure on all buildbots (otherwise I could have just marked it XFAIL), though I may have been looking in the wrong place.
Feb 5 2020
Feb 4 2020
Jan 24 2020
LGTM after James' comments too. Thanks for spotting this inconsistency.
Jan 13 2020
Jan 7 2020
I left similar comments on D72357 too
I left comments on D72357 instead
Jan 2 2020
Dec 20 2019
Thanks -- the code in question seems to be heavily templated, so it may be a corner case with how those are handled. I'll revert shortly and follow up with some kind of repro, but may be delayed due to holidays.
Dec 19 2019
We're seeing a large memory increase in compilations as a result of this patch: 4.7G -> 6.0G (25%)
Dec 18 2019
Dec 17 2019
If other reviewers agree, then let's just remove the warning. I can send a patch tomorrow unless someone else wants to do that.
It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename -frounding-math to -fexperimental-rounding-math.
Looks good for D/U, but looks like --help and --version options are also supported as combined short args; do you mind adding those too while you're here?
Dec 13 2019
Dec 12 2019
Dec 11 2019
Dec 10 2019
Looks good. Thanks for adding the tests!