- User Since
- Jun 28 2018, 11:39 AM (209 w, 4 d)
Feb 10 2022
Feb 3 2022
Also seems the most reasonable IMHO. Breakages seem pretty rare, I don't know if it's worth a bunch of resources for a once-a-year bug.
That's correct -- supporting this for C++17 was the only change I care about.
- Restoring original version of the patch
- Undo clang-formatting
- Use _LIBCPP_HIDE_FROM_ABI
- Use `_LIBCPP_DEBUG_LEVEL
- Fix clang-format CI test failure
- Fix whitespace in test
Jan 31 2022
Jan 28 2022
Jan 26 2022
Jan 25 2022
Jan 24 2022
Jan 10 2022
Dec 3 2021
Nov 29 2021
Nov 11 2021
Nov 10 2021
I assume you mean something like expectedFailure, as this should unconditionally fail.
- Use better test APIs, add test back w/ a @expectedFailure
- Switch crash repro from shell -> api test
Nov 9 2021
Given that this patch has been in tree for half a year, it'd be good to get confirmation here this can be reverted given there is now a test case for causing a crash. I got an offline comment that this is OK to revert, so if nobody has objections, I'll land sometime tomorrow.
Nov 8 2021
Nov 5 2021
Nov 3 2021
This version of the patch LGTM with regards to non-determinism
FWIW, we also saw a non-determinism issue as a result of this patch in a stage2 PGO'd build of clang.
Sep 22 2021
Aug 30 2021
Aug 17 2021
FYI, I ran into this commit when pulling into our downstream fork because we had some tests comparing expected profile dump output. Usually labeling a commit as "NFC" is reserved for patches that have no externally visible effect, but this changes the output of llvm-profdata show. See https://lists.llvm.org/pipermail/llvm-dev/2021-June/151234.html for recent discussion. I can certainly see this being a bit of an edge case.
Aug 16 2021
Jul 20 2021
It'd also be helpful to include the actual command to enable it, i.e. either echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope or sudo sysctl -w kernel.yama.ptrace_scope=0 (I think both commands are equivalent)
Jul 15 2021
Jul 7 2021
Jul 2 2021
Jun 30 2021
Jun 28 2021
Seems fine to me, but can you mention it in the release notes? Even though it's primarily a testing tool, downstream users may use llvm-readobj in their testing.
Jun 23 2021
Jun 22 2021
ToDC->getDeclKindName() is "ClassTemplateSpecialization". Does that explain the unreachable error message? Maybe it needs a special case somewhere?
Understood -- this is just an initial report with some early analysis; I've occasionally gotten lucky in reporting bugs.
We're seeing a test failure (and true miscompile AFAICT) in the CVC4 library that bisects to this patch. I don't have a nice reduction, but I can describe the issue we see.
Jun 21 2021
Jun 17 2021
I don't see any messages in the reverts, but this change caused crashes both times it landed, in case that wasn't already the reason that it was reverted each time.
Jun 15 2021
Jun 14 2021
- Require tsan feature to avoid buildbot jobs that don't support -fsanitize=thread (asan, windows, 32bit, ARMv7/8)
Thanks! I'll wait for another CI notification to post before landing.
- Add requires for clang to avoid unknown gcc flag errors
The test I added is not the greatest test, but it catches the issue. Lemme know if this works.
- Add a codegen test
Jun 10 2021
This commit seems to be causing an LLDB crash. I'm still working on gathering info and reducing it, but maybe the crash reason is obvious to you given this stack trace:
Jun 8 2021
Jun 7 2021
Jun 3 2021
May 27 2021
While building this, there's a warning about an unhandled switch:
It occurs on ArchiveWriter.cpp. I implement a way to write Big Archive. If you think it is better, I can add some code to remove warning, but my goal is to implement read and write for Big Archive, so it will be corrected in a future commit / PR.
Many people build with -Werror, so it would be good to handle the case even if it's explicitly ignored, like:
May 26 2021
The issue I'm seeing seems more directly caused by SLP vectorization, as it goes away with -fno-slp-vectorize. This patch merely unblocks that bad optimization AFAICT.
FYI, I'm seeing what I think is a miscompile that bisects to this patch. Greatly simplified, the problematic snippet is this:
Thanks, this fixes the miscompile I'm seeing.
May 25 2021
We're seeing some test failures that bisected to this patch, possibly a miscompile. The test failure is in the unit test for this file: https://github.com/google/tink/blob/master/cc/subtle/aes_eax_aesni.cc. Are there already any known issues with this patch?
May 13 2021
This patch introduces an assertion error we believe may be contributing to a miscompile (along with some other recent SLP patches -- this patch fixes the reduced case in http://llvm.org/PR50323, but doesn't fix the full case it was reduced from):
May 12 2021
Updated patch LG -- the unreduced test passes now (and has no assertion errors). Thanks! (Deferring to @nikic or others for actual re-review).
May 11 2021
Temporarily reverted in fec2945998947f04d672e9c5f33b57f7177474c0 to keep trunk clean.