Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (91 w, 5 d)

Recent Activity

Tue, Mar 10

Herald added a reviewer for D75949: [llvm-objcopy] Allow empty sections in --dump-section: alexshap.
Tue, Mar 10, 10:53 AM · Restricted Project
rupprecht added a comment to D75742: [Object] Support large archive members.

Simplify size handling slightly.

I've not deleted the test yet, but I will do so in due course before this gets committed. I'd like to see if we can come up with an alternative test option first, if we can. For the record, the test passes locally with my patch, but didn't without the fix (it was how I found the bug in the first place).

Tue, Mar 10, 8:39 AM · Restricted Project
rupprecht accepted D75899: [llvm-objdump] Simplify conditional statements (isa<...>(Obj) => Obj->isSomeFile()).
Tue, Mar 10, 8:06 AM · Restricted Project

Thu, Mar 5

rupprecht accepted D75713: [llvm-objdump] -d: print `00000000 <foo>:` instead of `00000000 foo:`.
Thu, Mar 5, 4:26 PM · Restricted Project
rupprecht committed rGc140810ea158: [llvm-readobj] Include section name of notes. (authored by rupprecht).
[llvm-readobj] Include section name of notes.
Thu, Mar 5, 10:24 AM
rupprecht closed D75647: [llvm-readobj] Include section name of notes..
Thu, Mar 5, 10:24 AM · Restricted Project
rupprecht accepted D75659: [llvm-objdump] --syms: make flags closer to GNU objdump.
Thu, Mar 5, 9:19 AM · Restricted Project
rupprecht added inline comments to D75647: [llvm-readobj] Include section name of notes..
Thu, Mar 5, 9:17 AM · Restricted Project
rupprecht updated the diff for D75647: [llvm-readobj] Include section name of notes..
  • Annotate SecName param
  • Use <?> for unknown section names
Thu, Mar 5, 9:17 AM · Restricted Project

Wed, Mar 4

rupprecht updated the diff for D75647: [llvm-readobj] Include section name of notes..

Upload correct patch

Wed, Mar 4, 7:03 PM · Restricted Project
rupprecht abandoned D75658: Add test comments about missing section names and only having file/offset.

The change should be merged into D75647 because currently Name is not dumped.

Wed, Mar 4, 7:03 PM · Restricted Project
rupprecht updated the diff for D75647: [llvm-readobj] Include section name of notes..
  • Update test comments
Wed, Mar 4, 7:03 PM · Restricted Project
rupprecht created D75658: Add test comments about missing section names and only having file/offset.
Wed, Mar 4, 4:20 PM · Restricted Project
rupprecht created D75647: [llvm-readobj] Include section name of notes..
Wed, Mar 4, 2:37 PM · Restricted Project
rupprecht accepted D75592: [llvm-readelf] Make --all output order closer to GNU readelf.
Wed, Mar 4, 12:21 PM · Restricted Project

Tue, Mar 3

rupprecht added reviewers for D75498: [llvm-objdump] Add option to sort symbols during disassembly: MaskRay, rupprecht.

Is there a particular use case for this feature?

Tue, Mar 3, 2:24 PM · Restricted Project

Mon, Mar 2

rupprecht committed rGd7803c38327d: Add default case to fix -Wswitch errors (authored by rupprecht).
Add default case to fix -Wswitch errors
Mon, Mar 2, 2:57 PM

Feb 28 2020

rupprecht committed rGd3693342708a: [NFC] Fix minor python issues. (authored by rupprecht).
[NFC] Fix minor python issues.
Feb 28 2020, 2:18 PM

Feb 21 2020

rupprecht committed rG266877a2a8b2: [llvm-objdump] Print method name from debug info in disassembly output. (authored by rupprecht).
[llvm-objdump] Print method name from debug info in disassembly output.
Feb 21 2020, 3:35 PM
rupprecht closed D74507: [llvm-objdump] Print method name from debug info in disassembly output..
Feb 21 2020, 3:35 PM · Restricted Project
rupprecht updated the diff for D74507: [llvm-objdump] Print method name from debug info in disassembly output..
  • clang-format
  • Simplify test case
Feb 21 2020, 2:39 PM · Restricted Project

Feb 20 2020

rupprecht committed rG0ffa6e1a7e1c: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY (authored by rupprecht).
[lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY
Feb 20 2020, 10:11 AM
rupprecht closed D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY.
Feb 20 2020, 10:11 AM · Restricted Project

Feb 19 2020

rupprecht added inline comments to D74507: [llvm-objdump] Print method name from debug info in disassembly output..
Feb 19 2020, 4:35 PM · Restricted Project
rupprecht updated the diff for D74507: [llvm-objdump] Print method name from debug info in disassembly output..
  • Add demangling to match updated GNU objdump behavior
Feb 19 2020, 4:35 PM · Restricted Project
rupprecht created D74859: [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY.
Feb 19 2020, 12:14 PM · Restricted Project
rupprecht accepted D74826: [compiler-rt] [builtins] Fix logb / logbl tests.

Thanks!

Feb 19 2020, 9:11 AM · Restricted Project, Restricted Project
rupprecht committed rG3f7d0e7e3194: [NFC][compiler-rt][test] Fully qualify string -> std::string (authored by rupprecht).
[NFC][compiler-rt][test] Fully qualify string -> std::string
Feb 19 2020, 9:03 AM

Feb 18 2020

rupprecht updated the diff for D74507: [llvm-objdump] Print method name from debug info in disassembly output..
  • Fix printing the same line info when only the function name changes (from something to <invalid>)
Feb 18 2020, 1:58 PM · Restricted Project
rupprecht updated the diff for D74507: [llvm-objdump] Print method name from debug info in disassembly output..
  • Add back blank line accidentally removed
  • Add source of IR
Feb 18 2020, 10:44 AM · Restricted Project
rupprecht added a comment to D74507: [llvm-objdump] Print method name from debug info in disassembly output..

Sure, here's an example you can play around with:

Feb 18 2020, 10:44 AM · Restricted Project

Feb 14 2020

rupprecht updated the diff for D74507: [llvm-objdump] Print method name from debug info in disassembly output..
  • Revert back to UseSymbolTable = true to allow printing the name in binaries without debug info
Feb 14 2020, 12:30 PM · Restricted Project
rupprecht added inline comments to D74507: [llvm-objdump] Print method name from debug info in disassembly output..
Feb 14 2020, 12:21 PM · Restricted Project
rupprecht added inline comments to D74507: [llvm-objdump] Print method name from debug info in disassembly output..
Feb 14 2020, 10:48 AM · Restricted Project
rupprecht updated the diff for D74507: [llvm-objdump] Print method name from debug info in disassembly output..
  • Use early return
  • Add name mangling test coverage
Feb 14 2020, 10:48 AM · Restricted Project

Feb 13 2020

rupprecht resigned from D74477: [llvm-ar] Simplify Windows comparePaths NFCI.

In my modified version of widenPath...

I second grimar's request for an associated test that covers this behavior, but are you saying that the issue is your modified version of sys::path::widenPath breaks some llvm-ar tests, and switching to sys::windows::UTF8ToUTF16 will keep them passing? (If so, submitting w/o an additional test sounds fine to me)

Feb 13 2020, 10:24 AM · Restricted Project
rupprecht accepted D74538: [doc] Clarify responsibility for fixing experimental target problems.

Thanks James!

Feb 13 2020, 10:24 AM · Restricted Project

Feb 12 2020

rupprecht created D74507: [llvm-objdump] Print method name from debug info in disassembly output..
Feb 12 2020, 2:05 PM · Restricted Project
rupprecht added inline comments to D74391: [llvm-readelf] Match GNU readelf more more closely when dumping notes.
Feb 12 2020, 8:33 AM · Restricted Project
rupprecht committed rG60a8a504f16d: [llvm-objdump] Print file format in lowercase to match GNU output. (authored by rupprecht).
[llvm-objdump] Print file format in lowercase to match GNU output.
Feb 12 2020, 8:24 AM
rupprecht closed D74433: [llvm-objdump] Print file format in lowercase to match GNU output..
Feb 12 2020, 8:23 AM · Restricted Project, Restricted Project
rupprecht added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.

This broke tests everywhere when the experimental AVR backend is enabled, e.g. http://45.33.8.238/

Please take a look, and if it takes a while to fix please revert while you investigate.

Feb 12 2020, 7:27 AM · Restricted Project
rupprecht added a comment to D72992: [llvm-objdump] - Add column headers for relocation printing.

Oh, I missed that James already posted to llvm-dev: http://lists.llvm.org/pipermail/llvm-dev/2020-February/139115.html. Please reply there instead.

Feb 12 2020, 7:27 AM · Restricted Project

Feb 11 2020

rupprecht added inline comments to D74391: [llvm-readelf] Match GNU readelf more more closely when dumping notes.
Feb 11 2020, 2:22 PM · Restricted Project
rupprecht added a comment to D74433: [llvm-objdump] Print file format in lowercase to match GNU output..

Wait. I wonder whether we can change llvm-readobj to use lower case names as well. The following should be updated:

StringRef ELFObjectFile<ELFT>::getFileFormatName() const {
  bool IsLittleEndian = ELFT::TargetEndianness == support::little;
  switch (EF.getHeader()->e_ident[ELF::EI_CLASS]) {
  case ELF::ELFCLASS32:
    switch (EF.getHeader()->e_machine) {
    case ELF::EM_386:
      return "ELF32-i386";
    case ELF::EM_IAMCU:
      return "ELF32-iamcu";
    case ELF::EM_X86_64:
      return "ELF32-x86-64";
    case ELF::EM_ARM:

These are almost bfdnames, except that they use upper cases. I don't find a compelling argument using upper case ELF, so I vote for changing these ELF to elf. @jhenderson @grimar @sbc100 thoughts?

// lib/Object/WasmObjectFile.cpp
StringRef WasmObjectFile::getFileFormatName() const { return "WASM"; }
Feb 11 2020, 2:04 PM · Restricted Project, Restricted Project
rupprecht updated the diff for D74433: [llvm-objdump] Print file format in lowercase to match GNU output..
  • Use StringRef::lower()
Feb 11 2020, 2:04 PM · Restricted Project, Restricted Project
rupprecht created D74433: [llvm-objdump] Print file format in lowercase to match GNU output..
Feb 11 2020, 12:06 PM · Restricted Project, Restricted Project
rupprecht committed rG734f086b42c7: [NFC] Fix unused var in release builds (authored by rupprecht).
[NFC] Fix unused var in release builds
Feb 11 2020, 10:15 AM
rupprecht committed rG99451b445368: [lldb][test] Remove symlink for API tests. (authored by rupprecht).
[lldb][test] Remove symlink for API tests.
Feb 11 2020, 10:05 AM
rupprecht closed D71151: [lldb][test] Remove symlink for API tests..
Feb 11 2020, 10:05 AM · Restricted Project

Feb 10 2020

rupprecht updated the summary of D71151: [lldb][test] Remove symlink for API tests..
Feb 10 2020, 8:43 AM · Restricted Project

Feb 7 2020

rupprecht added a comment to D71151: [lldb][test] Remove symlink for API tests..

Judging by the direction of the lua patches, it doesn't look like we will have lua "dotest" tests, so I think it's fine to just put this into API directly (without the extra "test" subfolder").

Feb 7 2020, 3:56 PM · Restricted Project
rupprecht updated the summary of D71151: [lldb][test] Remove symlink for API tests..
Feb 7 2020, 3:56 PM · Restricted Project
rupprecht committed rG25675d4eaab6: [lldb][test][NFC] Create a separate LLDB_TEST_SRC var to allow moving tests. (authored by rupprecht).
[lldb][test][NFC] Create a separate LLDB_TEST_SRC var to allow moving tests.
Feb 7 2020, 3:29 PM
rupprecht closed D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests..
Feb 7 2020, 3:29 PM · Restricted Project
rupprecht added inline comments to D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests..
Feb 7 2020, 3:11 PM · Restricted Project

Feb 6 2020

rupprecht added a comment to rGfafddbd956db: Revert "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid….

It's also dependent on the build mode: https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/Support/ErrorHandling.h#L134

Feb 6 2020, 6:32 PM
rupprecht added a comment to D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics.

FYI - reverted this too since I had conflicts when also reverting D74070.

Feb 6 2020, 6:12 PM · Restricted Project
rupprecht added a comment to D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used.

FYI, temporarily reverted this in fafddbd956dbe439787f6d717c247e648bb07ff5 since it was causing failures in Clang :: Driver/crash-report.c. I didn't see the failure on all buildbots (otherwise I could have just marked it XFAIL), though I may have been looking in the wrong place.

Feb 6 2020, 6:12 PM · Restricted Project
rupprecht committed rGfafddbd956db: Revert "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid… (authored by rupprecht).
Revert "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid…
Feb 6 2020, 6:03 PM
rupprecht added a reverting change for rG5fedc2b41085: [Clang] Avoid crashing when generating crash diagnostics when '#pragma clang…: rGfafddbd956db: Revert "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid….
Feb 6 2020, 6:03 PM
rupprecht added a reverting change for rGf41ec709d9d3: [Clang][Driver] Remove -M group options before generating crash diagnostics: rGfafddbd956db: Revert "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid….
Feb 6 2020, 6:03 PM

Feb 5 2020

rupprecht committed rG9f507bfd8d47: NFC: fix unused var warnings in no-assert builds (authored by rupprecht).
NFC: fix unused var warnings in no-assert builds
Feb 5 2020, 9:28 AM

Feb 4 2020

rupprecht accepted D73987: [sanitizer] Add missing declarations for sigaltstack syscall wrappers..
Feb 4 2020, 1:09 PM · Restricted Project, Restricted Project

Jan 24 2020

rupprecht added a comment to D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number..

LGTM after James' comments too. Thanks for spotting this inconsistency.

Jan 24 2020, 1:50 PM · Restricted Project
rupprecht accepted D73318: Print discriminators when printing .debug_line in GNU style..

Is there a particular reason to restrict this to GNU style? I think it's okay to expand on the LLVM style too, but might be worth getting more opinions on it.

LLVM output style already prints the column number (file:line:column), which tells you the same thing as the discriminator, but at a higher level that is more friendly for users. I'm open to adding it, but it seems a bit redundant.

Otherwise updated.

Jan 24 2020, 1:40 PM · Restricted Project
rupprecht added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Jan 24 2020, 1:23 PM · Restricted Project

Jan 13 2020

rupprecht added a comment to D52810: [llvm-nm] Print an explicit "no symbols" message when an object file has no symbols.

I it seems that the printing of this error message only occurs with GNU nm if the object doesn't have a symbols table at all. Have no symbols in the table does not print the error message.

$ touch foo.c
$ gcc -c foo.c
$ nm foo.o  <- no error output here.
$ strip foo.o
$ nm foo.o
nm: foo.o: no symbols

Interesting (subtle) behavior...

@rupprecht Do we know what projects parse "no symbols" from llvm-nm output?

Jan 13 2020, 2:39 PM · Restricted Project

Jan 7 2020

rupprecht added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Jan 7 2020, 2:06 PM · Restricted Project
rupprecht added a comment to D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`.

I left similar comments on D72357 too

Jan 7 2020, 1:46 PM · Restricted Project
rupprecht added a comment to D72358: [llvm-objcopy][test] Fix tests when path contains "bar".

I left comments on D72357 instead

Jan 7 2020, 1:46 PM · Restricted Project
rupprecht added inline comments to D72357: Fix llvm-objcopy when directory contains "bar"..
Jan 7 2020, 12:49 PM · Restricted Project

Jan 2 2020

rupprecht added a comment to D71554: [llvm-ranlib] Handle -D and -U command line flag.

Also handle -h/-v as short options. Does the adjusted test look okay?

Jan 2 2020, 11:43 AM · Restricted Project, Restricted Project

Dec 20 2019

rupprecht committed rG02a6b0bc3b54: Temporarily revert "Reapply [LVI] Normalize pointer behavior" and "[LVI]… (authored by rupprecht).
Temporarily revert "Reapply [LVI] Normalize pointer behavior" and "[LVI]…
Dec 20 2019, 10:40 AM
rupprecht added a reverting change for rG7e18aeba5062: [LVI] Restructure caching: rG02a6b0bc3b54: Temporarily revert "Reapply [LVI] Normalize pointer behavior" and "[LVI]….
Dec 20 2019, 10:40 AM
rupprecht added a comment to D70376: [LVI] Restructure caching.

Thanks -- the code in question seems to be heavily templated, so it may be a corner case with how those are handled. I'll revert shortly and follow up with some kind of repro, but may be delayed due to holidays.

Dec 20 2019, 10:29 AM · Restricted Project

Dec 19 2019

rupprecht added a comment to D70376: [LVI] Restructure caching.

We're seeing a large memory increase in compilations as a result of this patch: 4.7G -> 6.0G (25%)

Dec 19 2019, 4:24 PM · Restricted Project

Dec 18 2019

rupprecht abandoned D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg..

Before:

% clang -frounding-math -fsyntax-only -x c /dev/null
clang-10: warning: Support for floating point control option frounding-math is incomplete and experimental [-Wexperimental-float-control]

CC1 will do rounding math things.

After

% clang -frounding-math -fsyntax-only -x c /dev/null
clang-10: warning: optimization flag '-frounding-math' is not supported [-Wignored-optimization-argument]

CC1 will not do rounding math things. -fexperimental-rounding-math if the user really wants to use the feature.

Is my understanding correct? If yes, this patch seems pretty reasonable to me, because -frounding-math is currently incomplete/unsafe.

You may consider not changing CC1 options as they are not user facing.

Dec 18 2019, 5:40 PM · Restricted Project
rupprecht committed rG553a727f5f64: [clang] Remove -Wexperimental-float-control. (authored by rupprecht).
[clang] Remove -Wexperimental-float-control.
Dec 18 2019, 5:03 PM
rupprecht closed D71671: [clang] Remove -Wexperimental-float-control..
Dec 18 2019, 5:02 PM · Restricted Project
rupprecht added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename -frounding-math to -fexperimental-rounding-math.

Alternatively we could remove the warning. I still don't see a good argument for the middle ground of having it called -frounding-math but also generate a warning.

It's definitely incomplete but the results will not be any worse than you get when -frounding-math is ignored.

My preference would be to change the text of the warning that is issued but allow -frounding-math to be enabled by this commit without requiring an additional option.

If other reviewers agree, then let's just remove the warning. I can send a patch tomorrow unless someone else wants to do that.

Dec 18 2019, 12:24 PM · Restricted Project, Restricted Project
rupprecht created D71671: [clang] Remove -Wexperimental-float-control..
Dec 18 2019, 12:14 PM · Restricted Project

Dec 17 2019

rupprecht closed D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename -frounding-math to -fexperimental-rounding-math.

Alternatively we could remove the warning. I still don't see a good argument for the middle ground of having it called -frounding-math but also generate a warning.

It's definitely incomplete but the results will not be any worse than you get when -frounding-math is ignored.

My preference would be to change the text of the warning that is issued but allow -frounding-math to be enabled by this commit without requiring an additional option.

If other reviewers agree, then let's just remove the warning. I can send a patch tomorrow unless someone else wants to do that.

Dec 17 2019, 7:42 PM · Restricted Project, Restricted Project
rupprecht added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

It seems the discussion of whether or not this is incomplete died out -- I'd prefer to assume it is incomplete if there is no consensus. Mailed D71635 to rename -frounding-math to -fexperimental-rounding-math.

Dec 17 2019, 3:58 PM · Restricted Project, Restricted Project
rupprecht created D71635: [clang] Rename -frounding-math to -fexperimental-rounding-math and add -frounding-math back as a gcc-compat arg..
Dec 17 2019, 3:58 PM · Restricted Project
rupprecht accepted D71554: [llvm-ranlib] Handle -D and -U command line flag.

Looks good for D/U, but looks like --help and --version options are also supported as combined short args; do you mind adding those too while you're here?

Dec 17 2019, 10:44 AM · Restricted Project, Restricted Project

Dec 13 2019

rupprecht added a reviewer for D71035: [llvm-objcopy][ELF] -O binary: use LMA instead of sh_offset to decide where to write section contents: evgeny777.

Is it ok for me to commit if there is still no other people interested in this patch for, say, 10 hours? 😂

I tested it on an internal objcopy -I ihex -O binary use case that motivated me to send the patch. With this patch, the section content layout is now the same.

Let's give it until after the weekend. We've been stung on a few occasions by issues with binary output, so I want to give people ample opportunity to point out anything else we've missed!

Dec 13 2019, 11:10 AM · Restricted Project

Dec 12 2019

rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 12 2019, 4:19 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 12 2019, 12:51 PM · Restricted Project, Restricted Project

Dec 11 2019

rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 11 2019, 4:57 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 11 2019, 4:55 PM · Restricted Project, Restricted Project
rupprecht added inline comments to D71319: [lldb][dotest] Improve libc++ detection.
Dec 11 2019, 2:29 PM · Restricted Project
rupprecht committed rG786b6db8e6fd: [lldb][dotest] Add `#include <algorithm>` to libc++ detection (authored by rupprecht).
[lldb][dotest] Add `#include <algorithm>` to libc++ detection
Dec 11 2019, 2:10 PM
rupprecht closed D71376: [lldb][dotest] Add `#include <algorithm>` to libc++ detection.
Dec 11 2019, 2:10 PM · Restricted Project
rupprecht created D71376: [lldb][dotest] Add `#include <algorithm>` to libc++ detection.
Dec 11 2019, 2:10 PM · Restricted Project
rupprecht committed rG34ef51b5f979: [lldb][dotest] Improve libc++ detection (authored by rupprecht).
[lldb][dotest] Improve libc++ detection
Dec 11 2019, 1:51 PM
rupprecht closed D71319: [lldb][dotest] Improve libc++ detection.
Dec 11 2019, 1:51 PM · Restricted Project

Dec 10 2019

rupprecht created D71319: [lldb][dotest] Improve libc++ detection.
Dec 10 2019, 4:55 PM · Restricted Project
rupprecht accepted D71302: [llvm-ar] Improve tool selection logic.

Looks good. Thanks for adding the tests!

Dec 10 2019, 4:08 PM · Restricted Project
rupprecht added a comment to D71302: [llvm-ar] Improve tool selection logic.

Update the heuristic to make all the following work as intended:

llvm-ar-9
llvm-ranlib.exe
arm-pokymllib32-linux-gnueabi-llvm-ar
arm-pokymllib32-linux-gnueabi-llvm-ar-9

This was manually verified, but can you add a test for it?
You could probably write a lit test like:

# RUN: mkdir -p bin
# RUN: cp llvm-ar bin/llvm-ar-9
# RUN: bin/llvm-ar-9 --help | FileCheck %s --check-prefix=AR
# RUN: cp llvm-ar bin/llvm-ranlib.exe
# RUN: bin/llvm-ranlib.exe --help | FileCheck %s --check-prefix=RANLIB
...

The path of llvm-ar is not known.

lit substitutes llvm-ar with the full path; see llvm/test/tools/llvm-ar/case-detection.test

Dec 10 2019, 3:19 PM · Restricted Project