Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (155 w, 6 h)

Recent Activity

Today

rupprecht added a comment to D101713: [OpaquePtr] Use ArgListEntry indirect types more in ISel lowering.

I don't see any messages in the reverts, but this change caused crashes both times it landed, in case that wasn't already the reason that it was reverted each time.

Thu, Jun 17, 9:26 AM · Restricted Project
rupprecht added a comment to rG7647cb14dcd0: Revert "[NFC] Use ArgListEntry indirect types more in ISel lowering".

Some detail in the commit message of a revert explaining what issues motivated the revert would be handy

Thu, Jun 17, 9:25 AM

Tue, Jun 15

rupprecht committed rG6d33362dafb6: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}. (authored by rupprecht).
[libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}.
Tue, Jun 15, 7:56 AM
rupprecht closed D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
Tue, Jun 15, 7:56 AM · Restricted Project

Mon, Jun 14

rupprecht updated the diff for D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
  • Require tsan feature to avoid buildbot jobs that don't support -fsanitize=thread (asan, windows, 32bit, ARMv7/8)
Mon, Jun 14, 7:14 PM · Restricted Project
rupprecht added a comment to D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..

Thanks! I'll wait for another CI notification to post before landing.

Mon, Jun 14, 4:13 PM · Restricted Project
rupprecht updated the diff for D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
  • Add requires for clang to avoid unknown gcc flag errors
Mon, Jun 14, 4:13 PM · Restricted Project
rupprecht added a comment to D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..

The test I added is not the greatest test, but it catches the issue. Lemme know if this works.

Mon, Jun 14, 12:36 PM · Restricted Project
rupprecht updated the diff for D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
  • Add a codegen test
Mon, Jun 14, 12:33 PM · Restricted Project

Thu, Jun 10

rupprecht added a comment to D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls.

Sure I can take a look, but I don't see the immediate problem when looking at the backtrace.

I assume it takes some time to reduce the bug in Chrome? If you could get me the dump() output for the Decls D, (Decl*)ToDC, FromRD, ToD, (Decl*)ToD->getLexicalDeclContext() and whether the left or the right side of the && is true/false then maybe it becomes more obvious what's going wrong here.

Thu, Jun 10, 4:39 PM · Restricted Project
rupprecht added a comment to D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls.

This commit seems to be causing an LLDB crash. I'm still working on gathering info and reducing it, but maybe the crash reason is obvious to you given this stack trace:

Thu, Jun 10, 12:58 PM · Restricted Project

Tue, Jun 8

rupprecht added a comment to D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..

Is it possible to write a test for that? When you say

This was caught by tsan tests after D99434 [...]

Do you mean that any Clang that includes the fix for D99434 will catch the error with the existing libc++ test suite when TSAN is enabled? If so, then I think it's fine not to add a test, since it's already tested. We could consider moving more CI configurations to Clang trunk, too.

Requesting changes until I have answers to my questions, but otherwise this LGTM.

Tue, Jun 8, 11:13 AM · Restricted Project

Mon, Jun 7

rupprecht requested review of D103846: [libcxx][atomic] Fix failure mapping in compare_exchange_{strong,weak}..
Mon, Jun 7, 2:57 PM · Restricted Project

Thu, Jun 3

rupprecht added a comment to D101191: [InstCombine] Fully disable select to and/or i1 folding.

The issue I'm seeing seems more directly caused by SLP vectorization, as it goes away with -fno-slp-vectorize. This patch merely unblocks that bad optimization AFAICT.

Filed as http://llvm.org/PR50500

We needed SLP to get to the problem state in that example, but the bug was in instcombine/instsimplify.
Should be fixed with:
7bb8bfa0622b

Thu, Jun 3, 12:37 PM · Restricted Project, Restricted Project

Thu, May 27

rupprecht added a comment to D100651: [AIX] Support of Big archive (read).

While building this, there's a warning about an unhandled switch:

It occurs on ArchiveWriter.cpp. I implement a way to write Big Archive. If you think it is better, I can add some code to remove warning, but my goal is to implement read and write for Big Archive, so it will be corrected in a future commit / PR.

Many people build with -Werror, so it would be good to handle the case even if it's explicitly ignored, like:

Thu, May 27, 5:03 PM · Restricted Project
rupprecht committed rGe41aaea26238: [NFC][libObject] clang-format Archive{.h,.cpp} (authored by rupprecht).
[NFC][libObject] clang-format Archive{.h,.cpp}
Thu, May 27, 4:51 PM

Wed, May 26

rupprecht added a comment to D101191: [InstCombine] Fully disable select to and/or i1 folding.

The issue I'm seeing seems more directly caused by SLP vectorization, as it goes away with -fno-slp-vectorize. This patch merely unblocks that bad optimization AFAICT.

Wed, May 26, 4:46 PM · Restricted Project, Restricted Project
rupprecht added a comment to D101191: [InstCombine] Fully disable select to and/or i1 folding.

The issue I'm seeing seems more directly caused by SLP vectorization, as it goes away with -fno-slp-vectorize. This patch merely unblocks that bad optimization AFAICT.

Wed, May 26, 12:13 PM · Restricted Project, Restricted Project
rupprecht added a comment to D101191: [InstCombine] Fully disable select to and/or i1 folding.

FYI, I'm seeing what I think is a miscompile that bisects to this patch. Greatly simplified, the problematic snippet is this:

Wed, May 26, 9:51 AM · Restricted Project, Restricted Project
rupprecht added a comment to D103164: [SLP]Fix vectorization of insertelements with mutiple uses..

Thanks, this fixes the miscompile I'm seeing.

Wed, May 26, 8:02 AM · Restricted Project

Tue, May 25

rupprecht added a comment to D101555: [SLP]Improve handling of compensate external uses cost..

We're seeing some test failures that bisected to this patch, possibly a miscompile. The test failure is in the unit test for this file: https://github.com/google/tink/blob/master/cc/subtle/aes_eax_aesni.cc. Are there already any known issues with this patch?

No, there are not. It would help if you could provide the reproducer and exact compile command to check if the problem exists.

Tue, May 25, 7:16 PM · Restricted Project
rupprecht added a comment to D101555: [SLP]Improve handling of compensate external uses cost..

We're seeing some test failures that bisected to this patch, possibly a miscompile. The test failure is in the unit test for this file: https://github.com/google/tink/blob/master/cc/subtle/aes_eax_aesni.cc. Are there already any known issues with this patch?

Tue, May 25, 11:05 AM · Restricted Project

May 13 2021

rupprecht added a comment to D98714: [SLP] Add insertelement instructions to vectorizable tree.

This patch introduces an assertion error we believe may be contributing to a miscompile (along with some other recent SLP patches -- this patch fixes the reduced case in http://llvm.org/PR50323, but doesn't fix the full case it was reduced from):

May 13 2021, 7:46 PM · Restricted Project

May 12 2021

rupprecht added a comment to D95543: [GVN] Clobber partially aliased loads..

Updated patch LG -- the unreduced test passes now (and has no assertion errors). Thanks! (Deferring to @nikic or others for actual re-review).

May 12 2021, 8:45 AM · Restricted Project
rupprecht committed rG1336c5ae2fea: [llvm-cov][test] Add test coverage for "gcov" implying "llvm-cov gcov"… (authored by rupprecht).
[llvm-cov][test] Add test coverage for "gcov" implying "llvm-cov gcov"…
May 12 2021, 8:25 AM
rupprecht closed D102299: [llvm-cov][test] Add test coverage for "gcov" implying "llvm-cov gcov" compatibility..
May 12 2021, 8:25 AM · Restricted Project
rupprecht added a comment to D102299: [llvm-cov][test] Add test coverage for "gcov" implying "llvm-cov gcov" compatibility..

Is it strictly ends with, or do things like file extensions, version numbers etc have an impact? See the additional test cases in https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-objcopy/tool-name.test.

May 12 2021, 8:21 AM · Restricted Project

May 11 2021

rupprecht requested review of D102299: [llvm-cov][test] Add test coverage for "gcov" implying "llvm-cov gcov" compatibility..
May 11 2021, 6:39 PM · Restricted Project
rupprecht added a comment to D95543: [GVN] Clobber partially aliased loads..

Temporarily reverted in fec2945998947f04d672e9c5f33b57f7177474c0 to keep trunk clean.

May 11 2021, 5:50 PM · Restricted Project
rupprecht added a reverting change for rG6c570442318e: [GVN] Clobber partially aliased loads.: rGfec294599894: Revert "[GVN] Clobber partially aliased loads.".
May 11 2021, 4:09 PM
rupprecht committed rGfec294599894: Revert "[GVN] Clobber partially aliased loads." (authored by rupprecht).
Revert "[GVN] Clobber partially aliased loads."
May 11 2021, 4:09 PM
rupprecht added a reverting change for D95543: [GVN] Clobber partially aliased loads.: rGfec294599894: Revert "[GVN] Clobber partially aliased loads.".
May 11 2021, 4:09 PM · Restricted Project
rupprecht added a comment to D95543: [GVN] Clobber partially aliased loads..

Thanks for taking a look. Would it be all right to revert in the meantime? (I'm assuming the fix is not trivial)

May 11 2021, 9:47 AM · Restricted Project

May 7 2021

rupprecht added a comment to D95543: [GVN] Clobber partially aliased loads..

We're seeing some issues with this patch, potentially a miscompile. When we enable assertions we get an error about widening atomic loads -- I'm not sure this is the source of the miscompile we're seeing, but it certainly looks related (I think this is causing corruption and leading to issues elsewhere).

$ cat repro.ll
; ModuleID = 'repro.ll'
source_filename = "repro.ll"
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
May 7 2021, 12:22 PM · Restricted Project

May 6 2021

rupprecht added a comment to D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming.

I think we're all good now. The template depth fix in 84f0bb619507caf7c4809400138dae1da578282a actually exposed a long standing clang bug which needed another fix in 6bbfa0fd408e81055c360c2e059554dd76fd7f09. Thanks for the quick followups!

May 6 2021, 1:46 PM · Restricted Project

May 5 2021

rupprecht accepted D101560: [llvm-objcopy][ELF] --only-keep-debug: set offset/size of segments with no sections to zero.
May 5 2021, 10:22 AM · Restricted Project

Apr 30 2021

rupprecht added a comment to D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming.

This should fix the instantiation depth issue: https://reviews.llvm.org/D101661

@rupprecht Please ping me once you've reduced to something that doesn't involve Gmock and I'll look into it.

Apr 30 2021, 4:44 PM · Restricted Project
rupprecht added a comment to D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming.

Another issue we're seeing is interactions between std::any and gmock -- I'll see if I can reduce it to something w/o the gmock dependency.

Apr 30 2021, 1:04 PM · Restricted Project

Apr 29 2021

rupprecht added a comment to D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming.

We're seeing some issues with this patch manifested as complicated tuple expressions that hit compiler limits with template depth. A bit of a synthetic example, but here it is: https://godbolt.org/z/TzvzWhYYs

Apr 29 2021, 3:47 PM · Restricted Project

Apr 28 2021

rupprecht accepted D101483: [llvm-objdump] add -v alias for --version.
Apr 28 2021, 2:48 PM · Restricted Project

Apr 27 2021

rupprecht added a comment to D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again.

Landed 44e2247dcd04f3421164b085094eb575270564ba to fix LLDB. If you decide to go in a different direction again, please adjust that fix accordingly.

Apr 27 2021, 8:12 PM · Restricted Project, Restricted Project
rupprecht committed rG44e2247dcd04: [lldb] Fix DataLayout reference after 0f1137ba79c0 (authored by rupprecht).
[lldb] Fix DataLayout reference after 0f1137ba79c0
Apr 27 2021, 8:08 PM

Apr 26 2021

rupprecht added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Here's a C++ repro

Apr 26 2021, 5:21 PM · Restricted Project, debug-info
rupprecht added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

I'm seeing a crash after the most recent time this was re-applied in 791930d74087b8ae8901172861a0fd21a211e436. The crash is when compiling https://github.com/beltoforion/muparser/blob/master/src/muParserTest.cpp, but I'm reducing it now, as the error might also depend on how we build that internally (we use at least`-g -O3`)

Apr 26 2021, 10:52 AM · Restricted Project, debug-info

Apr 23 2021

rupprecht added a comment to D101153: [lldb][NFC] Specify guidelines for API tests.

LGTM too, thanks for writing this up!

Apr 23 2021, 10:16 AM · Restricted Project

Apr 22 2021

rupprecht added a comment to D100651: [AIX] Support of Big archive (read).

Added a few others that review binutils. Thanks for the patch!

Apr 22 2021, 4:21 PM · Restricted Project
rupprecht added reviewers for D100651: [AIX] Support of Big archive (read): MaskRay, jhenderson.
Apr 22 2021, 1:30 PM · Restricted Project

Apr 21 2021

rupprecht committed rGeb5e11f460b1: [lldb] Fix RichManglingContext::FromCxxMethodName() leak (authored by rupprecht).
[lldb] Fix RichManglingContext::FromCxxMethodName() leak
Apr 21 2021, 12:35 PM
rupprecht closed D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
Apr 21 2021, 12:34 PM · Restricted Project
rupprecht added inline comments to D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
Apr 21 2021, 9:05 AM · Restricted Project
rupprecht updated the diff for D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
  • Add comments about memory management for m_ipd_buf
Apr 21 2021, 9:03 AM · Restricted Project

Apr 20 2021

rupprecht added inline comments to D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
Apr 20 2021, 6:20 PM · Restricted Project
rupprecht accepted D100843: Fix memory leak in MicrosoftDemangleNodes's Node::toString.
Apr 20 2021, 2:28 PM · Restricted Project
rupprecht added reviewers for D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak: shafik, teemperor, JDevlieghere, MaskRay.
Apr 20 2021, 1:29 PM · Restricted Project
rupprecht updated the diff for D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
  • Move comment about switch to the correct spot
Apr 20 2021, 1:29 PM · Restricted Project

Apr 19 2021

rupprecht added inline comments to D100806: [lldb] Fix one leak in reproducer.
Apr 19 2021, 6:11 PM · Restricted Project
rupprecht updated the diff for D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
  • Refactor cleanup of m_cxx_method_parser
Apr 19 2021, 4:15 PM · Restricted Project
rupprecht requested review of D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak.
Apr 19 2021, 2:36 PM · Restricted Project

Apr 15 2021

rupprecht added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

I had to revert this change because the test case broke the windows builder. What's the right way to update/mark the test case so that it is only run on appropriate architectures & operating systems?

You add the python skipIfWindows "decorator" before each test case definition. Just grep around in the test/API directory and you'll see plenty of instances of its use.

Since this is a shell (lit) test, I think you mean adding # REQUIRES: windows at the top of the test?

Apr 15 2021, 7:47 PM · Restricted Project, Restricted Project, Restricted Project
rupprecht added a comment to D100508: [lldb] Simplify output for skipped categories in dotest.py.

The motivation for this change is that sometimes engineers misidentify the output of these messages as the cause for a test failure

Apr 15 2021, 8:56 AM · Restricted Project

Apr 7 2021

rupprecht committed rGf49a4440d38a: [lldb][Editline] Fix crash when navigating through empty command history. (authored by rupprecht).
[lldb][Editline] Fix crash when navigating through empty command history.
Apr 7 2021, 10:51 AM
rupprecht closed D100048: [lldb][Editline] Fix crash when navigating through empty command history..
Apr 7 2021, 10:51 AM · Restricted Project
rupprecht requested review of D100048: [lldb][Editline] Fix crash when navigating through empty command history..
Apr 7 2021, 10:01 AM · Restricted Project

Apr 5 2021

rupprecht added a comment to D96945: [InstCombine] Add simplification of two logical and/ors.

@spatel c590a9880d7a660a1c911fce07f3d01ea18be2df fixes the unreduced test case. Thanks!

Apr 5 2021, 10:00 AM · Restricted Project

Mar 31 2021

rupprecht added a comment to D96945: [InstCombine] Add simplification of two logical and/ors.

Here's a repro for the issue we're seeing. It only seems to be happening with msan enabled, so I'm not sure if this is just an msan bug, or a general miscompile that *happens* to trigger in this test when msan is enabled.

Mar 31 2021, 7:48 PM · Restricted Project
rupprecht added a comment to D96945: [InstCombine] Add simplification of two logical and/ors.

We're still seeing some *very* strange miscompiles as a result of this patch (maybe not really this patch's fault, it could be some bad optimization that this unblocks). I'm working on a reduction right now.

Mar 31 2021, 3:20 PM · Restricted Project

Mar 29 2021

rupprecht accepted D99414: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing.

Thanks, the error message is much better now!

Mar 29 2021, 12:20 PM · Restricted Project
rupprecht resigned from D99305: [docs] Document our norms around reverts.

I don't have anything more to add now, so resigning now & leaving final thoughts and wording nits to other reviewers.

Mar 29 2021, 7:34 AM · Restricted Project

Mar 25 2021

rupprecht requested changes to D99305: [docs] Document our norms around reverts.

As a whole, I think this patch is going in the right direction -- we definitely need more concrete guidance on reverting patches.

Mar 25 2021, 11:41 AM · Restricted Project

Mar 19 2021

rupprecht accepted D98980: [CodeGen] Don't crash on for loops with cond variables and no increment.

Thanks!

Mar 19 2021, 12:45 PM · Restricted Project
rupprecht added a comment to D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable..

I tried creating an IR repro, but: running -S -emit-llvm with the old PM crashes before it can generate anything, and running with the new PM seems to generate invalid IR (branches to %for.inc, which does not exist). I suspect this is not an optimizer bug, but crashing in the optimizer because invalid IR has been fed to it.

Mar 19 2021, 11:54 AM · Restricted Project
rupprecht added a comment to D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable..

The error message I posted earlier was when using O1 + new PM, but it crashes with the old one & no optimizations:

Mar 19 2021, 11:47 AM · Restricted Project
rupprecht added a comment to D98816: PR49585: Emit the jump destination for a for loop 'continue' from within the scope of the condition variable..

We're seeing a crash in the optimizer after this patch, with the following logged in assert builds: assert.h assertion failed at llvm/include/llvm/Support/Casting.h:104 in static bool llvm::isa_impl_cl<llvm::InvokeInst, const llvm::Instruction *>::doit(const From *) [To = llvm::InvokeInst, From = const llvm::Instruction *]: Val && "isa<> used on a null pointer"

Mar 19 2021, 9:58 AM · Restricted Project

Mar 12 2021

rupprecht added a comment to D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).

Here's an IR reproducer, derived from the C++ one I provided in the reverting commit (as before, it reproduces with "clang -O2", although it doesn't with "opt -O2"):

Mar 12 2021, 3:02 PM · Restricted Project
rupprecht added a comment to D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466).

Reverted in 8d20f2c2c66eb486ff23cc3d55a53bd840b36971. Although this fixes a crash, it also introduces a compile timeout (haven't checked if it's a true infinite loop or just _really_ slow) on other code. The reproducer is in the commit message.

Mar 12 2021, 2:02 PM · Restricted Project
rupprecht added a reverting change for rGcf82700af8c6: [CodeGenPrepare] Fix isIVIncrement (PR49466): rG8d20f2c2c66e: Revert "[CodeGenPrepare] Fix isIVIncrement (PR49466)".
Mar 12 2021, 2:00 PM
rupprecht added a reverting change for D98144: [CodeGenPrepare] Fix isIVIncrement (PR49466): rG8d20f2c2c66e: Revert "[CodeGenPrepare] Fix isIVIncrement (PR49466)".
Mar 12 2021, 2:00 PM · Restricted Project
rupprecht committed rG8d20f2c2c66e: Revert "[CodeGenPrepare] Fix isIVIncrement (PR49466)" (authored by rupprecht).
Revert "[CodeGenPrepare] Fix isIVIncrement (PR49466)"
Mar 12 2021, 2:00 PM

Mar 9 2021

rupprecht committed rGb4825a6d9c18: [lldb][gui] Fix uninitialized variable in SourceFileWindowDelegate. (authored by rupprecht).
[lldb][gui] Fix uninitialized variable in SourceFileWindowDelegate.
Mar 9 2021, 10:58 AM

Feb 19 2021

rupprecht committed rG1a368ae3b78d: [CUDA] fix builtin constraints for PTX 7.2 (authored by tra).
[CUDA] fix builtin constraints for PTX 7.2
Feb 19 2021, 10:00 AM
rupprecht closed D97009: [CUDA] fix builtin constraints for PTX 7.2.
Feb 19 2021, 10:00 AM · Restricted Project
rupprecht added a comment to D97009: [CUDA] fix builtin constraints for PTX 7.2.

This fixes a build error we're seeing, so I'd like to land this in a bit if that's OK.

Feb 19 2021, 9:40 AM · Restricted Project

Feb 12 2021

rupprecht accepted D96602: [llvm-nm][test] Add additional test coverage for llvm-nm options.
Feb 12 2021, 2:18 PM · Restricted Project
rupprecht accepted D96601: [llvm-nm] Tidy up error messages.
Feb 12 2021, 2:16 PM · Restricted Project

Feb 10 2021

rupprecht accepted D96202: [lldb/test] Automatically find debug servers to test.
Feb 10 2021, 12:28 PM · Restricted Project
rupprecht added inline comments to D96202: [lldb/test] Automatically find debug servers to test.
Feb 10 2021, 9:34 AM · Restricted Project

Feb 5 2021

rupprecht added a comment to D92059: [SLP] Control maximum vectorization factor from TTI.

This commit seems to be causing some internal test failures (raising a SIGFPE). I'm working on getting more details or a reduced test case to share. Is disabling this with -mllvm -slp-max-vf=1 generally OK as a short term workaround? That seems to disable enough bits that the tests pass with that, but I'm not sure if there are other implications by setting that.

Which tests are these? Setting the option to 1 effectively disables vectorization.

Feb 5 2021, 12:43 PM · Restricted Project
rupprecht added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 5 2021, 11:55 AM · Restricted Project
rupprecht accepted D96166: [NVPTX][NewPM] Temporarily disable NVPTX passes in new PM pipeline.

Verified, thanks!

Feb 5 2021, 11:25 AM · Restricted Project
rupprecht added a comment to D96084: Revert "Revert "[libc++] [P0879] constexpr std::nth_element, and rewrite its tests."".

FWIW, I applied this patch and was able to make it pass this pretty exhaustive test:

Feb 5 2021, 9:34 AM · Restricted Project
rupprecht abandoned D96074: [test] std::nth_element regression.

Thanks a lot for finding this regression and reporting it. How did you find it?

We had 10-20 test failures internally that all bisected to this patch, and I logged the before/after of std::nth_element near the test failures. The values here are the relative ordering of the case that failed -- not the actual values, of course :)

Feb 5 2021, 8:31 AM · Restricted Project

Feb 4 2021

rupprecht added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 4 2021, 7:57 PM · Restricted Project
rupprecht added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 4 2021, 5:13 PM · Restricted Project
rupprecht added inline comments to D93881: [llvm-objcopy] preserve file ownership when overwritten by root.
Feb 4 2021, 3:52 PM · Restricted Project
rupprecht added a comment to D93557: [libc++] [P0879] constexpr std::nth_element, and rewrite its tests..

When I was reducing a test case, one thing I noticed was the problem only happens for certain pivot values, e.g.:

Feb 4 2021, 2:24 PM · Restricted Project
rupprecht added a reverting change for rG207d4be4d9d3: [libc++] [P0879] constexpr std::nth_element, and rewrite its tests.: rGb6ffece32035: Revert "[libc++] [P0879] constexpr std::nth_element, and rewrite its tests.".
Feb 4 2021, 2:04 PM
rupprecht committed rGb6ffece32035: Revert "[libc++] [P0879] constexpr std::nth_element, and rewrite its tests." (authored by rupprecht).
Revert "[libc++] [P0879] constexpr std::nth_element, and rewrite its tests."
Feb 4 2021, 2:04 PM
rupprecht added a reverting change for D93557: [libc++] [P0879] constexpr std::nth_element, and rewrite its tests.: rGb6ffece32035: Revert "[libc++] [P0879] constexpr std::nth_element, and rewrite its tests.".
Feb 4 2021, 2:04 PM · Restricted Project
rupprecht added a comment to D93557: [libc++] [P0879] constexpr std::nth_element, and rewrite its tests..

It looks like this is generating incorrect results. I uploaded D96074 which shows the failing test case.

Feb 4 2021, 1:05 PM · Restricted Project
rupprecht requested review of D96074: [test] std::nth_element regression.
Feb 4 2021, 1:02 PM · Restricted Project