Page MenuHomePhabricator

rupprecht (Jordan Rupprecht)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2018, 11:39 AM (117 w, 1 d)

Recent Activity

Yesterday

rupprecht added inline comments to D88288: [Archive] Don't throw away errors for malformed archive members.
Fri, Sep 25, 11:17 AM · Restricted Project
rupprecht accepted D88320: [Object][MachO] Refine interface of Slice.
Fri, Sep 25, 11:14 AM · Restricted Project
rupprecht accepted D88288: [Archive] Don't throw away errors for malformed archive members.

There's a build warning that needs to be fixed, but otherwise LG.

Fri, Sep 25, 11:02 AM · Restricted Project

Wed, Sep 23

rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

(Sorry about the delay.) Given the current requirements, I think this patch is fine (excellent even).

That said, I'm not sure whether the original motivation for this requirement (avoiding dns lookups) is still relevant. These days, we communicate with the local debug server via socketpair(2) sockets (which wasn't the case back then), which does not require any dns lookups and is immune to a misconfigured hosts file.

The initial dns lookup may still fail, I think? e.g. my initial version of this patch had:

if (llvm::Error error =
        listen_socket.Listen("localhost:0", backlog).ToError())

If the hosts file has a bad value for localhost, that will create a bad socket. That said, I don't know how to reproduce the original issue -- maybe it isn't an issue for some other reason.

Given that none of the things touched by this patch is extremely critical (GDBRemoteCommunication::ConnectLocally is used for reproducers and the rest is test code), maybe we could use this to test the water and see whether we can start using the network stack the way it's supposed to be used ?

Many non-reproducers tests fail w/o the change to GDBRemoteCommunication::ConnectLocally, so it's at least used outside of that.

I can go either way with using localhost or using hard-coded localhost IPs. Whichever way we go, I have a slight preference for keeping the tests and code consistent, e.g. if we use hard-coded IPs in code linked into lldb to allow people with a bad hosts file to use lldb, we should use hard-coded IPs in the tests to allow those same users to develop on lldb.

Wed, Sep 23, 4:12 PM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • Switch back to using localhost for non-socket uses
Wed, Sep 23, 4:06 PM · Restricted Project

Tue, Sep 22

rupprecht added a comment to rG8fdac7cb7abb: Revert D71539 "Recommit "[SCEV] Look through single value PHIs."".

The issue is with the new pass manager.

Tue, Sep 22, 11:04 AM

Mon, Sep 21

rupprecht committed rG307b7a1d6658: [lldb/test] Clean up version checking. (authored by rupprecht).
[lldb/test] Clean up version checking.
Mon, Sep 21, 4:20 PM
rupprecht closed D88051: [lldb/test] Clean up version checking..
Mon, Sep 21, 4:20 PM · Restricted Project
rupprecht requested review of D88051: [lldb/test] Clean up version checking..
Mon, Sep 21, 3:22 PM · Restricted Project

Thu, Sep 17

rupprecht accepted D87855: [llvm-install-name-tool] Validate -id value early.

Looks like llvm/test/tools/llvm-objcopy/MachO/install-name-tool-id.test covers this, so LGTM

Thu, Sep 17, 4:12 PM · Restricted Project

Wed, Sep 16

rupprecht committed rGdd67581407c1: [lldb/test] Enable faulthandler in dotest (authored by rupprecht).
[lldb/test] Enable faulthandler in dotest
Wed, Sep 16, 2:31 PM
rupprecht closed D87637: [lldb/test] Enable faulthandler in dotest.
Wed, Sep 16, 2:31 PM · Restricted Project
rupprecht added inline comments to D87755: Silence GCC's `-Wclass-memaccess` warnings.
Wed, Sep 16, 9:45 AM · Restricted Project

Tue, Sep 15

rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

(Sorry about the delay.) Given the current requirements, I think this patch is fine (excellent even).

That said, I'm not sure whether the original motivation for this requirement (avoiding dns lookups) is still relevant. These days, we communicate with the local debug server via socketpair(2) sockets (which wasn't the case back then), which does not require any dns lookups and is immune to a misconfigured hosts file.

The initial dns lookup may still fail, I think? e.g. my initial version of this patch had:

Tue, Sep 15, 9:30 AM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • Compare directly against the error code instead of hopping through std::make_error_code()
Tue, Sep 15, 9:19 AM · Restricted Project

Mon, Sep 14

rupprecht requested review of D87637: [lldb/test] Enable faulthandler in dotest.
Mon, Sep 14, 2:41 PM · Restricted Project

Thu, Sep 10

rupprecht committed rG6040d525507b: [NFC] Fix whitespace in lldb-vscode --help (authored by rupprecht).
[NFC] Fix whitespace in lldb-vscode --help
Thu, Sep 10, 11:00 AM

Wed, Sep 9

rupprecht committed rG52f0837778b6: [NFC] Move definition of variable now only used in debug builds (authored by rupprecht).
[NFC] Move definition of variable now only used in debug builds
Wed, Sep 9, 8:28 PM
rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

This is ready for review now after scrubbing out the "localhost" changes I had earlier.

Wed, Sep 9, 12:44 PM · Restricted Project
rupprecht updated the summary of D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
Wed, Sep 9, 12:43 PM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • clang-format
Wed, Sep 9, 12:41 PM · Restricted Project
rupprecht updated the diff for D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
  • Don't use "localhost" to avoid dns latency. Instead, prefer either 127.0.0.1 or ::1 directly.
Wed, Sep 9, 12:40 PM · Restricted Project

Tue, Sep 8

rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.

I assume you mean people *not* having a "localhost" entry?

I believe the issue was with people having a modified version that replaces localhost with some other IP address.

I didn't even realize that was an option. Yes, this patch would break that. I'll have to take another approach, then.

You might check the "git log" on any files that have "127.0.0.1" in them for details.

Do you happen to have any references (bugs etc.) for those kinds of issues?

Tue, Sep 8, 4:44 PM · Restricted Project
rupprecht added a comment to D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..

FYI: we switched away from "localhost" a long time ago due to issues with people having a "localhost" entry in their /etc/hosts folder.

Tue, Sep 8, 4:21 PM · Restricted Project
rupprecht requested review of D87333: [lldb/ipv6] Support running lldb tests in an ipv6-only environment..
Tue, Sep 8, 3:31 PM · Restricted Project

Thu, Sep 3

rupprecht added inline comments to D86360: Add new hidden option -print-changed which only reports changes to IR.
Thu, Sep 3, 10:20 AM · Restricted Project

Wed, Sep 2

rupprecht committed rGf7e04b710d2d: [lldb/Gui] zero-initialize children_stop_id (authored by rupprecht).
[lldb/Gui] zero-initialize children_stop_id
Wed, Sep 2, 8:06 PM
rupprecht closed D86825: [lldb/Gui] zero-initialize children_stop_id.
Wed, Sep 2, 8:06 PM · Restricted Project
rupprecht added a comment to D86825: [lldb/Gui] zero-initialize children_stop_id.

SG, will land momentarily with the one formatting change. Thanks!

Wed, Sep 2, 7:43 PM · Restricted Project
rupprecht added a comment to D85133: [mlir] Extend BufferAssignmentTypeConverter with result conversion callbacks.

When trying to integrate this downstream, I'm having trouble figuring out what to do with this block: https://github.com/tensorflow/mlir-hlo/blob/master/lib/Dialect/mhlo/transforms/hlo_legalize_to_lhlo.cc#L441

Wed, Sep 2, 3:46 PM · Restricted Project
rupprecht added a comment to D86290: Move all fields of '-cc1' option related classes into def file databases.

Thanks for the revert.

Wed, Sep 2, 12:11 PM · Restricted Project
rupprecht committed rGc5aa63dd560b: [lldb/Host] Add missing proc states (authored by rupprecht).
[lldb/Host] Add missing proc states
Wed, Sep 2, 8:53 AM
rupprecht closed D86818: [lldb/Host] Add missing proc states.
Wed, Sep 2, 8:52 AM · Restricted Project

Tue, Sep 1

rupprecht added a comment to D86383: [GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _).

Ok. Thanks for confirming!

Tue, Sep 1, 4:46 PM · Restricted Project
rupprecht committed rG202766947edb: [NFC] Fix unused var in release builds. (authored by rupprecht).
[NFC] Fix unused var in release builds.
Tue, Sep 1, 4:39 PM
rupprecht added a comment to D86383: [GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _).

Usually, tests that are marked # REQUIRES: asserts are done so because they make use of some code that is only available behind NDEBUG. However, in this case, it's outright crashing on certain inputs when not in debug mode. At a first glance, that doesn't seem like a correct fix to me -- after all, the crashing bug is still there -- but I'm not familiar with this code, so I'm probably missing something?

Tue, Sep 1, 3:41 PM · Restricted Project
rupprecht added a comment to D86383: [GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _).

FYI, I reverted this (and D86413 which depends on it) in 8693ddc74371dedc742c9f3d3e4eda1da72c13ea to keep the build green, as it was causing surprising crashes when running ninja check-llvm-codegen-aarch64-globalisel in release builds.

Tue, Sep 1, 1:37 PM · Restricted Project
rupprecht added a reverting change for rG8ad8f484b63c: [GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _): rG8693ddc74371: Revert "[GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _)"….
Tue, Sep 1, 1:35 PM
rupprecht committed rG8693ddc74371: Revert "[GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _)"… (authored by rupprecht).
Revert "[GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _)"…
Tue, Sep 1, 1:34 PM
rupprecht added a reverting change for D86383: [GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _): rG8693ddc74371: Revert "[GlobalISel] Fold xor(cmp(pred, _, _), 1) -> cmp(inverse(pred), _, _)"….
Tue, Sep 1, 1:34 PM · Restricted Project
rupprecht committed rGc90f15d25a17: [NFC] Fix unused var in release build (authored by rupprecht).
[NFC] Fix unused var in release build
Tue, Sep 1, 1:09 PM

Fri, Aug 28

rupprecht requested review of D86825: [lldb/Gui] zero-initialize children_stop_id.
Fri, Aug 28, 5:03 PM · Restricted Project
rupprecht accepted D86821: [lldb] Make the majority of the lit configuration values optional for the API tests.
Fri, Aug 28, 4:29 PM · Restricted Project
rupprecht accepted D86817: [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest.
Fri, Aug 28, 3:07 PM · Restricted Project
rupprecht requested review of D86818: [lldb/Host] Add missing proc states.
Fri, Aug 28, 2:52 PM · Restricted Project
rupprecht added a reverting change for rGa06c28df3e8c: Temporarily revert "[test] Exit with an error if no tests are run.": rG031554ed46c8: Reland "[test] Exit with an error if no tests are run.".
Fri, Aug 28, 2:30 PM
rupprecht committed rG031554ed46c8: Reland "[test] Exit with an error if no tests are run." (authored by rupprecht).
Reland "[test] Exit with an error if no tests are run."
Fri, Aug 28, 2:30 PM
rupprecht committed rG8bd895cac0cd: [lldb/test] Use shorter test case names in TestStandardUnwind (authored by rupprecht).
[lldb/test] Use shorter test case names in TestStandardUnwind
Fri, Aug 28, 11:51 AM
rupprecht closed D86752: [lldb/test] Use shorter test case names in TestStandardUnwind.
Fri, Aug 28, 11:50 AM · Restricted Project
rupprecht committed rGe5e05ecf65ab: [lldb/test] Use @skipIfWindows for PExpectTest (authored by rupprecht).
[lldb/test] Use @skipIfWindows for PExpectTest
Fri, Aug 28, 11:42 AM
rupprecht closed D86745: [lldb/test] Use @skipIfWindows for PExpectTest.
Fri, Aug 28, 11:41 AM · Restricted Project

Thu, Aug 27

rupprecht requested review of D86752: [lldb/test] Use shorter test case names in TestStandardUnwind.
Thu, Aug 27, 5:18 PM · Restricted Project
rupprecht requested review of D86745: [lldb/test] Use @skipIfWindows for PExpectTest.
Thu, Aug 27, 3:47 PM · Restricted Project

Aug 21 2020

rupprecht added a comment to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..

I recommitted the change in 8eded24bf46c05ffd110d521f58320cdee93866e with a fix for the issue reported by @rupprecht, which was caused due to the expander also adding existing, re-used values to InsertedValues, which we should not try to remove.

Aug 21 2020, 12:52 PM · Restricted Project

Aug 20 2020

rupprecht committed rG0de3d0c61266: [lldb][asan] Mark destructor as virtual to allow subclasses. (authored by rupprecht).
[lldb][asan] Mark destructor as virtual to allow subclasses.
Aug 20 2020, 9:25 AM

Aug 17 2020

rupprecht added a comment to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..

Here's as far as I could get with a repro. Sorry it's weird:

Aug 17 2020, 12:52 PM · Restricted Project

Aug 14 2020

rupprecht added a comment to D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding..

FYI, I reverted this in 38884641f28e373ce291dc5ea93416756216e536 due to the assertion failure being triggered. The reduction is taking longer than usual, so I wasn't able to finish it today. I should be able to have something on Monday.

Aug 14 2020, 9:06 PM · Restricted Project
rupprecht added a reverting change for rG7829c33084a7: [SCEVExpander] Add helper to clean up instrs inserted while expanding.: rG38884641f28e: Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while….
Aug 14 2020, 2:54 PM
rupprecht committed rG38884641f28e: Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while… (authored by rupprecht).
Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while…
Aug 14 2020, 2:54 PM
rupprecht added a reverting change for D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding.: rG38884641f28e: Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while….
Aug 14 2020, 2:54 PM · Restricted Project
rupprecht committed rGfd9187f74697: [NFC] Silence variables unused in release builds (authored by rupprecht).
[NFC] Silence variables unused in release builds
Aug 14 2020, 8:36 AM

Aug 13 2020

rupprecht accepted D85939: [NFC] Remove unused variables..

This is the largest fix I've seen for unused variable warnings, but nonetheless looks correct.

Aug 13 2020, 2:55 PM · Restricted Project

Aug 11 2020

rupprecht committed rG1a67522d3ef4: [NFC] Inline variable only used in debug builds (authored by rupprecht).
[NFC] Inline variable only used in debug builds
Aug 11 2020, 7:39 PM
rupprecht committed rGd2c18b598359: [NFC][llvm-objcopy] Fix redundant config checks. (authored by rupprecht).
[NFC][llvm-objcopy] Fix redundant config checks.
Aug 11 2020, 10:40 AM

Aug 10 2020

rupprecht added inline comments to D83530: [llvm-symbolizer] Switch command line parsing from llvm::cl to OptTable.
Aug 10 2020, 11:25 AM · Restricted Project
rupprecht accepted D85119: [compiler-rt][builtins] Un-xfail two tests on sparcv9.

I'm not familiar with sparc target arches, but this looks fine to me if you've been able to verify it fixes things.

Aug 10 2020, 8:35 AM · Restricted Project

Aug 5 2020

rupprecht committed rG1dbac09dd6ec: [lldb/test] Support git commit version ids for clang. (authored by rupprecht).
[lldb/test] Support git commit version ids for clang.
Aug 5 2020, 1:17 PM
rupprecht closed D85248: [test] Support git commit version ids for clang..
Aug 5 2020, 1:17 PM · Restricted Project
rupprecht committed rGfcb0d8163a4f: [lldb/test] Use realpath consistently for test root file paths. (authored by rupprecht).
[lldb/test] Use realpath consistently for test root file paths.
Aug 5 2020, 11:36 AM
rupprecht closed D85258: [test] Use realpath consistently for test root file paths..
Aug 5 2020, 11:36 AM · Restricted Project
rupprecht added a comment to D75069: [LoopVectorizer] Inloop vector reductions.

FYI, reverted in 3c39db0c4452218c967a8ac3ad48144fbf1159ff. See http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/19573/steps/build%20stage%201/logs/stdio for a breakage that's shown up in buildbots.

Aug 5 2020, 10:48 AM · Restricted Project
rupprecht added a reverting change for rGe9761688e41c: [LoopVectorizer] Inloop vector reductions: rG3c39db0c4452: Revert "[LoopVectorizer] Inloop vector reductions".
Aug 5 2020, 10:27 AM
rupprecht committed rG3c39db0c4452: Revert "[LoopVectorizer] Inloop vector reductions" (authored by rupprecht).
Revert "[LoopVectorizer] Inloop vector reductions"
Aug 5 2020, 10:27 AM
rupprecht added a reverting change for D75069: [LoopVectorizer] Inloop vector reductions: rG3c39db0c4452: Revert "[LoopVectorizer] Inloop vector reductions".
Aug 5 2020, 10:27 AM · Restricted Project
rupprecht committed rGf425c0442c3e: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration (authored by rupprecht).
[lldb/test] Replace LLDB_TEST_SRC env variable with configuration
Aug 5 2020, 10:20 AM
rupprecht closed D85322: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration.
Aug 5 2020, 10:20 AM · Restricted Project
rupprecht added inline comments to D85258: [test] Use realpath consistently for test root file paths..
Aug 5 2020, 8:54 AM · Restricted Project
rupprecht requested review of D85322: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration.
Aug 5 2020, 8:51 AM · Restricted Project

Aug 4 2020

rupprecht requested review of D85258: [test] Use realpath consistently for test root file paths..
Aug 4 2020, 4:43 PM · Restricted Project
rupprecht requested review of D85248: [test] Support git commit version ids for clang..
Aug 4 2020, 2:14 PM · Restricted Project
rupprecht committed rG31ec6e969d60: [test] Fix another realpath->abspath. (authored by rupprecht).
[test] Fix another realpath->abspath.
Aug 4 2020, 11:07 AM
rupprecht added inline comments to D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects..
Aug 4 2020, 10:50 AM · Restricted Project
rupprecht added inline comments to D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects..
Aug 4 2020, 10:08 AM · Restricted Project
rupprecht committed rG817b3a6fe3a4: [test] Use abspath instead of realpath sometimes (authored by rupprecht).
[test] Use abspath instead of realpath sometimes
Aug 4 2020, 8:22 AM
rupprecht closed D85175: [test] Use abspath instead of realpath sometimes.
Aug 4 2020, 8:22 AM · Restricted Project
rupprecht added inline comments to D84043: [AArch64][SVE] Fix CFA calculation in presence of SVE objects..
Aug 4 2020, 8:20 AM · Restricted Project

Aug 3 2020

rupprecht added a reverting change for rGadb5c23f8c0d: [test] Exit with an error if no tests are run.: rGa06c28df3e8c: Temporarily revert "[test] Exit with an error if no tests are run.".
Aug 3 2020, 6:39 PM
rupprecht committed rGa06c28df3e8c: Temporarily revert "[test] Exit with an error if no tests are run." (authored by rupprecht).
Temporarily revert "[test] Exit with an error if no tests are run."
Aug 3 2020, 6:39 PM
rupprecht added a reverting change for D85169: [test] Exit with an error if no tests are run.: rGa06c28df3e8c: Temporarily revert "[test] Exit with an error if no tests are run.".
Aug 3 2020, 6:39 PM · Restricted Project
rupprecht requested review of D85175: [test] Use abspath instead of realpath sometimes.
Aug 3 2020, 5:41 PM · Restricted Project
rupprecht committed rGadb5c23f8c0d: [test] Exit with an error if no tests are run. (authored by rupprecht).
[test] Exit with an error if no tests are run.
Aug 3 2020, 4:32 PM
rupprecht closed D85169: [test] Exit with an error if no tests are run..
Aug 3 2020, 4:32 PM · Restricted Project
rupprecht added a comment to D85169: [test] Exit with an error if no tests are run..

Thanks for the quick review!

Aug 3 2020, 4:27 PM · Restricted Project
rupprecht updated the diff for D85169: [test] Exit with an error if no tests are run..
  • Use logging.error
  • Remove trailing stop
  • Edit message to indicate that matching tests weren't found (user error)
Aug 3 2020, 4:16 PM · Restricted Project
rupprecht requested review of D85169: [test] Exit with an error if no tests are run..
Aug 3 2020, 3:46 PM · Restricted Project
rupprecht committed rGaf3ec731d54d: [NFC][ARM] Silence unused variable in release builds (authored by rupprecht).
[NFC][ARM] Silence unused variable in release builds
Aug 3 2020, 3:22 PM

Jul 30 2020

rupprecht committed rGbe198e03ebba: [lldb][test] Move registers-target-xml-reading target to the correct test… (authored by rupprecht).
[lldb][test] Move registers-target-xml-reading target to the correct test…
Jul 30 2020, 10:31 AM
rupprecht committed rG09cb6f233d3d: [lldb][NFC][test] Fix comment referring to FileCheck instead of yaml2obj (authored by rupprecht).
[lldb][NFC][test] Fix comment referring to FileCheck instead of yaml2obj
Jul 30 2020, 9:49 AM

Jul 21 2020

rupprecht added inline comments to D82927: Intergerate Loop Peeling into Loop Fusion.
Jul 21 2020, 9:33 AM · Restricted Project
rupprecht committed rG1ee1da1ea572: [NFC] Fix unused var warning (authored by rupprecht).
[NFC] Fix unused var warning
Jul 21 2020, 9:28 AM