Page MenuHomePhabricator

gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (301 w, 5 d)

Recent Activity

Wed, Mar 15

gchatelet accepted D146112: [libc][docs] Move the link to "Compiler Support" under "Status"..
Wed, Mar 15, 2:57 AM · Restricted Project, Restricted Project

Tue, Mar 14

gchatelet committed rGa49118a3f452: [reland][libc][NFC] Move memcmp implementations in subfolders (authored by gchatelet).
[reland][libc][NFC] Move memcmp implementations in subfolders
Tue, Mar 14, 6:04 AM · Restricted Project, Restricted Project
gchatelet added a reverting change for rG7f20e2a8d2ba: [libc][NFC] Move memcmp implementations in subfolders: rG00c52331395e: Revert "[libc][NFC] Move memcmp implementations in subfolders".
Tue, Mar 14, 6:01 AM · Restricted Project, Restricted Project
gchatelet committed rG00c52331395e: Revert "[libc][NFC] Move memcmp implementations in subfolders" (authored by gchatelet).
Revert "[libc][NFC] Move memcmp implementations in subfolders"
Tue, Mar 14, 6:01 AM · Restricted Project, Restricted Project
gchatelet added a comment to D145685: [mlir][Affine] Add helper functions to allow reordering affine.apply operands and decompose the ops into smaller components.

This patch broke the buildkite bot
https://buildkite.com/llvm-project/upstream-bazel/builds/56515#0186dfcd-e044-4adf-992d-b51e688544dd

Tue, Mar 14, 5:50 AM · Restricted Project, Restricted Project
gchatelet committed rG7f20e2a8d2ba: [libc][NFC] Move memcmp implementations in subfolders (authored by gchatelet).
[libc][NFC] Move memcmp implementations in subfolders
Tue, Mar 14, 5:47 AM · Restricted Project, Restricted Project

Fri, Mar 10

gchatelet accepted D145763: llvm-exegesis: Only run X86 tests on X86 hosts.

Thx for the heads up / fix @tstellar !

Fri, Mar 10, 4:11 AM · Restricted Project, Restricted Project

Wed, Mar 8

gchatelet committed rG8de802e221b3: [bazel] Add layering-check (authored by gchatelet).
[bazel] Add layering-check
Wed, Mar 8, 5:24 AM · Restricted Project
gchatelet closed D143678: [bazel] Add layering-check.
Wed, Mar 8, 5:24 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D143678: [bazel] Add layering-check.
  • Disable layering check when using mpfr_system
  • Remove layering_check on MPRFUtils instead
Wed, Mar 8, 5:00 AM · Restricted Project, Restricted Project

Tue, Mar 7

gchatelet updated the diff for D143678: [bazel] Add layering-check.
  • Disable layering check when using mpfr_system
Tue, Mar 7, 5:49 AM · Restricted Project, Restricted Project
gchatelet reopened D143678: [bazel] Add layering-check.
Tue, Mar 7, 5:48 AM · Restricted Project, Restricted Project
gchatelet added a reverting change for rG5916decfc2ba: [bazel] Add layering-check: rG78373498cd6e: Revert D143678 "[bazel] Add layering-check".
Tue, Mar 7, 5:28 AM · Restricted Project
gchatelet committed rG78373498cd6e: Revert D143678 "[bazel] Add layering-check" (authored by gchatelet).
Revert D143678 "[bazel] Add layering-check"
Tue, Mar 7, 5:28 AM · Restricted Project
gchatelet added a reverting change for D143678: [bazel] Add layering-check: rG78373498cd6e: Revert D143678 "[bazel] Add layering-check".
Tue, Mar 7, 5:28 AM · Restricted Project, Restricted Project
gchatelet committed rG5916decfc2ba: [bazel] Add layering-check (authored by gchatelet).
[bazel] Add layering-check
Tue, Mar 7, 5:25 AM · Restricted Project
gchatelet closed D143678: [bazel] Add layering-check.
Tue, Mar 7, 5:24 AM · Restricted Project, Restricted Project
gchatelet committed rG65de8c8677e4: [libc][bazel] Fix missing dependency for math tests (authored by gchatelet).
[libc][bazel] Fix missing dependency for math tests
Tue, Mar 7, 5:22 AM · Restricted Project

Mon, Mar 6

gchatelet committed rGbff3682e9ede: Fix SafeIntIterator reference type (authored by gchatelet).
Fix SafeIntIterator reference type
Mon, Mar 6, 7:29 AM · Restricted Project, Restricted Project
gchatelet closed D145373: Fix SafeIntIterator reference type.
Mon, Mar 6, 7:28 AM · Restricted Project, Restricted Project
gchatelet added a comment to D145373: Fix SafeIntIterator reference type.

Thx for the review.

Mon, Mar 6, 7:26 AM · Restricted Project, Restricted Project
gchatelet retitled D145373: Fix SafeIntIterator reference type from Fix #61122 to Fix SafeIntIterator reference type.
Mon, Mar 6, 7:26 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D145373: Fix SafeIntIterator reference type.

rebase, rename test and retitle commit

Mon, Mar 6, 7:25 AM · Restricted Project, Restricted Project
gchatelet added a reviewer for D145373: Fix SafeIntIterator reference type: foad.
Mon, Mar 6, 6:17 AM · Restricted Project, Restricted Project
gchatelet requested review of D145373: Fix SafeIntIterator reference type.
Mon, Mar 6, 6:16 AM · Restricted Project, Restricted Project

Fri, Mar 3

gchatelet requested review of D145235: [libc] Add memcpy with software prefetcher.
Fri, Mar 3, 5:28 AM · Restricted Project, Restricted Project

Feb 15 2023

gchatelet added a comment to rG7a282bd2aaa5: [bazel] Fix missing dependency in clang-tools-extra/clang-tidy:llvmlibc.

My bad, thanks!

Feb 15 2023, 10:12 PM · Restricted Project
gchatelet committed rGb67ee5d50562: [reland][libc] Separate memcpy implementations per arch (authored by gchatelet).
[reland][libc] Separate memcpy implementations per arch
Feb 15 2023, 6:40 AM · Restricted Project, Restricted Project
gchatelet committed rG7a282bd2aaa5: [bazel] Fix missing dependency in clang-tools-extra/clang-tidy:llvmlibc (authored by gchatelet).
[bazel] Fix missing dependency in clang-tools-extra/clang-tidy:llvmlibc
Feb 15 2023, 5:55 AM · Restricted Project
gchatelet committed rG15b90805bcb8: Revert "[libc] Separate memcpy implementations per arch" (authored by gchatelet).
Revert "[libc] Separate memcpy implementations per arch"
Feb 15 2023, 5:30 AM · Restricted Project, Restricted Project
gchatelet added a reverting change for rG97e441dc6cfa: [libc] Separate memcpy implementations per arch: rG15b90805bcb8: Revert "[libc] Separate memcpy implementations per arch".
Feb 15 2023, 5:30 AM · Restricted Project, Restricted Project
gchatelet committed rG97e441dc6cfa: [libc] Separate memcpy implementations per arch (authored by gchatelet).
[libc] Separate memcpy implementations per arch
Feb 15 2023, 5:22 AM · Restricted Project, Restricted Project
gchatelet committed rGc3228714cc0e: [libc][NFC] Make tuning macros start with LIBC_COPT_ (authored by gchatelet).
[libc][NFC] Make tuning macros start with LIBC_COPT_
Feb 15 2023, 2:00 AM · Restricted Project, Restricted Project
gchatelet closed D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.
Feb 15 2023, 2:00 AM · Restricted Project, Restricted Project

Feb 14 2023

gchatelet added a reverting change for rG26541d417634: [libc] Separate memcpy implementations per arch: rG9a8d64a66a15: Revert "[libc] Separate memcpy implementations per arch".
Feb 14 2023, 8:15 AM · Restricted Project, Restricted Project
gchatelet committed rG9a8d64a66a15: Revert "[libc] Separate memcpy implementations per arch" (authored by gchatelet).
Revert "[libc] Separate memcpy implementations per arch"
Feb 14 2023, 8:15 AM · Restricted Project, Restricted Project
gchatelet committed rG26541d417634: [libc] Separate memcpy implementations per arch (authored by gchatelet).
[libc] Separate memcpy implementations per arch
Feb 14 2023, 7:58 AM · Restricted Project, Restricted Project
gchatelet committed rG8981f20ae9c3: [libc] refactor logic around embedded memcpy (authored by gchatelet).
[libc] refactor logic around embedded memcpy
Feb 14 2023, 7:58 AM · Restricted Project, Restricted Project
gchatelet committed rGddfabefe1be1: [libc] Conform memcpy tuning macro to the new naming scheme (authored by gchatelet).
[libc] Conform memcpy tuning macro to the new naming scheme
Feb 14 2023, 5:44 AM · Restricted Project, Restricted Project
gchatelet added a comment to D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.

The flags for my pieces don't have cmake options because I didn't know how we were going to organize them at first.

For printf:
Disable float, disable index mode, and disable write int are all independent flags. They can have simple options and I think they should default to off, off, and on respectively (so that we only disable write int).
Index arr len is takes an int, but it's already got a default in printf_config.h so its cmake options should probably default to off.
Conv atlas is intended to let users completely replace the conversion logic, since it defines where the header file that includes all the headers that define the converters is. I'd say it probably shouldn't have a cmake option at all, since the cmake targets that define the header libraries for the conversions would also need to be changed. Basically, it's for people who are using their own build system and want to use their own conversions.

For scanf:
Disable float and index mode are the same as in printf.

For strtofloat:
Scoping those options seems like a good idea. They can similarly have simple options, although it might be good to have a warning pop up when disabling simple decimal conversion since that means there's no guarantee of correctness.

Feb 14 2023, 4:20 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.
  • rename LLVM_LIBC_IMPLEMENTATION_DEFINED_TEST_BEHAVIOR as well
  • Scope str_to_float macros and add a warning
Feb 14 2023, 4:19 AM · Restricted Project, Restricted Project
gchatelet added a comment to D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.

@phosek @mcgrathr this patch would also rename LLVM_LIBC_TEST_USE_FUCHSIA to LIBC_COPT_TEST_USE_FUCHSIA to conform to our guidelines.
Let me know if that's an issue for you.

Feb 14 2023, 4:07 AM · Restricted Project, Restricted Project
gchatelet added a reviewer for D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_: phosek.
Feb 14 2023, 4:05 AM · Restricted Project, Restricted Project

Feb 13 2023

gchatelet added inline comments to D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.
Feb 13 2023, 7:40 AM · Restricted Project, Restricted Project
gchatelet added a comment to D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.

@michaelrj it seems that the following definitions are currently not exposed to the build system.
LIBC_COPT_PRINTF_CONV_ATLAS
LIBC_COPT_PRINTF_DISABLE_FLOAT
LIBC_COPT_PRINTF_DISABLE_INDEX_MODE
LIBC_COPT_PRINTF_DISABLE_WRITE_INT
LIBC_COPT_PRINTF_INDEX_ARR_LEN
LIBC_COPT_PRINTF_CONV_ATLAS
LIBC_COPT_SCANF_DISABLE_FLOAT
LIBC_COPT_SCANF_DISABLE_INDEX_MODE
LIBC_COPT_DISABLE_CLINGER_FAST_PATH
LIBC_COPT_DISABLE_EISEL_LEMIRE
LIBC_COPT_DISABLE_SIMPLE_DECIMAL_CONVERSION

Feb 13 2023, 7:37 AM · Restricted Project, Restricted Project
gchatelet added a reviewer for D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_: mcgrathr.
Feb 13 2023, 7:35 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.
  • Keep CMake option as is, only change preprocessor
Feb 13 2023, 7:25 AM · Restricted Project, Restricted Project
gchatelet committed rG676bca0b6f0d: [libc][NFC] Fix typo in header guards (authored by gchatelet).
[libc][NFC] Fix typo in header guards
Feb 13 2023, 7:23 AM · Restricted Project, Restricted Project
gchatelet requested review of D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_.
Feb 13 2023, 7:17 AM · Restricted Project, Restricted Project
gchatelet requested review of D143911: [libc][doc] Update macros documentation.
Feb 13 2023, 6:40 AM · Restricted Project, Restricted Project
gchatelet committed rG30f515a9101d: [libc] Fix LIBC_LOOP_NOUNROLL being a noop (authored by gchatelet).
[libc] Fix LIBC_LOOP_NOUNROLL being a noop
Feb 13 2023, 3:15 AM · Restricted Project, Restricted Project
gchatelet added a comment to D143678: [bazel] Add layering-check.

Looks like there's still an issue with mpfr.

Feb 13 2023, 1:37 AM · Restricted Project, Restricted Project
gchatelet added a comment to D143678: [bazel] Add layering-check.

One advantage to adding at the package level is that it will also apply for downstream projects using LLVM. So if someone is building via their own project and editing an LLVM submodule or something then they would still have layering enforced. Just a thought

Feb 13 2023, 1:34 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D143678: [bazel] Add layering-check.
  • Fix typo
Feb 13 2023, 1:23 AM · Restricted Project, Restricted Project
gchatelet added a reviewer for D143678: [bazel] Add layering-check: Restricted Project.
Feb 13 2023, 1:21 AM · Restricted Project, Restricted Project
gchatelet added a comment to D143805: [libc] Update macros/optimization.h build dependency for CMake and Bazel..

Thx a lot Tue, looks like I messed up with the FMA flags sorry.

Feb 13 2023, 1:19 AM · Restricted Project, Restricted Project

Feb 10 2023

gchatelet committed rG737e1cd161f3: [libc] Move likely/unlikely to the optimization header (authored by gchatelet).
[libc] Move likely/unlikely to the optimization header
Feb 10 2023, 7:32 AM · Restricted Project, Restricted Project
gchatelet committed rG4a96893fc5ca: [libc] Fix exp2f and prevent misuse of likely/unlikely (authored by gchatelet).
[libc] Fix exp2f and prevent misuse of likely/unlikely
Feb 10 2023, 6:02 AM · Restricted Project, Restricted Project
gchatelet closed D143732: [libc] Fix exp2f and prevent misuse of likely/unlikely.
Feb 10 2023, 6:02 AM · Restricted Project, Restricted Project
gchatelet added a comment to D143732: [libc] Fix exp2f and prevent misuse of likely/unlikely.

Done

Feb 10 2023, 6:00 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D143732: [libc] Fix exp2f and prevent misuse of likely/unlikely.
  • address comments
Feb 10 2023, 6:00 AM · Restricted Project, Restricted Project
gchatelet requested review of D143732: [libc] Fix exp2f and prevent misuse of likely/unlikely.
Feb 10 2023, 5:50 AM · Restricted Project, Restricted Project
gchatelet retitled D143678: [bazel] Add layering-check from [bazel] Add layering-check on CI to [bazel] Add layering-check.
Feb 10 2023, 3:48 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D143678: [bazel] Add layering-check.

rebase and move layering check as a global option

Feb 10 2023, 3:48 AM · Restricted Project, Restricted Project
gchatelet reclaimed D143678: [bazel] Add layering-check.

I just looked at the premerge checks and I can see how this will be hard to fix globally (if at all possible).
I'll use the package feature instead.

IMO we should try to clean those up, and then once we do so, remove the package-level annotations and have the feature globally enabled -- but as build --features=layering_check, not build:ci --features=layering_check.

If there are any that are really problematic, we can add a feature to disable layering check for that rule (or package)

Feb 10 2023, 3:44 AM · Restricted Project, Restricted Project
gchatelet committed rG1842b5885baa: [bazel] Fix build and make all target respect layering_check (authored by gchatelet).
[bazel] Fix build and make all target respect layering_check
Feb 10 2023, 3:41 AM · Restricted Project

Feb 9 2023

gchatelet abandoned D143678: [bazel] Add layering-check.

I just looked at the premerge checks and I can see how this will be hard to fix globally (if at all possible).
I'll use the package feature instead.

Feb 9 2023, 2:07 PM · Restricted Project, Restricted Project
gchatelet updated subscribers of D143678: [bazel] Add layering-check.

layering_check has already been turned on at the package level for the packages that are layering clean (e.g. https://github.com/llvm/llvm-project/blob/main/utils/bazel/llvm-project-overlay/llvm/BUILD.bazel#L15). You could add more

Feb 9 2023, 2:05 PM · Restricted Project, Restricted Project
gchatelet accepted D143627: [libc] Run libc tests unconditionally, even if there are no source changes..
Feb 9 2023, 1:46 PM · Restricted Project, Restricted Project
gchatelet requested review of D143678: [bazel] Add layering-check.
Feb 9 2023, 1:40 PM · Restricted Project, Restricted Project
gchatelet committed rGb7a2ff296352: [libc] Fix layering for bazel (authored by gchatelet).
[libc] Fix layering for bazel
Feb 9 2023, 1:36 PM · Restricted Project
gchatelet committed rG6fb61ed549ee: [libc] Introduce a config macro file (authored by gchatelet).
[libc] Introduce a config macro file
Feb 9 2023, 6:00 AM · Restricted Project, Restricted Project
gchatelet committed rG406b3f2cbbee: [libc] Add an optimization macro header (authored by gchatelet).
[libc] Add an optimization macro header
Feb 9 2023, 5:36 AM · Restricted Project, Restricted Project
gchatelet committed rGe2f8c5566426: [libc][NFC] separate macros in several targets (authored by gchatelet).
[libc][NFC] separate macros in several targets
Feb 9 2023, 2:51 AM · Restricted Project, Restricted Project
gchatelet committed rGe11d9110399d: [libc] Add documentation for the macros folder (authored by gchatelet).
[libc] Add documentation for the macros folder
Feb 9 2023, 1:35 AM · Restricted Project, Restricted Project
gchatelet committed rG46aa02cb8439: [libc][NFC] Format bazel file (authored by gchatelet).
[libc][NFC] Format bazel file
Feb 9 2023, 1:34 AM · Restricted Project
gchatelet committed rGa6db871e85f0: [libc][NFC] Move cpu_features.h to properties subfolder (authored by gchatelet).
[libc][NFC] Move cpu_features.h to properties subfolder
Feb 9 2023, 1:31 AM · Restricted Project, Restricted Project
gchatelet committed rGc53e15e841b8: [libc][NFC] Move compiler_features.h to properties subfolder (authored by gchatelet).
[libc][NFC] Move compiler_features.h to properties subfolder
Feb 9 2023, 1:27 AM · Restricted Project, Restricted Project
gchatelet committed rGf100ec2517e9: [libc][NFC] Move architectures.h to properties subfolder (authored by gchatelet).
[libc][NFC] Move architectures.h to properties subfolder
Feb 9 2023, 1:21 AM · Restricted Project, Restricted Project
gchatelet added inline comments to D143627: [libc] Run libc tests unconditionally, even if there are no source changes..
Feb 9 2023, 12:57 AM · Restricted Project, Restricted Project

Feb 8 2023

gchatelet committed rG6064742b528a: [libc][bazel] Add missing libc_root dep (authored by gchatelet).
[libc][bazel] Add missing libc_root dep
Feb 8 2023, 6:24 AM · Restricted Project

Feb 7 2023

gchatelet committed rG9fdff5415c66: [libc] Fix sanitizer (authored by gchatelet).
[libc] Fix sanitizer
Feb 7 2023, 12:57 PM · Restricted Project, Restricted Project
gchatelet committed rGa2569a76e034: [libc][NFC] Rename macros (authored by gchatelet).
[libc][NFC] Rename macros
Feb 7 2023, 12:50 PM · Restricted Project, Restricted Project
gchatelet committed rGe2263f1459d2: [libc][NFC] Move code to sanitizer.h + more consistent naming (authored by gchatelet).
[libc][NFC] Move code to sanitizer.h + more consistent naming
Feb 7 2023, 12:50 PM · Restricted Project, Restricted Project
gchatelet added a comment to D143386: Add function pointer alignment to DataLayout.

Almost all the specifications you're specifying are wrong. Very few targets should be using "i". Off the top of my head, 32-bit ARM, MIPS targets with MicroMIPS, and certain PowerPC targets should, but most common targets shouldn't. ("i" means that either the target mangles the bottom bits of function pointers, or function pointers don't point directly at code.)

Ok so I misunderstood the meaning of "i" then.

Feb 7 2023, 8:21 AM · Restricted Project, Restricted Project
gchatelet committed rGaa661a129b9d: Fix broken Bazel targets (authored by gchatelet).
Fix broken Bazel targets
Feb 7 2023, 6:01 AM · Restricted Project
gchatelet committed rG29f8e076bd42: [libc][NFC] Move attributes from common to macros folder (authored by gchatelet).
[libc][NFC] Move attributes from common to macros folder
Feb 7 2023, 5:17 AM · Restricted Project, Restricted Project
gchatelet committed rG8f3c2c5ee645: [libc][NFC] Sort dependencies (authored by gchatelet).
[libc][NFC] Sort dependencies
Feb 7 2023, 5:17 AM · Restricted Project, Restricted Project
gchatelet committed rG600904907667: [libc][NFC] Use LIBC_TARGET_IS_GPU instead of defining PACKAGE_FOR_GPU (authored by gchatelet).
[libc][NFC] Use LIBC_TARGET_IS_GPU instead of defining PACKAGE_FOR_GPU
Feb 7 2023, 5:17 AM · Restricted Project, Restricted Project
gchatelet committed rGf6d9972291a0: [libc][NFC] Rename compiler_feature macros (authored by gchatelet).
[libc][NFC] Rename compiler_feature macros
Feb 7 2023, 3:14 AM · Restricted Project, Restricted Project
gchatelet committed rG6473009502e2: [libc][NFC] Move sanitizer to macros folder (authored by gchatelet).
[libc][NFC] Move sanitizer to macros folder
Feb 7 2023, 3:14 AM · Restricted Project, Restricted Project
gchatelet committed rG1ae4bd83ce2a: [libc][NFC] Move compiler_features to macros folder (authored by gchatelet).
[libc][NFC] Move compiler_features to macros folder
Feb 7 2023, 2:40 AM · Restricted Project, Restricted Project
gchatelet committed rGced5a382a8eb: [libc][NFC] Move cpu_features to macros folder (authored by gchatelet).
[libc][NFC] Move cpu_features to macros folder
Feb 7 2023, 2:32 AM · Restricted Project, Restricted Project
gchatelet committed rG1637351fd125: [libc][NFC] Rename architecture macros and move to macros folder (authored by gchatelet).
[libc][NFC] Rename architecture macros and move to macros folder
Feb 7 2023, 2:21 AM · Restricted Project, Restricted Project
gchatelet committed rG83e98c85564a: [libc][doc] Update compiler (authored by gchatelet).
[libc][doc] Update compiler
Feb 7 2023, 1:33 AM · Restricted Project, Restricted Project
gchatelet closed D143389: [libc][doc] Update compiler.
Feb 7 2023, 1:32 AM · Restricted Project, Restricted Project
gchatelet committed rGc1832e903e00: [libc][doc] Add macros guidelines (authored by gchatelet).
[libc][doc] Add macros guidelines
Feb 7 2023, 1:30 AM · Restricted Project, Restricted Project
gchatelet closed D143413: [libc][doc] Add macros guidelines.
Feb 7 2023, 1:30 AM · Restricted Project, Restricted Project

Feb 6 2023

gchatelet requested review of D143413: [libc][doc] Add macros guidelines.
Feb 6 2023, 8:48 AM · Restricted Project, Restricted Project
gchatelet requested review of D143389: [libc][doc] Update compiler.
Feb 6 2023, 5:03 AM · Restricted Project, Restricted Project