User Details
User Details
- User Since
- Jun 7 2017, 7:28 AM (71 w, 6 d)
Today
Today
gchatelet updated the diff for D53488: [clang-tidy] Catching narrowing from double to float..
- Addressing comments
Tue, Oct 23, 4:43 AM · Restricted Project
Yesterday
Yesterday
[llvm-exegesis] Crash when assembling invalid Operand
gchatelet committed rL344906: [llvm-exegesis] Mark x86 segment register instructions as unsupported..
[llvm-exegesis] Mark x86 segment register instructions as unsupported.
gchatelet committed rL344905: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
[llvm-exegesis] Reject x86 instructions that use non uniform memory accesses
gchatelet updated the diff for D53438: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
- Adding missing comment
gchatelet updated the diff for D53438: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
- Addressing comments
Mon, Oct 22, 2:20 AM · Restricted Project
Nice ! Thx a lot :)
Fri, Oct 19
Fri, Oct 19
Thu, Oct 18
Thu, Oct 18
[llvm-exegesis] Fix off by one error
Wed, Oct 17
Wed, Oct 17
gchatelet added inline comments to D53371: [llvm-exegesis] Allow measuring several instructions in a single run..
gchatelet added a comment to D53371: [llvm-exegesis] Allow measuring several instructions in a single run..
gchatelet committed rL344692: Fix uninitialized variable.
Fix uninitialized variable
BuildBot fix, compiler complains about array decay to pointer
gchatelet committed rL344689: [llvm-exegeis] Computing Latency configuration upfront so we can generate many….
[llvm-exegeis] Computing Latency configuration upfront so we can generate many…
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
- Addressing comments
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
- Fix variable name
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
- Revert files from other commit to previous state
Tue, Oct 16
Tue, Oct 16
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
- Remove dead code and fix comment
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
-Addressing comments
Mon, Oct 15
Mon, Oct 15
[llvm-exegesis] Fix missing std::move.
[llvm-exegesis][NFC] Return many CodeTemplates instead of one.
Fri, Oct 12
Fri, Oct 12
gchatelet updated the diff for D53209: [llvm-exegesis][NFC] Return many CodeTemplates instead of one..
- Inlining some code.
gchatelet committed rL344351: [llvm-exegesis][NFC] Simplify code at the cost of small code duplication.
[llvm-exegesis][NFC] Simplify code at the cost of small code duplication
gchatelet added a comment to D53198: [llvm-exegesis][NFC] Simplify code at the cost of small code duplication.
The diffing tool makes the change difficult to review but it's basically getting rid of the templated X86SnippetGenerator.
As discussed let's drop this change and return many CodeTemplate instead of a single one, moving the informations into CodeTemplate.
Thu, Oct 11
Thu, Oct 11
Wed, Oct 10
Wed, Oct 10
[llvm-exegesis] Fix always true assert
[llvm-exegesis][NFC] Pass Instruction instead of bare Opcode
[llvm-exegesis][NFC] Code simplification
This revision was not accepted when it landed; it landed in state Needs Review.
gchatelet updated the diff for D53078: [llvm-exegesis][NFC] Code simplification.
- Extract variable
gchatelet committed rL344137: [llvm-exegesis][NFC] Fix typo.
[llvm-exegesis][NFC] Fix typo
gchatelet accepted D53074: [llvm-exegesis] Fix function return generation so it doesn't return register 0.
Thx a lot!
[llvm-exegesis] Fix broken build.
gchatelet committed rL344130: [llvm-exegesis][NFC] Simplify code now that Instruction has more semantic.
[llvm-exegesis][NFC] Simplify code now that Instruction has more semantic
gchatelet updated the diff for D53065: [llvm-exegesis][NFC] Simplify code now that Instruction has more semantic.
- Remove debug line
gchatelet committed rL344127: [llvm-exegesis] Remove unused variable, add more semantic to Instruction..
[llvm-exegesis] Remove unused variable, add more semantic to Instruction.
gchatelet updated the diff for D53062: [llvm-exegesis] Remove unused variable, add more semantic to Instruction..
- Fix aliases/alias
Tue, Oct 9
Tue, Oct 9
[llvm-exegesis] Fix invalid return type and add a Dump function.
gchatelet updated the diff for D53020: [llvm-exegesis] Fix invalid return type and add a Dump function..
- Fix function case.
[llvm-exegesis] Fix wrong index type.
[llvm-exegesis] Fix unused lambda capture.
[llvm-exegesis][NFC] Use accessors for Operand.
Mon, Oct 8
Mon, Oct 8
gchatelet updated the diff for D52982: [llvm-exegesis][NFC] Use accessors for Operand..
- As discussed, removing underscores.
gchatelet updated the diff for D52982: [llvm-exegesis][NFC] Use accessors for Operand..
- Also introducing accessors for Variable and Instruction.
Fri, Oct 5
Fri, Oct 5
gchatelet added inline comments to D52932: [MCSched] Bind PFM Counters to the CPUs instead of the SchedModel..
Thu, Oct 4
Thu, Oct 4
[llvm-exegesis][NFC] Improve parsing of the YAML files
gchatelet updated the diff for D52866: [llvm-exegesis][NFC] Improve parsing of the YAML files.
- Address comments
gchatelet added a comment to D52866: [llvm-exegesis][NFC] Improve parsing of the YAML files.
Wed, Oct 3
Wed, Oct 3
gchatelet added a comment to rL343690: [llvm-exegesis] Avoid yaml parser from calling sscanf for obvious non-matches….
I'd rather not go this route if possible because it's very brittle.
I'll rewrite the serialization code so it doesn't make use a formatting pattern, the automaton is probably rebuilt everytime we call sscanf.
gchatelet added inline comments to D52825: [llvm-exegesis] Resolve variant classes in analysis..
Mon, Oct 1
Mon, Oct 1
[llvm-exegesis][NFC] Move random functions from CodeTemplate to…
[llvm-exegesis][NFC] Make randomizeUnsetVariables a free function.
Thu, Sep 27
Thu, Sep 27
Is there any documentation to update as well?
[llvm-exegesis][NFC] moving code around.
Wed, Sep 26
Wed, Sep 26
[llvm-exegesis][NFC] Move CodeTemplate to it's own file.
gchatelet updated the diff for D52542: [llvm-exegesis][NFC] Move CodeTemplate to it's own file..
- Add missing header in cpp file