Page MenuHomePhabricator

gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (115 w, 2 d)

Recent Activity

Today

gchatelet added a comment to D65945: [LLVM][Alignment] Make functions using log of alignment explicit.

@arphaman do you mind having a look at the MIR parser / writer parts?
How is alignment supposed to be serialized for MIR? As power of two or a log of alignment?

Fri, Aug 23, 2:32 PM · Restricted Project
gchatelet updated the diff for D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
  • Rebasing
  • Update documentation flags.
Fri, Aug 23, 2:32 PM · Restricted Project
gchatelet updated the summary of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Fri, Aug 23, 2:32 PM · Restricted Project
gchatelet added inline comments to D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Fri, Aug 23, 2:32 PM · Restricted Project
gchatelet committed rL369810: [LLVM][NFC] remove unused fields.
[LLVM][NFC] remove unused fields
Fri, Aug 23, 1:49 PM
gchatelet committed rGb7be5b90955e: [LLVM][NFC] remove unused fields (authored by gchatelet).
[LLVM][NFC] remove unused fields
Fri, Aug 23, 1:49 PM
gchatelet closed D66683: [LLVM][NFC] remove unused fields.
Fri, Aug 23, 1:49 PM · Restricted Project
gchatelet added inline comments to D66428: Change TargetLibraryInfo analysis passes to always require Function.
Fri, Aug 23, 1:49 PM · Restricted Project
gchatelet created D66683: [LLVM][NFC] remove unused fields.
Fri, Aug 23, 1:40 PM · Restricted Project

Wed, Aug 21

gchatelet added a reviewer for D65945: [LLVM][Alignment] Make functions using log of alignment explicit: courbet.
Wed, Aug 21, 11:48 AM · Restricted Project
gchatelet updated the diff for D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
  • Also removes JumpBufSize
  • Rebasing fix
Wed, Aug 21, 11:45 AM · Restricted Project
gchatelet committed rG1c18a9cb9eef: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo (authored by gchatelet).
[LLVM][Alignment] Introduce Alignment In MachineFrameInfo
Wed, Aug 21, 7:30 AM
gchatelet committed rL369531: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.
[LLVM][Alignment] Introduce Alignment In MachineFrameInfo
Wed, Aug 21, 7:30 AM
gchatelet closed D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.
Wed, Aug 21, 7:29 AM · Restricted Project
gchatelet added a comment to D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.

Thx @hfinkel

Wed, Aug 21, 7:29 AM · Restricted Project

Tue, Aug 20

gchatelet updated the diff for D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.

rebasing

Tue, Aug 20, 12:38 PM · Restricted Project

Mon, Aug 19

gchatelet added a comment to D66428: Change TargetLibraryInfo analysis passes to always require Function.

Thx for working on this Teresa.

Mon, Aug 19, 11:06 AM · Restricted Project

Thu, Aug 15

gchatelet added a comment to D65859: [LLVM][Alignment] Fix MSVC warning.

Thx for fixing it!

Thu, Aug 15, 10:52 AM · Restricted Project
gchatelet added a comment to D65859: [LLVM][Alignment] Fix MSVC warning.

This isn't handling all the cases - its probably better to push at the top of the file (before namespace) and similarly pop at the end of the file

Thu, Aug 15, 4:40 AM · Restricted Project

Fri, Aug 9

gchatelet accepted D65948: [MCA] Add flag -show-encoding to llvm-mca..
Fri, Aug 9, 1:40 AM · Restricted Project

Thu, Aug 8

gchatelet added reviewers for D65945: [LLVM][Alignment] Make functions using log of alignment explicit: arphaman, nadav, gberry, Eugene.Zelenko.
Thu, Aug 8, 7:50 AM · Restricted Project
gchatelet added a comment to D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.

The Hexagon part looks ok.

Thu, Aug 8, 7:31 AM · Restricted Project
gchatelet updated the diff for D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.
  • Using Align for LocalFrameMaxAlign instead of MaybeAlign
Thu, Aug 8, 7:13 AM · Restricted Project
gchatelet added a reviewer for D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo: kparzysz.
Thu, Aug 8, 7:11 AM · Restricted Project
gchatelet accepted D65948: [MCA] Add flag -show-encoding to llvm-mca..

Nice!
Please wait for other reviewers to have a look.

Thu, Aug 8, 6:45 AM · Restricted Project
gchatelet updated the summary of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Thu, Aug 8, 6:07 AM · Restricted Project
gchatelet updated the diff for D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
  • Also removes JumpBufSize
Thu, Aug 8, 6:07 AM · Restricted Project
gchatelet updated the summary of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Thu, Aug 8, 6:03 AM · Restricted Project
gchatelet updated the summary of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Thu, Aug 8, 5:59 AM · Restricted Project
gchatelet updated the summary of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Thu, Aug 8, 5:58 AM · Restricted Project
gchatelet created D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Thu, Aug 8, 5:58 AM · Restricted Project

Wed, Aug 7

gchatelet accepted D65858: [DataLayout] Check StackNatural and FunctionPtr alignments..

LGTM. Thx!

Wed, Aug 7, 4:59 AM · Restricted Project
gchatelet updated the summary of D65859: [LLVM][Alignment] Fix MSVC warning.
Wed, Aug 7, 4:44 AM · Restricted Project
gchatelet created D65859: [LLVM][Alignment] Fix MSVC warning.
Wed, Aug 7, 4:42 AM · Restricted Project

Tue, Aug 6

gchatelet added a comment to D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.

All the tests are passing but I'm not entirely sure of the validity of this patch.
Alignment, StackAlignment seems to be always defined alignment (aka. Align) but I'm not so sure of MaxAlignment and LocalFrameMaxAlign.
Hexagon/HexagonFrameLowering.cpp seem to rely on the fact that LocalFrameMaxAlign is undefined.
I'm not sure about MaxAlignment.

Tue, Aug 6, 8:31 AM · Restricted Project
gchatelet updated the diff for D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.

Converting all alignements in MachineFrameInfo.

Tue, Aug 6, 8:31 AM · Restricted Project
gchatelet created D65800: [LLVM][Alignment] Introduce Alignment In MachineFrameInfo.
Tue, Aug 6, 5:12 AM · Restricted Project
gchatelet committed rGa7b6a7c851eb: [LLVM][Alignment] Introduce Alignment In Attributes (authored by gchatelet).
[LLVM][Alignment] Introduce Alignment In Attributes
Tue, Aug 6, 2:18 AM
gchatelet committed rL368002: [LLVM][Alignment] Introduce Alignment In Attributes.
[LLVM][Alignment] Introduce Alignment In Attributes
Tue, Aug 6, 2:16 AM
gchatelet closed D65742: [LLVM][Alignment] Introduce Alignment In Attributes.
Tue, Aug 6, 2:16 AM · Restricted Project
gchatelet updated the diff for D65742: [LLVM][Alignment] Introduce Alignment In Attributes.

clang-format before submitting

Tue, Aug 6, 2:15 AM · Restricted Project
gchatelet committed rG396521378f0a: [LLVM][Alignment] Introduce Alignment In GlobalObject (authored by gchatelet).
[LLVM][Alignment] Introduce Alignment In GlobalObject
Tue, Aug 6, 2:05 AM
gchatelet committed rL368000: [LLVM][Alignment] Introduce Alignment In GlobalObject.
[LLVM][Alignment] Introduce Alignment In GlobalObject
Tue, Aug 6, 2:03 AM
gchatelet closed D65748: [LLVM][Alignment] Introduce Alignment In GlobalObject.
Tue, Aug 6, 2:03 AM · Restricted Project
gchatelet updated the diff for D65748: [LLVM][Alignment] Introduce Alignment In GlobalObject.

Added FIXME and used neither instead of not

Tue, Aug 6, 2:00 AM · Restricted Project

Mon, Aug 5

gchatelet created D65748: [LLVM][Alignment] Introduce Alignment In GlobalObject.
Mon, Aug 5, 7:40 AM · Restricted Project
gchatelet created D65742: [LLVM][Alignment] Introduce Alignment In Attributes.
Mon, Aug 5, 6:03 AM · Restricted Project
gchatelet committed rGc97a3d15d23d: [LLVM][Alignment] Introduce Alignment Type (authored by gchatelet).
[LLVM][Alignment] Introduce Alignment Type
Mon, Aug 5, 4:04 AM
gchatelet committed rL367828: [LLVM][Alignment] Introduce Alignment Type.
[LLVM][Alignment] Introduce Alignment Type
Mon, Aug 5, 4:04 AM
gchatelet closed D65514: [LLVM][Alignment] Introduce Alignment Type.
Mon, Aug 5, 4:03 AM · Restricted Project
gchatelet committed rG6c5fb61f8bcc: [LLVM][Alignment] Introduce Alignment In CallingConv (authored by gchatelet).
[LLVM][Alignment] Introduce Alignment In CallingConv
Mon, Aug 5, 2:49 AM
gchatelet committed rL367822: [LLVM][Alignment] Introduce Alignment In CallingConv.
[LLVM][Alignment] Introduce Alignment In CallingConv
Mon, Aug 5, 2:49 AM
gchatelet closed D65659: [LLVM][Alignment] Introduce Alignment In CallingConv.
Mon, Aug 5, 2:49 AM · Restricted Project
gchatelet committed rG65e4b47aad33: [LLVM][Alignment] Introduce Alignment Type in DataLayout (authored by gchatelet).
[LLVM][Alignment] Introduce Alignment Type in DataLayout
Mon, Aug 5, 2:04 AM
gchatelet committed rL367817: [LLVM][Alignment] Introduce Alignment Type in DataLayout.
[LLVM][Alignment] Introduce Alignment Type in DataLayout
Mon, Aug 5, 2:00 AM
gchatelet closed D65521: [LLVM][Alignment] Introduce Alignment Type in DataLayout.
Mon, Aug 5, 2:00 AM · Restricted Project
gchatelet added a comment to rG2bea69bf6503: Finish moving TargetRegisterInfo::isVirtualRegister() and friends to llvm….

The fixits indicate the right change to make (TargetRegisterInfo -> Register). I've applied them in r367697

By the way, do you have a bot? I didn't get any failure notices for ARC.

Mon, Aug 5, 12:46 AM
gchatelet added a comment to rL367702: [llvm-objcopy] - Fix the strip-dwo-groups.test..

Thx a lot :)

Mon, Aug 5, 12:41 AM

Fri, Aug 2

gchatelet added inline comments to D65659: [LLVM][Alignment] Introduce Alignment In CallingConv.
Fri, Aug 2, 8:30 AM · Restricted Project
gchatelet added reviewers for D65659: [LLVM][Alignment] Introduce Alignment In CallingConv: hiraditya, jfb.
Fri, Aug 2, 8:27 AM · Restricted Project
gchatelet added a comment to D65514: [LLVM][Alignment] Introduce Alignment Type.

I will push this on Monday 5th of Aug. Let me know if you have any concerns.

Fri, Aug 2, 8:17 AM · Restricted Project
gchatelet created D65659: [LLVM][Alignment] Introduce Alignment In CallingConv.
Fri, Aug 2, 7:57 AM · Restricted Project
gchatelet added a comment to D65273: [llvm-objcopy] - Reimplement strip-dwo-groups.test to stop using the precompiled object..

The test appears to fail when the compilation path contains the debug_ substring.
This is not ideal.

Fri, Aug 2, 6:35 AM
gchatelet updated the diff for D65521: [LLVM][Alignment] Introduce Alignment Type in DataLayout.

Also changed getFunctionPtrAlign() return type to MaybeAlign.
Keeping getStackAlignment() return type as unsigned for now.

Fri, Aug 2, 2:47 AM · Restricted Project
gchatelet added a comment to rG2bea69bf6503: Finish moving TargetRegisterInfo::isVirtualRegister() and friends to llvm….

This patch broke ARC experimental target, activated by -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="ARC"

/llvm-project/llvm/lib/Target/ARC/ARCOptAddrMode.cpp:142:10: error: no member named 'isVirtualRegister' in 'llvm::TargetRegisterInfo'; did you mean 'llvm::Register::isVirtualRegister'?
  assert(TargetRegisterInfo::isVirtualRegister(VReg) &&
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         llvm::Register::isVirtualRegister
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \
                          ^~~~
/llvm-project/llvm/include/llvm/CodeGen/Register.h:68:15: note: 'llvm::Register::isVirtualRegister' declared here
  static bool isVirtualRegister(unsigned Reg) {
              ^
/llvm/lib/Target/ARC/ARCOptAddrMode.cpp:209:27: error: no member named 'isStackSlot' in 'llvm::TargetRegisterInfo'
  if (TargetRegisterInfo::isStackSlot(B) ||
      ~~~~~~~~~~~~~~~~~~~~^
/llvm-project/llvm/lib/Target/ARC/ARCOptAddrMode.cpp:210:8: error: no member named 'isVirtualRegister' in 'llvm::TargetRegisterInfo'; did you mean 'llvm::Register::isVirtualRegister'?
      !TargetRegisterInfo::isVirtualRegister(B)) {
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       llvm::Register::isVirtualRegister
/llvm-project/llvm/include/llvm/CodeGen/Register.h:68:15: note: 'llvm::Register::isVirtualRegister' declared here
  static bool isVirtualRegister(unsigned Reg) {
Fri, Aug 2, 2:31 AM
gchatelet committed rG8113c93fb1b7: [LLVM][Alignment] Update documentation (authored by gchatelet).
[LLVM][Alignment] Update documentation
Fri, Aug 2, 12:17 AM
gchatelet committed rL367655: [LLVM][Alignment] Update documentation.
[LLVM][Alignment] Update documentation
Fri, Aug 2, 12:16 AM
gchatelet closed D65558: [LLVM][Alignment] Update documentation.
Fri, Aug 2, 12:16 AM · Restricted Project
gchatelet added a comment to D65558: [LLVM][Alignment] Update documentation.

Thx for the review, I'll proceed with the push.

Fri, Aug 2, 12:13 AM · Restricted Project
gchatelet updated the diff for D65558: [LLVM][Alignment] Update documentation.

Fix typo

Fri, Aug 2, 12:12 AM · Restricted Project

Thu, Aug 1

gchatelet committed rG41dfc69dc7fc: [LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t (authored by gchatelet).
[LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t
Thu, Aug 1, 2:21 AM
gchatelet committed rL367532: [LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t.
[LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t
Thu, Aug 1, 2:21 AM
gchatelet closed D65563: [LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t.
Thu, Aug 1, 2:21 AM · Restricted Project
gchatelet created D65563: [LLVM][Alignment] Fix AlignmentTest on platform where size_t != uint64_t.
Thu, Aug 1, 2:09 AM · Restricted Project
gchatelet updated the diff for D65521: [LLVM][Alignment] Introduce Alignment Type in DataLayout.
  • Make getFunctionPtrAlign() return MaybeAlign
Thu, Aug 1, 1:48 AM · Restricted Project
gchatelet added a comment to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.

@aprantl I've created https://reviews.llvm.org/D65558 to address your comments since this patch is already submitted.

Thu, Aug 1, 12:30 AM · Restricted Project
gchatelet created D65558: [LLVM][Alignment] Update documentation.
Thu, Aug 1, 12:30 AM · Restricted Project

Wed, Jul 31

gchatelet added inline comments to D65521: [LLVM][Alignment] Introduce Alignment Type in DataLayout.
Wed, Jul 31, 10:14 AM · Restricted Project
gchatelet created D65521: [LLVM][Alignment] Introduce Alignment Type in DataLayout.
Wed, Jul 31, 9:45 AM · Restricted Project
gchatelet updated the diff for D65514: [LLVM][Alignment] Introduce Alignment Type.
  • Fix formatting
Wed, Jul 31, 7:12 AM · Restricted Project
gchatelet created D65514: [LLVM][Alignment] Introduce Alignment Type.
Wed, Jul 31, 7:01 AM · Restricted Project
gchatelet added a comment to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.

@gchatelet This is breaking windows bots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/1933 - please can you take a look? I think we'll need to revert until you have a fix.

Wed, Jul 31, 5:53 AM · Restricted Project
gchatelet committed rG10dd2965b74d: [LLVM] Fix Alignment death tests in Release Mode (authored by gchatelet).
[LLVM] Fix Alignment death tests in Release Mode
Wed, Jul 31, 5:49 AM
gchatelet committed rL367427: [LLVM] Fix Alignment death tests in Release Mode.
[LLVM] Fix Alignment death tests in Release Mode
Wed, Jul 31, 5:49 AM
gchatelet added a comment to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.

This also broke ninja check-llvm-unit on a Release build:

Wed, Jul 31, 5:27 AM · Restricted Project
gchatelet committed rGc87581c4d46e: Fix mismatching vector type in AlignmentTest.cpp (authored by gchatelet).
Fix mismatching vector type in AlignmentTest.cpp
Wed, Jul 31, 3:04 AM
gchatelet committed rL367404: Fix mismatching vector type in AlignmentTest.cpp.
Fix mismatching vector type in AlignmentTest.cpp
Wed, Jul 31, 3:03 AM
gchatelet added a comment to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.

This patch broke buildbot, I've submitted to fix MSVC https://reviews.llvm.org/rL367400

Wed, Jul 31, 2:19 AM · Restricted Project
gchatelet committed rGf87a9626f1df: Add default constructor for MaybeAlign (authored by gchatelet).
Add default constructor for MaybeAlign
Wed, Jul 31, 2:18 AM
gchatelet committed rL367400: Add default constructor for MaybeAlign.
Add default constructor for MaybeAlign
Wed, Jul 31, 2:17 AM
gchatelet committed rGac4869197f89: [LLVM][NFC] Adding an Alignment type to LLVM (authored by gchatelet).
[LLVM][NFC] Adding an Alignment type to LLVM
Wed, Jul 31, 1:31 AM
gchatelet committed rL367393: [LLVM][NFC] Adding an Alignment type to LLVM.
[LLVM][NFC] Adding an Alignment type to LLVM
Wed, Jul 31, 1:30 AM
gchatelet closed D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
Wed, Jul 31, 1:29 AM · Restricted Project
gchatelet added a comment to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.

Thank you for the review @jfb and @jakehehrlich. I'll submit the patch now and start working on the migration.
Let me know if you have additional comments.

Wed, Jul 31, 12:44 AM · Restricted Project
gchatelet updated the diff for D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
  • Remove final from Align and MaybeAlign
Wed, Jul 31, 12:44 AM · Restricted Project

Tue, Jul 30

gchatelet updated the diff for D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
  • Fix documentation
Tue, Jul 30, 12:29 AM · Restricted Project
gchatelet updated the diff for D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
  • Assert when Log2 on undefined MaybeAlign.
Tue, Jul 30, 12:28 AM · Restricted Project
gchatelet added inline comments to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
Tue, Jul 30, 12:28 AM · Restricted Project

Mon, Jul 29

gchatelet added a comment to D64790: [LLVM][NFC] Adding an Alignment type to LLVM.

Thx for the review @jfb. Anything else?

Mon, Jul 29, 7:36 AM · Restricted Project
gchatelet updated the diff for D64790: [LLVM][NFC] Adding an Alignment type to LLVM.
  • Make MaybeAlign an llvm::Optional.
  • Remove unnecessary documentation,
Mon, Jul 29, 7:36 AM · Restricted Project