- User Since
- Jun 7 2017, 7:28 AM (201 w, 6 d)
Sun, Apr 18
Fri, Apr 16
- Added documentation
- Recover ParamType from PRETTY_FUNCTION instead of RTTI or user provided type name.
Thx for the suggestion, I didn't go with explicit member function as it would allow for integer promotion.
In the case of endianness we want to make sure we only accept one of uint8_t, uint16_t, uint32_t, uint64_t and no other type.
I've added the symmetric functions as you suggested.
- Simplify tests
- Add tests and remove macros
- Fixed base revision
- Fix typo and static assert message.
- Fix argument capitalization
Thu, Apr 15
- Added missing modification to CMakeLists.txt
Let me know if you want this header to live somewhere else, or if you had other plans in mind.
I removed the various asserts from the original code as we did for StringView.
Should we start to add tests?
Tue, Apr 13
Thank you for the clean up. Really appreciate it.
Before submitting the patch did you check that there are no users in experimental targets? (ARC, VE)
Tue, Mar 30
Feb 24 2021
LGTM as well
Feb 23 2021
Feb 11 2021
Thx @jyknight ! Let me know if you prefer me to push it ( and D87443 ).
If you do push them please mention the two reviews (D87443 and D83465) in the description so we can track everything and abandon these changes.
Feb 5 2021
I had a similar patch - D82876 - but it never went through...
Thx for working on this!
Feb 1 2021
LGTM thx @qiucf
Jan 29 2021
Hey Andre, my apologies for the lag. Answers inlined
Jan 25 2021
Jan 19 2021
Jan 15 2021
- buffer values are never modified so we can use char instead of unsigned char.
- Address comments
Jan 14 2021
Jan 13 2021
Jan 12 2021
LGTM, can you please wait for @sivachandra answer about using assert in code before submitting? Thx!
Jan 11 2021
My apologies for the late reply. I've made a bunch of comments.
Jan 6 2021
- Address comments and rebase
Jan 5 2021
Dec 17 2020
@sivachandra I'll submit this as is. Let me know if you have any concerns and we can amend it in a follow up patch.
- Address comments
Dec 16 2020
- Address comments and fix naming style