User Details
- User Since
- Jun 7 2017, 7:28 AM (258 w, 5 d)
Fri, May 20
Thu, May 19
- fix type mismatch for inline_memset
- rebase and squash
- rebase
Format commit message
Wed, May 18
- Use enum class for Temporal and Aligned attributes
Tue, May 17
- Fix documentation for address.h
Thu, May 5
Wed, May 4
@sivachandra at first I thought I should use LLVM_LIBC_FUNCTION_ATTR but it does not work. Should it be moved to the definition instead of the declaration?
Mon, May 2
Apr 22 2022
Apr 21 2022
@avieira can you approve this change?
Apr 15 2022
Apr 14 2022
Apr 13 2022
Apr 5 2022
LLVM currently prefers 256-bit operations even on recent Intel processors.
https://godbolt.org/z/dffKPxo53
Mar 29 2022
@lgxbslgx can you abandon this patch?
rebase with all the diffs
rebase
Mar 28 2022
Thx for challenging my patch @lgxbslgx.
- Guard libc benchmarks behind a flag
- Use ExternalProject as the benchmark target is not always available
Mar 25 2022
I believe the benchmark CMake target is gated on some variable being defined.
Let me have a look, I'll reply ASAP.
Also it compiles just fine without the patch.
Can you share the error message you're getting in the first place?
This patch fails locally for me in the same way it fails on the build bot.
Mar 23 2022
- rebase
- Try to use prebuilt tools
- Update bazel files to get closer to internal files
Mar 22 2022
Mar 18 2022
Thx!
Mar 16 2022
- Fix bazel files after cpp_standalone splitting
- rebase
Mar 15 2022
- rebase and test CI now that https://github.com/google/llvm-premerge-checks/commit/86e2347137812b329d0ed603140737ceebaa1e9f is submitted.
Mar 14 2022
Much better, thank you.
Thx for the patch, please address the comment before submitting.
Mar 10 2022
- Use git_repository with tags, re-enable tool registration to check if CI works (m4 is missing), apply .bazelrc flags more specifically
Mar 9 2022
Another hack is to modify the .bazelrc file to pass -Wall -Werror only to cxxopt, instead of copt. Since make, gmp and mpfr are C and not C++ it works. But yeah, quite a hacky solution as well,
@GMNGeoffrey I'm having an issue that you may know how to solve.
.bazelrc automatically appends -Wall -Werror to everything that is built.
Feb 18 2022
rebase and squash
- Add documentation
Feb 17 2022
- Reverting print function, this will go in a different patch.
rebase and squash
- Use tuple ordering to simplify sorting
rebase and squash commits
- Cleanup StringSet angle brackets, they are not needed in C++17
- Rename flag so the intent is clearer
rebase
Feb 14 2022
Feb 11 2022
- Add documentation on why -Wno-error is needed to compile gmp and mpfr.
We'd need to have autotools installed on the CI machine though.
gmp and mpfr are built from source. Right now this is quite slow as Bazel does not parallelize the job yet (https://github.com/bazelbuild/rules_foreign_cc/issues/329).
Once the build is cached this is fast though.
Feb 10 2022
This patch has been broken down and submitted:
Feb 9 2022
Feb 8 2022
rebase and change commit message
- Add missing change
FYI I also had the following constness warning
/redacted/git/llvm-project/libc/src/fenv/fesetexceptflag.cpp: In function ‘int __llvm_libc::__fesetexceptflag_impl__(const fexcept_t*, int)’: /redacted/git/llvm-project/libc/src/fenv/fesetexceptflag.cpp:23:24: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers] 23 | int excepts_to_set = static_cast<const int>(*flagp) & excepts; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- Non recursive Repeated::move implementation