User Details
- User Since
- Jun 7 2017, 7:28 AM (301 w, 5 d)
Wed, Mar 15
Tue, Mar 14
This patch broke the buildkite bot
https://buildkite.com/llvm-project/upstream-bazel/builds/56515#0186dfcd-e044-4adf-992d-b51e688544dd
Fri, Mar 10
Thx for the heads up / fix @tstellar !
Wed, Mar 8
- Disable layering check when using mpfr_system
- Remove layering_check on MPRFUtils instead
Tue, Mar 7
- Disable layering check when using mpfr_system
Mon, Mar 6
Thx for the review.
rebase, rename test and retitle commit
Fri, Mar 3
Feb 15 2023
Feb 14 2023
- rename LLVM_LIBC_IMPLEMENTATION_DEFINED_TEST_BEHAVIOR as well
- Scope str_to_float macros and add a warning
Feb 13 2023
@michaelrj it seems that the following definitions are currently not exposed to the build system.
LIBC_COPT_PRINTF_CONV_ATLAS
LIBC_COPT_PRINTF_DISABLE_FLOAT
LIBC_COPT_PRINTF_DISABLE_INDEX_MODE
LIBC_COPT_PRINTF_DISABLE_WRITE_INT
LIBC_COPT_PRINTF_INDEX_ARR_LEN
LIBC_COPT_PRINTF_CONV_ATLAS
LIBC_COPT_SCANF_DISABLE_FLOAT
LIBC_COPT_SCANF_DISABLE_INDEX_MODE
LIBC_COPT_DISABLE_CLINGER_FAST_PATH
LIBC_COPT_DISABLE_EISEL_LEMIRE
LIBC_COPT_DISABLE_SIMPLE_DECIMAL_CONVERSION
- Keep CMake option as is, only change preprocessor
One advantage to adding at the package level is that it will also apply for downstream projects using LLVM. So if someone is building via their own project and editing an LLVM submodule or something then they would still have layering enforced. Just a thought
- Fix typo
Thx a lot Tue, looks like I messed up with the FMA flags sorry.
Feb 10 2023
Done
- address comments
rebase and move layering check as a global option
Feb 9 2023
I just looked at the premerge checks and I can see how this will be hard to fix globally (if at all possible).
I'll use the package feature instead.
Feb 8 2023
Feb 7 2023
Ok so I misunderstood the meaning of "i" then.