gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (71 w, 6 d)

Recent Activity

Today

gchatelet updated the diff for D53488: [clang-tidy] Catching narrowing from double to float..
  • Addressing comments
Tue, Oct 23, 4:43 AM · Restricted Project

Yesterday

gchatelet created D53502: [llvm-exegesis] ExecutionMode is computed upfront for Uops as well.
Mon, Oct 22, 8:13 AM
gchatelet committed rL344907: [llvm-exegesis] Crash when assembling invalid Operand.
[llvm-exegesis] Crash when assembling invalid Operand
Mon, Oct 22, 8:08 AM
gchatelet committed rL344906: [llvm-exegesis] Mark x86 segment register instructions as unsupported..
[llvm-exegesis] Mark x86 segment register instructions as unsupported.
Mon, Oct 22, 7:58 AM
gchatelet closed D53499: [llvm-exegesis] Mark x86 segment register instructions as unsupported..
Mon, Oct 22, 7:57 AM
gchatelet created D53499: [llvm-exegesis] Mark x86 segment register instructions as unsupported..
Mon, Oct 22, 7:56 AM
gchatelet committed rL344905: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
[llvm-exegesis] Reject x86 instructions that use non uniform memory accesses
Mon, Oct 22, 7:48 AM
gchatelet closed D53438: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
Mon, Oct 22, 7:48 AM
gchatelet updated the diff for D53438: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
  • Adding missing comment
Mon, Oct 22, 2:55 AM
gchatelet updated the diff for D53438: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
  • Addressing comments
Mon, Oct 22, 2:51 AM
gchatelet created D53488: [clang-tidy] Catching narrowing from double to float..
Mon, Oct 22, 2:20 AM · Restricted Project
gchatelet accepted D53455: [llvm-exegesis] Move namespace exegesis inside llvm::.

Nice ! Thx a lot :)

Mon, Oct 22, 1:46 AM

Fri, Oct 19

gchatelet created D53438: [llvm-exegesis] Reject x86 instructions that use non uniform memory accesses.
Fri, Oct 19, 8:17 AM
gchatelet accepted D53430: [llvm-exegesis] Mark second-form X87 instructions as unsupported..
Fri, Oct 19, 5:11 AM
gchatelet accepted D53429: [llvm-exegesis] Re-enable liveliness tracker..
Fri, Oct 19, 3:59 AM
gchatelet accepted D53423: [llvm-exegesis] X87 RFP setup code..
Fri, Oct 19, 2:50 AM

Thu, Oct 18

gchatelet committed rL344731: [llvm-exegesis] Fix off by one error.
[llvm-exegesis] Fix off by one error
Thu, Oct 18, 1:23 AM

Wed, Oct 17

gchatelet accepted D53371: [llvm-exegesis] Allow measuring several instructions in a single run..
Wed, Oct 17, 7:32 AM
gchatelet added inline comments to D53371: [llvm-exegesis] Allow measuring several instructions in a single run..
Wed, Oct 17, 7:18 AM
gchatelet added a comment to D53371: [llvm-exegesis] Allow measuring several instructions in a single run..

How do you plan to deal with opcodes that crash (assertion failure) the llvm as a whole?
I.e. not when the snippet crashes, but the generation of the snippet itself crashes.
I *believe* there are some cases.

Wed, Oct 17, 6:46 AM
gchatelet committed rL344692: Fix uninitialized variable.
Fix uninitialized variable
Wed, Oct 17, 5:29 AM
gchatelet committed rL344690: BuildBot fix, compiler complains about array decay to pointer.
BuildBot fix, compiler complains about array decay to pointer
Wed, Oct 17, 5:11 AM
gchatelet committed rL344689: [llvm-exegeis] Computing Latency configuration upfront so we can generate many….
[llvm-exegeis] Computing Latency configuration upfront so we can generate many…
Wed, Oct 17, 4:40 AM
gchatelet closed D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
Wed, Oct 17, 4:39 AM
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
  • Addressing comments
Wed, Oct 17, 4:13 AM
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
  • Fix variable name
Wed, Oct 17, 12:46 AM
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
  • Revert files from other commit to previous state
Wed, Oct 17, 12:21 AM

Tue, Oct 16

gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
  • Remove dead code and fix comment
Tue, Oct 16, 8:29 AM
gchatelet updated the diff for D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
-Addressing comments
Tue, Oct 16, 6:41 AM
gchatelet created D53320: [llvm-exegeis] Computing Latency configuration upfront so we can generate many CodeTemplates at once..
Tue, Oct 16, 5:07 AM

Mon, Oct 15

gchatelet committed rL344496: [llvm-exegesis] Fix missing std::move..
[llvm-exegesis] Fix missing std::move.
Mon, Oct 15, 2:23 AM
gchatelet committed rL344493: [llvm-exegesis][NFC] Return many CodeTemplates instead of one..
[llvm-exegesis][NFC] Return many CodeTemplates instead of one.
Mon, Oct 15, 2:11 AM
gchatelet closed D53209: [llvm-exegesis][NFC] Return many CodeTemplates instead of one..
Mon, Oct 15, 2:11 AM

Fri, Oct 12

gchatelet updated the diff for D53209: [llvm-exegesis][NFC] Return many CodeTemplates instead of one..
  • Inlining some code.
Fri, Oct 12, 11:23 AM
gchatelet created D53209: [llvm-exegesis][NFC] Return many CodeTemplates instead of one..
Fri, Oct 12, 11:18 AM
gchatelet committed rL344351: [llvm-exegesis][NFC] Simplify code at the cost of small code duplication.
[llvm-exegesis][NFC] Simplify code at the cost of small code duplication
Fri, Oct 12, 8:14 AM
gchatelet closed D53198: [llvm-exegesis][NFC] Simplify code at the cost of small code duplication.
Fri, Oct 12, 8:14 AM
gchatelet added a comment to D53198: [llvm-exegesis][NFC] Simplify code at the cost of small code duplication.

The diffing tool makes the change difficult to review but it's basically getting rid of the templated X86SnippetGenerator.

Fri, Oct 12, 8:06 AM
gchatelet created D53198: [llvm-exegesis][NFC] Simplify code at the cost of small code duplication.
Fri, Oct 12, 8:01 AM
gchatelet abandoned D53133: [llvm-exegesis][NFC] Make SnippetGenerator a pure virtual interface..

As discussed let's drop this change and return many CodeTemplate instead of a single one, moving the informations into CodeTemplate.

Fri, Oct 12, 2:45 AM

Thu, Oct 11

gchatelet created D53133: [llvm-exegesis][NFC] Make SnippetGenerator a pure virtual interface..
Thu, Oct 11, 4:46 AM

Wed, Oct 10

gchatelet committed rL344151: [llvm-exegesis] Fix always true assert.
[llvm-exegesis] Fix always true assert
Wed, Oct 10, 9:18 AM
gchatelet committed rL344145: [llvm-exegesis][NFC] Pass Instruction instead of bare Opcode.
[llvm-exegesis][NFC] Pass Instruction instead of bare Opcode
Wed, Oct 10, 7:59 AM
gchatelet committed rL344143: [llvm-exegesis][NFC] Code simplification.
[llvm-exegesis][NFC] Code simplification
Wed, Oct 10, 7:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Oct 10, 7:26 AM
gchatelet updated the diff for D53078: [llvm-exegesis][NFC] Code simplification.
  • Extract variable
Wed, Oct 10, 7:05 AM
gchatelet created D53078: [llvm-exegesis][NFC] Code simplification.
Wed, Oct 10, 6:58 AM
gchatelet committed rL344137: [llvm-exegesis][NFC] Fix typo.
[llvm-exegesis][NFC] Fix typo
Wed, Oct 10, 6:00 AM
gchatelet closed D53075: [llvm-exegesis][NFC] Fix typo.
Wed, Oct 10, 6:00 AM
gchatelet accepted D53074: [llvm-exegesis] Fix function return generation so it doesn't return register 0.

Thx a lot!

Wed, Oct 10, 5:58 AM
gchatelet created D53075: [llvm-exegesis][NFC] Fix typo.
Wed, Oct 10, 5:37 AM
gchatelet committed rL344131: [llvm-exegesis] Fix broken build..
[llvm-exegesis] Fix broken build.
Wed, Oct 10, 3:11 AM
gchatelet committed rL344130: [llvm-exegesis][NFC] Simplify code now that Instruction has more semantic.
[llvm-exegesis][NFC] Simplify code now that Instruction has more semantic
Wed, Oct 10, 2:47 AM
gchatelet closed D53065: [llvm-exegesis][NFC] Simplify code now that Instruction has more semantic.
Wed, Oct 10, 2:47 AM
gchatelet updated the diff for D53065: [llvm-exegesis][NFC] Simplify code now that Instruction has more semantic.
  • Remove debug line
Wed, Oct 10, 2:46 AM
gchatelet created D53065: [llvm-exegesis][NFC] Simplify code now that Instruction has more semantic.
Wed, Oct 10, 2:19 AM
gchatelet committed rL344127: [llvm-exegesis] Remove unused variable, add more semantic to Instruction..
[llvm-exegesis] Remove unused variable, add more semantic to Instruction.
Wed, Oct 10, 2:14 AM
gchatelet closed D53062: [llvm-exegesis] Remove unused variable, add more semantic to Instruction..
Wed, Oct 10, 2:14 AM
gchatelet updated the diff for D53062: [llvm-exegesis] Remove unused variable, add more semantic to Instruction..
  • Fix aliases/alias
Wed, Oct 10, 2:14 AM
gchatelet created D53062: [llvm-exegesis] Remove unused variable, add more semantic to Instruction..
Wed, Oct 10, 12:48 AM

Tue, Oct 9

gchatelet committed rL344051: Fix function case..
Fix function case.
Tue, Oct 9, 7:53 AM
gchatelet committed rL344050: [llvm-exegesis] Fix invalid return type and add a Dump function..
[llvm-exegesis] Fix invalid return type and add a Dump function.
Tue, Oct 9, 7:53 AM
gchatelet closed D53020: [llvm-exegesis] Fix invalid return type and add a Dump function..
Tue, Oct 9, 7:53 AM
gchatelet updated the diff for D53020: [llvm-exegesis] Fix invalid return type and add a Dump function..
  • Fix function case.
Tue, Oct 9, 7:52 AM
gchatelet created D53020: [llvm-exegesis] Fix invalid return type and add a Dump function..
Tue, Oct 9, 5:48 AM
gchatelet committed rL344032: [llvm-exegesis] Fix wrong index type..
[llvm-exegesis] Fix wrong index type.
Tue, Oct 9, 3:08 AM
gchatelet committed rL344029: [llvm-exegesis] Fix unused lambda capture..
[llvm-exegesis] Fix unused lambda capture.
Tue, Oct 9, 2:35 AM
gchatelet committed rL344028: [llvm-exegesis][NFC] Use accessors for Operand..
[llvm-exegesis][NFC] Use accessors for Operand.
Tue, Oct 9, 2:01 AM
gchatelet closed D52982: [llvm-exegesis][NFC] Use accessors for Operand..
Tue, Oct 9, 2:01 AM
gchatelet abandoned D50061: [llvm-exegesis] Proposal to add Exegesis Configuration to td files..
Tue, Oct 9, 1:49 AM

Mon, Oct 8

gchatelet updated the diff for D52982: [llvm-exegesis][NFC] Use accessors for Operand..
  • As discussed, removing underscores.
Mon, Oct 8, 7:50 AM
gchatelet added a reviewer for D52982: [llvm-exegesis][NFC] Use accessors for Operand.: courbet.
Mon, Oct 8, 7:34 AM
gchatelet updated the diff for D52982: [llvm-exegesis][NFC] Use accessors for Operand..
  • Also introducing accessors for Variable and Instruction.
Mon, Oct 8, 7:33 AM
gchatelet created D52982: [llvm-exegesis][NFC] Use accessors for Operand..
Mon, Oct 8, 6:18 AM

Fri, Oct 5

gchatelet accepted D52932: [MCSched] Bind PFM Counters to the CPUs instead of the SchedModel..
Fri, Oct 5, 7:51 AM
gchatelet added inline comments to D52932: [MCSched] Bind PFM Counters to the CPUs instead of the SchedModel..
Fri, Oct 5, 6:13 AM

Thu, Oct 4

gchatelet committed rL343771: [llvm-exegesis][NFC] Improve parsing of the YAML files.
[llvm-exegesis][NFC] Improve parsing of the YAML files
Thu, Oct 4, 5:35 AM
gchatelet closed D52866: [llvm-exegesis][NFC] Improve parsing of the YAML files.
Thu, Oct 4, 5:35 AM
gchatelet updated the diff for D52866: [llvm-exegesis][NFC] Improve parsing of the YAML files.
  • Address comments
Thu, Oct 4, 5:28 AM
gchatelet added a comment to D52866: [llvm-exegesis][NFC] Improve parsing of the YAML files.

It looks like you're reading/writing hex integer values now - weren't they regular decimals before hand?

Thu, Oct 4, 2:54 AM
gchatelet created D52866: [llvm-exegesis][NFC] Improve parsing of the YAML files.
Thu, Oct 4, 1:14 AM

Wed, Oct 3

gchatelet added a comment to rL343690: [llvm-exegesis] Avoid yaml parser from calling sscanf for obvious non-matches….

I'd rather not go this route if possible because it's very brittle.
I'll rewrite the serialization code so it doesn't make use a formatting pattern, the automaton is probably rebuilt everytime we call sscanf.

Wed, Oct 3, 8:07 AM
gchatelet accepted D52825: [llvm-exegesis] Resolve variant classes in analysis..
Wed, Oct 3, 4:47 AM
gchatelet added inline comments to D52825: [llvm-exegesis] Resolve variant classes in analysis..
Wed, Oct 3, 2:52 AM

Mon, Oct 1

gchatelet committed rL343461: [llvm-exegesis][NFC] Move random functions from CodeTemplate to….
[llvm-exegesis][NFC] Move random functions from CodeTemplate to…
Mon, Oct 1, 5:21 AM
gchatelet closed D52720: [llvm-exegesis][NFC] Move random functions from CodeTemplate to SnippetGenerator..
Mon, Oct 1, 5:21 AM
gchatelet created D52720: [llvm-exegesis][NFC] Move random functions from CodeTemplate to SnippetGenerator..
Mon, Oct 1, 4:48 AM
gchatelet committed rL343456: [llvm-exegesis][NFC] Make randomizeUnsetVariables a free function..
[llvm-exegesis][NFC] Make randomizeUnsetVariables a free function.
Mon, Oct 1, 4:47 AM
gchatelet closed D52718: [llvm-exegesis][NFC] Make randomizeUnsetVariables a free function..
Mon, Oct 1, 4:47 AM
gchatelet created D52718: [llvm-exegesis][NFC] Make randomizeUnsetVariables a free function..
Mon, Oct 1, 4:40 AM

Thu, Sep 27

gchatelet accepted D52607: [llvm-exegesis] Fix PR39096..

Is there any documentation to update as well?

Thu, Sep 27, 6:23 AM
gchatelet committed rL343188: [llvm-exegesis][NFC] moving code around..
[llvm-exegesis][NFC] moving code around.
Thu, Sep 27, 2:28 AM
gchatelet closed D52592: [llvm-exegesis][NFC] moving code around..
Thu, Sep 27, 2:28 AM
gchatelet created D52592: [llvm-exegesis][NFC] moving code around..
Thu, Sep 27, 2:13 AM

Wed, Sep 26

gchatelet accepted D52546: [llvm-exegesis] Get rid of debug_string..
Wed, Sep 26, 6:33 AM
gchatelet committed rL343098: [llvm-exegesis][NFC] Move CodeTemplate to it's own file..
[llvm-exegesis][NFC] Move CodeTemplate to it's own file.
Wed, Sep 26, 5:01 AM
gchatelet closed D52542: [llvm-exegesis][NFC] Move CodeTemplate to it's own file..
Wed, Sep 26, 5:00 AM
gchatelet updated the diff for D52542: [llvm-exegesis][NFC] Move CodeTemplate to it's own file..
  • Add missing header in cpp file
Wed, Sep 26, 4:48 AM
gchatelet created D52542: [llvm-exegesis][NFC] Move CodeTemplate to it's own file..
Wed, Sep 26, 4:30 AM
gchatelet accepted D52539: [llvm-exegesis] Add support for measuring NumMicroOps..
Wed, Sep 26, 4:23 AM