Page MenuHomePhabricator

gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (258 w, 5 d)

Recent Activity

Fri, May 20

gchatelet added a reverting change for rG94d6dd905766: [libc] Apply no-builtin everywhere, remove unnecessary flags: rG0443bfabe7ba: Revert "[libc] Apply no-builtin everywhere, remove unnecessary flags".
Fri, May 20, 7:37 AM · Restricted Project, Restricted Project
gchatelet committed rG0443bfabe7ba: Revert "[libc] Apply no-builtin everywhere, remove unnecessary flags" (authored by gchatelet).
Revert "[libc] Apply no-builtin everywhere, remove unnecessary flags"
Fri, May 20, 7:37 AM · Restricted Project, Restricted Project
gchatelet added a reverting change for D125894: [libc] Apply no-builtin everywhere, remove unnecessary flags: rG0443bfabe7ba: Revert "[libc] Apply no-builtin everywhere, remove unnecessary flags".
Fri, May 20, 7:37 AM · Restricted Project, Restricted Project

Thu, May 19

gchatelet updated the diff for D125768: [libc] Non-temporal memory function support.
  • fix type mismatch for inline_memset
Thu, May 19, 6:26 AM · Restricted Project, Restricted Project
gchatelet requested review of D125966: [libc][mem*] Address facility + test enum support.
Thu, May 19, 4:13 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D125768: [libc] Non-temporal memory function support.
  • rebase and squash
Thu, May 19, 2:52 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D125768: [libc] Non-temporal memory function support.
  • rebase
Thu, May 19, 2:11 AM · Restricted Project, Restricted Project
gchatelet committed rG94d6dd905766: [libc] Apply no-builtin everywhere, remove unnecessary flags (authored by gchatelet).
[libc] Apply no-builtin everywhere, remove unnecessary flags
Thu, May 19, 2:09 AM · Restricted Project, Restricted Project
gchatelet closed D125894: [libc] Apply no-builtin everywhere, remove unnecessary flags.
Thu, May 19, 2:08 AM · Restricted Project, Restricted Project
gchatelet updated the summary of D125894: [libc] Apply no-builtin everywhere, remove unnecessary flags.
Thu, May 19, 2:00 AM · Restricted Project, Restricted Project
gchatelet updated the summary of D125894: [libc] Apply no-builtin everywhere, remove unnecessary flags.
Thu, May 19, 2:00 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D125894: [libc] Apply no-builtin everywhere, remove unnecessary flags.

Format commit message

Thu, May 19, 1:59 AM · Restricted Project, Restricted Project

Wed, May 18

gchatelet requested review of D125894: [libc] Apply no-builtin everywhere, remove unnecessary flags.
Wed, May 18, 8:24 AM · Restricted Project, Restricted Project
gchatelet added inline comments to D125768: [libc] Non-temporal memory function support.
Wed, May 18, 2:32 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D125768: [libc] Non-temporal memory function support.
  • Use enum class for Temporal and Aligned attributes
Wed, May 18, 2:31 AM · Restricted Project, Restricted Project

Tue, May 17

gchatelet updated the diff for D125768: [libc] Non-temporal memory function support.
  • Fix documentation for address.h
Tue, May 17, 5:46 AM · Restricted Project, Restricted Project
gchatelet requested review of D125768: [libc] Non-temporal memory function support.
Tue, May 17, 5:40 AM · Restricted Project, Restricted Project

Thu, May 5

gchatelet added a comment to D124958: [libc] Align functions to 64B to lower benchmarking variance.

I have a few questions about this patch:

  1. Do you want all libc functions to be aligned to 64 bytes, or all public functions to be aligned to 64 bytes? Or, do you just want the memory functions to be aligned to 64 bytes?
Thu, May 5, 1:59 AM · Restricted Project, Restricted Project

Wed, May 4

gchatelet added a comment to D124958: [libc] Align functions to 64B to lower benchmarking variance.

@sivachandra at first I thought I should use LLVM_LIBC_FUNCTION_ATTR but it does not work. Should it be moved to the definition instead of the declaration?

Wed, May 4, 1:33 PM · Restricted Project, Restricted Project
gchatelet requested review of D124958: [libc] Align functions to 64B to lower benchmarking variance.
Wed, May 4, 1:30 PM · Restricted Project, Restricted Project

Mon, May 2

gchatelet added a reviewer for D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions: tejohnson.
Mon, May 2, 7:29 AM · Restricted Project, Restricted Project
gchatelet added a comment to D124214: [libc][NOT FOR COMMIT] building LLVM-libc on 32 bit arm with gcc.

The problem is that there are certain parts of libc++ that the tests include and depend on that aren't available. Most noticeably is iostream, which has #include "locale.h", which doesn't work since locales are disabled. The other problem is the memory functions, which have references to posix_memalign, which doesn't appear to be provided by your environment.

Mon, May 2, 1:26 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

gchatelet added inline comments to D124214: [libc][NOT FOR COMMIT] building LLVM-libc on 32 bit arm with gcc.
Apr 22 2022, 12:54 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

gchatelet added a comment to D124134: [libc] Use correct mnemonic for arm64_32 architecture.

@avieira can you approve this change?

Apr 21 2022, 1:04 AM · Restricted Project, Restricted Project
gchatelet added a reviewer for D124134: [libc] Use correct mnemonic for arm64_32 architecture: avieira.
Apr 21 2022, 1:03 AM · Restricted Project, Restricted Project

Apr 15 2022

gchatelet accepted D123849: [ExpandMemCmp] Properly expand `bcmp` to an equality pattern..
Apr 15 2022, 2:20 AM · Restricted Project, Restricted Project

Apr 14 2022

gchatelet added inline comments to D123645: [libc][docs] Add doc for libc string functions.
Apr 14 2022, 4:46 AM · Restricted Project, Restricted Project

Apr 13 2022

gchatelet added inline comments to D123645: [libc][docs] Add doc for libc string functions.
Apr 13 2022, 2:28 AM · Restricted Project, Restricted Project

Apr 5 2022

gchatelet added a comment to D41895: [X86] Another attempt at support prefer-vector-width function attribute.

I raised this on D111029 - its still not confirmed which avx512 capable targets work better with 512-bit vectors (other than KNL of course).

Apr 5 2022, 8:06 AM · Restricted Project, Restricted Project
Herald added projects to D41895: [X86] Another attempt at support prefer-vector-width function attribute: Restricted Project, Restricted Project.

LLVM currently prefers 256-bit operations even on recent Intel processors.
https://godbolt.org/z/dffKPxo53

Apr 5 2022, 6:57 AM · Restricted Project, Restricted Project

Mar 29 2022

gchatelet added a comment to D122392: [NFC][libc] Find the benchmark package and adjust the dependency targets.

@lgxbslgx can you abandon this patch?

Mar 29 2022, 1:48 AM · Restricted Project, Restricted Project
gchatelet committed rGdf838dbcfa9d: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available (authored by gchatelet).
[NFC][libc] Disable benchmarks when the LLVM benchmark target is not available
Mar 29 2022, 1:46 AM · Restricted Project, Restricted Project
gchatelet closed D122481: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available.
Mar 29 2022, 1:46 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D122481: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available.

rebase with all the diffs

Mar 29 2022, 1:46 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D122481: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available.

rebase

Mar 29 2022, 1:43 AM · Restricted Project, Restricted Project

Mar 28 2022

gchatelet added a comment to D122481: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available.

Thx for challenging my patch @lgxbslgx.

Mar 28 2022, 5:46 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D122481: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available.
  • Guard libc benchmarks behind a flag
  • Use ExternalProject as the benchmark target is not always available
Mar 28 2022, 5:27 AM · Restricted Project, Restricted Project

Mar 25 2022

gchatelet added a reviewer for D122481: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available: lgxbslgx.
Mar 25 2022, 7:00 AM · Restricted Project, Restricted Project
gchatelet added a comment to D122392: [NFC][libc] Find the benchmark package and adjust the dependency targets.

@lgxbslgx I'vre created D122481 that should fix the issue.

Mar 25 2022, 7:00 AM · Restricted Project, Restricted Project
gchatelet requested review of D122481: [NFC][libc] Disable benchmarks when the LLVM benchmark target is not available.
Mar 25 2022, 6:54 AM · Restricted Project, Restricted Project
gchatelet added a comment to D122392: [NFC][libc] Find the benchmark package and adjust the dependency targets.

I believe the benchmark CMake target is gated on some variable being defined.
Let me have a look, I'll reply ASAP.

Mar 25 2022, 5:55 AM · Restricted Project, Restricted Project
gchatelet added a comment to D122392: [NFC][libc] Find the benchmark package and adjust the dependency targets.

Also it compiles just fine without the patch.
Can you share the error message you're getting in the first place?

Mar 25 2022, 3:36 AM · Restricted Project, Restricted Project
gchatelet added a comment to D122392: [NFC][libc] Find the benchmark package and adjust the dependency targets.

This patch fails locally for me in the same way it fails on the build bot.

Mar 25 2022, 3:08 AM · Restricted Project, Restricted Project

Mar 23 2022

gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
  • rebase
Mar 23 2022, 9:07 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
  • Try to use prebuilt tools
Mar 23 2022, 8:41 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
  • Update bazel files to get closer to internal files
Mar 23 2022, 7:35 AM · Restricted Project, Restricted Project

Mar 22 2022

gchatelet removed a reviewer for D121934: [NFC][llvm][StringMap]Extract createTable and getHashTable functions and add the inline attribute to the getMinBucketToReserveForEntries function.: gchatelet.
Mar 22 2022, 3:20 AM · Restricted Project, Restricted Project

Mar 18 2022

gchatelet committed rG4b3a27e2e026: Add validation for number of arguments of __builtin_memcpy_inline (authored by royjacobson).
Add validation for number of arguments of __builtin_memcpy_inline
Mar 18 2022, 7:03 AM · Restricted Project
gchatelet closed D121965: Add validation for number of arguments of __builtin_memcpy_inline.
Mar 18 2022, 7:03 AM · Restricted Project, Restricted Project
gchatelet accepted D121965: Add validation for number of arguments of __builtin_memcpy_inline.

Thx!

Mar 18 2022, 2:39 AM · Restricted Project, Restricted Project

Mar 16 2022

gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
  • Fix bazel files after cpp_standalone splitting
Mar 16 2022, 4:42 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
  • rebase
Mar 16 2022, 2:24 AM · Restricted Project, Restricted Project

Mar 15 2022

gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
Mar 15 2022, 3:09 AM · Restricted Project, Restricted Project

Mar 14 2022

gchatelet accepted D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.

Much better, thank you.

Mar 14 2022, 5:34 AM · Restricted Project, Restricted Project
gchatelet accepted D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.

Thx for the patch, please address the comment before submitting.

Mar 14 2022, 2:19 AM · Restricted Project, Restricted Project

Mar 10 2022

gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
  • Use git_repository with tags, re-enable tool registration to check if CI works (m4 is missing), apply .bazelrc flags more specifically
Mar 10 2022, 5:07 AM · Restricted Project, Restricted Project
gchatelet accepted D121314: [libc][bazel] split support_standalone_cpp target.
Mar 10 2022, 2:23 AM · Restricted Project, Restricted Project

Mar 9 2022

gchatelet added a comment to D119547: [libc][bazel] Add tests to the bazel build.

Another hack is to modify the .bazelrc file to pass -Wall -Werror only to cxxopt, instead of copt. Since make, gmp and mpfr are C and not C++ it works. But yeah, quite a hacky solution as well,

Mar 9 2022, 7:57 AM · Restricted Project, Restricted Project
Herald added a project to D119547: [libc][bazel] Add tests to the bazel build: Restricted Project.

@GMNGeoffrey I'm having an issue that you may know how to solve.
.bazelrc automatically appends -Wall -Werror to everything that is built.

Mar 9 2022, 7:17 AM · Restricted Project, Restricted Project

Feb 18 2022

gchatelet committed rG07f93a1e390c: [libc][automemcpy] Discard aggrated samples from JSON (authored by gchatelet).
[libc][automemcpy] Discard aggrated samples from JSON
Feb 18 2022, 7:24 AM
gchatelet closed D120062: [libc][automemcpy] Discard aggrated samples from JSON.
Feb 18 2022, 7:24 AM · Restricted Project
gchatelet updated the diff for D120062: [libc][automemcpy] Discard aggrated samples from JSON.

rebase and squash

Feb 18 2022, 7:23 AM · Restricted Project
gchatelet updated the diff for D120062: [libc][automemcpy] Discard aggrated samples from JSON.
  • Add documentation
Feb 18 2022, 7:23 AM · Restricted Project

Feb 17 2022

gchatelet updated the diff for D120062: [libc][automemcpy] Discard aggrated samples from JSON.
  • Reverting print function, this will go in a different patch.
Feb 17 2022, 7:54 AM · Restricted Project
gchatelet requested review of D120062: [libc][automemcpy] Discard aggrated samples from JSON.
Feb 17 2022, 7:51 AM · Restricted Project
gchatelet committed rGda5a4f16e84b: [libc][automemcpy] Introduce geomean of scores as a tie breaker (authored by gchatelet).
[libc][automemcpy] Introduce geomean of scores as a tie breaker
Feb 17 2022, 5:46 AM
gchatelet closed D120040: [libc][automemcpy] Introduce geomean of scores as a tie breaker.
Feb 17 2022, 5:45 AM · Restricted Project
gchatelet updated the diff for D120040: [libc][automemcpy] Introduce geomean of scores as a tie breaker.

rebase and squash

Feb 17 2022, 5:37 AM · Restricted Project
gchatelet updated the diff for D120040: [libc][automemcpy] Introduce geomean of scores as a tie breaker.
  • Use tuple ordering to simplify sorting
Feb 17 2022, 5:36 AM · Restricted Project
gchatelet committed rG48e0e6cedc56: [llvm][automemcpy] Allow distribution filtering in analysis (authored by gchatelet).
[llvm][automemcpy] Allow distribution filtering in analysis
Feb 17 2022, 5:11 AM
gchatelet closed D120037: [llvm][automemcpy] Allow distribution filtering in analysis.
Feb 17 2022, 5:11 AM · Restricted Project
gchatelet updated the diff for D120037: [llvm][automemcpy] Allow distribution filtering in analysis.

rebase and squash commits

Feb 17 2022, 4:56 AM · Restricted Project
gchatelet updated the diff for D120037: [llvm][automemcpy] Allow distribution filtering in analysis.
  • Cleanup StringSet angle brackets, they are not needed in C++17
  • Rename flag so the intent is clearer
Feb 17 2022, 4:54 AM · Restricted Project
gchatelet requested review of D120040: [libc][automemcpy] Introduce geomean of scores as a tie breaker.
Feb 17 2022, 4:31 AM · Restricted Project
gchatelet updated the diff for D120037: [llvm][automemcpy] Allow distribution filtering in analysis.

rebase

Feb 17 2022, 4:13 AM · Restricted Project
gchatelet committed rGb254a2a70340: [libc][automemcpy] Add mean/variance and simplify implementation (authored by gchatelet).
[libc][automemcpy] Add mean/variance and simplify implementation
Feb 17 2022, 4:11 AM
gchatelet closed D120031: [libc][automemcpy] Add mean/variance and simplify implementation.
Feb 17 2022, 4:11 AM · Restricted Project
gchatelet requested review of D120037: [llvm][automemcpy] Allow distribution filtering in analysis.
Feb 17 2022, 3:52 AM · Restricted Project
gchatelet requested review of D120031: [libc][automemcpy] Add mean/variance and simplify implementation.
Feb 17 2022, 3:05 AM · Restricted Project

Feb 14 2022

gchatelet committed rGae8b63866d76: [libc][benchmark] Fix change in JSon API (authored by gchatelet).
[libc][benchmark] Fix change in JSon API
Feb 14 2022, 7:56 AM

Feb 11 2022

gchatelet updated the diff for D119547: [libc][bazel] Add tests to the bazel build.
  • Add documentation on why -Wno-error is needed to compile gmp and mpfr.
Feb 11 2022, 8:16 AM · Restricted Project, Restricted Project
gchatelet added a comment to D119547: [libc][bazel] Add tests to the bazel build.

We'd need to have autotools installed on the CI machine though.

Feb 11 2022, 8:09 AM · Restricted Project, Restricted Project
gchatelet added a comment to D119547: [libc][bazel] Add tests to the bazel build.

gmp and mpfr are built from source. Right now this is quite slow as Bazel does not parallelize the job yet (https://github.com/bazelbuild/rules_foreign_cc/issues/329).
Once the build is cached this is fast though.

Feb 11 2022, 7:47 AM · Restricted Project, Restricted Project
gchatelet requested review of D119547: [libc][bazel] Add tests to the bazel build.
Feb 11 2022, 7:36 AM · Restricted Project, Restricted Project

Feb 10 2022

gchatelet abandoned D119002: [libc] Fix compilation with gcc.

This patch has been broken down and submitted:

  • D119142: [libc][NFC] moving template specialization outside class declaration
  • D119143: [libc] Don't use Clang flags on other compilers
  • D119145: [libc] Replace type punning with bit_cast.
  • D119242: [libc] undefined reference in LibcTest.cpp.
Feb 10 2022, 1:34 AM · Restricted Project

Feb 9 2022

gchatelet committed rGd2c595466207: [libc] undefined reference in LibcTest.cpp (authored by gchatelet).
[libc] undefined reference in LibcTest.cpp
Feb 9 2022, 12:46 PM
gchatelet closed D119242: [libc] undefined reference in LibcTest.cpp.
Feb 9 2022, 12:46 PM · Restricted Project

Feb 8 2022

gchatelet committed rG7e7ecef98080: [libc] Replace type punning with bit_cast (authored by gchatelet).
[libc] Replace type punning with bit_cast
Feb 8 2022, 12:46 PM
gchatelet closed D119145: [libc] Replace type punning with bit_cast.
Feb 8 2022, 12:46 PM · Restricted Project
gchatelet added a comment to D119145: [libc] Replace type punning with bit_cast.

I am not an expert, but normally the word "illegal" in code/commit logs is not preferred as it can imply non-technical errors. So, may be replace it with "incorrect".

Feb 8 2022, 8:56 AM · Restricted Project
gchatelet retitled D119145: [libc] Replace type punning with bit_cast from [libc] Fix illegal type punning to [libc] Replace type punning with bit_cast.
Feb 8 2022, 8:56 AM · Restricted Project
gchatelet updated the diff for D119145: [libc] Replace type punning with bit_cast.

rebase and change commit message

Feb 8 2022, 8:55 AM · Restricted Project
gchatelet requested review of D119242: [libc] undefined reference in LibcTest.cpp.
Feb 8 2022, 6:55 AM · Restricted Project
gchatelet updated the diff for D119145: [libc] Replace type punning with bit_cast.
  • Add missing change
Feb 8 2022, 6:51 AM · Restricted Project
gchatelet added a comment to D119145: [libc] Replace type punning with bit_cast.

FYI I also had the following constness warning

/redacted/git/llvm-project/libc/src/fenv/fesetexceptflag.cpp: In function ‘int __llvm_libc::__fesetexceptflag_impl__(const fexcept_t*, int)’:
/redacted/git/llvm-project/libc/src/fenv/fesetexceptflag.cpp:23:24: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
   23 |   int excepts_to_set = static_cast<const int>(*flagp) & excepts;
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Feb 8 2022, 5:56 AM · Restricted Project
gchatelet committed rG83f9b13d8cc2: [libc] Optimized version of memmove (authored by gchatelet).
[libc] Optimized version of memmove
Feb 8 2022, 3:55 AM
gchatelet closed D114637: [libc] Optimized version of memmove.
Feb 8 2022, 3:55 AM · Restricted Project
gchatelet committed rGf231599666c7: [libc] Don't use Clang flags on other compilers (authored by gchatelet).
[libc] Don't use Clang flags on other compilers
Feb 8 2022, 3:01 AM
gchatelet closed D119143: [libc] Don't use Clang flags on other compilers.
Feb 8 2022, 3:01 AM · Restricted Project
gchatelet updated the diff for D114637: [libc] Optimized version of memmove.
  • Non recursive Repeated::move implementation
Feb 8 2022, 2:50 AM · Restricted Project