Page MenuHomePhabricator

gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (122 w, 5 d)

Recent Activity

Today

gchatelet created D68944: [Alignment][NFC] Remove dependency on GlobalObject::setAlignment(unsigned).
Mon, Oct 14, 8:06 AM · Restricted Project
gchatelet committed rGce56e1a1cc57: [Alignment][NFC] Move and type functions from MathExtras to Alignment (authored by gchatelet).
[Alignment][NFC] Move and type functions from MathExtras to Alignment
Mon, Oct 14, 6:15 AM
gchatelet committed rL374773: [Alignment][NFC] Move and type functions from MathExtras to Alignment.
[Alignment][NFC] Move and type functions from MathExtras to Alignment
Mon, Oct 14, 6:15 AM
gchatelet closed D68942: [Alignment][NFC] Move and type functions from MathExtras to Alignment.
Mon, Oct 14, 6:15 AM · Restricted Project
gchatelet updated the diff for D68942: [Alignment][NFC] Move and type functions from MathExtras to Alignment.
  • Address comments
Mon, Oct 14, 6:15 AM · Restricted Project
gchatelet added a comment to D68398: [Alignment][NFC] Value::getPointerAlignment returns MaybeAlign.

A gentle ping @jdoerfert

Mon, Oct 14, 5:56 AM · Restricted Project
gchatelet retitled D68942: [Alignment][NFC] Move and type functions from MathExtras to Alignment from [Alignment][NFC] Move functions from MathUtils to Alignment to [Alignment][NFC] Move and type functions from MathExtras to Alignment.
Mon, Oct 14, 5:38 AM · Restricted Project
gchatelet added a comment to D68028: [clang] Add no_builtin attribute.

A gentle ping @aaron.ballman

Mon, Oct 14, 5:29 AM · Restricted Project
gchatelet created D68942: [Alignment][NFC] Move and type functions from MathExtras to Alignment.
Mon, Oct 14, 5:29 AM · Restricted Project
gchatelet committed rG2a3f527cf8e7: Fix D68936 (authored by gchatelet).
Fix D68936
Mon, Oct 14, 2:30 AM
gchatelet committed rL374761: Fix D68936.
Fix D68936
Mon, Oct 14, 2:30 AM
gchatelet added a comment to D68936: [Alignment][NFC] Support compile time constants.

This patch broke the build for MSVC, a fix is underway.

Mon, Oct 14, 2:27 AM · Restricted Project
gchatelet committed rG415df89e22ab: [Alignment][NFC] Support compile time constants (authored by gchatelet).
[Alignment][NFC] Support compile time constants
Mon, Oct 14, 2:09 AM
gchatelet closed D68936: [Alignment][NFC] Support compile time constants.
Mon, Oct 14, 2:09 AM · Restricted Project
gchatelet committed rL374758: [Alignment][NFC] Support compile time constants.
[Alignment][NFC] Support compile time constants
Mon, Oct 14, 2:02 AM
gchatelet updated the diff for D68936: [Alignment][NFC] Support compile time constants.
  • Address comments
Mon, Oct 14, 1:53 AM · Restricted Project
gchatelet created D68936: [Alignment][NFC] Support compile time constants.
Mon, Oct 14, 1:32 AM · Restricted Project

Fri, Oct 11

gchatelet accepted D68780: [llvm-exegesis] Show noise cluster in analysis output..
Fri, Oct 11, 1:36 AM · Restricted Project
gchatelet abandoned D68379: FunctionDecl::isThisDeclarationADefinition is useless in ProcessDeclAttribute.
Fri, Oct 11, 1:36 AM · Restricted Project
gchatelet abandoned D68701: Adds a isDefinitionKind to FunctionDecl.
Fri, Oct 11, 1:36 AM · Restricted Project

Thu, Oct 10

gchatelet committed rGff054b9e3230: [Alignment][NFC] Use llv::Align in GISelKnownBits (authored by gchatelet).
[Alignment][NFC] Use llv::Align in GISelKnownBits
Thu, Oct 10, 8:41 AM
gchatelet committed rL374369: [Alignment][NFC] Use llv::Align in GISelKnownBits.
[Alignment][NFC] Use llv::Align in GISelKnownBits
Thu, Oct 10, 8:40 AM
gchatelet closed D68786: [Alignment][NFC] Use llvm::Align in GISelKnownBits.
Thu, Oct 10, 8:40 AM · Restricted Project
gchatelet added a comment to D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment.

@courbet there's a slight difference in the way the field is serialized in the mir / ir format (hence not [NFC]) but there's no change in semantics.

Thu, Oct 10, 8:40 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D68786: [Alignment][NFC] Use llvm::Align in GISelKnownBits.
  • Address comments
Thu, Oct 10, 8:31 AM · Restricted Project
gchatelet created D68792: [Alignment] Migrate Attribute::getWith(Stack)Alignment.
Thu, Oct 10, 8:22 AM · Restricted Project, Restricted Project
gchatelet committed rG837a1b84ced6: [Alignment][NFC] Make VectorUtils uas llvm::Align (authored by gchatelet).
[Alignment][NFC] Make VectorUtils uas llvm::Align
Thu, Oct 10, 5:40 AM
gchatelet closed D68784: [Alignment][NFC] Make VectorUtils use llvm::Align.

Closed as rL374330

Thu, Oct 10, 5:40 AM · Restricted Project
gchatelet retitled D68786: [Alignment][NFC] Use llvm::Align in GISelKnownBits from [Alignment][NFC] Use llv::Align in GISelKnownBits to [Alignment][NFC] Use llvm::Align in GISelKnownBits.
Thu, Oct 10, 5:40 AM · Restricted Project
gchatelet committed rL374330: [Alignment][NFC] Make VectorUtils uas llvm::Align.
[Alignment][NFC] Make VectorUtils uas llvm::Align
Thu, Oct 10, 5:32 AM
gchatelet retitled D68784: [Alignment][NFC] Make VectorUtils use llvm::Align from [Alignment][NFC] Make VectorUtils uas llvm::Align to [Alignment][NFC] Make VectorUtils use llvm::Align.
Thu, Oct 10, 5:32 AM · Restricted Project
gchatelet created D68786: [Alignment][NFC] Use llvm::Align in GISelKnownBits.
Thu, Oct 10, 5:31 AM · Restricted Project
gchatelet created D68784: [Alignment][NFC] Make VectorUtils use llvm::Align.
Thu, Oct 10, 4:44 AM · Restricted Project
gchatelet added inline comments to D68780: [llvm-exegesis] Show noise cluster in analysis output..
Thu, Oct 10, 4:33 AM · Restricted Project
gchatelet updated the diff for D68028: [clang] Add no_builtin attribute.
  • Fix missing rename
Thu, Oct 10, 2:31 AM · Restricted Project
gchatelet updated the diff for D68028: [clang] Add no_builtin attribute.
  • Address comments
Thu, Oct 10, 2:31 AM · Restricted Project
gchatelet added inline comments to D68398: [Alignment][NFC] Value::getPointerAlignment returns MaybeAlign.
Thu, Oct 10, 1:44 AM · Restricted Project
gchatelet added a comment to D68028: [clang] Add no_builtin attribute.

It should be ready to submit, @aaron.ballman @courbet can you take a final look?

Thu, Oct 10, 1:07 AM · Restricted Project
gchatelet updated the diff for D68028: [clang] Add no_builtin attribute.
  • rebase
Thu, Oct 10, 12:48 AM · Restricted Project

Wed, Oct 9

gchatelet updated the diff for D68028: [clang] Add no_builtin attribute.
  • Remove leftovers
Wed, Oct 9, 9:40 AM · Restricted Project
gchatelet updated the diff for D68028: [clang] Add no_builtin attribute.
  • Address aaron ballman comments
  • Checks function name validity and errors when passed 0 argument.
  • Update documentation and rebase
  • Rewrote mergeNoBuiltinAttr
  • Address comments
Wed, Oct 9, 9:40 AM · Restricted Project
gchatelet accepted D68703: [llvm-exegesis] Ensure that ExecutableFunction are aligned..
Wed, Oct 9, 7:11 AM · Restricted Project
gchatelet added inline comments to D68703: [llvm-exegesis] Ensure that ExecutableFunction are aligned..
Wed, Oct 9, 6:42 AM · Restricted Project
gchatelet added inline comments to D68028: [clang] Add no_builtin attribute.
Wed, Oct 9, 6:08 AM · Restricted Project
gchatelet created D68701: Adds a isDefinitionKind to FunctionDecl.
Wed, Oct 9, 6:08 AM · Restricted Project
gchatelet accepted D68692: [llvm-exegesis][NFC] Remove extra `llvm::` qualifications..
Wed, Oct 9, 4:45 AM · Restricted Project
gchatelet accepted D68687: [llvm-exegesis][NFC] Remove extra `llvm::` qualifications..
Wed, Oct 9, 3:05 AM · Restricted Project
gchatelet accepted D68646: [llvm-exegesis] Explore LEA addressing modes..
Wed, Oct 9, 1:15 AM · Restricted Project
gchatelet added inline comments to D68398: [Alignment][NFC] Value::getPointerAlignment returns MaybeAlign.
Wed, Oct 9, 1:15 AM · Restricted Project

Tue, Oct 8

gchatelet accepted D68642: [llvm-exegesis] Add options to SnippetGenerator..
Tue, Oct 8, 7:29 AM · Restricted Project
gchatelet accepted D68629: [llvm-exegesis] Finish plumbing the `Config` field..
Tue, Oct 8, 2:03 AM · Restricted Project
gchatelet added inline comments to D68028: [clang] Add no_builtin attribute.
Tue, Oct 8, 2:00 AM · Restricted Project
gchatelet added inline comments to D68629: [llvm-exegesis] Finish plumbing the `Config` field..
Tue, Oct 8, 1:14 AM · Restricted Project

Thu, Oct 3

gchatelet committed rGd1f23bd2250b: Revert "[Alignment][NFC] Allow constexpr Align" (authored by gchatelet).
Revert "[Alignment][NFC] Allow constexpr Align"
Thu, Oct 3, 8:56 AM
gchatelet added a reverting change for rGb3af236fb5fc: [Alignment][NFC] Allow constexpr Align: rGd1f23bd2250b: Revert "[Alignment][NFC] Allow constexpr Align".
Thu, Oct 3, 8:56 AM
gchatelet added a comment to D68329: [Alignment][NFC] Allow constexpr Align.

This breaks building with gcc 5.3 (the system compiler on Ubuntu Xenial LTS), and supported by LLVM per https://llvm.org/docs/GettingStarted.html#getting-a-modern-host-c-toolchain

Thx for reporting, from stackoverflow it looks like a GCC bug.
I'm not sure it can be fixed so I'll revert the patch for now.

Thu, Oct 3, 8:56 AM · Restricted Project
gchatelet committed rL373619: Revert "[Alignment][NFC] Allow constexpr Align".
Revert "[Alignment][NFC] Allow constexpr Align"
Thu, Oct 3, 8:52 AM
gchatelet added a comment to D68329: [Alignment][NFC] Allow constexpr Align.

This breaks building with gcc 5.3 (the system compiler on Ubuntu Xenial LTS), and supported by LLVM per https://llvm.org/docs/GettingStarted.html#getting-a-modern-host-c-toolchain

Thu, Oct 3, 8:47 AM · Restricted Project
gchatelet created D68398: [Alignment][NFC] Value::getPointerAlignment returns MaybeAlign.
Thu, Oct 3, 8:30 AM · Restricted Project
gchatelet committed rGd400d4515053: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned) (authored by gchatelet).
[Alignment][NFC] Remove StoreInst::setAlignment(unsigned)
Thu, Oct 3, 6:17 AM
gchatelet committed rL373595: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned).
[Alignment][NFC] Remove StoreInst::setAlignment(unsigned)
Thu, Oct 3, 6:16 AM
gchatelet closed D68268: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned).
Thu, Oct 3, 6:15 AM · Restricted Project, Restricted Project
gchatelet committed rGc79099e0f44d: [Alignment][Clang][NFC] Add CharUnits::getAsAlign (authored by gchatelet).
[Alignment][Clang][NFC] Add CharUnits::getAsAlign
Thu, Oct 3, 6:00 AM
gchatelet committed rL373592: [Alignment][Clang][NFC] Add CharUnits::getAsAlign.
[Alignment][Clang][NFC] Add CharUnits::getAsAlign
Thu, Oct 3, 5:58 AM
gchatelet closed D68274: [Alignment][Clang][NFC] Add CharUnits::getAsAlign.
Thu, Oct 3, 5:58 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D68274: [Alignment][Clang][NFC] Add CharUnits::getAsAlign.
  • Address comments
Thu, Oct 3, 5:46 AM · Restricted Project, Restricted Project
gchatelet added inline comments to D68274: [Alignment][Clang][NFC] Add CharUnits::getAsAlign.
Thu, Oct 3, 5:46 AM · Restricted Project, Restricted Project
gchatelet added inline comments to D68268: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned).
Thu, Oct 3, 5:38 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D68268: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned).
  • Address comments
Thu, Oct 3, 5:28 AM · Restricted Project, Restricted Project
gchatelet committed rGb3af236fb5fc: [Alignment][NFC] Allow constexpr Align (authored by gchatelet).
[Alignment][NFC] Allow constexpr Align
Thu, Oct 3, 3:52 AM
gchatelet committed rL373580: [Alignment][NFC] Allow constexpr Align.
[Alignment][NFC] Allow constexpr Align
Thu, Oct 3, 3:52 AM
gchatelet closed D68329: [Alignment][NFC] Allow constexpr Align.
Thu, Oct 3, 3:52 AM · Restricted Project
gchatelet added inline comments to D68028: [clang] Add no_builtin attribute.
Thu, Oct 3, 2:30 AM · Restricted Project
gchatelet created D68379: FunctionDecl::isThisDeclarationADefinition is useless in ProcessDeclAttribute.
Thu, Oct 3, 2:13 AM · Restricted Project
gchatelet accepted D68375: [llvm-exegesis][NFC] Rename ExegesisTarget::decrementLoopCounterAndLoop().
Thu, Oct 3, 12:53 AM · Restricted Project

Wed, Oct 2

gchatelet added inline comments to D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned).
Wed, Oct 2, 4:30 AM · Restricted Project, Restricted Project
gchatelet created D68329: [Alignment][NFC] Allow constexpr Align.
Wed, Oct 2, 4:28 AM · Restricted Project

Tue, Oct 1

gchatelet created D68274: [Alignment][Clang][NFC] Add CharUnits::getAsAlign.
Tue, Oct 1, 7:37 AM · Restricted Project, Restricted Project
Herald added a reviewer for D68268: [Alignment][NFC] Remove StoreInst::setAlignment(unsigned): bollu.
Tue, Oct 1, 6:07 AM · Restricted Project, Restricted Project
gchatelet added a comment to D68028: [clang] Add no_builtin attribute.

thx @aaron.ballman , I'm waiting for your reply before uploading the new patch (some of my comments won't have the accompanying code update sorry)

Tue, Oct 1, 5:22 AM · Restricted Project
gchatelet accepted D68262: [llvm-exegesis][NFC] Refactor X86 tests fixtures into a base class..

Thx for working on this!

Tue, Oct 1, 2:16 AM · Restricted Project

Mon, Sep 30

gchatelet closed D68122: [Alignment][NFC] Remove unneeded llvm:: scoping on Align types.

Submitted as rL373081

Mon, Sep 30, 7:23 AM · Restricted Project
gchatelet added inline comments to D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned).
Mon, Sep 30, 7:21 AM · Restricted Project, Restricted Project
gchatelet accepted D68217: [llvm-exegesis][NFC] Move BenchmarkFailure to own file..
Mon, Sep 30, 6:50 AM · Restricted Project
gchatelet added inline comments to D68217: [llvm-exegesis][NFC] Move BenchmarkFailure to own file..
Mon, Sep 30, 6:38 AM · Restricted Project
gchatelet committed rGab11b9188d75: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned) (authored by gchatelet).
[Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)
Mon, Sep 30, 6:34 AM
gchatelet committed rL373207: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned).
[Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)
Mon, Sep 30, 6:33 AM
gchatelet closed D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned).
Mon, Sep 30, 6:33 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned).
  • Address comments
Mon, Sep 30, 5:54 AM · Restricted Project, Restricted Project
gchatelet accepted D68212: [llvm-exegesis][NFC] Refactor snippet file reading out of tool main..
Mon, Sep 30, 5:47 AM · Restricted Project
gchatelet added a comment to D68142: [Alignment][NFC] Remove LoadInst::setAlignment(unsigned).

This patch broke polly, I'm working on a fix.

Mon, Sep 30, 4:22 AM · Restricted Project, Restricted Project
gchatelet committed rG725efb35c785: [Alignment] Fix polly build (authored by gchatelet).
[Alignment] Fix polly build
Mon, Sep 30, 4:15 AM
gchatelet committed rL373199: [Alignment] Fix polly build.
[Alignment] Fix polly build
Mon, Sep 30, 4:12 AM
gchatelet added a comment to D68142: [Alignment][NFC] Remove LoadInst::setAlignment(unsigned).

This patch broke polly, I'm working on a fix.

Mon, Sep 30, 3:57 AM · Restricted Project, Restricted Project
gchatelet committed rG02c19658ffe9: [Alignment][NFC] Adding a max function. (authored by gchatelet).
[Alignment][NFC] Adding a max function.
Mon, Sep 30, 3:02 AM
gchatelet committed rL373196: [Alignment][NFC] Adding a max function..
[Alignment][NFC] Adding a max function.
Mon, Sep 30, 3:02 AM
gchatelet closed D68201: [Alignment][NFC] Adding a max function..
Mon, Sep 30, 3:01 AM · Restricted Project
gchatelet added a comment to D68201: [Alignment][NFC] Adding a max function..

Thx!

Mon, Sep 30, 2:46 AM · Restricted Project
gchatelet updated the diff for D68201: [Alignment][NFC] Adding a max function..
  • Address comments
Mon, Sep 30, 2:41 AM · Restricted Project
gchatelet committed rG17380227e830: [Alignment][NFC] Remove LoadInst::setAlignment(unsigned) (authored by gchatelet).
[Alignment][NFC] Remove LoadInst::setAlignment(unsigned)
Mon, Sep 30, 2:37 AM