Page MenuHomePhabricator

gchatelet (Guillaume Chatelet)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2017, 7:28 AM (201 w, 6 d)

Recent Activity

Yesterday

gchatelet accepted D100743: [llvm-exegesis] Honor -mcpu in analysis mode..
Mon, Apr 19, 1:01 AM · Restricted Project

Sun, Apr 18

gchatelet requested review of D100732: [libc] Enhance ArrayRef + unittests.
Sun, Apr 18, 12:58 PM · Restricted Project

Fri, Apr 16

gchatelet committed rG2bfe15810def: [libc] Fix wrongly deduced type (authored by gchatelet).
[libc] Fix wrongly deduced type
Fri, Apr 16, 3:00 PM
gchatelet committed rG7e075ad0b261: [libc] Add endianness support (authored by gchatelet).
[libc] Add endianness support
Fri, Apr 16, 2:35 PM
gchatelet closed D100571: [libc] Add endianness support.
Fri, Apr 16, 2:35 PM · Restricted Project
gchatelet added a comment to D100631: [libc] Extends the testing framework to support typed test.

Note that Fuchsia does not block us from using this feature in LLVM libc source tree as only ctype tests from LLVM libc run in Fuchsia.

Fri, Apr 16, 2:26 PM · Restricted Project
gchatelet committed rG7c02dc22e487: [libc] Extends the testing framework to support typed test (authored by gchatelet).
[libc] Extends the testing framework to support typed test
Fri, Apr 16, 2:22 PM
gchatelet closed D100631: [libc] Extends the testing framework to support typed test.
Fri, Apr 16, 2:21 PM · Restricted Project
gchatelet updated the summary of D100631: [libc] Extends the testing framework to support typed test.
Fri, Apr 16, 2:09 PM · Restricted Project
gchatelet added a comment to D100631: [libc] Extends the testing framework to support typed test.

I'll check with zxtest maintainers.

Looks like we already have a few use cases for TYPED_TEST in Fuchsia, this is tracked as fxbug.dev/62890.

Fri, Apr 16, 2:04 PM · Restricted Project
gchatelet updated the diff for D100631: [libc] Extends the testing framework to support typed test.
  • Added documentation
Fri, Apr 16, 1:53 PM · Restricted Project
gchatelet updated the diff for D100631: [libc] Extends the testing framework to support typed test.
  • Recover ParamType from PRETTY_FUNCTION instead of RTTI or user provided type name.
Fri, Apr 16, 1:49 PM · Restricted Project
gchatelet added a comment to D100631: [libc] Extends the testing framework to support typed test.

While I am not opposed to this, I want to learn the usefulness of this feature. IIUC, this limits to a single ParamType - as in a uni-dimensional type variance. We have examples in math functions where there is two-dimensional type variance. I am not sure the feature added in this patch can help with it. For such cases, have used template test classes and helper macros to list the various combination of tests: https://github.com/llvm/llvm-project/blob/main/libc/test/src/math/RoundToIntegerTest.h.

Fri, Apr 16, 9:52 AM · Restricted Project
gchatelet added inline comments to D100646: [libc] Add a set of elementary operations.
Fri, Apr 16, 7:13 AM · Restricted Project
gchatelet requested review of D100646: [libc] Add a set of elementary operations.
Fri, Apr 16, 6:52 AM · Restricted Project
gchatelet added a comment to D100571: [libc] Add endianness support.

Thx for the suggestion, I didn't go with explicit member function as it would allow for integer promotion.
In the case of endianness we want to make sure we only accept one of uint8_t, uint16_t, uint32_t, uint64_t and no other type.
I've added the symmetric functions as you suggested.

Fri, Apr 16, 6:18 AM · Restricted Project
gchatelet updated the diff for D100571: [libc] Add endianness support.
  • Simplify tests
Fri, Apr 16, 6:17 AM · Restricted Project
gchatelet updated the diff for D100571: [libc] Add endianness support.
  • Add tests and remove macros
Fri, Apr 16, 6:01 AM · Restricted Project
gchatelet updated the diff for D100631: [libc] Extends the testing framework to support typed test.
  • Fixed base revision
Fri, Apr 16, 2:48 AM · Restricted Project
gchatelet updated the diff for D100631: [libc] Extends the testing framework to support typed test.
  • Fix typo and static assert message.
Fri, Apr 16, 2:45 AM · Restricted Project
gchatelet updated the summary of D100631: [libc] Extends the testing framework to support typed test.
Fri, Apr 16, 2:41 AM · Restricted Project
gchatelet requested review of D100631: [libc] Extends the testing framework to support typed test.
Fri, Apr 16, 2:37 AM · Restricted Project
gchatelet committed rG907b52d1a719: [libc] Fix typo (authored by gchatelet).
[libc] Fix typo
Fri, Apr 16, 1:09 AM
gchatelet added a comment to D100569: [libc] Add slice/take/drop methods to ArrayRef.

Should we start to add tests?

Sorry I missed this. We can add tests now in a different pass.

Fri, Apr 16, 12:58 AM · Restricted Project
gchatelet committed rGf6b656853644: [libc] Add slice/take/drop methods to ArrayRef (authored by gchatelet).
[libc] Add slice/take/drop methods to ArrayRef
Fri, Apr 16, 12:55 AM
gchatelet closed D100569: [libc] Add slice/take/drop methods to ArrayRef.
Fri, Apr 16, 12:55 AM · Restricted Project
gchatelet added inline comments to D100569: [libc] Add slice/take/drop methods to ArrayRef.
Fri, Apr 16, 12:53 AM · Restricted Project
gchatelet updated the diff for D100569: [libc] Add slice/take/drop methods to ArrayRef.
  • Fix argument capitalization
Fri, Apr 16, 12:53 AM · Restricted Project

Thu, Apr 15

gchatelet committed rG03375089f5a6: [libc] Add index operator[] to StringView (authored by gchatelet).
[libc] Add index operator[] to StringView
Thu, Apr 15, 8:56 AM
gchatelet updated subscribers of D100571: [libc] Add endianness support.
Thu, Apr 15, 8:54 AM · Restricted Project
gchatelet updated the diff for D100571: [libc] Add endianness support.
  • Added missing modification to CMakeLists.txt
Thu, Apr 15, 8:50 AM · Restricted Project
gchatelet added a comment to D100571: [libc] Add endianness support.

Let me know if you want this header to live somewhere else, or if you had other plans in mind.

Thu, Apr 15, 8:46 AM · Restricted Project
gchatelet added a comment to D100569: [libc] Add slice/take/drop methods to ArrayRef.

I removed the various asserts from the original code as we did for StringView.
Should we start to add tests?

Thu, Apr 15, 8:42 AM · Restricted Project
gchatelet requested review of D100571: [libc] Add endianness support.
Thu, Apr 15, 8:39 AM · Restricted Project
gchatelet requested review of D100569: [libc] Add slice/take/drop methods to ArrayRef.
Thu, Apr 15, 8:34 AM · Restricted Project

Tue, Apr 13

gchatelet accepted D99098: Remove deprecated member functions (NFC).

Thank you for the clean up. Really appreciate it.
Before submitting the patch did you check that there are no users in experimental targets? (ARC, VE)

Tue, Apr 13, 12:08 PM · Restricted Project

Tue, Mar 30

gchatelet committed rG77d81c2270c6: [libc] Fix msan/asan memcpy reentrancy (authored by gchatelet).
[libc] Fix msan/asan memcpy reentrancy
Tue, Mar 30, 8:29 AM
gchatelet closed D99598: [libc] Fix msan/asan memcpy reentrancy.
Tue, Mar 30, 8:29 AM · Restricted Project
gchatelet requested review of D99598: [libc] Fix msan/asan memcpy reentrancy.
Tue, Mar 30, 7:58 AM · Restricted Project

Feb 24 2021

gchatelet accepted D97363: [libc][NFC] Remove headergen for the cacheline size macro..
Feb 24 2021, 12:34 AM · Restricted Project
gchatelet accepted D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg..

LGTM as well

Feb 24 2021, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2021

gchatelet added a comment to D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg..

Looks like you didn't update the .bc reader/writer and the .ll printer/parser.

The instructions already had alignment support added to the type constructor and IR/BC in prior changes by gchatelet -- this is just updating the IRBuilder constructor.

Feb 23 2021, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
gchatelet added inline comments to D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg..
Feb 23 2021, 8:10 AM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2021

gchatelet committed rG74916008a87d: Fix errors in distributions (authored by gchatelet).
Fix errors in distributions
Feb 11 2021, 1:55 PM
gchatelet committed rG8f3518e69bee: Fix incorrect indentation in LangRef.rst (authored by gchatelet).
Fix incorrect indentation in LangRef.rst
Feb 11 2021, 12:51 PM
gchatelet committed rGca052adf07f0: Fix incorrect indentation in LangRef.rst (authored by gchatelet).
Fix incorrect indentation in LangRef.rst
Feb 11 2021, 12:34 PM
gchatelet accepted D96498: Fix exegesis build on aarch64-windows-msvc host.
Feb 11 2021, 12:22 PM · Restricted Project
gchatelet added a comment to D83465: Encode alignment attribute for `atomicrmw`.

Thx @jyknight ! Let me know if you prefer me to push it ( and D87443 ).
If you do push them please mention the two reviews (D87443 and D83465) in the description so we can track everything and abandon these changes.

Feb 11 2021, 12:21 PM · Restricted Project
gchatelet added a comment to D83465: Encode alignment attribute for `atomicrmw`.

Thx @jyknight ! Let me know if you prefer me to push it ( and D87443 ).
If you do push them please mention the two reviews (D87443 and D83465) in the description so we can track everything and abandon these changes.

Feb 11 2021, 12:20 PM · Restricted Project
gchatelet edited reviewers for D96498: Fix exegesis build on aarch64-windows-msvc host, added: gchatelet; removed: courbet.
Feb 11 2021, 7:43 AM · Restricted Project
gchatelet added inline comments to D96498: Fix exegesis build on aarch64-windows-msvc host.
Feb 11 2021, 7:43 AM · Restricted Project

Feb 5 2021

gchatelet abandoned D82876: [Alignment][NFC] Migrate TargetTransformInfo::allowsMisalignedMemoryAccesses to Align.

@gchatelet Abandon after D96097 ?

Feb 5 2021, 1:21 PM · Restricted Project
gchatelet committed rG79b3ab725d31: [NFC] Simplify expression (authored by gchatelet).
[NFC] Simplify expression
Feb 5 2021, 2:17 AM
gchatelet committed rG4b15156dca32: [NFC] inline variable (authored by gchatelet).
[NFC] inline variable
Feb 5 2021, 2:17 AM
gchatelet added a comment to D96097: [TargetLowering] Use Align in allowsMisalignedMemoryAccesses..

I had a similar patch - D82876 - but it never went through...
Thx for working on this!

Feb 5 2021, 12:42 AM · Restricted Project

Feb 1 2021

gchatelet accepted D94898: [llvm-exegesis] Ignore instructions using custom inserter.

LGTM thx @qiucf

Feb 1 2021, 1:13 AM · Restricted Project

Jan 29 2021

gchatelet accepted D92236: [LIBC] Add optimized memcpy routine for AArch64.

Hey Andre, my apologies for the lag. Answers inlined

Jan 29 2021, 8:17 AM · Restricted Project

Jan 25 2021

gchatelet accepted D95203: [CMake][libc] Don't do CPU feature detection when cross-compiling.
Jan 25 2021, 4:40 AM · Restricted Project
gchatelet added a comment to D95118: [CMake][libc] Distinguish compiler and run failures.

Thx!

Jan 25 2021, 3:13 AM · Restricted Project

Jan 19 2021

gchatelet committed rGe517dff50a4f: [libc][NFC] remove dependency on non standard ssize_t (authored by gchatelet).
[libc][NFC] remove dependency on non standard ssize_t
Jan 19 2021, 12:14 AM
gchatelet closed D94760: [libc][NFC] remove dependency on non standard ssize_t.
Jan 19 2021, 12:14 AM · Restricted Project
gchatelet committed rGd4bb3ef53276: [libc][NFC] Remove dead code (authored by gchatelet).
[libc][NFC] Remove dead code
Jan 19 2021, 12:12 AM

Jan 15 2021

gchatelet updated the diff for D94760: [libc][NFC] remove dependency on non standard ssize_t.
  • buffer values are never modified so we can use char instead of unsigned char.
Jan 15 2021, 7:42 AM · Restricted Project
gchatelet committed rG5bf47e142b6e: [libc] CopyAlignedBlocks can now specify alignment on top of block size (authored by gchatelet).
[libc] CopyAlignedBlocks can now specify alignment on top of block size
Jan 15 2021, 7:32 AM
gchatelet closed D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.
Jan 15 2021, 7:32 AM · Restricted Project
gchatelet added a comment to D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.

Eh you beat me to it. Had a similar patch I've been measuring and testing. Your's is more complete though :)

LGTM.

Jan 15 2021, 7:30 AM · Restricted Project
gchatelet requested review of D94770: [libc] CopyAlignedBlocks can now specify alignment on top of block size.
Jan 15 2021, 5:43 AM · Restricted Project
gchatelet requested review of D94760: [libc][NFC] remove dependency on non standard ssize_t.
Jan 15 2021, 3:10 AM · Restricted Project
gchatelet committed rGa10300a2b27c: [libc] Allow customization of memcpy via flags. (authored by gchatelet).
[libc] Allow customization of memcpy via flags.
Jan 15 2021, 1:27 AM
gchatelet closed D94692: [libc] Allow customization of memcpy via flags..
Jan 15 2021, 1:27 AM · Restricted Project
gchatelet updated the diff for D94692: [libc] Allow customization of memcpy via flags..
  • Address comments
Jan 15 2021, 1:24 AM · Restricted Project

Jan 14 2021

gchatelet requested review of D94692: [libc] Allow customization of memcpy via flags..
Jan 14 2021, 7:53 AM · Restricted Project

Jan 13 2021

gchatelet committed rGab577807165c: [libc] Refresh benchmark progress bar when needed. (authored by gchatelet).
[libc] Refresh benchmark progress bar when needed.
Jan 13 2021, 6:07 AM

Jan 12 2021

gchatelet accepted D93195: [libc] Add memmove implementation..

LGTM, can you please wait for @sivachandra answer about using assert in code before submitting? Thx!

Jan 12 2021, 3:46 AM · Restricted Project

Jan 11 2021

gchatelet requested changes to D93195: [libc] Add memmove implementation..

My apologies for the late reply. I've made a bunch of comments.

Jan 11 2021, 5:20 AM · Restricted Project

Jan 6 2021

gchatelet committed rGaa9db51ef69f: [libc] Align src buffer instead of dst buffer (authored by gchatelet).
[libc] Align src buffer instead of dst buffer
Jan 6 2021, 4:06 AM
gchatelet closed D93457: [libc] Align src buffer instead of dst buffer.
Jan 6 2021, 4:05 AM · Restricted Project
gchatelet committed rG223a6f94c59c: [libc] remove modulo from CircularArrayRef iterator (authored by gchatelet).
[libc] remove modulo from CircularArrayRef iterator
Jan 6 2021, 4:04 AM
gchatelet added a comment to D93457: [libc] Align src buffer instead of dst buffer.

Sure, LGTM. What is the usual convention for Libc reviewing? Should I 'accept revision' if I agree with it even though I'm not a maintainer?

Jan 6 2021, 3:20 AM · Restricted Project
gchatelet added a reviewer for D93457: [libc] Align src buffer instead of dst buffer: avieira.
Jan 6 2021, 2:10 AM · Restricted Project
gchatelet added a comment to D93457: [libc] Align src buffer instead of dst buffer.

Hi Guillaume,

Sorry for the late reply, I was looking at some other things and then holidays happened. I started looking at making some changes to CopyAlignedBlocks just like we discussed earlier. One of them is this one and I noticed this makes the MemcpyUtilsTest.CopyAlignedBlocks fail in libc_string_unittests. Specifically the ones that test destination misalignment. It seems the testing infrastructure keeps track of what bytes were read and written. I checked and making the source the misaligned input and switching the read and written expected traces makes it passs. Which makes sense I guess.

Would be good to make the change at the same time though.

Jan 6 2021, 2:10 AM · Restricted Project
gchatelet updated the diff for D93457: [libc] Align src buffer instead of dst buffer.
  • Address comments and rebase
Jan 6 2021, 2:08 AM · Restricted Project

Jan 5 2021

gchatelet edited reviewers for D93457: [libc] Align src buffer instead of dst buffer, added: courbet; removed: avieira, sivachandra.
Jan 5 2021, 6:55 AM · Restricted Project

Dec 17 2020

gchatelet added inline comments to D92236: [LIBC] Add optimized memcpy routine for AArch64.
Dec 17 2020, 8:42 AM · Restricted Project
gchatelet added a comment to D93210: [libc] revamp memory function benchmark.

@sivachandra I'll submit this as is. Let me know if you have any concerns and we can amend it in a follow up patch.

Sorry, I am no expert here so I just kept silent while @courbet was steering the review. LGTM.

Dec 17 2020, 8:41 AM · Restricted Project
gchatelet added inline comments to D92236: [LIBC] Add optimized memcpy routine for AArch64.
Dec 17 2020, 6:02 AM · Restricted Project
gchatelet requested review of D93457: [libc] Align src buffer instead of dst buffer.
Dec 17 2020, 5:58 AM · Restricted Project
gchatelet committed rGdeae7e982a3b: [libc] revamp memory function benchmark (authored by gchatelet).
[libc] revamp memory function benchmark
Dec 17 2020, 5:24 AM
gchatelet closed D93210: [libc] revamp memory function benchmark.
Dec 17 2020, 5:24 AM · Restricted Project
gchatelet added a comment to D93210: [libc] revamp memory function benchmark.

@sivachandra I'll submit this as is. Let me know if you have any concerns and we can amend it in a follow up patch.

Dec 17 2020, 5:11 AM · Restricted Project
gchatelet added inline comments to D93210: [libc] revamp memory function benchmark.
Dec 17 2020, 5:05 AM · Restricted Project
gchatelet updated the diff for D93210: [libc] revamp memory function benchmark.

rebasing

Dec 17 2020, 5:05 AM · Restricted Project
gchatelet updated the diff for D93210: [libc] revamp memory function benchmark.
  • Address comments
Dec 17 2020, 5:04 AM · Restricted Project

Dec 16 2020

gchatelet updated the diff for D93210: [libc] revamp memory function benchmark.
  • Address comments and fix naming style
Dec 16 2020, 2:07 AM · Restricted Project

Dec 14 2020

gchatelet added inline comments to D82134: [libc] Add strcmp implementation..
Dec 14 2020, 8:19 AM · Restricted Project
gchatelet added a comment to D82134: [libc] Add strcmp implementation..

The granularity of ARMv8.3 PAC is 16 byte. Can you read an invalid address?

Dec 14 2020, 6:59 AM · Restricted Project
gchatelet requested review of D93210: [libc] revamp memory function benchmark.
Dec 14 2020, 6:41 AM · Restricted Project
gchatelet added inline comments to D82134: [libc] Add strcmp implementation..
Dec 14 2020, 1:06 AM · Restricted Project
gchatelet accepted D93009: [libc] Add memcmp implementation..
Dec 14 2020, 12:53 AM · Restricted Project

Dec 7 2020

gchatelet added inline comments to D92236: [LIBC] Add optimized memcpy routine for AArch64.
Dec 7 2020, 6:47 AM · Restricted Project