Page MenuHomePhabricator

pzheng (Pengxuan Zheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2016, 1:53 PM (135 w, 6 d)

Recent Activity

Wed, Jun 26

pzheng committed rG4030631bfa24: [cmake] Allow config.guess to be run with MSYS on Windows (authored by pzheng).
[cmake] Allow config.guess to be run with MSYS on Windows
Wed, Jun 26, 3:09 PM
pzheng committed rL364485: [cmake] Allow config.guess to be run with MSYS on Windows.
[cmake] Allow config.guess to be run with MSYS on Windows
Wed, Jun 26, 3:08 PM
pzheng closed D63834: [cmake] Allow config.guess to be run with MSYS on Windows.
Wed, Jun 26, 3:07 PM · Restricted Project
pzheng added a reviewer for D63834: [cmake] Allow config.guess to be run with MSYS on Windows: compnerd.
Wed, Jun 26, 11:39 AM · Restricted Project
pzheng created D63834: [cmake] Allow config.guess to be run with MSYS on Windows.
Wed, Jun 26, 11:39 AM · Restricted Project

Jun 5 2019

pzheng committed rGe34d1a4e07b8: [cmake] Remove duplicate TestingSupport library for linking (authored by pzheng).
[cmake] Remove duplicate TestingSupport library for linking
Jun 5 2019, 12:42 PM
pzheng committed rL362637: [cmake] Remove duplicate TestingSupport library for linking.
[cmake] Remove duplicate TestingSupport library for linking
Jun 5 2019, 12:42 PM
pzheng closed D62924: [cmake] Remove duplicate TestingSupport library for linking.
Jun 5 2019, 12:42 PM · Restricted Project
pzheng added inline comments to D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests.
Jun 5 2019, 12:05 PM · Restricted Project, Restricted Project
pzheng added reviewers for D62924: [cmake] Remove duplicate TestingSupport library for linking: quantum, thakis, tlively.
Jun 5 2019, 12:01 PM · Restricted Project
pzheng created D62924: [cmake] Remove duplicate TestingSupport library for linking.
Jun 5 2019, 11:56 AM · Restricted Project

Apr 11 2019

pzheng committed rGd8ada681df24: [cmake] Fix dependency issue in TableGen (authored by pzheng).
[cmake] Fix dependency issue in TableGen
Apr 11 2019, 2:08 PM
pzheng committed rL358226: [cmake] Fix dependency issue in TableGen.
[cmake] Fix dependency issue in TableGen
Apr 11 2019, 2:08 PM
pzheng closed D60576: [cmake] Fix dependency issue in TableGen.
Apr 11 2019, 2:08 PM · Restricted Project
pzheng added a comment to D60576: [cmake] Fix dependency issue in TableGen.

Thanks for reviewing, aganea!

Apr 11 2019, 1:55 PM · Restricted Project
pzheng added reviewers for D60576: [cmake] Fix dependency issue in TableGen: aganea, smeenai.
Apr 11 2019, 1:31 PM · Restricted Project
pzheng created D60576: [cmake] Fix dependency issue in TableGen.
Apr 11 2019, 1:28 PM · Restricted Project

Apr 1 2019

pzheng added inline comments to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.
Apr 1 2019, 5:53 PM · Restricted Project, Restricted Project

Feb 7 2019

pzheng committed rL353458: [zorg] Update host compiler for reverse-iteration builder.
[zorg] Update host compiler for reverse-iteration builder
Feb 7 2019, 12:18 PM
pzheng closed D57917: [zorg] Update host compiler for reverse-iteration builder.
Feb 7 2019, 12:18 PM
pzheng added inline comments to D57917: [zorg] Update host compiler for reverse-iteration builder.
Feb 7 2019, 12:00 PM
pzheng updated the diff for D57917: [zorg] Update host compiler for reverse-iteration builder.

[zorg] Update host compiler for reverse-iteration builder

Feb 7 2019, 11:57 AM
pzheng added a reviewer for D57917: [zorg] Update host compiler for reverse-iteration builder: gkistanova.
Feb 7 2019, 11:25 AM
pzheng added reviewers for D57917: [zorg] Update host compiler for reverse-iteration builder: mgrang, jfb, kparzysz, zinob.
Feb 7 2019, 11:13 AM
pzheng created D57917: [zorg] Update host compiler for reverse-iteration builder.
Feb 7 2019, 11:11 AM
pzheng committed rL353441: [zorg] Update host compiler for polly-arm-linux builder.
[zorg] Update host compiler for polly-arm-linux builder
Feb 7 2019, 10:24 AM
pzheng closed D57865: [zorg] Update host compiler for polly-arm-linux builder.
Feb 7 2019, 10:24 AM

Feb 6 2019

pzheng added reviewers for D57865: [zorg] Update host compiler for polly-arm-linux builder: grosser, zinob, kparzysz, jfb, gkistanova.
Feb 6 2019, 4:31 PM
pzheng created D57865: [zorg] Update host compiler for polly-arm-linux builder.
Feb 6 2019, 4:23 PM

Apr 5 2018

pzheng committed rL329364: Update recipient list of AOSP builder.
Update recipient list of AOSP builder
Apr 5 2018, 4:57 PM

Oct 25 2017

pzheng committed rL316603: [zorg] Update status reporting of reverse-iteration builder.
[zorg] Update status reporting of reverse-iteration builder
Oct 25 2017, 12:37 PM
pzheng closed D39258: [zorg] Update status reporting of reverse-iteration builder.
Oct 25 2017, 12:37 PM

Oct 24 2017

pzheng created D39258: [zorg] Update status reporting of reverse-iteration builder.
Oct 24 2017, 1:56 PM

Sep 25 2017

pzheng committed rL314034: [zorg] Update the scheduler for the reverse iterator builder.
[zorg] Update the scheduler for the reverse iterator builder
Sep 25 2017, 5:06 AM
pzheng closed D38011: [zorg] Update the scheduler for the reverse iterator builder by committing rL314034: [zorg] Update the scheduler for the reverse iterator builder.
Sep 25 2017, 5:06 AM

Sep 21 2017

pzheng committed rL313914: [zorg] Add another build slave to the reverse iterator builder.
[zorg] Add another build slave to the reverse iterator builder
Sep 21 2017, 2:03 PM
pzheng closed D38152: [zorg] Add another build slave to the reverse iterator builder.
Sep 21 2017, 2:03 PM
pzheng added a comment to D38152: [zorg] Add another build slave to the reverse iterator builder.

Thanks for reviewing, Galina.

Sep 21 2017, 2:02 PM
pzheng added a comment to D38011: [zorg] Update the scheduler for the reverse iterator builder.

I have split the patch into two. Please review the other one too.
https://reviews.llvm.org/D38152

Sep 21 2017, 1:26 PM
pzheng created D38152: [zorg] Add another build slave to the reverse iterator builder.
Sep 21 2017, 1:25 PM
pzheng updated the diff for D38011: [zorg] Update the scheduler for the reverse iterator builder.
Sep 21 2017, 1:21 PM
pzheng updated the summary of D38011: [zorg] Update the scheduler for the reverse iterator builder.
Sep 21 2017, 1:20 PM

Sep 18 2017

pzheng created D38011: [zorg] Update the scheduler for the reverse iterator builder.
Sep 18 2017, 5:05 PM

Sep 8 2017

pzheng committed rL312829: [zorg] Reduce the number of concurrent jobs for AOSP build.
[zorg] Reduce the number of concurrent jobs for AOSP build
Sep 8 2017, 2:39 PM
pzheng closed D37641: [zorg] Reduce the number of concurrent jobs for AOSP build.
Sep 8 2017, 2:39 PM
pzheng created D37641: [zorg] Reduce the number of concurrent jobs for AOSP build.
Sep 8 2017, 2:33 PM

Aug 28 2017

pzheng committed rL311897: [zorg] Increase AOSP build timeout to 240s.
[zorg] Increase AOSP build timeout to 240s
Aug 28 2017, 10:37 AM
pzheng closed D37169: [zorg] Increase AOSP build timeout to 240s.
Aug 28 2017, 10:37 AM

Aug 25 2017

pzheng created D37169: [zorg] Increase AOSP build timeout to 240s.
Aug 25 2017, 4:00 PM

Aug 3 2017

pzheng added a comment to D36203: [zorg] Add buildbot with reverse iteration enabled.

@vleschuk, can you please update the buildbot master to make the changes live?

Aug 3 2017, 11:53 AM
pzheng committed rL309972: [zorg] Add buildbot with reverse iteration enabled.
[zorg] Add buildbot with reverse iteration enabled
Aug 3 2017, 11:51 AM
pzheng closed D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 3 2017, 11:50 AM
pzheng updated the diff for D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 3 2017, 11:44 AM
pzheng updated the summary of D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 3 2017, 11:43 AM
pzheng committed rL309971: [zorg] Add optional checkAll step to Polly buildbot.
[zorg] Add optional checkAll step to Polly buildbot
Aug 3 2017, 11:37 AM
pzheng closed D36277: [zorg] Add optional checkAll step to Polly buildbot.
Aug 3 2017, 11:37 AM
pzheng created D36277: [zorg] Add optional checkAll step to Polly buildbot.
Aug 3 2017, 11:30 AM
pzheng committed rL309970: [zorg] Remove test_polly_format step from Polly buildbot.
[zorg] Remove test_polly_format step from Polly buildbot
Aug 3 2017, 11:16 AM
pzheng closed D36276: [zorg] Remove test_polly_format step from Polly buildbot.
Aug 3 2017, 11:16 AM
pzheng created D36276: [zorg] Remove test_polly_format step from Polly buildbot.
Aug 3 2017, 11:11 AM

Aug 2 2017

pzheng added a comment to D36203: [zorg] Add buildbot with reverse iteration enabled.

@vleschuk is right that it is unclear why you change the Polly builder. I would suggest to motivate in the commit message that you modify the Polly builder to also include Polly into these builds!

Aug 2 2017, 12:10 PM
pzheng updated the summary of D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 2 2017, 12:08 PM
pzheng added inline comments to D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 2 2017, 10:58 AM

Aug 1 2017

pzheng added a reviewer for D36203: [zorg] Add buildbot with reverse iteration enabled: zinob.
Aug 1 2017, 6:02 PM
pzheng added a reviewer for D36203: [zorg] Add buildbot with reverse iteration enabled: gkistanova.
Aug 1 2017, 5:42 PM
pzheng created D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 1 2017, 5:41 PM

Jun 19 2017

pzheng committed rL305763: [test-release.sh] Enable Polly by default.
[test-release.sh] Enable Polly by default
Jun 19 2017, 6:05 PM
pzheng closed D34306: [test-release.sh] Enable Polly by default.
Jun 19 2017, 6:05 PM

Jun 16 2017

pzheng added a comment to D28712: [test-release.sh] Add Polly to the list of projects.

Here is the patch to enable Polly by default:
https://reviews.llvm.org/D34306

Jun 16 2017, 5:27 PM
pzheng created D34306: [test-release.sh] Enable Polly by default.
Jun 16 2017, 5:26 PM

Jan 26 2017

pzheng committed rL293233: Fix a typo in AOSP builder.
Fix a typo in AOSP builder
Jan 26 2017, 4:07 PM
pzheng committed rL293211: [zorg] Add AOSP builder.
[zorg] Add AOSP builder
Jan 26 2017, 1:51 PM
pzheng closed D29050: [zorg] Add AOSP builder.
Jan 26 2017, 1:50 PM
pzheng added a comment to D29050: [zorg] Add AOSP builder.

Thanks for explaining the usage of the manifest file. We will use the current manifest file for the AOSP master and won't sync the repo until a better one is found.

Jan 26 2017, 12:01 PM
pzheng added a comment to D29050: [zorg] Add AOSP builder.

I have already added "-Wno-error" in the flags used to build AOSP, but there are still many not suppressible. For example,

Jan 26 2017, 11:44 AM
pzheng added a comment to D29050: [zorg] Add AOSP builder.

I had a build of the AOSP release "android-7.1.1_r11" with the latest LLVM toolchain and noticed a lot of AOSP source code issues (compared to using the AOSP master branch) due to stricter compiler checks. Looks like many of the issues have already been fixed in AOSP mater but those fixes have not made it into the release yet. For now, I propose to use the AOSP master until a more "stable" release comes out.

Jan 26 2017, 11:27 AM

Jan 25 2017

pzheng updated the diff for D29050: [zorg] Add AOSP builder.

Added instructions for setting up build environment and downloading AOSP source.
Using PollyBuilder.getPollyBuildFactory to add steps for building LLVM.
Setting sync=False since we decided to use a AOSP release instead of the master. Also setting clean=False and patch=None for the same reason.

Jan 25 2017, 5:55 PM
pzheng added inline comments to D29050: [zorg] Add AOSP builder.
Jan 25 2017, 5:46 PM
pzheng added inline comments to D29050: [zorg] Add AOSP builder.
Jan 25 2017, 5:12 PM
pzheng added inline comments to D29050: [zorg] Add AOSP builder.
Jan 25 2017, 4:56 PM
pzheng added inline comments to D29050: [zorg] Add AOSP builder.
Jan 25 2017, 4:53 PM
pzheng added a comment to D29050: [zorg] Add AOSP builder.

Are you sure that you want to always be syncing AOSP? There is a good chance that the AOSP build could break for reasons beyond the control of the LLVM community. It might be better to pick a particular AOSP release to minimize those kinds of issues. One other potential problem is going to be the increasing presence of stricter warnings/errors from Clang. These can also cause issues with AOSP.

Thanks for bringing this up. These are indeed valid concerns. Can you please suggest an AOSP release for use with this buildbot?

Jan 25 2017, 11:51 AM

Jan 24 2017

pzheng added inline comments to D29050: [zorg] Add AOSP builder.
Jan 24 2017, 10:39 PM
pzheng added a comment to D29050: [zorg] Add AOSP builder.

Thanks for explaining how to setup the buildslave. Could you add the information (the link what to install, the need for java, the information which AOSP repo to checkout, ...) as comment to the AOSPBuilder?

Jan 24 2017, 10:31 PM
pzheng updated the diff for D29050: [zorg] Add AOSP builder.
Jan 24 2017, 4:55 PM
pzheng added a comment to D29050: [zorg] Add AOSP builder.

Here is the patch I use to enable building AOSP with a non-AOSP-version Clang.

Jan 24 2017, 3:52 PM
pzheng added inline comments to D29050: [zorg] Add AOSP builder.
Jan 24 2017, 3:48 PM
pzheng added a comment to D29050: [zorg] Add AOSP builder.

Thanks for reviewing the patch, Tobias. The AOSP source code repo is very large (over 50GB) and it takes hours to do a fresh checkout of the entire repo. Therefore, on the AOSP buildslave, I checkout the AOSP repo in advance and this is a one-time effort. After that, we can simply sync the AOSP repo (set sync=True) as necessary which only takes a few minutes. Detailed instructions for checking out AOSP is available at https://source.android.com/source/downloading.html

Jan 24 2017, 3:27 PM

Jan 23 2017

pzheng updated the diff for D29050: [zorg] Add AOSP builder.
Jan 23 2017, 5:14 PM
pzheng created D29050: [zorg] Add AOSP builder.
Jan 23 2017, 2:29 PM

Jan 17 2017

pzheng committed rL292323: [test-release.sh] Add Polly to the list of projects.
[test-release.sh] Add Polly to the list of projects
Jan 17 2017, 5:14 PM
pzheng closed D28712: [test-release.sh] Add Polly to the list of projects.
Jan 17 2017, 5:14 PM

Jan 16 2017

pzheng added a comment to D28712: [test-release.sh] Add Polly to the list of projects.

I agree that we should probably leave the default for Polly to be off since this is the first attempt to add it to the test release script and release testers may not be familiar with Polly. We can revisit turning it on by default in the future.

Jan 16 2017, 1:54 PM
pzheng updated the diff for D28712: [test-release.sh] Add Polly to the list of projects.

[test-release.sh] Add Polly to the list of projects

Jan 16 2017, 1:49 PM

Jan 13 2017

pzheng updated subscribers of D28712: [test-release.sh] Add Polly to the list of projects.
Jan 13 2017, 3:45 PM
pzheng added reviewers for D28712: [test-release.sh] Add Polly to the list of projects: zinob, grosser, hans.
Jan 13 2017, 3:43 PM
pzheng retitled D28712: [test-release.sh] Add Polly to the list of projects from to [test-release.sh] Add Polly to the list of projects.
Jan 13 2017, 3:39 PM

Jan 12 2017

pzheng committed rL291797: Revert test commit.
Revert test commit
Jan 12 2017, 11:34 AM
pzheng committed rL291793: This is a test commit for new account..
This is a test commit for new account.
Jan 12 2017, 11:16 AM

Jan 11 2017

pzheng added inline comments to D28493: [zorg] Add Polly builder for ARM target.
Jan 11 2017, 10:34 AM