Page MenuHomePhabricator

pzheng (Pengxuan Zheng)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2016, 1:53 PM (290 w, 1 d)

Recent Activity

Today

pzheng committed rGb5e49cdea971: [LLD][COFF] Ignore /kernel flag (authored by pzheng).
[LLD][COFF] Ignore /kernel flag
Fri, Jul 1, 10:03 AM · Restricted Project
pzheng closed D128238: [LLD][COFF] Ignore /kernel flag.
Fri, Jul 1, 10:03 AM · Restricted Project, Restricted Project
pzheng added a comment to D128238: [LLD][COFF] Ignore /kernel flag.

Thanks!

Fri, Jul 1, 10:02 AM · Restricted Project, Restricted Project

Tue, Jun 28

pzheng added a comment to D128238: [LLD][COFF] Ignore /kernel flag.

Thanks, @thieta! @hans, please let me know if there is anything I need to address.

Tue, Jun 28, 9:52 AM · Restricted Project, Restricted Project
pzheng committed rGb5b7e3adcdcd: [llvm-lib] Ignore /SUBSYSTEM flag (authored by pzheng).
[llvm-lib] Ignore /SUBSYSTEM flag
Tue, Jun 28, 9:47 AM · Restricted Project, Restricted Project
pzheng closed D128458: [llvm-lib] Ignore /SUBSYSTEM flag.
Tue, Jun 28, 9:47 AM · Restricted Project, Restricted Project
pzheng added a comment to D128458: [llvm-lib] Ignore /SUBSYSTEM flag.

Thanks!

Tue, Jun 28, 9:45 AM · Restricted Project, Restricted Project

Thu, Jun 23

pzheng requested review of D128458: [llvm-lib] Ignore /SUBSYSTEM flag.
Thu, Jun 23, 12:46 PM · Restricted Project, Restricted Project

Tue, Jun 21

pzheng retitled D128238: [LLD][COFF] Ignore /kernel flag from [LLD][COFF] Support /kernel flag to [LLD][COFF] Ignore /kernel flag.
Tue, Jun 21, 11:12 AM · Restricted Project, Restricted Project
pzheng updated the diff for D128238: [LLD][COFF] Ignore /kernel flag.

Ignore the flag

Tue, Jun 21, 11:11 AM · Restricted Project, Restricted Project
pzheng added a comment to D128238: [LLD][COFF] Ignore /kernel flag.

Thanks for the comments, @hans and @thieta! I haven't done any verification of anything built with this flag yet. So, I am not very confident whether there's more to it than what's documented by Microsoft. I guess, for now, we'll just ignore the flag. At some point, I'll probably get a chance to do more testing on this and maybe we can revisit it then.

Tue, Jun 21, 11:02 AM · Restricted Project, Restricted Project

Mon, Jun 20

pzheng updated the diff for D128238: [LLD][COFF] Ignore /kernel flag.

minor change

Mon, Jun 20, 6:54 PM · Restricted Project, Restricted Project
pzheng requested review of D128238: [LLD][COFF] Ignore /kernel flag.
Mon, Jun 20, 6:52 PM · Restricted Project, Restricted Project
pzheng committed rGdec16147912d: [LLD][COFF] Ignore /pdbcompress flag (authored by pzheng).
[LLD][COFF] Ignore /pdbcompress flag
Mon, Jun 20, 4:49 PM · Restricted Project
pzheng closed D128231: [LLD][COFF] Ignore /pdbcompress flag.
Mon, Jun 20, 4:48 PM · Restricted Project, Restricted Project
pzheng requested review of D128231: [LLD][COFF] Ignore /pdbcompress flag.
Mon, Jun 20, 3:21 PM · Restricted Project, Restricted Project

Thu, Jun 16

pzheng committed rG2e0c46044a5d: [Object][COFF] Improve section name parsing (authored by pzheng).
[Object][COFF] Improve section name parsing
Thu, Jun 16, 5:01 PM · Restricted Project, Restricted Project
pzheng closed D127902: [Object][COFF] Improve section name parsing.
Thu, Jun 16, 5:01 PM · Restricted Project, Restricted Project
pzheng updated the diff for D127902: [Object][COFF] Improve section name parsing.

Use getAsInteger

Thu, Jun 16, 2:55 PM · Restricted Project, Restricted Project
pzheng added inline comments to D127902: [Object][COFF] Improve section name parsing.
Thu, Jun 16, 2:51 PM · Restricted Project, Restricted Project

Wed, Jun 15

pzheng added inline comments to D127902: [Object][COFF] Improve section name parsing.
Wed, Jun 15, 2:39 PM · Restricted Project, Restricted Project
pzheng requested review of D127902: [Object][COFF] Improve section name parsing.
Wed, Jun 15, 12:57 PM · Restricted Project, Restricted Project
pzheng committed rG9db61c3fe18a: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs (authored by pzheng).
[LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs
Wed, Jun 15, 9:40 AM · Restricted Project
pzheng closed D127709: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs.
Wed, Jun 15, 9:39 AM · Restricted Project, Restricted Project

Tue, Jun 14

pzheng updated the diff for D127709: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs.

Fix a typo

Tue, Jun 14, 12:40 PM · Restricted Project, Restricted Project
pzheng updated the diff for D127709: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs.

Create a new test

Tue, Jun 14, 12:38 PM · Restricted Project, Restricted Project
pzheng added a comment to D127709: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs.

I guess it's a little weird to piggyback the test into nodefaultlib.test. :) Will put it into a new test instead.

Tue, Jun 14, 12:20 PM · Restricted Project, Restricted Project
pzheng added a comment to D127709: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs.

Thanks for the feedback, @hans and @thieta. I have added a test case which can trigger the bug.

Tue, Jun 14, 12:01 PM · Restricted Project, Restricted Project
pzheng updated the diff for D127709: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs.

Add a test case

Tue, Jun 14, 11:59 AM · Restricted Project, Restricted Project

Mon, Jun 13

pzheng requested review of D127709: [LLD][COFF] Convert file name to lowercase when inserting it into visitedLibs.
Mon, Jun 13, 7:47 PM · Restricted Project, Restricted Project

Fri, Jun 10

pzheng added inline comments to D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.
Fri, Jun 10, 6:04 PM · Restricted Project, Restricted Project

Thu, Jun 9

pzheng added inline comments to D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.
Thu, Jun 9, 6:46 PM · Restricted Project, Restricted Project
pzheng added inline comments to D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.
Thu, Jun 9, 3:23 PM · Restricted Project, Restricted Project
pzheng committed rG064db243113c: [Object][COFF] Fix section name parsing error when the name field is not null… (authored by pzheng).
[Object][COFF] Fix section name parsing error when the name field is not null…
Thu, Jun 9, 12:59 PM · Restricted Project, Restricted Project
pzheng closed D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.
Thu, Jun 9, 12:58 PM · Restricted Project, Restricted Project
pzheng added inline comments to D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.
Thu, Jun 9, 12:54 PM · Restricted Project, Restricted Project
pzheng updated the diff for D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.

Small update the test

Thu, Jun 9, 12:52 PM · Restricted Project, Restricted Project
pzheng added inline comments to D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.
Thu, Jun 9, 10:46 AM · Restricted Project, Restricted Project
pzheng updated the diff for D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.

Update the test to address @mstorsjo's comments.

Thu, Jun 9, 10:43 AM · Restricted Project, Restricted Project

Wed, Jun 8

pzheng requested review of D127369: [Object][COFF] Fix section name parsing error when the name field is not null-padded.
Wed, Jun 8, 6:27 PM · Restricted Project, Restricted Project

Tue, Jun 7

pzheng committed rG1b2c8b945b91: [NFC][test] Improve ecsymbols.test (authored by pzheng).
[NFC][test] Improve ecsymbols.test
Tue, Jun 7, 3:26 PM · Restricted Project, Restricted Project
pzheng closed D127235: [NFC][test] Improve ecsymbols.test.
Tue, Jun 7, 3:26 PM · Restricted Project, Restricted Project
pzheng added a comment to D127235: [NFC][test] Improve ecsymbols.test.

Thanks for the prompt review, @thieta!

Tue, Jun 7, 10:45 AM · Restricted Project, Restricted Project
pzheng added a comment to D127135: [Object][Archive] Support a new archive member /<ECSYMBOLS>/.

I think you can drop the content lines from the test cases. But other that that it looks fine.

I tried removing the content lines from the test case, but got the following error somehow. Any idea?

"truncated or malformed archive (offset to next archive member past the end of the archive after member foo-arm64ec.obj)"

Did you update the Size fields too? I suspect those might be the problem. I also think you should inline the test input into the test file, since it's presumably only going to be used in the one test - having the test input close to the test commands themselves makes it easier to see what the test is doing. Finally, if you don't need all the library members for the test (it doesn't look to me like you do), you should remove them, leavnig only the ECSYMBOLS one.

Tue, Jun 7, 10:44 AM · Restricted Project, Restricted Project
pzheng requested review of D127235: [NFC][test] Improve ecsymbols.test.
Tue, Jun 7, 10:40 AM · Restricted Project, Restricted Project

Mon, Jun 6

pzheng committed rGc1d3cfea08f5: [Object][Archive] Support a new archive member /<ECSYMBOLS>/ (authored by pzheng).
[Object][Archive] Support a new archive member /<ECSYMBOLS>/
Mon, Jun 6, 5:21 PM · Restricted Project, Restricted Project
pzheng closed D127135: [Object][Archive] Support a new archive member /<ECSYMBOLS>/.
Mon, Jun 6, 5:21 PM · Restricted Project, Restricted Project
pzheng added a comment to D127135: [Object][Archive] Support a new archive member /<ECSYMBOLS>/.

I think you can drop the content lines from the test cases. But other that that it looks fine.

Mon, Jun 6, 12:53 PM · Restricted Project, Restricted Project
pzheng requested review of D127135: [Object][Archive] Support a new archive member /<ECSYMBOLS>/.
Mon, Jun 6, 11:00 AM · Restricted Project, Restricted Project

May 27 2022

pzheng committed rG4f12a721f179: [llvm-lib] Ignore /LTCG option (authored by pzheng).
[llvm-lib] Ignore /LTCG option
May 27 2022, 11:39 AM · Restricted Project, Restricted Project
pzheng closed D126000: [llvm-lib] Ignore /LTCG option.
May 27 2022, 11:39 AM · Restricted Project, Restricted Project
pzheng added reviewers for D126000: [llvm-lib] Ignore /LTCG option: hans, rnk.
May 27 2022, 11:01 AM · Restricted Project, Restricted Project

May 26 2022

pzheng added a comment to D126000: [llvm-lib] Ignore /LTCG option.

ping

May 26 2022, 11:30 AM · Restricted Project, Restricted Project

May 19 2022

pzheng requested review of D126000: [llvm-lib] Ignore /LTCG option.
May 19 2022, 11:42 AM · Restricted Project, Restricted Project

May 17 2022

pzheng committed rG366e57de23ed: [clang-cl] Add /Zc:wchar_t- option (authored by pzheng).
[clang-cl] Add /Zc:wchar_t- option
May 17 2022, 9:41 AM · Restricted Project, Restricted Project
pzheng closed D125513: [clang-cl] Add /Zc:wchar_t- option.
May 17 2022, 9:40 AM · Restricted Project, Restricted Project
pzheng added a comment to D125513: [clang-cl] Add /Zc:wchar_t- option.

Looks good to me after addressing Hans's comment.

Do you have commit access?

May 17 2022, 9:38 AM · Restricted Project, Restricted Project
pzheng added inline comments to D125513: [clang-cl] Add /Zc:wchar_t- option.
May 17 2022, 9:38 AM · Restricted Project, Restricted Project
pzheng updated the diff for D125513: [clang-cl] Add /Zc:wchar_t- option.

Address @hans's comment

May 17 2022, 9:36 AM · Restricted Project, Restricted Project

May 15 2022

pzheng added inline comments to D125513: [clang-cl] Add /Zc:wchar_t- option.
May 15 2022, 2:16 PM · Restricted Project, Restricted Project
pzheng updated the diff for D125513: [clang-cl] Add /Zc:wchar_t- option.

Address @thakis's comment

May 15 2022, 2:14 PM · Restricted Project, Restricted Project

May 12 2022

pzheng requested review of D125513: [clang-cl] Add /Zc:wchar_t- option.
May 12 2022, 8:08 PM · Restricted Project, Restricted Project

Apr 20 2022

pzheng committed rG38612fbc8990: Reland "[COFF, ARM64] Add __break intrinsic" (authored by pzheng).
Reland "[COFF, ARM64] Add __break intrinsic"
Apr 20 2022, 1:02 PM · Restricted Project, Restricted Project, Restricted Project
pzheng added a comment to D124032: [COFF, ARM64] Add __break intrinsic.

Thanks for the heads-up, @thakis. I have reverted the patch for now and will try to reproduce the failure.

Apr 20 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
pzheng added a reverting change for rG8a9b4fb4aa6d: [COFF, ARM64] Add __break intrinsic: rGbff8356b1969: Revert "[COFF, ARM64] Add __break intrinsic".
Apr 20 2022, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
pzheng committed rGbff8356b1969: Revert "[COFF, ARM64] Add __break intrinsic" (authored by pzheng).
Revert "[COFF, ARM64] Add __break intrinsic"
Apr 20 2022, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
pzheng added a reverting change for D124032: [COFF, ARM64] Add __break intrinsic: rGbff8356b1969: Revert "[COFF, ARM64] Add __break intrinsic".
Apr 20 2022, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
pzheng committed rG8a9b4fb4aa6d: [COFF, ARM64] Add __break intrinsic (authored by pzheng).
[COFF, ARM64] Add __break intrinsic
Apr 20 2022, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
pzheng closed D124032: [COFF, ARM64] Add __break intrinsic.
Apr 20 2022, 11:20 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

pzheng added a comment to D124032: [COFF, ARM64] Add __break intrinsic.

Thanks for reviewing the patch, @rnk.

Apr 19 2022, 3:45 PM · Restricted Project, Restricted Project, Restricted Project
pzheng updated the diff for D124032: [COFF, ARM64] Add __break intrinsic.

Address comments from @mstorsjo.

Apr 19 2022, 3:44 PM · Restricted Project, Restricted Project, Restricted Project
pzheng requested review of D124032: [COFF, ARM64] Add __break intrinsic.
Apr 19 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

pzheng committed rG1c9415806ba6: [compiler-rt][builtins] Move DMB definition to syn-ops.h (authored by pzheng).
[compiler-rt][builtins] Move DMB definition to syn-ops.h
Apr 7 2022, 2:58 PM · Restricted Project, Restricted Project
pzheng closed D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.
Apr 7 2022, 2:58 PM · Restricted Project, Restricted Project
pzheng retitled D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h from [compiler-rt][builtins] Define DMB as nothing for pre-ARMv6 targets to [compiler-rt][builtins] Move DMB definition to syn-ops.h.
Apr 7 2022, 1:41 PM · Restricted Project, Restricted Project
pzheng updated the diff for D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.

Thanks, @efriedma. I am updating the patch to move the DMB defintion to sync-ops.h.

Apr 7 2022, 1:40 PM · Restricted Project, Restricted Project

Apr 6 2022

pzheng updated the summary of D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.
Apr 6 2022, 7:00 PM · Restricted Project, Restricted Project
pzheng updated the diff for D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.

update

Apr 6 2022, 6:59 PM · Restricted Project, Restricted Project
pzheng added a comment to D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.

Thanks for the suggestions, @efriedma. I checked the cmake files and the arm/sync_fetch_and_* files seem to have been properly excluded from unsupported archs. The build errors I saw are actually because the assembly.h header being included in many other assembly files too (e.g., aeabi_dcmp.S). After D99282, compiling any file which includes assembly.h for any pre-ARVv6 target will fail due to the "#error only supported on ARMv6+."

Apr 6 2022, 6:48 PM · Restricted Project, Restricted Project
pzheng retitled D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h from [compiler-rt][builtins] Use mcr for dmb instruction on armv5 to [compiler-rt][builtins] Define DMB as nothing for pre-ARMv6 targets.
Apr 6 2022, 9:49 AM · Restricted Project, Restricted Project

Apr 5 2022

pzheng updated the diff for D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.

Addressing some comments

Apr 5 2022, 6:56 PM · Restricted Project, Restricted Project
pzheng added a comment to D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.

I agree, @efriedma, the routines in sync-ops.h probably won't work as expected on ARMv5 and I doubt any of our baremetal customers actually use any of these. For now, to unblock the ARMv5 build, does it make sense to define DMB as nothing for any target pre-ARMv6? Any other suggestions are welcome too.

Apr 5 2022, 6:51 PM · Restricted Project, Restricted Project
pzheng added a comment to D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.

Thanks for digging out the references, @peter.smith. You are right, DMB is only available for ARMv6+ and what is available for ARMv5 is DWB. I overlooked some details.

Apr 5 2022, 6:42 PM · Restricted Project, Restricted Project

Apr 4 2022

pzheng requested review of D123105: [compiler-rt][builtins] Move DMB definition to syn-ops.h.
Apr 4 2022, 6:37 PM · Restricted Project, Restricted Project

Oct 6 2021

pzheng committed rGb0045f559549: [ARM] Fix a bug in finding a pair of extracts to create VMOVRRD (authored by pzheng).
[ARM] Fix a bug in finding a pair of extracts to create VMOVRRD
Oct 6 2021, 10:04 AM
pzheng closed D111188: [ARM] Fix a bug in finding a pair of extracts to create VMOVRRD.
Oct 6 2021, 10:03 AM · Restricted Project
pzheng added inline comments to D111188: [ARM] Fix a bug in finding a pair of extracts to create VMOVRRD.
Oct 6 2021, 8:52 AM · Restricted Project
pzheng updated the diff for D111188: [ARM] Fix a bug in finding a pair of extracts to create VMOVRRD.

Address @dmgreen's comments

Oct 6 2021, 8:50 AM · Restricted Project

Oct 5 2021

pzheng requested review of D111188: [ARM] Fix a bug in finding a pair of extracts to create VMOVRRD.
Oct 5 2021, 3:23 PM · Restricted Project

May 30 2021

pzheng committed rG056733d0195b: [SafeStack] Use proper API to get stack guard (authored by pzheng).
[SafeStack] Use proper API to get stack guard
May 30 2021, 12:54 AM
pzheng closed D102646: [SafeStack] Use proper API to get stack guard.
May 30 2021, 12:54 AM · Restricted Project

May 24 2021

pzheng added a comment to D102646: [SafeStack] Use proper API to get stack guard.

Any more comments? I'll probably wait a few more days before committing the change in case anyone hasn't got a chance to review.

May 24 2021, 12:15 PM · Restricted Project

May 18 2021

pzheng added a reviewer for D102646: [SafeStack] Use proper API to get stack guard: pcc.
May 18 2021, 2:12 PM · Restricted Project

May 17 2021

pzheng requested review of D102646: [SafeStack] Use proper API to get stack guard.
May 17 2021, 12:27 PM · Restricted Project

May 15 2021

pzheng committed rGc9b36a041fd7: Support GCC's -fstack-usage flag (authored by pzheng).
Support GCC's -fstack-usage flag
May 15 2021, 10:23 AM
pzheng closed D100509: Support GCC's -fstack-usage flag.
May 15 2021, 10:23 AM · Restricted Project, Restricted Project

May 14 2021

pzheng added a comment to D100509: Support GCC's -fstack-usage flag.

Thanks for all the feedbacks, @MaskRay! I will wait another day before committing the change.

May 14 2021, 10:53 AM · Restricted Project, Restricted Project
pzheng updated the diff for D100509: Support GCC's -fstack-usage flag.

Address new comments from @MaskRay.

May 14 2021, 10:49 AM · Restricted Project, Restricted Project
pzheng updated the diff for D100509: Support GCC's -fstack-usage flag.

Address @MaskRay's comments.

May 14 2021, 9:44 AM · Restricted Project, Restricted Project

May 10 2021

pzheng added inline comments to D100509: Support GCC's -fstack-usage flag.
May 10 2021, 11:59 AM · Restricted Project, Restricted Project