Page MenuHomePhabricator

Jim (Jim Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2018, 10:24 PM (45 w, 3 d)

Recent Activity

Jun 16 2019

Jim added a comment to D63068: [AVR] Fix incorrect stack parameter push order.

@hfinkel
Hi, I am not really sure the means of TokenFactor. I refer the implement of other target.
From document, TokenFactor is used to represent the fact that the operand operators are independent of each other.
I am not sure why other target transform all stores into one single node by using TokenFactor.
Most of target, it uses sp+offset to store arguments into stack. So the order of store instruction doesn't matter.
In AVR, it uses push instruction to store arguments. Therefore. the order of store(push) instruction can't be changed.
Could you give me some suggestion? Thanks.

Jun 16 2019, 11:07 PM · Restricted Project

Jun 13 2019

Jim accepted D54411: [Codegen] Merge tail blocks with no successors after block placement.

LGTM.

Jun 13 2019, 5:10 AM · Restricted Project
Jim added inline comments to D54411: [Codegen] Merge tail blocks with no successors after block placement.
Jun 13 2019, 2:30 AM · Restricted Project
Jim added inline comments to D54411: [Codegen] Merge tail blocks with no successors after block placement.
Jun 13 2019, 1:23 AM · Restricted Project

Jun 9 2019

Jim created D63068: [AVR] Fix incorrect stack parameter push order.
Jun 9 2019, 10:32 PM · Restricted Project

Jun 2 2019

Jim added a reviewer for D60365: [AVR] Fix codegen for rotate instructions: Jim.
Jun 2 2019, 10:58 PM · Restricted Project
Jim committed rG20b14dacbbbf: [AVR] Fix incorrect source regclass of LDWRdPtr (authored by Jim).
[AVR] Fix incorrect source regclass of LDWRdPtr
Jun 2 2019, 7:30 PM

May 27 2019

Jim added inline comments to D62300: [AVR] Fix incorrect source regclass of LDWRdPtr.
May 27 2019, 12:28 AM · Restricted Project

May 23 2019

Jim added a reviewer for D62300: [AVR] Fix incorrect source regclass of LDWRdPtr: dylanmckay.
May 23 2019, 3:48 AM · Restricted Project
Jim created D62300: [AVR] Fix incorrect source regclass of LDWRdPtr.
May 23 2019, 3:46 AM · Restricted Project

Apr 14 2019

Jim committed rG489f8255fcb4: [Sparc] Fix typo. NFC. (authored by Jim).
[Sparc] Fix typo. NFC.
Apr 14 2019, 10:16 PM

Apr 9 2019

Jim committed rGa49c95e02aac: [Sparc] Fix incorrect MI insertion position for spilling f128. (authored by Jim).
[Sparc] Fix incorrect MI insertion position for spilling f128.
Apr 9 2019, 6:55 PM
Jim updated the summary of D60397: [Sparc] Fix incorrect MI insertion position for spilling f128..
Apr 9 2019, 3:40 AM · Restricted Project

Apr 8 2019

Jim updated the diff for D60397: [Sparc] Fix incorrect MI insertion position for spilling f128..

Add test case for large stack offset.

Apr 8 2019, 7:27 PM · Restricted Project
Jim added a reviewer for D60397: [Sparc] Fix incorrect MI insertion position for spilling f128.: jyknight.
Apr 8 2019, 12:45 AM · Restricted Project
Jim created D60397: [Sparc] Fix incorrect MI insertion position for spilling f128..
Apr 8 2019, 12:41 AM · Restricted Project
Jim updated the summary of D60397: [Sparc] Fix incorrect MI insertion position for spilling f128..
Apr 8 2019, 12:41 AM · Restricted Project

Mar 29 2019

Jim closed D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:41 AM · Restricted Project
Jim reopened D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:33 AM · Restricted Project
Jim closed D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:13 AM · Restricted Project
Jim removed 1 commit(s) for D56073: Typo fix: NewDepth -> NewHeight: rG421c09427a3a: Test commit. Fix typo..
Mar 29 2019, 3:09 AM · Restricted Project
Jim removed an edge from rG421c09427a3a: Test commit. Fix typo.: D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:09 AM
Jim added an edge to rL357237: Test commit. Fix typo.: D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:09 AM
Jim removed an edge from rL357237: Test commit. Fix typo.: D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:09 AM
Jim removed 1 commit(s) for D56073: Typo fix: NewDepth -> NewHeight: rL357237: Test commit. Fix typo..
Mar 29 2019, 3:09 AM · Restricted Project
Jim added 1 commit(s) for D56073: Typo fix: NewDepth -> NewHeight: rL357237: Test commit. Fix typo..
Mar 29 2019, 3:09 AM · Restricted Project
Jim reopened D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:07 AM · Restricted Project
Jim added 1 commit(s) for D56073: Typo fix: NewDepth -> NewHeight: rG421c09427a3a: Test commit. Fix typo..
Mar 29 2019, 3:07 AM · Restricted Project
Jim added an edge to rG421c09427a3a: Test commit. Fix typo.: D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:07 AM
Jim closed D56073: Typo fix: NewDepth -> NewHeight.
Mar 29 2019, 3:05 AM · Restricted Project
Jim accepted D59983: fix typo: "\t" => " ".
Mar 29 2019, 2:45 AM · Restricted Project

Mar 28 2019

Jim committed rG421c09427a3a: Test commit. Fix typo. (authored by Jim).
Test commit. Fix typo.
Mar 28 2019, 10:05 PM
Jim accepted D56073: Typo fix: NewDepth -> NewHeight.
Mar 28 2019, 7:00 PM · Restricted Project

Dec 24 2018

Jim created D56073: Typo fix: NewDepth -> NewHeight.
Dec 24 2018, 11:26 PM · Restricted Project

Dec 4 2018

Jim updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Remove unused fixme comment in test/CodeGen/X86/loop-search.ll.

Dec 4 2018, 12:01 AM · Restricted Project

Nov 29 2018

Jim updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Remove unnecessary checking in test/CodeGen/WebAssembly/cfg-stackify.ll.

Nov 29 2018, 12:43 AM · Restricted Project
Jim added a reviewer for D54411: [Codegen] Merge tail blocks with no successors after block placement: aheejin.
Nov 29 2018, 12:03 AM · Restricted Project

Nov 27 2018

Jim updated the diff for D54411: [Codegen] Merge tail blocks with no successors after block placement.

Update test cases.

Nov 27 2018, 9:59 PM · Restricted Project

Nov 11 2018

Jim retitled D54411: [Codegen] Merge tail blocks with no successors after block placement from [Codegen] Merge tail blocks after block placement to [Codegen] Merge tail blocks with no successors after block placement.
Nov 11 2018, 6:52 PM · Restricted Project
Jim created D54411: [Codegen] Merge tail blocks with no successors after block placement.
Nov 11 2018, 6:52 PM · Restricted Project