Page MenuHomePhabricator

Jim (Jim Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2018, 10:24 PM (199 w, 1 d)

Recent Activity

Wed, Jun 1

Jim updated the diff for D95588: [RISCV] Implement the MC layer support of P extension.

Rebase

Wed, Jun 1, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
Jim updated the diff for D108189: [RISCV] Support experimental 'P' extension 0.96.

Rebase

Wed, Jun 1, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
Jim updated the diff for D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.

Rebase

Wed, Jun 1, 6:34 PM · Restricted Project, Restricted Project

May 15 2022

Jim committed rG0a0d6489ef2e: [Mips] Implement hasDivRemOp() (authored by Jim).
[Mips] Implement hasDivRemOp()
May 15 2022, 11:43 PM · Restricted Project, Restricted Project
Jim committed rG49b0c605424b: [DivRemPairs][Mips] Pre-commit test for Mips target (authored by Jim).
[DivRemPairs][Mips] Pre-commit test for Mips target
May 15 2022, 11:43 PM · Restricted Project, Restricted Project
Jim closed D124980: [Mips] Implement hasDivRemOp().
May 15 2022, 11:42 PM · Restricted Project, Restricted Project
Jim closed D124979: [DivRemPairs][Mips] Pre-commit test for Mips target.
May 15 2022, 11:42 PM · Restricted Project, Restricted Project
Jim updated the diff for D124980: [Mips] Implement hasDivRemOp().

Keep alphabetical ordering in CMakeLists.txt

May 15 2022, 7:24 PM · Restricted Project, Restricted Project
Jim updated the summary of D124980: [Mips] Implement hasDivRemOp().
May 15 2022, 7:16 PM · Restricted Project, Restricted Project

May 11 2022

Jim abandoned D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.
May 11 2022, 11:57 PM · Restricted Project, Restricted Project
Jim committed rG50f5cef39140: [BPF] Implement mod operation (authored by Jim).
[BPF] Implement mod operation
May 11 2022, 7:57 PM · Restricted Project, Restricted Project
Jim closed D125207: [BPF] Implement mod operation.
May 11 2022, 7:56 PM · Restricted Project, Restricted Project
Jim added a comment to D125207: [BPF] Implement mod operation.

@Jim Thanks for the updated commit message. Please go ahead to merge to llvm-project main branch if you have write permission. Otherwise, please provide me with peoper git author signature "<name> <email address>" and I can help push the patch for you.

May 11 2022, 7:55 PM · Restricted Project, Restricted Project

May 10 2022

Jim updated the summary of D125207: [BPF] Implement mod operation.
May 10 2022, 7:44 PM · Restricted Project, Restricted Project
Jim added a comment to D124431: [InlineAsm] Add missing constraint A to getMemConstraintName.

This patch only add missing case in getMemConstraintName.
Could someone help to take a review. Thanks.

May 10 2022, 7:34 PM · Restricted Project, Restricted Project

May 8 2022

Jim updated the summary of D125207: [BPF] Implement mod operation.
May 8 2022, 11:58 PM · Restricted Project, Restricted Project
Jim requested review of D125207: [BPF] Implement mod operation.
May 8 2022, 11:55 PM · Restricted Project, Restricted Project

May 4 2022

Jim updated subscribers of D124980: [Mips] Implement hasDivRemOp().
May 4 2022, 10:47 PM · Restricted Project, Restricted Project
Jim added reviewers for D124980: [Mips] Implement hasDivRemOp(): sdardis, RKSimon.
May 4 2022, 10:45 PM · Restricted Project, Restricted Project
Jim requested review of D124980: [Mips] Implement hasDivRemOp().
May 4 2022, 10:44 PM · Restricted Project, Restricted Project
Jim requested review of D124979: [DivRemPairs][Mips] Pre-commit test for Mips target.
May 4 2022, 10:43 PM · Restricted Project, Restricted Project

May 2 2022

Jim added a reviewer for D124431: [InlineAsm] Add missing constraint A to getMemConstraintName: craig.topper.
May 2 2022, 8:01 PM · Restricted Project, Restricted Project

Apr 27 2022

Jim committed rG9de7b93bc008: [RISCV][NFC] Update and add missing closed curly bracket comment in… (authored by Jim).
[RISCV][NFC] Update and add missing closed curly bracket comment in…
Apr 27 2022, 12:18 AM · Restricted Project, Restricted Project

Apr 25 2022

Jim added a reviewer for D124431: [InlineAsm] Add missing constraint A to getMemConstraintName: lewis-revill.
Apr 25 2022, 10:14 PM · Restricted Project, Restricted Project
Jim requested review of D124431: [InlineAsm] Add missing constraint A to getMemConstraintName.
Apr 25 2022, 10:13 PM · Restricted Project, Restricted Project

Mar 1 2022

Jim added a comment to D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.

It not just happen in RISCVPassConfig. If we inherit other class such as RISCVISelDAGToDAG.h and RISCVISelLowering.h, it still need to deal with the newly added override function issue.

Mar 1 2022, 6:59 PM · Restricted Project, Restricted Project
Jim added a comment to D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.

Creating a new class seems fragile. Does your class call the RISCVPassConfig version of the methods you override? What if your class overrides a method that RISCVPassConfig doesn't override today, but does in the future. Will your class call the newly added override when its done with your override?

Mar 1 2022, 6:52 PM · Restricted Project, Restricted Project
Jim added a comment to D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.

Note that git grep ' : public TargetPassConfig' llvm/lib/Target turns up 21 results, exactly one for each backend, and every single one lives in the backend's TargetMachine.cpp. So moving it to a header, or adding a second one, would go against the convention of every single backend in tree.

Mar 1 2022, 6:03 PM · Restricted Project, Restricted Project
Herald added a project to D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC: Restricted Project.

Inheriting from the pass doesn't make sense, just change the implementations. The TargetPassConfig has access to the TM for a reason. As someone with significant downstream changes I am sympathetic to changing upstream code to be more accommodating, but this change just seems motivated by an arbitrary downstream decision that goes against the intent of LLVM's structure just to avoid the occasional merge conflict (RISCVPassConfig hardly changes much).

Mar 1 2022, 5:55 PM · Restricted Project, Restricted Project

Feb 28 2022

Jim added a comment to D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.

Isn’t the function that returns the class in this cpp file? Why are you able to change that function in your downstream but can’t add your new class to the cpp in your downstream?

Feb 28 2022, 11:21 PM · Restricted Project, Restricted Project
Jim added a comment to D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.

Can you clarify what *why* this helps downstream?

Feb 28 2022, 10:31 PM · Restricted Project, Restricted Project
Jim updated the summary of D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.
Feb 28 2022, 10:26 PM · Restricted Project, Restricted Project
Jim updated the diff for D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.

Add commit log

Feb 28 2022, 10:25 PM · Restricted Project, Restricted Project
Jim updated the diff for D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.

clang-format

Feb 28 2022, 10:09 PM · Restricted Project, Restricted Project
Jim added a reviewer for D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC: craig.topper.
Feb 28 2022, 9:11 PM · Restricted Project, Restricted Project
Jim requested review of D120695: [RISCV] Move class RISCVPassConfig declaration to RISCVTargetMachine.h for downstream. NFC.
Feb 28 2022, 9:05 PM · Restricted Project, Restricted Project

Feb 21 2022

Jim added inline comments to D95588: [RISCV] Implement the MC layer support of P extension.
Feb 21 2022, 1:01 AM · Restricted Project, Restricted Project, Restricted Project
Jim added inline comments to D95588: [RISCV] Implement the MC layer support of P extension.
Feb 21 2022, 12:56 AM · Restricted Project, Restricted Project, Restricted Project
Jim updated the diff for D95588: [RISCV] Implement the MC layer support of P extension.

Remove inst alias smbb32 (alias to mulsr64) and kmar64 (alias to kmar64).
Having the same instruction in two different extensions under two different name is gone.

Feb 21 2022, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2022

Jim added a comment to D119529: [BasicTTI] Set scalarization cost of getCommonMaskedMemoryOpCost to Invalid..

Can you add a test for this change?

Feb 14 2022, 10:22 PM · Restricted Project, Restricted Project

Feb 11 2022

Jim requested review of D119529: [BasicTTI] Set scalarization cost of getCommonMaskedMemoryOpCost to Invalid..
Feb 11 2022, 1:18 AM · Restricted Project, Restricted Project

Feb 10 2022

Jim updated the diff for D95588: [RISCV] Implement the MC layer support of P extension.

Rebase

Feb 10 2022, 9:57 PM · Restricted Project, Restricted Project, Restricted Project
Jim updated the diff for D108189: [RISCV] Support experimental 'P' extension 0.96.

Rebase

Feb 10 2022, 9:56 PM · Restricted Project, Restricted Project, Restricted Project
Jim updated the diff for D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.

Rebase

Feb 10 2022, 9:55 PM · Restricted Project, Restricted Project
Jim added inline comments to D93298: [RISCV] add the MC layer support of Zfinx extension.
Feb 10 2022, 9:29 PM · Restricted Project, Restricted Project, Restricted Project
Jim abandoned D95589: [RISCV] Support experimental 'P' extension 0.9.
Feb 10 2022, 6:23 PM · Restricted Project

Feb 8 2022

Jim added inline comments to D93298: [RISCV] add the MC layer support of Zfinx extension.
Feb 8 2022, 7:34 PM · Restricted Project, Restricted Project, Restricted Project

Jan 29 2022

Jim committed rG33fe0872cd54: [M68k] Add addressing modes ARIPI and ARIPD support for BTST (authored by Jim).
[M68k] Add addressing modes ARIPI and ARIPD support for BTST
Jan 29 2022, 5:05 AM
Jim closed D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.
Jan 29 2022, 5:04 AM · Restricted Project

Jan 26 2022

Jim committed rGad39b5bc59b0: [NFC] Remove duplicate include (authored by Jim).
[NFC] Remove duplicate include
Jan 26 2022, 9:52 PM
Jim added a comment to D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.

Kindly ping.

Jan 26 2022, 6:05 PM · Restricted Project

Jan 25 2022

Jim committed rGda1cac7d19c4: [NFC] Remove duplicate include (authored by Jim).
[NFC] Remove duplicate include
Jan 25 2022, 11:07 PM
Jim committed rGf3314e374787: [clang-tidy] Pop Files only if FileChangeReason is ExitFile (authored by Jim).
[clang-tidy] Pop Files only if FileChangeReason is ExitFile
Jan 25 2022, 6:43 AM

Jan 24 2022

Jim committed rGf53301125257: [Hexagon] Use llvm::Register instead of unsigned in HexagonConstExtenders.cpp. (authored by Jim).
[Hexagon] Use llvm::Register instead of unsigned in HexagonConstExtenders.cpp.
Jan 24 2022, 12:04 AM
Jim closed D117851: [Hexagon] Use llvm::Register instead of unsigned in HexagonConstExtenders.cpp. NFC..
Jan 24 2022, 12:04 AM · Restricted Project

Jan 23 2022

Jim committed rG3f24cdec2572: [RISCV][NFC] Remove tailing whitespaces in RISCVInstrInfoVSDPatterns.td and… (authored by Jim).
[RISCV][NFC] Remove tailing whitespaces in RISCVInstrInfoVSDPatterns.td and…
Jan 23 2022, 6:54 PM

Jan 20 2022

Jim added a reviewer for D117851: [Hexagon] Use llvm::Register instead of unsigned in HexagonConstExtenders.cpp. NFC.: kparzysz.
Jan 20 2022, 9:11 PM · Restricted Project
Jim requested review of D117851: [Hexagon] Use llvm::Register instead of unsigned in HexagonConstExtenders.cpp. NFC..
Jan 20 2022, 9:11 PM · Restricted Project
Jim added a comment to D108189: [RISCV] Support experimental 'P' extension 0.96.

Hi, @Jim.
What time is P extension going to upstream to community since it's been no update for some months?

Hi @zixuan-wu,

Jan 20 2022, 6:09 PM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2022

Jim added a comment to D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.
Jan 19 2022, 9:36 PM · Restricted Project
Jim added a comment to D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.

This revision seems to be in conflict with D116993 . How are you going to resolve it? (e.g. rebasing this one on top of D116993 and setup a dependency)

Jan 19 2022, 9:27 PM · Restricted Project
Jim committed rG216ac31dd7d7: [M68k][NFC] Rename Bt(BT) to Btst(BTST) (authored by Jim).
[M68k][NFC] Rename Bt(BT) to Btst(BTST)
Jan 19 2022, 8:49 PM
Jim closed D117534: [M68k][NFC] Rename Bt(BT) to Btst(BTST).
Jan 19 2022, 8:48 PM · Restricted Project
Jim committed rGd6b073483712: [NFC] Use Register instead of unsigned (authored by Jim).
[NFC] Use Register instead of unsigned
Jan 19 2022, 4:31 AM

Jan 18 2022

Jim updated the diff for D117534: [M68k][NFC] Rename Bt(BT) to Btst(BTST).

Add missing unrenamed

Jan 18 2022, 7:46 PM · Restricted Project

Jan 17 2022

Jim updated the diff for D117534: [M68k][NFC] Rename Bt(BT) to Btst(BTST).

Formatting

Jan 17 2022, 10:54 PM · Restricted Project
Jim added reviewers for D117534: [M68k][NFC] Rename Bt(BT) to Btst(BTST): myhsu, ricky26.
Jan 17 2022, 10:03 PM · Restricted Project
Jim requested review of D117534: [M68k][NFC] Rename Bt(BT) to Btst(BTST).
Jan 17 2022, 10:02 PM · Restricted Project

Jan 13 2022

Jim abandoned D117196: [compiler-rt][RISCV] Implement __clear_cache() on ELF.

Please see D92464 for a discussion about the issues with this.

Jan 13 2022, 5:41 PM · Restricted Project
Jim updated the summary of D117196: [compiler-rt][RISCV] Implement __clear_cache() on ELF.
Jan 13 2022, 12:56 AM · Restricted Project
Jim requested review of D117196: [compiler-rt][RISCV] Implement __clear_cache() on ELF.
Jan 13 2022, 12:52 AM · Restricted Project

Jan 12 2022

Jim committed rGbb13036483d2: [M68k][NFC] Use Register instead of unsigned int (authored by Jim).
[M68k][NFC] Use Register instead of unsigned int
Jan 12 2022, 11:55 PM

Jan 11 2022

Jim committed rG48fd67cff100: [M68k][NFC] Rename header guard of M68kSubtarget.h (authored by Jim).
[M68k][NFC] Rename header guard of M68kSubtarget.h
Jan 11 2022, 9:12 PM
Jim committed rG4a7890c67c42: [M68k][NFC] Add missing #endif comment (authored by Jim).
[M68k][NFC] Add missing #endif comment
Jan 11 2022, 9:12 PM

Jan 10 2022

Jim added reviewers for D116993: [M68k] Add MC support for bchg, bclr and bset instruction: myhsu, ricky26.
Jan 10 2022, 10:08 PM · Restricted Project
Jim updated the diff for D116993: [M68k] Add MC support for bchg, bclr and bset instruction.

Fix tests

Jan 10 2022, 10:06 PM · Restricted Project
Jim requested review of D116993: [M68k] Add MC support for bchg, bclr and bset instruction.
Jan 10 2022, 10:01 PM · Restricted Project
Jim updated the diff for D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.

Rebase

Jan 10 2022, 10:00 PM · Restricted Project
Jim committed rG905ac777d5c1: [M68k][test][NFC] Reorder the tests for MxBTST_MI and MxBTST_MR (authored by Jim).
[M68k][test][NFC] Reorder the tests for MxBTST_MI and MxBTST_MR
Jan 10 2022, 6:48 PM

Jan 9 2022

Jim committed rG9b70ddaff6e1: [Builtins] Add missing the macro 'y' description in comments (authored by Jim).
[Builtins] Add missing the macro 'y' description in comments
Jan 9 2022, 6:47 PM
Jim closed D116509: [Builtins] Add missing the macro 'y' description in comments.
Jan 9 2022, 6:47 PM · Restricted Project

Jan 6 2022

Jim updated the diff for D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.

Rebase

Jan 6 2022, 6:55 PM · Restricted Project
Jim committed rG6d065ef7b998: [M68k][NFC] Fix typo. BCNG->BCHG (authored by Jim).
[M68k][NFC] Fix typo. BCNG->BCHG
Jan 6 2022, 6:51 PM
Jim committed rG9c0ac101d7d1: [M68k][test][NFC] Add missing tests for arith inst with size byte or word (authored by Jim).
[M68k][test][NFC] Add missing tests for arith inst with size byte or word
Jan 6 2022, 12:45 AM

Jan 5 2022

Jim committed rGcb0e12a144de: [M68k][test][NFC] Add missing tests for MxCMP_RM (authored by Jim).
[M68k][test][NFC] Add missing tests for MxCMP_RM
Jan 5 2022, 6:43 PM
Jim committed rG75ea6b43197c: [M68k][test][NFC] Fix no newline at end of file (authored by Jim).
[M68k][test][NFC] Fix no newline at end of file
Jan 5 2022, 6:11 PM
Jim committed rG30d739603c15: [M68k][test][NFC] Remove new line at end of file (authored by Jim).
[M68k][test][NFC] Remove new line at end of file
Jan 5 2022, 1:10 AM

Jan 4 2022

Jim committed rGc6c19a77e341: [M68k][test][NFC] Remove unecessary labels and assembly directives (authored by Jim).
[M68k][test][NFC] Remove unecessary labels and assembly directives
Jan 4 2022, 11:59 PM
Jim updated the summary of D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.
Jan 4 2022, 12:20 AM · Restricted Project
Jim requested review of D116580: [M68k] Add addressing modes ARIPI and ARIPD support for BTST.
Jan 4 2022, 12:16 AM · Restricted Project

Jan 3 2022

Jim committed rGc64ffa22d143: [M68k][NFC] Fix unused argument warnings in M68kInstrArithmetic.td (authored by Jim).
[M68k][NFC] Fix unused argument warnings in M68kInstrArithmetic.td
Jan 3 2022, 11:10 PM
Jim committed rG8b014ad725eb: [M68k][NFC] Fix typo in comment. PCD->PCI. (authored by Jim).
[M68k][NFC] Fix typo in comment. PCD->PCI.
Jan 3 2022, 7:18 PM
Jim committed rG6bf22ae4d31c: [M68k][NFC] Fix file header (authored by Jim).
[M68k][NFC] Fix file header
Jan 3 2022, 6:24 PM
Jim committed rGd38637a0e601: [RISCV] Fix the code alignment for GroupFloatVectors. NFC (authored by Jim).
[RISCV] Fix the code alignment for GroupFloatVectors. NFC
Jan 3 2022, 1:13 AM
Jim closed D116520: [RISCV] Fix the code alignment for GroupFloatVectors.
Jan 3 2022, 1:13 AM · Restricted Project

Jan 2 2022

Jim added a reviewer for D116520: [RISCV] Fix the code alignment for GroupFloatVectors: HsiangKai.
Jan 2 2022, 10:29 PM · Restricted Project
Jim requested review of D116520: [RISCV] Fix the code alignment for GroupFloatVectors.
Jan 2 2022, 10:28 PM · Restricted Project
Jim added a reviewer for D116509: [Builtins] Add missing the macro 'y' description in comments: stuij.
Jan 2 2022, 5:29 PM · Restricted Project
Jim requested review of D116509: [Builtins] Add missing the macro 'y' description in comments.
Jan 2 2022, 5:28 PM · Restricted Project

Dec 23 2021

Jim committed rG02478a26f269: [RISCV] Use DAG variable directly instead of DCI.DAG (authored by Jim).
[RISCV] Use DAG variable directly instead of DCI.DAG
Dec 23 2021, 9:15 PM