Page MenuHomePhabricator

Jim (Jim Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2018, 10:24 PM (107 w, 6 d)

Recent Activity

Jun 15 2020

Jim added inline comments to D81391: [RISC-V] Do not crash when using -ftrapping-math.
Jun 15 2020, 11:04 PM · Restricted Project

May 17 2020

Jim committed rG7ee479a760e0: [RISCV] Fix passing two floating-point values in complex separately by two GPRs… (authored by Jim).
[RISCV] Fix passing two floating-point values in complex separately by two GPRs…
May 17 2020, 10:21 PM
Jim closed D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64 .
May 17 2020, 10:21 PM · Restricted Project

May 12 2020

Jim added a comment to D78545: [RISCV] Make CanLowerReturn protected for downstream maintenance.

@lenary Ok, I have reverted it.

May 12 2020, 4:47 AM · Restricted Project
Jim added a reverting change for rGd775841d7d6e: [RISCV] Make CanLowerReturn protected for downstream maintenance: rG9d6064ec49ec: Revert "[RISCV] Make CanLowerReturn protected for downstream maintenance".
May 12 2020, 4:16 AM
Jim committed rG9d6064ec49ec: Revert "[RISCV] Make CanLowerReturn protected for downstream maintenance" (authored by Jim).
Revert "[RISCV] Make CanLowerReturn protected for downstream maintenance"
May 12 2020, 4:16 AM
Jim created D79770: [RISCV] Fix passing two floating-point values in complex separately by two GPRs on RV64 .
May 12 2020, 1:02 AM · Restricted Project

May 11 2020

Jim added a comment to D78545: [RISCV] Make CanLowerReturn protected for downstream maintenance.

I am still very confused why this is necessary. CanLowerReturn barely does anything other have a loop to call other functions that actually do useful work, it seems like the wrong place to hook into things. Your "explanation" is merely just "we want this because we want this". Could you please shed some light on how _exactly_ this is useful? As it stands I am none the wiser.

May 11 2020, 11:57 PM · Restricted Project
Jim committed rGd775841d7d6e: [RISCV] Make CanLowerReturn protected for downstream maintenance (authored by Jim).
[RISCV] Make CanLowerReturn protected for downstream maintenance
May 11 2020, 11:12 PM
Jim closed D78545: [RISCV] Make CanLowerReturn protected for downstream maintenance.
May 11 2020, 11:12 PM · Restricted Project

May 6 2020

Jim updated the diff for D78545: [RISCV] Make CanLowerReturn protected for downstream maintenance.

Add comment.

May 6 2020, 10:42 PM · Restricted Project

May 4 2020

Jim updated the diff for D78545: [RISCV] Make CanLowerReturn protected for downstream maintenance.

Only move CanLowerReturn to protected. In our case, we need to override this function for passing special type indirectly.
And the remaining type would be handled by the function of the basic class. It would be easier to integrate with the existing code.

May 4 2020, 11:07 PM · Restricted Project

Apr 21 2020

Jim created D78545: [RISCV] Make CanLowerReturn protected for downstream maintenance.
Apr 21 2020, 2:07 AM · Restricted Project

Mar 5 2020

Jim committed rGc40a9010d925: [AVR][NFC] Remove trailing space (authored by Jim).
[AVR][NFC] Remove trailing space
Mar 5 2020, 7:07 PM

Mar 4 2020

Jim committed rGea6eb813c7cb: [AVR][NFC] Use Register instead of unsigned (authored by Jim).
[AVR][NFC] Use Register instead of unsigned
Mar 4 2020, 7:37 PM
Jim closed D75595: [AVR][NFC] Use Register instead of unsigned.
Mar 4 2020, 7:37 PM · Restricted Project
Jim added inline comments to D75595: [AVR][NFC] Use Register instead of unsigned.
Mar 4 2020, 3:26 AM · Restricted Project
Jim created D75595: [AVR][NFC] Use Register instead of unsigned.
Mar 4 2020, 12:06 AM · Restricted Project

Mar 3 2020

Jim committed rG4e3b037665fd: [AVR] Fix incorrect register state for LDRdPtr (authored by Jim).
[AVR] Fix incorrect register state for LDRdPtr
Mar 3 2020, 1:44 AM
Jim closed D75437: [AVR] Fix incorrect register state for LDRdPtr.
Mar 3 2020, 1:44 AM · Restricted Project
Jim updated the diff for D75437: [AVR] Fix incorrect register state for LDRdPtr.

Format code.

Mar 3 2020, 12:00 AM · Restricted Project

Mar 2 2020

Jim updated the diff for D75437: [AVR] Fix incorrect register state for LDRdPtr.

Add -verify-machineinstrs for brind.ll

Mar 2 2020, 10:25 PM · Restricted Project
Jim committed rGc0a2da9460db: [AVR] Add missing ROLLOOP and RORLOOP into getTargetNodeName (authored by Jim).
[AVR] Add missing ROLLOOP and RORLOOP into getTargetNodeName
Mar 2 2020, 5:48 PM
Jim committed rGd40afadec0ac: [git-clang-format] Fix typo in help message (authored by Jim).
[git-clang-format] Fix typo in help message
Mar 2 2020, 2:19 AM
Jim created D75437: [AVR] Fix incorrect register state for LDRdPtr.
Mar 2 2020, 1:05 AM · Restricted Project

Mar 1 2020

Jim committed rGbfdb834bc3d5: [Sparc] Fix incorrect operand for matching CMPri pattern (authored by Jim).
[Sparc] Fix incorrect operand for matching CMPri pattern
Mar 1 2020, 7:35 PM
Jim closed D75227: [Sparc] Fix incorrect operand for matching CMPri pattern.
Mar 1 2020, 7:35 PM · Restricted Project

Feb 26 2020

Jim added a comment to D63973: [MachineVerifier] Improve checks of target instructions operands..

Fix sparc bug in https://reviews.llvm.org/D75227

Feb 26 2020, 9:35 PM · Restricted Project
Jim created D75227: [Sparc] Fix incorrect operand for matching CMPri pattern.
Feb 26 2020, 9:33 PM · Restricted Project

Feb 25 2020

Jim committed rGf6603aed59c6: [ARC][NFC] Remove trailing space (authored by Jim).
[ARC][NFC] Remove trailing space
Feb 25 2020, 9:40 PM

Feb 24 2020

Jim committed rG84c3d3f37a24: [Sparc][NFC] Remove trailing space (authored by Jim).
[Sparc][NFC] Remove trailing space
Feb 24 2020, 11:21 PM

Feb 20 2020

Jim committed rGe27b61c1ea3d: [XCore] Add instruction pattern for bitrev (authored by Jim).
[XCore] Add instruction pattern for bitrev
Feb 20 2020, 5:32 PM
Jim closed D74748: [XCore] Add instruction pattern for bitrev .
Feb 20 2020, 5:32 PM · Restricted Project

Feb 18 2020

Jim added inline comments to D74748: [XCore] Add instruction pattern for bitrev .
Feb 18 2020, 7:07 PM · Restricted Project
Jim committed rG492d4a992d88: [NFC] Update the testcase clang_f_opts.c for the removed options (authored by Jim).
[NFC] Update the testcase clang_f_opts.c for the removed options
Feb 18 2020, 5:27 PM
Jim committed rGea789f819f26: Remove unused option that gcc ignored (authored by Jim).
Remove unused option that gcc ignored
Feb 18 2020, 4:41 PM
Jim closed D72825: Remove unused option that gcc ignored.
Feb 18 2020, 4:41 PM · Restricted Project

Feb 17 2020

Jim committed rG466f8843f526: [NFC] Remove trailing space (authored by Jim).
[NFC] Remove trailing space
Feb 17 2020, 6:49 PM
Jim committed rGfa75bffbbbcf: [XCore][NFC] Remove trailing space (authored by Jim).
[XCore][NFC] Remove trailing space
Feb 17 2020, 6:39 PM
Jim created D74748: [XCore] Add instruction pattern for bitrev .
Feb 17 2020, 6:12 PM · Restricted Project
Jim added a comment to D72825: Remove unused option that gcc ignored.

ping?

Feb 17 2020, 6:03 PM · Restricted Project

Jan 21 2020

Jim committed rGdac7cda3a84e: [libcxxabi] NFC: Fix trivial typos in comments (authored by kiszk).
[libcxxabi] NFC: Fix trivial typos in comments
Jan 21 2020, 7:40 PM
Jim closed D72151: [libcxxabi] NFC: Fix trivial typos in comments.
Jan 21 2020, 7:40 PM · Restricted Project
Jim committed rGf65d4aa96082: [llvm] NFC: fix trivial typos in documents (authored by kiszk).
[llvm] NFC: fix trivial typos in documents
Jan 21 2020, 7:31 PM
Jim closed D73017: [llvm] NFC: fix trivial typos in documents.
Jan 21 2020, 7:31 PM · Restricted Project
Herald added a reviewer for D72624: [WIP] TargetMachine Hook for Module Metadata: nicolasvasilache.
Jan 21 2020, 1:35 AM · Restricted Project, Restricted Project, Restricted Project
Jim accepted D72151: [libcxxabi] NFC: Fix trivial typos in comments.
Jan 21 2020, 1:26 AM · Restricted Project
Jim accepted D73017: [llvm] NFC: fix trivial typos in documents.
Jan 21 2020, 1:26 AM · Restricted Project
Jim edited reviewers for D72434: Support offset of member designator with the arrow for __builtin_offsetof, added: efriedma; removed: eli.friedman.
Jan 21 2020, 1:17 AM · Restricted Project
Jim added inline comments to D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup.
Jan 21 2020, 1:17 AM · Restricted Project
Jim updated the diff for D72825: Remove unused option that gcc ignored.

Address the comment. Delete the options.

Jan 21 2020, 1:08 AM · Restricted Project

Jan 16 2020

Jim added a comment to D72825: Remove unused option that gcc ignored.

It should be kept for compatibility. These three options may be used in other projects compiled by gcc.
Clang should ignore it.
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html

Jan 16 2020, 5:47 PM · Restricted Project
Jim created D72825: Remove unused option that gcc ignored.
Jan 16 2020, 12:54 AM · Restricted Project
Jim updated the summary of D72825: Remove unused option that gcc ignored.
Jan 16 2020, 12:54 AM · Restricted Project
Jim added a reviewer for D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup: efriedma.
Jan 16 2020, 12:16 AM · Restricted Project

Jan 8 2020

Jim created D72434: Support offset of member designator with the arrow for __builtin_offsetof.
Jan 8 2020, 10:03 PM · Restricted Project
Jim added a reviewer for D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup: majnemer.
Jan 8 2020, 6:15 PM · Restricted Project

Jan 7 2020

Jim committed rGf7ca0c761979: [docs] Fix duplicate explicit target name: developer policy (authored by Jim).
[docs] Fix duplicate explicit target name: developer policy
Jan 7 2020, 6:46 PM
Jim added a comment to D72077: [docs] Improve HowTo commit changes from git.

Sorry about that I forgot to modify author information.

Jan 7 2020, 5:59 PM · Restricted Project
Jim committed rGf90a2c2d2cdb: [docs] Improve HowTo commit changes from git (authored by Jim).
[docs] Improve HowTo commit changes from git
Jan 7 2020, 5:51 PM
Jim closed D72077: [docs] Improve HowTo commit changes from git.
Jan 7 2020, 5:50 PM · Restricted Project
Jim accepted D72077: [docs] Improve HowTo commit changes from git.
Jan 7 2020, 5:44 PM · Restricted Project
Jim committed rG9de6a3987251: [libcxx] fix incorrect attribute property (authored by kiszk).
[libcxx] fix incorrect attribute property
Jan 7 2020, 5:32 PM
Jim closed D72314: [libcxx] fix incorrect attribute property.
Jan 7 2020, 5:32 PM · Restricted Project
Jim added a comment to D72314: [libcxx] fix incorrect attribute property.

It looks like test is passed now. Although I don't know why http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/1710 fails.

Jan 7 2020, 2:09 AM · Restricted Project
Jim committed rGab1bcda851d9: [NFC] Use isX86() instead of getArch() (authored by Jim).
[NFC] Use isX86() instead of getArch()
Jan 7 2020, 1:32 AM
Jim closed D72320: [NFC] Use isX86() instead of getArch().
Jan 7 2020, 1:32 AM · Restricted Project, Restricted Project
Jim created D72320: [NFC] Use isX86() instead of getArch().
Jan 7 2020, 1:13 AM · Restricted Project, Restricted Project

Jan 6 2020

Jim accepted D72314: [libcxx] fix incorrect attribute property.
Jan 6 2020, 10:13 PM · Restricted Project
Jim committed rG4c6a098ad52f: [OpenMP] NFC: Fix trivial typos in comments (authored by kiszk).
[OpenMP] NFC: Fix trivial typos in comments
Jan 6 2020, 10:04 PM
Jim closed D72285: [OpenMP] NFC: Fix trivial typos in comments.
Jan 6 2020, 10:04 PM · Restricted Project
Jim created D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup.
Jan 6 2020, 9:57 PM · Restricted Project
Jim accepted D72285: [OpenMP] NFC: Fix trivial typos in comments.

LGTM.

Jan 6 2020, 9:19 PM · Restricted Project
Jim added inline comments to D72285: [OpenMP] NFC: Fix trivial typos in comments.
Jan 6 2020, 6:52 PM · Restricted Project

Jan 2 2020

Jim committed rGabd707848bcd: [llvm-size] print a blank line between archieve members when using sysv format (authored by TH3CHARLie).
[llvm-size] print a blank line between archieve members when using sysv format
Jan 2 2020, 10:07 PM
Jim closed D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Jan 2 2020, 10:06 PM · Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

@TH3CHARLie
I can commit this for you.
git commit --amend --author="What-is-your-name <What-is-your-email-address>" ?
If you are interested in obtaining commit right. please refer to https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Jan 2 2020, 9:48 PM · Restricted Project
Jim accepted D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Jan 2 2020, 9:13 PM · Restricted Project
Jim added a comment to D69483: [PowerPC]: Fix predicate handling with SPE.

You can refer https://llvm.org/docs/Phabricator.html#committing-a-change to commit a change.
If your commit message has Differential Revision: <URL>, the differential will close automatically.
arc patch D<Revision> is used to fetch a differential from Phabricator.
https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator

Jan 2 2020, 6:44 PM · Restricted Project
Jim committed rGa050327064c7: [mlir] NFC: Fix broken links in docs (authored by kiszk).
[mlir] NFC: Fix broken links in docs
Jan 2 2020, 6:25 PM
Jim closed D72065: [mlir] NFC: Fix broken links in docs.
Jan 2 2020, 6:25 PM · Restricted Project
Jim added inline comments to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Jan 2 2020, 6:16 PM · Restricted Project
Jim committed rG8188c998ffa4: [docs] Update path to clang-tools-extra (authored by AlexanderLanin).
[docs] Update path to clang-tools-extra
Jan 2 2020, 3:30 AM
Jim closed D71982: [docs] Update path to clang-tools-extra.
Jan 2 2020, 3:30 AM · Restricted Project, Restricted Project
Jim requested changes to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Jan 2 2020, 3:11 AM · Restricted Project
Jim added inline comments to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Jan 2 2020, 2:52 AM · Restricted Project

Jan 1 2020

Jim added a comment to D71986: [compiler-rt] Fix typo..

Do you plan to land this change?

Jan 1 2020, 9:20 PM · Restricted Project, Restricted Project
Jim accepted D72065: [mlir] NFC: Fix broken links in docs.
Jan 1 2020, 9:11 PM · Restricted Project
Jim accepted D71957: [llvm-size] print a blank line between archieve members when using sysv format.

LGTM.

Jan 1 2020, 7:13 PM · Restricted Project
Jim added a comment to D71982: [docs] Update path to clang-tools-extra.

@AlexanderLanin
git commit --amend --author="What-is-your-name <What-is-your-email-address>" ?

Jan 1 2020, 5:42 PM · Restricted Project, Restricted Project

Dec 30 2019

Jim added a comment to D72014: [PowerPC]: Add powerpcspe target triple subarch component.

Could you add tests in llvm/unittests/ADT/TripleTest.cpp

Dec 30 2019, 10:13 PM · Restricted Project, Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

LGTM.
But I have tried gnu size, and I found that has two blank lines between archive members.
Here only one blank line.
What's your opinion?

Dec 30 2019, 6:41 PM · Restricted Project
Jim added inline comments to D71982: [docs] Update path to clang-tools-extra.
Dec 30 2019, 6:22 PM · Restricted Project, Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

There shows "Context not available."
Please follow https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface to upload patch.

Dec 30 2019, 2:32 AM · Restricted Project
Jim added inline comments to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Dec 30 2019, 1:56 AM · Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

The testcases tools/llvm-size/archive.test, tools/llvm-size/multiple-inputs.test and tools/llvm-size/radix.test
fail due to this patch. Could you update this testcases? You can try to execute command "ninja check-all -j32".

Dec 30 2019, 12:25 AM · Restricted Project

Dec 29 2019

Jim added a comment to D71982: [docs] Update path to clang-tools-extra.

There shows "Context not available".
Could you update for this?

Dec 29 2019, 11:12 PM · Restricted Project, Restricted Project
Jim accepted D71986: [compiler-rt] Fix typo..
Dec 29 2019, 9:56 PM · Restricted Project, Restricted Project

Dec 24 2019

Jim added inline comments to D70401: [WIP][RISCV] Implement ilp32e ABI.
Dec 24 2019, 7:41 PM · Restricted Project, Restricted Project
Jim accepted D71391: [PowerPC] Modify the hasSideEffects of some VSX instructions from 1 to 0.

LGTM.

Dec 24 2019, 7:32 PM · Restricted Project