Page MenuHomePhabricator

Jim (Jim Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2018, 10:24 PM (72 w, 5 d)

Recent Activity

Tue, Jan 21

Jim committed rGdac7cda3a84e: [libcxxabi] NFC: Fix trivial typos in comments (authored by kiszk).
[libcxxabi] NFC: Fix trivial typos in comments
Tue, Jan 21, 7:40 PM
Jim closed D72151: [libcxxabi] NFC: Fix trivial typos in comments.
Tue, Jan 21, 7:40 PM · Restricted Project
Jim committed rGf65d4aa96082: [llvm] NFC: fix trivial typos in documents (authored by kiszk).
[llvm] NFC: fix trivial typos in documents
Tue, Jan 21, 7:31 PM
Jim closed D73017: [llvm] NFC: fix trivial typos in documents.
Tue, Jan 21, 7:31 PM · Restricted Project
Herald added a reviewer for D72624: [WIP] TargetMachine Hook for Module Metadata: nicolasvasilache.
Tue, Jan 21, 1:35 AM · Restricted Project, Restricted Project, Restricted Project
Jim accepted D72151: [libcxxabi] NFC: Fix trivial typos in comments.
Tue, Jan 21, 1:26 AM · Restricted Project
Jim accepted D73017: [llvm] NFC: fix trivial typos in documents.
Tue, Jan 21, 1:26 AM · Restricted Project
Jim edited reviewers for D72434: Support offset of member designator with the arrow for __builtin_offsetof, added: efriedma; removed: eli.friedman.
Tue, Jan 21, 1:17 AM · Restricted Project
Jim added inline comments to D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup.
Tue, Jan 21, 1:17 AM · Restricted Project
Jim updated the diff for D72825: Remove unused option that gcc ignored.

Address the comment. Delete the options.

Tue, Jan 21, 1:08 AM · Restricted Project

Thu, Jan 16

Jim added a comment to D72825: Remove unused option that gcc ignored.

It should be kept for compatibility. These three options may be used in other projects compiled by gcc.
Clang should ignore it.
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html

Thu, Jan 16, 5:47 PM · Restricted Project
Jim created D72825: Remove unused option that gcc ignored.
Thu, Jan 16, 12:54 AM · Restricted Project
Jim updated the summary of D72825: Remove unused option that gcc ignored.
Thu, Jan 16, 12:54 AM · Restricted Project
Jim added a reviewer for D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup: efriedma.
Thu, Jan 16, 12:16 AM · Restricted Project

Wed, Jan 8

Jim created D72434: Support offset of member designator with the arrow for __builtin_offsetof.
Wed, Jan 8, 10:03 PM · Restricted Project
Jim added a reviewer for D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup: majnemer.
Wed, Jan 8, 6:15 PM · Restricted Project

Tue, Jan 7

Jim committed rGf7ca0c761979: [docs] Fix duplicate explicit target name: developer policy (authored by Jim).
[docs] Fix duplicate explicit target name: developer policy
Tue, Jan 7, 6:46 PM
Jim added a comment to D72077: [docs] Improve HowTo commit changes from git.

Sorry about that I forgot to modify author information.

Tue, Jan 7, 5:59 PM · Restricted Project
Jim committed rGf90a2c2d2cdb: [docs] Improve HowTo commit changes from git (authored by Jim).
[docs] Improve HowTo commit changes from git
Tue, Jan 7, 5:51 PM
Jim closed D72077: [docs] Improve HowTo commit changes from git.
Tue, Jan 7, 5:50 PM · Restricted Project
Jim accepted D72077: [docs] Improve HowTo commit changes from git.
Tue, Jan 7, 5:44 PM · Restricted Project
Jim committed rG9de6a3987251: [libcxx] fix incorrect attribute property (authored by kiszk).
[libcxx] fix incorrect attribute property
Tue, Jan 7, 5:32 PM
Jim closed D72314: [libcxx] fix incorrect attribute property.
Tue, Jan 7, 5:32 PM · Restricted Project
Jim added a comment to D72314: [libcxx] fix incorrect attribute property.

It looks like test is passed now. Although I don't know why http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/1710 fails.

Tue, Jan 7, 2:09 AM · Restricted Project
Jim committed rGab1bcda851d9: [NFC] Use isX86() instead of getArch() (authored by Jim).
[NFC] Use isX86() instead of getArch()
Tue, Jan 7, 1:32 AM
Jim closed D72320: [NFC] Use isX86() instead of getArch().
Tue, Jan 7, 1:32 AM · Restricted Project, Restricted Project
Jim created D72320: [NFC] Use isX86() instead of getArch().
Tue, Jan 7, 1:13 AM · Restricted Project, Restricted Project

Mon, Jan 6

Jim accepted D72314: [libcxx] fix incorrect attribute property.
Mon, Jan 6, 10:13 PM · Restricted Project
Jim committed rG4c6a098ad52f: [OpenMP] NFC: Fix trivial typos in comments (authored by kiszk).
[OpenMP] NFC: Fix trivial typos in comments
Mon, Jan 6, 10:04 PM
Jim closed D72285: [OpenMP] NFC: Fix trivial typos in comments.
Mon, Jan 6, 10:04 PM · Restricted Project
Jim created D72315: [NFC] Simplifying the condition which kind of MCFragment doesn't need to handle fixup.
Mon, Jan 6, 9:57 PM · Restricted Project
Jim accepted D72285: [OpenMP] NFC: Fix trivial typos in comments.

LGTM.

Mon, Jan 6, 9:19 PM · Restricted Project
Jim added inline comments to D72285: [OpenMP] NFC: Fix trivial typos in comments.
Mon, Jan 6, 6:52 PM · Restricted Project

Thu, Jan 2

Jim committed rGabd707848bcd: [llvm-size] print a blank line between archieve members when using sysv format (authored by TH3CHARLie).
[llvm-size] print a blank line between archieve members when using sysv format
Thu, Jan 2, 10:07 PM
Jim closed D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Thu, Jan 2, 10:06 PM · Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

@TH3CHARLie
I can commit this for you.
git commit --amend --author="What-is-your-name <What-is-your-email-address>" ?
If you are interested in obtaining commit right. please refer to https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Thu, Jan 2, 9:48 PM · Restricted Project
Jim accepted D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Thu, Jan 2, 9:13 PM · Restricted Project
Jim added a comment to D69483: [PowerPC]: Fix predicate handling with SPE.

You can refer https://llvm.org/docs/Phabricator.html#committing-a-change to commit a change.
If your commit message has Differential Revision: <URL>, the differential will close automatically.
arc patch D<Revision> is used to fetch a differential from Phabricator.
https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator

Thu, Jan 2, 6:44 PM · Restricted Project
Jim committed rGa050327064c7: [mlir] NFC: Fix broken links in docs (authored by kiszk).
[mlir] NFC: Fix broken links in docs
Thu, Jan 2, 6:25 PM
Jim closed D72065: [mlir] NFC: Fix broken links in docs.
Thu, Jan 2, 6:25 PM · Restricted Project
Jim added inline comments to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Thu, Jan 2, 6:16 PM · Restricted Project
Jim committed rG8188c998ffa4: [docs] Update path to clang-tools-extra (authored by AlexanderLanin).
[docs] Update path to clang-tools-extra
Thu, Jan 2, 3:30 AM
Jim closed D71982: [docs] Update path to clang-tools-extra.
Thu, Jan 2, 3:30 AM · Restricted Project, Restricted Project
Jim requested changes to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Thu, Jan 2, 3:11 AM · Restricted Project
Jim added inline comments to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Thu, Jan 2, 2:52 AM · Restricted Project

Wed, Jan 1

Jim added a comment to D71986: [compiler-rt] Fix typo..

Do you plan to land this change?

Wed, Jan 1, 9:20 PM · Restricted Project, Restricted Project
Jim accepted D72065: [mlir] NFC: Fix broken links in docs.
Wed, Jan 1, 9:11 PM · Restricted Project
Jim accepted D71957: [llvm-size] print a blank line between archieve members when using sysv format.

LGTM.

Wed, Jan 1, 7:13 PM · Restricted Project
Jim added a comment to D71982: [docs] Update path to clang-tools-extra.

@AlexanderLanin
git commit --amend --author="What-is-your-name <What-is-your-email-address>" ?

Wed, Jan 1, 5:42 PM · Restricted Project, Restricted Project

Mon, Dec 30

Jim added a comment to D72014: [PowerPC]: Add powerpcspe target triple subarch component.

Could you add tests in llvm/unittests/ADT/TripleTest.cpp

Mon, Dec 30, 10:13 PM · Restricted Project, Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

LGTM.
But I have tried gnu size, and I found that has two blank lines between archive members.
Here only one blank line.
What's your opinion?

Mon, Dec 30, 6:41 PM · Restricted Project
Jim added inline comments to D71982: [docs] Update path to clang-tools-extra.
Mon, Dec 30, 6:22 PM · Restricted Project, Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

There shows "Context not available."
Please follow https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface to upload patch.

Mon, Dec 30, 2:32 AM · Restricted Project
Jim added inline comments to D71957: [llvm-size] print a blank line between archieve members when using sysv format.
Mon, Dec 30, 1:56 AM · Restricted Project
Jim added a comment to D71957: [llvm-size] print a blank line between archieve members when using sysv format.

The testcases tools/llvm-size/archive.test, tools/llvm-size/multiple-inputs.test and tools/llvm-size/radix.test
fail due to this patch. Could you update this testcases? You can try to execute command "ninja check-all -j32".

Mon, Dec 30, 12:25 AM · Restricted Project

Sun, Dec 29

Jim added a comment to D71982: [docs] Update path to clang-tools-extra.

There shows "Context not available".
Could you update for this?

Sun, Dec 29, 11:12 PM · Restricted Project, Restricted Project
Jim accepted D71986: [compiler-rt] Fix typo..
Sun, Dec 29, 9:56 PM · Restricted Project, Restricted Project

Dec 24 2019

Jim added inline comments to D70401: [WIP][RISCV] Implement ilp32e ABI.
Dec 24 2019, 7:41 PM · Restricted Project, Restricted Project
Jim accepted D71391: [PowerPC] Modify the hasSideEffects of some VSX instructions from 1 to 0.

LGTM.

Dec 24 2019, 7:32 PM · Restricted Project

Dec 23 2019

Jim accepted D71844: [docs] fix typo in Lexicon.rst.
Dec 23 2019, 10:53 PM · Restricted Project

Dec 22 2019

Jim committed rGda0fe5db999b: [AVR] Fix codegen for rotate instructions (authored by Jim).
[AVR] Fix codegen for rotate instructions
Dec 22 2019, 7:46 PM
Jim closed D60365: [AVR] Fix codegen for rotate instructions.
Dec 22 2019, 7:46 PM · Restricted Project
Jim added a comment to D45677: [libcxx] [test] Fix typo in filesystem test .

This is fixed by https://reviews.llvm.org/rG437e0e5191ca255db27e86d232020844c1fd08c8.

Dec 22 2019, 7:18 PM

Dec 18 2019

Jim added a comment to D71541: [NFC] [Clang]: fix spelling mistake in assert message.

Do you need someone to commit this change for you?

Dec 18 2019, 9:16 PM · Restricted Project
Jim added a comment to D71646: [NFC][InlineCost] Run clang-format on InlineCost.cpp.

Could add "[NFC]" in the title.
That means "No Function Change".

Dec 18 2019, 12:10 AM · Restricted Project

Dec 17 2019

Jim added a reviewer for D71645: [NFC][InlineCost] Simplify internal inlining cost interface: Jim.
Dec 17 2019, 11:49 PM · Restricted Project
Jim added a comment to D71645: [NFC][InlineCost] Simplify internal inlining cost interface.

It looks like some of changes are the same as this patch https://reviews.llvm.org/D71646.
Please based on https://reviews.llvm.org/D71646 this patch to make change.

Dec 17 2019, 11:49 PM · Restricted Project
Jim accepted D71541: [NFC] [Clang]: fix spelling mistake in assert message.
Dec 17 2019, 10:53 PM · Restricted Project

Dec 16 2019

Jim added inline comments to D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 16 2019, 11:03 PM · Restricted Project
Jim added a comment to D71571: [NFC] [AArch64] Adding LLVM_FALLTHROUGH to ISelDAGToDAG..

This is fixed by https://reviews.llvm.org/rG002adabb3a251a81ef304353eefb1bf96ec388f6.

Dec 16 2019, 10:44 PM · Restricted Project
Jim added inline comments to D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 16 2019, 10:34 PM · Restricted Project
Jim requested changes to D71541: [NFC] [Clang]: fix spelling mistake in assert message.
Dec 16 2019, 9:59 PM · Restricted Project
Jim added a comment to D71541: [NFC] [Clang]: fix spelling mistake in assert message.

Could you add "[NFC]" in the title.
That means No Function Change.

Dec 16 2019, 9:59 PM · Restricted Project
Jim abandoned D63068: [AVR] Fix incorrect stack parameter push order.

Ok. Thanks

Dec 16 2019, 9:59 PM · Restricted Project
Jim added a comment to D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO.

This patch is only for RISCV.
The title should have prefix "[RISCV]".

Dec 16 2019, 9:13 PM · Restricted Project
Jim added a comment to D66839: Fix stack address builtin for negative numbers.

I think this checking should be implemented in lib/Sema/SemaChecking.cpp.

Dec 16 2019, 1:54 AM · Restricted Project
Herald added a project to D51120: clang-format Additional Indent for class blocks: Restricted Project.
Dec 16 2019, 1:00 AM · Restricted Project
Jim added a comment to D61549: Fix use of 'is' operator for comparison.

@j-carl Could you give a Python 3.8 syntax reference for this change.

Dec 16 2019, 12:14 AM · Restricted Project

Dec 15 2019

Jim added a comment to D69483: [PowerPC]: Fix predicate handling with SPE.

A few nits.
You can use git-clang-format to format your patch for following llvm coding style.

Dec 15 2019, 10:52 PM · Restricted Project
Herald updated subscribers of D71287: [PowerPC] Use fcti[dw] instructions in additional cases.
Dec 15 2019, 10:18 PM · Restricted Project
Jim added inline comments to D71324: [PowerPC] Exploit `vrl(b|h|w|d)` to perform vector rotation.
Dec 15 2019, 10:18 PM · Restricted Project
Jim added a comment to D71390: [PowerPC] Modify the hasSideEffects of MTLR and MFLR from 1 to 0.

If an instruction has side effects, it would be a scheduling barrier.
Not any instruction can be scheduled crossing it.

Dec 15 2019, 7:26 PM · Restricted Project
Jim accepted D71455: [NFC] Fix typos in Clangd and Clang.
Dec 15 2019, 6:43 PM · Restricted Project
Jim committed rG7e0fd77645cf: [PowerPC] Fix %llvm.ppc.altivec.vc* lowering (authored by Jim).
[PowerPC] Fix %llvm.ppc.altivec.vc* lowering
Dec 15 2019, 6:23 PM
Jim closed D71138: [PowerPC] Fix %llvm.ppc.altivec.vc* lowering.
Dec 15 2019, 6:22 PM · Restricted Project
Jim added a comment to D71138: [PowerPC] Fix %llvm.ppc.altivec.vc* lowering.

I have committed this patch for you.
If you are interested in obtaining the commit right. you can refer to https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access.

Dec 15 2019, 6:22 PM · Restricted Project

Dec 12 2019

Jim added a comment to D71374: Improve support of GNU mempcpy.

I am curious what is difference of code generation after applying your changes?

Dec 12 2019, 11:10 PM · Restricted Project
Jim accepted D71138: [PowerPC] Fix %llvm.ppc.altivec.vc* lowering.

LGTM, I have verified it.

Dec 12 2019, 10:43 PM · Restricted Project
Jim added a comment to D71138: [PowerPC] Fix %llvm.ppc.altivec.vc* lowering.

Link http://llvm.org/44239 is not available.

Dec 12 2019, 9:34 PM · Restricted Project
Jim committed rG4daa8d1de6dd: Correct inf typo (authored by gaul).
Correct inf typo
Dec 12 2019, 7:01 PM
Jim closed D57732: Correct inf typo.
Dec 12 2019, 7:01 PM · Restricted Project
Jim added a comment to D70731: [NFC][AArch64] Fix typo..

Hi, I can help to commit it for you.
You can obtain the commit right by following https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access.

Dec 12 2019, 6:34 PM · Restricted Project
Jim added a comment to D57732: Correct inf typo.

I can commit it for you.
If you are interested in obtaining the commit right. you can refer https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access.

Dec 12 2019, 6:34 PM · Restricted Project
Jim committed rGbc16666de430: [NFC][AArch64] Fix typo. (authored by ncv).
[NFC][AArch64] Fix typo.
Dec 12 2019, 6:25 PM
Jim closed D70731: [NFC][AArch64] Fix typo..
Dec 12 2019, 6:24 PM · Restricted Project
Jim added a comment to D57732: Correct inf typo.

Do you need someone to commit this change for you?

Dec 12 2019, 2:53 AM · Restricted Project
Herald added a project to D53999: Fix typo in LLVMCreateOprofileJITEventListener: Restricted Project.

This is fixed by https://reviews.llvm.org/rL345960

Dec 12 2019, 2:53 AM · Restricted Project
Herald added a project to D29112: NFC: Fix typo in Statepoint documentation: Restricted Project.

Do you need someone to commit this change for you?

Dec 12 2019, 2:27 AM · Restricted Project
Jim added a comment to D71359: Fix assertion failure in getMemOperandWithOffsetWidth.

Could you remove "[PATCH]" from the title?

Dec 12 2019, 2:07 AM · Restricted Project
Jim added a comment to D71391: [PowerPC] Modify the hasSideEffects of some VSX instructions from 1 to 0.

Hi @ZhangKang
You may follow @lkail 's suggestion is fine.
I am not a PowerPC guy. Just give some suggestions.

Dec 12 2019, 1:30 AM · Restricted Project