Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Jim (Jim Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2018, 10:24 PM (263 w, 3 d)

Recent Activity

Mon, Sep 4

Jim added inline comments to D159427: [InlineAsm] Add constraint A to getMemConstraintName.
Mon, Sep 4, 7:25 PM · Restricted Project, Restricted Project

Thu, Aug 31

Jim committed rG10c86197010e: [RISCV] Remove unused check prefixes for tests. NFC (authored by Jim).
[RISCV] Remove unused check prefixes for tests. NFC
Thu, Aug 31, 7:44 PM · Restricted Project, Restricted Project

Wed, Aug 30

Jim committed rGc1dda0f7934d: [AST] Remove unneeded `return false` from UseExcessPrecision. NFC. (authored by Jim).
[AST] Remove unneeded `return false` from UseExcessPrecision. NFC.
Wed, Aug 30, 1:08 AM · Restricted Project, Restricted Project

Tue, Aug 29

Jim committed rGd099dbb221a4: [git-clang-format] Fix typo in help message (authored by Jim).
[git-clang-format] Fix typo in help message
Tue, Aug 29, 11:12 PM · Restricted Project, Restricted Project
Jim added reviewers for D159152: [RISCV] Support fmaximum/fminimum for fp16 vector when only Zvfhmin enabled: jacquesguan, craig.topper, michaelmaitland.
Tue, Aug 29, 7:04 PM · Restricted Project, Restricted Project
Jim requested review of D159152: [RISCV] Support fmaximum/fminimum for fp16 vector when only Zvfhmin enabled.
Tue, Aug 29, 7:03 PM · Restricted Project, Restricted Project

Mon, Aug 28

Jim committed rG8ac62845ff4e: [Clang][RISCV][NFC] Re-run update_cc_test_checks.py on riscv-rvv-vls-*.c (authored by Jim).
[Clang][RISCV][NFC] Re-run update_cc_test_checks.py on riscv-rvv-vls-*.c
Mon, Aug 28, 8:37 PM · Restricted Project, Restricted Project
Jim committed rGb91b4ece349e: [RISCV] Add missing mask operand for masked vclmul/vclmulh tests. NFC. (authored by Jim).
[RISCV] Add missing mask operand for masked vclmul/vclmulh tests. NFC.
Mon, Aug 28, 2:40 AM · Restricted Project, Restricted Project

Sun, Aug 27

Jim committed rG57aee4ea69c7: [RISCV] Add check-prefixes ZVFH for zvfh and CHECK for zvfhmin. NFC. (authored by Jim).
[RISCV] Add check-prefixes ZVFH for zvfh and CHECK for zvfhmin. NFC.
Sun, Aug 27, 8:16 PM · Restricted Project, Restricted Project
Jim added inline comments to D158839: [SDAG] Add SimplifyDemandedBits support for ISD::SPLAT_VECTOR.
Sun, Aug 27, 8:00 PM · Restricted Project, Restricted Project
Jim added a comment to D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions.

It is also needed to add pre-defined macro test in clang/test/Preprocessor/riscv-target-features.c

Sun, Aug 27, 7:09 PM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2023

Jim added inline comments to D158256: [RISCV] Fix assertion failure when zcmp extension is enabled..
Aug 24 2023, 6:30 PM · Restricted Project, Restricted Project

Aug 22 2023

Jim added inline comments to D158492: [RISCV] Add CSR RegisterClass and save/restore fcsr in interrupt.
Aug 22 2023, 2:39 AM · Restricted Project, Restricted Project
Jim committed rGbdac6de215ca: [RISCV] Make the style of class definition in RISCVInstrInfoVPseudos.td to be… (authored by Jim).
[RISCV] Make the style of class definition in RISCVInstrInfoVPseudos.td to be…
Aug 22 2023, 12:05 AM · Restricted Project, Restricted Project

Aug 21 2023

Jim added inline comments to D158259: [clang][RISCV] Support operators for RVV sizeless vector types.
Aug 21 2023, 10:59 PM · Restricted Project, Restricted Project
Jim added inline comments to D158402: [Clang][RISCV] Add vcreate intrinsics for RVV tuple types.
Aug 21 2023, 10:38 PM · Restricted Project, Restricted Project
Jim added inline comments to D158259: [clang][RISCV] Support operators for RVV sizeless vector types.
Aug 21 2023, 10:33 PM · Restricted Project, Restricted Project
Jim added inline comments to D157417: [RISCV][SelectionDAG] Lower shuffles as bitrotates with vror.vi when possible.
Aug 21 2023, 6:14 PM · Restricted Project, Restricted Project

Aug 20 2023

Jim committed rG01da5b9438a9: [RISCV] Remove trailing whitespace. NFC. (authored by Jim).
[RISCV] Remove trailing whitespace. NFC.
Aug 20 2023, 7:02 PM · Restricted Project, Restricted Project

Aug 18 2023

Jim committed rG18f5ada24453: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT… (authored by Jim).
[DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT…
Aug 18 2023, 9:54 PM · Restricted Project, Restricted Project
Jim closed D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..
Aug 18 2023, 9:54 PM · Restricted Project, Restricted Project
Jim added a comment to D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..

Thanks, LGTM.
Sorry for the late reply, I was on vacation.

Aug 18 2023, 9:46 PM · Restricted Project, Restricted Project
Jim committed rGf3c0eaeb2eb2: [RISCV] Rename Ventana DecoderNamespace to XVentana for matching other… (authored by Jim).
[RISCV] Rename Ventana DecoderNamespace to XVentana for matching other…
Aug 18 2023, 9:45 PM · Restricted Project, Restricted Project
Jim committed rG974c6393297c: [M68k] Add MC support for bchg, bclr and bset instruction (authored by Jim).
[M68k] Add MC support for bchg, bclr and bset instruction
Aug 18 2023, 8:54 PM · Restricted Project, Restricted Project
Jim closed D116993: [M68k] Add MC support for bchg, bclr and bset instruction.
Aug 18 2023, 8:54 PM · Restricted Project, Restricted Project
Jim updated the diff for D116993: [M68k] Add MC support for bchg, bclr and bset instruction.

Address comment.

Aug 18 2023, 8:44 PM · Restricted Project, Restricted Project
Jim updated the diff for D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..

Rebase

Aug 18 2023, 1:28 AM · Restricted Project, Restricted Project

Aug 17 2023

Jim committed rGaf7231d1835b: [RISCV] Make the order of tests in riscv-target-features.c eqaul to the… (authored by Jim).
[RISCV] Make the order of tests in riscv-target-features.c eqaul to the…
Aug 17 2023, 10:01 PM · Restricted Project, Restricted Project

Aug 13 2023

Jim added a comment to D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..

kindly ping.

Aug 13 2023, 8:05 PM · Restricted Project, Restricted Project
Jim updated the summary of D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..
Aug 13 2023, 8:03 PM · Restricted Project, Restricted Project

Aug 9 2023

Jim updated the diff for D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..

Rebase

Aug 9 2023, 11:46 PM · Restricted Project, Restricted Project
Jim committed rGab34bf39e67c: [RISCV] Remove RISCVSaturatingBinaryAAShiftUnMasked/Masked and… (authored by Jim).
[RISCV] Remove RISCVSaturatingBinaryAAShiftUnMasked/Masked and…
Aug 9 2023, 2:15 AM · Restricted Project, Restricted Project
Jim closed D157473: [RISCV] Remove RISCVSaturatingBinaryAAShiftUnMasked/Masked and RISCVSaturatingBinaryABShiftUnMasked/Masked. NFC..
Aug 9 2023, 2:14 AM · Restricted Project, Restricted Project

Aug 8 2023

Jim added a comment to D157472: [RISCV] Fix rlist grammar for cm.push, cm.popret, cm.popretz and cm.pop in RISCV zcmp Extension.

No testcase changed? At least llvm/test/MC/RISCV/rv32zcmp-valid.s.

Aug 8 2023, 11:56 PM · Restricted Project, Restricted Project
Jim added reviewers for D157473: [RISCV] Remove RISCVSaturatingBinaryAAShiftUnMasked/Masked and RISCVSaturatingBinaryABShiftUnMasked/Masked. NFC.: eopXD, craig.topper.
Aug 8 2023, 10:16 PM · Restricted Project, Restricted Project
Jim requested review of D157473: [RISCV] Remove RISCVSaturatingBinaryAAShiftUnMasked/Masked and RISCVSaturatingBinaryABShiftUnMasked/Masked. NFC..
Aug 8 2023, 10:14 PM · Restricted Project, Restricted Project

Aug 7 2023

Jim committed rG767ca3a70d6d: [RISCV] Remove pre-defined macro test for b extension. NFC. (authored by Jim).
[RISCV] Remove pre-defined macro test for b extension. NFC.
Aug 7 2023, 10:03 PM · Restricted Project, Restricted Project
Jim closed D157353: [RISCV] Remove pre-defined macro test for b extension. NFC..
Aug 7 2023, 10:02 PM · Restricted Project, Restricted Project
Jim added a reviewer for D116993: [M68k] Add MC support for bchg, bclr and bset instruction: glaubitz.
Aug 7 2023, 8:10 PM · Restricted Project, Restricted Project
Jim added a reviewer for D157353: [RISCV] Remove pre-defined macro test for b extension. NFC.: craig.topper.
Aug 7 2023, 8:08 PM · Restricted Project, Restricted Project
Jim requested review of D157353: [RISCV] Remove pre-defined macro test for b extension. NFC..
Aug 7 2023, 8:07 PM · Restricted Project, Restricted Project
Jim committed rGf2bdc29f3e5d: [RISCV] Add a blank line after end of RUN lines. NFC. (authored by Jim).
[RISCV] Add a blank line after end of RUN lines. NFC.
Aug 7 2023, 3:40 AM · Restricted Project, Restricted Project
Jim committed rG5f94f3b7eac8: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC. (authored by Jim).
[RISCV] Refine getMaxPushPopReg like getLibCallID. NFC.
Aug 7 2023, 12:17 AM · Restricted Project, Restricted Project
Jim closed D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..
Aug 7 2023, 12:17 AM · Restricted Project, Restricted Project

Aug 6 2023

Jim committed rGd7abafa6a03f: [RISCV] Remove -menable-experimental-extensions option for zc extension in… (authored by Jim).
[RISCV] Remove -menable-experimental-extensions option for zc extension in…
Aug 6 2023, 11:04 PM · Restricted Project, Restricted Project
Jim updated the diff for D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..

Rebase

Aug 6 2023, 8:14 PM · Restricted Project, Restricted Project

Aug 3 2023

Jim committed rGa2938ba70727: [RISCV] Add tests that m extension enabled in extractelt-int-rv64.ll. NFC. (authored by Jim).
[RISCV] Add tests that m extension enabled in extractelt-int-rv64.ll. NFC.
Aug 3 2023, 12:35 AM · Restricted Project, Restricted Project

Aug 2 2023

Jim committed rG40cc106fa09e: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction (authored by Jim).
[RISCV] Scalarize binop followed by extractelement to custom lowered instruction
Aug 2 2023, 10:03 PM · Restricted Project, Restricted Project
Jim closed D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.
Aug 2 2023, 10:03 PM · Restricted Project, Restricted Project

Aug 1 2023

Jim added a comment to D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..

https://github.com/llvm/llvm-project-release-prs/pull/513

Aug 1 2023, 11:43 PM · Restricted Project, Restricted Project
Jim added inline comments to D152793: [RISCV] Add MC layer support for Zicfiss..
Aug 1 2023, 11:25 PM · Restricted Project, Restricted Project, Restricted Project
Jim added a comment to D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..

LGTM, and I think this should go to LLVM 17 branch, so don't forgot to create github issue for backport :)

Aug 1 2023, 10:16 PM · Restricted Project, Restricted Project
Jim committed rGd6a48a348ad0: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push. (authored by Jim).
[RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push.
Aug 1 2023, 10:10 PM · Restricted Project, Restricted Project
Jim closed D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..
Aug 1 2023, 10:09 PM · Restricted Project, Restricted Project
Jim committed rG1c1066797c5b: [AST] Simplify Type::isSizelessBuiltinType(). NFC. (authored by Jim).
[AST] Simplify Type::isSizelessBuiltinType(). NFC.
Aug 1 2023, 7:47 PM · Restricted Project, Restricted Project
Jim closed D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC..
Aug 1 2023, 7:47 PM · Restricted Project, Restricted Project
Jim updated the diff for D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.

Update comment.

Aug 1 2023, 7:13 PM · Restricted Project, Restricted Project
Jim updated the diff for D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..

Address @kito-cheng's comment.

Aug 1 2023, 6:54 PM · Restricted Project, Restricted Project

Jul 31 2023

Jim updated the diff for D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC..

Address comment.

Jul 31 2023, 11:07 PM · Restricted Project, Restricted Project
Jim added a reviewer for D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.: craig.topper.
Jul 31 2023, 8:38 PM · Restricted Project, Restricted Project
Jim updated the summary of D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.
Jul 31 2023, 7:01 PM · Restricted Project, Restricted Project
Jim retitled D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction from [RISCV] Scalarize binop followed by extractelement to W instruction on RV64 to [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.
Jul 31 2023, 7:00 PM · Restricted Project, Restricted Project
Jim added a comment to D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.

It's not clear to me this should be restricted to i64 and i32 either. An i16 or i8 add for example doesn't require any extra code unless the result needs to be sign/zero extended.

Jul 31 2023, 6:49 PM · Restricted Project, Restricted Project
Jim updated the diff for D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..

Address comments.

Jul 31 2023, 6:03 PM · Restricted Project, Restricted Project
Jim added inline comments to D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.
Jul 31 2023, 7:59 AM · Restricted Project, Restricted Project
Jim updated the diff for D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.

Address @craig.topper's comment

Jul 31 2023, 7:49 AM · Restricted Project, Restricted Project
Jim added reviewers for D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction: jacquesguan, craig.topper.
Jul 31 2023, 7:15 AM · Restricted Project, Restricted Project
Jim requested review of D156692: [RISCV] Scalarize binop followed by extractelement to custom lowered instruction.
Jul 31 2023, 7:14 AM · Restricted Project, Restricted Project
Jim added a comment to D156685: [RISCV] Match ext + ext + srem + trunc to vrem.vv.

Could you have pre-commit test for easily showing the change of this patch?

Jul 31 2023, 6:52 AM · Restricted Project, Restricted Project
Jim added a reviewer for D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC.: kazu.
Jul 31 2023, 6:19 AM · Restricted Project, Restricted Project
Jim requested review of D156686: [AST] Simplify Type::isSizelessBuiltinType(). NFC..
Jul 31 2023, 6:19 AM · Restricted Project, Restricted Project
Jim added inline comments to D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..
Jul 31 2023, 2:40 AM · Restricted Project, Restricted Project
Jim retitled D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push. from [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push/pop. to [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..
Jul 31 2023, 2:22 AM · Restricted Project, Restricted Project

Jul 30 2023

Jim committed rGf2e44238ee35: [RISCV] Clean up RISCVInstrInfoXTHead.td to look like the same style with other… (authored by Jim).
[RISCV] Clean up RISCVInstrInfoXTHead.td to look like the same style with other…
Jul 30 2023, 11:39 PM · Restricted Project, Restricted Project
Jim updated the summary of D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..
Jul 30 2023, 11:10 PM · Restricted Project, Restricted Project
Jim added reviewers for D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal.: sebastian-ne, craig.topper.
Jul 30 2023, 11:09 PM · Restricted Project, Restricted Project
Jim requested review of D156645: [DAGCombiner] Don't reduce BUILD_VECTOR to BITCAST before LegalizeTypes if VT is legal..
Jul 30 2023, 11:08 PM · Restricted Project, Restricted Project

Jul 27 2023

Jim abandoned D156507: [RISCV] Upgrade Zihintntl extension to version 1.0 and move out of experimental state..
Jul 27 2023, 11:48 PM · Restricted Project, Restricted Project, Restricted Project
Jim added reviewers for D156507: [RISCV] Upgrade Zihintntl extension to version 1.0 and move out of experimental state.: BeMg, craig.topper.
Jul 27 2023, 11:18 PM · Restricted Project, Restricted Project, Restricted Project
Jim requested review of D156507: [RISCV] Upgrade Zihintntl extension to version 1.0 and move out of experimental state..
Jul 27 2023, 11:15 PM · Restricted Project, Restricted Project, Restricted Project
Jim accepted D156407: [RISCV] Use max pushed register to get pushed register number..

LGTM, but wait other review's approve.

Jul 27 2023, 7:56 PM · Restricted Project, Restricted Project
Jim retitled D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push. from [RISCV] Reverse CFI offset order for callee-saved registers stored by Zcmp push for correct stack unwinding. to [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push/pop..
Jul 27 2023, 7:50 PM · Restricted Project, Restricted Project
Jim added inline comments to D156407: [RISCV] Use max pushed register to get pushed register number..
Jul 27 2023, 6:30 PM · Restricted Project, Restricted Project
Jim added reviewers for D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push.: VincentWu, fakepaper56, craig.topper, kito-cheng, KYG.
Jul 27 2023, 7:40 AM · Restricted Project, Restricted Project
Jim updated the diff for D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..

Fix comment

Jul 27 2023, 7:38 AM · Restricted Project, Restricted Project
Jim requested review of D156437: [RISCV] Fix the CFI offset for callee-saved registers stored by Zcmp push..
Jul 27 2023, 7:36 AM · Restricted Project, Restricted Project
Jim added a comment to D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..

So actually it's a NFC?

Jul 27 2023, 2:17 AM · Restricted Project, Restricted Project
Jim retitled D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC. from [RISCV] Refine getMaxPushPopReg like getLibCallID to [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..
Jul 27 2023, 2:15 AM · Restricted Project, Restricted Project
Jim retitled D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC. from [RISCV] Fix getMaxPushPopReg like getLibCallID to [RISCV] Refine getMaxPushPopReg like getLibCallID.
Jul 27 2023, 2:01 AM · Restricted Project, Restricted Project
Jim updated the diff for D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..

Address @fakepaper56's comment.

Jul 27 2023, 1:50 AM · Restricted Project, Restricted Project
Jim updated the summary of D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..
Jul 27 2023, 12:00 AM · Restricted Project, Restricted Project

Jul 26 2023

Jim added a comment to D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..

testcase?

Jul 26 2023, 11:00 PM · Restricted Project, Restricted Project
Jim added reviewers for D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC.: VincentWu, fakepaper56, craig.topper, kito-cheng.
Jul 26 2023, 10:32 PM · Restricted Project, Restricted Project
Jim requested review of D156393: [RISCV] Refine getMaxPushPopReg like getLibCallID. NFC..
Jul 26 2023, 10:30 PM · Restricted Project, Restricted Project
Jim committed rGfa140fe21183: [RISCV] Simplify tablegen for XCV mac and mul instructions. NFC. (authored by Jim).
[RISCV] Simplify tablegen for XCV mac and mul instructions. NFC.
Jul 26 2023, 10:06 PM · Restricted Project, Restricted Project
Jim closed D156335: [RISCV] Simplify tablegen for XCV mac and mul instructions. NFC..
Jul 26 2023, 10:05 PM · Restricted Project, Restricted Project
Jim updated the diff for D156335: [RISCV] Simplify tablegen for XCV mac and mul instructions. NFC..

Address comment

Jul 26 2023, 6:11 PM · Restricted Project, Restricted Project
Jim added reviewers for D156335: [RISCV] Simplify tablegen for XCV mac and mul instructions. NFC.: melonedo, realqhc, craig.topper.
Jul 26 2023, 7:39 AM · Restricted Project, Restricted Project
Jim requested review of D156335: [RISCV] Simplify tablegen for XCV mac and mul instructions. NFC..
Jul 26 2023, 7:38 AM · Restricted Project, Restricted Project
Jim committed rG657f8b35007c: [RISCV] Fix incorrect return type of isPushable() to bool. NFC. (authored by Jim).
[RISCV] Fix incorrect return type of isPushable() to bool. NFC.
Jul 26 2023, 2:08 AM · Restricted Project, Restricted Project