Page MenuHomePhabricator

Jim (Jim Lin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2018, 10:24 PM (145 w, 4 d)

Recent Activity

Today

Jim added a comment to D95588: [RISCV] Implement the MC layer support of P extension.

ping? Thanks.

Mon, Jun 21, 3:17 AM · Restricted Project, Restricted Project
Jim added a reviewer for D104626: [M68k] Refactor codegen patterns for logic operations and add tests for it: myhsu.
Mon, Jun 21, 2:47 AM · Restricted Project
Jim requested review of D104626: [M68k] Refactor codegen patterns for logic operations and add tests for it.
Mon, Jun 21, 2:46 AM · Restricted Project

Yesterday

Jim updated the diff for D95588: [RISCV] Implement the MC layer support of P extension.

Fix comment 0.9 to 0.93

Sun, Jun 20, 5:59 PM · Restricted Project, Restricted Project
Jim committed rG912b3b03489b: [IVDescriptors] Fix comment that getUnsafeAlgebraInst has been renamed to… (authored by Jim).
[IVDescriptors] Fix comment that getUnsafeAlgebraInst has been renamed to…
Sun, Jun 20, 4:55 PM
Jim closed D104441: [IVDescriptors] Fix comment that getUnsafeAlgebraInst has been renamed to getExactFPMathInst.
Sun, Jun 20, 4:55 PM · Restricted Project

Thu, Jun 17

Jim committed rGe7bf4510564a: [M68k][NFC] Fix indentation in M68kInstrArithmetic.td (authored by Jim).
[M68k][NFC] Fix indentation in M68kInstrArithmetic.td
Thu, Jun 17, 6:47 PM
Jim closed D104434: [M68k][NFC] Fix indentation in M68kInstrArithmetic.td.
Thu, Jun 17, 6:47 PM · Restricted Project
Jim added a comment to D104434: [M68k][NFC] Fix indentation in M68kInstrArithmetic.td.

LGTM Thanks!
Do you have commit access?

Thu, Jun 17, 6:46 PM · Restricted Project
Jim updated the summary of D104441: [IVDescriptors] Fix comment that getUnsafeAlgebraInst has been renamed to getExactFPMathInst.
Thu, Jun 17, 1:18 AM · Restricted Project
Jim requested review of D104441: [IVDescriptors] Fix comment that getUnsafeAlgebraInst has been renamed to getExactFPMathInst.
Thu, Jun 17, 1:14 AM · Restricted Project

Wed, Jun 16

Jim added a reviewer for D104434: [M68k][NFC] Fix indentation in M68kInstrArithmetic.td: myhsu.
Wed, Jun 16, 7:36 PM · Restricted Project
Jim requested review of D104434: [M68k][NFC] Fix indentation in M68kInstrArithmetic.td.
Wed, Jun 16, 7:35 PM · Restricted Project

Tue, Jun 15

Jim added a comment to D95588: [RISCV] Implement the MC layer support of P extension.

Any comments? Thanks.

Tue, Jun 15, 6:59 PM · Restricted Project, Restricted Project
Jim added inline comments to D103689: [RISCV] Add support for BSWAP and BITREVERSE for RVP.
Tue, Jun 15, 6:41 AM · Restricted Project
Jim updated the diff for D103689: [RISCV] Add support for BSWAP and BITREVERSE for RVP.

format td file.

Tue, Jun 15, 6:35 AM · Restricted Project
Jim updated the diff for D103689: [RISCV] Add support for BSWAP and BITREVERSE for RVP.

clang-foramt

Tue, Jun 15, 6:33 AM · Restricted Project
Jim abandoned D103691: [RISCV] Add support for BITREVERSE for RVP.

Merge this patch into D103689.

Tue, Jun 15, 6:31 AM · Restricted Project
Jim abandoned D103690: [RISCV] Pre-commit test for D103691.

Merge this patch into D103688

Tue, Jun 15, 6:30 AM · Restricted Project
Jim retitled D103689: [RISCV] Add support for BSWAP and BITREVERSE for RVP from [RISCV] Add support for BSWAP for RVP to [RISCV] Add support for BSWAP and BITREVERSE for RVP.
Tue, Jun 15, 6:29 AM · Restricted Project
Jim updated the diff for D103689: [RISCV] Add support for BSWAP and BITREVERSE for RVP.

Merge https://reviews.llvm.org/D103691 into this patch.
Add the codegen of RVB for testcases.

Tue, Jun 15, 6:28 AM · Restricted Project
Jim updated the diff for D103688: [RISCV] Pre-commit test for D103689.

Move test out of rvp directory.
Show the codegen of RVB.

Tue, Jun 15, 6:27 AM · Restricted Project
Jim updated the diff for D102467: [RISCV] Implement codegen patterns for RVP ALU operations.

Move tests out of rvp directory.

Tue, Jun 15, 6:25 AM · Restricted Project
Jim updated the diff for D103687: [RISCV] Pre-commit test for D102467.

Move tests out of rvp directory.

Tue, Jun 15, 6:23 AM · Restricted Project
Jim updated the diff for D99158: [RISCV][WIP] Implement intrinsics for P extension.

Alias swap16 to pkbt16.

Tue, Jun 15, 6:02 AM · Restricted Project, Restricted Project
Jim updated the summary of D95588: [RISCV] Implement the MC layer support of P extension.
Tue, Jun 15, 5:59 AM · Restricted Project, Restricted Project
Jim updated the diff for D95588: [RISCV] Implement the MC layer support of P extension.

Rebase

Tue, Jun 15, 5:07 AM · Restricted Project, Restricted Project
Jim retitled D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns from [RISCV] Add vector types to GPR for P extension and explict type to codegen patterns to [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.
Tue, Jun 15, 5:06 AM · Restricted Project
Jim updated the diff for D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.

Rebase

Tue, Jun 15, 5:04 AM · Restricted Project

Mon, Jun 14

Jim updated the diff for D95588: [RISCV] Implement the MC layer support of P extension.

Add tests for paired register operand for RV32.
Move testcases out of rvp directory.
Alias swap16 to pkbt16.

Mon, Jun 14, 5:02 AM · Restricted Project, Restricted Project

Sun, Jun 13

Jim updated the diff for D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.

Rebase

Sun, Jun 13, 10:58 PM · Restricted Project

Thu, Jun 10

Jim updated the diff for D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.

Rebase

Thu, Jun 10, 6:04 AM · Restricted Project

Wed, Jun 9

Jim added a comment to D103313: [RISCV][Clang] Implement support for zmmul-experimental.

It should add arch string tests such as in clang/test/Driver/riscv-arch.c.

Wed, Jun 9, 11:33 PM · Restricted Project, Restricted Project
Jim committed rGdec3154c161c: [Docs] Fix incorrect return type for example code (authored by Jim).
[Docs] Fix incorrect return type for example code
Wed, Jun 9, 11:18 PM
Jim committed rG391f9ef1aa8b: [docs] Fix load instructions in chapter 7 of the tutorial (authored by Jim).
[docs] Fix load instructions in chapter 7 of the tutorial
Wed, Jun 9, 2:39 AM
Jim closed D90326: [docs] Fix load instructions in chapter 7 of the tutorial.
Wed, Jun 9, 2:39 AM · Restricted Project
Jim added a comment to D103790: [RISCV][NFC] Add a single space after comma for VType.

Thanks, I missed to check MC tests.

Wed, Jun 9, 2:03 AM · Restricted Project
Jim committed rG9751af22c499: [Docs] Fix incorrect return type for example code (authored by Jim).
[Docs] Fix incorrect return type for example code
Wed, Jun 9, 12:19 AM

Tue, Jun 8

Jim committed rG242ddd50897c: [RISCV][NFC] Add a single space after comma for VType (authored by Jim).
[RISCV][NFC] Add a single space after comma for VType
Tue, Jun 8, 8:18 PM
Jim closed D103790: [RISCV][NFC] Add a single space after comma for VType.
Tue, Jun 8, 8:18 PM · Restricted Project
Jim added a comment to D103790: [RISCV][NFC] Add a single space after comma for VType.

The examples in the V spec show no spaces. Are you going to update that too? What about binutils?

I refer to https://github.com/riscv/riscv-binutils-gdb/blob/c5ef83e53e2528c0737bb0f40e6b77dc8b82eac8/gas/testsuite/gas/riscv/vector-insns.s
It looks that binutils can accept two formats with or without spaces.

I pull a request to update riscv-v-spec.
https://github.com/riscv/riscv-v-spec/pull/693

Tue, Jun 8, 8:13 PM · Restricted Project
Jim updated the diff for D103790: [RISCV][NFC] Add a single space after comma for VType.

Rebase

Tue, Jun 8, 8:11 PM · Restricted Project

Mon, Jun 7

Jim added reviewers for D103742: [RISCV] Support vector maximum and minimum for RVP: craig.topper, frasercrmck, jrtc27.
Mon, Jun 7, 3:16 AM · Restricted Project
Jim added reviewers for D103740: [RISCV] Support vector comparision for RVP: craig.topper, frasercrmck, jrtc27.
Mon, Jun 7, 3:15 AM · Restricted Project
Jim updated the diff for D103740: [RISCV] Support vector comparision for RVP.

Update comments and tests.

Mon, Jun 7, 3:12 AM · Restricted Project
Jim updated the diff for D102467: [RISCV] Implement codegen patterns for RVP ALU operations.

Add codegen patterns for logic operation with immediate.

Mon, Jun 7, 3:07 AM · Restricted Project
Jim updated the diff for D103687: [RISCV] Pre-commit test for D102467.

Add tests for logic operations with immediate.

Mon, Jun 7, 3:05 AM · Restricted Project
Jim added a reviewer for D103790: [RISCV][NFC] Add a single space after comma for VType: craig.topper.

The examples in the V spec show no spaces. Are you going to update that too? What about binutils?

Mon, Jun 7, 1:57 AM · Restricted Project
Jim requested review of D103790: [RISCV][NFC] Add a single space after comma for VType.
Mon, Jun 7, 12:01 AM · Restricted Project

Sun, Jun 6

Jim updated the diff for D103742: [RISCV] Support vector maximum and minimum for RVP.

Set ISD::SMAX, ISD::SMIN, ISD::UMAX and ISD::UMIN as legal.

Sun, Jun 6, 8:55 PM · Restricted Project
Jim updated the diff for D103741: [RISCV] Pre-commit test for D103742.

Add tests for RV64 only instructions, smax32, smin32, umax32 and umin32.

Sun, Jun 6, 8:53 PM · Restricted Project
Jim added a comment to D103691: [RISCV] Add support for BITREVERSE for RVP.

I do not think RVP needs its own subdirectory for CodeGen tests. RVV has one because the extension is massive, but RVP is comparatively small. It should be like all the others. Especially since I think we should be testing interesting combinations of extensions for various tests (e.g. bitmanip + P for things like this).

Sun, Jun 6, 4:08 AM · Restricted Project
Jim updated the diff for D103693: [RISCV] Add support for BUILD_VECTOR, VECTOR_SHUFFLE and INSERT_VECTOR_ELT for RVP.

Remove unused variable.

Sun, Jun 6, 4:00 AM · Restricted Project
Jim updated the diff for D99158: [RISCV][WIP] Implement intrinsics for P extension.

hasStdExtP -> hasStdExtZpn

Sun, Jun 6, 3:50 AM · Restricted Project, Restricted Project
Jim updated the diff for D103693: [RISCV] Add support for BUILD_VECTOR, VECTOR_SHUFFLE and INSERT_VECTOR_ELT for RVP.

Address comments.

Sun, Jun 6, 3:43 AM · Restricted Project
Jim added reviewers for D103693: [RISCV] Add support for BUILD_VECTOR, VECTOR_SHUFFLE and INSERT_VECTOR_ELT for RVP: craig.topper, frasercrmck, jrtc27.
Sun, Jun 6, 3:40 AM · Restricted Project

Fri, Jun 4

Jim retitled D103741: [RISCV] Pre-commit test for D103742 from [RISCV] Pre-commit to [RISCV] Pre-commit test for D103742.
Fri, Jun 4, 10:04 PM · Restricted Project
Jim updated the summary of D103740: [RISCV] Support vector comparision for RVP.
Fri, Jun 4, 10:04 PM · Restricted Project
Jim requested review of D103742: [RISCV] Support vector maximum and minimum for RVP.
Fri, Jun 4, 10:03 PM · Restricted Project
Jim requested review of D103741: [RISCV] Pre-commit test for D103742.
Fri, Jun 4, 10:02 PM · Restricted Project
Jim retitled D103739: [RISCV] Pre-commit test for D103740 from [RISCV] Pre-commit to [RISCV] Pre-commit test for D103740.
Fri, Jun 4, 9:59 PM · Restricted Project
Jim requested review of D103740: [RISCV] Support vector comparision for RVP.
Fri, Jun 4, 9:59 PM · Restricted Project
Jim requested review of D103739: [RISCV] Pre-commit test for D103740.
Fri, Jun 4, 9:57 PM · Restricted Project
Jim retitled D103737: [RISCV] Pre-commit test for D103738 from [RISCV] Pre-commit to [RISCV] Pre-commit test for D103738.
Fri, Jun 4, 9:55 PM · Restricted Project
Jim requested review of D103738: [RISCV] Add bpick codegen pattern.
Fri, Jun 4, 9:54 PM · Restricted Project
Jim requested review of D103737: [RISCV] Pre-commit test for D103738.
Fri, Jun 4, 9:51 PM · Restricted Project
Jim committed rG170b70b74b53: [RISCV] Replace (XLenVT (VLOp GPR:$vl)) with VLOpFrag (authored by Jim).
[RISCV] Replace (XLenVT (VLOp GPR:$vl)) with VLOpFrag
Fri, Jun 4, 9:48 PM
Jim closed D103682: [RISCV] Replace (XLenVT (VLOp GPR:$vl)) with VLOpFrag.
Fri, Jun 4, 9:48 PM · Restricted Project
Jim retitled D103697: [RISCV] Pre-commit test for D103698 from [RISCV] Pre-commit to [RISCV] Pre-commit test for D103698.
Fri, Jun 4, 5:56 AM · Restricted Project
Jim requested review of D103698: [RISCV] Add support for CLTZ for RVP.
Fri, Jun 4, 5:55 AM · Restricted Project
Jim requested review of D103697: [RISCV] Pre-commit test for D103698.
Fri, Jun 4, 5:54 AM · Restricted Project
Jim updated the summary of D103693: [RISCV] Add support for BUILD_VECTOR, VECTOR_SHUFFLE and INSERT_VECTOR_ELT for RVP.
Fri, Jun 4, 5:53 AM · Restricted Project
Jim updated the summary of D103693: [RISCV] Add support for BUILD_VECTOR, VECTOR_SHUFFLE and INSERT_VECTOR_ELT for RVP.
Fri, Jun 4, 5:50 AM · Restricted Project
Jim retitled D103692: [RISCV] Pre-commit test for D103693 from [RISCV] Pre-commit to [RISCV] Pre-commit test for D103693.
Fri, Jun 4, 5:27 AM · Restricted Project
Jim requested review of D103693: [RISCV] Add support for BUILD_VECTOR, VECTOR_SHUFFLE and INSERT_VECTOR_ELT for RVP.
Fri, Jun 4, 5:26 AM · Restricted Project
Jim requested review of D103692: [RISCV] Pre-commit test for D103693.
Fri, Jun 4, 5:24 AM · Restricted Project
Jim added reviewers for D103691: [RISCV] Add support for BITREVERSE for RVP: craig.topper, frasercrmck, jrtc27.
Fri, Jun 4, 5:22 AM · Restricted Project
Jim retitled D103690: [RISCV] Pre-commit test for D103691 from [RISCV] Pre-commit to [RISCV] Pre-commit test for D103691.
Fri, Jun 4, 5:19 AM · Restricted Project
Jim requested review of D103691: [RISCV] Add support for BITREVERSE for RVP.
Fri, Jun 4, 5:18 AM · Restricted Project
Jim requested review of D103690: [RISCV] Pre-commit test for D103691.
Fri, Jun 4, 5:16 AM · Restricted Project
Jim added reviewers for D103689: [RISCV] Add support for BSWAP and BITREVERSE for RVP: craig.topper, jrtc27, frasercrmck.
Fri, Jun 4, 5:15 AM · Restricted Project
Jim added a comment to D103688: [RISCV] Pre-commit test for D103689.

"[RISCV] Pre-commit" is not a sufficient revision/commit description

Fri, Jun 4, 5:14 AM · Restricted Project
Jim retitled D103688: [RISCV] Pre-commit test for D103689 from [RISCV] Pre-commit to [RISCV] Pre-commit test for D103689.
Fri, Jun 4, 5:12 AM · Restricted Project
Jim requested review of D103689: [RISCV] Add support for BSWAP and BITREVERSE for RVP.
Fri, Jun 4, 5:11 AM · Restricted Project
Jim retitled D102467: [RISCV] Implement codegen patterns for RVP ALU operations from [RISCV] Implement codegen patterns for add8, add16, sub8 and sub16 to [RISCV] Implement codegen patterns for RVP ALU operations.
Fri, Jun 4, 5:07 AM · Restricted Project
Jim requested review of D103688: [RISCV] Pre-commit test for D103689.
Fri, Jun 4, 5:06 AM · Restricted Project
Jim updated the diff for D102467: [RISCV] Implement codegen patterns for RVP ALU operations.

Add support for vector and, or and xor operations and
implement getPreferredVectorAction hook to widen v4i8 and v2i16 to v8i8 and v4i16 for RV64P.

Fri, Jun 4, 5:03 AM · Restricted Project
Jim requested review of D103687: [RISCV] Pre-commit test for D102467.
Fri, Jun 4, 5:00 AM · Restricted Project
Jim updated the diff for D99158: [RISCV][WIP] Implement intrinsics for P extension.

Rebase

Fri, Jun 4, 4:57 AM · Restricted Project, Restricted Project
Jim updated the diff for D95588: [RISCV] Implement the MC layer support of P extension.

Rebase

Fri, Jun 4, 4:55 AM · Restricted Project, Restricted Project
Jim updated the diff for D100288: [RISCV] Add vector types to GPR for P extension and explict type to existing codegen patterns.

Rebase

Fri, Jun 4, 4:53 AM · Restricted Project
Jim abandoned D102466: [RISCV] Support RVP vectors in the calling convention.
Fri, Jun 4, 4:51 AM · Restricted Project
Jim added a reviewer for D103682: [RISCV] Replace (XLenVT (VLOp GPR:$vl)) with VLOpFrag: craig.topper.
Fri, Jun 4, 4:23 AM · Restricted Project
Jim requested review of D103682: [RISCV] Replace (XLenVT (VLOp GPR:$vl)) with VLOpFrag.
Fri, Jun 4, 4:22 AM · Restricted Project

Sun, May 23

Jim added inline comments to D95322: [RISCV] Custom type legalize i8/i16 UDIV/UREM/SDIV on RV64 so we can use divuw/remuw/divw..
Sun, May 23, 3:12 AM · Restricted Project

May 21 2021

Jim committed rG445680593889: [X86] Don't fold (fneg (fma (fneg X), Y, (fneg Z))) to (fma X, Y, Z) (authored by Jim).
[X86] Don't fold (fneg (fma (fneg X), Y, (fneg Z))) to (fma X, Y, Z)
May 21 2021, 8:00 AM
Jim closed D90901: [X86] Don't fold (fneg (fma (fneg X), Y, (fneg Z))) to (fma X, Y, Z).
May 21 2021, 8:00 AM · Restricted Project
Jim committed rG35e5c3310fb0: [X86] Pre-commit test for D90901 (authored by Jim).
[X86] Pre-commit test for D90901
May 21 2021, 8:00 AM
Jim closed D102621: [X86] Pre-commit test for D90901.
May 21 2021, 7:59 AM · Restricted Project
Jim added a comment to D90901: [X86] Don't fold (fneg (fma (fneg X), Y, (fneg Z))) to (fma X, Y, Z).

Thanks! @spatel @RKSimon

May 21 2021, 7:45 AM · Restricted Project