Page MenuHomePhabricator

s.egerton (Scott Egerton)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2015, 9:23 AM (236 w, 3 d)

Recent Activity

Wed, Jan 15

s.egerton committed rGa90ea386981f: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using… (authored by s.egerton).
[Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using…
Wed, Jan 15, 3:33 AM
s.egerton closed D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag..
Wed, Jan 15, 3:33 AM · Restricted Project
s.egerton committed rGcbe681bd8339: Revert "[RISCV] Add Clang frontend support for Bitmanip extension" (authored by s.egerton).
Revert "[RISCV] Add Clang frontend support for Bitmanip extension"
Wed, Jan 15, 2:47 AM
s.egerton added a reverting change for rG57cf6ee9c844: [RISCV] Add Clang frontend support for Bitmanip extension: rGcbe681bd8339: Revert "[RISCV] Add Clang frontend support for Bitmanip extension".
Wed, Jan 15, 2:47 AM
s.egerton added a comment to D71553: [RISCV] Add Clang frontend support for Bitmanip extension.

Good point. It's reverted now.

Wed, Jan 15, 2:47 AM · Restricted Project

Tue, Jan 14

s.egerton committed rG57cf6ee9c844: [RISCV] Add Clang frontend support for Bitmanip extension (authored by s.egerton).
[RISCV] Add Clang frontend support for Bitmanip extension
Tue, Jan 14, 9:55 AM
s.egerton closed D71553: [RISCV] Add Clang frontend support for Bitmanip extension.
Tue, Jan 14, 9:55 AM · Restricted Project

Dec 20 2019

s.egerton added reviewers for D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.: rsmith, akyrtzi, jordan_rose.
Dec 20 2019, 6:08 AM · Restricted Project
s.egerton created D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag..
Dec 20 2019, 6:08 AM · Restricted Project

Dec 17 2019

s.egerton updated the diff for D71553: [RISCV] Add Clang frontend support for Bitmanip extension.

Add test that march 'b' flag enables __riscv_bitmanip.

Dec 17 2019, 8:03 AM · Restricted Project
s.egerton added a parent revision for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h: D71553: [RISCV] Add Clang frontend support for Bitmanip extension.
Dec 17 2019, 7:42 AM · Restricted Project, Restricted Project
s.egerton added a child revision for D71553: [RISCV] Add Clang frontend support for Bitmanip extension: D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.
Dec 17 2019, 7:42 AM · Restricted Project
s.egerton updated the diff for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.
  • Removed frontend changes, as these have been seperated out into a seperate patch here: https://reviews.llvm.org/D71553
  • Made use of riscv macro in intrin.h, rather than relying on riscv32 || __riscv64.
Dec 17 2019, 5:04 AM · Restricted Project, Restricted Project

Dec 16 2019

s.egerton created D71553: [RISCV] Add Clang frontend support for Bitmanip extension.
Dec 16 2019, 8:43 AM · Restricted Project

Dec 13 2019

s.egerton planned changes to D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

So I have a quick comment about this patch, perhaps it might help to get things moving again.

I'd like to see the actual frontend changes, IE separate from the header implementations, to be split into a separate patch. So we can have things like the __riscv_bitmanip macro and the target attribute parsing potentially landed sooner?

Dec 13 2019, 6:07 AM · Restricted Project, Restricted Project
s.egerton updated the diff for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

Add underscore in place of asm '.' in C function names

Dec 13 2019, 5:58 AM · Restricted Project, Restricted Project

Nov 18 2019

s.egerton updated the diff for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

Re-add accidentally reverted update.

Nov 18 2019, 8:35 AM · Restricted Project, Restricted Project
s.egerton updated the diff for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

Update to include changes in v0.92.

Nov 18 2019, 6:48 AM · Restricted Project, Restricted Project

Sep 23 2019

s.egerton updated the diff for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

Fixed typos in opcodes. Missing '.'s were added. e.g. adduw -> addu.w

Sep 23 2019, 8:01 AM · Restricted Project, Restricted Project
s.egerton updated the diff for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.
Sep 23 2019, 7:52 AM · Restricted Project, Restricted Project
s.egerton added a comment to D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

We have a patch to add codegen pattern matching (https://reviews.llvm.org/D67348). Unfortunately we have found that we will not be able to rely on pattern matching here to guarantee that these instructions are emitted in all situations due to differences in optimisation levels and the complexity of some instructions.
The approach of using arch-specific intrinsics in the middle end (https://reviews.llvm.org/D66479) was an alternative way to bridge the gap between the C level builtins and the Bitmanip instructions.

Sep 23 2019, 7:01 AM · Restricted Project, Restricted Project

Sep 18 2019

s.egerton added a comment to D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

Sorry I misread your original comment.

Sep 18 2019, 7:33 AM · Restricted Project, Restricted Project
s.egerton added a parent revision for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h: D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension.
Sep 18 2019, 5:40 AM · Restricted Project, Restricted Project
s.egerton added a child revision for D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension: D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.
Sep 18 2019, 5:40 AM · Restricted Project
s.egerton updated the diff for D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

Add missing <>

Sep 18 2019, 3:54 AM · Restricted Project, Restricted Project
s.egerton added a comment to D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.

I agree inline asm is a far from optimal solution but it seems like the lesser of two evils for now.

Sep 18 2019, 3:16 AM · Restricted Project, Restricted Project

Sep 17 2019

s.egerton created D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h.
Sep 17 2019, 8:19 AM · Restricted Project, Restricted Project

Sep 3 2019

s.egerton added inline comments to D66479: [RISCV] Add LLVM intrinsics for the Bit Manipulation extension.
Sep 3 2019, 6:53 AM · Restricted Project

Aug 21 2019

s.egerton added a reviewer for D66479: [RISCV] Add LLVM intrinsics for the Bit Manipulation extension: lenary.
Aug 21 2019, 3:07 AM · Restricted Project
s.egerton added inline comments to D66479: [RISCV] Add LLVM intrinsics for the Bit Manipulation extension.
Aug 21 2019, 3:07 AM · Restricted Project
s.egerton added a parent revision for D66479: [RISCV] Add LLVM intrinsics for the Bit Manipulation extension: D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension.
Aug 21 2019, 3:06 AM · Restricted Project
s.egerton added a child revision for D65649: [RISCV] Add MC encodings and tests of the Bit Manipulation extension: D66479: [RISCV] Add LLVM intrinsics for the Bit Manipulation extension.
Aug 21 2019, 3:06 AM · Restricted Project
s.egerton updated the summary of D66479: [RISCV] Add LLVM intrinsics for the Bit Manipulation extension.
Aug 21 2019, 1:55 AM · Restricted Project

Aug 20 2019

s.egerton created D66479: [RISCV] Add LLVM intrinsics for the Bit Manipulation extension.
Aug 20 2019, 8:24 AM · Restricted Project

Jul 31 2019

s.egerton abandoned D17079: [mips] Added -gpsize=0 to a test case as this is required in order to emit the same code as GAS..
Jul 31 2019, 2:26 AM
s.egerton abandoned D16455: [mips] Allowed la instructions on 64-bit architectures..
Jul 31 2019, 2:25 AM

May 24 2016

s.egerton added a comment to D17079: [mips] Added -gpsize=0 to a test case as this is required in order to emit the same code as GAS..

Currently dla instructions on 32-bit do not support using the 'at' register. The behavior is different to GAS unless using the -gpsize=0 option as the behavior without this option has not yet been implemented.

May 24 2016, 2:10 AM

Apr 29 2016

s.egerton updated subscribers of D19549: Fold compares irrespective of whether allocation can be elided.
Apr 29 2016, 1:55 AM

Mar 17 2016

s.egerton committed rL263703: [mips] Eliminate instances of "potentially uninitialised local variable"….
[mips] Eliminate instances of "potentially uninitialised local variable"…
Mar 17 2016, 3:43 AM
s.egerton closed D18087: [mips] Eliminate instances of "potentially uninitialised local variable" warnings, NFC.
Mar 17 2016, 3:42 AM

Mar 11 2016

s.egerton retitled D18087: [mips] Eliminate instances of "potentially uninitialised local variable" warnings, NFC from to [mips] Eliminate instances of "potentially uninitialised local variable" warnings, NFC.
Mar 11 2016, 7:37 AM

Mar 9 2016

s.egerton added a comment to D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings.

Hello. I will take a look at fixing the warnings coming from LLVMMipsAsmParser.

Mar 9 2016, 4:29 AM

Mar 3 2016

s.egerton added a comment to D17079: [mips] Added -gpsize=0 to a test case as this is required in order to emit the same code as GAS..

This change looks correct but it appears to expose a bug. One of the tests in macro-la-64bit.s emits different code to GAS. IAS gives:

2f0:   34068000        li      a2,0x8000
2f4:   00c6302d        daddu   a2,a2,a2

where the li clobbers the third operand of the daddu, whereas GAS emits:

2f0:   34018000        li      at,0x8000
2f4:   0026302d        daddu   a2,at,a2

I cannot recall the exact difference but I believe it is the 32bit equivalent of this difference. I can get more details on this if required. The correct behavior for when the -gpsize=0 option is not given has not been implemented yet. When it is implemented this test will start to fail without this option present.

Mar 3 2016, 3:21 AM

Feb 17 2016

s.egerton committed rL261083: [mips] Removed the SHF_ALLOC flag and the SHT_REL flag from the .pdr section..
[mips] Removed the SHF_ALLOC flag and the SHT_REL flag from the .pdr section.
Feb 17 2016, 3:19 AM

Feb 15 2016

s.egerton committed rL260896: [mips] Implemented the .hword directive..
[mips] Implemented the .hword directive.
Feb 15 2016, 8:16 AM
s.egerton closed D17200: [mips] Implemented the .hword directive..
Feb 15 2016, 8:16 AM
s.egerton committed rL260880: Reverted r260879 as it caused test failures in lld..
Reverted r260879 as it caused test failures in lld.
Feb 15 2016, 2:09 AM
s.egerton committed rL260879: [mips] Removed the SHF_ALLOC flag from the .pdr section..
[mips] Removed the SHF_ALLOC flag from the .pdr section.
Feb 15 2016, 1:38 AM
s.egerton closed D17199: [mips] Removed the SHF_ALLOC flag from the .pdr section..
Feb 15 2016, 1:38 AM

Feb 12 2016

s.egerton retitled D17199: [mips] Removed the SHF_ALLOC flag from the .pdr section. from [mips] Made the .pdr section not allocatable. to [mips] Removed the SHF_ALLOC flag from the .pdr section..
Feb 12 2016, 7:25 AM
s.egerton retitled D17200: [mips] Implemented the .hword directive. from to [mips] Implemented the .hword directive..
Feb 12 2016, 6:51 AM
s.egerton retitled D17199: [mips] Removed the SHF_ALLOC flag from the .pdr section. from to [mips] Made the .pdr section not allocatable..
Feb 12 2016, 6:31 AM
s.egerton abandoned D15949: [mips] Changed the way expressions in instructions are printed to support different kinds of expressions..
Feb 12 2016, 4:06 AM

Feb 11 2016

s.egerton committed rL260521: [MC] Fixed parsing of macro arguments where expressions with spaces are present..
[MC] Fixed parsing of macro arguments where expressions with spaces are present.
Feb 11 2016, 5:53 AM
s.egerton closed D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present. by committing rL260521: [MC] Fixed parsing of macro arguments where expressions with spaces are present..
Feb 11 2016, 5:53 AM

Feb 10 2016

s.egerton retitled D17079: [mips] Added -gpsize=0 to a test case as this is required in order to emit the same code as GAS. from to [mips] Added -gpsize=0 to a test case as this is required in order to emit the same code as GAS..
Feb 10 2016, 9:24 AM
s.egerton updated the diff for D16455: [mips] Allowed la instructions on 64-bit architectures..

Added the -gpsize=0 option to the test cases so that the IAS will emit the same code as GAS.

Feb 10 2016, 8:04 AM

Jan 22 2016

s.egerton retitled D16455: [mips] Allowed la instructions on 64-bit architectures. from to [mips] Allowed la instructions on 64-bit architectures..
Jan 22 2016, 1:44 AM

Jan 21 2016

s.egerton committed rL258400: [mips] Allowed dla instructions on 32-bit architectures..
[mips] Allowed dla instructions on 32-bit architectures.
Jan 21 2016, 7:15 AM
s.egerton closed D13594: [mips] Allowed dla instructions on 32-bit architectures..
Jan 21 2016, 7:14 AM

Jan 20 2016

s.egerton added a comment to D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present..

ping

Jan 20 2016, 1:07 AM

Jan 18 2016

s.egerton added a comment to D13594: [mips] Allowed dla instructions on 32-bit architectures..

ping

Jan 18 2016, 7:26 AM

Jan 14 2016

s.egerton committed rL257762: [mips] Added support for -Wa,-mips32 and similar..
[mips] Added support for -Wa,-mips32 and similar.
Jan 14 2016, 5:05 AM

Jan 13 2016

s.egerton committed rL257610: Revert r257602 because it breaks integrated-as.s on mips hosts..
Revert r257602 because it breaks integrated-as.s on mips hosts.
Jan 13 2016, 8:23 AM
s.egerton committed rL257602: [mips] Added support for -Wa,-mips32 and similar..
[mips] Added support for -Wa,-mips32 and similar.
Jan 13 2016, 6:31 AM
s.egerton closed D15070: [mips] Added support for -Wa,-mips32 and similar..
Jan 13 2016, 6:31 AM

Jan 7 2016

s.egerton added a parent revision for D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present.: D15949: [mips] Changed the way expressions in instructions are printed to support different kinds of expressions..
Jan 7 2016, 7:49 AM
s.egerton added a child revision for D15949: [mips] Changed the way expressions in instructions are printed to support different kinds of expressions.: D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present..
Jan 7 2016, 7:49 AM
s.egerton updated the diff for D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present..

Responded to reviewers comments. In order to pass the newly added test cases, I had to produce another patch to fix issues whilst printing expressions. This patch requires this in order to pass all test cases. The patch ca be found here: http://reviews.llvm.org/D15949

Jan 7 2016, 7:49 AM
s.egerton retitled D15949: [mips] Changed the way expressions in instructions are printed to support different kinds of expressions. from to [mips] Changed the way expressions in instructions are printed to support different kinds of expressions..
Jan 7 2016, 7:21 AM

Dec 18 2015

s.egerton added a comment to D13594: [mips] Allowed dla instructions on 32-bit architectures..

ping

Dec 18 2015, 4:39 AM

Dec 17 2015

s.egerton updated the diff for D15070: [mips] Added support for -Wa,-mips32 and similar..

Responded to reviewers comments.

Dec 17 2015, 6:48 AM

Dec 7 2015

s.egerton updated D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present..
Dec 7 2015, 7:29 AM

Nov 30 2015

s.egerton retitled D15070: [mips] Added support for -Wa,-mips32 and similar. from to [mips] Added support for -Wa,-mips32 and similar..
Nov 30 2015, 2:15 AM

Nov 26 2015

s.egerton updated D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present..
Nov 26 2015, 3:08 AM

Nov 25 2015

s.egerton updated the diff for D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present..

I have added test cases. I also had to update the patch to ensure all of the tests passed.

Nov 25 2015, 6:25 AM

Nov 24 2015

s.egerton updated the diff for D13594: [mips] Allowed dla instructions on 32-bit architectures..

I've now added test cases which test everything that is tested for dla on 64-bit architecture. I had to update the patch to then pass these tests.

Nov 24 2015, 9:09 AM

Oct 9 2015

s.egerton retitled D13594: [mips] Allowed dla instructions on 32-bit architectures. from to [mips] Allowed dla instructions on 32-bit architectures..
Oct 9 2015, 7:52 AM
s.egerton retitled D13592: [MC] Fixed parsing of macro arguments where expressions with spaces are present. from to [MC] Fixed parsing of macro arguments where expressions with spaces are present..
Oct 9 2015, 6:31 AM

Oct 7 2015

s.egerton committed rL249537: Revert: r249536 - Testing commit access with a trival whitespace change..
Revert: r249536 - Testing commit access with a trival whitespace change.
Oct 7 2015, 3:59 AM
s.egerton committed rL249536: Testing commit access with a trival whitespace change..
Testing commit access with a trival whitespace change.
Oct 7 2015, 3:51 AM

Oct 1 2015

s.egerton updated the diff for D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms..

Responded to comments made on the mailing list.

Oct 1 2015, 8:47 AM

Sep 23 2015

s.egerton retitled D13100: [mips] Separated mips specific -Wa options, so that they are not checked on other platforms. from to [mips] Separated mips specific -Wa options, so that they are not checked on other platforms..
Sep 23 2015, 7:55 AM

Sep 10 2015

s.egerton retitled D12760: [mips] Changed the way symbols are handled in dla and la instructions to allow simple expressions. from to [mips] Changed the way symbols are handled in dla and la instructions to allow simple expressions..
Sep 10 2015, 7:21 AM

Sep 9 2015

s.egerton added a comment to D12696: [mips] Unified the MipsMemSimm9GPRAsmOperand and MipsMemSimm9AsmOperand functions, NFC..

The re-uploaded version is now available here: http://reviews.llvm.org/D12730

Sep 9 2015, 7:47 AM
s.egerton retitled D12730: [mips] Unified the MipsMemSimm9GPRAsmOperand and MipsMemSimm9AsmOperand functions, NFC. from to [mips] Unified the MipsMemSimm9GPRAsmOperand and MipsMemSimm9AsmOperand functions, NFC..
Sep 9 2015, 7:45 AM
s.egerton abandoned D12696: [mips] Unified the MipsMemSimm9GPRAsmOperand and MipsMemSimm9AsmOperand functions, NFC..

Abandoned as it will be re-uploaded with llvm-commits CC'd from the start.

Sep 9 2015, 7:36 AM
s.egerton updated the diff for D11139: [mips] Added support for various EVA ASE instructions..

Responded to reviewers comments. Also, changed 'mem' in operands to 'mem_simm9' in order to properly detect the upper bounds for these operands.

Sep 9 2015, 3:03 AM

Sep 8 2015

s.egerton updated subscribers of D12696: [mips] Unified the MipsMemSimm9GPRAsmOperand and MipsMemSimm9AsmOperand functions, NFC..
Sep 8 2015, 8:08 AM
s.egerton retitled D12696: [mips] Unified the MipsMemSimm9GPRAsmOperand and MipsMemSimm9AsmOperand functions, NFC. from to [mips] Unified the MipsMemSimm9GPRAsmOperand and MipsMemSimm9AsmOperand functions, NFC..
Sep 8 2015, 8:07 AM

Sep 3 2015

s.egerton retitled D12600: [mips] Added support for using the command line options -Wa,-msoft-float and -Wa,-mhard-float. from to [mips] Added support for using the command line options -Wa,-msoft-float and -Wa,-mhard-float..
Sep 3 2015, 9:18 AM

Aug 28 2015

s.egerton updated the diff for D11676: [mips] Added support for using traps and breaks in the integrated assembler via command line options..

Fixed spacing issues.

Aug 28 2015, 3:34 AM
s.egerton updated the diff for D11676: [mips] Added support for using traps and breaks in the integrated assembler via command line options..

Changed all references to "use-div-traps" to "use-tcc-in-div" to relect changes made to the llvm integrated assember in a different patch (http://reviews.llvm.org/D11675).

Aug 28 2015, 3:24 AM
s.egerton updated the diff for D11675: [mips] Added support for the div, divu, ddiv and ddivu macros using traps and breaks in the integrated assembler..

Responded to reviewer comments. Made a few minor changes to emit functions to account for changes on the trunk. Also fixed last upload which accidentally removed a significant amount of code.

Aug 28 2015, 2:50 AM

Aug 14 2015

s.egerton updated the diff for D11675: [mips] Added support for the div, divu, ddiv and ddivu macros using traps and breaks in the integrated assembler..

Responded to reviewers comments.

Aug 14 2015, 6:17 AM

Jul 31 2015

s.egerton retitled D11676: [mips] Added support for using traps and breaks in the integrated assembler via command line options. from Added support for using traps and breaks in the integrated assembler via command line options. to [mips] Added support for using traps and breaks in the integrated assembler via command line options..
Jul 31 2015, 4:00 AM
s.egerton retitled D11675: [mips] Added support for the div, divu, ddiv and ddivu macros using traps and breaks in the integrated assembler. from Added support for the div, divu, ddiv and ddivu macros using traps and breaks in the integrated assembler. to [mips] Added support for the div, divu, ddiv and ddivu macros using traps and breaks in the integrated assembler..
Jul 31 2015, 4:00 AM
s.egerton retitled D11676: [mips] Added support for using traps and breaks in the integrated assembler via command line options. from to Added support for using traps and breaks in the integrated assembler via command line options..
Jul 31 2015, 3:57 AM
s.egerton retitled D11675: [mips] Added support for the div, divu, ddiv and ddivu macros using traps and breaks in the integrated assembler. from to Added support for the div, divu, ddiv and ddivu macros using traps and breaks in the integrated assembler..
Jul 31 2015, 3:54 AM

Jul 22 2015

s.egerton updated the diff for D11139: [mips] Added support for various EVA ASE instructions..

Responded to reviewers comments.

Jul 22 2015, 9:02 AM