Discourse thread: https://discourse.llvm.org/t/include-what-you-use-include-cleanup
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This breaks implicit module on macOS bots: https://green.lab.llvm.org/green/job/lldb-cmake/42098/console
Error message:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/MachinePipeliner.h:136:3: error: missing '#include "llvm/ADT/SetVector.h"'; 'SetVector' must be declared before it is used SetVector<SUnit *> NodeOrder; ^ /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ADT/SetVector.h:40:7: note: declaration here is not visible class SetVector { ^ /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/CodeGen/AtomicExpandPass.cpp:21:10: fatal error: could not build module 'LLVM_Backend' #include "llvm/CodeGen/AtomicExpandUtils.h" ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated.
This can be fixed by adding ADT/SetVector.h to include/llvm/CodeGen/MachinePipeliner.h