Page MenuHomePhabricator

yonghong-song (Yonghong Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2018, 11:50 PM (233 w, 2 d)

Recent Activity

Mon, Mar 13

yonghong-song committed rGdb3d2adecb4a: [BPF] Improve pruning to avoid generate more types in BTF (authored by yonghong-song).
[BPF] Improve pruning to avoid generate more types in BTF
Mon, Mar 13, 9:35 AM · Restricted Project, Restricted Project
yonghong-song closed D145816: [BPF] Improve pruning to avoid generate more types in BTF.
Mon, Mar 13, 9:35 AM · Restricted Project, Restricted Project

Sun, Mar 12

yonghong-song added a comment to D145816: [BPF] Improve pruning to avoid generate more types in BTF.

Added some comments to explain the rationale behind CheckPointer and SeePointer. If it looks okay, could you accept the patch?

Sun, Mar 12, 11:29 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D145816: [BPF] Improve pruning to avoid generate more types in BTF.

update the comment.

Sun, Mar 12, 11:26 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D145816: [BPF] Improve pruning to avoid generate more types in BTF.

add comments to explain CheckPointer and SeePointer.

Sun, Mar 12, 11:22 PM · Restricted Project, Restricted Project

Fri, Mar 10

yonghong-song requested review of D145816: [BPF] Improve pruning to avoid generate more types in BTF.
Fri, Mar 10, 11:11 AM · Restricted Project, Restricted Project

Sun, Feb 26

yonghong-song added a reviewer for D144829: [WIP][BPF] Add a few new insns under cpu=v4: eddyz87.
Sun, Feb 26, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song updated the summary of D144829: [WIP][BPF] Add a few new insns under cpu=v4.
Sun, Feb 26, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song requested review of D144829: [WIP][BPF] Add a few new insns under cpu=v4.
Sun, Feb 26, 9:51 AM · Restricted Project, Restricted Project, Restricted Project

Jan 21 2023

yonghong-song added a comment to D142046: [BPF][clang] Ignore stack protector options for BPF target.

@dyung I just pushed the fix to the 'main' branch (https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b). Please check it out. Thanks for reporting!

Jan 21 2023, 10:38 PM · Restricted Project, Restricted Project
yonghong-song committed rG183d075055c5: [BPF][Clang] Fix func argument pattern in bpf-stack-protector test (authored by yonghong-song).
[BPF][Clang] Fix func argument pattern in bpf-stack-protector test
Jan 21 2023, 10:36 PM · Restricted Project, Restricted Project

Jan 20 2023

yonghong-song committed rG56b038f887f3: [BPF][clang] Ignore stack protector options for BPF target (authored by eddyz87).
[BPF][clang] Ignore stack protector options for BPF target
Jan 20 2023, 3:16 PM · Restricted Project, Restricted Project
yonghong-song closed D142046: [BPF][clang] Ignore stack protector options for BPF target.
Jan 20 2023, 3:16 PM · Restricted Project, Restricted Project

Jan 19 2023

yonghong-song added a comment to D142046: [BPF][clang] Ignore stack protector options for BPF target.

Sorry, I double checked. '-fstack-protector -fno-stack-protector' will not result in warnings. So the patch LGTM. So gentoo people can add -fno-stack-protector to suppress warnings.

Jan 19 2023, 12:01 PM · Restricted Project, Restricted Project
yonghong-song added a comment to D142046: [BPF][clang] Ignore stack protector options for BPF target.

@ast With this patch, gentoo clang compilation will hit the warning even if people appends -fno-stack-protector. Is this okay? In general, if the option is '-fstack-protector -fno-stack-protector', we should not issue warning, right?

Jan 19 2023, 11:47 AM · Restricted Project, Restricted Project
yonghong-song updated subscribers of D142046: [BPF][clang] Ignore stack protector options for BPF target.
Jan 19 2023, 11:25 AM · Restricted Project, Restricted Project

Jan 18 2023

yonghong-song added a reviewer for D142046: [BPF][clang] Ignore stack protector options for BPF target: ast.
Jan 18 2023, 11:21 PM · Restricted Project, Restricted Project
yonghong-song added a comment to D142046: [BPF][clang] Ignore stack protector options for BPF target.

@compnerd could you also take a look at this patch?

Jan 18 2023, 11:21 PM · Restricted Project, Restricted Project
yonghong-song added a reviewer for D142046: [BPF][clang] Ignore stack protector options for BPF target: compnerd.
Jan 18 2023, 10:44 PM · Restricted Project, Restricted Project

Jan 17 2023

yonghong-song accepted D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros..

LGTM. Thanks!

Jan 17 2023, 8:46 PM · Restricted Project, Restricted Project

Jan 7 2023

yonghong-song committed rGf60aefdc7ff1: [BPF] generate btf_decl_tag records for params of extern functions (authored by eddyz87).
[BPF] generate btf_decl_tag records for params of extern functions
Jan 7 2023, 9:34 AM · Restricted Project, Restricted Project
yonghong-song closed D140971: [BPF] generate btf_decl_tag records for params of extern functions.
Jan 7 2023, 9:34 AM · Restricted Project, Restricted Project
yonghong-song accepted D140971: [BPF] generate btf_decl_tag records for params of extern functions.
Jan 7 2023, 9:27 AM · Restricted Project, Restricted Project

Jan 6 2023

yonghong-song committed rG58bdf8f9a8c3: [BPF] preserve btf_decl_tag for parameters of extern functions (authored by eddyz87).
[BPF] preserve btf_decl_tag for parameters of extern functions
Jan 6 2023, 11:03 PM · Restricted Project, Restricted Project
yonghong-song closed D140970: [BPF] preserve btf_decl_tag for parameters of extern functions.
Jan 6 2023, 11:02 PM · Restricted Project, Restricted Project
yonghong-song accepted D140970: [BPF] preserve btf_decl_tag for parameters of extern functions.

LGTM. I will add // REQUIRES: bpf-registered-target in the test to ensure it only executed with bpf target.

Jan 6 2023, 10:53 PM · Restricted Project, Restricted Project
yonghong-song committed rG5702202ad666: [BPF] Triple::isBPF() utility method (authored by eddyz87).
[BPF] Triple::isBPF() utility method
Jan 6 2023, 10:37 PM · Restricted Project, Restricted Project
yonghong-song closed D140969: [BPF] Triple::isBPF() utility method.
Jan 6 2023, 10:37 PM · Restricted Project, Restricted Project
yonghong-song accepted D140969: [BPF] Triple::isBPF() utility method.
Jan 6 2023, 10:10 PM · Restricted Project, Restricted Project

Jan 3 2023

yonghong-song added inline comments to D140929: [BPF] Support for "btf_decl_tag" annotations for arguments of extern functions.
Jan 3 2023, 11:52 PM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D140929: [BPF] Support for "btf_decl_tag" annotations for arguments of extern functions.

Please separate the patch to clang and llvm part.

Jan 3 2023, 11:27 PM · Restricted Project, Restricted Project, Restricted Project
yonghong-song updated subscribers of D140929: [BPF] Support for "btf_decl_tag" annotations for arguments of extern functions.
Jan 3 2023, 11:23 PM · Restricted Project, Restricted Project, Restricted Project

Dec 29 2022

yonghong-song committed rGed068386b451: [BPF] Use SectionForGlobal() for section names computation in BTF (authored by eddyz87).
[BPF] Use SectionForGlobal() for section names computation in BTF
Dec 29 2022, 11:28 AM · Restricted Project, Restricted Project
yonghong-song closed D140505: [BPF] Use SectionForGlobal() for section names computation in BTF.
Dec 29 2022, 11:27 AM · Restricted Project, Restricted Project

Dec 28 2022

yonghong-song added a comment to D138477: MC: Add .data. and .rodata. prefixes to MCContext section classification.

Somehow, CCACHE does not work for me, which has an error message like missing 'malloc/malloc.h'. I used the following scripts without CCACHE.

$ cat build_llvm_debug.sh
cd llvm-project/llvm/build
Dec 28 2022, 9:35 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D140505: [BPF] Use SectionForGlobal() for section names computation in BTF.
Dec 28 2022, 9:22 AM · Restricted Project, Restricted Project
yonghong-song added a comment to D140505: [BPF] Use SectionForGlobal() for section names computation in BTF.

Otherwise, the patch LGTM.

Dec 28 2022, 9:16 AM · Restricted Project, Restricted Project

Dec 27 2022

yonghong-song added inline comments to D138477: MC: Add .data. and .rodata. prefixes to MCContext section classification.
Dec 27 2022, 8:04 PM · Restricted Project, Restricted Project
yonghong-song committed rG5922d3612294: [MC][BPF] Add bpf guard for MC test data-section-prefix.ll (authored by yonghong-song).
[MC][BPF] Add bpf guard for MC test data-section-prefix.ll
Dec 27 2022, 8:02 PM · Restricted Project, Restricted Project
yonghong-song committed rGf27c4903c43b: MC: Add .data. and .rodata. prefixes to MCContext section classification (authored by davemarchevsky).
MC: Add .data. and .rodata. prefixes to MCContext section classification
Dec 27 2022, 4:04 PM · Restricted Project, Restricted Project
yonghong-song closed D138477: MC: Add .data. and .rodata. prefixes to MCContext section classification.
Dec 27 2022, 4:03 PM · Restricted Project, Restricted Project

Nov 23 2022

yonghong-song accepted D138565: [BPF] Avoid checking for intrinsics using string comparisons. NFC.

Thanks for the code simplification. LGTM.

Nov 23 2022, 11:34 AM · Restricted Project, Restricted Project

Nov 1 2022

yonghong-song committed rG2f047b56ba0e: [clang][Sema] Fix a clang crash with btf_type_tag (authored by yonghong-song).
[clang][Sema] Fix a clang crash with btf_type_tag
Nov 1 2022, 8:07 AM · Restricted Project, Restricted Project
yonghong-song closed D136807: [clang][Sema] Fix a clang crash with btf_type_tag.
Nov 1 2022, 8:07 AM · Restricted Project, Restricted Project
yonghong-song updated the diff for D136807: [clang][Sema] Fix a clang crash with btf_type_tag.
  • improve the bug description in release note.
Nov 1 2022, 7:58 AM · Restricted Project, Restricted Project

Oct 31 2022

yonghong-song added a comment to D136807: [clang][Sema] Fix a clang crash with btf_type_tag.

@aaron.ballman or @dblaikie I have addressed the comments, could you take a look again?

Oct 31 2022, 1:02 PM · Restricted Project, Restricted Project

Oct 28 2022

yonghong-song committed rG524c640090a8: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names (authored by eddyz87).
[clang][DebugInfo] Emit DISubprogram for extern functions with reserved names
Oct 28 2022, 8:08 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song closed D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names.
Oct 28 2022, 8:08 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2022

yonghong-song accepted D136042: [DAG] Enable combineShiftOfShiftedLogic folds after type legalization.
Oct 27 2022, 10:48 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D136807: [clang][Sema] Fix a clang crash with btf_type_tag.
  • Add the bug fix description in Release Note
  • Actually compare debuginfo btf_type_tag output instead of marking 'expected-no-diagnostics'.
Oct 27 2022, 10:27 AM · Restricted Project, Restricted Project
yonghong-song added a comment to D136807: [clang][Sema] Fix a clang crash with btf_type_tag.

The changes generally look good to me, but can you add a release note for the fix as well?

Yes, will add the bug fix brief description to clang/docs/ReleaseNotes.rst

Oct 27 2022, 10:20 AM · Restricted Project, Restricted Project

Oct 26 2022

yonghong-song updated subscribers of D136807: [clang][Sema] Fix a clang crash with btf_type_tag.
Oct 26 2022, 6:05 PM · Restricted Project, Restricted Project
yonghong-song requested review of D136807: [clang][Sema] Fix a clang crash with btf_type_tag.
Oct 26 2022, 5:57 PM · Restricted Project, Restricted Project

Oct 17 2022

yonghong-song added a comment to D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names.

Hmm - this does mean linking IR can produce invalid code, though, right (you link in a definition of the function, so what was valid is now invalid - because it now has a definition, can be inlined, etc)? Is that new? concerning?

Oct 17 2022, 11:01 PM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names.

@aprantl The following example shows the difference between gcc and clang w.r.t. reserved names.

Oct 17 2022, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D136042: [DAG] Enable combineShiftOfShiftedLogic folds after type legalization.

Thanks. The change looks good to me from BPF perspective as it fixed the regression in https://github.com/llvm/llvm-project/issues/57872.

Oct 17 2022, 8:42 AM · Restricted Project, Restricted Project

Sep 28 2022

yonghong-song committed rG75be0482a2e2: [clang][DebugInfo] Emit debuginfo for non-constant case value (authored by yonghong-song).
[clang][DebugInfo] Emit debuginfo for non-constant case value
Sep 28 2022, 12:11 PM · Restricted Project, Restricted Project
yonghong-song closed D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value.
Sep 28 2022, 12:11 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value.
  • simplify test case, add more CHECK's and add comments to explain the test.
Sep 28 2022, 12:07 PM · Restricted Project, Restricted Project
yonghong-song added a comment to D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value.

SGTM - could you also add some CHECKs in the test that show the enumeration was added to the enumerators list on the CU (& you can probably test with just one enumerator - don't need two in each test for instance)

Sep 28 2022, 12:00 AM · Restricted Project, Restricted Project

Sep 27 2022

yonghong-song updated subscribers of D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value.
Sep 27 2022, 11:57 PM · Restricted Project, Restricted Project
yonghong-song requested review of D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value.
Sep 27 2022, 12:04 AM · Restricted Project, Restricted Project

Sep 21 2022

yonghong-song added a comment to D77804: [DAG] Enable ISD::SRL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.

@yonghong-song Please can you raise this as an issue and include the IR as well? AFAICT this is a perf regression, and not an actual bug

Sep 21 2022, 7:53 AM · Restricted Project, Restricted Project

Sep 20 2022

yonghong-song added a comment to D77804: [DAG] Enable ISD::SRL SimplifyMultipleUseDemandedBits handling inside SimplifyDemandedBits.

Hi, we found a regression with some bpf code with this patch. The following shows the problem:

Sep 20 2022, 10:43 PM · Restricted Project, Restricted Project

Sep 9 2022

yonghong-song added a comment to D133464: [WIP][BPF] Add sext load instructions.

I hacked the kernel x64 jit part, with the following jit for sext load, it seems working okay from jit perspective.

+/* LDX: dst_reg = *(s8*)(src_reg + off) */
+static void emit_ldx_sext(u8 **pprog, u32 size, u32 dst_reg, u32 src_reg, int off)
+{
+       u8 *prog = *pprog;
+
+       switch (size) {
+       case BPF_B:
+               /* Emit 'movsx rax, byte ptr [rax + off]' */
+               EMIT3(add_2mod(0x48, src_reg, dst_reg), 0x0F, 0xBE);
+               break;
+       case BPF_H:
+               /* Emit 'movsx rax, word ptr [rax + off]' */
+               EMIT3(add_2mod(0x48, src_reg, dst_reg), 0x0F, 0xBF);
+               break;
+       case BPF_W:
+               /* Emit 'movsx rax, dword ptr [rax+0x14]' */
+               EMIT2(add_2mod(0x48, src_reg, dst_reg), 0x63);
+               break;
+       }
+       emit_insn_suffix(&prog, src_reg, dst_reg, off);
+       *pprog = prog;
+}
Sep 9 2022, 9:22 AM · Restricted Project, Restricted Project
yonghong-song added a comment to D133464: [WIP][BPF] Add sext load instructions.

All major architectures support sign extension load (x64, arm64, sparc, webassembly, lanai, etc.)

Sep 9 2022, 9:19 AM · Restricted Project, Restricted Project

Sep 7 2022

yonghong-song requested review of D133464: [WIP][BPF] Add sext load instructions.
Sep 7 2022, 6:11 PM · Restricted Project, Restricted Project

Aug 18 2022

yonghong-song committed rG481d67d310a7: [Clang][BPF] Support record argument with direct values (authored by yonghong-song).
[Clang][BPF] Support record argument with direct values
Aug 18 2022, 7:12 PM · Restricted Project, Restricted Project, Restricted Project
yonghong-song closed D132144: [Clang][BPF] Support record argument with direct values.
Aug 18 2022, 7:12 PM · Restricted Project, Restricted Project, Restricted Project
yonghong-song updated the diff for D132144: [Clang][BPF] Support record argument with direct values.

add two llvm/test/CodeGen/BPF tests.

Aug 18 2022, 4:47 PM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D132144: [Clang][BPF] Support record argument with direct values.
but if the function is always_inline it can have more than 5 arguments, right?
Aug 18 2022, 4:01 PM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D132144: [Clang][BPF] Support record argument with direct values.

Kernel changes were assuming at most 2

Aug 18 2022, 11:37 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D132144: [Clang][BPF] Support record argument with direct values.

The compiler only counted the total number of registers won't exceed 5. You could have 5 struct arguments (each one register), or 2 struct arguments (with two registers each) and one integer register.
Whether to pass by value or by reference is a ABI issue, not related to the number of arguments. Checking whether arguments are enough or not is left to BPF backend lowering.
This is an example,

[$~/tmp3] cat t3.c
int foo(int a1, int a2, int a3, int a4, int a5, int a6) {
  return a1 + a2 + a3 + a4 + a5 + a6;
}
[$ ~/tmp3] clang -target bpf -O2 -S -emit-llvm t3.c
[$~/tmp3] clang -target bpf -O2 -S t3.c
t3.c:1:5: error: defined with too many args
int foo(int a1, int a2, int a3, int a4, int a5, int a6) {
    ^
1 error generated.
[$ ~/tmp3]
Aug 18 2022, 11:34 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D132144: [Clang][BPF] Support record argument with direct values.

Are there any restrictions about number of struct arguments that can be passed in? Kernel changes were assuming at most 2, should we have a test that tests passing 3 structs that fit into 5 input registers and another test that passes 3 structs that do not fit in 5 input registers? And what should be the behavior in the latter case -- compilation error or switch to "pass by reference"?

Aug 18 2022, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song requested review of D132144: [Clang][BPF] Support record argument with direct values.
Aug 18 2022, 9:51 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

yonghong-song committed rGd9198f64d9be: [Clang][BPF]: Force sign/zero extension for return values in caller (authored by yonghong-song).
[Clang][BPF]: Force sign/zero extension for return values in caller
Aug 16 2022, 4:08 PM · Restricted Project, Restricted Project
yonghong-song closed D131598: [Clang][BPF]: Force sign/zero extension for return values in caller.
Aug 16 2022, 4:08 PM · Restricted Project, Restricted Project

Aug 10 2022

yonghong-song requested review of D131598: [Clang][BPF]: Force sign/zero extension for return values in caller.
Aug 10 2022, 10:35 AM · Restricted Project, Restricted Project

Aug 9 2022

yonghong-song added a comment to D131468: [WIP][BPF]: Force sign/zero extension for arguments in callee and return values in caller.

D124435 is going to change the assumption :)

Aug 9 2022, 12:16 AM · Restricted Project, Restricted Project

Aug 8 2022

yonghong-song retitled D131468: [WIP][BPF]: Force sign/zero extension for arguments in callee and return values in caller from [WIP][BPF]: Force truncation for arguments in callee and return values in caller to [WIP][BPF]: Force sign/zero extension for arguments in callee and return values in caller.
Aug 8 2022, 11:23 PM · Restricted Project, Restricted Project
yonghong-song requested review of D131468: [WIP][BPF]: Force sign/zero extension for arguments in callee and return values in caller.
Aug 8 2022, 11:21 PM · Restricted Project, Restricted Project

Jul 13 2022

yonghong-song committed rG6e6c1efe04d4: [BPF] Handle anon record for CO-RE relocations (authored by yonghong-song).
[BPF] Handle anon record for CO-RE relocations
Jul 13 2022, 3:17 PM · Restricted Project, Restricted Project
yonghong-song closed D129621: [BPF] Handle anon record for CO-RE relocations.
Jul 13 2022, 3:17 PM · Restricted Project, Restricted Project
yonghong-song requested review of D129621: [BPF] Handle anon record for CO-RE relocations.
Jul 13 2022, 12:35 AM · Restricted Project, Restricted Project

Jun 29 2022

yonghong-song committed rG70557eb3938a: [clang][BPF] Update comment to include TYPE_MATCH (authored by d-e-s-o).
[clang][BPF] Update comment to include TYPE_MATCH
Jun 29 2022, 6:34 PM · Restricted Project, Restricted Project
yonghong-song closed D126839: [clang][BPF] Update comment to include TYPE_MATCH.
Jun 29 2022, 6:34 PM · Restricted Project, Restricted Project
yonghong-song committed rGd129ac27e872: [BPF] Introduce support for type match relocations (authored by d-e-s-o).
[BPF] Introduce support for type match relocations
Jun 29 2022, 6:24 PM · Restricted Project, Restricted Project
yonghong-song closed D126838: [BPF] Introduce support for type match relocations.
Jun 29 2022, 6:24 PM · Restricted Project, Restricted Project
yonghong-song accepted D126838: [BPF] Introduce support for type match relocations.
Jun 29 2022, 6:00 PM · Restricted Project, Restricted Project
yonghong-song accepted D126839: [clang][BPF] Update comment to include TYPE_MATCH.
Jun 29 2022, 5:58 PM · Restricted Project, Restricted Project

Jun 6 2022

yonghong-song committed rGdc1c43d726c8: [BPF] Add BTF 64bit enum value support (authored by yonghong-song).
[BPF] Add BTF 64bit enum value support
Jun 6 2022, 11:36 AM · Restricted Project, Restricted Project
yonghong-song closed D124641: [BPF] Add BTF 64bit enum value support.
Jun 6 2022, 11:36 AM · Restricted Project, Restricted Project

Jun 2 2022

yonghong-song added a comment to D126839: [clang][BPF] Update comment to include TYPE_MATCH.

Also let us merge it unti kernel side change is in reasonable shape.

From what I understand it may take several days or some other not-precisely specified time until "nightly" builds, which we use in the BPF CI, pick up the change. Hence, I was under the impression that we should attempt to merge it sooner rather than later once it's ready to be merged. The kernel changes are in good enough shape to show feasibility, so I don't really see why not, but it's your call.

Jun 2 2022, 1:51 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D126838: [BPF] Introduce support for type match relocations.
Jun 2 2022, 1:34 PM · Restricted Project, Restricted Project
yonghong-song added a comment to D126839: [clang][BPF] Update comment to include TYPE_MATCH.

LGTM. But add the reference (https://reviews.llvm.org/D126838) to the commit message to indicate which 'earlier change'. Also let us merge it unti kernel side change is in reasonable shape.

Jun 2 2022, 11:59 AM · Restricted Project, Restricted Project

May 24 2022

yonghong-song abandoned D126223: [Clang][Sema] Fix a SemaType/VisitTagTypeLoc assertion.

@compnerd provided a better fix https://reviews.llvm.org/D126093, so I am going to close this one.

May 24 2022, 12:12 AM · Restricted Project, Restricted Project
yonghong-song accepted D126093: Sema: adjust assertion to account for deduced types.

Sorry. I missed this patch somehow and did another patch https://reviews.llvm.org/D126223. My patch skipped TL.setNameLoc(DS.getTypeSpecTypeNameLoc()); which probably not correct. Accept this patch and abandon my patch D126223.

May 24 2022, 12:10 AM · Restricted Project, Restricted Project

May 23 2022

yonghong-song requested review of D126223: [Clang][Sema] Fix a SemaType/VisitTagTypeLoc assertion.
May 23 2022, 10:04 AM · Restricted Project, Restricted Project

May 20 2022

yonghong-song added a comment to D111199: [Clang][LLVM][Attr] support btf_type_tag attribute.

@compnerd Thanks for reporting. I will take a look as soon as possible.

May 20 2022, 6:09 PM · Restricted Project, Restricted Project, Restricted Project

May 12 2022

yonghong-song updated the diff for D124641: [BPF] Add BTF 64bit enum value support.
  • also set signed enum for dwarf::DW_ATE_signed_char int.
May 12 2022, 6:51 PM · Restricted Project, Restricted Project