Page MenuHomePhabricator

yonghong-song (Yonghong Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 4 2018, 11:50 PM (112 w, 6 d)

Recent Activity

Today

yonghong-song committed rG286daafd6512: [BPF] support atomic instructions (authored by yonghong-song).
[BPF] support atomic instructions
Thu, Dec 3, 7:47 AM
yonghong-song closed D72184: [BPF] support atomic instructions.
Thu, Dec 3, 7:46 AM · Restricted Project, Restricted Project

Yesterday

yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

fix clang-format warnings.

Wed, Dec 2, 11:47 PM · Restricted Project, Restricted Project
yonghong-song committed rG61a06c071dd1: BPF: add a test for selectiondag alias analysis w.r.t. lifetime (authored by yonghong-song).
BPF: add a test for selectiondag alias analysis w.r.t. lifetime
Wed, Dec 2, 10:28 PM
yonghong-song closed D92451: BPF: add a test for selectiondag alias analysis w.r.t. lifetime.
Wed, Dec 2, 10:27 PM · Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

use llvm_unreachable() in default case of the switch statement

Wed, Dec 2, 12:07 AM · Restricted Project, Restricted Project

Tue, Dec 1

yonghong-song updated the diff for D72184: [BPF] support atomic instructions.
  • remove -mcpu=v4.
  • for new instructions (except xadd), for 32bit mode, only alu32 mode is supported. I chose this way since we have -mcpu=v3 for a while which has alu32 as default. We really want to promote alu32 mode. The new kernel which supports atomic op definitely supports alu32 well...
Tue, Dec 1, 11:56 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Tue, Dec 1, 9:39 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Tue, Dec 1, 9:28 PM · Restricted Project, Restricted Project
yonghong-song updated the summary of D92451: BPF: add a test for selectiondag alias analysis w.r.t. lifetime.
Tue, Dec 1, 7:51 PM · Restricted Project
yonghong-song added a reviewer for D92451: BPF: add a test for selectiondag alias analysis w.r.t. lifetime: niravd.
Tue, Dec 1, 7:46 PM · Restricted Project
yonghong-song added a comment to D89149: [SelectionDAG] Fix alias checking with potential later stack reuse.

@niravd Looks like https://reviews.llvm.org/D91833 fixed the issue. I have created a BPF patch https://reviews.llvm.org/D92451 with a test case so if anything happens we can detect the regression. Could you take a look whether https://reviews.llvm.org/D91833 can truely fix the issue?

Tue, Dec 1, 7:46 PM · Restricted Project
yonghong-song requested review of D92451: BPF: add a test for selectiondag alias analysis w.r.t. lifetime.
Tue, Dec 1, 7:43 PM · Restricted Project
yonghong-song abandoned D88525: BPF: use Source instead of ILP scheduler for selection dag.

Looks like https://reviews.llvm.org/D91833 fixed the issue. Abandon this.

Tue, Dec 1, 7:41 PM · Restricted Project

Mon, Nov 30

yonghong-song added a comment to D89149: [SelectionDAG] Fix alias checking with potential later stack reuse.

As an alternative, we could update ImproveChain (and visitLIFETIME_END) to limit the aliasing
around lifetime_start / end to disallow improving the chain dependence of a mem op node
from a different lifetime node that may alias. That should prohibit access from two aliasable
frame indices from being concurrent while still allowing us to leverage that disjoint allocs should be disjoint.

Mon, Nov 30, 11:34 PM · Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.
  • remove atomic_fetch_sub which can be implemented with neg + atomic_fetch_add
  • add support for xand, xor, xxor (xadd already been supported)
  • for any given __sync_fetch_and_{add, and, or, xor}, llvm will generate either atomic_fetch_<op> or x<op> depending on whether the return value is used or not.
Mon, Nov 30, 7:43 PM · Restricted Project, Restricted Project

Wed, Nov 25

yonghong-song accepted D91990: [BPF][NewPM] Port bpf-adjust-opt to NPM and add it to pipeline.

The change looks good to me. Thanks!

Wed, Nov 25, 11:13 PM · Restricted Project

Mon, Nov 23

yonghong-song added a comment to D91990: [BPF][NewPM] Port bpf-adjust-opt to NPM and add it to pipeline.

No problem. I will wait for that dependent patch getting merged and then will do the review.

Mon, Nov 23, 6:45 PM · Restricted Project
yonghong-song added a comment to D91990: [BPF][NewPM] Port bpf-adjust-opt to NPM and add it to pipeline.

I hit a build failure with latest llvm-project repo (top commit e42021d5cc25 ("[Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility")).

Mon, Nov 23, 4:38 PM · Restricted Project
yonghong-song added a comment to D72184: [BPF] support atomic instructions.

Ya, the above llvm crash is expected as bpf backend does not handle AtomicStore.

Mon, Nov 23, 8:24 AM · Restricted Project, Restricted Project

Thu, Nov 19

yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

add some comments in test w.r.t. __sync_lock_test_and_set()

Thu, Nov 19, 10:01 PM · Restricted Project, Restricted Project
yonghong-song added a comment to D72184: [BPF] support atomic instructions.

okay, my fault. I must have uploaded an old version of the patch so comment is not in the test. will upload the new version tonight.

Thu, Nov 19, 9:38 PM · Restricted Project, Restricted Project
yonghong-song added a comment to D72184: [BPF] support atomic instructions.
In D72184#2407264, @ast wrote:

Looks like the test didn't change. Only commit log... that's fine. I think the diff is ready to land, but let's wait for the kernel patches to be ready as well.

Thu, Nov 19, 9:34 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

add proper comment in test and clarify in commit message for __sync_lock_test_and_set which actually means an atomic exchange operation.

Thu, Nov 19, 8:39 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Thu, Nov 19, 11:36 AM · Restricted Project, Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.
  • remove all char/short atomic operations
  • remove barrier instruction
Thu, Nov 19, 11:16 AM · Restricted Project, Restricted Project
yonghong-song added a comment to D72184: [BPF] support atomic instructions.

Thanks. Somehow my build is successful. I kind of know what is the possible issue but wonder why I did not hit it.

Can we please keep barriers out of scope? I think there's a lot of design to be done there and I'd rather just get the core atomics working first.

The reason I put it here is to make *cpu=v4* roughly complete. Because if you adds barrier later we may need to add "cpu=v5", and I want to avoid that. But I agree this is a little bit overwhelming on you and let us discuss in bpf office hour how to proceed.

Thu, Nov 19, 7:53 AM · Restricted Project, Restricted Project

Wed, Nov 18

yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Wed, Nov 18, 7:55 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

add support for a barrier function. The correspond C code is sync_synchronize().
If we want to have variant like barrier for read/write/rw, etc. we may need to define bpf specific barrier functions as
sync_synchronize() does not allow taking additional parameters. I tentatively use one particular encoding but we can certainly change that later.

Wed, Nov 18, 11:36 AM · Restricted Project, Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

add fetch_and_{and,or,xor} support
force cmpxchg insn return results in r0 like r0 = cmpxchg(addr, r0, new)

Wed, Nov 18, 10:26 AM · Restricted Project, Restricted Project
yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Wed, Nov 18, 8:01 AM · Restricted Project, Restricted Project

Tue, Nov 17

yonghong-song added a comment to D72184: [BPF] support atomic instructions.

make sense. will add and/or/xor support in the next revision. will also think about how to support hardware-level barrier. Totally agree that we should have adequate atomic op support in cpu=v4.

Tue, Nov 17, 11:12 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

use the same register for dst and val for fetch-add, fetch-sub and xchg instructions.
for fetch-sub, if it is deemed later using different registers for dst/val is preferred, I can make the change then.

Tue, Nov 17, 1:26 PM · Restricted Project, Restricted Project

Mon, Nov 16

yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Mon, Nov 16, 9:49 AM · Restricted Project, Restricted Project
yonghong-song committed rG4369223ea73c: BPF: make __builtin_btf_type_id() return 64bit int (authored by yonghong-song).
BPF: make __builtin_btf_type_id() return 64bit int
Mon, Nov 16, 7:09 AM
yonghong-song closed D91489: BPF: make __builtin_btf_type_id() return 64bit int.
Mon, Nov 16, 7:09 AM · Restricted Project, Restricted Project

Sun, Nov 15

yonghong-song updated the diff for D91489: BPF: make __builtin_btf_type_id() return 64bit int.

fix clang-format warning

Sun, Nov 15, 10:21 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D91489: BPF: make __builtin_btf_type_id() return 64bit int.
Sun, Nov 15, 10:14 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D91489: BPF: make __builtin_btf_type_id() return 64bit int.
Sun, Nov 15, 11:33 AM · Restricted Project, Restricted Project

Sat, Nov 14

yonghong-song requested review of D91489: BPF: make __builtin_btf_type_id() return 64bit int.
Sat, Nov 14, 8:06 PM · Restricted Project, Restricted Project

Nov 3 2020

yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Nov 3 2020, 2:37 PM · Restricted Project, Restricted Project
yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Nov 3 2020, 10:45 AM · Restricted Project, Restricted Project
yonghong-song updated the summary of D72184: [BPF] support atomic instructions.
Nov 3 2020, 10:39 AM · Restricted Project, Restricted Project
yonghong-song updated the diff for D72184: [BPF] support atomic instructions.
  • remove RFC tag.
  • addressed comments for encoding, etc.
Nov 3 2020, 10:38 AM · Restricted Project, Restricted Project
yonghong-song added inline comments to D72184: [BPF] support atomic instructions.
Nov 3 2020, 7:16 AM · Restricted Project, Restricted Project

Nov 2 2020

yonghong-song updated the diff for D72184: [BPF] support atomic instructions.

changed encoding based on internal discussion on encoding
add a test

Nov 2 2020, 11:47 PM · Restricted Project, Restricted Project

Oct 28 2020

yonghong-song updated the summary of D72184: [BPF] support atomic instructions.
Oct 28 2020, 11:52 PM · Restricted Project, Restricted Project

Oct 15 2020

yonghong-song added a comment to D89149: [SelectionDAG] Fix alias checking with potential later stack reuse.

As an alternative, we could update ImproveChain (and visitLIFETIME_END) to limit the aliasing around lifetime_start / end to disallow improving the chain dependence of a mem op node from a different lifetime node that may alias. That should prohibit access from two aliasable frame indices from being concurrent while still allowing us to leverage that disjoint allocs should be disjoint.

Oct 15 2020, 2:00 PM · Restricted Project
yonghong-song added inline comments to D89149: [SelectionDAG] Fix alias checking with potential later stack reuse.
Oct 15 2020, 12:59 PM · Restricted Project

Oct 14 2020

yonghong-song added a comment to D89149: [SelectionDAG] Fix alias checking with potential later stack reuse.

ping @courbet @niravd, any comments on this patch?

Oct 14 2020, 7:53 AM · Restricted Project

Oct 10 2020

yonghong-song updated subscribers of D87428: BPF: avoid same condition evaluated in multiple branch instructions.
Oct 10 2020, 10:31 PM · Restricted Project

Oct 9 2020

yonghong-song updated subscribers of D89149: [SelectionDAG] Fix alias checking with potential later stack reuse.
Oct 9 2020, 1:06 PM · Restricted Project
yonghong-song accepted D89083: [BPF] Make BPFAbstractMemberAccessPass required.

LGTM. Thanks!

Oct 9 2020, 11:20 AM · Restricted Project
yonghong-song added a comment to D89083: [BPF] Make BPFAbstractMemberAccessPass required.

Thanks for explanation for IsRequired(), really appreciated.

Oct 9 2020, 11:00 AM · Restricted Project
yonghong-song requested review of D89149: [SelectionDAG] Fix alias checking with potential later stack reuse.
Oct 9 2020, 10:24 AM · Restricted Project

Oct 8 2020

yonghong-song added a comment to D89083: [BPF] Make BPFAbstractMemberAccessPass required.

If I understand correctly, "isRequired()" means this pass has to run. In this regard, BPFPreserveDIType also need isRequired().
Could you explain a little bit what if one pass does not have "isRequired()"? How PassManager deals with it?

Oct 8 2020, 10:24 PM · Restricted Project
yonghong-song added inline comments to D89083: [BPF] Make BPFAbstractMemberAccessPass required.
Oct 8 2020, 10:21 PM · Restricted Project
yonghong-song updated the diff for D87428: BPF: avoid same condition evaluated in multiple branch instructions.
  • added tests, added llc option to disable optimization if needed.
  • removed RFC tag.
Oct 8 2020, 3:49 PM · Restricted Project

Oct 7 2020

yonghong-song committed rG316117216867: BPF: fix incorrect DAG2DAG load optimization (authored by yonghong-song).
BPF: fix incorrect DAG2DAG load optimization
Oct 7 2020, 7:09 PM
yonghong-song closed D89021: BPF: fix incorrect DAG2DAG load optimization.
Oct 7 2020, 7:09 PM · Restricted Project
yonghong-song requested review of D89021: BPF: fix incorrect DAG2DAG load optimization.
Oct 7 2020, 6:21 PM · Restricted Project
yonghong-song committed rGddf1864ace48: BPF: add AdjustOpt IR pass to generate verifier friendly codes (authored by yonghong-song).
BPF: add AdjustOpt IR pass to generate verifier friendly codes
Oct 7 2020, 8:50 AM
yonghong-song closed D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.
Oct 7 2020, 8:50 AM · Restricted Project

Oct 6 2020

yonghong-song committed rGedd71db38b0c: BPF: avoid duplicated globals for CORE relocations (authored by yonghong-song).
BPF: avoid duplicated globals for CORE relocations
Oct 6 2020, 10:42 PM
yonghong-song closed D88942: BPF: avoid duplicated globals for CORE relocations.
Oct 6 2020, 10:42 PM · Restricted Project
yonghong-song updated the diff for D88942: BPF: avoid duplicated globals for CORE relocations.
  • got an even simpler fix. Just change the map to hold reloc globals GEPGlobals to be class static, so it will be available for all instances of BPFAbstractMemberAccess. this also resolved the issue for NPM nicely.
Oct 6 2020, 10:29 PM · Restricted Project
yonghong-song requested review of D88942: BPF: avoid duplicated globals for CORE relocations.
Oct 6 2020, 9:25 PM · Restricted Project

Oct 5 2020

yonghong-song added a comment to D88855: [BPF][NewPM] Make BPFTargetMachine properly adjust NPM optimizer pipeline.

BTW, can you share what is the plan for NPM? Any expected time to turn it on as the default?

Oct 5 2020, 10:58 PM · Restricted Project
yonghong-song accepted D88855: [BPF][NewPM] Make BPFTargetMachine properly adjust NPM optimizer pipeline.

I think I got how to enable npm in opt. It is -passes option in opt -passes='default<O2>' %s. It looks good. Will stamp it.

Oct 5 2020, 10:56 PM · Restricted Project
yonghong-song added a comment to D88855: [BPF][NewPM] Make BPFTargetMachine properly adjust NPM optimizer pipeline.

@aeubanks I assume this is related to new pass manager and is not on by default? What is the option I could turn npm on and give a try? Looks like Hexagon is another backend which has implemented npm support. We may plan to implement new (early or module) passes so we need to modify both adjustPassManager and registerPassBuilderCallbacks. Understanding how it really functions will help our future work. The code looks correct, esp. when comparing to what Hexagon has done, but I would like to experiment a little bit before accepting the patch. Thanks!

Oct 5 2020, 7:44 PM · Restricted Project

Oct 4 2020

yonghong-song updated the diff for D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.
  • remove RFC tag as proper tests are added
  • added "opt" options so the added optimizations can be disabled.
Oct 4 2020, 10:14 PM · Restricted Project

Sep 30 2020

yonghong-song added a comment to D88525: BPF: use Source instead of ILP scheduler for selection dag.
In D88525#2304656, @ast wrote:

looks like x86 64-bit is ILP, so it's not niche.
Looks like Source gets the least amount of testing (judging by archs that use it).
RegPressure is probably 2nd most used after ILP.
It feels that we should fix it inside ILP instead.

Sep 30 2020, 2:30 PM · Restricted Project
yonghong-song updated the diff for D88525: BPF: use Source instead of ILP scheduler for selection dag.

removed RFC tag as bpf selftests are solved.
using setSchedulingPreference() instead of enableMachineScheduler() to limit the scope
Regarding previous reported failures for bpf selftest test_verif_scale3.o:

  • current llvm-project master: processed 997315 insns
  • enableMachineScheduler() processed 1005967 insns (hacked verifier to increase to permit 2M insns), resulted from more instructions due to enabled machine scheduling phase (and possibly additional regalloc functionality, not verified).
  • setSchedulingPreference() processed 998991 insns
Sep 30 2020, 12:00 AM · Restricted Project

Sep 29 2020

yonghong-song requested review of D88525: BPF: use Source instead of ILP scheduler for selection dag.
Sep 29 2020, 9:02 PM · Restricted Project

Sep 28 2020

yonghong-song committed rGca1ce397acc3: BPF: explicitly specify bpfel triple for certain tests (authored by yonghong-song).
BPF: explicitly specify bpfel triple for certain tests
Sep 28 2020, 8:25 PM
yonghong-song committed rG54d9f743c8b0: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible (authored by yonghong-song).
BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible
Sep 28 2020, 4:57 PM
yonghong-song closed D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.
Sep 28 2020, 4:57 PM · Restricted Project, Restricted Project

Sep 23 2020

yonghong-song updated the diff for D87428: BPF: avoid same condition evaluated in multiple branch instructions.

rebase since https://reviews.llvm.org/D87153 changed

Sep 23 2020, 10:07 AM · Restricted Project

Sep 22 2020

yonghong-song updated the diff for D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.
    • remove RFC tag. The patch is complete and all tests are adjusted and passed.
    • remove the adjustIR phase which tries to coalescing two reloc-globals. My previous implementation did not compare the *last* type in the first reloc-global and the *first* type in the second reloc-global. This will require to traverse the access string (0:1:1:...). This seems too much work for this little optimization. I will delay it into the future as an enhancement.
  • adjusted existing clang/llvm CORE tests so they can pass.
Sep 22 2020, 11:57 PM · Restricted Project, Restricted Project

Sep 21 2020

yonghong-song added inline comments to D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.
Sep 21 2020, 9:03 PM · Restricted Project, Restricted Project
yonghong-song added a reviewer for D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible: anakryiko.
Sep 21 2020, 12:36 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.

add seq_num arg to passthrough builtin

Sep 21 2020, 12:31 PM · Restricted Project
yonghong-song updated the diff for D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.

add seq_num arg to passthrough builtin.

Sep 21 2020, 12:29 PM · Restricted Project, Restricted Project

Sep 15 2020

yonghong-song updated the diff for D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.

minor change: add some more conditions to further restrict transformation.

Sep 15 2020, 8:45 PM · Restricted Project

Sep 14 2020

yonghong-song retitled D87428: BPF: avoid same condition evaluated in multiple branch instructions from [RFC] BPF: avoid same condition evaluated in multiple branch instructions to [RFC PATCH 3] BPF: avoid same condition evaluated in multiple branch instructions.
Sep 14 2020, 6:13 PM · Restricted Project
yonghong-song retitled D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes from [RFC] BPF: add AdjustOpt IR pass to generate verifier friendly codes to [RFC PATCH 2] BPF: add AdjustOpt IR pass to generate verifier friendly codes.
Sep 14 2020, 6:13 PM · Restricted Project
yonghong-song retitled D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible from [RFC] BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible to [RFC PATCH 1] BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.
Sep 14 2020, 6:12 PM · Restricted Project, Restricted Project

Sep 10 2020

yonghong-song added inline comments to D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.
Sep 10 2020, 1:45 PM · Restricted Project, Restricted Project
yonghong-song added a comment to D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.
In D85570#2266620, @ast wrote:

is this based on D87153 ?
the passthrough will be removed later, right?

Sep 10 2020, 1:38 PM · Restricted Project

Sep 9 2020

yonghong-song requested review of D87428: BPF: avoid same condition evaluated in multiple branch instructions.
Sep 9 2020, 7:16 PM · Restricted Project
yonghong-song abandoned D82112: [RFC][BPF] Implement getUserCost() for BPFTargetTransformInfo.

Abandon this one. The current approach is to add "user barriers" in an IR phase before simplifyCFG/instrcombine to disable unfavorable speculative code motion.

Sep 9 2020, 3:36 PM · Restricted Project, Restricted Project
yonghong-song abandoned D81859: [RFC][SimplifyCFG] Allow target to control SpeculateOneExpensiveInst.

Abandon this one. The current approach is to introduce some kind of user barriers before instcombine to prevent such optimization in IR level.

Sep 9 2020, 3:34 PM · Restricted Project
yonghong-song updated the diff for D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.

A few changes:

  • AdjustOpt IR pass only called at EP_ModuleOptimizerEarly now
  • remove the pass which deals with a condition is used in more than one branch insns. This will be added to BPFCheckAndAdjustIR later.
Sep 9 2020, 2:11 PM · Restricted Project
yonghong-song updated the diff for D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.
  • introduced __builtin_bpf_passthrough() and use it for user barrier instead of inline asm. I found inline asm has some impact on inlining when running selftests (specifically checked for map_ptr_kern.c).
  • introduced an IR pass at the beginning of target dependent optimizations to (1). ensure reloc globals not in PHI node, (2). remove __builtin_bpf_passthrough(). (3). coalescing reloc globals if possible.

This patch can now pass all selftests.

Sep 9 2020, 2:07 PM · Restricted Project, Restricted Project

Sep 4 2020

yonghong-song requested review of D87153: BPF: move AbstractMemberAccess and PreserveDIType passes to EP_EarlyAsPossible.
Sep 4 2020, 9:32 AM · Restricted Project, Restricted Project

Sep 1 2020

yonghong-song updated the diff for D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.

add another adjustopt phase right after clang codegen to prevent certain early CSE optimization for __builtin_preserve_* intrinsics.

Sep 1 2020, 10:42 AM · Restricted Project

Aug 28 2020

yonghong-song updated the diff for D85570: BPF: add AdjustOpt IR pass to generate verifier friendly codes.

now all bpf selftests can pass.

Aug 28 2020, 11:54 AM · Restricted Project
yonghong-song committed rG443d352a1c4c: [GlobalISel] fix a compilation error with gcc 6.3.0 (authored by yonghong-song).
[GlobalISel] fix a compilation error with gcc 6.3.0
Aug 28 2020, 9:17 AM

Aug 16 2020

yonghong-song committed rGaa61e4304049: [InstCombine] Fix a compilation bug (authored by yonghong-song).
[InstCombine] Fix a compilation bug
Aug 16 2020, 10:00 PM
yonghong-song committed rG000ad1a976a5: [clang] fix a compilation bug (authored by yonghong-song).
[clang] fix a compilation bug
Aug 16 2020, 9:55 PM