- User Since
- Nov 21 2016, 2:12 PM (331 w, 3 d)
Tue, Mar 28
Mon, Mar 27
Fri, Mar 24
@philipp.tomsich Reverse Ping. What are your plans for this change?
Thu, Mar 23
Wed, Mar 22
This change should probably be marked [NFC] - because the disassembly output won't change in either case, and nor will the result of assembling into an object - the only difference in behaviour is if you parse assembly and then immediately print it again (like these tests do).
To clarify the changes to the tests: they check that we can parse both hint #N and the mnemonic, and when printed they both print out exactly the same way, based on features (the mnemonic if you have pauth, or as hint #n otherwise).
Tue, Mar 21
I only have one comment, beyond that this looks pretty good to me. Please don't forget the licensing info, it's fairly important to add either with or before the test sources are added, so we are totally clear on what is going on. Note with the C test suite, I landed the CMake first, and then the GPL-licensed test sources, rather than the other way around.
Sat, Mar 18
Wed, Mar 15
Don't change the source code, please change the CMakeLists.txt to disable this test if it's incorrect.
Fri, Mar 10
@jhenderson @int3 I think I have addressed your feedback - are you happy for me to land this?
Wed, Mar 8
The CHKFEAT instruction here is not exactly as described in https://developer.arm.com/downloads/-/exploration-tools today - but the next release of that description will be updated with the new syntax.
Mon, Mar 6
Fri, Mar 3
Tagging reviewers. @mehdi_amini I added you as you did the same change to the Support library in rG402461beb051b6a5c158f1e36d8e2c2b676e8804.
Thu, Mar 2
Tests and comment updated. I also split this patch stack away from the unrelated changes for inline asm handling of fp16/bf16.
Most recent change adds tests with multiple uses of the returned value.
Feb 28 2023
Feb 27 2023
Hopefully this addresses the feedback so far.
Updates incoming to add a specific check for netbsd and windows, which are currently excluding the affected tests anyway.
Feb 23 2023
Adding more reviewers. @mgorny you disabled some tests on NetBSD in the past for the same reason (rG92dc7dce4a6f117a497ced1650bc48e5b658f0ea), this just updates how they were disabled.
Feb 20 2023
Feb 16 2023
Feb 13 2023
Which configurations are still using this? Just Polly (via isl), or others too?
Feb 10 2023
@steven_wu @aprantl @dblaikie I'm abandoning this change, because as of rGd768bf994f50 these headers are not used in LLVM (apart from in Polly's isl import, which I have contacted the isl maintainer about). Hopefully this means you can update your clang modules/bazel configurations to properly consider the TargetParser separately from Support, if you wish.
Feb 9 2023
Offline, I suggested to Simon that the info about whether you have thumb2 is available in two places: in the subtarget, and also in the target triple's subarch, and that maybe he could use the latter instead of adding an arm-architecture-specific hook to TTI (which would be better to avoid). He reported that the final subarch during LTO depends on the object order during the link, rather than on something more determinstic, and therefore using the triple feels to me less reliable than the current approach in this patch.
Feb 8 2023
I dislike adding this to the target-independent API - is there a way we can express this with a downcast to an arm-backend-specific class and query on it, rather than adding it globally?
Feb 7 2023
Broadly, I think this is clearer, and shows that RCPC3 is more specific than LSE128 which is more specific than LSE2. I do have one concern shown in the tests.
Feb 3 2023
Most recent diff was to clang-format the patch, which has removed some duplicate includes.
Jan 31 2023
How many other places do we have to manually model that disabling feature X disables all features that require feature X? It's a little infuriating to be honest.
Jan 30 2023
I reported the same issue directly on the commit:
This commit causes an issue with -DBUILD_SHARED_LIBS - You need to add Demangle to the LINK_COMPONENTS in llvm/lib/IR/CMakeLists.txt
I'm not sure I agree with "map naturally", when CRm is a 4-bit field, and both bit 7 and bit 5 are different in the dsb <option> vs dsb <option>nXS instructions.
Jan 27 2023
From your description this sounds right, and GCC matches the new behaviour as far as I can see: https://godbolt.org/z/f1M41dhvv
Jan 26 2023
Thanks, I had been thinking this was the right way to go.
Jan 25 2023
I think we have tests for implies now? I'm not sure what the equivalent API is.