Page MenuHomePhabricator

lenary (Sam Elliott)
Senior Compiler Engineer at Arm

Projects

User does not belong to any projects.

User Details

User Since
Nov 21 2016, 2:12 PM (287 w, 3 d)

Recent Activity

Wed, May 18

lenary committed rG2321c36fbf76: [ARM] Don't Enable AES Pass for Generic Cores (authored by lenary).
[ARM] Don't Enable AES Pass for Generic Cores
Wed, May 18, 5:11 AM · Restricted Project, Restricted Project, Restricted Project
lenary closed D125775: [ARM] Don't Enable AES Pass for Generic Cores.
Wed, May 18, 5:11 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 17

lenary requested review of D125775: [ARM] Don't Enable AES Pass for Generic Cores.
Tue, May 17, 6:38 AM · Restricted Project, Restricted Project, Restricted Project

Fri, May 13

lenary committed rG3a24df992cf8: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum (authored by lenary).
[ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum
Fri, May 13, 2:48 AM · Restricted Project, Restricted Project, Restricted Project
lenary closed D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
Fri, May 13, 2:48 AM · Restricted Project, Restricted Project, Restricted Project
lenary committed rG48ad639036db: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum (authored by lenary).
[NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum
Fri, May 13, 2:42 AM · Restricted Project, Restricted Project
lenary closed D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.
Fri, May 13, 2:41 AM · Restricted Project, Restricted Project, Restricted Project
lenary added a comment to D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.

I spent some time last night trying to work out if a combination of --enable-misched=false --pre-RA-sched=linearize -disable-post-ra -enable-post-misched=false would help avoid having two sets of match lines, and none seemed to. @MaskRay as I can't find a quick way of making it smaller, and the patch these tests are for has been approved, I'm going to land this as-is. I hope that is ok.

Fri, May 13, 2:36 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 12

lenary added a comment to D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.

I want to keep the number of llvm functions the same, as they cover a wide variety of control flow at a wide variety of data widths which the pass should cope with.

One thing that I would like to cut down is the duplicated set of CHECK lines, one with scheduling and one without, but I'm not sure how to do that (the set with scheduling are there to test that -mcpu=cortex-a55 enables the pass), I'm not sure of a better way of doing the same.

Thu, May 12, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
lenary added a comment to D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.

I want to keep the number of llvm functions the same, as they cover a wide variety of control flow at a wide variety of data widths which the pass should cope with.

Thu, May 12, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
lenary added inline comments to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
Thu, May 12, 9:43 AM · Restricted Project, Restricted Project, Restricted Project
lenary updated the diff for D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
  • Address comment nits
  • Rebase
Thu, May 12, 9:41 AM · Restricted Project, Restricted Project, Restricted Project
lenary updated the diff for D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.
  • Upload correct patch.
Thu, May 12, 9:39 AM · Restricted Project, Restricted Project, Restricted Project
lenary updated the diff for D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.
  • Rebase
Thu, May 12, 9:37 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 10

lenary added a comment to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.

Ack to all the comment clarifications, will update patch with those soon (probably tomorrow).

Tue, May 10, 5:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2022

lenary abandoned D123797: [lit] Keep stdout/stderr when using GoogleTest.

@ychen it would have been nice to give me a heads up you were going to land your own implementation. Sorry I didn’t manage to add a unit test before I went on vacation.

Apr 25 2022, 12:34 PM · Restricted Project, Restricted Project

Apr 14 2022

lenary added a reviewer for D123797: [lit] Keep stdout/stderr when using GoogleTest: ychen.
Apr 14 2022, 8:25 AM · Restricted Project, Restricted Project
lenary requested review of D123797: [lit] Keep stdout/stderr when using GoogleTest.
Apr 14 2022, 8:18 AM · Restricted Project, Restricted Project

Apr 13 2022

lenary accepted D123689: [iwyu] Handle regressions in libLLVM header include.
Apr 13 2022, 10:16 AM · Restricted Project, Restricted Project
lenary added inline comments to rGfe02896a7917: [Driver] -fno-optimize-sibling-calls: use the same spelling for its -cc1….
Apr 13 2022, 2:56 AM · Restricted Project, Restricted Project
lenary added inline comments to rGfe02896a7917: [Driver] -fno-optimize-sibling-calls: use the same spelling for its -cc1….
Apr 13 2022, 2:37 AM · Restricted Project, Restricted Project

Apr 7 2022

lenary updated the diff for D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
  • Updated set of safe instructions
  • Address reviewer feedback, including reordering passes.
Apr 7 2022, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
lenary updated the diff for D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.
  • Added additional float and call tests.
Apr 7 2022, 6:56 AM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

lenary added a comment to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.

A few comments before I post the next version of the patch.

Apr 5 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Mar 31 2022

lenary added a comment to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.

Thanks for the review. Lots of comments inline, hopefully Phab doesn't mangle the large one.

Mar 31 2022, 2:13 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

lenary updated the diff for D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
  • Remove whitespace change in ARMSubtarget
  • Remove commented-out debug lines in RDFGraph
Mar 30 2022, 10:20 AM · Restricted Project, Restricted Project, Restricted Project
lenary planned changes to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
Mar 30 2022, 10:16 AM · Restricted Project, Restricted Project, Restricted Project
lenary removed a reviewer for D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum: kparzysz.

@kparzysz I have rewritten this to avoid using RDFGraph, so I don't think this needs you to review it any more.

Mar 30 2022, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
lenary updated the diff for D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
  • Rewrite pass in terms of ReachingDefAnalysis
  • Split tests into separate commit, for ease of review.
Mar 30 2022, 10:14 AM · Restricted Project, Restricted Project, Restricted Project
lenary requested review of D122747: [NFC][ARM] Tests for Cortex-A57 and Cortex-A72 Fused AES Erratum.
Mar 30 2022, 10:08 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2022

lenary added a comment to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.

I have a high level question regarding RDF, as I've not seen it used in many other places, so it may be under-tested on Arm systems at the moment. This currently, for all code, builds an rdf graph, analyze the rdf graph for a fairly rare instructions, then fixes up the code based on that. It might be best to avoid the (possibly expensive?) rdf graph generation for the common case where the instructions are not present. Check that the instruction exists first.

Mar 28 2022, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
lenary accepted D122576: Cleanup includes: final pass.

LGTM

Mar 28 2022, 5:27 AM · Restricted Project, Restricted Project
lenary planned changes to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
Mar 28 2022, 3:54 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

lenary added a comment to rTd26d6943656d: fix UB (read uninitialized memory) in test.

Sorry, I didn't notice this commit go past. This would have been better solved by editing the CMakeLists.txt to add this as a test not to run - we're aiming to not have downstream modifications to the gcc-c-torture tests, so we can update them from GNU's repo without causing regressions.

Mar 24 2022, 7:04 AM

Mar 23 2022

lenary added a comment to D118234: Unit tests to improve code coverage.

Sorry, this dropped off my radar a bit.

Mar 23 2022, 12:58 PM · Restricted Project

Mar 17 2022

lenary committed rGf496330f9719: [ARM] Fix Decode of tsb csync (authored by lenary).
[ARM] Fix Decode of tsb csync
Mar 17 2022, 10:30 AM · Restricted Project
lenary closed D121479: [ARM] Fix Decode of tsb csync.
Mar 17 2022, 10:30 AM · Restricted Project, Restricted Project
lenary added a comment to D92842: [SelectionDAG] Add Target-Independent Compiler Barrier.

Reverse ping. Is there any blocker issue for this patch landing?

Mar 17 2022, 2:27 AM · Restricted Project, Restricted Project

Mar 11 2022

lenary updated the diff for D121479: [ARM] Fix Decode of tsb csync.
  • Add Test
  • Fix Condition on Opcode
Mar 11 2022, 11:30 AM · Restricted Project, Restricted Project
lenary requested review of D121479: [ARM] Fix Decode of tsb csync.
Mar 11 2022, 11:05 AM · Restricted Project, Restricted Project

Mar 8 2022

lenary added a comment to D121169: Cleanup codegen includes.

This is part of the work described here: https://discourse.llvm.org/t/include-what-you-use-include-cleanup/5831

Mar 8 2022, 2:44 AM · Restricted Project, Restricted Project

Mar 7 2022

lenary accepted D120830: [AArch64] Move FeatureSpecRestrict into core 8.0-R architecture..

LGTM. Sorry for the delay, this code is a minefield.

Mar 7 2022, 7:51 AM · Restricted Project, Restricted Project

Mar 1 2022

lenary accepted D120741: Cleanup includes: TransformsUtils.

LGTM with one tiny nit.

Mar 1 2022, 9:54 AM · Restricted Project

Feb 28 2022

lenary committed rG220da125c423: [NFC][Clang][AArch64] Clean up AArch64TargetInfo::hasFeature (authored by lenary).
[NFC][Clang][AArch64] Clean up AArch64TargetInfo::hasFeature
Feb 28 2022, 6:25 AM

Feb 22 2022

lenary added a comment to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.

Ping

Feb 22 2022, 8:19 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2022

lenary added a comment to D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.

@kparzysz I've tagged you due to the changes in RDFGraph, which I believe you are the owner of. The asserts are hit in llvm/test/CodeGen/ARM/inlineasm-error-t-toofewregs.ll - the Register Allocator Chokes on the test due to not having enough registers for the inline assembly. llc then reports the error, but continues running passes (including this one), which then core dumps on the asserts I've removed (The first one hit is in DataFlowGraph::buildStmt). When I run the same testcase with -verify-machineinstrs, there is no verification error, but the verifier seems to have decided that analysing physical reg liveness is too hard (see e.g. MachineVerifier.cpp line 2990). I haven't worked out how else to prevent this pass running if the register allocation is known to be wrong, without analysing every instruction before building the RDFGraph. I wasn't sure the right approach, so I wanted to post the patch and then discuss it, rather than the other way around (so you can see the testcase).

Feb 14 2022, 7:36 AM · Restricted Project, Restricted Project, Restricted Project
lenary requested review of D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum.
Feb 14 2022, 7:30 AM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2022

lenary accepted D119301: [AArch64][ARM] add -Wunaligned-access only for clang.
Feb 10 2022, 9:35 AM · Restricted Project
lenary accepted D119301: [AArch64][ARM] add -Wunaligned-access only for clang.

Ah, I see.

Feb 10 2022, 2:46 AM · Restricted Project

Feb 9 2022

lenary added a comment to D119301: [AArch64][ARM] add -Wunaligned-access only for clang.

I don't fully understand the reasoning for the patch, and you haven't really explained it. I think what you are saying is that the IsAux argument to getTargetFeatures should be considered because it's true for offloading to another compiler, but I don't understand why we think the offload compiler is not clang-compatible, as the features added in getAArch64TargetFeatures and getARMTargetFeatures (and passed to the offloaded compiler) use the LLVM-specific internal names. I would like you to explain this further, and to document what IsAux implies in the code.

Feb 9 2022, 2:06 PM · Restricted Project

Feb 8 2022

lenary accepted D118705: [AArch64] FeaturePerfMon Added to CPUs.
Feb 8 2022, 3:00 AM · Restricted Project

Feb 1 2022

lenary added a comment to D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.

This was landed accidentally before it was approved, but given @tyb0807 had made the changes I asked, I have not asked him to revert it. I've given Post-commit approval on the specific commit.

Feb 1 2022, 3:31 AM · Restricted Project
lenary accepted rGdd88f40c80f5: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.
Feb 1 2022, 3:10 AM

Jan 31 2022

lenary added a comment to D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.

I'm concerned there is no test coverage for:

  • SpeculationBarrierISBDSBEndBB and SpeculationBarrierSBEndBB
  • StoreSwiftAsyncContext
  • JumpTableDest{32,16,8}
Jan 31 2022, 3:25 AM · Restricted Project

Jan 28 2022

lenary accepted D118009: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td.
Jan 28 2022, 3:49 AM · Restricted Project

Jan 27 2022

lenary accepted D118342: Move llvm::array_lenghtof to llvm/ADT/STLArrayExtras.h.
Jan 27 2022, 3:55 AM · Restricted Project

Jan 25 2022

lenary added a comment to D118009: [ARM] Make getInstSizeInBytes() use instruction size from InstrInfo.td.

Other reviewers should be careful with review here. My major concern that I have not yet verified is whether these pseudo's always expand to the same number of instructions or not, which would affect their corresponding size.

Jan 25 2022, 6:58 AM · Restricted Project

Jan 24 2022

lenary added inline comments to D117970: [AArch64] Make getInstSizeInBytes() use instruction size from InstrInfo.td.
Jan 24 2022, 2:59 AM · Restricted Project

Jan 21 2022

lenary committed rG38ac4093d9d2: [NFCI][Support] Avoid ASSERT_/EXPECT_TRUE(A <op> B) (authored by lenary).
[NFCI][Support] Avoid ASSERT_/EXPECT_TRUE(A <op> B)
Jan 21 2022, 5:16 AM
lenary closed D117319: [NFCI][Support] Avoid ASSERT_/EXPECT_TRUE(A <op> B).
Jan 21 2022, 5:15 AM · Restricted Project
lenary removed reviewers for D80963: [WIP][clang] Allow {u}int_fastN_t to be different to {u}int_leastN_t: luismarques, asb.
Jan 21 2022, 4:06 AM · Restricted Project
lenary planned changes to D80963: [WIP][clang] Allow {u}int_fastN_t to be different to {u}int_leastN_t.
Jan 21 2022, 4:06 AM · Restricted Project

Jan 20 2022

lenary added inline comments to D116952: [ConstantFolding] Respect denormal handling mode attributes when folding instructions.
Jan 20 2022, 5:22 AM · Restricted Project, Restricted Project
lenary accepted D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added.

LGTM. I've looked a lot closer at the tests this time around, and am happy with them, and I think the message is phrased better, and there shouldn't be warnings with -cc1as.

Jan 20 2022, 2:14 AM · Restricted Project, Restricted Project

Jan 19 2022

lenary accepted D117693: [llvm][AArch64] Accept armv8.8 "hbc" and "mops" in .arch_extension directive.
Jan 19 2022, 9:43 AM · Restricted Project
lenary added a comment to D117693: [llvm][AArch64] Accept armv8.8 "hbc" and "mops" in .arch_extension directive.

This is looking good. Do we also need a test in llvm/test/MC/AArch64/directive-arch_extension-negative.s too?

Jan 19 2022, 9:04 AM · Restricted Project

Jan 18 2022

lenary resigned from D79141: [RISCV] Better Split Stack Pointer Adjustment for RVC.
Jan 18 2022, 2:22 AM · Restricted Project

Jan 14 2022

lenary requested review of D117319: [NFCI][Support] Avoid ASSERT_/EXPECT_TRUE(A <op> B).
Jan 14 2022, 7:32 AM · Restricted Project
lenary accepted D117271: [AArch64] clang support for Armv8.8/9.3 MOPS.

LGTM

Jan 14 2022, 5:08 AM · Restricted Project, Restricted Project

Jan 13 2022

lenary reopened D116748: [AArch64][ARM][Clang] PerfMon Extension Added.
Jan 13 2022, 8:49 AM · Restricted Project, Restricted Project
lenary added a comment to D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added.

This is coming together well.

Jan 13 2022, 7:43 AM · Restricted Project, Restricted Project

Jan 7 2022

lenary added a comment to D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added.

Reverted for the moment in rG3aec4b3d348d69e6c1ead7cba54677b855293983 while we fix the windows tests.

Jan 7 2022, 5:13 AM · Restricted Project, Restricted Project
lenary committed rG3aec4b3d348d: Revert "Unaligned Access Warning Added" (authored by lenary).
Revert "Unaligned Access Warning Added"
Jan 7 2022, 5:09 AM
lenary added a comment to D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added.

This caused some driver test failures. They have been fixed in https://reviews.llvm.org/rG11c67e5a4e99f51ec66c9781710f81955cfd5e24

Jan 7 2022, 2:50 AM · Restricted Project, Restricted Project
lenary committed rG11c67e5a4e99: [clang][driver] Don't pass -Wunaligned-access to cc1as (authored by lenary).
[clang][driver] Don't pass -Wunaligned-access to cc1as
Jan 7 2022, 2:46 AM

Jan 6 2022

lenary committed rG37e6e022d21f: Re-land "[Clang][ScanDeps] Use the virtual path for module maps" (authored by Bigcheese).
Re-land "[Clang][ScanDeps] Use the virtual path for module maps"
Jan 6 2022, 1:06 PM
lenary closed D114206: [Clang][ScanDeps] Use the virtual path for module maps.
Jan 6 2022, 1:06 PM · Restricted Project
lenary accepted D114206: [Clang][ScanDeps] Use the virtual path for module maps.

@Bigcheese I am sorry - after a lot of further investigation, it was due to an odd interaction with some downstream changes. I will re-land your changes, with correct attribution to you.

Jan 6 2022, 9:56 AM · Restricted Project
lenary accepted D116748: [AArch64][ARM][Clang] PerfMon Extension Added.

I'm happy with this patch, but you could update the description to be clearer that you're adding an option to allow PMU v3.4 to be enabled/disabled separately to the architecture - not adding the pmu extension itself.

Jan 6 2022, 8:12 AM · Restricted Project, Restricted Project

Jan 5 2022

lenary added a comment to D114206: [Clang][ScanDeps] Use the virtual path for module maps.

Update: I'm going to revert this on main. This patch was accepted conditionally on you fixing the windows crash, which you have not done, so this was landed without being accepted.

Revert is here: https://reviews.llvm.org/rGea835171389a

When you re-land this, don't forget to include the changes from D116611, please.

There is no crash on Windows with this patch. The issue is if you pass main.m instead of DIR/main.m. The commit that landed had both fixes I mentioned. Did you try this on Windows or look at the bots? In the future please be more careful.

Jan 5 2022, 4:48 AM · Restricted Project
lenary requested changes to D114206: [Clang][ScanDeps] Use the virtual path for module maps.
Jan 5 2022, 4:18 AM · Restricted Project
lenary reopened D114206: [Clang][ScanDeps] Use the virtual path for module maps.

Update: I'm going to revert this on main. This patch was accepted conditionally on you fixing the windows crash, which you have not done, so this was landed without being accepted.

Jan 5 2022, 4:18 AM · Restricted Project
lenary committed rGea835171389a: Revert "[Clang][ScanDeps] Use the virtual path for module maps" (authored by lenary).
Revert "[Clang][ScanDeps] Use the virtual path for module maps"
Jan 5 2022, 4:17 AM
lenary added a comment to D114206: [Clang][ScanDeps] Use the virtual path for module maps.

@Bigcheese have you got a fix for the vfs issue with . and ..?

Jan 5 2022, 4:01 AM · Restricted Project
lenary committed rG015e08c6bada: [clang][scandeps] Update Module Cache Path in Test (authored by lenary).
[clang][scandeps] Update Module Cache Path in Test
Jan 5 2022, 2:43 AM
lenary closed D116611: [clang][scandeps] Update Module Cache Path in Test.
Jan 5 2022, 2:43 AM · Restricted Project

Jan 4 2022

lenary requested review of D116611: [clang][scandeps] Update Module Cache Path in Test.
Jan 4 2022, 11:22 AM · Restricted Project
lenary added inline comments to D114206: [Clang][ScanDeps] Use the virtual path for module maps.
Jan 4 2022, 11:07 AM · Restricted Project
lenary accepted D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added.

LGTM! Thanks for your hard work on this!

Jan 4 2022, 9:43 AM · Restricted Project, Restricted Project
lenary added a comment to D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added.

Two quick comments about when this is enabled, and then I'm happy!

Jan 4 2022, 6:51 AM · Restricted Project, Restricted Project
lenary accepted D116415: [Arm] Remove duplicate CPU tests.

There is also a duplicate line (lines 29 and 31) of // RUN: %clang -target arm -march=armv5 -mthumb -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V5-THUMB %s which I think can be removed when you land this.

Jan 4 2022, 5:25 AM · Restricted Project
lenary added a comment to D115994: [test-suite] Fix test for union initialization.

Ok, this has been held up for a while, and it's something that should have been quick.

Jan 4 2022, 4:18 AM
lenary added a reviewer for D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added: lenary.
Jan 4 2022, 4:03 AM · Restricted Project, Restricted Project
lenary resigned from D70401: [RISCV] Complete RV32E/ilp32e implementation.
Jan 4 2022, 3:14 AM · Restricted Project, Restricted Project, Restricted Project

Dec 26 2021

lenary accepted D115994: [test-suite] Fix test for union initialization.

Cool. This is the right kind of fix (thanks for the comment!)

Dec 26 2021, 2:43 AM

Dec 24 2021

lenary requested changes to D115994: [test-suite] Fix test for union initialization.

This test was directly copied in from the gcc c torture suite and iirc we haven’t edited them on purpose.

Dec 24 2021, 1:23 AM

Dec 13 2021

lenary added a comment to D70401: [RISCV] Complete RV32E/ilp32e implementation.

Is it (D70401) good enough to solve or complete rv32e issue?

It need to

  1. disallow ilp32e ABI with D ISA extension. https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/3f81fae0412bb9ad4002a4ade508be7aa5e1599b/riscv-cc.adoc#ilp32e-calling-convention
  2. emit predefined marco in header (__riscv_e)
  3. markSuperRegs for X16-X31
  4. update tests after rebase on main.

Nice. If no body objects, @pcwang-thead will take this task and re-draft a review.

Dec 13 2021, 1:49 AM · Restricted Project, Restricted Project, Restricted Project

Dec 10 2021

lenary committed rG52faad83c9f8: [AArch64] Use Feature for A53 Erratum 835769 Fix (authored by lenary).
[AArch64] Use Feature for A53 Erratum 835769 Fix
Dec 10 2021, 7:11 AM
lenary closed D114703: [AArch64] Use Feature for A53 Erratum 835769 Fix.
Dec 10 2021, 7:11 AM · Restricted Project, Restricted Project
lenary abandoned D78910: [RISCV] RISCBoy Scheduling Model.
Dec 10 2021, 5:59 AM · Restricted Project