This is an archive of the discontinued LLVM Phabricator instance.

Remove redundant .c_str() and .get() calls
ClosedPublic

Authored by gAlfonso-bit on Dec 6 2022, 4:16 PM.

Diff Detail

Event Timeline

gAlfonso-bit created this revision.Dec 6 2022, 4:16 PM
Herald added a project: Restricted Project. · View Herald Transcript
gAlfonso-bit requested review of this revision.Dec 6 2022, 4:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 4:16 PM
MaskRay added inline comments.Dec 6 2022, 4:19 PM
llvm/include/llvm/ProfileData/InstrProfReader.h
703

delete parens. ditto below

gAlfonso-bit marked an inline comment as done.Dec 6 2022, 7:59 PM
gAlfonso-bit retitled this revision from Remove redundant .c_str() and .get() calls where they are not needed. to [LLVM] Remove redundant .c_str() and .get() calls where they are not needed..Dec 7 2022, 2:50 PM
MaskRay accepted this revision.Dec 7 2022, 4:10 PM
This revision is now accepted and ready to land.Dec 7 2022, 4:10 PM
This comment was removed by gAlfonso-bit.
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2022, 3:16 PM
shafik added a subscriber: shafik.Dec 12 2022, 10:23 AM
shafik added inline comments.
lldb/source/API/SBPlatform.cpp
14 ↗(On Diff #481954)

These redundant header removals looks unrelated and should be done as a separate NFC change.

MaskRay retitled this revision from [LLVM] Remove redundant .c_str() and .get() calls where they are not needed. to Remove redundant .c_str() and .get() calls.Dec 17 2022, 4:28 PM
This revision was landed with ongoing or failed builds.Dec 17 2022, 4:34 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2022, 4:34 PM