Page MenuHomePhabricator

kristof.beyls (Kristof Beyls)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2014, 12:59 AM (457 w, 4 d)

Recent Activity

Tue, Mar 7

kristof.beyls requested review of D145480: [docs] Also mention Discord on Contributing.rst page.
Tue, Mar 7, 1:59 AM · Restricted Project, Restricted Project

Mon, Mar 6

kristof.beyls added a comment to D145212: Only split cold blocks with more than a given number of instructions.

It seems to me that this patch would also need:

  • Some regression test to test it actually changes code generation (only?) when targeting Arm.
  • As is, this patch will not result in changed code generation IIUC?
Mon, Mar 6, 11:00 PM · Restricted Project, Restricted Project
kristof.beyls added a reviewer for D145212: Only split cold blocks with more than a given number of instructions: snehasish.

Adding Snehasish as a reviewer as git blame suggests snehasish has designed and written most of the MachineFunctionSplitter.

Mon, Mar 6, 10:56 PM · Restricted Project, Restricted Project
kristof.beyls committed rW3fe4900c22ff: EuroLLVM 2023: update submission deadline. (authored by kristof.beyls).
EuroLLVM 2023: update submission deadline.
Mon, Mar 6, 6:48 AM · Restricted Project
kristof.beyls committed rW6efb9b1e651f: EuroLLVM 2023: update a few more submission deadline occurrences. (authored by kristof.beyls).
EuroLLVM 2023: update a few more submission deadline occurrences.
Mon, Mar 6, 6:48 AM · Restricted Project

Feb 22 2023

kristof.beyls accepted D144585: [Nomination] Adding Nvidia Compiler security representative to the LLVM security group..
Feb 22 2023, 10:09 PM · Restricted Project, Restricted Project

Feb 14 2023

kristof.beyls accepted D143915: [llvm][AArch64] Fix an interaction of SLS and BTI after a returns twice call.

LGTM, thank you!

Feb 14 2023, 2:46 AM · Restricted Project, Restricted Project

Jan 20 2023

kristof.beyls committed rG355762145328: Add security group 2022 transparency report. (authored by kristof.beyls).
Add security group 2022 transparency report.
Jan 20 2023, 12:50 AM · Restricted Project, Restricted Project

Jan 17 2023

kristof.beyls accepted D129693: [ARM] Don't emit Arm speculation hardening thunks under Thumb and vice-versa.

LGTM, thank you!

Jan 17 2023, 5:46 AM · Restricted Project, Restricted Project

Jan 9 2023

kristof.beyls added a comment to D129693: [ARM] Don't emit Arm speculation hardening thunks under Thumb and vice-versa.

I just have a few more very minor nit-picky comments. Feel free to disagree with them.
I'm happy for this to go in.
I haven't looked in detail into the comments @DavidSpickett mad , so please also explicitly get his approval before committing.

Jan 9 2023, 5:58 AM · Restricted Project, Restricted Project

Dec 7 2022

kristof.beyls added a comment to D129693: [ARM] Don't emit Arm speculation hardening thunks under Thumb and vice-versa.

My apologies for missing this outstanding review for so long.

Dec 7 2022, 12:37 AM · Restricted Project, Restricted Project

Nov 29 2022

kristof.beyls accepted D138898: [Nomination] Adding Mozilla representative to security group.
Nov 29 2022, 12:59 AM · Restricted Project, Restricted Project

Nov 22 2022

kristof.beyls accepted D132384: [AArch64][PAC] Select MOVK for ptrauth.blend intrinsic..
Nov 22 2022, 6:30 AM · Restricted Project, Restricted Project

Oct 28 2022

kristof.beyls committed rGf4a338ebf815: Online sync-ups: remove Windows/COFF entry. (authored by kristof.beyls).
Online sync-ups: remove Windows/COFF entry.
Oct 28 2022, 5:48 AM · Restricted Project, Restricted Project
kristof.beyls closed D136876: Online sync-ups: remove Windows/COFF entry.
Oct 28 2022, 5:48 AM · Restricted Project, Restricted Project

Oct 27 2022

kristof.beyls committed rG739b0df399ff: Community calendar: more clearly document how to add events (authored by kristof.beyls).
Community calendar: more clearly document how to add events
Oct 27 2022, 12:15 PM · Restricted Project, Restricted Project
kristof.beyls requested review of D136876: Online sync-ups: remove Windows/COFF entry.
Oct 27 2022, 12:10 PM · Restricted Project, Restricted Project

Oct 19 2022

kristof.beyls accepted D136270: [docs] Add myself for LLVM Office hours.

Looks great. Thank you for becoming an office hours host!

Oct 19 2022, 10:48 AM · Restricted Project, Restricted Project

Oct 10 2022

kristof.beyls committed rGc3e073bcbdc5: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values (authored by adeelahmad81299).
Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values
Oct 10 2022, 1:35 AM · Restricted Project, Restricted Project
kristof.beyls closed D135431: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values.
Oct 10 2022, 1:35 AM · Restricted Project, Restricted Project

Oct 9 2022

kristof.beyls accepted D135431: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values.

I've reuploaded the changed diff. Can you see it now?

Oct 9 2022, 11:54 PM · Restricted Project, Restricted Project

Oct 7 2022

kristof.beyls added a comment to D135431: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values.

I have updated the file and have run 'arc diff' command.

Oct 7 2022, 5:14 AM · Restricted Project, Restricted Project
kristof.beyls added a comment to D135431: Extended Documentation of LLVM_TARGETS_TO_BUILD by listing all possible values.

I just have one minor suggestion.
Otherwise, LGTM.

Oct 7 2022, 1:54 AM · Restricted Project, Restricted Project

Oct 5 2022

kristof.beyls accepted D132383: [InstCombine] Combine ptrauth sign/resign + auth/resign intrinsics..

LGTM, thanks!

Oct 5 2022, 5:21 AM · Restricted Project, Restricted Project
kristof.beyls added a comment to D132386: [AArch64][PAC] Lower auth/resign into checked sequence..

I finally found time to go through the patch from beginning to end. I only have 2 more - hopefully minor questions.
Apart from that, LGTM.

Oct 5 2022, 5:09 AM · Restricted Project, Restricted Project

Sep 29 2022

kristof.beyls added inline comments to D134740: Document use of Co-author-by git tag..
Sep 29 2022, 10:44 PM · Restricted Project, Restricted Project
kristof.beyls committed rGcdf03f763484: Fix spelling in Co-authored-by documentation (authored by kristof.beyls).
Fix spelling in Co-authored-by documentation
Sep 29 2022, 10:44 PM · Restricted Project, Restricted Project

Sep 28 2022

kristof.beyls committed rG4f4c44c580f0: Document use of Co-author-by git tag. (authored by kristof.beyls).
Document use of Co-author-by git tag.
Sep 28 2022, 3:00 AM · Restricted Project, Restricted Project
kristof.beyls closed D134740: Document use of Co-author-by git tag..
Sep 28 2022, 3:00 AM · Restricted Project, Restricted Project
kristof.beyls added inline comments to D134740: Document use of Co-author-by git tag..
Sep 28 2022, 2:56 AM · Restricted Project, Restricted Project

Sep 27 2022

kristof.beyls requested review of D134740: Document use of Co-author-by git tag..
Sep 27 2022, 7:45 AM · Restricted Project, Restricted Project

Sep 21 2022

kristof.beyls committed rWd7c6ddbe61a0: Add link to LLVM Community Calendar in left side-bar. (authored by kristof.beyls).
Add link to LLVM Community Calendar in left side-bar.
Sep 21 2022, 12:10 AM · Restricted Project
kristof.beyls closed D128963: Add link to LLVM Community Calendar in left side-bar..
Sep 21 2022, 12:10 AM · Restricted Project

Sep 15 2022

kristof.beyls committed rW944d6806f238: Copy LICENSE.txt from source repo. (authored by kristof.beyls).
Copy LICENSE.txt from source repo.
Sep 15 2022, 9:22 AM · Restricted Project

Sep 13 2022

kristof.beyls accepted D133766: [LLVM][AArch64] Don't warn about clobbering X16 when Speculative Load Hardening is used.
Sep 13 2022, 8:55 AM · Restricted Project, Restricted Project
kristof.beyls added a comment to D133766: [LLVM][AArch64] Don't warn about clobbering X16 when Speculative Load Hardening is used.

I seem to remember that the speculative_load_hardening for AArch64 has a work-around when a user does reserve register X16 in inline assembly, see comment at https://github.com/llvm/llvm-project/blob/b7dae832e61da1f8b48cce1715514cbd5809eb3f/llvm/lib/Target/AArch64/AArch64SpeculationHardening.cpp#L35.
Given that comment and the tests in https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AArch64/speculation-hardening-dagisel.ll that check that behaviour, the warning/error implemented in this patch is not correct?

Sep 13 2022, 5:37 AM · Restricted Project, Restricted Project

Aug 31 2022

kristof.beyls added a comment to D132384: [AArch64][PAC] Select MOVK for ptrauth.blend intrinsic..

I had just 2 more minor nitpicks - mostly about adding 2 more regression tests to test/document expected behavior in corner cases.

Aug 31 2022, 3:03 AM · Restricted Project, Restricted Project
kristof.beyls accepted D132385: [AArch64][PAC] Select XPAC for ptrauth.strip intrinsic..

LGTM!
I just added a few minor nitpicks - I'll leave it to you to decide if following those suggestions would result in an improvement or not.

Aug 31 2022, 2:36 AM · Restricted Project, Restricted Project

Aug 24 2022

kristof.beyls added inline comments to D132385: [AArch64][PAC] Select XPAC for ptrauth.strip intrinsic..
Aug 24 2022, 8:53 AM · Restricted Project, Restricted Project
kristof.beyls added inline comments to D132386: [AArch64][PAC] Lower auth/resign into checked sequence..
Aug 24 2022, 8:19 AM · Restricted Project, Restricted Project
kristof.beyls added inline comments to D132386: [AArch64][PAC] Lower auth/resign into checked sequence..
Aug 24 2022, 5:43 AM · Restricted Project, Restricted Project
kristof.beyls added a comment to D132531: [AArch64] Reserve more physical registers.

See https://reviews.llvm.org/D56305 and https://reviews.llvm.org/D48580 for previous related discussions.
I think it would be helpful to understand the use case for being able to reserve x8, x16, x17 and x19 better.

Aug 24 2022, 1:19 AM · Restricted Project, Restricted Project, Restricted Project
kristof.beyls added a reviewer for D132531: [AArch64] Reserve more physical registers: efriedma.
Aug 24 2022, 1:15 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2022

kristof.beyls added a comment to D132531: [AArch64] Reserve more physical registers.

My understanding is that X8, X16, X17 and X19 cannot be reserved because the code generator in places will make use of them.
For example, using X19 as a base register in some cases. X16 and X17 are defined by the ABI to potentially be clobbered on function calls & when a veneer needs to be inserted by a linker, it does get clobbered. IIRC, some of the security mitigations implemented in LLVM also clobber these 2 registers on function calls.
I'm not fully sure why X8 cannot be reserved.

Aug 23 2022, 11:38 PM · Restricted Project, Restricted Project, Restricted Project
kristof.beyls added inline comments to D132384: [AArch64][PAC] Select MOVK for ptrauth.blend intrinsic..
Aug 23 2022, 8:46 AM · Restricted Project, Restricted Project

Aug 19 2022

kristof.beyls committed rG3d2ea3c77f8a: Add guidance for what to put in community calendar invites (authored by kristof.beyls).
Add guidance for what to put in community calendar invites
Aug 19 2022, 5:12 AM · Restricted Project, Restricted Project
kristof.beyls closed D132134: Add guidance for what to put in community calendar invites.
Aug 19 2022, 5:12 AM · Restricted Project, Restricted Project

Aug 18 2022

kristof.beyls added a comment to D132018: [docs] Add LICENSE.txt to the root of the mono-repo.

How about a list of subdirectories with different licenses in the end of the top level LICENSE file? Then there is no need to keep the text in sync but only add / remove to the list in the end of the file when we add or remove a third-party dependency, which should be pretty infrequent.

Aug 18 2022, 6:38 AM · Restricted Project, Restricted Project
kristof.beyls requested review of D132134: Add guidance for what to put in community calendar invites.
Aug 18 2022, 6:25 AM · Restricted Project, Restricted Project

Aug 17 2022

kristof.beyls added a comment to D132018: [docs] Add LICENSE.txt to the root of the mono-repo.

This is a great idea, thank you for doing this. I think we should also point out the sublicenses that are not llvm licensed, e.g. we have a copy of PCRE, googletest etc, and should notify people about these things.

Agreed. We need to make sure that all licenses (ie MIT License as well) are accounted for here otherwise it makes things confusing if someone assumes everything is under only this license.

Otherwise I like this idea. I'm slightly concerned about it getting out of date if we add any other code with some new license.

Aug 17 2022, 12:28 PM · Restricted Project, Restricted Project
kristof.beyls accepted D132018: [docs] Add LICENSE.txt to the root of the mono-repo.

As this is something I suggested - this LGTM.

Aug 17 2022, 2:35 AM · Restricted Project, Restricted Project

Aug 10 2022

kristof.beyls added a comment to D128963: Add link to LLVM Community Calendar in left side-bar..

gentle ping.

Aug 10 2022, 3:25 AM · Restricted Project

Jun 30 2022

kristof.beyls requested review of D128963: Add link to LLVM Community Calendar in left side-bar..
Jun 30 2022, 10:51 PM · Restricted Project

Jun 23 2022

kristof.beyls committed rG91139cee1512: [docs] Document and publish LLVM community calendar (authored by kristof.beyls).
[docs] Document and publish LLVM community calendar
Jun 23 2022, 4:30 AM · Restricted Project, Restricted Project
kristof.beyls closed D127852: [docs] Document and publish LLVM community calendar.
Jun 23 2022, 4:30 AM · Restricted Project, Restricted Project

Jun 20 2022

kristof.beyls added a comment to D127852: [docs] Document and publish LLVM community calendar.

This can be another patch, but I would like to add a point of contact to all sync-ups for CoC purposes. This should also be included in the calendar notes. I'm happy to create the patch though.

Jun 20 2022, 4:59 AM · Restricted Project, Restricted Project
kristof.beyls added a comment to D127852: [docs] Document and publish LLVM community calendar.

This is awesome and a huge win!

Can you also make a PR to the llvm-www repo to get this posted on the main llvm.org page?

Jun 20 2022, 4:56 AM · Restricted Project, Restricted Project
kristof.beyls committed rG6cb076783e1e: [docs] More clearly document that the CoC applies to online sync-ups and office… (authored by kristof.beyls).
[docs] More clearly document that the CoC applies to online sync-ups and office…
Jun 20 2022, 4:50 AM · Restricted Project, Restricted Project
kristof.beyls closed D126954: More clearly document that the CoC applies to online sync-ups and office hours..
Jun 20 2022, 4:49 AM · Restricted Project, Restricted Project

Jun 15 2022

kristof.beyls added a comment to D127852: [docs] Document and publish LLVM community calendar.

is a screenshot of what the "LLVM community calendar" section looks like after rendering.

Jun 15 2022, 6:27 AM · Restricted Project, Restricted Project
kristof.beyls requested review of D127852: [docs] Document and publish LLVM community calendar.
Jun 15 2022, 6:22 AM · Restricted Project, Restricted Project

Jun 3 2022

kristof.beyls requested review of D126954: More clearly document that the CoC applies to online sync-ups and office hours..
Jun 3 2022, 2:43 AM · Restricted Project, Restricted Project
kristof.beyls committed rG8b18572ea7ca: [docs] Fix RST code-block syntax in HowToSetUpLLVMStyleRTTI.rst (authored by kristof.beyls).
[docs] Fix RST code-block syntax in HowToSetUpLLVMStyleRTTI.rst
Jun 3 2022, 2:26 AM · Restricted Project, Restricted Project

May 24 2022

kristof.beyls committed rG8d2918750684: Minutes for security group sync-ups have moved to Discourse. (authored by kristof.beyls).
Minutes for security group sync-ups have moved to Discourse.
May 24 2022, 4:46 AM · Restricted Project, Restricted Project

May 23 2022

kristof.beyls added a comment to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

See https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html, documentation for "mharden-sls": For AArch64, the options available on the command line are "retbr", "blr", "none" and "all".
I don't think the options necessarily have to be the same for x86.
But assuming I understand this patch correctly, it seems to me that with this patch -mharden-sls=all would mean fundamentally slightly different things for x86 vs arm and aarch64, which could be confusing to users.
IIUC this patch correctly, this patch implements the equivalent of aarch64/arm's -mharden-sls=retbr (i.e. add a straight-line-speculation mitigation for returns and indirect jumps, but not for indirect function calls).
Therefore, I wonder if it wouldn't be better to name this -mharden-sls=retbr for more consistency across architectures?
Or is the indirect function call case not relevant for x86 (sorry - I'm not up to speed on the details on the x86 side)?

May 23 2022, 1:24 AM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

kristof.beyls committed rG52f2d057235f: Minutes for pauth sync-ups have moved to Discourse. (authored by kristof.beyls).
Minutes for pauth sync-ups have moved to Discourse.
May 20 2022, 5:01 AM · Restricted Project, Restricted Project

May 19 2022

kristof.beyls closed D125963: [Office Hours] add initial guidance for hosts.

committed as https://github.com/llvm/llvm-project/commit/ac2f0a6f1d4b3f5ff61dac33d9aba395d79b6a3d

May 19 2022, 11:42 AM · Restricted Project, Restricted Project
kristof.beyls added inline comments to D125963: [Office Hours] add initial guidance for hosts.
May 19 2022, 11:40 AM · Restricted Project, Restricted Project
kristof.beyls committed rGac2f0a6f1d4b: [Office Hours] add initial guidance for hosts (authored by kristof.beyls).
[Office Hours] add initial guidance for hosts
May 19 2022, 11:40 AM · Restricted Project, Restricted Project
kristof.beyls updated the diff for D125963: [Office Hours] add initial guidance for hosts.

updated guidance based on Aaron's feedback.

May 19 2022, 7:39 AM · Restricted Project, Restricted Project
kristof.beyls added inline comments to D125963: [Office Hours] add initial guidance for hosts.
May 19 2022, 7:18 AM · Restricted Project, Restricted Project
kristof.beyls updated the diff for D125963: [Office Hours] add initial guidance for hosts.

Use correct syntax to indicate we're adding a subsubsection, not a section, see https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections

May 19 2022, 3:47 AM · Restricted Project, Restricted Project
kristof.beyls requested review of D125963: [Office Hours] add initial guidance for hosts.
May 19 2022, 3:45 AM · Restricted Project, Restricted Project

May 18 2022

kristof.beyls committed rGfdd019530680: [Security Group] Update representative for Rust. (authored by pietroalbini).
[Security Group] Update representative for Rust.
May 18 2022, 5:21 AM · Restricted Project, Restricted Project
kristof.beyls closed D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.
May 18 2022, 5:21 AM · Restricted Project, Restricted Project

May 13 2022

kristof.beyls committed rGe1a8d05dd27b: Update my office hours (authored by kristof.beyls).
Update my office hours
May 13 2022, 7:30 AM · Restricted Project, Restricted Project

May 3 2022

kristof.beyls added inline comments to D124836: [AArch64] Add support for -fzero-call-used-regs.
May 3 2022, 2:59 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

kristof.beyls accepted D117111: [AArch64] Add native CPU detection for Ampere1.

LGTM

Apr 28 2022, 2:11 AM · Restricted Project, Restricted Project

Mar 24 2022

kristof.beyls committed rG51d9aaf4e58e: Update my office hours (authored by kristof.beyls).
Update my office hours
Mar 24 2022, 1:57 AM · Restricted Project

Feb 21 2022

kristof.beyls committed rG7a837d38bdff: Create office hours documentation. (authored by kristof.beyls).
Create office hours documentation.
Feb 21 2022, 11:21 AM
kristof.beyls closed D120036: Create office hours documentation..
Feb 21 2022, 11:21 AM · Restricted Project

Feb 17 2022

kristof.beyls requested review of D120036: Create office hours documentation..
Feb 17 2022, 3:50 AM · Restricted Project

Feb 16 2022

kristof.beyls committed rG520a9252723b: Fix 2 RestructuredText warnings. (authored by kristof.beyls).
Fix 2 RestructuredText warnings.
Feb 16 2022, 5:17 AM

Feb 13 2022

kristof.beyls accepted D119659: [llvm][doc] Add Aarch64 to list of architectures supporting statepoints.

LGTM, thank you!

Feb 13 2022, 11:32 AM · Restricted Project

Feb 8 2022

kristof.beyls accepted D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.
Feb 8 2022, 12:02 AM · Restricted Project, Restricted Project

Feb 7 2022

kristof.beyls committed rGc127ba25fb8e: Add LLVM Embedded Toolchains call to the table of sync ups. (authored by voltur01).
Add LLVM Embedded Toolchains call to the table of sync ups.
Feb 7 2022, 7:39 AM
kristof.beyls closed D118884: Add LLVM Embedded Toolchains call to the table of sync ups.
Feb 7 2022, 7:39 AM · Restricted Project
kristof.beyls accepted D118884: Add LLVM Embedded Toolchains call to the table of sync ups.

LGTM, thank you @voltur01 !

Feb 7 2022, 3:32 AM · Restricted Project

Jan 21 2022

kristof.beyls committed rG4d82ae67b208: Add security group 2021 transparency report. (authored by kristof.beyls).
Add security group 2021 transparency report.
Jan 21 2022, 6:44 AM
kristof.beyls closed D117872: Add security group 2021 transparency report..
Jan 21 2022, 6:44 AM · Restricted Project
kristof.beyls requested review of D117872: Add security group 2021 transparency report..
Jan 21 2022, 4:12 AM · Restricted Project

Jan 13 2022

kristof.beyls added a comment to D117111: [AArch64] Add native CPU detection for Ampere1.

I'm afraid I don't know if it's possible to check anywhere in public documentation that the values 0xc0 and 0xac3 are correct.
I'm assuming you verified those are the correct.
The code looks good, apart from one place where clang-format suggests different indentation.
With that indentation adapted, this looks good to me.

Jan 13 2022, 6:02 AM · Restricted Project, Restricted Project

Jan 12 2022

kristof.beyls committed rGc8c3021e9fe6: Update Pietro Albini's employer (authored by pietroalbini).
Update Pietro Albini's employer
Jan 12 2022, 5:46 AM
kristof.beyls closed D117027: Update Pietro Albini's employer.
Jan 12 2022, 5:46 AM · Restricted Project

Jan 11 2022

kristof.beyls accepted D117027: Update Pietro Albini's employer.

LGTM, thank you!

Jan 11 2022, 7:59 AM · Restricted Project

Dec 20 2021

kristof.beyls added a comment to D114412: github: Add action for automated issue notification.

I think this would be useful to have, as writing fine-grained filter rules is not necessarily easy or even doable in some mail clients, such as gmail.
With that in mind, I wonder if this action (which if I understand correctly will add a comment mentioning "@issue-subscribers-label"), results in the corresponding notification email adding "issue-subscribes-label@noreply.github.com"? I hope it does as that probably would make it easier to write email filters.

Dec 20 2021, 11:53 PM · Restricted Project

Dec 16 2021

kristof.beyls committed rW522c3f1eaa1c: Add link to "getting involved" on home page where we talk about getting… (authored by kristof.beyls).
Add link to "getting involved" on home page where we talk about getting…
Dec 16 2021, 2:07 AM

Dec 14 2021

kristof.beyls accepted D115657: [Nomination] Adding Intel representatives to security group.
Dec 14 2021, 11:37 AM · Restricted Project

Nov 19 2021

kristof.beyls added a comment to D113685: [IR] Define "ptrauth" operand bundle..

I just have 2 bike-sheddy comments on the documentation text.
My comments should not let you delay in getting this committed if they do not make sense to you.

Nov 19 2021, 6:00 AM · Restricted Project
kristof.beyls added inline comments to D114236: [libc] Fix 64-bit ARM support and header includes.
Nov 19 2021, 5:33 AM · Restricted Project