Page MenuHomePhabricator

kristof.beyls (Kristof Beyls)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2014, 12:59 AM (414 w, 3 d)

Recent Activity

Tue, May 24

kristof.beyls committed rG8d2918750684: Minutes for security group sync-ups have moved to Discourse. (authored by kristof.beyls).
Minutes for security group sync-ups have moved to Discourse.
Tue, May 24, 4:46 AM · Restricted Project, Restricted Project

Mon, May 23

kristof.beyls added a comment to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

See https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html, documentation for "mharden-sls": For AArch64, the options available on the command line are "retbr", "blr", "none" and "all".
I don't think the options necessarily have to be the same for x86.
But assuming I understand this patch correctly, it seems to me that with this patch -mharden-sls=all would mean fundamentally slightly different things for x86 vs arm and aarch64, which could be confusing to users.
IIUC this patch correctly, this patch implements the equivalent of aarch64/arm's -mharden-sls=retbr (i.e. add a straight-line-speculation mitigation for returns and indirect jumps, but not for indirect function calls).
Therefore, I wonder if it wouldn't be better to name this -mharden-sls=retbr for more consistency across architectures?
Or is the indirect function call case not relevant for x86 (sorry - I'm not up to speed on the details on the x86 side)?

Mon, May 23, 1:24 AM · Restricted Project, Restricted Project, Restricted Project

Fri, May 20

kristof.beyls committed rG52f2d057235f: Minutes for pauth sync-ups have moved to Discourse. (authored by kristof.beyls).
Minutes for pauth sync-ups have moved to Discourse.
Fri, May 20, 5:01 AM · Restricted Project, Restricted Project

Thu, May 19

kristof.beyls closed D125963: [Office Hours] add initial guidance for hosts.

committed as https://github.com/llvm/llvm-project/commit/ac2f0a6f1d4b3f5ff61dac33d9aba395d79b6a3d

Thu, May 19, 11:42 AM · Restricted Project, Restricted Project
kristof.beyls added inline comments to D125963: [Office Hours] add initial guidance for hosts.
Thu, May 19, 11:40 AM · Restricted Project, Restricted Project
kristof.beyls committed rGac2f0a6f1d4b: [Office Hours] add initial guidance for hosts (authored by kristof.beyls).
[Office Hours] add initial guidance for hosts
Thu, May 19, 11:40 AM · Restricted Project, Restricted Project
kristof.beyls updated the diff for D125963: [Office Hours] add initial guidance for hosts.

updated guidance based on Aaron's feedback.

Thu, May 19, 7:39 AM · Restricted Project, Restricted Project
kristof.beyls added inline comments to D125963: [Office Hours] add initial guidance for hosts.
Thu, May 19, 7:18 AM · Restricted Project, Restricted Project
kristof.beyls updated the diff for D125963: [Office Hours] add initial guidance for hosts.

Use correct syntax to indicate we're adding a subsubsection, not a section, see https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections

Thu, May 19, 3:47 AM · Restricted Project, Restricted Project
kristof.beyls requested review of D125963: [Office Hours] add initial guidance for hosts.
Thu, May 19, 3:45 AM · Restricted Project, Restricted Project

Wed, May 18

kristof.beyls committed rGfdd019530680: [Security Group] Update representative for Rust. (authored by pietroalbini).
[Security Group] Update representative for Rust.
Wed, May 18, 5:21 AM · Restricted Project, Restricted Project
kristof.beyls closed D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.
Wed, May 18, 5:21 AM · Restricted Project, Restricted Project

Fri, May 13

kristof.beyls committed rGe1a8d05dd27b: Update my office hours (authored by kristof.beyls).
Update my office hours
Fri, May 13, 7:30 AM · Restricted Project, Restricted Project

Tue, May 3

kristof.beyls added inline comments to D124836: [AArch64] Add support for -fzero-call-used-regs.
Tue, May 3, 2:59 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

kristof.beyls accepted D117111: [AArch64] Add native CPU detection for Ampere1.

LGTM

Apr 28 2022, 2:11 AM · Restricted Project, Restricted Project

Mar 24 2022

kristof.beyls committed rG51d9aaf4e58e: Update my office hours (authored by kristof.beyls).
Update my office hours
Mar 24 2022, 1:57 AM · Restricted Project

Feb 21 2022

kristof.beyls committed rG7a837d38bdff: Create office hours documentation. (authored by kristof.beyls).
Create office hours documentation.
Feb 21 2022, 11:21 AM
kristof.beyls closed D120036: Create office hours documentation..
Feb 21 2022, 11:21 AM · Restricted Project

Feb 17 2022

kristof.beyls requested review of D120036: Create office hours documentation..
Feb 17 2022, 3:50 AM · Restricted Project

Feb 16 2022

kristof.beyls committed rG520a9252723b: Fix 2 RestructuredText warnings. (authored by kristof.beyls).
Fix 2 RestructuredText warnings.
Feb 16 2022, 5:17 AM

Feb 13 2022

kristof.beyls accepted D119659: [llvm][doc] Add Aarch64 to list of architectures supporting statepoints.

LGTM, thank you!

Feb 13 2022, 11:32 AM · Restricted Project

Feb 8 2022

kristof.beyls accepted D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.
Feb 8 2022, 12:02 AM · Restricted Project, Restricted Project

Feb 7 2022

kristof.beyls committed rGc127ba25fb8e: Add LLVM Embedded Toolchains call to the table of sync ups. (authored by voltur01).
Add LLVM Embedded Toolchains call to the table of sync ups.
Feb 7 2022, 7:39 AM
kristof.beyls closed D118884: Add LLVM Embedded Toolchains call to the table of sync ups.
Feb 7 2022, 7:39 AM · Restricted Project
kristof.beyls accepted D118884: Add LLVM Embedded Toolchains call to the table of sync ups.

LGTM, thank you @voltur01 !

Feb 7 2022, 3:32 AM · Restricted Project

Jan 21 2022

kristof.beyls committed rG4d82ae67b208: Add security group 2021 transparency report. (authored by kristof.beyls).
Add security group 2021 transparency report.
Jan 21 2022, 6:44 AM
kristof.beyls closed D117872: Add security group 2021 transparency report..
Jan 21 2022, 6:44 AM · Restricted Project
kristof.beyls requested review of D117872: Add security group 2021 transparency report..
Jan 21 2022, 4:12 AM · Restricted Project

Jan 13 2022

kristof.beyls added a comment to D117111: [AArch64] Add native CPU detection for Ampere1.

I'm afraid I don't know if it's possible to check anywhere in public documentation that the values 0xc0 and 0xac3 are correct.
I'm assuming you verified those are the correct.
The code looks good, apart from one place where clang-format suggests different indentation.
With that indentation adapted, this looks good to me.

Jan 13 2022, 6:02 AM · Restricted Project, Restricted Project

Jan 12 2022

kristof.beyls committed rGc8c3021e9fe6: Update Pietro Albini's employer (authored by pietroalbini).
Update Pietro Albini's employer
Jan 12 2022, 5:46 AM
kristof.beyls closed D117027: Update Pietro Albini's employer.
Jan 12 2022, 5:46 AM · Restricted Project

Jan 11 2022

kristof.beyls accepted D117027: Update Pietro Albini's employer.

LGTM, thank you!

Jan 11 2022, 7:59 AM · Restricted Project

Dec 20 2021

kristof.beyls added a comment to D114412: github: Add action for automated issue notification.

I think this would be useful to have, as writing fine-grained filter rules is not necessarily easy or even doable in some mail clients, such as gmail.
With that in mind, I wonder if this action (which if I understand correctly will add a comment mentioning "@issue-subscribers-label"), results in the corresponding notification email adding "issue-subscribes-label@noreply.github.com"? I hope it does as that probably would make it easier to write email filters.

Dec 20 2021, 11:53 PM · Restricted Project

Dec 16 2021

kristof.beyls committed rW522c3f1eaa1c: Add link to "getting involved" on home page where we talk about getting… (authored by kristof.beyls).
Add link to "getting involved" on home page where we talk about getting…
Dec 16 2021, 2:07 AM

Dec 14 2021

kristof.beyls accepted D115657: [Nomination] Adding Intel representatives to security group.
Dec 14 2021, 11:37 AM · Restricted Project

Nov 19 2021

kristof.beyls added a comment to D113685: [IR] Define "ptrauth" operand bundle..

I just have 2 bike-sheddy comments on the documentation text.
My comments should not let you delay in getting this committed if they do not make sense to you.

Nov 19 2021, 6:00 AM · Restricted Project
kristof.beyls added inline comments to D114236: [libc] Fix 64-bit ARM support and header includes.
Nov 19 2021, 5:33 AM · Restricted Project

Nov 16 2021

kristof.beyls accepted D113942: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py.

LGTM, thanks.

Nov 16 2021, 12:40 AM · Restricted Project

Nov 15 2021

kristof.beyls accepted D113918: [llvm][fix] Inclusive language: replace master with main in find_interesting_reviews.py.

LGTM - thanks for fixing this!

Nov 15 2021, 11:15 AM · Restricted Project

Nov 10 2021

kristof.beyls added inline comments to D112941: [clang] Add support for the new pointer authentication builtins..
Nov 10 2021, 12:28 AM · Restricted Project
kristof.beyls accepted D113427: docs: Clarify licensing rules for the project.
Nov 10 2021, 12:03 AM · Restricted Project

Nov 8 2021

kristof.beyls added inline comments to D112941: [clang] Add support for the new pointer authentication builtins..
Nov 8 2021, 1:20 AM · Restricted Project

Nov 5 2021

kristof.beyls added inline comments to D112941: [clang] Add support for the new pointer authentication builtins..
Nov 5 2021, 3:07 AM · Restricted Project

Nov 3 2021

kristof.beyls accepted D112993: Don't emit "deprecated instruction in IT block" warning if requested.

GNU binutils has a specific option to silence the warnings about deprecated IT blocks (-m{no-}warn-restrict-it), see https://sourceware.org/legacy-ml/binutils/2019-12/msg00093.html.
I haven't looked up if GNU tools have the equivalent of -no-deprecated-warn.

Nov 3 2021, 1:55 AM · Restricted Project

Oct 22 2021

kristof.beyls committed rG49e1753c5ef9: Mark baremetal.cpp test as unsupported on Windows. (authored by kristof.beyls).
Mark baremetal.cpp test as unsupported on Windows.
Oct 22 2021, 3:50 AM
kristof.beyls committed rGe5b87fb7222c: Fix baremetal.cpp test to handle windows paths. (authored by kristof.beyls).
Fix baremetal.cpp test to handle windows paths.
Oct 22 2021, 2:29 AM
kristof.beyls committed rG3b93dc6880f7: Add basic aarch64-none-elf bare metal driver. (authored by kristof.beyls).
Add basic aarch64-none-elf bare metal driver.
Oct 22 2021, 12:15 AM
kristof.beyls closed D111134: Add basic aarch64-none-elf bare metal driver..
Oct 22 2021, 12:15 AM · Restricted Project

Oct 15 2021

kristof.beyls added a comment to D111134: Add basic aarch64-none-elf bare metal driver..

@MaskRay - gentle ping: I wonder if you have any further remarks after I updated the patch based on your earlier feedback?

Oct 15 2021, 1:52 AM · Restricted Project

Oct 14 2021

kristof.beyls added inline comments to D111723: first draft of a written policy around git repos.
Oct 14 2021, 12:53 AM · Restricted Project

Oct 7 2021

kristof.beyls updated the diff for D111134: Add basic aarch64-none-elf bare metal driver..

run clang-format on the patch.

Oct 7 2021, 6:04 AM · Restricted Project
kristof.beyls added inline comments to D111134: Add basic aarch64-none-elf bare metal driver..
Oct 7 2021, 5:59 AM · Restricted Project
kristof.beyls updated the diff for D111134: Add basic aarch64-none-elf bare metal driver..

Updated test based on feedback from @MaskRay

Oct 7 2021, 5:59 AM · Restricted Project

Oct 5 2021

kristof.beyls requested review of D111134: Add basic aarch64-none-elf bare metal driver..
Oct 5 2021, 5:05 AM · Restricted Project
kristof.beyls accepted D111074: [ARM] Reset speculation-hardening-sls.ll test checks..

LGTM, thank you for fixing this!

Oct 5 2021, 1:44 AM · Restricted Project

Oct 4 2021

kristof.beyls accepted D111056: [AArch64] Make speculation-hardening-sls.ll x16 test more robust.

LGTM, thanks!

Oct 4 2021, 7:54 AM · Restricted Project
kristof.beyls added a comment to D110830: [AArch64] Make -mcpu=generic schedule for an in-order core.

On a side note, it looks like llvm/test/CodeGen/ARM/speculation-hardening-sls.ll doesn't contain many of the check lines I would expect any more, after e497b12a69604b6d691312a30f6b86da4f18f7f8. Is that expected, or should I make a patch to undo that?

Oct 4 2021, 7:53 AM · Restricted Project
kristof.beyls added a comment to D110830: [AArch64] Make -mcpu=generic schedule for an in-order core.

For speculation-hardening-sls.ll: the approach taken in the ARM backend version of the similar test is probably a lot more robust, and I'd guess that if the test was adapted to follow the approach there ( see https://github.com/llvm/llvm-project/blob/566690b067c8175314fa657b899c99bccf96821c/llvm/test/CodeGen/ARM/speculation-hardening-sls.ll#L343), the compiler would still use the x16 register.

Oct 4 2021, 4:00 AM · Restricted Project

Sep 3 2021

kristof.beyls added a comment to D109041: [ARM] Fix assembly in `tInt_eh_sjlj_longjmp`.

I'm afraid that I'm not fully up to speed on the code changes here.
That being said, I hope it's useful to point out that I expect that in the not-too-distant future the recent specification of r11 being the frame pointer for both Arm and Thumb to be implemented in LLVM. See https://github.com/ARM-software/abi-aa/blob/main/aapcs32/aapcs32.rst (search for "frame pointer") to see the specification. A frame pointer was only recently added to the ABI specification. Before there was no definition of frame pointer for 32-bit ARM in the ABI specification.

Sep 3 2021, 6:22 AM · Restricted Project
kristof.beyls added a reviewer for D69056: [LNT] Remove Python2 support: tnfchris.
Sep 3 2021, 2:58 AM · Restricted Project

Aug 30 2021

kristof.beyls added a comment to D108679: Restrict ARM IT Blocks on Windows.

The performance deprecation of certain forms of IT blocks has been reverted.
The performance deprecation notes are being removed from the Arm ARM.
I am expecting that in the near future, code generation for Arm will be adapted to not enable -mrestrict-it by default at all, following what was already done in gcc at https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg00134.html.

As such, I'm not sure if this patch is a good thing to implement.
Maybe the guidelines in Microsoft's document you point to (https://docs.microsoft.com/en-us/cpp/build/overview-of-arm-abi-conventions?view=msvc-160#it-instructions) should be adapted to take into account the above described changes to the ArmARM?

@kristof.beyls Can you please point me to any official documentation or announcement from ARM about this (I've tried looking myself but couldn't see anything)?
I'd be happy to abandon this change and get the Microsoft docs updated if these instructions are no longer deprecated.

Aug 30 2021, 8:31 AM · Restricted Project

Aug 25 2021

kristof.beyls added a comment to D108679: Restrict ARM IT Blocks on Windows.

The performance deprecation of certain forms of IT blocks has been reverted.
The performance deprecation notes are being removed from the Arm ARM.
I am expecting that in the near future, code generation for Arm will be adapted to not enable -mrestrict-it by default at all, following what was already done in gcc at https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg00134.html.

Aug 25 2021, 2:32 AM · Restricted Project

Aug 19 2021

kristof.beyls committed rW35d643bf085c: [www] Remove foundation directory. (authored by kristof.beyls).
[www] Remove foundation directory.
Aug 19 2021, 1:16 AM

Aug 18 2021

kristof.beyls committed rG8ea60cf1ded2: Adding an Nvidia representative to security group (authored by nikhgupt).
Adding an Nvidia representative to security group
Aug 18 2021, 3:09 AM
kristof.beyls closed D106906: [Nomination] Adding an Nvidia representative to security group.
Aug 18 2021, 3:09 AM · Restricted Project

Aug 12 2021

kristof.beyls committed rW97bf69deb319: XMOS has signed the relicensing agreement. (authored by kristof.beyls).
XMOS has signed the relicensing agreement.
Aug 12 2021, 3:30 AM

Aug 9 2021

kristof.beyls accepted D106906: [Nomination] Adding an Nvidia representative to security group.

How many more approvals are needed for this to be final? According to D99232, it looks like eight?

Aug 9 2021, 5:21 AM · Restricted Project
kristof.beyls accepted D106964: [Security] Replace a Sony member.
Aug 9 2021, 5:07 AM · Restricted Project

Jun 17 2021

kristof.beyls committed rG6f0e74cd583b: Avoid unnecessary AArch64 DSB in __clear_cache in some situations. (authored by kristof.beyls).
Avoid unnecessary AArch64 DSB in __clear_cache in some situations.
Jun 17 2021, 12:10 AM
kristof.beyls closed D104371: [compiler-rt] Avoid unnecessary AArch64 DSB in __clear_cache in some situations..
Jun 17 2021, 12:10 AM · Restricted Project

Jun 16 2021

kristof.beyls updated subscribers of D104371: [compiler-rt] Avoid unnecessary AArch64 DSB in __clear_cache in some situations..
Jun 16 2021, 5:23 AM · Restricted Project
kristof.beyls requested review of D104371: [compiler-rt] Avoid unnecessary AArch64 DSB in __clear_cache in some situations..
Jun 16 2021, 5:22 AM · Restricted Project

Jun 15 2021

kristof.beyls added a comment to D104094: Add missing AArch64 data synchronization barrier (dsb) to __clear_cache.

Do we still need the DSB on line 119?

Jun 15 2021, 5:21 AM · Restricted Project

Jun 11 2021

kristof.beyls accepted D104094: Add missing AArch64 data synchronization barrier (dsb) to __clear_cache.

Thank you Stephen; LGTM!

Jun 11 2021, 12:53 AM · Restricted Project

Jun 1 2021

kristof.beyls added a comment to D103080: [CMake] Ignore arm_*.h for non-ARM build.

Hi @kristof.beyls The original lib/clang/12.0.1/include is about total ~10M, and the arm*.h take about ~5M. Ignore these unused header files will save the developers who work on the low storage device.

Jun 1 2021, 8:10 AM · Restricted Project

May 31 2021

kristof.beyls added a comment to D103080: [CMake] Ignore arm_*.h for non-ARM build.

I'm wondering what the rationale for this change is.
If there is a good rationale for this; wouldn't it need to be applied to all target-specific header files, not only the Arm-specific header files?

May 31 2021, 8:04 AM · Restricted Project

May 19 2021

kristof.beyls accepted D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.

LGTM.

May 19 2021, 9:41 AM · Restricted Project, Restricted Project

May 18 2021

kristof.beyls accepted D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.

Thanks @danielkiss !
I only have a few nit picky remarks.
Overall looks good!

May 18 2021, 7:48 AM · Restricted Project, Restricted Project

May 11 2021

kristof.beyls added inline comments to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
May 11 2021, 5:57 AM · Restricted Project, Restricted Project

May 7 2021

kristof.beyls accepted D100873: [docs] Describe reporting security issues on the chromium tracker..

LGTM, thank you Ahmed!

May 7 2021, 5:38 AM · Restricted Project

Apr 21 2021

kristof.beyls accepted D100864: Replace Apple representative to security group..
Apr 21 2021, 1:09 AM · Restricted Project
kristof.beyls added a comment to D100873: [docs] Describe reporting security issues on the chromium tracker..

Thanks for this Ahmed!
This mostly looks good to me, I just have a few nit-comments inline.

Apr 21 2021, 12:54 AM · Restricted Project
kristof.beyls added inline comments to D100919: [AArch64] Support customizing stack protector guard.
Apr 21 2021, 12:39 AM · Restricted Project, Restricted Project

Apr 16 2021

kristof.beyls committed rGa7bbd670aa1c: [docs] Add Pointer Authentication call info (authored by kristof.beyls).
[docs] Add Pointer Authentication call info
Apr 16 2021, 6:19 AM

Apr 15 2021

kristof.beyls added a comment to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.

Apart from maybe needing to run clang-format on the patch, the code changes look good to me.
Before this could be committed, this needs tests.

Apr 15 2021, 4:48 AM · Restricted Project, Restricted Project

Apr 12 2021

kristof.beyls committed rG28dc50c4b75e: [docs] Add Windows/COFF call info (authored by kristof.beyls).
[docs] Add Windows/COFF call info
Apr 12 2021, 8:11 AM

Mar 25 2021

kristof.beyls accepted D99232: [Nomination] Adding new Google representative to security group.
Mar 25 2021, 1:36 AM · Restricted Project

Mar 24 2021

kristof.beyls added a comment to D99232: [Nomination] Adding new Google representative to security group.

I approve. Thanks George!

Mar 24 2021, 8:57 AM · Restricted Project

Mar 22 2021

kristof.beyls committed rGba0a28596e22: [docs] GettingInvolved: split out flang and openmp meeting series (authored by kristof.beyls).
[docs] GettingInvolved: split out flang and openmp meeting series
Mar 22 2021, 1:27 AM
kristof.beyls closed D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Mar 22 2021, 1:27 AM · Restricted Project

Mar 20 2021

kristof.beyls added inline comments to D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Mar 20 2021, 3:23 AM · Restricted Project
kristof.beyls updated the diff for D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Mar 20 2021, 3:21 AM · Restricted Project
kristof.beyls requested review of D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Mar 20 2021, 1:17 AM · Restricted Project

Mar 19 2021

kristof.beyls committed rG1d7cf550721c: [docs] Add calendar info for SVE sync-ups (authored by kristof.beyls).
[docs] Add calendar info for SVE sync-ups
Mar 19 2021, 2:29 AM

Mar 18 2021

kristof.beyls added a comment to D98797: [docs] Document regular LLVM sync-ups.

This is fantastic! I'd recommend mentioning this on llvm-dev / and to Alex @ llvm-weekly when it goes up.

Mar 18 2021, 10:35 AM · Restricted Project
kristof.beyls committed rG64bb3759dda5: [docs] Document regular LLVM sync-ups (authored by kristof.beyls).
[docs] Document regular LLVM sync-ups
Mar 18 2021, 10:33 AM
kristof.beyls closed D98797: [docs] Document regular LLVM sync-ups.
Mar 18 2021, 10:33 AM · Restricted Project
kristof.beyls updated the diff for D98797: [docs] Document regular LLVM sync-ups.

Addressing feedback + also adding a pointer to the various flang and openmp regular sync-ups.

Mar 18 2021, 9:21 AM · Restricted Project
kristof.beyls updated the diff for D98797: [docs] Document regular LLVM sync-ups.

Make capitalization consistent

Mar 18 2021, 4:01 AM · Restricted Project

Mar 17 2021

kristof.beyls updated the diff for D98797: [docs] Document regular LLVM sync-ups.

Thanks Chris.
Now updated following all of your suggestions.

Mar 17 2021, 11:27 PM · Restricted Project