Page MenuHomePhabricator

kristof.beyls (Kristof Beyls)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2014, 12:59 AM (355 w, 5 d)

Recent Activity

Thu, Mar 25

kristof.beyls accepted D99232: [Nomination] Adding new Google representative to security group.
Thu, Mar 25, 1:36 AM · Restricted Project

Wed, Mar 24

kristof.beyls added a comment to D99232: [Nomination] Adding new Google representative to security group.

I approve. Thanks George!

Wed, Mar 24, 8:57 AM · Restricted Project

Mon, Mar 22

kristof.beyls committed rGba0a28596e22: [docs] GettingInvolved: split out flang and openmp meeting series (authored by kristof.beyls).
[docs] GettingInvolved: split out flang and openmp meeting series
Mon, Mar 22, 1:27 AM
kristof.beyls closed D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Mon, Mar 22, 1:27 AM · Restricted Project

Sat, Mar 20

kristof.beyls added inline comments to D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Sat, Mar 20, 3:23 AM · Restricted Project
kristof.beyls updated the diff for D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Sat, Mar 20, 3:21 AM · Restricted Project
kristof.beyls requested review of D99012: [docs] GettingInvolved: split out flang and openmp meeting series.
Sat, Mar 20, 1:17 AM · Restricted Project

Fri, Mar 19

kristof.beyls committed rG1d7cf550721c: [docs] Add calendar info for SVE sync-ups (authored by kristof.beyls).
[docs] Add calendar info for SVE sync-ups
Fri, Mar 19, 2:29 AM

Thu, Mar 18

kristof.beyls added a comment to D98797: [docs] Document regular LLVM sync-ups.

This is fantastic! I'd recommend mentioning this on llvm-dev / and to Alex @ llvm-weekly when it goes up.

Thu, Mar 18, 10:35 AM · Restricted Project
kristof.beyls committed rG64bb3759dda5: [docs] Document regular LLVM sync-ups (authored by kristof.beyls).
[docs] Document regular LLVM sync-ups
Thu, Mar 18, 10:33 AM
kristof.beyls closed D98797: [docs] Document regular LLVM sync-ups.
Thu, Mar 18, 10:33 AM · Restricted Project
kristof.beyls updated the diff for D98797: [docs] Document regular LLVM sync-ups.

Addressing feedback + also adding a pointer to the various flang and openmp regular sync-ups.

Thu, Mar 18, 9:21 AM · Restricted Project
kristof.beyls updated the diff for D98797: [docs] Document regular LLVM sync-ups.

Make capitalization consistent

Thu, Mar 18, 4:01 AM · Restricted Project

Wed, Mar 17

kristof.beyls updated the diff for D98797: [docs] Document regular LLVM sync-ups.

Thanks Chris.
Now updated following all of your suggestions.

Wed, Mar 17, 11:27 PM · Restricted Project
kristof.beyls accepted D93347: [Test] Fix undef var in attr-speculative-load-hardening.c.

LGTM, thanks!

Wed, Mar 17, 10:57 AM · Restricted Project
kristof.beyls added a comment to D98797: [docs] Document regular LLVM sync-ups.

The rendered patch looks like this:

Wed, Mar 17, 10:55 AM · Restricted Project
kristof.beyls requested review of D98797: [docs] Document regular LLVM sync-ups.
Wed, Mar 17, 10:53 AM · Restricted Project

Tue, Mar 16

kristof.beyls added a comment to D96004: [AArch64] Stack probing for function prologues.

Thanks for this patch Oliver!
I've started reviewing, but am not very far yet.
I thought I'd share my thoughts so far already, as I'm not sure exactly when I'll be able to do a complete review.

Tue, Mar 16, 3:08 AM · Restricted Project

Mar 12 2021

kristof.beyls accepted D98277: [release][docs] List all cores Arm has added support for in LLVM 12..

Still LGTM

Mar 12 2021, 12:45 PM · Restricted Project
kristof.beyls accepted D98277: [release][docs] List all cores Arm has added support for in LLVM 12..

LGTM, thanks!

Mar 12 2021, 8:05 AM · Restricted Project

Mar 9 2021

kristof.beyls added a comment to D90868: [IR] Define @llvm.ptrauth intrinsics..

Before we get too far into editorial review, I think we should step back and ask what actually needs to be in this document. In particular, I'm not sure that the discussion of how pointer authentication can be used in an ABI is really appropriate for LLVM-level documentation. We should discuss the formal model we want the intrinsics/constant to provide — secret key registers, well-formed pointers, arbitrary discriminators — and just link to other documentation (e.g. the much longer white paper in the clang docs) for the benefit of people who are curious about how this can be used.

Mar 9 2021, 7:58 AM · Restricted Project
kristof.beyls added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 9 2021, 7:31 AM · Restricted Project

Mar 8 2021

kristof.beyls added inline comments to D90868: [IR] Define @llvm.ptrauth intrinsics..
Mar 8 2021, 2:47 AM · Restricted Project

Feb 12 2021

kristof.beyls committed rGf816cf6a4747: [DeveloperPolicy] Specify LLVM's license more clearly. (authored by kristof.beyls).
[DeveloperPolicy] Specify LLVM's license more clearly.
Feb 12 2021, 1:17 AM
kristof.beyls closed D96482: [DeveloperPolicy] Specify LLVM's license more clearly..
Feb 12 2021, 1:17 AM · Restricted Project

Feb 11 2021

kristof.beyls added a comment to D96164: [lld-macho] add code signature for native arm64 macOS.
In D96164#2547858, @gkm wrote:

df>>! In D96164#2547480, @smeenai wrote:

LLVM tries to not depend on external libraries if possible. Given that sha256 isn't that much code (https://golang.org/src/crypto/sha256/), just adding a fresh implementation of it (to lld/MachO for now) is probably the way to go.

Agreed. There's some prior art here too ... LLVM has a SHA1 implementation in llvm/include/llvm/Support/SHA1.h and llvm/lib/Support/SHA1.cpp. That was adapted from an existing public-domain implementation, and we could do the same here (find a SHA256 implementation with a license that allows it to copied into LLVM).

Openssl has a C implementation of sha256 with Apache 2.0 license. Unless someone knows of a better candidate, I'll go with that.

Feb 11 2021, 3:22 AM · Restricted Project, Restricted Project
kristof.beyls added a comment to D96482: [DeveloperPolicy] Specify LLVM's license more clearly..

If you would extend the paragraph, you could say:
"For reference the SPDX identifier is ..."

Feb 11 2021, 3:09 AM · Restricted Project
kristof.beyls requested review of D96482: [DeveloperPolicy] Specify LLVM's license more clearly..
Feb 11 2021, 2:58 AM · Restricted Project

Jan 26 2021

kristof.beyls accepted D95429: Deprecate build cache servers for aarch64 and aarch32 from Buildbot.

LGTM, thanks!

Jan 26 2021, 2:26 AM

Jan 20 2021

kristof.beyls added a comment to D95044: IR+AArch64: add `swiftasync` function parameter attribute.

Just a few quick, knee-jerk-style, questions. My apologies if these are too simplistic or vague.

  • Do you happen to have a pointer to some more documentation about this new Swift feature?
  • I wonder if any features from other languages could also map to this IR/backend implementation? E.g. I haven't looked at how C++ co-routines are implemented, but would they be able to reuse this feature (assuming they would need a somewhat similar feature in mid- and back-end).
  • As this seems to be introducing new ABI - do you have an idea of what the most appropriate ABI specification is this would be best documented in? Do I guess correctly that this is not a Darwin-only feature? If this is really swift-specific (i.e. it does not seem to be a good trade-off to have this mid/back-end feature support similar language features for multiple front-ends), I guess this is Swift-specific ABI. Do I guess correctly that there isn't really a specification for Swift-specific ABI - it's purely defined by its primary implementation?
  • I just had one very detailed nit-pick comment on the documentation of frame layout - see specific comment.
Jan 20 2021, 8:15 AM · Restricted Project
kristof.beyls accepted D94143: [AArch64] Add support for the GNU ILP32 ABI.
Jan 20 2021, 2:16 AM · Restricted Project

Jan 15 2021

kristof.beyls added a comment to D94143: [AArch64] Add support for the GNU ILP32 ABI.

My understanding is that AArch64 gnu_ilp32 support is present in mainline gcc, but not in mainline glibc nor in the mainline linux kernel. My understanding is also that it's unlikely that AArch64 gnu_ilp32 support will be added to mainline glibc or linux kernel anytime soon.
That makes me wonder how useful it is to support AArch64 gnu_ilp32 in mainline LLVM. It seems unlikely that it can be used for linux targets anytime soon. Are there non-linux targets using AArch64 gnu_ilp32?

Jan 15 2021, 5:45 AM · Restricted Project

Dec 19 2020

kristof.beyls committed rG9c895aea118a: [ARM] Add clang command line support for -mharden-sls= (authored by kristof.beyls).
[ARM] Add clang command line support for -mharden-sls=
Dec 19 2020, 4:55 AM
kristof.beyls closed D93221: [ARM] Add clang command line support for -mharden-sls=.
Dec 19 2020, 4:54 AM · Restricted Project
kristof.beyls committed rGdf8ed3928377: [ARM] harden-sls-blr: avoid r12 and lr in indirect calls. (authored by kristof.beyls).
[ARM] harden-sls-blr: avoid r12 and lr in indirect calls.
Dec 19 2020, 4:48 AM
kristof.beyls closed D92469: [ARM] harden-sls-blr: avoid r12 and lr in indirect calls.
Dec 19 2020, 4:48 AM · Restricted Project
kristof.beyls committed rGa4c1f5160e6d: [ARM] Harden indirect calls against SLS (authored by kristof.beyls).
[ARM] Harden indirect calls against SLS
Dec 19 2020, 4:39 AM
kristof.beyls closed D92468: [ARM] Harden indirect calls against SLS.
Dec 19 2020, 4:39 AM · Restricted Project
kristof.beyls committed rG320fd3314e37: [ARM] Implement harden-sls-retbr for Thumb mode (authored by kristof.beyls).
[ARM] Implement harden-sls-retbr for Thumb mode
Dec 19 2020, 4:33 AM
kristof.beyls closed D92396: [ARM] Implement harden-sls-retbr for Thumb mode.
Dec 19 2020, 4:33 AM · Restricted Project
kristof.beyls committed rG195f44278c43: [ARM] Implement harden-sls-retbr for ARM mode (authored by kristof.beyls).
[ARM] Implement harden-sls-retbr for ARM mode
Dec 19 2020, 4:26 AM
kristof.beyls closed D92395: [ARM] Implement harden-sls-retbr for ARM mode.
Dec 19 2020, 4:25 AM · Restricted Project

Dec 18 2020

kristof.beyls added a comment to D93221: [ARM] Add clang command line support for -mharden-sls=.

Why is this restricted to v7-A or later? The DSB and ISB instructions have existed since v6T2 and v6M.

Dec 18 2020, 6:11 AM · Restricted Project
kristof.beyls added inline comments to D92469: [ARM] harden-sls-blr: avoid r12 and lr in indirect calls.
Dec 18 2020, 6:09 AM · Restricted Project
kristof.beyls updated the diff for D92469: [ARM] harden-sls-blr: avoid r12 and lr in indirect calls.

Updated patch based on review comments + rebased to ToT

Dec 18 2020, 6:06 AM · Restricted Project
kristof.beyls updated the diff for D92468: [ARM] Harden indirect calls against SLS.

Updated patch based on review comments + rebased to ToT

Dec 18 2020, 6:04 AM · Restricted Project
kristof.beyls added inline comments to D92395: [ARM] Implement harden-sls-retbr for ARM mode.
Dec 18 2020, 6:02 AM · Restricted Project
kristof.beyls updated the diff for D92395: [ARM] Implement harden-sls-retbr for ARM mode.

Updated patch based on review feedback.

Dec 18 2020, 6:00 AM · Restricted Project

Dec 15 2020

kristof.beyls accepted D92831: Update references to 'master' branch..

LGTM too, thanks!

Dec 15 2020, 8:07 AM · Restricted Project

Dec 14 2020

kristof.beyls requested review of D93221: [ARM] Add clang command line support for -mharden-sls=.
Dec 14 2020, 8:17 AM · Restricted Project

Dec 10 2020

kristof.beyls added inline comments to D92831: Update references to 'master' branch..
Dec 10 2020, 12:09 AM · Restricted Project

Dec 9 2020

kristof.beyls added a comment to D92831: Update references to 'master' branch..

Thanks for this.
The proposed changes all LGTM.
I did do a grep on the term 'master' in llvm/docs, and found quite a few more uses of 'master', especially in links.
The command I used was: grep -R master llvm/docs/
Just two examples are:

Dec 9 2020, 2:36 AM · Restricted Project

Dec 2 2020

kristof.beyls requested review of D92469: [ARM] harden-sls-blr: avoid r12 and lr in indirect calls.
Dec 2 2020, 1:56 AM · Restricted Project
kristof.beyls requested review of D92468: [ARM] Harden indirect calls against SLS.
Dec 2 2020, 1:55 AM · Restricted Project

Dec 1 2020

kristof.beyls requested review of D92396: [ARM] Implement harden-sls-retbr for Thumb mode.
Dec 1 2020, 8:21 AM · Restricted Project
kristof.beyls requested review of D92395: [ARM] Implement harden-sls-retbr for ARM mode.
Dec 1 2020, 8:17 AM · Restricted Project
kristof.beyls added a comment to D92328: collect_and_build_with_pgo.py: adapt to monorepo.

thanks for this!

i think the preferred way to PGO LLVM is cmake: https://llvm.org/docs/AdvancedBuilds.html

that said, while we have this script & the docs pointing to it, seems good to keep it up-to-date. LGTM

Dec 1 2020, 2:59 AM · Restricted Project
kristof.beyls committed rG424fdbc3deda: collect_and_build_with_pgo.py: adapt to monorepo (authored by kristof.beyls).
collect_and_build_with_pgo.py: adapt to monorepo
Dec 1 2020, 12:17 AM
kristof.beyls closed D92328: collect_and_build_with_pgo.py: adapt to monorepo.
Dec 1 2020, 12:17 AM · Restricted Project

Nov 30 2020

kristof.beyls requested review of D92328: collect_and_build_with_pgo.py: adapt to monorepo.
Nov 30 2020, 8:16 AM · Restricted Project

Nov 28 2020

kristof.beyls added inline comments to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.
Nov 28 2020, 11:36 PM · Restricted Project, Restricted Project

Oct 13 2020

kristof.beyls committed rG05ef552e5660: Add expected response time and escalation path to the security docs (authored by pietroalbini).
Add expected response time and escalation path to the security docs
Oct 13 2020, 1:57 AM
kristof.beyls closed D89068: Add expected response time and escalation path to the security docs.
Oct 13 2020, 1:57 AM · Restricted Project
kristof.beyls added a comment to D89068: Add expected response time and escalation path to the security docs.

This seems to be approved, what's the process of landing the commit? I don't have commit access to LLVM.

Oct 13 2020, 1:19 AM · Restricted Project

Oct 9 2020

kristof.beyls added a comment to D89068: Add expected response time and escalation path to the security docs.

Thanks for this @pietroalbini !
This LGTM.
I'd also like to hear @mattdr's or @jfb's opinion before committing though.

Oct 9 2020, 1:04 AM · Restricted Project

Jul 6 2020

kristof.beyls accepted D76291: [Support] Fix formatted_raw_ostream for UTF-8.

LGTM, thanks!

Jul 6 2020, 2:21 AM · Restricted Project, Restricted Project

Jun 22 2020

Herald added a project to D76291: [Support] Fix formatted_raw_ostream for UTF-8: Restricted Project.

This looks fine to me; I just have a number of nit picks.
The only part where I don't understand the code logic is around the comment starting with "If this is the final byte of a multi-byte sequence".

Jun 22 2020, 4:48 AM · Restricted Project, Restricted Project

Jun 19 2020

kristof.beyls added inline comments to D81404: [AArch64] Add clang command line support for -mharden-sls=.
Jun 19 2020, 2:07 AM · Restricted Project

Jun 18 2020

kristof.beyls committed rGc113b59ef525: [AArch64] Add clang command line support for -mharden-sls= (authored by kristof.beyls).
[AArch64] Add clang command line support for -mharden-sls=
Jun 18 2020, 11:58 PM
kristof.beyls closed D81404: [AArch64] Add clang command line support for -mharden-sls=.
Jun 18 2020, 11:57 PM · Restricted Project
kristof.beyls committed rGd938ec4509c4: [AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen. (authored by kristof.beyls).
[AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen.
Jun 18 2020, 10:52 PM
kristof.beyls closed D81405: [AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen..
Jun 18 2020, 10:52 PM · Restricted Project
kristof.beyls added inline comments to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 18 2020, 12:30 AM · Restricted Project

Jun 17 2020

kristof.beyls committed rG832cfc767246: [IndirectThunks] Make generated MF structure as expected by all instruction… (authored by kristof.beyls).
[IndirectThunks] Make generated MF structure as expected by all instruction…
Jun 17 2020, 11:12 PM
kristof.beyls committed rGf7455da2633d: [IndirectThunks] Tiny comment fix (authored by kristof.beyls).
[IndirectThunks] Tiny comment fix
Jun 17 2020, 11:11 PM
kristof.beyls closed D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 17 2020, 11:11 PM · Restricted Project
kristof.beyls committed rG3f0cc96a9694: [AArch64] SLSHardening: compute correct thunk name for X29. (authored by kristof.beyls).
[AArch64] SLSHardening: compute correct thunk name for X29.
Jun 17 2020, 10:39 PM
kristof.beyls closed D81997: [AArch64] SLSHardening: compute correct thunk name for X29..
Jun 17 2020, 10:39 PM · Restricted Project
kristof.beyls added a comment to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..

LGTM

Could you explain how not adding the MBB entry block is different from removing extra MBB later? Curious on the details about the differences here since the change makes sense functionally and I don't see any issues, but I can't understand why adding the extra MBB entry block at the point we create the machine function and then deleting extra blocks results in something different than the automatically created entry block. Is it some attributes or configuration in the basic block or something?

Jun 17 2020, 7:31 AM · Restricted Project
kristof.beyls added inline comments to D81997: [AArch64] SLSHardening: compute correct thunk name for X29..
Jun 17 2020, 6:58 AM · Restricted Project
kristof.beyls updated the diff for D81997: [AArch64] SLSHardening: compute correct thunk name for X29..

Updated version based on @ostannard feedback.

Jun 17 2020, 6:58 AM · Restricted Project
kristof.beyls created D81997: [AArch64] SLSHardening: compute correct thunk name for X29..
Jun 17 2020, 2:40 AM · Restricted Project

Jun 16 2020

kristof.beyls committed rG503a26d8e4d0: Silence GCC 7 warning (authored by kristof.beyls).
Silence GCC 7 warning
Jun 16 2020, 3:51 AM

Jun 11 2020

kristof.beyls committed rGc35ed40f4f1b: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions. (authored by kristof.beyls).
[AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions.
Jun 11 2020, 11:58 PM
kristof.beyls closed D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 11:57 PM · Restricted Project
kristof.beyls added inline comments to D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 11:57 PM · Restricted Project
kristof.beyls updated the diff for D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..

This new revision fixes the root cause of GlobalISel asserting on an IndirectThunk: the IndirectThunk creation code was producing a MachineFunction with a slightly different structure than what gets produced from a naked function implemented in C code and processed by clang.
This fixes this by letting the IndirectThunk generator produce a MachineFunction structure that is the same as what gets produced by clang for an empty naked function written in C.

Jun 11 2020, 12:07 PM · Restricted Project
kristof.beyls added inline comments to D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 7:09 AM · Restricted Project
kristof.beyls updated the diff for D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 11 2020, 7:08 AM · Restricted Project
kristof.beyls committed rG994748770c35: [NFC] Refactor ThunkInserter to make it available for all targets. (authored by kristof.beyls).
[NFC] Refactor ThunkInserter to make it available for all targets.
Jun 11 2020, 1:15 AM
kristof.beyls closed D81401: [NFC] Refactor ThunkInserter to make it available for all targets..
Jun 11 2020, 1:15 AM · Restricted Project
kristof.beyls committed rG0ee176edc8b4: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and… (authored by kristof.beyls).
[AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and…
Jun 11 2020, 12:01 AM
kristof.beyls closed D81400: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and BR instructions..
Jun 11 2020, 12:01 AM · Restricted Project

Jun 10 2020

kristof.beyls updated the diff for D81405: [AArch64] Avoid incompatibility between SLSBLR mitigation and BTI codegen..

Based on the review feedback that using X16 or X17 could be problematic since a linker can clobber those registers on a call, this patch goes for a different approach to achieve compatibility with BTI-enabled callees.
It simply moves the register to be called always to be in X16, and then does BR X16.
It seems it's simplest to do that unconditionally, as it may not always be easy to find out if the call target has been BTI-enabled.

Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls updated the diff for D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls added inline comments to D81403: [IndirectThunks] Make generated MF structure as expected by all instruction selectors..
Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls added inline comments to D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..
Jun 10 2020, 7:37 AM · Restricted Project
kristof.beyls updated the diff for D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions..

The updated patch addresses Oliver's review comments.
Especially, it addresses the review feedback regarding potential clobbering of X16 or X17 when the call to the thunks go through a long veneer.
It addresses this by avoiding generating indirect calls that use X16 or X17.

Jun 10 2020, 7:37 AM · Restricted Project

Jun 9 2020

kristof.beyls added a comment to D81400: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and BR instructions..

Thanks for the feedback!

Jun 9 2020, 9:19 AM · Restricted Project
kristof.beyls updated the diff for D81400: [AArch64] Introduce AArch64SLSHardeningPass, implementing hardening of RET and BR instructions..
Jun 9 2020, 9:19 AM · Restricted Project