Page MenuHomePhabricator

HsiangKai (Hsiangkai Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 4 2016, 7:01 PM (141 w, 6 d)

Recent Activity

Mon, Jan 21

HsiangKai added a comment to D45045: [DebugInfo] Generate debug information for labels..

D54199 and D54465 have been accepted and landed. I have tested the revision with LLVM test and Clang test. They are all passed. Chromium build is also successful in my local environment. I think it is ready to reland the revision.

Mon, Jan 21, 6:26 PM

Thu, Jan 17

HsiangKai committed rL351525: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
[CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated.
Thu, Jan 17, 11:22 PM
HsiangKai closed D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Thu, Jan 17, 11:22 PM · debug-info

Thu, Jan 10

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Thu, Jan 10, 2:50 PM · debug-info

Wed, Dec 26

HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

Ping.

Wed, Dec 26, 7:13 PM · debug-info

Dec 17 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Dec 17 2018, 7:01 PM · debug-info

Dec 16 2018

HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

Ping.

Dec 16 2018, 6:20 PM · debug-info

Dec 4 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Dec 4 2018, 5:15 AM · debug-info

Nov 30 2018

HsiangKai closed D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..

This revision is committed to master branch.
I forgot to add "Differential Revision" in commit message. So, this revision is not closed automatically.

Nov 30 2018, 12:18 AM
HsiangKai committed rL347964: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
[CodeGen] Fix bugs in BranchFolderPass when debug labels are generated.
Nov 30 2018, 12:11 AM
HsiangKai closed D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
Nov 30 2018, 12:11 AM
HsiangKai committed rL347963: [NFC] Refine doxygen format..
[NFC] Refine doxygen format.
Nov 30 2018, 12:10 AM
HsiangKai closed D54568: [NFC] Refine doxygen format..
Nov 30 2018, 12:10 AM

Nov 28 2018

HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

Ping.

Nov 28 2018, 7:23 PM · debug-info
HsiangKai added inline comments to D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
Nov 28 2018, 7:16 PM

Nov 18 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 18 2018, 6:13 PM · debug-info
HsiangKai updated the diff for D54568: [NFC] Refine doxygen format..
Nov 18 2018, 6:11 PM

Nov 15 2018

HsiangKai added a parent revision for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated.: D54568: [NFC] Refine doxygen format..
Nov 15 2018, 6:26 PM · debug-info
HsiangKai added a child revision for D54568: [NFC] Refine doxygen format.: D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 15 2018, 6:26 PM
HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

This patch doesn't seem to apply. Does it need regenerating?

vext01@bencher8:~/source/llvm$ patch -Ep0 <  D54465.diff
patching file lib/CodeGen/LiveDebugVariables.cpp
Hunk #2 FAILED at 340.
Hunk #3 succeeded at 352 with fuzz 1 (offset -5 lines).
Hunk #4 FAILED at 372.
Hunk #5 succeeded at 395 (offset -9 lines).
Hunk #6 succeeded at 441 (offset -9 lines).
Hunk #7 succeeded at 466 (offset -9 lines).
Hunk #8 succeeded at 487 (offset -9 lines).
Hunk #9 succeeded at 531 (offset -9 lines).
Hunk #10 succeeded at 615 (offset -9 lines).
Hunk #11 succeeded at 651 (offset -9 lines).
Hunk #12 succeeded at 1291 (offset -7 lines).
Hunk #13 succeeded at 1348 (offset -7 lines).
2 out of 13 hunks FAILED -- saving rejects to file lib/CodeGen/LiveDebugVariables.cpp.rej
The next patch would create the file test/CodeGen/Generic/live-debug-label.ll,
which already exists!  Assume -R? [n]
Nov 15 2018, 6:25 PM · debug-info
HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 15 2018, 5:20 PM · debug-info
HsiangKai added a comment to D45045: [DebugInfo] Generate debug information for labels..

Hello all,

This commit has been reverted by rC345026. It was reported that this broke the Chromium build (again). Have you had a look to fix this, @HsiangKai?

Nov 15 2018, 6:43 AM

Nov 14 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 14 2018, 11:38 PM · debug-info
HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 14 2018, 11:30 PM · debug-info
HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 14 2018, 11:20 PM · debug-info
HsiangKai added inline comments to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 14 2018, 10:18 PM · debug-info
HsiangKai updated the diff for D54568: [NFC] Refine doxygen format..
Nov 14 2018, 10:17 PM
HsiangKai created D54568: [NFC] Refine doxygen format..
Nov 14 2018, 10:10 PM

Nov 12 2018

HsiangKai created D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 12 2018, 11:22 PM · debug-info

Nov 7 2018

HsiangKai added a reviewer for D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated.: petarj.
Nov 7 2018, 11:07 PM
HsiangKai added inline comments to D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
Nov 7 2018, 10:42 PM

Nov 6 2018

HsiangKai created D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
Nov 6 2018, 11:54 PM

Oct 23 2018

HsiangKai committed rL345009: [DebugInfo] Generate debug information for labels. (After fix PR39094).
[DebugInfo] Generate debug information for labels. (After fix PR39094)
Oct 23 2018, 1:08 AM
HsiangKai committed rC345009: [DebugInfo] Generate debug information for labels. (After fix PR39094).
[DebugInfo] Generate debug information for labels. (After fix PR39094)
Oct 23 2018, 1:08 AM
HsiangKai closed D45045: [DebugInfo] Generate debug information for labels..
Oct 23 2018, 1:08 AM

Oct 22 2018

HsiangKai added a comment to D45045: [DebugInfo] Generate debug information for labels..
Oct 22 2018, 12:15 AM

Oct 19 2018

HsiangKai added a comment to D52927: [CodeGen] Fix for PR39094..

I am sorry that I misunderstood the meaning of the status. I thought that if the status is ‘ACCEPTED’, I could upstream the commit.

Oct 19 2018, 1:53 AM

Oct 18 2018

HsiangKai committed rL344770: [CodeGen] Fix for PR39094..
[CodeGen] Fix for PR39094.
Oct 18 2018, 6:54 PM
HsiangKai closed D52927: [CodeGen] Fix for PR39094..
Oct 18 2018, 6:54 PM

Oct 8 2018

HsiangKai added a comment to D52927: [CodeGen] Fix for PR39094..

The tools we have available for reducing large inputs are (multi-)delta (http://delta.tigris.org) and creduce (https://embed.cs.utah.edu/creduce/). Delta is a "dumb" implementation of the delta debugging algorithm (same one that is implemented in llvm-bugpoint) that is in my personal experience faster than creduce. I highly recommend spending a day to learn how to use delta; you will find yourself using it a lot :-)

Oct 8 2018, 10:02 PM
HsiangKai updated the diff for D52927: [CodeGen] Fix for PR39094..
Oct 8 2018, 1:18 AM
HsiangKai updated the diff for D52927: [CodeGen] Fix for PR39094..
Oct 8 2018, 12:53 AM
HsiangKai added a comment to D52927: [CodeGen] Fix for PR39094..

a testcase would be nice, but generally this looks fine.

Oct 8 2018, 12:47 AM

Oct 5 2018

HsiangKai updated the summary of D52927: [CodeGen] Fix for PR39094..
Oct 5 2018, 12:50 AM
HsiangKai added a comment to D45045: [DebugInfo] Generate debug information for labels..

Fix the bug in https://reviews.llvm.org/D52927.

Oct 5 2018, 12:42 AM
HsiangKai created D52927: [CodeGen] Fix for PR39094..
Oct 5 2018, 12:41 AM

Oct 4 2018

HsiangKai accepted D52901: [DebugInfo] Fix debug information label tests..
Oct 4 2018, 6:55 PM

Sep 26 2018

HsiangKai committed rL343148: [DebugInfo] Generate debug information for labels..
[DebugInfo] Generate debug information for labels.
Sep 26 2018, 3:20 PM
HsiangKai committed rC343148: [DebugInfo] Generate debug information for labels..
[DebugInfo] Generate debug information for labels.
Sep 26 2018, 3:20 PM

Sep 25 2018

HsiangKai committed rL343062: [DebugInfo] Do not generate address info for removed debug labels..
[DebugInfo] Do not generate address info for removed debug labels.
Sep 25 2018, 9:21 PM

Sep 24 2018

HsiangKai committed rL342943: [DebugInfo] Do not generate address info for removed debug labels..
[DebugInfo] Do not generate address info for removed debug labels.
Sep 24 2018, 11:14 PM
HsiangKai closed D51908: [DebugInfo] Do not generate address info for removed labels..
Sep 24 2018, 11:14 PM

Sep 19 2018

HsiangKai updated the diff for D51908: [DebugInfo] Do not generate address info for removed labels..
Sep 19 2018, 7:16 AM

Sep 18 2018

HsiangKai updated the diff for D51908: [DebugInfo] Do not generate address info for removed labels..

I think that all of us agreed that it is a bug in GDB to crash when setting breakpoints on labels without address information. So, I updated the patch to generate label debug information without address even when the labels are removed after optimizations.

Sep 18 2018, 6:43 AM
HsiangKai added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

I use the same test program to generate executable with gcc. The executable has DW_TAG_label without DW_AT_low_pc. However, it will not crash GDB. There should be other debug attributes that will affect the behavior as setting breakpoints on labels.

I will dig into the difference and report here if I found the root cause.

Sep 18 2018, 1:20 AM

Sep 17 2018

HsiangKai added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

I use the same test program to generate executable with gcc. The executable has DW_TAG_label without DW_AT_low_pc. However, it will not crash GDB. There should be other debug attributes that will affect the behavior as setting breakpoints on labels.

Sep 17 2018, 9:24 PM

Sep 13 2018

HsiangKai added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

Can you preserved the declaration DIE (at 0x0000007c) while omitting the definition DIE (at 0x00000063)? Does that still cause a problem for GDB?

Sep 13 2018, 12:59 AM
HsiangKai added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

If it has no DW_AT_low_pc in label debug info, GDB seems to assume it is 0x0.

(gdb) info scope foo
Scope for foo:
Symbol done is a label at address 0x400551, length 8.
Symbol unreach is a label at address 0x0, length 8.

llvm-dwarfdump results:

0x00000056:     DW_TAG_label
                  DW_AT_abstract_origin (0x00000075 "done")

Hmm - what's the test case you're using here? Is there inlining? What about in cases without inlining?

Sep 13 2018, 12:58 AM

Sep 11 2018

HsiangKai added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

If it has no DW_AT_low_pc in label debug info, GDB seems to assume it is 0x0.

Sep 11 2018, 11:15 PM

Sep 10 2018

HsiangKai added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

This patch is related to https://reviews.llvm.org/D50495#1225927.

Sep 10 2018, 9:06 PM
HsiangKai added a comment to D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..

Hmm, so thinking about it, since this is a clang change and the crash reproduces with llc, this is just generating code that triggers an existing LLVM bug.

I think we still need to revert it for now as it triggers a clang crash :-(

llc: /usr/local/google/home/sammccall/src/llvm/lib/MC/MCExpr.cpp:176: llvm::MCSymbolRefExpr::MCSymbolRefExpr(const llvm::MCSymbol *, llvm::MCSymbolRefExpr::VariantKind, const llvm::MCAsmInfo *, llvm::SMLoc): Assertion `Symbol' failed.
Stack dump:
0.	Program arguments: bin/llc bugpoint-reduced-named-md.bc -split-dwarf-file out.dwo 
#0 0x0000000003659b19 llvm::sys::PrintStackTrace(llvm::raw_ostream&) /usr/local/google/home/sammccall/src/llvm/lib/Support/Unix/Signals.inc:490:11
#1 0x0000000003659cc9 PrintStackTraceSignalHandler(void*) /usr/local/google/home/sammccall/src/llvm/lib/Support/Unix/Signals.inc:554:1
#2 0x0000000003657f26 llvm::sys::RunSignalHandlers() /usr/local/google/home/sammccall/src/llvm/lib/Support/Signals.cpp:66:5
#3 0x000000000365a2e7 SignalHandler(int) /usr/local/google/home/sammccall/src/llvm/lib/Support/Unix/Signals.inc:353:1
#4 0x00007f8f521d20c0 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x110c0)
#5 0x00007f8f50d63fcf gsignal (/lib/x86_64-linux-gnu/libc.so.6+0x32fcf)
#6 0x00007f8f50d653fa abort (/lib/x86_64-linux-gnu/libc.so.6+0x343fa)
#7 0x00007f8f50d5ce37 (/lib/x86_64-linux-gnu/libc.so.6+0x2be37)
#8 0x00007f8f50d5cee2 (/lib/x86_64-linux-gnu/libc.so.6+0x2bee2)
#9 0x0000000002e36e0f llvm::MCSymbolRefExpr::MCSymbolRefExpr(llvm::MCSymbol const*, llvm::MCSymbolRefExpr::VariantKind, llvm::MCAsmInfo const*, llvm::SMLoc) /usr/local/google/home/sammccall/src/llvm/lib/MC/MCExpr.cpp:177:1
#10 0x0000000002e36eb6 llvm::MCSymbolRefExpr::create(llvm::MCSymbol const*, llvm::MCSymbolRefExpr::VariantKind, llvm::MCContext&, llvm::SMLoc) /usr/local/google/home/sammccall/src/llvm/lib/MC/MCExpr.cpp:182:10
#11 0x0000000000c12368 llvm::MCSymbolRefExpr::create(llvm::MCSymbol const*, llvm::MCContext&) /usr/local/google/home/sammccall/src/llvm/include/llvm/MC/MCExpr.h:323:5
#12 0x00000000025e4262 llvm::AddressPool::emit(llvm::AsmPrinter&, llvm::MCSection*) /usr/local/google/home/sammccall/src/llvm/lib/CodeGen/AsmPrinter/AddressPool.cpp:60:15
#13 0x000000000250dfa9 llvm::DwarfDebug::emitDebugAddr() /usr/local/google/home/sammccall/src/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2380:1
#14 0x000000000250be72 llvm::DwarfDebug::endModule() /usr/local/google/home/sammccall/src/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:896:11
#15 0x00000000024dd8ee llvm::AsmPrinter::doFinalization(llvm::Module&) /usr/local/google/home/sammccall/src/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1450:12
#16 0x0000000002cf8bf4 llvm::FPPassManager::doFinalization(llvm::Module&) /usr/local/google/home/sammccall/src/llvm/lib/IR/LegacyPassManager.cpp:1596:16
#17 0x0000000002cf95e3 (anonymous namespace)::MPPassManager::runOnModule(llvm::Module&) /usr/local/google/home/sammccall/src/llvm/lib/IR/LegacyPassManager.cpp:1670:16
#18 0x0000000002cf8d9e llvm::legacy::PassManagerImpl::run(llvm::Module&) /usr/local/google/home/sammccall/src/llvm/lib/IR/LegacyPassManager.cpp:1754:16
#19 0x0000000002cf9891 llvm::legacy::PassManager::run(llvm::Module&) /usr/local/google/home/sammccall/src/llvm/lib/IR/LegacyPassManager.cpp:1785:3
#20 0x0000000000bd8a5c compileModule(char**, llvm::LLVMContext&) /usr/local/google/home/sammccall/src/llvm/tools/llc/llc.cpp:600:41
#21 0x0000000000bd695d main /usr/local/google/home/sammccall/src/llvm/tools/llc/llc.cpp:351:13
#22 0x00007f8f50d512b1 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202b1)
#23 0x0000000000bd603a _start (bin/llc+0xbd603a)
Sep 10 2018, 9:05 PM
HsiangKai created D51908: [DebugInfo] Do not generate address info for removed labels..
Sep 10 2018, 9:04 PM

Sep 5 2018

HsiangKai committed rC341519: [DebugInfo] Generate debug information for labels. (Fix PR37395).
[DebugInfo] Generate debug information for labels. (Fix PR37395)
Sep 5 2018, 11:07 PM
HsiangKai committed rL341519: [DebugInfo] Generate debug information for labels. (Fix PR37395).
[DebugInfo] Generate debug information for labels. (Fix PR37395)
Sep 5 2018, 11:07 PM
HsiangKai committed rL341513: [DebugInfo] Do not generate label debug info if it has been processed..
[DebugInfo] Do not generate label debug info if it has been processed.
Sep 5 2018, 7:25 PM

Sep 4 2018

HsiangKai committed rL341446: [DebugInfo] Fix bug in LiveDebugVariables..
[DebugInfo] Fix bug in LiveDebugVariables.
Sep 4 2018, 11:00 PM
HsiangKai added a comment to D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..

Is there anything I should address?

Sep 4 2018, 8:13 PM
HsiangKai added a comment to D50621: [DebugInfo] Fix bug in LiveDebugVariables..

@bjope: After I committed the patch to LLVM repo, it still failed in clang-ppc64be-linux-lnt buildbot.

I guess the test case should contain target triple to be filtered out by llvm-lit in other architectures.
Is it correct to add "target triple = 'x86_64-unknown-linux-gnu' " in the test case?

That buildbot is probably building the compiler with support for both ppc and x86, but with ppc as default target.
So the check in test/DebugInfo/X86/lit.local.cfg that X86 is a configured target will pass, i.e. the test case will be executed even when the default target isn't X86.

Without explicitly specifying the triple (either by a "target triple = ..." statement, or by using -mtriple in the RUN-line) the test case will be executed using the default target.

In this case it might be slightly easier to add -mtriple=x86_64-unknown-linux-gnu to the RUN-line. Adding target triple = 'x86_64-unknown-linux-gnu should work as well, but then you need to put in inside the module definition (after line 10).

Sep 4 2018, 7:52 PM
HsiangKai added a comment to D50621: [DebugInfo] Fix bug in LiveDebugVariables..

@bjope: After I committed the patch to LLVM repo, it still failed in clang-ppc64be-linux-lnt buildbot.

Sep 4 2018, 12:11 AM

Sep 2 2018

HsiangKai committed rL341290: Revert "[DebugInfo] Fix bug in LiveDebugVariables.".
Revert "[DebugInfo] Fix bug in LiveDebugVariables."
Sep 2 2018, 9:36 AM
HsiangKai committed rL341289: [DebugInfo] Fix bug in LiveDebugVariables..
[DebugInfo] Fix bug in LiveDebugVariables.
Sep 2 2018, 8:58 AM
HsiangKai closed D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Sep 2 2018, 8:58 AM

Aug 29 2018

HsiangKai updated the diff for D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Add -run-pass=virtregrewriter to the test case.

Aug 29 2018, 7:00 AM
HsiangKai added a comment to D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Thanks @bjope for providing a good test case for the patch.
It will trigger another assertion due to no emitDebugValues() after livedebugvars.
I found it depends on VirtRegRewriter. So, I will change -run-pass to -stop-after.
Besides this, the test case works after applying the patch.

Not sure I understand the above. My suggestion was to only run the livedebugvars pass (making the test case specific to that pass).
Now you changed the -run-pass to -stop-after, but in which pass does it start then? Don't you need a start-before/-start-after as well to indicate where to start?
AFAIK "-run-pass=livedebugvars" is the same as "-start-before=livedebugvars -stop-after=livedebugvars", so we do not run VirtRegRewriter when using a single -run-pass like that.

Note that a problem with running these register allocation passes standalone is that handwritten input could be abnormal. Lot's of DBG_VALUE instructions are normally removed before we get to livedebugvars, and then they are added back to the IR by VirtRegRewriter. And we do not include information about the cached DBG_VALUE instructions in the MIR-format.

So the test case I provided does not necessarily imitate a normal situation when we get to livedebugvars (I just made up something to trigger the problem). Perhaps DBG_VALUE instructions referring to physical registers are among the cached DBG_VALUE instructions that will be reinserted by virtregrewriter. Do you know what the DBG_VALUE instructions looked like in your original TR? Was it perhaps DBG_VALUE instructions where the first operand was a constant value, I think such DBG_VALUE instructions stay in the IR during register allocation.

I don't know if it really is important how we model the DBG_VALUE instructions here, as long as they expose the problem. It is of course better to have the test case as realistic as possible.

Aug 29 2018, 6:54 AM

Aug 28 2018

HsiangKai added a comment to D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..

@aprantl, do you agree my comments?

Aug 28 2018, 12:49 AM
HsiangKai updated the diff for D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Update the test case.
@bjope and @aprantl, please help me to review the patch. Thanks a lot.

Aug 28 2018, 12:27 AM
HsiangKai added a comment to D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Thanks @bjope for providing a good test case for the patch.
It will trigger another assertion due to no emitDebugValues() after livedebugvars.
I found it depends on VirtRegRewriter. So, I will change -run-pass to -stop-after.
Besides this, the test case works after applying the patch.

Aug 28 2018, 12:18 AM
HsiangKai reopened D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Test case needs to be reviewed.

Aug 28 2018, 12:08 AM

Aug 22 2018

HsiangKai committed rL340508: [DebugInfo] Fix bug in LiveDebugVariables..
[DebugInfo] Fix bug in LiveDebugVariables.
Aug 22 2018, 8:29 PM
HsiangKai closed D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Aug 22 2018, 8:29 PM

Aug 21 2018

HsiangKai updated the summary of D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Aug 21 2018, 1:27 AM
HsiangKai updated the diff for D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Aug 21 2018, 12:52 AM

Aug 20 2018

HsiangKai added inline comments to D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Aug 20 2018, 9:02 PM
HsiangKai updated the diff for D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Aug 20 2018, 8:58 PM

Aug 19 2018

HsiangKai added a comment to D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..

Any comments?

Aug 19 2018, 8:10 PM
HsiangKai updated the diff for D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Update test case.

Aug 19 2018, 8:04 PM

Aug 18 2018

HsiangKai committed rL340122: [DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI..
[DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI.
Aug 18 2018, 7:57 AM
HsiangKai closed D50622: [DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI..
Aug 18 2018, 7:56 AM

Aug 17 2018

HsiangKai committed rL340039: [DebugInfo] Generate DWARF debug information for labels. (Fix leak problems).
[DebugInfo] Generate DWARF debug information for labels. (Fix leak problems)
Aug 17 2018, 8:23 AM

Aug 16 2018

HsiangKai updated the diff for D50621: [DebugInfo] Fix bug in LiveDebugVariables..

Update according to comments.
Add test case.

Aug 16 2018, 8:25 PM

Aug 14 2018

HsiangKai committed rL339676: [DebugInfo] Generate DWARF debug information for labels. (Fix leak problems).
[DebugInfo] Generate DWARF debug information for labels. (Fix leak problems)
Aug 14 2018, 6:51 AM

Aug 13 2018

HsiangKai added a comment to D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..

Hi HsiangKai,

Thanks for looking into this.

I've applied this diff to my LLVM clone (again, just before you DILabel codegen stuff was reverted) and rebuilt, but I can still see 0x0 low_pcs in the resulting label.

$ ls -al `which clang`
lrwxrwxrwx 1 vext01 vext01 7 Aug  1 16:16 /home/vext01/research/llvm/inst.debug/bin/clang -> clang-7
$ ls -al `which clang-7`
-rwxr-xr-x 1 vext01 vext01 2102557136 Aug  9 10:54 /home/vext01/research/llvm/inst.debug/bin/clan
$ clang -O0 -g example.ll -o example.o
warning: overriding the module target triple with x86_64-unknown-linux-gnu [-Woverride-module]
1 warning generated.
$ dwarfdump example.o
...
< 2><0x00000041>      DW_TAG_label
                        DW_AT_name                  XXXYYYZZZ
                        DW_AT_decl_file             0x00000001 ./main.xxx
                        DW_AT_decl_line             0x00000001
                        DW_AT_low_pc                0x00000000
...

Do you have this change in a svn or git branch somewhere? There was some fuzz applying the diff, which might be the cause.

Aug 13 2018, 3:17 AM

Aug 12 2018

HsiangKai updated the diff for D50622: [DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI..
Aug 12 2018, 11:51 PM
HsiangKai created D50622: [DebugInfo] In FastISel, convert llvm.dbg.label to DBG_LABEL MI..
Aug 12 2018, 11:46 PM
HsiangKai updated the diff for D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Aug 12 2018, 11:44 PM
HsiangKai created D50621: [DebugInfo] Fix bug in LiveDebugVariables..
Aug 12 2018, 11:40 PM
HsiangKai added inline comments to D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..
Aug 12 2018, 10:51 PM

Aug 9 2018

HsiangKai added a comment to D45045: [DebugInfo] Generate debug information for labels..

It should be fixed in https://reviews.llvm.org/D50495.
Please help me to confirm it in your environment. Thanks so much. :)

Aug 9 2018, 2:00 AM
HsiangKai added a reviewer for D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed.: vext01.
Aug 9 2018, 1:55 AM
HsiangKai updated the diff for D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..
Aug 9 2018, 1:52 AM