Page MenuHomePhabricator

HsiangKai (Hsiangkai Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
May 4 2016, 7:01 PM (322 w, 11 h)

Recent Activity

May 2 2022

HsiangKai committed rG3baff8080447: [RISCV] Precommit test cases for (uaddo X, C) (authored by HsiangKai).
[RISCV] Precommit test cases for (uaddo X, C)
May 2 2022, 8:54 PM · Restricted Project, Restricted Project
HsiangKai committed rGeaaa31ff2c2b: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C). (authored by HsiangKai).
[RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C).
May 2 2022, 8:54 PM · Restricted Project, Restricted Project
HsiangKai closed D124602: [RISCV] Precommit test cases for (uaddo X, C).
May 2 2022, 8:53 PM · Restricted Project, Restricted Project
HsiangKai closed D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..
May 2 2022, 8:53 PM · Restricted Project, Restricted Project

Apr 28 2022

HsiangKai committed rGc62b014db979: [RISCV] Merge addi into load/store as there is a ADD between them (authored by HsiangKai).
[RISCV] Merge addi into load/store as there is a ADD between them
Apr 28 2022, 9:36 PM · Restricted Project, Restricted Project
HsiangKai closed D124231: [RISCV] Merge addi into load/store as there is a ADD between them.
Apr 28 2022, 9:36 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..

Address comments.

Apr 28 2022, 6:32 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D124231: [RISCV] Merge addi into load/store as there is a ADD between them.

Address comments.

Apr 28 2022, 4:25 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..

Revert the change and modify the comments only.

Apr 28 2022, 4:21 PM · Restricted Project, Restricted Project
HsiangKai added inline comments to D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..
Apr 28 2022, 3:03 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..

Add predicate for (uaddo X, C).

Apr 28 2022, 2:57 AM · Restricted Project, Restricted Project
HsiangKai requested review of D124602: [RISCV] Precommit test cases for (uaddo X, C).
Apr 28 2022, 2:55 AM · Restricted Project, Restricted Project
HsiangKai updated the diff for D124231: [RISCV] Merge addi into load/store as there is a ADD between them.

Take the return value of UpdateNodeOperands().

Apr 28 2022, 12:33 AM · Restricted Project, Restricted Project
HsiangKai added inline comments to D124231: [RISCV] Merge addi into load/store as there is a ADD between them.
Apr 28 2022, 12:23 AM · Restricted Project, Restricted Project

Apr 26 2022

HsiangKai updated the diff for D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..

Update failed PowerPC test cases.

Apr 26 2022, 12:06 AM · Restricted Project, Restricted Project

Apr 25 2022

HsiangKai updated the diff for D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..

Move new test cases to the end of the test file to remove unnecessary noises.

Apr 25 2022, 7:43 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..

Add test cases.

Apr 25 2022, 7:37 PM · Restricted Project, Restricted Project
HsiangKai requested review of D124374: [RISCV][TargetLowering] Special case overflow expansion for (uaddo X, C)..
Apr 25 2022, 3:43 AM · Restricted Project, Restricted Project

Apr 21 2022

HsiangKai updated the diff for D124231: [RISCV] Merge addi into load/store as there is a ADD between them.

Update test cases.

Apr 21 2022, 11:41 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D124231: [RISCV] Merge addi into load/store as there is a ADD between them.

It is not safe to do this peephole for ADD*W.

Apr 21 2022, 11:40 PM · Restricted Project, Restricted Project
HsiangKai added inline comments to D124231: [RISCV] Merge addi into load/store as there is a ADD between them.
Apr 21 2022, 11:34 PM · Restricted Project, Restricted Project
HsiangKai updated the summary of D124231: [RISCV] Merge addi into load/store as there is a ADD between them.
Apr 21 2022, 10:59 PM · Restricted Project, Restricted Project
HsiangKai requested review of D124231: [RISCV] Merge addi into load/store as there is a ADD between them.
Apr 21 2022, 10:58 PM · Restricted Project, Restricted Project

Apr 15 2022

HsiangKai added inline comments to D123264: [RISCV] Pre-RA expand pseudos pass.
Apr 15 2022, 7:55 AM · Restricted Project, Restricted Project
HsiangKai added inline comments to D123264: [RISCV] Pre-RA expand pseudos pass.
Apr 15 2022, 2:29 AM · Restricted Project, Restricted Project
HsiangKai added inline comments to D123264: [RISCV] Pre-RA expand pseudos pass.
Apr 15 2022, 1:26 AM · Restricted Project, Restricted Project
HsiangKai added inline comments to D123264: [RISCV] Pre-RA expand pseudos pass.
Apr 15 2022, 1:06 AM · Restricted Project, Restricted Project

Feb 28 2022

HsiangKai committed rGb8e296cf6a35: [AArch64][SME] Add rdsvl instruction (authored by HsiangKai).
[AArch64][SME] Add rdsvl instruction
Feb 28 2022, 3:15 PM
HsiangKai committed rG7dd7cb0487ca: [AArch64][SME] Add addsvl and addspl instructions (authored by HsiangKai).
[AArch64][SME] Add addsvl and addspl instructions
Feb 28 2022, 3:15 PM
HsiangKai closed D120603: [AArch64][SME] Add rdsvl instruction.
Feb 28 2022, 3:15 PM · Restricted Project
HsiangKai closed D120554: [AArch64][SME] Add addsvl and addspl instructions.
Feb 28 2022, 3:15 PM · Restricted Project

Feb 25 2022

HsiangKai requested review of D120603: [AArch64][SME] Add rdsvl instruction.
Feb 25 2022, 7:00 PM · Restricted Project
HsiangKai requested review of D120554: [AArch64][SME] Add addsvl and addspl instructions.
Feb 25 2022, 3:32 AM · Restricted Project
HsiangKai committed rG2cd675249d8d: [NFC][AArch64][SME] Remove '#' prefix in PSEL test cases (authored by HsiangKai).
[NFC][AArch64][SME] Remove '#' prefix in PSEL test cases
Feb 25 2022, 1:24 AM
HsiangKai closed D120543: [NFC][AArch64][SME] Remove '#' prefix in PSEL test cases.
Feb 25 2022, 1:24 AM · Restricted Project
HsiangKai requested review of D120543: [NFC][AArch64][SME] Remove '#' prefix in PSEL test cases.
Feb 25 2022, 12:04 AM · Restricted Project

Jan 25 2022

HsiangKai committed rG901dd53cbf61: [docs] There are more than three bit storage containers. (authored by HsiangKai).
[docs] There are more than three bit storage containers.
Jan 25 2022, 2:10 AM
HsiangKai committed rG48f763edb471: [docs] Refine the description in Set-Like and Map-Like container options. (authored by HsiangKai).
[docs] Refine the description in Set-Like and Map-Like container options.
Jan 25 2022, 2:10 AM
HsiangKai closed D117849: [docs] There are more than three bit storage containers..
Jan 25 2022, 2:09 AM · Restricted Project
HsiangKai closed D117858: [docs] Refine the description in Set-Like and Map-Like container options..
Jan 25 2022, 2:09 AM · Restricted Project

Jan 24 2022

HsiangKai updated the summary of D117858: [docs] Refine the description in Set-Like and Map-Like container options..
Jan 24 2022, 12:16 AM · Restricted Project
HsiangKai updated the summary of D117858: [docs] Refine the description in Set-Like and Map-Like container options..
Jan 24 2022, 12:16 AM · Restricted Project
HsiangKai updated the diff for D117858: [docs] Refine the description in Set-Like and Map-Like container options..

Update ProgrammersManual.rst according to @dexonsmith's suggestions.

Jan 24 2022, 12:13 AM · Restricted Project

Jan 23 2022

HsiangKai added inline comments to D117858: [docs] Refine the description in Set-Like and Map-Like container options..
Jan 23 2022, 11:50 PM · Restricted Project
HsiangKai retitled D117849: [docs] There are more than three bit storage containers. from [docs] There are four bit storage containers. to [docs] There are more than three bit storage containers..
Jan 23 2022, 11:46 PM · Restricted Project
HsiangKai added inline comments to D117849: [docs] There are more than three bit storage containers..
Jan 23 2022, 11:45 PM · Restricted Project
HsiangKai updated the diff for D117849: [docs] There are more than three bit storage containers..

Address dexonsmith's comments.

Jan 23 2022, 11:43 PM · Restricted Project

Jan 21 2022

HsiangKai requested review of D117858: [docs] Refine the description in Set-Like and Map-Like container options..
Jan 21 2022, 12:24 AM · Restricted Project

Jan 20 2022

HsiangKai requested review of D117849: [docs] There are more than three bit storage containers..
Jan 20 2022, 5:49 PM · Restricted Project
HsiangKai committed rGad06e65dc4da: [RISCV] Fix the bug in the register allocator caused by reserved BP. (authored by HsiangKai).
[RISCV] Fix the bug in the register allocator caused by reserved BP.
Jan 20 2022, 5:24 PM
HsiangKai closed D117663: [RISCV] Fix the bug in the register allocator caused by reserved BP..
Jan 20 2022, 5:24 PM · Restricted Project

Jan 19 2022

HsiangKai committed rG34570f4faf4c: [RISCV] Add a test to show the bug in the RA caused by reserved BP. (authored by HsiangKai).
[RISCV] Add a test to show the bug in the RA caused by reserved BP.
Jan 19 2022, 6:41 PM
HsiangKai closed D117738: [RISCV] Add a test to show the bug in the RA caused by reserved BP..
Jan 19 2022, 6:40 PM · Restricted Project
HsiangKai added a reviewer for D117663: [RISCV] Fix the bug in the register allocator caused by reserved BP.: kito-cheng.
Jan 19 2022, 6:34 PM · Restricted Project
HsiangKai updated the diff for D117663: [RISCV] Fix the bug in the register allocator caused by reserved BP..

Address comments and add a test case from D117738.

Jan 19 2022, 6:33 PM · Restricted Project
HsiangKai added a comment to D117663: [RISCV] Fix the bug in the register allocator caused by reserved BP..

Share you my reduced case for that issue, did you mind add that to this patch?

Command:
$ llc -mtriple=riscv64 -mattr=+experimental-v,+f -riscv-v-vector-bits-min=128

define void @foo(i32* nocapture noundef %p1) {
entry:
  %vla = alloca [10 x i32], align 64
  %0 = bitcast [10 x i32]* %vla to i8*
  call void @llvm.lifetime.start.p0i8(i64 40, i8* nonnull %0)
  %1 = bitcast i32* %p1 to <8 x float>*
  %2 = load <8 x float>, <8 x float>* %1, align 32
  %arraydecay = getelementptr inbounds [10 x i32], [10 x i32]* %vla, i64 0, i64 0
  call void @bar(i32 noundef signext 1, i32 noundef signext 2, i32 noundef signext 3, i32 noundef signext 4, i32 noundef signext 5, i32 noundef signext 6, i32 noundef signext 7, i32 noundef signext 8, i32* noundef nonnull %arraydecay)
  %3 = load <8 x float>, <8 x float>* %1, align 32
  %add = fadd <8 x float> %2, %3
  store <8 x float> %add, <8 x float>* %1, align 32
  call void @llvm.lifetime.end.p0i8(i64 40, i8* nonnull %0)
  ret void
}

declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture) #1

declare void @bar(i32 noundef signext, i32 noundef signext, i32 noundef signext, i32 noundef signext, i32 noundef signext, i32 noundef signext, i32 noundef signext, i32 noundef signext, i32* noundef)

declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture) #1

attributes #1 = { argmemonly mustprogress nofree nosync nounwind willreturn }
Jan 19 2022, 6:27 PM · Restricted Project
HsiangKai requested review of D117738: [RISCV] Add a test to show the bug in the RA caused by reserved BP..
Jan 19 2022, 6:25 PM · Restricted Project
HsiangKai committed rGd93ffa1b37b3: [docs] Fix typo in the example code in ProgrammersManual. (authored by HsiangKai).
[docs] Fix typo in the example code in ProgrammersManual.
Jan 19 2022, 5:26 PM
HsiangKai closed D117665: [docs] Fix typo in the example code in ProgrammersManual..
Jan 19 2022, 5:26 PM · Restricted Project
HsiangKai updated the diff for D117665: [docs] Fix typo in the example code in ProgrammersManual..

Address @dexonsmith's comments.

Jan 19 2022, 5:22 PM · Restricted Project
HsiangKai committed rG70cef70b131e: [docs] Put define DEBUG_TYPE after include directives. (authored by HsiangKai).
[docs] Put define DEBUG_TYPE after include directives.
Jan 19 2022, 5:19 PM
HsiangKai closed D117666: [docs] Put define DEBUG_TYPE after include directives..
Jan 19 2022, 5:19 PM · Restricted Project
HsiangKai requested review of D117666: [docs] Put define DEBUG_TYPE after include directives..
Jan 19 2022, 5:39 AM · Restricted Project
HsiangKai requested review of D117665: [docs] Fix typo in the example code in ProgrammersManual..
Jan 19 2022, 5:38 AM · Restricted Project
HsiangKai requested review of D117663: [RISCV] Fix the bug in the register allocator caused by reserved BP..
Jan 19 2022, 5:33 AM · Restricted Project

Dec 27 2021

HsiangKai committed rGa1c7ddf9264e: [RISCV] Support passing scalable vectur values through the stack. (authored by HsiangKai).
[RISCV] Support passing scalable vectur values through the stack.
Dec 27 2021, 5:36 PM
HsiangKai closed D116310: [RISCV] Support passing scalable vector values through the stack..
Dec 27 2021, 5:36 PM · Restricted Project
HsiangKai updated the diff for D116310: [RISCV] Support passing scalable vector values through the stack..

Update the test case.

Dec 27 2021, 7:23 AM · Restricted Project
HsiangKai requested review of D116310: [RISCV] Support passing scalable vector values through the stack..
Dec 27 2021, 6:58 AM · Restricted Project

Dec 26 2021

HsiangKai committed rG5d47e7d76895: [RISCV] Convert whole register copies as the source defined explicitly. (authored by HsiangKai).
[RISCV] Convert whole register copies as the source defined explicitly.
Dec 26 2021, 10:00 PM
HsiangKai closed D115866: [RISCV] Convert whole register copies as the source defined explicitly..
Dec 26 2021, 10:00 PM · Restricted Project

Dec 19 2021

HsiangKai added a comment to D110831: [RISCV] Add undisturbed version of unmasked intrinsics..

LGTM. I would like to wait for others reviewer's comments.
BTW, why the default tail undisturbed version of unmasked intrinsics is using mu (mask undisturbed)?

Dec 19 2021, 11:28 PM · Restricted Project
HsiangKai accepted D115430: [Clang][RISCV] Fix upper bound of RISC-V V type in debug info.

LGTM.

Dec 19 2021, 8:32 PM · Restricted Project
HsiangKai updated the diff for D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy..

In riscv-insert-vsetvli, use the policy argument. No use implicit-def maskedoff to adjust the setting.

Dec 19 2021, 7:57 PM · Restricted Project, Restricted Project

Dec 16 2021

HsiangKai requested review of D115866: [RISCV] Convert whole register copies as the source defined explicitly..
Dec 16 2021, 2:15 AM · Restricted Project
HsiangKai committed rG78415b5044e8: [RISCV] Precommit a test for vector copy conversion under implicit-def. (authored by HsiangKai).
[RISCV] Precommit a test for vector copy conversion under implicit-def.
Dec 16 2021, 2:05 AM
HsiangKai updated the diff for D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy..

Update attribute test cases.

Dec 16 2021, 12:58 AM · Restricted Project, Restricted Project
HsiangKai abandoned D106939: [RISCV] If the maskedoff is vundefined(), use ta,ma for vsetvli..
Dec 16 2021, 12:24 AM · Restricted Project, Restricted Project
HsiangKai abandoned D107022: [RISCV] Update test cases for D106939..
Dec 16 2021, 12:23 AM · Restricted Project
HsiangKai updated the diff for D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy..

Fix build errors.

Dec 16 2021, 12:16 AM · Restricted Project, Restricted Project

Dec 15 2021

HsiangKai updated the diff for D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy..

Address @craig.topper and @frasercrmck's comments.

Dec 15 2021, 10:52 PM · Restricted Project, Restricted Project
HsiangKai added inline comments to D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy..
Dec 15 2021, 10:44 PM · Restricted Project, Restricted Project
HsiangKai added inline comments to D112534: [PoC][RISCV] Use an attribute to declare C intrinsics with different policy..
Dec 15 2021, 10:37 PM · Restricted Project, Restricted Project
HsiangKai updated the diff for D110831: [RISCV] Add undisturbed version of unmasked intrinsics..

Address @khchen's comments.

Dec 15 2021, 10:03 PM · Restricted Project

Dec 14 2021

HsiangKai updated the diff for D110831: [RISCV] Add undisturbed version of unmasked intrinsics..
  • Fix build errors.
  • Deal with 'tied' pseudo instructions.
Dec 14 2021, 8:12 PM · Restricted Project
HsiangKai updated the diff for D110831: [RISCV] Add undisturbed version of unmasked intrinsics..

Rebase.

Dec 14 2021, 3:18 PM · Restricted Project

Dec 11 2021

HsiangKai accepted D115536: [RISCV] Don't use VLMAX for start value splat in reduction lowering..

LGTM.

Dec 11 2021, 7:24 AM · Restricted Project

Dec 9 2021

HsiangKai added a comment to D111617: [RISCV] Lazily add RVV C intrinsics..

Release build:
Before this patch:

   text         data     bss    dec             hex
115471733       7987112  443760 123902605       7629a8d ./bin/clang

After this patch:

   text         data     bss    dec             hex
117568981       7996376  443760 126009117       782bf1d ./bin/clang  (+1.7%)

Debug build:
Before this patch:

   text         data     bss    dec             hex
265437945       9544132  494152 275476229       106b6f05        ./bin/clang

After this patch:

   text         data     bss    dec             hex
272133359       9553380  494152 282180891       10d1bd1b        ./bin/clang. (+2.4%)
Dec 9 2021, 3:55 PM · Restricted Project, Restricted Project, Restricted Project
HsiangKai added a comment to D111617: [RISCV] Lazily add RVV C intrinsics..

Release build:
Before this patch:

   text         data     bss    dec             hex
115471733       7987112  443760 123902605       7629a8d ./bin/clang
Dec 9 2021, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
HsiangKai added a comment to D111617: [RISCV] Lazily add RVV C intrinsics..

Although it reduces the header size, this patch will increase the binary size of clang.

Debug build:
Before this patch:

text            data            bss             dec             hex             filename
263892591       10838284        500232          275231107       1067b183        clang-14

After this patch:

text            data            bss             dec             hex             filename
263909721       12085116        500232          276495069       107afadd        clang-14

Release build:
Before this patch;

text            data            bss             dec             hex             filename
382952171       88029764        10264736        481246671       1caf3dcf        clang-14

After this patch:

text            data            bss             dec             hex             filename
387629483       94652582        10264736        492546801       1d5baaf1        clang-14

These number indicate the release build is larger than debug. That seems wrong. Am I misreading these numbers?

Dec 9 2021, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Dec 6 2021

HsiangKai committed rG2ba769842396: [RISCV] Add scheduling resources for Vector pseudo instructions. (authored by evandro).
[RISCV] Add scheduling resources for Vector pseudo instructions.
Dec 6 2021, 5:15 PM
HsiangKai closed D113353: [RISCV] Add scheduling resources for Vector pseudo instructions..
Dec 6 2021, 5:15 PM · Restricted Project

Dec 5 2021

HsiangKai added a comment to D113353: [RISCV] Add scheduling resources for Vector pseudo instructions..

Ping.

Dec 5 2021, 5:21 PM · Restricted Project
HsiangKai updated the diff for D111617: [RISCV] Lazily add RVV C intrinsics..
  • Use unique_ptr.
  • Avoid to create static global constructors.
Dec 5 2021, 5:17 PM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

HsiangKai committed rG9a8856653717: [RISCV] Fix a bug in RISCVFrameLowering. (authored by HsiangKai).
[RISCV] Fix a bug in RISCVFrameLowering.
Nov 29 2021, 6:40 PM
HsiangKai committed rG4ae2222e143b: [RISCV] Add a test case to show the bug in RISCVFrameLowering. (authored by HsiangKai).
[RISCV] Add a test case to show the bug in RISCVFrameLowering.
Nov 29 2021, 6:40 PM
HsiangKai closed D114246: [RISCV] Fix a bug in RISCVFrameLowering..
Nov 29 2021, 6:40 PM · Restricted Project
HsiangKai closed D114245: [RISCV] Add a test case to show the bug in RISCVFrameLowering..
Nov 29 2021, 6:40 PM · Restricted Project
HsiangKai added a comment to D114245: [RISCV] Add a test case to show the bug in RISCVFrameLowering..

Don't put comments in the middle of generated CHECK lines, they will be moved on the next regenerate. Though I guess if this is going to be immediately fixed in a subsequent commit maybe it's about the only time it's ok...

Nov 29 2021, 5:35 PM · Restricted Project
HsiangKai updated the diff for D114246: [RISCV] Fix a bug in RISCVFrameLowering..

Update comments.

Nov 29 2021, 5:21 PM · Restricted Project