Page MenuHomePhabricator

HsiangKai (Hsiangkai Wang)
Kai -SiFive

Projects

User does not belong to any projects.

User Details

User Since
May 4 2016, 7:01 PM (184 w, 3 d)

Recent Activity

Thu, Nov 14

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Thu, Nov 14, 9:02 AM · Restricted Project

Wed, Nov 13

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Remove redundant code.
  • Fix build errors.
Wed, Nov 13, 4:25 AM · Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Use 'optional operand' to model 'vm' operand. (Thanks for @rogfer01's suggestions.)
  • Update according to comments.
Wed, Nov 13, 12:42 AM · Restricted Project

Mon, Nov 11

HsiangKai added a comment to D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Thanks for your suggestions and PoC commit. It looks great! I will modify the patch according to your suggestions.

Mon, Nov 11, 11:00 PM · Restricted Project

Sun, Nov 10

HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..

Add test cases for invalid instructions.

Sun, Nov 10, 7:58 AM · Restricted Project

Fri, Nov 8

HsiangKai added inline comments to D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Fri, Nov 8, 3:47 PM · Restricted Project
HsiangKai updated the diff for D69987: [RISCV] Assemble/Disassemble v-ext instructions..
  • Fix coding style problems.
  • Add more error checking.
  • Update according to suggestions.
Fri, Nov 8, 3:47 PM · Restricted Project
HsiangKai updated the summary of D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Fri, Nov 8, 12:51 AM · Restricted Project

Thu, Nov 7

HsiangKai created D69987: [RISCV] Assemble/Disassemble v-ext instructions..
Thu, Nov 7, 10:49 PM · Restricted Project

Sun, Oct 20

HsiangKai committed rL375387: Request commit access for hsiangkai.
Request commit access for hsiangkai
Sun, Oct 20, 8:24 PM
HsiangKai added a comment to D68685: [RISCV] Scheduler description for Rocket Core.

I wonder whether, instead of putting all the scheduling resource information as part of the instruction definition, we should be doing something like we do with patterns, ie declaring them separately (either in each RISCVInstrInfoX.td, or in RISCVSchedule.td to keep scheduling completely separate from encoding and codegen). For example (formatting aside):

def : InstRW<[WriteFALU32], (instrs FADD_S, FSUB_S, FSGNJ_S, FSGNJN_S, FSGNJX_S, FMIN_S, FMAX_S)>;
Sun, Oct 20, 4:08 PM · Restricted Project

Oct 17 2019

HsiangKai added a comment to D68685: [RISCV] Scheduler description for Rocket Core.

Some suggestions inlined.

Oct 17 2019, 12:48 AM · Restricted Project

Jul 18 2019

HsiangKai committed rGc5ecdd3c5a98: [DebugInfo] Some fields do not need relocations even relax is enabled. (authored by HsiangKai).
[DebugInfo] Some fields do not need relocations even relax is enabled.
Jul 18 2019, 11:12 PM
HsiangKai committed rL366531: [DebugInfo] Some fields do not need relocations even relax is enabled..
[DebugInfo] Some fields do not need relocations even relax is enabled.
Jul 18 2019, 11:12 PM
HsiangKai closed D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
Jul 18 2019, 11:12 PM · Restricted Project
HsiangKai committed rG18ccfadd4630: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame. (authored by HsiangKai).
[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.
Jul 18 2019, 7:05 PM
HsiangKai committed rL366524: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..
[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.
Jul 18 2019, 7:03 PM
HsiangKai committed rG657277e0f10d: Revert "[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame." (authored by HsiangKai).
Revert "[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame."
Jul 18 2019, 8:08 AM
HsiangKai committed rL366444: Revert "[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.".
Revert "[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame."
Jul 18 2019, 8:07 AM
HsiangKai committed rGe43ce1a958aa: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame. (authored by HsiangKai).
[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.
Jul 18 2019, 7:50 AM
HsiangKai committed rL366442: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..
[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.
Jul 18 2019, 7:47 AM
HsiangKai closed D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..
Jul 18 2019, 7:47 AM · Restricted Project

Jul 11 2019

HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Does this solution extend/address other label deltas, like those that would appear in the other DWARF/non-frame sections? (eg: currently we use a length in the DWARF high_pc because it means not having to use a relocation for high_pc, which reduces object size - so, does this fix cause relocations to be used for that length expression to ensure they're correct if the linker changes the instructions in that range?)

After D45181 committed, LLVM will generate relocation pairs for symbol difference expressions if target enables relaxation. So, it will generate relocations for high_pc due to it is a symbol difference expression of end symbol and start symbol of the function range. Such as,

.word   .Lfunc_begin0           # DW_AT_low_pc
.word   .Lfunc_end4-.Lfunc_begin0 # DW_AT_high_pc

This commit modified the condition to generate relocations for symbol difference expressions. Not all symbol difference expressions are related to executable code. However, only executable code will be modified by linker for relaxation. So, we do not need to generate relocations for symbol differences not located in executable code sections.

Good to know - so has LLVM been creating incorrect DWARF in these cases so far - or has no target enabled linker relaxation yet?

Is there any way to make this more targeted - does linker relaxation allow arbitrary machine code changes? Or is there something more fine-grained - so we could compute compile-time constants for some label differences, but only use linker relocations for cases where we know the instruction sequence includes something relaxable?

Jul 11 2019, 12:24 AM · Restricted Project

Jul 10 2019

HsiangKai added a comment to D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

Ping.

Jul 10 2019, 8:29 PM · Restricted Project
HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Does this solution extend/address other label deltas, like those that would appear in the other DWARF/non-frame sections? (eg: currently we use a length in the DWARF high_pc because it means not having to use a relocation for high_pc, which reduces object size - so, does this fix cause relocations to be used for that length expression to ensure they're correct if the linker changes the instructions in that range?)

Jul 10 2019, 8:25 PM · Restricted Project

Jun 25 2019

HsiangKai added a comment to D63409: [RISCV] Specify various encodings for DWARF exception handling.

I think D63409, D63411, D63415, and D63416 could be merged as one patch. They are all related to exception handling for RISC-V.

I kept them as separate changes since they're incremental and I thought it would make things easier to review, but I can squash them into one patch if that is more convenient. At the very least I plan on keeping D63415 separate as it includes generic changes.

Jun 25 2019, 7:28 PM · Restricted Project

Jun 24 2019

HsiangKai added a comment to D63409: [RISCV] Specify various encodings for DWARF exception handling.

I think D63409, D63411, D63415, and D63416 could be merged as one patch. They are all related to exception handling for RISC-V.

Jun 24 2019, 8:46 PM · Restricted Project

Jun 22 2019

HsiangKai added a reviewer for D62062: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info: probinson.
Jun 22 2019, 7:30 PM · Restricted Project
HsiangKai added a comment to D62062: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info.

LGTM.

Jun 22 2019, 7:22 PM · Restricted Project
HsiangKai added a comment to D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

Use llvm-dwarfdump to ensure DWARF parsing is correct under relaxation.

Jun 22 2019, 6:43 PM · Restricted Project
HsiangKai updated the diff for D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

Update test cases.

Jun 22 2019, 6:33 PM · Restricted Project
HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Just a quick comment, I'm assuming this depends on D58335 based on the test file you've modified?

Jun 22 2019, 9:02 AM · Restricted Project
HsiangKai updated the diff for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Fix bugs.

Jun 22 2019, 8:50 AM · Restricted Project

Jun 11 2019

HsiangKai committed rG04ddf39b4465: [RISCV] Add CFI directives for RISCV prologue/epilog. (authored by HsiangKai).
[RISCV] Add CFI directives for RISCV prologue/epilog.
Jun 11 2019, 8:02 PM
HsiangKai committed rL363120: [RISCV] Add CFI directives for RISCV prologue/epilog..
[RISCV] Add CFI directives for RISCV prologue/epilog.
Jun 11 2019, 8:02 PM
HsiangKai closed D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..
Jun 11 2019, 8:02 PM · Restricted Project
HsiangKai committed rG93be25b5806e: [NFC] Correct comments in RegisterCoalescer. (authored by HsiangKai).
[NFC] Correct comments in RegisterCoalescer.
Jun 11 2019, 7:57 PM
HsiangKai committed rL363119: [NFC] Correct comments in RegisterCoalescer..
[NFC] Correct comments in RegisterCoalescer.
Jun 11 2019, 7:56 PM
HsiangKai closed D63124: [NFC] Correct comments in RegisterCoalescer..
Jun 11 2019, 7:56 PM · Restricted Project
HsiangKai created D63124: [NFC] Correct comments in RegisterCoalescer..
Jun 11 2019, 12:23 AM · Restricted Project

May 31 2019

HsiangKai added a comment to D62062: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info.

This patch does not handle .eh_frame and .debug_frame. I know that it could not generate debug frame information in the current upstream LLVM. In order to generate .eh_frame and .debug_frame for RISC-V architecture, D58335 and D61773 need to be landed first. So, I add related processing code for .eh_frame and .debug_frame in D58335.

May 31 2019, 3:50 AM · Restricted Project
HsiangKai updated the diff for D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

Support .debug_frame/.eh_frame parsing for llvm-dwarfdump.

May 31 2019, 3:38 AM · Restricted Project

May 29 2019

HsiangKai updated the diff for D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..

Update test cases.

May 29 2019, 5:37 PM · Restricted Project
HsiangKai updated the diff for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Fix the bug according to @jrtc27's suggestions.

May 29 2019, 5:37 PM · Restricted Project
HsiangKai updated the diff for D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..

Add .cfi_restore for callee-saved registers in epilogue.

May 29 2019, 12:49 AM · Restricted Project

May 24 2019

HsiangKai updated the diff for D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..

Update the test case.

May 24 2019, 5:02 PM · Restricted Project

May 23 2019

HsiangKai added a comment to D62062: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info.

Could you provide test cases for this patch?

May 23 2019, 7:59 PM · Restricted Project
HsiangKai updated the diff for D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..
May 23 2019, 7:06 PM · Restricted Project
HsiangKai added inline comments to D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..
May 23 2019, 7:02 PM · Restricted Project

May 16 2019

HsiangKai updated the diff for D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..

Update test cases.

May 16 2019, 7:12 PM · Restricted Project
HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Why do we need this flag; can we not already determine this (either in generic code or the target backends)? Anything where all symbols referenced are not in SHF_EXECINSTR sections can be evaluated even with relaxations, which covers all these cases:

  1. MCDwarfLineTableHeader::Emit's LineStartSym/LineEndSym/ProEndSym are in .debug_line.dwo which is just SHF_EXCLUDE
  2. EmitGenDwarfInfo's InfoStart/InfoEnd are in .debug_info.dwo which is just SHF_EXCLUDE
  3. FrameEmitterImpl::EmitCIE's sectionStart/sectionEnd are either in .eh_frame which is SHF_ALLOC (and also SHF_WRITE on non-x86 Solaris), or in .debug_frame which has no flags
  4. FrameEmitterImpl::EmitFDE's fdeStart/fdeEnd/cieStart/SectionStart should all also be in the same section as above
May 16 2019, 4:31 PM · Restricted Project
HsiangKai added a comment to D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..
In D61773#1504748, @asb wrote:
In D61773#1504714, @asb wrote:

Better to modify the tests to add nounwind. I have a patch that does that sitting around (I added CFI directives downstream but didn't clean it up for submission). Let me apply the test suite patch upstream, then can you rebase on that.

Committed in rL360897

May 16 2019, 4:31 PM · Restricted Project
HsiangKai updated the diff for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Check Fixup is nullptr or not before calling its member functions.

May 16 2019, 1:45 AM · Restricted Project
HsiangKai updated the diff for D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..

Update test cases for RISCV.

May 16 2019, 1:42 AM · Restricted Project

May 15 2019

HsiangKai updated the diff for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Update comments.

May 15 2019, 11:35 PM · Restricted Project
HsiangKai updated the diff for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Set Fixed flag to length of debug_info and debug_line. These fields should be fixed even the linker has modified the instructions in the program.

May 15 2019, 11:17 PM · Restricted Project
HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

It still bothers me that MCDwarf has to know exactly when to override the target's decision to do relaxation.

Why is it appropriate to do that in the two methods where you have made that change in this patch, and not in many other places within MCDwarf that call the same helper? What guides me to know it's correct in the first three calls to emitAbsValue within FrameEmitterImpl::EmitFDE, but not in the fourth? Without becoming an expert in all the fine details of every target.

May 15 2019, 11:10 PM · Restricted Project

May 14 2019

HsiangKai updated the diff for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Add a flag to MCFixup instead of MCExpr.

May 14 2019, 5:44 AM · Restricted Project

May 13 2019

HsiangKai added reviewers for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled.: probinson, dblaikie, aprantl.
May 13 2019, 7:45 PM · Restricted Project
HsiangKai updated the diff for D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Attach a test case.

May 13 2019, 7:37 PM · Restricted Project
HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

The call stack when evaluating Length in FDE is

MCExpr::evaluateAsAbsolute()
MCObjectStreamer::EmitValueImpl()  <= generate MCFixup
MCELFStreamer::EmitValueImpl()
MCStreamer::EmitValue()
emitAbsValue()
May 13 2019, 7:27 PM · Restricted Project
HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

Thanks for the reference, that helps some.
However I still think this isn't the right way to go about fixing the problem. This started because RISC-V decided not to resolve certain kinds of expressions, and then it turns out that applies to too many expressions. Somebody suggested that the asm backend decision should be more refined, based on symbol section perhaps, and that feels like a more principled way to go about it.

May 13 2019, 7:18 PM · Restricted Project

May 9 2019

HsiangKai created D61773: [RISCV] Add CFI directives for RISCV prologue/epilog..
May 9 2019, 6:37 PM · Restricted Project

May 8 2019

HsiangKai added a comment to D45181: [RISCV] Add diff relocation support for RISC-V.

The problem is that Length is the length of the CIE, i.e. the data structure itself; this means it isn't subject to relaxations and so the difference expression can be folded. I don't see much merit in teaching all the tools out there to check relocations for Length when we can instead just emit the "right" thing. I think the fix is to make sure we only return true from requiresDiffExpressionRelocations if a target is in a code section? MCSection::UseCodeAlign will tell you this (or you can use MCSectionELF::getFlags() & ELF::SHF_EXECINSTR to be less general), though perhaps it should be renamed to isCodeSection to match isVirtualSection.

May 8 2019, 9:07 AM · Restricted Project

May 6 2019

HsiangKai added a comment to D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..

I don't claim to be an MCExpr expert, but I think this should not be necessary. There are other situations where symbol differences are computed and emitted as constants, for example when DW_AT_high_pc is a length rather than an address, and they clearly don't require this tactic.

May 6 2019, 10:58 PM · Restricted Project
HsiangKai added a comment to D45181: [RISCV] Add diff relocation support for RISC-V.

@rogfer01 Are you still looking into this? My efforts to fix the problem with the debug information would also touch this. How do you want to proceed?

I made some changes in my downstream so things link successfully but I'm still seeing issues with exceptions at runtime. So nothing very useful at the moment for upstream, feel free to make changes here.

May 6 2019, 12:48 AM · Restricted Project
HsiangKai created D61584: [DebugInfo] Some fields do not need relocations even relax is enabled..
May 6 2019, 12:35 AM · Restricted Project

May 5 2019

HsiangKai added a comment to D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

Ping. The patch is similar to D46850.

May 5 2019, 11:34 PM · Restricted Project

Mar 1 2019

HsiangKai updated the diff for D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..
Mar 1 2019, 10:31 PM · Restricted Project
HsiangKai updated the diff for D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..
Mar 1 2019, 10:25 PM · Restricted Project
HsiangKai added inline comments to D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..
Mar 1 2019, 10:17 PM · Restricted Project

Feb 17 2019

HsiangKai created D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..
Feb 17 2019, 3:45 PM · Restricted Project

Jan 23 2019

HsiangKai committed rC352025: Reland r345009 "[DebugInfo] Generate debug information for labels.".
Reland r345009 "[DebugInfo] Generate debug information for labels."
Jan 23 2019, 9:34 PM
HsiangKai committed rL352025: Reland r345009 "[DebugInfo] Generate debug information for labels.".
Reland r345009 "[DebugInfo] Generate debug information for labels."
Jan 23 2019, 9:34 PM
HsiangKai closed D45045: [DebugInfo] Generate debug information for labels..
Jan 23 2019, 9:34 PM

Jan 21 2019

HsiangKai added a comment to D45045: [DebugInfo] Generate debug information for labels..

D54199 and D54465 have been accepted and landed. I have tested the revision with LLVM test and Clang test. They are all passed. Chromium build is also successful in my local environment. I think it is ready to reland the revision.

Jan 21 2019, 6:26 PM

Jan 17 2019

HsiangKai committed rL351525: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
[CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated.
Jan 17 2019, 11:22 PM
HsiangKai closed D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Jan 17 2019, 11:22 PM · debug-info

Jan 10 2019

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Jan 10 2019, 2:50 PM · debug-info

Dec 26 2018

HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

Ping.

Dec 26 2018, 7:13 PM · debug-info

Dec 17 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Dec 17 2018, 7:01 PM · debug-info

Dec 16 2018

HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

Ping.

Dec 16 2018, 6:20 PM · debug-info

Dec 4 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Dec 4 2018, 5:15 AM · debug-info

Nov 30 2018

HsiangKai closed D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed..

This revision is committed to master branch.
I forgot to add "Differential Revision" in commit message. So, this revision is not closed automatically.

Nov 30 2018, 12:18 AM
HsiangKai committed rL347964: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
[CodeGen] Fix bugs in BranchFolderPass when debug labels are generated.
Nov 30 2018, 12:11 AM
HsiangKai closed D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
Nov 30 2018, 12:11 AM
HsiangKai committed rL347963: [NFC] Refine doxygen format..
[NFC] Refine doxygen format.
Nov 30 2018, 12:10 AM
HsiangKai closed D54568: [NFC] Refine doxygen format..
Nov 30 2018, 12:10 AM

Nov 28 2018

HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

Ping.

Nov 28 2018, 7:23 PM · debug-info
HsiangKai added inline comments to D54199: [CodeGen] Fix bugs in BranchFolderPass when debug labels are generated..
Nov 28 2018, 7:16 PM

Nov 18 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 18 2018, 6:13 PM · debug-info
HsiangKai updated the diff for D54568: [NFC] Refine doxygen format..
Nov 18 2018, 6:11 PM

Nov 15 2018

HsiangKai added a parent revision for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated.: D54568: [NFC] Refine doxygen format..
Nov 15 2018, 6:26 PM · debug-info
HsiangKai added a child revision for D54568: [NFC] Refine doxygen format.: D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 15 2018, 6:26 PM
HsiangKai added a comment to D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..

This patch doesn't seem to apply. Does it need regenerating?

vext01@bencher8:~/source/llvm$ patch -Ep0 <  D54465.diff
patching file lib/CodeGen/LiveDebugVariables.cpp
Hunk #2 FAILED at 340.
Hunk #3 succeeded at 352 with fuzz 1 (offset -5 lines).
Hunk #4 FAILED at 372.
Hunk #5 succeeded at 395 (offset -9 lines).
Hunk #6 succeeded at 441 (offset -9 lines).
Hunk #7 succeeded at 466 (offset -9 lines).
Hunk #8 succeeded at 487 (offset -9 lines).
Hunk #9 succeeded at 531 (offset -9 lines).
Hunk #10 succeeded at 615 (offset -9 lines).
Hunk #11 succeeded at 651 (offset -9 lines).
Hunk #12 succeeded at 1291 (offset -7 lines).
Hunk #13 succeeded at 1348 (offset -7 lines).
2 out of 13 hunks FAILED -- saving rejects to file lib/CodeGen/LiveDebugVariables.cpp.rej
The next patch would create the file test/CodeGen/Generic/live-debug-label.ll,
which already exists!  Assume -R? [n]
Nov 15 2018, 6:25 PM · debug-info
HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 15 2018, 5:20 PM · debug-info
HsiangKai added a comment to D45045: [DebugInfo] Generate debug information for labels..

Hello all,

This commit has been reverted by rC345026. It was reported that this broke the Chromium build (again). Have you had a look to fix this, @HsiangKai?

Nov 15 2018, 6:43 AM

Nov 14 2018

HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 14 2018, 11:38 PM · debug-info
HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 14 2018, 11:30 PM · debug-info
HsiangKai updated the diff for D54465: [CodeGen] Fix bugs in LiveDebugVariables when debug labels are generated..
Nov 14 2018, 11:20 PM · debug-info