User Details
User Details
- User Since
- Dec 28 2012, 2:34 PM (316 w, 2 d)
Yesterday
Yesterday
LGTM
Fri, Jan 18
Fri, Jan 18
pcc added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..
This change would only impact the "diagnostic" (non-production) mode of CFI. In production builds we do not link the runtime library at all. So from a CFI perspective this is fine.
pcc added a comment to D56953: [COFF] Limit PR39667 ICF partitioning changes to ARM64.
D56955 should fix the underlying issue here.
pcc added inline comments to D56621: [hwasan] Madvise away thread aux data.
pcc added inline comments to D56757: [hwasan] Madvise away unused shadow..
Thu, Jan 17
Thu, Jan 17
It ought to be possible to cross-compile the Android runtimes on Mac/Win but that can probably be looked into later.
pcc added a comment to D56672: [HWASAN] Instrument globals.
An alternative idea to ifunc is to compute a tag for each global at compile time and store it in the global's virtual address in the symbol table. Although the tags wouldn't be randomized per run, maybe this would be enough.
xray: Add missing header to list of installed headers.
xray: Add missing header to list of installed headers.
Wed, Jan 16
Wed, Jan 16
pcc added inline comments to D54604: Automatic variable initialization.
pcc added inline comments to D54604: Automatic variable initialization.
LGTM
gn build: Add headers to compiler-rt build files.
Tue, Jan 15
Tue, Jan 15
pcc added inline comments to D56757: [hwasan] Madvise away unused shadow..
pcc committed rL351277: gn build: Add check-hwasan target..
gn build: Add check-hwasan target.
pcc added inline comments to D38430: Enable -pie and --enable-new-dtags by default on Android..
compiler-rt/test: Bring back -pie on Android.
compiler-rt/test: Bring back -pie on Android.
pcc added inline comments to D38430: Enable -pie and --enable-new-dtags by default on Android..
pcc added inline comments to D56713: gn build: Add check-hwasan target..
compiler-rt/test: Add a couple of convenience features for Android.
compiler-rt/test: Add a couple of convenience features for Android.
pcc committed rL351258: gn build: Add a stage2 host toolchain and make the hwasan runtime buildable on….
gn build: Add a stage2 host toolchain and make the hwasan runtime buildable on…
pcc added a comment to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Yes, those missing flags didn't cause any issues for me with hwasan. I'd expect that as support for more sanitizers is added we'd need to make the flags used look more like the cmake build.
gn build: Add a resource_dir.gni file.
pcc added inline comments to D56712: compiler-rt/test: Add a couple of convenience features for Android..
pcc committed rCRT351252: compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg..
compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg.
compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg.
gn build: Move target flags from toolchain to a .gni file.
pcc added a comment to D56710: gn build: Move target flags from toolchain to a .gni file..
gn build: Add build files for compiler-rt/lib/{hwasan,interception…
pcc committed rL351242: gn build: Merge r351216, r351228..
gn build: Merge r351216, r351228.
CodeGen: Remove debug printf unintentionally added in r351228.
CodeGen: Remove debug printf unintentionally added in r351228.
gn build: Rename llvm_host_triple to llvm_current_triple and have it use…
gn build: Make a couple of improvements to the unix toolchain.
Mon, Jan 14
Mon, Jan 14
pcc added inline comments to D56705: gn build: Make a couple of improvements to the unix toolchain..
pcc updated the diff for D56705: gn build: Make a couple of improvements to the unix toolchain..
- Address review comments
pcc added inline comments to D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..
pcc added inline comments to D56700: gn build: Add a resource_dir.gni file..
pcc updated the diff for D56700: gn build: Add a resource_dir.gni file..
- Rename to clang_resource_dir
gn build: Switch to using current_os in lib/Support/BUILD.gn.
pcc updated the diff for D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
- Also update the other files
pcc added inline comments to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
pcc updated the diff for D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
- Address review comments
gn build: Split no-RTTI flag into a config.
gn build: Stop defining LLVM_ON_UNIX globally.
LGTM
Sun, Jan 13
Sun, Jan 13
pcc added a comment to D56638: [llgo]: Somewhat revive it and make it buildable with current trunk..
For testing -fsplit-stack you probably want to add a test under llgo/test/irgen. They are standard lit tests.
Fri, Jan 11
Fri, Jan 11
pcc committed rL350980: sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of….
sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of…
pcc committed rCRT350980: sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of….
sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of…
gn build: Add a stage2 toolchain for Android.
pcc added inline comments to D56577: gn build: Add a stage2 toolchain for Android..
gn build: Create a template for unix toolchains.
pcc added inline comments to D56576: gn build: Create a template for unix toolchains..
pcc added inline comments to D56600: LLD doc tweaks.
LGTM
pcc committed rL350964: gn build: Create a variable for the host toolchain and start using it in the….
gn build: Create a variable for the host toolchain and start using it in the…
gn build: s/root_out_dir/root_build_dir/g in…