Page MenuHomePhabricator

pcc (Peter Collingbourne)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 28 2012, 2:34 PM (316 w, 2 d)

Recent Activity

Yesterday

pcc accepted D56638: [llgo]: Somewhat revive it and make it buildable with current trunk..

LGTM

Sun, Jan 20, 2:38 PM
pcc created D56986: COFF, ELF: ICF: Perform 2 rounds of relocation hash propagation..
Sun, Jan 20, 2:31 PM

Fri, Jan 18

pcc added a comment to D56485: Always compare C++ typeinfo (based on libstdc++ implementation)..

This change would only impact the "diagnostic" (non-production) mode of CFI. In production builds we do not link the runtime library at all. So from a CFI perspective this is fine.

Fri, Jan 18, 10:30 PM
pcc added a comment to D56953: [COFF] Limit PR39667 ICF partitioning changes to ARM64.

D56955 should fix the underlying issue here.

Fri, Jan 18, 8:44 PM
pcc created D56955: COFF, ELF: Adjust ICF hash computation to account for self relocations..
Fri, Jan 18, 8:39 PM
pcc added inline comments to D56621: [hwasan] Madvise away thread aux data.
Fri, Jan 18, 7:24 PM
pcc created D56954: hwasan: Move memory access checks into small outlined functions on aarch64..
Fri, Jan 18, 7:02 PM
pcc accepted D56757: [hwasan] Madvise away unused shadow..

LGTM

Fri, Jan 18, 5:43 PM
pcc added inline comments to D56757: [hwasan] Madvise away unused shadow..
Fri, Jan 18, 4:44 PM

Thu, Jan 17

pcc accepted D56898: gn build: unbreak mac (and maybe win) after r351258, r351277.

It ought to be possible to cross-compile the Android runtimes on Mac/Win but that can probably be looked into later.

Thu, Jan 17, 8:08 PM
pcc added a comment to D56672: [HWASAN] Instrument globals.

An alternative idea to ifunc is to compute a tag for each global at compile time and store it in the global's virtual address in the symbol table. Although the tags wouldn't be randomized per run, maybe this would be enough.

Thu, Jan 17, 6:43 PM
pcc committed rCRT351479: xray: Add missing header to list of installed headers..
xray: Add missing header to list of installed headers.
Thu, Jan 17, 1:16 PM
pcc committed rL351479: xray: Add missing header to list of installed headers..
xray: Add missing header to list of installed headers.
Thu, Jan 17, 1:15 PM
pcc closed D56797: xray: Add missing header to list of installed headers..
Thu, Jan 17, 1:15 PM

Wed, Jan 16

pcc added inline comments to D54604: Automatic variable initialization.
Wed, Jan 16, 4:58 PM
pcc added a comment to D56325: Sort symbols in .bss by size..

I was able to build and test Chrome on Android. Without this, the dirty pages from all libraries included in Chrome APK sum up to 364KB. With the symbols in those libraries sorted, this comes down to 360KB.

Wed, Jan 16, 4:19 PM
pcc added inline comments to D54604: Automatic variable initialization.
Wed, Jan 16, 3:39 PM
pcc accepted D56801: Fix most of LLVM's tests with LLVM_ENABLE_PIC=OFF.

LGTM

Wed, Jan 16, 12:48 PM
pcc accepted D56800: compiler-rt tests: Unbreak cmake with LLVM_ENABLE_PIC=OFF on mac.

LGTM

Wed, Jan 16, 12:27 PM
pcc created D56797: xray: Add missing header to list of installed headers..
Wed, Jan 16, 10:51 AM
pcc committed rL351367: gn build: Add headers to compiler-rt build files..
gn build: Add headers to compiler-rt build files.
Wed, Jan 16, 10:50 AM

Tue, Jan 15

pcc committed rL351293: gn build: Merge r351283..
gn build: Merge r351283.
Tue, Jan 15, 6:31 PM
pcc added inline comments to D56757: [hwasan] Madvise away unused shadow..
Tue, Jan 15, 5:40 PM
pcc committed rL351277: gn build: Add check-hwasan target..
gn build: Add check-hwasan target.
Tue, Jan 15, 4:19 PM
pcc closed D56713: gn build: Add check-hwasan target..
Tue, Jan 15, 4:19 PM
pcc added inline comments to D38430: Enable -pie and --enable-new-dtags by default on Android..
Tue, Jan 15, 3:31 PM
pcc committed rL351270: compiler-rt/test: Bring back -pie on Android..
compiler-rt/test: Bring back -pie on Android.
Tue, Jan 15, 2:57 PM
pcc committed rCRT351270: compiler-rt/test: Bring back -pie on Android..
compiler-rt/test: Bring back -pie on Android.
Tue, Jan 15, 2:57 PM
pcc added inline comments to D38430: Enable -pie and --enable-new-dtags by default on Android..
Tue, Jan 15, 2:51 PM
pcc added inline comments to D56713: gn build: Add check-hwasan target..
Tue, Jan 15, 2:39 PM
pcc committed rCRT351260: compiler-rt/test: Add a couple of convenience features for Android..
compiler-rt/test: Add a couple of convenience features for Android.
Tue, Jan 15, 2:11 PM
pcc committed rL351260: compiler-rt/test: Add a couple of convenience features for Android..
compiler-rt/test: Add a couple of convenience features for Android.
Tue, Jan 15, 2:11 PM
pcc closed D56712: compiler-rt/test: Add a couple of convenience features for Android..
Tue, Jan 15, 2:10 PM
pcc committed rL351258: gn build: Add a stage2 host toolchain and make the hwasan runtime buildable on….
gn build: Add a stage2 host toolchain and make the hwasan runtime buildable on…
Tue, Jan 15, 2:06 PM
pcc closed D56711: gn build: Add a stage2 host toolchain and make the hwasan runtime buildable on x86_64 Linux..
Tue, Jan 15, 2:06 PM
pcc added a comment to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..

Yes, those missing flags didn't cause any issues for me with hwasan. I'd expect that as support for more sanitizers is added we'd need to make the flags used look more like the cmake build.

Tue, Jan 15, 2:04 PM
pcc committed rL351255: gn build: Add a resource_dir.gni file..
gn build: Add a resource_dir.gni file.
Tue, Jan 15, 1:49 PM
pcc closed D56700: gn build: Add a resource_dir.gni file..
Tue, Jan 15, 1:49 PM
pcc added inline comments to D56712: compiler-rt/test: Add a couple of convenience features for Android..
Tue, Jan 15, 1:45 PM
pcc committed rCRT351252: compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg..
compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg.
Tue, Jan 15, 1:32 PM
pcc committed rL351252: compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg..
compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg.
Tue, Jan 15, 1:32 PM
pcc closed D56697: compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg..
Tue, Jan 15, 1:32 PM
pcc committed rL351248: gn build: Move target flags from toolchain to a .gni file..
gn build: Move target flags from toolchain to a .gni file.
Tue, Jan 15, 1:28 PM
pcc closed D56710: gn build: Move target flags from toolchain to a .gni file..
Tue, Jan 15, 1:28 PM
pcc added a comment to D56710: gn build: Move target flags from toolchain to a .gni file..

I think it might make sense to pretty soon add build/{android,...}/BUILD.gn that defines a build/{android,...}_compiler config that's added to the config list soon, instead of expanding this duplicate way to define compiler flags.

Tue, Jan 15, 1:26 PM
pcc accepted D56516: [SanitizerCoverage] Don't create comdat for interposable functions..
Tue, Jan 15, 1:22 PM
pcc committed rL351246: gn build: Add build files for compiler-rt/lib/{hwasan,interception….
gn build: Add build files for compiler-rt/lib/{hwasan,interception…
Tue, Jan 15, 1:12 PM
pcc closed D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Tue, Jan 15, 1:12 PM
pcc committed rL351242: gn build: Merge r351216, r351228..
gn build: Merge r351216, r351228.
Tue, Jan 15, 1:06 PM
pcc committed rC351241: CodeGen: Remove debug printf unintentionally added in r351228..
CodeGen: Remove debug printf unintentionally added in r351228.
Tue, Jan 15, 1:04 PM
pcc committed rL351241: CodeGen: Remove debug printf unintentionally added in r351228..
CodeGen: Remove debug printf unintentionally added in r351228.
Tue, Jan 15, 1:04 PM
pcc created D56713: gn build: Add check-hwasan target..
Tue, Jan 15, 2:03 AM
pcc created D56712: compiler-rt/test: Add a couple of convenience features for Android..
Tue, Jan 15, 2:03 AM
pcc created D56711: gn build: Add a stage2 host toolchain and make the hwasan runtime buildable on x86_64 Linux..
Tue, Jan 15, 2:02 AM
pcc created D56710: gn build: Move target flags from toolchain to a .gni file..
Tue, Jan 15, 2:02 AM
pcc committed rL351168: gn build: Rename llvm_host_triple to llvm_current_triple and have it use….
gn build: Rename llvm_host_triple to llvm_current_triple and have it use…
Tue, Jan 15, 12:24 AM
pcc closed D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..
Tue, Jan 15, 12:24 AM
pcc committed rL351167: gn build: Make a couple of improvements to the unix toolchain..
gn build: Make a couple of improvements to the unix toolchain.
Tue, Jan 15, 12:20 AM
pcc closed D56705: gn build: Make a couple of improvements to the unix toolchain..
Tue, Jan 15, 12:20 AM

Mon, Jan 14

pcc added inline comments to D56705: gn build: Make a couple of improvements to the unix toolchain..
Mon, Jan 14, 11:50 PM
pcc updated the diff for D56705: gn build: Make a couple of improvements to the unix toolchain..
  • Address review comments
Mon, Jan 14, 11:49 PM
pcc added inline comments to D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..
Mon, Jan 14, 11:35 PM
pcc added inline comments to D56700: gn build: Add a resource_dir.gni file..
Mon, Jan 14, 11:31 PM
pcc updated the diff for D56700: gn build: Add a resource_dir.gni file..
  • Rename to clang_resource_dir
Mon, Jan 14, 11:31 PM
pcc committed rL351166: gn build: Switch to using current_os in lib/Support/BUILD.gn..
gn build: Switch to using current_os in lib/Support/BUILD.gn.
Mon, Jan 14, 11:21 PM
pcc closed D56704: gn build: Switch to using current_os in lib/Support/BUILD.gn..
Mon, Jan 14, 11:21 PM
pcc created D56705: gn build: Make a couple of improvements to the unix toolchain..
Mon, Jan 14, 9:14 PM
pcc created D56704: gn build: Switch to using current_os in lib/Support/BUILD.gn..
Mon, Jan 14, 9:09 PM
pcc created D56700: gn build: Add a resource_dir.gni file..
Mon, Jan 14, 8:31 PM
pcc created D56697: compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg..
Mon, Jan 14, 8:04 PM
pcc created D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..
Mon, Jan 14, 7:42 PM
pcc updated the diff for D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
  • Also update the other files
Mon, Jan 14, 7:11 PM
pcc added inline comments to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Mon, Jan 14, 7:07 PM
pcc updated the diff for D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
  • Address review comments
Mon, Jan 14, 7:07 PM
pcc committed rL351155: gn build: Split no-RTTI flag into a config..
gn build: Split no-RTTI flag into a config.
Mon, Jan 14, 6:47 PM
pcc closed D56627: gn build: Split no-RTTI flag into a config..
Mon, Jan 14, 6:47 PM
pcc committed rL351154: gn build: Stop defining LLVM_ON_UNIX globally..
gn build: Stop defining LLVM_ON_UNIX globally.
Mon, Jan 14, 6:46 PM
pcc closed D56626: gn build: Stop defining LLVM_ON_UNIX globally..
Mon, Jan 14, 6:46 PM
pcc accepted D56666: [LLD][ELF][AArch64] Add missing PLT relocations to isStaticLinkTimeConstant.

LGTM

Mon, Jan 14, 1:42 PM

Sun, Jan 13

pcc added a comment to D56638: [llgo]: Somewhat revive it and make it buildable with current trunk..

For testing -fsplit-stack you probably want to add a test under llgo/test/irgen. They are standard lit tests.

Sun, Jan 13, 2:07 PM

Fri, Jan 11

pcc added a child revision for D56626: gn build: Stop defining LLVM_ON_UNIX globally.: D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Fri, Jan 11, 5:39 PM
pcc added a child revision for D56627: gn build: Split no-RTTI flag into a config.: D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Fri, Jan 11, 5:39 PM
pcc created D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Fri, Jan 11, 5:39 PM
pcc created D56627: gn build: Split no-RTTI flag into a config..
Fri, Jan 11, 5:37 PM
pcc created D56626: gn build: Stop defining LLVM_ON_UNIX globally..
Fri, Jan 11, 5:37 PM
pcc committed rL350980: sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of….
sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of…
Fri, Jan 11, 3:34 PM
pcc committed rCRT350980: sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of….
sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of…
Fri, Jan 11, 3:34 PM
pcc closed D56579: sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of writing to stdout..
Fri, Jan 11, 3:34 PM
pcc committed rL350979: gn build: Add a stage2 toolchain for Android..
gn build: Add a stage2 toolchain for Android.
Fri, Jan 11, 3:22 PM
pcc closed D56577: gn build: Add a stage2 toolchain for Android..
Fri, Jan 11, 3:22 PM
pcc added inline comments to D56577: gn build: Add a stage2 toolchain for Android..
Fri, Jan 11, 3:22 PM
pcc committed rL350977: gn build: Create a template for unix toolchains..
gn build: Create a template for unix toolchains.
Fri, Jan 11, 3:02 PM
pcc closed D56576: gn build: Create a template for unix toolchains..
Fri, Jan 11, 3:02 PM
pcc added inline comments to D56576: gn build: Create a template for unix toolchains..
Fri, Jan 11, 3:02 PM
pcc added inline comments to D56600: LLD doc tweaks.
Fri, Jan 11, 2:32 PM
pcc committed rL350974: gn build: Merge r350958..
gn build: Merge r350958.
Fri, Jan 11, 2:19 PM
pcc accepted D56369: [SanitizerCoverage][NFC] Use appendToUsed instead of include.

LGTM

Fri, Jan 11, 12:45 PM
pcc committed rL350964: gn build: Create a variable for the host toolchain and start using it in the….
gn build: Create a variable for the host toolchain and start using it in the…
Fri, Jan 11, 11:57 AM
pcc closed D56575: gn build: Create a variable for the host toolchain and start using it in the tblgen template..
Fri, Jan 11, 11:57 AM
pcc committed rL350963: gn build: s/root_out_dir/root_build_dir/g in….
gn build: s/root_out_dir/root_build_dir/g in…
Fri, Jan 11, 11:56 AM