- User Since
- Dec 28 2012, 2:34 PM (255 w, 11 h)
Could you show me a diff against your revert of r318575?
- Remove some debugging code
Thu, Nov 16
Assuming that you've made the obvious change to the set type locally, this LGTM.
Wed, Nov 15
I didn't think that the pe format allowed absolute symbols to be exported.
Tue, Nov 14
Mon, Nov 13
Unfortunately, we were still seeing occasional permission denied errors on our bots even with that change.
So this code was added as part of D39874.
Fri, Nov 10
Can you add a test that uses the -asan-with-ifunc flag?
Thu, Nov 9
Do you have numbers?
According to https://msdn.microsoft.com/en-us/library/bxwfs976.aspx link.exe disables ICF by default when linking with /debug. We could do the same.
True, but from a practical perspective, programs that have been linked with link.exe are unlikely to break as a result of the default.
disabling /OPT:REF by default
We might actually consider doing that in /debug builds because it should provide a better debugging experience.
Wed, Nov 8
- Fix test case
I think this test would need to check that LTO is supported (see e.g. D39508).
Tue, Nov 7
I cannot run the test on Android myself, so it may require adjustment.
Mon, Nov 6
Sun, Nov 5
This change makes sense to me as it should allow for further simplification of the class hierarchy.
Fri, Nov 3
Thu, Nov 2
Wed, Nov 1
LGTM, I guess.
- Address review comments
Tue, Oct 31
I'd be curious about what sort of perf impact (positive or negative) comes from splitting the special case list into multiple regexes, as this part of the compiler has historically been perf sensitive. It may be that the trigram filter (which is relatively new) makes the impact relatively insignificant.
I'd expect there to be a test which makes sure that a jump with no line info in a file with line info doesn't count as an unprotected jump. Can you add one?
Mon, Oct 30
That's the size of the object files, not the size of the final executable, right?
Sun, Oct 29
I think this change makes sense at least from a stylistic perspective. The original idea of the split was to separate symbol properties from symbol name properties, but that created other issues like where to put member functions.
Fri, Oct 27
Should this fix also be sent upstream?
Thu, Oct 26
Should this include a test case?
Wed, Oct 25
- Add commas