Page MenuHomePhabricator

pcc (Peter Collingbourne)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 28 2012, 2:34 PM (368 w, 14 h)

Recent Activity

Yesterday

pcc committed rG9b9c68a2d6ad: hwasan: Remove dead code. NFCI. (authored by pcc).
hwasan: Remove dead code. NFCI.
Fri, Jan 17, 3:21 PM
pcc closed D72896: hwasan: Remove dead code. NFCI..
Fri, Jan 17, 3:20 PM · Restricted Project, Restricted Project
pcc added a comment to D72899: [MC] Set sh_link to 0 if the associated symbol is undefined.
  1. Add a non-GC-root dummy section. This is a bit awkward to implement in MC because we have to pick a section name. The section may be combined with other normal sections with the same name. We need to be careful and not cause an "incompatible section flags" error (lld specific).
Fri, Jan 17, 1:56 PM · Restricted Project
pcc committed rGcd40bd0a32e2: hwasan: Move .note.hwasan.globals note to hwasan.module_ctor comdat. (authored by pcc).
hwasan: Move .note.hwasan.globals note to hwasan.module_ctor comdat.
Fri, Jan 17, 1:46 PM
pcc closed D72936: hwasan: Move .note.hwasan.globals note to hwasan.module_ctor comdat..
Fri, Jan 17, 1:46 PM · Restricted Project
pcc accepted D72943: [ELF] Allow R_PLT_PC (R_PC) to a hidden undefined weak symbol.

LGTM

Fri, Jan 17, 12:09 PM · Restricted Project
pcc created D72936: hwasan: Move .note.hwasan.globals note to hwasan.module_ctor comdat..
Fri, Jan 17, 10:13 AM · Restricted Project

Thu, Jan 16

pcc added a comment to D72892: [MC][ARM] Resolve some pcrel fixups at assembly time.

If we just want a quick fix then I would prefer if we consider strong hidden symbols to be non-preemptible. This just seems like it would cause our assembler to hide bugs of the sort that D72197 was intended to catch, while changing the behavior for hidden symbols would mean that we continue to catch those bugs.

Thu, Jan 16, 6:24 PM · Restricted Project
pcc created D72896: hwasan: Remove dead code. NFCI..
Thu, Jan 16, 6:15 PM · Restricted Project, Restricted Project
pcc added a comment to D72892: [MC][ARM] Resolve some pcrel fixups at assembly time.

Shouldn't we just implement support for the relocation instead?

Thu, Jan 16, 5:10 PM · Restricted Project
pcc added a comment to D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local.
In D72197#1825012, @pcc wrote:

It looks like this change caused us to start rejecting:

.thumb
.thumb_func
.globl foo
.hidden foo
foo:
adr lr, foo + 1

with:

test.s:6:1: error: unsupported relocation on symbol
adr lr, foo + 1
^

This is exposed by this Android ART code: https://cs.android.com/android/platform/superproject/+/master:art/runtime/arch/arm/quick_entrypoints_arm.S;l=1826

I see a couple of possible fixes for this:

  1. We could go back to the previous behaviour for global hidden symbols.
  2. We could teach MC and LLD about the R_ARM_THM_ALU_PREL_11_0 relocation required to relocate this instruction. Arguably the ART code shouldn't be adding the 1 for Thumb here (because R_ARM_THM_ALU_PREL_11_0 adds the 1 itself), so ART would then need to be fixed.

foo is a hidden definition in the current object file. Can the ART code be changed to use a local symbol (adr lr, .Lfoo) instead?

Thu, Jan 16, 3:34 PM · Restricted Project
pcc added a comment to D65653: [AArch64] Change location of frame-record within callee-save area..

Exception handling has to use a DWARF unwinder, not a "fast" unwinder. So the "fast" unwinder can't actually do anything with the address other than print it out.

Thu, Jan 16, 2:24 PM · Restricted Project
pcc added a comment to D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local.
In D72197#1825012, @pcc wrote:

It looks like this change caused us to start rejecting:

.thumb
.thumb_func
.globl foo
.hidden foo
foo:
adr lr, foo + 1

with:

test.s:6:1: error: unsupported relocation on symbol
adr lr, foo + 1
^

This is exposed by this Android ART code: https://cs.android.com/android/platform/superproject/+/master:art/runtime/arch/arm/quick_entrypoints_arm.S;l=1826

I see a couple of possible fixes for this:

  1. We could go back to the previous behaviour for global hidden symbols.
  2. We could teach MC and LLD about the R_ARM_THM_ALU_PREL_11_0 relocation required to relocate this instruction. Arguably the ART code shouldn't be adding the 1 for Thumb here (because R_ARM_THM_ALU_PREL_11_0 adds the 1 itself), so ART would then need to be fixed.
% arm-linux-gnueabi-as /tmp/c/a.s -o /tmp/c/a.o
/tmp/c/a.s: Assembler messages:
/tmp/c/a.s:6: Error: invalid Hi register with immediate
/tmp/c/a.s:6: Error: invalid immediate for address calculation (value = 0xFFFFFFFFFFFFFFFE)

How can I make GNU as recognize it?

Thu, Jan 16, 2:06 PM · Restricted Project
pcc committed rGc299d1981dea: scudo: Add initial memory tagging support. (authored by pcc).
scudo: Add initial memory tagging support.
Thu, Jan 16, 1:37 PM
pcc closed D70762: scudo: Add initial memory tagging support..
Thu, Jan 16, 1:36 PM · Restricted Project, Restricted Project
pcc added a comment to D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local.

It looks like this change caused us to start rejecting:

.thumb
.thumb_func
.globl foo
.hidden foo
foo:
adr lr, foo + 1

with:

test.s:6:1: error: unsupported relocation on symbol
adr lr, foo + 1
^
Thu, Jan 16, 1:26 PM · Restricted Project
pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Address review comments
Thu, Jan 16, 12:37 PM · Restricted Project, Restricted Project
pcc added a comment to D70762: scudo: Add initial memory tagging support..

And I verified that this patch works on Fuchsia (x64 and arm64).

Thu, Jan 16, 12:37 PM · Restricted Project, Restricted Project
pcc added inline comments to D70762: scudo: Add initial memory tagging support..
Thu, Jan 16, 12:37 PM · Restricted Project, Restricted Project
pcc added a comment to D65653: [AArch64] Change location of frame-record within callee-save area..

So I believe that after this change, we are no longer guaranteed that FP + 16 = SP at exit, correct? I think this would be a requirement for a "fast" unwinder that works by following frame pointers (rather than reading unwind info) and is capable of decrypting return addresses of functions built with -msign-return-addresses (because the AUT instruction would need to know SP at exit). If this is the case, would it be feasible to let a platform opt out of this behaviour? (I realise that Darwin is opted out, but I don't know about the SVE support status there.) I'm not very familiar with SVE, but I would imagine that you could use a different register for this purpose on opted out platforms.

Thu, Jan 16, 10:32 AM · Restricted Project

Wed, Jan 15

pcc updated the diff for D70762: scudo: Add initial memory tagging support..

ebase

Wed, Jan 15, 4:25 PM · Restricted Project, Restricted Project
pcc added a comment to D72701: [Hexagon] Add support for Linux/Musl ABI..
In D72701#1822556, @pcc wrote:

I know almost nothing about Hexagon, but shouldn't this be determined by the target triple, or at least a target-feature?

When the target is Linux the clang driver will add this option.

Wed, Jan 15, 3:29 PM · Restricted Project
pcc added a comment to D72701: [Hexagon] Add support for Linux/Musl ABI..

I know almost nothing about Hexagon, but shouldn't this be determined by the target triple, or at least a target-feature?

Wed, Jan 15, 12:14 PM · Restricted Project

Tue, Jan 14

pcc accepted D72681: [ELF] --exclude-libs: don't assign VER_NDX_LOCAL to undefined symbols.

LGTM

Tue, Jan 14, 10:14 AM · Restricted Project

Mon, Jan 13

pcc added a comment to D71795: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC.
In D71795#1818468, @pcc wrote:

Weak undefined symbols are preemptible after D71794.

What about hidden weak undefined symbols? We now reject the following input:

 cat foo.cpp
 __attribute__((weak, visibility("hidden"))) void f();
 
 void g() {
   if (f) f();
 }
 $ clang -shared -fuse-ld=lld foo.cpp
 ld.lld: error: relocation R_X86_64_PLT32 cannot refer to absolute symbol: f()
>>> defined in /tmp/foo-014d89.o
>>> referenced by foo.cpp
>>>               /tmp/foo-014d89.o:(g())
 clang: error: linker command failed with exit code 1 (use -v to see invocation)

This seems like a reasonable thing to want to do. I actually hit this problem in a slightly different case (--exclude-libs demoted the weak undef to hidden) which we could fix like so:

diff --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp
index 19598f52cd4..54c033303f6 100644
--- a/lld/ELF/Driver.cpp
+++ b/lld/ELF/Driver.cpp
@@ -1374,7 +1374,7 @@ static void excludeLibs(opt::InputArgList &args) {
     if (!file->archiveName.empty())
       if (all || libs.count(path::filename(file->archiveName)))
         for (Symbol *sym : file->getSymbols())
-          if (!sym->isLocal() && sym->file == file)
+          if (!sym->isUndefined() && !sym->isLocal() && sym->file == file)
             sym->versionId = VER_NDX_LOCAL;
   };

But I'm somewhat more concerned about the explicit hidden case.

This patch looks good. Only defined symbols should have versions. I think the logic will also be closer to GNU ld:

// bfd/elflink.c
	  /* If this symbol has default visibility and the user has
	     requested we not re-export it, then mark it as hidden.  */
	  if (!bfd_is_und_section (sec)
	      && !dynamic
	      && abfd->no_export
	      && ELF_ST_VISIBILITY (isym->st_other) != STV_INTERNAL)
	    isym->st_other = (STV_HIDDEN
			      | (isym->st_other & ~ELF_ST_VISIBILITY (-1)));

If you haven't started working on this yet, I can send a patch.

Mon, Jan 13, 6:41 PM · Restricted Project
pcc added a comment to D71795: [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC.

Weak undefined symbols are preemptible after D71794.

Mon, Jan 13, 5:18 PM · Restricted Project

Thu, Jan 9

pcc accepted D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..

LGTM

Thu, Jan 9, 4:54 PM · Restricted Project
pcc added inline comments to D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..
Thu, Jan 9, 11:38 AM · Restricted Project

Wed, Jan 8

pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Add memory clobber
Wed, Jan 8, 5:20 PM · Restricted Project, Restricted Project
pcc requested changes to D72404: [ThinLTO/FullLTO] Support Os and Oz.

This is going in the wrong direction IMO. We already have a way of specifying the size optimization level, which is to specify -Os or -Oz at compile time. Why is that not sufficient?

Wed, Jan 8, 10:49 AM · Restricted Project, Restricted Project

Mon, Jan 6

pcc added inline comments to D70762: scudo: Add initial memory tagging support..
Mon, Jan 6, 4:34 PM · Restricted Project, Restricted Project
pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Address review comments
Mon, Jan 6, 4:22 PM · Restricted Project, Restricted Project
pcc added inline comments to D70762: scudo: Add initial memory tagging support..
Mon, Jan 6, 10:54 AM · Restricted Project, Restricted Project

Fri, Dec 20

pcc committed rG71b26f1d1924: gn build: Silence mismatched-new-delete warning in scudo C++ wrapper tests. (authored by pcc).
gn build: Silence mismatched-new-delete warning in scudo C++ wrapper tests.
Fri, Dec 20, 4:57 PM
pcc closed D71783: gn build: Silence mismatched-new-delete warning in scudo C++ wrapper tests..
Fri, Dec 20, 4:57 PM · Restricted Project
pcc added inline comments to D71738: [lld][WebAssembly] Add libcall symbols to the link when LTO is being used..
Fri, Dec 20, 1:37 PM · Restricted Project
pcc created D71783: gn build: Silence mismatched-new-delete warning in scudo C++ wrapper tests..
Fri, Dec 20, 1:25 PM · Restricted Project
pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Formatting
Fri, Dec 20, 11:01 AM · Restricted Project, Restricted Project
pcc accepted D71772: [scudo][standalone] Support __BIONIC__.

LGTM

Fri, Dec 20, 10:51 AM · Restricted Project, Restricted Project
pcc added inline comments to D71772: [scudo][standalone] Support __BIONIC__.
Fri, Dec 20, 10:19 AM · Restricted Project, Restricted Project
pcc added inline comments to D71772: [scudo][standalone] Support __BIONIC__.
Fri, Dec 20, 9:49 AM · Restricted Project, Restricted Project
pcc added inline comments to D71772: [scudo][standalone] Support __BIONIC__.
Fri, Dec 20, 9:19 AM · Restricted Project, Restricted Project

Thu, Dec 19

pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Move tag check disablement to the caller
Thu, Dec 19, 6:24 PM · Restricted Project, Restricted Project

Dec 18 2019

pcc added inline comments to D70762: scudo: Add initial memory tagging support..
Dec 18 2019, 2:38 PM · Restricted Project, Restricted Project

Dec 17 2019

pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Only load tags if useMemoryTagging()
Dec 17 2019, 9:45 AM · Restricted Project, Restricted Project
pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Load tags in malloc_iterate
Dec 17 2019, 9:35 AM · Restricted Project, Restricted Project

Dec 10 2019

pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Address review comments
Dec 10 2019, 2:18 PM · Restricted Project, Restricted Project
pcc added inline comments to D70762: scudo: Add initial memory tagging support..
Dec 10 2019, 2:00 PM · Restricted Project, Restricted Project
pcc added inline comments to D70762: scudo: Add initial memory tagging support..
Dec 10 2019, 2:00 PM · Restricted Project, Restricted Project
pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Address review comments
Dec 10 2019, 12:37 PM · Restricted Project, Restricted Project
pcc added inline comments to D70762: scudo: Add initial memory tagging support..
Dec 10 2019, 12:37 PM · Restricted Project, Restricted Project
pcc accepted D70753: hwasan: add tag_offset DWARF attribute to optimized debug info.

LGTM

Dec 10 2019, 12:28 PM · Restricted Project
pcc committed rGe966416ff151: scudo: Move getChunkFromBlock() allocated check into caller. NFCI. (authored by pcc).
scudo: Move getChunkFromBlock() allocated check into caller. NFCI.
Dec 10 2019, 12:10 PM
pcc committed rG9fbfdd2bfe42: scudo: Tweak how we align UserPtr. NFCI. (authored by pcc).
scudo: Tweak how we align UserPtr. NFCI.
Dec 10 2019, 12:10 PM
pcc closed D71292: scudo: Tweak how we align UserPtr. NFCI..
Dec 10 2019, 12:10 PM · Restricted Project, Restricted Project
pcc closed D71291: scudo: Move getChunkFromBlock() allocated check into caller. NFCI..
Dec 10 2019, 12:10 PM · Restricted Project, Restricted Project
pcc added parent revisions for D70762: scudo: Add initial memory tagging support.: D71291: scudo: Move getChunkFromBlock() allocated check into caller. NFCI., D71292: scudo: Tweak how we align UserPtr. NFCI..
Dec 10 2019, 11:32 AM · Restricted Project, Restricted Project
pcc added a child revision for D71291: scudo: Move getChunkFromBlock() allocated check into caller. NFCI.: D70762: scudo: Add initial memory tagging support..
Dec 10 2019, 11:32 AM · Restricted Project, Restricted Project
pcc updated the summary of D70762: scudo: Add initial memory tagging support..
Dec 10 2019, 11:32 AM · Restricted Project, Restricted Project
pcc added a child revision for D71292: scudo: Tweak how we align UserPtr. NFCI.: D70762: scudo: Add initial memory tagging support..
Dec 10 2019, 11:32 AM · Restricted Project, Restricted Project
pcc updated the diff for D70762: scudo: Add initial memory tagging support..
  • Address review comments
Dec 10 2019, 11:23 AM · Restricted Project, Restricted Project
pcc added a comment to D70762: scudo: Add initial memory tagging support..

The code now implements UAF checks by retagging on free.

Dec 10 2019, 11:23 AM · Restricted Project, Restricted Project
pcc created D71292: scudo: Tweak how we align UserPtr. NFCI..
Dec 10 2019, 11:23 AM · Restricted Project, Restricted Project
pcc created D71291: scudo: Move getChunkFromBlock() allocated check into caller. NFCI..
Dec 10 2019, 11:23 AM · Restricted Project, Restricted Project

Dec 9 2019

pcc added a reviewer for D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone.: pcc.
Dec 9 2019, 3:03 PM · Restricted Project, Restricted Project
pcc committed rG29f0a65671e2: scudo: Add a basic malloc/free benchmark. (authored by pcc).
scudo: Add a basic malloc/free benchmark.
Dec 9 2019, 10:16 AM
pcc committed rGbab9849963eb: Reland 198fbcb8, "Driver: Don't look for libc++ headers in the install… (authored by pcc).
Reland 198fbcb8, "Driver: Don't look for libc++ headers in the install…
Dec 9 2019, 10:16 AM
pcc closed D71104: scudo: Add a basic malloc/free benchmark..
Dec 9 2019, 10:15 AM · Restricted Project, Restricted Project
pcc closed D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 9 2019, 10:15 AM · Restricted Project
pcc reopened D71154: Driver: Don't look for libc++ headers in the install directory on Android..

Relanding with a fix for the problem found by @davezarzycki. The test needed to be adjusted to set --sysroot, otherwise it will fail in the case where a directory named /usr/include/c++/v1 or /usr/local/include/c++/v1 exists.

Dec 9 2019, 10:05 AM · Restricted Project

Dec 6 2019

pcc updated the diff for D71104: scudo: Add a basic malloc/free benchmark..
  • Address review comments
Dec 6 2019, 7:09 PM · Restricted Project, Restricted Project
pcc added a comment to D71104: scudo: Add a basic malloc/free benchmark..

Could you please put a comment somewhere on how to use the benchmark?

Dec 6 2019, 7:09 PM · Restricted Project, Restricted Project
pcc committed rG198fbcb81749: Driver: Don't look for libc++ headers in the install directory on Android. (authored by pcc).
Driver: Don't look for libc++ headers in the install directory on Android.
Dec 6 2019, 6:25 PM
pcc closed D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 6 2019, 6:25 PM · Restricted Project
pcc added inline comments to D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 6 2019, 5:02 PM · Restricted Project
pcc created D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 6 2019, 4:07 PM · Restricted Project
pcc committed rG3131249204bc: gn build: Change scudo's list of supported platforms to a whitelist. (authored by pcc).
gn build: Change scudo's list of supported platforms to a whitelist.
Dec 6 2019, 3:58 PM
pcc closed D71131: gn build: Change scudo's list of supported platforms to a whitelist..
Dec 6 2019, 3:58 PM · Restricted Project
pcc added a comment to D71131: gn build: Change scudo's list of supported platforms to a whitelist..

Thanks! lg.

I'd probably find it easier to understand, or at least more self-consistent, if this file had an assert(is_linux || is_fuchsia), and llvm/utils/gn/secondary/BUILD.gn had just the dep on //compiler-rt it already had, and the supported_toolchain stuff in this file wasn't here and instead relied on secondary/compiler-rt/BUILD.gn, and secondary/compiler-rt/lib/BUILD.gn would add a dep to scudo only if target_os == linux || fuchsia.

Dec 6 2019, 1:39 PM · Restricted Project
pcc added inline comments to D71104: scudo: Add a basic malloc/free benchmark..
Dec 6 2019, 10:50 AM · Restricted Project, Restricted Project
pcc added a comment to D71081: gn build: Add support for building scudo and its unit tests..
In D71081#1773044, @pcc wrote:

Yes, looking through the code as well as the CMake [1], scudo only supports building on Linux, Android and Fuchsia. Most of the code in linux.cpp looks like it would work on non-Linux POSIX, except for the mutex implementation.

It looks like the non-standalone allocator had some level of support for Windows [2] but that wasn't carried over to the standalone allocator.

So we should probably change the blacklist in the supported platforms to a whitelist for now. I'll go ahead and do that.

[1] http://llvm-cs.pcc.me.uk/projects/compiler-rt/cmake/config-ix.cmake#695
[2] http://llvm-cs.pcc.me.uk/projects/compiler-rt/lib/scudo/scudo_allocator_secondary.h#110

Dec 6 2019, 10:23 AM · Restricted Project
pcc created D71131: gn build: Change scudo's list of supported platforms to a whitelist..
Dec 6 2019, 10:23 AM · Restricted Project
pcc added a comment to D71081: gn build: Add support for building scudo and its unit tests..

Yes, looking through the code as well as the CMake [1], scudo only supports building on Linux, Android and Fuchsia. Most of the code in linux.cpp looks like it would work on non-Linux POSIX, except for the mutex implementation.

Dec 6 2019, 10:12 AM · Restricted Project

Dec 5 2019

pcc updated the diff for D71104: scudo: Add a basic malloc/free benchmark..
  • license header
Dec 5 2019, 6:44 PM · Restricted Project, Restricted Project
pcc created D71104: scudo: Add a basic malloc/free benchmark..
Dec 5 2019, 6:35 PM · Restricted Project, Restricted Project
pcc committed rG406659184140: gn build: Add support for building scudo and its unit tests. (authored by pcc).
gn build: Add support for building scudo and its unit tests.
Dec 5 2019, 6:17 PM
pcc committed rGb3516a0d4af3: gn build: Bump Android API level to 29, and NDK to r21. (authored by pcc).
gn build: Bump Android API level to 29, and NDK to r21.
Dec 5 2019, 6:17 PM
pcc closed D71081: gn build: Add support for building scudo and its unit tests..
Dec 5 2019, 6:16 PM · Restricted Project
pcc closed D71079: gn build: Bump Android API level to 29, and NDK to r21..
Dec 5 2019, 6:16 PM · Restricted Project
pcc updated the diff for D71081: gn build: Add support for building scudo and its unit tests..
  • Silence sync_source_lists_from_cmake.py
Dec 5 2019, 1:06 PM · Restricted Project
pcc updated the diff for D71081: gn build: Add support for building scudo and its unit tests..
  • gn format
Dec 5 2019, 11:30 AM · Restricted Project
pcc committed rGc8a2882a97e2: scudo: Fix one of the C wrapper tests on Android. (authored by pcc).
scudo: Fix one of the C wrapper tests on Android.
Dec 5 2019, 11:21 AM
pcc committed rG0cfe0a7bb0e1: scudo: Fix the build of wrappers_c_test.cpp on Android. (authored by pcc).
scudo: Fix the build of wrappers_c_test.cpp on Android.
Dec 5 2019, 11:21 AM
pcc closed D71078: scudo: Fix one of the C wrapper tests on Android..
Dec 5 2019, 11:21 AM · Restricted Project, Restricted Project
pcc closed D71077: scudo: Fix the build of wrappers_c_test.cpp on Android..
Dec 5 2019, 11:21 AM · Restricted Project, Restricted Project
pcc created D71081: gn build: Add support for building scudo and its unit tests..
Dec 5 2019, 11:02 AM · Restricted Project
pcc added a child revision for D71077: scudo: Fix the build of wrappers_c_test.cpp on Android.: D71081: gn build: Add support for building scudo and its unit tests..
Dec 5 2019, 11:02 AM · Restricted Project, Restricted Project
pcc added a child revision for D71078: scudo: Fix one of the C wrapper tests on Android.: D71081: gn build: Add support for building scudo and its unit tests..
Dec 5 2019, 11:02 AM · Restricted Project, Restricted Project
pcc added a child revision for D71079: gn build: Bump Android API level to 29, and NDK to r21.: D71081: gn build: Add support for building scudo and its unit tests..
Dec 5 2019, 11:02 AM · Restricted Project
pcc created D71079: gn build: Bump Android API level to 29, and NDK to r21..
Dec 5 2019, 11:01 AM · Restricted Project