Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (254 w, 2 d)

Recent Activity

Yesterday

phosek added inline comments to D72950: [CMake] compiler-rt: Add COMPILER_RT_BUILTINS_ENABLE_PIC.
Fri, Jan 17, 5:05 PM · Restricted Project, Restricted Project
phosek accepted D72951: [CMake] Handle 'Generic' system in HandleLLVMOptions.cmake.

LGTM

Fri, Jan 17, 4:17 PM · Restricted Project
phosek committed rG128e1ebd9310: [CMake] Prefer multi-target variables over generic target variables in runtimes… (authored by JamesNagurne).
[CMake] Prefer multi-target variables over generic target variables in runtimes…
Fri, Jan 17, 3:21 PM
phosek closed D71570: [CMake] Prefer multi-target variables over generic target variables in runtimes build.
Fri, Jan 17, 3:20 PM · Restricted Project
phosek committed rGd3db13af7e5c: [profile] Support counter relocation at runtime (authored by phosek).
[profile] Support counter relocation at runtime
Fri, Jan 17, 3:03 PM
phosek closed D69740: [profile] Support counter relocation at runtime.
Fri, Jan 17, 3:02 PM · Restricted Project, Restricted Project, Restricted Project
phosek accepted D72743: [libc] Replace the use of gtest with a new light weight unittest framework..

LGTM

Fri, Jan 17, 2:52 PM · Restricted Project
phosek created D72960: Include phabricator.uri in .arcconfig.
Fri, Jan 17, 2:43 PM · Restricted Project

Thu, Jan 16

phosek updated the diff for D69740: [profile] Support counter relocation at runtime.

Addressed the comment and also added a test for Linux.

Thu, Jan 16, 7:58 PM · Restricted Project, Restricted Project, Restricted Project
phosek committed rG9050d0fb593c: [libcxx] Temporarily switch back to pthread backend for Fuchsia (authored by phosek).
[libcxx] Temporarily switch back to pthread backend for Fuchsia
Thu, Jan 16, 2:54 PM
phosek closed D72862: [libcxx] Temporarily switch back to pthread backend for Fuchsia.
Thu, Jan 16, 2:54 PM · Restricted Project
phosek updated the diff for D72862: [libcxx] Temporarily switch back to pthread backend for Fuchsia.

Done

Thu, Jan 16, 2:53 PM · Restricted Project
phosek created D72862: [libcxx] Temporarily switch back to pthread backend for Fuchsia.
Thu, Jan 16, 12:18 PM · Restricted Project
phosek accepted D72859: [gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev.

LGTM

Thu, Jan 16, 12:18 PM · Restricted Project

Wed, Jan 15

phosek committed rG3481e5d7ed08: [libcxx] Use mtx_plain | mtx_recursive following C11 API (authored by phosek).
[libcxx] Use mtx_plain | mtx_recursive following C11 API
Wed, Jan 15, 3:20 PM
phosek closed D72809: [libcxx] Use mtx_plain | mtx_recursive following C11 API.
Wed, Jan 15, 3:20 PM · Restricted Project
phosek created D72809: [libcxx] Use mtx_plain | mtx_recursive following C11 API.
Wed, Jan 15, 2:06 PM · Restricted Project

Tue, Jan 14

phosek added inline comments to D72687: [libcxx] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Tue, Jan 14, 5:05 PM · Restricted Project
phosek committed rGab9aefee9fa0: [libcxx] Use C11 thread API on Fuchsia (authored by phosek).
[libcxx] Use C11 thread API on Fuchsia
Tue, Jan 14, 4:56 PM
phosek closed D64378: [libcxx] Use C11 thread API on Fuchsia.
Tue, Jan 14, 4:55 PM · Restricted Project
phosek updated the diff for D64378: [libcxx] Use C11 thread API on Fuchsia.
Tue, Jan 14, 1:19 PM · Restricted Project
phosek added inline comments to D71894: [libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present.
Tue, Jan 14, 11:52 AM · Restricted Project

Mon, Jan 13

phosek committed rG231875e111fa: [Clang] Always set -z now linker option on Fuchsia (authored by phosek).
[Clang] Always set -z now linker option on Fuchsia
Mon, Jan 13, 12:00 PM
phosek closed D70576: [Clang] Always set -z now linker option on Fuchsia.
Mon, Jan 13, 11:59 AM · Restricted Project

Mon, Jan 6

phosek committed rG71a2a62163cf: [CMake] Pass symlink dependency to add_llvm_install_targets explicitly (authored by phosek).
[CMake] Pass symlink dependency to add_llvm_install_targets explicitly
Mon, Jan 6, 2:54 PM
phosek closed D71951: [CMake] Pass symlink dependency to add_llvm_install_targets explicitly.
Mon, Jan 6, 2:54 PM · Restricted Project
phosek added a comment to D71951: [CMake] Pass symlink dependency to add_llvm_install_targets explicitly.

Ping?

Mon, Jan 6, 1:39 PM · Restricted Project

Fri, Jan 3

phosek accepted D72188: [fuchsia] Enable Clang Static Analyzer.

LGTM

Fri, Jan 3, 3:48 PM · Restricted Project

Thu, Jan 2

phosek added a comment to D71620: [Attributor] AAValueConstantRange: Value range analysis using constant range.

We're seeing a slightly different test failure on aarch64-linux-gnu:

FAIL: LLVM :: Transforms/Attributor/liveness.ll (27821 of 35033)
******************** TEST 'LLVM :: Transforms/Attributor/liveness.ll' FAILED ********************
Script:
--
: 'RUN: at line 2';   /b/s/w/ir/k/recipe_cleanup/clange57EIw/llvm_build_dir/bin/opt -attributor --attributor-disable=false -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=4 -S < /b/s/w/ir/k/llvm-project/llvm/test/Transforms/Attributor/liveness.ll | /b/s/w/ir/k/recipe_cleanup/clange57EIw/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/Transforms/Attributor/liveness.ll --check-prefixes=CHECK,OLDPM
: 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clange57EIw/llvm_build_dir/bin/opt -passes=attributor --attributor-disable=false -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=4 -S < /b/s/w/ir/k/llvm-project/llvm/test/Transforms/Attributor/liveness.ll | /b/s/w/ir/k/recipe_cleanup/clange57EIw/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/Transforms/Attributor/liveness.ll --check-prefixes=CHECK,NEWPM
--
Exit Code: 2
Thu, Jan 2, 4:59 PM · Restricted Project
phosek committed rGb63bc648a489: [CMake] clang-scan-deps in Fuchsia distribution (authored by phosek).
[CMake] clang-scan-deps in Fuchsia distribution
Thu, Jan 2, 4:50 PM
phosek closed D72113: [CMake] clang-scan-deps in Fuchsia distribution.
Thu, Jan 2, 4:50 PM · Restricted Project
phosek created D72113: [CMake] clang-scan-deps in Fuchsia distribution.
Thu, Jan 2, 2:49 PM · Restricted Project

Fri, Dec 27

phosek added a comment to D71951: [CMake] Pass symlink dependency to add_llvm_install_targets explicitly.

As an alternative, I've also considered iterating over all dependencies inside add_llvm_install_targets and see if the prefix of that target is install- and handling it specially, but that seems like a more error prone solution.

Fri, Dec 27, 4:37 PM · Restricted Project
phosek created D71951: [CMake] Pass symlink dependency to add_llvm_install_targets explicitly.
Fri, Dec 27, 4:35 PM · Restricted Project

Mon, Dec 23

phosek accepted D71634: Add implementations of POSIX mmap and munmap functions..

LGTM

Mon, Dec 23, 11:42 AM · Restricted Project

Fri, Dec 20

phosek added a comment to D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing..

This change seems to have broken -ffixed-xX, we've noticed that our kernel started crashing with tip-of-tree Clang. After debugging, we found out that compiler would generate stores to x15 even though we compile with -ffixed-x15 which breaks the kernel because x15 is used to store per-cpu state. Would it be possible to revert or fix this issue ASAP please?

Fri, Dec 20, 7:58 PM · Restricted Project
phosek added a comment to D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing..

This change seems to have broken -ffixed-xX, we've noticed that our kernel started crashing with tip-of-tree Clang. After debugging, we found out that compiler would generate stores to x15 even though we compile with -ffixed-x15 which breaks the kernel because x15 is used to store per-cpu state. Would it be possible to revert or fix this issue ASAP please?

Fri, Dec 20, 7:49 PM · Restricted Project
phosek accepted D71570: [CMake] Prefer multi-target variables over generic target variables in runtimes build.

LGTM

Fri, Dec 20, 5:09 PM · Restricted Project
phosek abandoned D71737: [CMake][runtimes] Skip the generic target variable if named matches.

This foreach loop goes over each variable, yes?
If so, then I'm not sure this change does what is required.

If the list variableNames is:

RUNTIMES_target+multi_XYZ
RUNTIMES_target_XYZ

This loop will:

  1. variableName = RUNTIMES_target+multi_XYZ
  2. Check if {name} matches, it does
  3. Add -DXYZ=value to the list
  4. variableName = RUNTIMES_target_XYZ
  5. Check if {name} matches, it doesn't
  6. Else, check if {target} matches, it does
  7. Add -DXYZ=value to the list, overriding the expected value in 3 above

    Edit: That is to say, only one path will ever be executed per iteration of this loop, so the addition of else() doesn't change the behavior.
Fri, Dec 20, 5:09 PM · Restricted Project
phosek committed rG581a7d0ee6ad: [llvm-symbolizer] Prefix invocations in test with env (authored by phosek).
[llvm-symbolizer] Prefix invocations in test with env
Fri, Dec 20, 3:57 PM
phosek committed rGdedad08ee8e6: [llvm-symbolizer] Support reading options from environment (authored by phosek).
[llvm-symbolizer] Support reading options from environment
Fri, Dec 20, 12:50 PM
phosek closed D71668: [llvm-symbolizer] Support reading options from environment.
Fri, Dec 20, 12:50 PM · Restricted Project
phosek updated the diff for D71668: [llvm-symbolizer] Support reading options from environment.
Fri, Dec 20, 12:49 PM · Restricted Project

Thu, Dec 19

phosek added a comment to D70744: [compiler-rt] Split the builtins CMake build to a separate file.

If I read this correctly, this would break existing setups that build builtins only, by pointing cmake to compiler-rt/lib/builtins? Is it possible to handle the transition more gracefully?

Thu, Dec 19, 5:57 PM · Restricted Project, Restricted Project
phosek updated the diff for D70744: [compiler-rt] Split the builtins CMake build to a separate file.
Thu, Dec 19, 5:57 PM · Restricted Project, Restricted Project
phosek added a comment to D71737: [CMake][runtimes] Skip the generic target variable if named matches.

This is an alternative to D71570.

Thu, Dec 19, 5:24 PM · Restricted Project
phosek updated the diff for D71737: [CMake][runtimes] Skip the generic target variable if named matches.
Thu, Dec 19, 5:24 PM · Restricted Project
phosek added a comment to D71570: [CMake] Prefer multi-target variables over generic target variables in runtimes build.

I'm fine with this change in general, but I'm concerned that no matter what order we choose, this might break users who rely on the opposite order. Maybe it'd be better to modify the logic to skip the second loop if the first loop matches, that way we wouldn't rely on any particular order.

Thu, Dec 19, 5:19 PM · Restricted Project
phosek created D71737: [CMake][runtimes] Skip the generic target variable if named matches.
Thu, Dec 19, 5:19 PM · Restricted Project
phosek added a comment to D71570: [CMake] Prefer multi-target variables over generic target variables in runtimes build.

I'm fine with this change in general, but I'm concerned that no matter what order we choose, this might break users who rely on the opposite order. Maybe it'd be better to modify the logic to skip the second loop if the first loop matches, that way we wouldn't rely on any particular order.

Thu, Dec 19, 5:14 PM · Restricted Project
phosek updated the diff for D71668: [llvm-symbolizer] Support reading options from environment.

I changed the name to LLVM_SYMBOLIZER_OPTS/LLVM_ADDR2LINE_OPTS since the short form seems to be more common among other tools.

Thu, Dec 19, 12:13 PM · Restricted Project
phosek added a comment to D71668: [llvm-symbolizer] Support reading options from environment.

I like the idea, but the behaviour needs adding to the llvm-symbolizer command guide. You may also want to consider adding it to the section on differences in llvm-addr2line.

Thu, Dec 19, 12:13 PM · Restricted Project
phosek updated the diff for D71668: [llvm-symbolizer] Support reading options from environment.
Thu, Dec 19, 12:13 PM · Restricted Project

Dec 18 2019

phosek added inline comments to D71634: Add implementations of POSIX mmap and munmap functions..
Dec 18 2019, 7:25 PM · Restricted Project
phosek updated the diff for D71668: [llvm-symbolizer] Support reading options from environment.

Test case added.

Dec 18 2019, 4:14 PM · Restricted Project
phosek added a comment to D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr..

This seems to be failing on aarch64-linux-gnu:

******************** TEST 'Clang :: CodeGenCXX/mangle-ptr-size-address-space.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';   /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc -fms-extensions -emit-llvm -triple aarch64-unknown-linux-gnu -o - /b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/mangle-ptr-size-address-space.cpp | /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/mangle-ptr-size-address-space.cpp --check-prefixes=CHECK
: 'RUN: at line 2';   /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/lib/clang/10.0.0/include -nostdsysteminc -fms-extensions -emit-llvm -triple x86_64-windows-msvc -o - /b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/mangle-ptr-size-address-space.cpp | /b/s/w/ir/k/recipe_cleanup/clangdgOoVq/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/CodeGenCXX/mangle-ptr-size-address-space.cpp --check-prefixes=WIN
--
Exit Code: 1
Dec 18 2019, 12:43 PM · Restricted Project
phosek created D71668: [llvm-symbolizer] Support reading options from environment.
Dec 18 2019, 10:25 AM · Restricted Project

Dec 17 2019

phosek closed D71641: [unwind] Don't link libpthread and libdl on Fuchsia.
Dec 17 2019, 10:12 PM · Restricted Project
phosek committed rG547659ae56f5: [unwind] Don't link libpthread and libdl on Fuchsia (authored by phosek).
[unwind] Don't link libpthread and libdl on Fuchsia
Dec 17 2019, 5:29 PM
phosek added a comment to D71135: [cxx][cxxabi] Don't link libpthread and libdl on Fuchsia.

If it causes link-time error, why CMake checks don't catch that?

Dec 17 2019, 5:29 PM · Restricted Project
phosek created D71641: [unwind] Don't link libpthread and libdl on Fuchsia.
Dec 17 2019, 5:20 PM · Restricted Project
phosek added a comment to D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.

We're seeing a different failure on our 2-stage bots (in second stage):

/b/s/w/ir/k/llvm-project/llvm/test/TableGen/GICombinerEmitter/parse-match-pattern.td:30:17: error: CHECK-LABEL: expected string not found in input
// CHECK-LABEL: Parsed rule defs/match for 'trivial'
                ^
<stdin>:1:1: note: scanning from here
llvm-tblgen: for the -d option: may not occur within a group!
^
<stdin>:3:11: note: possible intended match here
llvm-tblgen: Did you mean '-d'?
          ^
Dec 17 2019, 4:59 PM · Restricted Project
phosek added a comment to D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -<platform>_version_min flag.

I'm not sure if the detection is working correctly, this is failing on our macOS toolchain bots:

FAIL: Clang :: Driver/darwin-ld-platform-version-ios.c (5284 of 16450)
******************** TEST 'Clang :: Driver/darwin-ld-platform-version-ios.c' FAILED ********************
Script:
--
: 'RUN: at line 1';   touch /b/s/w/ir/k/recipe_cleanup/clangybBdXS/llvm_build_dir/tools/clang/test/Driver/Output/darwin-ld-platform-version-ios.c.tmp.o
: 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangybBdXS/llvm_build_dir/bin/clang -target arm64-apple-ios12.3 -isysroot /b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/iPhoneOS13.0.sdk -### /b/s/w/ir/k/recipe_cleanup/clangybBdXS/llvm_build_dir/tools/clang/test/Driver/Output/darwin-ld-platform-version-ios.c.tmp.o 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangybBdXS/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/darwin-ld-platform-version-ios.c
: 'RUN: at line 5';   /b/s/w/ir/k/recipe_cleanup/clangybBdXS/llvm_build_dir/bin/clang -target x86_64-apple-ios13-simulator -isysroot /b/s/w/ir/k/llvm-project/clang/test/Driver/Inputs/iPhoneOS13.0.sdk -### /b/s/w/ir/k/recipe_cleanup/clangybBdXS/llvm_build_dir/tools/clang/test/Driver/Output/darwin-ld-platform-version-ios.c.tmp.o 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangybBdXS/llvm_build_dir/bin/FileCheck --check-prefix=SIMUL /b/s/w/ir/k/llvm-project/clang/test/Driver/darwin-ld-platform-version-ios.c
--
Exit Code: 1
Dec 17 2019, 1:48 PM · Restricted Project, Restricted Project

Dec 16 2019

phosek accepted D71430: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps.

LGTM

Dec 16 2019, 12:34 PM · Restricted Project

Dec 14 2019

phosek added inline comments to D71430: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps.
Dec 14 2019, 7:49 AM · Restricted Project
phosek accepted D71429: [llvm] Add llvm-lipo dependency to runtimes.

LGTM

Dec 14 2019, 7:40 AM · Restricted Project
phosek accepted D71507: [perf-training] Make training data location configurable.

LGTM

Dec 14 2019, 7:04 AM · Restricted Project

Dec 12 2019

phosek accepted D71419: [clang] [test] Disable the test exhausting stack on NetBSD.

LGTM

Dec 12 2019, 12:25 PM · Restricted Project

Dec 11 2019

phosek added a comment to D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing..

We're seeing an assertion error in Clang when compiling compiler-rt builtins for aarch64-linux-gnu with this change:

Dec 11 2019, 6:49 AM · Restricted Project

Dec 6 2019

phosek committed rG1aa170238192: [libcxx{,abi}] Don't link libpthread and libdl on Fuchsia (authored by phosek).
[libcxx{,abi}] Don't link libpthread and libdl on Fuchsia
Dec 6 2019, 11:18 AM
phosek closed D71135: [cxx][cxxabi] Don't link libpthread and libdl on Fuchsia.
Dec 6 2019, 11:18 AM · Restricted Project
phosek created D71135: [cxx][cxxabi] Don't link libpthread and libdl on Fuchsia.
Dec 6 2019, 11:18 AM · Restricted Project

Dec 5 2019

phosek accepted D71081: gn build: Add support for building scudo and its unit tests..

LGTM

Dec 5 2019, 4:51 PM · Restricted Project
phosek accepted D71079: gn build: Bump Android API level to 29, and NDK to r21..

LGTM

Dec 5 2019, 4:51 PM · Restricted Project

Dec 4 2019

phosek committed rG00e436f1307f: [llvm-symbolizer] Support debug file lookup using build ID (authored by phosek).
[llvm-symbolizer] Support debug file lookup using build ID
Dec 4 2019, 3:18 PM
phosek closed D70759: [llvm-symbolizer] Support debug file lookup using build ID.
Dec 4 2019, 3:17 PM · Restricted Project
phosek updated the diff for D70759: [llvm-symbolizer] Support debug file lookup using build ID.
Dec 4 2019, 2:29 PM · Restricted Project
phosek updated the diff for D64378: [libcxx] Use C11 thread API on Fuchsia.
Dec 4 2019, 2:19 PM · Restricted Project
phosek updated the diff for D70759: [llvm-symbolizer] Support debug file lookup using build ID.
Dec 4 2019, 10:30 AM · Restricted Project

Dec 3 2019

phosek updated the diff for D70759: [llvm-symbolizer] Support debug file lookup using build ID.

Test added.

Dec 3 2019, 8:44 PM · Restricted Project
phosek committed rG9c3f9b9c12b0: [Clang] Define Fuchsia C++ABI (authored by phosek).
[Clang] Define Fuchsia C++ABI
Dec 3 2019, 6:46 PM
phosek closed D70575: [Clang] Define Fuchsia C++ABI.
Dec 3 2019, 6:45 PM · Restricted Project

Dec 2 2019

phosek added a comment to D53250: [ToolChain] Use default linker if the toolchain uses a custom one.

Sorry about the late response, I was mostly out last week. This recently came up again so I'd like to look into it but I'll have to rethink the change and come up with a better approach.

Dec 2 2019, 12:37 PM · Restricted Project
phosek accepted D70888: [libcxx{,abi}] Emit deplibs only when detected by CMake.

LGTM, thanks!

Dec 2 2019, 12:15 PM · Restricted Project

Nov 30 2019

phosek accepted D70868: [libunwind] Emit dependent libraries only when detected by CMake.

LGTM, thanks! Would it be possible to make the same change to libc++abi and libc++ as well (since they also use dependent library feature)?

Nov 30 2019, 7:31 PM · Restricted Project

Nov 28 2019

phosek added inline comments to D70815: Enable `-funwind-tables` flag when building libunwind.
Nov 28 2019, 2:31 PM · Restricted Project

Nov 26 2019

phosek committed rGf7aeca45b23c: [Fuchsia] Don't fail for unknown architectures (authored by phosek).
[Fuchsia] Don't fail for unknown architectures
Nov 26 2019, 7:20 PM
phosek closed D70747: [Fuchsia] Don't fail for unknown architectures.
Nov 26 2019, 7:20 PM · Restricted Project
phosek added a comment to D70759: [llvm-symbolizer] Support debug file lookup using build ID.

@rupprecht added the --fallback-debug-path option in rL353730 which is AFAIK used for similar purpose as --debug-file-directory, except that it supports only a single directory, whereas in our use case we'd like to support searching through multiple directories.

Nov 26 2019, 7:20 PM · Restricted Project
phosek created D70759: [llvm-symbolizer] Support debug file lookup using build ID.
Nov 26 2019, 7:13 PM · Restricted Project
phosek accepted D70693: [scan-build-py] Set of small fixes.

LGTM

Nov 26 2019, 3:09 PM · Restricted Project
phosek created D70747: [Fuchsia] Don't fail for unknown architectures.
Nov 26 2019, 3:00 PM · Restricted Project
phosek created D70744: [compiler-rt] Split the builtins CMake build to a separate file.
Nov 26 2019, 2:12 PM · Restricted Project, Restricted Project
phosek added a comment to D70744: [compiler-rt] Split the builtins CMake build to a separate file.

I assume that builtins and crt would be eventually moved to their own top-level directory (e.g. builtins or just compiler-rt) separate from sanitizers at which point this new CMakeLists.txt would become the root of that directory.

Nov 26 2019, 2:12 PM · Restricted Project, Restricted Project

Nov 24 2019

phosek added a comment to D70575: [Clang] Define Fuchsia C++ABI.

Could you add a test to show that with a fuchsia target we end up returning this from constructors + destructors and ensure that this ABI is used?

Nov 24 2019, 4:20 PM · Restricted Project
phosek updated the diff for D70575: [Clang] Define Fuchsia C++ABI.
Nov 24 2019, 4:20 PM · Restricted Project
phosek committed rGe8a4e5892bd8: [CMake] Use correct include path for InstrProfData.inc on Darwin (authored by phosek).
[CMake] Use correct include path for InstrProfData.inc on Darwin
Nov 24 2019, 1:30 PM

Nov 22 2019

phosek added a comment to D69740: [profile] Support counter relocation at runtime.
In D69740#1752348, @vsk wrote:

I think this looks good overall. The only high-level item that seems to be missing is Fuchsia testing -- are there any bots for this?

Nov 22 2019, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D69740: [profile] Support counter relocation at runtime.
Nov 22 2019, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D69740: [profile] Support counter relocation at runtime.
Nov 22 2019, 2:53 PM · Restricted Project, Restricted Project, Restricted Project