phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (163 w, 5 d)

Recent Activity

Today

phosek created D45997: [CMake] Pass additional CMake flags in Fuchsia cache files.
Mon, Apr 23, 5:17 PM

Fri, Apr 20

phosek added a comment to D45604: Support for multiarch runtimes layout.
In D45604#1068915, @rnk wrote:

The overall goal makes sense to me, but I feel like this patch adds many CMake variables to accomplish it, which are only set from the Fuchsia CMake cache. I feel like it would be simpler to have one CMake flag that clang and the runtime libraries look at to decide if they want to use the old libclang_rt.$arch.$lib paths, or the new clang/$version/$triple/lib/$lib paths.

In other words, we should aim to make the CMake cache scripts as simple as possible. Most developers (so far as I know) don't use the cache scripts to configure their local builds. They directly invoke LLVM's CMake, usually with a shell script with their favorite options. Ideally, changing the runtime library layout this way would be adding a simple flag to that script, rather than requiring developers to switch to these cache scripts or duplicating the logic of the cache scripts.

Fri, Apr 20, 10:48 AM

Thu, Apr 19

phosek committed rL330383: [Fuzzer] Add a missing header in Fuchsia implementation.
[Fuzzer] Add a missing header in Fuchsia implementation
Thu, Apr 19, 5:44 PM
phosek committed rCRT330383: [Fuzzer] Add a missing header in Fuchsia implementation.
[Fuzzer] Add a missing header in Fuchsia implementation
Thu, Apr 19, 5:44 PM
phosek closed D45852: [Fuzzer] Add a missing header in Fuchsia implementation.
Thu, Apr 19, 5:44 PM
phosek updated the summary of D45852: [Fuzzer] Add a missing header in Fuchsia implementation.
Thu, Apr 19, 5:32 PM
phosek created D45852: [Fuzzer] Add a missing header in Fuchsia implementation.
Thu, Apr 19, 5:32 PM
phosek committed rL330328: [Fuzzer] Make InterruptHandler non-blocking for Fuchsia.
[Fuzzer] Make InterruptHandler non-blocking for Fuchsia
Thu, Apr 19, 7:05 AM
phosek committed rCRT330328: [Fuzzer] Make InterruptHandler non-blocking for Fuchsia.
[Fuzzer] Make InterruptHandler non-blocking for Fuchsia
Thu, Apr 19, 7:05 AM
phosek closed D45636: Make InterruptHandler non-blocking for Fuchsia.
Thu, Apr 19, 7:04 AM

Tue, Apr 17

phosek accepted D45636: Make InterruptHandler non-blocking for Fuchsia.

LGTM, can you please upload a squashed patch?

Tue, Apr 17, 1:39 AM

Mon, Apr 16

phosek added inline comments to D45636: Make InterruptHandler non-blocking for Fuchsia.
Mon, Apr 16, 3:59 AM

Fri, Apr 13

phosek committed rCRT330075: [Fuzzer] Avoid C++ compiler checks for fuzzer C++ library.
[Fuzzer] Avoid C++ compiler checks for fuzzer C++ library
Fri, Apr 13, 4:08 PM
phosek committed rL330075: [Fuzzer] Avoid C++ compiler checks for fuzzer C++ library.
[Fuzzer] Avoid C++ compiler checks for fuzzer C++ library
Fri, Apr 13, 4:08 PM
phosek closed D45638: [Fuzzer] Avoid C++ compiler checks for fuzzer C++ library.
Fri, Apr 13, 4:08 PM
phosek added a reviewer for D45639: [Driver] Support default libc++ library location on Darwin: beanz.
Fri, Apr 13, 2:56 PM
phosek created D45639: [Driver] Support default libc++ library location on Darwin.
Fri, Apr 13, 2:56 PM
phosek created D45638: [Fuzzer] Avoid C++ compiler checks for fuzzer C++ library.
Fri, Apr 13, 2:42 PM

Thu, Apr 12

phosek committed rL329984: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia.
[CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia
Thu, Apr 12, 7:08 PM
phosek committed rC329984: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia.
[CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia
Thu, Apr 12, 7:08 PM
phosek closed D45511: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia.
Thu, Apr 12, 7:08 PM
phosek committed rCXX329983: [CMake] Set the default ABI version for Fuchsia in CMake as well.
[CMake] Set the default ABI version for Fuchsia in CMake as well
Thu, Apr 12, 7:03 PM
phosek committed rL329983: [CMake] Set the default ABI version for Fuchsia in CMake as well.
[CMake] Set the default ABI version for Fuchsia in CMake as well
Thu, Apr 12, 7:03 PM
phosek closed D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well.
Thu, Apr 12, 7:03 PM
phosek created D45604: Support for multiarch runtimes layout.
Thu, Apr 12, 6:47 PM
phosek added a comment to D45604: Support for multiarch runtimes layout.

Currently everything is a single patch but I'd be happy to split into separate patches and submit those separately against each subproject if you're fine with the overall design.

Thu, Apr 12, 6:47 PM
phosek added a comment to D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well.

OK, so we need to bump the SO version -- However I don't want to generate a site_config header because of that if the config header is sufficient. I would like to see a solution that takes that into account.

Thu, Apr 12, 3:23 PM
phosek updated the diff for D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well.

I had something similar in D45304 but Eric suggested removing it. What I haven't realized is that this value is also used to set the SOVERSION so it's indeed needed.

Thu, Apr 12, 2:17 PM

Wed, Apr 11

phosek added a comment to D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well.

ping?

Wed, Apr 11, 7:05 PM
phosek created D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well.
Wed, Apr 11, 10:25 AM

Tue, Apr 10

phosek created D45511: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia.
Tue, Apr 10, 10:42 PM
phosek committed rL329778: [CMake][runtimes] Process common options in runtimes build.
[CMake][runtimes] Process common options in runtimes build
Tue, Apr 10, 10:21 PM
phosek closed D45507: [CMake][runtimes] Process common options in runtimes build.
Tue, Apr 10, 10:21 PM
phosek committed rCXX329770: [libcxx] Set ABI version 2 as default for Fuchsia.
[libcxx] Set ABI version 2 as default for Fuchsia
Tue, Apr 10, 6:13 PM
phosek committed rL329770: [libcxx] Set ABI version 2 as default for Fuchsia.
[libcxx] Set ABI version 2 as default for Fuchsia
Tue, Apr 10, 6:09 PM
phosek closed D45304: [libcxx] Set ABI version 2 as default for Fuchsia.
Tue, Apr 10, 6:09 PM
phosek updated the diff for D45304: [libcxx] Set ABI version 2 as default for Fuchsia.
Tue, Apr 10, 5:31 PM
phosek updated the diff for D45304: [libcxx] Set ABI version 2 as default for Fuchsia.
Tue, Apr 10, 5:16 PM
phosek created D45507: [CMake][runtimes] Process common options in runtimes build.
Tue, Apr 10, 4:44 PM
phosek updated the summary of D45304: [libcxx] Set ABI version 2 as default for Fuchsia.
Tue, Apr 10, 4:31 PM
phosek committed rL329760: Revert "Handle the default case".
Revert "Handle the default case"
Tue, Apr 10, 2:33 PM
phosek committed rC329760: Revert "Handle the default case".
Revert "Handle the default case"
Tue, Apr 10, 2:33 PM
phosek committed rL329758: Handle the default case.
Handle the default case
Tue, Apr 10, 2:22 PM
phosek committed rC329758: Handle the default case.
Handle the default case
Tue, Apr 10, 2:22 PM
phosek created D45499: [Driver] Handle the default case.
Tue, Apr 10, 1:03 PM
phosek committed rC329748: [Driver] Allow drivers to add multiple libc++ include paths.
[Driver] Allow drivers to add multiple libc++ include paths
Tue, Apr 10, 12:59 PM
phosek committed rL329748: [Driver] Allow drivers to add multiple libc++ include paths.
[Driver] Allow drivers to add multiple libc++ include paths
Tue, Apr 10, 12:59 PM
phosek closed D45422: [Driver] Allow drivers to add multiple libc++ include paths.
Tue, Apr 10, 12:59 PM

Mon, Apr 9

phosek committed rCRT329672: [sanitizer] Enable threads for libc++ build used by the symbolizer.
[sanitizer] Enable threads for libc++ build used by the symbolizer
Mon, Apr 9, 10:58 PM
phosek committed rL329672: [sanitizer] Enable threads for libc++ build used by the symbolizer.
[sanitizer] Enable threads for libc++ build used by the symbolizer
Mon, Apr 9, 10:57 PM
phosek closed D45424: [sanitizer] Enable threads for libc++ build used by the symbolizer.
Mon, Apr 9, 10:57 PM
phosek added inline comments to D45424: [sanitizer] Enable threads for libc++ build used by the symbolizer.
Mon, Apr 9, 10:56 PM
phosek updated the diff for D45424: [sanitizer] Enable threads for libc++ build used by the symbolizer.
Mon, Apr 9, 10:54 PM
phosek added a comment to D45424: [sanitizer] Enable threads for libc++ build used by the symbolizer.

This was discovered after landing D44773 when the builder starting failing on this line: https://reviews.llvm.org/source/libcxx/browse/libcxx/trunk/include/atomic;329545$553

Mon, Apr 9, 12:43 AM
phosek created D45424: [sanitizer] Enable threads for libc++ build used by the symbolizer.
Mon, Apr 9, 12:42 AM

Sun, Apr 8

phosek committed rL329545: Revert "[CMake] Use custom command and target to install libc++ headers".
Revert "[CMake] Use custom command and target to install libc++ headers"
Sun, Apr 8, 9:41 PM
phosek committed rCXX329545: Revert "[CMake] Use custom command and target to install libc++ headers".
Revert "[CMake] Use custom command and target to install libc++ headers"
Sun, Apr 8, 9:41 PM
phosek committed rCXX329544: [CMake] Use custom command and target to install libc++ headers.
[CMake] Use custom command and target to install libc++ headers
Sun, Apr 8, 9:26 PM
phosek committed rL329544: [CMake] Use custom command and target to install libc++ headers.
[CMake] Use custom command and target to install libc++ headers
Sun, Apr 8, 9:26 PM
phosek closed D44773: [CMake] Use custom command and target to install libc++ headers.
Sun, Apr 8, 9:26 PM
phosek closed D44773: [CMake] Use custom command and target to install libc++ headers.
Sun, Apr 8, 9:26 PM
phosek updated the diff for D44773: [CMake] Use custom command and target to install libc++ headers.
Sun, Apr 8, 9:05 PM
phosek created D45422: [Driver] Allow drivers to add multiple libc++ include paths.
Sun, Apr 8, 8:53 PM

Fri, Apr 6

phosek updated the diff for D44773: [CMake] Use custom command and target to install libc++ headers.
Fri, Apr 6, 3:34 PM

Thu, Apr 5

phosek committed rL329366: CMake option to allow enabling experimental new pass manager by default.
CMake option to allow enabling experimental new pass manager by default
Thu, Apr 5, 5:56 PM
phosek committed rC329366: CMake option to allow enabling experimental new pass manager by default.
CMake option to allow enabling experimental new pass manager by default
Thu, Apr 5, 5:56 PM
phosek closed D44330: CMake option to allow enabling experimental new pass manager by default.
Thu, Apr 5, 5:56 PM

Wed, Apr 4

phosek created D45304: [libcxx] Set ABI version 2 as default for Fuchsia.
Wed, Apr 4, 5:11 PM
phosek added a comment to D45304: [libcxx] Set ABI version 2 as default for Fuchsia.

I don't like this but I'm not sure if there's a better way to do this, do you have any ideas?

Wed, Apr 4, 5:11 PM
phosek added a comment to D44330: CMake option to allow enabling experimental new pass manager by default.

Ping?

Wed, Apr 4, 3:58 PM
phosek committed rUNW329212: [CMake] Support for monorepo layout.
[CMake] Support for monorepo layout
Wed, Apr 4, 1:52 PM
phosek committed rCXXA329208: [CMake] Support for monorepo layout.
[CMake] Support for monorepo layout
Wed, Apr 4, 11:30 AM
phosek committed rL329212: [CMake] Support for monorepo layout.
[CMake] Support for monorepo layout
Wed, Apr 4, 11:01 AM
phosek closed D45270: [CMake] Support for monorepo layout.
Wed, Apr 4, 11:01 AM
phosek committed rL329208: [CMake] Support for monorepo layout.
[CMake] Support for monorepo layout
Wed, Apr 4, 10:44 AM
phosek closed D45269: [CMake] Support for monorepo layout.
Wed, Apr 4, 10:44 AM
phosek created D45270: [CMake] Support for monorepo layout.
Wed, Apr 4, 10:39 AM
phosek created D45269: [CMake] Support for monorepo layout.
Wed, Apr 4, 10:37 AM
phosek committed rL329205: [CMake] Support statically linked libc++abi and libunwind.
[CMake] Support statically linked libc++abi and libunwind
Wed, Apr 4, 9:30 AM
phosek committed rCRT329205: [CMake] Support statically linked libc++abi and libunwind.
[CMake] Support statically linked libc++abi and libunwind
Wed, Apr 4, 9:30 AM
phosek closed D45242: [compiler-rt] Support statically linked libc++abi and libunwind.
Wed, Apr 4, 9:30 AM

Tue, Apr 3

phosek created D45242: [compiler-rt] Support statically linked libc++abi and libunwind.
Tue, Apr 3, 8:45 PM

Mon, Apr 2

phosek added a comment to D44773: [CMake] Use custom command and target to install libc++ headers.

ping

Mon, Apr 2, 5:39 PM
phosek committed rC329032: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests.
[Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests
Mon, Apr 2, 4:42 PM
phosek committed rL329032: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests.
[Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests
Mon, Apr 2, 4:42 PM
phosek closed D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests.
Mon, Apr 2, 4:42 PM
phosek updated the diff for D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests.

Thanks for the suggestion, I don't think we even need to rename the function since this already matches the pattern other functions use.

Mon, Apr 2, 12:30 PM

Sun, Apr 1

phosek committed rL328950: [AArch64] Reserve x18 register on Fuchsia.
[AArch64] Reserve x18 register on Fuchsia
Sun, Apr 1, 4:47 PM
phosek closed D45105: [AArch64] Reserve x18 register on Fuchsia.
Sun, Apr 1, 4:47 PM

Sat, Mar 31

phosek created D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests.
Sat, Mar 31, 8:39 PM

Fri, Mar 30

phosek created D45105: [AArch64] Reserve x18 register on Fuchsia.
Fri, Mar 30, 12:52 PM

Tue, Mar 27

phosek committed rL328672: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers.
[Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers
Tue, Mar 27, 2:36 PM
phosek committed rC328672: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers.
[Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers
Tue, Mar 27, 2:36 PM
phosek closed D44947: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers.
Tue, Mar 27, 2:35 PM
phosek created D44947: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers.
Tue, Mar 27, 12:26 PM
phosek added inline comments to D44330: CMake option to allow enabling experimental new pass manager by default.
Tue, Mar 27, 12:19 PM

Mon, Mar 26

phosek accepted D44791: [scudo] Fuchsia minimal shared runtime.

LGTM

Mon, Mar 26, 3:03 PM
phosek added inline comments to D44791: [scudo] Fuchsia minimal shared runtime.
Mon, Mar 26, 12:23 PM
phosek added inline comments to D44791: [scudo] Fuchsia minimal shared runtime.
Mon, Mar 26, 12:23 PM

Sun, Mar 25

phosek added inline comments to D44791: [scudo] Fuchsia minimal shared runtime.
Sun, Mar 25, 11:33 PM