Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (236 w, 6 d)

Recent Activity

Yesterday

phosek committed rG39c5106eec79: Move DK_Misexpect for compatability with getNextAvailablePluginDiagnosticKind (authored by phosek).
Move DK_Misexpect for compatability with getNextAvailablePluginDiagnosticKind
Tue, Sep 17, 9:27 AM
phosek committed rL372136: Move DK_Misexpect for compatability with getNextAvailablePluginDiagnosticKind.
Move DK_Misexpect for compatability with getNextAvailablePluginDiagnosticKind
Tue, Sep 17, 9:26 AM
phosek closed D67648: Move DK_Misexpect for compatability with getNextAvailablePluginDiagnosticKind.
Tue, Sep 17, 9:26 AM · Restricted Project

Mon, Sep 16

phosek added a comment to D67628: [compiler-rt][crt] make test case nontrivial in check_cxx_section_exists.

Could we make the function non-trivial e.g. __attribute__((constructor)) void f() { asm volatile ("nop"::); } to ensure that it's not optimized out even at -O2?

Mon, Sep 16, 11:07 AM · Restricted Project, Restricted Project

Wed, Sep 11

phosek added a comment to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.

@dankm do you still plan to work on this? We would really like to see this landed and we could help if needed.

Wed, Sep 11, 4:18 PM · Restricted Project, Restricted Project
phosek created D67466: [libcxx] Annotate unique_lock and shared_lock with thread annotations.
Wed, Sep 11, 2:13 PM
phosek committed rG7bdad0842941: Reland "clang-misexpect: Profile Guided Validation of Performance Annotations… (authored by phosek).
Reland "clang-misexpect: Profile Guided Validation of Performance Annotations…
Wed, Sep 11, 9:22 AM
phosek committed rL371635: Reland "clang-misexpect: Profile Guided Validation of Performance Annotations….
Reland "clang-misexpect: Profile Guided Validation of Performance Annotations…
Wed, Sep 11, 9:22 AM
phosek closed D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Wed, Sep 11, 9:21 AM · Restricted Project, Restricted Project
phosek added inline comments to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Wed, Sep 11, 9:03 AM · Restricted Project, Restricted Project

Tue, Sep 10

phosek committed rG394a8ed8f1ad: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM (authored by phosek).
clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM
Tue, Sep 10, 6:11 PM
phosek committed rL371584: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM
Tue, Sep 10, 6:10 PM
phosek closed D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Tue, Sep 10, 6:10 PM · Restricted Project, Restricted Project
phosek committed rGc856eb0b76b4: Revert "Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds." (authored by phosek).
Revert "Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds."
Tue, Sep 10, 5:46 PM
phosek committed rL371579: Revert "Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds.".
Revert "Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds."
Tue, Sep 10, 5:45 PM
phosek added a comment to D67195: Adding support for overriding LLVM_ENABLE_RUNTIMES for runtimes builds..

I think I see the issue, if you look at LLVMExternalProjectUtils.cmake, it uses the following logic for PASSTHROUGH_PREFIXES:

Tue, Sep 10, 5:36 PM · Restricted Project

Mon, Sep 9

phosek committed rL371488: Revert "clang-misexpect: Profile Guided Validation of Performance Annotations….
Revert "clang-misexpect: Profile Guided Validation of Performance Annotations…
Mon, Sep 9, 11:25 PM
phosek committed rG7d1757aba808: Revert "clang-misexpect: Profile Guided Validation of Performance Annotations… (authored by phosek).
Revert "clang-misexpect: Profile Guided Validation of Performance Annotations…
Mon, Sep 9, 11:25 PM
phosek committed rGa10802fd73f9: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM (authored by phosek).
clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM
Mon, Sep 9, 8:14 PM
phosek committed rL371484: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM
Mon, Sep 9, 8:14 PM
phosek closed D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Mon, Sep 9, 8:13 PM · Restricted Project, Restricted Project

Sun, Sep 8

phosek added a comment to D59754: [Sema] Add c++2a designated initializer warnings.

Hi! We've noticed that for our arm bots, we're getting some flaky builds that sometimes fail with error: array designators are a C99 extension [-Werror,-Wc99-designator] and sometimes don't fail. 2 questions:

  1. I can't see it off the patch immediately, but do you know why for arm specifically we can only get this warning sometimes?
  2. I noticed that for the test/SemaCXX/c99.cpp test, this warning is also diagnosed for the -std=c++17 case. Are C-style designated initializers only invalid in c++20, or are they also invalid in 17?

    Thanks.
Sun, Sep 8, 2:40 PM · Restricted Project, Restricted Project

Fri, Aug 30

phosek accepted D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

Trying to start reviewing this.
The llvm side of the patch is self contained; clang patch should be split into a dependent review.

Looking at this, is it necessary to split up the patch? That will loose a lot of the previous comment/context, and I'd prefer to land this as a single change. Doing so has the benefit that if my patch needs to be reverted, it can be done all together. For example, if only the llvm patch is reverted, then it will likely cause other problems and make triage needlessly painful.

Fri, Aug 30, 3:00 PM · Restricted Project, Restricted Project
phosek committed rL370524: Request commit access for phosek.
Request commit access for phosek
Fri, Aug 30, 1:37 PM

Thu, Aug 29

phosek committed rG864fd44d8f9e: [CMake][Fuchsia] Enable experimental pass manager by default (authored by phosek).
[CMake][Fuchsia] Enable experimental pass manager by default
Thu, Aug 29, 4:14 PM
phosek committed rL370421: [CMake][Fuchsia] Enable experimental pass manager by default.
[CMake][Fuchsia] Enable experimental pass manager by default
Thu, Aug 29, 4:14 PM
phosek closed D58214: [CMake][Fuchsia] Enable experimental pass manager by default.
Thu, Aug 29, 4:14 PM · Restricted Project, Restricted Project
phosek accepted D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`.

LGTM

Thu, Aug 29, 4:07 PM · Restricted Project

Fri, Aug 23

phosek accepted D66681: [clang-doc] Bump BitcodeWriter max line number to 32U.

LGTM (small nit, people usually use PRXXX rather than bXXX to refer to issues)

Fri, Aug 23, 2:04 PM · Restricted Project, Restricted Project

Thu, Aug 22

phosek committed rG028b5499fffa: Revert "[GWP-ASan] Remove c++ standard lib dependency." (authored by phosek).
Revert "[GWP-ASan] Remove c++ standard lib dependency."
Thu, Aug 22, 12:05 AM
phosek committed rL369623: Revert "[GWP-ASan] Remove c++ standard lib dependency.".
Revert "[GWP-ASan] Remove c++ standard lib dependency."
Thu, Aug 22, 12:05 AM

Wed, Aug 21

phosek committed rG3dd225851991: [GWP-ASan] Remove c++ standard lib dependency. (authored by phosek).
[GWP-ASan] Remove c++ standard lib dependency.
Wed, Aug 21, 5:25 PM
phosek committed rL369606: [GWP-ASan] Remove c++ standard lib dependency..
[GWP-ASan] Remove c++ standard lib dependency.
Wed, Aug 21, 5:21 PM
phosek closed D66568: [GWP-ASan] Remove c++ standard lib dependency..
Wed, Aug 21, 5:21 PM · Restricted Project, Restricted Project
phosek accepted D66568: [GWP-ASan] Remove c++ standard lib dependency..

LGTM

Wed, Aug 21, 5:19 PM · Restricted Project, Restricted Project
phosek added a comment to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..

This seems to have broke our toolchain build, specifically the stage that (cross-)compiles runtimes for i386-linux-gnu:

[697/697] Linking CXX executable compiler-rt/lib/gwp_asan/stack_trace_compressor_fuzzer
FAILED: compiler-rt/lib/gwp_asan/stack_trace_compressor_fuzzer 
: && /b/s/w/ir/k/recipe_cleanup/clangB3DKrD/llvm_build_dir/./bin/clang++ --target=i386-unknown-linux-gnu --sysroot=/b/s/w/ir/k/cipd/linux-i386  -resource-dir=/b/s/w/ir/k/recipe_cleanup/clangB3DKrD/llvm_build_dir/tools/clang/stage2-bins/./lib/clang/10.0.0 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++14 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -fdebug-prefix-map=/b/s/w/ir/k/recipe_cleanup/clangB3DKrD/llvm_build_dir/tools/clang/stage2-bins/runtimes/runtimes-i386-unknown-linux-gnu-bins=../recipe_cleanup/clangB3DKrD/llvm_build_dir/tools/clang/stage2-bins/runtimes/runtimes-i386-unknown-linux-gnu-bins -fdebug-prefix-map=/b/s/w/ir/k/llvm-project/= -no-canonical-prefixes -Wall -std=c++14 -Wno-unused-parameter -O2 -g -DNDEBUG  -resource-dir=/b/s/w/ir/k/recipe_cleanup/clangB3DKrD/llvm_build_dir/tools/clang/stage2-bins/./lib/clang/10.0.0 -fuse-ld=lld -fuse-ld=lld -Wl,--color-diagnostics   -fsanitize=fuzzer compiler-rt/lib/gwp_asan/CMakeFiles/stack_trace_compressor_fuzzer.dir/stack_trace_compressor_fuzzer.cpp.o compiler-rt/lib/gwp_asan/CMakeFiles/stack_trace_compressor_fuzzer.dir/platform_specific/guarded_pool_allocator_posix.cpp.o compiler-rt/lib/gwp_asan/CMakeFiles/stack_trace_compressor_fuzzer.dir/platform_specific/mutex_posix.cpp.o compiler-rt/lib/gwp_asan/CMakeFiles/stack_trace_compressor_fuzzer.dir/guarded_pool_allocator.cpp.o compiler-rt/lib/gwp_asan/CMakeFiles/stack_trace_compressor_fuzzer.dir/random.cpp.o compiler-rt/lib/gwp_asan/CMakeFiles/stack_trace_compressor_fuzzer.dir/stack_trace_compressor.cpp.o  -o compiler-rt/lib/gwp_asan/stack_trace_compressor_fuzzer   && :
ld.lld: error: unable to find library -lc++
ld.lld: error: unable to find library -lc++
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
FAILED: runtimes/runtimes-i386-unknown-linux-gnu-stamps/runtimes-i386-unknown-linux-gnu-build

Is this supposed to be linking libc++?

Wed, Aug 21, 4:16 PM · Restricted Project, Restricted Project

Aug 19 2019

phosek added a comment to D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared.

I started seeing segfaults in some of our tests after the latests Clang roll and bisecting narrowed it down to this change. I also tried reverting this change locally and the segfaults no longer occur so I'm pretty confident it's this change. What's confusing is that it's not happening in regular Clang builds, it's only affecting GCC builds (we're using GCC 8.3) that are using libc++ and ASan builds. It's also don't see any of the modified functions on the stack which makes it even more confusing but I'm suspecting memory corruption that's happens earlier.

Aug 19 2019, 12:39 AM

Aug 16 2019

phosek committed rGedf504f5038b: [Fuchsia] Create the VMO during initialization, not during exit (authored by phosek).
[Fuchsia] Create the VMO during initialization, not during exit
Aug 16 2019, 5:55 PM
phosek committed rL369180: [Fuchsia] Create the VMO during initialization, not during exit.
[Fuchsia] Create the VMO during initialization, not during exit
Aug 16 2019, 5:55 PM
phosek closed D66323: [Fuchsia] Create the VMO during initialization, not during exit.
Aug 16 2019, 5:55 PM · Restricted Project, Restricted Project
phosek committed rG0b5ecef299fd: [llvm-readobj] Unwrap the value first to avoid the error (authored by phosek).
[llvm-readobj] Unwrap the value first to avoid the error
Aug 16 2019, 5:14 PM
phosek committed rL369177: [llvm-readobj] Unwrap the value first to avoid the error.
[llvm-readobj] Unwrap the value first to avoid the error
Aug 16 2019, 5:06 PM
phosek committed rG7da81b5e4d2b: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections (authored by phosek).
[llvm-readobj] Fallback to PT_NOTE if file doesn't have sections
Aug 16 2019, 4:16 PM
phosek committed rL369169: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
[llvm-readobj] Fallback to PT_NOTE if file doesn't have sections
Aug 16 2019, 4:15 PM
phosek closed D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
Aug 16 2019, 4:15 PM · Restricted Project
phosek updated the diff for D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.

It should reproduce now.

Aug 16 2019, 1:07 PM · Restricted Project
phosek created D66358: [llvm-readobj] Fallback to PT_NOTE if file doesn't have sections.
Aug 16 2019, 11:59 AM · Restricted Project

Aug 15 2019

phosek created D66323: [Fuchsia] Create the VMO during initialization, not during exit.
Aug 15 2019, 4:50 PM · Restricted Project, Restricted Project
phosek accepted D62315: [compiler-rt][crt] Pass -fno-lto in check_cxx_section_exists.

LGTM

Aug 15 2019, 11:23 AM · Restricted Project

Aug 14 2019

phosek accepted D66271: [CMake] Check for C++14 instead of C++11.

LGTM

Aug 14 2019, 9:33 PM · Restricted Project, Restricted Project
phosek accepted D64939: Add a proposal for a libc project under the LLVM umbrella..
Aug 14 2019, 4:17 PM · Restricted Project
phosek added inline comments to D64939: Add a proposal for a libc project under the LLVM umbrella..
Aug 14 2019, 2:52 PM · Restricted Project

Aug 7 2019

phosek added a comment to D63672: Added Delta IR Reduction Tool.

Hey Diego, generally patches should not be committed without explicit approval (once a patch is sent for review, it's assumed it needs some kind of completion/sign-off/approval before committing). This patch has now been submitted 3 times without approval being given, I think?

Also when recommitting a reverted patch, it's important to include information about how the reason for a revert has been addressed. Committing with no fix to the bug is not usually acceptable except in fairly narrow circumstances (where all other avenues to reproduce the failure have been exhausted - including asking other developers who reported the failure to help reproduce the issue (they might be able to give hints about particular architectures and other environmental issues, etc - and they can do so on their own timeline rather than being forced to dig the issue out because they sync'd up and hit your patch again)).

I'm so sorry, I will be more thorough before committing Diffs; I will ask around to see if I can find the cause of the broken builds

No worries (:

I'm /guessing/ it might have something to do with running the interestingness test script - I doubt there's anything else quite like that in-tree, so probably a fair few reasons it might not work, I'd guess?

Aug 7 2019, 4:26 PM · Restricted Project

Aug 6 2019

phosek committed rG989679c3711a: Reverts commit r368117, r368115 and r368112 (authored by phosek).
Reverts commit r368117, r368115 and r368112
Aug 6 2019, 10:20 PM
phosek added a comment to D63672: Added Delta IR Reduction Tool.

Reverted in rL368122.

Aug 6 2019, 10:20 PM · Restricted Project
phosek committed rL368122: Reverts commit r368117, r368115 and r368112.
Reverts commit r368117, r368115 and r368112
Aug 6 2019, 10:15 PM
phosek added a comment to D63672: Added Delta IR Reduction Tool.

We see a different test failure:

******************** TEST 'LLVM :: Reduce/remove-funcs.ll' FAILED ********************
Script:
--
: 'RUN: at line 4';   llvm-reduce --test /b/s/w/ir/k/llvm-project/llvm/test/Reduce/Inputs/remove-funcs.sh /b/s/w/ir/k/llvm-project/llvm/test/Reduce/remove-funcs.ll
: 'RUN: at line 5';   cat reduced.ll | /b/s/w/ir/k/recipe_cleanup/clangzMsUXi/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/llvm/test/Reduce/remove-funcs.ll
--
Exit Code: 1
Aug 6 2019, 7:48 PM · Restricted Project
phosek accepted D65838: [Driver] Use enumeration for quoting mode. NFC.

LGTM

Aug 6 2019, 6:47 PM · Restricted Project
phosek accepted D65824: Append an executable suffix to the toolchain tool paths on Windows platform..

LGTM

Aug 6 2019, 5:33 PM · Restricted Project
phosek added a comment to D65307: Appending COMPILER_RT_LIBCXX_PATH include path to -isystem for compiler-rt xray.

I see a lot of errors when building XRay against the just built libc++ in the runtimes build after this change landed:

/b/s/w/ir/k/recipe_cleanup/clang1YIxKp/llvm_build_dir/./bin/clang++ --target=aarch64-unknown-fuchsia --sysroot=/b/s/w/ir/k/cipd/sdk/arch/arm64/sysroot  -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/.. -I/b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/../../include -I/b/s/w/ir/k/cipd/sdk/pkg/fdio/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -ffunction-sections -fdata-sections -fdebug-prefix-map=/b/s/w/ir/k/recipe_cleanup/clang1YIxKp/llvm_build_dir/runtimes/runtimes-aarch64-unknown-fuchsia-bins=../recipe_cleanup/clang1YIxKp/llvm_build_dir/runtimes/runtimes-aarch64-unknown-fuchsia-bins -fdebug-prefix-map=/b/s/w/ir/k/llvm-project/= -no-canonical-prefixes -Wall -std=c++11 -Wno-unused-parameter -O2 -g    -UNDEBUG  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-non-virtual-dtor -isystem /b/s/w/ir/k/llvm-project/llvm/../libcxx/include -fno-rtti -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_init.cpp.obj -MF compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_init.cpp.obj.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.aarch64.dir/xray_init.cpp.obj -c /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/xray_init.cpp
In file included from /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/xray_init.cpp:21:
In file included from /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/xray_interface_internal.h:18:
In file included from /b/s/w/ir/k/llvm-project/compiler-rt/lib/xray/../../include/xray/xray_interface.h:18:
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:152:8: error: no member named 'int8_t' in the global namespace
using::int8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:153:8: error: no member named 'int16_t' in the global namespace
using::int16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:154:8: error: no member named 'int32_t' in the global namespace
using::int32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:155:8: error: no member named 'int64_t' in the global namespace
using::int64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:157:8: error: no member named 'uint8_t' in the global namespace
using::uint8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:158:8: error: no member named 'uint16_t' in the global namespace
using::uint16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:159:8: error: no member named 'uint32_t' in the global namespace
using::uint32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:160:8: error: no member named 'uint64_t' in the global namespace
using::uint64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:162:8: error: no member named 'int_least8_t' in the global namespace
using::int_least8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:163:8: error: no member named 'int_least16_t' in the global namespace
using::int_least16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:164:8: error: no member named 'int_least32_t' in the global namespace
using::int_least32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:165:8: error: no member named 'int_least64_t' in the global namespace
using::int_least64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:167:8: error: no member named 'uint_least8_t' in the global namespace
using::uint_least8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:168:8: error: no member named 'uint_least16_t' in the global namespace
using::uint_least16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:169:8: error: no member named 'uint_least32_t' in the global namespace
using::uint_least32_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:170:8: error: no member named 'uint_least64_t' in the global namespace
using::uint_least64_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:172:8: error: no member named 'int_fast8_t' in the global namespace
using::int_fast8_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:173:8: error: no member named 'int_fast16_t' in the global namespace
using::int_fast16_t;
     ~~^
/b/s/w/ir/k/llvm-project/llvm/../libcxx/include/cstdint:174:8: error: no member named 'int_fast32_t' in the global namespace
using::int_fast32_t;
     ~~^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.

See https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8905896666240143152 for a full log. IMHO this should be conditionalized on NOT HAVE_LIBCXX (which is set by the runtimes build). Can we please address this issue or revert this change?

Aug 6 2019, 12:46 AM · Restricted Project, Restricted Project

Aug 5 2019

phosek accepted D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

LGTM

Aug 5 2019, 10:28 PM · Restricted Project, Restricted Project
phosek accepted D64089: [Driver] Introduce -stdlib++-isystem.

LGTM

Aug 5 2019, 10:23 PM · Restricted Project, Restricted Project
phosek accepted D65767: gn build: Add AMDGPU target.

LGTM, the s/SystemOperands/SearchableTables/ change could land separately.

Aug 5 2019, 3:56 PM · Restricted Project
phosek accepted D65773: Build libfuzzer libcxx-static with PIC.

LGTM

Aug 5 2019, 3:52 PM · Restricted Project, Restricted Project
phosek added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

This looks reasonable to me; I'd prefer to clean up Clang's internal headers to be compatible with both FreeBSD's and musl's standard headers as suggested in http://lists.llvm.org/pipermail/llvm-dev/2019-August/134353.html, but I'm not sure how feasible or doable that is.

Aug 5 2019, 2:14 PM · Restricted Project, Restricted Project
phosek added a comment to D65430: Add `--dependency-files` option, which is equivalent to compiler option -MD..

My understanding is that many developers use makefile/ninja generation systems such as cmake rather than hand-write the file themselves. As such would this get much use unless it was integrated into these generators? May be worth approaching them to see if they have any requirements/observations about the option?

Having it integrated into e.g. cmake would be a great project for someone to take on, but for us (FreeBSD) it would be useful by itself. Our build is about 175K lines of hand-written Makefiles and we could plug it in with a small change in a couple of places. In any case we shouldn't hold up lld support waiting on prospective cmake changes IMO.

Ed, does ld.lld a.o -o /dev/null | sed 's/(.*//' | sort -u | sed '$!s/$/ \\/';} generate a usable Makefile fragment? I think the scenarios where people write Makefile are not very common now (think cmake/bazel/meson/scons/buck/...). Makefile and build.ninja are mostly used as an "assembly language". I think a dependency graph feature will be useful, but a Makefile fragment is probably not the best format. (I actually like Makefile more than the alternatives but I know the trend is that people are moving away from hand-written Makefile) At least it looks like the output can be easily generated from ld.lld -t output.

I mentioned Makefile because -MD was created with that usage in mind (at least originally), but I guess that file format can be understood by other build tools. Am I missing something? Even though some build tools can understand C/C++ file dependencies without using a compiler, there's still some languages that the build systems cannot read, but still they can read auto-generated Makefile-compatible dependency file, no?

Different build systems use different syntax :/

Some are represented as a function call, e.g. executable('main', 'main.c'). Some are cc_binary(name="main", srcs=["main.c"]). llvm has LLVMBuild.txt. A Makefile fragment cannot be consumed by any of the build systems ;-)

In a hand-written Makefile, a.d is usually used in the following pattern:

a.o a.d: a.c
  gcc -MD -c $<

-include a.d   # suppress the error if a.d does not exist

a.c has many direct and indirect includes, e.g. stdio.h, stddef.h, a.h.
When any of the dependency is updated, a.o will be considered stale and will get rebuilt next time make is executed.

-MD is useful in that it gives the information that isn't available before: we can't tell what files a.c includes.

In the ld.lld --write-dependencies= case, the dependencies (bitcode files, object files, shared objects, and archive members that get pulled out) are already known. If it isn't, we'll get a "undefined reference" error. So I don't know who will be the consumer of the dependency output.

Aug 5 2019, 12:07 PM · Restricted Project
phosek added a comment to D64378: [libcxx] Use C11 thread API on Fuchsia.

@EricWF friendly ping?

Aug 5 2019, 11:56 AM

Aug 4 2019

phosek committed rG1e4f2792faf1: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack (authored by phosek).
[Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
Aug 4 2019, 9:49 PM
phosek committed rL367799: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
[Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack
Aug 4 2019, 9:49 PM
phosek closed D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
Aug 4 2019, 9:49 PM · Restricted Project, Restricted Project
phosek updated the diff for D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
Aug 4 2019, 9:31 PM · Restricted Project, Restricted Project
phosek commandeered D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack.
Aug 4 2019, 9:31 PM · Restricted Project, Restricted Project
phosek committed rGbc3c2994033c: [Driver] Derive Fuchsia Linker directly from Tool (authored by phosek).
[Driver] Derive Fuchsia Linker directly from Tool
Aug 4 2019, 6:40 PM
phosek committed rL367797: [Driver] Derive Fuchsia Linker directly from Tool.
[Driver] Derive Fuchsia Linker directly from Tool
Aug 4 2019, 6:36 PM
phosek committed rG5b066a9d9045: [Driver] Always use -z separate-code with lld on Fuchsia (authored by phosek).
[Driver] Always use -z separate-code with lld on Fuchsia
Aug 4 2019, 6:16 PM
phosek committed rL367796: [Driver] Always use -z separate-code with lld on Fuchsia.
[Driver] Always use -z separate-code with lld on Fuchsia
Aug 4 2019, 6:15 PM
phosek committed rG85faa70e0470: [Driver] Support for disabling sanitizer runtime linking (authored by phosek).
[Driver] Support for disabling sanitizer runtime linking
Aug 4 2019, 3:28 PM
phosek committed rL367794: [Driver] Support for disabling sanitizer runtime linking.
[Driver] Support for disabling sanitizer runtime linking
Aug 4 2019, 3:28 PM
phosek closed D65029: [Driver] Support for disabling sanitizer runtime linking.
Aug 4 2019, 3:28 PM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.
Aug 4 2019, 1:59 PM · Restricted Project, Restricted Project
phosek updated the summary of D65029: [Driver] Support for disabling sanitizer runtime linking.
Aug 4 2019, 2:27 AM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.
Aug 4 2019, 2:27 AM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.

One more change, I went with -fsanitize-runtime and -fno-sanitize-runtime in the end which seems like the best fit.

Aug 4 2019, 1:37 AM · Restricted Project, Restricted Project
phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.

I've decided to go with the original -f[no-]sanitize-link-deps: -fsanitize-minimal-runtime is also a cc1 flag which affects codegen, -fshared-libsan and -fstatic-libsan are orthogonal, e.g. it's possible to have minimal shared or static runtime, so these really need to be different flags.

Aug 4 2019, 1:06 AM · Restricted Project, Restricted Project
phosek accepted D65703: Fix typo in GN build configuration.

LGTM

Aug 4 2019, 12:58 AM · Restricted Project

Aug 2 2019

phosek updated the diff for D65029: [Driver] Support for disabling sanitizer runtime linking.

I've updated the change and renamed the flag to -fsanitize-no-runtime although I'm not sure if it's necessarily better. I was thinking that ideal interface might be -fsanitize-runtime=(none|minimal|shared|static) which could also replace -fshared-libsan and -fstatic-libsan, but it'd be a breaking change so we might have to keep the existing flag and maybe print a deprecation warning. WDYT?

Aug 2 2019, 7:53 PM · Restricted Project, Restricted Project
phosek added inline comments to D65690: [clang-doc] Add index in each info html file.
Aug 2 2019, 6:32 PM · Restricted Project, Restricted Project

Aug 1 2019

phosek added a comment to D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager.

Looks like this change broke Profile/gcc-flag-compatibility.c test on macOS:

******************** TEST 'Clang :: Profile/gcc-flag-compatibility.c' FAILED ********************
Script:
--
: 'RUN: at line 10';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-GEN /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 11';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-GEN /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 16';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -c -S -o - -emit-llvm -fprofile-generate=/path/to -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefixes=PROFILE-GEN,PROFILE-GEN-EQ /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 22';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 23';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 24';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/default.profdata
: 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 26';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 30';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 31';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 32';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof
: 'RUN: at line 33';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 34';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -Xclang -disable-llvm-passes -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 39';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 40';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 41';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility_IR.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/default.profdata
: 'RUN: at line 42';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 43';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 47';   rm -rf /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir
: 'RUN: at line 48';   mkdir -p /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path
: 'RUN: at line 49';   llvm-profdata merge /b/s/w/ir/k/llvm-project/clang/test/Profile/Inputs/gcc-flag-compatibility_IR.proftext -o /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof
: 'RUN: at line 50';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fno-experimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
: 'RUN: at line 51';   /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/clang /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c -o - -emit-llvm -S -fprofile-use=/b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/tools/clang/test/Profile/Output/gcc-flag-compatibility.c.tmp.dir/some/path/file.prof -fexperimental-new-pass-manager | /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_dir/bin/FileCheck -check-prefix=PROFILE-USE-IR /b/s/w/ir/k/llvm-project/clang/test/Profile/gcc-flag-compatibility.c
--
Exit Code: 1
Aug 1 2019, 11:52 PM · Restricted Project
phosek abandoned D64711: [LTO] Don't override relocation model stored in the module.

This was addressed in rL366644.

Aug 1 2019, 6:47 PM · Restricted Project

Jul 31 2019

phosek accepted D65512: gn build: Fix redundant object files in builtin lib..

LGTM

Jul 31 2019, 9:09 AM · Restricted Project
phosek accepted D65518: gn build: Add build files for compiler-rt/lib/profile.

LGTM

Jul 31 2019, 9:00 AM · Restricted Project
phosek accepted D65513: gn build: Make builtin library build on macOS.

LGTM

Jul 31 2019, 8:56 AM · Restricted Project

Jul 30 2019

phosek added inline comments to D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings.
Jul 30 2019, 7:41 PM · Restricted Project
phosek added inline comments to D65430: Add `--dependency-files` option, which is equivalent to compiler option -MD..
Jul 30 2019, 6:40 PM · Restricted Project

Jul 27 2019

phosek added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

I made another fixup (similar to https://reviews.llvm.org/rL367176) here https://reviews.llvm.org/rL367182.

Can someone please take a look (a post-commit review) of https://reviews.llvm.org/rL367182 to verify that I did not misunderstand the intention with the test somehow?

Jul 27 2019, 1:47 PM · Restricted Project
phosek added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

phosek: In what config / on what bot?

Jul 27 2019, 1:18 PM · Restricted Project

Jul 26 2019

phosek added a comment to D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach.

We see test failures in as-options.s:

******************** TEST 'Clang :: Driver/as-options.s' FAILED ********************
Script:
--
: 'RUN: at line 3';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 7';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -I foo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 11';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 15';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target x86_64-linux-gnu -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -I foo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 21';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target aarch64-linux-gnu -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target aarch64-linux-gnu -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 29';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target armv7-linux-gnueabihf -c -no-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 33';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -target armv7-linux-gnueabihf -c -integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s    -Ifoo_dir -### 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 42';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mincremental-linker-compatible -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 45';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mincremental-linker-compatible -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 48';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mimplicit-it=always -target armv7-linux-gnueabi -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 51';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mimplicit-it=always -target armv7-linux-gnueabi -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 54';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mbig-obj -target i386-pc-windows -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 57';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mbig-obj -target i386-pc-windows -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 60';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Xassembler -mbig-obj -target i386-pc-windows -E    -o /dev/null -x c++ /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 63';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Xassembler -mbig-obj -target i386-pc-windows -E    -o /dev/null -x assembler-with-cpp /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 70';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mno-warn-deprecated -fno-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOERROR --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 76';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -Wa,-mno-warn-deprecated -fno-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 81';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mrelax-all -fintegrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=NOWARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
: 'RUN: at line 83';   /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/clang -mrelax-all -fno-integrated-as /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s -S 2>&1    | /b/s/w/ir/k/recipe_cleanup/clangrtoFQg/llvm_build_dir/bin/FileCheck --check-prefix=WARN --allow-empty /b/s/w/ir/k/llvm-project/clang/test/Driver/as-options.s
--
Exit Code: 1
Jul 26 2019, 10:31 PM · Restricted Project
phosek committed rG92a2e1bbb900: Revert "[ARM] Set default alignment to 64bits" (authored by phosek).
Revert "[ARM] Set default alignment to 64bits"
Jul 26 2019, 7:03 PM
phosek committed rL367166: Revert "[ARM] Set default alignment to 64bits".
Revert "[ARM] Set default alignment to 64bits"
Jul 26 2019, 6:59 PM
phosek added a comment to D65000: [ARM] Set default alignment to 64bits.

Reverted in rL367166.

Jul 26 2019, 6:59 PM · Restricted Project, Restricted Project