phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (175 w, 4 d)

Recent Activity

Yesterday

phosek committed rCXX337118: [CMake] Use correct variable as header install prefix.
[CMake] Use correct variable as header install prefix
Sat, Jul 14, 9:14 PM
phosek committed rL337118: [CMake] Use correct variable as header install prefix.
[CMake] Use correct variable as header install prefix
Sat, Jul 14, 9:14 PM
phosek closed D49345: [CMake] Use correct variable as header install prefix.
Sat, Jul 14, 9:14 PM
phosek added a comment to D49345: [CMake] Use correct variable as header install prefix.

Thank you!

Sat, Jul 14, 9:14 PM
phosek created D49346: [CMake] Use cxx-headers as a depedency for C++ headers.
Sat, Jul 14, 8:24 PM
phosek created D49345: [CMake] Use correct variable as header install prefix.
Sat, Jul 14, 8:23 PM
phosek committed rC337117: [CMake] Use libc++ and compiler-rt for sanitizers.
[CMake] Use libc++ and compiler-rt for sanitizers
Sat, Jul 14, 8:17 PM
phosek committed rL337117: [CMake] Use libc++ and compiler-rt for sanitizers.
[CMake] Use libc++ and compiler-rt for sanitizers
Sat, Jul 14, 8:16 PM
phosek closed D49331: [CMake] Use libc++ and compiler-rt for sanitizers.
Sat, Jul 14, 8:16 PM
phosek committed rCRT337116: [CMake] Change the flag to use compiler-rt builtins to boolean.
[CMake] Change the flag to use compiler-rt builtins to boolean
Sat, Jul 14, 8:13 PM
phosek committed rL337116: [CMake] Change the flag to use compiler-rt builtins to boolean.
[CMake] Change the flag to use compiler-rt builtins to boolean
Sat, Jul 14, 8:12 PM
phosek closed D49325: [CMake] Change the flag to use compiler-rt builtins to boolean.
Sat, Jul 14, 8:12 PM
phosek updated the diff for D49325: [CMake] Change the flag to use compiler-rt builtins to boolean.
Sat, Jul 14, 8:00 PM
phosek committed rL337115: [CMake] Pass CMAKE_INSTALL_DO_STRIP to external projects.
[CMake] Pass CMAKE_INSTALL_DO_STRIP to external projects
Sat, Jul 14, 7:17 PM
phosek closed D49335: [CMake] Pass CMAKE_INSTALL_DO_STRIP to external projects.
Sat, Jul 14, 7:17 PM

Fri, Jul 13

phosek created D49335: [CMake] Pass CMAKE_INSTALL_DO_STRIP to external projects.
Fri, Jul 13, 8:13 PM
phosek created D49332: [CMake] Check -ffreestanding as C not C++ flag.
Fri, Jul 13, 6:01 PM
phosek created D49331: [CMake] Use libc++ and compiler-rt for sanitizers.
Fri, Jul 13, 5:27 PM
phosek added inline comments to D49325: [CMake] Change the flag to use compiler-rt builtins to boolean.
Fri, Jul 13, 3:30 PM
phosek created D49325: [CMake] Change the flag to use compiler-rt builtins to boolean.
Fri, Jul 13, 3:28 PM
phosek committed rL337039: Revert "[CMake] Pass Clang defaults to runtimes builds".
Revert "[CMake] Pass Clang defaults to runtimes builds"
Fri, Jul 13, 1:07 PM
phosek committed rL337033: [CMake] Don't use CLANG_DEFAULT_* values.
[CMake] Don't use CLANG_DEFAULT_* values
Fri, Jul 13, 12:21 PM
phosek committed rCRT337033: [CMake] Don't use CLANG_DEFAULT_* values.
[CMake] Don't use CLANG_DEFAULT_* values
Fri, Jul 13, 12:21 PM
phosek closed D49272: [CMake] Don't use CLANG_DEFAULT_* values.
Fri, Jul 13, 12:21 PM

Thu, Jul 12

phosek created D49272: [CMake] Don't use CLANG_DEFAULT_* values.
Thu, Jul 12, 4:05 PM

Wed, Jul 11

phosek updated the diff for D47208: [profile] Support profiling runtime on Fuchsia.
Wed, Jul 11, 5:30 PM
phosek updated the diff for D47208: [profile] Support profiling runtime on Fuchsia.
Wed, Jul 11, 5:29 PM
phosek updated the diff for D47208: [profile] Support profiling runtime on Fuchsia.
Wed, Jul 11, 5:28 PM
phosek added a reviewer for D47208: [profile] Support profiling runtime on Fuchsia: jakehehrlich.
Wed, Jul 11, 2:56 PM
phosek added inline comments to D47208: [profile] Support profiling runtime on Fuchsia.
Wed, Jul 11, 2:56 PM
phosek updated the diff for D47208: [profile] Support profiling runtime on Fuchsia.
Wed, Jul 11, 2:55 PM

Tue, Jul 10

phosek accepted D49157: Add libcxxabi option back for sanitizer use..

LGTM

Tue, Jul 10, 3:50 PM
phosek committed rUNW336713: [CMake] Set per-runtime library directory suffix in runtimes build.
[CMake] Set per-runtime library directory suffix in runtimes build
Tue, Jul 10, 12:37 PM
phosek committed rCXXA336713: [CMake] Set per-runtime library directory suffix in runtimes build.
[CMake] Set per-runtime library directory suffix in runtimes build
Tue, Jul 10, 12:35 PM
phosek committed rCXX336713: [CMake] Set per-runtime library directory suffix in runtimes build.
[CMake] Set per-runtime library directory suffix in runtimes build
Tue, Jul 10, 12:18 PM
phosek committed rL336713: [CMake] Set per-runtime library directory suffix in runtimes build.
[CMake] Set per-runtime library directory suffix in runtimes build
Tue, Jul 10, 12:18 PM
phosek closed D49121: [CMake] Set per-runtime library directory suffix in runtimes build.
Tue, Jul 10, 12:18 PM
phosek updated the diff for D49121: [CMake] Set per-runtime library directory suffix in runtimes build.
Tue, Jul 10, 11:54 AM

Mon, Jul 9

phosek created D49121: [CMake] Set per-runtime library directory suffix in runtimes build.
Mon, Jul 9, 7:12 PM

Thu, Jun 28

phosek committed rL335919: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain.
[CMake] Don't build Linux targets on Darwin in Fuchsia toolchain
Thu, Jun 28, 1:38 PM
phosek committed rC335919: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain.
[CMake] Don't build Linux targets on Darwin in Fuchsia toolchain
Thu, Jun 28, 1:38 PM
phosek closed D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain.
Thu, Jun 28, 1:38 PM
phosek committed rL335917: [CMake] Build static runtimes for host in Fuchsia first stage.
[CMake] Build static runtimes for host in Fuchsia first stage
Thu, Jun 28, 1:24 PM
phosek committed rC335917: [CMake] Build static runtimes for host in Fuchsia first stage.
[CMake] Build static runtimes for host in Fuchsia first stage
Thu, Jun 28, 1:24 PM
phosek closed D48707: [CMake] Disable per-target runtimes for the first stage Fuchsia build.
Thu, Jun 28, 1:24 PM
phosek added reviewers for D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain: jakehehrlich, juliehockett.
Thu, Jun 28, 10:44 AM
phosek created D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain.
Thu, Jun 28, 2:05 AM
phosek added a comment to D48701: [CMake] Rename cxx_headers back to cxx-headers..

It's not obvious to me how anything could depend on cxx-headers target (not the component) since that target did not exist until r334468 which has landed only recently (just before r334477). The motivation behind this change was just consistency since all other targets in libc++ use underscores rather than dashes, so reverting that change is fine with me if it's breaking you.

Thu, Jun 28, 2:00 AM
phosek accepted D48700: [CMake] Make bootstrap and compiler-rt depend on cxx-headers..

LGTM

Thu, Jun 28, 2:00 AM
phosek accepted D48701: [CMake] Rename cxx_headers back to cxx-headers..

LGTM

Thu, Jun 28, 1:40 AM
phosek updated the diff for D48707: [CMake] Disable per-target runtimes for the first stage Fuchsia build.
Thu, Jun 28, 1:39 AM

Wed, Jun 27

phosek created D48707: [CMake] Disable per-target runtimes for the first stage Fuchsia build.
Wed, Jun 27, 11:59 PM
phosek committed rL335812: [CMake] Use explicit targets for building Linux runtimes.
[CMake] Use explicit targets for building Linux runtimes
Wed, Jun 27, 10:20 PM
phosek committed rC335812: [CMake] Use explicit targets for building Linux runtimes.
[CMake] Use explicit targets for building Linux runtimes
Wed, Jun 27, 10:20 PM
phosek closed D48563: [CMake] Use explicit targets for building Linux runtimes.
Wed, Jun 27, 10:20 PM
phosek committed rC335810: Handle both Linux and Windows path separator for the resource dir.
Handle both Linux and Windows path separator for the resource dir
Wed, Jun 27, 8:59 PM
phosek committed rL335810: Handle both Linux and Windows path separator for the resource dir.
Handle both Linux and Windows path separator for the resource dir
Wed, Jun 27, 8:58 PM
phosek committed rCXXA335809: Support for multiarch runtimes layout.
Support for multiarch runtimes layout
Wed, Jun 27, 8:38 PM
phosek committed rUNW335809: Support for multiarch runtimes layout.
Support for multiarch runtimes layout
Wed, Jun 27, 8:31 PM
phosek committed rCXX335809: Support for multiarch runtimes layout.
Support for multiarch runtimes layout
Wed, Jun 27, 8:17 PM
phosek committed rC335809: Support for multiarch runtimes layout.
Support for multiarch runtimes layout
Wed, Jun 27, 8:17 PM
phosek committed rL335809: Support for multiarch runtimes layout.
Support for multiarch runtimes layout
Wed, Jun 27, 8:16 PM
phosek committed rCRT335809: Support for multiarch runtimes layout.
Support for multiarch runtimes layout
Wed, Jun 27, 8:16 PM
phosek closed D45604: Support for multiarch runtimes layout.
Wed, Jun 27, 8:16 PM
phosek updated the diff for D45604: Support for multiarch runtimes layout.
Wed, Jun 27, 7:14 PM
phosek updated the diff for D45604: Support for multiarch runtimes layout.
Wed, Jun 27, 2:38 PM
phosek committed rL335790: [sanitizer] zx_cprng_draw no longer returns any value.
[sanitizer] zx_cprng_draw no longer returns any value
Wed, Jun 27, 2:30 PM
phosek committed rCRT335790: [sanitizer] zx_cprng_draw no longer returns any value.
[sanitizer] zx_cprng_draw no longer returns any value
Wed, Jun 27, 2:30 PM
phosek closed D48671: [sanitizer] zx_cprng_draw no longer returns any value.
Wed, Jun 27, 2:30 PM
phosek closed D48671: [sanitizer] zx_cprng_draw no longer returns any value.
Wed, Jun 27, 2:30 PM
phosek created D48671: [sanitizer] zx_cprng_draw no longer returns any value.
Wed, Jun 27, 2:13 PM
phosek committed rCRT335755: [sanitizer] zx_cprng_draw no longer takes the output argument.
[sanitizer] zx_cprng_draw no longer takes the output argument
Wed, Jun 27, 9:54 AM
phosek committed rL335755: [sanitizer] zx_cprng_draw no longer takes the output argument.
[sanitizer] zx_cprng_draw no longer takes the output argument
Wed, Jun 27, 9:54 AM
phosek closed D48657: [sanitizer] zx_cprng_draw no longer takes the output argument.
Wed, Jun 27, 9:54 AM
phosek created D48657: [sanitizer] zx_cprng_draw no longer takes the output argument.
Wed, Jun 27, 9:52 AM

Tue, Jun 26

phosek committed rC335708: [CMake] Support passing FUCHSIA_SDK as the only variable.
[CMake] Support passing FUCHSIA_SDK as the only variable
Tue, Jun 26, 10:55 PM
phosek committed rL335708: [CMake] Support passing FUCHSIA_SDK as the only variable.
[CMake] Support passing FUCHSIA_SDK as the only variable
Tue, Jun 26, 10:55 PM
phosek closed D48564: [CMake] Support passing FUCHSIA_SDK as the only variable.
Tue, Jun 26, 10:55 PM
phosek committed rC335704: [CMake] Provide direct support for building sanitized runtimes.
[CMake] Provide direct support for building sanitized runtimes
Tue, Jun 26, 8:40 PM
phosek committed rL335704: [CMake] Provide direct support for building sanitized runtimes.
[CMake] Provide direct support for building sanitized runtimes
Tue, Jun 26, 8:40 PM
phosek closed D48061: [CMake] Provide direct support for building sanitized runtimes.
Tue, Jun 26, 8:40 PM
phosek added inline comments to D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2..
Tue, Jun 26, 8:35 PM
phosek committed rL335703: [CMake] Use variables rather than ":" delimiters.
[CMake] Use variables rather than ":" delimiters
Tue, Jun 26, 8:19 PM
phosek closed D37644: [CMake][runtimes] Use variables rather than ":" delimiters.
Tue, Jun 26, 8:19 PM
phosek added a comment to D45604: Support for multiarch runtimes layout.

Should ENABLE_PER_TARGET_RUNTIME_DIR be declared at LLVM's top level CMakeLists.txt? If I read the patch correctly, it's in clang so llvm/runtimes/ relies on the default value being OFF (hard to tell because the patch doesn't follow the current layout of the SVN repository but rather a git monorepo?)

Tue, Jun 26, 7:37 PM
phosek added inline comments to D48580: [AArch64] Support reserving x1-7 registers..
Tue, Jun 26, 2:53 PM

Mon, Jun 25

phosek added inline comments to D48509: Improve crash unwinding on Fuchsia.
Mon, Jun 25, 5:51 PM
phosek created D48564: [CMake] Support passing FUCHSIA_SDK as the only variable.
Mon, Jun 25, 1:25 PM
phosek created D48563: [CMake] Use explicit targets for building Linux runtimes.
Mon, Jun 25, 1:10 PM
phosek added a comment to D48061: [CMake] Provide direct support for building sanitized runtimes.

Ping?

Mon, Jun 25, 12:55 PM
phosek added inline comments to D37644: [CMake][runtimes] Use variables rather than ":" delimiters.
Mon, Jun 25, 12:55 PM
phosek added a comment to D48422: [CMake] Add compiler-rt header files to the list of sources for targets when building with an IDE.

Personally, I'd prefer to spell out all the headers explicitly rather than using globing which is more error-prone to future changes. I also agree with @kubamracek's comment about using crt (which may be also mistaken for crt*.o) to compiler_rt.

Mon, Jun 25, 12:48 PM
phosek added a comment to D47169: [CMake] Use a different source depending on C++ support.

The messages seem to be on llvm-commits (http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180528/557038.html and http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180611/thread.html#559742), but in any case you should have received a direct notification from Phabricator. Maybe you might want to check your filters?

Mon, Jun 25, 1:04 AM

Sun, Jun 24

phosek added a comment to D47169: [CMake] Use a different source depending on C++ support.

Due to the lack of replies, I've reverted this change in rL334903 to unbreak my build. Feel free to submit a patch that doesn't regress the build system, thanks.

Sun, Jun 24, 6:03 PM

Fri, Jun 22

phosek committed rC335410: [Fuchsia] Enable static libc++, libc++abi, libunwind.
[Fuchsia] Enable static libc++, libc++abi, libunwind
Fri, Jun 22, 8:20 PM
phosek committed rL335410: [Fuchsia] Enable static libc++, libc++abi, libunwind.
[Fuchsia] Enable static libc++, libc++abi, libunwind
Fri, Jun 22, 8:19 PM
phosek closed D48208: [Fuchsia] Enable static libc++, libc++abi, libunwind.
Fri, Jun 22, 8:19 PM
phosek updated the diff for D48208: [Fuchsia] Enable static libc++, libc++abi, libunwind.
Fri, Jun 22, 8:07 PM

Mon, Jun 18

phosek committed rL334928: [Fuzzer] Set an explicit libc++ dependency when needed.
[Fuzzer] Set an explicit libc++ dependency when needed
Mon, Jun 18, 1:06 AM
phosek committed rCRT334928: [Fuzzer] Set an explicit libc++ dependency when needed.
[Fuzzer] Set an explicit libc++ dependency when needed
Mon, Jun 18, 1:06 AM