Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (219 w, 3 d)

Recent Activity

Yesterday

phosek committed rCRT361111: Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Use CMAKE_C_COMPILER_ARG1 in compiler invocation
Sat, May 18, 8:33 PM
phosek committed rGcd78209a3510: Use CMAKE_C_COMPILER_ARG1 in compiler invocation (authored by phosek).
Use CMAKE_C_COMPILER_ARG1 in compiler invocation
Sat, May 18, 8:33 PM
phosek committed rL361111: Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Use CMAKE_C_COMPILER_ARG1 in compiler invocation
Sat, May 18, 8:27 PM
phosek closed D62104: [crt] Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Sat, May 18, 8:27 PM · Restricted Project, Restricted Project
phosek created D62104: [crt] Use CMAKE_C_COMPILER_ARG1 in compiler invocation.
Sat, May 18, 8:20 PM · Restricted Project, Restricted Project
phosek abandoned D62039: [GWP-ASan] Add missing dependency on C++ headers.

No longer needed since D62048 has landed.

Sat, May 18, 2:40 PM · Restricted Project, Restricted Project

Fri, May 17

phosek added a comment to D38479: Make -mgeneral-regs-only more like GCC's.

We (Fuchsia) would like to see this landed as well so we can start using this in our kernel.

Fri, May 17, 7:55 PM
phosek created D62090: [libcxx][libunwind] Support ELF dependent libraries feature on Linux.
Fri, May 17, 4:46 PM · Restricted Project

Thu, May 16

phosek committed rG61ed46c737a8: [Bugpoint] Only run plugins tests if plugins are enabled (authored by phosek).
[Bugpoint] Only run plugins tests if plugins are enabled
Thu, May 16, 11:39 PM
phosek committed rL360993: [Bugpoint] Only run plugins tests if plugins are enabled.
[Bugpoint] Only run plugins tests if plugins are enabled
Thu, May 16, 11:38 PM
phosek committed rGb7804ef3a746: [Analysis] Only run plugins tests if plugins are actually enabled (authored by phosek).
[Analysis] Only run plugins tests if plugins are actually enabled
Thu, May 16, 11:06 PM
phosek committed rC360991: [Analysis] Only run plugins tests if plugins are actually enabled.
[Analysis] Only run plugins tests if plugins are actually enabled
Thu, May 16, 11:05 PM
phosek committed rL360991: [Analysis] Only run plugins tests if plugins are actually enabled.
[Analysis] Only run plugins tests if plugins are actually enabled
Thu, May 16, 11:05 PM
phosek closed D62050: [Analysis] Only run plugins tests if plugins are actually enabled.
Thu, May 16, 11:05 PM · Restricted Project, Restricted Project
phosek added a comment to D60274: [ELF] Implement Dependent Libraries Feature.

@bd1976llvm do you plan on landing this? We'd really like to start using this feature.

Thu, May 16, 7:20 PM · Restricted Project
phosek accepted D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..

LGTM, would it be possible to land this?

Thu, May 16, 7:17 PM · Restricted Project, Restricted Project
phosek created D62050: [Analysis] Only run plugins tests if plugins are actually enabled.
Thu, May 16, 6:50 PM · Restricted Project, Restricted Project
phosek added a comment to D59464: [analyzer] Add an example plugin for checker dependency handling.

In that case, feel free to revert this. If around 11:00 CET time I tried to recommit with a possible fix (while watching your bots), would that be an issue?

Thu, May 16, 4:03 PM · Restricted Project, Restricted Project
phosek added inline comments to D59464: [analyzer] Add an example plugin for checker dependency handling.
Thu, May 16, 3:41 PM · Restricted Project, Restricted Project
phosek created D62039: [GWP-ASan] Add missing dependency on C++ headers.
Thu, May 16, 3:33 PM · Restricted Project, Restricted Project
phosek added a comment to D59464: [analyzer] Add an example plugin for checker dependency handling.
In D59464#1505463, @NoQ wrote:

Can we have a full build log?

Thu, May 16, 2:49 PM · Restricted Project, Restricted Project
phosek added a comment to D59464: [analyzer] Add an example plugin for checker dependency handling.

I started to land other patches as well that depend on this one -- I won't object, but I'd prefer to find a solution, mostly because I don't even know how I could reproduce this error. The thing is, I merely moved some files from one directory to the other, which makes me scratch my head even more. That being said -- (see inlines)

Thu, May 16, 1:47 PM · Restricted Project, Restricted Project
phosek added a comment to D59464: [analyzer] Add an example plugin for checker dependency handling.

All our bots are failing which seems to have been caused by the latest reland:

FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793)
******************** TEST 'Clang :: Analysis/checker-plugins.c' FAILED ********************
Script:
--
: 'RUN: at line 1';   /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range -verify /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c    -load /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/SampleAnalyzerPlugin.so    -analyzer-checker='example.MainCallChecker'
: 'RUN: at line 15';   /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c    -load /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/CheckerDependencyHandlingAnalyzerPlugin.so   -analyzer-checker=example.DependendentChecker    -analyzer-list-enabled-checkers    2>&1 | /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c -check-prefix=CHECK-IMPLICITLY-ENABLED
: 'RUN: at line 24';   /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c    -load /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/CheckerDependencyHandlingAnalyzerPlugin.so   -analyzer-checker=example.DependendentChecker    -analyzer-disable-checker=example.Dependency    -analyzer-list-enabled-checkers    2>&1 | /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c -check-prefix=CHECK-IMPLICITLY-DISABLED
--
Exit Code: 1
Thu, May 16, 11:43 AM · Restricted Project, Restricted Project

Tue, May 14

phosek created D61919: [builtins] Deduplicate __eqsf2 and __gtsf2.
Tue, May 14, 2:47 PM · Restricted Project, Restricted Project

Fri, May 10

phosek committed rGfc86c7fca313: [crt] Use -std=c11 for crtbegin.o/crtend.o (authored by phosek).
[crt] Use -std=c11 for crtbegin.o/crtend.o
Fri, May 10, 12:23 PM
phosek committed rCRT360459: [crt] Use -std=c11 for crtbegin.o/crtend.o.
[crt] Use -std=c11 for crtbegin.o/crtend.o
Fri, May 10, 12:23 PM
phosek committed rL360459: [crt] Use -std=c11 for crtbegin.o/crtend.o.
[crt] Use -std=c11 for crtbegin.o/crtend.o
Fri, May 10, 12:22 PM
phosek closed D61797: [crt] Use -std=c11 for crtbegin.o/crtend.o.
Fri, May 10, 12:22 PM · Restricted Project, Restricted Project
phosek added a comment to D61797: [crt] Use -std=c11 for crtbegin.o/crtend.o.

lgtm, but shouldn't we set this globally for all projects?

Fri, May 10, 12:17 PM · Restricted Project, Restricted Project
phosek updated the diff for D61797: [crt] Use -std=c11 for crtbegin.o/crtend.o.
Fri, May 10, 12:16 PM · Restricted Project, Restricted Project
phosek created D61797: [crt] Use -std=c11 for crtbegin.o/crtend.o.
Fri, May 10, 11:57 AM · Restricted Project, Restricted Project

Thu, May 9

phosek committed rG4fa4df9cdce7: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic (authored by phosek).
[compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic
Thu, May 9, 4:42 PM
phosek committed rCRT360394: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
[compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic
Thu, May 9, 4:42 PM
phosek committed rL360394: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
[compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic
Thu, May 9, 4:42 PM
phosek closed D61768: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
Thu, May 9, 4:41 PM · Restricted Project, Restricted Project
phosek updated the diff for D61768: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
Thu, May 9, 4:41 PM · Restricted Project, Restricted Project
phosek updated the diff for D61768: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
Thu, May 9, 4:31 PM · Restricted Project, Restricted Project
phosek created D61768: [compiler-rt] Migrate to _zx_clock_get_new/_zx_clock_get_monotonic.
Thu, May 9, 4:07 PM · Restricted Project, Restricted Project

Wed, May 8

phosek added inline comments to D61709: [NewPM] Port HWASan and Kernel HWASan.
Wed, May 8, 11:24 PM · Restricted Project, Restricted Project
phosek committed rG366cda03a89c: [NewPM] Setup Passes for KASan and KMSan (authored by phosek).
[NewPM] Setup Passes for KASan and KMSan
Wed, May 8, 11:09 PM
phosek committed rL360313: [NewPM] Setup Passes for KASan and KMSan.
[NewPM] Setup Passes for KASan and KMSan
Wed, May 8, 11:08 PM
phosek committed rC360313: [NewPM] Setup Passes for KASan and KMSan.
[NewPM] Setup Passes for KASan and KMSan
Wed, May 8, 11:08 PM
phosek closed D61664: [NewPM] Setup Passes for KASan and KMSan.
Wed, May 8, 11:08 PM · Restricted Project, Restricted Project
phosek added a comment to D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.

This change broke our build which is using Clang and the x86_64-windows-msvc target to cross-compile our EFI bootloader. Now the compilation fails because it cannot find Windows headers (as expected). We're probably going to work around the issue by setting -U_MSC_VER, but I'm going to start a discussion whether we should maybe define a new target for EFI.

Wed, May 8, 2:41 PM · Restricted Project

Tue, May 7

phosek created D61664: [NewPM] Setup Passes for KASan and KMSan.
Tue, May 7, 8:00 PM · Restricted Project, Restricted Project

Mon, May 6

phosek committed rG5f2e10e9c325: [Clang][NewPM] Don't bail out if the target machine is empty (authored by phosek).
[Clang][NewPM] Don't bail out if the target machine is empty
Mon, May 6, 4:23 PM
phosek committed rL360100: [Clang][NewPM] Don't bail out if the target machine is empty.
[Clang][NewPM] Don't bail out if the target machine is empty
Mon, May 6, 4:23 PM
phosek committed rC360100: [Clang][NewPM] Don't bail out if the target machine is empty.
[Clang][NewPM] Don't bail out if the target machine is empty
Mon, May 6, 4:23 PM
phosek closed D58374: [Clang][NewPM] Don't bail out if the target machine is empty.
Mon, May 6, 4:22 PM · Restricted Project
phosek accepted D61510: [SanitizerCoverage] Use different module ctor names for trace-pc-guard and inline-8bit-counters.

LGTM but you may want to wait for @kcc @morehouse @vitalybuka to take a look as well since they're the owners.

Mon, May 6, 3:59 PM · Restricted Project
phosek accepted D61541: [compiler-rt] Create install targets for Darwin libraries.

LGTM

Mon, May 6, 3:53 PM · Restricted Project, Restricted Project
phosek added a comment to D49587: [CMake] Support exporting runtimes using the CMake export.

Seems like you got the wrong diff.

Mon, May 6, 3:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D49587: [CMake] Support exporting runtimes using the CMake export.
Mon, May 6, 3:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sun, May 5

phosek committed rCXXA360004: [libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining….
[libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining…
Sun, May 5, 6:26 PM
phosek committed rG6971a166d910: [libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining… (authored by phosek).
[libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining…
Sun, May 5, 6:25 PM
phosek committed rCXX360003: [libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them.
[libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them
Sun, May 5, 6:24 PM
phosek committed rL360004: [libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining….
[libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining…
Sun, May 5, 6:24 PM
phosek closed D61572: [libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining them.
Sun, May 5, 6:24 PM · Restricted Project, Restricted Project
phosek committed rG741f52ca627e: [libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them (authored by phosek).
[libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them
Sun, May 5, 6:21 PM
phosek committed rL360003: [libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them.
[libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them
Sun, May 5, 6:21 PM
phosek closed D61571: [libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them.
Sun, May 5, 6:21 PM · Restricted Project, Restricted Project
phosek accepted D61571: [libcxx] Don't use -fvisibility-global-new-delete-hidden when not defining them.

LGTM

Sun, May 5, 6:18 PM · Restricted Project, Restricted Project
phosek accepted D61572: [libcxxabi] Don't use -fvisibility-global-new-delete-hidden when not defining them.

LGTM

Sun, May 5, 6:18 PM · Restricted Project, Restricted Project

Fri, May 3

phosek committed rG1e393064fa27: [Driver] Create non-existent directory for -fcrash-diagnostics-dir (authored by phosek).
[Driver] Create non-existent directory for -fcrash-diagnostics-dir
Fri, May 3, 5:54 PM
phosek committed rC359954: [Driver] Create non-existent directory for -fcrash-diagnostics-dir.
[Driver] Create non-existent directory for -fcrash-diagnostics-dir
Fri, May 3, 5:53 PM
phosek committed rL359954: [Driver] Create non-existent directory for -fcrash-diagnostics-dir.
[Driver] Create non-existent directory for -fcrash-diagnostics-dir
Fri, May 3, 5:53 PM
phosek closed D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir.
Fri, May 3, 5:53 PM · Restricted Project, Restricted Project
phosek added a comment to D60425: [GlobalISel][AArch64] Allow CallLowering to handle types.

We're seeing a failing assertion when building Skia for AArch64 which seems to have been introduced by this change, see PR41738 for more details.

Fri, May 3, 4:42 PM · Restricted Project
phosek created D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir.
Fri, May 3, 4:20 PM · Restricted Project, Restricted Project
phosek abandoned D54784: Use --push/pop-state with XRay link deps.

Turned out this is not the right approach because not every linker supports --push-state/--pop-state but I'm hoping to instead rely on ELF autolinking once D60274 lands.

Fri, May 3, 3:23 PM · Restricted Project
phosek accepted D61468: gn build: Update TODO now that libcxx libcxxabi libunwind clang-tools-extra are done.

LGTM although we're still missing tests for libunwind, libcxxabi and libcxx.

Fri, May 3, 3:20 PM · Restricted Project

Thu, May 2

phosek added a comment to D57646: [libcxx] Specify unwind lib before other system libraries..

Not yet, but it'll probably need to be reworked given all the changes that landed in libc++.

Thu, May 2, 6:23 PM · Restricted Project
phosek committed rG6e9cfee63a7e: [gn] Include the missing BUILD.gn file for libcxxabi includes (authored by phosek).
[gn] Include the missing BUILD.gn file for libcxxabi includes
Thu, May 2, 2:20 PM
phosek committed rL359828: [gn] Include the missing BUILD.gn file for libcxxabi includes.
[gn] Include the missing BUILD.gn file for libcxxabi includes
Thu, May 2, 2:20 PM
phosek closed D61462: [gn] Include the missing BUILD.gn file for libcxxabi includes.
Thu, May 2, 2:20 PM · Restricted Project
phosek created D61462: [gn] Include the missing BUILD.gn file for libcxxabi includes.
Thu, May 2, 1:56 PM · Restricted Project
phosek committed rG206bc17ea0f5: [gn] Update the clangd test lit site configuration (authored by phosek).
[gn] Update the clangd test lit site configuration
Thu, May 2, 1:35 PM
phosek committed rL359825: [gn] Update the clangd test lit site configuration.
[gn] Update the clangd test lit site configuration
Thu, May 2, 1:33 PM
phosek committed rG40028046cdbf: [gn] Include libcxx configuration file (authored by phosek).
[gn] Include libcxx configuration file
Thu, May 2, 12:06 PM
phosek committed rL359815: [gn] Include libcxx configuration file.
[gn] Include libcxx configuration file
Thu, May 2, 12:06 PM
phosek added a comment to D61456: [gn] Update the clangd test lit site configuration.

Thanks! This is incomplete:

  • Create clangd_lit_site_cfg_files.gni next to this build file, but path to generated files there
  • Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn and add remapping there

    Else out/gn/bin/llvm-lit clang-tools-extra/clangd/test/path/to/test won't work.

    Compare to all the other test targets (e.g. clang-tools-extra) for an example.
Thu, May 2, 12:03 PM · Restricted Project, Restricted Project
phosek updated the diff for D61456: [gn] Update the clangd test lit site configuration.
Thu, May 2, 12:02 PM · Restricted Project, Restricted Project
phosek accepted D61367: [crtbegin] Fix an off-by-1 bug in __do_fini.

LGTM, thanks!

Thu, May 2, 11:53 AM · Restricted Project, Restricted Project
phosek created D61456: [gn] Update the clangd test lit site configuration.
Thu, May 2, 11:52 AM · Restricted Project, Restricted Project
phosek committed rUNW359804: [gn] Support for building libunwind.
[gn] Support for building libunwind
Thu, May 2, 11:29 AM
phosek committed rGfa3c328c5104: [gn] Support for building libc++ (authored by phosek).
[gn] Support for building libc++
Thu, May 2, 10:30 AM
phosek committed rG4fe63c70c7ed: [gn] Support for building libcxxabi (authored by phosek).
[gn] Support for building libcxxabi
Thu, May 2, 10:30 AM
phosek committed rGf0652f03b66e: [gn] Support for building libunwind (authored by phosek).
[gn] Support for building libunwind
Thu, May 2, 10:30 AM
phosek committed rCXX359806: [gn] Support for building libc++.
[gn] Support for building libc++
Thu, May 2, 10:30 AM
phosek committed rCXXA359805: [gn] Support for building libcxxabi.
[gn] Support for building libcxxabi
Thu, May 2, 10:30 AM
phosek committed rL359806: [gn] Support for building libc++.
[gn] Support for building libc++
Thu, May 2, 10:30 AM
phosek closed D61143: [gn] Support for building libc++.
Thu, May 2, 10:30 AM · Restricted Project
phosek committed rL359805: [gn] Support for building libcxxabi.
[gn] Support for building libcxxabi
Thu, May 2, 10:29 AM
phosek closed D60372: [gn] Support for building libc++abi.
Thu, May 2, 10:29 AM · Restricted Project
phosek committed rL359804: [gn] Support for building libunwind.
[gn] Support for building libunwind
Thu, May 2, 10:29 AM
phosek closed D60370: [gn] Support for building libunwind.
Thu, May 2, 10:29 AM · Restricted Project
phosek abandoned D60253: [gn] Support for building runtimes.

Cool! Do you think we could maybe do one patch for unwind, libcxxabi, libcxx each? (Probably in that order.)

Thu, May 2, 10:29 AM · Restricted Project
phosek added inline comments to D61143: [gn] Support for building libc++.
Thu, May 2, 10:29 AM · Restricted Project
phosek committed rG156226bb7042: [compiler-rt] Set the ZX_VMO_RESIZABLE option for zx_vmo_create (authored by phosek).
[compiler-rt] Set the ZX_VMO_RESIZABLE option for zx_vmo_create
Thu, May 2, 10:23 AM
phosek committed rL359803: [compiler-rt] Set the ZX_VMO_RESIZABLE option for zx_vmo_create.
[compiler-rt] Set the ZX_VMO_RESIZABLE option for zx_vmo_create
Thu, May 2, 10:23 AM