Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (376 w, 4 d)

Recent Activity

Fri, May 20

phosek added inline comments to D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice.
Fri, May 20, 12:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, May 18

phosek accepted D125903: [runtimes] Fix the build of merged ABI/unwinder libraries.

LGTM

Wed, May 18, 11:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek committed rGe64722f686bd: [CMake][Fuchsia] Build runtimes as universal libraries on OS X (authored by phosek).
[CMake][Fuchsia] Build runtimes as universal libraries on OS X
Wed, May 18, 11:15 AM · Restricted Project, Restricted Project
phosek closed D125908: [CMake][Fuchsia] Build runtimes as universal libraries on OS X.
Wed, May 18, 11:15 AM · Restricted Project, Restricted Project
phosek requested review of D125908: [CMake][Fuchsia] Build runtimes as universal libraries on OS X.
Wed, May 18, 10:14 AM · Restricted Project, Restricted Project
phosek added a reverting change for rG9cddfe3085c4: [CMake] Passthrough OSX CMake options to builtins and runtimes: rGececce1b5ec1: Partially revert "[CMake] Passthrough OSX CMake options to builtins and….
Wed, May 18, 10:02 AM
phosek committed rGececce1b5ec1: Partially revert "[CMake] Passthrough OSX CMake options to builtins and… (authored by phosek).
Partially revert "[CMake] Passthrough OSX CMake options to builtins and…
Wed, May 18, 10:02 AM · Restricted Project, Restricted Project
phosek added a reverting change for D116976: [CMake] Passthrough OSX CMake options to builtins and runtimes: rGececce1b5ec1: Partially revert "[CMake] Passthrough OSX CMake options to builtins and….
Wed, May 18, 10:02 AM · Restricted Project
phosek added a comment to D125715: [runtimes] Default LIB*_HERMETIC_STATIC_LIBRARY to ON on Windows.

We may also want to consider renaming LIBCXXABI_HERMETIC_STATIC_LIBRARY and LIBCXX_HERMETIC_STATIC_LIBRARY to LIBCXXABI_HIDE_SYMBOLS and LIBCXX_HIDE_SYMBOLS respectively for consistency.

Wed, May 18, 9:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D125715: [runtimes] Default LIB*_HERMETIC_STATIC_LIBRARY to ON on Windows.

LGTM

Wed, May 18, 9:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D125864: [Debuginfod] Add --debug-file-directory to llvm-debuginfod-find..

LGTM

Wed, May 18, 9:29 AM · Restricted Project, Restricted Project

Tue, May 17

phosek added inline comments to D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice.
Tue, May 17, 11:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek added a reviewer for D124490: [InstrProf] Minimal Block Coverage: gulfem.
Tue, May 17, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
phosek committed rGa9127eb53894: [llvm] Fix typo for libxml2 detection (authored by sthibaul).
[llvm] Fix typo for libxml2 detection
Tue, May 17, 1:46 AM · Restricted Project, Restricted Project
phosek closed D117052: [llvm] Fix typo for libxml2 detection.
Tue, May 17, 1:46 AM · Restricted Project, Restricted Project
phosek added a comment to D117052: [llvm] Fix typo for libxml2 detection.

I can push the change for you if you don't have commit permissions. What name and email would you like me to use?

Tue, May 17, 12:50 AM · Restricted Project, Restricted Project

Mon, May 16

phosek accepted D125710: [InstrProf] Fix promoter when using counter relocations.

LGTM thanks for looking into this!

Mon, May 16, 2:13 PM · Restricted Project, Restricted Project

Fri, May 13

phosek committed rG6f5f847a36af: [libcxxabi] Copy headers into build location (authored by phosek).
[libcxxabi] Copy headers into build location
Fri, May 13, 9:10 PM · Restricted Project
phosek closed D125597: [libcxxabi] Copy headers into build location.
Fri, May 13, 9:10 PM · Restricted Project, Restricted Project
phosek accepted D125597: [libcxxabi] Copy headers into build location.
Fri, May 13, 8:49 PM · Restricted Project, Restricted Project
phosek added a comment to D120727: [libc++] Overhaul how we select the ABI library.

D125597 should address the build error in compiler-rt.

Fri, May 13, 7:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek requested review of D125597: [libcxxabi] Copy headers into build location.
Fri, May 13, 7:32 PM · Restricted Project, Restricted Project
phosek accepted D125121: [runtimes] Generalize how we reorder projects.

LGTM

Fri, May 13, 2:53 PM · Restricted Project, Restricted Project, Restricted Project
phosek accepted D114319: [InstrProf][NFC] Save profile bias to function map.

@ellis do you have time to land this change? This change should address https://github.com/llvm/llvm-project/issues/55125 so I'd like to see it landed.

Fri, May 13, 11:20 AM · Restricted Project, Restricted Project
phosek committed rG534f66042001: [CMake] Disable libedit in Fuchsia toolchain (authored by phosek).
[CMake] Disable libedit in Fuchsia toolchain
Fri, May 13, 10:53 AM · Restricted Project, Restricted Project
phosek closed D125570: [CMake] Disable libedit in Fuchsia toolchain.
Fri, May 13, 10:52 AM · Restricted Project, Restricted Project
phosek requested review of D125570: [CMake] Disable libedit in Fuchsia toolchain.
Fri, May 13, 10:46 AM · Restricted Project, Restricted Project
phosek added a comment to D124673: [llvm][lldb] use FindLibEdit.cmake everywhere.

Hi, Sorry for the late notification, but I think this change may not apply correctly to all configs.

We're seeing a breakage in Fuchsia's Clang CI builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8814329895908917697/overview

FAILED: lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o 
/b/s/w/ir/cache/goma/client/gomacc /b/s/w/ir/x/w/cipd/bin/clang++ --sysroot=/b/s/w/ir/x/w/cipd/linux -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/x/w/staging/llvm_build/lib/LineEditor -I/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/LineEditor -I/b/s/w/ir/cache/vpython/79db7c/lib/python3.8/site-packages/tensorflow/include -I/b/s/w/ir/x/w/staging/llvm_build/include -I/b/s/w/ir/x/w/llvm-llvm-project/llvm/include -isystem /b/s/w/ir/x/w/staging/zlib_install/include -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/b/s/w/ir/x/w/staging/llvm_build=../staging/llvm_build -ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -O3 -DNDEBUG  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -UNDEBUG -std=c++14 -MD -MT lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o -MF lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o.d -o lib/LineEditor/CMakeFiles/LLVMLineEditor.dir/LineEditor.cpp.o -c /b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/LineEditor/LineEditor.cpp
/b/s/w/ir/x/w/llvm-llvm-project/llvm/lib/LineEditor/LineEditor.cpp:18:10: fatal error: 'histedit.h' file not found
#include <histedit.h>
         ^~~~~~~~~~~~

since the error is a missing header for histedit.h, and this change alters how libedit is found in CMake, I assume this is the root cause.

I'm guessing some part of the old CMake checks like the old HAVE_HISTEDIT_H may not have propagated correctly in all cases?

If this will be hard to fix, would you mind reverting until a fix is ready?

It's not clear to me that this patch caused the issue for you, so I don't think it is right to ask for a revert now. You need to provide more evidence.
lldb-x86_64-debian and lldb-cmake-standalone on https://lldb.llvm.org/resources/bots.html work well with the change.

Fri, May 13, 10:41 AM · Restricted Project, Restricted Project, Restricted Project
phosek abandoned D116689: [libunwind][libcxxabi] Use object libraries in the build.

Superseded by D125393.

Fri, May 13, 10:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D125561: [runtimes][NFC] Remove dead code for Standalone builds.

LGTM

Fri, May 13, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D125393: [runtimes] Introduce object libraries.

Thanks a lot both @mstorsjo and @phosek for the comments. I've applied @mstorsjo's change (and made a similar change for static libraries). I also did it for libunwind.

@phosek I'm not sure I follow when you say that marking the object libraries as EXCLUDE_FROM_ALL is going to require some reworking elsewhere in LLVM. We are only marking the object libraries as EXCLUDE_FROM_ALL, and nobody outside the runtimes will be using them. The normal cxxabi_shared & friends targets will still be there, and they will still be built by default unless LIBCXXABI_ENABLE_SHARED=OFF.

Fri, May 13, 10:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Thu, May 12

phosek accepted D120727: [libc++] Overhaul how we select the ABI library.

LGTM

Thu, May 12, 4:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D125499: Enabling the detection of devtoolset-11 toolchain..

LGTM

Thu, May 12, 4:49 PM · Restricted Project, Restricted Project
phosek added inline comments to D125393: [runtimes] Introduce object libraries.
Thu, May 12, 1:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek added inline comments to D120727: [libc++] Overhaul how we select the ABI library.
Thu, May 12, 1:22 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, May 11

phosek added a comment to D125393: [runtimes] Introduce object libraries.

Thanks! Overall, this looks like it can work for me. The same two issues as I still had with D116689 (as discussed with @phosek there) exists here too:

  • For mingw, I can't build cxxabi_shared, but I do need cxxabi_shared_objects for cxx_shared. @phosek suggested fixing this by always creating the cxxabi_shared_objects target, but adding the EXCLUDE_FROM_ALL property on it.
  • As the line target_link_libraries(cxx_shared PUBLIC unwind_shared) is removed from cxx, builds with LIBCXXABI_USE_LLVM_UNWINDER, without LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY fail. This can be fixed (at least for my case, didn't test other cases) by moving that dependency from cxxabi_shared to cxxabi_shared_objects - so that it propagates to either cxxabi_shared or cxx_shared later.

I.e., to make it work for me, I made this change on top of it:

diff --git a/libcxxabi/src/CMakeLists.txt b/libcxxabi/src/CMakeLists.txt
index 6e22432759e6..04bee47deee7 100644
--- a/libcxxabi/src/CMakeLists.txt
+++ b/libcxxabi/src/CMakeLists.txt
@@ -152,10 +152,13 @@ if (NOT TARGET pstl::ParallelSTL)
 endif()
 
 # Build the shared library.
-if (LIBCXXABI_ENABLE_SHARED)
   add_library(cxxabi_shared_objects OBJECT ${LIBCXXABI_SOURCES} ${LIBCXXABI_HEADERS})
-  if (LIBCXXABI_USE_LLVM_UNWINDER AND LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY)
-    target_sources(cxxabi_shared_objects PUBLIC $<TARGET_OBJECTS:unwind_shared_objects>)
+  if (LIBCXXABI_USE_LLVM_UNWINDER)
+    if (LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY)
+      target_sources(cxxabi_shared_objects PUBLIC $<TARGET_OBJECTS:unwind_shared_objects>)
+    else()
+      target_link_libraries(cxxabi_shared_objects PUBLIC unwind_shared)
+    endif()
   endif()
   target_link_libraries(cxxabi_shared_objects PRIVATE cxx-headers ${LIBCXXABI_BUILTINS_LIBRARY} ${LIBCXXABI_SHARED_LIBRARIES} ${LIBCXXABI_LIBRARIES})
   target_link_libraries(cxxabi_shared_objects PUBLIC cxxabi-headers)
@@ -166,12 +169,11 @@ if (LIBCXXABI_ENABLE_SHARED)
       CXX_STANDARD_REQUIRED OFF
       COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS}"
       DEFINE_SYMBOL ""
+      EXCLUDE_FROM_ALL ON
   )
 
+if (LIBCXXABI_ENABLE_SHARED)
   add_library(cxxabi_shared SHARED $<TARGET_OBJECTS:cxxabi_shared_objects>)
-  if(LIBCXXABI_USE_LLVM_UNWINDER AND NOT LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY)
-    target_link_libraries(cxxabi_shared PUBLIC unwind_shared)
-  endif()
   set_target_properties(cxxabi_shared
     PROPERTIES
       LINK_FLAGS "${LIBCXXABI_LINK_FLAGS}"

(I guess the same change for always creating the cxxabi_static_objects, but with EXCLUDE_FROM_ALL, should be made too, but I just tested with the bare minimums for making this work for me.)

Wed, May 11, 2:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D116689: [libunwind][libcxxabi] Use object libraries in the build.

I wonder if we could simplify things by always building cxxabi_static_objects and cxxabi_shared_objects but marking them as EXCLUDE_FROM_ALL?

That's probably the best solution for that - thanks!

I've realized that this also going to simplify our build so I like that direction. It's not entirely straightforward though because there are currently various parts of the build that assume that either static or shared libcxxabi is being built which need to be reworked.

Wed, May 11, 1:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, May 10

phosek added a comment to D116689: [libunwind][libcxxabi] Use object libraries in the build.

I wonder if we could simplify things by always building cxxabi_static_objects and cxxabi_shared_objects but marking them as EXCLUDE_FROM_ALL?

That's probably the best solution for that - thanks!

Tue, May 10, 12:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, May 9

phosek added a comment to D116689: [libunwind][libcxxabi] Use object libraries in the build.

This version breaks things for me; I'm building with LIBCXX_ENABLE_STATIC_ABI_LIBRARY and LIBCXXABI_USE_LLVM_UNWINDER but not LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY. In this case, there's no shared libcxxabi (I build with LIBCXXABI_ENABLE_SHARED=OFF), so libcxx would need to retain the code to link against the libunwind cmake target, it can't be carried transitively via libcxxabi (cxxabi_shared_objects). I.e. this case gets lost:

if(LIBCXXABI_USE_LLVM_UNWINDER AND NOT LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY)
   target_link_libraries(cxxabi_shared PUBLIC unwind_shared)
 endif()
Mon, May 9, 2:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, May 6

phosek added a reverting change for rG203455c85ad0: [CMake][libcxx] Use target_include_directories for libc++ headers: rG83e07916ffc5: Revert "[CMake][libcxx] Use target_include_directories for libc++ headers".
Fri, May 6, 10:20 PM · Restricted Project, Restricted Project
phosek committed rG83e07916ffc5: Revert "[CMake][libcxx] Use target_include_directories for libc++ headers" (authored by phosek).
Revert "[CMake][libcxx] Use target_include_directories for libc++ headers"
Fri, May 6, 10:20 PM · Restricted Project, Restricted Project
phosek reopened D122614: [CMake][libcxx] Use target_include_directories for libc++ headers.
Fri, May 6, 10:20 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a reverting change for D122614: [CMake][libcxx] Use target_include_directories for libc++ headers: rG83e07916ffc5: Revert "[CMake][libcxx] Use target_include_directories for libc++ headers".
Fri, May 6, 10:20 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D122614: [CMake][libcxx] Use target_include_directories for libc++ headers.

I'll need some time to properly investigate this so I'm going to revert this change in the meantime.

Fri, May 6, 10:19 PM · Restricted Project, Restricted Project, Restricted Project
phosek reopened D115674: [runtime] Build compiler-rt with --unwindlib=none.
Fri, May 6, 10:18 PM · Restricted Project, Restricted Project
phosek added a reverting change for rG102bc634cb41: [runtime] Build compiler-rt with --unwindlib=none: rGbf3cba71e174: Revert "[runtime] Build compiler-rt with --unwindlib=none".
Fri, May 6, 7:54 PM · Restricted Project, Restricted Project
phosek committed rGbf3cba71e174: Revert "[runtime] Build compiler-rt with --unwindlib=none" (authored by phosek).
Revert "[runtime] Build compiler-rt with --unwindlib=none"
Fri, May 6, 7:54 PM · Restricted Project, Restricted Project
phosek added a reverting change for D115674: [runtime] Build compiler-rt with --unwindlib=none: rGbf3cba71e174: Revert "[runtime] Build compiler-rt with --unwindlib=none".
Fri, May 6, 7:53 PM · Restricted Project, Restricted Project
phosek committed rG102bc634cb41: [runtime] Build compiler-rt with --unwindlib=none (authored by phosek).
[runtime] Build compiler-rt with --unwindlib=none
Fri, May 6, 6:12 PM · Restricted Project, Restricted Project
phosek added a reverting change for rGfecad835fb4c: [runtime] Build compiler-rt with --unwindlib=none: rGd7732695ebcc: Revert "[runtime] Build compiler-rt with --unwindlib=none".
Fri, May 6, 5:52 PM · Restricted Project, Restricted Project
phosek committed rGd7732695ebcc: Revert "[runtime] Build compiler-rt with --unwindlib=none" (authored by phosek).
Revert "[runtime] Build compiler-rt with --unwindlib=none"
Fri, May 6, 5:52 PM · Restricted Project, Restricted Project
phosek added a reverting change for D115674: [runtime] Build compiler-rt with --unwindlib=none: rGd7732695ebcc: Revert "[runtime] Build compiler-rt with --unwindlib=none".
Fri, May 6, 5:52 PM · Restricted Project, Restricted Project
phosek committed rGfecad835fb4c: [runtime] Build compiler-rt with --unwindlib=none (authored by phosek).
[runtime] Build compiler-rt with --unwindlib=none
Fri, May 6, 5:41 PM · Restricted Project, Restricted Project
phosek closed D115674: [runtime] Build compiler-rt with --unwindlib=none.
Fri, May 6, 5:40 PM · Restricted Project, Restricted Project
phosek committed rG57636c25904e: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain (authored by phosek).
[CMake] Include llvm-debuginfod-find in Fuchsia toolchain
Fri, May 6, 4:55 PM · Restricted Project, Restricted Project
phosek closed D125082: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain.
Fri, May 6, 4:55 PM · Restricted Project, Restricted Project
phosek added inline comments to D125121: [runtimes] Generalize how we reorder projects.
Fri, May 6, 4:53 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D116689: [libunwind][libcxxabi] Use object libraries in the build.

@phosek Do you have time to pick this up and complete it? It'd be essential for a build cleanup for Windows - but the patch itself is a bit too far outside of my cmake-fu.

Fri, May 6, 4:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D116689: [libunwind][libcxxabi] Use object libraries in the build.
Fri, May 6, 4:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek committed rG203455c85ad0: [CMake][libcxx] Use target_include_directories for libc++ headers (authored by phosek).
[CMake][libcxx] Use target_include_directories for libc++ headers
Fri, May 6, 2:07 PM · Restricted Project, Restricted Project
phosek closed D122614: [CMake][libcxx] Use target_include_directories for libc++ headers.
Fri, May 6, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
phosek committed rG7f0e741db97c: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia (authored by phosek).
[Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia
Fri, May 6, 1:27 PM · Restricted Project, Restricted Project
phosek closed D114023: [Driver] Pass --fix-cortex-a53-843419 automatically on Fuchsia.
Fri, May 6, 1:27 PM · Restricted Project, Restricted Project
phosek accepted D120719: [runtimes] Always configure libc++abi before libc++.

LGTM after discussing this with @ldionne on Discord. We'll try to come up with a more general solution next.

Fri, May 6, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
phosek requested review of D125082: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain.
Fri, May 6, 1:37 AM · Restricted Project, Restricted Project

Wed, May 4

phosek accepted D124912: [libunwind] [CMake] Handle the RelWithDebInfo configuration similarly to Release.

LGTM

Wed, May 4, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 2

phosek added a comment to D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option..

Probably no from my view, as I got another internal feedback that "this seems rather crufty".
It seems that it is the build system maintainer's responsibility. If you add -Wno-unknown-warning-option temporarily, after a new clang is rolled, you may remove -Wno-unknown-warning-option.

Mon, May 2, 10:39 AM · Restricted Project, Restricted Project

Fri, Apr 29

phosek added inline comments to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.
Fri, Apr 29, 6:36 PM · Restricted Project, Restricted Project
phosek committed rG4bdb505d6265: [Driver] Support for compressed debug info on Fuchsia (authored by phosek).
[Driver] Support for compressed debug info on Fuchsia
Fri, Apr 29, 3:41 PM · Restricted Project, Restricted Project
phosek added a comment to D114115: [Driver] Support for compressed debug info on Fuchsia.

Lit is aware of zlib's presence or absence, you could use REQUIRES: zlib (or you might factor that bit out into its own test with the REQUIRES).

Fri, Apr 29, 3:40 PM · Restricted Project, Restricted Project
phosek updated the diff for D114115: [Driver] Support for compressed debug info on Fuchsia.
Fri, Apr 29, 3:40 PM · Restricted Project, Restricted Project

Wed, Apr 27

phosek added a reverting change for rG2d0c897212d0: [Driver] Support for compressed debug info on Fuchsia: rG82aa5e2c6fe9: Revert "[Driver] Support for compressed debug info on Fuchsia".
Wed, Apr 27, 11:43 AM · Restricted Project, Restricted Project
phosek committed rG82aa5e2c6fe9: Revert "[Driver] Support for compressed debug info on Fuchsia" (authored by phosek).
Revert "[Driver] Support for compressed debug info on Fuchsia"
Wed, Apr 27, 11:43 AM · Restricted Project, Restricted Project
phosek added a reverting change for D114115: [Driver] Support for compressed debug info on Fuchsia: rG82aa5e2c6fe9: Revert "[Driver] Support for compressed debug info on Fuchsia".
Wed, Apr 27, 11:42 AM · Restricted Project, Restricted Project
phosek committed rG2d0c897212d0: [Driver] Support for compressed debug info on Fuchsia (authored by phosek).
[Driver] Support for compressed debug info on Fuchsia
Wed, Apr 27, 11:25 AM · Restricted Project, Restricted Project

Tue, Apr 26

phosek abandoned D44605: [Driver] Default to DWARF 5 for Fuchsia.

No longer needed, this is now the Clang default.

Tue, Apr 26, 11:47 PM · Restricted Project
phosek committed rG19190cc651ef: [Driver] Support for compressed debug info on Fuchsia (authored by phosek).
[Driver] Support for compressed debug info on Fuchsia
Tue, Apr 26, 11:47 PM · Restricted Project, Restricted Project
phosek closed D114115: [Driver] Support for compressed debug info on Fuchsia.
Tue, Apr 26, 11:47 PM · Restricted Project, Restricted Project
phosek reopened D122750: [CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS.
Tue, Apr 26, 11:28 PM · Restricted Project, Restricted Project
phosek added a reverting change for rGd47565ed62a3: [CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS: rG0571af01df20: Revert "[CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS".
Tue, Apr 26, 11:26 PM · Restricted Project, Restricted Project
phosek committed rG0571af01df20: Revert "[CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS" (authored by phosek).
Revert "[CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS"
Tue, Apr 26, 11:26 PM · Restricted Project, Restricted Project
phosek added a reverting change for D122750: [CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS: rG0571af01df20: Revert "[CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS".
Tue, Apr 26, 11:26 PM · Restricted Project, Restricted Project
phosek committed rGd47565ed62a3: [CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS (authored by phosek).
[CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS
Tue, Apr 26, 11:19 PM · Restricted Project, Restricted Project
phosek closed D122750: [CMake][compiler-rt] Use COMPILE_OPTIONS and LINK_OPTIONS.
Tue, Apr 26, 11:19 PM · Restricted Project, Restricted Project
phosek updated the diff for D122614: [CMake][libcxx] Use target_include_directories for libc++ headers.

Rebase to trigger bots.

Tue, Apr 26, 11:18 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT.

I'd be in favor of defaulting to an ERROR and providing an option to downgrade to a WARNING.

Tue, Apr 26, 10:41 PM · Restricted Project, Restricted Project
phosek added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

In this case I'm just trying to make it work with existing build configurations where it is being used (for example Swift). We should definitely be moving away from LLVM_BUILD_EXTERNAL_COMPILER_RT in favor of LLVM_ENABLE_RUNTIMES eventually though.

My point here is that maybe you should move away from the legacy way of building now rather than improving it... Not sure how @phosek feels about this. I would personally very much prefer if we only had one way to build compiler-rt instead of the half dozen we have today.

Tue, Apr 26, 2:07 PM · Restricted Project, Restricted Project
phosek accepted D124375: [runtimes] [cmake] Fix -Werror detection in common build configs.

LGTM

Tue, Apr 26, 1:15 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Apr 25

phosek added a comment to D124411: [ELF] Add --vfs[overlay|replace] flags to change library search behavior.

Another use case besides the one already described by @abrachet is better support for case preserving and case insensitive file systems.

Mon, Apr 25, 8:35 PM · Restricted Project
phosek added inline comments to D124375: [runtimes] [cmake] Fix -Werror detection in common build configs.
Mon, Apr 25, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
phosek accepted D124377: [runtimes] [CMake] Fix checks for -Werror when building with incomplete toolchains.

LGTM

Mon, Apr 25, 2:25 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Apr 24

phosek added inline comments to D124343: [compiler-rt] Use C_STANDARD instead of custom logic for adding -std=c11.
Sun, Apr 24, 1:11 PM · Restricted Project, Restricted Project
phosek accepted D124343: [compiler-rt] Use C_STANDARD instead of custom logic for adding -std=c11.

LGTM

Sun, Apr 24, 1:10 PM · Restricted Project, Restricted Project

Sat, Apr 23

phosek added inline comments to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.
Sat, Apr 23, 3:07 PM · Restricted Project, Restricted Project

Apr 23 2022

phosek closed D123282: [Fuchsia] Omit the list of projects and runtimes.
Apr 23 2022, 2:50 AM · Restricted Project
phosek committed rZORGab6f18cc0fbb: [Fuchsia] Omit the list of projects and runtimes (authored by phosek).
[Fuchsia] Omit the list of projects and runtimes
Apr 23 2022, 2:50 AM · Restricted Project

Apr 22 2022

phosek added inline comments to D123282: [Fuchsia] Omit the list of projects and runtimes.
Apr 22 2022, 11:30 PM · Restricted Project
phosek retitled D123282: [Fuchsia] Omit the list of projects and runtimes from [Fuchsia] The list of projects and runtimes is part of cache now to [Fuchsia] Omit the list of projects and runtimes.
Apr 22 2022, 11:29 PM · Restricted Project
phosek committed rG4466672861ff: [CMake] Update ARM32 list for CRT config-ix (authored by phosek).
[CMake] Update ARM32 list for CRT config-ix
Apr 22 2022, 2:38 PM · Restricted Project, Restricted Project

Apr 20 2022

phosek accepted D123777: [CMake] Check for problematic MSVC + /arch:AVX configuration.

LGTM

Apr 20 2022, 9:54 PM · Restricted Project, Restricted Project