User Details
User Details
- User Since
- Mar 4 2015, 5:44 PM (201 w, 6 d)
Yesterday
Yesterday
[libc++] Support different libc++ namespaces in the iterator test
[libc++] Support different libc++ namespaces in the iterator test
phosek accepted D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..
LGTM
LGTM
Mon, Jan 14
Mon, Jan 14
phosek added inline comments to D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..
phosek added inline comments to D56705: gn build: Make a couple of improvements to the unix toolchain..
LGTM
phosek added inline comments to D56700: gn build: Add a resource_dir.gni file..
[CMake][Fuchsia] Synchronize first and second stage builds
[CMake][Fuchsia] Synchronize first and second stage builds
phosek accepted D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.
LGTM, although I'll probably try to fix the gn help behavior to avoid similar workarounds.
Sun, Jan 13
Sun, Jan 13
phosek added inline comments to D56026: [libcxxabi] Support building hermetic static library.
phosek committed rCXX351027: [libcxx] Mark do_open, do_get and do_close parameters unused when catopen is….
[libcxx] Mark do_open, do_get and do_close parameters unused when catopen is…
phosek committed rL351027: [libcxx] Mark do_open, do_get and do_close parameters unused when catopen is….
[libcxx] Mark do_open, do_get and do_close parameters unused when catopen is…
phosek updated the diff for D56026: [libcxxabi] Support building hermetic static library.
Fri, Jan 11
Fri, Jan 11
phosek added inline comments to D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.
phosek added inline comments to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
phosek added inline comments to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
phosek added inline comments to D56577: gn build: Add a stage2 toolchain for Android..
phosek added inline comments to D56577: gn build: Add a stage2 toolchain for Android..
phosek added a comment to D56427: gn build: s/root_out_dir/root_build_dir/g in llvm/utils/gn/build/write_cmake_config.gni..
Are all the generated files independent of the target toolchain? The most idiomatic from GN point of view would be to use root_gen_dir for all generated files.
Wed, Jan 9
Wed, Jan 9
phosek added a comment to D56479: [compiler-rt] Add option to disable libc++ build.
This also needs to support the runtimes build which defines HAVE_LIBCXX variable when libc++ is being built.
Tue, Jan 8
Tue, Jan 8
phosek accepted D56423: gn build: Copy file permissions from input file in configure_file() emulation..
LGTM
phosek added inline comments to D56423: gn build: Copy file permissions from input file in configure_file() emulation..
phosek accepted D56420: [gn build] Add a TODO.txt file.
I'd still prefer Markdown, but I'm also used to writing things in Markdown so I don't see that as a downside personally. However, I think it's a minor thing so I'm not going to push for it ;)
Mon, Jan 7
Mon, Jan 7
phosek updated the diff for D55917: Introduce Fuchsia builder.
phosek accepted D56420: [gn build] Add a TODO.txt file.
Can we make it .rst or .md so it's formatted nicely when opened e.g. on GitHub?
LGTM
LGTM
phosek accepted D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present.
LGTM
Sun, Jan 6
Sun, Jan 6
LGTM
LGTM
[CMake] Use hidden visibility for static libc++ in Fuchsia
[CMake] Use hidden visibility for static libc++ in Fuchsia
Sat, Jan 5
Sat, Jan 5
[libcxx] Support building hermetic static library
[libcxx] Support building hermetic static library
[compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call
[compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call
[CMake][Fuchsia] Enable build ID, relaxations for first stage
[CMake][Fuchsia] Enable build ID, relaxations for first stage
phosek accepted D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
LGTM
phosek committed rL350484: Revert "[CMake][Fuchsia] Enable experimental new pass manager by default".
Revert "[CMake][Fuchsia] Enable experimental new pass manager by default"
phosek committed rC350484: Revert "[CMake][Fuchsia] Enable experimental new pass manager by default".
Revert "[CMake][Fuchsia] Enable experimental new pass manager by default"
[CMake][Fuchsia] Enable experimental new pass manager by default
[CMake][Fuchsia] Enable x86 relaxation by default
[CMake][Fuchsia] Enable experimental new pass manager by default
[CMake][Fuchsia] Enable x86 relaxation by default
[CMake][Fuchsia] Enable --build-id linker flag by default
[CMake][Fuchsia] Enable --build-id linker flag by default
Fri, Jan 4
Fri, Jan 4
phosek added a parent revision for D56349: [CMake][Fuchsia] Enable x86 relaxation by default: D56348: [CMake][Fuchsia] Enable --build-id linker flag by default.
phosek accepted D56328: [gn build] Add build files for unittests under llvm/unittests/ExecutionEngine.
LGTM
phosek added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
LGTM
LGTM but don't forget to update the message.
phosek accepted D56316: [gn build] Add build files for llvm/lib/{LineEditor,Testing/Support,TextAPI}.
LGTM
phosek added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
phosek updated the diff for D56305: [AArch64] Support reserving arbitrary general purpose registers.
Thu, Jan 3
Thu, Jan 3
phosek updated the diff for D55917: Introduce Fuchsia builder.
Wed, Jan 2
Wed, Jan 2
phosek updated the diff for D55917: Introduce Fuchsia builder.
LGTM
LGTM
LGTM
LGTM