phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (150 w, 1 d)

Recent Activity

Yesterday

phosek committed rL322922: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver.
[Fuchsia] Tests for the Fuzzer support in Fuchsia driver
Thu, Jan 18, 8:11 PM
phosek committed rC322922: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver.
[Fuchsia] Tests for the Fuzzer support in Fuchsia driver
Thu, Jan 18, 8:11 PM
phosek closed D42283: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver.
Thu, Jan 18, 8:11 PM
phosek created D42283: [Fuchsia] Tests for the Fuzzer support in Fuchsia driver.
Thu, Jan 18, 7:41 PM
phosek updated the diff for D42055: Fallback option for colorized output when terminfo isn't available.

I've implemented what @joerg suggested, is this acceptable?

Thu, Jan 18, 7:20 PM
phosek committed rC322916: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia.
[Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia
Thu, Jan 18, 5:59 PM
phosek committed rL322916: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia.
[Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia
Thu, Jan 18, 5:59 PM
phosek closed D42275: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia.
Thu, Jan 18, 5:59 PM
phosek created D42275: [Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia.
Thu, Jan 18, 5:30 PM
phosek created D42274: [Support] Remove the terminfo dependency and rely on TERM.
Thu, Jan 18, 5:27 PM
phosek added a comment to D42055: Fallback option for colorized output when terminfo isn't available.

I'd like it better if you just removed the "#ifdef HAVE_TERMINFO" branch of code entirely, along the cmake support for causing it to be defined and adding TERMINFO_LIBS to llvm. (lldb still looks like it uses it, so can't just remove everything related to terminfo from the cmake support files)

Both GCC and Git simply use the TERM is set and != "dumb" check, and never touch curses. If it's good enough for them, it's good enough for llvm too, and we don't need to extra complexity and dependencies. Also, the hacks in this code are ugly (writing our own function signatures for these functions instead of using a proper #include!).

Thu, Jan 18, 12:35 PM

Wed, Jan 17

phosek committed rCRT322755: Reland "[libFuzzer] Support using libc++".
Reland "[libFuzzer] Support using libc++"
Wed, Jan 17, 12:42 PM
phosek committed rL322755: Reland "[libFuzzer] Support using libc++".
Reland "[libFuzzer] Support using libc++"
Wed, Jan 17, 12:42 PM
phosek committed rCRT322689: Revert "[libFuzzer] Support using libc++".
Revert "[libFuzzer] Support using libc++"
Wed, Jan 17, 9:26 AM
phosek committed rL322689: Revert "[libFuzzer] Support using libc++".
Revert "[libFuzzer] Support using libc++"
Wed, Jan 17, 9:26 AM

Tue, Jan 16

phosek committed rL322604: [libFuzzer] Support using libc++.
[libFuzzer] Support using libc++
Tue, Jan 16, 4:44 PM
phosek committed rCRT322604: [libFuzzer] Support using libc++.
[libFuzzer] Support using libc++
Tue, Jan 16, 4:44 PM
phosek closed D37631: [libFuzzer] Support using libc++.
Tue, Jan 16, 4:44 PM
phosek updated the diff for D37631: [libFuzzer] Support using libc++.
Tue, Jan 16, 3:29 PM
phosek added inline comments to D37631: [libFuzzer] Support using libc++.
Tue, Jan 16, 12:29 PM

Mon, Jan 15

phosek created D42055: Fallback option for colorized output when terminfo isn't available.
Mon, Jan 15, 2:09 AM

Sat, Jan 13

phosek committed rCRT322451: Reland "Install resource files into a share/ directory".
Reland "Install resource files into a share/ directory"
Sat, Jan 13, 7:45 PM
phosek committed rC322452: Reland "[Driver] Update default sanitizer blacklist location".
Reland "[Driver] Update default sanitizer blacklist location"
Sat, Jan 13, 7:44 PM
phosek committed rL322452: Reland "[Driver] Update default sanitizer blacklist location".
Reland "[Driver] Update default sanitizer blacklist location"
Sat, Jan 13, 7:44 PM
phosek committed rL322451: Reland "Install resource files into a share/ directory".
Reland "Install resource files into a share/ directory"
Sat, Jan 13, 7:44 PM
phosek added inline comments to D37631: [libFuzzer] Support using libc++.
Sat, Jan 13, 4:34 PM

Fri, Jan 12

phosek added a comment to D42022: Reland "Make TracePcGuardController linker-initialized".

@kcc @vitalybuka lib/sanitizer_common/scripts/cpplint.py and clang-format seem to disagree on formatting of static initializers which is breaking the build. It's likely that the version that's in tree doesn't even support static initializers. I tried to replace lib/sanitizer_common/scripts/cpplint.py with the latest version from https://github.com/cpplint/cpplint which resolves this issue but starts throwing errors for other files in compiler-rt. Do you have any suggestion/opinion on what to do about this?

Fri, Jan 12, 5:16 PM · Restricted Project
phosek added reviewers for D42022: Reland "Make TracePcGuardController linker-initialized": vitalybuka, kcc.
Fri, Jan 12, 5:11 PM · Restricted Project
phosek created D42022: Reland "Make TracePcGuardController linker-initialized".
Fri, Jan 12, 5:03 PM · Restricted Project
phosek committed rL322428: Revert "[SanitizerCoverage][Fuchsia] Make TracePcGuardController linker….
Revert "[SanitizerCoverage][Fuchsia] Make TracePcGuardController linker…
Fri, Jan 12, 4:57 PM
phosek committed rCRT322428: Revert "[SanitizerCoverage][Fuchsia] Make TracePcGuardController linker….
Revert "[SanitizerCoverage][Fuchsia] Make TracePcGuardController linker…
Fri, Jan 12, 4:57 PM
phosek added a comment to D39963: [RISCV] Add initial RISC-V target and driver support.

This has broken our toolchain build, the log is here: https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8957686819564148864%2F%2B%2Fsteps%2Fcheck_clang%2F0%2Fstdout. The failure is:

******************** TEST 'Clang :: Driver/riscv32-toolchain.c' FAILED ********************
Script:
--
/b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/clang /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c -### -no-canonical-prefixes -target riscv32 2>&1 | /b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/FileCheck -check-prefix=CC1 /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c
/b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/clang /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c -### -no-canonical-prefixes    -target riscv32-linux-unknown-elf    --gcc-toolchain=/b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk    --sysroot=/b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot 2>&1    | /b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/FileCheck -check-prefix=CC1-RV32-LINUX-ILP32 /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c
/b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/clang /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c -### -no-canonical-prefixes    -target riscv32-linux-unknown-elf -march=rv32imafd -mabi=ilp32d    --gcc-toolchain=/b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk    --sysroot=/b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot 2>&1    | /b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/FileCheck -check-prefix=CC1-RV32-LINUX-ILP32D /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c
/b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/clang -target riscv32 /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c -emit-llvm -S -o - | /b/s/w/ir/tmp/rt/clangM7g4Ie/llvm_build_dir/tools/clang/stage2-bins/bin/FileCheck /b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c
--
Exit Code: 1
Command Output (stderr):
--
/b/s/w/ir/kitchen-workdir/llvm-project/clang/test/Driver/riscv32-toolchain.c:13:26: error: expected string not found in input
// CC1-RV32-LINUX-ILP32: "{{.*}}/Inputs/multilib_riscv_linux_sdk/lib/gcc/riscv64-unknown-linux-gnu/7.2.0/../../../../riscv64-unknown-linux-gnu/bin{{/|\\\\}}ld"
                         ^
<stdin>:1:1: note: scanning from here
Fuchsia clang version 7.0.0 (https://fuchsia.googlesource.com/a/third_party/clang 6d538af698b9b96bc18bfbe62173dca1c103aaca) (https://fuchsia.googlesource.com/a/third_party/llvm 0b5677cbf87647986caf9fa818adb7f8c355cf1f) (based on LLVM 7.0.0svn)
^
--

I think the problem is that in our toolchain, we configure LLD as the default linker which is why that check is failing.

Fri, Jan 12, 4:38 PM
phosek committed rCRT322424: [SanitizerCoverage][Fuchsia] Make TracePcGuardController linker-initialized.
[SanitizerCoverage][Fuchsia] Make TracePcGuardController linker-initialized
Fri, Jan 12, 4:31 PM
phosek committed rL322424: [SanitizerCoverage][Fuchsia] Make TracePcGuardController linker-initialized.
[SanitizerCoverage][Fuchsia] Make TracePcGuardController linker-initialized
Fri, Jan 12, 4:31 PM
phosek closed D41513: [SanitizerCoverage][Fuchsia] Make TracePcGuardController linker-initialized.
Fri, Jan 12, 4:31 PM · Restricted Project
phosek created D42019: [Driver] Set default sysroot for Fuchsia if none is specified.
Fri, Jan 12, 4:18 PM
phosek updated the diff for D37631: [libFuzzer] Support using libc++.
Fri, Jan 12, 3:51 PM

Thu, Jan 11

phosek added a comment to D37631: [libFuzzer] Support using libc++.

I see a lot of these on "ninja check-fuzzer"

Thu, Jan 11, 8:19 PM
phosek updated the diff for D37631: [libFuzzer] Support using libc++.
Thu, Jan 11, 8:18 PM

Wed, Jan 10

phosek committed rCRT322261: Revert "Install resource files into a share/ directory".
Revert "Install resource files into a share/ directory"
Wed, Jan 10, 11:07 PM
phosek committed rL322261: Revert "Install resource files into a share/ directory".
Revert "Install resource files into a share/ directory"
Wed, Jan 10, 11:07 PM
phosek committed rL322260: Revert "[Driver] Update default sanitizer blacklist location".
Revert "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 11:07 PM
phosek committed rC322260: Revert "[Driver] Update default sanitizer blacklist location".
Revert "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 11:06 PM
phosek committed rL322258: Reland "[Driver] Update default sanitizer blacklist location".
Reland "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 10:43 PM
phosek committed rC322258: Reland "[Driver] Update default sanitizer blacklist location".
Reland "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 10:43 PM
phosek committed rL322256: Reland "Install resource files into a share/ directory".
Reland "Install resource files into a share/ directory"
Wed, Jan 10, 10:43 PM
phosek committed rCRT322256: Reland "Install resource files into a share/ directory".
Reland "Install resource files into a share/ directory"
Wed, Jan 10, 10:43 PM
phosek committed rL322253: [Fuchsia] Remove LLDB from the toolchain distribution.
[Fuchsia] Remove LLDB from the toolchain distribution
Wed, Jan 10, 8:26 PM
phosek committed rC322253: [Fuchsia] Remove LLDB from the toolchain distribution.
[Fuchsia] Remove LLDB from the toolchain distribution
Wed, Jan 10, 8:26 PM
phosek closed D41929: [Fuchsia] Disable LLDB from the toolchain distribution.
Wed, Jan 10, 8:26 PM
phosek committed rL322252: [Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts.
[Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts
Wed, Jan 10, 8:19 PM
phosek committed rC322252: [Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts.
[Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts
Wed, Jan 10, 8:19 PM
phosek closed D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts.
Wed, Jan 10, 8:19 PM
phosek added a comment to D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts.

The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will also use llvm-objcopy.

Wed, Jan 10, 7:53 PM
phosek retitled D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts from [Fuchsia] Use llvm-objcopy as objcopy on Linux to [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts.
Wed, Jan 10, 7:53 PM
phosek created D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts.
Wed, Jan 10, 5:33 PM
phosek created D41929: [Fuchsia] Disable LLDB from the toolchain distribution.
Wed, Jan 10, 5:29 PM
phosek committed rC322242: Revert "[Driver] Update default sanitizer blacklist location".
Revert "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 4:13 PM
phosek committed rCRT322243: Revert "Install resource files into a share/ directory".
Revert "Install resource files into a share/ directory"
Wed, Jan 10, 4:13 PM
phosek committed rL322243: Revert "Install resource files into a share/ directory".
Revert "Install resource files into a share/ directory"
Wed, Jan 10, 4:13 PM
phosek committed rL322242: Revert "[Driver] Update default sanitizer blacklist location".
Revert "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 4:13 PM
phosek committed rCRT322234: Reland "Install resource files into a share/ directory".
Reland "Install resource files into a share/ directory"
Wed, Jan 10, 3:00 PM
phosek committed rL322233: Reland "[Driver] Update default sanitizer blacklist location".
Reland "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 3:00 PM
phosek committed rL322234: Reland "Install resource files into a share/ directory".
Reland "Install resource files into a share/ directory"
Wed, Jan 10, 3:00 PM
phosek committed rC322233: Reland "[Driver] Update default sanitizer blacklist location".
Reland "[Driver] Update default sanitizer blacklist location"
Wed, Jan 10, 3:00 PM
phosek committed rUNW322228: [libunwind] Set up .arcconfig to point to new Diffusion UNW repository.
[libunwind] Set up .arcconfig to point to new Diffusion UNW repository
Wed, Jan 10, 2:24 PM
phosek committed rL322228: [libunwind] Set up .arcconfig to point to new Diffusion UNW repository.
[libunwind] Set up .arcconfig to point to new Diffusion UNW repository
Wed, Jan 10, 2:21 PM
phosek closed D41918: [libunwind] Set up .arcconfig to point to new Diffusion UNW repository.
Wed, Jan 10, 2:21 PM
phosek updated subscribers of D41918: [libunwind] Set up .arcconfig to point to new Diffusion UNW repository.
Wed, Jan 10, 2:09 PM
phosek created D41918: [libunwind] Set up .arcconfig to point to new Diffusion UNW repository.
Wed, Jan 10, 2:08 PM

Tue, Jan 9

phosek committed rL322156: Revert "[CMake] Install resource files into a share/ directory".
Revert "[CMake] Install resource files into a share/ directory"
Tue, Jan 9, 6:25 PM
phosek committed rC322155: Revert "[Driver] Update default sanitizer blacklist location".
Revert "[Driver] Update default sanitizer blacklist location"
Tue, Jan 9, 6:25 PM
phosek committed rCRT322156: Revert "[CMake] Install resource files into a share/ directory".
Revert "[CMake] Install resource files into a share/ directory"
Tue, Jan 9, 6:25 PM
phosek committed rL322155: Revert "[Driver] Update default sanitizer blacklist location".
Revert "[Driver] Update default sanitizer blacklist location"
Tue, Jan 9, 6:25 PM
phosek committed rCRT322153: [CMake] Install resource files into a share/ directory.
[CMake] Install resource files into a share/ directory
Tue, Jan 9, 6:17 PM
phosek committed rL322154: [Driver] Update default sanitizer blacklist location.
[Driver] Update default sanitizer blacklist location
Tue, Jan 9, 6:13 PM
phosek committed rL322153: [CMake] Install resource files into a share/ directory.
[CMake] Install resource files into a share/ directory
Tue, Jan 9, 6:13 PM
phosek committed rC322154: [Driver] Update default sanitizer blacklist location.
[Driver] Update default sanitizer blacklist location
Tue, Jan 9, 6:13 PM
phosek closed D41673: [CMake] Install resource files into a share/ directory.
Tue, Jan 9, 6:13 PM
phosek closed D41706: [Driver] Update default sanitizer blacklist location.
Tue, Jan 9, 6:13 PM
phosek updated the diff for D41753: [libunwind][CMake] Collect target names in the global LLVM_RUNTIMES property.
Tue, Jan 9, 11:58 AM
phosek updated the diff for D41754: [CMake] Collect target names in the global LLVM_RUNTIMES property.
Tue, Jan 9, 11:57 AM
phosek updated the diff for D41755: [CMake] Collect target names in the global LLVM_RUNTIMES property.
Tue, Jan 9, 11:57 AM
phosek updated the diff for D41752: [CMake] Collect target names in the global LLVM_RUNTIMES property.
Tue, Jan 9, 11:56 AM
phosek added a comment to D37631: [libFuzzer] Support using libc++.

ping?

Tue, Jan 9, 11:42 AM

Mon, Jan 8

phosek committed rL322046: [CMake] Support for cross-compilation when build runtimes.
[CMake] Support for cross-compilation when build runtimes
Mon, Jan 8, 3:52 PM
phosek closed D41678: [CMake] Support for cross-compilation when build runtimes.
Mon, Jan 8, 3:52 PM
phosek committed rL322044: [libcxx] Support the use of compiler-rt in lit tests.
[libcxx] Support the use of compiler-rt in lit tests
Mon, Jan 8, 3:38 PM
phosek committed rCXX322044: [libcxx] Support the use of compiler-rt in lit tests.
[libcxx] Support the use of compiler-rt in lit tests
Mon, Jan 8, 3:38 PM
phosek closed D40513: [libcxx] Support the use of compiler-rt in lit tests.
Mon, Jan 8, 3:38 PM

Sun, Jan 7

phosek committed rL321981: Don't try to run MCJIT/OrcJIT EH tests when C++ library is statically linked.
Don't try to run MCJIT/OrcJIT EH tests when C++ library is statically linked
Sun, Jan 7, 6:50 PM
phosek closed D41272: Don't try to run MCJIT/OrcJIT EH tests when C++ library is statically linked.
Sun, Jan 7, 6:49 PM
phosek committed rL321980: [llvm-readobj] Support -needed-libs option for Mach-O files.
[llvm-readobj] Support -needed-libs option for Mach-O files
Sun, Jan 7, 6:24 PM
phosek closed D41527: [llvm-readobj] Support -needed-libs option for Mach-O files.
Sun, Jan 7, 6:24 PM

Fri, Jan 5

phosek added a comment to D41272: Don't try to run MCJIT/OrcJIT EH tests when C++ library is statically linked.

This looks good to me. Please correct me if I'm wrong, but it also looks like you've written this patch so that it will work correctly even if it is landed before the llvm-readobj changes are landed. If that is the case go ahead and land this.

Fri, Jan 5, 2:22 PM

Thu, Jan 4

phosek created D41755: [CMake] Collect target names in the global LLVM_RUNTIMES property.
Thu, Jan 4, 6:20 PM
phosek created D41754: [CMake] Collect target names in the global LLVM_RUNTIMES property.
Thu, Jan 4, 6:18 PM
phosek created D41753: [libunwind][CMake] Collect target names in the global LLVM_RUNTIMES property.
Thu, Jan 4, 6:17 PM
phosek created D41752: [CMake] Collect target names in the global LLVM_RUNTIMES property.
Thu, Jan 4, 6:15 PM

Wed, Jan 3

phosek updated the diff for D41706: [Driver] Update default sanitizer blacklist location.
Wed, Jan 3, 11:03 AM