Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (327 w, 2 d)

Recent Activity

Yesterday

phosek accepted D104138: Create install targets for scan-build-py..

LGTM

Fri, Jun 11, 1:47 PM · Restricted Project
phosek added a comment to D101479: [Driver] Support libc++ in MSVC.

Couldn’t this commit have been kept in, and just reverting the one for using it in the fuchsia cmake cache? (I’m not using this particular commit myself, just observing.)

Fri, Jun 11, 10:41 AM · Restricted Project
phosek reopened D101479: [Driver] Support libc++ in MSVC.
Fri, Jun 11, 12:48 AM · Restricted Project
phosek added a reverting change for rG9625d61eb66c: [Driver] Support libc++ in MSVC: rG22f194909ae2: Revert "[Driver] Support libc++ in MSVC".
Fri, Jun 11, 12:46 AM
phosek committed rG22f194909ae2: Revert "[Driver] Support libc++ in MSVC" (authored by phosek).
Revert "[Driver] Support libc++ in MSVC"
Fri, Jun 11, 12:46 AM
phosek added a reverting change for rGb413e44200e7: [CMake] Don't use libc++ by default on Windows yet: rG0d5af7a4caaf: Revert "[CMake] Don't use libc++ by default on Windows yet".
Fri, Jun 11, 12:46 AM
phosek added a reverting change for D101479: [Driver] Support libc++ in MSVC: rG22f194909ae2: Revert "[Driver] Support libc++ in MSVC".
Fri, Jun 11, 12:46 AM · Restricted Project
phosek committed rG0d5af7a4caaf: Revert "[CMake] Don't use libc++ by default on Windows yet" (authored by phosek).
Revert "[CMake] Don't use libc++ by default on Windows yet"
Fri, Jun 11, 12:46 AM
phosek added a reverting change for D103941: [CMake] Don't use libc++ by default on Windows yet: rG0d5af7a4caaf: Revert "[CMake] Don't use libc++ by default on Windows yet".
Fri, Jun 11, 12:46 AM · Restricted Project

Thu, Jun 10

phosek added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

I think we can say that _HAS_EXCEPTIONS=0 is an important configuration.

Oh, that's good to know, thanks for clarifying it!

I can't speak to or improve the state of libc++ testing, but I think we'd start using this configuration if libc++ supported it. We have plans to work on Windows testing in LLVM, and that might include libc++, but the timeline is early 2022, so I'm not sure we should wait for that.

So I guess it's mostly up to @goncharov and the resources of the current windows runners and how much load they have from the current CI setups (from what I've seen lately, they run their tasks with little to no wait so they seem fine?), whether it's ok to add another config. If it is, I could try looking into adding a config for this.

Thu, Jun 10, 11:16 AM · Restricted Project

Wed, Jun 9

phosek accepted D101139: Create install targets for scan-build-py..

LGTM

Wed, Jun 9, 10:37 AM · Restricted Project
phosek added inline comments to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.
Wed, Jun 9, 10:22 AM · Restricted Project
phosek accepted D103973: [libc++abi] Remove the LIBCXXABI_ENABLE_PIC option.

LGTM for consistency with other runtimes.

Wed, Jun 9, 10:14 AM · Restricted Project, Restricted Project
phosek added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Is this configuration being tested by a bot? Who is it important for?

This looks good to me, except for the principle that we should not attempt to half-support configurations that we don't commit to testing - instead we should clearly state that those are not supported and simplify the library to not even try to support them. I'm 100% fine with this patch and supportive of this if I can get an answer to the questions above.

Wed, Jun 9, 10:12 AM · Restricted Project

Tue, Jun 8

phosek committed rGb413e44200e7: [CMake] Don't use libc++ by default on Windows yet (authored by phosek).
[CMake] Don't use libc++ by default on Windows yet
Tue, Jun 8, 11:57 PM
phosek closed D103941: [CMake] Don't use libc++ by default on Windows yet.
Tue, Jun 8, 11:57 PM · Restricted Project
phosek requested review of D103941: [CMake] Don't use libc++ by default on Windows yet.
Tue, Jun 8, 10:47 PM · Restricted Project
phosek committed rG1683dbf0ddb2: [CMake][Fuchsia] Disable vcruntime for first stage as well (authored by phosek).
[CMake][Fuchsia] Disable vcruntime for first stage as well
Tue, Jun 8, 1:44 PM
phosek closed D103926: [CMake][Fuchsia] Disable vcruntime for first stage as well.
Tue, Jun 8, 1:44 PM · Restricted Project
phosek requested review of D103926: [CMake][Fuchsia] Disable vcruntime for first stage as well.
Tue, Jun 8, 1:42 PM · Restricted Project
phosek committed rGa7142f5c91ba: Partially revert the Fuchsia changes to avoid the use of PIC (authored by phosek).
Partially revert the Fuchsia changes to avoid the use of PIC
Tue, Jun 8, 1:03 PM
phosek committed rG2a5afb466553: [CMake][Fuchsia] Use PIC for Fuchsia runtimes (authored by phosek).
[CMake][Fuchsia] Use PIC for Fuchsia runtimes
Tue, Jun 8, 12:30 PM
phosek closed D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes.
Tue, Jun 8, 12:30 PM · Restricted Project
phosek added a comment to D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes.

Should _LLVM_ENABLE_PIC ON also be added for the multilibs?

Tue, Jun 8, 12:30 PM · Restricted Project
phosek requested review of D103919: [CMake][Fuchsia] Use PIC for Fuchsia runtimes.
Tue, Jun 8, 11:40 AM · Restricted Project
phosek committed rGf673365e1ce1: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain (authored by phosek).
[CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain
Tue, Jun 8, 11:25 AM
phosek closed D103918: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain.
Tue, Jun 8, 11:25 AM · Restricted Project
phosek requested review of D103918: [CMake][Fuchsia] Include llvm-otool in Fuchsia toolchain.
Tue, Jun 8, 11:03 AM · Restricted Project
phosek committed rGde98da2eced7: [CMake] Only include LTO on Apple targets (authored by phosek).
[CMake] Only include LTO on Apple targets
Tue, Jun 8, 11:00 AM
phosek closed D103916: [CMake] Only include LTO on Apple targets.
Tue, Jun 8, 11:00 AM · Restricted Project
phosek updated the diff for D103916: [CMake] Only include LTO on Apple targets.
Tue, Jun 8, 10:52 AM · Restricted Project
phosek requested review of D103916: [CMake] Only include LTO on Apple targets.
Tue, Jun 8, 10:50 AM · Restricted Project
phosek committed rG1dba2a026956: [Fuchsia] Update some of the Fuchsia toolchain flags (authored by phosek).
[Fuchsia] Update some of the Fuchsia toolchain flags
Tue, Jun 8, 10:04 AM
phosek closed D103875: [Fuchsia] Update some of the Fuchsia toolchain flags.
Tue, Jun 8, 10:04 AM · Restricted Project
phosek requested review of D103875: [Fuchsia] Update some of the Fuchsia toolchain flags.
Tue, Jun 8, 1:07 AM · Restricted Project

Mon, Jun 7

phosek committed rG9625d61eb66c: [Driver] Support libc++ in MSVC (authored by phosek).
[Driver] Support libc++ in MSVC
Mon, Jun 7, 11:36 PM
phosek closed D101479: [Driver] Support libc++ in MSVC.
Mon, Jun 7, 11:36 PM · Restricted Project
phosek added a reverting change for rG7ed7d4ccb899: [libcxx][gardening] Move all algorithms into their own headers.: rG692d7166f771: Revert "[libcxx][gardening] Move all algorithms into their own headers.".
Mon, Jun 7, 5:16 PM
phosek committed rG692d7166f771: Revert "[libcxx][gardening] Move all algorithms into their own headers." (authored by phosek).
Revert "[libcxx][gardening] Move all algorithms into their own headers."
Mon, Jun 7, 5:16 PM
phosek added a reverting change for rGf1417eb9b1f5: [libcxx][module-map] creates submodules for private headers: rGd9633f229c36: Revert "[libcxx][module-map] creates submodules for private headers".
Mon, Jun 7, 5:16 PM
phosek added a reverting change for D103583: [libcxx][gardening] Move all algorithms into their own headers.: rG692d7166f771: Revert "[libcxx][gardening] Move all algorithms into their own headers.".
Mon, Jun 7, 5:16 PM · Restricted Project
phosek committed rGd9633f229c36: Revert "[libcxx][module-map] creates submodules for private headers" (authored by phosek).
Revert "[libcxx][module-map] creates submodules for private headers"
Mon, Jun 7, 5:16 PM
phosek added a reverting change for D103551: [libcxx][module-map] creates submodules for private headers: rGd9633f229c36: Revert "[libcxx][module-map] creates submodules for private headers".
Mon, Jun 7, 5:16 PM · Restricted Project
phosek accepted D103863: [libcxx][ci] enables assertions for runtimes-build.

LGTM

Mon, Jun 7, 5:15 PM · Restricted Project
phosek added a comment to D103551: [libcxx][module-map] creates submodules for private headers.

Is this for Chromium or Fuchsia? Either way, I'll take a look at it tomorrow morning.

Mon, Jun 7, 9:50 AM · Restricted Project

Sun, Jun 6

phosek added a comment to D103551: [libcxx][module-map] creates submodules for private headers.

https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8845421670067038960/+/u/clang/test/stdout is the full log.

Sun, Jun 6, 3:33 PM · Restricted Project
phosek added a comment to D103551: [libcxx][module-map] creates submodules for private headers.

After this change landed, we started seeing a number of crashes in our CI when using the just built Clang to run libc++ tests (that is using the runtimes build):

Failed Tests (6):
  libc++ :: libcxx/modules/cinttypes_exports.compile.pass.cpp
  libc++ :: libcxx/modules/clocale_exports.compile.pass.cpp
  libc++ :: libcxx/modules/cstdint_exports.compile.pass.cpp
  libc++ :: libcxx/modules/inttypes_h_exports.compile.pass.cpp
  libc++ :: libcxx/modules/stdint_h_exports.compile.pass.cpp
  libc++ :: libcxx/modules/stds_include.sh.cpp

They all fail with the same error:

clang++: clang/lib/Serialization/ASTWriter.cpp:2502: unsigned int clang::ASTWriter::getSubmoduleID(clang::Module *): Assertion `(ID || !Mod) && "asked for module ID for non-local, non-imported module"' failed.
clang++: llvm/include/llvm/Bitstream/BitstreamWriter.h:124: llvm::BitstreamWriter::~BitstreamWriter(): Assertion `BlockScope.empty() && CurAbbrevs.empty() && "Block imbalance"' failed.
clang-13: error: clang frontend command failed with exit code 134 (use -v to see invocation)
Sun, Jun 6, 1:49 PM · Restricted Project

Fri, Jun 4

phosek added inline comments to D103705: [libc++] Simplify a few macros in __config.
Fri, Jun 4, 11:32 AM · Restricted Project

Thu, Jun 3

phosek added a comment to D102892: [WIP][lld] Implement crash reproducer for ELF.

I left some comments, but after reading the change, I'd suggest a slightly different structure: I think it'd be nice if we could avoid duplicating the logic between the --reproduce and --reproduce-on-crash case.

Thu, Jun 3, 4:27 PM · Restricted Project
phosek added a reverting change for rGb5dd421a3afa: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain: rGe237168341ed: Revert "[Fuchsia] Use libc++abi on Windows in Fuchsia toolchain".
Thu, Jun 3, 1:18 AM
phosek committed rGe237168341ed: Revert "[Fuchsia] Use libc++abi on Windows in Fuchsia toolchain" (authored by phosek).
Revert "[Fuchsia] Use libc++abi on Windows in Fuchsia toolchain"
Thu, Jun 3, 1:18 AM
phosek added a reverting change for D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain: rGe237168341ed: Revert "[Fuchsia] Use libc++abi on Windows in Fuchsia toolchain".
Thu, Jun 3, 1:18 AM · Restricted Project

Wed, Jun 2

phosek added a comment to D102180: [Clang][OpenMP] Emit dependent PreInits before directive..

OpenMP/tile_codegen_tile_for.cpp is failing on all our bots, would it be possible to revert the change?

FAIL: Clang :: OpenMP/tile_codegen_tile_for.cpp (9951 of 28034)
******************** TEST 'Clang :: OpenMP/tile_codegen_tile_for.cpp' FAILED ********************
Script:
--
: 'RUN: at line 2';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal-isystem /opt/s/w/ir/x/w/staging/llvm_build/lib/clang/13.0.0/include -nostdsysteminc -verify -triple x86_64-pc-linux-gnu -fopenmp -fopenmp-version=51 -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp -o - | /opt/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --allow-unused-prefixes /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp --check-prefix=IR
: 'RUN: at line 5';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal-isystem /opt/s/w/ir/x/w/staging/llvm_build/lib/clang/13.0.0/include -nostdsysteminc -verify -triple x86_64-pc-linux-gnu -fopenmp -fopenmp-version=51 -emit-pch -o /opt/s/w/ir/x/w/staging/llvm_build/tools/clang/test/OpenMP/Output/tile_codegen_tile_for.cpp.tmp /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp
: 'RUN: at line 6';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal-isystem /opt/s/w/ir/x/w/staging/llvm_build/lib/clang/13.0.0/include -nostdsysteminc -verify -triple x86_64-pc-linux-gnu -fopenmp -fopenmp-version=51 -include-pch /opt/s/w/ir/x/w/staging/llvm_build/tools/clang/test/OpenMP/Output/tile_codegen_tile_for.cpp.tmp -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp -o - | /opt/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --allow-unused-prefixes /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp --check-prefix=IR
--
Exit Code: 1
Wed, Jun 2, 6:29 PM · Restricted Project, Restricted Project
phosek committed rGb5dd421a3afa: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain (authored by phosek).
[Fuchsia] Use libc++abi on Windows in Fuchsia toolchain
Wed, Jun 2, 2:57 PM
phosek closed D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain.
Wed, Jun 2, 2:57 PM · Restricted Project
phosek requested review of D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain.
Wed, Jun 2, 2:19 PM · Restricted Project
phosek added inline comments to D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements.
Wed, Jun 2, 2:17 PM · Restricted Project
phosek accepted D103547: Don't delete the module you're inspecting.

LGTM

Wed, Jun 2, 1:35 PM · Restricted Project

Tue, Jun 1

phosek accepted D103477: [Fuchsia] Add compat multilibs to cache file.

LGTM

Tue, Jun 1, 1:56 PM · Restricted Project

Mon, May 24

phosek accepted D102453: [CMake][ELF] Add -fno-semantic-interposition for GCC and Clang>=13.

LGTM

Mon, May 24, 10:38 PM · Restricted Project
phosek accepted D103044: [docs] [CMake] Change recommendations for how to use LLVM_DEFINITIONS.

LGTM

Mon, May 24, 4:07 PM · Restricted Project
phosek added inline comments to D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
Mon, May 24, 4:02 PM · Restricted Project

Sat, May 22

phosek reopened D101479: [Driver] Support libc++ in MSVC.
Sat, May 22, 3:52 PM · Restricted Project
phosek added a reverting change for D101479: [Driver] Support libc++ in MSVC: rG5ff79f001feb: Revert "[Driver] Support libc++ in MSVC".
Sat, May 22, 3:52 PM · Restricted Project
phosek added a reverting change for rGb604301be355: [Driver] Support libc++ in MSVC: rG5ff79f001feb: Revert "[Driver] Support libc++ in MSVC".
Sat, May 22, 3:52 PM
phosek committed rG5ff79f001feb: Revert "[Driver] Support libc++ in MSVC" (authored by phosek).
Revert "[Driver] Support libc++ in MSVC"
Sat, May 22, 3:52 PM
phosek committed rGb604301be355: [Driver] Support libc++ in MSVC (authored by phosek).
[Driver] Support libc++ in MSVC
Sat, May 22, 1:33 PM
phosek closed D101479: [Driver] Support libc++ in MSVC.
Sat, May 22, 1:32 PM · Restricted Project

Wed, May 19

phosek added a comment to D102453: [CMake][ELF] Add -fno-semantic-interposition for GCC and Clang>=13.

Have you considered using -fvisibility=protected instead?

Wed, May 19, 5:06 PM · Restricted Project
phosek committed rG757a851a2c27: [CMake] Don't LTO optimize targets that aren't part of any distribution (authored by phosek).
[CMake] Don't LTO optimize targets that aren't part of any distribution
Wed, May 19, 3:02 PM
phosek closed D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
Wed, May 19, 3:02 PM · Restricted Project
phosek requested review of D102786: [profile] Don't publish VMO if there are no counters.
Wed, May 19, 10:17 AM · Restricted Project
phosek accepted D102372: [libcxxabi] Remove unnecessary define from build.

LGTM

Wed, May 19, 9:40 AM · Restricted Project
phosek added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

We've started seeing LLVM ERROR: out of memory on our 2-stage LTO Linux builders after this change landed. It looks like linking clang-repl always fails on our bot, but I've also seen OOM when linking ClangCodeGenTests and FrontendTests. Do you have any idea why this could be happening? We'd appreciate any help since our bots have been broken for several days now.

Ouch. Are the bot logs public? If not maybe a stacktrace could be useful. clang-repl combines a lot of libraries across llvm and clang that usually are compiled separately. For instance we put in memory most of the clang frontend, the backend and the JIT. Could it be we are hitting some real limit?

Yes, they are, see https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64, but there isn't much information in there unfortunately. It's possible that we're hitting some limit, but these bots use 32-core instances with 128GB RAM which I'd hope is enough even for the LTO build.

I think the specs are fine for just building with LTO, but I am not sure if that's enough to for the worst case when running ninja -j320 with an LTO build (which is what your job is doing). Can you try limiting your link jobs to something like 16 or 32 (e.g., -DLLVM_PARALLEL_LINK_JOBS=32)

(FWIW, your go build script also crashes with OOM errors so you really are running low on memory on that node)`

Wed, May 19, 9:28 AM · Restricted Project

Tue, May 18

phosek added a comment to D102542: [GlobalISel] Simplify G_ICMP to true/false when the result is known.

We're seeing a test failure in prelegalizer-combiner-icmp-to-true-false-known-bits.mir on our 2-stage LTO builder:

FAIL: LLVM :: CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir (2029 of 43749)
******************** TEST 'LLVM :: CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir' FAILED ********************
Script:
--
: 'RUN: at line 2';   /b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/llc -debugify-and-strip-all-safe -mtriple aarch64 -run-pass=aarch64-prelegalizer-combiner --aarch64prelegalizercombinerhelper-only-enable-rule="icmp_to_true_false_known_bits" -global-isel -verify-machineinstrs /b/s/w/ir/x/w/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir -o - | /b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins/bin/FileCheck /b/s/w/ir/x/w/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/prelegalizer-combiner-icmp-to-true-false-known-bits.mir
--
Exit Code: 2
Tue, May 18, 10:16 PM · Restricted Project
phosek updated the diff for D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
Tue, May 18, 5:13 PM · Restricted Project
phosek accepted D102735: [profile] Skip mmap() if there are no counters.

LGTM

Tue, May 18, 5:02 PM · Restricted Project
phosek updated the diff for D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
Tue, May 18, 5:00 PM · Restricted Project
phosek added inline comments to D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
Tue, May 18, 4:38 PM · Restricted Project
phosek added inline comments to D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
Tue, May 18, 4:27 PM · Restricted Project
phosek requested review of D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution.
Tue, May 18, 4:17 PM · Restricted Project
phosek committed rG832f7af2832e: [CMake] Use -O0 for unittests under full LTO as well (authored by phosek).
[CMake] Use -O0 for unittests under full LTO as well
Tue, May 18, 1:42 PM
phosek closed D102718: [CMake] Use -O0 for unittests under full LTO as well.
Tue, May 18, 1:41 PM · Restricted Project
phosek requested review of D102718: [CMake] Use -O0 for unittests under full LTO as well.
Tue, May 18, 1:10 PM · Restricted Project
phosek added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

We've started seeing LLVM ERROR: out of memory on our 2-stage LTO Linux builders after this change landed. It looks like linking clang-repl always fails on our bot, but I've also seen OOM when linking ClangCodeGenTests and FrontendTests. Do you have any idea why this could be happening? We'd appreciate any help since our bots have been broken for several days now.

Ouch. Are the bot logs public? If not maybe a stacktrace could be useful. clang-repl combines a lot of libraries across llvm and clang that usually are compiled separately. For instance we put in memory most of the clang frontend, the backend and the JIT. Could it be we are hitting some real limit?

Tue, May 18, 10:56 AM · Restricted Project
phosek added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

We've started seeing LLVM ERROR: out of memory on our 2-stage LTO Linux builders after this change landed. It looks like linking clang-repl always fails on our bot, but I've also seen OOM when linking ClangCodeGenTests and FrontendTests. Do you have any idea why this could be happening? We'd appreciate any help since our bots have been broken for several days now.

Tue, May 18, 9:52 AM · Restricted Project

Fri, May 14

phosek added a comment to D101479: [Driver] Support libc++ in MSVC.

Ping, is this OK to land?

Fri, May 14, 6:38 PM · Restricted Project
phosek accepted D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia.

LGTM

Fri, May 14, 12:37 PM · Restricted Project

Thu, May 13

phosek added inline comments to D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia.
Thu, May 13, 7:06 PM · Restricted Project

May 13 2021

phosek accepted D101681: [Compiler-rt] Distinguish between testing just built runtime libraries and the libraries shipped with the compiler..

LGTM

May 13 2021, 2:06 PM · Restricted Project

May 12 2021

phosek added inline comments to D102039: [profile] WIP Add binary id into profiles.
May 12 2021, 11:33 PM · Restricted Project, Restricted Project
phosek added inline comments to D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia.
May 12 2021, 11:17 PM · Restricted Project
phosek added inline comments to D101139: Create install targets for scan-build-py..
May 12 2021, 10:30 AM · Restricted Project

May 11 2021

phosek committed rG8280ece0c972: [Coverage] Support overriding compilation directory (authored by phosek).
[Coverage] Support overriding compilation directory
May 11 2021, 3:27 PM
phosek closed D100232: [Coverage] Support overriding compilation directory.
May 11 2021, 3:27 PM · Restricted Project
phosek closed D100535: [llvm-cov] Support for v4 format in convert-for-testing.
May 11 2021, 3:26 PM · Restricted Project
phosek updated the diff for D100232: [Coverage] Support overriding compilation directory.
May 11 2021, 3:25 PM · Restricted Project
phosek committed rG489a3531a42f: [llvm-cov] Support for v4 format in convert-for-testing (authored by phosek).
[llvm-cov] Support for v4 format in convert-for-testing
May 11 2021, 2:42 PM

May 10 2021

phosek accepted D102030: [clang][Fuchsia] Introduce compat multilibs.

LGTM

May 10 2021, 11:09 AM · Restricted Project
phosek added inline comments to D102039: [profile] WIP Add binary id into profiles.
May 10 2021, 11:06 AM · Restricted Project, Restricted Project