Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (210 w, 5 d)

Recent Activity

Wed, Mar 13

phosek added inline comments to D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Wed, Mar 13, 2:26 PM · Restricted Project
phosek added inline comments to D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Wed, Mar 13, 12:27 AM · Restricted Project

Tue, Mar 12

phosek added inline comments to D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Tue, Mar 12, 10:36 PM · Restricted Project
phosek accepted D59248: [libc++] Do not share an object library to create the static/shared libraries.

LGTM, this looks great, I think we should do the same for libc++abi and libunwind. I've added @smeenai since he has CMake expertise.

Tue, Mar 12, 11:07 AM
phosek added a reviewer for D59248: [libc++] Do not share an object library to create the static/shared libraries: smeenai.
Tue, Mar 12, 11:07 AM
phosek added a parent revision for D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux: D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Tue, Mar 12, 9:38 AM · Restricted Project
phosek added a child revision for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation: D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Tue, Mar 12, 9:38 AM · Restricted Project, Restricted Project
phosek updated the summary of D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Tue, Mar 12, 9:36 AM · Restricted Project
phosek created D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux.
Tue, Mar 12, 9:36 AM · Restricted Project
phosek added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/.

I don't think the duplicated triple is too huge of a deal. I think the layout where the resource directory is moved inside the triple directory is a bit nicer, but I also don't know how much work that change would be and if it's worth it.

Tue, Mar 12, 12:54 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 11

phosek committed rG930d46a2ef63: [Driver] Support object files in addition to static and shared libraries in… (authored by phosek).
[Driver] Support object files in addition to static and shared libraries in…
Mon, Mar 11, 7:15 PM
phosek committed rC355891: [Driver] Support object files in addition to static and shared libraries in….
[Driver] Support object files in addition to static and shared libraries in…
Mon, Mar 11, 7:15 PM
phosek committed rL355891: [Driver] Support object files in addition to static and shared libraries in….
[Driver] Support object files in addition to static and shared libraries in…
Mon, Mar 11, 7:15 PM
phosek closed D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt.
Mon, Mar 11, 7:14 PM · Restricted Project, Restricted Project
phosek added a comment to D59170: [lld] [ELF] Print a better error for an archive containing a non-ELF file..

This seems to be failing on our Mac bots for some reason:

Mon, Mar 11, 7:08 PM · Restricted Project
phosek created D59225: [profile] Support for GCDA profiling in Fuchsia.
Mon, Mar 11, 11:53 AM · Restricted Project, Restricted Project
phosek updated the diff for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Mon, Mar 11, 12:57 AM · Restricted Project, Restricted Project

Sat, Mar 9

phosek committed rGb68566aec32d: [runtime] Use --strip-all rather than --strip-sections (authored by phosek).
[runtime] Use --strip-all rather than --strip-sections
Sat, Mar 9, 8:27 PM
phosek committed rL355783: [runtime] Use --strip-all rather than --strip-sections.
[runtime] Use --strip-all rather than --strip-sections
Sat, Mar 9, 8:26 PM
phosek closed D59184: [runtime] Use --strip-all rather than --strip-sections.
Sat, Mar 9, 8:26 PM · Restricted Project
phosek created D59184: [runtime] Use --strip-all rather than --strip-sections.
Sat, Mar 9, 6:23 PM · Restricted Project

Fri, Mar 8

phosek committed rGaac819b84442: [CMake] Support stripping and linking output to .build-id directory (authored by phosek).
[CMake] Support stripping and linking output to .build-id directory
Fri, Mar 8, 5:28 PM
phosek committed rL355765: [CMake] Support stripping and linking output to .build-id directory.
[CMake] Support stripping and linking output to .build-id directory
Fri, Mar 8, 5:28 PM
phosek committed rC355765: [CMake] Support stripping and linking output to .build-id directory.
[CMake] Support stripping and linking output to .build-id directory
Fri, Mar 8, 5:28 PM
phosek closed D59127: [CMake] Support stripping and linking output to .build-id directory.
Fri, Mar 8, 5:28 PM · Restricted Project, Restricted Project
phosek added inline comments to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/.
Fri, Mar 8, 5:28 PM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/.
Fri, Mar 8, 5:28 PM · Restricted Project, Restricted Project, Restricted Project
phosek added inline comments to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/.
Fri, Mar 8, 5:17 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/.

The layout currently looks as follows:

Fri, Mar 8, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/.

This is a reland of D59013, apart from fixing the failing test on Windows, it also changes one thing where libraries are installed in lib/clang/<target> rather than lib/<target> based on the discussion in "RFC: Place libs in Clang-dedicated directories (affects openmp, libcxx, libunwind, compiler-rt)".
"

Fri, Mar 8, 5:09 PM · Restricted Project, Restricted Project, Restricted Project
phosek created D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/.
Fri, Mar 8, 5:08 PM · Restricted Project, Restricted Project, Restricted Project
phosek accepted D58317: [clang] Add install targets for API headers.

LGTM

Fri, Mar 8, 3:26 PM · Restricted Project, Restricted Project
phosek updated the diff for D59127: [CMake] Support stripping and linking output to .build-id directory.

I've updated the patch to make the .build-id linking an option that can be set in the cache file, how does that look to you?

Fri, Mar 8, 3:18 PM · Restricted Project, Restricted Project
Herald added a project to D56928: Support attribute used in member funcs of class templates: Restricted Project.

This broke the 2-stage LTO build of LLVM, the error is:

ld.lld: /usr/local/google/home/phosek/clang-llvm/llvm-project/llvm/lib/IR/Constants.cpp:995: static llvm::Constant *llvm::ConstantArray::getImpl(llvm::ArrayType *, ArrayRef<llvm::Constant *>): Assertion `V[i]->getType() == Ty->getElementType() && "Wrong type in array element initializer"' failed.
Fri, Mar 8, 11:49 AM · Restricted Project
phosek added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Fri, Mar 8, 11:21 AM · Restricted Project

Thu, Mar 7

phosek added inline comments to D59127: [CMake] Support stripping and linking output to .build-id directory.
Thu, Mar 7, 11:21 PM · Restricted Project, Restricted Project
phosek created D59127: [CMake] Support stripping and linking output to .build-id directory.
Thu, Mar 7, 11:17 PM · Restricted Project, Restricted Project
phosek committed rGbd83f7097c52: [Clang] Include the test directory ommited in r355665 (authored by phosek).
[Clang] Include the test directory ommited in r355665
Thu, Mar 7, 10:16 PM
phosek committed rC355666: [Clang] Include the test directory ommited in r355665.
[Clang] Include the test directory ommited in r355665
Thu, Mar 7, 10:15 PM
phosek committed rL355666: [Clang] Include the test directory ommited in r355665.
[Clang] Include the test directory ommited in r355665
Thu, Mar 7, 10:15 PM
phosek committed rCXXA355665: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
Thu, Mar 7, 10:07 PM
phosek committed rUNW355665: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
Thu, Mar 7, 9:59 PM
phosek committed rCXX355665: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
Thu, Mar 7, 9:36 PM
phosek committed rG28302c66d258: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ (authored by phosek).
[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
Thu, Mar 7, 9:35 PM
phosek committed rC355665: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
Thu, Mar 7, 9:35 PM
phosek committed rL355665: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/
Thu, Mar 7, 9:34 PM
phosek closed D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Thu, Mar 7, 9:34 PM · Restricted Project, Restricted Project, Restricted Project
phosek added inline comments to D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2].
Thu, Mar 7, 7:41 PM · Restricted Project
phosek added a comment to D59120: [ELF] Sort notes by alignment in decreasing order.

Would be nice to have a test where 2 sections are out of order, and this change puts them into the correct order. It's not clear from this if the build ID section is naturally placed at the end or not.

Thu, Mar 7, 5:42 PM · Restricted Project
phosek created D59120: [ELF] Sort notes by alignment in decreasing order.
Thu, Mar 7, 5:08 PM · Restricted Project
phosek added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

@joerg is it okay with you if I go ahead and land this?

Thu, Mar 7, 4:14 PM · Restricted Project, Restricted Project
phosek updated the diff for D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Thu, Mar 7, 3:40 PM · Restricted Project, Restricted Project, Restricted Project
phosek added inline comments to D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Thu, Mar 7, 12:59 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 6

phosek updated the diff for D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Wed, Mar 6, 11:35 PM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Wed, Mar 6, 10:26 PM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Wed, Mar 6, 7:50 PM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt.
Wed, Mar 6, 12:13 PM · Restricted Project, Restricted Project
phosek added inline comments to D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Wed, Mar 6, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Wed, Mar 6, 9:32 AM · Restricted Project, Restricted Project
phosek created D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/.
Wed, Mar 6, 12:11 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 5

phosek added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Tue, Mar 5, 6:58 PM · Restricted Project, Restricted Project

Mon, Mar 4

phosek accepted D58862: [cmake] Create exports for umbrella library targets.

LGTM

Mon, Mar 4, 4:32 PM · Restricted Project, Restricted Project

Fri, Mar 1

phosek added a comment to D58374: [Clang][NewPM] Don't bail out if the target machine is empty.

Maybe update at least some of the tests using these targets to additionally run with the new pass manager explicitly enabled via flag?

Fri, Mar 1, 4:16 PM · Restricted Project
phosek updated the diff for D58374: [Clang][NewPM] Don't bail out if the target machine is empty.
Fri, Mar 1, 4:16 PM · Restricted Project

Thu, Feb 28

phosek updated the diff for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Thu, Feb 28, 11:40 PM · Restricted Project, Restricted Project
phosek added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Thu, Feb 28, 11:40 PM · Restricted Project, Restricted Project
phosek added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

I was trying to build compiler-rt with WebAssembly and forgot I still had this patched applied. But it looks like it breaks when doing this and things work if you disble crt. You probably just don't want to build crt with WebAssembly targets?

Thu, Feb 28, 10:26 PM · Restricted Project, Restricted Project
phosek accepted D58791: [build] Rename clang-headers to clang-resource-headers.

LGTM

Thu, Feb 28, 6:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek committed rUNW355142: [CMake][libunwind] Define add_target_flags which is missing.
[CMake][libunwind] Define add_target_flags which is missing
Thu, Feb 28, 3:12 PM
phosek committed rGdc1b8e9f4478: [CMake][libunwind] Define add_target_flags which is missing (authored by phosek).
[CMake][libunwind] Define add_target_flags which is missing
Thu, Feb 28, 1:39 PM
phosek committed rL355142: [CMake][libunwind] Define add_target_flags which is missing.
[CMake][libunwind] Define add_target_flags which is missing
Thu, Feb 28, 1:38 PM
phosek closed D58745: [CMake][libunwind] Define add_target_flags which is missing.
Thu, Feb 28, 1:38 PM · Restricted Project

Wed, Feb 27

phosek added a comment to D58533: [hwasan, asan] Intercept vfork..

r355064 should do this.

Wed, Feb 27, 7:02 PM · Restricted Project, Restricted Project
phosek added a reviewer for D58745: [CMake][libunwind] Define add_target_flags which is missing: smeenai.
Wed, Feb 27, 5:29 PM · Restricted Project
phosek added a comment to D58533: [hwasan, asan] Intercept vfork..

This broke our builders with the following error:

Wed, Feb 27, 5:27 PM · Restricted Project, Restricted Project
phosek updated the diff for D58745: [CMake][libunwind] Define add_target_flags which is missing.
Wed, Feb 27, 4:01 PM · Restricted Project
phosek added a comment to D57670: [CMake] Support CMake variables for setting target, sysroot and toolchain.

Done in D58745.

Wed, Feb 27, 3:35 PM · Restricted Project
phosek created D58745: [CMake][libunwind] Define add_target_flags which is missing.
Wed, Feb 27, 3:35 PM · Restricted Project

Tue, Feb 26

phosek updated the diff for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Tue, Feb 26, 8:07 PM · Restricted Project, Restricted Project
phosek added a comment to D57872: [CMake] Split linked libraries for shared and static libc++.
combining these together in LIBCXX_LIBRARIES and LIBCXX_INTERFACE_LIBRARIES can introduce unnecessary dependencies.

Can you provide an example? And elaborate on the introducing unused libraries on the link line?

Tue, Feb 26, 12:20 PM · Restricted Project
phosek updated the diff for D57872: [CMake] Split linked libraries for shared and static libc++.
Tue, Feb 26, 12:20 PM · Restricted Project
phosek added a comment to D58375: [Clang][NewPM] Disable tests that are broken under new PM.

Ping?

Tue, Feb 26, 11:39 AM · Restricted Project
phosek added a comment to D58374: [Clang][NewPM] Don't bail out if the target machine is empty.

Ping?

Tue, Feb 26, 11:38 AM · Restricted Project

Mon, Feb 25

phosek committed rT354835: [CMake] Support alternative C++ ABI library.
[CMake] Support alternative C++ ABI library
Mon, Feb 25, 5:17 PM
phosek committed rL354835: [CMake] Support alternative C++ ABI library.
[CMake] Support alternative C++ ABI library
Mon, Feb 25, 4:42 PM
phosek closed D58598: [CMake] Support alternative C++ ABI library.
Mon, Feb 25, 4:42 PM · Restricted Project
phosek added inline comments to D58598: [CMake] Support alternative C++ ABI library.
Mon, Feb 25, 2:14 PM · Restricted Project
phosek added inline comments to D58598: [CMake] Support alternative C++ ABI library.
Mon, Feb 25, 2:13 PM · Restricted Project
phosek updated the diff for D58598: [CMake] Support alternative C++ ABI library.
Mon, Feb 25, 12:14 PM · Restricted Project
phosek added inline comments to D58598: [CMake] Support alternative C++ ABI library.
Mon, Feb 25, 12:13 AM · Restricted Project

Sun, Feb 24

phosek created D58598: [CMake] Support alternative C++ ABI library.
Sun, Feb 24, 4:51 PM · Restricted Project
phosek updated the diff for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Sun, Feb 24, 2:57 PM · Restricted Project, Restricted Project
phosek added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

For the clang side, I don't understand why Driver::GetFilePath is not good enough. This shouldn't need all toolchain changes at all.

Sun, Feb 24, 2:57 PM · Restricted Project, Restricted Project
phosek updated the diff for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Sun, Feb 24, 2:37 PM · Restricted Project, Restricted Project

Wed, Feb 20

phosek added a comment to D58317: [clang] Add install targets for API headers.

I'm not entirely happy with the name clang-dev-headers, and am open to suggestions. It's unfortunate clang-headers was already taken for something different, but renaming that target or increasing its scope seems bad for existing users. Other possibilities I thought of include clang-tooling-headers, though that might be confused with the headers for libTooling specifically, and clang-library-headers. I'm open to suggestions.

We could consider renaming clang-headers to e.g. clang-resource-headers and then reusing the name which would match llvm-headers. What do you think about that?

I like that, but I'm worried about breaking existing users of the clang-headers target (e.g. in their build scripts or distributions). I could post on cfe-dev and wait for dissent/consensus, I guess, but if there's an option which doesn't involve breaking backward compatibility, maybe that's preferable.

Wed, Feb 20, 3:38 PM · Restricted Project, Restricted Project
phosek added a comment to D58317: [clang] Add install targets for API headers.

I'm not entirely happy with the name clang-dev-headers, and am open to suggestions. It's unfortunate clang-headers was already taken for something different, but renaming that target or increasing its scope seems bad for existing users. Other possibilities I thought of include clang-tooling-headers, though that might be confused with the headers for libTooling specifically, and clang-library-headers. I'm open to suggestions.

Wed, Feb 20, 3:11 PM · Restricted Project, Restricted Project
phosek committed rG9aefd7f55411: [CMake][runtimes] Set clang-header dependency for builtins (authored by phosek).
[CMake][runtimes] Set clang-header dependency for builtins
Wed, Feb 20, 3:06 PM
phosek committed rL354524: [CMake][runtimes] Set clang-header dependency for builtins.
[CMake][runtimes] Set clang-header dependency for builtins
Wed, Feb 20, 3:06 PM
phosek closed D58471: [CMake][runtimes] Set clang-header dependency for builtins.
Wed, Feb 20, 3:06 PM · Restricted Project
phosek accepted D58284: [clang] Switch to LLVM_ENABLE_IDE.

LGTM

Wed, Feb 20, 3:06 PM · Restricted Project, Restricted Project