No longer needed since D62048 has landed.

We (Fuchsia) would like to see this landed as well so we can start using this in our kernel.

@bd1976llvm do you plan on landing this? We'd really like to start using this feature.

LGTM, would it be possible to land this?

In D59464#1505682, @Szelethus wrote:

In that case, feel free to revert this. If around 11:00 CET time I tried to recommit with a possible fix (while watching your bots), would that be an issue?

In D59464#1505463, @NoQ wrote:

Can we have a full build log?

In D59464#1505323, @Szelethus wrote:

I started to land other patches as well that depend on this one -- I won't object, but I'd prefer to find a solution, mostly because I don't even know how I could reproduce this error. The thing is, I merely moved some files from one directory to the other, which makes me scratch my head even more. That being said -- (see inlines)

All our bots are failing which seems to have been caused by the latest reland:

FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793)
******************** TEST 'Clang :: Analysis/checker-plugins.c' FAILED ********************
Script:
--
: 'RUN: at line 1';   /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range -verify /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c    -load /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/SampleAnalyzerPlugin.so    -analyzer-checker='example.MainCallChecker'
: 'RUN: at line 15';   /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c    -load /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/CheckerDependencyHandlingAnalyzerPlugin.so   -analyzer-checker=example.DependendentChecker    -analyzer-list-enabled-checkers    2>&1 | /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c -check-prefix=CHECK-IMPLICITLY-ENABLED
: 'RUN: at line 24';   /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/clang -cc1 -internal-isystem /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/lib/clang/9.0.0/include -nostdsysteminc -analyze -analyzer-constraints=range /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c    -load /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/./lib/CheckerDependencyHandlingAnalyzerPlugin.so   -analyzer-checker=example.DependendentChecker    -analyzer-disable-checker=example.Dependency    -analyzer-list-enabled-checkers    2>&1 | /b/s/w/ir/k/recipe_cleanup/clangsCGbgY/llvm_build_dir/bin/FileCheck /b/s/w/ir/k/llvm-project/clang/test/Analysis/checker-plugins.c -check-prefix=CHECK-IMPLICITLY-DISABLED
--
Exit Code: 1

In D61797#1498367, @thakis wrote:

lgtm, but shouldn't we set this globally for all projects?

This change broke our build which is using Clang and the x86_64-windows-msvc target to cross-compile our EFI bootloader. Now the compilation fails because it cannot find Windows headers (as expected). We're probably going to work around the issue by setting -U_MSC_VER, but I'm going to start a discussion whether we should maybe define a new target for EFI.

LGTM but you may want to wait for @kcc @morehouse @vitalybuka to take a look as well since they're the owners.

LGTM

In D49587#1488328, @smeenai wrote:

Seems like you got the wrong diff.

LGTM

LGTM

We're seeing a failing assertion when building Skia for AArch64 which seems to have been introduced by this change, see PR41738 for more details.

Turned out this is not the right approach because not every linker supports --push-state/--pop-state but I'm hoping to instead rely on ELF autolinking once D60274 lands.

LGTM although we're still missing tests for libunwind, libcxxabi and libcxx.

Not yet, but it'll probably need to be reworked given all the changes that landed in libc++.

In D61456#1488383, @thakis wrote:

Thanks! This is incomplete:

• Create clangd_lit_site_cfg_files.gni next to this build file, but path to generated files there
• Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn and add remapping there
  
  Else out/gn/bin/llvm-lit clang-tools-extra/clangd/test/path/to/test won't work.
  
  Compare to all the other test targets (e.g. clang-tools-extra) for an example.

LGTM, thanks!

In D60253#1455118, @thakis wrote:

Cool! Do you think we could maybe do one patch for unwind, libcxxabi, libcxx each? (Probably in that order.)