Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (201 w, 6 d)

Recent Activity

Yesterday

phosek committed rCXX351220: [libc++] Support different libc++ namespaces in the iterator test.
[libc++] Support different libc++ namespaces in the iterator test
Tue, Jan 15, 11:00 AM
phosek committed rL351220: [libc++] Support different libc++ namespaces in the iterator test.
[libc++] Support different libc++ namespaces in the iterator test
Tue, Jan 15, 10:59 AM
phosek closed D56698: [libc++] Support different libc++ namespaces in the iterator test.
Tue, Jan 15, 10:59 AM
phosek accepted D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..

LGTM

Tue, Jan 15, 12:10 AM
phosek accepted D56705: gn build: Make a couple of improvements to the unix toolchain..

LGTM

Tue, Jan 15, 12:09 AM
phosek accepted D56700: gn build: Add a resource_dir.gni file..

LGTM

Tue, Jan 15, 12:09 AM

Mon, Jan 14

phosek added inline comments to D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu,os}..
Mon, Jan 14, 11:06 PM
phosek added inline comments to D56705: gn build: Make a couple of improvements to the unix toolchain..
Mon, Jan 14, 11:01 PM
phosek accepted D56704: gn build: Switch to using current_os in lib/Support/BUILD.gn..

LGTM

Mon, Jan 14, 10:57 PM
phosek added inline comments to D56700: gn build: Add a resource_dir.gni file..
Mon, Jan 14, 8:53 PM
phosek created D56702: [libc++] Use runtime rather then compile-time glibc version check.
Mon, Jan 14, 8:36 PM
phosek created D56701: [libc++] Support compiler-rt builtins library in tests.
Mon, Jan 14, 8:31 PM
phosek created D56699: [libc++] Update lit test configuration.
Mon, Jan 14, 8:27 PM
phosek created D56698: [libc++] Support different libc++ namespaces in the iterator test.
Mon, Jan 14, 8:19 PM
phosek committed rC351145: [CMake][Fuchsia] Synchronize first and second stage builds.
[CMake][Fuchsia] Synchronize first and second stage builds
Mon, Jan 14, 5:18 PM
phosek committed rL351145: [CMake][Fuchsia] Synchronize first and second stage builds.
[CMake][Fuchsia] Synchronize first and second stage builds
Mon, Jan 14, 5:18 PM
phosek closed D56652: [CMake][Fuchsia] Synchronize first and second stage builds.
Mon, Jan 14, 5:18 PM
phosek accepted D56479: [compiler-rt] Add option to disable libc++ build.

Okay, I decided to make it default ON. I think this should be a pretty safe and uncontroversial change at this point?

Mon, Jan 14, 12:13 PM
phosek accepted D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.

LGTM, although I'll probably try to fix the gn help behavior to avoid similar workarounds.

Mon, Jan 14, 1:28 AM

Sun, Jan 13

phosek added inline comments to D56026: [libcxxabi] Support building hermetic static library.
Sun, Jan 13, 7:00 PM
phosek created D56652: [CMake][Fuchsia] Synchronize first and second stage builds.
Sun, Jan 13, 3:15 PM
phosek committed rCXX351027: [libcxx] Mark do_open, do_get and do_close parameters unused when catopen is….
[libcxx] Mark do_open, do_get and do_close parameters unused when catopen is…
Sun, Jan 13, 2:23 PM
phosek committed rL351027: [libcxx] Mark do_open, do_get and do_close parameters unused when catopen is….
[libcxx] Mark do_open, do_get and do_close parameters unused when catopen is…
Sun, Jan 13, 2:19 PM
phosek closed D56023: [libcxx] Mark do_open, do_get and do_close parameters unused when catopen is missing.
Sun, Jan 13, 2:19 PM
phosek updated the diff for D56026: [libcxxabi] Support building hermetic static library.
Sun, Jan 13, 1:46 PM

Fri, Jan 11

phosek added inline comments to D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.
Fri, Jan 11, 8:41 PM
phosek added inline comments to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Fri, Jan 11, 8:36 PM
phosek added inline comments to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Fri, Jan 11, 8:28 PM
phosek accepted D56630: gn build: Unbreak Windows build.

LGTM

Fri, Jan 11, 8:13 PM
phosek added inline comments to D56577: gn build: Add a stage2 toolchain for Android..
Fri, Jan 11, 7:48 AM
phosek added inline comments to D56577: gn build: Add a stage2 toolchain for Android..
Fri, Jan 11, 7:45 AM
phosek added a comment to D56427: gn build: s/root_out_dir/root_build_dir/g in llvm/utils/gn/build/write_cmake_config.gni..

Are all the generated files independent of the target toolchain? The most idiomatic from GN point of view would be to use root_gen_dir for all generated files.

Fri, Jan 11, 7:36 AM

Wed, Jan 9

phosek added a comment to D56479: [compiler-rt] Add option to disable libc++ build.

This also needs to support the runtimes build which defines HAVE_LIBCXX variable when libc++ is being built.

Wed, Jan 9, 9:55 PM

Tue, Jan 8

phosek accepted D56423: gn build: Copy file permissions from input file in configure_file() emulation..

LGTM

Tue, Jan 8, 8:17 PM
phosek added inline comments to D56423: gn build: Copy file permissions from input file in configure_file() emulation..
Tue, Jan 8, 7:54 PM
phosek accepted D56459: gn build: Fix a Python2ism in write_vcsrevision.py..

LGTM

Tue, Jan 8, 6:45 PM
phosek accepted D56420: [gn build] Add a TODO.txt file.

I'd still prefer Markdown, but I'm also used to writing things in Markdown so I don't see that as a downside personally. However, I think it's a minor thing so I'm not going to push for it ;)

Tue, Jan 8, 6:40 PM

Mon, Jan 7

phosek added a comment to D55917: Introduce Fuchsia builder.

Could you clean off the unused imports, please?

Mon, Jan 7, 9:49 PM
phosek updated the diff for D55917: Introduce Fuchsia builder.
Mon, Jan 7, 9:48 PM
phosek accepted D56426: gn build: Stop passing -o to ar..

LGTM

Mon, Jan 7, 8:00 PM
phosek accepted D56420: [gn build] Add a TODO.txt file.

Can we make it .rst or .md so it's formatted nicely when opened e.g. on GitHub?

Mon, Jan 7, 7:46 PM
phosek accepted D56375: [gn build] Update readme.

LGTM

Mon, Jan 7, 7:45 PM
phosek accepted D56374: [gn build] Add build files for llvm/lib/Target/WebAssembly + tests.

LGTM

Mon, Jan 7, 6:13 PM
phosek accepted D56416: [gn build] Add build files for llvm/lib/Target/PowerPC + tests.

LGTM

Mon, Jan 7, 6:11 PM
phosek accepted D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present.

LGTM

Mon, Jan 7, 6:11 PM

Sun, Jan 6

phosek accepted D56371: [gn build] Add build files for llvm/lib/Target/ARM + tests.

LGTM

Sun, Jan 6, 5:23 PM
phosek accepted D56364: [gn build] Add build files for llvm/lib/Target/AArch64 + tests.

LGTM

Sun, Jan 6, 5:22 PM
phosek committed rC350491: [CMake] Use hidden visibility for static libc++ in Fuchsia.
[CMake] Use hidden visibility for static libc++ in Fuchsia
Sun, Jan 6, 12:32 AM
phosek committed rL350491: [CMake] Use hidden visibility for static libc++ in Fuchsia.
[CMake] Use hidden visibility for static libc++ in Fuchsia
Sun, Jan 6, 12:31 AM
phosek closed D55405: [CMake] Use hidden visibility for static libc++ in Fuchsia.
Sun, Jan 6, 12:31 AM

Sat, Jan 5

phosek committed rCXX350489: [libcxx] Support building hermetic static library.
[libcxx] Support building hermetic static library
Sat, Jan 5, 10:18 PM
phosek committed rL350489: [libcxx] Support building hermetic static library.
[libcxx] Support building hermetic static library
Sat, Jan 5, 10:18 PM
phosek closed D55404: [libcxx] Support building static library with hidden visibility.
Sat, Jan 5, 10:18 PM
phosek committed rCRT350488: [compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call.
[compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call
Sat, Jan 5, 9:23 PM
phosek committed rL350488: [compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call.
[compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call
Sat, Jan 5, 9:23 PM
phosek closed D56360: [compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call.
Sat, Jan 5, 9:23 PM
phosek created D56360: [compiler-rt][Fuchsia] Replace _zx_vmar_allocate_old call.
Sat, Jan 5, 8:59 PM
phosek committed rC350486: [CMake][Fuchsia] Enable build ID, relaxations for first stage.
[CMake][Fuchsia] Enable build ID, relaxations for first stage
Sat, Jan 5, 8:19 PM
phosek committed rL350486: [CMake][Fuchsia] Enable build ID, relaxations for first stage.
[CMake][Fuchsia] Enable build ID, relaxations for first stage
Sat, Jan 5, 8:19 PM
phosek closed D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage.
Sat, Jan 5, 8:19 PM
phosek accepted D56219: [gn build] Add build files for LLVM unittests with a custom main() function.

LGTM

Sat, Jan 5, 6:47 PM
phosek created D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage.
Sat, Jan 5, 4:43 PM
phosek committed rL350484: Revert "[CMake][Fuchsia] Enable experimental new pass manager by default".
Revert "[CMake][Fuchsia] Enable experimental new pass manager by default"
Sat, Jan 5, 3:49 PM
phosek committed rC350484: Revert "[CMake][Fuchsia] Enable experimental new pass manager by default".
Revert "[CMake][Fuchsia] Enable experimental new pass manager by default"
Sat, Jan 5, 3:49 PM
phosek committed rL350461: [CMake][Fuchsia] Enable experimental new pass manager by default.
[CMake][Fuchsia] Enable experimental new pass manager by default
Sat, Jan 5, 12:02 AM
phosek committed rL350460: [CMake][Fuchsia] Enable x86 relaxation by default.
[CMake][Fuchsia] Enable x86 relaxation by default
Sat, Jan 5, 12:02 AM
phosek committed rC350461: [CMake][Fuchsia] Enable experimental new pass manager by default.
[CMake][Fuchsia] Enable experimental new pass manager by default
Sat, Jan 5, 12:01 AM
phosek closed D56350: [CMake][Fuchsia] Enable experimental new pass manager by default.
Sat, Jan 5, 12:01 AM
phosek committed rC350460: [CMake][Fuchsia] Enable x86 relaxation by default.
[CMake][Fuchsia] Enable x86 relaxation by default
Sat, Jan 5, 12:01 AM
phosek closed D56349: [CMake][Fuchsia] Enable x86 relaxation by default.
Sat, Jan 5, 12:01 AM
phosek committed rC350459: [CMake][Fuchsia] Enable --build-id linker flag by default.
[CMake][Fuchsia] Enable --build-id linker flag by default
Sat, Jan 5, 12:01 AM
phosek committed rL350459: [CMake][Fuchsia] Enable --build-id linker flag by default.
[CMake][Fuchsia] Enable --build-id linker flag by default
Sat, Jan 5, 12:01 AM
phosek closed D56348: [CMake][Fuchsia] Enable --build-id linker flag by default.
Sat, Jan 5, 12:01 AM

Fri, Jan 4

phosek added a parent revision for D56350: [CMake][Fuchsia] Enable experimental new pass manager by default: D56349: [CMake][Fuchsia] Enable x86 relaxation by default.
Fri, Jan 4, 11:49 PM
phosek added a child revision for D56349: [CMake][Fuchsia] Enable x86 relaxation by default: D56350: [CMake][Fuchsia] Enable experimental new pass manager by default.
Fri, Jan 4, 11:49 PM
phosek added a child revision for D56348: [CMake][Fuchsia] Enable --build-id linker flag by default: D56349: [CMake][Fuchsia] Enable x86 relaxation by default.
Fri, Jan 4, 11:49 PM
phosek added a parent revision for D56349: [CMake][Fuchsia] Enable x86 relaxation by default: D56348: [CMake][Fuchsia] Enable --build-id linker flag by default.
Fri, Jan 4, 11:49 PM
phosek created D56350: [CMake][Fuchsia] Enable experimental new pass manager by default.
Fri, Jan 4, 11:48 PM
phosek created D56349: [CMake][Fuchsia] Enable x86 relaxation by default.
Fri, Jan 4, 11:48 PM
phosek created D56348: [CMake][Fuchsia] Enable --build-id linker flag by default.
Fri, Jan 4, 11:41 PM
phosek accepted D56328: [gn build] Add build files for unittests under llvm/unittests/ExecutionEngine.

LGTM

Fri, Jan 4, 7:30 PM
phosek added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Fri, Jan 4, 6:50 PM
phosek accepted D56330: [gn build] Add build files for unittests that load shared libraries.

LGTM

Fri, Jan 4, 4:25 PM
phosek accepted D56324: [gn build] Add build file for DebugInfoPDBTests.

LGTM but don't forget to update the message.

Fri, Jan 4, 4:03 PM
phosek accepted D56316: [gn build] Add build files for llvm/lib/{LineEditor,Testing/Support,TextAPI}.

LGTM

Fri, Jan 4, 9:05 AM
phosek accepted D56317: [gn build] Add build file for libLTO.dylib.

LGTM

Fri, Jan 4, 9:05 AM
phosek added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Fri, Jan 4, 9:02 AM
phosek accepted D56195: [gn build] Add check-llvm target and make it work.

LGTM

Fri, Jan 4, 9:00 AM
phosek updated the diff for D56305: [AArch64] Support reserving arbitrary general purpose registers.
Fri, Jan 4, 8:58 AM

Thu, Jan 3

phosek created D56305: [AArch64] Support reserving arbitrary general purpose registers.
Thu, Jan 3, 8:23 PM
phosek updated the diff for D55917: Introduce Fuchsia builder.
Thu, Jan 3, 6:38 PM
phosek added a comment to D55917: Introduce Fuchsia builder.

It is better to use the zorg.buildbot.process.factory.LLVMBuildFactory instead of buildbot.process.factory.BuildFactory(). Zorg would assign it to the correct scheduler automatically in this case.

Thu, Jan 3, 6:22 PM

Wed, Jan 2

phosek added a comment to D55917: Introduce Fuchsia builder.

On what commits do you want this builder to do a build?
As it is currently coded it would never work.

Wed, Jan 2, 6:01 PM
phosek updated the diff for D55917: Introduce Fuchsia builder.
Wed, Jan 2, 5:58 PM
phosek accepted D56217: [gn build] Add even more build files for LLVM unittests.

LGTM

Wed, Jan 2, 12:57 PM
phosek accepted D56213: [gn build] Add more build files for LLVM unittests.

LGTM

Wed, Jan 2, 12:43 PM
phosek accepted D56212: [gn build] Start adding build files for LLVM unittests.

LGTM

Wed, Jan 2, 12:42 PM
phosek accepted D56194: [gn build] Add fuzzers in llvm/tools that are needed for check-llvm.

LGTM

Wed, Jan 2, 9:38 AM
phosek accepted D56193: [gn build] Add some llvm/tools: lli, lli-child-target.

LGTM

Wed, Jan 2, 9:34 AM
phosek accepted D56204: [gn build] Add build files for bugpoint-passes and LLVMHello plugins.

LGTM

Wed, Jan 2, 9:30 AM