phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (193 w, 2 d)

Recent Activity

Today

phosek accepted D54345: Add initial scaffolding for the GN build..

LGTM

Fri, Nov 16, 5:31 PM
phosek added a comment to D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option.

Ping?

Fri, Nov 16, 3:33 PM
phosek committed rC347108: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia.
[CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia
Fri, Nov 16, 3:09 PM
phosek committed rL347108: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia.
[CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia
Fri, Nov 16, 3:09 PM
phosek closed D54655: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia.
Fri, Nov 16, 3:09 PM
phosek created D54655: [CMake] Use lld and llvm-objcopy for first stage compiler in Fuchsia.
Fri, Nov 16, 3:05 PM
phosek added inline comments to D54345: Add initial scaffolding for the GN build..
Fri, Nov 16, 8:30 AM

Yesterday

phosek committed rC347026: [CMake] Support cross-compiling with Fuchsia toolchain build.
[CMake] Support cross-compiling with Fuchsia toolchain build
Thu, Nov 15, 8:52 PM
phosek committed rL347026: [CMake] Support cross-compiling with Fuchsia toolchain build.
[CMake] Support cross-compiling with Fuchsia toolchain build
Thu, Nov 15, 8:52 PM
phosek closed D54463: [CMake] Support cross-compiling with Fuchsia toolchain build.
Thu, Nov 15, 8:52 PM
phosek committed rL347025: [CMake] Support cross-compiling with multi-stage builds.
[CMake] Support cross-compiling with multi-stage builds
Thu, Nov 15, 8:50 PM
phosek committed rC347025: [CMake] Support cross-compiling with multi-stage builds.
[CMake] Support cross-compiling with multi-stage builds
Thu, Nov 15, 8:50 PM
phosek closed D54461: [CMake] Support cross-compiling with multi-stage builds.
Thu, Nov 15, 8:50 PM
phosek committed rCRT347022: [compiler-rt] Use exact spelling when building for default target.
[compiler-rt] Use exact spelling when building for default target
Thu, Nov 15, 8:17 PM
phosek committed rL347022: [compiler-rt] Use exact spelling when building for default target.
[compiler-rt] Use exact spelling when building for default target
Thu, Nov 15, 8:17 PM
phosek closed D54612: [compiler-rt] Use exact spelling when building for default target.
Thu, Nov 15, 8:17 PM
phosek updated the diff for D54612: [compiler-rt] Use exact spelling when building for default target.
Thu, Nov 15, 8:16 PM
phosek committed rL347021: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain.
[CMake] Use the correct spelling for armv7 in Fuchsia's toolchain
Thu, Nov 15, 8:12 PM
phosek committed rC347021: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain.
[CMake] Use the correct spelling for armv7 in Fuchsia's toolchain
Thu, Nov 15, 8:12 PM
phosek closed D54613: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain.
Thu, Nov 15, 8:12 PM
phosek created D54613: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain.
Thu, Nov 15, 7:59 PM
phosek created D54612: [compiler-rt] Use exact spelling when building for default target.
Thu, Nov 15, 7:58 PM
phosek committed rL346997: [CMake] Explicitly list Linux targets for Fuchsia toolchain.
[CMake] Explicitly list Linux targets for Fuchsia toolchain
Thu, Nov 15, 2:00 PM
phosek committed rC346997: [CMake] Explicitly list Linux targets for Fuchsia toolchain.
[CMake] Explicitly list Linux targets for Fuchsia toolchain
Thu, Nov 15, 2:00 PM
phosek closed D54598: [CMake] Explicitly list Linux targets for Fuchsia toolchain.
Thu, Nov 15, 2:00 PM
phosek created D54598: [CMake] Explicitly list Linux targets for Fuchsia toolchain.
Thu, Nov 15, 1:08 PM

Wed, Nov 14

phosek added inline comments to D54345: Add initial scaffolding for the GN build..
Wed, Nov 14, 10:21 AM

Tue, Nov 13

phosek committed rL346827: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
[CMake] Include clang-apply-replacements in Fuchsia toolchain
Tue, Nov 13, 8:10 PM
phosek committed rC346827: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
[CMake] Include clang-apply-replacements in Fuchsia toolchain
Tue, Nov 13, 8:10 PM
phosek closed D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
Tue, Nov 13, 8:10 PM
phosek added a comment to D54461: [CMake] Support cross-compiling with multi-stage builds.

Any other comments?

Tue, Nov 13, 5:51 PM
phosek created D54505: [CMake] Include clang-apply-replacements in Fuchsia toolchain.
Tue, Nov 13, 5:48 PM
phosek committed rUNW346820: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
[CMake] Passthrough CFLAGS when checking the compiler-rt path
Tue, Nov 13, 5:19 PM
phosek updated the diff for D54461: [CMake] Support cross-compiling with multi-stage builds.
Tue, Nov 13, 4:18 PM
phosek committed rCXXA346820: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
[CMake] Passthrough CFLAGS when checking the compiler-rt path
Tue, Nov 13, 4:14 PM
phosek committed rCXX346820: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
[CMake] Passthrough CFLAGS when checking the compiler-rt path
Tue, Nov 13, 4:12 PM
phosek committed rCRT346820: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
[CMake] Passthrough CFLAGS when checking the compiler-rt path
Tue, Nov 13, 4:12 PM
phosek committed rL346820: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
[CMake] Passthrough CFLAGS when checking the compiler-rt path
Tue, Nov 13, 4:12 PM
phosek closed D54371: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
Tue, Nov 13, 4:11 PM

Mon, Nov 12

phosek created D54463: [CMake] Support cross-compiling with Fuchsia toolchain build.
Mon, Nov 12, 8:02 PM
phosek added a comment to D54345: Add initial scaffolding for the GN build..

Shouldn't all the GN files have a copyright header?

Mon, Nov 12, 7:47 PM
phosek added a reviewer for D54345: Add initial scaffolding for the GN build.: mcgrathr.
Mon, Nov 12, 7:47 PM
phosek created D54461: [CMake] Support cross-compiling with multi-stage builds.
Mon, Nov 12, 7:18 PM
phosek added inline comments to D54384: [llvm-objcopy] Add --build-id-link-dir flag.
Mon, Nov 12, 11:22 AM

Fri, Nov 9

phosek created D54371: [CMake] Passthrough CFLAGS when checking the compiler-rt path.
Fri, Nov 9, 6:55 PM
phosek committed rCXX346567: [libcxx] Provide thread annotations for shared_mutex.
[libcxx] Provide thread annotations for shared_mutex
Fri, Nov 9, 3:37 PM
phosek committed rL346567: [libcxx] Provide thread annotations for shared_mutex.
[libcxx] Provide thread annotations for shared_mutex
Fri, Nov 9, 3:35 PM
phosek closed D54290: [libcxx] Provide thread annotations for shared_mutex.
Fri, Nov 9, 3:35 PM
phosek added inline comments to D54290: [libcxx] Provide thread annotations for shared_mutex.
Fri, Nov 9, 11:54 AM

Thu, Nov 8

phosek created D54290: [libcxx] Provide thread annotations for shared_mutex.
Thu, Nov 8, 8:29 PM
phosek committed rL346470: [llvm-rc] Support joined or separate spelling for /fo flag.
[llvm-rc] Support joined or separate spelling for /fo flag
Thu, Nov 8, 7:20 PM
phosek closed D54191: [llvm-rc] Support joined or separate spelling for /fo flag.
Thu, Nov 8, 7:20 PM
phosek committed rL346450: [llvm-rc] Support absolute filenames in manifests.
[llvm-rc] Support absolute filenames in manifests
Thu, Nov 8, 3:48 PM
phosek closed D54194: [llvm-rc] Support absolute filenames in manifests.
Thu, Nov 8, 3:48 PM
phosek updated the diff for D54194: [llvm-rc] Support absolute filenames in manifests.
Thu, Nov 8, 3:44 PM

Wed, Nov 7

phosek updated the diff for D54194: [llvm-rc] Support absolute filenames in manifests.

Test added.

Wed, Nov 7, 5:45 PM
phosek updated the diff for D54191: [llvm-rc] Support joined or separate spelling for /fo flag.

Test added, I'd be fine adding tests for more flags in subsequent changes.

Wed, Nov 7, 3:10 PM
phosek committed rL346341: [llvm-mt] Accept and ignore notify_update flag.
[llvm-mt] Accept and ignore notify_update flag
Wed, Nov 7, 10:39 AM
phosek closed D54196: [llvm-mt] Accept and ignore notify_update flag.
Wed, Nov 7, 10:39 AM
phosek committed rCRT346339: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.
[CMake][ASan][HWASan] Set an explicit dependency on libc++ headers
Wed, Nov 7, 10:38 AM
phosek committed rL346339: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.
[CMake][ASan][HWASan] Set an explicit dependency on libc++ headers
Wed, Nov 7, 10:38 AM
phosek closed D54198: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.
Wed, Nov 7, 10:38 AM

Tue, Nov 6

phosek added a comment to D54198: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.

Here's an example of one such failure: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8931024528216969696/+/steps/clang/0/steps/build/0/stdout

Tue, Nov 6, 11:50 PM
phosek added a comment to D54198: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.
Tue, Nov 6, 11:50 PM
phosek created D54198: [CMake][ASan][HWASan] Set an explicit dependency on libc++ headers.
Tue, Nov 6, 11:49 PM
phosek created D54196: [llvm-mt] Accept and ignore notify_update flag.
Tue, Nov 6, 7:27 PM
phosek created D54194: [llvm-rc] Support absolute filenames in manifests.
Tue, Nov 6, 6:14 PM
phosek created D54191: [llvm-rc] Support joined or separate spelling for /fo flag.
Tue, Nov 6, 5:47 PM

Mon, Nov 5

phosek updated subscribers of D54124: [llvm-readelf] Make llvm-readelf more compatible with GNU readelf..

In the "Migrating llvm-objdump and a few other common binutils replacements away from llvm::c" thread, @silvas said:

Mon, Nov 5, 11:15 PM
phosek added a comment to D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option.

@rsmith does this look reasonable to you?

Mon, Nov 5, 7:09 PM

Sun, Nov 4

phosek committed rC346107: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia.
[Driver] Use -Bstatic/dynamic for libc++ on Fuchsia
Sun, Nov 4, 2:42 PM
phosek committed rL346107: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia.
[Driver] Use -Bstatic/dynamic for libc++ on Fuchsia
Sun, Nov 4, 2:42 PM
phosek closed D54082: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia.
Sun, Nov 4, 2:42 PM

Sat, Nov 3

phosek created D54082: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia.
Sat, Nov 3, 9:28 PM
phosek closed D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia.
Sat, Nov 3, 9:28 PM
phosek committed rC346088: [Driver] Always match resource dir in Fuchsia driver tests.
[Driver] Always match resource dir in Fuchsia driver tests
Sat, Nov 3, 8:56 PM
phosek committed rL346088: [Driver] Always match resource dir in Fuchsia driver tests.
[Driver] Always match resource dir in Fuchsia driver tests
Sat, Nov 3, 8:56 PM
phosek closed D54064: [Driver] Always match resource dir in Fuchsia driver tests.
Sat, Nov 3, 8:56 PM

Fri, Nov 2

phosek created D54064: [Driver] Always match resource dir in Fuchsia driver tests.
Fri, Nov 2, 8:03 PM
phosek committed rL346064: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia.
[Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia
Fri, Nov 2, 6:45 PM
phosek committed rC346064: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia.
[Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia
Fri, Nov 2, 6:45 PM
phosek closed D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia.
Fri, Nov 2, 6:45 PM
phosek committed rCRT346063: [compiler-rt] Support for passing through linker flags to libc++ build.
[compiler-rt] Support for passing through linker flags to libc++ build
Fri, Nov 2, 6:40 PM
phosek committed rL346063: [compiler-rt] Support for passing through linker flags to libc++ build.
[compiler-rt] Support for passing through linker flags to libc++ build
Fri, Nov 2, 6:40 PM
phosek closed D54027: [compiler-rt] Support for passing through linker flags to libc++ build.
Fri, Nov 2, 6:40 PM
phosek committed rC346056: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes.
[CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes
Fri, Nov 2, 4:52 PM
phosek committed rL346056: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes.
[CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes
Fri, Nov 2, 4:52 PM
phosek closed D54026: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes.
Fri, Nov 2, 4:52 PM
phosek added a comment to D54026: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes.

So the default is not per-target? It should be.

Fri, Nov 2, 4:50 PM
phosek added a comment to D54027: [compiler-rt] Support for passing through linker flags to libc++ build.

Is it OK to land this now that D54058 has landed?

Fri, Nov 2, 4:49 PM
phosek committed rL346052: [compiler-rt][Fuzzer] Fix the fuzzer test build.
[compiler-rt][Fuzzer] Fix the fuzzer test build
Fri, Nov 2, 4:32 PM
phosek committed rCRT346052: [compiler-rt][Fuzzer] Fix the fuzzer test build.
[compiler-rt][Fuzzer] Fix the fuzzer test build
Fri, Nov 2, 4:32 PM
phosek closed D54058: [compiler-rt][Fuzzer] Fix the fuzzer test build.
Fri, Nov 2, 4:32 PM
phosek added a comment to D54027: [compiler-rt] Support for passing through linker flags to libc++ build.

D54058 is a fix for the broken bot build. I've decided to keep that change separate since it's independent from this change.

Fri, Nov 2, 4:22 PM
phosek created D54058: [compiler-rt][Fuzzer] Fix the fuzzer test build.
Fri, Nov 2, 4:22 PM
phosek added a comment to D54027: [compiler-rt] Support for passing through linker flags to libc++ build.

I'm looking into that issue now, although that's independent from this change.

Fri, Nov 2, 12:48 PM
phosek created D54027: [compiler-rt] Support for passing through linker flags to libc++ build.
Fri, Nov 2, 12:38 AM
phosek created D54026: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes.
Fri, Nov 2, 12:06 AM

Thu, Nov 1

phosek committed rC345889: [CMake][Fuchsia] Don't restrict Linux runtimes to UNIX.
[CMake][Fuchsia] Don't restrict Linux runtimes to UNIX
Thu, Nov 1, 1:38 PM
phosek committed rL345889: [CMake][Fuchsia] Don't restrict Linux runtimes to UNIX.
[CMake][Fuchsia] Don't restrict Linux runtimes to UNIX
Thu, Nov 1, 1:38 PM