Page MenuHomePhabricator

phosek (Petr Hosek)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2015, 5:44 PM (419 w, 4 d)

Recent Activity

Today

phosek added a comment to D146355: [compiler-rt] Allow finding LLVMConfig if CMAKE_FIND_ROOT_PATH_MODE_PACKAGE is set to ONLY.

I still don't understand the motivation behind this change. You already explicitly set CMAKE_FIND_ROOT_PATH_MODE_PACKAGE to ONLY for Android so why do we need to change the default?

Mon, Mar 20, 12:10 PM · Restricted Project

Thu, Mar 16

phosek accepted D146135: [compiler-rt] Avoid signed overflow in floatdidf.c and floatdisf.c.

LGTM

Thu, Mar 16, 12:17 AM · Restricted Project, Restricted Project

Mon, Mar 13

phosek added inline comments to D142986: Enable multilib.yaml in the BareMetal ToolChain.
Mon, Mar 13, 9:43 PM · Restricted Project, Restricted Project
phosek added inline comments to D142933: Add -print-multi-selection-flags-experimental option.
Mon, Mar 13, 9:40 PM · Restricted Project, Restricted Project
phosek added inline comments to D142932: Multilib YAML parsing.
Mon, Mar 13, 9:20 PM · Restricted Project, Restricted Project
phosek added a comment to D142905: [Driver] Change multilib selection algorithm.

I have just one comment related to efficiency, but if it turns out to be too difficult to address, I'd be also fine landing this change as is and addressing that issue in a follow up change.

Mon, Mar 13, 9:03 PM · Restricted Project, Restricted Project
phosek accepted D145999: [RISCV] Reserve X18 by default for Android.

LGTM

Mon, Mar 13, 4:12 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Mar 12

phosek updated the diff for D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Sun, Mar 12, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
phosek reopened D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Sun, Mar 12, 3:59 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Mar 10

phosek committed rGb00aaab730ae: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag (authored by phosek).
[CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag
Fri, Mar 10, 11:36 AM · Restricted Project
phosek closed D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Fri, Mar 10, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Fri, Mar 10, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
phosek accepted D145818: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS..

LGTM

Fri, Mar 10, 11:32 AM · Restricted Project, Restricted Project

Thu, Mar 9

phosek accepted D145725: [Driver] Make -X default for baremetal riscv.

LGTM

Thu, Mar 9, 10:14 PM · Restricted Project, Restricted Project
phosek added a comment to D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.

Ideally we would land D143052 but the 3.20 bump is getting pushed back due to buildbot issues so I'd like to land this in the meantime to unblock other cleanup.

Thu, Mar 9, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
phosek requested review of D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Thu, Mar 9, 11:40 AM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D145596: [runtimes] Fixes building with CMake 3.26..

I have D142957 that's trying to address the same underlying issue and with that change I can build runtimes with CMake 3.26. It needs to be broken up and landed piecemeal which I started (so far I have D143052 and D144440) but haven't finished yet due to a lack of time. I can try to prioritize it.

Thu, Mar 9, 10:15 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

phosek added a comment to D145619: extend llvm variables for build flexibility.

I agree with @smeenai, I think we should try to come with a more maintainable and less error prone approach.

Wed, Mar 8, 11:11 PM · Restricted Project, Restricted Project

Tue, Mar 7

phosek accepted D145443: Use LLVM_USE_SYMLINKS option in install_symlink.

LGTM

Tue, Mar 7, 11:06 PM · Restricted Project, Restricted Project
phosek added a comment to D145449: [Fuchsia] Add LLDB options to stage 1 cmake..

LLVM_ENABLE_PROJECTS is automatically forwarded from stage 1 builds to
stage 2 builds, so setting FUCHSIA_ENABLE_LLDB has no effect on
two-stage builds.

That shouldn't be the case, do you know where it's being passed through?

Tue, Mar 7, 3:13 PM · Restricted Project, Restricted Project
phosek added a comment to D145449: [Fuchsia] Add LLDB options to stage 1 cmake..

LLVM_ENABLE_PROJECTS is automatically forwarded from stage 1 builds to
stage 2 builds, so setting FUCHSIA_ENABLE_LLDB has no effect on
two-stage builds.

Tue, Mar 7, 10:56 AM · Restricted Project, Restricted Project

Mon, Mar 6

phosek requested changes to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.
Mon, Mar 6, 11:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek requested review of D145411: [WIP][Fuchsia] Include baremetal ARM builtins.
Mon, Mar 6, 11:34 AM · Restricted Project, Restricted Project

Fri, Mar 3

phosek accepted D145187: [Fuchsia] Add other necessary components to LLDB install..

LGTM

Fri, Mar 3, 1:40 AM · Restricted Project, Restricted Project
phosek added a comment to D144603: Disable compiler launcher on external projects and multi stage clang.

I think remove the compiler launcher from default pass through flags are fine. What about the using compiler launcher in runtime builds? I don't think we should read CLANG_BOOTSTRAP_PASSTHROUGH to determine if we should pass through compiler launcher flags.

I'd suggest a similar approach, that is remove C_COMPILER_LAUNCHER and CXX_COMPILER_LAUNCHER from the default passthrough list and provide a new LLVM_EXTERNAL_PROJECT_PASSTHROUGH variable.

Will the PASSTHROUGH approach let us choose a different LAUNCHER for the external projects? For example, we could still distribute those compiles, albeit without expecting any caching.

Fri, Mar 3, 1:40 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 1

phosek added a comment to D144603: Disable compiler launcher on external projects and multi stage clang.

I think remove the compiler launcher from default pass through flags are fine. What about the using compiler launcher in runtime builds? I don't think we should read CLANG_BOOTSTRAP_PASSTHROUGH to determine if we should pass through compiler launcher flags.

Wed, Mar 1, 11:24 PM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D144603: Disable compiler launcher on external projects and multi stage clang.

I agree, in that case let's remove C_COMPILER_LAUNCHER;CXX_COMPILER_LAUNCHER from the list of default passthrough variables which seems like a reasonable default, and provide CLANG_BOOTSTRAP_EXTRA_PASSTHROUGH so developers have a way to pass these through to the next stage if they want to.

Wed, Mar 1, 10:46 AM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D144660: [compiler-rt][CMake] Properly set COMPILER_RT_HAS_LLD.

It seems reasonable that COMPILER_RT_HAS_LLD is only set to true when we build lld in LLVM_ENABLE_PROJECTS builds or lld is available in a runtimes build.
I.e. don't consider COMPILER_RT_HAS_LLD true in LLVM_ENABLE_PROJECTS builds when lld comes from the system.

Wed, Mar 1, 12:45 AM · Restricted Project, Restricted Project
phosek added a comment to D144603: Disable compiler launcher on external projects and multi stage clang.

@beanz @smeenai do you have any preferences/other ideas?

Wed, Mar 1, 12:21 AM · Restricted Project, Restricted Project, Restricted Project
phosek added reviewers for D144603: Disable compiler launcher on external projects and multi stage clang: beanz, smeenai.
Wed, Mar 1, 12:21 AM · Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D144603: Disable compiler launcher on external projects and multi stage clang.

A more generic version might be to have a list of variables to (not) passthrough.

Wed, Mar 1, 12:20 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Feb 28

phosek accepted D144998: [llvm] Prevent building for riscv32-unknown-fuchsia.

LGTM

Tue, Feb 28, 11:59 PM · Restricted Project, Restricted Project
phosek accepted D145003: [builtins] Add option to always build int128 routines.

LGTM

Tue, Feb 28, 3:20 PM · Restricted Project, Restricted Project
phosek accepted D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap.

LGTM

Tue, Feb 28, 3:16 PM · Restricted Project, Restricted Project

Sun, Feb 26

phosek added inline comments to D142888: [compiler-rt] Fix building GWPASAN on ARM.
Sun, Feb 26, 12:21 PM · Restricted Project, Restricted Project

Fri, Feb 24

phosek accepted D144573: [z/OS][NFC] Remove obsolete code..
Fri, Feb 24, 12:07 PM · Restricted Project, Restricted Project

Thu, Feb 23

phosek added inline comments to D131618: [clang][llvm][lld] FatLTO Prototype.
Thu, Feb 23, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
phosek added inline comments to D142905: [Driver] Change multilib selection algorithm.
Thu, Feb 23, 12:49 AM · Restricted Project, Restricted Project

Wed, Feb 22

phosek retitled D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag from [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag to [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Wed, Feb 22, 9:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek reopened D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Wed, Feb 22, 9:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Wed, Feb 22, 9:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek added a reverting change for rGefae3174f095: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag: rG24d144571dbf: Revert "[CMake] Unify llvm_check_linker_flag and….
Wed, Feb 22, 9:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek committed rG24d144571dbf: Revert "[CMake] Unify llvm_check_linker_flag and… (authored by phosek).
Revert "[CMake] Unify llvm_check_linker_flag and…
Wed, Feb 22, 9:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek added a reverting change for D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag: rG24d144571dbf: Revert "[CMake] Unify llvm_check_linker_flag and….
Wed, Feb 22, 9:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek added a comment to D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.

Is the intention that we handle this like CMakePolicy.cmake and pull it from the source dir when we build flang, or is it a mistake to move it to the top level?

Wed, Feb 22, 9:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D144542: [Clang] Improve hermeticity of clang_rt tests.

Thanks!

Wed, Feb 22, 1:14 AM · Restricted Project, Restricted Project
phosek added a comment to D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON.

I'm happy to revert this and add --sysroot if you prefer. That would fit with keeping the tests hermetic.

Wed, Feb 22, 12:51 AM · Restricted Project, Restricted Project

Tue, Feb 21

phosek added a comment to D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON.

I missed this change so I apologize for late response, but can you elaborate on why this is needed? Clang first checks the name without architecture and if the file doesn't exist then it'll return the one with architecture unconditionally, see https://github.com/llvm/llvm-project/blob/d61a863050bb4afd22d08bbe53af1e24c0657aba/clang/lib/Driver/ToolChain.cpp#L545. Since there are no files inside https://github.com/llvm/llvm-project/tree/main/clang/test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/arm, it should always return the path with architecture as was the case for the previous version. LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON should play no role here since Clang tests are hermetic (as in they don't rely on runtimes being built).

Tue, Feb 21, 11:53 PM · Restricted Project, Restricted Project
phosek committed rGefae3174f095: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag (authored by phosek).
[CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag
Tue, Feb 21, 8:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek closed D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Tue, Feb 21, 8:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D144400: [runtimes] Remove unused functions from Handle{Libcxx,Libunwind}Flags.cmake.

LGTM

Tue, Feb 21, 2:36 PM · Restricted Project, Restricted Project, Restricted Project
phosek updated the diff for D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Tue, Feb 21, 1:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek requested review of D144520: [libcxx] Provide set_new_handler/get_new_handler on Windows.
Tue, Feb 21, 1:53 PM · Restricted Project, Restricted Project
phosek committed rG1d7dad8ae0d2: [libc][CMake] Missing TableGen include (authored by phosek).
[libc][CMake] Missing TableGen include
Tue, Feb 21, 11:58 AM · Restricted Project, Restricted Project
phosek closed D144435: [libc][CMake] Missing TableGen include.
Tue, Feb 21, 11:58 AM · Restricted Project, Restricted Project
phosek accepted D144509: [CMake] Bumps minimum version to 3.20.0..

LGTM

Tue, Feb 21, 11:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Feb 20

phosek added a reviewer for D144440: [runtimes][CMake] Drop the check to see if linker works: ldionne.
Mon, Feb 20, 5:04 PM · Restricted Project, Restricted Project, Restricted Project
phosek requested review of D144440: [runtimes][CMake] Drop the check to see if linker works.
Mon, Feb 20, 5:04 PM · Restricted Project, Restricted Project, Restricted Project
phosek requested review of D144435: [libc][CMake] Missing TableGen include.
Mon, Feb 20, 3:08 PM · Restricted Project, Restricted Project
phosek updated the diff for D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag.
Mon, Feb 20, 2:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D144398: [runtimes] Remove add_target_flags* functions and use add_flags* instead.

LGTM

Mon, Feb 20, 2:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek accepted D144395: [runtimes] Move common functions from Handle{Libcxx,Libcxxabi,Libunwind}Flags.cmake to runtimes/cmake/Modules/HandleFlags.cmake.

LGTM

Mon, Feb 20, 2:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 17 2023

phosek accepted D144287: [Fuchsia] Enable llvm-driver build.

LGTM

Feb 17 2023, 11:49 AM · Restricted Project, Restricted Project
phosek added a comment to D144252: [runtimes] Synchronize warnings flags between libc++/libc++abi/libunwind.

runtimes/cmake/Modules/WarningFlags.cmake uses target_add_compile_flags_if_supported which is defined in https://github.com/llvm/llvm-project/blob/2b2b8409e6848361577be404bd0ae47a097f0e0c/libcxx/cmake/Modules/HandleLibcxxFlags.cmake#L246. That function uses other functions defined in the same file. That file is also not explicitly included here.

Feb 17 2023, 11:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 15 2023

phosek added a comment to D143468: [CMake] Remove custom ccache CMake logic.

@jrtc27 raises a good point - we have discussed deprecating the option but made it a hard error. Should we instead make it a soft error for now and a hard error later on?

Honestly, I was not expecting this option to be used as much as it seems like it is. So maybe it makes sense to make it a soft error to start.

Any thoughts on this so I can make the appropriate changes?

Feb 15 2023, 11:23 PM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2023

phosek added a comment to D142932: Multilib YAML parsing.

For the existing YAML files within LLVM, we most commonly used the PascalCase for field names and less commonly lisp-case. This change uses camelCase which is unusual and unless there's a particular reason for using this scheme such as compatibility with an existing format, I'd prefer keeping the format consistent with the rest of LLVM and using PascalCase or lisp-case.

Feb 14 2023, 1:35 AM · Restricted Project, Restricted Project
phosek accepted D142893: [NFC] Class for building MultilibSet.

LGTM

Feb 14 2023, 1:16 AM · Restricted Project, Restricted Project
phosek accepted D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags.

LGTM

Feb 14 2023, 12:13 AM · Restricted Project, Restricted Project

Feb 13 2023

phosek accepted D143794: [Fuchsia] Add FUCHSIA_ENABLE_LLDB option..

LGTM

Feb 13 2023, 11:48 AM · Restricted Project, Restricted Project

Feb 12 2023

phosek accepted D143468: [CMake] Remove custom ccache CMake logic.

LGTM

Feb 12 2023, 3:46 PM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2023

phosek updated the diff for D117263: [CMake] Support runtimes targets without specifying triple.
Feb 11 2023, 2:26 PM · Restricted Project, Restricted Project

Feb 7 2023

phosek added a comment to D142932: Multilib YAML parsing.

Do you know if regular expressions are necessary to cover the existing use cases? In our experience, while regular expressions are powerful, they also tend to be error prone and more difficult to reason about. Would glob patterns that are implemented by https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Support/GlobPattern.h be sufficient?

Feb 7 2023, 9:23 PM · Restricted Project, Restricted Project
phosek added inline comments to D142893: [NFC] Class for building MultilibSet.
Feb 7 2023, 8:24 PM · Restricted Project, Restricted Project

Feb 5 2023

phosek reopened D117263: [CMake] Support runtimes targets without specifying triple.
Feb 5 2023, 6:54 PM · Restricted Project, Restricted Project
phosek updated the diff for D117263: [CMake] Support runtimes targets without specifying triple.
Feb 5 2023, 6:54 PM · Restricted Project, Restricted Project
phosek added a reverting change for rGe6975c4ced27: [CMake] Support runtimes targets without specifying triple: rG8dac97efe46b: Revert "[CMake] Support runtimes targets without specifying triple".
Feb 5 2023, 6:52 PM · Restricted Project, Restricted Project
phosek committed rG8dac97efe46b: Revert "[CMake] Support runtimes targets without specifying triple" (authored by phosek).
Revert "[CMake] Support runtimes targets without specifying triple"
Feb 5 2023, 6:52 PM · Restricted Project, Restricted Project
phosek added a reverting change for D117263: [CMake] Support runtimes targets without specifying triple: rG8dac97efe46b: Revert "[CMake] Support runtimes targets without specifying triple".
Feb 5 2023, 6:52 PM · Restricted Project, Restricted Project
phosek accepted D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.

LGTM

Feb 5 2023, 4:10 PM · Restricted Project, Restricted Project
phosek accepted D143355: [RISCV] Default to -ffixed-x18 for Fuchsia.

LGTM

Feb 5 2023, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
phosek accepted D143357: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia.

LGTM

Feb 5 2023, 4:03 PM · Restricted Project, Restricted Project

Feb 4 2023

phosek added inline comments to D142878: Add testing for Fuchsia multilib.
Feb 4 2023, 11:03 PM · Restricted Project, Restricted Project
phosek requested review of D143332: [CMake] Unify compiler-rt flag variables.
Feb 4 2023, 10:23 PM · Restricted Project, Restricted Project
phosek committed rG3fad47a91741: [CMake] Process components and install targets separately (authored by phosek).
[CMake] Process components and install targets separately
Feb 4 2023, 6:46 PM · Restricted Project, Restricted Project
phosek accepted D141808: [Driver] Add --vfsoverlay flag.

LGTM

Feb 4 2023, 3:20 PM · Restricted Project, Restricted Project
phosek accepted D143304: [Coverage] Map regions from system headers.

LGTM

Feb 4 2023, 3:04 PM · Restricted Project, Restricted Project
phosek committed rGe6975c4ced27: [CMake] Support runtimes targets without specifying triple (authored by phosek).
[CMake] Support runtimes targets without specifying triple
Feb 4 2023, 3:00 PM · Restricted Project, Restricted Project
phosek closed D117263: [CMake] Support runtimes targets without specifying triple.
Feb 4 2023, 3:00 PM · Restricted Project, Restricted Project
phosek updated the diff for D117263: [CMake] Support runtimes targets without specifying triple.
Feb 4 2023, 2:43 PM · Restricted Project, Restricted Project
phosek added a comment to D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData.

Another alternative would be to move these classes to the Demangle library.

Feb 4 2023, 10:26 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2023

phosek accepted D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.

LGTM but can you update the change title and description since the original one no longer matches the content of the patch.

Feb 3 2023, 11:02 PM · Restricted Project, Restricted Project
phosek accepted D141460: [bootstrap build] Add libc-hdrgen as a build dep for libc bootstrap build..

LGTM

Feb 3 2023, 10:52 PM · Restricted Project, Restricted Project
phosek accepted D143288: [Fuchsia] Simplified the stage2 build setup.

LGTM

Feb 3 2023, 1:07 PM · Restricted Project, Restricted Project
phosek accepted D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain.

LGTM

Feb 3 2023, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
phosek added inline comments to D143025: [Clang] Add llvm-mt and llvm-rc to Clang bootstrap dependency.
Feb 3 2023, 10:20 AM · Restricted Project, Restricted Project
phosek added inline comments to D143120: [llvm] infer rtlib from triple for codegen decisions.
Feb 3 2023, 1:06 AM · Restricted Project, Restricted Project
phosek added inline comments to D141460: [bootstrap build] Add libc-hdrgen as a build dep for libc bootstrap build..
Feb 3 2023, 1:01 AM · Restricted Project, Restricted Project

Feb 2 2023

phosek added inline comments to D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR.
Feb 2 2023, 11:42 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
phosek added inline comments to D142888: [compiler-rt] Fix building GWPASAN on ARM.
Feb 2 2023, 1:19 AM · Restricted Project, Restricted Project
phosek added inline comments to D142888: [compiler-rt] Fix building GWPASAN on ARM.
Feb 2 2023, 1:18 AM · Restricted Project, Restricted Project