Page MenuHomePhabricator

t.p.northover (Tim Northover)
Lord High Supreme Bullshitter

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2012, 4:53 AM (379 w, 4 d)

Recent Activity

Tue, Jan 14

t.p.northover committed rG77cc690bae31: AArch64: fix bitcode upgrade of @llvm.neon.addp. (authored by t.p.northover).
AArch64: fix bitcode upgrade of @llvm.neon.addp.
Tue, Jan 14, 5:47 AM

Mon, Jan 13

t.p.northover updated the diff for D72331: OpaquePtr: add type to inalloca attribute..

I made the change suggested to Core.cpp style and rebased this patch, and fixed the nullptr issue David pointed out.

Mon, Jan 13, 4:25 AM · Restricted Project, Restricted Project

Thu, Jan 9

t.p.northover committed rGaaebed82473e: Merge remote-tracking branch 'upstream/master' into apple/master (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into apple/master
Thu, Jan 9, 5:46 PM
t.p.northover committed rGdfbcbcc8a57a: AArch64: move Apple codename CPUs to be based on the OSS numbered definitions. (authored by t.p.northover).
AArch64: move Apple codename CPUs to be based on the OSS numbered definitions.
Thu, Jan 9, 5:46 PM
t.p.northover committed rG667e1f71b83c: IR: remove "else" after "return". NFCI. (authored by t.p.northover).
IR: remove "else" after "return". NFCI.
Thu, Jan 9, 7:06 AM

Wed, Jan 8

t.p.northover committed rG903e5c3028d6: AArch64: add missing Apple CPU names and use them by default. (authored by t.p.northover).
AArch64: add missing Apple CPU names and use them by default.
Wed, Jan 8, 1:57 AM
t.p.northover closed D70779: AArch64: add support for newer Apple CPUs.

Thanks Ahmed, pushed:

Wed, Jan 8, 1:56 AM · Restricted Project

Tue, Jan 7

t.p.northover committed rGe130eef58814: OpaquePtr: print byval types containing anonymous types correctly. (authored by t.p.northover).
OpaquePtr: print byval types containing anonymous types correctly.
Tue, Jan 7, 7:15 AM
t.p.northover closed D72323: OpaquePtr: print byval types containing anonymous types correctly..

Thanks Matt. Pushed:

Tue, Jan 7, 7:14 AM · Restricted Project
t.p.northover created D72331: OpaquePtr: add type to inalloca attribute..
Tue, Jan 7, 6:09 AM · Restricted Project, Restricted Project
t.p.northover created D72323: OpaquePtr: print byval types containing anonymous types correctly..
Tue, Jan 7, 4:09 AM · Restricted Project
t.p.northover updated the diff for D72323: OpaquePtr: print byval types containing anonymous types correctly..

Relised I should test all modified places that print attrs.

Tue, Jan 7, 4:09 AM · Restricted Project

Dec 19 2019

t.p.northover committed rG85cb560b8a42: ConstrainedFP: use API compatible with opaque pointers. (authored by t.p.northover).
ConstrainedFP: use API compatible with opaque pointers.
Dec 19 2019, 1:52 PM
t.p.northover closed D71723: ConstrainedFP: use API compatible with opaque pointers..

Thanks Kevin. Committed as 85cb560b8a4.

Dec 19 2019, 1:52 PM · Restricted Project, Restricted Project
t.p.northover created D71723: ConstrainedFP: use API compatible with opaque pointers..
Dec 19 2019, 12:33 PM · Restricted Project, Restricted Project

Dec 12 2019

ahatanaka <ahatanaka@apple.com> committed rG7710e2162bd4: CodeGen: set correct result for atomic compound expressions (authored by t.p.northover).
CodeGen: set correct result for atomic compound expressions
Dec 12 2019, 3:55 PM
t.p.northover committed rG20faea56992f: Fix regression tests. (authored by t.p.northover).
Fix regression tests.
Dec 12 2019, 2:49 PM
t.p.northover committed rGb7d6b0e0fc04: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 2:49 PM
t.p.northover committed rG1856e3af8fad: IR: fix tests after upstream change to print arguments (authored by t.p.northover).
IR: fix tests after upstream change to print arguments
Dec 12 2019, 2:27 PM
t.p.northover committed rGed4961dd2573: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 1:11 PM
t.p.northover committed rG2c8654bae230: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 12:47 PM
t.p.northover committed rG599460c24bb9: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 12:45 PM

Dec 4 2019

t.p.northover added a comment to D70483: AArch64: add FastISel support for arm64_32.

Ping.

Dec 4 2019, 1:39 AM · Restricted Project

Dec 3 2019

t.p.northover updated the diff for D70779: AArch64: add support for newer Apple CPUs.

Stop inheriting CPU features because they aren't necessarily strictly monotonic.

Dec 3 2019, 4:32 AM · Restricted Project
t.p.northover added inline comments to D70779: AArch64: add support for newer Apple CPUs.
Dec 3 2019, 1:51 AM · Restricted Project

Dec 2 2019

t.p.northover accepted D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A.

Why are you only implementing rot90 and rot270 intrinsics? My quick calculations made rot0 and rot90 the natural ones to implement a bog-standard complex multiplication, but even if I slipped up there I'd expect the others to be useful in some situations.

Dec 2 2019, 1:37 AM · Restricted Project, Restricted Project
t.p.northover added a comment to D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A.

Why are you only implementing rot90 and rot270 intrinsics? My quick calculations made rot0 and rot90 the natural ones to implement a bog-standard complex multiplication, but even if I slipped up there I'd expect the others to be useful in some situations.

Dec 2 2019, 1:28 AM · Restricted Project, Restricted Project

Nov 28 2019

t.p.northover added a comment to D70777: AArch64: use some crypto instructions during CodeGen.

In this case, on our CPUs it looks like there's no difference between how an these instructions and a single eor execute in either latency or pipelines. Since the final operation in all of these patterns is an eor anyway, I think that means the it's not a worry.

Nov 28 2019, 1:54 AM · Restricted Project
t.p.northover added a comment to D70779: AArch64: add support for newer Apple CPUs.

Thanks Florian. I'll wait as you suggest.

Nov 28 2019, 1:31 AM · Restricted Project

Nov 27 2019

t.p.northover updated the diff for D70779: AArch64: add support for newer Apple CPUs.

Test updates after switching arm64_32 default CPU to apple-s4.

Nov 27 2019, 5:14 AM · Restricted Project
t.p.northover created D70779: AArch64: add support for newer Apple CPUs.
Nov 27 2019, 5:14 AM · Restricted Project
t.p.northover committed rG31c25fadccec: AArch64: support the Apple NEON syntax for v8.2 crypto instructions. (authored by t.p.northover).
AArch64: support the Apple NEON syntax for v8.2 crypto instructions.
Nov 27 2019, 3:17 AM
t.p.northover created D70777: AArch64: use some crypto instructions during CodeGen.
Nov 27 2019, 3:16 AM · Restricted Project

Nov 26 2019

t.p.northover committed rG78ad22e0cc63: Recommit ARM-NEON: make type modifiers orthogonal and allow multiple modifiers. (authored by t.p.northover).
Recommit ARM-NEON: make type modifiers orthogonal and allow multiple modifiers.
Nov 26 2019, 1:29 AM

Nov 25 2019

t.p.northover added a comment to D69618: NeonEmitter: clean up prototype modifiers.

Sorry about the delay investigating this, your e-mail bypassed my inbox for some reason and I only noticed the issue when Hans reverted the change this afternoon. I'm looking into it now.

Nov 25 2019, 7:43 AM

Nov 21 2019

t.p.northover committed rG5cf58768cb3b: Atomics: support min/max orthogonally (authored by t.p.northover).
Atomics: support min/max orthogonally
Nov 21 2019, 2:40 AM
t.p.northover closed D55562: Atomics: support min/max orthogonally.

Thanks JF. Finally pushed it today:

Nov 21 2019, 2:40 AM · Restricted Project

Nov 20 2019

t.p.northover committed rG3f91705ca54b: ARM-NEON: make type modifiers orthogonal and allow multiple modifiers. (authored by t.p.northover).
ARM-NEON: make type modifiers orthogonal and allow multiple modifiers.
Nov 20 2019, 5:24 AM
t.p.northover committed rGe23d6f3184d3: NeonEmitter: remove special case on casting polymorphic builtins. (authored by t.p.northover).
NeonEmitter: remove special case on casting polymorphic builtins.
Nov 20 2019, 5:24 AM
t.p.northover committed rGdb73bcd98ef4: ARM-NEON: separate soon-to-be conflicting f16 patterns. NFC. (authored by t.p.northover).
ARM-NEON: separate soon-to-be conflicting f16 patterns. NFC.
Nov 20 2019, 5:24 AM
t.p.northover closed D69618: NeonEmitter: clean up prototype modifiers.

Thanks. Pushed it with those suggestions:

Nov 20 2019, 5:24 AM
t.p.northover committed rGb80e483c4205: Update tests after change to llvm-cxxfilt's underscore stripping behaviour. (authored by t.p.northover).
Update tests after change to llvm-cxxfilt's underscore stripping behaviour.
Nov 20 2019, 5:13 AM
t.p.northover created D70483: AArch64: add FastISel support for arm64_32.
Nov 20 2019, 2:41 AM · Restricted Project

Nov 19 2019

t.p.northover committed rG75b5db309439: [docs] Remove dangling parenthesis from documentation (authored by t.p.northover).
[docs] Remove dangling parenthesis from documentation
Nov 19 2019, 12:52 PM

Nov 18 2019

t.p.northover committed rGdea8f3b0a4ea: arm64_32: support function return in FastISel. (authored by t.p.northover).
arm64_32: support function return in FastISel.
Nov 18 2019, 6:40 AM

Nov 14 2019

t.p.northover committed rG232cdb3d3018: ARM: allow rewriting frame indexes for all prefetch variants. (authored by t.p.northover).
ARM: allow rewriting frame indexes for all prefetch variants.
Nov 14 2019, 6:35 AM

Nov 12 2019

t.p.northover added a comment to D63131: arm64_32: implement the desired ABI for the ILP32 triple..

Thanks, I've updated for most of the suggestions and committed it. I'll make the AArch64 naming changes separately if we decide to.

Nov 12 2019, 7:04 AM · Restricted Project
t.p.northover committed rG44e5879f0fb7: AArch64: add arm64_32 support to Clang. (authored by t.p.northover).
AArch64: add arm64_32 support to Clang.
Nov 12 2019, 4:56 AM
t.p.northover added a comment to D69618: NeonEmitter: clean up prototype modifiers.

Ping.

Nov 12 2019, 3:53 AM

Nov 7 2019

t.p.northover committed rG10e0d64337d6: CodeGen: set correct result for atomic compound expressions (authored by t.p.northover).
CodeGen: set correct result for atomic compound expressions
Nov 7 2019, 6:01 AM
t.p.northover closed D67436: CodeGen: set correct result for atomic compound expressions.

Thanks JF.

Nov 7 2019, 6:00 AM · Restricted Project

Nov 6 2019

t.p.northover committed rG59f063b89c51: NeonEmitter: remove special 'a' type modifier. (authored by t.p.northover).
NeonEmitter: remove special 'a' type modifier.
Nov 6 2019, 2:31 AM
t.p.northover closed D69716: NeonEmitter: remove special 'a' modifier..

To github.com:llvm/llvm-project.git

6c2a4f5ff93..59f063b89c5  master -> master
Nov 6 2019, 2:31 AM · Restricted Project
t.p.northover committed rG9577ee84e638: NeonEmitter: switch to enum for internal Type representation. (authored by t.p.northover).
NeonEmitter: switch to enum for internal Type representation.
Nov 6 2019, 2:04 AM
t.p.northover closed D69715: NeonEmitter: change Type representation. NFC..

I guess the extra checks are due to existing code "accidentally" doing the right thing?

Nov 6 2019, 2:04 AM · Restricted Project

Nov 1 2019

t.p.northover updated the diff for D69618: NeonEmitter: clean up prototype modifiers.

Separated off the two features I mentioned as D69715 and D69716.

Nov 1 2019, 7:58 AM
t.p.northover created D69716: NeonEmitter: remove special 'a' modifier..
Nov 1 2019, 7:58 AM · Restricted Project
t.p.northover created D69715: NeonEmitter: change Type representation. NFC..
Nov 1 2019, 7:53 AM · Restricted Project

Oct 31 2019

t.p.northover added a comment to D69618: NeonEmitter: clean up prototype modifiers.

It looks like this patch contains a few other changes, besides the changes to the prototypes. In particular, the change to CGBuiltin.cpp, and there are a few new lines in the .td files that don't correspond to anything in the old versions. Is that accidental, or is it part of cleaning up the prototypes, somehow?

Oct 31 2019, 1:16 AM

Oct 30 2019

t.p.northover created D69618: NeonEmitter: clean up prototype modifiers.
Oct 30 2019, 8:43 AM

Oct 29 2019

t.p.northover committed rG11524ee3aaa2: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 4:50 PM
t.p.northover committed rGb510bd1031a3: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 4:44 PM
t.p.northover committed rG43887f1dd4c4: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 4:43 PM
t.p.northover committed rGcc2aed815cb7: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 4:43 PM
t.p.northover committed rG59507f9c6c03: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 3:36 PM
t.p.northover committed rG5a4928e04d86: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 3:36 PM
t.p.northover committed rG3c5b821f7f08: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 3:35 PM
t.p.northover committed rGda2a88488883: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 3:35 PM
t.p.northover committed rG2b75e43c64bc: [YAML] Fix YAML API usage (authored by thegameg).
[YAML] Fix YAML API usage
Oct 29 2019, 3:33 PM
t.p.northover committed rG2b8d6c24cfc2: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 2:43 PM
t.p.northover committed rG610e11b7b7e2: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 2:41 PM
t.p.northover committed rG7017b536cb19: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 2:09 PM
t.p.northover committed rG56791e498687: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 1:58 PM
t.p.northover committed rGd710453d080b: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 1:57 PM
t.p.northover committed rGbea24bcfdabf: Update internal tool after API change. (authored by t.p.northover).
Update internal tool after API change.
Oct 29 2019, 1:55 PM
t.p.northover committed rG5849603291a6: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 1:55 PM
t.p.northover committed rGd2348adb2ff8: ARM test fixup: allow lr to be used. (authored by t.p.northover).
ARM test fixup: allow lr to be used.
Oct 29 2019, 12:52 PM
t.p.northover committed rG7dba415bcfd2: Fix botched merge (authored by t.p.northover).
Fix botched merge
Oct 29 2019, 12:50 PM
t.p.northover committed rGf997b06f527d: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:50 PM
t.p.northover committed rGb7f8b1324245: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:46 PM
t.p.northover committed rG82f48d03f3fe: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:46 PM
t.p.northover committed rG101e9d787f45: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:46 PM
t.p.northover committed rG97f137c65096: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:45 PM
t.p.northover committed rG71187bf585cb: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:41 PM
t.p.northover committed rG3f6e5d4ea72e: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:41 PM
t.p.northover committed rGd24ccc520dde: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:38 PM
t.p.northover committed rG9e387957e5f7: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by t.p.northover).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Oct 29 2019, 12:24 PM

Oct 17 2019

t.p.northover added inline comments to rL371384: GlobalISel: add combiner to form indexed loads..
Oct 17 2019, 9:37 AM

Oct 16 2019

t.p.northover updated the diff for D63131: arm64_32: implement the desired ABI for the ILP32 triple..

Updating diff. How target features are handled changed slightly upstream.

Oct 16 2019, 10:46 AM · Restricted Project

Oct 10 2019

t.p.northover added a comment to D63131: arm64_32: implement the desired ABI for the ILP32 triple..

Ping.

Oct 10 2019, 7:06 AM · Restricted Project

Oct 9 2019

t.p.northover accepted D68675: [9.0 branch][ARM] VFPv2 only supports 16 D registers..

LGTM!

Oct 9 2019, 4:00 AM · Restricted Project

Oct 4 2019

t.p.northover committed rGa7d90af1be48: ARM-Darwin: keep the frame register reserved even if not updated. (authored by t.p.northover).
ARM-Darwin: keep the frame register reserved even if not updated.
Oct 4 2019, 5:29 AM

Oct 3 2019

t.p.northover accepted D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.

Fair enough. Still fine I think.

Oct 3 2019, 10:35 AM · Restricted Project
t.p.northover accepted D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.

Looks reasonable to me.

Oct 3 2019, 1:05 AM · Restricted Project

Sep 30 2019

t.p.northover committed rG1249126c7c61: Revert "Update polly test for SCEV change." (authored by t.p.northover).
Revert "Update polly test for SCEV change."
Sep 30 2019, 12:50 AM
t.p.northover committed rG58e8c793d0e4: Revert "[SCEV] add no wrap flag for SCEVAddExpr." (authored by t.p.northover).
Revert "[SCEV] add no wrap flag for SCEVAddExpr."
Sep 30 2019, 12:50 AM

Sep 27 2019

t.p.northover added a comment to D67436: CodeGen: set correct result for atomic compound expressions.

Ping.

Sep 27 2019, 1:45 AM · Restricted Project

Sep 20 2019

t.p.northover added a comment to D67485: AArch64: use ldp/stp for atomic & volatile 128-bit where appropriate..

First, it appears that the current codegen (CAS loop) for 128-bit atomic accesses is broken based on this comment: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70814#c3. There are two problematic cases as far as I understand: (1) const and (2) volatile atomic objects. Const objects disallow write access to the underlying memory, volatile objects mandate that each byte of the underlying memory shall be accessed exactly once according to the AAPCS. The CAS loop violates both.

Sep 20 2019, 7:29 AM · Restricted Project

Sep 13 2019

t.p.northover committed rG52a89cc07d80: AArch64: fix EXPENSIVE_CHECKS for arm64_32. (authored by t.p.northover).
AArch64: fix EXPENSIVE_CHECKS for arm64_32.
Sep 13 2019, 11:57 AM
t.p.northover added a comment to rL371722: AArch64: support arm64_32, an ILP32 slice for watchOS..

Thanks for pinging me, I don't get notifications for plain relpies to whatever Phabricator calls this. I'll get it sorted.

Sep 13 2019, 10:09 AM