Page MenuHomePhabricator

VincentWu (Xinlong Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2021, 1:40 AM (63 w, 3 d)

Recent Activity

Feb 28 2022

VincentWu accepted D119530: [RISCV] Add combination crypto extensions in ISAInfo.

LGTM

Feb 28 2022, 10:33 PM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2022

VincentWu added inline comments to D119530: [RISCV] Add combination crypto extensions in ISAInfo.
Feb 16 2022, 7:31 PM · Restricted Project, Restricted Project, Restricted Project
VincentWu added inline comments to D119530: [RISCV] Add combination crypto extensions in ISAInfo.
Feb 16 2022, 7:27 PM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2022

VincentWu added inline comments to D119530: [RISCV] Add combination crypto extensions in ISAInfo.
Feb 13 2022, 1:45 AM · Restricted Project, Restricted Project, Restricted Project

Feb 12 2022

VincentWu added inline comments to D119530: [RISCV] Add combination crypto extensions in ISAInfo.
Feb 12 2022, 10:54 PM · Restricted Project, Restricted Project, Restricted Project

Jan 28 2022

VincentWu accepted D118430: [RISCV] Custom legalize BITREVERSE with Zbkb..

LGTM

Jan 28 2022, 10:26 PM · Restricted Project

Jan 27 2022

VincentWu added a comment to D118430: [RISCV] Custom legalize BITREVERSE with Zbkb..
Jan 27 2022, 10:42 PM · Restricted Project
VincentWu committed rG6a4d3f37b5a7: [RISCV] fix dead code (authored by VincentWu).
[RISCV] fix dead code
Jan 27 2022, 12:00 AM
VincentWu closed D118323: [RISCV] fix dead code.
Jan 27 2022, 12:00 AM · Restricted Project

Jan 26 2022

VincentWu committed rG615d71d9a340: [RISCV][CodeGen] Implement IR Intrinsic support for K extension (authored by VincentWu).
[RISCV][CodeGen] Implement IR Intrinsic support for K extension
Jan 26 2022, 11:53 PM
VincentWu closed D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.
Jan 26 2022, 11:53 PM · Restricted Project
VincentWu requested review of D118323: [RISCV] fix dead code.
Jan 26 2022, 11:51 PM · Restricted Project
VincentWu added inline comments to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Jan 26 2022, 11:32 PM · Restricted Project
VincentWu added a comment to D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

LGTM

Jan 26 2022, 10:27 PM · Restricted Project
VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

rebase & read to submit

Jan 26 2022, 10:24 PM · Restricted Project
VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

update & address comment

Jan 26 2022, 8:01 PM · Restricted Project

Jan 25 2022

VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

remove duplicate code & clang-format

Jan 25 2022, 10:23 PM · Restricted Project
VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

address comments

Jan 25 2022, 9:59 PM · Restricted Project
VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

fix intrinsic and testcase

Jan 25 2022, 5:49 AM · Restricted Project
VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

fix intrinsic

Jan 25 2022, 4:37 AM · Restricted Project
VincentWu updated the summary of D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.
Jan 25 2022, 3:53 AM · Restricted Project
VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

rename testcase

Jan 25 2022, 3:51 AM · Restricted Project
VincentWu updated the diff for D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.

rebase and update

Jan 25 2022, 3:41 AM · Restricted Project

Jan 24 2022

VincentWu commandeered D102310: [RISCV][CodeGen] Implement IR Intrinsic support for K extension.
Jan 24 2022, 6:42 PM · Restricted Project
VincentWu added a comment to D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension .

it is a great work to implement the intrinsic of zbkb.
however, I don't know whether you have noticed that there is already to patch https://reviews.llvm.org/D112774 and https://reviews.llvm.org/D102310.
these two patches have included almost all the work you did in your patch.

Jan 24 2022, 7:43 AM · Restricted Project, Restricted Project

Jan 23 2022

VincentWu added inline comments to D117889: [RISCV] add support for zbkx subextension in MC layer..
Jan 23 2022, 10:56 PM · Restricted Project
VincentWu added inline comments to D117889: [RISCV] add support for zbkx subextension in MC layer..
Jan 23 2022, 10:54 PM · Restricted Project
VincentWu committed rGe29d8fb16978: [RISCV] Initially support the K-extension instructions on the LLVM MC layer (authored by VincentWu).
[RISCV] Initially support the K-extension instructions on the LLVM MC layer
Jan 23 2022, 10:46 PM
VincentWu closed D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Jan 23 2022, 10:45 PM · Restricted Project
VincentWu added a comment to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

LGTM

Jan 23 2022, 8:02 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

rebase

Jan 23 2022, 8:01 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

address comment & remove [RFC] from title

Jan 23 2022, 6:55 PM · Restricted Project

Jan 22 2022

VincentWu accepted D117958: [RISCV] Adjust the header comment in RISCVInstrInfoZb.td to better integrate Zbk* extensions..
Jan 22 2022, 11:57 PM · Restricted Project
VincentWu added a comment to D117958: [RISCV] Adjust the header comment in RISCVInstrInfoZb.td to better integrate Zbk* extensions..

LGTM

Jan 22 2022, 11:51 PM · Restricted Project

Jan 21 2022

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

rebase and update

Jan 21 2022, 7:46 PM · Restricted Project
VincentWu added inline comments to D117889: [RISCV] add support for zbkx subextension in MC layer..
Jan 21 2022, 6:21 PM · Restricted Project
VincentWu added a comment to D117889: [RISCV] add support for zbkx subextension in MC layer..

Revision Contents look weired. Does this patch upload by git diff -U99999?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Jan 21 2022, 6:18 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

updete

Jan 21 2022, 2:53 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

rebase and fix comments

Jan 21 2022, 12:19 AM · Restricted Project

Jan 20 2022

VincentWu updated the diff for D117640: [RISCV][RFC] add inst support of zbkb.

Rebase to latest main.

Jan 20 2022, 6:40 PM · Restricted Project
VincentWu updated the diff for D117640: [RISCV][RFC] add inst support of zbkb.

remove aliases zip/unzip.
change aliase rev.b to brev8

Jan 20 2022, 12:37 AM · Restricted Project

Jan 19 2022

VincentWu added inline comments to D117640: [RISCV][RFC] add inst support of zbkb.
Jan 19 2022, 11:26 PM · Restricted Project
VincentWu updated the diff for D117640: [RISCV][RFC] add inst support of zbkb.

add comment and remove blank line

Jan 19 2022, 12:03 AM · Restricted Project
VincentWu updated the diff for D117640: [RISCV][RFC] add inst support of zbkb.

fix comment

Jan 19 2022, 12:00 AM · Restricted Project

Jan 18 2022

VincentWu updated the diff for D117640: [RISCV][RFC] add inst support of zbkb.

remove folder zbkb

Jan 18 2022, 11:28 PM · Restricted Project
VincentWu updated the summary of D117640: [RISCV][RFC] add inst support of zbkb.
Jan 18 2022, 11:26 PM · Restricted Project
VincentWu requested review of D117640: [RISCV][RFC] add inst support of zbkb.
Jan 18 2022, 11:23 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

emove ext verision number

Jan 18 2022, 7:02 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

add new line at end of file

Jan 18 2022, 12:50 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

fix comment

Jan 18 2022, 12:41 AM · Restricted Project

Jan 17 2022

VincentWu added a comment to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

The latest spec (rc-6) of the scalar crypto extension has been released for almost two months. That means that the scalar crypto extensions have become stable.
Also the GCC seems to have merged the patch for scalar crypto extensions into the upstream
So I think it is time to decide whether this patch should be merged or not.

Jan 17 2022, 12:24 AM · Restricted Project

Jan 16 2022

VincentWu added a comment to D117433: [RISCV] Implement support for the Zicbop extension.

This introduces a bug when disassembling ori with =mattr=+zicbop enabled. I've not investigated further yet.

Jan 16 2022, 11:21 PM · Restricted Project, Restricted Project

Jan 6 2022

VincentWu updated the summary of D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Jan 6 2022, 7:50 AM · Restricted Project

Jan 4 2022

VincentWu updated the summary of D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Jan 4 2022, 10:24 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

fix issues mentioned on comment

Jan 4 2022, 7:20 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Jan 4 2022, 12:32 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

add Entropy Source CSR

Jan 4 2022, 12:22 AM · Restricted Project

Dec 29 2021

VincentWu added a comment to D116350: [RISCV] Modification of RVV CSR test file.

Whether Vector CSRs should be allowed to be accessed when V extensions are not enabled?

I mean, is there a wrong implementation or a wrong test case?

I found this patch where the F extension check was removed from fcsr, fflags, and frm based on binutils not checking. https://reviews.llvm.org/D58932 But it looks like binutils may have implemented checking after that patch https://sourceware.org/legacy-ml/binutils/2019-12/msg00222.html

Dec 29 2021, 10:42 PM · Restricted Project

Dec 28 2021

VincentWu added a comment to D116350: [RISCV] Modification of RVV CSR test file.

Whether Vector CSRs should be allowed to be accessed when V extensions are not enabled?

Dec 28 2021, 8:24 PM · Restricted Project

Oct 19 2021

VincentWu updated the summary of D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Oct 19 2021, 1:29 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

update the code to adopt the spec v1.0.0-rc4
co-worker @achieveartificialintelligence

Oct 19 2021, 1:14 AM · Restricted Project

Oct 18 2021

VincentWu updated the summary of D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Oct 18 2021, 10:42 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Oct 18 2021, 10:40 AM · Restricted Project
VincentWu abandoned D112009: update k-ext to 1.0-rc4.
Oct 18 2021, 8:54 AM · Restricted Project
VincentWu requested review of D112009: update k-ext to 1.0-rc4.
Oct 18 2021, 8:54 AM · Restricted Project
VincentWu abandoned D112007: [RISCV] Initialy support the K-extension instructions on the LLVM MC layer Co-author: QiXing Xue & Xinlong Wu.
Oct 18 2021, 8:49 AM · Restricted Project
VincentWu requested review of D112007: [RISCV] Initialy support the K-extension instructions on the LLVM MC layer Co-author: QiXing Xue & Xinlong Wu.
Oct 18 2021, 8:47 AM · Restricted Project

Sep 11 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
  • [RISCV] style: formate the code of RISCVAsmParser.cpp
Sep 11 2021, 3:19 AM · Restricted Project
VincentWu updated the summary of D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Sep 11 2021, 2:39 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

update the implemention to adopt the spec v1.0.0-rc1
co-worker @lihongliang

Sep 11 2021, 2:37 AM · Restricted Project
VincentWu abandoned D109643: Revert "CI: update gitlab config for newer runners.".
Sep 11 2021, 2:31 AM · Restricted Project
VincentWu updated the diff for D109643: Revert "CI: update gitlab config for newer runners.".

test

Sep 11 2021, 2:30 AM · Restricted Project
VincentWu abandoned D109643: Revert "CI: update gitlab config for newer runners.".
Sep 11 2021, 2:26 AM · Restricted Project
VincentWu requested review of D109643: Revert "CI: update gitlab config for newer runners.".
Sep 11 2021, 2:23 AM · Restricted Project

May 12 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

handle k* extension for ELF attribute

May 12 2021, 10:26 PM · Restricted Project

May 9 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

[RISCV][MC][K-ext] Fix wrong input DAG for ByteSelect cls

May 9 2021, 10:59 PM · Restricted Project

Apr 15 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Apr 15 2021, 8:11 PM · Restricted Project
VincentWu added a comment to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
In D98136#2691388, @Jim wrote:

Revision Contents look weired. Does this patch upload by git diff -U99999?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Apr 15 2021, 7:52 PM · Restricted Project

Apr 14 2021

VincentWu added inline comments to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Apr 14 2021, 11:21 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Apr 14 2021, 11:21 PM · Restricted Project

Apr 4 2021

VincentWu added inline comments to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Apr 4 2021, 11:21 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

Classifies instructions into their corresponding functional subset
add more test case for Zkg&Zkg which share instructions from B ext

Apr 4 2021, 11:18 PM · Restricted Project

Mar 13 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

fix: submit the wrong patch file

Mar 13 2021, 6:19 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
  • style: formate the code
  • refactor: use rcon class to limit the imm range
  • Test: add 64bit test case
  • move test cases
  • fix: fix wrong CHECK-INST
Mar 13 2021, 5:50 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Mar 13 2021, 4:44 AM · Restricted Project

Mar 12 2021

VincentWu added inline comments to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Mar 12 2021, 3:00 AM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Mar 12 2021, 2:59 AM · Restricted Project

Mar 10 2021

VincentWu added inline comments to D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Mar 10 2021, 6:57 PM · Restricted Project

Mar 8 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Mar 8 2021, 2:07 AM · Restricted Project

Mar 7 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

fix: submit wrong patch

Mar 7 2021, 10:14 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

style: formate the whitespace, annotation&code style

Mar 7 2021, 7:56 PM · Restricted Project

Mar 6 2021

VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

typo: RISC-K ->RISC-V

Mar 6 2021, 11:27 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

fix: fix error trailing whitespace when building

Mar 6 2021, 10:50 PM · Restricted Project
VincentWu updated the diff for D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.

refactor: move the definition of the immediate number uimm2 and uimm4

Mar 6 2021, 10:25 PM · Restricted Project
VincentWu requested review of D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer.
Mar 6 2021, 10:05 PM · Restricted Project