Page MenuHomePhabricator

gAlfonso-bit (Alf)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2021, 2:20 PM (8 w, 6 d)

Recent Activity

Today

gAlfonso-bit added a reviewer for D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType: dexonsmith.
Mon, Sep 20, 6:19 AM · Restricted Project
gAlfonso-bit requested review of D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Mon, Sep 20, 6:15 AM · Restricted Project
gAlfonso-bit abandoned D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Mon, Sep 20, 6:09 AM · Restricted Project

Thu, Sep 16

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Thu, Sep 16, 6:28 AM · Restricted Project

Wed, Sep 15

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Wed, Sep 15, 4:37 PM · Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Wed, Sep 15, 4:05 PM · Restricted Project
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@ldionne can you please please merge

Wed, Sep 15, 4:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

Rebased to main

Wed, Sep 15, 12:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Wed, Sep 15, 12:09 PM · Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

git-format

Wed, Sep 15, 12:09 PM · Restricted Project
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@Mordante Alfonso Gregory gfunni234@gmail.com

Wed, Sep 15, 12:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Sep 6

gAlfonso-bit updated the diff for D107715: [libc++][NFC] Resolve Python 2 FIXME.

Rebased to main

Mon, Sep 6, 12:27 PM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

Rebase to Main @ldionne

Mon, Sep 6, 12:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Mon, Sep 6, 12:18 PM · Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Added test to TypePrinter

Mon, Sep 6, 12:13 PM · Restricted Project
gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

@dgoldman May I ask what tests?

Mon, Sep 6, 11:05 AM · Restricted Project

Thu, Sep 2

gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

I put a case for it in the declprinter so it is handled appropriately so it would get the pointee type, whereas before this was neglected.

Other than that, there should be no difference.

It looks like DeclPrinter only uses that method here - so it shouldn't make a difference.

but TypePrinter does call isSpecifierType() so this changes that behavior, right? Can you add a test to TypePrinterTest for this change?

Thu, Sep 2, 7:46 AM · Restricted Project

Tue, Aug 31

gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@ldionne update?

Tue, Aug 31, 9:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Aug 25

gAlfonso-bit added a comment to D107473: [LLVM][LTO][NFC] Resolve FIXME in ThinLTOCodeGenerator.cpp.

Can you unify the duplicated code or just put the FIXME back saying need to fix the duplicated code in the future?

Does the original code break any linter? Or it is just an attempt to rewrite the code using switch?

Wed, Aug 25, 8:42 AM · Restricted Project
gAlfonso-bit updated the diff for D107473: [LLVM][LTO][NFC] Resolve FIXME in ThinLTOCodeGenerator.cpp.

Readded arm64e detection

Wed, Aug 25, 8:34 AM · Restricted Project
gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Does this change the behavior of TypePrinter or DeclPrinter - not sure if there are existing tests for those with ObjC code?

I put a case for it in the declprinter so it is handled appropriately so it would get the pointee type, whereas before this was neglected.

Wed, Aug 25, 8:17 AM · Restricted Project

Tue, Aug 24

gAlfonso-bit edited reviewers for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType, added: marksl; removed: rsmith.
Tue, Aug 24, 8:47 AM · Restricted Project

Mon, Aug 23

gAlfonso-bit added a comment to D106902: [libc][NFC] Add explicit casts to ctype functions.

@sivachandra passed all tests

Mon, Aug 23, 7:38 AM · Restricted Project, Restricted Project
gAlfonso-bit edited reviewers for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType, added: dgoldman; removed: erik.pilkington.
Mon, Aug 23, 7:37 AM · Restricted Project

Sun, Aug 22

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Rebased

Sun, Aug 22, 10:01 AM · Restricted Project
gAlfonso-bit added a reviewer for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType: JDevlieghere.
Sun, Aug 22, 9:56 AM · Restricted Project

Aug 21 2021

gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Passed every test in check-all!

Aug 21 2021, 1:27 PM · Restricted Project

Aug 19 2021

gAlfonso-bit added a comment to D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const..

How do I request it?

Aug 19 2021, 8:15 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D106902: [libc][NFC] Add explicit casts to ctype functions.

The isprint test is still failing. I have left a comment inline explaining why.

BTW, if you need help with building/testing your patches, let me know and I can give you few instructions. Or, you can lookup the command from the builder logs, from here for example: https://lab.llvm.org/buildbot/#/builders/78/builds/1654

Aug 19 2021, 8:10 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.

Resolved all test failures

Aug 19 2021, 8:10 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const..

gentle ping

Aug 19 2021, 8:06 AM · Restricted Project, Restricted Project
gAlfonso-bit edited reviewers for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType, added: erik.pilkington; removed: RKSimon.
Aug 19 2021, 7:52 AM · Restricted Project

Aug 18 2021

gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

I don't think there are any other outstanding issues. Are we good to accept and merge? @ldionne

Aug 18 2021, 9:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 17 2021

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Aug 17 2021, 9:52 AM · Restricted Project
gAlfonso-bit requested review of D108214: [LLVM][AST][NFC] Optimize Indent function.
Aug 17 2021, 9:24 AM

Aug 16 2021

gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.
Aug 16 2021, 10:38 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.
Aug 16 2021, 10:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Rearranged if statements

Aug 16 2021, 10:32 AM · Restricted Project
gAlfonso-bit added inline comments to rG435756206700: [NFC][AArch64] Fix unused var in release build.
Aug 16 2021, 10:19 AM
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@ldionne can we land this please?

Aug 16 2021, 9:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit added inline comments to rG94b4598d77fe: [PS4] stp[n]cpy not available on PS4.
Aug 16 2021, 9:10 AM
gAlfonso-bit added a comment to rG94b4598d77fe: [PS4] stp[n]cpy not available on PS4.

Wait, aren't these functions nonstandard anyway? Why not also say mempcpy isn't available also then (though hopefully it will be soon)

Aug 16 2021, 9:09 AM
gAlfonso-bit added a comment to D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..

Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)?

What's the value in backporting it to 13? It's NFC

Aug 16 2021, 9:07 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to rG92abb1cf90ff: [TypePromotion] Don't mutate the result type of SwitchInst..

should we back port this to release/13x

Aug 16 2021, 9:06 AM
gAlfonso-bit added a comment to D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..

@RKSimon could you commit for me please?

Aug 16 2021, 8:32 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..
Aug 16 2021, 8:12 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..

I do not have commit access.

Aug 16 2021, 8:12 AM · Restricted Project, Restricted Project

Aug 15 2021

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Rebased

Aug 15 2021, 2:38 PM · Restricted Project
gAlfonso-bit added a comment to D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..

Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)?

Aug 15 2021, 9:26 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..
Aug 15 2021, 8:20 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

Rebased to main

Aug 15 2021, 8:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..
Aug 15 2021, 8:17 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..

Rebased to main

Aug 15 2021, 8:17 AM · Restricted Project, Restricted Project

Aug 14 2021

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Add ObjectPointerType to GetBaseType

Aug 14 2021, 1:24 PM · Restricted Project
gAlfonso-bit added inline comments to D102817: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 2.
Aug 14 2021, 11:18 AM · Restricted Project
gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.
Aug 14 2021, 10:54 AM · Restricted Project, Restricted Project

Aug 13 2021

gAlfonso-bit added a comment to D106902: [libc][NFC] Add explicit casts to ctype functions.

The test for isprint is still failing.

Aug 13 2021, 8:09 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.
Aug 13 2021, 8:09 AM · Restricted Project, Restricted Project

Aug 12 2021

gAlfonso-bit added a comment to D106902: [libc][NFC] Add explicit casts to ctype functions.

@sivachandra All rebased

Aug 12 2021, 11:58 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.
Aug 12 2021, 9:03 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit requested review of D107970: [LLVM][Support] Add macOS 12 to Triple.cpp.
Aug 12 2021, 8:56 AM · Restricted Project
gAlfonso-bit edited reviewers for D107469: [LLVM][IR][NFC] Simplify writeDIGenericSubrange, added: dexonsmith; removed: MaskRay.
Aug 12 2021, 8:34 AM · Restricted Project
gAlfonso-bit added a reviewer for D107469: [LLVM][IR][NFC] Simplify writeDIGenericSubrange: MaskRay.
Aug 12 2021, 8:33 AM · Restricted Project
gAlfonso-bit added a comment to D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..
Aug 12 2021, 8:20 AM · Restricted Project, Restricted Project
gAlfonso-bit added a reviewer for D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0: jvesely.
Aug 12 2021, 8:19 AM · Restricted Project
gAlfonso-bit added a reviewer for D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.: RKSimon.
Aug 12 2021, 8:19 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks.

Only clang-tidy is upset and it is falsely flagging "missing" files

Aug 12 2021, 8:18 AM · Restricted Project
gAlfonso-bit added a reviewer for D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.: RKSimon.
Aug 12 2021, 8:17 AM · Restricted Project, Restricted Project
gAlfonso-bit edited reviewers for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType, added: RKSimon; removed: ldionne.
Aug 12 2021, 8:15 AM · Restricted Project
gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)?

Aug 12 2021, 8:13 AM · Restricted Project

Aug 11 2021

gAlfonso-bit updated the diff for D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0.
Aug 11 2021, 11:31 AM · Restricted Project
gAlfonso-bit added a reviewer for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType: ldionne.
Aug 11 2021, 11:19 AM · Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.
Aug 11 2021, 11:03 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@ldionne is this ok? any other changes?

Aug 11 2021, 11:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit abandoned D107240: [LLVM][Support][NFC] Make multiple bitwise MathExtras functions constexpr.

I don't see how to progress here, so I am closing this for now

Aug 11 2021, 10:55 AM · Restricted Project
gAlfonso-bit updated the diff for D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0.
Aug 11 2021, 10:53 AM · Restricted Project
gAlfonso-bit added a comment to D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0.

I don't understand what you are trying to fix. What crashes exactly?

It doesn’t crash anymore, so we can remove the workarounds in place. That’s the point.

Aug 11 2021, 10:07 AM · Restricted Project

Aug 10 2021

gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.
Aug 10 2021, 2:10 PM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks.

Addressed all issues!

Aug 10 2021, 1:19 PM · Restricted Project
gAlfonso-bit updated the diff for D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0.
Aug 10 2021, 1:19 PM · Restricted Project
gAlfonso-bit updated the diff for D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0.
Aug 10 2021, 1:17 PM · Restricted Project
gAlfonso-bit updated the diff for D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0.
Aug 10 2021, 12:12 PM · Restricted Project
gAlfonso-bit requested review of D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0.
Aug 10 2021, 11:01 AM · Restricted Project
gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.
Aug 10 2021, 10:01 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D106902: [libc][NFC] Add explicit casts to ctype functions.

Can you please rebase this so that I can apply and test it?

Aug 10 2021, 9:28 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.

Rebased

Aug 10 2021, 9:27 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.
Aug 10 2021, 9:22 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit added inline comments to rG919f0b4acb03: test commit.
Aug 10 2021, 9:16 AM
gAlfonso-bit added inline comments to rG919f0b4acb03: test commit.
Aug 10 2021, 9:16 AM
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Rebased

Aug 10 2021, 9:07 AM · Restricted Project
gAlfonso-bit updated the diff for D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks.

Removed goto

Aug 10 2021, 9:03 AM · Restricted Project
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.
Aug 10 2021, 8:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit abandoned D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr.
Aug 10 2021, 7:01 AM · Restricted Project

Aug 9 2021

gAlfonso-bit added a comment to D107771: [NFC][libcxxabi] Move PODSmallVector definition to the top of ItaniumDemangle.h.

You should format the changed sections with clang format, which you can do in VSCode

Aug 9 2021, 4:38 PM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.
Aug 9 2021, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

Alright. Thank you!

Aug 9 2021, 12:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit removed a reviewer for D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks: Restricted Project.
Aug 9 2021, 12:41 PM · Restricted Project
gAlfonso-bit updated the diff for D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks.

clang-tidy workaround

Aug 9 2021, 12:41 PM · Restricted Project
gAlfonso-bit removed a reviewer for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project: Restricted Project.
Aug 9 2021, 12:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class..

Removed other changes

Aug 9 2021, 11:48 AM · Restricted Project, Restricted Project