Page MenuHomePhabricator

gAlfonso-bit (Alf)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2021, 2:20 PM (63 w, 16 h)

Recent Activity

May 21 2022

gAlfonso-bit requested review of D126121: Remove undefined behavior in count.c test program [NFC].
May 21 2022, 9:55 AM · Restricted Project, Restricted Project
Herald added a project to D107289: [vim] Fix regexp matching against syntax attribute: Restricted Project.

Any update on this?

May 21 2022, 8:48 AM · Restricted Project, Restricted Project
Herald added a project to D107849: [Libclc] Resolve FIXME: GCN insel crashes when a == 0 or b == 0: Restricted Project.

I tested clang 13 and 14

May 21 2022, 8:41 AM · Restricted Project, Restricted Project
gAlfonso-bit abandoned D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers.

This change is no longer necessary.

May 21 2022, 8:39 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D110179: [NFC][IR] Remove unused assignment to Offset.

Rebased

May 21 2022, 8:32 AM · Restricted Project, Restricted Project
Herald added a project to D110179: [NFC][IR] Remove unused assignment to Offset: Restricted Project.

Any updates on this?

May 21 2022, 8:19 AM · Restricted Project, Restricted Project
gAlfonso-bit abandoned D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.

Obsolete

May 21 2022, 8:10 AM · Restricted Project, Restricted Project

Jan 4 2022

gAlfonso-bit added a comment to D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check.

@aprantl any updates?

Jan 4 2022, 10:06 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.
Jan 4 2022, 10:02 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check.

@xgupta any updates?

Jan 4 2022, 9:58 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.
Jan 4 2022, 9:58 AM · Restricted Project, Restricted Project

Nov 12 2021

gAlfonso-bit added a reviewer for D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers: MaskRay.
Nov 12 2021, 2:59 PM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107715: [libc++][NFC] Resolve Python 2 FIXME.
Nov 12 2021, 10:49 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check.

Yes, the big one being that we don't use GDB and use LLDB instead. @xgupta

Nov 12 2021, 9:28 AM · Restricted Project, Restricted Project
gAlfonso-bit abandoned D107493: Re: Work around non-existence of ElfW(type) macro on FreeBSD.

Will revisit this one day.

Nov 12 2021, 9:17 AM · Restricted Project
gAlfonso-bit abandoned D110196: [IR] Modernize and Cleanup LLVM/IR folder.

Will split this into many patches

Nov 12 2021, 9:16 AM · Restricted Project
gAlfonso-bit added inline comments to D107715: [libc++][NFC] Resolve Python 2 FIXME.
Nov 12 2021, 9:10 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.
Nov 12 2021, 9:06 AM · Restricted Project, Restricted Project

Oct 23 2021

gAlfonso-bit added a comment to D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.

@jdoerfert Thank you, but I do not have commit permissions. Could you please commit this?

Oct 23 2021, 4:17 PM · Restricted Project, Restricted Project
gAlfonso-bit added a reviewer for D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers: dexonsmith.
Oct 23 2021, 9:36 AM · Restricted Project, Restricted Project
gAlfonso-bit requested review of D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers.
Oct 23 2021, 9:36 AM · Restricted Project, Restricted Project

Oct 20 2021

gAlfonso-bit updated the diff for D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.
Oct 20 2021, 12:23 PM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.
Oct 20 2021, 12:21 PM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.
Oct 20 2021, 12:20 PM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.

Addressed issues

Oct 20 2021, 12:10 PM · Restricted Project, Restricted Project
gAlfonso-bit requested review of D112162: [NFC] [LLVM] Fix MaxFixPointIterations typo to match documentation.
Oct 20 2021, 10:53 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Oct 20 2021, 9:01 AM · Restricted Project
gAlfonso-bit updated the diff for D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Rebased to main

Oct 20 2021, 8:01 AM · Restricted Project
gAlfonso-bit added a comment to D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Any updates? I do not have commit permissions. @ahatanak

Oct 20 2021, 7:39 AM · Restricted Project

Oct 2 2021

gAlfonso-bit added a comment to D107715: [libc++][NFC] Resolve Python 2 FIXME.

I do not have commit access. Could someone please land this for me?

Oct 2 2021, 12:50 PM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D110344: [LLVM][IR] Fixed input arguments for Verifier getter.

I do not have commit access. Could someone please land this for me?

Oct 2 2021, 12:50 PM · Restricted Project
gAlfonso-bit added a comment to D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check.

I do not have commit access. Could someone please land this for me?

Oct 2 2021, 12:50 PM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D110477: [LLDB] Fix objc_clsopt_v16_t struct.

Any updates?

This patch is accepted and ready to land. Let me know if you don't have commit access and need someone to land this for you.

Oct 2 2021, 12:49 PM · Restricted Project

Sep 30 2021

gAlfonso-bit abandoned D107473: [LLVM][LTO][NFC] Resolve FIXME in ThinLTOCodeGenerator.cpp.
Sep 30 2021, 2:36 PM · Restricted Project
gAlfonso-bit added a comment to D110477: [LLDB] Fix objc_clsopt_v16_t struct.

Any updates?

Sep 30 2021, 11:37 AM · Restricted Project
gAlfonso-bit added a comment to D110344: [LLVM][IR] Fixed input arguments for Verifier getter.

@jeroen.dobbelaere Is this LGTM now?

Sep 30 2021, 9:50 AM · Restricted Project

Sep 27 2021

gAlfonso-bit removed a reviewer for D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check: dexonsmith.
Sep 27 2021, 10:18 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D110344: [LLVM][IR] Fixed input arguments for Verifier getter.

Removed unneeded change

Sep 27 2021, 9:54 AM · Restricted Project

Sep 25 2021

gAlfonso-bit requested review of D110477: [LLDB] Fix objc_clsopt_v16_t struct.
Sep 25 2021, 6:48 AM · Restricted Project
gAlfonso-bit added a comment to D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check.

This undos commit ba6ec4b70bc49bf8b65b59f64b43df4df3fe786e, which was done in 2015, and a temporary measure. This behavior from clang has changed since then, especially when dealing with GDB.

Sep 25 2021, 6:32 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

I'm a bit hesitant to trust lack of tests as proof that old FIXMEs can be resolved safely. Can you add some background information about why this was originally a specifier, and why it's safe to fix it now? (If you don't know, I suggest looking through git-blame to figure it out (unless @ahatanak already knows?).)

Sep 25 2021, 6:24 AM · Restricted Project
gAlfonso-bit added a comment to D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 25 2021, 6:08 AM · Restricted Project
gAlfonso-bit updated the diff for D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 25 2021, 6:06 AM · Restricted Project
gAlfonso-bit added inline comments to D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 25 2021, 6:05 AM · Restricted Project
gAlfonso-bit edited reviewers for D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check, added: hiraditya; removed: jdoerfert.
Sep 25 2021, 6:03 AM · Restricted Project, Restricted Project
gAlfonso-bit removed a reviewer for D110344: [LLVM][IR] Fixed input arguments for Verifier getter: Restricted Project.
Sep 25 2021, 6:03 AM · Restricted Project
gAlfonso-bit edited reviewers for D110344: [LLVM][IR] Fixed input arguments for Verifier getter, added: hiraditya; removed: jdoerfert.
Sep 25 2021, 6:02 AM · Restricted Project
gAlfonso-bit edited reviewers for D110179: [NFC][IR] Remove unused assignment to Offset, added: jeroen.dobbelaere, hiraditya; removed: ldionne, MaskRay.
Sep 25 2021, 6:02 AM · Restricted Project, Restricted Project
gAlfonso-bit requested review of D110475: [LLVM][IR] Resolve Verifier FIXME: remove if (V->isArtificial()) check.
Sep 25 2021, 6:01 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D110344: [LLVM][IR] Fixed input arguments for Verifier getter.
Sep 25 2021, 5:57 AM · Restricted Project
gAlfonso-bit edited reviewers for D110344: [LLVM][IR] Fixed input arguments for Verifier getter, added: jeroen.dobbelaere, jdoerfert, dexonsmith; removed: MaskRay.
Sep 25 2021, 5:49 AM · Restricted Project

Sep 23 2021

gAlfonso-bit added a comment to D107493: Re: Work around non-existence of ElfW(type) macro on FreeBSD.

Any updates? Should we try to make the macros consistent or should I just abandon this?

Sep 23 2021, 9:40 AM · Restricted Project
gAlfonso-bit planned changes to D110196: [IR] Modernize and Cleanup LLVM/IR folder.
Sep 23 2021, 9:39 AM · Restricted Project
gAlfonso-bit removed a reviewer for D110196: [IR] Modernize and Cleanup LLVM/IR folder: ldionne.
Sep 23 2021, 9:39 AM · Restricted Project
gAlfonso-bit requested review of D110344: [LLVM][IR] Fixed input arguments for Verifier getter.
Sep 23 2021, 9:38 AM · Restricted Project
gAlfonso-bit updated the diff for D110196: [IR] Modernize and Cleanup LLVM/IR folder.
Sep 23 2021, 8:36 AM · Restricted Project
gAlfonso-bit updated the diff for D110196: [IR] Modernize and Cleanup LLVM/IR folder.
Sep 23 2021, 8:13 AM · Restricted Project
gAlfonso-bit updated the diff for D110196: [IR] Modernize and Cleanup LLVM/IR folder.

Fixed clang-tidy

Sep 23 2021, 7:57 AM · Restricted Project

Sep 21 2021

gAlfonso-bit added a reviewer for D110179: [NFC][IR] Remove unused assignment to Offset: MaskRay.
Sep 21 2021, 12:52 PM · Restricted Project, Restricted Project
gAlfonso-bit added reviewers for D110196: [IR] Modernize and Cleanup LLVM/IR folder: dexonsmith, ldionne, MaskRay.
Sep 21 2021, 12:51 PM · Restricted Project
gAlfonso-bit requested review of D110196: [IR] Modernize and Cleanup LLVM/IR folder.
Sep 21 2021, 12:51 PM · Restricted Project
gAlfonso-bit abandoned D107970: [LLVM][Support] Add macOS 12 to Triple.cpp.
Sep 21 2021, 11:53 AM · Restricted Project
gAlfonso-bit added a reviewer for D110179: [NFC][IR] Remove unused assignment to Offset: ldionne.
Sep 21 2021, 9:40 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Rebased to upstream

Sep 21 2021, 8:59 AM · Restricted Project
gAlfonso-bit updated the diff for D110179: [NFC][IR] Remove unused assignment to Offset.
Sep 21 2021, 8:37 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D110179: [NFC][IR] Remove unused assignment to Offset.

Use correct data type

Sep 21 2021, 8:34 AM · Restricted Project, Restricted Project
gAlfonso-bit added a reviewer for D110179: [NFC][IR] Remove unused assignment to Offset: dexonsmith.
Sep 21 2021, 8:15 AM · Restricted Project, Restricted Project
gAlfonso-bit requested review of D110179: [NFC][IR] Remove unused assignment to Offset.
Sep 21 2021, 8:15 AM · Restricted Project, Restricted Project

Sep 20 2021

gAlfonso-bit added a reviewer for D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType: dexonsmith.
Sep 20 2021, 6:19 AM · Restricted Project
gAlfonso-bit requested review of D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 20 2021, 6:15 AM · Restricted Project
gAlfonso-bit abandoned D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 20 2021, 6:09 AM · Restricted Project

Sep 16 2021

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 16 2021, 6:28 AM · Restricted Project

Sep 15 2021

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 15 2021, 4:37 PM · Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 15 2021, 4:05 PM · Restricted Project
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@ldionne can you please please merge

Sep 15 2021, 4:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

Rebased to main

Sep 15 2021, 12:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 15 2021, 12:09 PM · Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

git-format

Sep 15 2021, 12:09 PM · Restricted Project
gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@Mordante Alfonso Gregory gfunni234@gmail.com

Sep 15 2021, 12:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 6 2021

gAlfonso-bit updated the diff for D107715: [libc++][NFC] Resolve Python 2 FIXME.

Rebased to main

Sep 6 2021, 12:27 PM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

Rebased to Main @ldionne

Sep 6 2021, 12:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Sep 6 2021, 12:18 PM · Restricted Project
gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Added test to TypePrinter

Sep 6 2021, 12:13 PM · Restricted Project
gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

@dgoldman May I ask what tests?

Sep 6 2021, 11:05 AM · Restricted Project

Sep 2 2021

gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

I put a case for it in the declprinter so it is handled appropriately so it would get the pointee type, whereas before this was neglected.

Other than that, there should be no difference.

It looks like DeclPrinter only uses that method here - so it shouldn't make a difference.

but TypePrinter does call isSpecifierType() so this changes that behavior, right? Can you add a test to TypePrinterTest for this change?

Sep 2 2021, 7:46 AM · Restricted Project

Aug 31 2021

gAlfonso-bit added a comment to D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project.

@ldionne update?

Aug 31 2021, 9:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 25 2021

gAlfonso-bit added a comment to D107473: [LLVM][LTO][NFC] Resolve FIXME in ThinLTOCodeGenerator.cpp.

Can you unify the duplicated code or just put the FIXME back saying need to fix the duplicated code in the future?

Does the original code break any linter? Or it is just an attempt to rewrite the code using switch?

Aug 25 2021, 8:42 AM · Restricted Project
gAlfonso-bit updated the diff for D107473: [LLVM][LTO][NFC] Resolve FIXME in ThinLTOCodeGenerator.cpp.

Readded arm64e detection

Aug 25 2021, 8:34 AM · Restricted Project
gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Does this change the behavior of TypePrinter or DeclPrinter - not sure if there are existing tests for those with ObjC code?

I put a case for it in the declprinter so it is handled appropriately so it would get the pointee type, whereas before this was neglected.

Aug 25 2021, 8:17 AM · Restricted Project

Aug 24 2021

gAlfonso-bit edited reviewers for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType, added: marksl; removed: rsmith.
Aug 24 2021, 8:47 AM · Restricted Project

Aug 23 2021

gAlfonso-bit added a comment to D106902: [libc][NFC] Add explicit casts to ctype functions.

@sivachandra passed all tests

Aug 23 2021, 7:38 AM · Restricted Project, Restricted Project
gAlfonso-bit edited reviewers for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType, added: dgoldman; removed: erik.pilkington.
Aug 23 2021, 7:37 AM · Restricted Project

Aug 22 2021

gAlfonso-bit updated the diff for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Rebased

Aug 22 2021, 10:01 AM · Restricted Project
gAlfonso-bit added a reviewer for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType: JDevlieghere.
Aug 22 2021, 9:56 AM · Restricted Project

Aug 21 2021

gAlfonso-bit added a comment to D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

Passed every test in check-all!

Aug 21 2021, 1:27 PM · Restricted Project

Aug 19 2021

gAlfonso-bit added a comment to D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const..

How do I request it?

Aug 19 2021, 8:15 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D106902: [libc][NFC] Add explicit casts to ctype functions.

The isprint test is still failing. I have left a comment inline explaining why.

BTW, if you need help with building/testing your patches, let me know and I can give you few instructions. Or, you can lookup the command from the builder logs, from here for example: https://lab.llvm.org/buildbot/#/builders/78/builds/1654

Aug 19 2021, 8:10 AM · Restricted Project, Restricted Project
gAlfonso-bit updated the diff for D106902: [libc][NFC] Add explicit casts to ctype functions.

Resolved all test failures

Aug 19 2021, 8:10 AM · Restricted Project, Restricted Project
gAlfonso-bit added a comment to D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const..

gentle ping

Aug 19 2021, 8:06 AM · Restricted Project, Restricted Project
gAlfonso-bit edited reviewers for D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType, added: erik.pilkington; removed: RKSimon.
Aug 19 2021, 7:52 AM · Restricted Project