- User Since
- Jul 24 2013, 5:36 AM (325 w, 5 d)
Fri, Oct 18
OK with me
Wed, Oct 2
For reference libcxxrt comes from here: https://github.com/libcxxrt/libcxxrt
Fri, Sep 27
Tue, Sep 24
Sep 9 2019
This is fine with me as a little simplification and avoid an extra syscall.
error = vn_fullpath(req->td, vp, &retbuf, &freebuf); vrele(vp); if (error) return (error); error = SYSCTL_OUT(req, retbuf, strlen(retbuf) + 1);
and in vn_fullpath:
buf = malloc(MAXPATHLEN, M_TEMP, M_WAITOK);
Sep 7 2019
LGTM from the FreeBSD perspective.
Sep 3 2019
- also change __addtf3 return type
Correct typo, update tests
Aug 29 2019
Aug 26 2019
Aug 14 2019
And moved to CodeGen in rL339397
Jul 30 2019
Jul 29 2019
Jul 23 2019
OK, I will try to check if it still applies cleanly and commit soon
Jul 22 2019
Jun 4 2019
I've created D62862 which is independent of X86/AArch64.
May 27 2019
May 7 2019
Apr 24 2019
Apr 15 2019
LGTM. I much prefer only - short and -- long options, except for lld where unfortunately there's a precedent of accepting both.
Mar 18 2019
Mar 7 2019
@xiangzhangllvm, a question for you not directly related to the patch but I suspect you might be best suited to find an answer: how do we test CET support today? We started trying to add CET to FreeBSD some time ago but have no way to test any work that we do.
Feb 21 2019
Feb 7 2019
Feb 6 2019
Feb 5 2019
Feb 4 2019
Feb 3 2019
FreeBSD patch adding initial exec TLS mode for dynamically loaded shared objects: https://reviews.freebsd.org/D19072. Can we revisit this lld patch?
Jan 7 2019
There is a list of 140-150 unsafe (LLD_UNSAFE) packages with LLD.
Dec 21 2018
I think the arch-change (switching from a whitelist to a MIPS blacklist) is reasonable. What is the motivation for dropping DT_HASH, just binary size reduction?
Dec 18 2018
Dec 6 2018
Can I go ahead with this version as a starting point?
Dec 3 2018
- fix warnings from mandoc -Tlint and/or igor
- remove options that should not be listed
Nov 27 2018
This is fine for me (from FreeBSD's perspective), but I suspect some people (on operating systems without ifuncs in libc) may be surprised by having a(n empty) .rela.plt in all of their statically linked binaries.
I have an interim copy in FreeBSD and am updating it based on the feedback here; I'll update this review shortly.
Nov 26 2018
Additional comment that wasn't submitted while reviews.llvm.org was down on Friday: I started working on this as it's needed for us to switch from GNU objdump to llvm-objdump in FreeBSD (FreeBSD PR229046).
Nov 25 2018
I think this is reasonable.
Perhaps someone else can review?
Nov 24 2018
Nov 23 2018
Nov 22 2018
Nov 21 2018
Confirmed this fixes my bug.
Nov 20 2018
Oct 15 2018
Oct 14 2018
Oct 10 2018
Oct 9 2018
I think that the inconsistency of linkers behavior shown above shows that LLD behavior is not incorrect. It is different. But we never tried to be fully bug compatible with bfd/gold. First of all the problem is caused by a weak assumption in the linker script, which assumes that orphans are placed at the particular place before the assignment command, and my feeling it should be fixed.
I backported the change to lld 6.0 currently in FreeBSD-HEAD and it has the expected behaviour, but for my test case I think sh_info should reference .got.plt not .plt - note the address marked with ######## below.
This change looks good to me; testing it out in the FreeBSD tree now.
This change LGTM.
Oct 5 2018
Looks good to me
Oct 4 2018
Oct 3 2018
For SHT_REL and SHT_RELA, sh_link references the associated symbol table and sh_info the "section to which the relocation applies."
Oct 2 2018
I don't think you can fix the issue by recompiling it without -fPIC
I would think a fix would be compiling with -fPIC.