emaste (Ed Maste)
User

Projects

User Details

User Since
Jul 24 2013, 5:36 AM (229 w, 8 h)

Recent Activity

Mon, Dec 11

emaste added inline comments to D41057: Avoid a gnu readelf warning.
Mon, Dec 11, 5:31 PM

Sun, Dec 10

emaste accepted D41037: Create reserved symbols early so they can be versioned.

This LGTM (but @ruiu or @grimar please review as well).

Sun, Dec 10, 6:01 PM
emaste added inline comments to D41057: Avoid a gnu readelf warning.
Sun, Dec 10, 6:00 PM
emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

From e-mail followup @dim linked against libc linked with pre-patch lld.

Sun, Dec 10, 5:46 PM

Sat, Dec 9

emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

I successfully linked all of FreeBSD/amd64 with LLD head + this patch.

Sat, Dec 9, 5:31 AM

Fri, Dec 8

emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

Spoke too soon - buildworld is actually failing elsewhere now, with my backported patch in lld.

/usr/obj/usr/home/emaste/src/freebsd/amd64.amd64/tmp/usr/bin/ld: error: relocation R_X86_64_PLT32 cannot refer to absolute symbol: __tls_get_addr
>>> defined in <internal>
>>> referenced by runetype.h:98 (/usr/obj/usr/home/emaste/src/freebsd/amd64.amd64/tmp/usr/include/runetype.h:98)
>>>               xlat16_iconv.pico:(kiconv_xlat16_open)

I probably have an error in my backport attempt though, this other library (lib/libkiconv) linked succesfully with lld head + this patch.

Fri, Dec 8, 6:40 PM
emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

I tested this patch against lld head and confirm it resolves the issue via my reproducer. I also backported it to lld 5.0.1 (the version in FreeBSD HEAD) , rebuilt, and confirm that sbrk() is functional.

Fri, Dec 8, 5:55 PM

Mon, Nov 20

emaste added a reviewer for D32172: Port asan to FreeBSD AArch64: kcc.
Mon, Nov 20, 6:27 PM
emaste added a reviewer for D32175: Add the llvm asan support: kcc.
Mon, Nov 20, 6:27 PM

Nov 4 2017

emaste added inline comments to D39464: Define fs::allocate_file which preallocates disk blocks..
Nov 4 2017, 6:25 PM

Oct 31 2017

emaste added a comment to D39459: Rename SymbolBody -> Symbol..

Thanks for including the steps you used to effect the mechanical change! Having maintained long-lived derived branches of open source projects in the past I've found that sort of thing very helpful.

Oct 31 2017, 10:41 AM

Oct 14 2017

emaste committed rL315814: libunwind: document tested FreeBSD configs and sort OS list.
libunwind: document tested FreeBSD configs and sort OS list
Oct 14 2017, 10:04 AM
emaste closed D38900: libunwind: document tested FreeBSD configs and sort OS list by committing rL315814: libunwind: document tested FreeBSD configs and sort OS list.
Oct 14 2017, 10:04 AM

Oct 13 2017

emaste updated subscribers of D38900: libunwind: document tested FreeBSD configs and sort OS list.

@joerg might have insight on ppc, sparc64, arm on NetBSD.

Oct 13 2017, 2:01 PM
emaste created D38900: libunwind: document tested FreeBSD configs and sort OS list.
Oct 13 2017, 12:36 PM

Oct 6 2017

emaste added a comment to D38142: FreeBSD kernel debugging fixes.

Since I'm a first-time contributor, I definitely don't have commit privileges. Should I apply for them, or is someone else supposed to commit this for me?

Oct 6 2017, 12:09 PM

Oct 2 2017

emaste committed rL314672: Improve FreeBSD kernel debugging.
Improve FreeBSD kernel debugging
Oct 2 2017, 7:37 AM
emaste closed D38142: FreeBSD kernel debugging fixes by committing rL314672: Improve FreeBSD kernel debugging.
Oct 2 2017, 7:36 AM

Sep 30 2017

emaste added a comment to D38142: FreeBSD kernel debugging fixes.

I realized I don't have my LLVM SVN creds on my laptop, so will commit this when I return home in a couple of days if it's still not done.

Sep 30 2017, 12:28 AM

Sep 27 2017

emaste added a comment to D38142: FreeBSD kernel debugging fixes.

Since I'm a first-time contributor, I definitely don't have commit privileges. Should I apply for them, or is someone else supposed to commit this for me?

Sep 27 2017, 11:08 AM

Sep 16 2017

emaste added a comment to D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.

Very small nit noticed on another look: there are couple of instances of Mib that should be MiB

Sep 16 2017, 5:04 AM

Sep 13 2017

emaste accepted D37825: Accept not only --foo but also -foo..
Sep 13 2017, 6:21 PM

Sep 2 2017

emaste committed rL312431: Add test case for attach-by-pid from different cwd.
Add test case for attach-by-pid from different cwd
Sep 2 2017, 6:48 PM
emaste closed D32522: Test case for the issue raised in D32271 by committing rL312431: Add test case for attach-by-pid from different cwd.
Sep 2 2017, 6:48 PM
emaste committed rL312430: FreeBSD: attach to pid from different cwd.
FreeBSD: attach to pid from different cwd
Sep 2 2017, 6:43 PM
emaste closed D32271: Patch to Attach pid successfully from different dir by committing rL312430: FreeBSD: attach to pid from different cwd.
Sep 2 2017, 6:43 PM
emaste updated the diff for D32271: Patch to Attach pid successfully from different dir.

correct variable

Sep 2 2017, 4:32 PM
emaste added inline comments to D32522: Test case for the issue raised in D32271.
Sep 2 2017, 2:33 PM
emaste added a comment to D32522: Test case for the issue raised in D32271.

Testing this just now I got:

FAIL: LLDB (/usr/bin/cc-x86_64) :: test_attach_to_process_from_different_dir_by_id (TestProcessAttach.ProcessAttachTestCase)
======================================================================          
ERROR: test_attach_to_process_from_different_dir_by_id (TestProcessAttach.ProcessAttachTestCase)
   Test attach by process id                                                    
----------------------------------------------------------------------          
Traceback (most recent call last):                                              
  File "/tank/emaste/src/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py", line 44, in test_attach_to_process_from_different_dir_by_id
    os.mkdir(os.path.join(os.getcwd(),'newdir'))                                
OSError: [Errno 17] File exists: '/tank/emaste/src/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/process_attach/newdir'
Config=x86_64-/usr/bin/cc

investigating...

Sep 2 2017, 10:09 AM

Aug 25 2017

emaste added a comment to D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

See D23113

Aug 25 2017, 2:40 PM

Aug 18 2017

emaste added a comment to D13104: Mips - Mark the section .eh_frame as writeable for pic.

We also face this problem on FreeBSD/mips64 when trying to link with lld.

Aug 18 2017, 8:47 AM
emaste added a comment to D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.

(Aside, for FreeBSD we are rather eager to have this support arrive in lld upstream and will from there backport it to the lld 5.0.0 in our src tree. As it stands we cannot link the full base system with lld because lldb has grown too large -- https://bugs.freebsd.org/215691)

Aug 18 2017, 6:25 AM

Aug 17 2017

emaste added inline comments to D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.
Aug 17 2017, 5:23 PM
emaste added a comment to D36823: [LLD][ELF] Read ARM BuildAttributes section to determine supported features..

Thank you, this will be quite useful for FreeBSD and the change seems reasonable to me.

Aug 17 2017, 8:32 AM

Aug 16 2017

emaste added inline comments to D36812: Add support for writing 64-bit symbol tables for archives when offsets become too large for 32-bit.
Aug 16 2017, 5:49 PM
emaste committed rL311003: convert hard tabs to spaces in PlatformOpenBSD.cpp.
convert hard tabs to spaces in PlatformOpenBSD.cpp
Aug 16 2017, 6:12 AM
emaste committed rL311002: Make i386-*-freebsd expression work on JIT path.
Make i386-*-freebsd expression work on JIT path
Aug 16 2017, 5:57 AM
emaste closed D34776: Make i386-*-freebsd expression work on JIT path by committing rL311002: Make i386-*-freebsd expression work on JIT path.
Aug 16 2017, 5:57 AM

Aug 13 2017

emaste added a comment to D32522: Test case for the issue raised in D32271.

Ping for two open questions

Aug 13 2017, 6:08 AM

Aug 10 2017

emaste committed rL310644: remove FreeBSD xfail decorator from TestCppNsImport.
remove FreeBSD xfail decorator from TestCppNsImport
Aug 10 2017, 11:27 AM
emaste committed rL310626: remove FreeBSD xfail decorator from TestCallStdStringFunction.
remove FreeBSD xfail decorator from TestCallStdStringFunction
Aug 10 2017, 10:02 AM
emaste committed rL310624: remove FreeBSD xfail decorator from TestExitDuringBreak.
remove FreeBSD xfail decorator from TestExitDuringBreak
Aug 10 2017, 9:49 AM
emaste committed rL310591: Report inferior signals as signals, not exceptions, on FreeBSD.
Report inferior signals as signals, not exceptions, on FreeBSD
Aug 10 2017, 6:48 AM
emaste closed D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd by committing rL310591: Report inferior signals as signals, not exceptions, on FreeBSD.
Aug 10 2017, 6:48 AM

Aug 9 2017

emaste accepted D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

Still would appreciate diffs uploaded with full context - i.e.,

Note that you can upload patches created through various diff tools, including git and svn. To make reviews easier, please always include as much context as possible with your diff! Don’t worry, Phabricator will automatically send a diff with a smaller context in the review email, but having the full file in the web interface will help the reviewer understand your code.
Aug 9 2017, 12:34 PM
emaste added a comment to D36538: Remove RISCV from LLVM_ALL_TARGETS in CMakeLists.txt.

Adding the comment above the list seems like a good idea to me.

Aug 9 2017, 12:17 PM
emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

I've committed this to FreeBSD's copy of lldb in r322326. @labath if you're happy with this patch I will commit to lldb for @karnajitw. I'm not sure how the patch ended up with a conflict, but it's just a whitespace issue.

Aug 9 2017, 12:13 PM

Aug 8 2017

emaste added a reviewer for D34776: Make i386-*-freebsd expression work on JIT path: labath.
Aug 8 2017, 11:54 AM
emaste accepted D34776: Make i386-*-freebsd expression work on JIT path.
Aug 8 2017, 11:54 AM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

Actually, I think you probably need to extend the @skipIfLinux to apply to freebsd as well.

Aug 8 2017, 10:27 AM

Aug 7 2017

emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

With this patch i386 test results are comparable to amd64, and I'm happy with it from a FreeBSD perspective (modulo the PlatformOpenBSD patch conflict).

Aug 7 2017, 6:27 PM
emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

The change in PlatformOpenBSD.cpp failed to apply for me (although it was trivial to manually apply it).

Aug 7 2017, 12:34 PM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

With this patch I observed three new failures on FreeBSD and three new unexpected passes on FreeBSD. An example of a new failure:

Aug 7 2017, 10:06 AM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

The patch LGTM, I will test it soon.

Aug 7 2017, 5:34 AM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

Sorry I missed this when first uploaded, I will look at it shortly.

Aug 7 2017, 5:23 AM
emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

Sorry I missed this when first uploaded, I will look at it shortly.

Aug 7 2017, 5:23 AM

Aug 4 2017

emaste added inline comments to D35553: Define OFF_T as 64-bit integer on NetBSD.
Aug 4 2017, 7:30 AM · Restricted Project

Jul 24 2017

emaste updated subscribers of D35509: Covnert .[cd]tors to .{init,fini}_array using synthetic section..
Jul 24 2017, 5:29 PM

Jul 18 2017

emaste added a comment to D35595: Bring back r307364.

Handy Phabricator link: rL307364

Jul 18 2017, 6:20 PM
emaste added a comment to rL307100: Move clearOutputSections earlier. NFC..

Fixed in rL308382

Jul 18 2017, 5:15 PM
emaste added a reviewer for D35034: compiler-rt: use fp_t instead of long double, for consistency: compnerd.
Jul 18 2017, 1:19 PM
emaste updated subscribers of D35034: compiler-rt: use fp_t instead of long double, for consistency.
Jul 18 2017, 1:19 PM
emaste added a comment to rL307100: Move clearOutputSections earlier. NFC..

Bug report in http://llvm.org/pr33821

Jul 18 2017, 7:54 AM
emaste added a comment to rL307364: [ELF] - Handle symbols with default version early..

For reference reverted in rL308239

Jul 18 2017, 7:40 AM
emaste added a comment to D35517: Add the --chroot option for --reproduce..

Approach LGTM, modulo @grimar's issue. I wonder if we should call the option --sysroot (and make it available to users) though? We'd have a little more work to do to handle a user-supplied sysroot when creating reproducers.

Jul 18 2017, 6:03 AM
emaste added inline comments to D35553: Define OFF_T as 64-bit integer on NetBSD.
Jul 18 2017, 5:29 AM · Restricted Project

Jul 16 2017

emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

One note, the ordering of the value tags differs wrt GNU ld. It shouldn't matter, just something I noticed.

Jul 16 2017, 10:27 AM
emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

I've successfully tested this change imported into my FreeBSD work branch
https://github.com/emaste/freebsd/commit/12f8c0fd362c128c03acc9689c76d8c5d5c69dbe

Jul 16 2017, 10:26 AM
emaste added a comment to D35351: [llvm-readobj] - Teach readobj to print DT_FILTER dynamic tag in human readable form..

One note, the ordering of the value tags differs wrt GNU ld. It shouldn't matter, just something I noticed.

Jul 16 2017, 8:47 AM
emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

This LGTM.

Jul 16 2017, 3:57 AM

Jul 13 2017

emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

I believe -F / --filter can be used multiple times, as with -f.

Jul 13 2017, 6:46 AM
emaste added a comment to D35351: [llvm-readobj] - Teach readobj to print DT_FILTER dynamic tag in human readable form..

Should we instead switch DT_NEEDED to be like DT_AUXILIARY? This would be similar to the format used by binutils readelf and ELF Tool Chain readelf.

Jul 13 2017, 6:43 AM

Jul 9 2017

emaste committed rL307441: remove deprecated register storage class specifier.
remove deprecated register storage class specifier
Jul 9 2017, 6:18 AM
emaste closed D35124: remove register storage class specifier. by committing rL307441: remove deprecated register storage class specifier.
Jul 9 2017, 6:17 AM
emaste added a comment to D35129: Add DragonFlyBSD support to OpenMP.

For future uploads can you please include context (e.g. git diff -U9999)
This seems reasonable to me.

Jul 9 2017, 6:13 AM

Jul 7 2017

emaste created D35124: remove register storage class specifier..
Jul 7 2017, 7:04 AM
emaste committed rL307399: remove duplicate symbol version script entries.
remove duplicate symbol version script entries
Jul 7 2017, 6:46 AM
emaste closed D35121: openmp: remove duplicate symbol version script entries by committing rL307399: remove duplicate symbol version script entries.
Jul 7 2017, 6:46 AM
emaste added a comment to D35121: openmp: remove duplicate symbol version script entries.

As an aside it looks like cmake's omp lib rule has no dependency on the version script / export list file.

Jul 7 2017, 6:23 AM
emaste updated subscribers of D35121: openmp: remove duplicate symbol version script entries.
Jul 7 2017, 6:11 AM
emaste created D35121: openmp: remove duplicate symbol version script entries.
Jul 7 2017, 6:11 AM

Jul 5 2017

emaste created D35034: compiler-rt: use fp_t instead of long double, for consistency.
Jul 5 2017, 2:14 PM

Jun 27 2017

emaste added inline comments to D34618: [LLD] Add basic 64-bit SPARC support.
Jun 27 2017, 5:22 AM
emaste committed rL306403: Sort lit.cfg architectures.
Sort lit.cfg architectures
Jun 27 2017, 5:22 AM

Jun 26 2017

emaste accepted D34632: Check for libdl, and only use it when available.
Jun 26 2017, 11:25 AM
emaste added inline comments to D34618: [LLD] Add basic 64-bit SPARC support.
Jun 26 2017, 10:02 AM

Jun 17 2017

emaste accepted D34236: Delete ProcessLauncherPosix.

LGTM from the FreeBSD side. The launch code for FreeBSD came from the original (in-process) implementation that Linux and FreeBSD shared.

Jun 17 2017, 3:59 AM

Jun 16 2017

emaste added a comment to D34313: Prefer -Ttext over linker script values.

I like this idea.

Jun 16 2017, 7:43 PM
emaste added a comment to D34236: Delete ProcessLauncherPosix.

FreeBSD build and test in progress.

Jun 16 2017, 7:39 PM
emaste added a comment to D34274: Remove home-grown thread-local storage wrappers.

Fine from FreeBSD

Jun 16 2017, 7:36 PM

Jun 13 2017

emaste added a comment to D34140: [ELF] Add armelf emulation mode.
In D34140#779285, @ruiu wrote:

This seems fine, but who actually passes "armelf"? Just want to confirm that this is in use.

Jun 13 2017, 5:42 PM · lld
emaste added a comment to D34140: [ELF] Add armelf emulation mode.

This LGTM, I had hacked something like this locally for my FreeBSD/lld work.

Jun 13 2017, 11:31 AM · lld

May 30 2017

emaste added a comment to D32522: Test case for the issue raised in D32271.

Generally LGTM with two questions inline.

May 30 2017, 6:49 AM

May 25 2017

emaste committed rL303965: FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap.
FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap
May 25 2017, 8:16 PM

May 24 2017

emaste accepted D33516: Add generic __bswap[ds]i2 implementations.

LGTM from my perspective.

May 24 2017, 5:25 PM

May 19 2017

emaste added a comment to D33343: Add some tips on how to benchhmark.

Thanks! I will try to add an equivalent section for FreeBSD shortly after this goes in.

May 19 2017, 11:09 AM
emaste added inline comments to D33343: Add some tips on how to benchhmark.
May 19 2017, 9:46 AM
emaste added a comment to D32271: Patch to Attach pid successfully from different dir.
In D32271#759361, @dim wrote:

As I found out in rL303015, the KERN_PROC_PATHNAME has one drawback: if an executable file has multiple hard links, you will get just one of its filenames as the result. Since that filename is more or less randomly chosen, it does *not* have to correspond to the actual argv[0] the executable was invoked with. If that does not matter, this approach is fine, though.

May 19 2017, 8:08 AM
emaste updated subscribers of D32271: Patch to Attach pid successfully from different dir.
May 19 2017, 5:55 AM
emaste added a comment to D32522: Test case for the issue raised in D32271.

Two small nits noted inline, but now the test does not pass without D32271 and does with it. Note that in the "without" case it returned error rather than failing, perhaps related to the path issue I noted?

May 19 2017, 5:51 AM