emaste (Ed Maste)
User

Projects

User Details

User Since
Jul 24 2013, 5:36 AM (247 w, 4 d)

Recent Activity

Yesterday

emaste committed rL330504: Temporarily skip Go TestExpressions on FreeBSD as it hangs.
Temporarily skip Go TestExpressions on FreeBSD as it hangs
Sat, Apr 21, 7:02 AM
emaste committed rL330500: FreeBSD: propagate error to user if memory access fails.
FreeBSD: propagate error to user if memory access fails
Sat, Apr 21, 4:27 AM

Mon, Apr 9

emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Happy belated birthday Multi-GOT patch

Mon, Apr 9, 1:21 PM · lld

Mar 15 2018

emaste added a comment to D40623: Correctly set reserved bits for UUID version 4..

LGTM

Mar 15 2018, 8:57 AM

Mar 9 2018

emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

Thanks for the review. As for the -Wl,-z,origin part, I'd rather leave that alone unless we have a clear indication that either it is not necessary for any of the supported FreeBSD and DragonFly BSD versions, or that it can be passed unconditionally without breaking any of the supported systems (and which linkers accept it).

Mar 9 2018, 2:25 PM

Mar 8 2018

emaste accepted D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

LGTM for FreeBSD

Mar 8 2018, 6:20 AM
emaste committed rL327000: Use ellipsis ... to indicate omitted commands.
Use ellipsis ... to indicate omitted commands
Mar 8 2018, 5:54 AM

Mar 7 2018

emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

ld(1) might accept -z origin, but why do we want it for other OSes? I don't see it used in the NetBSD dynamic ELF loader. DF_ORIGIN is just defined but not used by anything.

Mar 7 2018, 8:18 PM
emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

Uconditionally for all Unices? I don't think so.

Mar 7 2018, 4:12 PM

Mar 5 2018

emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

LGTM from the FreeBSD perspective

Mar 5 2018, 8:23 AM
emaste added a reviewer for D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD: dim.
Mar 5 2018, 8:16 AM

Mar 1 2018

emaste committed rLLD326536: Update man page for long opts that accept = after r326506.
Update man page for long opts that accept = after r326506
Mar 1 2018, 6:59 PM
emaste committed rL326536: Update man page for long opts that accept = after r326506.
Update man page for long opts that accept = after r326506
Mar 1 2018, 6:59 PM
emaste committed rL326463: Correct man page description for --section-start.
Correct man page description for --section-start
Mar 1 2018, 11:05 AM
emaste committed rLLD326463: Correct man page description for --section-start.
Correct man page description for --section-start
Mar 1 2018, 11:05 AM
emaste committed rLLD326459: Where possible use --long-opt=value in lld man page.
Where possible use --long-opt=value in lld man page
Mar 1 2018, 10:42 AM
emaste committed rL326459: Where possible use --long-opt=value in lld man page.
Where possible use --long-opt=value in lld man page
Mar 1 2018, 10:42 AM
emaste committed rLLD326446: Correct markup and nits in ld.lld man page.
Correct markup and nits in ld.lld man page
Mar 1 2018, 8:04 AM
emaste committed rL326446: Correct markup and nits in ld.lld man page.
Correct markup and nits in ld.lld man page
Mar 1 2018, 8:04 AM

Feb 27 2018

emaste added a comment to D43643: [RFC] Sceptre a Spectre variant 1 detector.

Is the pass intentionally named "Sceptre"? That's amusing, but kind of confusing.

Feb 27 2018, 10:28 AM

Feb 26 2018

emaste committed rL326166: Mark test_*int*_t_dwarf as failing on FreeBSD.
Mark test_*int*_t_dwarf as failing on FreeBSD
Feb 26 2018, 6:56 PM
emaste committed rL326139: Revert r326134 due to broken buildbot.
Revert r326134 due to broken buildbot
Feb 26 2018, 2:41 PM
emaste committed rL326134: Mark test_*int*_t_dwarf as failing on FreeBSD.
Mark test_*int*_t_dwarf as failing on FreeBSD
Feb 26 2018, 2:16 PM
emaste added inline comments to D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5.
Feb 26 2018, 10:36 AM

Feb 22 2018

emaste committed rL325856: remove FreeBSD xfail from lit TestCallStdStringFunction.
remove FreeBSD xfail from lit TestCallStdStringFunction
Feb 22 2018, 6:53 PM

Feb 21 2018

emaste added a comment to D42516: [llvm-objcopy] Add support for large indexes.
Feb 21 2018, 7:14 PM
emaste added a comment to D42516: [llvm-objcopy] Add support for large indexes.

One other point - it would be good to compare the performance of llvm-objcopy to GNU objcopy in this case, and if we're a lot worse, run a profiler at some point to identify what we're doing that makes things worse.

Feb 21 2018, 3:52 PM

Feb 19 2018

emaste added a comment to D43168: Don't use -ldl on BSD.

In FreeBSD libpthread.so is a symlink to libthr; -pthread and -lpthread should both work.

Feb 19 2018, 9:23 PM

Feb 16 2018

emaste added a comment to D43370: Add initial XRay support for NetBSD.

This LGTM

Feb 16 2018, 6:46 AM · Restricted Project

Feb 9 2018

emaste committed rL324739: Add IMPLEMENTATION NOTES describing lld's .a handling in the man page.
Add IMPLEMENTATION NOTES describing lld's .a handling in the man page
Feb 9 2018, 7:38 AM
emaste committed rLLD324739: Add IMPLEMENTATION NOTES describing lld's .a handling in the man page.
Add IMPLEMENTATION NOTES describing lld's .a handling in the man page
Feb 9 2018, 7:38 AM
emaste closed D43072: ld.lld.1: add IMPLEMENTATION NOTES section documenting lld's handling.
Feb 9 2018, 7:38 AM

Feb 8 2018

emaste updated subscribers of D43072: ld.lld.1: add IMPLEMENTATION NOTES section documenting lld's handling.
Feb 8 2018, 5:47 PM
emaste created D43072: ld.lld.1: add IMPLEMENTATION NOTES section documenting lld's handling.
Feb 8 2018, 7:16 AM

Feb 7 2018

emaste committed rL324528: Document --build-id=fast in ld.lld.1.
Document --build-id=fast in ld.lld.1
Feb 7 2018, 1:24 PM
emaste committed rLLD324528: Document --build-id=fast in ld.lld.1.
Document --build-id=fast in ld.lld.1
Feb 7 2018, 1:24 PM
emaste closed D43039: ld.lld.1: document --build-id=fast.
Feb 7 2018, 1:24 PM
emaste created D43039: ld.lld.1: document --build-id=fast.
Feb 7 2018, 1:05 PM
emaste added inline comments to D42963: Add initial ld.lld.1 man page.
Feb 7 2018, 12:45 PM
emaste committed rL324512: Add ld.lld.1 man page, describing lld's ELF linker.
Add ld.lld.1 man page, describing lld's ELF linker
Feb 7 2018, 12:40 PM
emaste committed rLLD324512: Add ld.lld.1 man page, describing lld's ELF linker.
Add ld.lld.1 man page, describing lld's ELF linker
Feb 7 2018, 12:40 PM
emaste closed D42963: Add initial ld.lld.1 man page.
Feb 7 2018, 12:40 PM
emaste added a comment to D42963: Add initial ld.lld.1 man page.

Thanks, I'll commit this later today. Not sure how I ended up with 01 instead of O1 but have fixed those locally.

Feb 7 2018, 12:08 PM
emaste added inline comments to D42963: Add initial ld.lld.1 man page.
Feb 7 2018, 6:21 AM
emaste added inline comments to D42963: Add initial ld.lld.1 man page.
Feb 7 2018, 6:16 AM
emaste added a comment to D42963: Add initial ld.lld.1 man page.

PDF version of current version:

Feb 7 2018, 6:16 AM
emaste updated the diff for D42963: Add initial ld.lld.1 man page.
Feb 7 2018, 6:16 AM

Feb 6 2018

emaste added inline comments to D42963: Add initial ld.lld.1 man page.
Feb 6 2018, 6:04 PM
emaste added a comment to D42963: Add initial ld.lld.1 man page.

PDF rendered version of the man page:

Feb 6 2018, 6:04 PM
emaste added inline comments to D42963: Add initial ld.lld.1 man page.
Feb 6 2018, 6:01 PM
emaste updated the diff for D42963: Add initial ld.lld.1 man page.

Incorporate review feedback

Feb 6 2018, 5:59 PM
emaste updated the diff for D42963: Add initial ld.lld.1 man page.
  • Update copyright and license statement
  • Remove internal -full-shutdown option
Feb 6 2018, 9:40 AM
emaste created D42963: Add initial ld.lld.1 man page.
Feb 6 2018, 6:51 AM

Jan 26 2018

emaste added inline comments to D42550: Put the header in the first PT_LOAD even if that PT_LOAD has a LMAExpr.
Jan 26 2018, 6:35 AM

Jan 25 2018

emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

We have a chance to celebrate the first anniversary of this patch in a couple of months. Is it possible to escape this dubious holiday?

Jan 25 2018, 2:10 PM · lld
emaste added inline comments to D42550: Put the header in the first PT_LOAD even if that PT_LOAD has a LMAExpr.
Jan 25 2018, 11:20 AM

Jan 11 2018

emaste accepted D41635: Align SHT_NOBITS sections is they are the first on a PT_LOAD.

Seems fine to me

Jan 11 2018, 7:37 PM

Jan 10 2018

emaste added a comment to D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts.

The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will also use llvm-objcopy.

Jan 10 2018, 5:37 PM
emaste committed rLLD322180: Correct typo in help text.
Correct typo in help text
Jan 10 2018, 4:56 AM
emaste committed rL322180: Correct typo in help text.
Correct typo in help text
Jan 10 2018, 4:56 AM

Jan 4 2018

emaste added a comment to D41723: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre...

Is there any plan (or willingness?) to backport this further, to 4.0.0 and even 3.4.1?

Jan 4 2018, 11:40 AM
emaste updated subscribers of D41723: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre...
Jan 4 2018, 4:42 AM

Dec 29 2017

emaste added a comment to D41592: [ELF] - Add missing dynamic tags when producing output with IRelative relocations only..

With this patch applied Kostik's original testcase passes.

Dec 29 2017, 1:27 PM
emaste added inline comments to D41592: [ELF] - Add missing dynamic tags when producing output with IRelative relocations only..
Dec 29 2017, 10:13 AM

Dec 26 2017

emaste accepted D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given..

LGTM

Dec 26 2017, 1:33 PM
emaste added inline comments to D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given..
Dec 26 2017, 6:27 AM
emaste added a comment to D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given..

The original FreeBSD test case (a 'hello world' linked with lld -znotext) works with this change applied.

Dec 26 2017, 6:26 AM

Dec 25 2017

emaste added a comment to D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given..

Conflicts after rL321430. I tried a straightforward rebase (moving the if ((S.Flags & SHF_WRITE) || !Config->ZText) block below if (Sym.isUndefWeak()) but test/ELF/retain-und.s (from rL293093) fails.

Dec 25 2017, 7:31 PM

Dec 24 2017

emaste added a comment to D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given..

LGTM.

Dec 24 2017, 10:01 AM

Dec 23 2017

emaste added a comment to D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given..

This LGTM, I had a similar change in my repo while trying to fix PR35720.

Dec 23 2017, 6:43 PM

Dec 22 2017

emaste added a comment to D41541: [ELF] - Allow using PLT relocations when "-z notext" is given..

I can confirm this fixes the reduced test case, but the 'hello world' test on FreeBSD still fails, now with:

Dec 22 2017, 7:52 AM
emaste added inline comments to D41541: [ELF] - Allow using PLT relocations when "-z notext" is given..
Dec 22 2017, 6:28 AM

Dec 20 2017

emaste added a comment to D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__.

Ping?

Dec 20 2017, 12:04 PM

Dec 18 2017

emaste added a reviewer for D41207: Rename --icf-data and add a corresponding flag for functions: dim.
Dec 18 2017, 7:46 AM

Dec 13 2017

emaste added a comment to D41057: Avoid a gnu readelf warning.

FWIW our standard readelf in FreeBSD comes from the ELF Tool Chain project and doesn't have the warning. It's only when the GNU readelf package is installed that we'd encounter this.

Dec 13 2017, 12:55 PM

Dec 11 2017

emaste added inline comments to D41057: Avoid a gnu readelf warning.
Dec 11 2017, 5:31 PM

Dec 10 2017

emaste accepted D41037: Create reserved symbols early so they can be versioned.

This LGTM (but @ruiu or @grimar please review as well).

Dec 10 2017, 6:01 PM
emaste added inline comments to D41057: Avoid a gnu readelf warning.
Dec 10 2017, 6:00 PM
emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

From e-mail followup @dim linked against libc linked with pre-patch lld.

Dec 10 2017, 5:46 PM

Dec 9 2017

emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

I successfully linked all of FreeBSD/amd64 with LLD head + this patch.

Dec 9 2017, 5:31 AM

Dec 8 2017

emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

Spoke too soon - buildworld is actually failing elsewhere now, with my backported patch in lld.

/usr/obj/usr/home/emaste/src/freebsd/amd64.amd64/tmp/usr/bin/ld: error: relocation R_X86_64_PLT32 cannot refer to absolute symbol: __tls_get_addr
>>> defined in <internal>
>>> referenced by runetype.h:98 (/usr/obj/usr/home/emaste/src/freebsd/amd64.amd64/tmp/usr/include/runetype.h:98)
>>>               xlat16_iconv.pico:(kiconv_xlat16_open)

I probably have an error in my backport attempt though, this other library (lib/libkiconv) linked succesfully with lld head + this patch.

Dec 8 2017, 6:40 PM
emaste added a comment to D41037: Create reserved symbols early so they can be versioned.

I tested this patch against lld head and confirm it resolves the issue via my reproducer. I also backported it to lld 5.0.1 (the version in FreeBSD HEAD) , rebuilt, and confirm that sbrk() is functional.

Dec 8 2017, 5:55 PM

Nov 20 2017

emaste added a reviewer for D32172: Port asan to FreeBSD AArch64: kcc.
Nov 20 2017, 6:27 PM
emaste added a reviewer for D32175: Add the llvm asan support: kcc.
Nov 20 2017, 6:27 PM

Nov 4 2017

emaste added inline comments to D39464: Define fs::allocate_file which preallocates disk blocks..
Nov 4 2017, 6:25 PM

Oct 31 2017

emaste added a comment to D39459: Rename SymbolBody -> Symbol..

Thanks for including the steps you used to effect the mechanical change! Having maintained long-lived derived branches of open source projects in the past I've found that sort of thing very helpful.

Oct 31 2017, 10:41 AM

Oct 14 2017

emaste committed rL315814: libunwind: document tested FreeBSD configs and sort OS list.
libunwind: document tested FreeBSD configs and sort OS list
Oct 14 2017, 10:04 AM
emaste closed D38900: libunwind: document tested FreeBSD configs and sort OS list by committing rL315814: libunwind: document tested FreeBSD configs and sort OS list.
Oct 14 2017, 10:04 AM

Oct 13 2017

emaste updated subscribers of D38900: libunwind: document tested FreeBSD configs and sort OS list.

@joerg might have insight on ppc, sparc64, arm on NetBSD.

Oct 13 2017, 2:01 PM
emaste created D38900: libunwind: document tested FreeBSD configs and sort OS list.
Oct 13 2017, 12:36 PM

Oct 6 2017

emaste added a comment to D38142: FreeBSD kernel debugging fixes.

Since I'm a first-time contributor, I definitely don't have commit privileges. Should I apply for them, or is someone else supposed to commit this for me?

Oct 6 2017, 12:09 PM

Oct 2 2017

emaste committed rL314672: Improve FreeBSD kernel debugging.
Improve FreeBSD kernel debugging
Oct 2 2017, 7:37 AM
emaste closed D38142: FreeBSD kernel debugging fixes by committing rL314672: Improve FreeBSD kernel debugging.
Oct 2 2017, 7:36 AM

Sep 30 2017

emaste added a comment to D38142: FreeBSD kernel debugging fixes.

I realized I don't have my LLVM SVN creds on my laptop, so will commit this when I return home in a couple of days if it's still not done.

Sep 30 2017, 12:28 AM

Sep 27 2017

emaste added a comment to D38142: FreeBSD kernel debugging fixes.

Since I'm a first-time contributor, I definitely don't have commit privileges. Should I apply for them, or is someone else supposed to commit this for me?

Sep 27 2017, 11:08 AM

Sep 16 2017

emaste added a comment to D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.

Very small nit noticed on another look: there are couple of instances of Mib that should be MiB

Sep 16 2017, 5:04 AM

Sep 13 2017

emaste accepted D37825: Accept not only --foo but also -foo..
Sep 13 2017, 6:21 PM

Sep 2 2017

emaste committed rL312431: Add test case for attach-by-pid from different cwd.
Add test case for attach-by-pid from different cwd
Sep 2 2017, 6:48 PM
emaste closed D32522: Test case for the issue raised in D32271 by committing rL312431: Add test case for attach-by-pid from different cwd.
Sep 2 2017, 6:48 PM
emaste committed rL312430: FreeBSD: attach to pid from different cwd.
FreeBSD: attach to pid from different cwd
Sep 2 2017, 6:43 PM