Page MenuHomePhabricator

emaste (Ed Maste)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2013, 5:36 AM (504 w, 1 d)

Recent Activity

Sat, Mar 18

emaste accepted D146251: [test-suite] Fix FreeBSD and OpenBSD builds.
Sat, Mar 18, 5:48 PM · Restricted Project

Fri, Mar 17

emaste accepted D146285: [lldb] For native compiles, check signal numbers are correct when adding codes.
Fri, Mar 17, 6:52 AM · Restricted Project, Restricted Project

Thu, Mar 16

emaste updated subscribers of D146076: [libc++] Remove <cstdlib> includes.
Thu, Mar 16, 7:16 PM · Restricted Project, Restricted Project
emaste added inline comments to D146222: [lldb] Add compile time checks for signal codes when on the matching platform.
Thu, Mar 16, 6:18 AM · Restricted Project, Restricted Project

Tue, Mar 14

emaste added a comment to D146044: [lldb] Implement CrashReason using UnixSignals.

FreeBSD LGTM

Tue, Mar 14, 7:56 AM · Restricted Project, Restricted Project
emaste added inline comments to D146044: [lldb] Implement CrashReason using UnixSignals.
Tue, Mar 14, 6:54 AM · Restricted Project, Restricted Project

Thu, Mar 9

emaste abandoned D140050: [draft][libc++] Add CI job testing on FreeBSD.

This review was just used for triggering and testing FreeBSD CI; actual change committed via D128084.

Thu, Mar 9, 11:15 AM · Restricted Project
emaste committed rG720e6297d1f5: [libc++] Add CI job testing on FreeBSD (authored by emaste).
[libc++] Add CI job testing on FreeBSD
Thu, Mar 9, 10:03 AM · Restricted Project, Restricted Project
emaste closed D128084: [libc++] Add CI job testing on FreeBSD.
Thu, Mar 9, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D128084: [libc++] Add CI job testing on FreeBSD.

regen

Thu, Mar 9, 5:05 AM · Restricted Project, Restricted Project, Restricted Project
emaste committed rGf188004183b7: [libc++] Remove XFAIL for a test that now passes on FreeBSD (authored by emaste).
[libc++] Remove XFAIL for a test that now passes on FreeBSD
Thu, Mar 9, 5:04 AM · Restricted Project, Restricted Project

Wed, Mar 8

emaste updated the diff for D128084: [libc++] Add CI job testing on FreeBSD.

XFAIL removal in libcxx/test/libcxx/modules_include.sh.cpp is a separate commit

Wed, Mar 8, 12:18 PM · Restricted Project, Restricted Project, Restricted Project
emaste accepted D145561: [lldb] Remove unused CrashReasonAsString function.
Wed, Mar 8, 5:23 AM · Restricted Project, Restricted Project
emaste accepted D145559: [lldb] Remove unused POSIX ProcessMessage files.
Wed, Mar 8, 4:46 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 6

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

regen

Mon, Mar 6, 11:09 AM · Restricted Project

Thu, Mar 2

emaste committed rG5295fe4e98dc: [libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD (authored by emaste).
[libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD
Thu, Mar 2, 12:31 PM · Restricted Project, Restricted Project
emaste closed D145120: [libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD.
Thu, Mar 2, 12:30 PM · Restricted Project, Restricted Project
emaste updated the diff for D145120: [libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD.
Thu, Mar 2, 11:47 AM · Restricted Project, Restricted Project
emaste added inline comments to D145120: [libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD.
Thu, Mar 2, 11:44 AM · Restricted Project, Restricted Project
emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

Seeing an occasional timeout in libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_wait_explicit.pass.cpp or other atomic tests

Thu, Mar 2, 9:47 AM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

try reverting umtx changes

Thu, Mar 2, 9:38 AM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Thu, Mar 2, 8:15 AM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

remove C++2b and Modular build, which are failing apparently unrelated to my work

Thu, Mar 2, 6:05 AM · Restricted Project
emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

It's currently failing in c++2b before getting to my job:

/home/libcxx-builder/.buildkite-agent/builds/0306c2d9b628-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1/bitset:396:63: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
        __r |= static_cast<unsigned long long>(__first_[__i]) << (sizeof(__storage_type) * CHAR_BIT);
                                                              ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Thu, Mar 2, 6:02 AM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Thu, Mar 2, 5:36 AM · Restricted Project

Wed, Mar 1

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

regen

Wed, Mar 1, 6:23 PM · Restricted Project
emaste committed rG0fe1012f8ee2: [libc++] [FreeBSD] correct 64-bit test (authored by emaste).
[libc++] [FreeBSD] correct 64-bit test
Wed, Mar 1, 6:23 PM · Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

regen

Wed, Mar 1, 4:18 PM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

adjust xfails

Wed, Mar 1, 2:13 PM · Restricted Project
emaste requested review of D145120: [libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD.
Wed, Mar 1, 2:11 PM · Restricted Project, Restricted Project
emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

I was away for a bit, and will get back to this. I've pushed a rebased test version to D140050 to check for any new regressions, and if it looks good I will push this.

Wed, Mar 1, 1:57 PM · Restricted Project, Restricted Project, Restricted Project
emaste committed rG17ecbb3ea6ff: [libc++] [FreeBSD] only use _umtx_op(2) on 64bit arches (authored by kib).
[libc++] [FreeBSD] only use _umtx_op(2) on 64bit arches
Wed, Mar 1, 12:52 PM · Restricted Project, Restricted Project
emaste closed D142422: [libc++] [FreeBSD] only use _umtx_op(2) on 64bit arches.
Wed, Mar 1, 12:52 PM · Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Wed, Mar 1, 12:45 PM · Restricted Project

Tue, Feb 28

emaste accepted D140343: [libc++] Update supported system versions.

LGTM for FreeBSD

Tue, Feb 28, 1:41 PM · Restricted Project, Restricted Project

Feb 21 2023

emaste added inline comments to D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang.
Feb 21 2023, 2:06 PM · Restricted Project, Restricted Project

Jan 25 2023

emaste added a comment to D142422: [libc++] [FreeBSD] only use _umtx_op(2) on 64bit arches.

Does this still work on FreeBSD platforms where SIZEOF_LONG != 8 ?

Jan 25 2023, 9:53 AM · Restricted Project, Restricted Project

Jan 24 2023

emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

One more FreeBSD libc++ change is in D142422

Jan 24 2023, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
emaste accepted D142422: [libc++] [FreeBSD] only use _umtx_op(2) on 64bit arches.
Jan 24 2023, 1:49 PM · Restricted Project, Restricted Project
emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

Can you rebase onto main? I don't think you had D141294 in your tree.

Jan 24 2023, 9:41 AM · Restricted Project, Restricted Project, Restricted Project

Jan 23 2023

emaste accepted D142422: [libc++] [FreeBSD] only use _umtx_op(2) on 64bit arches.
Jan 23 2023, 5:25 PM · Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Jan 23 2023, 7:24 AM · Restricted Project

Jan 22 2023

emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

I've been using D140050 as a scratch-pad to iterate on testing (in an attempt to avoid spamming everyone on the subscriber list here) and will keep it updated regularly until this lands. I did submit many runs with an additional change that removed the other, non-FreeBSD CI targets to speed iteration and avoid unnecessary CI cycles.

Jan 22 2023, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Jan 22 2023, 10:19 AM · Restricted Project

Jan 20 2023

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase, apply https://reviews.freebsd.org/D38132

Jan 20 2023, 5:20 PM · Restricted Project
emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

Everything should be ready now, test run in progress at https://buildkite.com/llvm-project/libcxx-ci/builds/17740

Jan 20 2023, 2:05 PM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

update to final candidate version

Jan 20 2023, 1:52 PM · Restricted Project
emaste committed rG7ec6c629052c: [libc++] Add FreeBSD XFAILs in preparation for CI (authored by emaste).
[libc++] Add FreeBSD XFAILs in preparation for CI
Jan 20 2023, 1:51 PM · Restricted Project, Restricted Project
emaste closed D141542: [libc++] Add FreeBSD XFAILs in preparation for CI runner.
Jan 20 2023, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
emaste committed rG83387dbc18e7: [libc++] add FreeBSD atomic wait support (authored by kib).
[libc++] add FreeBSD atomic wait support
Jan 20 2023, 1:40 PM · Restricted Project, Restricted Project
emaste closed D142134: [libc++] add FreeBSD atomic wait support.
Jan 20 2023, 1:40 PM · Restricted Project, Restricted Project
emaste added a comment to D141542: [libc++] Add FreeBSD XFAILs in preparation for CI runner.

IMO we should fix these issues, but I rather have a CI that tests most of libc++ instead of all of FreeBSD.

Jan 20 2023, 9:34 AM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase after D141294

Jan 20 2023, 8:44 AM · Restricted Project
emaste added inline comments to D142134: [libc++] add FreeBSD atomic wait support.
Jan 20 2023, 8:30 AM · Restricted Project, Restricted Project

Jan 19 2023

emaste added a comment to D142134: [libc++] add FreeBSD atomic wait support.

I applied this change and restored those tests and (in the one run so far) they passed.

Jan 19 2023, 5:09 PM · Restricted Project, Restricted Project
emaste accepted D141294: [libc++] Enable clang-tidy from the buildkite pipeline instead of hard-coding it in run-buildbot.
Jan 19 2023, 1:07 PM · Restricted Project, Restricted Project
emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

FreeBSD CI looks good with the four reviews in the stack
D141294, D142134, D141542, D128084

Jan 19 2023, 12:08 PM · Restricted Project, Restricted Project, Restricted Project
emaste added a comment to D142134: [libc++] add FreeBSD atomic wait support.

Thanks for working on this!

In fact Kostik found this independent of my work on bringing up CI. It's fortuitous timing.

Jan 19 2023, 9:39 AM · Restricted Project, Restricted Project
emaste added inline comments to D142134: [libc++] add FreeBSD atomic wait support.
Jan 19 2023, 9:37 AM · Restricted Project, Restricted Project
emaste added a comment to D141294: [libc++] Enable clang-tidy from the buildkite pipeline instead of hard-coding it in run-buildbot.

LGTM assuming doc update

Jan 19 2023, 9:30 AM · Restricted Project, Restricted Project
emaste requested review of D142134: [libc++] add FreeBSD atomic wait support.
Jan 19 2023, 9:23 AM · Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Jan 19 2023, 9:05 AM · Restricted Project

Jan 17 2023

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

no hard tabs

Jan 17 2023, 6:24 PM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase, add tests back, add kib's atomic patch

Jan 17 2023, 5:20 PM · Restricted Project

Jan 16 2023

emaste added a comment to D141294: [libc++] Enable clang-tidy from the buildkite pipeline instead of hard-coding it in run-buildbot.

This is one of two outstanding issues I need to figure out to get the FreeBSD CI runner going

Jan 16 2023, 12:34 PM · Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase, restore clang-tidy

Jan 16 2023, 11:57 AM · Restricted Project
emaste added a comment to D141542: [libc++] Add FreeBSD XFAILs in preparation for CI runner.

LGTM if the runner in D128084 is happy.

Jan 16 2023, 9:46 AM · Restricted Project, Restricted Project, Restricted Project
emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.
  • XFAIL adjustments are in D141542
  • I've temporarily removed the clang-tidy bits in my local tree as there is an issue that needs to be investigated/resolved
  • A number of tests either had inconsistent results or timeouts and I have excluded them temporarily
    • atomic_wait.pass.cpp
    • atomic_wait_explicit.pass.cpp
    • atomic_notify_one.pass.cpp
    • thread.lock.shared.locking/lock.pass.cpp
Jan 16 2023, 8:27 AM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D128084: [libc++] Add CI job testing on FreeBSD.

Update & rebase after committing a number of related changes, and limit this review to the CI portion only

Jan 16 2023, 8:23 AM · Restricted Project, Restricted Project, Restricted Project
emaste commandeered D128084: [libc++] Add CI job testing on FreeBSD.
Jan 16 2023, 8:23 AM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase, remove a test that timed out on FreeBSD

Jan 16 2023, 8:22 AM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Jan 16 2023, 5:52 AM · Restricted Project
emaste committed rG2b91dbae650e: [libc++] allow redefined macro in non_trivial_copy_move_ABI test (authored by emaste).
[libc++] allow redefined macro in non_trivial_copy_move_ABI test
Jan 16 2023, 5:49 AM · Restricted Project, Restricted Project
emaste closed D141774: [libc++] allow redefined macro in non_trivial_copy_move_ABI test.
Jan 16 2023, 5:49 AM · Restricted Project, Restricted Project

Jan 14 2023

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Jan 14 2023, 1:05 PM · Restricted Project
emaste requested review of D141774: [libc++] allow redefined macro in non_trivial_copy_move_ABI test.
Jan 14 2023, 1:03 PM · Restricted Project, Restricted Project

Jan 12 2023

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

use // ADDITIONAL_COMPILE_FLAGS: -Wno-macro-redefined

Jan 12 2023, 5:07 PM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

retest flakey tests

Jan 12 2023, 1:53 PM · Restricted Project
emaste added inline comments to D128084: [libc++] Add CI job testing on FreeBSD.
Jan 12 2023, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

test without _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR change

Jan 12 2023, 12:02 PM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase, skip all non-FreeBSD for testing

Jan 12 2023, 9:43 AM · Restricted Project

Jan 11 2023

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Jan 11 2023, 6:10 PM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

fixup pipeline

Jan 11 2023, 1:56 PM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase

Jan 11 2023, 1:43 PM · Restricted Project
emaste requested review of D141542: [libc++] Add FreeBSD XFAILs in preparation for CI runner.
Jan 11 2023, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

sorting & curating patches

Jan 11 2023, 11:09 AM · Restricted Project
emaste added a reverting change for rGeca9196dc882: [libc++] Add FreeBSD ABI list: rG146c7d0b6abb: [libc++] Add FreeBSD exceptions.nonew ABI list.
Jan 11 2023, 10:43 AM · Restricted Project, Restricted Project
emaste committed rG146c7d0b6abb: [libc++] Add FreeBSD exceptions.nonew ABI list (authored by emaste).
[libc++] Add FreeBSD exceptions.nonew ABI list
Jan 11 2023, 10:43 AM · Restricted Project, Restricted Project
emaste added a reverting change for D140431: [libc++] Add FreeBSD ABI list: rG146c7d0b6abb: [libc++] Add FreeBSD exceptions.nonew ABI list.
Jan 11 2023, 10:43 AM · Restricted Project, Restricted Project
emaste closed D141496: [libc++] Add FreeBSD exceptions.nonew ABI list.
Jan 11 2023, 10:42 AM · Restricted Project, Restricted Project
emaste updated the diff for D141496: [libc++] Add FreeBSD exceptions.nonew ABI list.

Also remove unused ABI list from local development environment.

Jan 11 2023, 7:40 AM · Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase after ABI list change put in D141496

Jan 11 2023, 7:19 AM · Restricted Project
emaste requested review of D141496: [libc++] Add FreeBSD exceptions.nonew ABI list.
Jan 11 2023, 6:59 AM · Restricted Project, Restricted Project

Jan 10 2023

emaste added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

With (quite) a few hacks I finally managed to get a green FreeBSD run
https://buildkite.com/llvm-project/libcxx-ci/builds/17075#01859d7d-2444-4152-a2e6-a4e41c3912fc

Jan 10 2023, 1:57 PM · Restricted Project, Restricted Project, Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

tweak symbols again, rebase

Jan 10 2023, 12:58 PM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase and tweak symbols again

Jan 10 2023, 11:50 AM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

Rebase, update symbols

Jan 10 2023, 10:41 AM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

fix python

Jan 10 2023, 7:49 AM · Restricted Project
emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

rebase, tweak symbol list

Jan 10 2023, 6:51 AM · Restricted Project

Jan 6 2023

emaste updated the diff for D140050: [draft][libc++] Add CI job testing on FreeBSD.

add xfails to time tests that started failing (again?)

Jan 6 2023, 1:57 PM · Restricted Project