Page MenuHomePhabricator

emaste (Ed Maste)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2013, 5:36 AM (411 w, 3 d)

Recent Activity

May 11 2021

emaste accepted D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.
May 11 2021, 5:57 PM · Restricted Project
emaste accepted D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.
May 11 2021, 5:57 PM · Restricted Project
emaste added a comment to D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.

LGTM

May 11 2021, 7:28 AM · Restricted Project
emaste added a comment to D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.

LGTM

May 11 2021, 7:25 AM · Restricted Project

May 5 2021

emaste added inline comments to D101890: [LLD] Improve --strip-all help text.
May 5 2021, 10:03 AM · Restricted Project

May 3 2021

emaste added a comment to D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Presumably the MIPS tests changed in 72e75ca343c6f need to be changed back

May 3 2021, 3:38 PM · Restricted Project

Mar 27 2021

emaste accepted D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD.
Mar 27 2021, 6:21 PM · Restricted Project
emaste accepted D98285: [asan] Add an offset for the kernel address sanitizer on FreeBSD.
Mar 27 2021, 6:19 PM · Restricted Project

Mar 22 2021

emaste accepted D98281: [asan] Remove FreeBSD XFAIL from asan-sigbus.cpp test.

See https://svnweb.freebsd.org/base?view=revision&revision=352807

Mar 22 2021, 7:53 AM · Restricted Project

Mar 3 2021

emaste added a comment to D96626: Support: mapped_file_region: Pass MAP_NORESERVE to mmap.

So that's all the more reason to consistently use that mode everywhere, I think.

Mar 3 2021, 8:38 AM · Restricted Project

Mar 2 2021

emaste committed rG462cf39a5c18: [Driver] Fix -gz=zlib options for linker also on FreeBSD (authored by emaste).
[Driver] Fix -gz=zlib options for linker also on FreeBSD
Mar 2 2021, 5:45 AM
emaste closed D97752: Fix -gz=zlib options for linker for FreeBSD too.
Mar 2 2021, 5:45 AM · Restricted Project

Mar 1 2021

emaste added a comment to D97752: Fix -gz=zlib options for linker for FreeBSD too.

I can drop the Fixes trailer (I added it as we've adopted it in FreeBSD from Linux). That said, the referenced patch changed Gnu, AMDGPU, and HIP. My main goal here is to get the final library / executable artifacts to have compressed debug, we can look more at the intermediate bits later.

Mar 1 2021, 7:31 PM · Restricted Project
emaste retitled D97752: Fix -gz=zlib options for linker for FreeBSD too from Fix -gz=zlib options for linker to Fix -gz=zlib options for linker for FreeBSD too.
Mar 1 2021, 6:31 PM · Restricted Project
emaste requested review of D97752: Fix -gz=zlib options for linker for FreeBSD too.
Mar 1 2021, 6:30 PM · Restricted Project
emaste added a comment to D87321: Fix -gz=zlib options for linker.

I just ran into this issue on FreeBSD, bug report in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253942

Mar 1 2021, 10:19 AM · Restricted Project

Feb 24 2021

emaste added a comment to D97230: [lldb] [test] Workaround symlink-related test failures.

OK; I think this change is reasonable, I just want to make sure we don't completely lose the underlying issue.

Feb 24 2021, 11:22 AM · Restricted Project
emaste added a comment to D97210: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86.

No objection from me

Feb 24 2021, 11:19 AM · Restricted Project
emaste added a comment to D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support.

I don't think it's very likely. @emaste, any opinion on this?

Feb 24 2021, 11:17 AM · Restricted Project
emaste added a comment to D97230: [lldb] [test] Workaround symlink-related test failures.

I think it's valuable to avoid testing this (symlink issue) as a side effect of these test cases, but we should have an explicit test for this; it is an issue users could hit.

Feb 24 2021, 8:28 AM · Restricted Project

Feb 20 2021

emaste accepted D97114: [lldb] [docs] Update platform support status.

FreeBSD changes LGTM

Feb 20 2021, 8:05 AM · Restricted Project

Feb 19 2021

emaste added a comment to D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections.

See also https://bugs.llvm.org/show_bug.cgi?id=22906

Feb 19 2021, 6:34 PM · Restricted Project

Feb 14 2021

emaste added inline comments to D96555: [lldb] Remove the legacy FreeBSD plugin.
Feb 14 2021, 1:50 PM · Restricted Project
emaste added a comment to D96555: [lldb] Remove the legacy FreeBSD plugin.

Not sure if you're missing something, but removing the old plugin LGTM

Feb 14 2021, 1:49 PM · Restricted Project

Feb 8 2021

emaste accepted D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support.
Feb 8 2021, 9:29 AM · Restricted Project

Feb 3 2021

emaste added inline comments to D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes.
Feb 3 2021, 1:15 PM · Restricted Project
emaste added inline comments to D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes.
Feb 3 2021, 1:12 PM · Restricted Project

Feb 1 2021

emaste added a comment to D74367: [llvm-readelf] Print raw ELF note contents if we can't parse it.

Do you expect to pick this up again?

Feb 1 2021, 5:45 PM · Restricted Project
emaste added a comment to D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes.

@arichardson do you think you'll get back to this?

Feb 1 2021, 5:26 PM · Restricted Project

Jan 30 2021

emaste added a comment to D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support.

lldb-server. We're aiming towards removing the native plug-in soon.

Jan 30 2021, 10:10 AM · Restricted Project

Jan 4 2021

emaste added a comment to D89490: Introduce __attribute__((darwin_abi)).

For now, only Linux/ARM64 is supported/tested.

Jan 4 2021, 1:14 PM · Restricted Project, Restricted Project

Dec 31 2020

emaste added inline comments to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..
Dec 31 2020, 12:01 PM · Restricted Project

Dec 28 2020

emaste added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Dec 28 2020, 4:27 PM · Restricted Project, Restricted Project

Dec 27 2020

emaste added inline comments to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..
Dec 27 2020, 1:35 PM · Restricted Project
emaste added inline comments to D93495: CrashReason: Add MTE tag check faults to the list of crash reasons..
Dec 27 2020, 10:33 AM · Restricted Project

Dec 16 2020

emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

I think it's ok to only warn on Windows.

IMO that's sensible

Dec 16 2020, 7:17 PM · Restricted Project, Restricted Project

Dec 6 2020

emaste added a comment to D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach.

Seems reasonable to me

Dec 6 2020, 11:38 AM · Restricted Project

Dec 4 2020

emaste accepted D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching.

Ah, of course. SGTM.

Dec 4 2020, 4:59 PM · Restricted Project
emaste added a comment to D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching.

No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?

Dec 4 2020, 10:54 AM · Restricted Project

Dec 1 2020

emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

How do things go wrong on Darwin? I was under the impression that this was implemented in LLVM as strictly inline code, no runtime support required.

Dec 1 2020, 8:45 AM · Restricted Project, Restricted Project

Nov 30 2020

emaste added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

One thing that FreeBSD should do, is to upgrade to the protocol version 1 (stored in r_version), like Linux, NetBSD and OpenBSD.

Nov 30 2020, 2:43 PM · Restricted Project
emaste added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.
Nov 30 2020, 2:21 PM · Restricted Project
emaste added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

Link to Linux info:
https://sourceware.org/gdb/wiki/LinkerInterface

Nov 30 2020, 1:52 PM · Restricted Project
emaste updated subscribers of D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand.

Nov 30 2020, 7:49 AM · Restricted Project
emaste added a comment to D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress().

No objection, but maybe add a comment explaining the status of this implementation? Does/will NetBSD do the same?

Nov 30 2020, 7:40 AM · Restricted Project
emaste added a comment to D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

Can we add a test that the feature can be enabled on an OS other than Linux / Windows / Darwin?

Nov 30 2020, 6:26 AM · Restricted Project, Restricted Project
emaste abandoned D92100: [clang] do not limit -fstack-clash-protection to Linux.

Abandon in favour of D92245

Nov 30 2020, 6:25 AM
emaste added a comment to D92100: [clang] do not limit -fstack-clash-protection to Linux.

Perhaps

if (EffectiveTriple.isOSWindows() || EffectiveTriple.isOSDarwin())
  return;

here too

Nov 30 2020, 6:23 AM

Nov 25 2020

emaste added inline comments to D92100: [clang] do not limit -fstack-clash-protection to Linux.
Nov 25 2020, 1:16 PM
emaste updated the diff for D92100: [clang] do not limit -fstack-clash-protection to Linux.
  • add comment suggested by @rnk
  • combine Linux and FreeBSD FileCheck
Nov 25 2020, 1:14 PM
emaste added inline comments to D92100: [clang] do not limit -fstack-clash-protection to Linux.
Nov 25 2020, 7:28 AM
emaste requested review of D92100: [clang] do not limit -fstack-clash-protection to Linux.
Nov 25 2020, 7:25 AM

Nov 24 2020

emaste added inline comments to D68720: Support -fstack-clash-protection for x86.
Nov 24 2020, 5:34 PM · Restricted Project, Restricted Project

Nov 19 2020

emaste accepted D91810: [lldb] Prevent 'process connect' from using local-only plugins.

Looks ok to me

Nov 19 2020, 11:20 AM · Restricted Project

Nov 18 2020

emaste added inline comments to D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Nov 18 2020, 7:56 AM · Restricted Project

Nov 17 2020

emaste added inline comments to D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386.
Nov 17 2020, 8:16 PM · Restricted Project

Nov 10 2020

emaste added a comment to D91165: [libc++] Fix two fr_FR locale tests on FreeBSD.

I'm not sure if we need to add a runtime check?

Nov 10 2020, 12:15 PM · Restricted Project
emaste accepted D91165: [libc++] Fix two fr_FR locale tests on FreeBSD.

This is fine with me; have we always done that?

Nov 10 2020, 7:59 AM · Restricted Project

Nov 9 2020

emaste added a comment to D91065: [lldb] [test] Rename '.categories' to 'categories'.

No objection from me but I haven't been sufficiently involved in lldb's tests to approve.

Nov 9 2020, 7:59 AM · Restricted Project
emaste accepted D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes.

Agree that even if refactoring is needed correcting these makes sense.

Nov 9 2020, 7:56 AM · Restricted Project

Nov 8 2020

emaste accepted D91026: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'.
Nov 8 2020, 6:18 AM · Restricted Project

Nov 7 2020

emaste accepted D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP.
Nov 7 2020, 1:11 PM · Restricted Project
emaste accepted D91012: [llvm] [Support] Fix segv if argv0 is null in getMainExecutable().
Nov 7 2020, 1:09 PM · Restricted Project, Restricted Project
emaste added a comment to D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin.

In theory Obj-C is available on other systems

Nov 7 2020, 1:09 PM · Restricted Project

Nov 5 2020

emaste added a comment to D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests.

How does Windows fit into this? Other than that Q, LGTM.

Nov 5 2020, 2:54 PM
emaste accepted D90862: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD.
Nov 5 2020, 10:56 AM · Restricted Project
emaste added a comment to D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching.

Does Linux fetch each time also?
I agree it's probably not worth the effort.

Nov 5 2020, 10:55 AM · Restricted Project
emaste added inline comments to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.
Nov 5 2020, 6:40 AM · Restricted Project
emaste accepted D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

What do you suggest? Is it fine to go with my results for as long as I work on it? I can update it to match CI/buildbot results later.

Nov 5 2020, 6:35 AM · Restricted Project

Nov 4 2020

emaste added a comment to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

When running locally with this change applied I get:

Nov 4 2020, 12:42 PM · Restricted Project
emaste added a comment to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

I added comments in the now-dereferenced bugs linking back to this review - most of them were submitted by me, and I'll double check and close them once this lands.

Nov 4 2020, 10:04 AM · Restricted Project

Nov 2 2020

emaste accepted D90620: [lldb] [Process/FreeBSDRemote] Remove GetSharedLibraryInfoAddress override.
Nov 2 2020, 9:21 AM · Restricted Project

Oct 30 2020

emaste added a comment to D90454: [lldb] [Host/{free,net}bsd] Fix process matching by name.

There is TestProcessAttach.py that has an @expectedFailureNetBSD but no FreeBSD annotation, as well as TestCompletion.py, but I don't see these in the failing list.

Oct 30 2020, 7:02 AM · Restricted Project
emaste updated subscribers of D44964: Change order of libclang_rt.profile link for freebsd.
Oct 30 2020, 6:56 AM
emaste added a comment to D46791: Make -gsplit-dwarf generally available.

running clang -target x86_64-unknown-freebsd13.0 -split-dwarf foo.c indeed produces a foo.dwo and foo.o w/o invoking objcopy

Oct 30 2020, 6:56 AM

Oct 21 2020

emaste accepted D89859: Remove .svn from exclude list as we moved to git.
Oct 21 2020, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
emaste added a comment to D89859: Remove .svn from exclude list as we moved to git.

LGTM

Oct 21 2020, 7:00 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2020

emaste accepted D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support.
Oct 15 2020, 6:36 AM · Restricted Project
emaste added a comment to D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support.

Looks fine to me

Oct 15 2020, 6:36 AM · Restricted Project

Oct 13 2020

emaste added a comment to D89248: [lldb] [test/Register] Add read/write tests for multithreaded process.

Looks reasonable to me and currently fails (as expected) on FreeBSD.

Oct 13 2020, 11:31 AM · Restricted Project
emaste added inline comments to D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Oct 13 2020, 11:04 AM · Restricted Project
emaste added a comment to D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.

Looks OK

Oct 13 2020, 9:45 AM · Restricted Project
emaste added a comment to D88820: [libc++] Fix aligned_alloc tests FreeBSD.

fine with me

Oct 13 2020, 9:41 AM · Restricted Project
emaste added a comment to D88818: [libc++] Add missing XFAIL to tests that need __atomic_* libcalls.

fine with me

Oct 13 2020, 9:41 AM · Restricted Project

Sep 30 2020

emaste committed rGf794160c6cb7: [lldb] Fix FreeBSD Arm Process Plugin build (authored by emaste).
[lldb] Fix FreeBSD Arm Process Plugin build
Sep 30 2020, 6:25 AM
emaste closed D88453: [lldb] Fix FreeBSD Arm Process Plugin build..
Sep 30 2020, 6:25 AM · Restricted Project

Aug 28 2020

emaste added inline comments to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.
Aug 28 2020, 11:56 AM · Restricted Project, Restricted Project

Aug 26 2020

emaste added a comment to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.

It looks like this conflicts with OpenSSL's compiler version check

Aug 26 2020, 12:28 PM · Restricted Project

Aug 25 2020

emaste added inline comments to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.
Aug 25 2020, 6:12 PM · Restricted Project, Restricted Project

Aug 22 2020

emaste updated subscribers of D86397: Move special va_list handling to kmp_os.h.
Aug 22 2020, 7:26 AM · Restricted Project
emaste added a comment to D77333: OpenMP: Support FreeBSD on AArch64..

See D86397

Aug 22 2020, 7:25 AM · Restricted Project

Aug 18 2020

emaste added a comment to D86163: Default to disabling the libunwind frameheader cache.

Ah if you use _LIBUNWIND_USE_FRAME_HEADER_CACHE instead (i.e., a _ between FRAME and HEADER) it will match the workaround committed to FreeBSD.

Aug 18 2020, 1:30 PM · Restricted Project, Restricted Project
emaste updated subscribers of D86163: Default to disabling the libunwind frameheader cache.
Aug 18 2020, 1:28 PM · Restricted Project, Restricted Project
emaste added a comment to D86163: Default to disabling the libunwind frameheader cache.

Looks reasonable to me.

Aug 18 2020, 1:23 PM · Restricted Project, Restricted Project

Jul 27 2020

emaste accepted D84510: [msan] Compile the libatomic.c test with a C compiler.

LGTM

Jul 27 2020, 7:17 AM · Restricted Project

Jul 24 2020

emaste accepted D84541: [asan] Mark the strstr test as UNSUPPORTED on FreeBSD.

LGTM, we acquired our strstr from musl

Jul 24 2020, 11:13 AM · Restricted Project

Jul 12 2020

emaste accepted D83645: Bump the default target CPU for i386-freebsd to i686.

Fine with me

Jul 12 2020, 12:50 PM · Restricted Project

Jul 3 2020

emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project
emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project
emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project