Page MenuHomePhabricator

emaste (Ed Maste)
User

Projects

User Details

User Since
Jul 24 2013, 5:36 AM (281 w, 14 h)

Recent Activity

Thu, Dec 6

emaste added a comment to D54864: Introduce llvm-objdump man page.

Can I go ahead with this version as a starting point?

Thu, Dec 6, 11:12 AM

Mon, Dec 3

emaste updated the diff for D54864: Introduce llvm-objdump man page.
  • fix warnings from mandoc -Tlint and/or igor
  • remove options that should not be listed
Mon, Dec 3, 6:24 AM

Tue, Nov 27

emaste added a comment to D54985: [ELF] Keep empty In.RelaIplt so that __rela_iplt_{start,end} have valid st_shndx.

This is fine for me (from FreeBSD's perspective), but I suspect some people (on operating systems without ifuncs in libc) may be surprised by having a(n empty) .rela.plt in all of their statically linked binaries.

Tue, Nov 27, 6:26 PM
emaste added a comment to D54864: Introduce llvm-objdump man page.

I have an interim copy in FreeBSD and am updating it based on the feedback here; I'll update this review shortly.

Tue, Nov 27, 5:56 AM

Mon, Nov 26

emaste added a comment to D54864: Introduce llvm-objdump man page.

Additional comment that wasn't submitted while reviews.llvm.org was down on Friday: I started working on this as it's needed for us to switch from GNU objdump to llvm-objdump in FreeBSD (FreeBSD PR229046).

Mon, Nov 26, 7:32 AM
emaste added inline comments to D54864: Introduce llvm-objdump man page.
Mon, Nov 26, 6:50 AM
emaste updated the diff for D54864: Introduce llvm-objdump man page.

Review feedback

Mon, Nov 26, 6:50 AM

Sun, Nov 25

emaste added a comment to D48069: [cmake] Disable a GCC optimization when building LLVM for MIPS.

I think this is reasonable.

Sun, Nov 25, 7:34 AM
emaste added a comment to D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps.

Perhaps someone else can review?

Sun, Nov 25, 7:33 AM · lld

Sat, Nov 24

emaste added a comment to D54864: Introduce llvm-objdump man page.

lgtm, but seems that some hidden/alias options are not listed here (I could help add them). I am not expert in this area, so I will leave the decision to @kristina

Sat, Nov 24, 10:24 AM

Fri, Nov 23

emaste updated subscribers of D54864: Introduce llvm-objdump man page.
Fri, Nov 23, 7:29 AM
emaste created D54864: Introduce llvm-objdump man page.
Fri, Nov 23, 7:28 AM

Thu, Nov 22

emaste added inline comments to D54577: [ELF] - Implement -z nodefaultlib.
Thu, Nov 22, 4:06 PM

Wed, Nov 21

emaste accepted D54782: [ELF] Write IPLT header in -static -z retpolineplt mode.
Wed, Nov 21, 9:40 AM
emaste accepted D54782: [ELF] Write IPLT header in -static -z retpolineplt mode.

Confirmed this fixes my bug.

Wed, Nov 21, 6:24 AM

Tue, Nov 20

emaste updated subscribers of D54604: Automatic variable initialization.
Tue, Nov 20, 1:31 PM

Oct 15 2018

emaste added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Oct 15 2018, 3:29 PM
emaste updated subscribers of D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Oct 15 2018, 8:22 AM

Oct 14 2018

emaste added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Oct 14 2018, 1:52 PM

Oct 10 2018

emaste accepted D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections..
Oct 10 2018, 3:14 PM

Oct 9 2018

emaste committed rL344100: clang: Allow ifunc resolvers to accept arguments.
clang: Allow ifunc resolvers to accept arguments
Oct 9 2018, 5:37 PM
emaste committed rC344100: clang: Allow ifunc resolvers to accept arguments.
clang: Allow ifunc resolvers to accept arguments
Oct 9 2018, 5:37 PM
emaste closed D52703: Allow ifunc resolvers to accept arguments.
Oct 9 2018, 5:37 PM
emaste added a comment to rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

I think that the inconsistency of linkers behavior shown above shows that LLD behavior is not incorrect. It is different. But we never tried to be fully bug compatible with bfd/gold. First of all the problem is caused by a weak assumption in the linker script, which assumes that orphans are placed at the particular place before the assignment command, and my feeling it should be fixed.

Oct 9 2018, 10:24 AM
emaste added a comment to D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections..

I backported the change to lld 6.0 currently in FreeBSD-HEAD and it has the expected behaviour, but for my test case I think sh_info should reference .got.plt not .plt - note the address marked with ######## below.

Oct 9 2018, 8:55 AM
emaste added a comment to D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections..

This change looks good to me; testing it out in the FreeBSD tree now.

Oct 9 2018, 7:59 AM
emaste added a comment to D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections..

This change LGTM.

Oct 9 2018, 7:52 AM

Oct 5 2018

emaste added a comment to D52908: [LLD] [docs] Mention some notable feature in the release notes.

Looks good to me

Oct 5 2018, 6:09 AM

Oct 4 2018

emaste committed rLLD343820: ReleaseNotes: remove superfluous 's' in 'can promotes'.
ReleaseNotes: remove superfluous 's' in 'can promotes'
Oct 4 2018, 2:41 PM
emaste committed rL343820: ReleaseNotes: remove superfluous 's' in 'can promotes'.
ReleaseNotes: remove superfluous 's' in 'can promotes'
Oct 4 2018, 2:41 PM

Oct 3 2018

emaste added a comment to D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections..

For SHT_REL and SHT_RELA, sh_link references the associated symbol table and sh_info the "section to which the relocation applies."

Oct 3 2018, 11:43 AM
emaste updated subscribers of D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections..
Oct 3 2018, 7:07 AM

Oct 2 2018

emaste added a comment to D52812: Change the warning message for -warn-ifunc-textrel..

I don't think you can fix the issue by recompiling it without -fPIC

I would think a fix would be compiling with -fPIC.

Oct 2 2018, 5:13 PM

Oct 1 2018

emaste updated subscribers of D52703: Allow ifunc resolvers to accept arguments.
Oct 1 2018, 6:14 PM
emaste updated subscribers of D52703: Allow ifunc resolvers to accept arguments.
Oct 1 2018, 7:13 AM

Sep 30 2018

emaste added a comment to D52696: Update ifunc attribute support documentation.

Maybe "available for some architectures in at least..."? Or maybe we shouldn't bother trying to list versions, and mention it is dependent on CPU arch, linker, and rtld?

Sep 30 2018, 5:45 PM
emaste updated subscribers of D52703: Allow ifunc resolvers to accept arguments.
Sep 30 2018, 8:45 AM
emaste created D52703: Allow ifunc resolvers to accept arguments.
Sep 30 2018, 8:29 AM
emaste committed rC343408: Update ifunc attribute support documentation.
Update ifunc attribute support documentation
Sep 30 2018, 8:11 AM
emaste committed rL343408: Update ifunc attribute support documentation.
Update ifunc attribute support documentation
Sep 30 2018, 8:10 AM
emaste closed D52696: Update ifunc attribute support documentation.
Sep 30 2018, 8:09 AM

Sep 29 2018

emaste created D52696: Update ifunc attribute support documentation.
Sep 29 2018, 2:22 PM

Sep 26 2018

emaste added a comment to D52430: Introduce a flag to warn when ifunc symbols are used with text relocations..

I am sure IFUNC+DT_TEXTREL does not affect FreeBSD, but OpenBSD can be affected. Many other systems (including musl) may not support IFUNC at all.

Sep 26 2018, 3:35 PM
emaste added a comment to D52430: Introduce a flag to warn when ifunc symbols are used with text relocations..

Probably. We'll need this information though I think. Otherwise, how will we find that it is safe to remove the flag?

Sep 26 2018, 7:27 AM
emaste added inline comments to D52430: Introduce a flag to warn when ifunc symbols are used with text relocations..
Sep 26 2018, 7:22 AM
emaste added a comment to D52430: Introduce a flag to warn when ifunc symbols are used with text relocations..

The benefit from this that we can track and update the status of the fix and even maybe provide info about the known distributions affected/fixed on the page what can be helpful for removing this flag at some longer-term point.

Sep 26 2018, 7:15 AM

Sep 25 2018

emaste added a comment to D50294: [Driver] Use -gdwarf-3 by default for FreeBSD.

I'm using this change: https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21

Sep 25 2018, 11:10 AM
emaste accepted D52507: Fix FreeBSD build after r342633..

The FreeBSD build bot was down for a little over a week due to an IP address issue, but is back now: http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11

Sep 25 2018, 10:19 AM

Sep 24 2018

emaste updated subscribers of D52430: Introduce a flag to warn when ifunc symbols are used with text relocations..
Sep 24 2018, 12:59 PM
emaste committed rLLD342887: Correct RISC-V link in release notes.
Correct RISC-V link in release notes
Sep 24 2018, 7:52 AM
emaste committed rL342887: Correct RISC-V link in release notes.
Correct RISC-V link in release notes
Sep 24 2018, 7:52 AM

Sep 17 2018

emaste added a comment to D50297: Align AArch64 and i386 image base to superpage.

In theory this change shouldn't affect the amount of memory used by an application

Sep 17 2018, 12:19 PM

Sep 14 2018

emaste abandoned D52096: lld: add -z nodump support.

Agreed - when I submitted it I thought it might be uncommon but worth supporting, but the evidence Mark found suggests it is a single-purpose feature that is not relevant to the platforms lld supports.

Sep 14 2018, 10:31 AM
emaste added a comment to D52096: lld: add -z nodump support.

Thanks for finding that Mark - based on that IMO this feature is not worth supporting.

Sep 14 2018, 8:50 AM
emaste created D52096: lld: add -z nodump support.
Sep 14 2018, 7:56 AM
emaste committed rLLD342239: lld: add -z interpose support.
lld: add -z interpose support
Sep 14 2018, 7:29 AM
emaste committed rL342239: lld: add -z interpose support.
lld: add -z interpose support
Sep 14 2018, 7:29 AM
emaste closed D52094: lld: add -z interpose support.
Sep 14 2018, 7:29 AM
emaste updated the diff for D52094: lld: add -z interpose support.

keep flags in order

Sep 14 2018, 7:24 AM
emaste updated the diff for D52094: lld: add -z interpose support.

Reuse existing FLAGS: test

Sep 14 2018, 7:22 AM
emaste added inline comments to D52094: lld: add -z interpose support.
Sep 14 2018, 7:22 AM
emaste updated subscribers of D52094: lld: add -z interpose support.

See also https://reviews.freebsd.org/D17172 for a lld 6 version intended for commit to FreeBSD's in-tree lld.

Sep 14 2018, 7:06 AM
emaste created D52094: lld: add -z interpose support.
Sep 14 2018, 7:04 AM

Aug 5 2018

emaste added a comment to D39322: [lld] Support RISC-V.

@ruiu what do you suggest as the next step here?

Aug 5 2018, 12:03 PM · lld

Jul 30 2018

emaste added a comment to D49992: [ELF][ARM] Add Arm ABI names for float ABI ELF Header flags.

LGTM. I made the same change in FreeBSD r336745.

Jul 30 2018, 9:07 AM
emaste added a comment to D49938: [ELF] Add missing options to ld.lld.1.

FWIW I don't have a strong opinion on | vs newline to separate aliases, but if we are going to go with the newline -compact and .Pp approach I'd suggest making that change as a separate commit first so that the actual content changes here are easier to see/review.

Jul 30 2018, 6:34 AM
emaste added inline comments to D49938: [ELF] Add missing options to ld.lld.1.
Jul 30 2018, 6:31 AM
emaste added a comment to D49938: [ELF] Add missing options to ld.lld.1.

For reference I had a discussion on markup for option aliases with Ingo Schwarze and he wrote:

Jul 30 2018, 6:24 AM

Jul 4 2018

emaste added a comment to D41821: [MIPS] Disassemble the 0xefefefef trap padding used by LLD.

I'm going to implement both parts of the plan.

Jul 4 2018, 11:08 AM

May 29 2018

emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Ping?

@ruiu could I use a post-commit review option in that case?

May 29 2018, 10:55 AM · lld
emaste removed a reviewer for D31528: [ELF][MIPS] Multi-GOT implementation: espindola.
May 29 2018, 10:25 AM · lld

May 25 2018

emaste added inline comments to D47073: Document and Enforce new Host Compiler Policy.
May 25 2018, 5:58 AM

May 10 2018

emaste accepted D46690: [ELF] - Improve the test cases for notes sections..

After the second look, I think it is ok to add check here that we still keep non-a section and keep its SHT_NOTE flag for safety though. I'll update the patch.

May 10 2018, 6:36 AM
emaste accepted D46690: [ELF] - Improve the test cases for notes sections..

note-noalloc2.s is close to my original test, I think that's reasonable.

May 10 2018, 5:48 AM
emaste committed rLLD331973: [ELF] Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.
[ELF] Omit PT_NOTE for SHT_NOTE without SHF_ALLOC
May 10 2018, 4:16 AM
emaste committed rL331973: [ELF] Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.
[ELF] Omit PT_NOTE for SHT_NOTE without SHF_ALLOC
May 10 2018, 4:16 AM
emaste closed D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.
May 10 2018, 4:16 AM

May 9 2018

emaste updated the diff for D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.
May 9 2018, 8:22 PM
emaste added a comment to D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.
  1. what is the content of .debug-ghc-link-info? If the section contains an optional, human-readable string, they might have just used .comment instead.
May 9 2018, 11:16 AM
emaste added a comment to D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.

Committed to FreeBSD in r333401

May 9 2018, 4:19 AM
emaste added a comment to D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.

Yeah, @espindola was added by a Herald rule.

May 9 2018, 4:03 AM

May 8 2018

emaste added a comment to D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.

@arichardson @dim I'm also looking for approval to commit the change to FreeBSD (perhaps in advance of committing upstream), with a bump of the FreeBSD-specific version to LLD_REVISION_STRING "326565-1200002" - I might as well solicit that via this review.

May 8 2018, 7:53 PM
emaste created D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.
May 8 2018, 7:41 PM

Apr 28 2018

emaste committed rLLD331133: Add -warn-backrefs (r329636) to lld's man page.
Add -warn-backrefs (r329636) to lld's man page
Apr 28 2018, 7:23 PM
emaste committed rL331133: Add -warn-backrefs (r329636) to lld's man page.
Add -warn-backrefs (r329636) to lld's man page
Apr 28 2018, 7:22 PM
emaste added inline comments to D45195: Add --check-library-dependency to maintain compatibility with other linkers.
Apr 28 2018, 7:16 PM

Apr 25 2018

emaste added a comment to D46080: Pack symbols a bit more.

Nice :)

Apr 25 2018, 1:58 PM
emaste added a comment to D45652: Asan, fix FreeBSD support.

Do we know why pthread_{get,set}specific fails now? And would it make sense to use tls more broadly (not just on FreeBSD)?

Apr 25 2018, 9:25 AM
emaste added a reviewer for D45652: Asan, fix FreeBSD support: dim.
Apr 25 2018, 9:09 AM

Apr 21 2018

emaste committed rL330504: Temporarily skip Go TestExpressions on FreeBSD as it hangs.
Temporarily skip Go TestExpressions on FreeBSD as it hangs
Apr 21 2018, 7:02 AM
emaste committed rL330500: FreeBSD: propagate error to user if memory access fails.
FreeBSD: propagate error to user if memory access fails
Apr 21 2018, 4:27 AM

Apr 9 2018

emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Happy belated birthday Multi-GOT patch

Apr 9 2018, 1:21 PM · lld

Mar 15 2018

emaste added a comment to D40623: Correctly set reserved bits for UUID version 4..

LGTM

Mar 15 2018, 8:57 AM

Mar 9 2018

emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

Thanks for the review. As for the -Wl,-z,origin part, I'd rather leave that alone unless we have a clear indication that either it is not necessary for any of the supported FreeBSD and DragonFly BSD versions, or that it can be passed unconditionally without breaking any of the supported systems (and which linkers accept it).

Mar 9 2018, 2:25 PM

Mar 8 2018

emaste accepted D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

LGTM for FreeBSD

Mar 8 2018, 6:20 AM
emaste committed rL327000: Use ellipsis ... to indicate omitted commands.
Use ellipsis ... to indicate omitted commands
Mar 8 2018, 5:54 AM

Mar 7 2018

emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

ld(1) might accept -z origin, but why do we want it for other OSes? I don't see it used in the NetBSD dynamic ELF loader. DF_ORIGIN is just defined but not used by anything.

Mar 7 2018, 8:18 PM
emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

Uconditionally for all Unices? I don't think so.

Mar 7 2018, 4:12 PM

Mar 5 2018

emaste added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

LGTM from the FreeBSD perspective

Mar 5 2018, 8:23 AM
emaste added a reviewer for D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD: dim.
Mar 5 2018, 8:16 AM