emaste (Ed Maste)
User

Projects

User Details

User Since
Jul 24 2013, 5:36 AM (212 w, 6 d)

Recent Activity

Fri, Aug 18

emaste added a comment to D13104: Mips - Mark the section .eh_frame as writeable for pic.

We also face this problem on FreeBSD/mips64 when trying to link with lld.

Fri, Aug 18, 8:47 AM
emaste added a comment to D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.

(Aside, for FreeBSD we are rather eager to have this support arrive in lld upstream and will from there backport it to the lld 5.0.0 in our src tree. As it stands we cannot link the full base system with lld because lldb has grown too large -- https://bugs.freebsd.org/215691)

Fri, Aug 18, 6:25 AM

Thu, Aug 17

emaste added inline comments to D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.
Thu, Aug 17, 5:23 PM
emaste added a comment to D36823: [LLD][ELF] Read ARM BuildAttributes section to determine supported features..

Thank you, this will be quite useful for FreeBSD and the change seems reasonable to me.

Thu, Aug 17, 8:32 AM

Wed, Aug 16

emaste added inline comments to D36812: Add support for writing 64-bit symbol tables for archives when offsets become too large for 32-bit.
Wed, Aug 16, 5:49 PM
emaste committed rL311003: convert hard tabs to spaces in PlatformOpenBSD.cpp.
convert hard tabs to spaces in PlatformOpenBSD.cpp
Wed, Aug 16, 6:12 AM
emaste committed rL311002: Make i386-*-freebsd expression work on JIT path.
Make i386-*-freebsd expression work on JIT path
Wed, Aug 16, 5:57 AM
emaste closed D34776: Make i386-*-freebsd expression work on JIT path by committing rL311002: Make i386-*-freebsd expression work on JIT path.
Wed, Aug 16, 5:57 AM

Sun, Aug 13

emaste added a comment to D32522: Test case for the issue raised in D32271.

Ping for two open questions

Sun, Aug 13, 6:08 AM

Thu, Aug 10

emaste committed rL310644: remove FreeBSD xfail decorator from TestCppNsImport.
remove FreeBSD xfail decorator from TestCppNsImport
Thu, Aug 10, 11:27 AM
emaste committed rL310626: remove FreeBSD xfail decorator from TestCallStdStringFunction.
remove FreeBSD xfail decorator from TestCallStdStringFunction
Thu, Aug 10, 10:02 AM
emaste committed rL310624: remove FreeBSD xfail decorator from TestExitDuringBreak.
remove FreeBSD xfail decorator from TestExitDuringBreak
Thu, Aug 10, 9:49 AM
emaste committed rL310591: Report inferior signals as signals, not exceptions, on FreeBSD.
Report inferior signals as signals, not exceptions, on FreeBSD
Thu, Aug 10, 6:48 AM
emaste closed D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd by committing rL310591: Report inferior signals as signals, not exceptions, on FreeBSD.
Thu, Aug 10, 6:48 AM

Wed, Aug 9

emaste accepted D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

Still would appreciate diffs uploaded with full context - i.e.,

Note that you can upload patches created through various diff tools, including git and svn. To make reviews easier, please always include as much context as possible with your diff! Don’t worry, Phabricator will automatically send a diff with a smaller context in the review email, but having the full file in the web interface will help the reviewer understand your code.
Wed, Aug 9, 12:34 PM
emaste added a comment to D36538: Remove RISCV from LLVM_ALL_TARGETS in CMakeLists.txt.

Adding the comment above the list seems like a good idea to me.

Wed, Aug 9, 12:17 PM
emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

I've committed this to FreeBSD's copy of lldb in r322326. @labath if you're happy with this patch I will commit to lldb for @karnajitw. I'm not sure how the patch ended up with a conflict, but it's just a whitespace issue.

Wed, Aug 9, 12:13 PM

Tue, Aug 8

emaste added a reviewer for D34776: Make i386-*-freebsd expression work on JIT path: labath.
Tue, Aug 8, 11:54 AM
emaste accepted D34776: Make i386-*-freebsd expression work on JIT path.
Tue, Aug 8, 11:54 AM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

Actually, I think you probably need to extend the @skipIfLinux to apply to freebsd as well.

Tue, Aug 8, 10:27 AM

Mon, Aug 7

emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

With this patch i386 test results are comparable to amd64, and I'm happy with it from a FreeBSD perspective (modulo the PlatformOpenBSD patch conflict).

Mon, Aug 7, 6:27 PM
emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

The change in PlatformOpenBSD.cpp failed to apply for me (although it was trivial to manually apply it).

Mon, Aug 7, 12:34 PM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

With this patch I observed three new failures on FreeBSD and three new unexpected passes on FreeBSD. An example of a new failure:

Mon, Aug 7, 10:06 AM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

The patch LGTM, I will test it soon.

Mon, Aug 7, 5:34 AM
emaste added a comment to D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd.

Sorry I missed this when first uploaded, I will look at it shortly.

Mon, Aug 7, 5:23 AM
emaste added a comment to D34776: Make i386-*-freebsd expression work on JIT path.

Sorry I missed this when first uploaded, I will look at it shortly.

Mon, Aug 7, 5:23 AM

Fri, Aug 4

emaste added inline comments to D35553: Define OFF_T as 64-bit integer on NetBSD.
Fri, Aug 4, 7:30 AM · Restricted Project

Mon, Jul 24

emaste updated subscribers of D35509: Covnert .[cd]tors to .{init,fini}_array using synthetic section..
Mon, Jul 24, 5:29 PM

Jul 18 2017

emaste added a comment to D35595: Bring back r307364.

Handy Phabricator link: rL307364

Jul 18 2017, 6:20 PM
emaste added a comment to rL307100: Move clearOutputSections earlier. NFC..

Fixed in rL308382

Jul 18 2017, 5:15 PM
emaste added a reviewer for D35034: compiler-rt: use fp_t instead of long double, for consistency: compnerd.
Jul 18 2017, 1:19 PM
emaste updated subscribers of D35034: compiler-rt: use fp_t instead of long double, for consistency.
Jul 18 2017, 1:19 PM
emaste added a comment to rL307100: Move clearOutputSections earlier. NFC..

Bug report in http://llvm.org/pr33821

Jul 18 2017, 7:54 AM
emaste added a comment to rL307364: [ELF] - Handle symbols with default version early..

For reference reverted in rL308239

Jul 18 2017, 7:40 AM
emaste added a comment to D35517: Add the --chroot option for --reproduce..

Approach LGTM, modulo @grimar's issue. I wonder if we should call the option --sysroot (and make it available to users) though? We'd have a little more work to do to handle a user-supplied sysroot when creating reproducers.

Jul 18 2017, 6:03 AM
emaste added inline comments to D35553: Define OFF_T as 64-bit integer on NetBSD.
Jul 18 2017, 5:29 AM · Restricted Project

Jul 16 2017

emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

One note, the ordering of the value tags differs wrt GNU ld. It shouldn't matter, just something I noticed.

Jul 16 2017, 10:27 AM
emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

I've successfully tested this change imported into my FreeBSD work branch
https://github.com/emaste/freebsd/commit/12f8c0fd362c128c03acc9689c76d8c5d5c69dbe

Jul 16 2017, 10:26 AM
emaste added a comment to D35351: [llvm-readobj] - Teach readobj to print DT_FILTER dynamic tag in human readable form..

One note, the ordering of the value tags differs wrt GNU ld. It shouldn't matter, just something I noticed.

Jul 16 2017, 8:47 AM
emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

This LGTM.

Jul 16 2017, 3:57 AM

Jul 13 2017

emaste added a comment to D35352: [ELF] - Implement filter library support (-F / --filter).

I believe -F / --filter can be used multiple times, as with -f.

Jul 13 2017, 6:46 AM
emaste added a comment to D35351: [llvm-readobj] - Teach readobj to print DT_FILTER dynamic tag in human readable form..

Should we instead switch DT_NEEDED to be like DT_AUXILIARY? This would be similar to the format used by binutils readelf and ELF Tool Chain readelf.

Jul 13 2017, 6:43 AM

Jul 9 2017

emaste committed rL307441: remove deprecated register storage class specifier.
remove deprecated register storage class specifier
Jul 9 2017, 6:18 AM
emaste closed D35124: remove register storage class specifier. by committing rL307441: remove deprecated register storage class specifier.
Jul 9 2017, 6:17 AM
emaste added a comment to D35129: Add DragonFlyBSD support to OpenMP.

For future uploads can you please include context (e.g. git diff -U9999)
This seems reasonable to me.

Jul 9 2017, 6:13 AM

Jul 7 2017

emaste created D35124: remove register storage class specifier..
Jul 7 2017, 7:04 AM
emaste committed rL307399: remove duplicate symbol version script entries.
remove duplicate symbol version script entries
Jul 7 2017, 6:46 AM
emaste closed D35121: openmp: remove duplicate symbol version script entries by committing rL307399: remove duplicate symbol version script entries.
Jul 7 2017, 6:46 AM
emaste added a comment to D35121: openmp: remove duplicate symbol version script entries.

As an aside it looks like cmake's omp lib rule has no dependency on the version script / export list file.

Jul 7 2017, 6:23 AM
emaste updated subscribers of D35121: openmp: remove duplicate symbol version script entries.
Jul 7 2017, 6:11 AM
emaste created D35121: openmp: remove duplicate symbol version script entries.
Jul 7 2017, 6:11 AM

Jul 5 2017

emaste created D35034: compiler-rt: use fp_t instead of long double, for consistency.
Jul 5 2017, 2:14 PM

Jun 27 2017

emaste added inline comments to D34618: [LLD] Add basic 64-bit SPARC support.
Jun 27 2017, 5:22 AM
emaste committed rL306403: Sort lit.cfg architectures.
Sort lit.cfg architectures
Jun 27 2017, 5:22 AM

Jun 26 2017

emaste accepted D34632: Check for libdl, and only use it when available.
Jun 26 2017, 11:25 AM
emaste added inline comments to D34618: [LLD] Add basic 64-bit SPARC support.
Jun 26 2017, 10:02 AM

Jun 17 2017

emaste accepted D34236: Delete ProcessLauncherPosix.

LGTM from the FreeBSD side. The launch code for FreeBSD came from the original (in-process) implementation that Linux and FreeBSD shared.

Jun 17 2017, 3:59 AM

Jun 16 2017

emaste added a comment to D34313: Prefer -Ttext over linker script values.

I like this idea.

Jun 16 2017, 7:43 PM
emaste added a comment to D34236: Delete ProcessLauncherPosix.

FreeBSD build and test in progress.

Jun 16 2017, 7:39 PM
emaste added a comment to D34274: Remove home-grown thread-local storage wrappers.

Fine from FreeBSD

Jun 16 2017, 7:36 PM

Jun 13 2017

emaste added a comment to D34140: [ELF] Add armelf emulation mode.
In D34140#779285, @ruiu wrote:

This seems fine, but who actually passes "armelf"? Just want to confirm that this is in use.

Jun 13 2017, 5:42 PM · lld
emaste added a comment to D34140: [ELF] Add armelf emulation mode.

This LGTM, I had hacked something like this locally for my FreeBSD/lld work.

Jun 13 2017, 11:31 AM · lld

May 30 2017

emaste added a comment to D32522: Test case for the issue raised in D32271.

Generally LGTM with two questions inline.

May 30 2017, 6:49 AM

May 25 2017

emaste committed rL303965: FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap.
FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap
May 25 2017, 8:16 PM

May 24 2017

emaste accepted D33516: Add generic __bswap[ds]i2 implementations.

LGTM from my perspective.

May 24 2017, 5:25 PM

May 19 2017

emaste added a comment to D33343: Add some tips on how to benchhmark.

Thanks! I will try to add an equivalent section for FreeBSD shortly after this goes in.

May 19 2017, 11:09 AM
emaste added inline comments to D33343: Add some tips on how to benchhmark.
May 19 2017, 9:46 AM
emaste added a comment to D32271: Patch to Attach pid successfully from different dir.
In D32271#759361, @dim wrote:

As I found out in rL303015, the KERN_PROC_PATHNAME has one drawback: if an executable file has multiple hard links, you will get just one of its filenames as the result. Since that filename is more or less randomly chosen, it does *not* have to correspond to the actual argv[0] the executable was invoked with. If that does not matter, this approach is fine, though.

May 19 2017, 8:08 AM
emaste updated subscribers of D32271: Patch to Attach pid successfully from different dir.
May 19 2017, 5:55 AM
emaste added a comment to D32522: Test case for the issue raised in D32271.

Two small nits noted inline, but now the test does not pass without D32271 and does with it. Note that in the "without" case it returned error rather than failing, perhaps related to the path issue I noted?

May 19 2017, 5:51 AM

May 18 2017

emaste added a comment to D32820: Parallelize demangling.

Without tcmalloc, on Ubuntu 14.04, 40 core VM: 13%
With tcmalloc, on Ubuntu 14.04, 40 core VM: 24% (built using cmake ... -DCMAKE_EXE_LINKER_FLAGS=-ltcmalloc_minimal, which amazingly only works when building with clang, not gcc...)

May 18 2017, 7:56 PM

May 16 2017

emaste added a comment to D33251: [lld][ELF]Add option to make .dynamic read only.

Does it make sense to make it read-only from beginning?

May 16 2017, 2:28 PM · lld

May 10 2017

emaste added a comment to D32175: Add the llvm asan support.

The change looks fine to me from a FreeBSD perspective

May 10 2017, 1:12 PM

Apr 30 2017

emaste requested changes to D32522: Test case for the issue raised in D32271.

This test passes even without the change in D32271, presumably because exe = os.path.join(os.getcwd(), 'newdir/proc_attach') is providing us with an absolute path for argv[0].

Apr 30 2017, 1:01 PM
emaste added inline comments to D32522: Test case for the issue raised in D32271.
Apr 30 2017, 12:36 PM
emaste added a comment to D32271: Patch to Attach pid successfully from different dir.

Test case in D32522

Apr 30 2017, 11:36 AM

Apr 24 2017

emaste added a comment to D32271: Patch to Attach pid successfully from different dir.

I have plan to revisit corresponding files in NetBSD and switch from kvm(3) to sysctl(3). But this is lower priority than Process Plugin right now.

Apr 24 2017, 7:17 AM
emaste added a reviewer for D32418: "target variable" not showing all global variable if we print any global variable before execution starts: zturner.
Apr 24 2017, 6:18 AM

Apr 23 2017

emaste updated subscribers of D32271: Patch to Attach pid successfully from different dir.
Apr 23 2017, 5:44 PM
emaste updated the diff for D32271: Patch to Attach pid successfully from different dir.

Slightly simpler approach after early returns added in rL301100

Apr 23 2017, 5:43 PM
emaste commandeered D32271: Patch to Attach pid successfully from different dir.
Apr 23 2017, 5:41 PM

Apr 22 2017

emaste committed rL301100: Simplify FreeBSD Host.cpp with early returns.
Simplify FreeBSD Host.cpp with early returns
Apr 22 2017, 7:41 PM
emaste added a comment to D32120: Don't test setting sticky bits on files for (Free|Open)BSD.

I don't agree. It would mean that it's supposed to work on BSD4.4 and derivate systems like BSD/OS.

Apr 22 2017, 11:35 AM

Apr 21 2017

emaste added a comment to D32271: Patch to Attach pid successfully from different dir.

Sorry I've been away from LLDB for a bit, I will take a look at this soon.

Apr 21 2017, 7:01 PM
emaste committed rL301067: ThreadSanitizer plugin: match for loop variable with expected type.
ThreadSanitizer plugin: match for loop variable with expected type
Apr 21 2017, 6:51 PM
emaste added a comment to D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ years ago.

It's perhaps no-op, but it might be noted in the commit message what platforms are supposed to be improved.

Apr 21 2017, 6:41 PM

Apr 12 2017

emaste added a comment to D31774: [sanitizer] Introduce tid_t as a typedef for OS-provided thread IDs.

As an aside we may want pthread_getthreadid_np() (the user-facing thread ID) on FreeBSD instead of pthread_self() (an opaque pointer), as a separate / later change.

Apr 12 2017, 10:16 AM · Restricted Project
emaste committed rL300062: Fix detection of backtrace() availability on FreeBSD.
Fix detection of backtrace() availability on FreeBSD
Apr 12 2017, 7:03 AM
emaste closed D27143: Fix detection of backtrace() availability on FreeBSD by committing rL300062: Fix detection of backtrace() availability on FreeBSD.
Apr 12 2017, 7:03 AM

Apr 7 2017

emaste committed rL299781: Correct environ parsing on FreeBSD.
Correct environ parsing on FreeBSD
Apr 7 2017, 9:53 AM
emaste added a comment to D31784: Correct environ parsing on NetBSD.

For freebsd/Host.cpp I will also move Host::GetEnvironment near the end of the file (in the same place as linux/Host.cpp).

Apr 7 2017, 9:26 AM · Restricted Project
emaste accepted D31784: Correct environ parsing on NetBSD.
Apr 7 2017, 9:24 AM · Restricted Project

Apr 6 2017

emaste updated subscribers of D30087: [Driver] Unify linking of OpenMP runtime. NFCI..
Apr 6 2017, 10:11 AM

Apr 3 2017

emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

I compared the tmp objects in the failing and passing case using diffoscope and noticed one unexpected difference, although it does not appear to be root cause of the failure.

Apr 3 2017, 11:46 AM · lld
emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Thanks a lot for your help. BTW what tools and libraries do you use to build LLD: Clang (what version?) or gcc, libc++ or libstdc++?

Apr 3 2017, 9:13 AM · lld
emaste added a comment to D31557: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el..

FreeBSD ostensibly supports o32, n32, and n64, so n32 is indeed relevant for us. That said the in-tree toolchain still uses GCC 4.2.1 for MIPS, and the LLVM work is still somewhat forward-looking for us.

Apr 3 2017, 9:09 AM
emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

One other note, I tried linking the FreeBSD base system on mips64 with this patch applied (since we require mxgot or multigot to be able to link the entirety of the base system), and have a reproducible segfault in lld. A reproducer is at https://people.freebsd.org/~emaste/lld/lld-mips.tar. It seems the crash is reproducible after reverting the patch, so I'll submit a bug for it shortly.

Apr 3 2017, 8:13 AM · lld
emaste updated subscribers of D31557: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el..
Apr 3 2017, 7:37 AM

Mar 31 2017

emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

Is the error reproduced each time? I just made a clean build with the patch and did not see the error.

Mar 31 2017, 1:53 PM · lld
emaste added a comment to D31528: [ELF][MIPS] Multi-GOT implementation.

I had ELF/mips-got-and-copy.s fail for me with this applied, with .../mips-got-and-copy.s.tmp.o:(.text+0xC): relocation R_MIPS_GOT16 out of range

Mar 31 2017, 10:22 AM · lld