Page MenuHomePhabricator

emaste (Ed Maste)
User

Projects

User Details

User Since
Jul 24 2013, 5:36 AM (374 w, 1 d)

Recent Activity

Fri, Aug 28

emaste added inline comments to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.
Fri, Aug 28, 11:56 AM · Restricted Project, Restricted Project

Wed, Aug 26

emaste added a comment to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.

It looks like this conflicts with OpenSSL's compiler version check

Wed, Aug 26, 12:28 PM · Restricted Project

Aug 25 2020

emaste added inline comments to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.
Aug 25 2020, 6:12 PM · Restricted Project, Restricted Project

Aug 22 2020

emaste updated subscribers of D86397: Move special va_list handling to kmp_os.h.
Aug 22 2020, 7:26 AM · Restricted Project
emaste added a comment to D77333: OpenMP: Support FreeBSD on AArch64..

See D86397

Aug 22 2020, 7:25 AM · Restricted Project

Aug 18 2020

emaste added a comment to D86163: Default to disabling the libunwind frameheader cache.

Ah if you use _LIBUNWIND_USE_FRAME_HEADER_CACHE instead (i.e., a _ between FRAME and HEADER) it will match the workaround committed to FreeBSD.

Aug 18 2020, 1:30 PM · Restricted Project, Restricted Project
emaste updated subscribers of D86163: Default to disabling the libunwind frameheader cache.
Aug 18 2020, 1:28 PM · Restricted Project, Restricted Project
emaste added a comment to D86163: Default to disabling the libunwind frameheader cache.

Looks reasonable to me.

Aug 18 2020, 1:23 PM · Restricted Project, Restricted Project

Jul 27 2020

emaste accepted D84510: [msan] Compile the libatomic.c test with a C compiler.

LGTM

Jul 27 2020, 7:17 AM · Restricted Project

Jul 24 2020

emaste accepted D84541: [asan] Mark the strstr test as UNSUPPORTED on FreeBSD.

LGTM, we acquired our strstr from musl

Jul 24 2020, 11:13 AM · Restricted Project

Jul 12 2020

emaste accepted D83645: Bump the default target CPU for i386-freebsd to i686.

Fine with me

Jul 12 2020, 12:50 PM · Restricted Project

Jul 3 2020

emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project
emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project
emaste updated subscribers of D80105: [LLDB] Combine multiple defs of arm64 register sets.
Jul 3 2020, 10:12 AM · Restricted Project

Jun 29 2020

emaste added a comment to D82786: [llvm-ar] Unsupport test on FreeBSD.

Sorry- the review is fine as-is. There is some nuance here, but it is better to just mark this unsupported for now (as you've done) and we (FreeBSD) can revisit later when all supported versions do not allow reading dirfds.

Jun 29 2020, 3:18 PM · Restricted Project

Jun 25 2020

emaste added a comment to D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().

some nitpick comments. I'm not familiar with z/OS's APIs here so not qualified to fully review the change in getMainExecutable but seems reasonable

Jun 25 2020, 6:53 AM · Restricted Project

Jun 12 2020

emaste added a comment to D77333: OpenMP: Support FreeBSD on AArch64..

LGTM

Jun 12 2020, 11:28 AM · Restricted Project

May 30 2020

emaste added a comment to D80871: [Object] Add DF_1_PIE.

LGTM

May 30 2020, 1:46 PM · Restricted Project
emaste added a comment to D80872: [ELF] Set DF_1_PIE for -pie.

This LGTM.
I'm now adding support in FreeBSD, e.g. https://reviews.freebsd.org/rS361657

May 30 2020, 1:14 PM · Restricted Project
emaste added inline comments to D80872: [ELF] Set DF_1_PIE for -pie.
May 30 2020, 12:11 PM · Restricted Project

May 7 2020

emaste committed rG21e5e1724b75: getMainExecutable: Fix hand-rolled AT_EXECPATH for older FreeBSD (authored by emaste).
getMainExecutable: Fix hand-rolled AT_EXECPATH for older FreeBSD
May 7 2020, 2:10 PM
emaste closed D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.
May 7 2020, 2:10 PM · Restricted Project
emaste added a comment to D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.

I will commit this shortly (and then merge the change into FreeBSD's copy).

May 7 2020, 1:35 PM · Restricted Project

May 2 2020

emaste accepted D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.
May 2 2020, 1:14 PM · Restricted Project

Apr 20 2020

emaste accepted D77776: [Driver] Default to libc++ on FreeBSD.

Looks ok to me

Apr 20 2020, 11:53 AM · Restricted Project
emaste added a comment to D77776: [Driver] Default to libc++ on FreeBSD.
  • Limit the scope to -stdlib
In D77776#1972543, @dim wrote:

the lowest supported version, which is currently 10

Where is this defined? Does someone build LLVM master on FreeBSD < 11.3?

Apr 20 2020, 11:53 AM · Restricted Project

Apr 2 2020

emaste committed rG55e32e92cda7: [lldb] update eArgTypeScriptLang description to mention lua (authored by emaste).
[lldb] update eArgTypeScriptLang description to mention lua
Apr 2 2020, 7:01 AM
emaste closed D77241: update eArgTypeScriptLang description to mention lua.
Apr 2 2020, 7:01 AM · Restricted Project

Apr 1 2020

emaste committed rGaf1b7d06d9e4: Correct copy-pasteo in lua script language description (authored by emaste).
Correct copy-pasteo in lua script language description
Apr 1 2020, 9:14 PM
emaste updated the diff for D77241: update eArgTypeScriptLang description to mention lua.

reword

Apr 1 2020, 5:26 PM · Restricted Project
emaste created D77241: update eArgTypeScriptLang description to mention lua.
Apr 1 2020, 1:41 PM · Restricted Project

Mar 21 2020

emaste added a comment to D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__.

Ping.

Mar 21 2020, 12:48 PM

Feb 7 2020

emaste added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 7 2020, 6:12 AM · Restricted Project, Restricted Project

Feb 6 2020

emaste added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 5:41 AM · Restricted Project, Restricted Project
emaste added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

It will be nice to include in the description what systems were not supported by hard coding 560, if such information can be obtained relatively easily.

Feb 6 2020, 5:41 AM · Restricted Project, Restricted Project

Dec 16 2019

emaste added inline comments to D71554: [llvm-ranlib] Handle -D and -U command line flag.
Dec 16 2019, 9:29 AM · Restricted Project, Restricted Project

Nov 18 2019

emaste committed rGb462cdff05b8: Avoid duplicate exe_path definition on recent FreeBSD (authored by emaste).
Avoid duplicate exe_path definition on recent FreeBSD
Nov 18 2019, 5:54 AM

Nov 17 2019

emaste added a comment to D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..

Should have a test added

Nov 17 2019, 10:15 AM · Restricted Project

Nov 15 2019

emaste added a comment to D70157: Align branches within 32-Byte boundary(NOP padding).

I think the default policy discussion might be better had on llvm-dev than a Phab review.

Nov 15 2019, 12:28 PM · Restricted Project, Restricted Project
emaste committed rGcb1761465a0d: clang: enable unwind tables on FreeBSD !amd64 (authored by emaste).
clang: enable unwind tables on FreeBSD !amd64
Nov 15 2019, 7:43 AM
emaste closed D70110: [Driver][FreeBSD] Enable unwind tables on !amd64.
Nov 15 2019, 7:42 AM · Restricted Project
emaste added a comment to D70157: Align branches within 32-Byte boundary(NOP padding).

Shall we default to -mbranches-within-32B-boundaries if the specified -march= or -mtune= may be affected by the erratum?

Nov 15 2019, 6:40 AM · Restricted Project, Restricted Project

Nov 14 2019

emaste updated subscribers of D70157: Align branches within 32-Byte boundary(NOP padding).
Nov 14 2019, 10:06 AM · Restricted Project, Restricted Project
emaste committed rGa0a38b81ea91: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath (authored by emaste).
On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath
Nov 14 2019, 6:54 AM
emaste closed D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.
Nov 14 2019, 6:54 AM · Restricted Project

Nov 13 2019

emaste updated subscribers of D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.
Nov 13 2019, 2:21 PM · Restricted Project
emaste updated the diff for D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.

Use elf_aux_info() if we can

Nov 13 2019, 2:14 PM · Restricted Project
emaste added a comment to D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.

See https://bugs.freebsd.org/241932

Nov 13 2019, 12:02 PM · Restricted Project
emaste created D70198: On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath.
Nov 13 2019, 11:50 AM · Restricted Project

Nov 8 2019

emaste added a comment to D70011: lld patch for Linker Script UTF-8 BOM encoding capability .

Out of curiosity what workflow leads to BOMs in linker scripts?

Nov 8 2019, 9:12 AM · Restricted Project, lld

Oct 23 2019

emaste added a comment to D69004: Use portable flag with nm in extract_symbols.py.

I was under the impression that -P was supported on FreeBSD.

Oct 23 2019, 3:47 PM · Restricted Project
emaste added a comment to D69004: Use portable flag with nm in extract_symbols.py.

Is this using the system nm? ELF Tool Chain nm does not (currently) support the -P flag.

Oct 23 2019, 2:14 PM · Restricted Project

Oct 18 2019

emaste accepted D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 12:59 PM · Restricted Project
emaste accepted D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.

OK with me

Oct 18 2019, 11:25 AM · Restricted Project

Oct 2 2019

emaste added a comment to D68269: [libc++abi] Do not define new/delete by default.

For reference libcxxrt comes from here: https://github.com/libcxxrt/libcxxrt

Oct 2 2019, 6:21 PM · Restricted Project

Sep 27 2019

emaste updated subscribers of D66870: [Sanitizers] Add support for RISC-V 64-bit.
Sep 27 2019, 8:56 AM · Restricted Project, Restricted Project

Sep 24 2019

emaste added a comment to D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc.
In D60748#1499756, @dim wrote:

Please also exclude FreeBSD from these changes, since we care a lot about backwards compatibility, and specifically about alignment requirements. (We have run into many issues in our ports collection where upstream assumes everything is 16-byte aligned on i386, which is *NOT* ABI compliant.)

Sep 24 2019, 11:42 AM · Restricted Project
emaste updated subscribers of D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc.
Sep 24 2019, 11:37 AM · Restricted Project

Sep 9 2019

emaste committed rG1a3dd638c4a9: compiler-rt: use fp_t instead of long double, for consistency (authored by emaste).
compiler-rt: use fp_t instead of long double, for consistency
Sep 9 2019, 6:52 AM
emaste committed rL371400: compiler-rt: use fp_t instead of long double, for consistency.
compiler-rt: use fp_t instead of long double, for consistency
Sep 9 2019, 6:50 AM
emaste closed D35034: compiler-rt: use fp_t instead of long double, for consistency.
Sep 9 2019, 6:49 AM · Restricted Project
emaste accepted D46518: LLDB - Simplify GetProgramFileSpec.

This is fine with me as a little simplification and avoid an extra syscall.

Sep 9 2019, 6:29 AM · Restricted Project
Herald added a project to D46518: LLDB - Simplify GetProgramFileSpec: Restricted Project.

From sysctl_kern_proc_pathname:

error = vn_fullpath(req->td, vp, &retbuf, &freebuf);
vrele(vp);
if (error)
        return (error);
error = SYSCTL_OUT(req, retbuf, strlen(retbuf) + 1);

and in vn_fullpath:

buf = malloc(MAXPATHLEN, M_TEMP, M_WAITOK);
Sep 9 2019, 6:29 AM · Restricted Project

Sep 7 2019

emaste added inline comments to D56398: Add new EINTEGRITY errno.
Sep 7 2019, 6:06 AM
emaste added a comment to D67316: Remove ::gets for FreeBSD 13 and later.

LGTM from the FreeBSD perspective.

Sep 7 2019, 5:36 AM · Restricted Project

Sep 3 2019

emaste added a comment to D46791: Make -gsplit-dwarf generally available.

Ping

Sep 3 2019, 11:08 AM
emaste accepted D52812: Change the warning message for -warn-ifunc-textrel..
Sep 3 2019, 11:06 AM · Restricted Project
emaste updated the diff for D35034: compiler-rt: use fp_t instead of long double, for consistency.
  • rebase
  • also change __addtf3 return type
Sep 3 2019, 11:06 AM · Restricted Project
emaste added inline comments to D35034: compiler-rt: use fp_t instead of long double, for consistency.
Sep 3 2019, 11:06 AM · Restricted Project
emaste committed rG5289bbe4d4c7: ld.lld.1: explain long options may use one or two dashes (authored by emaste).
ld.lld.1: explain long options may use one or two dashes
Sep 3 2019, 11:00 AM
emaste committed rG174e08334541: ld.lld.1: stylistic changes suggested by igor (authored by emaste).
ld.lld.1: stylistic changes suggested by igor
Sep 3 2019, 10:59 AM
emaste committed rL370800: ld.lld.1: explain long options may use one or two dashes.
ld.lld.1: explain long options may use one or two dashes
Sep 3 2019, 10:58 AM
emaste committed rL370799: ld.lld.1: stylistic changes suggested by igor.
ld.lld.1: stylistic changes suggested by igor
Sep 3 2019, 10:57 AM
emaste committed rGdfde7b09c830: clang: default to DWARF 4 for FreeBSD 12.0 and later (authored by emaste).
clang: default to DWARF 4 for FreeBSD 12.0 and later
Sep 3 2019, 9:30 AM
emaste committed rL370779: clang: default to DWARF 4 for FreeBSD 12.0 and later.
clang: default to DWARF 4 for FreeBSD 12.0 and later
Sep 3 2019, 9:29 AM
emaste closed D66760: clang: default to DWARF 4 for FreeBSD 12.0 and later.
Sep 3 2019, 9:29 AM · Restricted Project
emaste updated the diff for D66760: clang: default to DWARF 4 for FreeBSD 12.0 and later.

Correct typo, update tests

Sep 3 2019, 8:12 AM · Restricted Project
emaste added inline comments to D66760: clang: default to DWARF 4 for FreeBSD 12.0 and later.
Sep 3 2019, 8:12 AM · Restricted Project
emaste committed rG1b6ee802c66a: compiler-rt: use 64-bit time_t for all FreeBSD archs except i386 (authored by emaste).
compiler-rt: use 64-bit time_t for all FreeBSD archs except i386
Sep 3 2019, 6:54 AM
emaste committed rL370756: compiler-rt: use 64-bit time_t for all FreeBSD archs except i386.
compiler-rt: use 64-bit time_t for all FreeBSD archs except i386
Sep 3 2019, 6:43 AM
emaste closed D66758: compiler-rt: all FreeBSD CPU archs except i386 use 64-bit time_t.
Sep 3 2019, 6:43 AM · Restricted Project
emaste committed rG14cf2b20ca6d: compiler-rt: use more __sanitizer_time_t on FreeBSD (authored by emaste).
compiler-rt: use more __sanitizer_time_t on FreeBSD
Sep 3 2019, 6:43 AM
emaste committed rL370755: compiler-rt: use more __sanitizer_time_t on FreeBSD.
compiler-rt: use more __sanitizer_time_t on FreeBSD
Sep 3 2019, 6:40 AM
emaste closed D66756: compiler-rt: use more __sanitizer_time_t on FreeBSD.
Sep 3 2019, 6:40 AM · Restricted Project

Aug 29 2019

emaste added a comment to D66756: compiler-rt: use more __sanitizer_time_t on FreeBSD.

It turns out __LP64__ is wrong anyway, see D66758, so I intend to commit this first with no functional change and then follow up with D66758.

Aug 29 2019, 5:21 AM · Restricted Project

Aug 26 2019

emaste added a comment to D66760: clang: default to DWARF 4 for FreeBSD 12.0 and later.

FreeBSD references:
https://reviews.freebsd.org/D17930
https://reviews.freebsd.org/rS343429

Aug 26 2019, 11:21 AM · Restricted Project
emaste created D66760: clang: default to DWARF 4 for FreeBSD 12.0 and later.
Aug 26 2019, 11:03 AM · Restricted Project
emaste created D66758: compiler-rt: all FreeBSD CPU archs except i386 use 64-bit time_t.
Aug 26 2019, 10:56 AM · Restricted Project
emaste created D66756: compiler-rt: use more __sanitizer_time_t on FreeBSD.
Aug 26 2019, 10:37 AM · Restricted Project

Aug 14 2019

emaste added a comment to D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

And moved to CodeGen in rL339397

Aug 14 2019, 7:16 AM
emaste added a comment to D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

@brooks @arichardson is this something we want to revisit?

Aug 14 2019, 7:08 AM

Jul 30 2019

emaste added a comment to D65430: Add `--dependency-files` option, which is equivalent to compiler option -MD..

My understanding is that many developers use makefile/ninja generation systems such as cmake rather than hand-write the file themselves. As such would this get much use unless it was integrated into these generators? May be worth approaching them to see if they have any requirements/observations about the option?

Jul 30 2019, 6:45 AM · Restricted Project

Jul 23 2019

emaste updated subscribers of D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

@brooks @arichardson is this something we want to revisit?

Jul 23 2019, 1:50 PM
emaste added a comment to D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking..

OK, I will try to check if it still applies cleanly and commit soon

Jul 23 2019, 7:23 AM

Jul 22 2019

emaste added a comment to D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking..

@brooks, @arichardson do we still want to pursue this?

Jul 22 2019, 2:18 PM

Jun 4 2019

emaste added a comment to D62853: Read .note.gnu.property sections and emit a merged .note.gnu.property section..

I've created D62862 which is independent of X86/AArch64.

Jun 4 2019, 9:40 AM · Restricted Project

May 27 2019

emaste added inline comments to D57795: [RISCV] Add FreeBSD targets.
May 27 2019, 6:47 AM · Restricted Project, Restricted Project

May 7 2019

emaste added inline comments to D61613: [LLD][ELF] Add the -z ifunc-noplt option.
May 7 2019, 7:18 AM · Restricted Project

Apr 24 2019

Herald added a project to D50294: [Driver] Use -gdwarf-3 by default for FreeBSD: Restricted Project.

I'm using this change: https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21

In FreeBSD 12 and later we use Clang, lld, and ELF Tool Chain. (We still have gas and objdump from the outdated binutils 2.17.50.)

Will you upstream this commit (I can abandon this one)? I created this revision because I was learning clangDriver... I had a vague and probably incorrect impression that some folks said kgdb or dtrace or whatever might not support DWARF 3 or 4.

Apr 24 2019, 1:09 PM · Restricted Project

Apr 15 2019

emaste added a comment to D60439: [llvm-objcopy] Accept --long-option but not -long-option.

LGTM. I much prefer only - short and -- long options, except for lld where unfortunately there's a precedent of accepting both.

Apr 15 2019, 7:00 AM · Restricted Project