Page MenuHomePhabricator

emaste (Ed Maste)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2013, 5:36 AM (466 w, 5 d)

Recent Activity

Sun, Jun 26

emaste added a comment to D128592: [docs] Remove outdated status update for FreeBSD.

LGTM - yes, this links to a 2016 status report and is not relevant to include here anymore.

Sun, Jun 26, 6:16 PM · Restricted Project, lld, Restricted Project

Mon, Jun 20

emaste added a comment to D128195: [LLD][ELF] Add FORCE_LLD_DIAGNOSTICS_CRASH to force LLD to crash.

LGTM

Mon, Jun 20, 6:09 AM · Restricted Project, Restricted Project

Mon, Jun 13

emaste added a comment to D127657: [libc++] Remove mention of official support for FreeBSD.

I actually hope that I'll never commit this change

Mon, Jun 13, 11:13 AM · Restricted Project, Restricted Project

Thu, Jun 9

emaste accepted D126982: [lldb] [test] Implement getting thread ID on FreeBSD.
Thu, Jun 9, 12:47 PM · Restricted Project, Restricted Project
emaste added a comment to D127360: [libc++] Drop the legacy debug mode symbols by default.

@danalbert @dim I think this is worth your input. Can you confirm whether you folks have been shipping symbols like __ZNSt3__111__libcpp_db10__insert_iEPv (std::__1::__libcpp_db::__insert_i(void*)), and whether you are aware of applications using those symbols?

Thu, Jun 9, 9:21 AM · Restricted Project, Restricted Project
emaste committed rG95141aa9cbb1: Fix TableLookupTest on FreeBSD (authored by andrew).
Fix TableLookupTest on FreeBSD
Thu, Jun 9, 6:24 AM · Restricted Project, Restricted Project
emaste closed D125902: [fuzzer] Fix TableLookupTest on FreeBSD.
Thu, Jun 9, 6:24 AM · Restricted Project, Restricted Project

Wed, Jun 8

emaste committed rGccae01cbce8a: [compiler-rt] Fix Mmap on FreeBSD AArch64 (authored by andrew).
[compiler-rt] Fix Mmap on FreeBSD AArch64
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project
emaste committed rGad3faddaa67d: [compiler-rt] Fix the longjmp sp slot on FreeBSD AArch64 (authored by andrew).
[compiler-rt] Fix the longjmp sp slot on FreeBSD AArch64
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project
emaste committed rGb3c1442c6c0b: [compiler-rt] Add the FreeBSD AArch64 shadow offset (authored by andrew).
[compiler-rt] Add the FreeBSD AArch64 shadow offset
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project
emaste committed rG9496e39b4a83: [compiler-rt] Add the common FreeBSD AArch64 support (authored by andrew).
[compiler-rt] Add the common FreeBSD AArch64 support
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project
emaste closed D125901: [safestack] Fix Mmap on FreeBSD AArch64.
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project
emaste closed D125762: [tsan] Fix the longjmp sp slot on FreeBSD AArch64.
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project
emaste closed D125757: [asan] Add the FreeBSD AArch64 shadow offset.
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project
emaste closed D125756: [sanitizer] Add the common FreeBSD AArch64 support.
Wed, Jun 8, 2:23 PM · Restricted Project, Restricted Project

Jun 1 2022

emaste committed rG18efa420da5f: compiler-rt: Allow build without __c11_atomic_fetch_nand (authored by brooks).
compiler-rt: Allow build without __c11_atomic_fetch_nand
Jun 1 2022, 9:59 AM · Restricted Project, Restricted Project
emaste closed D126710: Allow build without __c11_atomic_fetch_nand.
Jun 1 2022, 9:58 AM · Restricted Project, Restricted Project
emaste accepted D126770: [lldb] [Process/FreeBSD] Do not send SIGSTOP to stopped process.
Jun 1 2022, 5:14 AM · Restricted Project, Restricted Project

May 31 2022

emaste added a comment to D126710: Allow build without __c11_atomic_fetch_nand.

Fine with me from a FreeBSD perspective

May 31 2022, 10:29 AM · Restricted Project, Restricted Project

May 26 2022

emaste added a comment to D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14.

However, I am not completely sure how far off FreeBSD 14.0's "freeze" is, e.g. when a stable/14 branch is created, and the main branch is bumped to 15.0.

May 26 2022, 12:03 PM · Restricted Project, Restricted Project
emaste accepted D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14.

Sounds good to me. We can bump the .so version in the base system, but how do we treat it upstream (i.e., here in llvm) and in the ports tree?

May 26 2022, 7:06 AM · Restricted Project, Restricted Project
emaste added a comment to D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14.

For reference, we're going to support FreeBSD 13 until Jan 2026.
https://www.freebsd.org/security/

May 26 2022, 7:04 AM · Restricted Project, Restricted Project

Apr 11 2022

emaste accepted D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.
Apr 11 2022, 5:35 AM · Restricted Project, Restricted Project

Apr 8 2022

emaste accepted D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.

Sounds good to me for FreeBSD (w/ the release note as mentioned by @ldionne) arc4random is ChaCha20 in all supported FreeBSD versions.

Apr 8 2022, 3:05 PM · Restricted Project, Restricted Project
emaste added a reviewer for D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD: dim.
Apr 8 2022, 2:15 PM · Restricted Project, Restricted Project

Mar 27 2022

emaste accepted D122545: Skip attempts to access /proc/self/fd on FreeBSD.
Mar 27 2022, 10:15 AM · Restricted Project, Restricted Project

Mar 23 2022

Herald added a project to D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64: Restricted Project.
Mar 23 2022, 9:25 AM · Restricted Project, Restricted Project

Mar 4 2022

emaste accepted D121015: [libunwind] Add a _LIBUNWIND_VERSION macro.

LGTM (modulo the lint complaints)

Mar 4 2022, 12:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__: Restricted Project.

The original author appears to have given up on it. Someone will need to rebase and work on pushing it forward

Mar 2 2022, 12:38 PM · Restricted Project

Mar 1 2022

emaste added inline comments to D120701: [ELF] Add -z pack-relative-relocs.
Mar 1 2022, 2:32 PM · Restricted Project, Restricted Project

Feb 24 2022

emaste added a comment to D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.

We need to make sure a test covers this as well, perhaps just enabling lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py?

Feb 24 2022, 9:49 AM · Restricted Project, Restricted Project
emaste updated subscribers of D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.
Feb 24 2022, 9:48 AM · Restricted Project, Restricted Project
emaste added inline comments to D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.
Feb 24 2022, 9:04 AM · Restricted Project, Restricted Project

Feb 17 2022

emaste added inline comments to D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 17 2022, 6:41 AM · Restricted Project, Restricted Project

Feb 16 2022

emaste added inline comments to D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 16 2022, 10:35 AM · Restricted Project, Restricted Project

Feb 15 2022

emaste added a comment to D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests.

ping

Feb 15 2022, 12:08 PM
emaste added inline comments to D119538: [libcxxabi] [test] Depend on unwind only if available.
Feb 15 2022, 12:07 PM · Restricted Project, Restricted Project

Feb 11 2022

emaste added a comment to D119515: [asan] Always skip first object from dl_iterate_phdr.

OK with me.

Feb 11 2022, 6:26 AM · Restricted Project, Restricted Project

Feb 8 2022

emaste updated subscribers of D119255: [runtimes] Remove support for standalone builds.
Feb 8 2022, 12:38 PM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2022

emaste committed rG64de0064f315: [sanitizer] Improve FreeBSD ASLR detection (authored by emaste).
[sanitizer] Improve FreeBSD ASLR detection
Jan 18 2022, 2:08 PM
emaste closed D117521: [sanitizer] Improve FreeBSD ASLR detection.
Jan 18 2022, 2:07 PM · Restricted Project

Jan 17 2022

emaste added a comment to D117521: [sanitizer] Improve FreeBSD ASLR detection.

procctl was added as of FreeBSD 10.0, and both 10.x and 11.x are now EOL, so I don't think we need to support for cases where it is not available.

Jan 17 2022, 7:17 PM · Restricted Project
emaste updated the diff for D117521: [sanitizer] Improve FreeBSD ASLR detection.
Jan 17 2022, 6:17 PM · Restricted Project
emaste updated the diff for D117521: [sanitizer] Improve FreeBSD ASLR detection.

0 is an alias for curproc

Jan 17 2022, 5:50 PM · Restricted Project
emaste added inline comments to D117521: [sanitizer] Improve FreeBSD ASLR detection.
Jan 17 2022, 5:50 PM · Restricted Project
emaste added a comment to D117521: [sanitizer] Improve FreeBSD ASLR detection.

As a subsequent change I'll propose using PROC_ASLR_CTL to turn ASLR off and ReExec().

Jan 17 2022, 4:26 PM · Restricted Project
emaste added a comment to D117521: [sanitizer] Improve FreeBSD ASLR detection.

References:
rG:e2ed800d622567b35968a27f8784705fb48190f5
https://github.com/llvm/llvm-project/issues/53256

Jan 17 2022, 4:11 PM · Restricted Project
emaste requested review of D117521: [sanitizer] Improve FreeBSD ASLR detection.
Jan 17 2022, 4:09 PM · Restricted Project

Dec 20 2021

emaste added a comment to D115957: [Support] Revert posix_fallocate in resize_file.

It greatly harms performance on Linux tmpfs, 0.3s in my 5.2s link.

Dec 20 2021, 10:31 AM · Restricted Project

Dec 17 2021

emaste added a comment to D115957: [Support] Revert posix_fallocate in resize_file.

it is likely Linux specific

Dec 17 2021, 12:24 PM · Restricted Project

Dec 15 2021

emaste committed rGb41bb6c1b715: [Driver] Default to contemporary FreeBSD profiling behaviour (authored by emaste).
[Driver] Default to contemporary FreeBSD profiling behaviour
Dec 15 2021, 6:07 AM
emaste closed D114396: [Driver] Default to current FreeBSD profiling behaviour.
Dec 15 2021, 6:07 AM · Restricted Project

Dec 6 2021

emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

We requested an experimental ports build with the start-stop-gc behaviour reverted (i.e., with getZFlag(args, "start-stop-gc", "nostart-stop-gc", false);)

Dec 6 2021, 8:49 AM · Restricted Project

Dec 3 2021

emaste added inline comments to D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores.
Dec 3 2021, 1:59 PM · Restricted Project
emaste accepted D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests.

Fine with me, or maybe "A test for Darwin- (and prehaps Windows-)specific behavior."

Dec 3 2021, 1:52 PM

Dec 2 2021

emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

@jrtc27 and @emaste are both on board that the traditional GNU ld behavior / current 13.0.0 behavior is the future.

Dec 2 2021, 12:55 PM · Restricted Project

Dec 1 2021

emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

FreeBSD used an ancient version of GNU ld (2.17.50, from mid 2000s) until we migrated all target architectures to lld. That old ld defaults to no GC start/stop, we have been using that behaviour for decades.

Dec 1 2021, 8:22 AM · Restricted Project
emaste added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

compatible with GNU ld newer than 2015-10

Dec 1 2021, 7:41 AM · Restricted Project

Nov 22 2021

emaste updated subscribers of D114396: [Driver] Default to current FreeBSD profiling behaviour.

Similar idea to D77776 (libc++ default if major not specified)

Nov 22 2021, 2:04 PM · Restricted Project
emaste requested review of D114396: [Driver] Default to current FreeBSD profiling behaviour.
Nov 22 2021, 2:02 PM · Restricted Project
emaste committed rG2dec2aa3ad08: [Driver] Default to libc++ on FreeBSD (authored by jbeich).
[Driver] Default to libc++ on FreeBSD
Nov 22 2021, 1:47 PM
emaste closed D77776: [Driver] Default to libc++ on FreeBSD.
Nov 22 2021, 1:47 PM · Restricted Project
emaste committed rGa40dcd060e9d: [Driver] correct typo in FreeBSD 14 test (authored by emaste).
[Driver] correct typo in FreeBSD 14 test
Nov 22 2021, 11:38 AM
emaste added inline comments to D77776: [Driver] Default to libc++ on FreeBSD.
Nov 22 2021, 8:38 AM · Restricted Project
emaste updated the diff for D77776: [Driver] Default to libc++ on FreeBSD.

rebase tests

Nov 22 2021, 8:36 AM · Restricted Project
emaste commandeered D77776: [Driver] Default to libc++ on FreeBSD.
Nov 22 2021, 8:36 AM · Restricted Project

Nov 2 2021

emaste added a comment to D96914: [ELF] Add -z start-stop-gc to let __start_/__stop_ not retain C identifier name sections.

@emaste replied: "However, if GNU ld / gold / lld default to GCing things we could set the option to reenable it in kernel/userland Makefiles."

Nov 2 2021, 1:55 PM · Restricted Project

Nov 1 2021

emaste added a comment to D111863: [libunwind] Add an interface for dynamic .eh_frame registration.

@joerg @dim @emaste Any further comments on this?

Nov 1 2021, 5:40 PM · Restricted Project, Restricted Project

Sep 28 2021

emaste committed rG993ada05f5a0: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test (authored by andrew).
[lldb] [unittests] Fix building the FreeBSD arm64 Register Context test
Sep 28 2021, 7:55 AM
emaste closed D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test.
Sep 28 2021, 7:55 AM · Restricted Project

Sep 24 2021

emaste added a comment to D108120: [lld] Add CMake options to disable individual linkers.

IMO this is worth it for the build time reduction, the size reduction is a nice bonus but not the main benefit.

Sep 24 2021, 5:46 AM · Restricted Project, Restricted Project

Sep 16 2021

emaste added a comment to D109090: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on FreeBSD.

It looks like this worked prior to 2518433f861f because shouldAssumeDSOLocal has this case:

// PPC has no copy relocations and cannot use a plt entry as a symbol address.
llvm::Triple::ArchType Arch = TT.getArch();
if (Arch == llvm::Triple::ppc || Arch == llvm::Triple::ppc64 ||
    Arch == llvm::Triple::ppc64le)
  return false;
Sep 16 2021, 12:24 PM · Restricted Project

Sep 14 2021

emaste added a comment to D109753: [Sanitizers] intercept fparseln on FreeBSD.

Do we want to share some of these tests between NetBSD and FreeBSD?

Sep 14 2021, 10:57 AM · Restricted Project

Aug 24 2021

emaste committed rG6609892a2dcd: [clang] allow -fstack-clash-protection on FreeBSD (authored by emaste).
[clang] allow -fstack-clash-protection on FreeBSD
Aug 24 2021, 6:03 PM
emaste closed D108571: [clang] allow -fstack-clash-protection on FreeBSD.
Aug 24 2021, 6:03 PM · Restricted Project
emaste added a comment to D108630: [libc++] Remove _LIBCPP_HAS_NO_LONG_LONG in favour of using_if_exists.

Would it be possible to add build bots for FreeBSD so we can test changes like those automatically?

Aug 24 2021, 10:28 AM · Restricted Project

Aug 23 2021

emaste added a comment to D54880: Ignore gcc's stack-clash-protection flag.

Superseded by e67cbac81211d40332a79d98c9d5953624cc1202 (D68720)

Aug 23 2021, 12:06 PM · Restricted Project
emaste added a comment to D108571: [clang] allow -fstack-clash-protection on FreeBSD.

We make this change in FreeBSD's in-tree Clang about 9 months ago (https://reviews.freebsd.org/D27366)

Aug 23 2021, 11:55 AM · Restricted Project
emaste requested review of D108571: [clang] allow -fstack-clash-protection on FreeBSD.
Aug 23 2021, 11:54 AM · Restricted Project

Aug 6 2021

emaste accepted D107635: [LLD] Support compressed input sections on big-endian targets.
Aug 6 2021, 11:55 AM · Restricted Project
emaste added a comment to D107635: [LLD] Support compressed input sections on big-endian targets.

LGTM

Aug 6 2021, 11:55 AM · Restricted Project
emaste updated subscribers of D107635: [LLD] Support compressed input sections on big-endian targets.
Aug 6 2021, 7:08 AM · Restricted Project
emaste added a comment to D107635: [LLD] Support compressed input sections on big-endian targets.

With this patch applied BE mips64 FreeBSD builds successfully for me

Aug 6 2021, 7:07 AM · Restricted Project

Aug 4 2021

emaste added a comment to D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance.

LGTM, although in FreeBSD we don't have any backwards- or cross-compatibility issues to worry about.

Aug 4 2021, 9:48 AM · Restricted Project, Restricted Project

Jul 28 2021

emaste accepted D106964: [Security] Replace a Sony member.
Jul 28 2021, 2:12 PM · Restricted Project

Jul 27 2021

emaste accepted D106917: Security: make peoples' phab names obvious; recommend phab as the place for nominations.
Jul 27 2021, 6:06 PM · Restricted Project

Jul 7 2021

emaste added inline comments to D105563: [libc++][docs] Update documentation to reflect libc++'s compiler support policy.
Jul 7 2021, 1:01 PM · Restricted Project

Jun 26 2021

emaste committed rG699d47472c3f: [Driver] do not link _p libs for -pg on FreeBSD 14 and later (authored by emaste).
[Driver] do not link _p libs for -pg on FreeBSD 14 and later
Jun 26 2021, 3:22 PM
emaste closed D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14.
Jun 26 2021, 3:21 PM · Restricted Project

Jun 22 2021

emaste added a comment to D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14.

-pg is still supported (see the OPT_pg at line 253), gprof just won't be able to "see into" libc, libm, etc.

Jun 22 2021, 5:21 PM · Restricted Project
emaste requested review of D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14.
Jun 22 2021, 2:44 PM · Restricted Project

May 11 2021

emaste accepted D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.
May 11 2021, 5:57 PM · Restricted Project
emaste accepted D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.
May 11 2021, 5:57 PM · Restricted Project
emaste added a comment to D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo.

LGTM

May 11 2021, 7:28 AM · Restricted Project
emaste added a comment to D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores.

LGTM

May 11 2021, 7:25 AM · Restricted Project

May 5 2021

emaste added inline comments to D101890: [LLD] Improve --strip-all help text.
May 5 2021, 10:03 AM · Restricted Project

May 3 2021

emaste added a comment to D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Presumably the MIPS tests changed in 72e75ca343c6f need to be changed back

May 3 2021, 3:38 PM · Restricted Project

Mar 27 2021

emaste accepted D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD.
Mar 27 2021, 6:21 PM · Restricted Project
emaste accepted D98285: [asan] Add an offset for the kernel address sanitizer on FreeBSD.
Mar 27 2021, 6:19 PM · Restricted Project

Mar 22 2021

emaste accepted D98281: [asan] Remove FreeBSD XFAIL from asan-sigbus.cpp test.

See https://svnweb.freebsd.org/base?view=revision&revision=352807

Mar 22 2021, 7:53 AM · Restricted Project