- User Since
- Jul 24 2013, 5:36 AM (247 w, 4 d)
Mon, Apr 9
Happy belated birthday Multi-GOT patch
Mar 15 2018
Mar 9 2018
Mar 8 2018
LGTM for FreeBSD
Mar 7 2018
Mar 5 2018
LGTM from the FreeBSD perspective
Mar 1 2018
Feb 27 2018
Feb 26 2018
Feb 22 2018
Feb 21 2018
Feb 19 2018
In FreeBSD libpthread.so is a symlink to libthr; -pthread and -lpthread should both work.
Feb 16 2018
Feb 9 2018
Feb 8 2018
Feb 7 2018
Thanks, I'll commit this later today. Not sure how I ended up with 01 instead of O1 but have fixed those locally.
PDF version of current version:
- more feedback from review
- incorporated doc updates for -z from https://reviews.freebsd.org/D14220
Feb 6 2018
PDF rendered version of the man page:
Incorporate review feedback
- Update copyright and license statement
- Remove internal -full-shutdown option
Jan 26 2018
Jan 25 2018
Jan 11 2018
Seems fine to me
Jan 10 2018
The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will also use llvm-objcopy.
Jan 4 2018
Is there any plan (or willingness?) to backport this further, to 4.0.0 and even 3.4.1?
Dec 29 2017
With this patch applied Kostik's original testcase passes.
Dec 26 2017
The original FreeBSD test case (a 'hello world' linked with lld -znotext) works with this change applied.
Dec 25 2017
Dec 24 2017
Dec 23 2017
This LGTM, I had a similar change in my repo while trying to fix PR35720.
Dec 22 2017
I can confirm this fixes the reduced test case, but the 'hello world' test on FreeBSD still fails, now with:
Dec 20 2017
Dec 18 2017
Dec 13 2017
FWIW our standard readelf in FreeBSD comes from the ELF Tool Chain project and doesn't have the warning. It's only when the GNU readelf package is installed that we'd encounter this.
Dec 11 2017
Dec 10 2017
From e-mail followup @dim linked against libc linked with pre-patch lld.
Dec 9 2017
I successfully linked all of FreeBSD/amd64 with LLD head + this patch.
Dec 8 2017
Spoke too soon - buildworld is actually failing elsewhere now, with my backported patch in lld.
/usr/obj/usr/home/emaste/src/freebsd/amd64.amd64/tmp/usr/bin/ld: error: relocation R_X86_64_PLT32 cannot refer to absolute symbol: __tls_get_addr >>> defined in <internal> >>> referenced by runetype.h:98 (/usr/obj/usr/home/emaste/src/freebsd/amd64.amd64/tmp/usr/include/runetype.h:98) >>> xlat16_iconv.pico:(kiconv_xlat16_open)
I probably have an error in my backport attempt though, this other library (lib/libkiconv) linked succesfully with lld head + this patch.
I tested this patch against lld head and confirm it resolves the issue via my reproducer. I also backported it to lld 5.0.1 (the version in FreeBSD HEAD) , rebuilt, and confirm that sbrk() is functional.
Nov 20 2017
Nov 4 2017
Oct 31 2017
Thanks for including the steps you used to effect the mechanical change! Having maintained long-lived derived branches of open source projects in the past I've found that sort of thing very helpful.
Oct 14 2017
Oct 13 2017
Oct 6 2017
Oct 2 2017
Sep 30 2017
I realized I don't have my LLVM SVN creds on my laptop, so will commit this when I return home in a couple of days if it's still not done.
Sep 27 2017
Sep 16 2017
Very small nit noticed on another look: there are couple of instances of Mib that should be MiB