User Details
- User Since
- Jul 24 2013, 5:36 AM (466 w, 5 d)
Sun, Jun 26
LGTM - yes, this links to a 2016 status report and is not relevant to include here anymore.
Mon, Jun 20
LGTM
Mon, Jun 13
I actually hope that I'll never commit this change
Thu, Jun 9
Wed, Jun 8
Jun 1 2022
May 31 2022
Fine with me from a FreeBSD perspective
May 26 2022
However, I am not completely sure how far off FreeBSD 14.0's "freeze" is, e.g. when a stable/14 branch is created, and the main branch is bumped to 15.0.
Sounds good to me. We can bump the .so version in the base system, but how do we treat it upstream (i.e., here in llvm) and in the ports tree?
For reference, we're going to support FreeBSD 13 until Jan 2026.
https://www.freebsd.org/security/
Apr 11 2022
Apr 8 2022
Sounds good to me for FreeBSD (w/ the release note as mentioned by @ldionne) arc4random is ChaCha20 in all supported FreeBSD versions.
Mar 27 2022
Mar 23 2022
Mar 4 2022
LGTM (modulo the lint complaints)
Mar 2 2022
The original author appears to have given up on it. Someone will need to rebase and work on pushing it forward
Mar 1 2022
Feb 24 2022
We need to make sure a test covers this as well, perhaps just enabling lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py?
Feb 17 2022
Feb 16 2022
Feb 15 2022
ping
Feb 11 2022
OK with me.
Feb 8 2022
Jan 18 2022
Jan 17 2022
procctl was added as of FreeBSD 10.0, and both 10.x and 11.x are now EOL, so I don't think we need to support for cases where it is not available.
0 is an alias for curproc
As a subsequent change I'll propose using PROC_ASLR_CTL to turn ASLR off and ReExec().
References:
rG:e2ed800d622567b35968a27f8784705fb48190f5
https://github.com/llvm/llvm-project/issues/53256
Dec 20 2021
It greatly harms performance on Linux tmpfs, 0.3s in my 5.2s link.
Dec 17 2021
it is likely Linux specific
Dec 15 2021
Dec 6 2021
We requested an experimental ports build with the start-stop-gc behaviour reverted (i.e., with getZFlag(args, "start-stop-gc", "nostart-stop-gc", false);)
Dec 3 2021
Fine with me, or maybe "A test for Darwin- (and prehaps Windows-)specific behavior."
Dec 2 2021
@jrtc27 and @emaste are both on board that the traditional GNU ld behavior / current 13.0.0 behavior is the future.
Dec 1 2021
FreeBSD used an ancient version of GNU ld (2.17.50, from mid 2000s) until we migrated all target architectures to lld. That old ld defaults to no GC start/stop, we have been using that behaviour for decades.
compatible with GNU ld newer than 2015-10
Nov 22 2021
Similar idea to D77776 (libc++ default if major not specified)
rebase tests
Nov 2 2021
@emaste replied: "However, if GNU ld / gold / lld default to GCing things we could set the option to reenable it in kernel/userland Makefiles."
Nov 1 2021
Sep 28 2021
Sep 24 2021
IMO this is worth it for the build time reduction, the size reduction is a nice bonus but not the main benefit.
Sep 16 2021
It looks like this worked prior to 2518433f861f because shouldAssumeDSOLocal has this case:
// PPC has no copy relocations and cannot use a plt entry as a symbol address. llvm::Triple::ArchType Arch = TT.getArch(); if (Arch == llvm::Triple::ppc || Arch == llvm::Triple::ppc64 || Arch == llvm::Triple::ppc64le) return false;
Sep 14 2021
Do we want to share some of these tests between NetBSD and FreeBSD?
Aug 24 2021
Would it be possible to add build bots for FreeBSD so we can test changes like those automatically?
Aug 23 2021
Superseded by e67cbac81211d40332a79d98c9d5953624cc1202 (D68720)
We make this change in FreeBSD's in-tree Clang about 9 months ago (https://reviews.freebsd.org/D27366)
Aug 6 2021
LGTM
With this patch applied BE mips64 FreeBSD builds successfully for me
Aug 4 2021
LGTM, although in FreeBSD we don't have any backwards- or cross-compatibility issues to worry about.
Jul 28 2021
Jul 27 2021
Jul 7 2021
Jun 26 2021
Jun 22 2021
-pg is still supported (see the OPT_pg at line 253), gprof just won't be able to "see into" libc, libm, etc.
May 11 2021
LGTM
LGTM
May 5 2021
May 3 2021
Presumably the MIPS tests changed in 72e75ca343c6f need to be changed back