- User Since
- Jul 24 2013, 5:36 AM (411 w, 3 d)
May 11 2021
May 5 2021
May 3 2021
Presumably the MIPS tests changed in 72e75ca343c6f need to be changed back
Mar 27 2021
Mar 22 2021
Mar 3 2021
So that's all the more reason to consistently use that mode everywhere, I think.
Mar 2 2021
Mar 1 2021
I can drop the Fixes trailer (I added it as we've adopted it in FreeBSD from Linux). That said, the referenced patch changed Gnu, AMDGPU, and HIP. My main goal here is to get the final library / executable artifacts to have compressed debug, we can look more at the intermediate bits later.
I just ran into this issue on FreeBSD, bug report in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253942
Feb 24 2021
OK; I think this change is reasonable, I just want to make sure we don't completely lose the underlying issue.
No objection from me
I don't think it's very likely. @emaste, any opinion on this?
I think it's valuable to avoid testing this (symlink issue) as a side effect of these test cases, but we should have an explicit test for this; it is an issue users could hit.
Feb 20 2021
FreeBSD changes LGTM
Feb 19 2021
Feb 14 2021
Not sure if you're missing something, but removing the old plugin LGTM
Feb 8 2021
Feb 3 2021
Feb 1 2021
Do you expect to pick this up again?
@arichardson do you think you'll get back to this?
Jan 30 2021
Jan 4 2021
For now, only Linux/ARM64 is supported/tested.
Dec 31 2020
Dec 28 2020
Dec 27 2020
Dec 16 2020
I think it's ok to only warn on Windows.
IMO that's sensible
Dec 6 2020
Seems reasonable to me
Dec 4 2020
Ah, of course. SGTM.
No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?
Dec 1 2020
How do things go wrong on Darwin? I was under the impression that this was implemented in LLVM as strictly inline code, no runtime support required.
Nov 30 2020
One thing that FreeBSD should do, is to upgrade to the protocol version 1 (stored in r_version), like Linux, NetBSD and OpenBSD.
Link to Linux info:
I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand.
No objection, but maybe add a comment explaining the status of this implementation? Does/will NetBSD do the same?
Can we add a test that the feature can be enabled on an OS other than Linux / Windows / Darwin?
Abandon in favour of D92245
if (EffectiveTriple.isOSWindows() || EffectiveTriple.isOSDarwin()) return;
Nov 25 2020
- add comment suggested by @rnk
- combine Linux and FreeBSD FileCheck
Nov 24 2020
Nov 19 2020
Looks ok to me
Nov 18 2020
Nov 17 2020
Nov 10 2020
I'm not sure if we need to add a runtime check?
This is fine with me; have we always done that?
Nov 9 2020
No objection from me but I haven't been sufficiently involved in lldb's tests to approve.
Agree that even if refactoring is needed correcting these makes sense.
Nov 8 2020
Nov 7 2020
In theory Obj-C is available on other systems
Nov 5 2020
How does Windows fit into this? Other than that Q, LGTM.
Does Linux fetch each time also?
I agree it's probably not worth the effort.
What do you suggest? Is it fine to go with my results for as long as I work on it? I can update it to match CI/buildbot results later.
Nov 4 2020
When running locally with this change applied I get:
I added comments in the now-dereferenced bugs linking back to this review - most of them were submitted by me, and I'll double check and close them once this lands.
Nov 2 2020
Oct 30 2020
There is TestProcessAttach.py that has an @expectedFailureNetBSD but no FreeBSD annotation, as well as TestCompletion.py, but I don't see these in the failing list.
running clang -target x86_64-unknown-freebsd13.0 -split-dwarf foo.c indeed produces a foo.dwo and foo.o w/o invoking objcopy
Oct 21 2020
Oct 15 2020
Looks fine to me
Oct 13 2020
Looks reasonable to me and currently fails (as expected) on FreeBSD.
fine with me
fine with me
Sep 30 2020
Aug 28 2020
Aug 26 2020
It looks like this conflicts with OpenSSL's compiler version check
Aug 25 2020
Aug 22 2020
Aug 18 2020
Ah if you use _LIBUNWIND_USE_FRAME_HEADER_CACHE instead (i.e., a _ between FRAME and HEADER) it will match the workaround committed to FreeBSD.
Looks reasonable to me.
Jul 27 2020
Jul 24 2020
LGTM, we acquired our strstr from musl
Jul 12 2020
Fine with me