- User Since
- Jul 24 2013, 5:36 AM (300 w, 13 h)
Mon, Apr 15
LGTM. I much prefer only - short and -- long options, except for lld where unfortunately there's a precedent of accepting both.
Mar 18 2019
Mar 7 2019
@xiangzhangllvm, a question for you not directly related to the patch but I suspect you might be best suited to find an answer: how do we test CET support today? We started trying to add CET to FreeBSD some time ago but have no way to test any work that we do.
Feb 21 2019
Feb 7 2019
Feb 6 2019
Feb 5 2019
Feb 4 2019
Feb 3 2019
FreeBSD patch adding initial exec TLS mode for dynamically loaded shared objects: https://reviews.freebsd.org/D19072. Can we revisit this lld patch?
Jan 7 2019
There is a list of 140-150 unsafe (LLD_UNSAFE) packages with LLD.
Dec 21 2018
I think the arch-change (switching from a whitelist to a MIPS blacklist) is reasonable. What is the motivation for dropping DT_HASH, just binary size reduction?
Dec 18 2018
Dec 6 2018
Can I go ahead with this version as a starting point?
Dec 3 2018
- fix warnings from mandoc -Tlint and/or igor
- remove options that should not be listed
Nov 27 2018
This is fine for me (from FreeBSD's perspective), but I suspect some people (on operating systems without ifuncs in libc) may be surprised by having a(n empty) .rela.plt in all of their statically linked binaries.
I have an interim copy in FreeBSD and am updating it based on the feedback here; I'll update this review shortly.
Nov 26 2018
Additional comment that wasn't submitted while reviews.llvm.org was down on Friday: I started working on this as it's needed for us to switch from GNU objdump to llvm-objdump in FreeBSD (FreeBSD PR229046).
Nov 25 2018
I think this is reasonable.
Perhaps someone else can review?
Nov 24 2018
Nov 23 2018
Nov 22 2018
Nov 21 2018
Confirmed this fixes my bug.
Nov 20 2018
Oct 15 2018
Oct 14 2018
Oct 10 2018
Oct 9 2018
I think that the inconsistency of linkers behavior shown above shows that LLD behavior is not incorrect. It is different. But we never tried to be fully bug compatible with bfd/gold. First of all the problem is caused by a weak assumption in the linker script, which assumes that orphans are placed at the particular place before the assignment command, and my feeling it should be fixed.
I backported the change to lld 6.0 currently in FreeBSD-HEAD and it has the expected behaviour, but for my test case I think sh_info should reference .got.plt not .plt - note the address marked with ######## below.
This change looks good to me; testing it out in the FreeBSD tree now.
This change LGTM.
Oct 5 2018
Looks good to me
Oct 4 2018
Oct 3 2018
For SHT_REL and SHT_RELA, sh_link references the associated symbol table and sh_info the "section to which the relocation applies."
Oct 2 2018
I don't think you can fix the issue by recompiling it without -fPIC
I would think a fix would be compiling with -fPIC.
Oct 1 2018
Sep 30 2018
Maybe "available for some architectures in at least..."? Or maybe we shouldn't bother trying to list versions, and mention it is dependent on CPU arch, linker, and rtld?
Sep 29 2018
Sep 26 2018
I am sure IFUNC+DT_TEXTREL does not affect FreeBSD, but OpenBSD can be affected. Many other systems (including musl) may not support IFUNC at all.
Probably. We'll need this information though I think. Otherwise, how will we find that it is safe to remove the flag?
The benefit from this that we can track and update the status of the fix and even maybe provide info about the known distributions affected/fixed on the page what can be helpful for removing this flag at some longer-term point.
Sep 25 2018
I'm using this change: https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21
The FreeBSD build bot was down for a little over a week due to an IP address issue, but is back now: http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11
Sep 24 2018
Sep 17 2018
Sep 14 2018
Agreed - when I submitted it I thought it might be uncommon but worth supporting, but the evidence Mark found suggests it is a single-purpose feature that is not relevant to the platforms lld supports.
Thanks for finding that Mark - based on that IMO this feature is not worth supporting.
keep flags in order
Reuse existing FLAGS: test
See also https://reviews.freebsd.org/D17172 for a lld 6 version intended for commit to FreeBSD's in-tree lld.
Aug 5 2018
@ruiu what do you suggest as the next step here?
Jul 30 2018
LGTM. I made the same change in FreeBSD r336745.
FWIW I don't have a strong opinion on | vs newline to separate aliases, but if we are going to go with the newline -compact and .Pp approach I'd suggest making that change as a separate commit first so that the actual content changes here are easier to see/review.
For reference I had a discussion on markup for option aliases with Ingo Schwarze and he wrote:
Jul 4 2018
May 29 2018
May 25 2018
May 10 2018
note-noalloc2.s is close to my original test, I think that's reasonable.
May 9 2018
- what is the content of .debug-ghc-link-info? If the section contains an optional, human-readable string, they might have just used .comment instead.
Committed to FreeBSD in r333401
Yeah, @espindola was added by a Herald rule.