ruiu (Rui Ueyama)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 12:16 AM (242 w, 4 d)

Recent Activity

Today

ruiu added a comment to D40849: CodeGen: support an extension to pass linker options on ELF.

It also means that it is harder to add features in the future for things which may not yet exist. As an example, there is no equivalent to this option today, but it would be pretty nice to have: -reexport-l<ibrary>. This would be equivalent to forwarders in COFF and LC_REEXPORT in the MachO. There is no ELF equivalent, but, were we to add that to the linker, this would now require changing the entire toolchain rather than forwarding the one single option.

Mon, Dec 11, 4:48 PM
ruiu accepted D41097: [ELF] Use shell to check the file permissions.

LGTM

Mon, Dec 11, 4:27 PM
ruiu added a comment to D41097: [ELF] Use shell to check the file permissions.

I wonder if replacing gnustat with shell and use [ -x <filename> ] is more robust than using gnustat. At least there's a precedence in clang/test/Driver/target-override.c.

Mon, Dec 11, 4:00 PM
ruiu added a comment to D41097: [ELF] Use shell to check the file permissions.

I believe it's still fragile against weird umask setting (such as 444), but that's in practice not an issue.

Mon, Dec 11, 3:58 PM
ruiu committed rL320436: Remove redundant local variables..
Remove redundant local variables.
Mon, Dec 11, 3:19 PM
ruiu committed rLLD320436: Remove redundant local variables..
Remove redundant local variables.
Mon, Dec 11, 3:19 PM
ruiu accepted D41060: Add an option for ICFing data.

--icf-data is not technically a correct name but that's probably the best name.

Mon, Dec 11, 3:13 PM
ruiu committed rL320434: Do not read the same .lib file more than once..
Do not read the same .lib file more than once.
Mon, Dec 11, 3:10 PM
ruiu committed rLLD320434: Do not read the same .lib file more than once..
Do not read the same .lib file more than once.
Mon, Dec 11, 3:10 PM
ruiu closed D41094: Do not read the same .lib file more than once. by committing rLLD320434: Do not read the same .lib file more than once..
Mon, Dec 11, 3:09 PM
ruiu committed rLLD320433: Reduce indentation..
Reduce indentation.
Mon, Dec 11, 3:09 PM
ruiu committed rL320433: Reduce indentation..
Reduce indentation.
Mon, Dec 11, 3:09 PM
ruiu accepted D41049: Compact symbols from 96 to 88 bytes.

LGTM

Mon, Dec 11, 3:03 PM
ruiu accepted D41041: [ELF] Don't set the executable bit for relocatable or shared files.

LGTM with this fix.

Mon, Dec 11, 2:32 PM
ruiu created D41094: Do not read the same .lib file more than once..
Mon, Dec 11, 2:22 PM
ruiu accepted D41082: [ELF] Change default output section type to SHT_NOBITS.

LGTM. Nice!

Mon, Dec 11, 1:23 PM
ruiu accepted D41089: [COFF] Don't error out on undefined references to __enclave_config.

Got it. We can figure this out later.

Mon, Dec 11, 1:16 PM
ruiu added a comment to D41089: [COFF] Don't error out on undefined references to __enclave_config.

What does this symbol do in MSVC 2017?

Mon, Dec 11, 12:58 PM
ruiu added inline comments to D41052: [LLD] [MinGW] Don't pass -dynamicbase:no by default for arm/arm64.
Mon, Dec 11, 12:51 PM
ruiu added inline comments to D41057: Avoid a gnu readelf warning.
Mon, Dec 11, 10:51 AM
ruiu added a comment to D41060: Add an option for ICFing data.

Got it. If you are using this option from the beginning, it should be fine.

Mon, Dec 11, 10:47 AM
ruiu added a comment to D40849: CodeGen: support an extension to pass linker options on ELF.

Allowing a limited set of flags or features, such as adding a library path, is probably fine, but I'd strongly oppose to allow embedding arbitrary linker flags to object files. That would open up a can of warms as I described in the previous message.

Mon, Dec 11, 10:20 AM
ruiu added a comment to D41051: [LLD] [COFF] Disallow -dynamicbase:no for arm and arm64.

LGTM

Mon, Dec 11, 10:10 AM
ruiu accepted D40962: [ELF] When a relocation is out of range print the value and the range.

LGTM

Mon, Dec 11, 9:59 AM
ruiu committed rLLD320394: Sort..
Sort.
Mon, Dec 11, 9:53 AM
ruiu committed rL320394: Sort..
Sort.
Mon, Dec 11, 9:53 AM
ruiu committed rLLD320393: Change function type more LLVM-ish..
Change function type more LLVM-ish.
Mon, Dec 11, 9:53 AM
ruiu committed rL320393: Change function type more LLVM-ish..
Change function type more LLVM-ish.
Mon, Dec 11, 9:53 AM
ruiu added inline comments to D40962: [ELF] When a relocation is out of range print the value and the range.
Mon, Dec 11, 9:52 AM
ruiu added inline comments to D40962: [ELF] When a relocation is out of range print the value and the range.
Mon, Dec 11, 9:47 AM
ruiu added inline comments to D41041: [ELF] Don't set the executable bit for relocatable or shared files.
Mon, Dec 11, 9:20 AM
ruiu added inline comments to D41052: [LLD] [MinGW] Don't pass -dynamicbase:no by default for arm/arm64.
Mon, Dec 11, 9:18 AM
ruiu accepted D41051: [LLD] [COFF] Disallow -dynamicbase:no for arm and arm64.

LGTM with this change.

Mon, Dec 11, 9:16 AM
ruiu added a comment to D41060: Add an option for ICFing data.

We used to merge data for COFF but not anymore because it causes nasty problems that are hard to find and debug. E.g. https://bugs.chromium.org/p/chromium/issues/detail?id=682773#c24

Mon, Dec 11, 9:14 AM
ruiu added inline comments to D40962: [ELF] When a relocation is out of range print the value and the range.
Mon, Dec 11, 9:04 AM
ruiu accepted D41037: Create reserved symbols early so they can be versioned.

LGTM

Mon, Dec 11, 8:56 AM
ruiu accepted D41038: [WebAssembly] Preserve ordering of global symbols.

LGTM

Mon, Dec 11, 8:53 AM
ruiu added inline comments to D41049: Compact symbols from 96 to 88 bytes.
Mon, Dec 11, 8:47 AM

Fri, Dec 8

ruiu added a comment to D41041: [ELF] Don't set the executable bit for relocatable or shared files.

So is true for .so, isn't it?

Fri, Dec 8, 4:59 PM
ruiu added a comment to D40849: CodeGen: support an extension to pass linker options on ELF.

Do you mind if I ask you explain the motivation of adding this feature?

Fri, Dec 8, 4:02 PM
ruiu accepted D41033: Use ErrorOS for log messages as well as error.

LGTM

Fri, Dec 8, 3:27 PM
ruiu added a comment to D41033: Use ErrorOS for log messages as well as error.

I agree that log should go to stderr, but I think message should still go to stdout. We have that function to print out a regular message, such as printing out version information or some hint message. We have this function mainly because we want to acquire the global lock before printing out something in the multithreaded environment.

Fri, Dec 8, 2:53 PM
ruiu accepted D41025: ELF: Ignore --long-plt flag..

LGTM

Fri, Dec 8, 11:27 AM
ruiu added a comment to D41024: [WebAssembly] Improve wasm test cases.

LGTM, but please submit this as two separate patches -- one for weak symbols and the other to fix -mtriple.

Fri, Dec 8, 11:26 AM

Thu, Dec 7

ruiu committed rL320130: Use lambda to simplify code..
Use lambda to simplify code.
Thu, Dec 7, 6:21 PM
ruiu committed rLLD320130: Use lambda to simplify code..
Use lambda to simplify code.
Thu, Dec 7, 6:21 PM
ruiu closed D40994: Use lambda to simplify code. by committing rL320130: Use lambda to simplify code..
Thu, Dec 7, 6:21 PM
ruiu closed D40994: Use lambda to simplify code. by committing rLLD320130: Use lambda to simplify code..
Thu, Dec 7, 6:21 PM
ruiu created D40994: Use lambda to simplify code..
Thu, Dec 7, 6:03 PM
ruiu accepted D40993: Prefer `ArrayRef` over `const std::vector&`.

Thank you for doing this!

Thu, Dec 7, 5:03 PM
ruiu added inline comments to D40989: [WebAssembly] De-dup indirect function table.
Thu, Dec 7, 4:17 PM
ruiu accepted D40990: [WebAssembly] Add check to ensure symbol VA is only set once. NFC.

LGTM

Thu, Dec 7, 4:09 PM
ruiu committed rLLD320117: Fix a test that didn't actually test anything..
Fix a test that didn't actually test anything.
Thu, Dec 7, 4:01 PM
ruiu committed rL320117: Fix a test that didn't actually test anything..
Fix a test that didn't actually test anything.
Thu, Dec 7, 4:01 PM
ruiu added inline comments to D40954: [ELF] - Teach LLD to hint about -fdebug-types-section..
Thu, Dec 7, 3:28 PM
ruiu accepted D40725: Wasm entrypoint changes #3 (add --no-entry argument to LLD).

Thank you for making the change. As to the empty string handling, I wanted to make it consistent with other ports, and we in general don't write much code for edge cases to keep the code straightforward.

Thu, Dec 7, 2:09 PM
ruiu added inline comments to D40980: Add /DEBUG:GHASH option to LLD to speed up COFF linking.
Thu, Dec 7, 2:08 PM
ruiu added inline comments to D40980: Add /DEBUG:GHASH option to LLD to speed up COFF linking.
Thu, Dec 7, 2:00 PM
ruiu accepted D40963: Print the bad value and required alignment for unaligned relocations.

LGTM

Thu, Dec 7, 11:24 AM
ruiu added inline comments to D40962: [ELF] When a relocation is out of range print the value and the range.
Thu, Dec 7, 11:21 AM

Wed, Dec 6

ruiu committed rL320005: Remove checkToString functions and use toString instead..
Remove checkToString functions and use toString instead.
Wed, Dec 6, 7:25 PM
ruiu committed rLLD320005: Remove checkToString functions and use toString instead..
Remove checkToString functions and use toString instead.
Wed, Dec 6, 7:25 PM
ruiu closed D40928: Remove checkToString functions and use toString instead. by committing rLLD320005: Remove checkToString functions and use toString instead..
Wed, Dec 6, 7:25 PM
ruiu accepted D40859: [WebAssembly] Export globals when linking with -r/--relocatable.

LGTM :)

Wed, Dec 6, 5:31 PM
ruiu added a comment to D40859: [WebAssembly] Export globals when linking with -r/--relocatable.

If I'm not too slow, give me a few hours to review patches. If I didn't respond timely, please go ahead without my LG. Does this sound good?

Wed, Dec 6, 5:21 PM
ruiu added a comment to D40859: [WebAssembly] Export globals when linking with -r/--relocatable.

You don't need to wait for my LGTM for small-ish changes. I want to continue reviewing wasm lld patches to (1) keep wasm in line with other ports, (2) keep wasm lld as fast as possible, and (3) prevent wasm from making mistakes that other binary formats made in their history. But that's mostly about high-level design.

Wed, Dec 6, 5:04 PM
ruiu accepted D40931: [COFF] Stop lowercasing paths in messages.

I believe it is me who wrote code to lowercase pathnames, but I don't remember why I decided to do that.

Wed, Dec 6, 4:43 PM
ruiu added a comment to D40845: Wasm COMDAT: LLD support.

I just skimmed through the code, but it looks like what this code does is different from ELF. Is there a reason to be different?

Wed, Dec 6, 4:40 PM
ruiu accepted D40878: Handle multiple "--version-script" options..

LGTM

Wed, Dec 6, 4:25 PM · lld
ruiu created D40928: Remove checkToString functions and use toString instead..
Wed, Dec 6, 3:46 PM
ruiu accepted D40760: [WebAssembly] Add support for __init_array_start and friends.

LGTM

Wed, Dec 6, 3:38 PM
ruiu added inline comments to D40725: Wasm entrypoint changes #3 (add --no-entry argument to LLD).
Wed, Dec 6, 3:20 PM
ruiu committed rL319974: Always evaluate the second argument for CHECK() lazily..
Always evaluate the second argument for CHECK() lazily.
Wed, Dec 6, 2:09 PM
ruiu committed rLLD319974: Always evaluate the second argument for CHECK() lazily..
Always evaluate the second argument for CHECK() lazily.
Wed, Dec 6, 2:08 PM
ruiu closed D40915: Always evaluate the second argument for CHECK() lazily. by committing rLLD319974: Always evaluate the second argument for CHECK() lazily..
Wed, Dec 6, 2:08 PM
ruiu updated the diff for D40915: Always evaluate the second argument for CHECK() lazily..
  • Use C macro only for the arity 2 check function.
Wed, Dec 6, 1:52 PM
ruiu added inline comments to D40915: Always evaluate the second argument for CHECK() lazily..
Wed, Dec 6, 1:41 PM
ruiu updated the diff for D40915: Always evaluate the second argument for CHECK() lazily..
  • Use llvm::function_ref instead of std::function
Wed, Dec 6, 1:37 PM
ruiu added a reviewer for D40916: Always evaluate the second argument for CHECK() lazily.: rafael.
Wed, Dec 6, 1:16 PM
ruiu added a comment to D40916: Always evaluate the second argument for CHECK() lazily..

How much does this buy us?

Wed, Dec 6, 1:05 PM
ruiu updated the diff for D40916: Always evaluate the second argument for CHECK() lazily..
  • fix typo
Wed, Dec 6, 12:42 PM
ruiu created D40916: Always evaluate the second argument for CHECK() lazily..
Wed, Dec 6, 12:41 PM
ruiu created D40915: Always evaluate the second argument for CHECK() lazily..
Wed, Dec 6, 12:40 PM
ruiu committed rL319933: [COFF] Ignore semicolons in module definition identifiers.
[COFF] Ignore semicolons in module definition identifiers
Wed, Dec 6, 11:19 AM
ruiu closed D39968: [COFF] Ignore semicolons in module definition identifiers by committing rL319933: [COFF] Ignore semicolons in module definition identifiers.
Wed, Dec 6, 11:18 AM · lld

Tue, Dec 5

ruiu added inline comments to D40725: Wasm entrypoint changes #3 (add --no-entry argument to LLD).
Tue, Dec 5, 7:24 PM
ruiu committed rL319863: Fix broken .gnu.hash section if -no-rosegment is given..
Fix broken .gnu.hash section if -no-rosegment is given.
Tue, Dec 5, 4:50 PM
ruiu committed rLLD319863: Fix broken .gnu.hash section if -no-rosegment is given..
Fix broken .gnu.hash section if -no-rosegment is given.
Tue, Dec 5, 4:50 PM
ruiu accepted D40870: [WebAssembly] Remove wasm/Strings.cpp+h. NFC.

LGTM

Tue, Dec 5, 4:32 PM
ruiu accepted D40868: [lld] Fix handling of wildcards in dynamic lists..

Wow. I was surprised that we didn't notice this until now. Thank you for finding this out.

Tue, Dec 5, 3:51 PM
ruiu added inline comments to D40842: [ObjectYAML] Update obj2yaml and yaml2obj for .debug$H section.
Tue, Dec 5, 3:19 PM
ruiu added inline comments to D40842: [ObjectYAML] Update obj2yaml and yaml2obj for .debug$H section.
Tue, Dec 5, 3:07 PM
ruiu accepted D39984: [docs] Update doc build instructions and some reformatting.

LGTM but please split this into two patches, one is to change format, and the other is to remove some sections, before committing.

Tue, Dec 5, 2:23 PM
ruiu accepted D40736: [CodeView] Add support for type record content hashing.

Let's land this so that we can experiment. I still doubt if a noncryptographic tree hash is faster than SHA1, but that can be experimented once this patch is in.

Tue, Dec 5, 1:42 PM
ruiu accepted D40847: [WebAssembly] Fix stack pointer relocations.

LGTM

Tue, Dec 5, 11:51 AM
ruiu accepted D40843: [WebAssembly] Improve support for linker synthetic symbols. NFC.

LGTM

Tue, Dec 5, 10:41 AM
ruiu added inline comments to D40843: [WebAssembly] Improve support for linker synthetic symbols. NFC.
Tue, Dec 5, 10:30 AM
ruiu accepted D40839: [ELF] - Show .plt symbols in -Map output..

LGTM

Tue, Dec 5, 10:19 AM

Mon, Dec 4

ruiu added inline comments to D40736: [CodeView] Add support for type record content hashing.
Mon, Dec 4, 11:12 PM
ruiu added inline comments to D40760: [WebAssembly] Add support for __init_array_start and friends.
Mon, Dec 4, 10:23 PM