ruiu (Rui Ueyama)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 12:16 AM (253 w, 1 d)

Recent Activity

Yesterday

ruiu added a comment to D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows..

That's weird, because lots of lldb tests compile and link test binaries on Windows with -fuse-ld=lld (without the .exe). What makes you say the .exe is necessary?

Thu, Feb 22, 8:30 PM · Restricted Project
ruiu created D43670: Add more items to lld 6.0 release note.
Thu, Feb 22, 8:22 PM
ruiu added inline comments to D43665: Take SHF_ARM_PURECODE into consideration when setting the program header flags.
Thu, Feb 22, 7:07 PM
ruiu added inline comments to D43642: [ELF] Add comment for preemptible and fix typo. NFC.
Thu, Feb 22, 6:10 PM
ruiu added a comment to D43664: Fail early if an output file is not writable..

Yes, there's a chance that this test succeeds but the final output fails, but that should be acceptable. File writing could fail for other reasons, like disk full situation, and there's no way to know that before we actually write bytes to a file, so I think it's not worth to spend too much effort to be more accurate.

Thu, Feb 22, 6:01 PM
ruiu accepted D43632: [ELF] - Add testcase documenting flags assigned when empty synthetic section is removed..

LGTM with this fix.

Thu, Feb 22, 5:53 PM
ruiu created D43664: Fail early if an output file is not writable..
Thu, Feb 22, 5:43 PM
ruiu added a comment to D42960: [ELF] DEMO: Example for adding .eh_frame pieces to map file.

Yeah, please add a test for this for demonstration purpose. Actually, for demonstration purpose, a test is probably more useful than the actual code, because we are more interested in knowing about how a program works as a result of a change than the change itself. In particular, I'm interested in knowing the information that is contained in the new output.

Thu, Feb 22, 5:24 PM
ruiu committed rLLD325849: Make undefined symbol in DSO to pull out object files from archive files..
Make undefined symbol in DSO to pull out object files from archive files.
Thu, Feb 22, 5:19 PM
ruiu committed rL325849: Make undefined symbol in DSO to pull out object files from archive files..
Make undefined symbol in DSO to pull out object files from archive files.
Thu, Feb 22, 5:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Feb 22, 5:19 PM
ruiu updated the diff for D43658: Make undefined symbol in DSO to pull out object files from archive files..
  • updated the test case.
Thu, Feb 22, 5:09 PM
ruiu created D43658: Make undefined symbol in DSO to pull out object files from archive files..
Thu, Feb 22, 4:41 PM
ruiu added a comment to D43264: [WebAssembly] Add explicit symbol table.

(So my previous comments were optional -- you can submit without fixing them.)

Thu, Feb 22, 4:31 PM
ruiu accepted D43264: [WebAssembly] Add explicit symbol table.

There are a few things that hasn't been addressed, but we can address them later if we still want to do that.

Thu, Feb 22, 4:26 PM
ruiu created D43644: Make llvm::djbHash an inline function..
Thu, Feb 22, 1:56 PM
ruiu accepted D43636: Update LLD docs to mention PDB support.

LGTM

Thu, Feb 22, 10:35 AM
ruiu added a comment to D43636: Update LLD docs to mention PDB support.

Maybe we can just say "done"? No products are shipped without bugs, so having a few known bugs isn't that bad.

Thu, Feb 22, 10:21 AM
ruiu accepted D43633: Add a few release notes.

Thanks. I'm writing release notes too, so I'll merge it with yours. Please just submit yours now and I'll edit it further.

Thu, Feb 22, 10:07 AM

Wed, Feb 21

ruiu committed rL325714: Revert r325679: [ELF] Add -nopie alias for -no-pie (PR36423).
Revert r325679: [ELF] Add -nopie alias for -no-pie (PR36423)
Wed, Feb 21, 12:10 PM
ruiu committed rLLD325714: Revert r325679: [ELF] Add -nopie alias for -no-pie (PR36423).
Revert r325679: [ELF] Add -nopie alias for -no-pie (PR36423)
Wed, Feb 21, 12:10 PM
ruiu accepted D43575: [docs][mips] Add MIPS specific release notes for LLD 6.0.

LGTM

Wed, Feb 21, 11:22 AM · lld
ruiu added a comment to D43488: [mips][lld] Spectre variant two mitigation for MIPSR2.

LGTM

Wed, Feb 21, 11:21 AM
ruiu accepted D43574: [ELF] - Introduce getInputSections() helper..

LGTM

Wed, Feb 21, 10:50 AM
ruiu added inline comments to D43264: [WebAssembly] Add explicit symbol table.
Wed, Feb 21, 10:38 AM
ruiu accepted D43588: [WebAssembly] Rename member DefinedFunctions -> InputFunctions. NFC..

LGTM

Wed, Feb 21, 10:31 AM
ruiu accepted D43587: [WebAssembly] Use make<> rather then make_unique<>. NFC..

LGTM

Wed, Feb 21, 10:26 AM
ruiu added inline comments to D43264: [WebAssembly] Add explicit symbol table.
Wed, Feb 21, 9:41 AM

Tue, Feb 20

ruiu added a comment to D43525: Inline a trivial ctor..

Yes, I forgot to do that. Will do next time.

Tue, Feb 20, 2:17 PM
ruiu accepted D43529: Consistent use of header file for ICF and MarkLive.

LGTM

Tue, Feb 20, 2:02 PM
ruiu accepted D43528: Consistent (non) use of empty lines in include blocks.

As long as it is consistent, I don't care much about this style, and I always use clang-format, so I like this change.

Tue, Feb 20, 1:44 PM
ruiu created D43527: Handle --version before handling --mllvm..
Tue, Feb 20, 1:34 PM
ruiu created D43525: Inline a trivial ctor..
Tue, Feb 20, 1:31 PM
ruiu created D43526: Inline printHelp..
Tue, Feb 20, 1:31 PM
ruiu created D43524: Simplify..
Tue, Feb 20, 1:20 PM
ruiu committed rL325625: Use more early returns in SymbolTable.cpp..
Use more early returns in SymbolTable.cpp.
Tue, Feb 20, 1:11 PM
ruiu committed rLLD325625: Use more early returns in SymbolTable.cpp..
Use more early returns in SymbolTable.cpp.
Tue, Feb 20, 1:10 PM
ruiu closed D43517: Use more early returns in SymbolTable.cpp..
Tue, Feb 20, 1:10 PM
ruiu updated the diff for D43523: Remove SymbolTable::addUndefined and add SymbolTable::addUndefined{Function,Global}.
  • removed unused parameter from shouldReplace
Tue, Feb 20, 12:55 PM
ruiu updated the diff for D43523: Remove SymbolTable::addUndefined and add SymbolTable::addUndefined{Function,Global}.
  • use toString() instead of getName().
Tue, Feb 20, 12:48 PM
ruiu created D43523: Remove SymbolTable::addUndefined and add SymbolTable::addUndefined{Function,Global}.
Tue, Feb 20, 12:44 PM
ruiu updated the diff for D43517: Use more early returns in SymbolTable.cpp..
  • rebased
Tue, Feb 20, 11:17 AM
ruiu accepted D43496: [WebAssembly] Split addDefined into two different methods. NFC..

LGTM

Tue, Feb 20, 10:56 AM
ruiu updated the diff for D43517: Use more early returns in SymbolTable.cpp..
  • fix typo
Tue, Feb 20, 10:49 AM
ruiu added a comment to D43517: Use more early returns in SymbolTable.cpp..

Please go first.

Tue, Feb 20, 10:49 AM
ruiu updated the diff for D43517: Use more early returns in SymbolTable.cpp..
  • reduces number of checkSymbolTypes function calls.
Tue, Feb 20, 10:47 AM
ruiu created D43517: Use more early returns in SymbolTable.cpp..
Tue, Feb 20, 10:42 AM
ruiu accepted D43516: [WebAssembly] Remove unused header.

LGTM

Tue, Feb 20, 10:27 AM
ruiu added inline comments to D43496: [WebAssembly] Split addDefined into two different methods. NFC..
Tue, Feb 20, 10:00 AM
ruiu added a comment to D43503: Rename LLD lit features for targets from e.g. "x86" -> "x86-registered-target".

Pardon my ignorance, but what is a difference between x86 and x86-registered-target?

Tue, Feb 20, 9:48 AM
ruiu accepted D43493: [WebAssembly] Remove InputChunk from Symbol baseclass. NFC..

LGTM

Tue, Feb 20, 9:44 AM

Mon, Feb 19

ruiu closed D43484: Inline applyRelocations into writeTo..

The patch to remove OutRelocation also contained this change, so this change was submitted as part of that. I do prefer shorter functions, but in this case it feels to me that writeTo does too less. That's probably a personal preference though.

Mon, Feb 19, 8:39 PM
ruiu accepted D43476: [WebAssembly] Rename symbols types in preparation to adding wasm globals. NFC..

LGTM

Mon, Feb 19, 8:39 PM
ruiu added inline comments to D43493: [WebAssembly] Remove InputChunk from Symbol baseclass. NFC..
Mon, Feb 19, 8:36 PM
ruiu committed rLLD325549: Do not create a temporary data structure for relocations..
Do not create a temporary data structure for relocations.
Mon, Feb 19, 8:29 PM
ruiu committed rL325549: Do not create a temporary data structure for relocations..
Do not create a temporary data structure for relocations.
Mon, Feb 19, 8:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Mon, Feb 19, 8:29 PM
ruiu accepted D43492: [WebAssembly] Check signatures of weakly defined funtions too.

LGTM

Mon, Feb 19, 8:29 PM
ruiu added inline comments to D43496: [WebAssembly] Split addDefined into two different methods. NFC..
Mon, Feb 19, 8:21 PM
ruiu updated the diff for D43491: [WebAssembly] Do not create a temporary data structure for relocations..
  • remove dead code
Mon, Feb 19, 3:37 PM
ruiu retitled D43491: [WebAssembly] Do not create a temporary data structure for relocations. from Do not create a temporary data structure for relocations. to [WebAssembly] Do not create a temporary data structure for relocations..
Mon, Feb 19, 3:34 PM
ruiu created D43491: [WebAssembly] Do not create a temporary data structure for relocations..
Mon, Feb 19, 3:33 PM
ruiu created D43484: Inline applyRelocations into writeTo..
Mon, Feb 19, 2:51 PM
ruiu committed rL325538: Merge two small functions and add comments..
Merge two small functions and add comments.
Mon, Feb 19, 2:46 PM
ruiu committed rLLD325538: Merge two small functions and add comments..
Merge two small functions and add comments.
Mon, Feb 19, 2:46 PM
ruiu closed D43406: Merge two small functions and add comments..
Mon, Feb 19, 2:46 PM
ruiu committed rL325537: Removed a variable that is used only once..
Removed a variable that is used only once.
Mon, Feb 19, 2:43 PM
ruiu committed rLLD325537: Removed a variable that is used only once..
Removed a variable that is used only once.
Mon, Feb 19, 2:43 PM
ruiu committed rL325536: [WebAssembly] Expand a lambda that is used only once..
[WebAssembly] Expand a lambda that is used only once.
Mon, Feb 19, 2:39 PM
ruiu committed rLLD325536: [WebAssembly] Expand a lambda that is used only once..
[WebAssembly] Expand a lambda that is used only once.
Mon, Feb 19, 2:39 PM
ruiu closed D43435: Expand a lambda that is used only once..
Mon, Feb 19, 2:39 PM
ruiu added a comment to D43435: Expand a lambda that is used only once..

I didn't actually try to see the assembly output for this file, but decent compilers are smart enough to figure out that the lambda can be inlined, so I don't think this change doesn't improve performance.

Mon, Feb 19, 2:36 PM
ruiu committed rLLD325535: [WebAssembly] Define toString(wasm::InputChunk *) and use that in MarkLive.cpp..
[WebAssembly] Define toString(wasm::InputChunk *) and use that in MarkLive.cpp.
Mon, Feb 19, 2:33 PM
ruiu committed rL325535: [WebAssembly] Define toString(wasm::InputChunk *) and use that in MarkLive.cpp..
[WebAssembly] Define toString(wasm::InputChunk *) and use that in MarkLive.cpp.
Mon, Feb 19, 2:33 PM
ruiu closed D43434: Define toString(wasm::InputChunk *) and use that in MarkLive.cpp..
Mon, Feb 19, 2:32 PM

Sat, Feb 17

ruiu created D43435: Expand a lambda that is used only once..
Sat, Feb 17, 3:53 PM
ruiu created D43434: Define toString(wasm::InputChunk *) and use that in MarkLive.cpp..
Sat, Feb 17, 3:47 PM
ruiu committed rL325453: Simplify..
Simplify.
Sat, Feb 17, 3:39 PM
ruiu committed rLLD325453: Simplify..
Simplify.
Sat, Feb 17, 3:39 PM
ruiu committed rL325445: Remove an unused accessor and simplify the logic a bit. NFC..
Remove an unused accessor and simplify the logic a bit. NFC.
Sat, Feb 17, 12:44 PM
ruiu committed rLLD325445: Remove an unused accessor and simplify the logic a bit. NFC..
Remove an unused accessor and simplify the logic a bit. NFC.
Sat, Feb 17, 12:44 PM
ruiu committed rLLD325444: Factor out common code from applySecRel functions..
Factor out common code from applySecRel functions.
Sat, Feb 17, 12:31 PM
ruiu committed rL325444: Factor out common code from applySecRel functions..
Factor out common code from applySecRel functions.
Sat, Feb 17, 12:30 PM
ruiu closed D43412: Factor out common code from applySecRel functions..
Sat, Feb 17, 12:30 PM

Fri, Feb 16

ruiu accepted D43422: [WebAssembly] Remove unneeded classifer methods from Symbol class. NFC..

LGTM

Fri, Feb 16, 4:44 PM
ruiu committed rL325416: Use toString to print out garbage-collected sections..
Use toString to print out garbage-collected sections.
Fri, Feb 16, 4:12 PM
ruiu committed rLLD325416: Use toString to print out garbage-collected sections..
Use toString to print out garbage-collected sections.
Fri, Feb 16, 4:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Feb 16, 4:12 PM
ruiu created D43420: Use toString to print out garbage-collected sections..
Fri, Feb 16, 4:04 PM
ruiu added a comment to D43405: [WebAssembly] Remove unneeded Chunk::getFileName() method. NFC..

Good observation, but I think we should use toString() in ELF too. toString() is there for you so that you don't need to construct a string like this, and doing this is error-prone. In this case, if file foo.o is in bar.a, toString generates something like

Fri, Feb 16, 3:58 PM
ruiu committed rLLD325413: Remove "--full-shutdown" and instead use an environment variable LLD_IN_TEST..
Remove "--full-shutdown" and instead use an environment variable LLD_IN_TEST.
Fri, Feb 16, 3:46 PM
ruiu committed rL325413: Remove "--full-shutdown" and instead use an environment variable LLD_IN_TEST..
Remove "--full-shutdown" and instead use an environment variable LLD_IN_TEST.
Fri, Feb 16, 3:46 PM
ruiu closed D43410: Do not automatically append --full-shutdown to lld tests..
Fri, Feb 16, 3:46 PM
ruiu accepted D43416: [WebAssembly] Simplify FunctionSymbol get/set/hasFunctionType. NFC..

LGTM

Fri, Feb 16, 3:42 PM
ruiu accepted D43405: [WebAssembly] Remove unneeded Chunk::getFileName() method. NFC..

But I believe a better way of doing this kind of stuff is to define toString(InputChunk *). toString() function is a common interface to stringize objects to create debug messages.

Fri, Feb 16, 3:40 PM
ruiu updated the diff for D43410: Do not automatically append --full-shutdown to lld tests..
  • removed --full-shutdown
Fri, Feb 16, 3:34 PM
ruiu updated the diff for D43410: Do not automatically append --full-shutdown to lld tests..
  • redesign
Fri, Feb 16, 3:24 PM
ruiu added a comment to D43417: [WebAssembly] Add wasm-ld to lit tool_patterns.

Actually I've just did that a few hours ago. Please sync to SVN head.

Fri, Feb 16, 3:24 PM
ruiu added a comment to D43410: Do not automatically append --full-shutdown to lld tests..

If this is needed by all tests, how about making it an environment variable (e.g. "LLD_IN_TEST=1") and detect it in lld.cpp instead of in each driver?

Fri, Feb 16, 3:09 PM
ruiu updated the diff for D43406: Merge two small functions and add comments..
  • removed a comment from the .h file
Fri, Feb 16, 3:09 PM