ruiu (Rui Ueyama)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 12:16 AM (287 w, 1 d)

Recent Activity

Today

ruiu accepted D53393: Add a addAbsolute static function to Writer.cpp.

Please commit.

Fri, Oct 19, 1:54 PM
ruiu added inline comments to D53444: Support ARM_V4BX relocation.
Fri, Oct 19, 1:52 PM
ruiu added a comment to D53408: [PPC64] Long branch thunks. .

First round of review.

Fri, Oct 19, 1:50 PM · lld
ruiu accepted D53432: Use llvm::arrayRefFromStringRef.

LGTM

Fri, Oct 19, 10:10 AM
ruiu accepted D53421: [WebAssembly] Simplify --help message.

LGTM

Fri, Oct 19, 10:09 AM

Yesterday

ruiu accepted D53388: [LLD] [COFF] Fix error handling on duplicates for import library symbols.

LGTM

Thu, Oct 18, 4:49 PM
ruiu accepted D53401: [PPC64] Fix offset checks on rel24 call relocations..

LGTM

Thu, Oct 18, 8:05 AM · lld
ruiu added a comment to D53393: Add a addAbsolute static function to Writer.cpp.

First, let me explain my motivation as to why I made changes to the symbol table in the first place, so that you understand the background of my changes.

Thu, Oct 18, 6:58 AM
ruiu updated subscribers of rL344305: Remove SymbolTable::addAbsolute()..

I'm sorry but we do not guarantee internal API to be the same between
different lld versions. As to removing the utility function, I think
removing a utility function that is used only once in the lld's codebase
makes sense.

Thu, Oct 18, 6:13 AM

Tue, Oct 16

ruiu accepted D53330: [LTO] Call InitLLVM from llvm-lto2.

LGTM

Tue, Oct 16, 10:10 AM

Mon, Oct 15

ruiu accepted D53278: [LLD][ELF] - Check options before processing the -v/-version options..

Honestly I don't think this is worth "fixing" because this is not a bug. We shouldn't bother copying this much details of GNU linkers' behavior. Being said that, since this patch does not append any complexity to the linker, I'm fine with that. LGTM

Mon, Oct 15, 7:19 AM

Sun, Oct 14

ruiu accepted D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags.

LGTM

Sun, Oct 14, 7:58 PM

Fri, Oct 12

ruiu committed rLLD344427: Simplify. NFC..
Simplify. NFC.
Fri, Oct 12, 3:46 PM
ruiu committed rL344427: Simplify. NFC..
Simplify. NFC.
Fri, Oct 12, 3:46 PM
ruiu added a comment to D46228: [ELF] Use union-find set in Call-Chain Clustering (C³) heuristic to improve worst-case time complexity..

Honestly I do not understand the code. What is this code doing? Can you explain it for me?

Fri, Oct 12, 3:14 PM
ruiu added a comment to D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags.

Can you add a test?

Fri, Oct 12, 2:52 PM
ruiu added inline comments to D46228: [ELF] Use union-find set in Call-Chain Clustering (C³) heuristic to improve worst-case time complexity..
Fri, Oct 12, 2:52 PM
ruiu added inline comments to D46228: [ELF] Use union-find set in Call-Chain Clustering (C³) heuristic to improve worst-case time complexity..
Fri, Oct 12, 2:39 PM
ruiu committed rL344395: Replace assert() with llvm_unreachable because it's obviously a typo..
Replace assert() with llvm_unreachable because it's obviously a typo.
Fri, Oct 12, 11:31 AM
ruiu committed rL344394: Remove `Type` parameter from SymbolTable::insert(). NFC..
Remove `Type` parameter from SymbolTable::insert(). NFC.
Fri, Oct 12, 11:31 AM
ruiu committed rLLD344394: Remove `Type` parameter from SymbolTable::insert(). NFC..
Remove `Type` parameter from SymbolTable::insert(). NFC.
Fri, Oct 12, 11:31 AM
ruiu committed rL344368: [lld] Add more complete support for the INCLUDE command..
[lld] Add more complete support for the INCLUDE command.
Fri, Oct 12, 10:09 AM
ruiu committed rLLD344368: [lld] Add more complete support for the INCLUDE command..
[lld] Add more complete support for the INCLUDE command.
Fri, Oct 12, 10:09 AM
ruiu closed D52951: [lld] Add more complete support for the INCLUDE command..
Fri, Oct 12, 10:09 AM
ruiu added inline comments to D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags.
Fri, Oct 12, 9:52 AM

Thu, Oct 11

ruiu committed rL344305: Remove SymbolTable::addAbsolute()..
Remove SymbolTable::addAbsolute().
Thu, Oct 11, 3:17 PM
ruiu committed rLLD344305: Remove SymbolTable::addAbsolute()..
Remove SymbolTable::addAbsolute().
Thu, Oct 11, 3:17 PM
ruiu committed rLLD344302: Remove `else` after `return`..
Remove `else` after `return`.
Thu, Oct 11, 2:59 PM
ruiu committed rL344302: Remove `else` after `return`..
Remove `else` after `return`.
Thu, Oct 11, 2:59 PM
ruiu accepted D52951: [lld] Add more complete support for the INCLUDE command..

LGTM

Thu, Oct 11, 2:52 PM
ruiu committed rL344294: Rename SymbolTable::addRegular -> SymbolTable::addDefined..
Rename SymbolTable::addRegular -> SymbolTable::addDefined.
Thu, Oct 11, 1:45 PM
ruiu committed rLLD344294: Rename SymbolTable::addRegular -> SymbolTable::addDefined..
Rename SymbolTable::addRegular -> SymbolTable::addDefined.
Thu, Oct 11, 1:45 PM
ruiu committed rL344292: Remove unused default arguments..
Remove unused default arguments.
Thu, Oct 11, 1:41 PM
ruiu committed rLLD344292: Remove unused default arguments..
Remove unused default arguments.
Thu, Oct 11, 1:41 PM
ruiu committed rL344290: Remove SymbolTable::addUndefined<ELF32LE>(StringRef)..
Remove SymbolTable::addUndefined<ELF32LE>(StringRef).
Thu, Oct 11, 1:36 PM
ruiu committed rLLD344290: Remove SymbolTable::addUndefined<ELF32LE>(StringRef)..
Remove SymbolTable::addUndefined<ELF32LE>(StringRef).
Thu, Oct 11, 1:36 PM
ruiu accepted D53143: [LLD] [COFF] Add and use a Wordsize field in Config. NFCI..

Thank you for doing this!

Thu, Oct 11, 10:34 AM
ruiu added a comment to D53143: [LLD] [COFF] Add and use a Wordsize field in Config. NFCI..

lld/ELF has Config->Wordsize, so we should add the same variable to COFF.

Thu, Oct 11, 9:58 AM
ruiu accepted D53128: [LLD] [COFF] Set proper pointer size alignment for LocalImportChunk.

LGTM

Thu, Oct 11, 8:23 AM

Wed, Oct 10

ruiu committed rLLD344196: Make a member function private and rename it to avoid function overloading..
Make a member function private and rename it to avoid function overloading.
Wed, Oct 10, 3:51 PM
ruiu committed rL344196: Make a member function private and rename it to avoid function overloading..
Make a member function private and rename it to avoid function overloading.
Wed, Oct 10, 3:51 PM
ruiu accepted D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.

LGTM

Wed, Oct 10, 3:49 PM
ruiu added inline comments to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.
Wed, Oct 10, 3:46 PM
ruiu added inline comments to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.
Wed, Oct 10, 3:40 PM
ruiu added inline comments to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.
Wed, Oct 10, 3:32 PM
ruiu added inline comments to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.
Wed, Oct 10, 3:10 PM
ruiu accepted D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections..

LGTM

Wed, Oct 10, 1:55 PM
ruiu added inline comments to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.
Wed, Oct 10, 1:54 PM
ruiu committed rLLD344177: Eliminate dependency to formatv(). NFC..
Eliminate dependency to formatv(). NFC.
Wed, Oct 10, 1:32 PM
ruiu committed rL344177: Eliminate dependency to formatv(). NFC..
Eliminate dependency to formatv(). NFC.
Wed, Oct 10, 1:32 PM
ruiu added a comment to D53054: Adapt OptTable::PrintHelp change in D51009.

Please avoid llvm::formatv because StringRef and Twine work fine as well. I don't expect that the readers of the code memorizes this Python-style format string.

Wed, Oct 10, 1:22 PM
ruiu accepted D53003: [ELF] Fix link failure with Android compressed relocation support..

Please submit.

Wed, Oct 10, 11:26 AM
ruiu added a comment to D52452: Change the timestamp of llvmcache-foo file to meet the thinLTO prune policy.

If you are using git monorepo, you can easily combine two or more patches into one on this review site, and when you submit by "git llvm push", the command will automatically make a commit to each backing SVN repository. If you prefer, you can make a separate patch for review though. It's up to you. As long as you get an LGTM, you can commit it to lld.

Wed, Oct 10, 9:52 AM

Tue, Oct 9

ruiu committed rL344089: Merge two overloaded functions into one function. NFC..
Merge two overloaded functions into one function. NFC.
Tue, Oct 9, 3:47 PM
ruiu committed rLLD344089: Merge two overloaded functions into one function. NFC..
Merge two overloaded functions into one function. NFC.
Tue, Oct 9, 3:47 PM
ruiu committed rL344088: Return early. NFC..
Return early. NFC.
Tue, Oct 9, 3:47 PM
ruiu committed rLLD344088: Return early. NFC..
Return early. NFC.
Tue, Oct 9, 3:47 PM
ruiu added a comment to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.

It needs to be explained. I couldn't get it just by reading two lines of code.

Tue, Oct 9, 3:39 PM
ruiu added a comment to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.

I don't think I understand the point of this patch. You can't reorder undefined symbols, so why does CG-profile section contains undefined symbol in the first place?

Tue, Oct 9, 3:27 PM
ruiu added a comment to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.

Does that make sense? I still feel like ignoring undefined symbols spoils the point of calling that function in the first place.

Tue, Oct 9, 3:14 PM
ruiu added a comment to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.

You should skip an undefined symbol if it is created from a DSO, no? Looks like just skipping all undefined symbols there also suppresses legitimate warnings.

Tue, Oct 9, 3:03 PM
ruiu committed rLLD344083: Attempt to fix ubsan..
Attempt to fix ubsan.
Tue, Oct 9, 2:44 PM
ruiu committed rL344083: Attempt to fix ubsan..
Attempt to fix ubsan.
Tue, Oct 9, 2:44 PM
ruiu added inline comments to D53017: [LLD] [COFF] Look for libfoo.a if foo.lib is specified, for MinGW.
Tue, Oct 9, 2:31 PM
ruiu committed rL344076: Calculate an offset only once. NFC..
Calculate an offset only once. NFC.
Tue, Oct 9, 1:32 PM
ruiu committed rLLD344076: Calculate an offset only once. NFC..
Calculate an offset only once. NFC.
Tue, Oct 9, 1:32 PM
ruiu committed rLLD344075: Remove redundant `Symtab->`..
Remove redundant `Symtab->`.
Tue, Oct 9, 1:24 PM
ruiu committed rL344075: Remove redundant `Symtab->`..
Remove redundant `Symtab->`.
Tue, Oct 9, 1:24 PM
ruiu committed rL344074: Simplify. NFC..
Simplify. NFC.
Tue, Oct 9, 1:18 PM
ruiu committed rLLD344074: Simplify. NFC..
Simplify. NFC.
Tue, Oct 9, 1:18 PM
ruiu committed rL344072: Remove a use of template to make code less abstracted..
Remove a use of template to make code less abstracted.
Tue, Oct 9, 12:57 PM
ruiu committed rLLD344072: Remove a use of template to make code less abstracted..
Remove a use of template to make code less abstracted.
Tue, Oct 9, 12:57 PM
ruiu committed rL344062: Add an entry to the release notes..
Add an entry to the release notes.
Tue, Oct 9, 10:55 AM
ruiu committed rLLD344062: Add an entry to the release notes..
Add an entry to the release notes.
Tue, Oct 9, 10:55 AM
ruiu updated the diff for D53031: Expand comment for MinGW driver..
  • fix typos
Tue, Oct 9, 10:45 AM
ruiu accepted D53021: lld-link: Use /pdbsourcepath: for more places when present..

LGTM

Tue, Oct 9, 10:43 AM
ruiu created D53031: Expand comment for MinGW driver..
Tue, Oct 9, 10:43 AM
ruiu accepted D53015: [LLD] [MinGW] Pass libpath to the COFF linker.

LGTM

Tue, Oct 9, 10:19 AM
ruiu added a comment to D53021: lld-link: Use /pdbsourcepath: for more places when present..

Personally, I found that the way how Go handles pathnames is better than other languages and libraries. In Go, pathname separator is always "/" even on Windows. That means you have to convert from/to native Windows paths by replacing "\" with "/" when you do IO, but having one internal representation makes coding much easier. For example, concatenating a directory name and a filename is as easy as Dir + "/" + Filename; you don't need anything like sys::path::append. Unfortunately, that's not how we handle pathnames in LLVM, though. I'm just saying.

Tue, Oct 9, 10:13 AM
ruiu added inline comments to D53021: lld-link: Use /pdbsourcepath: for more places when present..
Tue, Oct 9, 7:05 AM
ruiu added a comment to D53003: [ELF] Fix link failure with Android compressed relocation support..

Looking good, but I'd like to wait for pcc's response for a few days if he's okay to have a padding at the end of the section.

Tue, Oct 9, 6:33 AM
ruiu added a comment to D53015: [LLD] [MinGW] Pass libpath to the COFF linker.

If you do this, do you still have to search library files in MinGW driver?

Tue, Oct 9, 6:30 AM

Mon, Oct 8

ruiu added a comment to D53003: [ELF] Fix link failure with Android compressed relocation support..

How did you find it? If you find it in the wild, how large is the padding you added to workaround the issue for your program?

Mon, Oct 8, 4:14 PM
ruiu added a comment to D52909: Add R_HEX_GOT_16_X support.

Is this your final patch to support Hexagon, or do you have any other plans? I'm just wondering.

Mon, Oct 8, 11:11 AM
ruiu added a comment to D52951: [lld] Add more complete support for the INCLUDE command..

Or, as George pointed out, you can make linker script as independent files.

Mon, Oct 8, 11:08 AM
ruiu added inline comments to D52951: [lld] Add more complete support for the INCLUDE command..
Mon, Oct 8, 11:08 AM
ruiu accepted D52942: lld-link: Implement support for %_PDB% and %_EXT% for /pdbaltpath:..

Hmm, okay, it seems all the choices are not that different, so I'm fine with your original one. Thank you for writing all the pieces of code by the way! :)

Mon, Oct 8, 11:04 AM
ruiu abandoned D52241: Eliminate .{,z}debug_gnu_pub{names,types} sections as early as possible..

I submitted https://reviews.llvm.org/rL343979 which also reduce memory consumption for .zdebug_gnu_pub{names,types} sections, so I don't think we need this anymore.

Mon, Oct 8, 10:58 AM
ruiu committed rLLD343983: Fix a broken buildbot..
Fix a broken buildbot.
Mon, Oct 8, 10:26 AM
ruiu committed rL343983: Fix a broken buildbot..
Fix a broken buildbot.
Mon, Oct 8, 10:26 AM
ruiu committed rL343979: Avoid unnecessary buffer allocation and memcpy for compressed sections..
Avoid unnecessary buffer allocation and memcpy for compressed sections.
Mon, Oct 8, 10:01 AM
ruiu committed rLLD343979: Avoid unnecessary buffer allocation and memcpy for compressed sections..
Avoid unnecessary buffer allocation and memcpy for compressed sections.
Mon, Oct 8, 10:01 AM
ruiu closed D52917: Avoid unnecessary buffer allocation and memcpy for compressed sections..
Mon, Oct 8, 10:00 AM

Fri, Oct 5

ruiu added inline comments to D52942: lld-link: Implement support for %_PDB% and %_EXT% for /pdbaltpath:..
Fri, Oct 5, 1:28 PM
ruiu accepted D52931: [LLD] [COFF] Do MinGW specific entry/subsystem inference.

LGTM

Fri, Oct 5, 12:39 PM
ruiu added inline comments to D52917: Avoid unnecessary buffer allocation and memcpy for compressed sections..
Fri, Oct 5, 10:38 AM
ruiu updated the diff for D52917: Avoid unnecessary buffer allocation and memcpy for compressed sections..
  • make member variables mutable instead of using const_cast to call uncompress()
Fri, Oct 5, 10:38 AM
ruiu added a comment to D52931: [LLD] [COFF] Do MinGW specific entry/subsystem inference.

This function is called only when you did not pass /entry:.

Fri, Oct 5, 10:10 AM
ruiu accepted D52908: [LLD] [docs] Mention some notable feature in the release notes.

LGTM

Fri, Oct 5, 10:08 AM
ruiu added inline comments to D52917: Avoid unnecessary buffer allocation and memcpy for compressed sections..
Fri, Oct 5, 9:47 AM