Page MenuHomePhabricator

arichardson (Alexander Richardson)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2015, 4:18 PM (356 w, 3 d)

Recent Activity

Sun, Jul 3

arichardson added inline comments to D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths.
Sun, Jul 3, 12:21 PM · Restricted Project, Restricted Project

Thu, Jun 30

arichardson added inline comments to D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths.
Thu, Jun 30, 3:03 AM · Restricted Project, Restricted Project

Fri, Jun 24

arichardson added inline comments to D128481: Add expensive/extensive pass to set Load/Store alignment.
Fri, Jun 24, 1:15 AM · Restricted Project, Restricted Project

Mon, Jun 20

arichardson added a comment to D127581: [ELF] Relax R_RISCV_ALIGN.

I haven't looked at the code yet, but I can confirm that I was able to build and boot FreeBSD for RISCV64 with this patch and the FreeBSD patch below to remove -mno-relax (I could have just defined the riscv-relaxations linker feature, but I wanted to make sure that the code is actually built with relaxations):

diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk
index 36d91ea019f3..b37ebe39ecf4 100644
--- a/share/mk/bsd.lib.mk
+++ b/share/mk/bsd.lib.mk
@@ -123,8 +123,8 @@ CXXFLAGS+= ${DEBUG_FILES_CFLAGS}
 CTFFLAGS+= -g
 .endif
Mon, Jun 20, 2:47 AM · Restricted Project, Restricted Project
arichardson committed rG8df257a6d0b0: [libunwind] Ensure test/libunwind_01.pass is not completely inlined (authored by arichardson).
[libunwind] Ensure test/libunwind_01.pass is not completely inlined
Mon, Jun 20, 2:06 AM · Restricted Project
arichardson closed D126611: [libunwind] Ensure test/libunwind_01.pass is not completely inlined.
Mon, Jun 20, 2:06 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Fri, Jun 17

arichardson added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

I have some WIP patches for the locale tests that I should update . I'm not sure how long it will take to fix all the tests so maybe xfail is better so that regressions are caught?

Fri, Jun 17, 3:54 PM · Restricted Project, Restricted Project, Restricted Project

May 29 2022

arichardson added inline comments to D126611: [libunwind] Ensure test/libunwind_01.pass is not completely inlined.
May 29 2022, 12:51 PM · Restricted Project, Restricted Project, Unknown Object (Project)
arichardson added inline comments to D126611: [libunwind] Ensure test/libunwind_01.pass is not completely inlined.
May 29 2022, 4:23 AM · Restricted Project, Restricted Project, Unknown Object (Project)
arichardson requested review of D126611: [libunwind] Ensure test/libunwind_01.pass is not completely inlined.
May 29 2022, 4:22 AM · Restricted Project, Restricted Project, Unknown Object (Project)

May 26 2022

arichardson added a comment to D126411: update_mir_test_checks: Better handling of common prefixes.

This looks reasonable to me, would it be possible to add a test showing the new behaviour?

Yeah, I was wondering about that as well. Do you have any advice on how to do that? I didn't find any pre-existing tests, and it seems somewhat tricky to set up given that it's subject to changes in the code generator.

May 26 2022, 1:16 PM · Restricted Project, Restricted Project
arichardson added a comment to D126392: [RISCV] Use two ADDIs to do some stack pointer adjustments..

This may break assumptions that some unwinding code uses (e.g. an kernel backtrace without debug info). But then again I don't know if any of them handle non-immediate offsets anyway.

What do you mean? Unwinding with neither the frame pointer nor CFI?

May 26 2022, 12:03 PM · Restricted Project, Restricted Project
arichardson added a comment to D126392: [RISCV] Use two ADDIs to do some stack pointer adjustments..

This may break assumptions that some unwinding code uses (e.g. an kernel backtrace without debug info). But then again I don't know if any of them handle non-immediate offsets anyway.

May 26 2022, 2:00 AM · Restricted Project, Restricted Project

May 25 2022

arichardson added a comment to D126411: update_mir_test_checks: Better handling of common prefixes.

This looks reasonable to me, would it be possible to add a test showing the new behaviour?

May 25 2022, 4:31 PM · Restricted Project, Restricted Project

May 24 2022

arichardson added a comment to D95137: [update_(llc_)test_checks.py] Support pre-processing commands.

Unless there are any

May 24 2022, 1:38 PM · Restricted Project, Restricted Project

May 14 2022

arichardson added a comment to D125303: [update_llc_test_checks] Handle mixed asm and ISel debug output.

Thank you so much for the improvements, Alexander! It would be nice to support isel and asm at the same time. Although I do have a few questions and one concern with regard to an ongoing change of mine.

I noticed a potentially uninitialized variable warning after D119368.

Would you mind pointing me to that warning? Is it complaining about output_type? And after your change the warning is gone? That does sound quite false positive-ish...

I have deleted the add_checks() function from isel.py as it is identical to the one in asm.py

Please don't delete that add_checks() function yet. It is only identical to the one in asm.py because we are still working on it... I have a review D122824 in progress (Sorry this one took a bit too long for me to get back to it, but I do plan to get back to it in the next few days.)

Ah I didn't see that one. For mixed ISel and non-ISel output this will need a different approach though since the correct prefix depends on the current RUN: line.

May 14 2022, 2:30 PM · Restricted Project, Restricted Project
arichardson committed rGc8b44600c5ec: [AArch64] Avoid emitting MOVID when NEON is disabled (authored by arichardson).
[AArch64] Avoid emitting MOVID when NEON is disabled
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson committed rG996873cdcbe0: [UpdateTestChecks] Use a counter for unpredictable FileCheck variables (authored by arichardson).
[UpdateTestChecks] Use a counter for unpredictable FileCheck variables
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson committed rG37a68497f117: [update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output (authored by arichardson).
[update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson committed rGf421659286af: [update_llc_test_checks] Baseline test for --asm-show-inst (authored by arichardson).
[update_llc_test_checks] Baseline test for --asm-show-inst
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson committed rG4b5ad57d676c: [UpdateTestChecks] Change global functions to NamelessValue members. NFCI (authored by arichardson).
[UpdateTestChecks] Change global functions to NamelessValue members. NFCI
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson closed D125237: [AArch64] Avoid emitting MOVID when NEON is disabled.
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson committed rGf8639133b58d: [AArch64] Baseline test for D125307 (authored by arichardson).
[AArch64] Baseline test for D125307
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson closed D125405: [UpdateTestChecks] Use a counter for unpredictable FileCheck variables.
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson committed rG09551251e32a: [AArch64] Add missing HasNEON predicates to int->float patterns (authored by arichardson).
[AArch64] Add missing HasNEON predicates to int->float patterns
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson closed D125307: [update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output.
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson closed D125305: [update_llc_test_checks] Baseline test for --asm-show-inst.
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson closed D125390: [UpdateTestChecks] Change global functions to NamelessValue members. NFCI.
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson closed D125308: [AArch64] Add missing HasNEON predicates to int->float patterns.
May 14 2022, 7:43 AM · Restricted Project, Restricted Project
arichardson closed D125240: [AArch64] Baseline test for D125307.
May 14 2022, 7:43 AM · Restricted Project, Restricted Project

May 13 2022

arichardson added inline comments to D125328: [BasicAA] Fix order in which we pass MemoryLocations to alias().
May 13 2022, 10:41 AM · Restricted Project, Restricted Project

May 12 2022

arichardson added inline comments to D125308: [AArch64] Add missing HasNEON predicates to int->float patterns.
May 12 2022, 3:08 AM · Restricted Project, Restricted Project
arichardson updated the diff for D125308: [AArch64] Add missing HasNEON predicates to int->float patterns.

Drop --asm-show-inst

May 12 2022, 3:06 AM · Restricted Project, Restricted Project
arichardson updated the diff for D125240: [AArch64] Baseline test for D125307.

drop --asm-show-inst

May 12 2022, 3:05 AM · Restricted Project, Restricted Project
arichardson added a comment to D125240: [AArch64] Baseline test for D125307.

Do we need --asm-show-inst, or is it enough to just show the instructions? It seems quite verbose for the information it gives.

May 12 2022, 3:04 AM · Restricted Project, Restricted Project
arichardson updated the diff for D125308: [AArch64] Add missing HasNEON predicates to int->float patterns.

Regen with D125405

May 12 2022, 2:57 AM · Restricted Project, Restricted Project
arichardson updated the diff for D125240: [AArch64] Baseline test for D125307.

regen with D125405

May 12 2022, 2:35 AM · Restricted Project, Restricted Project

May 11 2022

arichardson requested review of D125405: [UpdateTestChecks] Use a counter for unpredictable FileCheck variables.
May 11 2022, 10:43 AM · Restricted Project, Restricted Project
arichardson retitled D125307: [update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output from [update_llc_test_checks] Scrub MCInst numbers with --asm-show-inst to [update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output.
May 11 2022, 10:24 AM · Restricted Project, Restricted Project
arichardson updated the diff for D125307: [update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output.

Use FileCheck captures instead to ensure registers are matched

May 11 2022, 10:22 AM · Restricted Project, Restricted Project
arichardson requested review of D125390: [UpdateTestChecks] Change global functions to NamelessValue members. NFCI.
May 11 2022, 7:36 AM · Restricted Project, Restricted Project

May 10 2022

arichardson updated the diff for D125305: [update_llc_test_checks] Baseline test for --asm-show-inst.

Simplify test

May 10 2022, 8:25 AM · Restricted Project, Restricted Project
arichardson published D125308: [AArch64] Add missing HasNEON predicates to int->float patterns for review.
May 10 2022, 5:10 AM · Restricted Project, Restricted Project
arichardson published D125305: [update_llc_test_checks] Baseline test for --asm-show-inst for review.
May 10 2022, 5:09 AM · Restricted Project, Restricted Project
arichardson published D125240: [AArch64] Baseline test for D125307 for review.
May 10 2022, 5:09 AM · Restricted Project, Restricted Project
arichardson published D125307: [update_llc_test_checks] Use FileCheck captures for MCInst/MCReg output for review.
May 10 2022, 5:08 AM · Restricted Project, Restricted Project
arichardson requested review of D125303: [update_llc_test_checks] Handle mixed asm and ISel debug output.
May 10 2022, 4:04 AM · Restricted Project, Restricted Project
arichardson committed rT11047081ff02: SPEC2006: Allow building on FreeBSD (authored by arichardson).
SPEC2006: Allow building on FreeBSD
May 10 2022, 2:01 AM · Restricted Project
arichardson closed D124393: SPEC2006: Allow building on FreeBSD.
May 10 2022, 2:01 AM · Restricted Project

May 9 2022

arichardson added a comment to D124105: [ELF] Support -plugin-opt=stats-file=.

@MTC @arichardson The test stats-file-option.ll that is now enabled after this commit seems to fail if X86 is not one of the built targets. Can the test be rewritten to now require that, or an appropriate REQUIRES line added?

May 9 2022, 3:53 PM · Restricted Project, Restricted Project
arichardson requested review of D125237: [AArch64] Avoid emitting MOVID when NEON is disabled.
May 9 2022, 8:10 AM · Restricted Project, Restricted Project
arichardson committed rG7c20e7ca8642: [ELF] Support -plugin-opt=stats-file= (authored by arichardson).
[ELF] Support -plugin-opt=stats-file=
May 9 2022, 8:05 AM · Restricted Project
arichardson closed D124105: [ELF] Support -plugin-opt=stats-file=.
May 9 2022, 8:05 AM · Restricted Project, Restricted Project
arichardson added inline comments to D125204: [RISCV] Use RISCVISAInfo to parse arch string from ELF build attribute..
May 9 2022, 12:25 AM · Restricted Project, Restricted Project

May 6 2022

arichardson added inline comments to D125036: [RISCV] Alignment relaxation.
May 6 2022, 1:08 AM · Restricted Project, Restricted Project

Apr 27 2022

arichardson retitled D124105: [ELF] Support -plugin-opt=stats-file= from [ELF] Support -plugin-opt=statsfile= to [ELF] Support -plugin-opt=stats-file=.
Apr 27 2022, 3:07 AM · Restricted Project, Restricted Project
arichardson updated the diff for D124105: [ELF] Support -plugin-opt=stats-file=.

Replace --stats-file and make the test actually run

Apr 27 2022, 3:07 AM · Restricted Project, Restricted Project

Apr 25 2022

arichardson requested review of D124393: SPEC2006: Allow building on FreeBSD.
Apr 25 2022, 8:10 AM · Restricted Project

Apr 21 2022

arichardson requested review of D124169: [SelectionDAG] Add statistics for inline emission of memory intrinsics.
Apr 21 2022, 6:43 AM · Restricted Project, Restricted Project
arichardson added a comment to D124105: [ELF] Support -plugin-opt=stats-file=.

If this is for LTO usage, I think we should remove --stats-file= recently added from D121809 (@MTC) and keep this -plugin-opt=stats-file=

Apr 21 2022, 2:00 AM · Restricted Project, Restricted Project

Apr 20 2022

arichardson committed rT866848a9c6f6: utils/compare.py: Add --absolute-diff (authored by arichardson).
utils/compare.py: Add --absolute-diff
Apr 20 2022, 10:36 AM · Restricted Project
arichardson closed D124102: utils/compare.py: Add --absolute-diff.
Apr 20 2022, 10:36 AM · Restricted Project
arichardson closed D121908: utils/compare.py: Fix support for multiple metrics.
Apr 20 2022, 10:36 AM · Restricted Project
arichardson committed rT0954371820c4: utils/compare.py: Fix support for multiple metrics (authored by arichardson).
utils/compare.py: Fix support for multiple metrics
Apr 20 2022, 10:36 AM · Restricted Project
arichardson committed rTbb77bd4067c7: utils/compare.py: Add a main() function (authored by arichardson).
utils/compare.py: Add a main() function
Apr 20 2022, 10:36 AM · Restricted Project
arichardson committed rT16b7d7fce5c1: utils/compare.py: Fix a pandas deprecation warning (authored by arichardson).
utils/compare.py: Fix a pandas deprecation warning
Apr 20 2022, 10:36 AM · Restricted Project
arichardson added inline comments to D124102: utils/compare.py: Add --absolute-diff.
Apr 20 2022, 10:33 AM · Restricted Project
arichardson requested review of D124105: [ELF] Support -plugin-opt=stats-file=.
Apr 20 2022, 9:54 AM · Restricted Project, Restricted Project
arichardson added a comment to D121908: utils/compare.py: Fix support for multiple metrics.

ping?

Apr 20 2022, 9:36 AM · Restricted Project
arichardson requested review of D124102: utils/compare.py: Add --absolute-diff.
Apr 20 2022, 9:36 AM · Restricted Project

Apr 19 2022

arichardson added a comment to D122569: [lit] Support %if ... %else syntax for RUN lines.

While this is not a huge amount of code to be added to lit, I do wonder if we really need it. Wouldn't something like %feature{foo} that expands to 0 or 1 be sufficient? You could then use shell conditionals/test to avoid running lines.
Looking at the examples from D121727, you could do the following:

RUN: if [ %feature{ptxas} -ne 0 ]; then ptxas -c %t-nvptx.ptx -o /dev/null; fi
RUN: test %feature{ptxas} -ne 0 && ptxas -c %t-nvptx.ptx -o /dev/null

Or alternatively if %feature expands to an empty string ("") or "1":

RUN: if [ -n %feature{ptxas} ]; then ptxas -c %t-nvptx.ptx -o /dev/null; fi
RUN: test -n %feature{ptxas} && ptxas -c %t-nvptx.ptx -o /dev/null

Depending on how you set up the ptxas substitution it might even be possible without a %feature{} lit substitution.

Apr 19 2022, 2:31 AM · Restricted Project, Restricted Project

Apr 13 2022

arichardson committed rG32a353a5e086: [AArch64] Baseline test for D123491 (authored by arichardson).
[AArch64] Baseline test for D123491
Apr 13 2022, 2:31 AM · Restricted Project, Restricted Project
arichardson committed rGee44896cf42d: [AArch64] Add missing HasNEON predicate in scalar FABD patterns (authored by arichardson).
[AArch64] Add missing HasNEON predicate in scalar FABD patterns
Apr 13 2022, 2:31 AM · Restricted Project, Restricted Project
arichardson committed rG9107cd632d50: [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics (authored by arichardson).
[AutoUpgrade] Don't lose attributes when upgrading mem intrinsics
Apr 13 2022, 2:31 AM · Restricted Project, Restricted Project
arichardson closed D121971: [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics.
Apr 13 2022, 2:31 AM · Restricted Project, Restricted Project
arichardson closed D123491: [AArch64] Add missing HasNEON predicate in scalar FABD patterns.
Apr 13 2022, 2:31 AM · Restricted Project, Restricted Project

Apr 12 2022

arichardson added inline comments to D123633: Adapt "cross compile?" check for Apple Silicon.
Apr 12 2022, 3:47 PM · Restricted Project, Restricted Project
arichardson added a comment to D122569: [lit] Support %if ... %else syntax for RUN lines.

Please don't forget to also update the llvm/utils/update_*_checks.py.

It seems that update_*_checks.py scripts are completely independent of lit.py, so there is no way to easily reuse code between them. Parsing of RUN lines and standard substitutions is duplicated there. We have to either integrate these scripts, or copy paste the code.

Apr 12 2022, 3:36 PM · Restricted Project, Restricted Project
arichardson added inline comments to D123491: [AArch64] Add missing HasNEON predicate in scalar FABD patterns.
Apr 12 2022, 2:01 PM · Restricted Project, Restricted Project

Apr 11 2022

arichardson added inline comments to D121971: [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics.
Apr 11 2022, 5:18 AM · Restricted Project, Restricted Project
arichardson updated the diff for D121971: [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics.

Address review comment by @nikic

Apr 11 2022, 5:17 AM · Restricted Project, Restricted Project
arichardson added inline comments to D121971: [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics.
Apr 11 2022, 3:51 AM · Restricted Project, Restricted Project
arichardson requested review of D123491: [AArch64] Add missing HasNEON predicate in scalar FABD patterns.
Apr 11 2022, 3:19 AM · Restricted Project, Restricted Project
arichardson updated the diff for D121971: [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics.

Fix another test that benefits from this change

Apr 11 2022, 2:58 AM · Restricted Project, Restricted Project

Mar 30 2022

arichardson added a comment to D120851: [libc++] Add a CI job running MSAN.

My guess is that all that's needed here are MSAN annotations around the functions written in inline assembly (saving/restoring all registers).

Mar 30 2022, 2:08 PM · Unknown Object (Project), Restricted Project, Restricted Project
arichardson added inline comments to D122335: [clang] Emit crash reproduction as a single tar file.
Mar 30 2022, 1:15 AM · Restricted Project

Mar 25 2022

arichardson updated the diff for D121908: utils/compare.py: Fix support for multiple metrics.

Ensure the full terminal width is used for the d.describe() call.

Mar 25 2022, 5:31 AM · Restricted Project

Mar 24 2022

arichardson added a comment to D122335: [clang] Emit crash reproduction as a single tar file.

As a developer who often deals with crashes locally this is more annoying; currently I can just point tools at the shell script and C file in /tmp and let them go to work reducing, but now I have to also extract the files

Mar 24 2022, 2:02 AM · Restricted Project

Mar 23 2022

arichardson accepted D115274: [IR][RFC] Memory region declaration intrinsic.

I am happy with this but I feel like someone else should also approve it :)

Mar 23 2022, 1:45 PM · Restricted Project, Restricted Project

Mar 21 2022

arichardson added inline comments to D115274: [IR][RFC] Memory region declaration intrinsic.
Mar 21 2022, 4:29 PM · Restricted Project, Restricted Project
arichardson added inline comments to D115274: [IR][RFC] Memory region declaration intrinsic.
Mar 21 2022, 4:04 PM · Restricted Project, Restricted Project
arichardson added a comment to D115274: [IR][RFC] Memory region declaration intrinsic.

In general I like this and would be very happy if we had a better way of dealing with sub-objects in LLVM.

Mar 21 2022, 3:36 PM · Restricted Project, Restricted Project

Mar 17 2022

arichardson requested review of D121971: [AutoUpgrade] Don't lose attributes when upgrading mem intrinsics.
Mar 17 2022, 4:32 PM · Restricted Project, Restricted Project
arichardson requested review of D121908: utils/compare.py: Fix support for multiple metrics.
Mar 17 2022, 5:39 AM · Restricted Project

Mar 15 2022

arichardson accepted D121654: [RISCV] Ensure PseudoLA* can be hoisted.

LGTM

Mar 15 2022, 7:37 AM · Restricted Project, Restricted Project

Feb 25 2022

arichardson accepted D120535: [ELF] Support some absolute/PC-relative relocation types for REL format.

LGTM

Feb 25 2022, 3:17 AM · Restricted Project

Feb 14 2022

arichardson planned changes to D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source.

Have to fix cmake -GNinja -DCLANG_ENABLE_STATIC_ANALYZER=OFF -DLLVM_ENABLE_PROJECTS="llvm;clang;clang-tools-extra" -DCLANG_ENABLE_ARCMT=OFF ../llvm

Feb 14 2022, 6:15 AM · Restricted Project, Restricted Project
arichardson reopened D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source.

I will try to get back to this soon, but it will probably not be this week.

Feb 14 2022, 6:15 AM · Restricted Project, Restricted Project

Jan 31 2022

arichardson added inline comments to D108416: [llvm-libgcc] initial commit.
Jan 31 2022, 3:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 19 2022

arichardson added a comment to D117728: [libc++] Check that gdb is linked with Python 3.

Do they still fail after rG89103bd2f06d? I was able to run ninja check-all successfully with a gdb linked against 2.7.

Jan 19 2022, 4:13 PM · Restricted Project