Page MenuHomePhabricator
People hiraditya

hiraditya (Aditya Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2014, 4:23 PM (429 w, 2 d)

Recent Activity
View All

Apr 18 2022

hiraditya updated the summary of D32140: Global code motion of congruent computations.
Apr 18 2022, 2:08 PM · Restricted Project, Restricted Project
hiraditya updated the summary of D32140: Global code motion of congruent computations.
Apr 18 2022, 2:07 PM · Restricted Project, Restricted Project

Apr 12 2022

hiraditya retitled D123640: [NFC] Make comment consistent with allow|ignore list renamings from Make comment consistent with allow|ignore list renamings to [NFC] Make comment consistent with allow|ignore list renamings.
Apr 12 2022, 6:01 PM · Restricted Project, Restricted Project
hiraditya requested review of D123640: [NFC] Make comment consistent with allow|ignore list renamings.
Apr 12 2022, 3:54 PM · Restricted Project, Restricted Project

Mar 30 2022

hiraditya added a comment to D122730: [GVNHoist] drop debug location according to the debug info guide.

issue addressed by this patch: https://github.com/llvm/llvm-project/issues/48443

Mar 30 2022, 8:21 PM · Restricted Project, Restricted Project
hiraditya committed rG368681f80383: [GVNHoist] drop debug location according to the debug info guide (authored by hiraditya).
[GVNHoist] drop debug location according to the debug info guide
Mar 30 2022, 8:19 PM · Restricted Project, Restricted Project
hiraditya closed D122730: [GVNHoist] drop debug location according to the debug info guide.
Mar 30 2022, 8:18 PM · Restricted Project, Restricted Project
Herald added projects to D49858: [RFC] re-enable GVNHoist by default: Restricted Project, Restricted Project.

https://bugs.llvm.org/show_bug.cgi?id=38807 has been fixed.

Mar 30 2022, 8:21 AM · Restricted Project, Restricted Project
Herald added projects to D50323: [GVNHoist] Prune out useless CHI insertions: Restricted Project, Restricted Project.

https://bugs.llvm.org/show_bug.cgi?id=38807 has been fixed.

Mar 30 2022, 8:19 AM · Restricted Project, Restricted Project
hiraditya updated subscribers of D122730: [GVNHoist] drop debug location according to the debug info guide.
Mar 30 2022, 8:02 AM · Restricted Project, Restricted Project
hiraditya requested review of D122730: [GVNHoist] drop debug location according to the debug info guide.
Mar 30 2022, 8:02 AM · Restricted Project, Restricted Project
hiraditya accepted D122521: Value-number GVNHoist loads by result type as well as pointer address..

GVN hoist did not have the logic for opaque pointers because opaque pointers were added later IIRC.
Thanks for fixing this!
LGTM.

Mar 30 2022, 7:23 AM · Restricted Project, Restricted Project

Mar 29 2022

Herald added a project to D110817: [GVN] Simple GVN hoist - scalars: Restricted Project.

i fixed PR46874 last year in case this was the issue https://reviews.llvm.org/D108425. If there are further bugs with GVNHoist, i'm happy to fix them.

Mar 29 2022, 2:12 PM · Restricted Project, Restricted Project

Mar 15 2022

hiraditya accepted D121735: [libc++] Fix incorrect availability markup for bad_optional_access & friends.

LGTM, thanks for fixing it quickly.

Mar 15 2022, 1:48 PM · Restricted Project, Restricted Project

Mar 12 2022

hiraditya committed rW07a5edbc0d13: [LLVM CGO] Update to virtual (authored by hiraditya).
[LLVM CGO] Update to virtual
Mar 12 2022, 11:50 AM · Restricted Project

Mar 11 2022

Herald added a project to D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list=<arg1,arg2,...> to match gcc options.: Restricted Project.

Is there a plan to revive this? this is quite necessary for one of my use cases.
can we at least have '-fno-instrument-functions'?

Mar 11 2022, 4:04 PM · Restricted Project

Feb 11 2022

hiraditya committed rW9c3f68058466: Make hyperlinks (authored by hiraditya).
Make hyperlinks
Feb 11 2022, 10:59 AM

Jan 30 2022

hiraditya committed rW089eb0ac8b5d: LLVM-CGO: Fix formatting (authored by hiraditya).
LLVM-CGO: Fix formatting
Jan 30 2022, 10:31 PM
hiraditya committed rWaebbb1299a61: Add LLVM CGO workshop CFP (authored by hiraditya).
Add LLVM CGO workshop CFP
Jan 30 2022, 10:31 PM

Jan 16 2022

hiraditya added inline comments to D117256: [memprof] Introduce a wrapper around MemInfoBlock..
Jan 16 2022, 11:33 PM · Restricted Project, Restricted Project
hiraditya added inline comments to D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs.
Jan 16 2022, 11:23 PM · Restricted Project, Restricted Project
hiraditya accepted D110179: [NFC][IR] Remove unused assignment to Offset.

LGTM.

Jan 16 2022, 11:02 PM · Restricted Project, Restricted Project
hiraditya added a reviewer for D117292: [Driver] Pass the flag -dI to cc1 invocation: rsmith.
Jan 16 2022, 10:58 PM · Restricted Project

Oct 21 2021

hiraditya added a comment to D111912: New Pass for Merging Arbitrary Pair of Functions to Reduce Code Size.

maybe git-clang-format because we are modifying unrelated changes.

Oct 21 2021, 11:38 AM · Restricted Project, Restricted Project

Oct 19 2021

hiraditya added a comment to D111912: New Pass for Merging Arbitrary Pair of Functions to Reduce Code Size.

clang-format please.

Oct 19 2021, 11:08 AM · Restricted Project, Restricted Project

Oct 8 2021

hiraditya committed rG0f00aa502d79: Add no_instrument_function attribute to Objective C methods as well (authored by hiraditya).
Add no_instrument_function attribute to Objective C methods as well
Oct 8 2021, 5:55 PM
hiraditya closed D111286: Add no_instrument_function attribute to Objective C methods as well.
Oct 8 2021, 5:54 PM · Restricted Project

Oct 7 2021

hiraditya updated the diff for D111286: Add no_instrument_function attribute to Objective C methods as well.

clang-format

Oct 7 2021, 11:47 AM · Restricted Project
hiraditya updated the diff for D111286: Add no_instrument_function attribute to Objective C methods as well.

Added SemaObjc test case.

Oct 7 2021, 10:06 AM · Restricted Project

Oct 6 2021

hiraditya updated the diff for D111286: Add no_instrument_function attribute to Objective C methods as well.
Oct 6 2021, 11:27 PM · Restricted Project
hiraditya updated the summary of D111286: Add no_instrument_function attribute to Objective C methods as well.
Oct 6 2021, 11:26 PM · Restricted Project
hiraditya updated the diff for D111286: Add no_instrument_function attribute to Objective C methods as well.

Testcase ready.

Oct 6 2021, 11:25 PM · Restricted Project
hiraditya added a comment to D111286: Add no_instrument_function attribute to Objective C methods as well.

Still working on adding the testcase.

Oct 6 2021, 9:43 PM · Restricted Project
hiraditya requested review of D111286: Add no_instrument_function attribute to Objective C methods as well.
Oct 6 2021, 9:43 PM · Restricted Project

Aug 20 2021

hiraditya added a comment to D108425: PR46874: Reset stack after visiting a node.

PR: https://bugs.llvm.org/show_bug.cgi?id=46874

Aug 20 2021, 11:34 AM · Restricted Project
hiraditya committed rGb8e345b26674: PR46874: Reset stack after visiting a node (authored by hiraditya).
PR46874: Reset stack after visiting a node
Aug 20 2021, 11:29 AM
hiraditya closed D108425: PR46874: Reset stack after visiting a node.
Aug 20 2021, 11:28 AM · Restricted Project

Aug 19 2021

hiraditya updated the diff for D108425: PR46874: Reset stack after visiting a node.

clang-format

Aug 19 2021, 8:50 PM · Restricted Project
hiraditya updated the diff for D108425: PR46874: Reset stack after visiting a node.

Rebase

Aug 19 2021, 7:06 PM · Restricted Project
hiraditya requested review of D108425: PR46874: Reset stack after visiting a node.
Aug 19 2021, 4:36 PM · Restricted Project

Jun 13 2021

hiraditya committed rGdcbbc69cc582: Calculate getTerminator only when necessary (authored by hiraditya).
Calculate getTerminator only when necessary
Jun 13 2021, 8:16 PM
hiraditya closed D104202: [NFC] Calculate getTerminator only when necessary.
Jun 13 2021, 8:16 PM · Restricted Project
hiraditya accepted D104204: [docs][GISel]Added GISel documentation link.
Jun 13 2021, 1:04 PM · Restricted Project
hiraditya added a comment to D88460: Strlen loop idiom recognition.
Jun 13 2021, 12:55 PM · Restricted Project
hiraditya added inline comments to D104142: [IROutliner] Ensure instructions at end of candidate are excluded.
Jun 13 2021, 12:47 PM · Restricted Project
hiraditya added a comment to D88460: Strlen loop idiom recognition.

Do we have an example of real world workload where this pattern was found?

Jun 13 2021, 12:19 PM · Restricted Project
hiraditya added a comment to D104060: Machine IR Profile.
In D104060#2815509, @davidxl wrote:

Thinking about MIP's use case a little, it seems that it actually matches
what xray does. Xray has very low runtime overhead and can be turned on
always : xra https://llvm.org/docs/XRay.htmly. Have you compare with xray
and consider using that?

Jun 13 2021, 11:57 AM · Restricted Project
hiraditya retitled D104202: [NFC] Calculate getTerminator only when necessary from Calculate getTerminator only when necessary to [NFC] Calculate getTerminator only when necessary.
Jun 13 2021, 11:35 AM · Restricted Project
hiraditya requested review of D104202: [NFC] Calculate getTerminator only when necessary.
Jun 13 2021, 11:33 AM · Restricted Project

Mar 10 2021

hiraditya committed rG6976255faffb: Add noreturn attribute to non-returning functions (authored by hiraditya).
Add noreturn attribute to non-returning functions
Mar 10 2021, 2:36 PM
hiraditya closed D97308: Add noreturn attribute to non-returning functions.
Mar 10 2021, 2:36 PM · Restricted Project
hiraditya added a comment to D97308: Add noreturn attribute to non-returning functions.
In D97308#2616596, @Quuxplusone wrote:
In D97308#2615920, @hiraditya wrote:
In D97308#2611794, @Quuxplusone wrote:
  • void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

No, I meant this version: https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L6270

Mar 10 2021, 10:49 AM · Restricted Project
hiraditya committed rW788319fadebb: [LLVM+CGO] Add slide deck by Arun (authored by hiraditya).
[LLVM+CGO] Add slide deck by Arun
Mar 10 2021, 6:23 AM
hiraditya added a comment to D97308: Add noreturn attribute to non-returning functions.
In D97308#2611794, @Quuxplusone wrote:

I did a grep for void __throw and verified that every other instance is attributed, except for:

  • __throw_if_valueless in <variant>: this is good and intentional
  • void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

Mar 10 2021, 12:03 AM · Restricted Project

Mar 8 2021

hiraditya committed rW380b81ea9521: [LLVM+CGO] Add slide decks by Arun (authored by hiraditya).
[LLVM+CGO] Add slide decks by Arun
Mar 8 2021, 2:33 PM

Mar 2 2021

hiraditya committed rWff6911bf9c67: [LLVM CGO] Add slide deck of presenters (authored by hiraditya).
[LLVM CGO] Add slide deck of presenters
Mar 2 2021, 4:22 PM

Feb 25 2021

hiraditya committed rW8bf170784e88: [LLVM CGO] Update abstract by Denis (authored by hiraditya).
[LLVM CGO] Update abstract by Denis
Feb 25 2021, 3:31 PM
hiraditya added reviewers for D97308: Add noreturn attribute to non-returning functions: ldionne, mclow.lists.
Feb 25 2021, 11:44 AM · Restricted Project

Feb 23 2021

hiraditya committed rWd131edbb660c: [LLVM CGO] Move Denis before Aditya (authored by hiraditya).
[LLVM CGO] Move Denis before Aditya
Feb 23 2021, 8:05 PM
hiraditya requested review of D97308: Add noreturn attribute to non-returning functions.
Feb 23 2021, 11:17 AM · Restricted Project

Feb 16 2021

hiraditya added inline comments to D88460: Strlen loop idiom recognition.
Feb 16 2021, 11:00 AM · Restricted Project

Feb 14 2021

hiraditya requested review of D96685: [WIP] Add noexcept clang-tidy codemod.
Feb 14 2021, 10:48 PM · Restricted Project, Restricted Project

Feb 10 2021

hiraditya committed rWa2da935907bf: [LLVM+CGO] Increase Stefanos presentation to 45 minutes (authored by hiraditya).
[LLVM+CGO] Increase Stefanos presentation to 45 minutes
Feb 10 2021, 2:29 AM

Feb 9 2021

hiraditya committed rW39bfdd37a465: [LLVM+CGO] Moved Stefanos 1.5 hours earlier (authored by hiraditya).
[LLVM+CGO] Moved Stefanos 1.5 hours earlier
Feb 9 2021, 5:16 PM
hiraditya committed rW959dcfd8595d: [LLVM+CGO] Fix typo in schedule and reduced a talk to 30 minutes (authored by hiraditya).
[LLVM+CGO] Fix typo in schedule and reduced a talk to 30 minutes
Feb 9 2021, 6:53 AM

Feb 8 2021

hiraditya committed rWa696f5565735: [LLVM+CGO] Added abstract of Gokcen (authored by hiraditya).
[LLVM+CGO] Added abstract of Gokcen
Feb 8 2021, 9:53 PM

Feb 3 2021

hiraditya committed rW7fe2d2c14212: [LLVM CGO 2021] Table Border (authored by hiraditya).
[LLVM CGO 2021] Table Border
Feb 3 2021, 7:35 PM
hiraditya committed rW040ce07c4d97: [LLVM CGO 2021] Note to presenters (authored by hiraditya).
[LLVM CGO 2021] Note to presenters
Feb 3 2021, 7:05 PM
hiraditya committed rWa6ec64918b51: [LLVM CGO 2021] Adding link and affiliations (authored by hiraditya).
[LLVM CGO 2021] Adding link and affiliations
Feb 3 2021, 7:02 PM
hiraditya committed rWc7a9885a5b20: [LLVM CGO 2021] Fix formatting issues (authored by hiraditya).
[LLVM CGO 2021] Fix formatting issues
Feb 3 2021, 6:28 PM
hiraditya committed rWd369802a025c: [LLVM+CGO 2021] Add tentative schedule (authored by hiraditya).
[LLVM+CGO 2021] Add tentative schedule
Feb 3 2021, 6:18 PM

Jan 26 2021

hiraditya committed rW1486fd048407: Move LLVM-HPC to past events (authored by hiraditya).
Move LLVM-HPC to past events
Jan 26 2021, 3:33 PM

Jan 24 2021

hiraditya committed rW04533102f2ca: Adding the slide for Function entry instrumentation (authored by hiraditya).
Adding the slide for Function entry instrumentation
Jan 24 2021, 2:48 PM
hiraditya committed rWb3ca7ceed984: Added slides for LLVM-CGO 2020 (authored by hiraditya).
Added slides for LLVM-CGO 2020
Jan 24 2021, 9:57 AM

Jan 16 2021

hiraditya added inline comments to D94202: Preserve the lexical order for global variables during llvm-link merge.
Jan 16 2021, 10:01 AM · Restricted Project

Jan 14 2021

hiraditya added a reviewer for D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided: t.p.northover.
Jan 14 2021, 8:30 AM · Restricted Project

Jan 5 2021

hiraditya committed rW98514120753a: Added note about video recording (authored by hiraditya).
Added note about video recording
Jan 5 2021, 1:07 PM
hiraditya committed rW54461db6c77e: Extending the deadline by another 10 days (authored by hiraditya).
Extending the deadline by another 10 days
Jan 5 2021, 7:08 AM

Dec 18 2020

hiraditya committed rG1ab4db0f847f: [HotColdSplit] Reflect full cost of parameters in split penalty (authored by hiraditya).
[HotColdSplit] Reflect full cost of parameters in split penalty
Dec 18 2020, 5:07 PM
hiraditya closed D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.
Dec 18 2020, 5:06 PM · Restricted Project
hiraditya committed rW4eae6584ffb0: [LLVM CGO Workshop] Formatting fixes (authored by hiraditya).
[LLVM CGO Workshop] Formatting fixes
Dec 18 2020, 4:52 PM
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

I need to setup access token because github has changed commit policy recently.

Dec 18 2020, 12:57 PM · Restricted Project
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

It seems, I'm no longer having access to the llvm-project. Please commit this for me.

Dec 18 2020, 12:55 PM · Restricted Project
hiraditya updated the diff for D93559: Rename files with same (case insensitive) name.

rename

Dec 18 2020, 12:08 PM · Restricted Project
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

ok i'll rename this before commit.

Dec 18 2020, 12:07 PM · Restricted Project
hiraditya added a reviewer for D93559: Rename files with same (case insensitive) name: smeenai.
Dec 18 2020, 11:52 AM · Restricted Project
hiraditya updated the summary of D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 11:46 AM · Restricted Project
hiraditya requested review of D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 11:44 AM · Restricted Project
hiraditya updated the diff for D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

Rebase, fix a typo, change default hotcoldsplit-max-params=4

Dec 18 2020, 11:30 AM · Restricted Project
hiraditya added a reviewer for D91718: [LV] Legalize scalable VF hints: • zinob.
Dec 18 2020, 10:01 AM · Restricted Project

Dec 17 2020

hiraditya retitled D93518: [Not for review, only reference] Adding private method attribute by inferring from the program from [Not fore review, only reference] Adding private method attribute by inferring from the program to [Not for review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:57 PM
hiraditya retitled D93518: [Not for review, only reference] Adding private method attribute by inferring from the program from Adding private method attribute by inferring from the program to [Not fore review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:57 PM
hiraditya retitled D93519: [Not for review, only reference] Add objc_private_attr as function attribute from [Not fore review, only reference] Add objc_private_attr as function attribute to [Not for review, only reference] Add objc_private_attr as function attribute.
Dec 17 2020, 11:57 PM
hiraditya requested review of D93519: [Not for review, only reference] Add objc_private_attr as function attribute.
Dec 17 2020, 11:57 PM
hiraditya requested review of D93518: [Not for review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:56 PM
hiraditya edited reviewers for D93517: [Not for review, only reference] Adding attribute to private method for inlining, added: hiraditya; removed: aaron.ballman.
Dec 17 2020, 11:54 PM
hiraditya retitled D93517: [Not for review, only reference] Adding attribute to private method for inlining from Adding attribute to private method for inlining to [Not for review, only reference] Adding attribute to private method for inlining.
Dec 17 2020, 11:54 PM
hiraditya requested review of D93517: [Not for review, only reference] Adding attribute to private method for inlining.
Dec 17 2020, 11:54 PM
hiraditya updated subscribers of D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:34 PM
hiraditya updated the diff for D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:34 PM