Page MenuHomePhabricator

hiraditya (Aditya Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2014, 4:23 PM (306 w, 2 d)

Recent Activity

Today

hiraditya accepted D72873: [clang][xray] Add -fxray-ignore-loops option.

The test case is in another patch so LGTM.

Fri, Jan 17, 10:22 AM · Restricted Project
hiraditya added inline comments to D72873: [clang][xray] Add -fxray-ignore-loops option.
Fri, Jan 17, 10:22 AM · Restricted Project

Tue, Jan 7

hiraditya added a comment to D71733: [NFC][InlineCost] Factor cost modeling out of CallAnalyzer traversal..

Thanks for refactoring LGTM.

Tue, Jan 7, 11:41 AM · Restricted Project

Nov 8 2019

hiraditya added inline comments to D70014: ThinLTO : Import always_inline functions irrespective of the threshold.
Nov 8 2019, 9:58 AM · Restricted Project
hiraditya committed rG1d321434a202: [llvm-xray] Add AArch64 to llvm-xray extract (authored by hiraditya).
[llvm-xray] Add AArch64 to llvm-xray extract
Nov 8 2019, 6:44 AM
hiraditya closed D69967: [llvm-xray] Add AArch64 to llvm-xray extract.
Nov 8 2019, 6:44 AM · Restricted Project

Oct 31 2019

hiraditya updated the diff for D65376: Randomly outline code for cold regions.

Rebase

Oct 31 2019, 9:05 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Rebase against master.

Oct 31 2019, 4:35 PM · Restricted Project
hiraditya added a comment to D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper..

Thanks for rebasing the patch.

Oct 31 2019, 11:18 AM · Restricted Project

Oct 30 2019

hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 30 2019, 10:02 AM · Restricted Project

Oct 29 2019

hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 29 2019, 1:44 PM · Restricted Project
hiraditya added a comment to D32140: Global code motion of congruent computations.

GVNHoist was recently reverted maily due to big regressions:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20181001/591519.html

Oct 29 2019, 7:11 AM · Restricted Project
hiraditya added a comment to D32140: Global code motion of congruent computations.

Two high level comments after a quick glance

  1. gnv-sink & gvn-hoist are still disabled by default AFAIK and there are still a few known bugs that need to be addressed (https://bugs.llvm.org/buglist.cgi?quicksearch=gvn-hoist, https://bugs.llvm.org/buglist.cgi?quicksearch=gvn-sink). It would be good to guard this change by a new flag that's off by default, otherwise it might hinder work towards weeding out the existing bugs.
Oct 29 2019, 7:11 AM · Restricted Project
hiraditya added a comment to D32140: Global code motion of congruent computations.

Hi @hiraditya , thanks for your work. I want to test your patch on PowerPC, however current patch seems unable to be applied to current master branch.

Oct 29 2019, 7:02 AM · Restricted Project

Oct 28 2019

hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 28 2019, 9:49 PM · Restricted Project
hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 28 2019, 9:47 PM · Restricted Project
hiraditya updated the summary of D32140: Global code motion of congruent computations.
Oct 28 2019, 9:44 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Add testcase for sinking

Oct 28 2019, 5:30 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Remove unused variable and use function for updating local stats.

Oct 28 2019, 11:00 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Make MaxSinkChainLength a flag.

Oct 28 2019, 10:42 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Remove VNs already handled to reduce redundant lookups.

Oct 28 2019, 10:35 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Sink iteratively.

Oct 28 2019, 10:23 AM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Sink iteratively

Oct 28 2019, 6:54 AM · Restricted Project

Oct 27 2019

hiraditya removed reviewers for D32140: Global code motion of congruent computations: dberlin, chandlerc, efriedma.
Oct 27 2019, 12:53 PM · Restricted Project
hiraditya updated the diff for D32140: Global code motion of congruent computations.

Rebase against master and use profitability to reduce liveness

Oct 27 2019, 12:48 PM · Restricted Project

Oct 25 2019

hiraditya added a comment to D69257: Outline non returning functions unless a longjmp.

ping.

Oct 25 2019, 8:15 AM · Restricted Project

Oct 24 2019

hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.

Add check for both hot and cold prefixes.

Oct 24 2019, 3:02 PM · Restricted Project
hiraditya added a comment to D69384: Add unlikely attribute to outlined function.

btw, I had this patch in mind:

Oct 24 2019, 2:50 PM · Restricted Project
hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.
Oct 24 2019, 2:50 PM · Restricted Project
hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.

It is happening without my changes with -codegenprepare. So just keeping the testcase.

Oct 24 2019, 2:50 PM · Restricted Project
hiraditya updated the diff for D69384: Add unlikely attribute to outlined function.

test case

Oct 24 2019, 2:26 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.

Added testcase

Oct 24 2019, 2:16 PM · Restricted Project
hiraditya added a comment to D69384: Add unlikely attribute to outlined function.

Because my goal is to improve outlining without PGO (with static analysis), I'm wondering what would be the best place to put this other than HotColdSplitting.

Oct 24 2019, 2:14 PM · Restricted Project
hiraditya created D69384: Add unlikely attribute to outlined function.
Oct 24 2019, 7:02 AM · Restricted Project

Oct 21 2019

hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 2:41 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 2:41 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 10:37 AM · Restricted Project
hiraditya updated the diff for D65376: Randomly outline code for cold regions.

WIP

Oct 21 2019, 7:06 AM · Restricted Project
hiraditya created D69257: Outline non returning functions unless a longjmp.
Oct 21 2019, 6:43 AM · Restricted Project
hiraditya added a comment to D69257: Outline non returning functions unless a longjmp.

Will add test case soon.

Oct 21 2019, 6:43 AM · Restricted Project

Oct 18 2019

hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

rebase against latest changes

Oct 18 2019, 5:19 AM · Restricted Project

Oct 15 2019

hiraditya committed rL374966: Request commit access for nadavrot.
Request commit access for nadavrot
Oct 15 2019, 7:19 PM
hiraditya committed rG9d10b9d99b4d: CodeExtractor: NFC: Use Range based loop (authored by hiraditya).
CodeExtractor: NFC: Use Range based loop
Oct 15 2019, 6:52 PM
hiraditya closed D68924: CodeExtractor: NFC: Use Range based loop.
Oct 15 2019, 6:51 PM · Restricted Project
hiraditya committed rL374963: CodeExtractor: NFC: Use Range based loop.
CodeExtractor: NFC: Use Range based loop
Oct 15 2019, 6:51 PM
hiraditya committed rL374960: Request commit access for nadav.
Request commit access for nadav
Oct 15 2019, 5:54 PM

Oct 13 2019

hiraditya abandoned D66614: Add inline to uflow and underflow.
Oct 13 2019, 4:27 PM
hiraditya added a comment to D68924: CodeExtractor: NFC: Use Range based loop.

Good point, there's something about updating the users that copying maybe required. make_early_inc_range didn't work, I searched for uses cases of replaceUsesOfWith and I couldn't find any instance where we use 'users'.

Oct 13 2019, 12:27 PM · Restricted Project
hiraditya added a comment to D68924: CodeExtractor: NFC: Use Range based loop.

Tried the following, I get test failures and crashes.

Oct 13 2019, 10:28 AM · Restricted Project

Oct 12 2019

hiraditya created D68924: CodeExtractor: NFC: Use Range based loop.
Oct 12 2019, 6:58 PM · Restricted Project

Oct 7 2019

hiraditya accepted D68257: [Support] Add mathematical constants.

LGTM as the comments have been addressed.

Oct 7 2019, 2:45 PM · Restricted Project
hiraditya accepted D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Oct 7 2019, 2:43 PM · Restricted Project
hiraditya accepted D68399: Update lit infra to detect "MemoryWithOrigins' sanitizer build..
Oct 7 2019, 2:36 PM · Restricted Project
hiraditya added inline comments to D68559: [RISCV] Support fast calling convention.
Oct 7 2019, 2:30 PM · Restricted Project
hiraditya added inline comments to D68579: [HardwareLoops] Optimisation remarks.
Oct 7 2019, 2:06 PM · Restricted Project
hiraditya added a comment to D68579: [HardwareLoops] Optimisation remarks.

Nice!

Oct 7 2019, 12:38 PM · Restricted Project
hiraditya added inline comments to D68570: Unify the two CRC implementations.
Oct 7 2019, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
hiraditya added inline comments to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Oct 7 2019, 12:05 PM · Restricted Project, Restricted Project
hiraditya closed D22834: Added 'inline' attribute to basic_string's destructor.
Oct 7 2019, 6:47 AM · Restricted Project

Oct 4 2019

hiraditya committed rG50afaa9d34d6: Add a unittest to verify for assumption cache (authored by hiraditya).
Add a unittest to verify for assumption cache
Oct 4 2019, 4:37 PM
hiraditya committed rL373811: Add a unittest to verify for assumption cache.
Add a unittest to verify for assumption cache
Oct 4 2019, 4:37 PM
hiraditya closed D68095: Add a unittest to verify for assumption cache.
Oct 4 2019, 4:37 PM · Restricted Project
hiraditya abandoned D68345: Verify that assumption cache has valid entries..

Reviewed and committed: https://reviews.llvm.org/D67941

Oct 4 2019, 4:28 PM · Restricted Project
hiraditya added a comment to D68478: Invalidate assumption cache before outlining..

Reviewed here: https://reviews.llvm.org/D67941

Oct 4 2019, 4:22 PM · Restricted Project
hiraditya closed D67941: Invalidate assumption cache before outlining..

Closed in: https://reviews.llvm.org/rL373807

Oct 4 2019, 4:22 PM · Restricted Project
hiraditya committed rG6a2673605e50: Invalidate assumption cache before outlining. (authored by hiraditya).
Invalidate assumption cache before outlining.
Oct 4 2019, 3:46 PM
hiraditya committed rL373807: Invalidate assumption cache before outlining..
Invalidate assumption cache before outlining.
Oct 4 2019, 3:45 PM
hiraditya closed D68478: Invalidate assumption cache before outlining..
Oct 4 2019, 3:45 PM · Restricted Project
hiraditya created D68478: Invalidate assumption cache before outlining..
Oct 4 2019, 12:12 PM · Restricted Project

Oct 2 2019

hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Oct 2 2019, 2:13 PM · Restricted Project
hiraditya updated the diff for D68345: Verify that assumption cache has valid entries..

remove XFAIL now that fix had landed

Oct 2 2019, 10:37 AM · Restricted Project
hiraditya added a reviewer for D68345: Verify that assumption cache has valid entries.: fhahn.
Oct 2 2019, 10:36 AM · Restricted Project
hiraditya committed rG0cacf136fcbc: Fix: Actually erase remove the elements from AssumeHandles (authored by hiraditya).
Fix: Actually erase remove the elements from AssumeHandles
Oct 2 2019, 10:35 AM
hiraditya committed rL373494: Fix: Actually erase remove the elements from AssumeHandles.
Fix: Actually erase remove the elements from AssumeHandles
Oct 2 2019, 10:33 AM
hiraditya closed D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 2 2019, 10:33 AM · Restricted Project
hiraditya removed a child revision for D68345: Verify that assumption cache has valid entries.: D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 2 2019, 10:18 AM · Restricted Project
hiraditya removed a parent revision for D68318: Fix: Actually erase remove the elements from AssumeHandles: D68345: Verify that assumption cache has valid entries..
Oct 2 2019, 10:18 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

Splitting the verifier into a separate diff: https://reviews.llvm.org/D68345

Oct 2 2019, 10:15 AM · Restricted Project
hiraditya added a parent revision for D68318: Fix: Actually erase remove the elements from AssumeHandles: D68345: Verify that assumption cache has valid entries..
Oct 2 2019, 10:15 AM · Restricted Project
hiraditya added a child revision for D68345: Verify that assumption cache has valid entries.: D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 2 2019, 10:15 AM · Restricted Project
hiraditya added inline comments to D68345: Verify that assumption cache has valid entries..
Oct 2 2019, 10:09 AM · Restricted Project
hiraditya created D68345: Verify that assumption cache has valid entries..
Oct 2 2019, 10:09 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

It depends on the verifier function (CodeExtractor::verifyAssumptionCache) from D67941 to fail with the test case in: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll

Oct 2 2019, 9:37 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.

Oct 2 2019, 8:39 AM · Restricted Project
hiraditya committed rGc4a7b912c26e: [CodeExtractor] NFC: Refactor sanity checks into isEligible (authored by hiraditya).
[CodeExtractor] NFC: Refactor sanity checks into isEligible
Oct 2 2019, 8:36 AM
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

passed ninja check-all

Oct 2 2019, 8:36 AM · Restricted Project
hiraditya updated the summary of D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 2 2019, 8:36 AM · Restricted Project
hiraditya added reviewers for D68318: Fix: Actually erase remove the elements from AssumeHandles: fhahn, tejohnson.
Oct 2 2019, 8:36 AM · Restricted Project
hiraditya committed rL373479: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
[CodeExtractor] NFC: Refactor sanity checks into isEligible
Oct 2 2019, 8:35 AM
hiraditya closed D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
Oct 2 2019, 8:34 AM · Restricted Project
hiraditya updated the diff for D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.

addressed comments

Oct 2 2019, 8:27 AM · Restricted Project
hiraditya added a comment to D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.

ninja check passed

Oct 2 2019, 6:13 AM · Restricted Project
hiraditya added a reviewer for D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible: tejohnson.
Oct 2 2019, 5:57 AM · Restricted Project
hiraditya created D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
Oct 2 2019, 5:57 AM · Restricted Project
hiraditya committed rGb1fe6c90e66b: NFC: directly return when CommonExitBlock != Succ (authored by hiraditya).
NFC: directly return when CommonExitBlock != Succ
Oct 2 2019, 5:18 AM
hiraditya committed rL373456: NFC: directly return when CommonExitBlock != Succ.
NFC: directly return when CommonExitBlock != Succ
Oct 2 2019, 5:13 AM
hiraditya closed D68330: NFC: directly return when CommonExitBlock != Succ.
Oct 2 2019, 5:13 AM · Restricted Project
hiraditya created D68330: NFC: directly return when CommonExitBlock != Succ.
Oct 2 2019, 5:13 AM · Restricted Project

Oct 1 2019

hiraditya created D68318: Fix: Actually erase remove the elements from AssumeHandles.
Oct 1 2019, 9:13 PM · Restricted Project
hiraditya accepted D68159: [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary.
Oct 1 2019, 5:56 PM · Restricted Project