Do we have an example of real world workload where this pattern was found?

In D104060#2815509, @davidxl wrote:

Thinking about MIP's use case a little, it seems that it actually matches
what xray does. Xray has very low runtime overhead and can be turned on
always : xra https://llvm.org/docs/XRay.htmly. Have you compare with xray
and consider using that?

In D97308#2616596, @Quuxplusone wrote:

In D97308#2615920, @hiraditya wrote:

In D97308#2611794, @Quuxplusone wrote:

• void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

No, I meant this version: https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L6270

In D97308#2611794, @Quuxplusone wrote:

I did a grep for void __throw and verified that every other instance is attributed, except for:

• __throw_if_valueless in <variant>: this is good and intentional
• void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

I need to setup access token because github has changed commit policy recently.

It seems, I'm no longer having access to the llvm-project. Please commit this for me.

rename

ok i'll rename this before commit.

Rebase, fix a typo, change default hotcoldsplit-max-params=4

In D88460#2458205, @anjankgk wrote:

In D88460#2342937, @hiraditya wrote:

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Thanks for working on this.

Thank you for the feedback @hiraditya! I have tested the latest patch at various options (O2, O3, LTO and PGO) against the SPEC benchmarks as well as run the lnt tests and bootstrap tests successfully. If you were concerned about any other specific testsuite, pls let me know.

the following failures reported by buildbot are unrelated to this change:

remove consume

Rebase

Maybe ask in Discord to get reviewers?

LGTM, an example of a gep with inbounds wouldbe nice. there are some test cases like: CodeGen/2009-02-13-zerosize-union-field.c, CodeGen/2010-07-14-ref-off-end.c etc from where we can take a reduced example for the doc.

@vsk Let me know if you dont have bandwidth to land. I can land it otherwise.

Please fix clang-format issues.

Instcombine also expands small (16 bytes, hardcoded) memcpy's

or if you prefer, I can land it in its current state.

Good to have these tests. I'd wait for the previous patches in the stack to be reviewed.

@rjf do you have numbers on Firefox. Let us know.

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Any plans to merge this patch?

nit: If FIXME's are mostly future works, then please replace them with TODOs.

Is the test failure related to this patch?

Self approving because this is NFC change to outline function definitions.

rebase

then it may be possible to construct a synthetic/fake profile as a pre-processing step

Rebase

Addressed fhahn's comments

please run clang-format