Page MenuHomePhabricator

hiraditya (Aditya Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2014, 4:23 PM (293 w, 5 d)

Recent Activity

Today

hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Mon, Oct 21, 2:41 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Mon, Oct 21, 2:41 PM · Restricted Project
hiraditya updated the diff for D69257: Outline non returning functions unless a longjmp.
Mon, Oct 21, 10:37 AM · Restricted Project
hiraditya updated the diff for D65376: Randomly outline code for cold regions.

WIP

Mon, Oct 21, 7:06 AM · Restricted Project
hiraditya created D69257: Outline non returning functions unless a longjmp.
Mon, Oct 21, 6:43 AM · Restricted Project
hiraditya added a comment to D69257: Outline non returning functions unless a longjmp.

Will add test case soon.

Mon, Oct 21, 6:43 AM · Restricted Project

Fri, Oct 18

hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

rebase against latest changes

Fri, Oct 18, 5:19 AM · Restricted Project

Tue, Oct 15

hiraditya committed rL374966: Request commit access for nadavrot.
Request commit access for nadavrot
Tue, Oct 15, 7:19 PM
hiraditya committed rG9d10b9d99b4d: CodeExtractor: NFC: Use Range based loop (authored by hiraditya).
CodeExtractor: NFC: Use Range based loop
Tue, Oct 15, 6:52 PM
hiraditya closed D68924: CodeExtractor: NFC: Use Range based loop.
Tue, Oct 15, 6:51 PM · Restricted Project
hiraditya committed rL374963: CodeExtractor: NFC: Use Range based loop.
CodeExtractor: NFC: Use Range based loop
Tue, Oct 15, 6:51 PM
hiraditya committed rL374960: Request commit access for nadav.
Request commit access for nadav
Tue, Oct 15, 5:54 PM

Sun, Oct 13

hiraditya abandoned D66614: Add inline to uflow and underflow.
Sun, Oct 13, 4:27 PM
hiraditya added a comment to D68924: CodeExtractor: NFC: Use Range based loop.

Good point, there's something about updating the users that copying maybe required. make_early_inc_range didn't work, I searched for uses cases of replaceUsesOfWith and I couldn't find any instance where we use 'users'.

Sun, Oct 13, 12:27 PM · Restricted Project
hiraditya added a comment to D68924: CodeExtractor: NFC: Use Range based loop.

Tried the following, I get test failures and crashes.

Sun, Oct 13, 10:28 AM · Restricted Project

Sat, Oct 12

hiraditya created D68924: CodeExtractor: NFC: Use Range based loop.
Sat, Oct 12, 6:58 PM · Restricted Project

Mon, Oct 7

hiraditya accepted D68257: [Support] Add mathematical constants.

LGTM as the comments have been addressed.

Mon, Oct 7, 2:45 PM · Restricted Project
hiraditya accepted D68285: [AMDGPU] Use math constants defined in MathExtras (NFC).
Mon, Oct 7, 2:43 PM · Restricted Project
hiraditya accepted D68399: Update lit infra to detect "MemoryWithOrigins' sanitizer build..
Mon, Oct 7, 2:36 PM · Restricted Project
hiraditya added inline comments to D68559: [RISCV] Support fast calling convention.
Mon, Oct 7, 2:30 PM · Restricted Project
hiraditya added inline comments to D68579: [HardwareLoops] Optimisation remarks.
Mon, Oct 7, 2:06 PM · Restricted Project
hiraditya added a comment to D68579: [HardwareLoops] Optimisation remarks.

Nice!

Mon, Oct 7, 12:38 PM · Restricted Project
hiraditya added inline comments to D68570: Unify the two CRC implementations.
Mon, Oct 7, 12:16 PM · Restricted Project, Restricted Project, Restricted Project
hiraditya added inline comments to D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps.
Mon, Oct 7, 12:05 PM · Restricted Project, Restricted Project
hiraditya closed D22834: Added 'inline' attribute to basic_string's destructor.
Mon, Oct 7, 6:47 AM · Restricted Project

Fri, Oct 4

hiraditya committed rG50afaa9d34d6: Add a unittest to verify for assumption cache (authored by hiraditya).
Add a unittest to verify for assumption cache
Fri, Oct 4, 4:37 PM
hiraditya committed rL373811: Add a unittest to verify for assumption cache.
Add a unittest to verify for assumption cache
Fri, Oct 4, 4:37 PM
hiraditya closed D68095: Add a unittest to verify for assumption cache.
Fri, Oct 4, 4:37 PM · Restricted Project
hiraditya abandoned D68345: Verify that assumption cache has valid entries..

Reviewed and committed: https://reviews.llvm.org/D67941

Fri, Oct 4, 4:28 PM · Restricted Project
hiraditya added a comment to D68478: Invalidate assumption cache before outlining..

Reviewed here: https://reviews.llvm.org/D67941

Fri, Oct 4, 4:22 PM · Restricted Project
hiraditya closed D67941: Invalidate assumption cache before outlining..

Closed in: https://reviews.llvm.org/rL373807

Fri, Oct 4, 4:22 PM · Restricted Project
hiraditya committed rG6a2673605e50: Invalidate assumption cache before outlining. (authored by hiraditya).
Invalidate assumption cache before outlining.
Fri, Oct 4, 3:46 PM
hiraditya committed rL373807: Invalidate assumption cache before outlining..
Invalidate assumption cache before outlining.
Fri, Oct 4, 3:45 PM
hiraditya closed D68478: Invalidate assumption cache before outlining..
Fri, Oct 4, 3:45 PM · Restricted Project
hiraditya created D68478: Invalidate assumption cache before outlining..
Fri, Oct 4, 12:12 PM · Restricted Project

Wed, Oct 2

hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Wed, Oct 2, 2:13 PM · Restricted Project
hiraditya updated the diff for D68345: Verify that assumption cache has valid entries..

remove XFAIL now that fix had landed

Wed, Oct 2, 10:37 AM · Restricted Project
hiraditya added a reviewer for D68345: Verify that assumption cache has valid entries.: fhahn.
Wed, Oct 2, 10:36 AM · Restricted Project
hiraditya committed rG0cacf136fcbc: Fix: Actually erase remove the elements from AssumeHandles (authored by hiraditya).
Fix: Actually erase remove the elements from AssumeHandles
Wed, Oct 2, 10:35 AM
hiraditya committed rL373494: Fix: Actually erase remove the elements from AssumeHandles.
Fix: Actually erase remove the elements from AssumeHandles
Wed, Oct 2, 10:33 AM
hiraditya closed D68318: Fix: Actually erase remove the elements from AssumeHandles.
Wed, Oct 2, 10:33 AM · Restricted Project
hiraditya removed a child revision for D68345: Verify that assumption cache has valid entries.: D68318: Fix: Actually erase remove the elements from AssumeHandles.
Wed, Oct 2, 10:18 AM · Restricted Project
hiraditya removed a parent revision for D68318: Fix: Actually erase remove the elements from AssumeHandles: D68345: Verify that assumption cache has valid entries..
Wed, Oct 2, 10:18 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

Splitting the verifier into a separate diff: https://reviews.llvm.org/D68345

Wed, Oct 2, 10:15 AM · Restricted Project
hiraditya added a parent revision for D68318: Fix: Actually erase remove the elements from AssumeHandles: D68345: Verify that assumption cache has valid entries..
Wed, Oct 2, 10:15 AM · Restricted Project
hiraditya added a child revision for D68345: Verify that assumption cache has valid entries.: D68318: Fix: Actually erase remove the elements from AssumeHandles.
Wed, Oct 2, 10:15 AM · Restricted Project
hiraditya added inline comments to D68345: Verify that assumption cache has valid entries..
Wed, Oct 2, 10:09 AM · Restricted Project
hiraditya created D68345: Verify that assumption cache has valid entries..
Wed, Oct 2, 10:09 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

It depends on the verifier function (CodeExtractor::verifyAssumptionCache) from D67941 to fail with the test case in: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll

Wed, Oct 2, 9:37 AM · Restricted Project
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.

Wed, Oct 2, 8:39 AM · Restricted Project
hiraditya committed rGc4a7b912c26e: [CodeExtractor] NFC: Refactor sanity checks into isEligible (authored by hiraditya).
[CodeExtractor] NFC: Refactor sanity checks into isEligible
Wed, Oct 2, 8:36 AM
hiraditya added a comment to D68318: Fix: Actually erase remove the elements from AssumeHandles.

passed ninja check-all

Wed, Oct 2, 8:36 AM · Restricted Project
hiraditya updated the summary of D68318: Fix: Actually erase remove the elements from AssumeHandles.
Wed, Oct 2, 8:36 AM · Restricted Project
hiraditya added reviewers for D68318: Fix: Actually erase remove the elements from AssumeHandles: fhahn, tejohnson.
Wed, Oct 2, 8:36 AM · Restricted Project
hiraditya committed rL373479: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
[CodeExtractor] NFC: Refactor sanity checks into isEligible
Wed, Oct 2, 8:35 AM
hiraditya closed D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
Wed, Oct 2, 8:34 AM · Restricted Project
hiraditya updated the diff for D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.

addressed comments

Wed, Oct 2, 8:27 AM · Restricted Project
hiraditya added a comment to D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.

ninja check passed

Wed, Oct 2, 6:13 AM · Restricted Project
hiraditya added a reviewer for D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible: tejohnson.
Wed, Oct 2, 5:57 AM · Restricted Project
hiraditya created D68331: [CodeExtractor] NFC: Refactor sanity checks into isEligible.
Wed, Oct 2, 5:57 AM · Restricted Project
hiraditya committed rGb1fe6c90e66b: NFC: directly return when CommonExitBlock != Succ (authored by hiraditya).
NFC: directly return when CommonExitBlock != Succ
Wed, Oct 2, 5:18 AM
hiraditya committed rL373456: NFC: directly return when CommonExitBlock != Succ.
NFC: directly return when CommonExitBlock != Succ
Wed, Oct 2, 5:13 AM
hiraditya closed D68330: NFC: directly return when CommonExitBlock != Succ.
Wed, Oct 2, 5:13 AM · Restricted Project
hiraditya created D68330: NFC: directly return when CommonExitBlock != Succ.
Wed, Oct 2, 5:13 AM · Restricted Project

Tue, Oct 1

hiraditya created D68318: Fix: Actually erase remove the elements from AssumeHandles.
Tue, Oct 1, 9:13 PM · Restricted Project
hiraditya accepted D68159: [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary.
Tue, Oct 1, 5:56 PM · Restricted Project
hiraditya added a comment to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Essentially did this:

diff --git a/llvm/lib/Transforms/Utils/CodeExtractor.cpp b/llvm/lib/Transforms/Utils/CodeExtractor.cpp
index 952263c0b1f..49fa07a3648 100644
--- a/llvm/lib/Transforms/Utils/CodeExtractor.cpp
+++ b/llvm/lib/Transforms/Utils/CodeExtractor.cpp
@@ -1336,13 +1336,13 @@ void CodeExtractor::calculateNewCallTerminatorWeights(
Tue, Oct 1, 3:40 PM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Tue, Oct 1, 3:27 PM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Tue, Oct 1, 3:08 PM · Restricted Project
hiraditya added inline comments to D68159: [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary.
Tue, Oct 1, 2:42 PM · Restricted Project
hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Tue, Oct 1, 2:36 PM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..
Tue, Oct 1, 2:36 PM · Restricted Project
hiraditya added a comment to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Do we have further feedback for this patch?

Tue, Oct 1, 1:49 PM · Restricted Project
hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Tue, Oct 1, 1:41 PM · Restricted Project
hiraditya added a comment to D68154: [Dominators][CodeGen] Fix MachineDominatorTree preservation in PHIElimination.

LGTM, thanks for committing.

Tue, Oct 1, 11:42 AM · Restricted Project
hiraditya added inline comments to D67941: Invalidate assumption cache before outlining..
Tue, Oct 1, 7:01 AM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..

Fixed a bug in assumption cache where the AssumeVH wasn't getting cleared.

Tue, Oct 1, 6:56 AM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..
Tue, Oct 1, 6:08 AM · Restricted Project
hiraditya updated the diff for D68095: Add a unittest to verify for assumption cache.
Tue, Oct 1, 5:24 AM · Restricted Project
hiraditya updated the diff for D68095: Add a unittest to verify for assumption cache.
Tue, Oct 1, 5:14 AM · Restricted Project

Mon, Sep 30

hiraditya committed rG07286cb384c4: [OCaml] Handle nullptr in Llvm.global_initializer (authored by hiraditya).
[OCaml] Handle nullptr in Llvm.global_initializer
Mon, Sep 30, 8:44 PM
hiraditya committed rL373299: [OCaml] Handle nullptr in Llvm.global_initializer.
[OCaml] Handle nullptr in Llvm.global_initializer
Mon, Sep 30, 8:43 PM
hiraditya closed D65195: [OCaml] Handle nullptr in Llvm.global_initializer.
Mon, Sep 30, 8:43 PM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Mon, Sep 30, 6:09 PM · Restricted Project
hiraditya updated the diff for D67941: Invalidate assumption cache before outlining..

added flag to the testcase.

Mon, Sep 30, 2:50 PM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Addressed comments from @vsk

  • Move input parameter validation to isEligible().

This now requires recomputing inputs in extractCodeRegion because PHI nodes, and return blocks are split. The computation cost of input is same as before because previously the input parameter would be computed on the client side (caller of extractCodeRegion) and introduce extra overhead to be taken care of.

Mon, Sep 30, 1:59 PM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Mon, Sep 30, 1:19 PM · Restricted Project
hiraditya updated the diff for D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.

Comments from @compnerd

Mon, Sep 30, 9:37 AM · Restricted Project
hiraditya accepted D68228: [bugpoint] Update runPasses to take ArrayRef instead of a pointer (NFC).

LGTM, makes it easier to read as well!

Mon, Sep 30, 9:00 AM · Restricted Project
hiraditya added inline comments to D68192: Fix PR40710: Outlined Function has token parameter but isn't an intrinsic.
Mon, Sep 30, 8:56 AM · Restricted Project

Sun, Sep 29

hiraditya updated the diff for D52896: MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences.

fix clonetype tests

Sun, Sep 29, 11:13 PM · Restricted Project
hiraditya updated the diff for D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary.

port to llvm bitcode version 8

Sun, Sep 29, 11:13 PM · Restricted Project
hiraditya added a child revision for D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage: D53254: [Merge SImilar Function ThinLTO 5/n] Set up similar function to be imported.
Sun, Sep 29, 10:40 PM · Restricted Project
hiraditya added a parent revision for D53254: [Merge SImilar Function ThinLTO 5/n] Set up similar function to be imported: D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage.
Sun, Sep 29, 10:40 PM · Restricted Project
hiraditya added a parent revision for D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage: D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary.
Sun, Sep 29, 10:38 PM · Restricted Project
hiraditya added a child revision for D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout: D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary.
Sun, Sep 29, 10:38 PM · Restricted Project
hiraditya added a parent revision for D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary: D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout.
Sun, Sep 29, 10:38 PM · Restricted Project
hiraditya added a child revision for D52966: [Merge SImilar Function ThinLTO 3/n] Add hash code to function summary: D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage.
Sun, Sep 29, 10:38 PM · Restricted Project
hiraditya added a parent revision for D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout: D52896: MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences.
Sun, Sep 29, 10:36 PM · Restricted Project
hiraditya added a child revision for D52896: MergeSimilarFunctions 1/n: a code size pass to merge functions with small differences: D52898: [Porting MergeSimilarFunctions 2/n] Changes to DataLayout.
Sun, Sep 29, 10:36 PM · Restricted Project