- User Since
- Mar 5 2014, 4:23 PM (293 w, 5 d)
Will add test case soon.
Fri, Oct 18
rebase against latest changes
Tue, Oct 15
Sun, Oct 13
Good point, there's something about updating the users that copying maybe required. make_early_inc_range didn't work, I searched for uses cases of replaceUsesOfWith and I couldn't find any instance where we use 'users'.
Tried the following, I get test failures and crashes.
Sat, Oct 12
Mon, Oct 7
LGTM as the comments have been addressed.
Fri, Oct 4
Reviewed and committed: https://reviews.llvm.org/D67941
Reviewed here: https://reviews.llvm.org/D67941
Closed in: https://reviews.llvm.org/rL373807
Wed, Oct 2
remove XFAIL now that fix had landed
Splitting the verifier into a separate diff: https://reviews.llvm.org/D68345
It depends on the verifier function (CodeExtractor::verifyAssumptionCache) from D67941 to fail with the test case in: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll
Relevant test case: llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll is already in trunk.
passed ninja check-all
ninja check passed
Tue, Oct 1
Essentially did this:
diff --git a/llvm/lib/Transforms/Utils/CodeExtractor.cpp b/llvm/lib/Transforms/Utils/CodeExtractor.cpp index 952263c0b1f..49fa07a3648 100644 --- a/llvm/lib/Transforms/Utils/CodeExtractor.cpp +++ b/llvm/lib/Transforms/Utils/CodeExtractor.cpp @@ -1336,13 +1336,13 @@ void CodeExtractor::calculateNewCallTerminatorWeights(
Do we have further feedback for this patch?
LGTM, thanks for committing.
Fixed a bug in assumption cache where the AssumeVH wasn't getting cleared.
Mon, Sep 30
added flag to the testcase.
Addressed comments from @vsk
- Move input parameter validation to isEligible().
This now requires recomputing inputs in extractCodeRegion because PHI nodes, and return blocks are split. The computation cost of input is same as before because previously the input parameter would be computed on the client side (caller of extractCodeRegion) and introduce extra overhead to be taken care of.
Comments from @compnerd
LGTM, makes it easier to read as well!
Sun, Sep 29
fix clonetype tests
port to llvm bitcode version 8