Differential D78441

Delete NaCl support
Needs ReviewPublic
Actions

Authored by MaskRay on Apr 18 2020, 7:31 PM.

Details

Reviewers

dschuff

Summary

See https://developer.chrome.com/native-client/migration

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

MaskRay created this revision.Apr 18 2020, 7:31 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2020, 7:31 PM

Herald added subscribers: cfe-commits, jfb, arphaman and 8 others. · View Herald Transcript

Harbormaster failed remote builds in B53878: Diff 258570!Apr 18 2020, 7:56 PM

I think someone from the current NaCl team should OK this change.

jfb edited the summary of this revision. (Show Details)Apr 19 2020, 8:51 PM

jfb retitled this revision from Delete NaCl supportSee https://developer.chrome.com/native-client/migration to Delete NaCl support.

@jfb thanks for the heads-up.
I replied on the mailing list thread.

nickdesaulniers added a subscriber: nickdesaulniers.Apr 20 2020, 10:40 PM

MaskRay mentioned this in D95375: [MC] Adding MCContext parameter to MCAsmBackend::relaxInstruction.Jan 25 2021, 10:12 AM

@dschuff Is NaCL dead in 2022 ? :)

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 23 2022, 3:48 PM

Herald added subscribers: llvm-commits, StephenFan, pengfei. · View Herald Transcript

Sorry, no :)

In D78441#4067440, @dschuff wrote:

Sorry, no :)

Is there a timeline for the removal?

Revision Contents
Changeset List

Path

Size

clang/

include/

clang/

Basic/

10 lines

4 lines

1 line

lib/

AST/

ASTContext.cpp

2 lines

Basic/

CMakeLists.txt

2 lines

Targets.cpp

23 lines

Targets/

3 lines

51 lines

CodeGen/

85 lines

Driver/

CMakeLists.txt

1 line

Driver.cpp

4 lines

ToolChains/

Arch/

2 lines

Frontend/

2 lines

test/

CodeGen/

6 lines

long_double_fp128.cpp

3 lines

malign-double-x86-nacl.c

pr18235.c

target-data.c

20 lines

x86_64-arguments-nacl.c

x86_64-longdouble.c

3 lines

CodeGenCXX/

member-function-pointers.cpp

2 lines

static-init-pnacl.cpp

x86_64-arguments-nacl-x32.cpp

Driver/

arm-alignment.c

6 lines

le32-toolchain.c

le32-unknown-nacl.cpp

le64-unknown-unknown.cpp

mipsel-nacl-defines.cpp

nacl-direct.c

unsupported-target-arch.c

4 lines

x86_64-nacl-defines.cpp

Frontend/

x86_64-nacl-types.cpp

Headers/

stdarg.cpp

2 lines

llvm/

include/

llvm/

ADT/

Triple.h

6 lines

lib/

Support/

Triple.cpp

3 lines

Target/

ARM/

1 line

1 line

9 lines

2 lines

MCTargetDesc/

ARMMCTargetDesc.cpp

6 lines

Mips/

MCTargetDesc/

CMakeLists.txt

1 line

MipsMCNaCl.h

MipsMCTargetDesc.cpp

11 lines

MipsNaClELFStreamer.cpp

MipsAsmPrinter.h

2 lines

MipsAsmPrinter.cpp

31 lines

MipsBranchExpansion.cpp

25 lines

MipsCallingConv.td

10 lines

MipsDelaySlotFiller.cpp

12 lines

16 lines

1 line

7 lines

2 lines

X86/

5 lines

2 lines

4 lines

9 lines

2 lines

9 lines

7 lines

test/

CodeGen/

ARM/

fast-isel-align.ll

3 lines

struct_byval.ll

14 lines

trap.ll

18 lines

varargs-spill-stack-align-nacl.ll

Generic/

Mips/

12 lines

11 lines

35 lines

nacl-reserved-regs.ll

X86/

11 lines

1 line

2 lines

1 line

1 line

1 line

1 line

1 line

8 lines

x86-64-stack-and-frame-ptr.ll

6 lines

MC/

ARM/

arm_instructions.s

6 lines

Mips/

nacl-mask.s

X86/

AlignedBundling/

labeloffset.s

rodata-section.s

unittests/

ADT/

TripleTest.cpp

4 lines

utils/

gn/

secondary/

clang/

lib/

Basic/

BUILD.gn

2 lines

Driver/

BUILD.gn

1 line

llvm/

lib/

Target/

Mips/

MCTargetDesc/

BUILD.gn

1 line

Diff 258570

View Options

clang/include/clang/Basic/BuiltinsLe64.def

View Options

clang/include/clang/Basic/TargetBuiltins.h

View Options

clang/include/clang/Basic/TargetInfo.h

View Options

clang/include/clang/module.modulemap

View Options

clang/lib/AST/ASTContext.cpp

View Options

clang/lib/Basic/CMakeLists.txt

View Options

clang/lib/Basic/Targets.cpp

View Options

clang/lib/Basic/Targets/ARM.cpp

View Options

clang/lib/Basic/Targets/Le64.h

View Options

clang/lib/Basic/Targets/Le64.cpp

View Options

clang/lib/Basic/Targets/OSTargets.h

View Options

clang/lib/Basic/Targets/PNaCl.h

View Options

clang/lib/Basic/Targets/PNaCl.cpp

View Options

clang/lib/CodeGen/TargetInfo.cpp

View Options

clang/lib/Driver/CMakeLists.txt

View Options

clang/lib/Driver/Driver.cpp

View Options

clang/lib/Driver/ToolChains/Arch/ARM.cpp

View Options

clang/lib/Driver/ToolChains/NaCl.h

View Options

clang/lib/Driver/ToolChains/NaCl.cpp

View Options

clang/lib/Frontend/InitHeaderSearch.cpp

View Options

clang/test/CodeGen/arm-aapcs-vfp.c

View Options

clang/test/CodeGen/le32-arguments.c

View Options

clang/test/CodeGen/le32-libcall-pow.c

View Options

clang/test/CodeGen/le32-regparm.c

View Options

clang/test/CodeGen/le32-vaarg.c

View Options

clang/test/CodeGen/long_double_fp128.cpp

View Options

clang/test/CodeGen/malign-double-x86-nacl.c

View Options

clang/test/CodeGen/pr18235.c

View Options

clang/test/CodeGen/target-data.c

View Options

clang/test/CodeGen/x86_64-arguments-nacl.c

View Options

clang/test/CodeGen/x86_64-longdouble.c

View Options

clang/test/CodeGenCXX/member-function-pointers.cpp

View Options

clang/test/CodeGenCXX/static-init-pnacl.cpp

View Options

clang/test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp

View Options

clang/test/Driver/arm-alignment.c

View Options

clang/test/Driver/le32-toolchain.c

View Options

clang/test/Driver/le32-unknown-nacl.cpp

View Options

clang/test/Driver/le64-unknown-unknown.cpp

View Options

clang/test/Driver/mipsel-nacl-defines.cpp

View Options

clang/test/Driver/nacl-direct.c

View Options

clang/test/Driver/unsupported-target-arch.c

View Options

clang/test/Driver/x86_64-nacl-defines.cpp

View Options

clang/test/Frontend/x86_64-nacl-types.cpp

View Options

clang/test/Headers/stdarg.cpp

View Options

llvm/include/llvm/ADT/Triple.h

View Options

llvm/lib/Support/Triple.cpp

View Options

llvm/lib/Target/ARM/ARMPredicates.td

View Options

llvm/lib/Target/ARM/ARMSubtarget.h

View Options

llvm/lib/Target/ARM/ARMSubtarget.cpp

View Options

llvm/lib/Target/ARM/ARMTargetMachine.cpp

View Options

llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp

View Options

llvm/lib/Target/Mips/MCTargetDesc/CMakeLists.txt

View Options

llvm/lib/Target/Mips/MCTargetDesc/MipsMCNaCl.h

View Options

llvm/lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp

View Options

llvm/lib/Target/Mips/MCTargetDesc/MipsNaClELFStreamer.cpp

View Options

llvm/lib/Target/Mips/MipsAsmPrinter.h

View Options

llvm/lib/Target/Mips/MipsAsmPrinter.cpp

View Options

llvm/lib/Target/Mips/MipsBranchExpansion.cpp

View Options

llvm/lib/Target/Mips/MipsCallingConv.td

View Options

llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp

View Options

llvm/lib/Target/Mips/MipsInstrFPU.td

View Options

llvm/lib/Target/Mips/MipsInstrInfo.td

View Options

llvm/lib/Target/Mips/MipsRegisterInfo.cpp

View Options

llvm/lib/Target/Mips/MipsSubtarget.h

View Options

llvm/lib/Target/X86/X86ExpandPseudo.cpp

View Options

llvm/lib/Target/X86/X86FrameLowering.cpp

View Options

llvm/lib/Target/X86/X86ISelDAGToDAG.cpp

View Options

llvm/lib/Target/X86/X86ISelLowering.cpp

View Options

llvm/lib/Target/X86/X86InstrInfo.td

View Options

llvm/lib/Target/X86/X86Subtarget.h

View Options

llvm/lib/Target/X86/X86TargetMachine.cpp

View Options

llvm/test/CodeGen/ARM/fast-isel-align.ll

View Options

llvm/test/CodeGen/ARM/struct_byval.ll

View Options

llvm/test/CodeGen/ARM/trap.ll

View Options

llvm/test/CodeGen/ARM/varargs-spill-stack-align-nacl.ll

View Options

llvm/test/CodeGen/Generic/no-target.ll

View Options

llvm/test/CodeGen/Mips/fastcc.ll

View Options

llvm/test/CodeGen/Mips/fp-indexed-ls.ll

View Options

llvm/test/CodeGen/Mips/longbranch.ll

View Options

llvm/test/CodeGen/Mips/nacl-align.ll

View Options

llvm/test/CodeGen/Mips/nacl-branch-delay.ll

View Options

llvm/test/CodeGen/Mips/nacl-reserved-regs.ll

View Options

llvm/test/CodeGen/X86/constructor.ll

View Options

llvm/test/CodeGen/X86/fast-isel-x32.ll

View Options

llvm/test/CodeGen/X86/frameaddr.ll

View Options

llvm/test/CodeGen/X86/lea-2.ll

View Options

llvm/test/CodeGen/X86/lea-3.ll

View Options

llvm/test/CodeGen/X86/lea-4.ll

View Options

llvm/test/CodeGen/X86/lea-5.ll

View Options

llvm/test/CodeGen/X86/lea.ll

View Options

llvm/test/CodeGen/X86/x86-64-baseptr.ll

View Options

llvm/test/CodeGen/X86/x86-64-stack-and-frame-ptr.ll

View Options

llvm/test/MC/ARM/arm_instructions.s

View Options

llvm/test/MC/Mips/nacl-mask.s

View Options

llvm/test/MC/X86/AlignedBundling/labeloffset.s

View Options

llvm/test/MC/X86/AlignedBundling/rodata-section.s

View Options

llvm/unittests/ADT/TripleTest.cpp

View Options

llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn

View Options

llvm/utils/gn/secondary/clang/lib/Driver/BUILD.gn

View Options

llvm/utils/gn/secondary/llvm/lib/Target/Mips/MCTargetDesc/BUILD.gn

Delete NaCl supportNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 258570

clang/include/clang/Basic/BuiltinsLe64.def

clang/include/clang/Basic/TargetBuiltins.h

clang/include/clang/Basic/TargetInfo.h

clang/include/clang/module.modulemap

clang/lib/AST/ASTContext.cpp

clang/lib/Basic/CMakeLists.txt

clang/lib/Basic/Targets.cpp

clang/lib/Basic/Targets/ARM.cpp

clang/lib/Basic/Targets/Le64.h

clang/lib/Basic/Targets/Le64.cpp

clang/lib/Basic/Targets/OSTargets.h

clang/lib/Basic/Targets/PNaCl.h

clang/lib/Basic/Targets/PNaCl.cpp

clang/lib/CodeGen/TargetInfo.cpp

clang/lib/Driver/CMakeLists.txt

clang/lib/Driver/Driver.cpp

clang/lib/Driver/ToolChains/Arch/ARM.cpp

clang/lib/Driver/ToolChains/NaCl.h

clang/lib/Driver/ToolChains/NaCl.cpp

clang/lib/Frontend/InitHeaderSearch.cpp

clang/test/CodeGen/arm-aapcs-vfp.c

clang/test/CodeGen/le32-arguments.c

clang/test/CodeGen/le32-libcall-pow.c

clang/test/CodeGen/le32-regparm.c

clang/test/CodeGen/le32-vaarg.c

clang/test/CodeGen/long_double_fp128.cpp

clang/test/CodeGen/malign-double-x86-nacl.c

clang/test/CodeGen/pr18235.c

clang/test/CodeGen/target-data.c

clang/test/CodeGen/x86_64-arguments-nacl.c

clang/test/CodeGen/x86_64-longdouble.c

clang/test/CodeGenCXX/member-function-pointers.cpp

clang/test/CodeGenCXX/static-init-pnacl.cpp

clang/test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp

clang/test/Driver/arm-alignment.c

clang/test/Driver/le32-toolchain.c

clang/test/Driver/le32-unknown-nacl.cpp

clang/test/Driver/le64-unknown-unknown.cpp

clang/test/Driver/mipsel-nacl-defines.cpp

clang/test/Driver/nacl-direct.c

clang/test/Driver/unsupported-target-arch.c

clang/test/Driver/x86_64-nacl-defines.cpp

clang/test/Frontend/x86_64-nacl-types.cpp

clang/test/Headers/stdarg.cpp

llvm/include/llvm/ADT/Triple.h

llvm/lib/Support/Triple.cpp

llvm/lib/Target/ARM/ARMPredicates.td

llvm/lib/Target/ARM/ARMSubtarget.h

llvm/lib/Target/ARM/ARMSubtarget.cpp

llvm/lib/Target/ARM/ARMTargetMachine.cpp

llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp

llvm/lib/Target/Mips/MCTargetDesc/CMakeLists.txt

llvm/lib/Target/Mips/MCTargetDesc/MipsMCNaCl.h

llvm/lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp

llvm/lib/Target/Mips/MCTargetDesc/MipsNaClELFStreamer.cpp

llvm/lib/Target/Mips/MipsAsmPrinter.h

llvm/lib/Target/Mips/MipsAsmPrinter.cpp

llvm/lib/Target/Mips/MipsBranchExpansion.cpp

llvm/lib/Target/Mips/MipsCallingConv.td

llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp

llvm/lib/Target/Mips/MipsInstrFPU.td

llvm/lib/Target/Mips/MipsInstrInfo.td

llvm/lib/Target/Mips/MipsRegisterInfo.cpp

llvm/lib/Target/Mips/MipsSubtarget.h

llvm/lib/Target/X86/X86ExpandPseudo.cpp

llvm/lib/Target/X86/X86FrameLowering.cpp

llvm/lib/Target/X86/X86ISelDAGToDAG.cpp

llvm/lib/Target/X86/X86ISelLowering.cpp

llvm/lib/Target/X86/X86InstrInfo.td

llvm/lib/Target/X86/X86Subtarget.h

llvm/lib/Target/X86/X86TargetMachine.cpp

llvm/test/CodeGen/ARM/fast-isel-align.ll

llvm/test/CodeGen/ARM/struct_byval.ll

llvm/test/CodeGen/ARM/trap.ll

Delete NaCl support
Needs ReviewPublic
Actions

Revision Contents
Changeset List